Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Raise required PCRE version 36/52936/2
Stephan Großberndt [Wed, 24 May 2017 14:09:18 +0000 (16:09 +0200)]
[BUGFIX] Raise required PCRE version

Warn about an outdated PCRE version which is not compatible to PHP 7.0
in the Install Tool to make aware of possible PHP crashes in the TYPO3
backend.

Releases: master, 8.7
Resolves: #81335
Change-Id: I0db145146eb02bcab81a83195f375c87ae85f3e4
Reviewed-on: https://review.typo3.org/52936
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][BUGFIX] Exchange flag icons from SVG to PNG 19/53019/2
Marco Christian Krenn [Fri, 2 Jun 2017 09:27:01 +0000 (11:27 +0200)]
[FOLLOWUP][BUGFIX] Exchange flag icons from SVG to PNG

Remove flag SVG's from grunt and bower.

Resolves: #76291
Releases: master
Change-Id: I5698c5b23e74848a0330f080845d1d471ac37523
Reviewed-on: https://review.typo3.org/53019
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] SystemInformationMenu: Automatically refresh counter badge 01/53001/5
Johannes Goslar [Thu, 1 Jun 2017 16:22:31 +0000 (18:22 +0200)]
[TASK] SystemInformationMenu: Automatically refresh counter badge

Automatically reload the SystemInformation every 5 minutes.

Resolves: #68920
Releases: master, 8.7
Change-Id: Ie21d345d6bcbbae30f0fd77f084c22b1b2a0f6f2
Reviewed-on: https://review.typo3.org/53001
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Replace pagetree gifs with svg 12/53012/2
Markus Sommer [Thu, 1 Jun 2017 20:59:48 +0000 (22:59 +0200)]
[TASK] Replace pagetree gifs with svg

Change-Id: Ifd4c06ebb7bb670d8f4c17ffbe6b781ee4dfe4da
Resolves: #81412
Releases: master
Reviewed-on: https://review.typo3.org/53012
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Change order of preferred extension icons 02/53002/2
Georg Ringer [Thu, 1 Jun 2017 16:56:49 +0000 (18:56 +0200)]
[TASK] Change order of preferred extension icons

Prefer svg over png icons.

Resolves: #81396
Releases: master, 8.7
Change-Id: Ide44eb1f0c841c788516424fbff01bd319c79104
Reviewed-on: https://review.typo3.org/53002
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Exchange flag icons from SVG to PNG 11/53011/2
Marco Christian Krenn [Thu, 1 Jun 2017 20:53:05 +0000 (22:53 +0200)]
[BUGFIX] Exchange flag icons from SVG to PNG

All flag icons are exchanged to PNG to reduce file size and
fix viewport rendering problem in IE11.

Moved following flag icons from IconRegistry to registerFlags

* flag-an
* flag-cs
* flag-qc

Removed icon 'flag-fam', this was the famfamfam flag and has no use

Remove US states flags

Releases: master, 8.7
Resolves: #76291
Change-Id: I3d45b76901c2584680c8fcaa49aa0fed308405fc
Reviewed-on: https://review.typo3.org/53011
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid unnecessarily fetching file for processing 74/52874/2
Helmut Hummel [Sat, 20 May 2017 09:29:45 +0000 (11:29 +0200)]
[BUGFIX] Avoid unnecessarily fetching file for processing

Files that are not configured as images, won't be processed,
but are still unnecessarily fetched for processing.

To avoid this, we change the processing API, that fetching
only happens, if the file is then used by following code.

In addition we avoid showing a non descriptive thumb
in FileInfoElement, which is used when editing meta data of the file.

Resolves: #81279
Releases: master, 8.7, 7.6
Change-Id: Ie68aa02b1b6149ddb7fbda346ac312d3646e260c
Reviewed-on: https://review.typo3.org/52874
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years agoRevert "[BUGFIX] Avoid duplicates if ReferenceIndex is unable to finish" 21/52921/3
Christian Kuhn [Tue, 23 May 2017 20:39:31 +0000 (22:39 +0200)]
Revert "[BUGFIX] Avoid duplicates if ReferenceIndex is unable to finish"

This reverts commit c2a9726c4efb23d76c084e3319b29f74c14ccdce
from review https://review.typo3.org/#/c/50803/
due to regression in #81320

Change-Id: I496e13ce9efe743a5607e12b46a3fdc90e2f17c2
Resolves: #81320
Reverts: #78829
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52921
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Combine lint task for ci integration and correct code violations 07/53007/3
Benjamin Kott [Thu, 1 Jun 2017 19:05:19 +0000 (21:05 +0200)]
[TASK] Combine lint task for ci integration and correct code violations

Resolves: #81411
Releases: master, 8.7
Change-Id: I2b0f848ee6db870e78d8d102ef48ba2b417f91d7
Reviewed-on: https://review.typo3.org/53007
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix display of content area in modal windows in backend 98/52998/3
Jasmina Liessmann [Thu, 1 Jun 2017 16:17:40 +0000 (18:17 +0200)]
[BUGFIX] Fix display of content area in modal windows in backend

Add scroll possibility for modal body.

Resolves: #81387
Releases: master
Change-Id: I11d54473a6996bee534ea5663cc0de5a4552b66e
Reviewed-on: https://review.typo3.org/52998
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Remove duplicate ViewHelper from extensionmanager 03/52903/3
Claus Due [Mon, 22 May 2017 15:19:02 +0000 (17:19 +0200)]
[TASK] Remove duplicate ViewHelper from extensionmanager

JSON encoding ViewHelper from Fluid is fully compatible.
Also removes a number of unused arguments in the Fluid
template - note that removed ViewHelper declared it was
a tag based ViewHelper which supports additionalAttributes,
but did not render a tag, which is why all the attributes were
simply ignored and unused.

Change-Id: I8d59f5a5e8971aac2b63be86c0a51aaf56437306
Resolves: #81301
Releases: master
Reviewed-on: https://review.typo3.org/52903
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove deprecated f:switch and f:case 15/52915/5
Claus Due [Mon, 22 May 2017 19:02:48 +0000 (21:02 +0200)]
[!!!][TASK] Remove deprecated f:switch and f:case

Counterparts exist in Fluid engine.

Change-Id: I7fd0bc3b5569196858a8f5aa6967de2bf76385b1
Resolves: #81307
Resolves: #81106
Releases: master
Reviewed-on: https://review.typo3.org/52915
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Module menu clicks with slow connections opens standalone module 96/52996/2
Oliver Hader [Thu, 1 Jun 2017 13:57:50 +0000 (15:57 +0200)]
[BUGFIX] Module menu clicks with slow connections opens standalone module

If loading the backend using a slow internet connection an early click on
any item in the module menu on the left side causes the link to be opened
directly. The reason is, that JavaScript and thus click handlers are not
completely loaded yet. Thus, the regular DOM behavior of anchor tags is
executed.

To circumvent this behavior, href-arguments have to be disabled and the
module URL moved to a dedicated new data-attribute. As a result all items
that trigger a module change have to be adjusted as well.

Resolves: #80565
Releases: master, 8.7
Change-Id: I4687e6594eb539acc0d299dc8fc02e6820019911
Reviewed-on: https://review.typo3.org/52996
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove FormatViewHelper of EXT:cshmanual 26/52926/2
Georg Ringer [Wed, 24 May 2017 06:07:11 +0000 (08:07 +0200)]
[TASK] Remove FormatViewHelper of EXT:cshmanual

Instead of using a custom viewhelper in the EXT:cshmanual use the
ViewHelpers of fluid and chain those.

Resolves: #81324
Releases: master

Change-Id: I7b936b0d684333909c71f35bfe8156a51688646a
Reviewed-on: https://review.typo3.org/52926
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <service@enobe.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Require bower and have node build scripts 03/53003/2
Christian Kuhn [Thu, 1 Jun 2017 17:06:43 +0000 (19:06 +0200)]
[TASK] Require bower and have node build scripts

In preperation of a scss linter and typescript linter
we require bower as root dev dependency and register
some happy little scripts.

Change-Id: I425fd848a4012065fc7d955be0ae961f0f2ee8c4
Resolves: #81410
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53003
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid jumping of form fields on focus 97/52997/3
Jasmina Liessmann [Thu, 1 Jun 2017 14:11:43 +0000 (16:11 +0200)]
[BUGFIX] Avoid jumping of form fields on focus

Use absolute position for hints of remaining
characters to prevent form fields from being
moved down.

Resolves: #77069
Releases: master, 8.7
Change-Id: Iacba62543b036309e17828ab86f1986eb65f36a0
Reviewed-on: https://review.typo3.org/52997
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Add NPM package lock file 93/52993/4
Benjamin Kott [Thu, 1 Jun 2017 13:05:27 +0000 (15:05 +0200)]
[TASK] Add NPM package lock file

The file describes the exact tree that was generated, such that
subsequent installs are able to generate identical trees, regardless
of intermediate dependency updates.

https://docs.npmjs.com/files/package-lock.json

Resolves: #81406
Releases: master
Change-Id: I8c2f0d7a8d6a1d0cd7434d8e753a32d387b32f8f
Reviewed-on: https://review.typo3.org/52993
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] trigger Backend.doLayout() on window resize 91/52991/2
Johannes Goslar [Thu, 1 Jun 2017 12:26:47 +0000 (14:26 +0200)]
[BUGFIX] trigger Backend.doLayout() on window resize

Resolves: #78464
Releases: master, 8.7
Change-Id: I8d861df1e047213a355d145e05a9131386c7439f
Reviewed-on: https://review.typo3.org/52991
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[TASK] Functionals: Rename "@group mysql" to "@group not-postgres" 84/52984/3
Christian Kuhn [Wed, 31 May 2017 20:28:12 +0000 (22:28 +0200)]
[TASK] Functionals: Rename "@group mysql" to "@group not-postgres"

Functional tests annotated with "@group mysql" are currently ignored
if running tests on postgres via "--exclude-group mysql" argument.
With mssql we have some tests that run fine with mysql and postgres,
but not with mssql.
To improve handling, "@group mysql" annotation is renamed
to "@group not-postgres". Tests not available on postgres and mssql
will then later have a second annotation "@group not-mssql".
This way its easier to keep track which tests go red on which DBMS.

Change-Id: I2522b00352f1a7d61479588a22cdd9ea5d454ca3
Resolves: #81394
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52984
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Reduce cache gets in MarkerBasedTemplateService 74/52974/2
Claus Due [Tue, 30 May 2017 22:42:10 +0000 (00:42 +0200)]
[CLEANUP] Reduce cache gets in MarkerBasedTemplateService

Multiple calls to get() from cache can be condensed to one.

Change-Id: I1d949fcbc0c91afdbfb2d0e2bc3d9c1b4dfd475a
Resolves: #81385
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52974
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Refactor ext:impexp functional tests 80/52980/6
Christian Kuhn [Wed, 31 May 2017 15:18:15 +0000 (17:18 +0200)]
[TASK] Refactor ext:impexp functional tests

The ext:impexp functional tests are rather hard to read and
follow. The patch untangles them to make them better maintainable:

* Combine the two different import / export abstract classes into 1 class
* Don't inherit from AbstractDataHandlerActionTestCase anymore
* Give single test cases better file names and do not hide them in sub dirs
* Move all fixtures to Fixtures/ dir
* Use less helper methods to import and test things
* File paths are more straight and with less helper magic

Change-Id: Iae36771b94045f99444f394129cbcf183168b584
Resolves: #81393
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52980
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix typos in upgrade wizards of Install Tool 73/52973/2
Georg Ringer [Tue, 30 May 2017 19:57:46 +0000 (21:57 +0200)]
[TASK] Fix typos in upgrade wizards of Install Tool

Use the term "Upgrade wizard" instead of "Update wizard"
for the buttons of the single steps as the main menu item
is also called "Upgrade wizard".

Resolves: #81383
Releases: master, 8.7
Change-Id: I8047ae45101533a67fa4488af7040acc49af563f
Reviewed-on: https://review.typo3.org/52973
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[FOLLOWUP][TASK] Squeeze every bit of performance from CGL fixer 39/52939/2
Elmar Hinz [Wed, 24 May 2017 16:10:23 +0000 (18:10 +0200)]
[FOLLOWUP][TASK] Squeeze every bit of performance from CGL fixer

Support case sensitve file systems again.

Releases: master, 8.7
Resolves: #80814
Change-Id: I82274b328e9cfa75fb35360145d7a668d1270dc3
Reviewed-on: https://review.typo3.org/52939
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Ensure correct URL generation with http_build_query() 34/52934/4
Markus Klein [Wed, 24 May 2017 12:09:42 +0000 (14:09 +0200)]
[BUGFIX] Ensure correct URL generation with http_build_query()

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
This does not seem appropriate for URLs generated by TYPO3.

Use the optional parameters of http_build_query() to get the desired
functionality.

Releases: master, 8.7, 7.6
Resolves: #81366
Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf
Reviewed-on: https://review.typo3.org/52934
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Extbase: Pass parameter to real raw queries 63/52863/2
Daniel Goerz [Fri, 19 May 2017 12:02:56 +0000 (14:02 +0200)]
[BUGFIX] Extbase: Pass parameter to real raw queries

Resolves: #81272
Releases: master, 8.7
Change-Id: Iac3d486697b8c52fbace185ab1a55c514847db07
Reviewed-on: https://review.typo3.org/52863
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[CLEANUP] Remove unused parameter in workspaces hook implementation 24/52924/6
Georg Ringer [Wed, 24 May 2017 05:05:38 +0000 (07:05 +0200)]
[CLEANUP] Remove unused parameter in workspaces hook implementation

Remove the last parameter of method makeEditForm_accessCheck
in BackendUtilityHook as it is unused.

Resolves: #81290
Releases: master
Change-Id: I46a8d88273765762c6dbc8793b76e35b5a2b6653
Reviewed-on: https://review.typo3.org/52924
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Properly escape <> in Install Tool Check. 25/52925/3
Georg Ringer [Wed, 24 May 2017 05:47:12 +0000 (07:47 +0200)]
[BUGFIX] Properly escape <> in Install Tool Check.

Escape the < > in the check of the Windows Apache ThreadStackSize.

Resolves: #81134
Releases: master, 8.7
Change-Id: Iaa73e61438766f413ba7aeeaebac0fcbf41f1a99
Reviewed-on: https://review.typo3.org/52925
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Make encoding of parameters for cHash independent of PHP settings 22/52922/2
Markus Klein [Tue, 23 May 2017 20:51:35 +0000 (22:51 +0200)]
[BUGFIX] Make encoding of parameters for cHash independent of PHP settings

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
Our code relies on having a simple ampersand as this character.
If the PHP is set to a different configuration the code will fail.

This is fixed by enforcing the ampersand. Moreover we force RFC3986
encoding to ensure that decoding with rawurldecode() does the right
thing.

Releases: master, 8.7
Resolves: #81293
Change-Id: I321c7bba03ee597adc29a2f8429b8fc9ac3b709d
Reviewed-on: https://review.typo3.org/52922
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Carsten Falkenberg <office@limebox.de>
Tested-by: Carsten Falkenberg <office@limebox.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Explicit cast to string for VersionState object 16/52916/3
Christian Kuhn [Mon, 22 May 2017 21:12:31 +0000 (23:12 +0200)]
[BUGFIX] Explicit cast to string for VersionState object

Some DB drivers are picky on their arguments not being
objects. Add an explicit cast to string for a VersionState
object just before it's fed to a query as argument.

Change-Id: I81c8f9dded7068ad7bf817e034aa67a29f28290c
Resolves: #81309
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52916
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use correct constructor argument for TableDiff 72/52872/6
Stephan Großberndt [Fri, 19 May 2017 17:33:14 +0000 (19:33 +0200)]
[BUGFIX] Use correct constructor argument for TableDiff

Using the correct datatype "string" instead of a
\Doctrine\DBAL\Schema\Identifier as TableDiff->name prevents exceptions
if another SchemaEventSubscriber is registered.

Releases: master, 8.7
Resolves: #81276
Change-Id: If273a165604ff3149d8e5aba2c0b5ccbdef8102d
Reviewed-on: https://review.typo3.org/52872
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid DBAL\Exception on unknown data type in Install Tool 58/52858/2
Stephan Großberndt [Fri, 19 May 2017 06:35:30 +0000 (08:35 +0200)]
[BUGFIX] Avoid DBAL\Exception on unknown data type in Install Tool

Using $connection->getSchemaManager()->listTableNames() instead of
->listTables() in Install Tool prevents a DBAL\Exception as the table
details are not requested - which are not used anyway, so this is
faster too.

Releases: master, 8.7
Resolves: #81264
Change-Id: I35db1b6fa743ad4869bf2ba24717320f0f009995
Reviewed-on: https://review.typo3.org/52858
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Re-enable passing tests in SchemaMigratorTest 05/52905/2
Stephan Großberndt [Mon, 22 May 2017 16:00:00 +0000 (18:00 +0200)]
[TASK] Re-enable passing tests in SchemaMigratorTest

Re-enable the tests passing tests changeExistingColumn() and
installDoesNotAddIndexOnChangedColumn() in SchemaMigratorTest.

Resolves: #81302
Releases: master, 8.7
Change-Id: Idaf9d87c16d58864c6de3353ec68be46ae93024f
Reviewed-on: https://review.typo3.org/52905
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Squeeze every bit of performance from CGL fixer 17/52417/14
Claus Due [Tue, 11 Apr 2017 18:23:31 +0000 (20:23 +0200)]
[TASK] Squeeze every bit of performance from CGL fixer

This patch reduces the amount of time required to check
CGL to less than 3% of what it was before when xdebug
is loaded and the script is asked to check ~100 files.

Time before: 17m
Time after: 23.3s

Change-Id: I533ac3bfd03922362ccd6180caf6df2bfecd5bac
Releases: master, 8.7
Resolves: #80814
Reviewed-on: https://review.typo3.org/52417
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Extract datahandling framework to testing-framework 28/52728/9
Anja Leichsenring [Sat, 20 May 2017 16:36:34 +0000 (18:36 +0200)]
[TASK] Extract datahandling framework to testing-framework

Ext:core comes with a little testing framework for functional tests,
that is pretty useful for all kind of DataHandler related tests. Those
classes are better located in the testing-framework package to be
available.

Change-Id: I429e801b7318fda3a96acb4f5f63bb75050fb3e3
Resolves: #81154
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52728
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove usage of PATH_typo3conf from ConfigurationManager 79/52879/5
Anja Leichsenring [Sat, 20 May 2017 17:57:23 +0000 (19:57 +0200)]
[TASK] Remove usage of PATH_typo3conf from ConfigurationManager

Resolves: #81284
Releases: master, 8.7
Change-Id: I59730f5807d27bbc7eb232917763daa89f41315a
Reviewed-on: https://review.typo3.org/52879
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cache results in doesRecordExist_pageLookUp 16/51516/12
Thomas Hohn [Fri, 3 Feb 2017 09:00:02 +0000 (10:00 +0100)]
[TASK] Cache results in doesRecordExist_pageLookUp

Copying big sub-trees can benefit from caching the calls
to doesRecordExist_pageLookUp in a run-time cache since
there are a lot of identical calls to the database.

In addition the signature was adjusted - see also the already
merged issue #77391 which altered the signature.

Resolves: #79610
Releases: master
Change-Id: I2da164193f13759123d57c17985be46e7bd7667b
Reviewed-on: https://review.typo3.org/51516
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Tested-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Acceptance test installing TYPO3 on mysql 80/52880/5
Christian Kuhn [Sat, 20 May 2017 19:12:30 +0000 (21:12 +0200)]
[TASK] Acceptance test installing TYPO3 on mysql

A basic acceptance tests clicking through installer
using a mysql db connection, checking backend login
and "blank" site frontend output works.

Change-Id: Ie14d9c6fd8280d382b4041f98fa04ed00ef8386c
Resolves: #81285
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52880
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Claus Due <claus@phpmind.net>
2 years ago[BUGFIX] Embed parameters in SQL fragment create by getSelectQuery 72/52472/7
Christer Vindberg [Tue, 18 Apr 2017 10:28:07 +0000 (12:28 +0200)]
[BUGFIX] Embed parameters in SQL fragment create by getSelectQuery

Use quoted/escaped values embedded in the SQL fragment instead of named
parameters in QueryGenerator::getSelectQuery. The values of named
parameters get lost when the SQL fragment is returned and subsequently
used in a query.

Resolves: #80872
Releases: master, 8.7
Change-Id: If22bf24b75d2aa0efe36e587e38e7c590f3ec34a
Reviewed-on: https://review.typo3.org/52472
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Tested-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Minor CGL cleanup makes php-cs-fixer happy 89/52889/2
Christian Kuhn [Sun, 21 May 2017 12:43:04 +0000 (14:43 +0200)]
[TASK] Minor CGL cleanup makes php-cs-fixer happy

Change-Id: I4ce5bae6d200bbd7eba6679136375c71cfb6e268
Resolves: #81289
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52889
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update typo3/testing-framework to 1.0.6 85/52885/3
Christian Kuhn [Sat, 20 May 2017 23:23:05 +0000 (01:23 +0200)]
[TASK] Update typo3/testing-framework to 1.0.6

A couple of bug fixes and a setup for acceptance tests
of the installation procedure.

Change-Id: I97c211acb6f65a48ee90a45885887f8d16f800b9
Resolves: #81287
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52885
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Review comment and sig of addMountPointParameterToPage() 77/52877/4
Elmar Hinz [Sat, 20 May 2017 13:03:14 +0000 (15:03 +0200)]
[CLEANUP] Review comment and sig of addMountPointParameterToPage()

Releases: master, 8.7
Resolves: #81280
Change-Id: I8689827c9e33202e7659a39bb55e7a9bfd792aa2
Reviewed-on: https://review.typo3.org/52877
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup .gitignore components directory 81/52881/2
Christian Kuhn [Sat, 20 May 2017 19:19:48 +0000 (21:19 +0200)]
[TASK] Cleanup .gitignore components directory

The components/ directory has been a temporary directory in v8 phase,
does not exist anymore and can be removed from .gitignore.

Change-Id: I0f690c8fb38733dc8d168a7e43078dffc60450ea
Resolves: #81286
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52881
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make sure relative URL receives a proper host part for errorpage 59/52859/5
Anja Leichsenring [Fri, 19 May 2017 09:46:40 +0000 (11:46 +0200)]
[BUGFIX] Make sure relative URL receives a proper host part for errorpage

If the code given for PageNotFound_handling is a relative URL, the host
determination gets skipped, resulting in a redirect of the markup of
the page instead a proper redirect.

Change-Id: Id9c26cba813c212438368cee031673dc59db360b
Resolves: #81267
Relates: #81031
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52859
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prevent duplicated special char in backend breadcrumb 20/52820/3
Thomas Schur [Wed, 17 May 2017 11:09:03 +0000 (13:09 +0200)]
[BUGFIX] Prevent duplicated special char in backend breadcrumb

Prevent duplicated special char conversion of page title in
TYPO3 backend breadcrumb and fix title cropping

Resolves: #81242
Releases: master, 8.7
Change-Id: Id7710d8d8f79e20b20f43569558833d3d3f68f16
Reviewed-on: https://review.typo3.org/52820
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix typo in rst file 55/52855/2
Josef Glatz [Thu, 18 May 2017 14:31:50 +0000 (16:31 +0200)]
[BUGFIX] Fix typo in rst file

Related: #81171
Resolves: #81258
Releases: master
Change-Id: I2a07571bb45aefd5927498dee5604edb99ba271b
Reviewed-on: https://review.typo3.org/52855
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
2 years ago[BUGFIX] Remove doubled SQL query in PageRepository 54/52754/3
Benni Mack [Thu, 11 May 2017 06:22:13 +0000 (08:22 +0200)]
[BUGFIX] Remove doubled SQL query in PageRepository

The method PageRepository->checkWorkspaceAccess() does a SQL query to fetch
the workspace record, then hands it over to BE_USER->checkWorkspace which has the
same functionality - to fetch the full workspace record.

As this is redundant code, the PageRepository code can be simplified a lot by just leaving
the workspaceCache property.

Resolves: #81187
Releases: master, 8.7
Change-Id: Ia82febb2269084ea9101acfc36a1c9aa20950290
Reviewed-on: https://review.typo3.org/52754
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Page tree request in a workspaces times out 06/52506/4
Oliver Hader [Wed, 19 Apr 2017 19:24:38 +0000 (21:24 +0200)]
[BUGFIX] Page tree request in a workspaces times out

Tryign to determine workspace versions for a particular database table
results in a very long process execution time and possible timeout due
to the following reasons:

* in general a bug was introduced during the Doctrine DBAL migration
  which leads to misbehaviors in resolving versions for pages
* the SQL query implicitly creates an INNER JOIN with a huge result
  set that takes a long query time
* invalid types leading to possible flaws when using prepared statements

The SQL query has been split into using sub-queries now.

Change-Id: I4e4f69815bd73f0562f7ffbd6d411b417be7a18a
Resolves: #80898
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52506
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Streamline icons (order/style) in InlineRecordContainer 04/50104/13
Daniel Windloff [Fri, 7 Oct 2016 12:05:47 +0000 (14:05 +0200)]
[TASK] Streamline icons (order/style) in InlineRecordContainer

In order to be consistent, change the button order and styling
(according to the list module) in the InlineRecordContainer.

Resolves: #78174
Releases: master, 8.7
Change-Id: I2f4498f1e822785c2b26dab697ec4fe26aae5ef0
Reviewed-on: https://review.typo3.org/50104
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix wrong comment in TSFE for xhtmlDoctype property 00/52800/3
Jochen Greiner [Sat, 13 May 2017 17:11:52 +0000 (19:11 +0200)]
[BUGFIX] Fix wrong comment in TSFE for xhtmlDoctype property

The comment was wrong because the TSFE-Controller
takes care of setting this option internally.

Resolves: #81219
Releases: master, 8.7
Change-Id: If4af5b5aefa2758063e595e9e3e0b55892c7df27
Reviewed-on: https://review.typo3.org/52800
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Render prepended option tag always in first place 01/51501/4
Marcus Schwemer [Sun, 22 Jan 2017 21:24:39 +0000 (22:24 +0100)]
[BUGFIX] Render prepended option tag always in first place

Currently the prepend option is rendered together with the options
argument from select viewhelper. Using the option "optionsAfterContent"
renders also the prepend option after the children. The preprend
option is now rendered always in the first place.

Resolves: #79584
Releases: master, 8.7
Change-Id: Ia58c3b7d9b26d00cbda4d7ebce2a881a7129b331
Reviewed-on: https://review.typo3.org/51501
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Typo3DBQueryParser fails to wrap subselect in braces 17/52817/2
Thomas Maroschik [Wed, 17 May 2017 10:30:18 +0000 (12:30 +0200)]
[BUGFIX] Typo3DBQueryParser fails to wrap subselect in braces

When the Typo3DBQueryParser converts Extbase queries to Doctrine
queries, it creates subselects for certain relation constraints.
It fails to wrap the subselect in braces for has-many relations
which leads to sql exceptions.

This patch introduces braces around those subselects.

Change-Id: Ie9721a01bf166391770c7a1471272af0e15f9ccb
Fixes: #81240
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52817
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use different field for logging in EXT:scheduler 53/52553/4
Georg Ringer [Fri, 21 Apr 2017 20:37:36 +0000 (22:37 +0200)]
[BUGFIX] Use different field for logging in EXT:scheduler

The public method Scheduler::log accepts an optional $code as 3rd
parameter. Add this information to the parameter $details of
BackendUserAuthentication::writelog as otherwise it will be
casted to an integer and its information will be lost.

Resolves: #80592
Releases: master, 8.7
Change-Id: Iab5f1d285976e9e88795ebbe75faff9f689b1a8c
Reviewed-on: https://review.typo3.org/52553
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Drop dedicated edit view in EXT:tstemplate 96/52696/9
Andreas Fernandez [Wed, 3 May 2017 18:19:24 +0000 (20:19 +0200)]
[!!!][TASK] Drop dedicated edit view in EXT:tstemplate

Triggering ext:t3editor out-of-bound of FormEngine is pretty tricky and
blocks further development of t3editor. To streamline this, the
current implementation of t3editor within ext:tstemplate is revamped
and now uses FormEngine directly to edit "constants" and "setup" of
template records.
Some hooks are now obsolete and dropped along the way.

Resolves: #81171
Releases: master
Change-Id: Iab62a15828bfb82bc9f8ad11f705bb4529a38734
Reviewed-on: https://review.typo3.org/52696
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Update comment of PageRepository::getMountPointInfo() 42/52842/6
Elmar Hinz [Thu, 18 May 2017 10:48:05 +0000 (12:48 +0200)]
[CLEANUP] Update comment of PageRepository::getMountPointInfo()

Update the comment of the mehtod PageRepository::getMountPointInfo().
Add hint addressing to the usage of recursive mount points.

Change-Id: I095563cb940e25f8c5f004497d407733faf4cbcc
Releases: master, 8.7
Resolves: #81254
Reviewed-on: https://review.typo3.org/52842
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Bootstrap: Load TCA configuration on every request 53/52753/3
Benni Mack [Thu, 11 May 2017 06:18:22 +0000 (08:18 +0200)]
[TASK] Bootstrap: Load TCA configuration on every request

By moving Bootstrap::loadBaseTca() to the configure() call of the
TYPO3 Bootstrap, the global TCA variable is now populated very early
and it is obvious that this logic is then part of the actual system setup,
and does not need to be handled by any RequestHandler anymore.

Considering TCA is necessary for a TYPO3 environment to run,
this change might be very helpful.

Please note that the Install Tool application does not call
configure(), so this is not affected.

This also removes some issues related to Extbase
Command controllers in CLI handling.

Side effects:
- eID requests now have full TCA loaded as well at any time
- TCA is now loaded BEFORE entering any request handler check
- TCA is now loaded before e.g. BackendRouting initialization, and other Backend security checks

Easy to test the current behaviour:
- Clear all caches via install tool
- Call CLI command extbase:help which will result in a Warning / Exception

Resolves: #72222
Resolves: #81201
Releases: master
Change-Id: I31a0de0d0b039eb6180123678c61d3f26435dd63
Reviewed-on: https://review.typo3.org/52753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix typo in documentation intent-left > indent-left 32/52832/3
Fabian Thommen [Thu, 18 May 2017 09:14:25 +0000 (11:14 +0200)]
[TASK] Fix typo in documentation intent-left > indent-left

Releases: master, 8.7
Resolves: #81253
Change-Id: I9920ba02349d51925610c2bd04fd8c3ea668e3a6
Reviewed-on: https://review.typo3.org/52832
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Use EXEC_TIME for sys_log entry instead of time() 22/52822/2
Helmut Hummel [Wed, 17 May 2017 12:11:04 +0000 (14:11 +0200)]
[BUGFIX] Use EXEC_TIME for sys_log entry instead of time()

DataHandler does a lookup in sys_log table after it performed
its operations to find relevant error entries for the current request.

It determines relevance by looking for entries with the same
timestamp as $GLOBALS['EXEC_TIME'].

However error log entries are written using time(). Now if the
DataHandler operations take longer than one second, or the log entry
is written directly before a next tick, it can happen, that errors
will not be detected during the lookup process.

Since such errors are exposed to the user, it can happen that an operation
fails, but the users will not be notified.

Fix this by using $GLOBALS['EXEC_TIME'] when writing the log entries.

Resolves: #81244
Releases: master, 8.7, 7.6
Change-Id: Ic22b5f51ba4e10991be4a59ae28cb1f77a91c71e
Reviewed-on: https://review.typo3.org/52822
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Felix Rauch <rauch@skaiamail.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Correct doctrine expression for perms_clause 25/52825/3
Gerrit Mohrmann [Wed, 17 May 2017 12:41:23 +0000 (14:41 +0200)]
[BUGFIX] Correct doctrine expression for perms_clause

During the refactoring to doctrine in https://review.typo3.org/#/c/48574
a wrong expression was used. Use notIn() instead of in().

Resolves: #81246
Releases: master, 8.7
Change-Id: Icd1bf595fe3a75dc12d875a8a4c416c9b568c6c0
Reviewed-on: https://review.typo3.org/52825
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] EXT:beuser: Fix action icon (compare user) 60/52660/3
Daniel Windloff [Sat, 29 Apr 2017 10:17:13 +0000 (12:17 +0200)]
[BUGFIX] EXT:beuser: Fix action icon (compare user)

In EXT:beuser -> Backend User Listing there is the
possibility to add an user to the compare list.

If the user is already in the compare user list,
the user is removed from this list.

Resolves: #81079
Releases: master, 8.7
Change-Id: If0d6c132cdb2dbbd524890c3c90f92877240a284
Reviewed-on: https://review.typo3.org/52660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][BUGFIX] Fix parse time calculation 27/52827/2
Christian Kuhn [Wed, 17 May 2017 14:49:14 +0000 (16:49 +0200)]
[FOLLOWUP][BUGFIX] Fix parse time calculation

Unit test: Fix namespace, test file location and class inheritance.

Change-Id: Ida24b5adf747dc7c259a966fcddfdb7feb9f0951
Resolves: #80742
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52827
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix minor ux issues in EXT:recycler 62/52662/5
Daniel Windloff [Sat, 29 Apr 2017 12:51:13 +0000 (14:51 +0200)]
[BUGFIX] Fix minor ux issues in EXT:recycler

* move multi selector to the left
* separate action icons
* use info icon to open more information
* move mass action actions to the left
* use btn-default for actions
* add icons to the mass action buttons

Resolves: #81086
Releases: master, 8.7
Change-Id: Ib65343043a5c5c7ae77689d95502b389bb4acb0b
Reviewed-on: https://review.typo3.org/52662
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate "noWSOL" in PageRepository->getRecordRaw 03/52803/2
Benni Mack [Sun, 14 May 2017 12:26:25 +0000 (14:26 +0200)]
[TASK] Deprecate "noWSOL" in PageRepository->getRecordRaw

The method getRecordRaw has a very unspeakable method argument called
"noWSOL" which is only used internally within PageRepository.

Setting "noWSOL" to true only does a regular SQL query which can be implemented
directly in the according places, as the WSOL does not need to be known.

Resolves: #81218
Releases: master
Change-Id: I459ead0172f4ca1a6655599dd47aee2651a452bb
Reviewed-on: https://review.typo3.org/52803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add `controlsList` as known additional attribute 01/52801/4
Andreas Fernandez [Sun, 14 May 2017 09:12:39 +0000 (11:12 +0200)]
[BUGFIX] Add `controlsList` as known additional attribute

The HTML5 attribute `controlsList` is used in at least Google Chrome
to limit the control buttons. The AudioTagRenderer and VideoTagRenderer
classes are now aware of that attribute.

Resolves: #81222
Releases: master, 8.7, 7.6
Change-Id: I9a577ae077e7e7b55b9fed7852a5a61a5fd4061a
Reviewed-on: https://review.typo3.org/52801
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Unit test fails with recent PHP releases 16/52816/3
Christian Kuhn [Wed, 17 May 2017 10:24:18 +0000 (12:24 +0200)]
[TASK] Unit test fails with recent PHP releases

Recent PHP unit minor upgrades fixed a bug in DateTimeZone reflection
which is used as test object in our ObjectAccess reflection tests.
Make the test a bit less strict to cope with youngest and older
PHP versions at the same time.

Change-Id: Iaf2290872938f4c04a3307b0fe73c933ca7d69d8
Resolves: #81239
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/52816
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Introduce .typoscript file extension 96/50096/11
Andreas Allacher [Fri, 7 Oct 2016 05:37:33 +0000 (07:37 +0200)]
[FEATURE] Introduce .typoscript file extension

The new file extension .typoscript will be the default for TypoScript
configuration files and is the only recommended one from now on. This
effort is made to introduce a dedicated file extension for TypoScript
configuration files, and to avoid conflicts with already existing and
more spread file extensions like ".ts" for TypeScript or Video Transport
Stream Files.

Resolves: #78161
Resolves: #80689
Releases: master, 8.7
Change-Id: I44b41631f498e3ba39e0f1936329094a59859f4e
Reviewed-on: https://review.typo3.org/50096
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[!!!][TASK] Migrate EXT:context_help into EXT:backend 04/52804/7
Georg Ringer [Mon, 15 May 2017 07:01:37 +0000 (09:01 +0200)]
[!!!][TASK] Migrate EXT:context_help into EXT:backend

Merge the extension into EXT:backend as it only consists of
one AJAX controller - all other functionality related to context
help is already in EXT:backend and deeply connected to Backend-related
output code, so this is just a regular step.

Resolves: #81225
Releases: master
Change-Id: Ie5d577d62876f18414b61f5eefc9d9dd48d52430
Reviewed-on: https://review.typo3.org/52804
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Remove deprecated Fluid Viewhelper arguments 20/52520/6
Benni Mack [Wed, 17 May 2017 05:30:18 +0000 (07:30 +0200)]
[!!!][TASK] Remove deprecated Fluid Viewhelper arguments

Remove arguments within f:be.container and f:be.pageRenderer which
have been marked as deprecated before:

* f:be.container->enableClickMenu
* f:be.container->loadExtJs
* f:be.container->loadExtJsTheme
* f:be.container->enableExtJsDebug
* f:be.container->loadJQuery
* f:be.container->jQueryNamespace
* f:be.pageRenderer->loadExtJs
* f:be.pageRenderer->loadExtJsTheme
* f:be.pageRenderer->enableExtJsDebug
* f:be.pageRenderer->loadJQuery
* f:be.pageRenderer->jQueryNamespace

Resolves: #80707
Releases: master
Change-Id: If1f36b3fb197e108cb12351145e312a5aaca6447
Reviewed-on: https://review.typo3.org/52520
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix parse time calculation 27/52727/6
Susanne Moog [Fri, 5 May 2017 15:20:16 +0000 (17:20 +0200)]
[BUGFIX] Fix parse time calculation

Parse time calculation in RequestHandler was wrong,
additionally the same calculation is used in admin panel view.

The calculation was therefore added to the TimeTracker into a
common function and tested.

Change-Id: Ib935664e78a62deab7818426e2a853087c00b015
Resolves: #80742
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
2 years ago[!!!][TASK] Remove deprecated parameters in RecyclerUtility 42/52642/3
Wouter Wolters [Thu, 27 Apr 2017 15:48:19 +0000 (17:48 +0200)]
[!!!][TASK] Remove deprecated parameters in RecyclerUtility

EXT:recycler has some deprecated code that is now removed.

Releases: master
Resolves: #81237
Change-Id: I6db8ac155f2fe06a07528fbe17855c036f593e96
Reviewed-on: https://review.typo3.org/52642
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Unset current file in generic Content Object Renderer 16/49616/5
Benjamin Serfhos [Mon, 29 Aug 2016 08:38:22 +0000 (10:38 +0200)]
[BUGFIX] Unset current file in generic Content Object Renderer

When function is done, reset current file for further processing

Resolves: #77645
Releases: master, 8.7, 7.6
Change-Id: Ibae2e3221c51c8cb45f92b0bc7dbe395cc809605
Reviewed-on: https://review.typo3.org/49616
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Serfhos <serfhos@gmail.com>
Tested-by: Benjamin Serfhos <serfhos@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Introduce cache for readLLfile() 06/52406/10
Faton Haliti [Mon, 10 Apr 2017 13:43:24 +0000 (15:43 +0200)]
[TASK] Introduce cache for readLLfile()

Cache the result of readLLfile() gives a better performance
for cases where readLLfile() is called often.

Resolves: #80788
Releases: master, 8.7
Change-Id: I59913c7c5124ebe54c567a0a7c126a32fdd60284
Reviewed-on: https://review.typo3.org/52406
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Faton Haliti <fha@systime.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Move LanguageService to EXT:core 74/52774/6
Benni Mack [Thu, 11 May 2017 15:29:10 +0000 (17:29 +0200)]
[TASK] Move LanguageService to EXT:core

The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization"
namespace, where all other related XLF/XML factory, store and parser classes reside.

This is done in order to streamline the localization of core-relevant files, since this class will
also be used in frontend context.

EXT:lang now contains the backend module, as well as most XLF files.

Resolves: #81196
Releases: master
Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a
Reviewed-on: https://review.typo3.org/52774
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Let ElementInfo Template take care of proper title crop 92/52692/12
Mathias Brodala [Wed, 3 May 2017 07:27:21 +0000 (09:27 +0200)]
[BUGFIX] Let ElementInfo Template take care of proper title crop

If the title is too long, it gets cropped. Then, the link title must
contain the whole string in order to provide a proper tooltip.

Resolves: #81124
Releases: master, 8.7
Change-Id: I55b4784c431b4a495dc4089ab954eb3c7e1ca435
Reviewed-on: https://review.typo3.org/52692
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Throw explicit exception on missing link handler class 87/52787/2
Mathias Brodala [Fri, 12 May 2017 09:07:19 +0000 (11:07 +0200)]
[TASK] Throw explicit exception on missing link handler class

This adds the link handler identifier to the error message which
makes it easier to fix the missing class reference.

Resolves: #81205
Releases: master, 8.7, 7.6
Change-Id: I0ce610f7ec167704d5cbc5de20d43639c18e3fc1
Reviewed-on: https://review.typo3.org/52787
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Drop TSFE->dtdAllowsFrames 82/52782/3
Benni Mack [Thu, 11 May 2017 15:41:03 +0000 (17:41 +0200)]
[!!!][TASK] Drop TSFE->dtdAllowsFrames

The typolink calculation for checking of allowing frames has been encapsulated
in the TypoLinkBuilder extraction, so this public property is also obsolete.

Resolves: #81198
Releases: master
Change-Id: Ic2d0e64a754da983abfd6c9bcaa66884eaa9af35
Reviewed-on: https://review.typo3.org/52782
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Indexed Search should use FrontendRestrictionsContainer 68/52768/2
Benni Mack [Thu, 11 May 2017 12:19:11 +0000 (14:19 +0200)]
[BUGFIX] Indexed Search should use FrontendRestrictionsContainer

Indexed Search still uses enableFields for querying page records,
unlike most other places in the TYPO3 Core. This should be streamlined
because it was forgotten in the initial migration.

Resolves: #81194
Releases: master, 8.7
Change-Id: I0712f6811eefba6d2cb46ed06ff4b1d31ac7fa0b
Reviewed-on: https://review.typo3.org/52768
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Make MemcachedBackend a transient backend 15/52015/12
Claus Due [Sun, 12 Mar 2017 18:01:29 +0000 (19:01 +0100)]
[TASK] Make MemcachedBackend a transient backend

Allows passing non-string values to the backend, which
is perfectly allowed for this type of backend. The change
means that VariableFrontends used with this backend will
store non-string values without serializing, thus optimising
performance and transparency.

Key changes:

* Exceptions are no longer thrown when a non-string is passed
* Chunk-splitting does not happen on non-strings; entries
   exceeding the maximum bucket size get logged and ignored.
* Serializer decision is delegated to memcached configuration.

Change-Id: Ie11736be621a2dd27bfde60b82cd5f6b3a04d981
Resolves: #80246
Releases: master
Reviewed-on: https://review.typo3.org/52015
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Tested-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Do not throw exception on unavailable APC(u) cache backend 21/51521/6
tbringewatt [Fri, 3 Feb 2017 14:45:02 +0000 (15:45 +0100)]
[TASK] Do not throw exception on unavailable APC(u) cache backend

Log an error (keeping the website available) instead of throwing an
exception (and thus completely disabling it) if TYPO3 is configured to
use the APC / APCu cache backend but saving data to the cache failed.

Resolves: #79636
Releases: master, 8.7

Change-Id: I3adf829825017a3061e921d5d3ec74f20e18311e
Reviewed-on: https://review.typo3.org/51521
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove TSFE->getDocumentTemplate 83/52783/2
Benni Mack [Thu, 11 May 2017 15:43:56 +0000 (17:43 +0200)]
[TASK] Remove TSFE->getDocumentTemplate

Calling the protected method getDocumentTemplate() within TSFE
was added while cleaning up to be PHP-Storm-green in 2015, without
checking if this function is actually in use.

Resolves: #81199
Releases: master
Change-Id: I9a118c9cd20c9c00e836473d96132d8cb8898c7a
Reviewed-on: https://review.typo3.org/52783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Added missing workspace preview info 40/49740/8
Robert Vock [Fri, 2 Sep 2016 07:45:04 +0000 (09:45 +0200)]
[BUGFIX] Added missing workspace preview info

The workspace preview info got lost from TYPO3 4.5 to 4.6. This commit
readds the info and respects the same TypoScript config options.

Resolves: #77467
Releases: master, 8.7
Change-Id: Ie1696a5f86714c6ef9a61c10c41b0397abb95ab5
Reviewed-on: https://review.typo3.org/49740
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Linkvalidator: Scheduler task not working correctly 93/52593/7
Thorben Nissen [Tue, 25 Apr 2017 07:51:57 +0000 (09:51 +0200)]
[BUGFIX] Linkvalidator: Scheduler task not working correctly

The scheduler task does not check anything but just returns and does not
send an email. Furthermore it is not possible to enter email address
separated by newlines. Under some conditions it can happen, that result
numbers are added to the last result.

Explode pid list into array in LinkAnalyzer::init and use the array later.
Check if email adresses are comma or newline separated when validating
them when saving the task. Add file link statistic to default email
template. Reset the link statistics before the run to avoid adding it to
the last result numbers.

Resolves: #81000
Releases: master, 8.7
Change-Id: I05a98c9babcb889a83ce2f1ec7c0a2bee5dafede
Reviewed-on: https://review.typo3.org/52593
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Tested-by: Christer V <cvi@systime.dk>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] PageLayoutView - Allow to disable copy- / translate- buttons 45/52345/2
Andreas Fernandez [Mon, 3 Apr 2017 17:59:04 +0000 (19:59 +0200)]
[FEATURE] PageLayoutView - Allow to disable copy- / translate- buttons

The localization actions "Translate" and "Copy" are now toggleable by
PageTS and UserTS.

Resolves: #76910
Releases: master
Change-Id: Idee6cee57398b6ad7a24e6f84637e9ef3d33cfc5
Reviewed-on: https://review.typo3.org/52345
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Respect link target for individual pages in menu generation 35/52735/2
Benjamin Kott [Sun, 7 May 2017 17:33:30 +0000 (19:33 +0200)]
[BUGFIX] Respect link target for individual pages in menu generation

The link target configuration for a page was ignored during menu
generation. The link target is now respected and will override the
defined link target for the menu.

Resolves: #81162
Releases: master, 8.7
Change-Id: Iecf45456942c998e4084b95fe3003d2c5dc038db
Reviewed-on: https://review.typo3.org/52735
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[FOLLOWUP][BUGFIX] Convert ViewHelpers to static calling 78/52778/2
Claus Due [Thu, 11 May 2017 13:36:59 +0000 (15:36 +0200)]
[FOLLOWUP][BUGFIX] Convert ViewHelpers to static calling

Followup to prevent a variable reassignment which in
turn prevents overriding the controller, extension and
plugin name in f:uri.action.

Change-Id: I766e110555e03b36b93c777c63bbd629a42999fd
Resolves: #81143
Releases: master
Reviewed-on: https://review.typo3.org/52778
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Add UI blocker to prevent loading issues in FormEngine 13/52613/8
Frank Naegler [Wed, 26 Apr 2017 13:19:37 +0000 (15:19 +0200)]
[BUGFIX] Add UI blocker to prevent loading issues in FormEngine

Resolves: #80672
Releases: master, 8.7, 7.6
Change-Id: I52da6df109531f2a29acbb99b7871dc6227974b7
Reviewed-on: https://review.typo3.org/52613
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Convert ViewHelpers to static calling 07/52707/4
Claus Due [Fri, 5 May 2017 01:31:07 +0000 (03:31 +0200)]
[TASK] Convert ViewHelpers to static calling

Several ViewHelpers were not yet converted to use
the renderStatic method and CompileWith* traits
from Fluid. This patch converts those.

Change-Id: I17773d4014969c5ad5a3b87bffd34c14871a2958
Releases: master
Resolves: #81143
Reviewed-on: https://review.typo3.org/52707
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Set default root paths constants in Indexed Search 26/52526/3
Christian Toffolo [Thu, 20 Apr 2017 17:47:56 +0000 (19:47 +0200)]
[BUGFIX] Set default root paths constants in Indexed Search

Resolves: #80923
Releases: master, 8.7
Change-Id: Id291a086c6ce4717d5b934d80cd7a4101fb985af
Reviewed-on: https://review.typo3.org/52526
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix non-unique hash values in SysRefindexHashUpdater 98/52398/4
Morton Jonuschat [Sat, 8 Apr 2017 21:43:07 +0000 (14:43 -0700)]
[BUGFIX] Fix non-unique hash values in SysRefindexHashUpdater

The new hash calculation can result in non-unique hash values when
updating old hashes. This is due to the new algorithm ignoring
the sorting fields while it was taken into account in the old one.
When two rows in the database (using the old hash format) only
differ in the sorting field (and the derived hash) the new hash
will be identical for both rows.
Due to the hash value being the primary key which needs to be
unique this will result in errors during the update.

This change adds an SQL call to remove the offending rows from
the database before proceeding to update the hash values.
Statement has been validated on MySQL and PostgreSQL.

Change-Id: I1ec0f2369ae714f2e8d0190a5bf412151405687f
Resolves: #80763
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52398
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Replace outdated nowrap attribute 83/52683/10
Henrik Elsner [Tue, 2 May 2017 14:17:39 +0000 (16:17 +0200)]
[TASK] Replace outdated nowrap attribute

The outdated nowrap attribute for table tags
is replaced by a class addition, bringing
the functional stylings

Resolves: #81110
Releases: master, 8.7
Change-Id: Id0981b104be226dec4dc7c2c56b2919391823b31
Reviewed-on: https://review.typo3.org/52683
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Use renderType selectSingle for field t3_tables of sys_action 91/52691/2
Georg Ringer [Wed, 3 May 2017 03:48:50 +0000 (05:48 +0200)]
[BUGFIX] Use renderType selectSingle for field t3_tables of sys_action

The field t3_tables of sys_action must be rendered as a single
select field. This was also the behaviour before the regression
introduced with #69822.

Resolves: #81119
Releases: master, 8.7, 7.6
Change-Id: I2c885ea3494d7e2be22fad6df1b2a4791991551b
Reviewed-on: https://review.typo3.org/52691
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Cover getContentObject related methods by unit tests. 78/52378/15
Elmar Hinz [Thu, 6 Apr 2017 18:11:52 +0000 (20:11 +0200)]
[TASK] Cover getContentObject related methods by unit tests.

Cover getContentObject related methods of ContentObjectRenderer
by unit tests.

Resolves: #80737
Releases: master, 8.7, 7.6
Change-Id: Ida957cd18c35d10cfc41f954ffdc15e0a04c03a8
Reviewed-on: https://review.typo3.org/52378
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Add unit test for Typolink resolveTargetAttribute 05/52305/16
Elmar Hinz [Fri, 31 Mar 2017 19:49:21 +0000 (21:49 +0200)]
[TASK] Add unit test for Typolink resolveTargetAttribute

Add a unit test for AbstractTypolinkBuilder::resolveTargetAttribute.

Releases: master, 8.7
Resolves: #80618
Change-Id: I429900c036371be4f0bd57e75d841f9d0dfe7720
Reviewed-on: https://review.typo3.org/52305
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Use DBAL Restrictions for index_config queries 55/52755/3
Benni Mack [Thu, 11 May 2017 06:26:58 +0000 (08:26 +0200)]
[BUGFIX] Use DBAL Restrictions for index_config queries

The IndexSearch repository calls $TSFE->sys_page->enableFields
for queries on index_config which has very static information
(deleted/hidden) which the default restriction container handles.

Changing this code was simply forgotton to migrate to the
restriction container.

Resolves: #81188
Releases: master, 8.7
Change-Id: I159b4c2cf898e97b0e92fd2a57bcd30de0806146
Reviewed-on: https://review.typo3.org/52755
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make DataHandler multibyte-safe 52/52752/2
Benni Mack [Thu, 11 May 2017 04:51:01 +0000 (06:51 +0200)]
[BUGFIX] Make DataHandler multibyte-safe

There are still a few places left where multibyte string functions
are not used. Since 8.x the core delivers a mbstring polyfill
and can be used in various places.

Resolves: #19774
Releases: master, 8.7
Change-Id: I16f022b109749e9f547c177c511fee3bcc5d4b60
Reviewed-on: https://review.typo3.org/52752
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix path to Header partial in Textmedia and Textpic 65/52465/5
Olli [Sun, 16 Apr 2017 14:31:11 +0000 (16:31 +0200)]
[BUGFIX] Fix path to Header partial in Textmedia and Textpic

Fix path to call the existing partial Partials/Header/All instead of
Partials/Header.

Releases: master,8.7
Resolves: #80859
Change-Id: Ib4743acd3f3673fdfbe414cf4563c38e2f153055
Reviewed-on: https://review.typo3.org/52465
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[TASK] Move CSH files from context_help to correct places 80/52680/3
Georg Ringer [Tue, 2 May 2017 12:56:29 +0000 (14:56 +0200)]
[TASK] Move CSH files from context_help to correct places

Instead of having some CSH files in the ext "context_help"
it is better to move those to the correct places.

Resolves: #81107
Releases: master
Change-Id: I3a7e56130f889fc744243a1299fbeb78e6a255d5
Reviewed-on: https://review.typo3.org/52680
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Ensure extractDottedPathToLastElement() always returns a string 19/52519/8
Daniel Goerz [Thu, 20 Apr 2017 13:46:16 +0000 (15:46 +0200)]
[BUGFIX] Ensure extractDottedPathToLastElement() always returns a string

Resolves: #80919
Releases: master, 8.7
Change-Id: I3fddc6e83a117d25ec7abeb7d82130275321c2c7
Reviewed-on: https://review.typo3.org/52519
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] INCLUDE_TYPOSCRIPT condition use correct ConditionMatcher 14/52114/8
Andreas Allacher [Wed, 22 Mar 2017 07:25:35 +0000 (08:25 +0100)]
[BUGFIX] INCLUDE_TYPOSCRIPT condition use correct ConditionMatcher

In order to support all conditions correctly
whether one is in FE or BE the condition
has to be matched against the correct
ConditionMatcher instead of always
using the one for BE.

Releases: master, 8.7, 7.6
Resolves: #80385
Change-Id: Id5e216da40000b408f96822855d97799f254d0fb
Reviewed-on: https://review.typo3.org/52114
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] travis-ci: Drop JS unit tests 58/52758/3
Christian Kuhn [Thu, 11 May 2017 10:24:36 +0000 (12:24 +0200)]
[TASK] travis-ci: Drop JS unit tests

Drop the jasmine / karma based JS unit tests from travis. They're
becoming unstable and are executed as pre-merge tests anyway.
Supporting one executing platform that keeps an eye on
nodejs & friends should be enough.

Change-Id: Ie2134c08c50d9da33ff39bc1a0fe3f4a416e7b45
Resolves: #81192
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52758
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:scheduler:action icons and sorting 61/52661/2
Daniel Windloff [Sat, 29 Apr 2017 11:39:11 +0000 (13:39 +0200)]
[TASK] EXT:scheduler:action icons and sorting

In order to be consistent, add action icons
and sort multi action buttons according to the single action.

Resolves: #81080
Releases: master, 8.7
Change-Id: If987643eaea17ed98722b933fc8c57818e7a7a93
Reviewed-on: https://review.typo3.org/52661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>