Packages/TYPO3.CMS.git
5 years ago[FOLLOWUP] Remove remaining occurrences of JSImgCode 36/32736/2
Helmut Hummel [Fri, 12 Sep 2014 08:45:16 +0000 (10:45 +0200)]
[FOLLOWUP] Remove remaining occurrences of JSImgCode

Resolves: #60523
Releases: 6.3
Change-Id: I38d9379277b173ba03c0761576ca60569b2bc88a
Reviewed-on: http://review.typo3.org/32736
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] RootlineUtility wrongly handles group-type fields 93/29493/6
Francois Suter [Tue, 15 Apr 2014 19:48:16 +0000 (21:48 +0200)]
[BUGFIX] RootlineUtility wrongly handles group-type fields

\TYPO3\CMS\Core\Utility\RootlineUtility::enrichWithRelationFields()
tries to resolve relations to the current page record, including
fields with MM-relations. But it wrongly tests only for the
"foreign_table" property, whereas group-type fields will use the
"allowed" property.

This patch checks for "allowed" first and falls back on
"foreign_table". Furthermore a check is added to ensure the final
implode is indeed working on an array.

Resolves: #50396
Releases: 6.3, 6.2, 6.1
Change-Id: I43427061a5051298a25e45584aa995846ebb877c
Reviewed-on: http://review.typo3.org/29493
Reviewed-by: Jacob Rasmussen <jacob@omnius.dk>
Tested-by: Jacob Rasmussen <jacob@omnius.dk>
Reviewed-by: Mattias Nilsson <tollepjaer@gmail.com>
Tested-by: Mattias Nilsson <tollepjaer@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Followup to mod.SHARED.colPos_list fix 97/32697/5
Helmut Hummel [Wed, 10 Sep 2014 08:31:05 +0000 (10:31 +0200)]
[BUGFIX] Followup to mod.SHARED.colPos_list fix

The internal property activeColPosList is intermediately
set to an array and not converted to a comma separated list
any more, which breaks related code.

Resolves: #39967
Releases: 6.2, 6.3
Change-Id: I6f2e4710174ad5277f9de47c2d7b2cbb7a5ebb80
Reviewed-on: http://review.typo3.org/32697
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 years ago[BUGFIX] Followup to merge extra_page_cm_options into backend 98/32698/2
Wouter Wolters [Wed, 10 Sep 2014 08:40:49 +0000 (10:40 +0200)]
[BUGFIX] Followup to merge extra_page_cm_options into backend

Syntax error in line 298

Releases: 6.3
Resolves: #55136
Change-Id: I497e0e2b65b40a87ef1f8af205a0991b4dd92f74
Reviewed-on: http://review.typo3.org/32698
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Merge extra_page_cm_options into backend 65/32665/4
Georg Ringer [Tue, 9 Sep 2014 07:17:43 +0000 (09:17 +0200)]
[TASK] Merge extra_page_cm_options into backend

Move the lines of the hook of extra_page_cm_options into EXT:backend
to cleanup up the core.

Resolves: #55136
Releases: 6.3
Change-Id: I318888775f4ec02caec6b0cb35f1e461f748224d
Reviewed-on: http://review.typo3.org/32665
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] TS Parser: Remove resolving of resources and filenames 30/27130/7
Benjamin Mack [Mon, 8 Sep 2014 21:55:29 +0000 (23:55 +0200)]
[TASK] TS Parser: Remove resolving of resources and filenames

The functionality for using direct resources with TypoScript
templates was removed with TYPO3 CMS 6.1. However
the code still supports the resources, also the resolving
of the resources and files within tslib/media - a directory
which does not even exist anymore.
The patch removes all functionality in the core.

Resolves: #55442
Releases: 6.3
Change-Id: Idc3f4585a2ed59a5814ec9629c0a1f256da69b91
Reviewed-on: http://review.typo3.org/27130
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[TASK] Make file_edit.php dispatched 38/28238/10
Wouter Wolters [Mon, 10 Mar 2014 22:16:07 +0000 (23:16 +0100)]
[TASK] Make file_edit.php dispatched

Use dispatching for file_edit.php

Resolves: #56743
Releases: 6.3
Change-Id: Ib25745dd29642a83aa5700752c83cda8e11ea7fa
Reviewed-on: http://review.typo3.org/28238
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Add upgrade wizard for backend user setting startModule 92/32692/4
Wouter Wolters [Tue, 9 Sep 2014 17:13:19 +0000 (19:13 +0200)]
[BUGFIX] Add upgrade wizard for backend user setting startModule

In #60633 the rewrite of the module menu was done but can lead
to an error if the backend user startModule is set
to help_aboutmodules. Check all backend users and update the
setting if needed.

Resolves: #61485
Releases: 6.3
Change-Id: Ib6f21c4bd4d4315e76cc7d51bebf08c9fa01b924
Reviewed-on: http://review.typo3.org/32692
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[FEATURE] Base EXT: t3skin on twbs 79/32679/6
Felix Kopp [Tue, 9 Sep 2014 11:10:03 +0000 (13:10 +0200)]
[FEATURE] Base EXT: t3skin on twbs

Base TYPO3 CMS backend on twbs bootstrap. Brings bootstrap variables
adapted for TYPO3 CMS t3skin. There is no visual change.

This patch is the first step in a list of CSS refactorings.

Next steps:
Base more TYPO3 CMS backend widgets on twbs components.

Resolves: #61471
Releases: 6.3
Change-Id: I38df90a4925306a5aa8dd6ce5934ce5bd454a1db
Reviewed-on: http://review.typo3.org/32679
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[TASK] Move eID script to Resources/PHP folder 87/32687/2
Nicole Cordes [Tue, 9 Sep 2014 14:58:48 +0000 (16:58 +0200)]
[TASK] Move eID script to Resources/PHP folder

Resolves: #61478
Releases: 6.3
Change-Id: I81a8ae747e59649999c5372b51b8fc866a4dd4dd
Reviewed-on: http://review.typo3.org/32687
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Add more files to .gitignore 90/32690/3
Nicole Cordes [Tue, 9 Sep 2014 16:17:54 +0000 (18:17 +0200)]
[TASK] Add more files to .gitignore

composer.lock and everything below typo3conf/ should be excluded if
the core checkout is used as document root directly.

Resolves: #61483
Releases: 6.3, 6.2
Change-Id: I34e706c510c38d953a98f0f30789f87fc968ae52
Reviewed-on: http://review.typo3.org/32690
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[CLEANUP] Remove documentation folder from extbase 89/32689/2
Markus Klein [Tue, 9 Sep 2014 15:25:03 +0000 (17:25 +0200)]
[CLEANUP] Remove documentation folder from extbase

The present Documentation/README.txt refers to totally outdated
information and contains old links.

The new documentation can be found within the central Core documentation.

Resolves: #61480
Releases: master
Change-Id: I1bf43e0a244fc2e4d45aa5267af4411a5eb713d1
Reviewed-on: http://review.typo3.org/32689
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Use FE category collection for pages 64/32064/2
Francois Suter [Fri, 8 Aug 2014 13:10:43 +0000 (15:10 +0200)]
[BUGFIX] Use FE category collection for pages

Class CategoryMenuUtility which is used when rendering a list
of categorized pages calls on
\TYPO3\CMS\Core\Category\Collection\CategoryCollection
to collect the pages. This is wrong in a FE context as all
pages will be collected (hidden, deleted, workspace copies, etc.).
It must use
\TYPO3\CMS\Frontend\Category\Collection\CategoryCollection
instead.

Resolves: #59440
Releases: 6.2, 6.3
Change-Id: Ia8df04f5f615f3b6f09d2f67fbfadf69baca8f21
Reviewed-on: http://review.typo3.org/32064
Reviewed-by: Tomita Militaru <militarutomita@gmail.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Francois Suter <francois@typo3.org>
Tested-by: Francois Suter <francois@typo3.org>
5 years ago[FEATURE] Signal for IconUtility html tag manipulation 42/32542/7
Felix Kopp [Mon, 1 Sep 2014 09:10:02 +0000 (11:10 +0200)]
[FEATURE] Signal for IconUtility html tag manipulation

Registers a signal to EXT:Backend\Utility\IconUtility to manipulate
the generated html code for sprite icons.

Resolves: #61289
Releases: 6.3
Change-Id: Ie61e09b2033114b2258bf14eaaba9e068410bcfc
Reviewed-on: http://review.typo3.org/32542
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
5 years ago[TASK] Consolidate JSimgCode in TSFE into additionalJavaScript 58/31758/5
Benjamin Mack [Thu, 24 Jul 2014 13:29:00 +0000 (15:29 +0200)]
[TASK] Consolidate JSimgCode in TSFE into additionalJavaScript

In order to streamline the javascript variables in
frontend rendering the functionality for using
JSimagecode (used by GMENU) should add its
code to the generic $additionalJavaScript and
not the hardly used "public $JSImgCode".

Releases: 6.3
Resolves: #60523
Change-Id: Iec3b5623348ce448c1827e30a831acb3fb82a415
Reviewed-on: http://review.typo3.org/31758
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Cache missing class information only in productive context 85/32685/3
Nicole Cordes [Tue, 9 Sep 2014 13:18:27 +0000 (15:18 +0200)]
[BUGFIX] Cache missing class information only in productive context

To improve cache handling during development, missing class information
shouldn't be cached anymore. Otherwise each time a class was misspelled
and not found we have to clear the classes_cache.

Resolves: #61475
Releases: 6.3, 6.2
Change-Id: I7de24348e84bd89afd81164b90f776a996fcb8d9
Reviewed-on: http://review.typo3.org/32685
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Respect tablenames, fieldname when updating mm record 05/32505/7
Frans Saris [Fri, 29 Aug 2014 10:14:31 +0000 (12:14 +0200)]
[BUGFIX] Respect tablenames, fieldname when updating mm record

The Typo3DbBackend doesn't respect the columns tablenames
and fieldname when updating mm releations. As result wrong
relations are adjusted.

Resolves: #61268
Releases: 6.2, 6.3
Change-Id: Ica1c04fb54b2f152ccf0f9bd766091854f01721a
Reviewed-on: http://review.typo3.org/32505
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Add CLI option to set DB socket for functional tests 67/32667/3
Steffen Müller [Tue, 9 Sep 2014 08:52:53 +0000 (10:52 +0200)]
[TASK] Add CLI option to set DB socket for functional tests

An additional option "typo3DatabaseSocket" can be set
to configure a custom DB socket when running functional tests
from the commandline interface.

Resolves: #61465
Releases: 6.3, 6.2
Change-Id: If34526264bdc8b91c7c45785dde06a10fb606526
Reviewed-on: http://review.typo3.org/32667
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[CLEANUP] Cleanup backend toolbar item registration 68/32668/5
Helmut Hummel [Tue, 9 Sep 2014 08:44:26 +0000 (10:44 +0200)]
[CLEANUP] Cleanup backend toolbar item registration

* Remove side effects from class file
* Move registration script to Resources/PHP folder

Resolves: #61467
Releases: 6.3
Change-Id: I0786a1d2bddefac17780168acbd2e088c2e5690a
Reviewed-on: http://review.typo3.org/32668
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Adopt layout of element "table" 55/28455/3
Georg Ringer [Mon, 8 Sep 2014 16:23:47 +0000 (18:23 +0200)]
[TASK] Adopt layout of element "table"

The content element "table" is not configured as the other content
elements because the configuration of the TCA is overriden inside
EXT:css_styled_content again.
* Introduce the appearance tab
* Introduce the palettes for the tab access

Change-Id: I8f122ad9e13faac4d5126c421ebf966a555242cd
Resolves: #56972
Releases: 6.3
Reviewed-on: http://review.typo3.org/28455
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Remove warning if IE6 is used on backend login screen 83/31883/4
Wouter Wolters [Mon, 28 Jul 2014 13:44:27 +0000 (15:44 +0200)]
[TASK] Remove warning if IE6 is used on backend login screen

When IE6 is used a message is shown that IE6 is not supported.
IE6 support was already dropped since TYPO3 CMS 4.6 so we
now remove this warning.

Resolves: #60640
Releases: 6.3
Change-Id: Ib964fef63fcd987eef4cc04264fff0c7cc761d47
Reviewed-on: http://review.typo3.org/31883
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Remove unused property $be_user_Array 62/32662/2
Wouter Wolters [Mon, 8 Sep 2014 21:19:59 +0000 (23:19 +0200)]
[TASK] Remove unused property $be_user_Array

In InfoModuleController and VersionModuleController a property
$be_user_Array is defined but unused.

Resolves: #61461
Releases: 6.3
Change-Id: I32146421b211ee10c705e0b7079bb09b782e87d5
Reviewed-on: http://review.typo3.org/32662
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Remove unused stat_type funcMenu initialization 63/32663/2
Wouter Wolters [Mon, 8 Sep 2014 21:37:01 +0000 (23:37 +0200)]
[TASK] Remove unused stat_type funcMenu initialization

In PageInformationController there is unused code initialized.
The stat_type is unused and can be removed.

Resolves: #61462
Releases: 6.3
Change-Id: I61e59b8c10d32bd907ffd90d86aecabb39394c30
Reviewed-on: http://review.typo3.org/32663
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Streamline services in reports module 52/32652/6
Georg Ringer [Mon, 8 Sep 2014 17:20:48 +0000 (19:20 +0200)]
[TASK] Streamline services in reports module

* Use current table implementation
* Use lead class for 1st paragraph
* Use h3 for headlines of both check

Resolves: #61453
ReleaseS: 6.3
Change-Id: Ie3e00423949acfee5f8ccadb7f4e46b44660baf2
Reviewed-on: http://review.typo3.org/32652
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Allow multi-line module menu labels 58/29558/3
Benjamin Mack [Mon, 8 Sep 2014 21:40:22 +0000 (23:40 +0200)]
[TASK] Allow multi-line module menu labels

Labels in the module menu cannot be in multiple
lines. this is especially a problem when the labels
are translated.

The patch introduces a new class for each
submodule item label and adds the proper CSS.

Resolves: #57590
Releases: 6.3
Change-Id: I37b6331d41bd1e6e014bf79596ad928430441f7e
Reviewed-on: http://review.typo3.org/29558
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[FEATURE] Bring twbs & fontawesome via composer 56/32656/2
Felix Kopp [Mon, 8 Sep 2014 20:17:13 +0000 (22:17 +0200)]
[FEATURE] Bring twbs & fontawesome via composer

Brings Bootstrap 3.2 and FontAwesome 4.2 dependency for require-dev.

Resolves: #61454
Releases: 6.3
Change-Id: I07e9258eecdef509825c6122096ff2f1c5e7fca7
Reviewed-on: http://review.typo3.org/32656
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Check TBE_STYLES skins for being an array 45/32645/2
Georg Ringer [Mon, 8 Sep 2014 14:48:11 +0000 (16:48 +0200)]
[BUGFIX] Check TBE_STYLES skins for being an array

If no skinning extension is installed, an exception is thrown which
makes it impossible to use the system. Therefore the variable must
be checked.

Resolves: #61446
Releases: 6.3
Change-Id: Iefd603199d69d0609b662f3b89a5ea6fb479e50f
Reviewed-on: http://review.typo3.org/32645
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Rewrite Module Menu 76/31876/8
Benjamin Mack [Mon, 28 Jul 2014 06:33:47 +0000 (08:33 +0200)]
[TASK] Rewrite Module Menu

Currently rendering of the module menu of the backend left side is
quite complex. This is because there are several parts introduced
in recent TYPO3 versions, that have only substituted parts of the
existing code. So the "old" code was still in use. To give a better
understanding I will first introduce all the parts relevant to the
rendering of the module menu.

PHP side
 * The mother of all classes is ModuleLoader.php, originally made by
   Kasper, which takes TBE_MODULES and compiles a long list of all
   modules into an array. (ModuleLoader->load()). Currently this class
   is kept as is for the time being.
 * For 4.1/4.2, the ModuleMenuView was introduced, a wrapper class to
   access the data of ModuleLoader and also does some other stuff like
   saving the Open/Collapsed state of the modules via AJAX (note: this
   will be handled browser-internally via LocalStorage from now on, as
   it saves HTTP requests).
   It does one other thing: Rendering of the Logout Button.
   This is completely in the wrong place right now, as the Logout
   button isn't within the module menu frame anymore since 4.x,
   but on the top right area of the backend.
 * The BackendController class is responsible for adding all HTML and
   JS code code to the backend.php page so it can be rendered. It
   instantiates the ModuleMenuView class to call the LogoutButton
   function.
 * As one of the first steps of rewriting the module menu a couple of
   versions ago, there was a ModuleController, which was again a
   wrapper for ModuleLoader while putting everything together in a
   ModuleRepository, along with Module objects and a singleton object
   ModuleStorage. This new version allows for nesting of up to three
   levels (incl. modfuncs), along with clear objects instead of arrays.

JS side
 * The module menu isn't output with a single line of PHP code, as it
   is defined as a ExtJS storage which fetches the module menu
   asynchronously. The HTML code is built in a ExtJS template, which
   leads to the funny effect that the raw backend.php only zero HTML
   code output for the module menu.
   An extra AJAX request is fired to load up the module, which then is
   prepared and templated by ExtJS.

The changes:
 * The logout button rendering is now done in the BackendController
   and not in the ModuleMenuView class.
 * The menu is now outputted in the BackendController at the same
   time as backend.php by a standalone Fluid template. The menu is
   built by a simple call to the ModuleRepository which returns a
   ModuleStorage.
 * ModuleMenuView, ModuleMenuController are not needed anymore, and
   are deprecated.
 * The JS is rewritten so that it works as before. These parts are filled
   up with jQuery code.
 * The collapsed/open state of the main modules is now done via the
   local storage JS functionality of the browsers to avoid further
   unnecessary HTTP loading operations.

Resolves: #60633
Releases: 6.3
Change-Id: I5402c1345a2931340d7ec9ef1881877b39d1bfc3
Reviewed-on: http://review.typo3.org/31876
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
5 years ago[TASK] Improve deprecation message in show_rechis.php 59/32659/2
Wouter Wolters [Mon, 8 Sep 2014 20:52:41 +0000 (22:52 +0200)]
[TASK] Improve deprecation message in show_rechis.php

Use a more detailed message how to link to this script.

Resolves: #61458
Releases: 6.3, 6.2
Change-Id: Ifabac9033b72bea288b13a11d1e649f28b99f950
Reviewed-on: http://review.typo3.org/32659
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Remove unused property $fileProcessor 57/32657/2
Wouter Wolters [Mon, 8 Sep 2014 20:21:26 +0000 (22:21 +0200)]
[TASK] Remove unused property $fileProcessor

In PageFunctionsController a property $fileProcessor is
defined but unused.

Resolves: #61456
Releases: 6.3
Change-Id: I7f19c533ab3f906da414d184e6730d9eed836d49
Reviewed-on: http://review.typo3.org/32657
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] One func wizard installed shows "Select wizard" without selectbox 51/32651/3
Wouter Wolters [Mon, 8 Sep 2014 16:56:33 +0000 (18:56 +0200)]
[BUGFIX] One func wizard installed shows "Select wizard" without selectbox

With one func wizard installed the text "Select wizard" is shown
without a selectbox. Hide the text if no func menu is available.

Resolves: #61452
Releases: 6.3
Change-Id: Iafb24bc2dcbf9b09b13939d7a8c5217ce94b43f0
Reviewed-on: http://review.typo3.org/32651
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Sort and create page wizard cleanup 26/32626/6
Wouter Wolters [Sun, 7 Sep 2014 21:25:17 +0000 (23:25 +0200)]
[TASK] Sort and create page wizard cleanup

* Move ExtJs code to jQuery
* Remove unused method modMenu
* Use boolean values in functions if possible

Resolves: #61451
Releases: 6.3
Change-Id: Ibf00d23112ced8744dc356dcb11c1914deb3a91a
Reviewed-on: http://review.typo3.org/32626
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Replace usage of old logo 50/32650/2
Georg Ringer [Mon, 8 Sep 2014 16:16:45 +0000 (18:16 +0200)]
[TASK] Replace usage of old logo

The old logo is used in a screenshot of the logo and needs to be updated.

Resolves: #54185
Releases: 6.3
Change-Id: Iac7f6d06cbf77a75855e780fa5653efb58febaad
Reviewed-on: http://review.typo3.org/32650
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fix Unit Tests for DBAL SqlParser 49/32649/3
Markus Klein [Mon, 8 Sep 2014 16:16:35 +0000 (18:16 +0200)]
[BUGFIX] Fix Unit Tests for DBAL SqlParser

Resolves: #61449
Related: #55648
Releases: 6.3
Change-Id: I2aa05fa02626668b4d5c560a0f900d279256b52e
Reviewed-on: http://review.typo3.org/32649
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Upgrade ext:scheduler to a modern file structure 75/31875/10
Wouter Wolters [Sun, 27 Jul 2014 23:37:17 +0000 (01:37 +0200)]
[TASK] Upgrade ext:scheduler to a modern file structure

* Move images to Resources/Public/Images/
* Move language files to Resources/Private/Language/
* Migrate ExtJs to jQuery
* Move module template to Resources/Private/Template/
* Add strict comparison were possible

Resolves: #60630
Releases: 6.3
Change-Id: I7bae64263268562b158dccf9b9c8fa6d6726fe52
Reviewed-on: http://review.typo3.org/31875
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Line breaks in string in compile* methods of the SqlParser 18/27318/4
Stefano Kowalke [Tue, 4 Feb 2014 09:30:46 +0000 (10:30 +0100)]
[BUGFIX] Line breaks in string in compile* methods of the SqlParser

There are lines-breaks inside the string which produces
'SELECT * \n\t\t\t\tFROM table_name\n\t\t\t\tWHERE'
queries while compile the sql query back from the array.

This breaks the test for EXT:dbal because debugAndCompare()
function will die.

Releases: 6.3, 6.2
Resolves: #55648
Change-Id: Iab6ad451d30bb94494ebbd3cb3b69e661ee55c00
Reviewed-on: http://review.typo3.org/27318
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
5 years ago[TASK] Add unit tests for forceAbsoluteUrl() 74/31874/4
Markus Klein [Sun, 27 Jul 2014 23:00:41 +0000 (01:00 +0200)]
[TASK] Add unit tests for forceAbsoluteUrl()

ContentObjectRenderer::forceAbsoluteUrl() is not covered by unit tests
at all.
Add unit tests and improve mocking in other existing tests.

Resolves: #60629
Releases: 6.3, 6.2
Change-Id: Ie3c03b0cff2118bf7ef38ca03135f2a0a6f120cd
Reviewed-on: http://review.typo3.org/31874
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Overriding TCA results in Exception 65/31965/2
Stefan Froemken [Mon, 4 Aug 2014 08:15:24 +0000 (10:15 +0200)]
[BUGFIX] Overriding TCA results in Exception

This problem only occours when using "tree" as
display mode for TCA-type "select".
FlexForm-API brings a special configuration to add,
edit and remove items from a selectbox, but in
case of a select-tree it does not make sense. A
completely different API was called to render this tree.
This patch prevents modifying the select-tree.

Releases: 6.3, 6.2
Resolves: #54490
Change-Id: I3ad3c5c608d7968ba90117aa048014b00cfd44af
Reviewed-on: http://review.typo3.org/31965
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christoph Buchli <cbuchli@snowflake.ch>
Tested-by: Christoph Buchli <cbuchli@snowflake.ch>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Tested-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[!!!][TASK] Deprecate all client related condition matchers 20/31820/4
Sascha Egerer [Fri, 25 Jul 2014 16:45:03 +0000 (18:45 +0200)]
[!!!][TASK] Deprecate all client related condition matchers

Conditions that depend on client details are unlovely for a number
of reasons:

* Per condition or permutation of conditions that matches, the frontend
  creates a different cache entry. This can lead to a very high number
  of cache entrys per page
* Most usual conditions for specific browsers can nowadays turned into
  conditional CSS includes
* Conditions based on browser or clients on server side are
  bad practice.
* If conditions for specific clients or devices are still needed, they
  should be done with a userFunc condition and a project like WURFL
  that keep the device information more recent than the current core
  code like matching AMIGA
* Setups like reverse proxies give additional headaches with these
  types of conditions
* All client related condition types are deprecated with this patch.

Resolves: #60574
Releases: 6.3
Change-Id: Ib9e78748e87a2f7e04fa1b606415ad1d8d302374
Reviewed-on: http://review.typo3.org/31820
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[TASK] Allow line breaks in ext_conf_template description 33/32633/2
Georg Ringer [Mon, 8 Sep 2014 09:36:01 +0000 (11:36 +0200)]
[TASK] Allow line breaks in ext_conf_template description

The description of configuration in the EM should allow
line breaks.

Resolves: #61323
Releases: 6.3
Change-Id: I7a1020e72d6385ba30b933ddde555092f5d2767f
Reviewed-on: http://review.typo3.org/32633
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Add file existence check before processing it 04/32604/4
Frank Nägler [Fri, 5 Sep 2014 14:16:03 +0000 (16:16 +0200)]
[BUGFIX] Add file existence check before processing it

This patch adds a check if a file exists before processing it.
If the file does not exist, all file functions will generate a warning.

Resolves: #61300
Releases: 6.3, 6.2
Change-Id: Ie829ec0ade8357b16f8a550d5f137593900720b9
Reviewed-on: http://review.typo3.org/32604
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[CLEANUP] ImportExport code needs some love 24/32324/4
Markus Klein [Fri, 22 Aug 2014 15:46:10 +0000 (17:46 +0200)]
[CLEANUP] ImportExport code needs some love

* Fix undefined variables
* Add missing return values
* Reduce indentation level by using guards
* Optimize readability
* CGL compliance

No functional changes.

Resolves: #61152
Releases: 6.3
Change-Id: Ifa2ed030d5fd721ef3ea2c4ef3a819b2d1f8762b
Reviewed-on: http://review.typo3.org/32324
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] RTE styling does not fit to TCEforms styling 67/28767/5
Benjamin Mack [Sun, 17 Aug 2014 20:43:10 +0000 (22:43 +0200)]
[BUGFIX] RTE styling does not fit to TCEforms styling

The toolbar on top still has old background color and border.
Removing these options makes the toolbar better
natively integrated into the rest of the CMS.

Resolves: #57292
Releases: 6.3, 6.2
Change-Id: I51ed27bff09e6b0479aa0673c65497e08b52540c
Reviewed-on: http://review.typo3.org/28767
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix clear_cache for XCache < 3.0 41/32441/2
Alexander Opitz [Wed, 27 Aug 2014 16:03:37 +0000 (18:03 +0200)]
[BUGFIX] Fix clear_cache for XCache < 3.0

The XCache API changed with version 3.0. Ubuntu 12.04 uses XCache
version 1.3.2 so we need to support the old API.

Resolves: #61175
Releases: 6.3, 6.2
Change-Id: I76e975222747c965c5ef6e062231209d398a1c15
Reviewed-on: http://review.typo3.org/32441
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[FOLLOWUP] Typo in wizard's label 35/32635/2
Xavier Perseguers [Mon, 8 Sep 2014 09:56:19 +0000 (11:56 +0200)]
[FOLLOWUP] Typo in wizard's label

Relates: #34298
Releases: 6.3
Change-Id: I28a13bd05f027cca08238b47d2463cb54692edfc
Reviewed-on: http://review.typo3.org/32635
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
5 years ago[TASK] Rewrite Backend Login JS to use jQuery 26/31826/6
Benjamin Mack [Wed, 27 Aug 2014 09:31:06 +0000 (11:31 +0200)]
[TASK] Rewrite Backend Login JS to use jQuery

The backend login process uses various
JavaScript parts.

1) Some basic redirects on pure JavaScript
that is inline in the LoginController.

2) A flat and hardcoded JS file in the
login.html template which actually
uses ExtJS and Prototype for various
cookie checks and usability checks.

3) RSA Authentication with Backend Login
for doing an AJAX call. This is done in
ExtJS.

All of the parts above are rewritten
using the proper API calls based on
jQuery.

Resolves: #60576
Releases: 6.3
Change-Id: Ie64c4736c79327b816c39da5bba533bcc65cee45
Reviewed-on: http://review.typo3.org/31826
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
5 years ago[TASK] Add indexed search icon to plugin wizard 21/9221/12
Kay Strobach [Sun, 26 Feb 2012 20:03:25 +0000 (21:03 +0100)]
[TASK] Add indexed search icon to plugin wizard

Adds a small icon to the plugin wizard to avoid the hacky 2 click access.
The icon is added to the tab "Plug-Ins".

Change-Id: Ib0b9705acaf69c0c49de660174c536caedda9292
Resolves: #34298
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/9221
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
5 years ago[BUGFIX] Remove PHP warnings when no icon is found in FormEngine 16/32616/2
Benjamin Mack [Sun, 7 Sep 2014 15:24:28 +0000 (17:24 +0200)]
[BUGFIX] Remove PHP warnings when no icon is found in FormEngine

If running in development mode and an icon
in FormEngine is not found, TYPO3 shows
the PHP E_WARNING of getimagesize() in a flash message.

The check should therefore be done in a cleaner way,
without the @ symbol.

Releases: 6.3, 6.2
Resolves: #61394
Change-Id: I546faee95bf304e135709c3e1c95292f48daf3d7
Reviewed-on: http://review.typo3.org/32616
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Travis-ci: Disable apc in PHP 5.4 23/32623/2
Christian Kuhn [Sun, 7 Sep 2014 19:43:24 +0000 (21:43 +0200)]
[TASK] Travis-ci: Disable apc in PHP 5.4

APC for travis-ci on cli was disabled for PHP 5.3 already because of
instability. This patch kicks out APC for PHP 5.4 as well after
recent failed travis runs in this area.

Releases: master, 6.2
Change-Id: I1182a0fcfc5f94f7f778c9f0fde5f5d8672b17ee
Reviewed-on: http://review.typo3.org/32623
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Move backend module icons to respective location 11/32511/3
Felix Kopp [Fri, 29 Aug 2014 11:59:18 +0000 (13:59 +0200)]
[TASK] Move backend module icons to respective location

In TYPO3 CMS world each extension contains multiple icons:

+ "extension icons" (ext_icon.gif) to identify the whole extension (EM/TER)
+ "module icon" as Start button per backend module (module menu)
+ "record icons" in recordlist as clickmenu link
+ "action icons" like save, close or info (toolbar)

Currently all icons look the same in the backend (16x16 pixels, same theme).
Also many icon files are used multiple ways (e.g. ext_icon.gif as module icon).

In order to be able to differentiate icons better by their primary function
this patch introduces a common folder as defined location for backend
module icon files and demontrastes a naming schema "module-name.xxx".

Also this patch reduces cohesion and coupling of backend extensions since
extensions now bring their own icons in a predictable fashion.

This supports alternative backends that do not rely on t3skin at all.

Resolves: #61200
Releases: 6.3
Change-Id: I035b7777f0c59546ec641dbb59165a98fd887d44
Reviewed-on: http://review.typo3.org/32511
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Use SpriteIcon for Add icon in Scheduler 17/32617/3
Felix Kopp [Sun, 7 Sep 2014 17:40:06 +0000 (19:40 +0200)]
[TASK] Use SpriteIcon for Add icon in Scheduler

Resolves: #61395
Releases: 6.2, 6.3
Change-Id: If77a7b9163ef23d291ca6106c453da059fe5ff21
Reviewed-on: http://review.typo3.org/32617
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fix loading of registry entries for namespace 08/32608/8
Frank Nägler [Fri, 5 Sep 2014 19:01:24 +0000 (21:01 +0200)]
[BUGFIX] Fix loading of registry entries for namespace

When calling get(), all entries for the given namespace are loaded only
if no value for this namespace has been set() before in the same run.

This patch fix this by tracking the loading of namespaces and check the
state before set() or get() is processed. In case the namespace was not
loaded before, the loadEntriesByNamespace() is called to prevent
overwrite of values.

Resolves: #53182
Releases: 6.3, 6.2
Change-Id: Ib09e5892e35cef998413d2f0d8039ed49a7e7226
Reviewed-on: http://review.typo3.org/32608
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Remove the closing PHP tag 14/32614/2
Wouter Wolters [Sun, 7 Sep 2014 13:50:04 +0000 (15:50 +0200)]
[TASK] Remove the closing PHP tag

During the last year some closing PHP tags are added again.
Remove the new added closing tags.

Resolves: #61393
Releases: 6.3
Change-Id: I40612b7ae10f3b0341bf46a894d193dbd732a70b
Reviewed-on: http://review.typo3.org/32614
Reviewed-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] colPos_list sets access to edit areas 83/31783/7
Jigal van Hemert [Thu, 24 Jul 2014 23:18:52 +0000 (01:18 +0200)]
[BUGFIX] colPos_list sets access to edit areas

The property mod.SHARED.colPos_list used to determine which columns
were visible in the Page module. With backend layouts it will only
determine which edit areas in the backend layout are accessible for
editing.

Resolves: #39967
Releases: 6.3, 6.2
Change-Id: Iba65ce84adf025802d1b0ebda00dff4d6299a06a
Reviewed-on: http://review.typo3.org/31783
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Marcin Sągol <marcin@soee.pl>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 years ago[TASK] Additional Documentation for #61351 12/32612/2
Anja Leichsenring [Sat, 6 Sep 2014 18:48:46 +0000 (20:48 +0200)]
[TASK] Additional Documentation for #61351

Add documentation for changelog for merged feature
'Add generic data-* attribute' for Fluid ViewHelpers.

Change-Id: Idfa80355b23d98ab6d9bf6b4ec3bed74b3365a7c
Resolves: #61389
Related: #61351
Releases: 6.3
Reviewed-on: http://review.typo3.org/32612
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Remove class.tx_cms_layout.php from EXT:cms/layout 59/32459/2
Wouter Wolters [Wed, 27 Aug 2014 19:21:42 +0000 (21:21 +0200)]
[TASK] Remove class.tx_cms_layout.php from EXT:cms/layout

Class in unused and marked for removal in TYPO3 CMS 6.2

Resolves: #61232
Related: #61218
Releases: 6.3
Change-Id: I720020e5d36045f2cba3535b9bbb043c34f33715
Reviewed-on: http://review.typo3.org/32459
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[FEATURE] Add generic data-* attribute 90/32590/3
Frank Nägler [Thu, 4 Sep 2014 21:18:03 +0000 (23:18 +0200)]
[FEATURE] Add generic data-* attribute

All elements in HTML5 can have any number of data-* attributes.
This additional array attribute on tag bases viewhelpers makes
it easier to add several data-* attributes to them:
  <f:form.textfield data="{foo: 'bar', baz: 'foos'}" />

Will render:
  <input data-foo="bar" data-baz="foos" ...

This is a backport from TYPO3.Fluid

Resolves: #61351
Related: #35748
Releases: 6.3
Change-Id: I3a6483e3293a7e18a3ee7fb5b04bf28bdb19d63d
Reviewed-on: http://review.typo3.org/32590
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Martin Sonnenholzer <martin.sonnenholzer@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] indexed_search: in some cases indexing does not work 55/32355/4
Samir Rachidi [Mon, 25 Aug 2014 15:59:09 +0000 (17:59 +0200)]
[BUGFIX] indexed_search: in some cases indexing does not work

In some cases $pObj->register['SYS_LASTCHANGED'] is NULL and therefore
a MySQL error occurs during indexing a page. So, in these cases,
we need to set the 'mtime' value by getting it from the page and we
always want to prevent a NULL-value getting inserted into the DB.

Resolves: #61135
Releases: 6.1, 6.2, 6.3
Change-Id: Idb78af3aa23350db4bd43f58638541e6b3ad3ae3
Reviewed-on: http://review.typo3.org/32355
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Make TCA property "exclusiveKeys" work with single key 91/32591/3
Roland Waldner [Thu, 4 Sep 2014 21:32:46 +0000 (23:32 +0200)]
[BUGFIX] Make TCA property "exclusiveKeys" work with single key

It is necessary that "exclusiveValues" is a string in the JavaScript
method FormEngine.setSelectOptionFromExternalSource() because
in JavaScript strings (but not numbers) have a method match() which
is used in FormEngine.setSelectOptionFromExternalSource().

"exclusiveValues" representing a single key (e.g. -1) are of type
"Number" - in this case an JavaScript error is thrown when the
script calls match() on it.

This commit ensures that "exclusiveValues" is always casted to
String.

Resolves: #61276
Releases: 6.3, 6.2
Change-Id: I049a5e6d11b3b27be901baa1e00429ab200b9a04
Reviewed-on: http://review.typo3.org/32591
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] where statement in typoscript select with stdWrap 96/32296/4
Kilian Hann [Thu, 21 Aug 2014 11:37:27 +0000 (13:37 +0200)]
[BUGFIX] where statement in typoscript select with stdWrap

The 'where' part of the statement now takes stdWrap properties
into account.

Resolves: #61117
Releases: 6.3, 6.2
Change-Id: Id1b2fe88a1cc72ca12acdb6628ed4b713e121798
Reviewed-on: http://review.typo3.org/32296
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Allow integers to be converted to objects 43/32543/2
Helmut Hummel [Mon, 1 Sep 2014 09:43:40 +0000 (11:43 +0200)]
[BUGFIX] Allow integers to be converted to objects

In TYPO3 CMS the identity of objects/ records are
integers (uids). Because of that, the persistent object
type converter should be able to convert integers to
objects, not only strings.

Releases: 6.2, 6.3
Resolves: #61292
Change-Id: I0b69295ae7adfdbe49cf19056614b984f34290c6
Reviewed-on: http://review.typo3.org/32543
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Migrate Taskcenter JavaScript to jQuery 61/32561/5
Wouter Wolters [Tue, 2 Sep 2014 18:29:45 +0000 (20:29 +0200)]
[TASK] Migrate Taskcenter JavaScript to jQuery

Move all JavaScript code to a RequireJS module based
on jQuery.

Resolves: #61322
Releases: 6.3
Change-Id: I8558a4952f22410337011991f304fbec6bb9cb84
Reviewed-on: http://review.typo3.org/32561
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Improve linkvalidator scheduler task usablity 83/32383/2
Alexander Stehlik [Tue, 26 Aug 2014 12:27:03 +0000 (14:27 +0200)]
[TASK] Improve linkvalidator scheduler task usablity

The getAdditionalInformation() method is implemented in the
linkvalidator scheduler task to show more information about
the task in the scheduler Backend module.

Resolves: #61198
Releases: 6.3
Change-Id: Iebb43923b73ff4ecebab4a6747655596be859604
Reviewed-on: http://review.typo3.org/32383
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Cleanup error handling code and settings description 64/32464/2
Markus Klein [Wed, 27 Aug 2014 22:21:55 +0000 (00:21 +0200)]
[TASK] Cleanup error handling code and settings description

The error handling code for PHP errors needs some cleanup.
So does the description of the related settings in the Install Tool.

Resolves: #61235
Releases: 6.3, 6.2
Change-Id: Ibd95fcdaa6a50a870035037a2332b95d2c5e1266
Reviewed-on: http://review.typo3.org/32464
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Viktor Livakivskyi <invisible.kinder@gmail.com>
Tested-by: Viktor Livakivskyi <invisible.kinder@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Remove class.tslib_pagegen.php from EXT:cms/tslib 58/32458/4
Wouter Wolters [Wed, 27 Aug 2014 19:13:57 +0000 (21:13 +0200)]
[TASK] Remove class.tslib_pagegen.php from EXT:cms/tslib

Class is unused and contains code that is deprecated and
marked for removal in TYPO3 CMS 6.3

Resolves: #61231
Releases: 6.3
Change-Id: Ia0ec7aa95d54b0372edc340a8986a1d15c43d3e5
Reviewed-on: http://review.typo3.org/32458
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[!!!][BUGFIX] Avoid to call stdWrap twice 66/32466/6
Markus Klein [Thu, 28 Aug 2014 00:10:55 +0000 (02:10 +0200)]
[!!!][BUGFIX] Avoid to call stdWrap twice

Using the recursive stdWrap will work on the stdWrap twice, although the
output is created only once.

Fix this by preventing the recursive call to stdWrap() if the
current function name is "stdWrap" as this will trigger a call to
stdWrap_stdWrap() later on anyway.

This will change rendering if LOAD_REGISTER or something similar
is used in a recursive stdWrap context.

Resolves: #60135
Releases: 6.3
Change-Id: I728f637b4e34f26b9cf6951f04667c8195638b3d
Reviewed-on: http://review.typo3.org/32466
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Remove tx_cms_webinfo and tx_cms_webinfo_lang 09/32409/3
Wouter Wolters [Tue, 26 Aug 2014 21:05:45 +0000 (23:05 +0200)]
[TASK] Remove tx_cms_webinfo and tx_cms_webinfo_lang

Remove tx_cms_webinfo and tx_cms_webinfo_lang and use
their namespaced variant for registration into web_info module.

Resolves: #61218
Releases: 6.3
Change-Id: I66c25241197d0b3898aee3e126f0b5b212e38a45
Reviewed-on: http://review.typo3.org/32409
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Unify EXT: beuser html table semantics (t3-table) 04/32504/4
Felix Kopp [Fri, 29 Aug 2014 10:07:30 +0000 (12:07 +0200)]
[TASK] Unify EXT: beuser html table semantics (t3-table)

Bring common html structure for EXT: beuser table. The other
table (above in code) has already been changed before.

Resolves: #61267
Releases: 6.3
Change-Id: I88f688ed421dcf8b2984fe3a1e0204b3ed6e19cf
Reviewed-on: http://review.typo3.org/32504
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Let Web-View respect TCEMAIN.previewDomain 10/32510/5
Georg Kühnberger [Wed, 27 Aug 2014 14:04:31 +0000 (16:04 +0200)]
[BUGFIX] Let Web-View respect TCEMAIN.previewDomain

Added previewDomain in order to have Web-View functioning in the
same way like Page-Preview does.

Fixes: #61226
Related: #30889
Releases: 6.3, 6.2
Change-Id: I872651aeac1bda27f7a8a034fc30a21ff7162df0
Reviewed-on: http://review.typo3.org/32510
Reviewed-by: Oliver Gassner <og@plan2.net>
Tested-by: Oliver Gassner <og@plan2.net>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Add missing check in PreparedStatement->execute() 52/32452/2
Jacob Rasmussen [Wed, 27 Aug 2014 15:32:26 +0000 (17:32 +0200)]
[BUGFIX] Add missing check in PreparedStatement->execute()

When using prepared statements for inserts and updates, the
execute method currently fails due to a missing check on the
return value from $this->statement->result_metadata();

Resolves: #61229
Releases: 6.3, 6.2
Change-Id: Ida17f617915c36a0c2e91663eee64b4c358090e2
Reviewed-on: http://review.typo3.org/32452
Reviewed-by: Mattias Nilsson <tollepjaer@gmail.com>
Tested-by: Mattias Nilsson <tollepjaer@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[FEATURE] BE: Use proper placeholder shim for IE <= 9 30/31830/5
Benjamin Mack [Fri, 25 Jul 2014 18:14:47 +0000 (20:14 +0200)]
[FEATURE] BE: Use proper placeholder shim for IE <= 9

The current solution to add HTML5 placeholder
attribute support for unsupported browsers
(which are IE9 and lower) is using a combination
of ExtJS and Prototype, which both need
to be loaded for that.

Currently this is used in FormEngine and
the backend login form.

However, there are better ways of creating
these fallbacks, one being Placeholder.JS
(see http://jamesallardice.github.io/Placeholders.js/)
which can seamlessly be integrated,
and only be loaded for IE9 and less.

Resolves: #60578
Releases: 6.3
Change-Id: If8443276b85d15222c4fc0954e3f79b50ce6a4c9
Reviewed-on: http://review.typo3.org/31830
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] SqlParser: Unify internal usage of tableType/engine 04/32304/2
Stefan Neufeind [Thu, 21 Aug 2014 19:50:05 +0000 (21:50 +0200)]
[TASK] SqlParser: Unify internal usage of tableType/engine

For create-table "tableType" was still used while an alter-table
used "engine".

Change-Id: Idee0e569e331ec66084484f1e8d55d9cab03ff9f
Resolves: #61129
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32304
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Make context menus work with modules 87/31987/7
Helmut Hummel [Mon, 4 Aug 2014 16:30:44 +0000 (18:30 +0200)]
[BUGFIX] Make context menus work with modules

To make it possible to use the module dispatcher
with a click menu item, it is necessary to add
the CSRF token to the URL of the called click menu
functionality.

Resolves: #60635
Releases: 6.3, 6.2
Change-Id: I0b378c3ba4c22f25b10e39950d08568f608decdb
Reviewed-on: http://review.typo3.org/31987
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] EM using bad indexes 80/31080/2
Stefan Froemken [Mon, 23 Jun 2014 15:16:34 +0000 (17:16 +0200)]
[BUGFIX] EM using bad indexes

The extensionmanager uses bad indexes. It is better
to move col repository to the the end of the indexes.

Resolves: #59809
Releases: 6.3,6.2
Change-Id: I0bb8d5cdfc8591bb35485b204ad5e8dafd1b4d16
Reviewed-on: http://review.typo3.org/31080
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Marcin Sągol <marcin@soee.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Remove non accessible pages from browse menu 98/30098/11
Kay Strobach [Wed, 14 May 2014 07:26:13 +0000 (09:26 +0200)]
[BUGFIX] Remove non accessible pages from browse menu

This patch enables the browse menu to skip inaccessible items
for prev and next links.

It makes use of the filterMenuPages method, which is already
applied to any kind of menu. Since it has not been applied
to the sections of the browse menu type, which are actually
menus themselves, inaccessible pages made browsing unusable.

This applies to missing translations as well.

Change-Id: I8779731139785dea72b078567912c96e3ad5c7ca
Resolves: #58792
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/30098
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Marcin Sągol <marcin@soee.pl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix call to undefined function when importing t3x 44/31744/6
René Bigler [Wed, 23 Jul 2014 22:06:38 +0000 (00:06 +0200)]
[BUGFIX] Fix call to undefined function when importing t3x

When importing a t3x file that contains files the function
"getFiles" of the object TYPO3\CMS\Core\Resource\Folder is called
which does not exist.

Resolves: #60474
Releases: 6.3, 6.2
Change-Id: Ibc392bced57a85ad6eae333406ff507af7faefd4
Reviewed-on: http://review.typo3.org/31744
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] QueryGenerator getTreeList negative ids 19/31919/3
Klaas Johan Kooistra [Thu, 31 Jul 2014 09:39:39 +0000 (11:39 +0200)]
[BUGFIX] QueryGenerator getTreeList negative ids

When persistence.recursive is configured when using a command controller no
records can be retrieved because the storagePid is negated in the
AbstractConfigurationManager, while claiming all implementations of getTreeList
support negative ids. Using abs() on the id when it is negative fixes this.
Also see the ContentObjectRenderer implementation of getTreeList

Change-Id: I7732290126a83a79204b8224d52a3cd878360e64
Resolves: #60697
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31919
Reviewed-by: Peter Beernink <p.beernink@youwe.nl>
Tested-by: Peter Beernink <p.beernink@youwe.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Collect correct information on elements in page 29/31929/3
Jigal van Hemert [Fri, 1 Aug 2014 04:55:35 +0000 (06:55 +0200)]
[BUGFIX] Collect correct information on elements in page

In the page module information on neighboring content elements is
collected while building the page layout. This information must
be remembered for other elements on the page instead of generated
new when rendering each element. This makes sure the move buttons and
edit buttons have the correct URLs.

Resolves: #60199
Releases: 6.3, 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I9fec256b145fe8aba229d8b026fba73871942347
Reviewed-on: http://review.typo3.org/31929
Reviewed-by: Robert Heinig <robert.heinig@3m5.de>
Tested-by: Robert Heinig <robert.heinig@3m5.de>
Reviewed-by: Gerwin Kramer <gerwinkramer@gmail.com>
Tested-by: Gerwin Kramer <gerwinkramer@gmail.com>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Stefan Holz <sh@atlantismedia.de>
Tested-by: Stefan Holz <sh@atlantismedia.de>
Reviewed-by: Christian Hernmarck <ch_t3@hernmarck.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Change fetch of maximum version using LEFT JOIN 62/32062/10
Andreas Fernandez [Fri, 8 Aug 2014 12:03:02 +0000 (14:03 +0200)]
[TASK] Change fetch of maximum version using LEFT JOIN

Currently, the method fetchMaximalVersionsForAllExtensions uses a
subselect to determine the highest available version. This solution is
rather inefficient and incomptabile to DBAL. The query is replaced by
a LEFT JOIN.

Resolves: #60857
Releases: 6.2, 6.3
Change-Id: I7ae3c523259bf260c41080aee269f6df33edb408
Reviewed-on: http://review.typo3.org/32062
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 years agoRevert "[BUGFIX] Unified maxitems default value for group fields" 18/31818/3
Wouter Wolters [Fri, 25 Jul 2014 16:03:27 +0000 (18:03 +0200)]
Revert "[BUGFIX] Unified maxitems default value for group fields"

Unexpected behaviour. Default of maxitems in now 1 by default
which doesn't work if you need more items. Previously this
was possible. Revert this to have the old working
behaviour again.

Releases: 6.3,6.2
Resolves: #60263
Reverts: #55731
This reverts commit c578d47617f803c9ea167d88000e63a92c13fa93.

Change-Id: Ice5357aecb1969f11c6821cb81824d2d68200717
Reviewed-on: http://review.typo3.org/31818
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Make sure all new files are indexed 00/32000/3
Frans Saris [Tue, 5 Aug 2014 14:19:19 +0000 (16:19 +0200)]
[BUGFIX] Make sure all new files are indexed

If the FAL indexer scheduler task finds a index record with
same content hash as a new found file the file isn't added to the
index if it isn't marked as missing.

This patch changes the indexer so that new files with same
content hash are added when no index record is found for a missing
file with same content hash.

Resolves: #60764
Releases: 6.3, 6.2
Change-Id: Ifb7f9e6f48ba327c958a7aa0e0b71f0575cabdf7
Reviewed-on: http://review.typo3.org/32000
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Avoid DB error on writing to log 47/32247/2
Markus Klein [Tue, 19 Aug 2014 13:10:33 +0000 (15:10 +0200)]
[BUGFIX] Avoid DB error on writing to log

The writeLog() function of the ErrorHandler tries to log the IP that
caused the error. On CLI there is no IP hence a NULL value is being
tried to insert into the DB, where the DB field is NOT NULL.

Fix this by casting the IP to a string.

Resolves: #61051
Releases: 6.3, 6.2
Change-Id: Id46e97468bf825307258e907811d5f2c77c62161
Reviewed-on: http://review.typo3.org/32247
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Daniel Hürtgen <daniel@higidi.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Missing stdWrap for select.recursive TypoScript property 43/30043/7
Matthias Kappenberg [Tue, 13 May 2014 11:09:24 +0000 (13:09 +0200)]
[TASK] Missing stdWrap for select.recursive TypoScript property

Processing stdWrap for the select.recursive TypoScript property
has just been forgotten in the original issue #18822 during the
development of TYPO3 4.6.

Change-Id: I34f2ac45e5112fbcc2becf7936f486f0b53d361a
Resolves: #55707
Releases: 6.3, 6.2, 6.1
Reviewed-on: http://review.typo3.org/30043
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] "Illegal mix of collations" in Upgrade Wizard 17/32117/6
Lars Trebing [Tue, 12 Aug 2014 15:20:58 +0000 (17:20 +0200)]
[BUGFIX] "Illegal mix of collations" in Upgrade Wizard

When directly comparing CAST(... AS CHAR) with a CHAR field (including
VARCHAR and TEXT) whose collation isn't the same as that of the database
connection, MySQL gives an error like this:

> Illegal mix of collations (utf8_general_ci,IMPLICIT) and
> (utf8_unicode_ci,IMPLICIT) for operation '<>'

Wrapping the right side of the comparison in CAST(... AS CHAR) as well
keeps the data unchanged while ensuring that both sides have the same
collation.

Change-Id: Icaec66412d6b6441ae30065ffb92565991e9a1e4
Resolves: #36754
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32117
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 years ago[TASK] Clean-up source code 58/32158/3
Oliver Hader [Thu, 14 Aug 2014 09:43:13 +0000 (11:43 +0200)]
[TASK] Clean-up source code

Remove new-line at end of file that has been introduced
by accident in commit:7ef6d2c8fddaf2ba01cb820d9abefcb8ead09b17

Releases: master
Change-Id: I0a18755d16aaef4496b21183f870dffbd86ee2c1
Reviewed-on: http://review.typo3.org/32158
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[TASK] Refactor file references relations retrieval 87/31287/3
Oliver Hader [Wed, 2 Jul 2014 10:20:27 +0000 (12:20 +0200)]
[TASK] Refactor file references relations retrieval

The retrieval of file references in BackendUtility
is currently bound to the thumbCode() method but
is useful for other components as well.

Resolves: #60054
Releases: master, 6.2
Change-Id: Id92bdeaed24d8924285a640f905ffd55db21da4d
Reviewed-on: http://review.typo3.org/31287
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[TASK] Simplify record icons in workspace module 54/31254/3
Oliver Hader [Mon, 30 Jun 2014 19:01:20 +0000 (21:01 +0200)]
[TASK] Simplify record icons in workspace module

The record details view renders record icons for both live and
versioned record. However, this representation is shown rather
stand-alone and can be combined with the accordant headers.

Resolves: #60015
Releases: master, 6.2
Change-Id: I2f468a06271f335c491d90d825f7bcef7a9db9f6
Reviewed-on: http://review.typo3.org/31254
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[TASK] CGL Cleanup: Fix TYPO3.Strings.ConcatenationSpacing-Sniff 71/32071/3
Andy Grunwald [Sun, 10 Aug 2014 18:05:07 +0000 (20:05 +0200)]
[TASK] CGL Cleanup: Fix TYPO3.Strings.ConcatenationSpacing-Sniff

Resolves: #60878
Releases: 6.3
Change-Id: I2cc8ec067adcc66bdd589104d03f20c385e52e99
Reviewed-on: http://review.typo3.org/32071
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Prevent Inclusion of MediaWizardProvider* in Base Bootstrap 46/28046/7
Benjamin Mack [Fri, 25 Jul 2014 18:32:29 +0000 (20:32 +0200)]
[TASK] Prevent Inclusion of MediaWizardProvider* in Base Bootstrap

On every Frontend request, the original media wizard
provider of EXT:cms is loaded, by fetching the
MediaWizardProviderManager and then
an object of MediaWizardProvider is loaded and held
in memory, as this is not needed, but only on pages
where a media is used.

This change moves the instantiation of the providers to
the time when it is needed.

Further modification would be to add the registered
wizards to TYPO3_CONF_VARS[FE][mediaProviders] and
use them directly in the MEDIA object, so the
MediaWizardProviderManager class could be deprecated.

Releases: 6.3
Resolves: #56336
Change-Id: Id466d41fef019449d820b6faec3946ec1c951488
Reviewed-on: http://review.typo3.org/28046
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Extend install tool suhosin checks 37/31637/3
Oliver Hader [Wed, 16 Jul 2014 10:13:35 +0000 (12:13 +0200)]
[TASK] Extend install tool suhosin checks

Extend install tool suhosin checks by
* suhosin.get.max_name_length=200
* suhosin.post.max_name_length=200
* suhosin.request.max_varname_length=200

Resolves: #60356
Releases: 6.2, 6.3
Change-Id: I382e44832918799df58a912e95cd4b0c3f0b81a3
Reviewed-on: http://review.typo3.org/31637
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Use defaultMailFromName setting in install tool 66/31966/4
Oliver Hader [Mon, 4 Aug 2014 08:50:36 +0000 (10:50 +0200)]
[BUGFIX] Use defaultMailFromName setting in install tool

The defaultMailFromName setting is not used for sending
the test mails in the install tool.

Resolves: #60758
Releases: master, 6.2
Change-Id: I35e1b887de6b06bb5f301e037d6d412c18ac0b37
Reviewed-on: http://review.typo3.org/31966
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Show properties of stdClass object in <f:debug> 08/32108/5
Christian Weiske [Tue, 12 Aug 2014 12:13:20 +0000 (14:13 +0200)]
[BUGFIX] Show properties of stdClass object in <f:debug>

Using fluid's <f:debug> to get dumps of json_decode()d objects
does not work currently. The DebuggerUtility shows only properties
obtainable via ReflectionClass, which does not work for stdClass objects.

The patch introduces special handling of stdClass objects, using the
properties that actually exist in the object.

Change-Id: I3845178f6defdbceae4b867f45e5080f23443766
Fixes: #60912
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32108
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Updating "current_version" fails with some DBMS 65/32065/4
Andreas Fernandez [Fri, 8 Aug 2014 14:00:19 +0000 (16:00 +0200)]
[BUGFIX] Updating "current_version" fails with some DBMS

Updating the field "current_version" fails with some DMBS because
$uidsOfCurrentVersion has too many elements. This patch chunks
the array into multiple parts and updates the uids in each part.

Resolves: #60859
Releases: 6.2, 6.3
Change-Id: If63f855b250bf7c9b6cd7112f60392cfc8ccfd67
Reviewed-on: http://review.typo3.org/32065
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Correctly parse suhosin configuration 22/32122/2
Markus Klein [Wed, 13 Aug 2014 08:51:22 +0000 (10:51 +0200)]
[BUGFIX] Correctly parse suhosin configuration

The system environment check does not properly parse the suhosin
configuration option for whitelist.
Fix this by changing the code to be less strict about the actual syntax
of this option.

Resolves: #60925
Releases: 6.3, 6.2
Change-Id: I6797a313cedaaf1895cf7b4fddaae9811341006b
Reviewed-on: http://review.typo3.org/32122
Reviewed-by: Daniel <typo3dev@outlook.com>
Tested-by: Daniel <typo3dev@outlook.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Publishing delete placeholder affects other workspaces 89/31589/3
Oliver Hader [Fri, 11 Jul 2014 08:49:51 +0000 (10:49 +0200)]
[BUGFIX] Publishing delete placeholder affects other workspaces

On publishing a delete placeholder all other versions shall be
deleted as well, since the original record will be deleted after
that action. However, this is only valid for the live workspace
and using the legacy version behavior there.

DataHandler::deleteVersionsForRecord() calls
BackendUtility::selectVersionsOfRecord(), but without the
additional, but required, $workspace argument. Thus, all other
versions in other workspaces are deleted as well. The SQL query
to determine versions needs to be limited to either the live
workspace (for legacy versions) and the current workspace.

Resolves: #60249
Releases: master, 6.2
Change-Id: If90511dc4ac2bc3dde6e58570e6bf10e4ac949db
Reviewed-on: http://review.typo3.org/31589
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Wrong nesting of deleted versioned child records 91/31591/3
Oliver Hader [Wed, 25 Jun 2014 11:19:13 +0000 (13:19 +0200)]
[BUGFIX] Wrong nesting of deleted versioned child records

If deleting an IRRE child reference, the nesting leving in the
workspace module is not shown correctly. The reason for that is,
that the sys_refindex entry points to the live id of the deleted
child record.

This change takes care of correct visualization only, but does not
touch the sys_refindex behavior in this case.

Resolves: #59853
Releases: master, 6.2
Change-Id: I09970d12ba10e528c150275952ec4c9ff8333a0a
Reviewed-on: http://review.typo3.org/31591
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Failing cascaded delete action of localized elements 42/31142/4
Oliver Hader [Wed, 25 Jun 2014 13:50:02 +0000 (15:50 +0200)]
[BUGFIX] Failing cascaded delete action of localized elements

Having a record in live workspace with an accordant localization
leads to the fact that actions to the default language also have
an impact to all localizations.

In a workspace, first deleting the localization, then deleting
the record of the default language, ends up in actually having
reverted the previous deletion of the localization.

The solution is to check for delete placeholders in
DataHandler::deleteL10nOverlayRecords().

Resolves: #59113
Releases: master, 6.2
Change-Id: I888c83a58d591f57bc2ea75a49fa603a56a7f722
Reviewed-on: http://review.typo3.org/31142
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Page Tree not always updated after workspace actions 91/31091/3
Oliver Hader [Mon, 23 Jun 2014 18:34:59 +0000 (20:34 +0200)]
[BUGFIX] Page Tree not always updated after workspace actions

After some workspace actions being performed in the workspaces
module in the TYPO3 Backend, the page tree does not get updated:
* discarding a single workspace version
* performing mass actions which output warnings

Resolves: #59828
Releases: 6.2, master
Change-Id: Ic9fb6613e8647ed351246ea18fcb3696e60ef7b2
Reviewed-on: http://review.typo3.org/31091
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Keep phpunit 4.1 branch 15/32115/3
Christian Kuhn [Tue, 12 Aug 2014 20:22:08 +0000 (22:22 +0200)]
[BUGFIX] Keep phpunit 4.1 branch

composer.json is configured to fetch latest phpunit 4.x branch.
Since 4.2 was just released stable, it will be used now.

phpunit 4.2 now relies on Ocramius/Instantiator to create mocks
that do not call a constructor during instantiation. This project
was created to cope with a recent security fix in PHP unserialize()
that rendered the old way of creating those mocks invalid.

The instantiator project however has issues with PHP versions
5.3 and 5.6 that lead to some failing tests and need further
investigation.

To not run into this during our next merges, the patch nails
phpunit to 4.1.x for now.

Change-Id: I5feb8346e0713fefe6c8fa899c76d3e040dd1973
Resolves: #60923
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32115
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] JavaScript error in Install Tool 28/31828/4
Wouter Wolters [Fri, 25 Jul 2014 18:06:30 +0000 (20:06 +0200)]
[BUGFIX] JavaScript error in Install Tool

When using toggleButton in "Test setup" a JavaScript
error is thrown because the scrolling handler can only
be used if the fixed footer is available.

Add a check to prevent this JavaScript error.

Resolves: #60577
Releases: 6.3,6.2
Change-Id: Ie7628e83280f6af032b364586cdfb6b386663d9d
Reviewed-on: http://review.typo3.org/31828
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>