Packages/TYPO3.CMS.git
6 years ago[BUGFIX] Fix invalid global for getData hooks 35/22735/3
Alexander Stehlik [Wed, 31 Jul 2013 16:21:31 +0000 (18:21 +0200)]
[BUGFIX] Fix invalid global for getData hooks

Replace the invalid usage of $TYPO3_CONF_VARS with
$GLOBALS['TYPO3_CONF_VARS'] for getting the hook
configuration in ContentObjectRenderer::getData().

This bug was introduced with issue #50606 in 6.2 only.

Resolves: #50606
Related: #50258
Releases: 6.2
Change-Id: Ib553f8c0dacd891e4bd392481ef7b4773386287f
Reviewed-on: https://review.typo3.org/22735
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Create BE-user in Install Tool with a salted password 76/22676/3
Wouter Wolters [Mon, 29 Jul 2013 22:31:23 +0000 (00:31 +0200)]
[FEATURE] Create BE-user in Install Tool with a salted password

Introduce the possibility to salt the password when creating
a new Backend User in the Install Tool. When Saltedpasswords
is installed and backend usage is enabled the password will
be salted with saltedpasswords. Otherwise the md5 hashing method
is still used.

Change-Id: I30b2fab2c4158c878e849f061f0d464b501b62bc
Resolves: #31407
Releases: 6.2
Reviewed-on: https://review.typo3.org/22676
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
6 years ago[TASK] Raise PHP version requirement to 5.3.7 62/22662/3
Christian Kuhn [Mon, 29 Jul 2013 15:53:03 +0000 (17:53 +0200)]
[TASK] Raise PHP version requirement to 5.3.7

PHP versions smaller than 5.3.7 have some bugs that are worked
around with some nasty hacks in current core. It was already
decided on TYPO3 Active Contributor Meeting in Nuernberg to
not support these versions with the upcoming LTS that will have
to support so many different PHP versions already: Younger 5.3,
5.4, 5.5 and later on in the lifecycle of the product maybe even
more.

The patch drops compatibility code for versions smaller than 5.3.7.

Change-Id: I3344d797f0c2f23f5135257b98c1b05c80871399
Resolves: #50529
Releases: 6.2
Reviewed-on: https://review.typo3.org/22662
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Cleanup ext:func 68/22268/6
Wouter Wolters [Fri, 12 Jul 2013 18:53:20 +0000 (20:53 +0200)]
[TASK] Cleanup ext:func

- Remove require_once calls
- Replace global $LANG and $BACK_PATH

Change-Id: I279bf7a1a59ed3dbf490a6b875977915ef503d13
Resolves: #49989
Releases: 6.2
Reviewed-on: https://review.typo3.org/22268
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Travis setup without Introduction package 23/22723/2
Christian Kuhn [Tue, 30 Jul 2013 14:29:35 +0000 (16:29 +0200)]
[TASK] Travis setup without Introduction package

In travis, the introduction package is used to import the database
schema to successfully run the unit tests.
This is now substituted with a small php based script in the
travis integration repository, that basically imports the base schema
by running code similar to the according step in the installation
process. Cloning the introduction package is no longer needed.
Travis will now for automatically adapt to database schema changes
defined in ext_tables.sql scripts and without changing foreign
repositories anymore.

Change-Id: If246650acfabde119d4e02c78d5449ab8d44feef
Resolves: #50571
Releases: 6.2
Reviewed-on: https://review.typo3.org/22723
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup ext:info and ext:info_pagetsconfig 71/22271/5
Wouter Wolters [Fri, 12 Jul 2013 19:46:59 +0000 (21:46 +0200)]
[TASK] Cleanup ext:info and ext:info_pagetsconfig

- Remove require_once calls
- Replace global $LANG and $BACK_PATH
- Make some function calls use real boolean

Change-Id: I6e913e183a8357076b55d84c961e1104d643e81e
Resolves: #49992
Releases: 6.2
Reviewed-on: https://review.typo3.org/22271
Reviewed-by: Oliver Klee
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[SECURITY] fileDenyPattern ignored in file-list module 12/22712/2
Jigal van Hemert [Tue, 30 Jul 2013 12:39:57 +0000 (14:39 +0200)]
[SECURITY] fileDenyPattern ignored in file-list module

Change-Id: Icf4b3452c3b039f12335e184161083cbcbd3acec
Fixes: #47452
Releases: 6.0, 6.1, 6.2
Security-Commit: 15cd3daec85c16cf0e810c41f5005810876fc99b
Security-Bulletin: TYPO3-CORE-SA-2013-002
Reviewed-on: https://review.typo3.org/22712
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] XSS in 3rd party library Flowplayer 11/22711/2
Oliver Hader [Tue, 30 Jul 2013 12:39:42 +0000 (14:39 +0200)]
[SECURITY] XSS in 3rd party library Flowplayer

Change-Id: I6bb53b23ca4df6f8d4b8ee801bd99a1a5c32f5b2
Fixes: #49209
Releases: 4.7, 6.0, 6.1, 6.2
Security-Commit: 7d306dbb20eb3a6b1dbee6c9896835c50dda87eb
Security-Bulletin: TYPO3-CORE-SA-2013-002
Reviewed-on: https://review.typo3.org/22711
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] XSS in 3rd party library Audio Player 10/22710/2
Oliver Hader [Tue, 30 Jul 2013 12:39:34 +0000 (14:39 +0200)]
[SECURITY] XSS in 3rd party library Audio Player

Update player.swf of version 2.0.4.6 from
http://wordpress.org/plugins/audio-player/

Change-Id: Ib9ba8c7f02279c42d619154b9b79cc38a8e2c41b
Fixes: #49210
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Security-Commit: 0391f9dad3698a519b0f6785d210accddc708238
Security-Bulletin: TYPO3-CORE-SA-2013-002
Reviewed-on: https://review.typo3.org/22710
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] EM unit test is broken 86/22686/2
Xavier Perseguers [Tue, 30 Jul 2013 05:21:10 +0000 (07:21 +0200)]
[BUGFIX] EM unit test is broken

Follow-up: #50441
Releases: 6.2
Change-Id: I008a3b08ff84b050118d9b37adc6e61e9ddd9279
Reviewed-on: https://review.typo3.org/22686
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Deleted flag is not updated during file indexing 60/22660/3
Oliver Hader [Mon, 29 Jul 2013 14:31:44 +0000 (16:31 +0200)]
[BUGFIX] Deleted flag is not updated during file indexing

If sys_file records (file objects) have set the deleted flag, it
won't be removed once the file is physically available again
with the same file name (identifier).

Change-Id: Id6dc7466764ac3994606204edadc9c2a7d2106c8
Fixes: #50525
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22660
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[FEATURE] Add a timestamp when downloading an extension 69/22669/2
Xavier Perseguers [Mon, 29 Jul 2013 18:25:18 +0000 (20:25 +0200)]
[FEATURE] Add a timestamp when downloading an extension

When downloading an extension within the Extension Manager, a
timestamp should be automatically added to the filename.

Resolves: #50441
Releases: 6.2
Change-Id: I86c00b814715b126a655f2c73b40b955b328acff
Reviewed-on: https://review.typo3.org/22669
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[BUGFIX] MailUtility breakLinesForEmail cuts text wrong and discard rest 78/21978/5
Tim Lochmueller [Fri, 5 Jul 2013 21:26:50 +0000 (23:26 +0200)]
[BUGFIX] MailUtility breakLinesForEmail cuts text wrong and discard rest

Now the substrStart pointer increases in case that the line is longer
than the lineWidth parameter.

Resolves: #49396
Releases: 6.2, 6.1, 6.0
Change-Id: I87b3622c2ada7efdcb4c1992c1cfa43635d68f09
Reviewed-on: https://review.typo3.org/21978
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[FEATURE] stdWrap replacement: add optionSplit-support 98/15898/6
Stefan Neufeind [Mon, 22 Oct 2012 23:28:34 +0000 (01:28 +0200)]
[FEATURE] stdWrap replacement: add optionSplit-support

With optionSplit the "replace"-parameter can be
different depending on the occurence of the string
(first/middle/last-part, ...).

Change-Id: Ic71adfbc05e6c963098d47847475f731eb577af2
Resolves: #42287
Releases: 6.2
Reviewed-on: https://review.typo3.org/15898
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years agoRevert "[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay" 70/22670/2
Anja Leichsenring [Mon, 29 Jul 2013 19:10:57 +0000 (21:10 +0200)]
Revert "[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay"

This reverts commit ef71d61619d7da17131c38531308d4abbfa8dbf5

The patch introduces a regression. We have no easy fix for it, so the patch gets reverted. Sorry for now, we come back to the problem.

Change-Id: Iad674e88ea488d3bcee4d306b3e5c935a4c90334
Reviewed-on: https://review.typo3.org/22670
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years agoRevert "[BUGFIX] sys_file record doesn't get flagged as delete" 65/22665/2
Oliver Hader [Mon, 29 Jul 2013 16:39:26 +0000 (18:39 +0200)]
Revert "[BUGFIX] sys_file record doesn't get flagged as delete"

This reverts commit 18bb6574966d6fdff944e8fd5f95e9225dae4365

Change-Id: I2cd6c4a03c3336e73bfe81fa86f222ce5a352f7d
Reviewed-on: https://review.typo3.org/22665
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Properly double-backslash some backslashes in strings 48/19948/4
Stefan Neufeind [Sat, 13 Apr 2013 21:58:01 +0000 (23:58 +0200)]
[TASK] Properly double-backslash some backslashes in strings

Resolves: #47198
Releases: 6.2
Change-Id: I56c1221b58ce08868ff755c4a54b0fa9f4447aff
Reviewed-on: https://review.typo3.org/19948
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Workspace selector in top toolbar cannot scroll 12/21912/4
Georg Ringer [Fri, 5 Jul 2013 09:41:09 +0000 (11:41 +0200)]
[BUGFIX] Workspace selector in top toolbar cannot scroll

If there are too many workspaces defined, some of them cannot
be accessed using the workspace selector in in the top toolbar
due to a missing scrolling behaviour of that component.

Fixes: #11014
Releases: 6.2, 6.1, 6.0
Change-Id: Iaae51ebb2524116b8673a9cc81d612fd845b2d29
Reviewed-on: https://review.typo3.org/21912
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Detection of curlProxyServer settings is incorrect 81/18481/5
Dmitry Dulepov [Tue, 26 Feb 2013 13:53:17 +0000 (17:53 +0400)]
[BUGFIX] Detection of curlProxyServer settings is incorrect

Parsing of 'curlProxyServer' option during the bootstrap is incorrect.
It produces wrong host and port part in 'proxy_host' and 'proxy_port'
system options.

Change-Id: I12f66acef697dbec9b065edcba8ad0d8f78c4e01
Resolves: #45834
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/18481
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] vfsStream: Use namespaced version from phpunit follow-up 49/22649/2
Wouter Wolters [Sun, 28 Jul 2013 19:53:38 +0000 (21:53 +0200)]
[TASK] vfsStream: Use namespaced version from phpunit follow-up

Follow-up for #50496

Change-Id: I7f0f453100d3024492387b241013cc7088089103
Resolves: #50504
Releases: 6.2
Reviewed-on: https://review.typo3.org/22649
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Backend documentation module 22/22622/5
Xavier Perseguers [Sat, 27 Jul 2013 13:15:35 +0000 (15:15 +0200)]
[FEATURE] Backend documentation module

The documentation module brings back access to extension manuals and
lets official TYPO3 documents (such as guidelines, tutorials and
references) as well as custom documents to be listed in a central place.

Resolves: #50486
Releases: 6.2
Change-Id: Ib35a48f72682844f1bfe569763a561a89e7d810b
Reviewed-on: https://review.typo3.org/22622
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
6 years ago[FEATURE] INCLUDE_TYPOSCRIPT all files from directory (recursive) 31/9431/13
Loek Hilgersom [Wed, 19 Dec 2012 21:47:27 +0000 (22:47 +0100)]
[FEATURE] INCLUDE_TYPOSCRIPT all files from directory (recursive)

Include all TypoScript files from a directory tree:
<INCLUDE TYPOSCRIPT: source="DIR:directorypath" extensions="ts">
This includes all files from the directory, including subdirs.
If the additional property extensions=".." is provided, only
files with these file extensions are included. This allows e.g.
to include both setup and constants from the same directory tree,
using different file extensions for each.
Order in which files are included is alphabetically, first files,
then directories.

Change-Id: Ie3ca7eea47b61326dfc1f60743051be13b8aee2f
Resolves: #34621
Releases: 6.2
Reviewed-on: https://review.typo3.org/9431
Tested-by: Sebastian Michaelsen
Reviewed-by: Ronald Klomp
Tested-by: Ronald Klomp
Reviewed-by: Rens Admiraal
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] RTE wizard can't "save document and view page" 11/20111/6
Stanislas Rolland [Tue, 23 Apr 2013 15:47:46 +0000 (11:47 -0400)]
[BUGFIX] RTE wizard can't "save document and view page"

Including the full fieldConfig from TCA may produce too long an URL.
In IE, the RTE wizard simply does not open.

Solution: Remove the fieldConfig parameter not used by the RTE wizard.

Revolves: #43637
Resolves: #43631
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Change-Id: Idd855d56d6a7ed92d40d9a788bc11efb3f535ed3
Reviewed-on: https://review.typo3.org/20111
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Support custom translation servers for extensions 87/22587/2
Xavier Perseguers [Fri, 26 Jul 2013 12:41:43 +0000 (14:41 +0200)]
[FEATURE] Support custom translation servers for extensions

Use of signal/slot to post-process the mirror URL when fetching
localization packages for a given extension key.

Resolves: #50467
Releases: 6.2
Change-Id: I6a0edc0a6765da05458c191f968f72068132b87b
Reviewed-on: https://review.typo3.org/22587
Reviewed-by: Stefan Neufeind
Reviewed-by: Begoña
Reviewed-by: Frans Saris
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
6 years ago[FEATURE] Add check if local extensions can be loaded 47/22047/13
Susanne Moog [Sat, 6 Jul 2013 17:17:45 +0000 (19:17 +0200)]
[FEATURE] Add check if local extensions can be loaded

Add a check in the install tool that checks if all local
extensions can be loaded without fatal errors by including
ext_localconf and ext_tables files.

Change-Id: I30ff00af83e59681c52901ecc09889f5c3cd4243
Releases: 6.2
Resolves: #49760
Reviewed-on: https://review.typo3.org/22047
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Adjust namespacing in Extbase-testcases 32/22232/2
Stefan Neufeind [Thu, 11 Jul 2013 21:30:33 +0000 (23:30 +0200)]
[TASK] Adjust namespacing in Extbase-testcases

Classes created for testing should run inside
separate testing-namespace and not pollute
the global namespace.
We also need to extend from \\TYPO3\\...
instead of just TYPO3\\... then.

Change-Id: I0577327a3b3a7ee1be089bf381b153dd1a1a5602
Resolves: #42984
Releases: 6.2
Reviewed-on: https://review.typo3.org/22232
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] vfsStream: Use namespaced version from phpunit 34/22634/3
Stefan Neufeind [Sat, 27 Jul 2013 22:18:17 +0000 (00:18 +0200)]
[TASK] vfsStream: Use namespaced version from phpunit

Newest phpunit introduced a namespaced version of
vfsStream together with the fix for #50230.
Although a migration-layer with the old classnames
was added, the namespaced classes should now
directly be used.

Change-Id: I1832f5690b9ea2b3f9fea5b7a1c2b39f8637f761
Resolves: #50496
Releases: 6.2
Reviewed-on: https://review.typo3.org/22634
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Check lightweight cases before class_exists if possible 27/22627/3
Stefan Neufeind [Sat, 27 Jul 2013 20:22:23 +0000 (22:22 +0200)]
[TASK] Check lightweight cases before class_exists if possible

If other checks like "in_array" can be done first that are more
lightweight than calling class_exists and potentially causing
(multiple) autoloaders (without success) to search for files.

Resolves: #50494
Releases 6.2

Change-Id: I9b2010c09591fd02eefdc57f869edd80d4106e14
Reviewed-on: https://review.typo3.org/22627
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Add a clear all cache button to install tool 33/22633/2
Christian Kuhn [Sat, 27 Jul 2013 21:09:58 +0000 (23:09 +0200)]
[FEATURE] Add a clear all cache button to install tool

This implements a clear all cache functionality to the install tool.

The implementation is different from the existing backend solution
so that it at least partly clears caches even if some broken
extension is loaded that would kill the operation.

To achieve that, first a low level removal of typo3temp/Cache is
performed, then all table names starting with "cf_" are truncated
with direct database calls. After that ext_localconf and ext_tables
of extension are loaded (this may fatal) and the final cache
configuration is then feeded to the cache manager that executes
the usual flushCaches() call.

Change-Id: Ibd717b0d34bd5b8737a73acebf4632fed38c4d8c
Resolves: #50495
Releases: 6.2
Reviewed-on: https://review.typo3.org/22633
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Use real boolean value for pi_getLL third param 93/22593/2
Wouter Wolters [Fri, 26 Jul 2013 13:24:53 +0000 (15:24 +0200)]
[TASK] Use real boolean value for pi_getLL third param

Make use of boolean value TRUE as third parameter in
pi_getLL function.

Change-Id: I688187fcb5130b9d3b49fabeee36c67cf300e3dc
Resolves: #50469
Releases: 6.2
Reviewed-on: https://review.typo3.org/22593
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Debug exception handler: set exit code on CLI 40/17240/4
Christian Weiske [Wed, 19 Dec 2012 13:50:40 +0000 (14:50 +0100)]
[BUGFIX] Debug exception handler: set exit code on CLI

Sets the exit code to 1 when an exception is caught by the debug exception
handler, so that the error state can be checked automatically.

Change-Id: Ic89a79f2ded0b4b9ccc58a4789d9416f260fd88a
Fixes: #44118
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/17240
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Class loader tries to load classes it cannot load 40/22440/4
Andreas Wolf [Sat, 20 Jul 2013 10:19:13 +0000 (12:19 +0200)]
[BUGFIX] Class loader tries to load classes it cannot load

If a class file from a third-party package is loaded which does not
follow the Vendor\Product\Classname convention (e.g. Product\Classname),
the class loader still tries to access the third component of the class
name, leading to a warning (and thus an exception, depending on your
configuration).

To fix this problem, the class loader now checks in advance if it can
possibly load this class (or rather if the classname conforms to the
specification for the CMS universe).

Change-Id: I1cd3964b9486ea591fb373533fd6cef4e9ce3989
Resolves: #50217
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22440
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Better distinction of fields in the backend 03/22603/4
Ingo Pfennigstorf [Fri, 26 Jul 2013 19:26:51 +0000 (21:26 +0200)]
[TASK] Better distinction of fields in the backend

This patch enables a better distinction of form elements in the
backend.

Change-Id: Id5bd87eeb68aaa68ccbc284d874a22a1ff0577bb
Fixes: #50460
Releases: 6.2
Reviewed-on: https://review.typo3.org/22603
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[CLEANUP] Avoid double parsing of includes 12/22612/2
Francois Suter [Fri, 26 Jul 2013 20:08:52 +0000 (22:08 +0200)]
[CLEANUP] Avoid double parsing of includes

The Template Analyzer BE module parses TypoScript for
included files twice.

Resolves: #50473
Releases: 6.2
Change-Id: I5794b55d22e3ca139112477cd28c5ad4477e97cc
Reviewed-on: https://review.typo3.org/22612
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Add tests for ContentObjectRenderer::getData() 73/22473/3
Stefan Neufeind [Sun, 21 Jul 2013 19:42:13 +0000 (21:42 +0200)]
[TASK] Add tests for ContentObjectRenderer::getData()

* Adds unittests
* Cleanup and fix some things along the way
* Some modes didn't allow to be executed without
  adding a dummy-value (e.g. "parameters")

Change-Id: I2b4ff89c828384c852e6fbf9f82c55e6ebbac281
Resolves: #50258
Releases: 6.2
Reviewed-on: https://review.typo3.org/22473
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Run phpLint and phpUnit in different travis builds 24/22624/2
Christian Kuhn [Sat, 27 Jul 2013 18:15:05 +0000 (20:15 +0200)]
[TASK] Run phpLint and phpUnit in different travis builds

phpLint checks php files for compilation errors in travis before
the unit tests are executed. This takes quite some time.
The patch configures travis to run phpLint and phpUnit in different
builds to speed up the process. Additionally, phpLint environment
does not clone phpunit and the introduction package and does no
database initialization.

Change-Id: Ie25ade5b6a8fcf4c4dc0752fc8662c433ea3c33c
Resolves: #50492
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22624
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Adds fileReferenceUid to content rendering 59/21759/3
Lars Peipmann [Mon, 1 Jul 2013 09:28:43 +0000 (11:28 +0200)]
[TASK] Adds fileReferenceUid to content rendering

FrontendContentAdapterService saves the file uid but not the
file reference uid.

This commits adds the file reference uid.

Change-Id: I5af09521d5dadc194ec567aec24792def370aedc
Resolves: #49535
Releases: 6.2
Reviewed-on: https://review.typo3.org/21759
Reviewed-by: Andreas Wolf
Reviewed-by: Lars Peipmann
Reviewed-by: Steffen Ritter
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Fix disappearing table head in extension manager 11/22611/3
Ingo Pfennigstorf [Fri, 26 Jul 2013 19:52:58 +0000 (21:52 +0200)]
[BUGFIX] Fix disappearing table head in extension manager

This is a sass recompilation of the extension manager scss that fixes
the problem of disappearing table heads.

Change-Id: I7b708f34798714170bed1cbf1b76599990c9dd6f
Fixes: #50440
Releases: 6.2
Reviewed-on: https://review.typo3.org/22611
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[TASK] Provide information about import action in TCEmain to hooks 15/10515/9
Stefan Galinski [Tue, 27 Nov 2012 01:31:50 +0000 (02:31 +0100)]
[TASK] Provide information about import action in TCEmain to hooks

While importing T3D files the TCEmain currently fires the required
processing on records just as if the editor is generating the records. If
extensions hook into TCEmain, there is no way to differenciate this
situation from the regular editing mode - which might provide unexpected
results, i.e. wrong IRRE relations.

Solution is to provide a boolean to indicate that TCEmain has been called
during an import action which extensions could use to recognize this
situation.

Change-Id: I4fe429fb88f8ec24a7fda885f38ddfbdb4a642f5
Resolves: #36031
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/10515
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Use @inject annotation in extensionmanager 19/22619/3
Ingo Pfennigstorf [Fri, 26 Jul 2013 23:12:43 +0000 (01:12 +0200)]
[TASK] Use @inject annotation in extensionmanager

This patch removes all occurences of injectFooBar methods from the
extensionmanager sysext and replaces them with the @inject
annotation.

Releases: 6.2
Fixes: #50482
Change-Id: Idc55d15e3a4d6086529864e4013478983b9c45e7
Reviewed-on: https://review.typo3.org/22619
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Make BackendUtility::viewOnClick honor doc 26/14826/8
Kasper Ligaard [Fri, 21 Sep 2012 12:27:28 +0000 (14:27 +0200)]
[BUGFIX] Make BackendUtility::viewOnClick honor doc

Make parameter $alternativeUrl work as documented in the docblock
and also as it worked until #22157.
This patch preserves the hook and basically just puts in an
if-statement. Also adding a unit test.

Change-Id: I7d67af438b0a0af51ca7662b3f8286aeec827c77
Fixes: #41165
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/14826
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Kasper Ligaard
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[TASK] Remove empty .gitmodules file 13/22613/2
Christian Kuhn [Fri, 26 Jul 2013 21:02:46 +0000 (23:02 +0200)]
[TASK] Remove empty .gitmodules file

With removal of git submodules the .gitmodules file is empty
and can be removed now.

Change-Id: I453f63c0852825b46e9ea62f87385d9eace25134
Resolves: #50480
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22613
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Failures in em unit tests due to phpunit update 04/22604/2
Christian Kuhn [Fri, 26 Jul 2013 19:30:43 +0000 (21:30 +0200)]
[BUGFIX] Failures in em unit tests due to phpunit update

Young phpunit versions seem to handle clones a bit differently,
resulting in test failures in extension manager tests. The tests
are adapted a bit to fix this.

Change-Id: If70561743f68a62167e41ee4c23ae96b56f83ab9
Resolves: #50478
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22604
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] FAL wrong \RecursiveIteratorIterator usage 02/22602/2
Christian Kuhn [Fri, 26 Jul 2013 18:54:23 +0000 (20:54 +0200)]
[BUGFIX] FAL wrong \RecursiveIteratorIterator usage

If using \RecursiveIteratorIterator on \RecursiveDirectoryIterator,
flag SELF_FIRST must be used, otherwise only leaves (files) and not
also directories are returned. This behavior is a bit dependent on
the PHP version used, younger versions (> 5.3.3 seem to do it
correctly).

Furthermore, in copyFolderWithinStorage() $itemSubPath contains
the "relative" path part and not only the node name, checking
equality to "." or ".." fails then if handling sub directories.
So, directories may be created multiple times, resulting in mkdir()
warnings. This is fixed by getting the node name itself and using
that for comparison.

Resolves: #50476
Releases: 6.2, 6.1, 6.0

Change-Id: Ifac4b28f4e02ec8a9bf5891739cf66c1e1074af9
Reviewed-on: https://review.typo3.org/22602
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] FAL does not copy subfolders cleanly 96/22596/2
Christian Kuhn [Fri, 26 Jul 2013 15:43:19 +0000 (17:43 +0200)]
[BUGFIX] FAL does not copy subfolders cleanly

If full structures with sub folders are copied around in FAL
local driver, sub folders are not correctly created in the
target directory.

This is detected in unit tests after recent vfsStream updates in
ext:phpunit.

The patch adds a flag to the Iterator code to also include
directories to fix the issue.

Additionally, the existing two unit tests also tested multiple other
methods of the local driver and are functional tests. The patch moves
those two tests to the functional section and adds three simple unit
tests with correct mocking instead.

Change-Id: I30d3c8bd5c6538b3fe23405d97bcddff6c1ff405
Releases: 6.2, 6.1, 6.0
Resolves: #50472
Reviewed-on: https://review.typo3.org/22596
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Use real boolean value for getLL second param 38/22538/2
Wouter Wolters [Wed, 24 Jul 2013 14:34:06 +0000 (16:34 +0200)]
[TASK] Use real boolean value for getLL second param

Make use of boolean value TRUE as second parameter in
getLL function.

Change-Id: I15fe034159e4bb8ecb7c15f8f6e915975fca7c9b
Resolves: #50393
Releases: 6.2
Reviewed-on: https://review.typo3.org/22538
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Use real boolean value for trimExplode third param 42/22542/3
Wouter Wolters [Wed, 24 Jul 2013 17:11:30 +0000 (19:11 +0200)]
[TASK] Use real boolean value for trimExplode third param

Make use of boolean value TRUE as third parameter in
trimExplode function.

Change-Id: Ied33efac6cddfc2e2798435fe9b1ef748c11905b
Resolves: #50402
Releases: 6.2
Reviewed-on: https://review.typo3.org/22542
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Fix failing test 84/22584/2
Anja Leichsenring [Fri, 26 Jul 2013 09:21:45 +0000 (11:21 +0200)]
[BUGFIX] Fix failing test

The test failes due to incorrect mocking, what leads to not claimed
properties for the test.
Additionally the expected call amounts where handled more strictly
where fitting.

Releases: 6.2, 6.1, 6.0
Resolves: #50458
Change-Id: I34214fb9ef9e9935892aa03518505b877538e128
Reviewed-on: https://review.typo3.org/22584
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Uninstall extension with dependency throws Exception 62/22162/3
Wouter Wolters [Tue, 9 Jul 2013 16:49:02 +0000 (18:49 +0200)]
[BUGFIX] Uninstall extension with dependency throws Exception

Exception is thrown if uninstalling an extension with
dependecies on that extension. Catch the exception and
show a nice Flashmessage.

Change-Id: I434a4e1e1d83f43a6f5d4c99a82433e35ddd92f9
Resolves: #49722
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22162
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Test regression from patch for #47192 61/22461/2
Andreas Wolf [Sat, 20 Jul 2013 21:14:22 +0000 (23:14 +0200)]
[BUGFIX] Test regression from patch for #47192

This fixes a unit test regression introduced with the solution for
 #47192.

Change-Id: I0e70b916f24fada7f76e7fd835d31e54ca41a402
Related: #47192
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22461
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Improve method annotation and type hinting in FAL 72/22572/2
Christian Kuhn [Thu, 25 Jul 2013 20:53:04 +0000 (22:53 +0200)]
[BUGFIX] Improve method annotation and type hinting in FAL

Add a missing "@throws" annotation and a namespaced comment.

Change-Id: Ibc929a01dbfdef9cf8730a8da259570786b6118c
Resolves: #50447
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22572
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] rsaauth BackendFactory does not unset backend 45/22545/2
Markus Klein [Wed, 24 Jul 2013 18:12:42 +0000 (20:12 +0200)]
[BUGFIX] rsaauth BackendFactory does not unset backend

The BackendFactory of rsaauth tries to forcefully unset an
instantiated backend, but unsets the class name instead of the object.

Resolves: #50411
Releases: 6.2, 6.1, 6.0
Change-Id: I26712c73b74788cad159f95c7e54cbbbf69e8764
Reviewed-on: https://review.typo3.org/22545
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] require_once of vfsStream triggers travis fail 66/22566/3
Christian Kuhn [Thu, 25 Jul 2013 18:42:59 +0000 (20:42 +0200)]
[BUGFIX] require_once of vfsStream triggers travis fail

vfsStream is now included in ext:phpunit, the pear module is
not maintained and was removed in travis.
This triggeres a failure in the phplint check. All require_once
calls are removed for now, ext:phpunit now also provides an
autoloader for vfsSstream.

Change-Id: If1b07c31e999111e6b5d2804a9f5cc457066b7b0
Resolves: #50442
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22566
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Revise typo3/sysext/README.txt 44/22544/3
Wouter Wolters [Wed, 24 Jul 2013 18:00:47 +0000 (20:00 +0200)]
[TASK] Revise typo3/sysext/README.txt

* Replace GIT repository link with the new one
* Remove information about submodules

Change-Id: I60db762ce831c7edea413d9f7780a5617b7f9e96
Resolves: #50410
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22544
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years agoRevert "[BUGFIX] Links on external pages don't get indexed" 52/22552/3
Jigal van Hemert [Thu, 25 Jul 2013 08:14:08 +0000 (10:14 +0200)]
Revert "[BUGFIX] Links on external pages don't get indexed"

This reverts commit 819b5be0ac81004371fee2f0e6386cc32233a59b

Discussion with Mario Rimann and Stefan Neufeind leads to the conclusion
that this patch breaks current behaviour and that it's not possible to
implement both use cases without an extra setting. Agreement was to
revert this change and turn the bug report into a feature request.

Change-Id: Iebb62c89959328cc460fea5f1f46fb824b892822
Reviewed-on: https://review.typo3.org/22552
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[TASK] Remove comments for revised in TYPO3 3.6 43/22543/2
Wouter Wolters [Wed, 24 Jul 2013 17:41:13 +0000 (19:41 +0200)]
[TASK] Remove comments for revised in TYPO3 3.6

Double class comments are also removed.

Change-Id: Ic46d7e353b8874e46ae720a2e3603bf54cc8d524
Resolves: #50409
Releases: 6.2
Reviewed-on: https://review.typo3.org/22543
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
6 years ago[TASK] Make DiffUtility faster and much more scaleable. 08/22508/3
Kasper Ligaard [Mon, 22 Jul 2013 16:19:49 +0000 (18:19 +0200)]
[TASK] Make DiffUtility faster and much more scaleable.

The method DiffUtility->explodeStringIntoWords() calls array_merge()
inside a loop. The cost of constantly doing a function invocation and
merging arrays needlessly slows the method and the whole diff utility.
Moving the array merging outside the loop, the method becomes faster
and able to handle much larger input.

Change-Id: I4c2d21cff9b18392e89e316fec9dc615e715a073
Resolves: #50318
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22508
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Two mailforms on a page cause error on field validation 44/12844/7
Ernesto Baschny [Tue, 27 Nov 2012 01:38:49 +0000 (02:38 +0100)]
[BUGFIX] Two mailforms on a page cause error on field validation

Check formname for uniqueness and if need append a unique hash.

Change-Id: Ifd33c5130c383f3afc3e5e6d80c1be017f25ec5b
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Fixes: #16114
Reviewed-on: https://review.typo3.org/12844
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] phpdoc: Use boolean/integer instead of bool/int 70/22470/2
Stefan Neufeind [Sun, 21 Jul 2013 12:23:32 +0000 (14:23 +0200)]
[TASK] phpdoc: Use boolean/integer instead of bool/int

Change-Id: I44d65aa2669e4516cfb2edb26d937ef70a58df2d
Resolves: #50253
Releases: 6.2
Reviewed-on: https://review.typo3.org/22470
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Improve logout button styling and add id 52/22452/2
Andreas Wolf [Sat, 20 Jul 2013 15:48:38 +0000 (17:48 +0200)]
[TASK] Improve logout button styling and add id

Change-Id: I093d38bb048e96257a35931dbd3f36f85796e26c
Resolves: #50227
Releases: 6.2
Reviewed-on: https://review.typo3.org/22452
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Width of action column is wrong 34/22434/3
Oliver Hader [Wed, 19 Jun 2013 14:53:35 +0000 (16:53 +0200)]
[BUGFIX] Width of action column is wrong

The width of the action column in the workspaces module is
wrong. 5 icons with a width of 16px each need to be displayed
and results in a required width of 80px.

Fixes: #50210
Releases: 6.0, 6.1, 6.2
Change-Id: I3e1cbfd9be53c57dad86a6003edbf38b559dab73
Reviewed-on: https://review.typo3.org/22434
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay 22/21322/2
Stanislas Rolland [Mon, 10 Jun 2013 15:25:00 +0000 (11:25 -0400)]
[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay

Solution: When this flag is set to FALSE, do not apply language
overlays.

Resolves: #47192
Releases: 6.0, 6.1, 6.2
Change-Id: Iac0d647fde2f930a63bc6982472b1c76e649601d
Reviewed-on: https://review.typo3.org/21322
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Paul Dubuc
Tested-by: Paul Dubuc
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
6 years ago[TASK] Adhere enableDeprecationLog settings 10/18510/7
Michael Schams [Wed, 27 Feb 2013 11:42:29 +0000 (12:42 +0100)]
[TASK] Adhere enableDeprecationLog settings

Refactoring of function deprecationLog() to prevent accidental
activation of log file creation due to misconfiguration.
Correct misleading configuration description (label in Install Tool).

Resolves: #43900
Releases: 6.2
Change-Id: I04164270ea3359014b6637d6c68cf2d9348356b0
Reviewed-on: https://review.typo3.org/18510
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[FEATURE] Registers for title & alt text fields in file links 05/17705/3
Georg Ringer [Fri, 25 Jan 2013 14:06:39 +0000 (15:06 +0100)]
[FEATURE] Registers for title & alt text fields in file links

The file link element offers a description, title text and alternative
label text for each file.
Currently, it is only possible to access the description via a register.
It would be desirable to also provide registers for the alt and title
text fields, e.g., to only link the description and provide more
in-depth info in the other fields.

Change-Id: I7860a769e957c83691e48090ea1bbc94c9ebf9df
Resolves: #44182
Releases: 6.2
Reviewed-on: https://review.typo3.org/17705
Reviewed-by: Alexander Opitz
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Faulty layout if row details are too long 81/22381/2
Oliver Hader [Wed, 17 Jul 2013 11:49:52 +0000 (13:49 +0200)]
[BUGFIX] Faulty layout if row details are too long

If the row details in in the workspaces difference view are too
long, e.g. a string that does not contain white-spaces like e.g.
a filename, the layout looks broken.
The solution is to introduce a new classname for the content
details and to force word breaking via CSS.

Fixes: #50114
Releases: 6.0, 6.1, 6.2
Change-Id: I9a768aed1c9bb4ebdfea5ba79083b7e5dce262d9
Reviewed-on: https://review.typo3.org/22381
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Undefined switchable controller actions must be removed 30/22030/5
Alexander Schnitzler [Sat, 6 Jul 2013 15:39:05 +0000 (17:39 +0200)]
[BUGFIX] Undefined switchable controller actions must be removed

Currently there is no check if switchable controller actions in
pi_flexform are still present in the configuration flexform. So,
when removing the flexforms in the configuration file, the
switchable controller actions section is not deleted in pi_flexform.

This change removes all occurences in the present pi_flexform, so
if no switchable controller actions are defined any longer, they
will be removed, else they are overwritten by the current flexform
data.

Releases: 6.2
Resolves: #31198
Change-Id: I6046b29dbf436d8c970593dbc6fd2c216f222c52
Reviewed-on: https://review.typo3.org/22030
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Use correct url schema in MediaWizardProvider 45/22345/2
Georg Ringer [Tue, 16 Jul 2013 05:00:18 +0000 (07:00 +0200)]
[BUGFIX] Use correct url schema in MediaWizardProvider

If the media provider supports https, the video should be
embedded using https instead of http.

Change-Id: Id6f1677acfd82ba071c2425f345ea20b48de9cfe
Resolves: #50041
Releases: 6.2
Reviewed-on: https://review.typo3.org/22345
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[FEATURE] Backport ApplicationContext from Flow 69/22269/7
Steffen Müller [Fri, 12 Jul 2013 18:56:44 +0000 (20:56 +0200)]
[FEATURE] Backport ApplicationContext from Flow

Flow has the notion of ApplicationContext which provides a unique
API for handling contexts.

This API allow us to provide default configuration sets for
particular contexts. For example having decent logging in
production context vs. full reports in development context.

The context is set using the TYPO3_CONTEXT environment variable.
If not set the context defaults to "Production".

The context can be queried using:
\TYPO3\CMS\Core\Core\Bootstrap::getInstance()->getContext();

Resolves: #49988
Releases: 6.2
Change-Id: Id953052f2846c740f27a83931adfb64b0d8d9169
Reviewed-on: https://review.typo3.org/22269
Reviewed-by: Thomas Maroschik
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Remove redundant try/catches in ResourceStorage of FAL 75/21575/5
Claus Due [Fri, 21 Jun 2013 19:13:50 +0000 (21:13 +0200)]
[TASK] Remove redundant try/catches in ResourceStorage of FAL

This change simply removes some try/catch statement which did
nothing but re-throw the RuntimeException.

Fixes: #49332
Releases: 6.0, 6.1, 6.2
Change-Id: I62d7e1b0312a16926b06e0bd5eb6fc8be0829d3c
Reviewed-on: https://review.typo3.org/21575
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGFIX] Category API does not consider multiple tables 63/21963/3
Marc Wöhlken [Fri, 5 Jul 2013 16:23:58 +0000 (18:23 +0200)]
[BUGFIX] Category API does not consider multiple tables

Using the Category API with multiple tables, leads to wrong
results due to a missing check for the correct table.

Resolves: #45332
Releases: 6.2, 6.1, 6.0
Change-Id: Iaf5b453acd434ab8d8f58932a2c96385a66abf37
Reviewed-on: https://review.typo3.org/21963
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Use extension's name in documentation 61/22361/2
Xavier Perseguers [Tue, 16 Jul 2013 13:53:32 +0000 (15:53 +0200)]
[TASK] Use extension's name in documentation

Settings.yml should reflect the name of the extension.

Resolves: #50081
Releases: 6.2
Change-Id: Iac7573b0023609a8b9cf91b23623983cee7b67dd
Reviewed-on: https://review.typo3.org/22361
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Setting space before/after should use !important 46/22346/3
Georg Ringer [Tue, 16 Jul 2013 05:04:08 +0000 (07:04 +0200)]
[TASK] Setting space before/after should use !important

If the setting space before/after is used, the generated styles
should use !important to override possible CSS styles done somewhere else.

Change-Id: Ib2cbef280e6d2ac9d1503448ebaede48cf9d159b
Resolves: #50038
Releases: 6.2,6.1,6.0
Reviewed-on: https://review.typo3.org/22346
Reviewed-by: Ralf-Rene Schroeder
Tested-by: Ralf-Rene Schroeder
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGFIX] Links on external pages don't get indexed 90/6990/10
Mario Rimann [Fri, 5 Apr 2013 18:48:24 +0000 (20:48 +0200)]
[BUGFIX] Links on external pages don't get indexed

Allows the crawler to start indexing a specific file like
www.domain.tld/foobar.html instead of just www.domain.tld/

This is just about the comparison against the base URL and
enables the Crawler to start crawling at e.g. a file that contains
a manually generated list of links to follow. Before that change,
even links to targets on the same domain were rejected by
the checkUrl() method in case the base Url was pointing to some
file instead of "/". This was because the base URL was then not
part of the target URL.
After stripping off any path from the base URL for this comparison
this can now also be used to start crawling from a file.

Change-Id: I2727a9a447754b88d2c279c24b32b5c3a2df26c0
Resolves: #16534
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/6990
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Missing/Wrong copy buttons if deflangBinding is disabled 15/22015/4
Stefan Galinski [Sat, 6 Jul 2013 13:41:16 +0000 (15:41 +0200)]
[BUGFIX] Missing/Wrong copy buttons if deflangBinding is disabled

Fixes: #49712
Releases: 6.2, 6.1, 6.0
Change-Id: If3aebb786ae6b3f23964704d5f3c13ea7b0fd0af
Reviewed-on: https://review.typo3.org/22015
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[FEATURE] Migrate sysext manuals to reST 37/22337/2
Francois Suter [Mon, 15 Jul 2013 20:28:05 +0000 (22:28 +0200)]
[FEATURE] Migrate sysext manuals to reST

All system extension manuals are migrated to reStructured Text.
All OpenOffice manuals are removed.

Resolves: #50052
Releases: 6.2
Change-Id: I9d8d9ad433276e6105d9c38b9f2a3b34dc8749f6
Reviewed-on: https://review.typo3.org/22337
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Localconf upgrade wizard fails 82/22282/3
Wouter Wolters [Sat, 13 Jul 2013 15:43:26 +0000 (17:43 +0200)]
[BUGFIX] Localconf upgrade wizard fails

Converting localconf.php to LocalConfiguration.php
with the installtool upgrade-wizard fails on
Debian Squeeze installation.

Change-Id: Id06793fc487cd1ad6b1d56ca5ee5a99960b3f4b1
Resolves: #39434
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22282
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] require-statements should use absolute paths 70/22270/3
Stefan Neufeind [Fri, 12 Jul 2013 19:27:45 +0000 (21:27 +0200)]
[TASK] require-statements should use absolute paths

require-statements relying on the current working-
directory and/or a certain include-path setting
can cause unexpected behaviour.
A path is added for those cases. For the current
working-directory simply using __DIR__ is okay.

Change-Id: I959c8f4a1d25ca1403e7dcecb0bc20826c7c5059
Resolves: #49991
Releases: 6.2
Reviewed-on: https://review.typo3.org/22270
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Fix PHP warning trigged in initFEuser 27/22327/2
Markus Klein [Mon, 15 Jul 2013 18:32:18 +0000 (20:32 +0200)]
[BUGFIX] Fix PHP warning trigged in initFEuser

TypoScriptFrontendController::initFEuser() calls
$GLOBALS['TYPO3_DB']->cleanIntList() with a possible NULL argument.
This leads to a PHP warning in GeneralUtility::trimExplode().

Resolves: #42921
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Id33ee8fe5e4177716af6ce8c9084e098b86c280c
Reviewed-on: https://review.typo3.org/22327
Reviewed-by: Thorsten Kahler
Tested-by: Thorsten Kahler
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Indexing files does not store the language 99/18899/4
Mario Rimann [Thu, 14 Mar 2013 10:32:55 +0000 (11:32 +0100)]
[BUGFIX] Indexing files does not store the language

While indexing externals (e.g. PDF files) the language of the page
being rendered is not stored with the indexed file content. Thus
the file is shown/not shown in the wrong situations.

See detailed description in bug-report regarding the "situations".

Change-Id: I69eb1e222eb186b052eba93eaa9d5a80dd1e87ab
Resolves: #46261
Releases: 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/18899
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Cleanup entry classes in typo3/ part2 69/21669/3
Wouter Wolters [Wed, 26 Jun 2013 17:36:15 +0000 (19:36 +0200)]
[TASK] Cleanup entry classes in typo3/ part2

Cleanup the entry classes inside typo3/ with the following
changes:

* Move language include to constructor
* Remove not needed doc-comments
* Make class available in $GLOBALS['SOBE']

Change-Id: Ie5bcf1f6f09a070a946a021d41d4809567ff6229
Resolves: #49454
Releases: 6.2
Reviewed-on: https://review.typo3.org/21669
Reviewed-by: Alexander Opitz
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Fix usage of functions, which are deprecated in PHP 5.5 56/21556/4
Markus Klein [Thu, 20 Jun 2013 23:55:37 +0000 (01:55 +0200)]
[TASK] Fix usage of functions, which are deprecated in PHP 5.5

Fixes a call to preg_replace with /e modifier,
which is deprecated in PHP 5.5 now.

Resolves: #49300
Releases: 6.2, 6.1
Change-Id: I6bd4b57d64801be912e0050772420a684b1aa237
Reviewed-on: https://review.typo3.org/21556
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] requestUpdate sensitive to spaces 14/22314/2
Wouter Wolters [Sat, 13 Jul 2013 17:26:28 +0000 (19:26 +0200)]
[BUGFIX] requestUpdate sensitive to spaces

The TCA property "requestUpdate" is sensitive to spaces, although this
is documented nowhere. Indeed "foo1, foo2" will not work whereas
"foo1,foo2" does. This patch strips spaces from the "requestUpdate"
string before testing it.

Resolves: #49872
Related: #42789
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I44410007503443843a3ecbff15f4738cd857b73c
Reviewed-on: https://review.typo3.org/22314
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years agoRevert "[BUGFIX] requestUpdate sensitive to spaces" 11/22311/3
Markus Klein [Mon, 15 Jul 2013 07:36:34 +0000 (09:36 +0200)]
Revert "[BUGFIX] requestUpdate sensitive to spaces"

This reverts commit acd257b53de13b01f8e5efb4cb1e3af8a74260f4

The code has a wrong parentheses order.
Backports are fixed, only master (6.2) affected.

Releases: 6.2
Change-Id: I605730841fa8c86eb275d3d925c5a917049f386b
Reviewed-on: https://review.typo3.org/22311
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGFIX] requestUpdate sensitive to spaces 83/22283/3
Wouter Wolters [Sat, 13 Jul 2013 17:26:28 +0000 (19:26 +0200)]
[BUGFIX] requestUpdate sensitive to spaces

The TCA property "requestUpdate" is sensitive to spaces, although this
is documented nowhere. Indeed "foo1, foo2" will not work whereas
"foo1,foo2" does. This patch strips spaces from the "requestUpdate"
string before testing it.

Change-Id: Ifbb1fe5be59077207316e48204d65a978592f878
Resolves: #49872
Related: #42789
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22283
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGFIX] Exceptions if EXT:context_help is not installed 29/20929/3
Dmitry Dulepov [Mon, 20 May 2013 11:25:34 +0000 (15:25 +0400)]
[BUGFIX] Exceptions if EXT:context_help is not installed

If the extension 'context_help' is not installed, the web
server's error log sometimes shows exceptions like "Class
'TYPO3\CMS\ContextHelp\ExtDirect\ContextHelpDataProvider'
not found" and "Invalid argument supplied for foreach()".
This happens because the class in question is registered
to ExtDirect without checking if the corresponding
extension is loaded.

Change-Id: Ic773cff2822912aac7841955be2f09d77169fdb9
Resolves: #48394
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/20929
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Felix Kopp
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Use new paths for tstemplate classes 73/22273/3
Max Roesch [Sat, 13 Jul 2013 07:03:48 +0000 (09:03 +0200)]
[BUGFIX] Use new paths for tstemplate classes

TsTemplate classes have been moved into a central directory.
All uses of the classes now have the right new directory.

Resolves: #49993
Releases: 6.2
Change-Id: I3b3168b0550d704ef2388304be30bac961e371f9
Reviewed-on: https://review.typo3.org/22273
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Max Roesch
Tested-by: Max Roesch
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] be_users:usergroup_cached_list to small 84/22284/2
Wouter Wolters [Sat, 13 Jul 2013 18:17:28 +0000 (20:17 +0200)]
[BUGFIX] be_users:usergroup_cached_list to small

The field usergroup_cached_list in be_users table
is to small. Make it a text field.

Change-Id: I45afa0880da20323329694073777a51dcfc2db4d
Resolves: #49962
Releases: 6.2
Reviewed-on: https://review.typo3.org/22284
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Use correct class in T3Editor save hook 89/22289/2
Jigal van Hemert [Sun, 14 Jul 2013 11:03:27 +0000 (13:03 +0200)]
[BUGFIX] Use correct class in T3Editor save hook

After merging the Template related sysexts the save hook in T3Editor
needs to refer to the new class.

Change-Id: I6eb4eef2d703b9e50246b7faef808985f609cb7f
Resolves: #50013
Releases: 6.2
Reviewed-on: https://review.typo3.org/22289
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Make DBgetDelete() update tstamp on delete by update 24/20024/3
Stefan Neufeind [Thu, 18 Apr 2013 15:03:57 +0000 (17:03 +0200)]
[BUGFIX] Make DBgetDelete() update tstamp on delete by update

If told to do so by TCA ContentObjectRenderer::DBgetDelete()
will not immediately delete a row but mark it as deleted.
This change updates the tstamp (if that column is configured)
for that "updated" row as well, like on a regular update.

Fixes: #47354
Releases: 6.2, 6.1
Change-Id: I61b9ce7d8608b73cfb974e79d2f9f59e6dc3547a
Reviewed-on: https://review.typo3.org/20024
Tested-by: Dmitry Dulepov
Reviewed-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGIFX] RTEmagic upgrade wizard: missing attributes 19/22019/3
Francois Suter [Sat, 6 Jul 2013 14:32:56 +0000 (16:32 +0200)]
[BUGIFX] RTEmagic upgrade wizard: missing attributes

When the RTE creates a magic images it uses data-* attributes
to keep a reference to the original FAL record. The upgrade
wizard migrates the images, creates the sys_file entries but
does not add the data-* attributes.

Resolves: #49733
Releases: 6.1, 6.2
Change-Id: Ib483355336d1331892920ada847850a61c35a3af
Reviewed-on: https://review.typo3.org/22019
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGFIX] Remove gap underneath Linkvalidator tabs 76/22276/2
Wouter Wolters [Sat, 13 Jul 2013 10:24:45 +0000 (12:24 +0200)]
[BUGFIX] Remove gap underneath Linkvalidator tabs

In Linkvalidator backend module the gap between tabs
and table is removed.

Change-Id: Icaed87594cb7e9833810709fd3ae9acf40b963f7
Resolves: #49997
Related: #49133
Releases: 6.2
Reviewed-on: https://review.typo3.org/22276
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
6 years ago[BUGFIX] Remove gap underneath Workspace tabs 74/22274/2
Felix Kopp [Sat, 13 Jul 2013 09:42:46 +0000 (11:42 +0200)]
[BUGFIX] Remove gap underneath Workspace tabs

In Workspace backend module the gap between tabs
and table is removed.

Change-Id: I1031c1a8eed43a23bc87cf7415972b5bd1cd6055
Resolves: #49133
Releases: 6.2
Reviewed-on: https://review.typo3.org/22274
Reviewed-by: Max Roesch
Tested-by: Max Roesch
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Permissions backend module not accessible 26/22226/2
Wouter Wolters [Thu, 11 Jul 2013 19:05:18 +0000 (21:05 +0200)]
[BUGFIX] Permissions backend module not accessible

Permissions backend module not accessible in "List" view.

Change-Id: Ic1e4e06f387ee5450466e051162572c3392e3d53
Resolves: #49918
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22226
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Allow target attribute for more doctypes 15/22215/2
Jigal van Hemert [Thu, 11 Jul 2013 13:55:33 +0000 (15:55 +0200)]
[BUGFIX] Allow target attribute for more doctypes

The target attribute for links is allowed according to w3c documentation
in more doctypes than xhtml frameset and html5.

Change-Id: Id4110399dec1c1f1d0a4d69342440021837b51a9
Resolves: #37710
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22215
Reviewed-by: Henrik Ziegenhain
Tested-by: Patrick Broens
Reviewed-by: Patrick Broens
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Set TYPO3 version to 6.2-dev 11/22211/2
TYPO3 Release Team [Thu, 11 Jul 2013 13:29:00 +0000 (15:29 +0200)]
[TASK] Set TYPO3 version to 6.2-dev

Change-Id: Ia0b2a4cbfc50b71340e7d5133f699d62e4c46254
Reviewed-on: https://review.typo3.org/22211
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.2.0alpha2 10/22210/2 TYPO3_6-2-0alpha2
TYPO3 Release Team [Thu, 11 Jul 2013 13:28:35 +0000 (15:28 +0200)]
[RELEASE] Release of TYPO3 6.2.0alpha2

Change-Id: Ib7566d7b13a7e2c091158ea77d7f8e2077d475e0
Reviewed-on: https://review.typo3.org/22210
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Refactored ElementInfo missed one table 00/22200/2
Ernesto Baschny [Thu, 11 Jul 2013 09:48:12 +0000 (11:48 +0200)]
[BUGFIX] Refactored ElementInfo missed one table

Resolves: #49889
Related: #49164
Releases: 6.2
Change-Id: I09276b37134f3f781e28ac098596966f7866ec04
Reviewed-on: https://review.typo3.org/22200
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
6 years ago[TASK] Add latest changes to ChangeLog.txt 03/22203/2
Anja Leichsenring [Thu, 11 Jul 2013 10:18:11 +0000 (12:18 +0200)]
[TASK] Add latest changes to ChangeLog.txt

In preparation of the Alpha2 release of TYPO3 CMS 6.2 the latest
changes in extbase were added to the ChangeLog file.

Releases: 6.2
Resolves: #49896
Change-Id: Ib59f741a4427ba093e459545c823f9bfd0277d5e
Reviewed-on: https://review.typo3.org/22203
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Add latest changes to ChangeLog.txt 02/22202/3
Anja Leichsenring [Thu, 11 Jul 2013 10:01:06 +0000 (12:01 +0200)]
[TASK] Add latest changes to ChangeLog.txt

In preparation of the Alpha2 release of TYPO3 CMS 6.2 the latest
changes in extbase were added to the ChangeLog file.

Releases: 6.2
Resolves: #49894
Change-Id: I3ca728147dc4eed7c27dd5f2039336d1d2b52472
Reviewed-on: https://review.typo3.org/22202
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] requestUpdate sensitive to spaces 74/22174/2
Francois Suter [Wed, 10 Jul 2013 12:12:32 +0000 (14:12 +0200)]
[BUGFIX] requestUpdate sensitive to spaces

The TCA property "requestUpdate" is sensitive to spaces, although this
is documented nowhere. Indeed "foo1, foo2" will not work whereas
"foo1,foo2" does. This patch strips spaces from the "requestUpdate"
string before testing it.

Resolves: #42789
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I340090e93e7b8645493f8db0c8c374cb1227f684
Reviewed-on: https://review.typo3.org/22174
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Francois Suter
Tested-by: Francois Suter