Packages/TYPO3.CMS.git
14 months ago[TASK] Add more rules for Code sniffer 33/56533/13
Georg Ringer [Mon, 16 Apr 2018 13:55:20 +0000 (15:55 +0200)]
[TASK] Add more rules for Code sniffer

In order to improve code quality, the following code sniffers are added:

- cast_spaces
- declare_equal_normalize
- dir_constant

Resolves: #84590
Releases: master, 8.7
Change-Id: Ib8a353b9ec47bff146b5decc3d5f97d242672efa
Reviewed-on: https://review.typo3.org/56533
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[BUGFIX] Make categories required for category related menus 79/56679/2
Georg Ringer [Mon, 16 Apr 2018 10:19:42 +0000 (12:19 +0200)]
[BUGFIX] Make categories required for category related menus

Set the minitems of categories of the the menu types "Categorized content"
and "Categorized pages" to 1 to force editors to fill out this field.

Resolves: #84738
Releases: master, 8.7
Change-Id: I84962e35ac1cffe34e1cd1abb0234a4e201eccd6
Reviewed-on: https://review.typo3.org/56679
Reviewed-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
14 months ago[BUGFIX] Fix typos in TCA migration messages 78/56678/2
Georg Ringer [Mon, 16 Apr 2018 10:10:46 +0000 (12:10 +0200)]
[BUGFIX] Fix typos in TCA migration messages

Improve typos and grammar in messages of the TCA migration

Resolves: #84742
Releases: master, 8.7
Change-Id: I5dca04efcd9bfe796907612500735b4d93dddc41
Reviewed-on: https://review.typo3.org/56678
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Ensure that the „recover“ message is always in jQuery context 38/56638/5
Andreas Fernandez [Thu, 12 Apr 2018 12:45:26 +0000 (14:45 +0200)]
[BUGFIX] Ensure that the „recover“ message is always in jQuery context

When a page is about to get recovered by the recycler, a checkbox is
rendered into the modal text, which requires propert jQuery object.

However, if that checkbox is not required, a simple string is stored in
the `$message` variable, breaking functionality as a jQuery object is
expected. The message is now wrapped in a `<p>` tag to always have a
jQuery object in place.

Resolves: #84701
Relases: master, 8.7
Change-Id: Ie534380aa4be9800ce2754e0226ee52ee9ce5dc1
Reviewed-on: https://review.typo3.org/56638
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Fix getPublicUrl return hints 43/56643/6
Kevin Ditscheid [Wed, 11 Apr 2018 20:41:49 +0000 (22:41 +0200)]
[BUGFIX] Fix getPublicUrl return hints

Since getPublicUrl could also return null, we need to
change the return hints to respect that.

Resolves: #84688
Releases: master, 8.7
Change-Id: Ib811b6bbeebf9dec974b094c6acf505ca4ac26e1
Reviewed-on: https://review.typo3.org/56643
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
15 months ago[BUGFIX] Remove quoting of search value in recycler 45/56645/2
Andreas Fernandez [Fri, 13 Apr 2018 06:46:11 +0000 (08:46 +0200)]
[BUGFIX] Remove quoting of search value in recycler

This patch removes a wrong call of `$queryBuilder->quote()` which causes
a wrong SQL statement, as the search filter text gets passed as a named
parameter later on.

Resolves: #84710
Releases: master, 8.7
Change-Id: If9bd45687827e20142558f12acefea6b70290372
Reviewed-on: https://review.typo3.org/56645
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Haupt <dh@schiffel.it>
Tested-by: Daniel Haupt <dh@schiffel.it>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
15 months ago[TASK] Fix UTF-8 spelling in examples + documentation 49/56649/3
Michael Stucki [Fri, 13 Apr 2018 14:53:30 +0000 (16:53 +0200)]
[TASK] Fix UTF-8 spelling in examples + documentation

Resolves: #84714
Releases: master
Change-Id: I5c3642800457db5f15cfa500632949f3c6cd1e6e
Reviewed-on: https://review.typo3.org/56649
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[TASK] Increase title length of filemount 61/56661/3
Guido Schmechel [Sat, 14 Apr 2018 17:59:20 +0000 (19:59 +0200)]
[TASK] Increase title length of filemount

Increase length of sys_filemount.title from 30 to 255 characters.

Resolves: #50979
Releases: master, 8.7
Change-Id: I37fc5a7877073bdfa485adb3d25dc8f2bd9b76ff
Reviewed-on: https://review.typo3.org/56661
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[TASK] Move rootPage resolving into PSR-15 middleware 64/56664/2
Benni Mack [Sun, 15 Apr 2018 07:38:15 +0000 (09:38 +0200)]
[TASK] Move rootPage resolving into PSR-15 middleware

The functionality to resolve the "domain start page" - the page ID
where a sys_domain record is found, is moved from TSFE/sys_page
into the SiteResolver middleware, making the domain start page value
available at an earlier point of a request.

Change of behaviours:
- TSFE->domainStartPage is now filled earlier than before
- TSFE->domainStartPage is now filled regardless of access checks of the
permissions of that page record, as the check is done later-on again anyways.

For the sake of completeness:
If a site is configured, this code is not executed anymore, as the site contains
the rootpage ID already anyways.

The method "TypoScriptFrontendController->findDomainRecord"
is removed, as it was marked as private and should have not been
used outside TYPO3 Core.

The method "PageRepository->getDomainStartPage" is marked
as deprecated as it is not called anymore.

Resolves: #84725
Releases: master
Change-Id: I5c420701eb463630d6286578ff582cb0e4e1dd35
Reviewed-on: https://review.typo3.org/56664
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Set exclude property for fields of tt_content 62/56662/2
Georg Ringer [Sat, 14 Apr 2018 18:07:44 +0000 (20:07 +0200)]
[TASK] Set exclude property for fields of tt_content

The exclude property is set for the following fields in the
table tt_content:

- file_collections
- filelink_size
- filelink_sorting
- filelink_sorting_direction

Resolves: #84715
Releases: master
Change-Id: I626d86d4f4f632f6c1c65e177672563a55e96663
Reviewed-on: https://review.typo3.org/56662
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
15 months ago[TASK] Cover adding image to tt_content with acceptance tests 72/56572/4
Tymoteusz Motylewski [Thu, 5 Apr 2018 15:44:46 +0000 (17:44 +0200)]
[TASK] Cover adding image to tt_content with acceptance tests

Add acceptance tests for adding image to tt_content,
when image has metadata filled or not.
As a side effect, it covers https://review.typo3.org/56438
with test.

Releases: master, 8.7
Resolves: #84631
Related: #81235

Change-Id: Idc92c14b6f44825b6082766ee92b72170680d4b3
Reviewed-on: https://review.typo3.org/56572
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Change InfoModule member function access types 51/56651/3
Jan Stockfisch [Fri, 13 Apr 2018 15:18:02 +0000 (17:18 +0200)]
[TASK] Change InfoModule member function access types

The changed methods are used in getContent(). While overriding
getContent there is no need for copying the changed methods anymore.

Resolves: #84716
Releases: master
Change-Id: I42bafea9292ab54718e166eec432a417c0213db3
Reviewed-on: https://review.typo3.org/56651
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[BUGFIX] Finishers with output must return the output 77/56377/7
Ralf Zimmermann [Tue, 20 Mar 2018 11:28:38 +0000 (12:28 +0100)]
[BUGFIX] Finishers with output must return the output

Since #83822 EXT:form makes usage of the controller context
response object which has impacts to the finisher logic which was not
treated by #83822.
Now, finishers with output can return this as string instead of setting
this directly into the response (which results in a double output).

Resolves: #84495
Releases: master, 8.7
Change-Id: Ib5accba1004b857b5447ae26dff8a689acfa6579
Reviewed-on: https://review.typo3.org/56377
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[TASK] Drop compatibility layer for lib.fluidContent 48/56648/4
Benjamin Kott [Fri, 13 Apr 2018 10:00:25 +0000 (12:00 +0200)]
[TASK] Drop compatibility layer for lib.fluidContent

Resolves: #84712
Related: #80412
Releases: master
Change-Id: Ia7b650eedcd05f45e5f542e81e5a263ec5cad0d3
Reviewed-on: https://review.typo3.org/56648
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[TASK] Remove undefined offset notices in PageLinkBuilder 87/56587/2
Tim Schreiner [Fri, 6 Apr 2018 14:15:14 +0000 (16:15 +0200)]
[TASK] Remove undefined offset notices in PageLinkBuilder

The PageLinkBuilder access some array keys that might not exist.
This leads to undefined offset notices.

Resolves: #84647
Releases: master
Change-Id: I50c44ba55364f0122bd88be851cd7c35aacd5220
Reviewed-on: https://review.typo3.org/56587
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joshua Westerheide <account@jdoubleu.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[BUGFIX] Fix exception in clipboard inside recycler folders 70/56570/5
Georg Ringer [Thu, 5 Apr 2018 15:17:22 +0000 (17:17 +0200)]
[BUGFIX] Fix exception in clipboard inside recycler folders

To avoid exceptions in a _recycler_ folder in the filelist when
using the clipboard, the image is built without an ImageViewHelper.

Resolves: #84578
Releases: master, 8.7
Change-Id: Ib596f8bdec5eba1b2cc13a0b61abd3b12f186b65
Reviewed-on: https://review.typo3.org/56570
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[BUGFIX] Increase length of sys_filemount.path 50/56650/4
Pinar Oezmen [Fri, 13 Apr 2018 14:05:56 +0000 (16:05 +0200)]
[BUGFIX] Increase length of sys_filemount.path

Increase length of sys_filemount.path from 120 to 255 chars.

Resolves: #84643
Releases: master,8.7
Change-Id: I84ff263a97e30403f5851ba731773e7ab5efde91
Reviewed-on: https://review.typo3.org/56650
Reviewed-by: Daniel Haupt <dh@schiffel.it>
Tested-by: Daniel Haupt <dh@schiffel.it>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[BUGFIX] Add missing column in database query 71/56571/5
Georg Ringer [Thu, 5 Apr 2018 15:29:47 +0000 (17:29 +0200)]
[BUGFIX] Add missing column in database query

To avoid exceptions on certain database systems the pid must be selected
as well as it is used in the order statement.

Resolves: #84303
Releases: master, 8.7
Change-Id: I1f41925d9c22c20a2fa3f080b85bb4d17d03a778
Reviewed-on: https://review.typo3.org/56571
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
15 months agoRevert "[FEATURE] Add button to select all records" 37/56637/3
Andreas Fernandez [Thu, 12 Apr 2018 12:25:17 +0000 (14:25 +0200)]
Revert "[FEATURE] Add button to select all records"

This reverts commit 7ef327081a503fc2e4e60b6d2cb413943f68469e.

The original patch does not work well with a huge record set as the
processing time per request is too high. Also, the recover button
for a single record does not work anymore, as the action is not
called properly via AJAX.

Resolves: #84700
Related: #81310
Releases: master
Change-Id: I4ba5d2982ef57c62d03f76df3ae5bf2ca3c9bdf8
Reviewed-on: https://review.typo3.org/56637
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Set extension name in Fluid context 35/56635/4
Andreas Fernandez [Thu, 12 Apr 2018 07:28:14 +0000 (09:28 +0200)]
[BUGFIX] Set extension name in Fluid context

Resolves: #84697
Related: #83987
Releases: master
Change-Id: I292b5942144c1453921ba7ce490e26209dee187f
Reviewed-on: https://review.typo3.org/56635
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
15 months ago[BUGFIX] Check if a valid logger is available in error handlers 98/56598/2
Markus Klein [Fri, 6 Apr 2018 19:39:45 +0000 (21:39 +0200)]
[BUGFIX] Check if a valid logger is available in error handlers

If the logger for some reason couldn't be created by GeneralUtility
or causes an exception or error itself the triggered ErrorHandler or
ExceptionHandler must not try to use the (non-existing) logger.

Resolves: #84646
Releases: master, 8.7
Change-Id: I46ba22bf4141c37db6530912b9e34252d1fb462c
Reviewed-on: https://review.typo3.org/56598
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Fix path to fileadmin in system report 25/56625/2
Helmut Hummel [Tue, 10 Apr 2018 13:54:47 +0000 (15:54 +0200)]
[BUGFIX] Fix path to fileadmin in system report

Resolves: #84683
Releases: master
Change-Id: I08d2fceeabd9d2d6ff52d65e35c03fc4336b8141
Reviewed-on: https://review.typo3.org/56625
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Tested-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Fix typo in documentation for change 83556 27/56627/2
Sybille Peters [Tue, 10 Apr 2018 15:26:05 +0000 (17:26 +0200)]
[BUGFIX] Fix typo in documentation for change 83556

Resolves: #84686
Releases: master
Change-Id: Ib652d17685b65004d68ade431200d8f88e87dff1
Reviewed-on: https://review.typo3.org/56627
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[TASK] Set branch alias to 9.3-dev 26/56626/3
Helmut Hummel [Tue, 10 Apr 2018 14:07:39 +0000 (16:07 +0200)]
[TASK] Set branch alias to 9.3-dev

Change-Id: Ied93632cfdf9221044577b8506ffa82f317a8756
Reviewed-on: https://review.typo3.org/56626
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
15 months ago[TASK] Set TYPO3 version to 9.3.0-dev 21/56621/2
Oliver Hader [Mon, 9 Apr 2018 20:52:42 +0000 (22:52 +0200)]
[TASK] Set TYPO3 version to 9.3.0-dev

Change-Id: I27ae8aa8699a382f2d2a71a215931f6de7425738
Reviewed-on: https://review.typo3.org/56621
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[RELEASE] Release of TYPO3 9.2.0 20/56620/2 v9.2.0
Oliver Hader [Mon, 9 Apr 2018 20:51:18 +0000 (22:51 +0200)]
[RELEASE] Release of TYPO3 9.2.0

Change-Id: Ifb953ea1058c45a59273493170b7c3e567da104b
Reviewed-on: https://review.typo3.org/56620
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Do not show sysfolders on pid 0 in sites module 04/56604/2
Mathias Schreiber [Sun, 8 Apr 2018 08:50:51 +0000 (10:50 +0200)]
[BUGFIX] Do not show sysfolders on pid 0 in sites module

Pages of the doktype “sys_folder” are no longer shown as valid entrypoints
into a site.

Resolves: #84663
Releases: master
Change-Id: I92fa2966ccf9319df52d656a30ec35a767c2dd21
Reviewed-on: https://review.typo3.org/56604
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
15 months ago[TASK] Fetch html tag "lang" attribute from site 19/56619/2
Benni Mack [Mon, 9 Apr 2018 19:03:47 +0000 (21:03 +0200)]
[TASK] Fetch html tag "lang" attribute from site

The site configuration contains the value of
the <html lang="..."> attribute and should be
set.

Resolves: #84679
Releases: master
Change-Id: Ia91fdffbb6bf9be884a0f7242ebb960d8ce17b5d
Reviewed-on: https://review.typo3.org/56619
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Do not call deprecated feedit initialize method 18/56618/2
Susanne Moog [Mon, 9 Apr 2018 18:47:02 +0000 (20:47 +0200)]
[BUGFIX] Do not call deprecated feedit initialize method

Resolves: #84677
Releases: master
Change-Id: I2d1887dd982e95e633755eed75f3bb0cdfe4d4ec
Reviewed-on: https://review.typo3.org/56618
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Minor fixes in SiteLanguage 10/56610/2
Simon Gilli [Sun, 8 Apr 2018 22:35:04 +0000 (00:35 +0200)]
[BUGFIX] Minor fixes in SiteLanguage

This patch fixes some minor issues in getter methods.

Resolves: #84670
Releases: master
Change-Id: I4123238ca17bc3c3463090117b975997ea092a7e
Reviewed-on: https://review.typo3.org/56610
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[BUGFIX] Handle empty absRefPrefix in PageLinkBuilder 16/56616/3
Oliver Hader [Mon, 9 Apr 2018 18:11:50 +0000 (20:11 +0200)]
[BUGFIX] Handle empty absRefPrefix in PageLinkBuilder

Using empty values for absRefPrefix as needle in strpos() will
throw a warning. In order to avoid that, it's now checked more
explicitly if the prefixed slash originally was absRefPrefix.

Resolves: #84676
Releases: master
Change-Id: I7515e8d283b2d68e39f7a0451432d453471088f0
Reviewed-on: https://review.typo3.org/56616
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[TASK] Move leftover 9.2 documentation RST files 17/56617/3
Benni Mack [Mon, 9 Apr 2018 18:45:56 +0000 (20:45 +0200)]
[TASK] Move leftover 9.2 documentation RST files

Resolves: #84678
Releases: master
Change-Id: Ie4f338cc5ce6200319b407b9426442d3ae843942
Reviewed-on: https://review.typo3.org/56617
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[TASK] Clean-up in site handling 02/56602/4
Susanne Moog [Sun, 8 Apr 2018 08:29:35 +0000 (10:29 +0200)]
[TASK] Clean-up in site handling

- add void return types
- add access modifiers for constants
- fix some null coalescing
- remove superfluous comments
- add newline before namespace

Resolves: #84662
Releases: master
Change-Id: I1288b27b1edbd99b0624a66a5fb01cd02547b5ec
Reviewed-on: https://review.typo3.org/56602
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[BUGFIX] Fix resource loading in composer mode 14/56614/3
Susanne Moog [Mon, 9 Apr 2018 16:04:06 +0000 (18:04 +0200)]
[BUGFIX] Fix resource loading in composer mode

Resolves: #84674
Releases: master
Change-Id: Ia3283ffcf4973e5b511a57de25cb73490916e4d2
Reviewed-on: https://review.typo3.org/56614
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[DOCS] 9.2 Docs 03/56603/2
Mathias Schreiber [Sun, 8 Apr 2018 08:32:05 +0000 (10:32 +0200)]
[DOCS] 9.2 Docs

Resolves: #DOCS
Releases: master
Change-Id: I9644f255336076f09c2c570c981549a39846e776
Reviewed-on: https://review.typo3.org/56603
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Use existing locale in site handling examples 15/56615/2
Benjamin Kott [Mon, 9 Apr 2018 17:54:36 +0000 (19:54 +0200)]
[BUGFIX] Use existing locale in site handling examples

Resolves: #84675
Releases: master
Change-Id: If8873b88bd5976729ac75b1ef876bdc9ccd2b6ae
Reviewed-on: https://review.typo3.org/56615
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Display tree hierarchy in sites module 05/56605/2
Mathias Schreiber [Sun, 8 Apr 2018 08:56:23 +0000 (10:56 +0200)]
[BUGFIX] Display tree hierarchy in sites module

The page hierarchy is now properly displayed in the sites module

Resolves: #84664
Releases: master
Change-Id: Ib390c0322042e6ddf433576df42219eeb3377525
Reviewed-on: https://review.typo3.org/56605
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[BUGFIX] Keep sorting column value for deleted records 09/56609/3
Tim Schreiner [Sun, 8 Apr 2018 15:38:49 +0000 (17:38 +0200)]
[BUGFIX] Keep sorting column value for deleted records

Keep the value for the defined sorting field when a record is
deleted. This improves the quality of restored records especially
for tt_content records when a whole page is restored.

This change might be breaking for functional tests in third-party
extensions that rely on deleted records.

Resolves: #84658
Releases: master
Change-Id: I7714d73d07a8c78da56603230bde8ede6c02d8f4
Reviewed-on: https://review.typo3.org/56609
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[BUGFIX] Remove wrong break; statement in rootline check 69/56369/2
Georg Ringer [Mon, 19 Mar 2018 19:08:07 +0000 (20:08 +0100)]
[BUGFIX] Remove wrong break; statement in rootline check

With issue #81280 a break statement has been added which breaks
the check of permissons "extend to subpage".

Resolves: #84293
Releases: master
Change-Id: I2a2735a95bd933c4890e1cf829b0d9e5650dd63c
Reviewed-on: https://review.typo3.org/56369
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Streamline upgrade wizards that install extensions 59/56559/5
Susanne Moog [Sun, 8 Apr 2018 07:50:32 +0000 (09:50 +0200)]
[TASK] Streamline upgrade wizards that install extensions

Let the adminpanel and redirect upgrade wizards make use of
the abstract wizard for installing extensions,
which includes handling composer based installations.

Resolves: #84660
Releases: master
Change-Id: Iab7f3ed44945362a315a7f4d32497c6a1c70d779
Reviewed-on: https://review.typo3.org/56559
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[BUGFIX] Fix windows loading of site configuration 01/56601/2
Susanne Moog [Sun, 8 Apr 2018 08:24:07 +0000 (10:24 +0200)]
[BUGFIX] Fix windows loading of site configuration

Due to different path handling, the path separators need
to be streamlined before using the path. Windows can handle
both / and \ but not in the same path.

Resolves: #84661
Releases: master
Change-Id: I138f0be68a9ffd017a840411bee92695b51e989d
Reviewed-on: https://review.typo3.org/56601
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Do not use deprecated $R_URI 06/56606/2
Susanne Moog [Sun, 8 Apr 2018 09:14:17 +0000 (11:14 +0200)]
[BUGFIX] Do not use deprecated $R_URI

Resolves: #84649
Releases: master
Change-Id: I98ec184e4b2d15d04515ba121babb470ac832882
Reviewed-on: https://review.typo3.org/56606
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Convert languageId to integer before passing to getLanguageById 99/56599/2
Simon Gilli [Fri, 6 Apr 2018 22:47:20 +0000 (00:47 +0200)]
[BUGFIX] Convert languageId to integer before passing to getLanguageById

ServerRequestInterface->getQueryParams() returns as string value which
has to be converted to an integer before passing it to
Site->getLanguageById().

Resolves: #84652
Related: #84581
Releases: master
Change-Id: Ibfdb2043aa5f6aee1e7e3cf92d752c7f399ef39b
Reviewed-on: https://review.typo3.org/56599
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Do not try to download extensions in composer mode 82/56582/9
Helmut Hummel [Fri, 6 Apr 2018 10:55:08 +0000 (12:55 +0200)]
[BUGFIX] Do not try to download extensions in composer mode

Upgrade wizards that download extensions from TER must
no do so in composer mode as they would create an unusable
system.

But in case the extension is found, in the system, these wizards
still activate them.

Resolves: #82318
Releases: master, 8.7
Change-Id: I5ad1fdfeb81ad809497d8a88db32325639cd236b
Reviewed-on: https://review.typo3.org/56582
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joshua Westerheide <account@jdoubleu.de>
Tested-by: Joshua Westerheide <account@jdoubleu.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[FEATURE] Introduce Site Handling 05/56505/56
Christian Kuhn [Sun, 1 Apr 2018 11:15:55 +0000 (13:15 +0200)]
[FEATURE] Introduce Site Handling

TYPO3 is famously known for the "multi-site"
functionality, allowing multiple websites running
within one TYPO3 instance.

However, configuring a multi-site had various downsides,
mostly regarding to domain/entrypoint handling for a site,
and if lots of languages were in place.

Concepts like "absRefPrefix", "baseURL", various language
related TypoScript settings, and the infamous
"L" GET parameter can now be seen obsolete.

Also, handling page-not-found or access-denied errors
have never been easier, as every admin/integrator is able
to configure this.

What TYPO3 calls a "site" is a entrypoint / pagetree,
and contains both configuration values relevant for
Backend and Frontend.

A site configuration has a unique (human-readable)
"site identifier" and the following additional values:

* Root page ID
This is a page on the root level (pid=0) or having
"is_siteroot" checked.

* The base path / base URL
This HTTP entry point e.g. https://www.mydomain.com/
 ("Base URL" / HTTP entry point,
like https://www.mydomain.com/)

-- This allows to fully identify a pagetree with
an entrypoint without having to guess during "runtime".

* The definition of all available languages for this
  pagetree, including the default language for this
  specific pagetree.

-- This includes both values for backend-related as
well as information, previously only settable via TypoScript.

This way, it is possible to have a TYPO3 installation
with 20 languages, but only using 5 languages within
one pagetree (site), using 15 different languages in
another site, while also giving meaning for all records
within one site.

A site configuration can be added or edited within the
TYPO3 Backend in a new backend module for admins,
and is then persisted in
"typo3conf/sites/site-identifier/config.yaml".

The configuration format yaml is chosen as it minimizes
the risk of doing hacks, but the concept of a SiteConfiguration
can be adapted / exchanged to be overloaded or found
in various other places in the future.

Adding a site configuration for a project has various
benefits:
- Configuration is in one place, stored in the file system
  thus, is deployable.
- Configuration can be done by an integrator/admin without
  any programming skills => in one place.
- The necessity to query sys_language is only needed when
  configuring a site.
- No need to configure TSconfig options like
  "previewDomains" and "defaultLanguageLabel" are gone.
  is
- No need to configure any TypoScript conditions, or
  even TypoScript settings related to language handling.
- It is possible to configure error handling on a per-site
  level, even language-dependant, without having to
  code or configure anything.

However, if no site is configured for a pagetree, the
previous behaviour is still in place, allowing to migrate
slowly to the sites handling, as some key functionality like
URL path handling for speaking URLs is not in place yet.

It is important to understand that adding a site
configuration comes with various restrictions:
- "sys_domain" handling is not necessary anymore, as a page
  is resolved via the domain+base URL given in the configuration
- Any previously configured TypoScript conditions based
  on L parameter do not apply anymore if a site is configured
- This also applies to any config.*language* related TypoScript
  setting.
- It is necessary to use a URI with scheme and path to configure
  a site, where as previously, TYPO3 would work without a base
  URL.
- mod_rewrite or something similar is a requirement for sites
  to work properly.

Further improvements not yet implemented:
- Ensure backend modules like Web->Page, Web->View, Web->List
and Web->Info only show records in the configured site languages.
- Enable the possibility to handle "domain entry aliases",
  also for multi-server setups with different domain names.
- Ensure the new Site module can handle "read-only" / deployable
  site configurations.
- Allow to activate a language for a site to be editable
  in the Backend but not be available in the Frontend for
  everybody.
- Handling "Storage Folder" on the top level with different
  language entries.
- Improve URL generation in frontend to skip sys_domain
  resolving.
- TypoScript conditions for [site = my-identifier] and
  [siteLanguage = dk].
- Improve proper caching for rootline resolving of pages
  without restrictions.
- Improve resolving of siteLanguage from the current request.
- Linking from one site to a page of a different site.
- Centralizing access to sys_language and sys_domain.
- Handle copying/moving of records to a different site
  with different languages and language settings.
- Handle configuration change (like deleting a language
  in the configuration - what should happen to the
  translated records?)

Next up for 9.3:
- Adding "Routers" on top of sites for URL resolving
  of pages and records.
- Handle Storage Folders on top level rootline
- Handle Mount Points

New API:
- New Entity classes "Site" and "SiteLanguage" are
  resolved as part of a PSR-15 middleware and available
  for pages in FE and BE when possible.
- A SiteFinder object is used to query Site and SiteLanguage
  objects and used in various places.
- The new PageUriBuilder allows to create links to pages
  without any relation to the current request, and
  are already in use in Frontend links and Backend preview links.
- A PageErrorHandlerInterface allows to custom error handlers
  to be introduced by extensions and configured on any site.

Site handling is considered still "under development"
until TYPO3 9 LTS, and implementation as well as the
configuration format might change in the next sprint
releases, in order to gather feedback on what is missing
in the implementation.

As a site configuration will be mandatory for TYPO3 v10.0,
some changes regarding sys_language and sys_domain will
follow.

Beware:
- Due to the definition of every record of default language
  (language=0), it might be possible to switch to locales
  for languages and get rid of the language ID.
- sys_domain won't make it any much longer.

Resolves: #84581
Releases: master
Change-Id: Iabeeb6835a98c8f5a71d502379ed63a68dfad6dd
Reviewed-on: https://review.typo3.org/56505
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Decouple adminPanel from frontend 58/56558/18
Susanne Moog [Thu, 5 Apr 2018 11:09:41 +0000 (13:09 +0200)]
[TASK] Decouple adminPanel from frontend

The admin panel has been extracted into an own extension. To enable
users to de-activate the admin panel completely, the hard coupling
between the extension and other parts of the core had to be resolved.

With this change, the initialization of both adminPanel and feedit
were moved into PSR-15 middlewares. Additionally all parameters
related to the adminPanel were removed from the FrontendBackend-
UserAuthentication.

As feedit is tigthly coupled with the adminPanel some changes had
to be made to its initialization, too.

The flow of the adminPanel initialization and rendering were
streamlined to allow modules to make use of the request object.

Due to these changes in the control flow of the application the
two existing tests were removed and new tests will be rewritten
once the API is declared as stable.

Releases: master
Resolves: #84641
Change-Id: I72beefde0d792d3f4295c45aa27204c817d2de7a
Reviewed-on: https://review.typo3.org/56558
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Fix wrong icon usage in install tool 80/56580/2
Frank Naegler [Fri, 6 Apr 2018 10:24:34 +0000 (12:24 +0200)]
[BUGFIX] Fix wrong icon usage in install tool

This patch change a icon to be consistent, the icon was misleading
and had the wrong color. Now the „add“-icon is used instead of the
„missing“-icon.

Resolves: #84642
Releases: master
Change-Id: I4563badbaab956798c9df58dce5e9e7f3c436c5a
Reviewed-on: https://review.typo3.org/56580
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[BUGFIX] Keep parameters in link browser’s upload form 92/56592/2
Andreas Fernandez [Fri, 6 Apr 2018 16:18:32 +0000 (18:18 +0200)]
[BUGFIX] Keep parameters in link browser’s upload form

Any given attribute stored in the `P` parameter is kept and attached to
the return URL of the upload form.

Resolves: #83923
Releases: master, 8.7, 7.6
Change-Id: Id6ff93f0a30691f7bde84275128a34eb479499de
Reviewed-on: https://review.typo3.org/56592
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[TASK] Add hook to upload methods in GeneralUtility 44/56544/4
Frank Naegler [Wed, 4 Apr 2018 09:18:15 +0000 (11:18 +0200)]
[TASK] Add hook to upload methods in GeneralUtility

Resolves: #84600
Releases: master, 8.7, 7.6
Change-Id: I3f4698e892c98aadb41d3e6ba4f1e974a2ca479d
Reviewed-on: https://review.typo3.org/56544
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Set correct number of arguments in MethodCallMatcher 86/56586/2
Tim Schreiner [Fri, 6 Apr 2018 14:08:49 +0000 (16:08 +0200)]
[BUGFIX] Set correct number of arguments in MethodCallMatcher

The MethodCallMatcher contains wrong argument definition for methods

* TYPO3\CMS\Core\TypoScript\TemplateService->getFromMPmap
* TYPO3\CMS\Core\TypoScript\TemplateService->initMPmap_create

Resolves: #84648
Releases: master
Change-Id: I31f68570efbbb9b6ba46e5aaccb90401cc3028fc
Reviewed-on: https://review.typo3.org/56586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Flush `l10n` cache after downloading languages 83/56583/2
Andreas Fernandez [Fri, 6 Apr 2018 11:57:28 +0000 (13:57 +0200)]
[BUGFIX] Flush `l10n` cache after downloading languages

This patch let's the Maintenance Area flush the `l10n` caches after
language packs were downloaded. Since the Install Tool uses
"hacked settings", we have to create a new instance of the `CacheManager`
to be able to operate on the mentioned cache. The same handling can be
seen in `ClearCacheService::clearAll()`.

Resolves: #84645
Releases: master
Change-Id: I221bd0d77f2991eac550316586002a8329bb36df
Reviewed-on: https://review.typo3.org/56583
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joshua Westerheide <account@jdoubleu.de>
Tested-by: Joshua Westerheide <account@jdoubleu.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Only apply language constraints for "Show hidden" checkbox if neccessary 32/56532/5
Andreas Fernandez [Tue, 3 Apr 2018 19:08:02 +0000 (21:08 +0200)]
[BUGFIX] Only apply language constraints for "Show hidden" checkbox if neccessary

The checkbox "Show hidden content elements" currently checks any selected
language. This is malfunctioning in case the language "Default" is
selected in the "Language" view, as it won't affect any translation.

The patch now changes the handling to add the language constraint only if
the view renders multiple languages and any language is selected, that is
not the default language.

Resolves: #84589
Resolves: #84573
Releases: master, 8.7
Change-Id: I572d594e5828d423e67a40481f44857df79ebae9
Reviewed-on: https://review.typo3.org/56532
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Joshua Westerheide <account@jdoubleu.de>
Tested-by: Joshua Westerheide <account@jdoubleu.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Correct wrong type annotation for drawItem_footer hook 75/56575/4
Joshua Westerheide [Fri, 6 Apr 2018 07:28:58 +0000 (09:28 +0200)]
[BUGFIX] Correct wrong type annotation for drawItem_footer hook

Change-Id: I10e4061dcb54dda3460d248bc7ae436ee12103a0
Resolves: #84636
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56575
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Tested-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Fix extraction path of language packs in LanguagePackService 77/56577/6
Joshua Westerheide [Fri, 6 Apr 2018 08:51:30 +0000 (10:51 +0200)]
[BUGFIX] Fix extraction path of language packs in LanguagePackService

Due to the appended extension key an invalid directory structure was
created. The language pack ".zip" files already contain extension
directories.

Resolves: #84638
Releases: master
Related: #84131
Change-Id: I19d4fa418a5c09a88fb814fb0780e122655a24b0
Reviewed-on: https://review.typo3.org/56577
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Tested-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Move linkData() functionality in PageLinkBuilder 76/56576/5
Benni Mack [Fri, 6 Apr 2018 07:38:21 +0000 (09:38 +0200)]
[TASK] Move linkData() functionality in PageLinkBuilder

The "mother of building all links in Frontend" is moved
into PageLinkBuilder. Along with this, building a
mountPointMap is moved into the PageLinkBuilder as well,
as this is solely needed.

Existing methods are deprecated:
 * TemplateService->linkData
 * TemplateService->getFromMPmap
 * TemplateService->initMPmap_create

The existing hook is moved into PageLinkBuilder as well,
so functionality like RealURL will work the same.

Resolves: #84637
Releases: master
Change-Id: I513bd721a77ed8959f3c8b4bfc4eaa25dd05eacc
Reviewed-on: https://review.typo3.org/56576
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[TASK] Sort packages by name in Composer manifests 55/56555/4
Wouter Wolters [Wed, 4 Apr 2018 19:21:19 +0000 (21:21 +0200)]
[TASK] Sort packages by name in Composer manifests

Resolves: #84630
Releases: master, 8.7
Change-Id: Ie3af5ddd3721e546718cfa88ea219c40dc666e51
Reviewed-on: https://review.typo3.org/56555
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[TASK] Simplify frontend/backend security viewhelpers 61/56561/3
Mathias Brodala [Thu, 5 Apr 2018 12:31:10 +0000 (14:31 +0200)]
[TASK] Simplify frontend/backend security viewhelpers

This logic is already implemented in
AbstractConditionViewHelper::renderStatic().

Resolves: #84627
Releases: master
Change-Id: Iaf1fa4630fcc5df0ef22bec55d4fa15df1aa0986
Reviewed-on: https://review.typo3.org/56561
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Allow span tags in fieldInformation return 73/56573/2
Nicole Cordes [Thu, 5 Apr 2018 16:38:14 +0000 (18:38 +0200)]
[BUGFIX] Allow span tags in fieldInformation return

To be able to improve the layout of field information, the span tag is
added to the list of allowed tags in html.

Resolves: #84633
Releases: master, 8.7
Change-Id: If3a60002cb8b7a7473e96820bdb35ac9c8111bab
Reviewed-on: https://review.typo3.org/56573
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
15 months ago[TASK] Update friendsofphp/php-cs-fixer to latest version 54/56554/2
Wouter Wolters [Wed, 4 Apr 2018 17:48:25 +0000 (19:48 +0200)]
[TASK] Update friendsofphp/php-cs-fixer to latest version

Update from 2.10.2 to 2.11.1

Command used:
composer update friendsofphp/php-cs-fixer php-cs-fixer/diff

Resolves: #84619
Releases: master,8.7
Change-Id: Ic9a30c1085c0fa2140416e371ed4735032f463b0
Reviewed-on: https://review.typo3.org/56554
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Allow tables with adminOnly in cleanup task of recycler 64/56564/2
Georg Ringer [Thu, 5 Apr 2018 14:08:03 +0000 (16:08 +0200)]
[BUGFIX] Allow tables with adminOnly in cleanup task of recycler

Allow also tables with the setting 'adminOnly' to be removed with the
scheduler task of EXT:recycler.

Resolves: #84604
Releases: master, 8.7
Change-Id: I41010359bbc3aa55f88e4bb184e9effe35884a76
Reviewed-on: https://review.typo3.org/56564
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Keep UTF-8 characters unescaped in JsonView 01/56501/3
Oliver Klee [Sat, 31 Mar 2018 19:28:41 +0000 (21:28 +0200)]
[BUGFIX] Keep UTF-8 characters unescaped in JsonView

Resolves: #84572
Releases: master, 8.7
Change-Id: I7ace7322bdefcaeae5ffcc9021a5f13b4f5aeb1a
Reviewed-on: https://review.typo3.org/56501
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[TASK] Streamline HTTP Response codes 62/56562/8
Frank Naegler [Thu, 5 Apr 2018 12:57:23 +0000 (14:57 +0200)]
[TASK] Streamline HTTP Response codes

This patch streamlines all lists of HTTP response codes.

Resolves: #84626
Related: #84490
Related: #84481
Releases: master, 8.7
Change-Id: Id7d3675e5f0f07a9c8920c40f70ddd194db994d0
Reviewed-on: https://review.typo3.org/56562
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Add missing HTTP status code presets for PSR-7 responses 75/56375/2
Benjamin Franzke [Tue, 20 Mar 2018 05:12:31 +0000 (06:12 +0100)]
[TASK] Add missing HTTP status code presets for PSR-7 responses

They've been synched from the list of status codes at:
http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml

This patch also corrects some misspelled reason phrases.

Change-Id: I993d851d6ac5dc5fb2538149d1e399aed62227ad
Releases: master, 8.7
Resolves: #84490
Related: #84481
Reviewed-on: https://review.typo3.org/56375
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
15 months ago[BUGFIX] Use URI of request for „Open in new window“ 70/56370/5
Andreas Fernandez [Mon, 19 Mar 2018 19:40:29 +0000 (20:40 +0100)]
[BUGFIX] Use URI of request for „Open in new window“

Resolves: #84487
Related: #84195
Releases: master
Change-Id: I2976ea291319893b25a537715e2effbbef50ef81
Reviewed-on: https://review.typo3.org/56370
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[TASK] Make RedirectServiceTest notice free 22/56222/5
Sascha Löffler [Fri, 16 Mar 2018 13:06:57 +0000 (14:06 +0100)]
[TASK] Make RedirectServiceTest notice free

Resolves: #84339
Releases: master
Change-Id: I6457c95e033a19e0e2bfa103070e75e3d42026de
Reviewed-on: https://review.typo3.org/56222
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Render „create new content element“ wizard in modal 20/56520/3
Andreas Fernandez [Tue, 3 Apr 2018 14:11:55 +0000 (16:11 +0200)]
[BUGFIX] Render „create new content element“ wizard in modal

The "create new content element" wizard that may be triggered by using
the context menu now properly renders the wizard in a modal window.

Additionally, the patch streamlines the usage of Enum/Severity.

Resolves: #84046
Related: #75676
Releases: master
Change-Id: Id166fd5acbe19cbb969ff3d5cfef75119deb80b3
Reviewed-on: https://review.typo3.org/56520
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
15 months ago[BUGFIX] Fix the return type annotations of JsonView 99/56499/3
Oliver Klee [Sat, 31 Mar 2018 18:41:34 +0000 (20:41 +0200)]
[BUGFIX] Fix the return type annotations of JsonView

transformValue will return the argument (mixed) untransformed if it is no
array or object and thus needs to return mixed as well.

transformObject will return a string for DateTime and hence needs to have
string as an additional return type.

Resolves: #84570
Releases: master, 8.7
Change-Id: I4d73f060eebb20b6f521fa685eca99acb688c702
Reviewed-on: https://review.typo3.org/56499
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Show descriptionColumn in PageLayoutView only if not empty 50/56550/2
Georg Ringer [Wed, 4 Apr 2018 13:02:25 +0000 (15:02 +0200)]
[BUGFIX] Show descriptionColumn in PageLayoutView only if not empty

Check if there is actually content provided to build the footer of
content elements in the page module.

Resolves: #84602
Releases: master, 8.7
Change-Id: Ic2be8eed03b7ed06bc6f048f5e56854e5155615c
Reviewed-on: https://review.typo3.org/56550
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
15 months ago[BUGFIX] Add conflicts with broken sf/finder versions 41/56541/2
Helmut Hummel [Wed, 4 Apr 2018 10:11:42 +0000 (12:11 +0200)]
[BUGFIX] Add conflicts with broken sf/finder versions

A regression was introduced in symfony/finder
https://github.com/symfony/symfony/pull/26337

This caused PackageManager to not find any core packages
any more in case they were symlinked.

Composer command (after adding conflict):
composer update --lock

Resolves: #84601
Releases: 7.6, 8.7, master
Change-Id: I914c3b3c4a6c12375ebd9fe5442c3f7ff407de72
Reviewed-on: https://review.typo3.org/56541
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[TASK] Provide upgradeWizard to enable adminPanel 19/56519/4
Susanne Moog [Tue, 3 Apr 2018 13:27:15 +0000 (15:27 +0200)]
[TASK] Provide upgradeWizard to enable adminPanel

The adminpanel has been extracted to an own extension
which should be installed on upgrading to get the same
behaviour as pre-extraction.

Resolves: #84583
Releases: master
Change-Id: Ic536dc75af205ff3e7c7d261f2371fc56169cf9b
Reviewed-on: https://review.typo3.org/56519
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[TASK] Update CKEditor from 4.7.2 to 4.9.1 88/56488/5
Josef Glatz [Fri, 30 Mar 2018 06:51:14 +0000 (08:51 +0200)]
[TASK] Update CKEditor from 4.7.2 to 4.9.1

Update CKEditor to the lastest version that fixes a lot of bugs.

Release notes:
https://ckeditor.com/cke4/release-notes
https://ckeditor.com/cke4/release/CKEditor-4.7.3
https://ckeditor.com/cke4/release/CKEditor-4.8.0
https://ckeditor.com/cke4/release/CKEditor-4.9.0
https://ckeditor.com/cke4/release/CKEditor-4.9.1

@types/ckeditor has also been updated

Following commands were used to update dependencies:
- yarn add ckeditor@4.9.1 -E -D
- yarn add @types/ckeditor@0.0.46 -E -D

Resolves: #84565
Releases: master
Change-Id: I47f81e1ecafb06770e18ac83cbe2a15e904623dd
Reviewed-on: https://review.typo3.org/56488
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Try SVG first when detecting image size 21/56521/5
Anja [Tue, 3 Apr 2018 14:56:50 +0000 (16:56 +0200)]
[BUGFIX] Try SVG first when detecting image size

By processing SVG files first and falling back to IM/GM identify, output
of a 'invalid image content' error for SVG files is avoided.

Change-Id: I44a7d822b100bdc83f7afa8aa544b6f3eff194d0
Resolves: #84586
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56521
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[FEATURE] Allow setting of validation messages in form editor 78/52078/31
Ralf Zimmermann [Fri, 17 Mar 2017 11:35:01 +0000 (12:35 +0100)]
[FEATURE] Allow setting of validation messages in form editor

Add the form element property "validationErrorMessages" to allow the
definition of custom validation error messages with the help of the
form editor.

Resolves: #80124
Releases: master
Change-Id: Ic72a5adf0a943a0fae11eb4af89c66f7fa6ca00f
Reviewed-on: https://review.typo3.org/52078
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[FEATURE] Use new REST API for update checks 68/56468/17
Susanne Moog [Fri, 30 Mar 2018 12:35:55 +0000 (14:35 +0200)]
[FEATURE] Use new REST API for update checks

A new REST api for get.typo3.org was built and should be used
for update checks and additional information gathering.

With this patch the core upgrade and version service is refactored
to use the new API and an additional information in the system
informatian tool bar is displayed.

With the new API it would be possible to add change logs or
links to news for new versions easily in the future.

Additional info:
https://get.typo3.org/v1/api/doc

Resolves: #84549
Releases: master
Change-Id: I9d9c923605a853e9e676367daaa7074bff68aedb
Reviewed-on: https://review.typo3.org/56468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Provide language labels for delete modal in filelist 18/56518/2
Andreas Fernandez [Tue, 3 Apr 2018 06:40:02 +0000 (08:40 +0200)]
[BUGFIX] Provide language labels for delete modal in filelist

Resolves: #84577
Releases: master
Change-Id: Iff6cf14a745699e9fa2f8da74485e0a4ec760035
Reviewed-on: https://review.typo3.org/56518
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Show image metadata description 38/56438/2
Guido Schmechel [Thu, 22 Mar 2018 23:32:49 +0000 (00:32 +0100)]
[BUGFIX] Show image metadata description

Show the description as a placeholder when an image
is added as a reference.

Resolves: #81235
Releases: master, 8.7
Change-Id: I75363f74ba72bf4fd95b2a2e9a2a061ad250f825
Reviewed-on: https://review.typo3.org/56438
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
15 months ago[BUGFIX] Correctly deprecate globals usage in FormEngine 43/56443/4
Nicole Cordes [Sat, 24 Mar 2018 19:03:21 +0000 (20:03 +0100)]
[BUGFIX] Correctly deprecate globals usage in FormEngine

Resolves: #84530
Releases: master
Change-Id: Idb8fc143d7126840f0d964697b2a6dbe71e72cb3
Reviewed-on: https://review.typo3.org/56443
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
15 months ago[TASK] Replace validateRstFiles.sh with PHP version 94/56094/21
Sybille Peters [Sun, 11 Mar 2018 09:52:19 +0000 (10:52 +0100)]
[TASK] Replace validateRstFiles.sh with PHP version

Resolves: #84197
Releases: master,8.7
Change-Id: Ie0dcb29243a0852baa1b0de104b2e357edd0ab36
Reviewed-on: https://review.typo3.org/56094
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Fix wrong usage of $callback in ArrayUtility::filterRecursive 68/56368/7
Stephan Jorek [Mon, 19 Mar 2018 16:32:54 +0000 (17:32 +0100)]
[BUGFIX] Fix wrong usage of $callback in ArrayUtility::filterRecursive

Change closure call of callable-typed $callback in
\TYPO3\CMS\Core\Utility\ArrayUtility::filterRecursive to call_user_func().
Add test to ArrayUtilityTest to verify the correct behaviour.

Resolves: #84485
Releases: master
Change-Id: If3e2362fc7393634032f93a4f6e89e27bb5b7fc9
Reviewed-on: https://review.typo3.org/56368
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[TASK] Extract request processing from OpendocsToolbarItem 58/56358/12
Mathias Brodala [Sun, 18 Mar 2018 14:13:53 +0000 (15:13 +0100)]
[TASK] Extract request processing from OpendocsToolbarItem

Change-Id: I786353379221af8da1436b77f654779d40fa77d3
Resolves: #84412
Releases: master
Reviewed-on: https://review.typo3.org/56358
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Properly encode HTML attributes in Toolbar 82/56482/4
Frank Naegler [Thu, 29 Mar 2018 14:43:02 +0000 (16:43 +0200)]
[BUGFIX] Properly encode HTML attributes in Toolbar

Resolves: #84561
Releases: master, 8.7
Change-Id: Iacb5dbf1fc5b709acd9db1c4463a991212a26a91
Reviewed-on: https://review.typo3.org/56482
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Unify version/release in Documentation/Settings.cfg 76/56476/4
Sybille Peters [Thu, 29 Mar 2018 12:35:45 +0000 (14:35 +0200)]
[BUGFIX] Unify version/release in Documentation/Settings.cfg

Resolves: #83480
Releases: master, 8.7, 7.6
Change-Id: I87f3d692b4422b2e998076b2ef09ee65c85b8bba
Reviewed-on: https://review.typo3.org/56476
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[!!!][TASK] Aggregate validator information in class schema 61/55261/13
Alexander Schnitzler [Thu, 4 Jan 2018 10:34:42 +0000 (11:34 +0100)]
[!!!][TASK] Aggregate validator information in class schema

This is the first part of many to streamline the resolving of
validators. In this patch, the following changes:

- The class schema aggregates all the information about
  validators that are added via @validate annotations.
  As reflection is involved here, it makes sense to
  put this into the class schema generation and remove
  it from the ActionController.

- Along with this change there have been changes to the
  ValidatorResolver class. Being references only in the
  ActionController, buildMethodArgumentsValidatorConjunctions
  has been deprecated and is no longer used by the core
  itself.

- Also, the methods parseValidatorAnnotation and
  resolveValidatorObjectName have been made public as they
  are now used from outside the ValidatorResolver class.

The main achievements of this patch are getting rid of
runtime reflection by the ActionController and fetching
the necessary information about validators from the class
schema, which at this very moment, is also generated during
runtime but is cached and that cache can be warmed up in
the future. Therefore this change does also improve the
runtime performance of Extbase a bit.

This patch is considered breaking as it removes the support
for adding validators to properties of method arguments via
the following (quite unknown) semantic sugar.

/*
 * @param Model $model
 * @validate $model.property NotEmpty
 */
public function foo(Model $model){}

This possibility is quite unknown and unused in the wild and
as it eases the aggregation of validators it will be removed
without any replacement.

However, whenever a model is validated and a model validator
exists for that model, it will be registered and called
automatically. If not dealing with models but regular objects
or arrays, the recommended way is to write a custom validator
and do the validation manually in that class.

Releases: master
Resolves: #83475
Change-Id: I3c76e722fe084e8346bb27ea5ba8c7ef0f056eda
Reviewed-on: https://review.typo3.org/55261
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[TASK] Simplify modal callback handling 77/56477/2
Christian Kuhn [Thu, 29 Mar 2018 12:58:57 +0000 (14:58 +0200)]
[TASK] Simplify modal callback handling

The fix from #84499 can be simplified a bit: class
"modal-content-loaded" is not needed with the callback
solution.

Resolves: #84559
Related: #84499
Releases: master
Change-Id: I2900ecafc06579076670f8678471530d03d0b63c
Reviewed-on: https://review.typo3.org/56477
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Change the order of the AJAX Request for image cropping 69/56469/11
Giuseppe Cavallaro [Tue, 20 Mar 2018 12:41:57 +0000 (13:41 +0100)]
[BUGFIX] Change the order of the AJAX Request for image cropping

It ensures that the request will not be overwritten by the spinning icon
on fast servers.

Before the changes, the image cropping tool triggered a Console Error
"Uncaught TypeError: Cannot read property 'cropArea' of undefined at
ImageManipulation.init (ImageManipulation.js)."

Resolves: #84499
Releases: master, 8.7
Change-Id: Ic2208ba43d0976a1ba9674d68e5d861e89619d1a
Reviewed-on: https://review.typo3.org/56469
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Renaming files on non LocalDriver storages 21/55421/4
Michael Oehlhof [Sun, 21 Jan 2018 17:37:49 +0000 (18:37 +0100)]
[BUGFIX] Renaming files on non LocalDriver storages

Fixing determination of the parent folder of a file inside the
storage, so it can be used as destination for the renaming.

Resolves: #83628
Releases: master, 8.7
Change-Id: I2b905dc7ba5e3d6fa8bec2b5a728d27f3c4a3258
Reviewed-on: https://review.typo3.org/55421
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[FEATURE] Make csv delimiter configurable 15/56415/4
Guido Schmechel [Wed, 21 Mar 2018 20:35:40 +0000 (21:35 +0100)]
[FEATURE] Make csv delimiter configurable

It is now possible to control the delimiter and quote character of the
recordlist csv export.

Resolves: #84517
Releases: master
Change-Id: I47d6f7bbc4dffc83032e096e2e141714edb4e714
Reviewed-on: https://review.typo3.org/56415
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Patricia Tiedemann <pixelaeffchen@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Hide duplicate button if sys_file_meta is edited 30/56430/2
Georg Ringer [Thu, 22 Mar 2018 12:59:37 +0000 (13:59 +0100)]
[BUGFIX] Hide duplicate button if sys_file_meta is edited

Hide the button "duplicate" in the toolbar if meta data of
files is edited.

Resolves: #84270
Releases: master
Change-Id: I72242ddcca6b91627fb061669861afa390dfa818
Reviewed-on: https://review.typo3.org/56430
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[FEATURE] Extract html into fluid template from edit module in admin panel 92/56392/6
Steffen Frese [Tue, 20 Mar 2018 14:33:33 +0000 (15:33 +0100)]
[FEATURE] Extract html into fluid template from edit module in admin panel

The edit module should use a fluid template instead of the old php-html
mixed data structure.

Resolves: #84291
Releases: master
Change-Id: I195a746ccbac8e75e9257b8f48a5dfa648110de6
Reviewed-on: https://review.typo3.org/56392
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[FEATURE] Use dynamic path for typo3temp/var/ 13/56413/9
Benni Mack [Wed, 21 Mar 2018 19:03:38 +0000 (20:03 +0100)]
[FEATURE] Use dynamic path for typo3temp/var/

All TYPO3 Core areas where typo3temp/var/ was directly used,
the new Environment::getVarPath() API is now used.

When running via composer or setting the environment
variable "TYPO3_PATH_APP", the folder is $projectRootPath . /var
otherwise "typo3temp/var/" as before.

Additional changes to the default naming scheme
- Cache folders are now named lower-case (Cache/Code becomes
cache/code).
- Install tool session files are stored within "var/session" instead of
"var/InstallToolSessions".
- Extension Manager files are now within "var/extensionmanager"
in a lower-cased variant
- log files are now placed into "var/log" instead of "var/logs"
- lock files are now placed into "var/lock" instead of "var/locks"

Resolves: #84545
Releases: master
Change-Id: Ifa57413cd212243387532ffb3435cfca361a582b
Reviewed-on: https://review.typo3.org/56413
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[BUGFIX] Correctly evaluate LIT:0 in TS conditions 64/56464/2
Markus Klein [Tue, 27 Mar 2018 19:59:19 +0000 (21:59 +0200)]
[BUGFIX] Correctly evaluate LIT:0 in TS conditions

Handle LIT:0 used in TypoScript conditions such that is evaluates
to '0' instead of null.
This makes comparisons for equality working.

Resolves: #84543
Releases: master, 8.7
Change-Id: I5eb16d556098179605646faf696f9defaf6195ac
Reviewed-on: https://review.typo3.org/56464
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
15 months ago[FEATURE] Add HTTPS security check to reports module 49/56349/15
Mathias Brodala [Sun, 18 Mar 2018 11:31:42 +0000 (12:31 +0100)]
[FEATURE] Add HTTPS security check to reports module

Two new interfaces are added which can be implemented
by reports and status providers to access the current
PSR-7 server request.

Change-Id: I280bee3a71d425861af197ef1e907c4f60ff003f
Resolves: #84466
Releases: master
Reviewed-on: https://review.typo3.org/56349
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[BUGFIX] Change path to label of preview pane in admin panel 18/56418/3
Tobi Kretschmann [Thu, 22 Mar 2018 07:19:04 +0000 (08:19 +0100)]
[BUGFIX] Change path to label of preview pane in admin panel

the label is moved to a separate locallang file.
Hence the method getLabel needs to get the label from the new file.

Resolves: #84519
Releases: master
Change-Id: I16a961499ad7ac9a26d2cc92a7ea3ef80413fc15
Reviewed-on: https://review.typo3.org/56418
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[BUGFIX] Fix path issue in gruntfile.js 02/56402/5
Frank Naegler [Wed, 21 Mar 2018 12:17:31 +0000 (13:17 +0100)]
[BUGFIX] Fix path issue in gruntfile.js

This patch fix a wrong path for module icon in Gruntfile.js

Resolves: #84510
Related: #84159
Releases: master
Change-Id: I89686bf3eb7611df0c0cffb16c2f660c56dfd941
Reviewed-on: https://review.typo3.org/56402
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[BUGFIX] Catch FolderDoesNotExistsException in linkvalidator 85/56385/2
Sascha Maier [Tue, 20 Mar 2018 23:08:55 +0000 (00:08 +0100)]
[BUGFIX] Catch FolderDoesNotExistsException in linkvalidator

Catch FolderDoesNotExistsException in linkvalidators checklink method,
if wrong links like file:// checked.

Resolves: #84488
Releases: master, 8.7

Change-Id: Ife1e34a638a56379fcc0fde7150c945c93a6157a
Reviewed-on: https://review.typo3.org/56385
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months ago[BUGFIX] Allow PSR-7 Uris to allow no port at all 16/56416/3
Benni Mack [Wed, 21 Mar 2018 21:23:47 +0000 (22:23 +0100)]
[BUGFIX] Allow PSR-7 Uris to allow no port at all

In order to set a PSR-7 based uri to the default port
the specs allow to set $uri->withPort(null) but our
tests and implementation restrict that.

Resolves: #84518
Releases: master, 8.7
Change-Id: Ic2c3d70fca35a767c7ed9d324eb93b30c66bbd3e
Reviewed-on: https://review.typo3.org/56416
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 months agoRevert "[BUGFIX] Test ifBlank with strlen again" 21/56421/2
Oliver Hader [Thu, 22 Mar 2018 08:40:09 +0000 (09:40 +0100)]
Revert "[BUGFIX] Test ifBlank with strlen again"

This reverts commit ac72c832b9d037c837a244b318984a6e1f4abd50.

The patch for issue #84434 introduced a different behavior for the
stdWrap.ifBlank feature. The current implementation now ignores
whitespace characters (tab, spaces, new lines, carriage return)
which was not the case in previous TYPO3 versions - as a comparison:

* TYPO3 v7: trim($content) === ''
* TYPO3 v6.2: !strlen(trim($content))
* TYPO3 v.4.5: !strlen(trim($content))
* TYPO3 v4.3: !strlen(trim($content)

Thus, the trim() part is basically missing currently. To avoid this
regression concerning the change of behavior, the change is reverted.

Related: #84434
Resolves: #84520
Releases: master, 8.7
Change-Id: I1fcbd0d249e18d06a96d481bf44a39de0662bed1
Reviewed-on: https://review.typo3.org/56421
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[TASK] Add rule "return_type_declaration" to php-cs-fixer 14/56414/5
Georg Ringer [Wed, 21 Mar 2018 19:45:15 +0000 (20:45 +0100)]
[TASK] Add rule "return_type_declaration" to php-cs-fixer

Unify the space before the colon of return type.

Resolves: #84515
Releases: master, 8.7
Change-Id: Ie107e574965f834c8fcaa8c2aa4f44f7cc41d7c5
Reviewed-on: https://review.typo3.org/56414
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[TASK] Add another fallback for youtube preview image 71/56371/3
Guido Schmechel [Mon, 19 Mar 2018 19:46:34 +0000 (20:46 +0100)]
[TASK] Add another fallback for youtube preview image

For some YouTube videos no MaxResDefaultImage is available. As a fallback
you can request the file mqdefault.jpg that has the same ratio of 16:9.

Resolves: #84483
Releases: master, 8.7
Change-Id: I31dd8b5a60a63edae7e9cc27f0049b9235fc7bd8
Reviewed-on: https://review.typo3.org/56371
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[TASK] Anonymize token in Exception handlers 86/56386/6
Mathias Schreiber [Wed, 21 Mar 2018 07:01:00 +0000 (08:01 +0100)]
[TASK] Anonymize token in Exception handlers

Log entries no longer contain specific tokens.
Instead, they are replaced with `--AnonymizedToken—`.

Resolves: #84502
Releases: master, 8.7
Change-Id: I42a8127cdccc904e8bbb82b5ea74b0e3d012586f
Reviewed-on: https://review.typo3.org/56386
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>