Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Fix functional tests for EXT:extbase on PostgreSQL 33/51733/4
Morton Jonuschat [Fri, 17 Feb 2017 09:03:43 +0000 (01:03 -0800)]
[BUGFIX] Fix functional tests for EXT:extbase on PostgreSQL

Fix ExpressionBuilder::inSet() to allow working with columns
on a seondary table on Non-MySQL databases. Fix the usage of
inSet() within Typo3DbQueryParser to properly quote the table
identifier and ensure that all places that use inSet() use it
to compare a string value or a field on a table.

Fix assertions to take string/int differences into account and
ensure consistent order when asserting lists of records.

Change-Id: I9fecd228cde1a7d5a6202702616d806b4354eb4f
Resolves: #79796
Releases: master
Reviewed-on: https://review.typo3.org/51733
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix functional tests for EXT:indexed_search on PostgreSQL 65/51765/2
Morton Jonuschat [Mon, 20 Feb 2017 05:21:30 +0000 (21:21 -0800)]
[BUGFIX] Fix functional tests for EXT:indexed_search on PostgreSQL

MySQL has support for backslash escape sequences. Change the tests
to have the expected results without the additional escaping and
add the additional slashes to the expected result if the database
platform running the tests is MySQL.

Change-Id: Ib2e30e95db507501aaea095eb3764a0d37135ec9
Resolves: #79799
Releases: master
Reviewed-on: https://review.typo3.org/51765
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
2 years ago[BUGFIX] Fix deleting file from context menu 68/51768/2
Tymoteusz Motylewski [Mon, 20 Feb 2017 11:15:13 +0000 (12:15 +0100)]
[BUGFIX] Fix deleting file from context menu

Since context menu refactoring the file deletion
did not work.
This patch fixes the issue, by adding missing line in JS.

Resolves: #79916
Releases: master
Change-Id: I939f153aa1d5eae22f821ede98329774e63a3757
Reviewed-on: https://review.typo3.org/51768
Reviewed-by: Malte Koitka <malte@cytrus.de>
Tested-by: Malte Koitka <malte@cytrus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix functional tests for EXT:frontend on PostgreSQL 64/51764/2
Morton Jonuschat [Mon, 20 Feb 2017 05:09:01 +0000 (21:09 -0800)]
[BUGFIX] Fix functional tests for EXT:frontend on PostgreSQL

Replace the MySQL specific backtick quoting with the actual quote
character in test checking for SQL fragments/quoting of fields.

Change assertions that assume integer return values from the
database driver to also accept string types using assertEquals().

Resolves: #79797
Releases: master
Change-Id: I1f78b0b65cdcceeaefa23902d14fa0988198d849
Reviewed-on: https://review.typo3.org/51764
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Skip another unstable acceptance test 67/51767/3
Christian Kuhn [Mon, 20 Feb 2017 10:18:38 +0000 (11:18 +0100)]
[TASK] Skip another unstable acceptance test

The "addAndDeletePage" acceptance test is still unstable, even with
multiple people trying to stabilize that thing already. To raise acceptance
of acceptance tests during core development, this one is skipped for now.

Resolves: #79913
Releases: master
Change-Id: I55ac9ede4b241a737046d1c0ee16618c314f9d79
Reviewed-on: https://review.typo3.org/51767
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Use new cropping API for CE preview in the BE page module 52/51752/2
Frans Saris [Sun, 19 Feb 2017 10:27:47 +0000 (11:27 +0100)]
[BUGFIX] Use new cropping API for CE preview in the BE page module

Resolves: #79854
Releases: master
Change-Id: Ib7cc81efda1c59d54ab30af00622456955cf7397
Reviewed-on: https://review.typo3.org/51752
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] L10nModeUpdater: Cast parentId to integer 57/51757/3
Andreas Fernandez [Sun, 19 Feb 2017 18:09:28 +0000 (19:09 +0100)]
[BUGFIX] L10nModeUpdater: Cast parentId to integer

To prevent PHP errors in L10nModeUpdater caused by faulty extensions
whose `transOrigPointerField` field is not an integer, the parentId is
now always cast to an int.

Resolves: #79824
Releases: master
Change-Id: I238b89b6fec476731f16807125eb89e9198f50c4
Reviewed-on: https://review.typo3.org/51757
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Enhance DataHandler translation and synchronization handling 14/51714/10
Oliver Hader [Wed, 15 Feb 2017 21:47:15 +0000 (22:47 +0100)]
[TASK] Enhance DataHandler translation and synchronization handling

* add more tests for allowLanguageSynchronization & l10n_mode=exclude
* enhance inline children synchronization for non-translatable tables
  using $GLOBALS['TCA'][$tableName]['ctrl']['origUid'] if defined
* bugfix for copying records instead of localizing them - the target
  page-id was missing
* integrate handling of l10n_mode=prefixLangTitle for cloning data
  in memory - DataHandler hooks are not process in that regard

Resolves: #79856
Releases: master
Change-Id: I7f5ef7edba9e80deba6025fe1394d10ee8e2d78c
Reviewed-on: https://review.typo3.org/51714
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Prevent division by 0 when using image file without dimensions 50/51750/5
Frans Saris [Sun, 19 Feb 2017 09:50:48 +0000 (10:50 +0100)]
[BUGFIX] Prevent division by 0 when using image file without dimensions

Resolves: #79902
Releases: master
Change-Id: I42a126369108434e33d3b00d4fe6b556592dc2c9
Reviewed-on: https://review.typo3.org/51750
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
2 years ago[BUGFIX] Fix functional tests for EXT:workspaces on PostgreSQL 31/51731/4
Morton Jonuschat [Fri, 17 Feb 2017 07:07:24 +0000 (23:07 -0800)]
[BUGFIX] Fix functional tests for EXT:workspaces on PostgreSQL

Detect errors during execution of SQL statements using the
exceptions thrown by Doctrine DBAL instead of trying to use
Connection::errorCode().

The previous code doesn't work on MySQL if an actual error
occurs since an exception would be thrown earlier in the
process and the relevant code path would not be reached.

The happy path worked before because MySQL returns 0 as the
code when a statement executed successfully while PostgreSQL
returns '00000' which PHP does not consider to be empty.

Resolves: #79801
Releases: master
Change-Id: I508966b6731d256d1edff2267669d158a8d647bf
Reviewed-on: https://review.typo3.org/51731
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Make progress of tasks in scheduler more readable 10/51710/7
Thomas Hohn [Wed, 15 Feb 2017 20:41:56 +0000 (21:41 +0100)]
[TASK] Make progress of tasks in scheduler more readable

Currently it's hard to read the progress of tasks in the
scheduler due to the combination of blue, white and light
grey. Change of background color for progress from f5f5f5
to dedede makes it more readable.

Resolves: #79844
Releases: master

Change-Id: I896e66452e3093d729522c9ca7da6b597e0451c7
Reviewed-on: https://review.typo3.org/51710
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
2 years ago[BUGFIX] Use correct check to find site root pages 56/51756/3
Georg Ringer [Sun, 19 Feb 2017 17:47:45 +0000 (18:47 +0100)]
[BUGFIX] Use correct check to find site root pages

The change #79857 introduced a wrong check to find the
site root pages. Instead of checking pid == 0, the field
is_siteroot must be used.

Resolves: #79897
Releases: master
Change-Id: Ibfff703fc9506505f860c051f65dc3d31083eb1e
Reviewed-on: https://review.typo3.org/51756
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
2 years ago[BUGFIX] RTE: Determine window object correctly 54/51754/3
Philipp Kerling [Sun, 19 Feb 2017 11:10:16 +0000 (12:10 +0100)]
[BUGFIX] RTE: Determine window object correctly

Resolves: #79904
Related: #77385
Related: #77137
Releases: master
Change-Id: I2036ecfcf380d864438d3e5480ce3aecc96b2634
Reviewed-on: https://review.typo3.org/51754
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] fsc/csc: Fix typolink parameters in parseFunc 55/51755/3
Philipp Kerling [Sun, 19 Feb 2017 11:14:11 +0000 (12:14 +0100)]
[BUGFIX] fsc/csc: Fix typolink parameters in parseFunc

This is a simple typo in the lib.parseFunc of both fluid_styled_content
and css_styled_content. The ATagParams attribute for the typolink
function needs to be written with a capital A in order to work,
otherwise all additional parameters on <a> tags will be dropped in the
rendered output.

Resolves: #79896
Releases: master
Change-Id: I54d5c18fe6934c03b97ae197aba56055394916e5
Reviewed-on: https://review.typo3.org/51755
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
2 years ago[TASK] AC tests: Change default log dir 47/51747/6
Christian Kuhn [Sat, 18 Feb 2017 21:13:38 +0000 (22:13 +0100)]
[TASK] AC tests: Change default log dir

Change acceptance tests log directories for better artifact
building in bamboo with screenshots and adapt two tests to
be less flacky.

Change-Id: Ib86531db23617f8205e5099532249653959662cf
Resolves: #79898
Releases: master
Reviewed-on: https://review.typo3.org/51747
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix assertion in Local Driver Test 41/51741/2
Sascha Egerer [Sat, 18 Feb 2017 14:44:25 +0000 (15:44 +0100)]
[BUGFIX] Fix assertion in Local Driver Test

There are 2 places in the local driver test where a
true assertion is expected. But instead of the correct usage
of `assertTrue()` the method `isTrue()` is being used which
does no assertion.

Resolves: #79891
Releases: master
Change-Id: I68f5e43cb1011dd7aadd2c67479d64810ef88bf3
Reviewed-on: https://review.typo3.org/51741
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] AC tests: Restructure styleguide field tests 43/51743/4
Christian Kuhn [Sat, 18 Feb 2017 17:28:49 +0000 (18:28 +0100)]
[TASK] AC tests: Restructure styleguide field tests

Simplify styleguide "elements basic" acceptance tests to
be easier understandable, split them into two Cest files.

Change-Id: I37ba7a043134e7b2d2291d517c6d0e6aa4c239ae
Resolves: #79893
Releases: master
Reviewed-on: https://review.typo3.org/51743
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Hide help button in create multiple pages function 36/51736/2
Gianluigi Martino [Fri, 17 Feb 2017 22:05:22 +0000 (23:05 +0100)]
[TASK] Hide help button in create multiple pages function

Hide the empty button in the create multiple pages function
if TYPO3 Manual extension is not loaded.

Resolves: #79884
Releases: master
Change-Id: Ib72ddae96512c982e634280ddf888f490289af01
Reviewed-on: https://review.typo3.org/51736
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Fix common misspellings 34/51734/4
Wouter Wolters [Fri, 17 Feb 2017 11:38:00 +0000 (12:38 +0100)]
[TASK] Fix common misspellings

Resolves: #79880
Releases: master
Change-Id: Ia4b240614ee2c1c1a220fcea7d0f7d13ad518acb
Reviewed-on: https://review.typo3.org/51734
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[CLEANUP] Initialize variables and fix invalid function calls 25/51725/2
Sascha Egerer [Thu, 16 Feb 2017 21:55:08 +0000 (22:55 +0100)]
[CLEANUP] Initialize variables and fix invalid function calls

* Initialize some uninitialized variables
* Fix invalid argument count on function calls
* Fix case typo in function call
* Fix some phpdoc issues

Resolves: #79865
Releases: master
Change-Id: I4e41940d849daa818735f75169e7cc686ee908c9
Reviewed-on: https://review.typo3.org/51725
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix functional tests for EXT:recycler on PostgreSQL 32/51732/2
Morton Jonuschat [Fri, 17 Feb 2017 07:30:29 +0000 (23:30 -0800)]
[BUGFIX] Fix functional tests for EXT:recycler on PostgreSQL

Enforce consistent ordering of deleted records.

Change-Id: Ibcb5e61c8cf848b2e25702aef3a2d4ca6bd1cfe6
Resolves: #79800
Releases: master
Reviewed-on: https://review.typo3.org/51732
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[FOLLOWUP][TASK] Move typo3/sysext/core/Build/Scripts to Build/Scripts 30/51730/3
Christian Kuhn [Fri, 17 Feb 2017 01:51:01 +0000 (02:51 +0100)]
[FOLLOWUP][TASK] Move typo3/sysext/core/Build/Scripts to Build/Scripts

Fix travis

Change-Id: I3be72d1f892167c884a4ca533dd37633139ef879
Resolves: #79869
Releases: master
Reviewed-on: https://review.typo3.org/51730
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Move typo3/sysext/core/Build/Scripts to Build/Scripts 29/51729/3
Christian Kuhn [Fri, 17 Feb 2017 01:13:04 +0000 (02:13 +0100)]
[!!!][TASK] Move typo3/sysext/core/Build/Scripts to Build/Scripts

This moves all maintenance / check / test scripts from
typo3/sysext/core/Build/Scripts to Build/Scripts.
This is possible now after the test framework extraction.
The artifical Build folder of typo3/sysext/core vanishes and
all core related integrity and code sanitation scripts are
now located next to all other main core build relevant stuff.

This patch is only breaking for core devs who executed one
of the scripts, most notably the "cglFixMyCommit.sh" script.
Path is now:

./Build/Scripts/cglFixMyCommit.sh

Change-Id: I8272d3d18c5e4164d67df8831168476f315db285
Resolves: #79869
Releases: master
Reviewed-on: https://review.typo3.org/51729
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Run acceptance tests in parallel 13/51713/7
Tymoteusz Motylewski [Wed, 15 Feb 2017 22:40:42 +0000 (23:40 +0100)]
[TASK] Run acceptance tests in parallel

Provide script for generating files with acceptance tests groups
to allow running them in parallel on different hosts. Very useful
for bamboo.

Usage:

Generating 5 dynamic group files:
./components/testing_framework/Resources/Core/Build/Scripts/splitAcceptanceTests.sh 5

Run tests of group 1:
./bin/codecept run Acceptance -g AcceptanceTests-Job-1 -c ...

Note group numbers start from 1, not 0.

Resolves: #79845
Releases: master
Change-Id: Ib74ec0b457ee927a906a77e648041ae15dc727d2
Reviewed-on: https://review.typo3.org/51713
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Initialize variable in EXT:filelist 26/51726/2
Sascha Egerer [Thu, 16 Feb 2017 22:09:31 +0000 (23:09 +0100)]
[CLEANUP] Initialize variable in EXT:filelist

Resolves: #79866
Releases: master
Change-Id: Iffb59947ae8a2790736352c473637ac184796b36
Reviewed-on: https://review.typo3.org/51726
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Fix usage of GeneralUtility::quoteJSvalue 27/51727/2
Sascha Egerer [Thu, 16 Feb 2017 22:22:54 +0000 (23:22 +0100)]
[CLEANUP] Fix usage of GeneralUtility::quoteJSvalue

The function GeneralUtility::quoteJSvalue is sometimes called
with a second parameter but it does only have on parameter.

Resolves: #79867
Releases: master
Change-Id: I994501574b798026f43a0e463a633e05ffc1cff3
Reviewed-on: https://review.typo3.org/51727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Remove superfluous initialization of UriBuilder 23/51723/4
Sascha Egerer [Thu, 16 Feb 2017 21:20:35 +0000 (22:20 +0100)]
[CLEANUP] Remove superfluous initialization of UriBuilder

The UriBuilder initialization has been added in
f5dd76ca41f70ea7ab22a2aeb1291aabefc95232 but it is not used
anywhere

Resolves: #79863
Releases: master
Change-Id: I46deb21e5466f3d068f95063034feb4da3b7f60c
Reviewed-on: https://review.typo3.org/51723
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix localization guard for "pages_language_overlay" 20/51720/2
Mathias Brodala [Thu, 16 Feb 2017 15:42:39 +0000 (16:42 +0100)]
[BUGFIX] Fix localization guard for "pages_language_overlay"

Resolves: #79859
Related: #78191
Releases: master, 7.6
Change-Id: Ia2a3ed9b1a793c1be554f73fa99362e3015313df
Reviewed-on: https://review.typo3.org/51720
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove deprecated argument htmlEscape of f:translate VH 09/51709/3
Frank Naegler [Wed, 15 Feb 2017 18:22:26 +0000 (19:22 +0100)]
[TASK] Remove deprecated argument htmlEscape of f:translate VH

Remove usage of htmlEscape from core templates, because it is deprecated since #75575

Resolves: #79842
Related: #75575
Releases: master
Change-Id: I62c53cb9cdba585f5ead920154dcef729c8c02eb
Reviewed-on: https://review.typo3.org/51709
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] Fix SQL error for single table view in list module 21/51721/3
Frank Naegler [Thu, 16 Feb 2017 17:01:33 +0000 (18:01 +0100)]
[BUGFIX] Fix SQL error for single table view in list module

This patch fixes wrong field escaping due to simple implode of fields
in case label_alt is set for select or groups fields.

Resolves: #79860
Releases: master
Change-Id: Ie0753957e387c1624824d152ac291524cfd34ccd
Reviewed-on: https://review.typo3.org/51721
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[TASK] Improve page tree in access module 19/51719/2
Georg Ringer [Thu, 16 Feb 2017 15:06:51 +0000 (16:06 +0100)]
[TASK] Improve page tree in access module

If the root page is selected, the following is improved:

- show the sitename instead of '[root-level]'
- show the world icon for the first pages (all with pid = 0)

Resolves: #79857
Releases: master
Change-Id: I449a34e356ec43f8679bb9cdcd4c790fd4701004
Reviewed-on: https://review.typo3.org/51719
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix access to non existing object 24/51724/2
Sascha Egerer [Thu, 16 Feb 2017 21:34:50 +0000 (22:34 +0100)]
[BUGFIX] Fix access to non existing object

Fix a fatal error introduced in a previous refactoring of
the code.

Resolves: #79864
Releases: master
Change-Id: Ib50052f2d7b3485da97fbe7a4ad88041bb676dad
Reviewed-on: https://review.typo3.org/51724
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Initialize variables in EXT:version 22/51722/2
Sascha Egerer [Thu, 16 Feb 2017 21:06:43 +0000 (22:06 +0100)]
[CLEANUP] Initialize variables in EXT:version

Add some missing variable initialization in EXT:version

Resolves: #79862
Releases: master
Change-Id: I97d8326675d9d90404b99e501e8756ec045c0d90
Reviewed-on: https://review.typo3.org/51722
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Improve TCA migration messages 56/51556/6
Mona Muzaffar [Mon, 6 Feb 2017 14:11:34 +0000 (15:11 +0100)]
[TASK] Improve TCA migration messages

Resolves: #79437
Releases: master
Change-Id: I5d1c64202d9e59c0a2a8e799df0576af9f6cb82d
Reviewed-on: https://review.typo3.org/51556
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix functional tests for EXT:core on PostgreSQL 64/51664/5
Morton Jonuschat [Wed, 8 Feb 2017 04:58:53 +0000 (20:58 -0800)]
[BUGFIX] Fix functional tests for EXT:core on PostgreSQL

Fix reliance on MySQLs implicit secondary ordering by uid within
DataHandler.

Reset sequenced on non-MySQL database platforms.

Sort expected results retrieved from the database and switch to using
assertEquals() to avoid string/int type differences in result rows
due to different drivers.

Change-Id: I95a8cdb81dbbdb6c4bcf2c6c9ad9f0e5f9ae44fe
Resolves: #79672
Releases: master
Reviewed-on: https://review.typo3.org/51664
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix functional tests for EXT:backend on PostgreSQL 65/51665/3
Morton Jonuschat [Wed, 8 Feb 2017 04:22:37 +0000 (20:22 -0800)]
[BUGFIX] Fix functional tests for EXT:backend on PostgreSQL

Sort expected results retrieved from the database and switch to using
assertEquals() to avoid string/int type differences in result rows
due to different drivers.

Change-Id: I65975967171c28a13c8711d352895d2969d408ea
Resolves: #79671
Releases: master
Reviewed-on: https://review.typo3.org/51665
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] UriBuilder: Do not skip empty parameters 04/51704/4
Markus Klein [Wed, 15 Feb 2017 15:55:41 +0000 (16:55 +0100)]
[BUGFIX] UriBuilder: Do not skip empty parameters

This is not the job of the uri builder to decide this.
It must simply build an URL from all given parameters.

In general, empty parameters can be intended by a dev.

Resolves: #79835
Releases: master, 7.6
Change-Id: I0ec3e7c41a78b40ecd81e52381f1d744a1e65608
Reviewed-on: https://review.typo3.org/51704
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Change namespace of testing framework 15/51715/6
Susanne Moog [Thu, 16 Feb 2017 08:13:45 +0000 (09:13 +0100)]
[TASK] Change namespace of testing framework

Change-Id: Ib8b787980d90c686457155cbb6c15cd3cd7c0d61
Releases: master
Resolves: #79851
Reviewed-on: https://review.typo3.org/51715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Ensure proper quoting of fields for PostgreSQL in JsonRenderer.ts 69/51569/3
Morton Jonuschat [Wed, 8 Feb 2017 03:49:20 +0000 (19:49 -0800)]
[BUGFIX] Ensure proper quoting of fields for PostgreSQL in JsonRenderer.ts

PostgreSQL requires mixed case column names in the database to be quoted at
all times, otherwise the name of the column will be forcefully converted to
all lowercase.

Set a constant in the testrenderer that contains the current database type
and switch the WHERE condition in JsonRenderer.ts to a properly quoted
version for PostgreSQL

Change-Id: I0b7caf4b51006bdf3bc131d995b0993504f49889
Releases: master
Resolves: #79651
Reviewed-on: https://review.typo3.org/51569
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Clean up testing framework from core deps - part 1 06/51706/6
Benni Mack [Wed, 15 Feb 2017 17:24:57 +0000 (18:24 +0100)]
[TASK] Clean up testing framework from core deps - part 1

There are some unnecessary calls to the core,
which are obviously unneeded.

Resolves: #79843
Releases: master
Change-Id: Ia86f57e56516cc30132a2360d8dc17a44e95531e
Reviewed-on: https://review.typo3.org/51706
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FOLLOWUP][TASK] Add functional test for IRRE on pages 12/51712/2
Oliver Hader [Wed, 15 Feb 2017 21:30:11 +0000 (22:30 +0100)]
[FOLLOWUP][TASK] Add functional test for IRRE on pages

* add values of pages.tx_irretutorial_hotels to assertions
* extend JSON renderer to reflect pages.tx_irretutorial_hotels

Resolves: #79829
Releases: master
Change-Id: I27ac88af79aa6cef85e8d34d22f464c62142cbed
Reviewed-on: https://review.typo3.org/51712
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] CKEditor: Avoid JS error when opening an existing link 91/51691/2
Benni Mack [Wed, 15 Feb 2017 05:47:09 +0000 (06:47 +0100)]
[BUGFIX] CKEditor: Avoid JS error when opening an existing link

When opening an existing link by double-clicking on the
a tag element in CKEditor the popup should open, however
if no additional attributes are registered, JS throws an
error.

Resolves: #79818
Releases: master
Change-Id: I9f9b838862ab76d21161d4962f75f88d70c44cdd
Reviewed-on: https://review.typo3.org/51691
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Streamline DataHandler functional tests 01/51701/4
Oliver Hader [Wed, 15 Feb 2017 15:08:48 +0000 (16:08 +0100)]
[TASK] Streamline DataHandler functional tests

Live and Workspaces share quite a lot of common test cases which however
are duplicated for each scenario. To ease the integration of new tests
for both scenarios, these superfluous redundancies are removed.

Resolves: #79833
Releases: master
Change-Id: I2ef2ee63d9c052ea5e9a5a8ddae7c63f15abf58d
Reviewed-on: https://review.typo3.org/51701
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Adjust paths for fsc static template during migration 97/51697/3
Jan Kiesewetter [Wed, 15 Feb 2017 13:40:58 +0000 (14:40 +0100)]
[BUGFIX] Adjust paths for fsc static template during migration

Resolves: #79828
Releases: master
Change-Id: Ibf3da0d9a181004340038762ef548b10883406b8
Reviewed-on: https://review.typo3.org/51697
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Split long running acceptance test into smaller pieces 60/51660/2
Tymoteusz Motylewski [Mon, 13 Feb 2017 19:02:13 +0000 (20:02 +0100)]
[TASK] Split long running acceptance test into smaller pieces

The formengine validation test is splitted into few smaller tests.

Releases: master
Resolves: #79788
Change-Id: I8a44c02e77bad9b26d33aa17a1d18f2c9edd26ff
Reviewed-on: https://review.typo3.org/51660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FOLLOWUP][TASK] Add functional test for IRRE on pages 05/51705/2
Oliver Hader [Wed, 15 Feb 2017 15:58:56 +0000 (16:58 +0100)]
[FOLLOWUP][TASK] Add functional test for IRRE on pages

* remove wrong column shift in data-set
* update reference index entries for workspaces

Resolves: #79829
Releases: master
Change-Id: I64496bf907cda7a81313c49c80419be3a798ad2e
Reviewed-on: https://review.typo3.org/51705
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Add functional test for IRRE on pages 98/51698/3
Oliver Hader [Wed, 15 Feb 2017 14:09:14 +0000 (15:09 +0100)]
[TASK] Add functional test for IRRE on pages

* add field pages.tx_irretutorial_hotels
* add one relation to tx_irretutorial_1nff_hotel
* update assertions for all scenarios

Resolves: #79829
Releases: master
Change-Id: Ic2f830ac855e1c79692b7182762795be1a893a80
Reviewed-on: https://review.typo3.org/51698
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Extend Testbase to run functionals tests with multiple DB drivers 52/51152/13
Manuel Selbach [Sun, 22 Jan 2017 06:06:55 +0000 (22:06 -0800)]
[TASK] Extend Testbase to run functionals tests with multiple DB drivers

Implement Testbase::importXmlDatabaseFixtureFinisher to handle database
platform specific cleanup tasks for functional tests. For PostgreSQL
this will update the primary key sequences to the maximum value used
in the table to avoid key errors on subsquent inserts.

This patch doesn't fix all functional test to work on PostgreSQL, this
will follow in smaller, subsequent patches as many tests currently fail
due to database rows being returned in a different order as well as
due to different return types of the databases (i.e. int vs. string)
leading to failures when using assertSame().

Releases: master
Resolves: #79650
Change-Id: I8a08fc033b638eb66ca7655fdde4f311dd5982b2
Reviewed-on: https://review.typo3.org/51152
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Code cleanup based on Psalm static analyser 79/51679/5
Wouter Wolters [Tue, 14 Feb 2017 16:59:19 +0000 (17:59 +0100)]
[TASK] Code cleanup based on Psalm static analyser

Code cleanup based on the static analyser Psalm.
https://github.com/vimeo/psalm

Resolves: #79815
Releases: master
Change-Id: I67dd33a79564b81931515f210644e980f83d3b7b
Reviewed-on: https://review.typo3.org/51679
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] FlexFormNoTabsContainer: Fix usage of array_pop() 90/51590/2
Andreas Fernandez [Wed, 8 Feb 2017 16:52:25 +0000 (17:52 +0100)]
[BUGFIX] FlexFormNoTabsContainer: Fix usage of array_pop()

PHP’s `array_pop()` requires its argument being passed as reference,
but the result of `array_keys()` is directly used.
The result of `array_keys()` is now stored into a variable which gets
passed to `array_pop()`.

Resolves: #79686
Releases: master, 7.6
Change-Id: Icda3040abefbffad64e93acf0d7ae632ccee00bf
Reviewed-on: https://review.typo3.org/51590
Reviewed-by: Armin Vieweg <armin@v.ieweg.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fluid: Register "core" namespace globally 88/51688/3
Benni Mack [Tue, 14 Feb 2017 20:23:31 +0000 (21:23 +0100)]
[TASK] Fluid: Register "core" namespace globally

The Fluid namespace "core" is now available globally, making
it obsolete to register the namespace manually in each file
any core viewhelper is necessary.

This is also a precursor for integrating Frontend Editing content
editable ViewHelpers in all places of TYPO3 Frontend when
fluid templates are in use.

Resolves: #79817
Releases: master
Change-Id: I7691107fa7c02e71b848cd8d0bb0eecdae5a8171
Reviewed-on: https://review.typo3.org/51688
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mattias Nilsson <tollepjaer@gmail.com>
Tested-by: Mattias Nilsson <tollepjaer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update file list module access in backend groups and users 82/50982/5
Nicole Cordes [Thu, 15 Dec 2016 23:51:13 +0000 (00:51 +0100)]
[TASK] Update file list module access in backend groups and users

As the file list module was renamed, backend groups and users access
lists need adjustments. This patch updates the module name and
removes the non-existing "file" module from those lists.

Resolves: #78979
Releases: master, 7.6
Change-Id: I06bd10523399f38e2a0ec6fdf5740cbfea6dd509
Reviewed-on: https://review.typo3.org/50982
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Update TYPO3 version to TYPO3 8.7-dev 74/51674/3
Wouter Wolters [Tue, 14 Feb 2017 14:37:32 +0000 (15:37 +0100)]
[TASK] Update TYPO3 version to TYPO3 8.7-dev

Resolves: #79810
Releases: master
Change-Id: I8325ad82a66d7a2c4c5028ecf63fea690c5b7ac0
Reviewed-on: https://review.typo3.org/51674
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove outdated comment 87/51687/2
Georg Ringer [Tue, 14 Feb 2017 20:16:16 +0000 (21:16 +0100)]
[TASK] Remove outdated comment

A comment in InitializeProcessedTca can be removed as
since #79059 a type is required and checked.

Resolves: #79816
Releases: master
Change-Id: Id9ecf7e15b584c20e30f4a5148f35c093d0c6923
Reviewed-on: https://review.typo3.org/51687
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Throw exception when CLI command is added twice 16/51316/4
Benni Mack [Sun, 15 Jan 2017 13:22:44 +0000 (14:22 +0100)]
[TASK] Throw exception when CLI command is added twice

If two extensions register the same command, the "last one"
wins currently.

The patch throws an exception if there is already a name
or alias with this command name.

Resolves: #79590
Releases: master
Change-Id: Iaafb97d88455077ab60689c32dda0580c47e0b47
Reviewed-on: https://review.typo3.org/51316
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Truncate long GIFBUILDER file names 05/51305/6
Thoams Oliver Moll [Fri, 13 Jan 2017 14:05:50 +0000 (15:05 +0100)]
[BUGFIX] Truncate long GIFBUILDER file names

GIFBUILDER generates file names from serialized data from
the GIFBUILDER setup (typoscript).
This can result in too long file names when the GIFBUILDER
is called with many parameters and on filesystems with
a max filename/path length.

The comment of the function fileName() states that the filename
should be shortened to 100 chars, but this doesn't happen.

This patch introduces a simple substring to enforce this limit.

Change-Id: Iaa17760bbf34fc6c01a9bc5ea8d1f8b6b242fecb
Resolves: #79301
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51305
Reviewed-by: Marco Huber <mail@marco-huber.de>
Tested-by: Marco Huber <mail@marco-huber.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Set TYPO3 version to 8.6.1-dev 73/51673/2
TYPO3 Release Team [Tue, 14 Feb 2017 14:33:13 +0000 (15:33 +0100)]
[TASK] Set TYPO3 version to 8.6.1-dev

Change-Id: I112860b52029a9df98143602ef4addaf48a488fe
Reviewed-on: https://review.typo3.org/51673
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 8.6.0 72/51672/2 8.6.0 TYPO3_8-6-0
TYPO3 Release Team [Tue, 14 Feb 2017 14:31:56 +0000 (15:31 +0100)]
[RELEASE] Release of TYPO3 8.6.0

Change-Id: I92505b77df3a6d1a8dceaf137a174aa887e08e0e
Reviewed-on: https://review.typo3.org/51672
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[BUGFIX] allowLanguageSynchronization flaws with pages_language_overlay 71/51671/2
Oliver Hader [Tue, 14 Feb 2017 14:03:14 +0000 (15:03 +0100)]
[BUGFIX] allowLanguageSynchronization flaws with pages_language_overlay

The allowLanguageSynchronization does not work correctly with the tables
pages and pages_language_overlay. This change at least provides the basic
functionality for regular non-relational values (which might work, but are
not verified with tests properly).

Resolves: #79809
Releases: master
Change-Id: Ia8402799828490e695fd7bfed1d1df51c6c43f3e
Reviewed-on: https://review.typo3.org/51671
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Finalize L10nModeUpdater for enhanced l10n_modes 46/51646/9
Oliver Hader [Sun, 12 Feb 2017 20:03:13 +0000 (21:03 +0100)]
[TASK] Finalize L10nModeUpdater for enhanced l10n_modes

L10nModeUpdater has to be adjusted to reflect all possibilities that
became available with introducing allowLanguageSynchronization and
the implicit synchronization for the exclude mode.

Instead of cloning the logic again inside the upgrade wizard, the
DataHandler and DataMapResolver is used to determine required changes
as well as performing especially relation resolving and handling.

Resolves: #79768
Releases: master
Change-Id: Id61c419fe9f6aa6fdbbe6f3d6335b0e9c1bf0693
Reviewed-on: https://review.typo3.org/51646
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Documentation for FluidStyledContent and CSSStyledContent changes 40/51640/11
Benjamin Kott [Sun, 12 Feb 2017 13:54:41 +0000 (14:54 +0100)]
[TASK] Documentation for FluidStyledContent and CSSStyledContent changes

Resolves: #79719
Related: #79622
Releases: master
Change-Id: Id4c7cd1c659df35fb1484d40d079f3d6b1074e20
Reviewed-on: https://review.typo3.org/51640
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Harden TcaMigration 68/51668/2
Christian Kuhn [Tue, 14 Feb 2017 11:29:24 +0000 (12:29 +0100)]
[BUGFIX] Harden TcaMigration

Broken TCA - if 'config' is not an array - can lead to warnings
in TcaMigration. Move a couple of lines around to suppress this.

Change-Id: I8411cd8335de6af49cbd85f821239723dc6d6c55
Resolves: #79806
Releases: master
Reviewed-on: https://review.typo3.org/51668
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Enable "show source" btn in default RTE config 70/51670/2
Benni Mack [Tue, 14 Feb 2017 11:59:13 +0000 (12:59 +0100)]
[BUGFIX] Enable "show source" btn in default RTE config

The button was accidentally removed when introducing
the configuration of the RTE via YAML.

Resolves: #79807
Releases: master
Change-Id: I083432af50279f7bc3a1e0d0d748d8ee06b31354
Reviewed-on: https://review.typo3.org/51670
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Add missing fields in functional tests fixtures 61/51661/2
Tymoteusz Motylewski [Mon, 13 Feb 2017 20:26:40 +0000 (21:26 +0100)]
[BUGFIX] Add missing fields in functional tests fixtures

Add value to the language_isocode column for sys_language fixture
and CType for tt_content fixture.

Resolves: #79790
Releases: master
Change-Id: I2d83d436c495bc2a8174527f34610880f8a0f9ea
Reviewed-on: https://review.typo3.org/51661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Thomas Löffler <thomas.loeffler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix broken svg flag 62/51662/3
Josef Glatz [Mon, 13 Feb 2017 22:13:15 +0000 (23:13 +0100)]
[BUGFIX] Fix broken svg flag

The vietnam svg flag is somewhat garbled. The external lib "region-flags"
isn't broken. It seems as if it was mutilated while adding it to the core
last time.

The broken svg icon is fixed by a re-run of `grunt svgmin` task.

Resolves: #79793
Releases: master, 7.6
Change-Id: Ic1337a1a7037fa95d739937571a1a4ed381e1dae
Reviewed-on: https://review.typo3.org/51662
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Commit compiled install.css 63/51663/2
Josef Glatz [Mon, 13 Feb 2017 22:47:08 +0000 (23:47 +0100)]
[TASK] Commit compiled install.css

Make compiling css with grunt clean again when executing.

Resolves: #79794
Releases: master
Change-Id: Iafee078446347e1de834f555439c921fc401aa98
Reviewed-on: https://review.typo3.org/51663
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Update require.js version number in bower.json 23/51623/5
Anders Kostending [Fri, 10 Feb 2017 09:21:19 +0000 (10:21 +0100)]
[TASK] Update require.js version number in bower.json

The version number of require.js should reflect the one of the
already installed version v2.3.2.

Require.js release notes:
2.3.0:
The way dependencies are found for the sugared syntax changed
slightly in #1582. It is now faster and should catch more
legitimate dependency cases. You should not notice any negative
consequences to the change, but given how important that
mechanism is, it was best to rev the minor version to 2.3.
The r.js optimizer also handles larger directory changes better.
If you are using 2.2, you are encouraged to update to 2.3.
alameda was also updated to 1.1.0 to include the same
dependency searching change as requirejs 2.3.

2.3.1:
Only one change from 2.3.0, and it is in the optimizer.
It fixes how the bundled uglifyjs declares the addFile function.
Without the fix, it causes an error in Node 0.10/0.12.
Newer versions of Node are not affected.

2.3.2:
Fixes an issue that prevented the 2.3.x optimizer from running
in Java's 8+'s jjs. There was a change in require.js and a
change in the r.js optimizer.

Resolves: #79738
Releases: master
Change-Id: I117e0809236462fb6888108f1db60d6d1b4254e9
Reviewed-on: https://review.typo3.org/51623
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[DOCS] 8.6 Documentation 41/51641/6
Mathias Schreiber [Sun, 12 Feb 2017 15:22:10 +0000 (16:22 +0100)]
[DOCS] 8.6 Documentation

Update and proofread 8.6 docs

Resolves:
Change-Id: Ie6cf569ad331f97637cc01901e689db22abeae05
Reviewed-on: https://review.typo3.org/51641
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Added testing_framework to gitattributes export-ignore 59/51659/2
Susanne Moog [Mon, 13 Feb 2017 15:39:40 +0000 (16:39 +0100)]
[TASK] Added testing_framework to gitattributes export-ignore

As the testing framework shall be a standalone component
which will be required via composer it has been excluded
from the exported files via .gitattributes.

Change-Id: I74708a31b3848105a949268e9caa1160c59cbc30
Resolves: #79783
Releases: master
Reviewed-on: https://review.typo3.org/51659
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] DataMapProcessor does not exclude workspace versions 47/51647/2
Oliver Hader [Sun, 12 Feb 2017 20:26:58 +0000 (21:26 +0100)]
[BUGFIX] DataMapProcessor does not exclude workspace versions

DataMapProcessor, used to resolve and handle the language synchronization
feature, does not exclude workspace versions correctly. That's why it
might happen, that inline records are not correctly synchronized in the
live workspace if translations exist in any workspace.

Resolves: #79769
Releases: master
Change-Id: Id1d724ae38aeddefbe82a316624a75315d1a93f1
Reviewed-on: https://review.typo3.org/51647
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] allowLanguageSynchronization fails for 2nd level translations 44/51644/5
Oliver Hader [Sun, 12 Feb 2017 17:04:07 +0000 (18:04 +0100)]
[BUGFIX] allowLanguageSynchronization fails for 2nd level translations

2nd level translations are not considered yet with the feature to
synchronize languages either from parent or source language records.
This change modifies the creation of the language state as well as
switches "custom" states to "source" states of a new second level
translation is being created.

Resolves: #79755
Releases: master
Change-Id: I860d87a1b305966a9caa5cbd17bc5bf7229f5704
Reviewed-on: https://review.typo3.org/51644
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix wrong path handling in DocumentationFile 37/51637/2
Nicole Cordes [Sat, 11 Feb 2017 16:11:39 +0000 (17:11 +0100)]
[BUGFIX] Fix wrong path handling in DocumentationFile

Currently several unit tests are failing on Windows system due to the
usage of DIRECTORY_SEPARATOR. This patch ensures unix-like paths are
used everywhere and tests are running again.

Resolves: #79759
Releases: master
Change-Id: I60d8e2c31b56fae627c59b8aa4e8fed0eb85b0a9
Reviewed-on: https://review.typo3.org/51637
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Matthes
Tested-by: Christian Matthes
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[CLEANUP] Remove unused splat operator in AreaTest 52/51652/4
Ingo Pfennigstorf [Mon, 13 Feb 2017 09:10:45 +0000 (10:10 +0100)]
[CLEANUP] Remove unused splat operator in AreaTest

This removes an unnecessary splat operator in the AreaTest.

Resolves: #79775
Releases: master
Change-Id: Ife0ba8c75780552737761f8b0ca97ffc0fe83c51
Reviewed-on: https://review.typo3.org/51652
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[FOLLOWUP][TASK] DatabaseSessionBackend: Pass on DB exception information 58/51658/2
Markus Klein [Mon, 13 Feb 2017 15:20:19 +0000 (16:20 +0100)]
[FOLLOWUP][TASK] DatabaseSessionBackend: Pass on DB exception information

Shorten exception messages.

Resolves: #79781
Releases: master
Change-Id: I4b16c02c4f74dc667e0ce7f5baf525e50c49234a
Reviewed-on: https://review.typo3.org/51658
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] FormEngineValidation on speed 43/51643/2
Frank Naegler [Sun, 12 Feb 2017 16:10:50 +0000 (17:10 +0100)]
[TASK] FormEngineValidation on speed

This patch removes the setTimeout hacks from FormEngineValidation.js.
Since the removal of ExtJS from FormEngine this hacky solution could be
removed and speed up the FormEngine validation process.

Resolves: #79765
Releases: master
Change-Id: I18f38a1641ea7916844cd464da3f31ad0fc22517
Reviewed-on: https://review.typo3.org/51643
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] DatabaseSessionBackend: Pass on DB exception information 57/51657/2
Markus Klein [Mon, 13 Feb 2017 15:20:19 +0000 (16:20 +0100)]
[TASK] DatabaseSessionBackend: Pass on DB exception information

We add the original message from the DBAL exception to our custom
message in the session backend exception.

Resolves: #79781
Releases: master
Change-Id: I8aec6ba5dcee097f65d4f06916e158092fa31f04
Reviewed-on: https://review.typo3.org/51657
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] EXT:form - add renderRenderable ViewHelper for hidden elements 54/51654/2
Ralf Zimmermann [Mon, 13 Feb 2017 12:16:59 +0000 (13:16 +0100)]
[BUGFIX] EXT:form - add renderRenderable ViewHelper for hidden elements

* Wrap the hidden form element with the renderRenderable ViewHelper.
* Remove the 'value' viewhelper argument and use the 'property'
  argument instead.

Resolves: #79779
Releases: master
Change-Id: I3a1a7fde0af894dbd95293f890555ed432f6bc18
Reviewed-on: https://review.typo3.org/51654
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Add composer.json to testing framework 40/51540/4
Susanne Moog [Sat, 4 Feb 2017 15:55:18 +0000 (16:55 +0100)]
[TASK] Add composer.json to testing framework

Change-Id: Iec9952e91d46796d05f87715a2e8548629acd9ab
Releases: master
Resolves: #79630
Reviewed-on: https://review.typo3.org/51540
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] ViewHelper examples: streamline case of boolean attribute values 51/51651/3
Josef Glatz [Mon, 13 Feb 2017 06:35:58 +0000 (07:35 +0100)]
[TASK] ViewHelper examples: streamline case of boolean attribute values

Streamline all boolean attribute values to lowercase within
ViewHelper inline documentation examples (like the majority is).

Resolves: #79773
Releases: master
Change-Id: Ic2e11120c7124cb5b1e7c1c9c795454a9335376c
Reviewed-on: https://review.typo3.org/51651
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Eliminate gremlins in image cropper 42/51642/10
Helmut Hummel [Tue, 7 Feb 2017 20:12:16 +0000 (21:12 +0100)]
[BUGFIX] Eliminate gremlins in image cropper

Refactor rendering to use two templates, a layout
and a partial to be more flexible.

Now also force the crop to be applied, even when
the editor does not open the image manipulation.

This is important when only one aspect ratio is
allowed to not allow the editor to save an invalid
state.

Eliminate several quirks in the TypeScript code,
among them:

* reset state when closing the cropper
* reset state when modal is dismissed
* correctly initialize all previews
* show correct size of crop area for big images
* avoid accidental dismiss of the modal

Last but not least add the accidentally removed form engine
wizard html fields again.

Resolves: #79764
Resolves: #79731
Resolves: #79753
Resolves: #79674

Releases: master
Change-Id: I0a24d6418d6263b00c3fbf31901fd7c67e9fc97e
Reviewed-on: https://review.typo3.org/51642
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix broken acceptance tests 48/51648/4
Tymoteusz Motylewski [Sun, 12 Feb 2017 21:40:32 +0000 (22:40 +0100)]
[BUGFIX] Fix broken acceptance tests

Acceptance tests for Template module are fixed
- seems that element with #ts-overview is not rendered any more
  when showing table on installation root (pid 0)
- the correct id of the site root ("styleguide TCA demo") is #extdd-3
- fix scheduler tests after tooltip were added
  (title => data-original-title)
- adapt tests after context menu refactoring

Resolves: #79771
Releases: master

Change-Id: I48879315b81267ae65ef92003c5034cbb62d576e
Reviewed-on: https://review.typo3.org/51648
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Remove l10n_mode noCopy 49/51649/2
Oliver Hader [Sun, 12 Feb 2017 21:18:52 +0000 (22:18 +0100)]
[FOLLOWUP][TASK] Remove l10n_mode noCopy

Wrong data-provider in TcaMigrationTest

Resolves: #79242
Releases: master
Change-Id: I1dd42c6c47532b61906204f3fa39b45b70a3462c
Reviewed-on: https://review.typo3.org/51649
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Improve doc header for smaller screens 02/51602/2
Georg Ringer [Thu, 9 Feb 2017 04:22:06 +0000 (05:22 +0100)]
[TASK] Improve doc header for smaller screens

To make the doc header nicer on smaller (13") screens, the following
changes are applied:

- Remove the label of the language select box
- Remove the media query

Resolves: #79701
Releases: master
Change-Id: Ie3581c37f4169c89aa72aa3a429dbdf073901e0f
Reviewed-on: https://review.typo3.org/51602
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] EXT:css_styled_content: always render all images 85/51585/5
Christer Vindberg [Wed, 8 Feb 2017 14:30:16 +0000 (15:30 +0100)]
[BUGFIX] EXT:css_styled_content: always render all images

In CssStyledContentController::render_textpic if $accessibilityMode
evaluates to false and $separateRows is also false, $allRows is never
added to $thisImages. This causes images to not be outputted
to the frontend.

Resolves: #79687
Releases: master
Change-Id: I918741aaa8724837ef87567d481072ceedf275fa
Reviewed-on: https://review.typo3.org/51585
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Streamline ext_tables.sql of compatibility ext 45/51645/2
Georg Ringer [Sun, 12 Feb 2017 19:40:40 +0000 (20:40 +0100)]
[TASK] Streamline ext_tables.sql of compatibility ext

Move the 2 fields of tt_content into one table definition.

Resolves: #79767
Releases: master
Change-Id: Ie376d095f1ebc4611635b0c487d43796ffa6fdc9
Reviewed-on: https://review.typo3.org/51645
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] TcaMigration: remove unused variable and fix typo 39/51639/2
Josef Glatz [Sun, 12 Feb 2017 10:32:17 +0000 (11:32 +0100)]
[TASK] TcaMigration: remove unused variable and fix typo

Remove unused array `$migrateFields` in `migrateRequestUpdate()`.
Fix a small typo in PHPDoc block.

Resolves: #79762
Releases: master
Change-Id: I0bb22b01c1d963ef3788bff9437343fc826861ff
Reviewed-on: https://review.typo3.org/51639
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Better index on sys_log 95/51595/6
Thomas Hohn [Wed, 8 Feb 2017 19:32:31 +0000 (20:32 +0100)]
[TASK] Better index on sys_log

Looking at the selects performed on sys_log in the core
of TYPO3 reveals that a combination of tstamp, type, userid
should giver a better performance for at least 2 SQL
statements. One performing a full-table scan - the other
approximately half a full-table scan.

On installations where a few users have created a lot of entries
in sys_log the existing indexes event and user_auth will return
too many rows compared to the new combined index.

Especially the method printLogErrorMessages in the DataHandler
benefits from this index.

Resolves: #79696
Releases: master

Change-Id: I3e115b8b5a3cc9cd134d0cc995a06488134be40d
Reviewed-on: https://review.typo3.org/51595
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Prevent exception when using link wizard in flexform input 28/51628/8
Marcus Schwemer [Fri, 10 Feb 2017 15:57:09 +0000 (16:57 +0100)]
[BUGFIX] Prevent exception when using link wizard in flexform input

The itemValue of a field might be null, which is not accepted
by getLinkExplanation(). Add a check to ensure we always pass a string.

Resolves: #79749
Releases: master
Change-Id: Ic1b80faf1e2cc8c4e4119238225c6480a66c4cdc
Reviewed-on: https://review.typo3.org/51628
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Dominique Kreemers <dominique.kreemers@icloud.com>
Tested-by: Dominique Kreemers <dominique.kreemers@icloud.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove non existing fields in FormEngine ListOfFieldsContainer 30/51630/4
Christian Kuhn [Fri, 10 Feb 2017 17:52:36 +0000 (18:52 +0100)]
[BUGFIX] Remove non existing fields in FormEngine ListOfFieldsContainer

ListOfFieldsContainer of FormEngine render construct is used
to reduce the field list of a full record down to a given list of
fields that should be rendered, only.
It is triggered for instance from the list module if only a single
field of multiple different records should be edited at once.
Until now, the container did not fully validate if a given field
actually exists within the showitem field or palette and basically
delegated the handling down to a different container which in the
end skipped that field if it was not configured in TCA for given
record type.
The patch fixes this by improving the lookup. Field rendering is
no longer delegated down to other containers if the field in
question does not exist within the 'types' section and is not
within a referenced 'palette' of given record type.

Change-Id: I750ebf7c3d87ecb381f7bbe21b63528765841277
Resolves: #79750
Releases: master
Reviewed-on: https://review.typo3.org/51630
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Only set a session anonymous if in FE context 35/51635/4
Nicole Cordes [Sat, 11 Feb 2017 15:24:36 +0000 (16:24 +0100)]
[BUGFIX] Only set a session anonymous if in FE context

The session id regeneration must not touch the sys_anonymous field
of the session record, since it only exists for FE session.
The FrontendUserAuthentication is responsible for this.

Resolves: #79757
Releases: master
Change-Id: Iefcc678b9171830b587432fa7fbbc9e77033931f
Reviewed-on: https://review.typo3.org/51635
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Remove styling from .t3js-* classes 29/51629/2
Andreas Fernandez [Fri, 10 Feb 2017 17:37:30 +0000 (18:37 +0100)]
[BUGFIX] Remove styling from .t3js-* classes

Resolves: #79729
Releases: master
Change-Id: I689e8ecd0ffa2d005931e6162fb8df5d9694da3d
Reviewed-on: https://review.typo3.org/51629
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Skip failing unit tests if preconditions not available 36/51636/2
Nicole Cordes [Sat, 11 Feb 2017 15:52:10 +0000 (16:52 +0100)]
[BUGFIX] Skip failing unit tests if preconditions not available

The unit tests for RedisSessionBackendTest rely on a class \Redis
which might not be available on all systems. Therefore the tests
should be skipped to not fail.

Resolves: #79758
Releases: master
Change-Id: Ie14911e7ba90eaffd32585c1c18d642996bbf74c
Reviewed-on: https://review.typo3.org/51636
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Allow customData in FormEngine data compiler 27/51627/3
Christian Kuhn [Fri, 10 Feb 2017 14:21:19 +0000 (15:21 +0100)]
[TASK] Allow customData in FormEngine data compiler

FormEngine is a two-fold process: First all dependent data is
compiled into main "data array" by data providers, then the render
engine uses this array to render forms.

The main data array is restricted, top level keys can not be added
or removed by single data providers.

With the recent refactorings on element level, it is now much easier
to create powerful extensions to single elements. Those may need
additional data, the rest of the FormEngine doesn't know about.

To allow custom data providers adding data that is not related
to other keys from the data array, a general "customData" is
introduced to the array. This is not filled nor used by core
related classes, but it can be used by extensions to park data here.

For v9, we will probably see another patch giving the form data groups
control about the data array structure, but that may follow later.
For v8 and v7, allowing custom data should solve the one or
the other data provider usage for now.

Change-Id: I8e88ec8f9e55eed7fc4a58590cbb5ead19baaae3
Resolves: #79747
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51627
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Artus Kolanowski <artus@ionoi.net>
Tested-by: Artus Kolanowski <artus@ionoi.net>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Update CKEDITOR to 4.6.2 84/51584/3
Anders Kostending [Wed, 8 Feb 2017 13:37:23 +0000 (14:37 +0100)]
[TASK] Update CKEDITOR to 4.6.2

New features:
* Added a new pastel color palette for the Color Button plugin and a
new config.colorButton_colorsPerRow configuration option for setting
the number of rows in the color selector.
* Added a new Azerbaijani localization.
* It is now possible to group Widget style definitions, so applying
one style disables the other.

Fixed Issues:
* [Chrome] Fixed: It is possible to type in an unfocused inline editor.
* Fixed: Font size and font family reset each other when modified at
certain positions.
* [Edge] Fixed: List items are lost when pasted from Word.
* [Edge] Fixed: A list gets pasted from Word as a set of paragraphs.
Added the config.pasteFromWord_heuristicsEdgeList configuration option.
* Fixed: Context menu items can be dragged into the editor.
* [IE] Fixed: Copy Formatting breaks the editor in Quirks Mode.
* [IE] Fixed: Copy Formatting breaks the editor in Compatibility Mode.
* Fixed: Styles applied with Copy Formatting to a single table cell
are applied to the whole table.
* Fixed: element.setSize sets incorrect editor dimensions if the
border width is represented as a fraction of pixels.
* [Firefox] Fixed: Unable to paste images as Base64 strings when
using Clipboard.
* Fixed: JavaScript error is thrown when trying to use Find in
a <div>-based editor.

Resolves: #79689
Releases: master
Change-Id: I7e610452ffbab821325cd565dd02fd7bf84fc918
Reviewed-on: https://review.typo3.org/51584
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Copying a record with translation and IRRE relation fails 31/51631/3
Oliver Hader [Fri, 10 Feb 2017 18:07:16 +0000 (19:07 +0100)]
[BUGFIX] Copying a record with translation and IRRE relation fails

The data-map processing for "allowLanguageSynchronization" tries to
resolve language dependencies for IRRE child records, without doing
a check wether the the child table does support translation at all.
In a result the built database query fails.

Resolves: #79746
Releases: master
Change-Id: I846c9e47346f5a4d2eb05e3eee639ba179a06419
Reviewed-on: https://review.typo3.org/51631
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Use correct type hint for messages in install tool updates 24/51624/5
Markus Klein [Thu, 9 Feb 2017 11:35:03 +0000 (12:35 +0100)]
[CLEANUP] Use correct type hint for messages in install tool updates

The data type of customMessage has been changed to string a while ago
but the method signatures still have a mixed-type.
Normalize this over all updates to make things consistent again.

Resolves: #79739
Releases: master
Change-Id: I840cc6d217dafb1a83f0af5b7a978fdc60318d5d
Reviewed-on: https://review.typo3.org/51624
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] PageTree: Re-introduce queueing 91/51591/8
Andreas Fernandez [Wed, 8 Feb 2017 17:52:35 +0000 (18:52 +0100)]
[BUGFIX] PageTree: Re-introduce queueing

With the removal of the ExtJS state providers, the polyfill
`TYPO3ExtJSStateProviderBridge` with a limited functional subset was
introduced. Previously, changes were queued to reduce the amount of
requests, which got lost since then. This was a complex workaround in
first place and the real issue that the same data is sent *per node*
lies somewhere deep in ExtJS and was never fixed.

As we aim to get rid of the last pieces of ExtJS sooner than later, the
queueing mechanism is added again keep the load low and to worship our
servers.

Resolves: #79693
Related: #79227
Releases: master
Change-Id: Ibcccd9be183437192027cbfab634515f710728c6
Reviewed-on: https://review.typo3.org/51591
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Show record title for inline element 15/51115/2
Nicole Cordes [Wed, 4 Jan 2017 14:06:38 +0000 (15:06 +0100)]
[BUGFIX] Show record title for inline element

Currently no record titles for nested inline elements are shown. Due to
the current method to resolve a record title for an inline element
always an empty title is returned as there is the same processing as for
select fields. This patch introduces an own resolving method according to
the already resolved children attached to the current field.

Resolves: #78726
Releases: master, 7.6
Change-Id: I7f62ad843552534b36c0ccd91488c79ff796ec0c
Reviewed-on: https://review.typo3.org/51115
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Reintroduce context menu on page title in the page tree 09/51609/5
Tymoteusz Motylewski [Thu, 9 Feb 2017 14:14:19 +0000 (15:14 +0100)]
[BUGFIX] Reintroduce context menu on page title in the page tree

Since context menu refactoring https://review.typo3.org/#/c/50124/
the context was not showing when right clicking on the page title in
the page tree.

Resolves: #79710
Releases: master
Change-Id: Idcdb9a8afebe050bb0b409b7d475285d1a1d4419
Reviewed-on: https://review.typo3.org/51609
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: volker kemeter <volker@kemeter.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Upgrade to version 4.5.0 of D3.js 11/51611/5
Anders Kostending [Thu, 9 Feb 2017 15:48:05 +0000 (16:48 +0100)]
[TASK] Upgrade to version 4.5.0 of D3.js

New features/fixes:
4.4.4:
 * Fix calculation of clock skew when page is backgrounded
   before timers are scheduled.
4.5.0:
 * Add node.count.
 * Fix overlapping circles in d3.pack and d3.packSiblings.

Resolves: #79713
Releases: master
Change-Id: I1d2f4a323bddb4f25a2a5d680912e1f1bbbdb33a
Reviewed-on: https://review.typo3.org/51611
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>