Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Broken links to online TSconfig in two language labels 32/26932/2
Xavier Perseguers [Sun, 19 Jan 2014 15:47:28 +0000 (16:47 +0100)]
[BUGFIX] Broken links to online TSconfig in two language labels

Old links pointing to http://typo3.org/documentation/ should be updated
and point to the official TYPO3 documentation.

Fixes: #28808
Releases: 6.2
Change-Id: Id9943b23e5811bc2f00182111fed98cd17541fd6
Reviewed-on: https://review.typo3.org/26932
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Make use of .t3-table in EXT: wizard_sortpages 26/26926/3
Felix Kopp [Sat, 18 Jan 2014 16:59:24 +0000 (17:59 +0100)]
[TASK] Make use of .t3-table in EXT: wizard_sortpages

Use <table class="t3-table"> in backend module.
Also removes few markups and improves CGL compliancy.

Change-Id: I4f53affc0a6130965d8c3dc516ed800bc5094f50
Resolves: #55131
Releases: 6.2
Reviewed-on: https://review.typo3.org/26926
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fatal error in indexed_search 22/26922/2
Markus Klein [Sat, 18 Jan 2014 15:06:30 +0000 (16:06 +0100)]
[BUGFIX] Fatal error in indexed_search

FileContentParser misses one backslash for RuntimeException
to be in global namespace.
Only master is affected, since backports got corrected already.

Releases: 6.2
Resolves: #55128
Change-Id: I015c1236847c4963dd28f400d14a5fe97b7868e6
Reviewed-on: https://review.typo3.org/26922
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Cannot download manuals 17/26917/3
Xavier Perseguers [Sat, 18 Jan 2014 14:08:35 +0000 (15:08 +0100)]
[BUGFIX] Cannot download manuals

Since the UX renaming, it is not possible anymore to download
manuals from docs.typo3.org.

Fixes: #55126
Releases: 6.2
Change-Id: Iee5d8fda83dc9ad6b9b2ecfa668f7587a99170ff
Reviewed-on: https://review.typo3.org/26917
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Install Tool: System Information shows empty values 11/24611/3
Philipp Gampe [Fri, 11 Oct 2013 22:57:37 +0000 (00:57 +0200)]
[TASK] Install Tool: System Information shows empty values

Adopt the list such that either port or socket is shown.
Print "default socket" for an empty socket definition.

Resolves: #52712
Releases: 6.2
Change-Id: I28bd59f9f66ce314d31908c3790c9f75ca5e2a44
Reviewed-on: https://review.typo3.org/24611
Reviewed-by: Markus Klein
Reviewed-by: Marcin S?gol
Tested-by: Marcin S?gol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] No placeholder attribute in backend forms 65/25365/4
Oliver Hader [Wed, 13 Nov 2013 09:44:41 +0000 (10:44 +0100)]
[BUGFIX] No placeholder attribute in backend forms

The disposal of the placeholder feature in backend forms needs
to be enabled using the mode setting "useOrOverridePlaceholder"
in TCA. However, the implementation for checking this needs to
be inverted, since it returns an empty string if it's enabled,
but should be the opposite way instead.

Fixes: #53594
Releases: 6.2, 6.1, 6.0
Change-Id: I3d3fe5ac76c05f4601860c79d7f514bffea13963
Reviewed-on: https://review.typo3.org/25365
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Hide update icon for incompatible extensions 48/25348/3
Nicole Cordes [Tue, 12 Nov 2013 22:33:50 +0000 (23:33 +0100)]
[BUGFIX] Hide update icon for incompatible extensions

Currently the update icon in extension manager is displayed every time
a higher TER version of the extension exists. But the update fails if
the TYPO3 version isn't within the extension dependencies. This patch
adds the dependency check to the isUpdateAvailable function.

Resolves: #53576
Releases: 6.2
Change-Id: I109e779037f670ab205b43cbbbb1bc16954860e6
Reviewed-on: https://review.typo3.org/25348
Reviewed-by: Philipp Gampe
Reviewed-by: Marcin S?gol
Tested-by: Marcin S?gol
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Set TYPO3 version to 6.2-dev 09/26909/2
TYPO3 Release Team [Fri, 17 Jan 2014 19:24:25 +0000 (20:24 +0100)]
[TASK] Set TYPO3 version to 6.2-dev

Change-Id: If5e62f07957ac8a288e028df769eec912d9e134b
Reviewed-on: https://review.typo3.org/26909
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.0beta4 08/26908/2 TYPO3_6-2-0beta4
TYPO3 Release Team [Fri, 17 Jan 2014 19:23:50 +0000 (20:23 +0100)]
[RELEASE] Release of TYPO3 6.2.0beta4

Change-Id: If2de3be4d0ff90088e8e94fbb63c9632b700b147
Reviewed-on: https://review.typo3.org/26908
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[TASK] Remove fixed width for Content Element Wizard tabs content container 06/26906/3
Marcin Sągol [Fri, 17 Jan 2014 16:45:54 +0000 (17:45 +0100)]
[TASK] Remove fixed width for Content Element Wizard tabs content container

When using Content Element Wizard configured to render items with
tabs their body container has fixed width of 680px. This leads
to visual problems when using some extra tabs registered - their
titles are rendered outside body content. This patch removes
fixed width and some other styles that are not needed. For example
there are some styles for tables inside tab content but items are
rendered in lists not tables so we can remove them.

Change-Id: I1d749649ffa86cd2220460f1ebf4894aca98f4bc
Resolves: #53904
Releases: 6.2
Reviewed-on: https://review.typo3.org/26906
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marcin S?gol
Tested-by: Marcin S?gol
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Handle empty tags in language pack index files 38/15138/6
Alexander Stehlik [Fri, 17 Jan 2014 09:46:44 +0000 (10:46 +0100)]
[BUGFIX] Handle empty tags in language pack index files

This patch adds a check to the L10n index parser to consider
whether the value of an XML tag is empty or contains only
spaces. In this case it is not included in the resulting array.

Resolves: #41450
Releases: 6.2, 6.1, 6.0
Change-Id: Ia17a430f3ab2d79e2f97b55feb9d3c4ee60bfb7e
Reviewed-on: https://review.typo3.org/15138
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Optimize TypoScriptParser 01/26701/21
Michiel Roos [Wed, 15 Jan 2014 15:00:23 +0000 (16:00 +0100)]
[TASK] Optimize TypoScriptParser

The code in \TYPO3\CMS\Core\TypoScript\Parser\TypoScriptParser gets called
a lot. It needs to be optimised.

* Use language constructs insted of function calls where possible
* Cleanup method descriptions and parameter defaults

Resolves: #54856
Releases: 6.2
Change-Id: Ia52b3f72393288ed8259b25743a7403260eb5d73
Reviewed-on: https://review.typo3.org/26701
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Marcin S?gol
Tested-by: Marcin S?gol
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Fix typos & grammar issues in Install Tool 96/26896/2
Georg Ringer [Fri, 17 Jan 2014 10:28:00 +0000 (11:28 +0100)]
[TASK] Fix typos & grammar issues in Install Tool

Change-Id: Iaad158d8e0a67ee839cfd346e33f9cf466620893
Resolves: #55098
Releases: 6.2
Reviewed-on: https://review.typo3.org/26896
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] BE: Make "Template Analyzer" the last menu item 94/26894/2
Benjamin Mack [Fri, 17 Jan 2014 09:40:42 +0000 (10:40 +0100)]
[TASK] BE: Make "Template Analyzer" the last menu item

During the refactoring of the tstemplate extension, the
Template Analyzer modfunc was inserted at first position
of the backend module menu. AFAIK this was a
functionality that was not desired, and confuses
existing integrators.

Releases: 6.2
Resolves: #55097
Change-Id: I153cf3076e6c31b95fa8d40996ffbf9192c48f74
Reviewed-on: https://review.typo3.org/26894
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Michael Staatz
Tested-by: Michael Staatz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Use system locale when indexing external documents 12/5312/15
Jigal van Hemert [Sun, 25 Sep 2011 09:58:14 +0000 (11:58 +0200)]
[BUGFIX] Use system locale when indexing external documents

If paths or filenames of external documents contain utf-8 characters the
system locale must be used. Functions like escapeshellarg and basename are
locale aware.

Change-Id: I50a73a42d60de569c63e5ba27ad6a6a3a66fd6c8
Fixes: #30244
Releases: 4.5, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/5312
Reviewed-by: Markus Klein
Reviewed-by: Sebastian Fischer
Reviewed-by: Xavier Perseguers
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] PackageManager no cache if TYPO3 dir has symlinks 38/26838/2
Alexander Opitz [Wed, 15 Jan 2014 14:10:38 +0000 (15:10 +0100)]
[BUGFIX] PackageManager no cache if TYPO3 dir has symlinks

In the PackageManager cache file is a validation of the actual file
path to the file path the cache was last generated. This was written
to invalidate the cache if someone moves TYPO3 around. This comparison
fails on symlinks in path. As you need to clear the complete cache
after moving the typo3 directory for other purposes and as this is no
real use case, we can remove this line.

Resolves: #55022
Releases: 6.2
Change-Id: I12d0fe09a3a7e1b3aad2f08c4bcde7a337cab769
Reviewed-on: https://review.typo3.org/26838
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Deprecated function call mysql_list_dbs in dbal 90/26390/3
Ingo Schmitt [Fri, 13 Dec 2013 17:09:37 +0000 (18:09 +0100)]
[BUGFIX] Deprecated function call mysql_list_dbs in dbal

replaced mysql_list_dbs by show databases query

Resolves: #53761
Releases: 6.2
Change-Id: I2b41b19aa900ba7eef33f2a990c8c029cbc1c08c
Reviewed-on: https://review.typo3.org/26390
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Add FlashMessage API to Extbase AbstractController 31/25731/6
Nico de Haen [Thu, 28 Nov 2013 16:56:49 +0000 (17:56 +0100)]
[TASK] Add FlashMessage API to Extbase AbstractController

Flow comes with an API in AbstractController to add FlashMessages.
Introducing this API to Extbase provides a convenient way to
add new FlashMessages to the queue.
Usage in your controller: $this->addFlashMessage();

Resolves: #54036
Releases: 6.2
Change-Id: I3f6b69597d7f972054c5081d1f9e20d65b598848
Reviewed-on: https://review.typo3.org/25731
Reviewed-by: Benjamin Mack
Reviewed-by: Marcin S?gol
Tested-by: Marcin S?gol
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
5 years ago[TASK] Fix typo in Install Tool 73/26873/2
Georg Ringer [Thu, 16 Jan 2014 12:41:54 +0000 (13:41 +0100)]
[TASK] Fix typo in Install Tool

Replace 'chose' with 'choose'.

Change-Id: I5ad978009e20fa420ba888a3deabb86d0d1ae926
Resolves: #55053
Releases: 6.2
Reviewed-on: https://review.typo3.org/26873
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Use file_exists() instead of is_file() 72/26872/2
Oliver Hader [Thu, 16 Jan 2014 11:12:06 +0000 (12:12 +0100)]
[TASK] Use file_exists() instead of is_file()

is_file() checks whether a resource exists and whether it
is actually a file. There are several parts in the core,
where it is sufficient to check for the existence only,
which is faster.

Resolves: #55052
Releases: 6.2
Change-Id: I57b6d2f68dd3c1c45b603c3f194cc0c53c48e28c
Reviewed-on: https://review.typo3.org/26872
Reviewed-by: Wouter Wolters
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Oliver Klee
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years agoRevert "[BUGFIX] Assume pid 0 for global backend context" 64/26864/3
Marc Bastian Heinrichs [Wed, 15 Jan 2014 21:43:35 +0000 (22:43 +0100)]
Revert "[BUGFIX] Assume pid 0 for global backend context"

formal: the change is not marked as breaking.
functional: removing the functionality fetching the
typoscript from a auto detected page completly without
an alternative breaks all extbase backend modules using
typoscript configuration.

This reverts commit ba2386e7305e0d6e64db5cc485bc38728728ad8e

Change-Id: I0c4c10b1bd8b5d09c54743a4949cce250d962ede
Reviewed-on: https://review.typo3.org/26864
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[!!!][FEATURE] Improve caching framework by introducing groups 29/26829/8
Benjamin Mack [Wed, 15 Jan 2014 09:22:35 +0000 (10:22 +0100)]
[!!!][FEATURE] Improve caching framework by introducing groups

The current TYPO3 Core includes different types of caches. There are
system-related caches (class loading cache, configuration cache,
l10n_cache, extbase_object, extbase_reflection etc.) and
frontend-related caches (chash cache, page cache, page section
cache).

The patch introduces the possibility to group caches. The core uses
two groups "pages" with all page-related caches, and "system" that
is used for compile-time caches and configuration caches.

The new API is now used to be more flexible inside DataHandler
clear_cacheCmd without having hooks, as the Cache Manager is used
to clear all caches inside one hook.

!!! The "Clear all caches" command does not flush caches for
system-related caches anymore. Only "Clear Configuration Cache" or
inside the install tool in the backend removes all the system caches.

A new userTSconfig option is used to non-admins to be allowed to
clear the system caches.

Resolves: #54991
Releases: 6.2
Change-Id: Ie0fe134102882a1fcc5a85a0199016cdfbda08bf
Reviewed-on: https://review.typo3.org/26829
Reviewed-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Image CE rendering does not scale images 56/26556/6
Thomas Blaß [Tue, 24 Dec 2013 11:33:46 +0000 (12:33 +0100)]
[BUGFIX] Image CE rendering does not scale images

When rendering images with CssStyledContent while using the features
maxW and equalHeight at the same time, the rendering needs to pre-
calculate the target sizes. Doing this the GifBuilder is used to
determine the width and height of the file while still relying on the
being a locally reachable path. Since the introduction of FAL uids will
be present at that point and therefore this calcuation will fail.

This change extracts the width and height of the image from the
according file object which not only fixes the the mentioned issue but
will be way more performant since the values doe not need to be
derived from the filesystem.

Resolves: #45086
Releases: 6.2
Change-Id: Icb03d337bb84851a5c905a45c4941fc9d9539033
Reviewed-on: https://review.typo3.org/26556
Reviewed-by: Wouter Wolters
Reviewed-by: Frans Saris
Reviewed-by: Thomas Blaß
Tested-by: Thomas Blaß
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] Add fileSuffix option to GeneralUtility::tempnam() 50/26650/8
Frans Saris [Sun, 5 Jan 2014 16:26:57 +0000 (17:26 +0100)]
[BUGFIX] Add fileSuffix option to GeneralUtility::tempnam()

Currently it is only possible to create a
temporary file with a given prefix and without
any file extension. But for some use-cases you
need a file with a certain file extension.

This patch introduces a new optional parameter to
GeneralUtility::tempnam() to make it possible to add
e.g. a specific extension to the created file.

In addition the occurrences in core, which can benefit
from this, are adapted resulting in less orphaned
temporary files in typo3temp.

Releases: 6.2
Resolves: #54750
Change-Id: I19383bc8f6b387133bff2f4033f05b28e883d427
Reviewed-on: https://review.typo3.org/26650
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Extend TypoScriptParser test cases 42/26842/2
Oliver Hader [Wed, 15 Jan 2014 14:25:55 +0000 (15:25 +0100)]
[TASK] Extend TypoScriptParser test cases

Resolves: #55026
Releases: 6.2
Change-Id: Ia1d03b4c3db6bb224b920b7252bd68df70053515
Reviewed-on: https://review.typo3.org/26842
Reviewed-by: Oliver Klee
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Skip two tests in LocalDriverTests in PHP 5.3 45/26845/2
Steffen Ritter [Wed, 15 Jan 2014 14:32:49 +0000 (15:32 +0100)]
[TASK] Skip two tests in LocalDriverTests in PHP 5.3

For most tests in the LocalDriverTest vfsStream is used to
emulate the filesystem. This needs PHP filesystem functions
to use the stream wrappers.

For touch() this has been enabled with PHP 5.4. The reversal
conclusion is, that this does not work with PHP 5.3 which
causes failing tests there.

As a result If the PHP version is 5.3 we skip the two tests.
This is a follow-up to https://review.typo3.org/#/c/26520/

Resolves: #54230
Releases: 6.2
Change-Id: I4e92927e1d77f825bab8583318a944a8916051d5
Reviewed-on: https://review.typo3.org/26845
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Extend DB fields for be users/groups of DB/file mounts 37/26837/2
Benjamin Mack [Wed, 15 Jan 2014 14:14:56 +0000 (15:14 +0100)]
[TASK] Extend DB fields for be users/groups of DB/file mounts

The maxitems entry for be_users / be_groups fields
db/file mounts was raised in issue #55018. The DB schema of
these fields should reflect the changes as well.

Releases: 6.2
Followup to: #55018
Resolves: #55025

Change-Id: I475ed18d3210a68e476c1434fa83b0b410937c8a
Reviewed-on: https://review.typo3.org/26837
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Bring back final class name cache 21/26821/3
Helmut Hummel [Tue, 14 Jan 2014 16:34:44 +0000 (17:34 +0100)]
[BUGFIX] Bring back final class name cache

The class name needs to be determined through
a lookup in the implementation configuration
(AKA XCLASS).

This runtime cache was removed in favor of
a cache in the class loader. But this caching
behavior also changed due to the package management
API implementation.

Releases: 6.2
Resolves: #55024
Change-Id: I8dc101c0c04c88e531907fcfaf82e529af483e01
Reviewed-on: https://review.typo3.org/26821
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[!!!][TASK] Driver API has too many crosscutting concerns 20/26520/12
Steffen Ritter [Sat, 14 Dec 2013 10:33:35 +0000 (11:33 +0100)]
[!!!][TASK] Driver API has too many crosscutting concerns

The Driver within the FileAbstractionLayer is the actual
abstraction of a concrete file-system meant to unify
access to several kind of storage-systems the file data
might reside in. For each way of storing files there
has to be a driver.

Therefore a driver is solely a unique API to interact with
an underlying storage system based upon its own identifier
system.

Opposite to that, the AbstractDriver (defining our Interface)
knows about its storage, file- and folder-objects as well
as indexes. The methods within the current driver need to
implement more FAL-internal logic than one would expect from
what the driver is purposed to. As a result only a few drivers
are existing by now. In addition it's nearly impossible to
change FAL interals without touching every driver out there.

This change deals with these problems. In several steps the
current driver API has been refactored to have less dependencies
and only fullfills it's original purpose: the abstraction of a
file storage system.

The following things are considered:
   1. Change every return value which has been an object to the
      identifier and adapt the ResourceStorage accordingly.
   2. Change every method parameter being FileInterface, File,
      AbstractFile or Folder objects to a string: the identifier.
   3. Get rid of the storage as a member variable, only the uid
      of the storage is needed at two places.
   4. Remove all abstract methods from the AbstractDriver and
      put them in a newly created DriverInterface.
   5. Exchange all references to AbstractDriver to the interface.
   6. Remove unused methods, which came to light doing so.
   7. Merge addFile/removeFile and *Raw since the do the same if
      no objects are in place.
   8. Unify the creation of folder objects and how information
      is retrieved (analogue to files now).
   9. Unify and simplify the methods for retrieving folder
      contents (files / folders).
  10. Adapt the UnitTests of both classes to the changes.
      This also leads to the removal of some tests which are
      superfluous with that change.
  11. Make the DriverRegistry check the implementation of the
      newly created interface.
  12. Unify the parameter names in the methods.

Releases: 6.2
Resolves: #54230
Resolves: #54231
Change-Id: I4a51572c6a10859e6fd5f12f6cb539950444992e
Reviewed-on: https://review.typo3.org/26520
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[TASK] Document that TYPO3 is not compatible with MySQL strict mode 25/26725/3
Ernesto Baschny [Thu, 9 Jan 2014 17:11:31 +0000 (18:11 +0100)]
[TASK] Document that TYPO3 is not compatible with MySQL strict mode

Document that in the requirements section of the INSTALL.md.

Resolves: #54883
Releases: 6.2
Change-Id: Idd80528493b9920f4488e359f13fe4304ac5fe25
Reviewed-on: https://review.typo3.org/26725
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Reviewed-by: Aske Ertmann
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK][CONF] Accept other settings in [SYS][setDBinit] 69/15369/21
Alexander Stehlik [Tue, 14 Jan 2014 17:12:10 +0000 (18:12 +0100)]
[TASK][CONF] Accept other settings in [SYS][setDBinit]

Since the mysqli interface recommends setting the charset using the
mysqli API the utf8 charset will be initialized when establishing the
database connection using mysqli_set_charset().

Additionally [SYS][setDBinit] can now be set to any value or can totally
be removed. To make sure the database connection still uses the correct
encoding an additional check is added to the database connection process
that checks the MySQL character set session variables.

Finally the old default value of [SYS][setDBinit] will automatically be
removed if it is set to the old default value.

Resolves: #41596
Releases: 6.2
Change-Id: I8d0a9eba50495d52accb59627147c1c87b6a9bb5
Reviewed-on: https://review.typo3.org/15369
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Cleanup __DIR__ and require/require_once 52/19952/5
Stefan Neufeind [Thu, 14 Nov 2013 17:05:55 +0000 (18:05 +0100)]
[TASK] Cleanup __DIR__ and require/require_once

* Use __DIR__ instead of dirname(__FILE__) (since PHP 5.3.0)
* Use require_once for loading classes ("just once")

Resolves: #47203
Releases: 6.2
Change-Id: I4b5d003a0bbabd91dcc7e58081eed41b5314da3f
Reviewed-on: https://review.typo3.org/19952
Reviewed-by: Xavier Perseguers
Reviewed-by: Oliver Klee
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Pascal Dürsteler
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] FrontendContentAdapterService processes record repeatedly 86/26786/4
Steffen Ritter [Mon, 13 Jan 2014 15:40:05 +0000 (16:40 +0100)]
[TASK] FrontendContentAdapterService processes record repeatedly

The FrontendContentAdapterService rewrites records so legacy
TypoScript is able to work on the files to. To do so it queries
the objects regarding the relations and fills the properties of
the record new line separated as known from pre-6.x records.

This change adds a runtime cache, so already processed records
of are not processed again, if the next cObject for the same
record is started.

Resolves: #54953
Releases: 6.2, 6.1
Change-Id: I1f632f175075c9d85079ea83e343e35867a1fcca
Reviewed-on: https://review.typo3.org/26786
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[TASK] Allow more DB and File Mounts for BE users and BE groups 34/26834/2
Benjamin Mack [Wed, 15 Jan 2014 12:27:13 +0000 (13:27 +0100)]
[TASK] Allow more DB and File Mounts for BE users and BE groups

In big installations, more than just 25 DB mount points are needed.

Solution: Raise the default configuration to 100.

Releases: 6.2
Resolves: #55018
Change-Id: I613a90bc6c15b7642f2c6b6b6ca4ec8221838c0b
Reviewed-on: https://review.typo3.org/26834
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Correct handling of empty Backend Layouts 82/24882/5
Alexander Stehlik [Mon, 21 Oct 2013 06:49:42 +0000 (08:49 +0200)]
[BUGFIX] Correct handling of empty Backend Layouts

Since the default value of the page properties backend_layout and
backend_layout_next_level is an empty string the value in the select
item is changed from zero to an empty string for consistency.

Additionally the BackendLayoutView will treat an empty string equally
as a zero namely as a non set Backend Layout.

Resolves: #52596
Releases: 6.2
Change-Id: Ic792f748d005f5749f24a3e979b304c23320c8fa
Reviewed-on: https://review.typo3.org/24882
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Images in distributions are not shown 07/26407/5
Ernesto Baschny [Thu, 9 Jan 2014 12:52:37 +0000 (13:52 +0100)]
[BUGFIX] Images in distributions are not shown

The API of the fluid image viewhelper had changed. This makes that
change less breaking, by respecting the old order of parameters,
thus allowing subclasses to continue working as usual.

Also adds some comments in phpdoc for the parameters.

Related: #53700
Resolves: #54411
Releases: 6.2

Change-Id: I11c8ec06ee263a18abd72a12e77a25899f73b475
Reviewed-on: https://review.typo3.org/26407
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] PHP warnings in ElementBrowser 24/26824/3
Markus Klein [Tue, 14 Jan 2014 18:04:33 +0000 (19:04 +0100)]
[BUGFIX] PHP warnings in ElementBrowser

The ElementBrowser tries to access array indexes
which do not exists.
Fix this to prevent PHP warnings.

Resolves: #54995
Releases: 6.2, 6.1
Change-Id: Ief660ae535f01bc593617667ce7eb81f8cd78cd3
Reviewed-on: https://review.typo3.org/26824
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Speedup typolink root-line handling 87/26787/5
Steffen Ritter [Mon, 13 Jan 2014 18:06:53 +0000 (19:06 +0100)]
[TASK] Speedup typolink root-line handling

The link generation via typolink needs the domain record as well
as the rootline to generate the links correctly. To save
superfluous database queries some local caches are introduced.

Furthermore the rootline cache does not use all information which
is present after the database query. This information is unpacked
here, too. As a result less requests to the CacheFrontend need to
be done.

Resolves: #54959
Releases: 6.2, 6.1
Change-Id: Iea7fff4c6c624a03b75523a7352b5f9736f2d57e
Reviewed-on: https://review.typo3.org/26787
Reviewed-by: Jo Hasenau
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Folder tree in popup throws JS error 33/25633/8
Aske Ertmann [Tue, 26 Nov 2013 12:35:54 +0000 (13:35 +0100)]
[BUGFIX] Folder tree in popup throws JS error

When using the folder tree (file, and folder navigation) popup
(browse_links) a JS error occurs when opening new folders.

This is due to incorrect handling of scope.
This patch fixes the error for both RTE and normal link browser.

Change-Id: I25fa0871405e06d6fc084985b3beba6396b872ad
Resolves: #53826
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/25633
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Add defaultTypoScript to hierachyInfo 38/26738/5
Peter Niederlag [Fri, 10 Jan 2014 13:16:53 +0000 (14:16 +0100)]
[BUGFIX] Add defaultTypoScript to hierachyInfo

Fixes a problem with the TemplateAnalyzer introduced by #43540

- Always add both defaultTypoScript_setup and defaultTypoScript_constants.
- Add information for defaultTypoScript into hierarchyInfo.

Change-Id: I15ad5f268eb167d6c8f027e1891409d9ead64539
Resolves: #53352
Releases: 6.2, 6.1, 4.7
Reviewed-on: https://review.typo3.org/26738
Reviewed-by: Markus Klein
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Stefan Neufeind
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] Add SQL Index to Processed Files DB table 28/26628/5
Ingo Schmitt [Fri, 3 Jan 2014 16:03:49 +0000 (17:03 +0100)]
[BUGFIX] Add SQL Index to Processed Files DB table

Added index to original,task_type,configurationsha1
this improves performance for non-cached pages and
backend calls

Resolves: #54729
Releases: 6.2
Change-Id: I2ecfe62c64b89078da5c04ee708ea3c343d4fc9a
Reviewed-on: https://review.typo3.org/26628
Reviewed-by: Oliver Klee
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] Exception in FileMetadataOverlayAspect 14/25914/4
Georg Ringer [Tue, 3 Dec 2013 14:45:47 +0000 (15:45 +0100)]
[BUGFIX] Exception in FileMetadataOverlayAspect

It is possible that PageRepository::getRecordOverlay() returns NULL which
throws an exception as ArrayObject::exchangeArray() either needs an
array or an (array-)object.

The fix adds a small check for the Result of the PageRepository function.

Change-Id: I248125154220e6250c4a2a6fdf29759211bf214b
Resolves: #54169
Releases: 6.2
Reviewed-on: https://review.typo3.org/25914
Reviewed-by: Steffen Ritter
Reviewed-by: Oliver Klee
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Prevent double loading of session data 10/25510/10
Alexander Opitz [Tue, 19 Nov 2013 15:43:10 +0000 (16:43 +0100)]
[BUGFIX] Prevent double loading of session data

At the moment we load the session data to verify authentication and
again to verify session existence. This isn't necessary. Also removing
the session deletion if we didn't find session data.

Resolves: #53598
Releases: 6.2
Change-Id: Ibc3c4ebc5c1bbca970374172f714bddcd37b539a
Reviewed-on: https://review.typo3.org/25510
Reviewed-by: Thorsten Kahler
Tested-by: Thorsten Kahler
Reviewed-by: Wouter Wolters
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Usage of sys_lang_mode in Typo3DbBackend 32/25932/5
Georg Ringer [Wed, 4 Dec 2013 05:50:29 +0000 (06:50 +0100)]
[BUGFIX] Usage of sys_lang_mode in Typo3DbBackend

Due refactoring the property $languageMode is compared but is never
filled. The property from the querySettings has to be used.

Change-Id: I8f66a10548213513b8cc5a3a90cc219ed5f91918
Resolves: #54182
Releases: 6.2
Reviewed-on: https://review.typo3.org/25932
Reviewed-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Proper template for EXT:cshmanual 33/25933/2
Georg Ringer [Wed, 4 Dec 2013 07:15:04 +0000 (08:15 +0100)]
[TASK] Proper template for EXT:cshmanual

Use the proper template mechanism and a toolbar for the cshmanual ext to
let it look like all other backend modules.

Change-Id: I6b1a4cfe036034d09caa71a8914eed359f2da930
Resolves: #54184
Releases: 6.2
Reviewed-on: https://review.typo3.org/25933
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Update IDNA-class to 0.8.1 67/25667/2
Stefan Neufeind [Sat, 23 Nov 2013 18:20:27 +0000 (19:20 +0100)]
[TASK] Update IDNA-class to 0.8.1

Change-Id: I1aaf487c43adc7e36fa98aaf972094fa13d1e764
Resolves: #53902
Releases: 6.2
Reviewed-on: https://review.typo3.org/25667
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Fix typo in copyright notice 36/26736/2
Roland Waldner [Fri, 10 Jan 2014 12:08:26 +0000 (13:08 +0100)]
[TASK] Fix typo in copyright notice

"textfile" will be replaced by "text file"

Resolves: #54893
Releases: 6.2
Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b
Reviewed-on: https://review.typo3.org/26736
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Template dropdown doesn't refresh template title after save 66/26766/3
Torben Hansen [Mon, 13 Jan 2014 08:08:03 +0000 (09:08 +0100)]
[BUGFIX] Template dropdown doesn't refresh template title after save

Reloads the template menu after the template title has been changed.

Resolves: #51805
Releases: 6.2, 6.1
Change-Id: I5d987a3ffc6a11dfa1ebe54480c9c3b69ccc1959
Reviewed-on: https://review.typo3.org/26766
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Only variables should be passed by reference 79/26779/3
Xavier Perseguers [Mon, 13 Jan 2014 09:59:24 +0000 (10:59 +0100)]
[BUGFIX] Only variables should be passed by reference

array_shift() takes argument by reference.

Releases: 6.2
Fixes: #54933
Change-Id: I94c16bc739f36d669640701561ff94aebd63b1f5
Reviewed-on: https://review.typo3.org/26779
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix PHP warnings in PackageManager 89/26789/4
Markus Klein [Mon, 13 Jan 2014 19:49:40 +0000 (20:49 +0100)]
[BUGFIX] Fix PHP warnings in PackageManager

Resolves: #54963
Releases: 6.2
Change-Id: I58b1f6109872d6eb8059fceb1bec1af7134e84e2
Reviewed-on: https://review.typo3.org/26789
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Check for libxml bug in install tool 89/25089/11
Tomita Militaru [Thu, 31 Oct 2013 10:44:17 +0000 (12:44 +0200)]
[TASK] Check for libxml bug in install tool

Add check for libxml bug when saving special characters ">><<"
in a flexform

Resolves: #51271
Releases: 6.2
Change-Id: I5d120cdfeb9538209273c8761d017cb67256617b
Reviewed-on: https://review.typo3.org/25089
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Calculated hash of File object is never used 89/26689/5
Steffen Ritter [Wed, 8 Jan 2014 08:51:28 +0000 (09:51 +0100)]
[TASK] Calculated hash of File object is never used

The indexing pre-calculates the file hash and stores it in
the sys_file table. Sadly the getter of file objects never looks
at this again and always recalculates the hash via the driver,
which is very slow.

Resolves: #54235
Releases: 6.2, 6.1, 6.0
Change-Id: I16bfa2126031f26b8e31da8d8c0b3fc07d0217dc
Reviewed-on: https://review.typo3.org/26689
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Oliver Klee
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] Ignore dependencies of inactive packages 19/26719/5
Helmut Hummel [Thu, 9 Jan 2014 12:25:23 +0000 (13:25 +0100)]
[BUGFIX] Ignore dependencies of inactive packages

It might happen that activating or deactivating
a package throws an exception because other inactive
packages are available on the system with broken or
not fulfilled dependencies.

To solve this issue, only active packages
are regarded when resolving dependencies.

To remove a side effect from this change,
cache clearing in extension manager is
moved to a later point (see #54951).

This needs a proper fix in another change,
but makes this fix work for now.

Resolves: #54879
Releases: 6.2
Change-Id: Id81b66b2d2b6f4ba7d1c6ea2d001c271982539b3
Reviewed-on: https://review.typo3.org/26719
Reviewed-by: Thomas Maroschik
Reviewed-by: Markus Klein
Tested-by: Kasper Ligaard
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Add index to sys_file_metadata 74/26774/6
Ingo Schmitt [Mon, 13 Jan 2014 09:08:13 +0000 (10:08 +0100)]
[TASK] Add index to sys_file_metadata

Since sys_file_metadata records are enabled to be
translated the file list module is capable of metadata
translations, too. In order to directly link to edit
or create a new translation depending on wether this
language already has been translated for each file the
metadata translations are fetched from the database.

In order to improve that query this patch adds an index
including l10n_parent and sys_language_uid.

Resolves: #54927
Releases: 6.2
Change-Id: I6cc5c74505e96647c5ddd7e7ee77518176d2ba0b
Reviewed-on: https://review.typo3.org/26774
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[TASK] Update SQL definition for sys_file_storage 68/26768/8
Ingo Schmitt [Mon, 13 Jan 2014 08:18:41 +0000 (09:18 +0100)]
[TASK] Update SQL definition for sys_file_storage

There are missing indexes as well as a mismatch between the
TCA definition (and therefore actual usage) and the SQL
definition at database level.

This change
* adds combined index to deleted / hidden to speedup the
  query initializing storages in Be_UserAuth

* changes SQL definition for field "name" to match their
  usage in TCA

Resolves: #54923
Releases: 6.2
Change-Id: I86f345a941802304ed7fbe29d00ae38130f8e5d2
Reviewed-on: https://review.typo3.org/26768
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Oliver Klee
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[TASK] Add index to sys_category 75/26775/3
Ingo Schmitt [Mon, 13 Jan 2014 09:28:37 +0000 (10:28 +0100)]
[TASK] Add index to sys_category

All page, content and file-records TCEforms render a category
tree in order to assign these. The tree building executes the
same queries quite often. In order to optimize these queries
this change adds
* an index "category_parent" to sys_category.parent in order
  to for the parent category while index "parent" currently
  indexes the pid the record is stored.

* a combined index "category_list" to columns pid, deleted
  and sys_language_uid.

Resolves: #54929
Releases: 6.2
Change-Id: I1d42ba7171dc1213d5d5559ae190092acaa57464
Reviewed-on: https://review.typo3.org/26775
Reviewed-by: Oliver Klee
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] Indexer tries to insert NULL into DB 57/26757/2
Markus Klein [Sun, 12 Jan 2014 15:57:41 +0000 (16:57 +0100)]
[BUGFIX] Indexer tries to insert NULL into DB

The Indexer of indexed_search tries to insert NULL values
into NOT NULL columns of the database.

Since #53662 NULL values are passed to the database,
hence these insert statements now fail.

Resolves: #54917
Releases: 6.2
Change-Id: Ia935abe14b9c3be2062f1b38ec98fb63921a1c2f
Reviewed-on: https://review.typo3.org/26757
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Skip validation of uninitialized collections 49/25549/8
Nico de Haen [Thu, 14 Nov 2013 10:39:29 +0000 (11:39 +0100)]
[BUGFIX] Skip validation of uninitialized collections

Elements in LazyObjectStorages should not be validated,
since the values would be reconstituted from persistence anyway.
This patch adds the same behaviour as implemented in Flow and
adds the tests found in Flow (and one additional test).

Resolves: #53816
Releases: 6.2
Change-Id: I65f62a4ef6777e3678b2fdd06fc58d828bb8cb87
Reviewed-on: https://review.typo3.org/25549
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
5 years ago[BUGIFX] Drop usage of addTofeInterface parameter 45/26745/2
Francois Suter [Fri, 10 Jan 2014 16:05:24 +0000 (17:05 +0100)]
[BUGIFX] Drop usage of addTofeInterface parameter

In #54613, usage of parameter $addTofeInterface in method
ExtensionManagementUtility::addTCAcolumns() was deprecated.
However it is used in a few places of the Core.
Those calls must be modified too.

Resolves: #54899
Releases: 6.2
Change-Id: I22696cb4655578dc583edcb9cfa4693b69e228c8
Reviewed-on: https://review.typo3.org/26745
Reviewed-by: Oliver Klee
Reviewed-by: Eric Chavaillaz
Tested-by: Eric Chavaillaz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Add missing logger names 54/26754/3
Steffen Müller [Sat, 11 Jan 2014 11:14:41 +0000 (12:14 +0100)]
[BUGFIX] Add missing logger names

A logger name is mandatory to configure a particular logger.
The convention is use __CLASS__ as the logger name when
instanciating a new logger using LogManager->getLogger().

Resolves: #54909
Releases: 6.2, 6.1
Change-Id: I5dbda770ec92fd75c3aff9ed89c68c5666669b07
Reviewed-on: https://review.typo3.org/26754
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Allow empty values in start/stop filter of belog 23/26723/3
Steffen Müller [Thu, 9 Jan 2014 14:48:28 +0000 (15:48 +0100)]
[BUGFIX] Allow empty values in start/stop filter of belog

One can limit records in the backend log module to a custom period
of time using the "User defined" mode and a start and stop field.

Leaving these fields empty is now supported in the corresponding
domain model setters by adding default values to the DateTime
arguments.

Resolves: #53975
Releases: 6.1, 6.2
Change-Id: I944322bb3747a29fab33c3d32e17dd070c7cb6db
Reviewed-on: https://review.typo3.org/26723
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Assume pid 0 for global backend context 75/26675/3
Felix Oertel [Tue, 7 Jan 2014 17:03:56 +0000 (18:03 +0100)]
[BUGFIX] Assume pid 0 for global backend context

If outside from "Web", extbase modules try to figure out some pid,
while in reality there is just none. The core takes "0" in this
situations, for looking for typoscript templates and tagging
cf_cache_pagesection entries.

To enable extbase to use the core's cache entries, we should streamline
this.

* Return 0, if no pid is set
* Remove needless unit-tests

Resolves: #54813
Releases: 6.2
Change-Id: I58cbaac0b40323e1766229488973b775accd1b97
Reviewed-on: https://review.typo3.org/26675
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Improve feedit 59/21859/9
Georg Ringer [Wed, 3 Jul 2013 14:48:24 +0000 (16:48 +0200)]
[TASK] Improve feedit

The frontend editing + admin panel needs some polishing.
Following changes are included:

General
=======
- Reformat code
- Use Sprite API which means using the correct icons

Admin Panel
==============
- Add missing translations
- Show "Simulate usergroup" only if usergroups are available
- Remove "Total page count" in Info Tab as information is wrong
  (counting images + document is not the total page size)

Frontend Editing
=================
- Remove "edit_editNoPopup", "forceNoPopup", "editFormsOnPage"
  for direct inline editing
- Remove setting "previewBorder" which is not needed and looks just ugly

Releases: 6.2
Resolves: #49640
Change-Id: I35f88bc4e8c138fc21b74c0448b2f3892ab61918
Reviewed-on: https://review.typo3.org/21859
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years agoRevert "[BUGFIX] IRRE creates new records when using foreign_selector" 26/26726/2
Markus Klein [Thu, 9 Jan 2014 17:33:10 +0000 (18:33 +0100)]
Revert "[BUGFIX] IRRE creates new records when using foreign_selector"

This reverts commit 692bd22c0875fd37e876c79cb4a1738c67873c11

The patch breaks IRRE. It is impossible to add images.

Change-Id: Iac9f0a7af3cc8532a953ac1947f6877ded4f915f
Resolves: #43239
Releases: 6.2
Reviewed-on: https://review.typo3.org/26726
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] IRRE creates new records when using foreign_selector 90/16690/4
Kai Vogel [Thu, 22 Nov 2012 23:27:56 +0000 (00:27 +0100)]
[BUGFIX] IRRE creates new records when using foreign_selector

This patch links existing child records correctly to the parent IRRE
field when selecting it in the generated dropdown.

Scenario:

Parent table configuration:
====================================================
[...]['columns']['irreField']['config'] = array(
  'type' => 'inline',
  'foreign_table' => 'childTable',
  'foreign_selector' => 'childSelector',
);

Child table configuration:
====================================================
[...]['columns'][childSelector']['config'] = array(
  'type' => 'select',
  'foreign_table' => 'childTable',
);

What happens?
====================================================
1. The parent IRRE field renders a dropdown field
   before the child records
2. Selecting one of the items in the dropdown should
   link this child record to current IRRE field
3. Without patch, it will only create a blank child
   record
4. Using the patch, it will link the existing child
   to the parent IRRE field

Resolves: #43239
Releases: 6.2, 6.1
Change-Id: I2a308cb050962b71e9ba28b64a44962c91bde440
Reviewed-on: https://review.typo3.org/16690
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Replace all strcmp() calls with === 43/25843/30
Jo Hasenau [Sun, 1 Dec 2013 13:34:14 +0000 (14:34 +0100)]
[TASK] Replace all strcmp() calls with ===

This patch replaces about 300 places using strcmp()
in the whole core. There are different contexts for strcmp()
within this set, i.e. checking for strings being '0',
'', not '' and the like.

strcmp() has to stay when it comes to real sorting of strings,
which is a rather rare case, otherwise it can be replaced with
faster alternatives.

The following 'rules' were used for the replacement:

* Use a type cast if you can't be sure about the incoming values.
  We do not need type casts if the types are implicitly defined
  before by another function. i.e. intval(), trim(), substr()
* Use int-cast whenever the values to be compared are numbers only.
* Use string-cast for any other combination. i.e
  (string)$len === '0' when $len can be NULL, which is different
  to (int)$len === 0

Resolves: #54085
Releases: 6.2
Change-Id: I88fb294ae20d8c23ff58d8296fbb37925d5213c8
Reviewed-on: https://review.typo3.org/25843
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Add functional tests from irre_tutorial to the core 74/26674/9
Tymoteusz Motylewski [Wed, 8 Jan 2014 12:38:07 +0000 (13:38 +0100)]
[TASK] Add functional tests from irre_tutorial to the core

Add irre_tutorial extension as mock extension for functional tests.
Port functional tests from IRRE tutorial to the functional testing
framework and include them in the core and workspaces extensions.
Some tests are skipped for now, because the core is buggy.

Releases: 6.2
Resolves: #54812
Change-Id: I691dd97e7649c8239b6e96ce6f9a9d59e9b124c4
Reviewed-on: https://review.typo3.org/26674
Tested-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Test extensions not considered in functional tests 05/26705/4
Oliver Hader [Wed, 8 Jan 2014 23:16:05 +0000 (00:16 +0100)]
[BUGFIX] Test extensions not considered in functional tests

The functional testing framework offers the possibility to define
custom extension to be installed for each test scenario. However,
this does not work at all, only extensions that are available in
the original base installation can be used.

This change cleans and adds the package state definition for any
extension to be used during a functional test execution.

Fixes: #54857
Releases: 6.2
Change-Id: I91b1cd1bc5d147287a154283e94d03d1392ac92d
Reviewed-on: https://review.typo3.org/26705
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Thomas Maroschik
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] File browser fails on inexistent expandFolder 66/26466/4
Mario Rimann [Wed, 18 Dec 2013 09:17:30 +0000 (10:17 +0100)]
[BUGFIX] File browser fails on inexistent expandFolder

If a user browsed to a directory "foo" and re-opens the file-
browser later, the same directory is shown expanded.

In case the directory has been moved/renamed/deleted in the
meantime, the user gets an exception due to the inexistent
directory.

This change just adds a try/catch block around to handle that
situation.

Change-Id: I39aab6be46aec1d3f1f365e5d5f5455aca9b3aa2
Resolves: #50266
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/26466
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Pascal Maechler
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Adopt order of cols in ext:documentation 12/26712/3
Georg Ringer [Thu, 9 Jan 2014 05:27:16 +0000 (06:27 +0100)]
[TASK] Adopt order of cols in ext:documentation

Each of the actions 'show' and 'download' got a different sorting of the
columns. Change the order of the download action so that the action links
are placed at the end.

Change-Id: Ifa8aa7ed2eb9bee1ebbc086607ce1261fe1a3c95
Resolves: #54840
Releases: 6.2
Reviewed-on: https://review.typo3.org/26712
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Properly escape the ImageMagick frame selector 62/6662/7
Georg Ringer [Wed, 18 Dec 2013 13:15:27 +0000 (14:15 +0100)]
[BUGFIX] Properly escape the ImageMagick frame selector

The frame selector looks like a glob pattern and gets interpreted as
such by the shell. Currently the generated shell argument is, for
example, 'image.png'[0] which matches a file called image.png0.
Thus, if such a file exists, the wrong argument would be passed to
ImageMagick.

Only if there is no filename that matches the pattern, the string is
correctly passed to ImageMagick (i.e. as-is). But even in that case
there is a performance penalty, because the shell has to scan the whole
directory to check if the file exists. This becomes especially bad if
you're not dealing with a local file system.

By properly escaping the frame selector we stop the shell from
interpreting the glob pattern and both problems get fixed.

Resolves: #31797
Releases: 6.2, 6.1
Change-Id: Ib6dc6556bb9f1d64a0154b0cbe9e253b185c74c2
Reviewed-on: https://review.typo3.org/6662
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Only create one keypair in rsaauth 85/10485/10
Tom Ruether [Fri, 22 Nov 2013 10:47:37 +0000 (11:47 +0100)]
[BUGFIX] Only create one keypair in rsaauth

If there are two login forms on one page the second form's private
key overwrites the first form's private key so the first form doesn't
work. With this patch only one keypair gets created and it doesn't
matter how many login forms you have one one page.

Change-Id: I42660140aea72d1888cc73d56e83b823206a0797
Fixes: #24877
Fixes: #6708
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/10485
Reviewed-by: Stefan Neufeind
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Daniel Gorges
Tested-by: Daniel Gorges
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] use search word(s) for ordering search results (again) 94/20294/3
Ralf Hettinger [Mon, 29 Apr 2013 10:31:06 +0000 (12:31 +0200)]
[BUGFIX] use search word(s) for ordering search results (again)

There has been a regression in http://review.typo3.org/6657 which
removes correlation between searched words and ordering of search
results. Therefore the ordering of search results had nothing to do
with the search term anymore. This is fixed hereby by using the code
parts from prior versions.

Resolves: #38767
Releases: 6.2, 6.1, 6.0, 4.7
Change-Id: I9cfaceaeede38456dd7622085879c1bd0648be85
Reviewed-on: https://review.typo3.org/20294
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix wording of encryption key in Installer 11/26611/4
Markus Klein [Wed, 1 Jan 2014 20:28:19 +0000 (21:28 +0100)]
[BUGFIX] Fix wording of encryption key in Installer

The description of the encryption key uses the irregular verb
'output' in the wrong way.

Resolves: #54677
Releases: 6.2
Change-Id: Iad5cf8fea6e57cd8449da6d93edd7d05b3b52bf8
Reviewed-on: https://review.typo3.org/26611
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Installer fails when no database is selected 44/26544/4
Philipp Gampe [Sun, 22 Dec 2013 15:02:12 +0000 (16:02 +0100)]
[BUGFIX] Installer fails when no database is selected

Display an error message, if the selected database name is empty.

Resolves: #54569
Releases: 6.2
Change-Id: Idbf768d7edc0e5d5e1d0faf87d62e1060c70b1e9
Reviewed-on: https://review.typo3.org/26544
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Functional tests cannot write to backend log 97/26697/2
Oliver Hader [Wed, 8 Jan 2014 19:23:17 +0000 (20:23 +0100)]
[BUGFIX] Functional tests cannot write to backend log

Functional test cases cannot write to the backend log. The
log entry also has an information about the currently used
IP address, which is taken from the environment variable
REMOTE_ADDR. In a CLI disposal this value is NULL and cannot
be stored in the database, since the accordant sys_log.IP
field does not support NULL values.

Fixes: #54849
Releases: 6.2
Change-Id: If6c572c62ab7022a4cab596fa4660dec754aee3c
Reviewed-on: https://review.typo3.org/26697
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Cleanup ContentObject\ContentObjectRenderer 87/26687/3
Michiel Roos [Wed, 8 Jan 2014 00:31:13 +0000 (01:31 +0100)]
[TASK] Cleanup ContentObject\ContentObjectRenderer

Implement early return for many methods.

Change-Id: I7e0c8549037f4ab15ee8653d124891bad655db83
Resolves: #54823
Releases: 6.2
Reviewed-on: https://review.typo3.org/26687
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Render ext icon in EM only if available 93/26693/3
Georg Ringer [Wed, 8 Jan 2014 14:22:26 +0000 (15:22 +0100)]
[BUGFIX] Render ext icon in EM only if available

Even if the ext icon is required, it can happen that it is still not
there. Currently this leads to an ugly output which can be easily
fixed by just checking if the icon is there.

Change-Id: I207a93bb796510fba6096085a86f1dd832100e06
Resolves: #54838
Releases: 6.2
Reviewed-on: https://review.typo3.org/26693
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Use arrays in str_replace() calls 81/26481/8
Michiel Roos [Wed, 18 Dec 2013 21:46:49 +0000 (22:46 +0100)]
[TASK] Use arrays in str_replace() calls

Multiple consecutive calls to str_replace can be replaced with a single
call if the subject is the same.

This will speed up the replacement and in some cases has the benefit of
being able to return or use the result of the str_replace directly without
creating an intermediate variable.

Bad:
$lala = 'something';
$lala = str_replace('so', 'the', $lala);
$lala = str_replace('me', ' ', $lala);
$lala = str_replace('thing', 'other', $lala);

Good:
$lala = str_replace(
  array('so', 'me', 'thing'),
  array('the', ' ', 'other'),
  'something'
);

Change-Id: I1a2b99cce1444d3d2191eba8674f74aa2f74f0e8
Resolves: #54500
Releases: 6.2
Reviewed-on: https://review.typo3.org/26481
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Improve performance of array_merge_recursive_overrule 86/25986/11
Markus Klein [Fri, 6 Dec 2013 12:50:07 +0000 (13:50 +0100)]
[TASK] Improve performance of array_merge_recursive_overrule

The method GeneralUtility::array_merge_recursive_overrule()
always works on a copy of the given array(s). This is highly
inefficient when it comes to really big arrays and recursion.

This patches moves the functionality into the class ArrayUtility
and changes the behaviour to use a reference to the
original array.
All calls in the core are adjusted accordingly.

Furthermore we deprecate the method in GeneralUtility and
preserve backward compatibility.

Resolves: #54251
Releases: 6.2
Change-Id: I5499905593c2124897de5998be985e546a3d05ee
Reviewed-on: https://review.typo3.org/25986
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Optimize columns in sys_file_reference 25/26625/5
Ingo Schmitt [Fri, 3 Jan 2014 14:52:46 +0000 (15:52 +0100)]
[TASK] Optimize columns in sys_file_reference

MySQL up to version 5.5 allows at maximum 64 characters for table-
and fieldnames. Other DBMS allow less. Since MySQL is our primary
database and DBAL could handle specialties.

This patch changes the fields tablenames, fieldname and table_local
to varchar(64) which currently is considered save.

Resolves: #54726
Releases: 6.2
Change-Id: Ic67450a9326dceb413fe694a6233b8c092f70c79
Reviewed-on: https://review.typo3.org/26625
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Adapt indexes of sys_file_reference 26/26626/7
Ingo Schmitt [Fri, 3 Jan 2014 15:18:43 +0000 (16:18 +0100)]
[TASK] Adapt indexes of sys_file_reference

The backend and frontend fire several queries for referenced
files - files with metadata overlay as used in tt_content for
images and media field as well as in pages:media.
Analysing the queries for that some indexed should be added
to improve the query speed on large installations.

This patch adds indexed for the table/fieldname combination
as well es the uid of the record the file is attached to.

Resolves: #54725
Releases: 6.2
Change-Id: I229e27e382e8d0fdaf9bbc0b6729f90dac019e19
Reviewed-on: https://review.typo3.org/26626
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Superfluous comparison in indexed_search 40/25740/2
Wouter Wolters [Thu, 28 Nov 2013 20:57:33 +0000 (21:57 +0100)]
[TASK] Superfluous comparison in indexed_search

Change-Id: I1934a6201876290b706078519e934e05c28352ab
Resolves: #54053
Releases: 6.2
Reviewed-on: https://review.typo3.org/25740
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jo Hasenau
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Superfluous comparison in DatabaseRecordList 36/25736/3
Wouter Wolters [Thu, 28 Nov 2013 20:37:54 +0000 (21:37 +0100)]
[TASK] Superfluous comparison in DatabaseRecordList

Fix superfluous comparison against boolean in
DatabaseRecordList::getTable

Change-Id: Icdbf78935da4135a7c6b4902b97c87e7ce658eb8
Resolves: #54049
Releases: 6.2
Reviewed-on: https://review.typo3.org/25736
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Clean up uses of fe_adminLib properties 67/26567/3
Francois Suter [Fri, 27 Dec 2013 16:28:56 +0000 (17:28 +0100)]
[TASK] Clean up uses of fe_adminLib properties

Two Core tables (fe_users and index_config) still use the
"fe_admin_fieldList" property, which has no effect on the
Core since the fe_adminLib.inc was moved out of it
(into the statictemplates extension).

Additionally a deprecation message is logged in method
ExtensionManagementUtility::addTCAcolumns() when the $addTofeInterface
argument is set to TRUE.

Resolves: #54613
Releases: 6.2
Change-Id: I7c9961c5e92411a78bd355519a0493eb695177e7
Reviewed-on: https://review.typo3.org/26567
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Repository uses wrong property to calc current result page 77/26677/3
Benjamin Rau [Tue, 7 Jan 2014 17:07:34 +0000 (18:07 +0100)]
[BUGFIX] Repository uses wrong property to calc current result page

In the IndexedSearchRepository on line 157 an undefined/unused
property $this->resultsPerPage is used for the calculation
of the current page the visitor is showing on search results.

Instead of using $this->resultsPerPage we have to use
$this->numberOfResults which is defined and contains the expected setting.

Change-Id: I37c3a08c1049eb6166704b2b98ba071f03aad243
Resolves: #54808
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/26677
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] PageBrowsing ViewHelper defines unused method argument 76/26676/4
Benjamin Rau [Tue, 7 Jan 2014 17:08:37 +0000 (18:08 +0100)]
[BUGFIX] PageBrowsing ViewHelper defines unused method argument

The PHP-Doc comments for the render-method in PageBrowsing
Viewhelper on Indexed Search define a $details argument
for that method with is then not part of the method arguments
itself.

As it seems to be unused the argument definition should simply
be removed from doc comments to dont mess up the defintions
of the other arguments.

Right now this results in maximumNumberOfResultPages be defined
as array and causes a fatal error like:
The argument "maximumNumberOfResultPages" was registered with
type "array", but is of type "string" in view helper
"TYPO3\CMS\IndexedSearch\ViewHelpers\PageBrowsingViewHelper"

Resolves: #54807
Releases: 6.2, 6.1
Change-Id: I58376880ef64a1e1088561fbdb3ff25f9c1fbdc2
Reviewed-on: https://review.typo3.org/26676
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix dependencies for non-composer extensions 19/26619/3
Thomas Maroschik [Thu, 2 Jan 2014 11:01:07 +0000 (12:01 +0100)]
[BUGFIX] Fix dependencies for non-composer extensions

The method packageRequirementIsComposerPackage of
TYPO3\CMS\Core\Package ignores all non composer package
names and thus dependency resolving of non composer packages
doesn't work.

This patch adapts the behavior to ignore just the platform
package links described here
http://getcomposer.org/doc/02-libraries.md#platform-packages

Fixes: #54142
Releases: 6.2
Change-Id: Idb6a837eebf792c6cbf9394885edc17c9d392a9f
Reviewed-on: https://review.typo3.org/26619
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Replace reference to Security Cookbook with Security Guide 56/26656/2
Michael Schams [Mon, 6 Jan 2014 09:26:35 +0000 (20:26 +1100)]
[BUGFIX] Replace reference to Security Cookbook with Security Guide

Section "TYPO3 Security" refers to the TYPO3 Security Cookbook, which is
obsolete and has been replaced by the official TYPO3 Security Guide in
December 2011. This patch removes the reference to the Cookbook and
replaces it by a link to the latest version of the Security Guide on
docs.typo3.org.

Resolves: #54756
Releases: 6.2
Change-Id: I4067d40e854e7d4b4f77e2c12239e3e00616f5a7
Reviewed-on: https://review.typo3.org/26656
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Cleanup convertParameterReflectionToArray() 17/25717/3
Michiel Roos [Wed, 27 Nov 2013 20:12:02 +0000 (21:12 +0100)]
[TASK] Cleanup convertParameterReflectionToArray()

ReflectionService::convertParameterReflectionToArray() checks
functions already returning boolean again for boolean value.

Remove this overhead and improve readability.

Change-Id: I113f16cd73c713da5ec75b0e57eeee1d0e17308c
Resolves: #54021
Releases: 6.2
Reviewed-on: https://review.typo3.org/25717
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Set uid of BE_USER mock in functional tests 42/26642/2
Markus Klein [Sat, 4 Jan 2014 15:36:36 +0000 (16:36 +0100)]
[BUGFIX] Set uid of BE_USER mock in functional tests

Datahandler functional tests lack proper initialization of the
BE_USER mock used.

Set a 'uid' for the mock in order to get tests working again.

Resolves: #54741
Releases: 6.2
Change-Id: I20cccf8d3622b2c63d6b7c9f07c0e2d238bea7b9
Reviewed-on: https://review.typo3.org/26642
Reviewed-by: Oliver Hader
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Allow NULL values in INSERT queries 22/25422/2
Alexander Stehlik [Fri, 15 Nov 2013 13:06:13 +0000 (14:06 +0100)]
[BUGFIX] Allow NULL values in INSERT queries

Currently only UPDATE queries pass the $allowNull parameter to the
fullQuoteStr() method in the DatabaseHandler. To make the behavior of
both methods consistent and to allow NULL values during creation of
new records by TCEmain the $allowNull parameter is also set to TRUE for
INSERT queries.

Resolves: #53662
Releases: 6.2, 6.1, 6.0
Change-Id: I066b9880a557b6c9058fc15f467631f1313300f9
Reviewed-on: https://review.typo3.org/25422
Reviewed-by: Philipp Gampe
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] EM does not always show description 15/26615/4
Michiel Roos [Thu, 2 Jan 2014 08:23:17 +0000 (09:23 +0100)]
[BUGFIX] EM does not always show description

When an extension (like rsaauth) has configuration options in the
extension manager, the description is not shown as a tooltip when hovering
over the extension name. Then it will only show 'Configure'. Which is not
so helpful.

The ConfigureExtensionViewHelper can be modified to not add a title
attribute on the link. This will ensure that the title attribute of the td
is shown.

Change-Id: Ie6de8033545856cbe4a3689366e05d5d2ad3dc7b
Resolves: #54689
Releases: 6.2
Reviewed-on: https://review.typo3.org/26615
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] joinTSarrays() is replaced by array_replace_recursive() 00/26500/3
Michiel Roos [Thu, 19 Dec 2013 19:07:51 +0000 (20:07 +0100)]
[TASK] joinTSarrays() is replaced by array_replace_recursive()

\TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer::joinTSarrays is
replaced by the PHP native array_replace_recursive() (added in PHP 5.3.0)
which does exactly the same and is twice as fast.

Usage of $cObj->joinTSarrays() is deprecated.

Change-Id: I748270a192bccc89927e0d6b82a1f405959b2209
Resolves: #54520
Releases: 6.2
Reviewed-on: https://review.typo3.org/26500
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] isValidUrl() idna converts whole URI 36/25636/26
Michiel Roos [Fri, 22 Nov 2013 11:06:14 +0000 (12:06 +0100)]
[BUGFIX] isValidUrl() idna converts whole URI

GeneralUtility::isValidUrl() idna converts whole URI instead of
domain only.

The expensive idna_convert() is called from isValidUrl(). Instead of
feeding it just the domain part, the whole URI is converted.

When supplying just the domain part, a great speed gain can be seen.

On seriously malformed URLs, parse_url() may return FALSE and emits an
E_WARNING. So we check for that first.

PHP no longer supports the flags FILTER_FLAG_HOST_REQUIRED and
FILTER_FLAG_SCHEME_REQUIRED. A scheme is now required by default. [1]
Return FALSE if the URL does not start with a scheme.

A public GeneralUtility::idnaEncode() method uses a static idna_convert
instance and fetches converted strings from a string cache array
to avoid multiple checks on the same domain.

All manual idna_convert instances are replaced with
GeneralUtility::idnaEncode() calls.

Special characters are not allowed in the URL except in the domain
part [2]. So the test with special characters in the path was removed
from the GeneralUtilityTest class.

[1] http://www.php.net/manual/en/filter.filters.flags.php#107382
[2] http://tools.ietf.org/html/rfc3986#appendix-A

Change-Id: I7a0ab0a399d9d6cf68c824f413be6b6d621947c1
Resolves: #53862
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/25636
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Tested-by: Markus Klein
Reviewed-by: Andreas Wolf
Reviewed-by: Jo Hasenau
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Folder::getFiles directly calls Factory::createFileObject 60/26360/2
Steffen Ritter [Thu, 12 Dec 2013 18:50:26 +0000 (19:50 +0100)]
[BUGFIX] Folder::getFiles directly calls Factory::createFileObject

Folder::getFiles implements the logic of creating file objects
itself, after retrieving the information from the driver.
Besides the fact that this is slow since all information for the
object are received from the filesystem directly instead of the
cache in the sys_file table the uid is not present in these
objects which finally results in the lack of metadata in these
file objects.

In addition to that ommiting the ResourceFactory several objects
for the same file might exists which may lead to inconsistent
behaviour and output on modifying the file.

As the Folder/File Objects only should be a convinience facade
in front of the ResourceStorage this change introduces a new
method their, implementing the new and improved logic.

At the same time the old functionality - which enforces manual
file object creation - has been deprecated and the filelist
module is adapted accordingly.

Releases: 6.2
Resolves: #53688
Change-Id: I3fb97d432d325bd6400c0ae208b90d702c9f528d
Reviewed-on: https://review.typo3.org/26360
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] getFileIndexRecordsForFolder only works for hierarchical path 57/26357/3
Steffen Ritter [Thu, 12 Dec 2013 16:08:21 +0000 (17:08 +0100)]
[BUGFIX] getFileIndexRecordsForFolder only works for hierarchical path

The method FileRepository::getFileIndexRecordsForFolder
retrieves the Index Records for files in a given folder using a
LIKE-query. This basically checks if the identifier of the a
folder is part of the identifier of the file.

This concept has several drawbacks. First not all storages are
hierarchical, second this will fail if there is a different
directory seperator than / and finally this fetches records
for the folder recursively which may result in a huge amount of
data if for example the root folder of an storage is queried.

In addition the method resides in the FileRepository while it
retrieves IndexRecords - which is a different concern.

This change introduces the function within the
FileIndexRepository and uses the folder_hash (introduced in
https://review.typo3.org/23398) to query for the files.

The old method is deprecated now, calls the new method and
all core-usages of the old function have been rewritten to
use the new functionality.

Releases: 6.2
Resolves: #53687
Change-Id: Icabf2350192c93951f2277f3aa7468fe958bfabf
Reviewed-on: https://review.typo3.org/26357
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Fix message for install tool warning 09/26509/4
Cynthia Mattingly [Fri, 20 Dec 2013 10:06:52 +0000 (11:06 +0100)]
[BUGFIX] Fix message for install tool warning

Fix incorrect message for install tool login attempt warning.

Resolves: #54531
Releases: 6.2, 6.1
Change-Id: I40f34b85ffc554187baf1f2601c578cbaafc5718
Reviewed-on: https://review.typo3.org/26509
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] UX enhancement for EXT:documentation 75/25975/4
Xavier Perseguers [Fri, 6 Dec 2013 09:21:52 +0000 (10:21 +0100)]
[TASK] UX enhancement for EXT:documentation

Rework the documentation module according to the
discussion with the TYPO3 Usability Team.

Resolves: #54067
Releases: 6.2
Change-Id: Ia59c9a1554080b71412b467f6621bc7270a81c72
Reviewed-on: https://review.typo3.org/25975
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Set TYPO3 version to 6.2-dev 93/26493/2
TYPO3 Release Team [Thu, 19 Dec 2013 15:26:52 +0000 (16:26 +0100)]
[TASK] Set TYPO3 version to 6.2-dev

Change-Id: Ia6a172bcc88924db714005165d92added4bb4a1a
Reviewed-on: https://review.typo3.org/26493
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team