Packages/TYPO3.CMS.git
4 months ago[BUGFIX] Decouple GeneralUtility::rmdir from Environment::isWindows() 31/58631/2
Nicole Cordes [Sun, 14 Oct 2018 19:12:42 +0000 (21:12 +0200)]
[BUGFIX] Decouple GeneralUtility::rmdir from Environment::isWindows()

To be able to call rmdir without an initialized Environment instance,
the check if a Windows system is used, is decoupled. This allows to
call GeneralUtility::rmdir e.g. in typo3/testing-framework.

Resolves: #86655
Releases: master
Change-Id: Ica1feafbd9a07005c4b653ef2fe1153fba4b9417
Reviewed-on: https://review.typo3.org/58631
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Allow more tags when no RTE processing is available 45/58745/2
Benni Mack [Sat, 27 Oct 2018 21:28:41 +0000 (23:28 +0200)]
[BUGFIX] Allow more tags when no RTE processing is available

If somebody has no RTE extension available, there is also no
RTE processing information available, so the default
from RteHtmlParser is used. However, tags like <abbr>
are then not provided by the yaml configuration, so they are
not allowed, and thus - escaped.

The patch adds abbr,acronym and dfn to be allowed all the time.

Resolves: #83424
Releases: master, 8.7
Change-Id: Ifdc0e7f155bef95a7c397584f2cf7b1eab61f6bb
Reviewed-on: https://review.typo3.org/58745
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Add margin-bottom for tab-content 72/58572/5
Nikita Hovratov [Wed, 3 Oct 2018 19:06:44 +0000 (21:06 +0200)]
[BUGFIX] Add margin-bottom for tab-content

This adds a margin between the tab-content and the submit-button in the
extension configuration form.

Resolves: #86562
Releases: master
Change-Id: Ifdbf30af3cb92162c876c49b46d32776b654991e
Reviewed-on: https://review.typo3.org/58572
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Do not require */ext to be writable in Composer Mode 72/57772/3
Łukasz Uznański [Sat, 31 Mar 2018 23:33:34 +0000 (01:33 +0200)]
[BUGFIX] Do not require */ext to be writable in Composer Mode

Resolves: #81857
Releases: master
Change-Id: I2dc07e8ac23edad2c7bd4880c4fd12ebcf2e40d6
Reviewed-on: https://review.typo3.org/57772
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Resolve correct page in slug validation 29/58229/8
Oliver Hader [Sat, 8 Sep 2018 12:54:45 +0000 (14:54 +0200)]
[BUGFIX] Resolve correct page in slug validation

The SlugHelper now receives an encapsulated RecordState object that
represents a record.

This allows fine-grained control over a record and helps resolving
related information, which is required to resolve slugs properly in a
case where e.g. the node ("parent") and language uid can occur multiple
times.

The RecordState contains:

- an EntityContext which describes a variant of a record by its language
  and workspace assignment

- a node object (EntityPointer) that points to the node (aka "parent") of
  the record

- a EntityUidPointer that describes the origin of the record by its table
  name and uid

The RecordStateFactory creates such RecordState objects and enriches them
with links (EntityPointerLink) that point to languages and versions, that
are also represented by EntityPointer implementations.

Resolves: #86195
Releases: master
Change-Id: If17a30e98f802825d80e95044572153f2426bea2
Reviewed-on: https://review.typo3.org/58229
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Move page fields to new tab 'social media' 18/58718/3
Jasmina Ließmann [Fri, 26 Oct 2018 15:03:22 +0000 (17:03 +0200)]
[TASK] Move page fields to new tab 'social media'

Move fields for open graph and twitter card to a new tab 'social media'

Resolves: #86514
Releases: master
Change-Id: I293f250b57f6bba3c696e77550584912db3491eb
Reviewed-on: https://review.typo3.org/58718
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update typo3/cms-composer-installers to 2.2.1 42/58742/2
Christian Kuhn [Sat, 27 Oct 2018 20:03:20 +0000 (22:03 +0200)]
[TASK] Update typo3/cms-composer-installers to 2.2.1

Upgrade from 2.2.0 to 2.2.1 which allows PHP 7.3
in this dependency.

composer update typo3/cms-composer-installers

Resolves: #86772
Releases: master
Change-Id: I04ca2bd7af007321de7ea0d010b073e113e4cb61
Reviewed-on: https://review.typo3.org/58742
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Detect recursions in PageContentErrorHandler 15/58615/3
Simon Praetorius [Thu, 11 Oct 2018 12:43:09 +0000 (14:43 +0200)]
[BUGFIX] Detect recursions in PageContentErrorHandler

Possible recursions that can occur while fetching the content of an error page are now detected and resolved.

Resolves: #86626
Releases: master
Change-Id: I72ca04bd57ac400e14a06231218cee903c713675
Reviewed-on: https://review.typo3.org/58615
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Show original error in ReflectionService exception 30/58730/7
Susanne Moog [Sat, 27 Oct 2018 10:58:50 +0000 (12:58 +0200)]
[BUGFIX] Show original error in ReflectionService exception

Instead of displaying a custom error message, let the original
exception message be part of the ReflectionException to differentiate
if the original class or any of the type hints has a problem.

Resolves: #86742
Releases: master, 8.7
Change-Id: I215ce779812b43f8bca5e6dfd2052461686482a7
Reviewed-on: https://review.typo3.org/58730
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] In BE: MetaTags are not cached by page rendering 34/58734/3
Ursula Klinger [Sat, 27 Oct 2018 13:49:39 +0000 (15:49 +0200)]
[BUGFIX] In BE: MetaTags are not cached by page rendering

Calling the redirect module in the BE, the page renderer is called
without a specified $GLOBALS['TSFE']->page['uid']. So the meta tags
could not be cached.

Resolves: #86769
Releases: master
Change-Id: I39c099c7c0d13dda0c7098a2f798671b6d7b3f5b
Reviewed-on: https://review.typo3.org/58734
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add more doktypes to be excluded from XML sitemap by default 15/58715/5
Richard Haeser [Fri, 26 Oct 2018 14:06:31 +0000 (16:06 +0200)]
[TASK] Add more doktypes to be excluded from XML sitemap by default

Shortcuts and backend user sections should be removed from the XML
sitemap because a search engine should not index those pages
by default.

An integrator can always override this setting.

Resolves: #86690
Releases: master
Change-Id: I1b6c2299dc01d315c0aefe2205436037f045dc8c
Reviewed-on: https://review.typo3.org/58715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[BUGFIX] Also process array in InputSlugElement 00/58700/6
Daniel Goerz [Thu, 25 Oct 2018 14:07:15 +0000 (16:07 +0200)]
[BUGFIX] Also process array in InputSlugElement

It is possible that the incoming $row contains an array
at the $languageField. This patch assures that the
$languageId can always be determined.

Resolves: #86734
Resolves: #86554
Relates: #86754
Releases: master
Change-Id: Ia2c8621cd935788f33a9b625ec0226a22e21b123
Reviewed-on: https://review.typo3.org/58700
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Linkvalidator validates linked content elements 12/57612/6
Patrick Broens [Mon, 16 Jul 2018 13:49:45 +0000 (15:49 +0200)]
[BUGFIX] Linkvalidator validates linked content elements

This patch makes the LinkValidator check typolinks to tt_content
elements like t3://page?uid=x#y by calling InternalLinktype twice, once
for the page as first part of the SoftReferenceIndex and again for the
tt_content element as second part.

Resolves: #85576
Related: #84016
Releases: master, 8.7
Change-Id: I94243e66f5eff38c9a0b0859a85aac48885e38ba
Reviewed-on: https://review.typo3.org/57612
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Avoid excluding fields in copyToLanguage 35/58235/5
Oliver Hader [Sun, 9 Sep 2018 09:17:33 +0000 (11:17 +0200)]
[BUGFIX] Avoid excluding fields in copyToLanguage

Given that a TCA column is using 'l10n_mode' => 'exclude' and creating
a "free localization" of that record using DataHandler's copyToLanguage
command, the according field stays empty in the created localization.

The expected behavior is that the accordings field is still duplicated
once on creating the duplicate for a particular language. Title prefix
"[Translate to <language>:]" is expected to be missing here since it
is the result of a copy command instead of a localize command.

Resolves: #86203
Releases: master
Change-Id: Ib9914a8d02cbbabdbdc56720a983b6314a34709b
Reviewed-on: https://review.typo3.org/58235
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Respect no_index while creating canonical and hreflang tags 88/58588/3
Richard Haeser [Sat, 6 Oct 2018 19:05:13 +0000 (21:05 +0200)]
[BUGFIX] Respect no_index while creating canonical and hreflang tags

When the current page is set to no_index, no canonical tag
and hreflang tags will be generated.

Resolves: #86569
Releases: master
Change-Id: I7e5360bc9159e31a4ffaa352a05ba0d8296693ed
Reviewed-on: https://review.typo3.org/58588
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Marc Hirdes <hirdes@clickstorm.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add field pages.hidden to rootline default fields 27/58727/2
Joerg Kummer [Sat, 27 Oct 2018 01:43:21 +0000 (03:43 +0200)]
[TASK] Add field pages.hidden to rootline default fields

Adding field 'hidden' to default field list of rootline page requests
ensures more detailed rendering of page status in FLUID using
ViewHelper core:iconForRecord.

Resolves: #86512
Releases: master
Change-Id: I111d9cb22c47d735029603463cf43c0837a0f732
Reviewed-on: https://review.typo3.org/58727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Allow relative URLs in locationHeaderUrl 05/58705/9
Susanne Moog [Thu, 25 Oct 2018 20:18:45 +0000 (22:18 +0200)]
[BUGFIX] Allow relative URLs in locationHeaderUrl

Resolves: #81720
Releases: master, 8.7
Change-Id: I099c905bf335a13fafa920c2849fd88971dc0e44
Reviewed-on: https://review.typo3.org/58705
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Ursula Klinger <klinger@punkt.de>
Tested-by: Ursula Klinger <klinger@punkt.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Update display of text under the translated input field 93/58693/4
Jasmina Liessmann [Thu, 25 Oct 2018 09:25:30 +0000 (11:25 +0200)]
[BUGFIX] Update display of text under the translated input field

Break words in text of default language under the translated input field.

Resolves: #84020
Releases: master
Change-Id: I07e0f0d75439b0ccba95f998d6c68276e649a939
Reviewed-on: https://review.typo3.org/58693
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Use correct type for header value 23/58723/4
Daniel Goerz [Fri, 26 Oct 2018 17:27:44 +0000 (19:27 +0200)]
[BUGFIX] Use correct type for header value

Resolves: #86758
Releases: master
Change-Id: Ia0803d4ba68e0913478e4cfa9173cce5e1c5b5db
Reviewed-on: https://review.typo3.org/58723
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Pass status code as int to RedirectResponse 31/58731/3
Thomas Alboth, undkonsorten [Sat, 27 Oct 2018 11:06:52 +0000 (13:06 +0200)]
[BUGFIX] Pass status code as int to RedirectResponse

The filelist module shows an error when creating an new textfile
with a file extension that is not allowed via [SYS][textfile_ext],
e.g. test.md and sends an according RedirectResponse.

The RedirectResponse constructor call has been fixed to be called with
an int instead of a string as status code.

Resolves: #86765
Releases: master
Change-Id: I63ea741223db21b8e4f8fbda1cc958b608ff981e
Reviewed-on: https://review.typo3.org/58731
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Always set overrideVals when editing a page 12/58712/4
Daniel Goerz [Fri, 26 Oct 2018 13:24:51 +0000 (15:24 +0200)]
[BUGFIX] Always set overrideVals when editing a page

Resolves: #86754
Releases: master
Change-Id: I2bb3226595e53ed993e0114130123e4f87f1603b
Reviewed-on: https://review.typo3.org/58712
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Refactor AdminPanel JavaScript 99/58699/5
Oliver Hader [Fri, 26 Oct 2018 11:13:45 +0000 (13:13 +0200)]
[TASK] Refactor AdminPanel JavaScript

- move to namespaced functions
- remove console log on copy

Prerequisite for further bug fixes.

Resolves: #86744
Releases: master
Change-Id: I7647cd7b75bab999680806fc65dddcec9271717f
Reviewed-on: https://review.typo3.org/58699
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Update codemirror to 5.40.2 62/58662/2
Andreas Fernandez [Fri, 19 Oct 2018 10:19:03 +0000 (12:19 +0200)]
[TASK] Update codemirror to 5.40.2

Used commands:
yarn add codemirror@^5.40.0 --dev
grunt build

Resolves: #86700
Releases: master
Change-Id: I07a146e2ca108339092e16d769fef8031e783511
Reviewed-on: https://review.typo3.org/58662
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Recover switched items in maxitems=1 selectMultipleSideBySide 99/58599/4
Kevin von Spiczak [Tue, 9 Oct 2018 11:32:37 +0000 (13:32 +0200)]
[BUGFIX] Recover switched items in maxitems=1 selectMultipleSideBySide

Shows and re-enables all the options, that are currently not selected
when using maxitems = 1

Resolves: #86594
Releases: master, 8.7
Change-Id: I1f5e727ec42203981edaaf4b79bb6e201352d296
Reviewed-on: https://review.typo3.org/58599
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Nicolai Schirawski <ns@t3magic.de>
Tested-by: Nicolai Schirawski <ns@t3magic.de>
Reviewed-by: Eike Starkmann <starkmann@undkonsorten.com>
Tested-by: Eike Starkmann <starkmann@undkonsorten.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Give install tool a fresher look 43/58543/4
Benjamin Kott [Mon, 1 Oct 2018 19:34:31 +0000 (21:34 +0200)]
[TASK] Give install tool a fresher look

During the last-minute changes before LTS, some stylings in the
Maintenance area were done to streamline the look&feel, but the
installer process should get an update look as well.

Resolves: #86756
Releases: master
Change-Id: Idb58da1f467c27ce3e12252f201e031c2faaedc2
Reviewed-on: https://review.typo3.org/58543
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Remove surrounding &nsbp; in the tables with ol or ul in CKEditor 77/57777/4
Łukasz Uznański [Thu, 2 Aug 2018 12:07:13 +0000 (14:07 +0200)]
[BUGFIX] Remove surrounding &nsbp; in the tables with ol or ul in CKEditor

This patch removes generated &nbsp; in tables with ol or ul inside. This
is unintented behaviour, and we can't manually remove them from table.

Also, I moved HTMLparser section into existing nonTypoTagStdWrap

Resolves: #83795
Releases: master, 8.7
Change-Id: I711e4cbab8249fe6f43c8abe6f63183eaac9131f
Reviewed-on: https://review.typo3.org/57777
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Thomas Alboth, undkonsorten <ta@undkonsorten.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Display FlashMessage in View Module 73/58573/6
Oliver Bartsch [Wed, 3 Oct 2018 19:53:32 +0000 (21:53 +0200)]
[BUGFIX] Display FlashMessage in View Module

When clicking on the root page while in view module
a FlashMessage is now displayed with proper information.
The FlashMessage is also shown in the case of clicking the
root page and a Page, marked as siteroot, exists.
Furthermore the FlashMessage is now also shown if the
selected page has no valid doktype e.g. sysfolder
or spacer.

Resolves: #86563
Releases: master
Change-Id: Ia8c6cddfe38602c94b41d5da81987d061778096f
Reviewed-on: https://review.typo3.org/58573
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Avoid exception of renderType selectCheckBox in workspace 84/57484/4
Alexey Atsyn [Fri, 6 Jul 2018 14:03:50 +0000 (19:03 +0500)]
[BUGFIX] Avoid exception of renderType selectCheckBox in workspace

Resolves: #85109
Releases: master, 8.7
Change-Id: I34a269ec2d564a546d4dc2036a97eb1027d2352f
Reviewed-on: https://review.typo3.org/57484
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Prevent null value being passed to hash_equals 96/58596/5
Sascha Egerer [Mon, 8 Oct 2018 23:13:49 +0000 (01:13 +0200)]
[BUGFIX] Prevent null value being passed to hash_equals

The second parameter of hash_equals must be a string but could be a
null value in the FileDumpController. It is ensured now that the
value is always a string.

Resolves: #86599
Releases: master, 8.7
Change-Id: Iaf682b405be6712aa31603521a2d873b4c3bcb89
Reviewed-on: https://review.typo3.org/58596
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Show deleted records in recycler 60/58660/2
Stefan Froemken [Fri, 19 Oct 2018 07:45:34 +0000 (09:45 +0200)]
[BUGFIX] Show deleted records in recycler

Show deleted records in recycler also when
related be_user was deleted completely from database.

Resolves: #86696
Releases: master
Change-Id: Idc16781ce4bb0c28be48cc86052738110c500165
Reviewed-on: https://review.typo3.org/58660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Ursula Klinger <klinger@punkt.de>
Tested-by: Ursula Klinger <klinger@punkt.de>
Tested-by: Eike Starkmann <starkmann@undkonsorten.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Add EXT:recordlist as dependency of EXT:backend 75/58575/7
Jan Stockfisch [Thu, 4 Oct 2018 09:24:25 +0000 (11:24 +0200)]
[BUGFIX] Add EXT:recordlist as dependency of EXT:backend

Resolves: #86567
Releases: master
Change-Id: Ida5a35fe28b32f100779b048bc9b676cb2bd099e
Reviewed-on: https://review.typo3.org/58575
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 months ago[BUGFIX] Properly reference config.yaml instead of config.yml 09/58709/2
Benni Mack [Fri, 26 Oct 2018 12:06:05 +0000 (14:06 +0200)]
[BUGFIX] Properly reference config.yaml instead of config.yml

There is one wrong documentation about config.yaml of
site configuration, where it is `config.yml`, however,
TYPO3 Core always uses the `yaml` file ending.

Resolves: #86752
Releases: master
Change-Id: I06605ca83baa453bc64da96d321f7a22b0893687
Reviewed-on: https://review.typo3.org/58709
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[BUGFIX] CleanerTask processes all FileResource Fields 12/57112/4
Sven Jürgens [Fri, 1 Jun 2018 13:19:32 +0000 (15:19 +0200)]
[BUGFIX] CleanerTask processes all FileResource Fields

By removing an errorous break in a loop, all FileResource Fields are found
and therefor all connected files can be deleted.

Resolves: #85140
Releases: master, 8.7
Change-Id: I0aea4427dd9e74b1a11ab04e8aa235e17ae1a031
Reviewed-on: https://review.typo3.org/57112
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Properly mock LocalizationFactory in form tests 03/58703/2
Susanne Moog [Thu, 25 Oct 2018 18:49:02 +0000 (20:49 +0200)]
[BUGFIX] Properly mock LocalizationFactory in form tests

Resolves: #86704
Releases: master
Change-Id: Ie30f22e641d76890a97bc47c51665d697aad93f5
Reviewed-on: https://review.typo3.org/58703
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Execute tests via docker 89/57789/29
Christian Kuhn [Fri, 3 Aug 2018 10:00:52 +0000 (12:00 +0200)]
[TASK] Execute tests via docker

The patch adds a new entry script Build/Script/runTests.sh
that hides away all the complexity of test suite execution
and docker details to execute everything that bamboo performs
locally via docker.

Use Build/Script/runTests.sh -h for an overview of available
options.

Example call to execute all functional tests on postgres DBMS
and sending xdebug output to a local (phpstorm) listening on
port 9000:
Build/Script/runTests.sh -s functional -d postgres -x

Change-Id: Idaaf0a90ed1a0ba0f31c1b7128dd9d564335e056
Resolves: #86746
Releases: master
Reviewed-on: https://review.typo3.org/57789
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Register "then"/"else" in IfHasRoleViewHelper again 92/58692/2
Mathias Brodala [Thu, 25 Oct 2018 09:07:58 +0000 (11:07 +0200)]
[BUGFIX] Register "then"/"else" in IfHasRoleViewHelper again

This fixes the usage of "then" and "else" for the inline notation.

Resolves: #86743
Releases: master, 8.7
Change-Id: Ia0a749fedcb3b3d4ffe7f90ac40ab604fd7c340a
Reviewed-on: https://review.typo3.org/58692
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 months ago[BUGFIX] Allow fallback to default language in site config 98/58698/2
Daniel Goerz [Thu, 25 Oct 2018 11:01:05 +0000 (13:01 +0200)]
[BUGFIX] Allow fallback to default language in site config

Resolves: #86597
Releases: master
Change-Id: I119a83a76bb3b5695965490434daef78245c27dd
Reviewed-on: https://review.typo3.org/58698
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Allow editing of pages with language ID > 9 96/58696/2
Daniel Goerz [Thu, 25 Oct 2018 10:49:47 +0000 (12:49 +0200)]
[BUGFIX] Allow editing of pages with language ID > 9

Resolves: #86734
Releases: master
Change-Id: Ib26c0336531e1e692f73ccc431b7091c47755ce9
Reviewed-on: https://review.typo3.org/58696
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Allow rendering of description for InputSlugElement 81/58681/2
Georg Ringer [Wed, 24 Oct 2018 07:46:43 +0000 (09:46 +0200)]
[TASK] Allow rendering of description for InputSlugElement

The description must be available for the InputSlugElement as well to give
editors an additional guidance.

Resolves: #86720
Releases: master
Change-Id: Iaa70a6e62209eb72cbe51be91727c8bed775fac6
Reviewed-on: https://review.typo3.org/58681
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Let CObjectViewHelper render top level objects again 86/58686/3
Helmut Hummel [Wed, 24 Oct 2018 16:46:19 +0000 (18:46 +0200)]
[BUGFIX] Let CObjectViewHelper render top level objects again

Making the CObjectViewHelper had the unfortunate side effect,
that top level object paths are not working any more.

Adapt the tests to show the mistake and make the rendering
work in this case.

Additionally now an exception is also thrown, if the given
object path does not resolve to a TypoScript object.

Releases: master
Resolves: #86729
Related: #84345
Change-Id: I686119b480c6fae88be7d704b82094e35789c0d7
Reviewed-on: https://review.typo3.org/58686
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Assure that $_POST is never set to null 82/58682/4
Daniel Goerz [Wed, 24 Oct 2018 08:05:24 +0000 (10:05 +0200)]
[BUGFIX] Assure that $_POST is never set to null

Resolves: #86731
Releases: master
Change-Id: Ia48925cf98637d7c7b2ecfb071bc935508032dec
Reviewed-on: https://review.typo3.org/58682
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update php-cs-fixer configuration to exclude _generated directory 83/58683/2
Sybille Peters [Wed, 24 Oct 2018 08:21:38 +0000 (10:21 +0200)]
[TASK] Update php-cs-fixer configuration to exclude _generated directory

Resolves: #86730
Releases: master, 8.7
Change-Id: I9e707e6d9c1305baa92b7f2c4c0f83bbeea52daa
Reviewed-on: https://review.typo3.org/58683
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Remove `fbclid` argument from chash calculation 71/58671/2
Andreas Fernandez [Tue, 23 Oct 2018 06:17:56 +0000 (08:17 +0200)]
[BUGFIX] Remove `fbclid` argument from chash calculation

Facebook adds the `fbclid` argument to outbound URLs which triggers a
recalculcation of the cache hash. The argument is now added to the
blacklist for chash parameters.

Resolves: #86715
Releases: master, 8.7, 7.6
Change-Id: I8cd66fdfa2c549c65750d6ef896261cccba4b54d
Reviewed-on: https://review.typo3.org/58671
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Remove duplicate XLIFF entry 70/58670/4
Xavier Perseguers [Mon, 22 Oct 2018 09:13:51 +0000 (11:13 +0200)]
[TASK] Remove duplicate XLIFF entry

Resolves: #86135
Releases: master
Change-Id: I2b77b58aeb5bdbd12e9186b1b18d8b82a9dbfe6d
Reviewed-on: https://review.typo3.org/58670
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Tested-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
5 months ago[BUGFIX] Bring back findByUid behavior for L>0 35/58635/12
Tymoteusz Motylewski [Mon, 15 Oct 2018 10:20:48 +0000 (12:20 +0200)]
[BUGFIX] Bring back findByUid behavior for L>0

findByUid as well as getObjectByIdentifier will always overlay records
to a language from the global context.

This solves the problem with controller arguments not being translated,
when default language record was used in the URL.

Resolves: #86619
Releases: master
Related: #82363
Change-Id: I823cdc1118a8217e306473b1596d349cc7ca08d4
Reviewed-on: https://review.typo3.org/58635
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[TASK] Raise version of typo3/phar-stream-wrapper to 3.0.1 47/58647/3
Oliver Hader [Thu, 18 Oct 2018 10:15:38 +0000 (12:15 +0200)]
[TASK] Raise version of typo3/phar-stream-wrapper to 3.0.1

composer require typo3/phar-stream-wrapper:^3.0.1

Resolves: #86680
Releases: master
Change-Id: Id138feafe6a3507f2cee5e3650a343d9ba10cf64
Reviewed-on: https://review.typo3.org/58647
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[BUGFIX] Fix example of StaticRangeMapper 42/58642/2
Georg Ringer [Tue, 16 Oct 2018 05:28:24 +0000 (07:28 +0200)]
[BUGFIX] Fix example of StaticRangeMapper

The variables need to be strings and not integers.

Resolves: #86665
Releases: master
Change-Id: I6ee14d6865b954aa84208ed361b1a760bf9e0d26
Reviewed-on: https://review.typo3.org/58642
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Fix argument ordering of RecordHistoryStore 41/58641/3
Georg Ringer [Mon, 15 Oct 2018 19:46:52 +0000 (21:46 +0200)]
[BUGFIX] Fix argument ordering of RecordHistoryStore

The DataHandler must use the correct ordering of arguments of
RecordHistoryStore. Furthermore the sorting of the arguments in the
doc block is fixed.

Resolves: #86657
Releases: master
Change-Id: I3054cb5a94f0e84a5c93accfd6349b7c24dbc885
Reviewed-on: https://review.typo3.org/58641
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Minor typo in bamboo specs 44/58644/2
Christian Kuhn [Tue, 16 Oct 2018 12:51:53 +0000 (14:51 +0200)]
[BUGFIX] Minor typo in bamboo specs

Resolves: #86671
Releases: master
Change-Id: I66916f2b7570ef44884b8f268fc127685f710840
Reviewed-on: https://review.typo3.org/58644
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[BUGFIX] Always provide an array to applyControllerActionValues 95/58595/5
Daniel Siepmann [Mon, 8 Oct 2018 08:07:17 +0000 (10:07 +0200)]
[BUGFIX] Always provide an array to applyControllerActionValues

As applyControllerActionValues requires an array as 2nd argument by
reference, we make sure to provide an array as 2nd argument.

Resolves: #86592
Releases: master
Change-Id: If2d56da60302b8a2dea89f0b31c02eba41024d3d
Reviewed-on: https://review.typo3.org/58595
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Use consistent API for checking update status 20/58620/3
Susanne Moog [Fri, 12 Oct 2018 09:53:24 +0000 (11:53 +0200)]
[BUGFIX] Use consistent API for checking update status

Instead of re-implementing checking of update wizards in
the status report, the same methods for checking should be
used to generate the same status as the install tool upgrade
wizard section itself.

Resolves: #86632
Releases: master
Change-Id: Ifc0f282dcb42dd52b79e65c31e29f52b46e54593
Reviewed-on: https://review.typo3.org/58620
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Add link to "cleanup of AbstractRecordList breaks hook" documentation 85/58585/5
Tomas Norre Mikkelsen [Fri, 5 Oct 2018 16:35:00 +0000 (18:35 +0200)]
[BUGFIX] Add link to "cleanup of AbstractRecordList breaks hook" documentation

Releases: master
Resolves: #86583
Change-Id: Icbd41aba47a5cb3ba82485f505e6d90e21bc524e
Reviewed-on: https://review.typo3.org/58585
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Correct tooltips for pages in the page tree 16/58616/3
Tymoteusz Motylewski [Thu, 11 Oct 2018 14:32:48 +0000 (16:32 +0200)]
[BUGFIX] Correct tooltips for pages in the page tree

Make tooltips for pages in the page tree correct (in case of shortcuts,
and mountpoints).

* add missing fields to selection in page tree Repository
required by BackendUtility->titleAttribForPages()
* add guard clauses for page 0 to avoid unnecessary processing
* fixes several notices

Resolves: #86631
Releases: master
Change-Id: Ia0229203b78ef8c58e066ef3a587c1de1ee0b975
Reviewed-on: https://review.typo3.org/58616
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Use correct variable name in OnlineMedia.ts 19/58619/3
Georg Ringer [Fri, 12 Oct 2018 08:16:42 +0000 (10:16 +0200)]
[BUGFIX] Use correct variable name in OnlineMedia.ts

Resolves: #86630
Releases: master, 8.7
Change-Id: I4bce2665ed54cddc3a151445c5863c24ffac6df6
Reviewed-on: https://review.typo3.org/58619
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Return success when zero wizards run in upgrade:run 58/58558/4
Benjamin Franzke [Tue, 2 Oct 2018 12:12:08 +0000 (14:12 +0200)]
[BUGFIX] Return success when zero wizards run in upgrade:run

Having to run zero wizards (e.g. fully upgraded)
is obviously not an error.

Releases: master
Resolves: #86543
Change-Id: Ide967005581e7c5fa956f5ffdb2c482a4a2f2048
Reviewed-on: https://review.typo3.org/58558
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[BUGFIX] Correct inline foreign_unique with target type="group" handling 21/58421/5
Cyril Janody [Thu, 27 Sep 2018 22:31:10 +0000 (18:31 -0400)]
[BUGFIX] Correct inline foreign_unique with target type="group" handling

Using type="inline" and MM relations having type="group" (instead of
type="select") and foreign_unique defined results in a fatal since
group db relations have been resolved to an array in TcaGroup data
provider already.

Change-Id: I20d138e7622aafb097a11e60014f9e4398bae811
Resolves: #82104
Resolves: #84735
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58421
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Cyril Janody <typo3@cjanody.com>
Tested-by: Cyril Janody <typo3@cjanody.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Disable dump autoloading in Composer mode 78/58578/4
Rune Piper [Fri, 5 Oct 2018 07:20:00 +0000 (09:20 +0200)]
[BUGFIX] Disable dump autoloading in Composer mode

This patch hides the "Dump autoload" button in the maintenance area when
in Composer mode, because it does nothing.

Resolves: #86565
Releases: master
Change-Id: Ib8f71f5a41189f97f02aed6b4c7cb69feabef724
Reviewed-on: https://review.typo3.org/58578
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Fix path when writing AdditionalConfiguration.php 71/58571/2
Alexander Stehlik [Wed, 3 Oct 2018 19:08:29 +0000 (21:08 +0200)]
[BUGFIX] Fix path when writing AdditionalConfiguration.php

Use the getAdditionalConfigurationFileLocation() method to
determine the path to the file.

Releases: master
Resolves: #86561
Change-Id: I61b52e8eeb99ab2575f75025712a17f4c8ea4a40
Reviewed-on: https://review.typo3.org/58571
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Rune Piper <kontakt@runepiper.de>
Tested-by: Rune Piper <kontakt@runepiper.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself 97/58597/4
Josef Glatz [Tue, 9 Oct 2018 03:51:46 +0000 (05:51 +0200)]
[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

In addition, the suggest has been improved to search also in the
following fields of page records:
* nav_title
* alias
* url

Releases: master, 8.7
Resolves: #86600
Related: #54867
Change-Id: Ifce04fc5f01b5585f2320901b56be8b9970d4762
Reviewed-on: https://review.typo3.org/58597
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Fix version preview checks in PageRepository 77/58577/2
Markus Klein [Thu, 4 Oct 2018 20:26:01 +0000 (22:26 +0200)]
[BUGFIX] Fix version preview checks in PageRepository

This patch corrects all conditions for version preview in the
PageRepository class, which have been converted incorrectly
with #85078.

Resolves: #86574
Releases: master
Change-Id: I9a77f2de7c6c8abab9e5b3a1012c1582ed863fdd
Reviewed-on: https://review.typo3.org/58577
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[TASK] Do not render robots metatag on pages with index,follow 90/58590/3
Richard Haeser [Sat, 6 Oct 2018 19:17:57 +0000 (21:17 +0200)]
[TASK] Do not render robots metatag on pages with index,follow

Index,follow is default behaviour for robots. In case that a page have
the index and follow attributes, the robots tag is not generated in
frontend.

Resolves: #86570
Releases: master
Change-Id: I951a25150f48bc16e15e8d10516be0347632cea0
Reviewed-on: https://review.typo3.org/58590
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Marc Hirdes <hirdes@clickstorm.de>
Tested-by: Marc Hirdes <hirdes@clickstorm.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[BUGFIX] Avoid using hardcoded uid of repository record 09/58609/2
Georg Ringer [Wed, 10 Oct 2018 19:31:39 +0000 (21:31 +0200)]
[BUGFIX] Avoid using hardcoded uid of repository record

As some situations might lead to a different uid set in the database
the correct repository should be found by the method 'findOneTypo3OrgRepository'.

Resolves: #86591
Releases: master
Change-Id: I8a1b9e8241b054f4d864dd5474f9eddfeaa44a6c
Reviewed-on: https://review.typo3.org/58609
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Filelist: fix file/folder pasteFileInto in file tree context menu 06/58606/3
Josef Glatz [Wed, 10 Oct 2018 04:30:00 +0000 (05:30 +0100)]
[BUGFIX] Filelist: fix file/folder pasteFileInto in file tree context menu

Provide missing data attributes for the context menu paste action.

Resolves: #86613
Releases: master
Change-Id: Ieafa22ca1456ac51cf217d30dbf1b762c9b6c923
Reviewed-on: https://review.typo3.org/58606
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Tested-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Let FileBrowser render the readable directory path 01/58601/3
Andreas Fernandez [Tue, 9 Oct 2018 12:46:32 +0000 (14:46 +0200)]
[BUGFIX] Let FileBrowser render the readable directory path

The FileBrowser is changed to render the human readable path of a
directory instead of the raw identifier.

Resolves: #86603
Releases: master, 8.7
Change-Id: I437075cfdeb6adaeddd38a55ff6f4fbd5415a351
Reviewed-on: https://review.typo3.org/58601
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[TASK] Fix link in Changelog: Breaking-80929-TYPO3_DBMovedToExtension.rst 83/58583/4
Tomas Norre Mikkelsen [Fri, 5 Oct 2018 16:06:08 +0000 (18:06 +0200)]
[TASK] Fix link in Changelog: Breaking-80929-TYPO3_DBMovedToExtension.rst

Missing space between link text and link-href

Releases: master
Resolves: #86581
Change-Id: I8c8b131eee6b08862c4567f9393dfbdcc17f24d8
Reviewed-on: https://review.typo3.org/58583
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
5 months ago[BUGFIX] Do not cache content with different status code than 200 82/58582/3
Markus Klein [Fri, 5 Oct 2018 08:57:24 +0000 (10:57 +0200)]
[BUGFIX] Do not cache content with different status code than 200

Resolves: #83755
Releases: master, 8.7, 7.6
Change-Id: I6e13133f221137c63283ec1575fc405a38668b1a
Reviewed-on: https://review.typo3.org/58582
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[BUGFIX] Fix site handling documentation 89/58589/2
Georg Ringer [Sat, 6 Oct 2018 19:16:14 +0000 (21:16 +0200)]
[BUGFIX] Fix site handling documentation

Since #86323 the structure of the site yaml file has been changed.
Fix the documentation accordingly.

Resolves: #86587
Releases: master
Change-Id: I776e06d9f790141507b0a884bf9e38f343b015a2
Reviewed-on: https://review.typo3.org/58589
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Christian Knauf <knauf@analog.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Records sitemap uses wrong data array 98/58598/3
Susanne Moog [Tue, 9 Oct 2018 10:12:29 +0000 (12:12 +0200)]
[BUGFIX] Records sitemap uses wrong data array

The records sitemap has an additional level of nesting for
data from database but was trying to access database data
on the first level resulting in missing URL parameters in
generated URLs.

This array access has been fixed.

Resolves: #86602
Releases: master
Change-Id: I0e5e368f177ad2fc4358b8ef8927e220536fa59f
Reviewed-on: https://review.typo3.org/58598
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[BUGFIX] Initialize arguments correctly in routing related ViewHelpers 79/58579/4
Daniel Goerz [Fri, 5 Oct 2018 07:34:51 +0000 (09:34 +0200)]
[BUGFIX] Initialize arguments correctly in routing related ViewHelpers

Being initialized with the correct default value of an empty array
the Viewhelper no longer leads to a fatal error if called without
the argument "parameters".

Additionally the argument "route" is marked as required.

Resolves: #86576
Releases: master
Change-Id: I3457b4292d4409826250d4c5b1ec53d087b2bd95
Reviewed-on: https://review.typo3.org/58579
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[TASK] Improve click area of new content element wizard item 94/58594/4
Josef Glatz [Mon, 8 Oct 2018 03:30:00 +0000 (04:30 +0100)]
[TASK] Improve click area of new content element wizard item

The clickable area of a new content element wizard item
is improved now.

The <a>-tag was added around the Bootstrap 3 media object
childrens which makes it easier now to add a new content
element by clicking anywhere on the item.

The text shows also the hover-style when an editor hovers
the icon of a NCEW item. The user experience for editors
working on touch devices is also improved by this.

Resolves: #86590
Releases: master
Change-Id: Ib6dc65a0d926945e6e9dd8a9fe7b57e5ee27d8f9
Reviewed-on: https://review.typo3.org/58594
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[TASK] Fix formatting of lists in Changelog 87/58587/3
Sybille Peters [Sat, 6 Oct 2018 17:19:22 +0000 (19:19 +0200)]
[TASK] Fix formatting of lists in Changelog

Lists in reStructuredText must be seperated by the rest of a text
a newline. If not, the text is not rendered correctly.
This patch fixes incorrectly formatted lists in the .rst files of
the Changelog.

Resolves: #85995
Releases: master,8.7
Change-Id: Icc390862f77ee99a5f96373e85ef5e09ac4272d5
Reviewed-on: https://review.typo3.org/58587
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Omit `overrideVals` in NewRecordController 61/58561/3
Andreas Fernandez [Tue, 2 Oct 2018 14:51:38 +0000 (16:51 +0200)]
[BUGFIX] Omit `overrideVals` in NewRecordController

In the old times of pages_language_overlay, the "New Record" wizard
automatically re-used the doktype of the parent table which was `pages`.
Since pages_language_overlay vanished, the `overrideVals` in the links in
the wizard use the `pages` table.

This results in invalid value for `doktype` if a page in pid=0 is
created, as pid=0 has no doktype.

For this reason, the `overrideVals` parameter is removed.

Resolves: #86547
Related: #82445
Releases: master
Change-Id: I6efa699e5ef09eed6321ae68b5838682214376de
Reviewed-on: https://review.typo3.org/58561
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[TASK] Info about the new location of _.htaccess / _web.config 64/58564/4
Josef Glatz [Wed, 3 Oct 2018 05:00:00 +0000 (06:00 +0100)]
[TASK] Info about the new location of _.htaccess / _web.config

Resolves: #86484
Releases: master
Change-Id: Ie711a5de0849081389e78dd32b60a3a451e58eec
Reviewed-on: https://review.typo3.org/58564
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
5 months ago[BUGFIX] Only English shown as BE language in Composer mode 60/58560/3
Andreas Wolf [Tue, 2 Oct 2018 14:21:37 +0000 (16:21 +0200)]
[BUGFIX] Only English shown as BE language in Composer mode

Using the legacy path for the l10n files folder does not work anymore in
Composer mode, as the folder was moved into `var/` there.

Change-Id: I61dea0e4e909c5640e776e558ca493015a539015
Resolves: #86546
Releases: master
Reviewed-on: https://review.typo3.org/58560
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[TASK] Add return type declaration to FileDumpController::dumpAction 74/58574/2
Benjamin Franzke [Wed, 3 Oct 2018 20:42:28 +0000 (22:42 +0200)]
[TASK] Add return type declaration to FileDumpController::dumpAction

For historical reasons FileDumpController::dumpAction was allowed to
return null. It didn't specify a nullable return type declaration because
it was not yed decided whether v9 will require php 7.2 or not.
With https://review.typo3.org/55585 FileDumpController was adapted to
return a PSR-7 Response but missed to update the function signature.
The nullable annotation is therefore removed now and the explicit
return type declaration is added.

Change-Id: I10e2cc60ab8e1f023c1beb6cf467bee1800971c8
Releases: master
Resolves: #86564
Reviewed-on: https://review.typo3.org/58574
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Set COMPOSER_ROOT_VERSION=9.5.0 in bamboo 69/58569/2
Christian Kuhn [Wed, 3 Oct 2018 14:50:33 +0000 (16:50 +0200)]
[TASK] Set COMPOSER_ROOT_VERSION=9.5.0 in bamboo

Resolves: #86559
Releases: master
Change-Id: Ic691f77adaa521f1b5d3d7457fa9cfb81ef47663
Reviewed-on: https://review.typo3.org/58569
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Update typo3/class-alias-loader from 1.0.0 to 1.0.1 66/58566/2
Christian Kuhn [Wed, 3 Oct 2018 13:11:15 +0000 (15:11 +0200)]
[TASK] Update typo3/class-alias-loader from 1.0.0 to 1.0.1

Tiny patch level release with cosmetical fixes.

composer update typo3/class-alias-loader

Resolves: #86555
Releases: master, 8.7, 7.6
Change-Id: Ib949e1aa961ea9aede1eeaebd5da9995a2a65bc0
Reviewed-on: https://review.typo3.org/58566
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Use chr(10) instead of LF in functional test data provider 63/58563/2
Christian Kuhn [Wed, 3 Oct 2018 10:04:18 +0000 (12:04 +0200)]
[BUGFIX] Use chr(10) instead of LF in functional test data provider

The functional test splitter script does not define LF and various
other constants, but loads test data providers to find out how
many tests they produce. Those data provider should not use LF,
the splitter throws PHP warnings otherwise.

Resolves: #86552
Releases: master
Change-Id: I89c0748ce595f1f7caee2934f4431b103f60471b
Reviewed-on: https://review.typo3.org/58563
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Adjust conditions for Symfony Expressions in RST-files 57/58557/4
Stefan Neufeind [Tue, 2 Oct 2018 08:35:50 +0000 (10:35 +0200)]
[BUGFIX] Adjust conditions for Symfony Expressions in RST-files

Since the original introduction of some new features the syntax used
for the expression was adjusted globally in TYPO3, leading to
examples no longer up-to-date in the documentation shipped as RSTs.

Resolves: #86541
Releases: master
Change-Id: I3c8b78fe05263a6cca5afa52d61f5ea5afe940a4
Reviewed-on: https://review.typo3.org/58557
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Update installation acceptance tests 59/58559/6
Mathias Brodala [Tue, 2 Oct 2018 13:28:18 +0000 (15:28 +0200)]
[BUGFIX] Update installation acceptance tests

The introduction package was revamped which brought us some text
changes, thus update the installation acceptance tests accordingly.

To mitigate an issue with certain databases causing a wrong casing of
column names, the DefaultTcaSchema now always quotes all column names
with backticks.

Resolves: #86544
Releases: master
Change-Id: Ic91368817bb775379302e904496c35537aaaa13c
Reviewed-on: https://review.typo3.org/58559
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[TASK] Set TYPO3 version to 9.5.1-dev 56/58556/2
Oliver Hader [Tue, 2 Oct 2018 08:11:35 +0000 (10:11 +0200)]
[TASK] Set TYPO3 version to 9.5.1-dev

Change-Id: If916407e7a7d9d54777ecee641bee5a604885ce2
Reviewed-on: https://review.typo3.org/58556
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[RELEASE] Release of TYPO3 9.5.0 55/58555/2 v9.5.0
Oliver Hader [Tue, 2 Oct 2018 08:10:15 +0000 (10:10 +0200)]
[RELEASE] Release of TYPO3 9.5.0

Change-Id: Ibacf4ce5d6c2a2e3f7aafb2c17536ab89dff1c15
Reviewed-on: https://review.typo3.org/58555
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[BUGFIX] Ensure that requirements in RouteEnhancers are optional 54/58554/2
Benni Mack [Tue, 2 Oct 2018 07:39:29 +0000 (09:39 +0200)]
[BUGFIX] Ensure that requirements in RouteEnhancers are optional

Resolves: #86539
Releases: master
Change-Id: Ia0a53b713382ae5cbbc9f5b57c82a532ba8f601b
Reviewed-on: https://review.typo3.org/58554
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[BUGFIX] Streamline PageTypeDecorator handling 53/58553/2
Oliver Hader [Tue, 2 Oct 2018 06:47:36 +0000 (08:47 +0200)]
[BUGFIX] Streamline PageTypeDecorator handling

* uses '&type=xyz' argument value of query in case no PageType decorator
  has been configured or if no value could be resolved (not defined in
  'map' nor as 'default' value)
* allows using 'default' value without having it defined in 'map' (values
  always should be explicit, however this is a fallback handling)

Resolves: #86538
Releases: master
Change-Id: I32ddbaebba916f875f6cd76609fce6b4172eee4d
Reviewed-on: https://review.typo3.org/58553
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
5 months ago[BUGFIX] Do not append slashes on slug importer 52/58552/3
Benni Mack [Tue, 2 Oct 2018 06:17:55 +0000 (08:17 +0200)]
[BUGFIX] Do not append slashes on slug importer

When importing from page_path of RealURL,
a slash is appended for all imported URLs,
however TYPO3 Core does not add slashes at the
end for new pages - which leads to a bad UX, having
mixed values.

However, with route enhancers, it is possible to add slashes
to the very end of a link, so it's useful to NOT have them
anymore inside the database.

Resolves: #86536
Releases: master
Change-Id: I50e941ec97a70654d9974757a6191b416aa40c29
Reviewed-on: https://review.typo3.org/58552
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[TASK] Improve changelog docs 51/58551/2
Daniel Siepmann [Tue, 2 Oct 2018 06:07:28 +0000 (08:07 +0200)]
[TASK] Improve changelog docs

* Fix wrong indentation level in example.
* Adjust sorting of paragraphs for explanation to match order of
  configuration options in example above.
* Keep example consistent. Remove single quotes around two keys in a
  single line, not used in other lines.
* Add syntax highlighting to SiteConfiguration syntax for environment
  variables.

Releases: master
Resolves: #86365, #86409
Change-Id: Ic7923bf7a3215f86637d3a8e20776f74666daf3f
Reviewed-on: https://review.typo3.org/58551
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[BUGFIX] Ensure LoadTcaService loads ext_tables.php 50/58550/2
Benni Mack [Tue, 2 Oct 2018 06:12:39 +0000 (08:12 +0200)]
[BUGFIX] Ensure LoadTcaService loads ext_tables.php

During deprecation of TYPO3_LOADED_EXT,
ext_tables.php is not loaded in "Check TCA in ext_tables.php"
anymore.

The fix loads the file correctly.

Resolves: #86534
Releases: master
Change-Id: If4ab1183704862bed7e2c6f657f8d80d9338d9f4
Reviewed-on: https://review.typo3.org/58550
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[BUGFIX] Reduce amount of false positives of extension scanner 49/58549/5
Georg Ringer [Mon, 1 Oct 2018 22:18:57 +0000 (00:18 +0200)]
[BUGFIX] Reduce amount of false positives of extension scanner

Reduce amount of false positives introduced with #86366 as methods
like 'getTitle()' are used too often.

Resolves: #86533
Releases: master
Change-Id: I97e7406cb5f134042fabf96ea3435c5c2f7ad665
Reviewed-on: https://review.typo3.org/58549
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Do not expand pseudo element `:after` to 100% in modals 47/58547/2
Andreas Fernandez [Mon, 1 Oct 2018 21:18:32 +0000 (23:18 +0200)]
[BUGFIX] Do not expand pseudo element `:after` to 100% in modals

This patch removes the unnecessary `width: 100%` definition. This fixes
the glitch in the image cropper.

Resolves: #86530
Related: #86445
Releases: master
Change-Id: Iaaf6e7f2f69bc526e245ec4b79ece00977c5c5d6
Reviewed-on: https://review.typo3.org/58547
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[TASK] Move documentation files into 9.5 folder - part 2 45/58545/3
Anja [Mon, 1 Oct 2018 19:50:09 +0000 (21:50 +0200)]
[TASK] Move documentation files into 9.5 folder - part 2

Change-Id: Ic2ad05680c072f901c200b05810be958204825db
Releases: master
Resolves: #86434
Reviewed-on: https://review.typo3.org/58545
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Fix decrementing of AJAX requests in extension scanner 39/58539/5
Andreas Fernandez [Mon, 1 Oct 2018 17:55:00 +0000 (19:55 +0200)]
[BUGFIX] Fix decrementing of AJAX requests in extension scanner

The queueing of AJAX requests in the extension scanner has some flaws
which causes the scanner to refuse another scan request.

The counter of pending requests is now always decremented, not only if
the amount of requests equals the threshold. Also, it's now checked if
there is any item in the request queue before shifting.

Instead of overriding the `success` and `error` callback, only `complete`
is now overridden, as this callback is executed on any return state.

To make the queueing part better maintainable and reusable, the code has
been moved into a separate module.

Resolves: #86523
Related: #86436
Releases: master
Change-Id: Ifa26ad7ce3bd81497c43b8606b902d467bdd1dda
Reviewed-on: https://review.typo3.org/58539
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] XmlSitemapRenderer should use TSFE->type for page-type 40/58540/2
Stefan Neufeind [Mon, 1 Oct 2018 19:19:36 +0000 (21:19 +0200)]
[BUGFIX] XmlSitemapRenderer should use TSFE->type for page-type

When the new PageTypeEnhancer resolved type from a URL it is
not part of getQueryParams() but needs to be fetched from TSFE.

Resolves: #86527
Releases: master
Change-Id: I5041b042f1246f2ecc8adc8fa6cba123abfccf5b
Reviewed-on: https://review.typo3.org/58540
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[TASK] Update INSTALL.md and README.md 88/58388/10
Josef Glatz [Tue, 25 Sep 2018 11:55:17 +0000 (13:55 +0200)]
[TASK] Update INSTALL.md and README.md

The main goal of this patch is to update the neglected
INSTALL.md and README.md to represent the current
state of the requirements and to improve the overall
content of the two "entry" documentation files.

The install.md has been massively shortened and links to
the official guides were added to finally be able to have
one source of truth.

Resolves: #86487
Releases: master
Change-Id: Id61abf86a4113d25c940c63f1423fa341aa7e702
Reviewed-on: https://review.typo3.org/58388
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[BUGFIX] Fix EXT:core/bin/typo3 entry point in composer-mode 31/58531/7
Benjamin Franzke [Mon, 1 Oct 2018 11:49:03 +0000 (13:49 +0200)]
[BUGFIX] Fix EXT:core/bin/typo3 entry point in composer-mode

typo3/sysext/core/bin/typo3 does not work in composer mode
currently. Composer-based installations need to use the binary from
the composer "bin-dir", which is fine from a composer-usage point
of view – but hard for documentation.
Additionally the path to "typo3/sysext/core/bin/typo3" is hardcoded
in some places (e.g. scheduler).
We now make sure this binary works in composer mode as well,
using the same entry point strategy as for "typo3/index.php"
and "typo3/install.php".

Change-Id: I400ccd3a2bba4496c5d4ec9482e624cf8270a462
Releases: master
Resolves: #86513
Reviewed-on: https://review.typo3.org/58531
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[BUGFIX] Ensure most site related exceptions are handled 37/58537/6
Markus Klein [Mon, 1 Oct 2018 16:47:53 +0000 (18:47 +0200)]
[BUGFIX] Ensure most site related exceptions are handled

Make sure that in most places any site related exception is handled
in a graceful way to avoid negative UX.

Resolves: #86522
Releases: master
Change-Id: I3b0d7f9ce63351f8dd7bb6b4988704fc8a3d0a9f
Reviewed-on: https://review.typo3.org/58537
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jurian Janssen <jurian.janssen@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Resolve slashed values in PageTypeDecorator correctly 12/58512/15
Oliver Hader [Sun, 30 Sep 2018 22:52:13 +0000 (00:52 +0200)]
[BUGFIX] Resolve slashed values in PageTypeDecorator correctly

* slashed values are not resolved correctly concerning their
  dynamic '/' prefix in route paths
* adjusting route path and parameters might cause side effects
  when dealing with multiple decorating enhancers
* test cases for resolving and generating URIs using new
  PageTypeDecorator enhancer are added

Resolves: #86506
Releases: master
Change-Id: I3757933c47ea0f06d88bb27a635c2077e8f673b1
Reviewed-on: https://review.typo3.org/58512
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[BUGFIX] Make redirect sources with Query matchable 22/58522/6
Daniel Goerz [Mon, 1 Oct 2018 11:26:33 +0000 (13:26 +0200)]
[BUGFIX] Make redirect sources with Query matchable

Resolves: #86503
Releases: master
Change-Id: Iaf924b9f851bd25cb2d16ab5e5656703603a669b
Reviewed-on: https://review.typo3.org/58522
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[TASK] Streamline phpdoc annotations in EXT:extbase 35/58535/2
Benni Mack [Mon, 1 Oct 2018 16:03:21 +0000 (18:03 +0200)]
[TASK] Streamline phpdoc annotations in EXT:extbase

EXT:extbase uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:extbase: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

On top, all license headers and @license annotations have been streamlined.

This means:
- TYPO3 Core's PHP classes area all public API by default
   unless marked as @internal or an extension class
- @api is not allowed anymore and will be restricted in
   the future from adding.
- @internal should be used for everything that should
   not be explicitly exposed as public API in the future.
- Everything under Tests/ is not part of TYPO3's Public API

Resolves: #86521
Releases: master
Change-Id: I83c5a27d9af001929142d2620600668ad0a84c92
Reviewed-on: https://review.typo3.org/58535
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[BUGFIX] Ensure Uri->getQuery() always returns a string 34/58534/2
Daniel Goerz [Mon, 1 Oct 2018 14:47:47 +0000 (16:47 +0200)]
[BUGFIX] Ensure Uri->getQuery() always returns a string

As stated in the Interface:
If no query string is present, this method MUST return an empty string.

Resolves: #86520
Releases: master, 8.7
Change-Id: I9869af08c84262443e503c34a2c608fbc5ba4bc2
Reviewed-on: https://review.typo3.org/58534
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[BUGFIX] Add user authentication to activate extension command 36/58536/2
Susanne Moog [Mon, 1 Oct 2018 16:24:39 +0000 (18:24 +0200)]
[BUGFIX] Add user authentication to activate extension command

As extensions might contain data to import the activate extension
command needs to initialize the user authentication so the data
handler may import data.

The backend user authentication initialization has been added to
the activate extension command.

Resolves: #86161
Releases: master
Change-Id: Id25c45bdfc8ac1cb930c9ed6adb49c39c17d7952
Reviewed-on: https://review.typo3.org/58536
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>