Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Install Tool image tests: black background after scaling 27/31827/2
Susanne Moog [Fri, 25 Jul 2014 15:05:48 +0000 (17:05 +0200)]
[BUGFIX] Install Tool image tests: black background after scaling

Transparent turns black unless you specify a different color
because transparent = unset color = 0 = black. We should fix this
by adding the "-opaque white -background white -flatten"
parameters for the convert action done
by the install tool.

Change-Id: I5dd5c41852a33159752702b68ce0a297b33cf569
Releases: 6.3, 6.2
Fixes: #60570
Reviewed-on: http://review.typo3.org/31827
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Extension manager page browser not disabled on list update 24/31824/2
Susanne Moog [Fri, 25 Jul 2014 17:22:53 +0000 (19:22 +0200)]
[BUGFIX] Extension manager page browser not disabled on list update

The extension list on "get extensions" only masks the table when
loading where it should also mask the page browser as you will get
errors when using it while the list is still loading.

The mask now covers the whole ter table content.

Change-Id: I404e4f1a5b9b62a53392491c911d654ce6f007b3
Releases: 6.2, 6.3
Fixes: #55317
Reviewed-on: http://review.typo3.org/31824
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Add missing unit test for enumeration 19/31819/2
Sascha Egerer [Fri, 25 Jul 2014 16:00:56 +0000 (18:00 +0200)]
[TASK] Add missing unit test for enumeration

Add unit test that checks if the constructor throws
an exception if an invalid value is requested.

Resolves: #60572
Releases: 6.3, 6.2
Change-Id: I2179414f94bbd6465c5b780c71dfed3c91e71776
Reviewed-on: http://review.typo3.org/31819
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Respect global renderReadonly in Tceforms for tree 15/31815/2
Lorenz Ulrich [Tue, 24 Jun 2014 12:45:48 +0000 (14:45 +0200)]
[BUGFIX] Respect global renderReadonly in Tceforms for tree

The global renderReadonly status in Tceforms doesn't affect a
rendered tree because the check was forgotten when #25888 was
implemented. An additional check is added.

Resolves: #59849
Releases: 6.3, 6.2
Change-Id: Ic89ab2f39636dbbb7dc37941af8fe7be085fefcf
Reviewed-on: http://review.typo3.org/31815
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Menu-links generate two empty spaces at closing anchor 82/31682/2
Tomita Militaru [Tue, 12 Nov 2013 15:52:33 +0000 (17:52 +0200)]
[BUGFIX] Menu-links generate two empty spaces at closing anchor

Checks for ATagParams & access key code before adding empty
spaces between anchor parameters.

Resolves: #50566
Releases: 6.3, 6.2, 6.1
Change-Id: I57a2a2a06a97fc1eda6e0438bfdc6e210437e5bb
Reviewed-on: http://review.typo3.org/31682
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Adjust comment for default HTTP-userAgent 35/31735/2
Stefan Neufeind [Wed, 16 Jul 2014 21:14:06 +0000 (23:14 +0200)]
[BUGFIX] Adjust comment for default HTTP-userAgent

The default userAgent is for example TYPO3/6.2.4

Change-Id: I2412b901a3a42938a433e7d8a414de24587011a3
Resolves: #60365
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31735
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Fix wrong named unit tests of the logging framework 04/31804/2
Sascha Egerer [Thu, 24 Jul 2014 20:50:44 +0000 (22:50 +0200)]
[TASK] Fix wrong named unit tests of the logging framework

Most of the unit tests for the logging framework have a
wrong filename and also a wrong classname.

Resolves: #60547
Releases: 6.3, 6.2
Change-Id: I5aaad54566bd33a9caf0d665655d9cb0f4552119
Reviewed-on: http://review.typo3.org/31804
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Add wrapper for GeneralUtility::getIndpEnv in ContentObjectRenderer 92/31792/2
Sascha Egerer [Fri, 25 Jul 2014 08:15:35 +0000 (10:15 +0200)]
[TASK] Add wrapper for GeneralUtility::getIndpEnv in ContentObjectRenderer

A wrapper function for GeneralUtility::getIndpEnv() is required
to mock these static calls in unit tests.

Resolves: #60549
Releases: 6.3, 6.2
Change-Id: I47b565f5a5bd9b2445847d38447c01cfa20954c7
Reviewed-on: http://review.typo3.org/31792
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Make call to isPackageKeyValid non-static 78/31778/2
Peter Niederlag [Thu, 24 Jul 2014 10:50:24 +0000 (12:50 +0200)]
[BUGFIX] Make call to isPackageKeyValid non-static

Function isPackagKeyValid on PackageManeger is not a static function
and must be called on an object instance.

Resolves: #59619
Releases: 6.3, 6.2
Change-Id: I03b068db00ccdf76b6e8658721e630b7de6ebfd8
Reviewed-on: http://review.typo3.org/31778
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Turn isOnSymmetricSide into static function 77/31777/2
Peter Niederlag [Thu, 24 Jul 2014 10:20:20 +0000 (12:20 +0200)]
[BUGFIX] Turn isOnSymmetricSide into static function

Function isOnSymmetricSide of RelationHandler is used as
static function all the time so we properly turn the function
declaration into a static one.

Resolves: #60516
Releases: 6.3, 6.2
Change-Id: I72a922596e69dca26e173dad5b42da76e0949865
Reviewed-on: http://review.typo3.org/31748
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
(cherry picked from commit 0674579840c2785323cba9d3e860c768f875ddf3)
Reviewed-on: http://review.typo3.org/31777

5 years ago[TASK] Keep the changes to PackageStates.php low 74/31774/2
Markus Klein [Fri, 28 Feb 2014 10:06:34 +0000 (11:06 +0100)]
[TASK] Keep the changes to PackageStates.php low

Introduce a sort operation of the packages before determining
the loading order.
This way the number of changes made to the PackageStates.php file
are reduced.

This is only a first step, further improvements have to be made
to finally resolve #56362.

Resolves: #56362
Releases: 6.3, 6.2
Change-Id: Id6cc4cc2d3f4d9f00e90f355bdede1afe20f57af
Reviewed-on: http://review.typo3.org/31774
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Add label for title of "Edit metadata" link 72/31772/2
Markus Klein [Sun, 20 Jul 2014 15:28:43 +0000 (17:28 +0200)]
[BUGFIX] Add label for title of "Edit metadata" link

Currently the title of the "Edit metadata" link in filelist is
hardcoded. Add a label to make it translatable.

Resolves: #60410
Releases: 6.3, 6.2
Change-Id: Id618dfcd96ae3b4558cf9d529e0cc7c3ae220f9a
Reviewed-on: http://review.typo3.org/31772
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[TASK] Remove skipped FAL functional tests 69/31769/2
Christian Kuhn [Thu, 24 Jul 2014 16:02:10 +0000 (18:02 +0200)]
[TASK] Remove skipped FAL functional tests

Utility/File/ExtendedFileUtilityTest.php contains some old FAL
related tests that are not maintained for quite some time, broken
and skipped.
Functional tests for FAL should be re-written if needed from scratch
so these tests are removed for now.

Resolves: #60541
Releases: 6.3, 6.2
Change-Id: Ib703f5c4bbd5d52ef5c67f0fc2f2387772c315fd
Reviewed-on: http://review.typo3.org/31769
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Add a "save and close" button in the extensionmanager 66/31766/2
Eric Chavaillaz [Mon, 23 Jun 2014 16:08:17 +0000 (18:08 +0200)]
[TASK] Add a "save and close" button in the extensionmanager

Resolves: #59812
Releases: 6.3, 6.2
Change-Id: I3ccfbdd496af2fca9a72d2675393537eafffd075
Reviewed-on: http://review.typo3.org/31766
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Catch freshly introduced ResourceDoesNotExistException 65/31765/2
Anja Leichsenring [Thu, 24 Jul 2014 13:55:29 +0000 (15:55 +0200)]
[BUGFIX] Catch freshly introduced ResourceDoesNotExistException

Change #60506 introduced a new specific exception in case a file
reference can not be resolved. This new exception now needs to be
catched on the right places.

Change-Id: I545f4eb98386918903380cc3d0b34796a0917b3f
Resolves: #60529
Relates: #60506
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31765
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Fix resource exceptions 57/31757/2
Helmut Hummel [Wed, 23 Jul 2014 18:50:56 +0000 (20:50 +0200)]
[BUGFIX] Fix resource exceptions

When rendering the FILES content object,
exceptions due to missing file references and missing collections
are meant to be caught. However they are not, because
InvalidArgumentException and RuntimeException are thrown instead of
ResourceDoesNotExistException

Throw the appropriate exceptions instead and also
fix a wrong check in RecordCollection Repository, where
the return type is checked against NULL while the DB
call returns FALSE when no record is found.

Resolves: #60506
Releases: 6.2, 6.3
Change-Id: I9cea492d814850f75549d280c2de0defc8b91548
Reviewed-on: http://review.typo3.org/31757
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Set correct cookie when permalogin is enabled 54/31754/2
Gernot Schulmeister [Mon, 14 Jul 2014 21:17:37 +0000 (23:17 +0200)]
[BUGFIX] Set correct cookie when permalogin is enabled

Although permalogin is enabled we set a session cookie.
This happens because setSessionCookie is called too early
and we do not know yet whether the session should be permanent
and an according cookie shall be set or not.

Solution is to set $this->dontSetCookie = FALSE
which triggers setting the cookie at an appropriate time.

Resolves: #60264
Releases: 6.3, 6.2
Change-Id: Iad5ce8597f90c4a607a43ea4d3368d117fa6b4ed
Reviewed-on: http://review.typo3.org/31754
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Change sys_file.size type from INT to BIGINT 52/31752/2
Stefan Neufeind [Wed, 23 Jul 2014 11:05:37 +0000 (13:05 +0200)]
[BUGFIX] Change sys_file.size type from INT to BIGINT

Regular INT limits filesize to 2GB.

Change-Id: I525bd53bff6495630bd5880c8ef8789a1d9bbf26
Resolves: #60327
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31752
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Complete datatable structure fe_groups 47/31747/2
Markus Guenther [Thu, 10 Jul 2014 15:24:34 +0000 (17:24 +0200)]
[BUGFIX] Complete datatable structure fe_groups

While creating frontend groups via extbase without any subgroup set,
the record will have the value NULL in the database
for the property subgroup.
This leads to an exception.

This patch only defines TSconfig, subgroups and description not
to accept NULL and to be consistent the tx_extbase_type gets
the default value 0.

Resolves: #60245
Releases: 6.3, 6.2
Change-Id: Ie402d4c47058755efe40cc762f4220ba7dc6b781
Reviewed-on: http://review.typo3.org/31747
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Catch all resource exceptions when parsing RTE links 45/31745/2
Helmut Hummel [Mon, 14 Jul 2014 16:00:30 +0000 (18:00 +0200)]
[BUGFIX] Catch all resource exceptions when parsing RTE links

The RteHtmlParser checks for valid links by trying to retrieve
a file or folder object. The FAL API will throw exceptions
if anything goes wrong with the given path.

Catch all these exceptions to ignore the invalid link
and act the same for invalid paths as for not found files/ folders

Releases: 6.2, 6.3
Resolves: #60316
Change-Id: I0752678eb8ed2b596c3a88536d957ec35c172d7b
Reviewed-on: http://review.typo3.org/31745
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Wrong sys_refindex for deleted child records 38/31738/2
Oliver Hader [Thu, 10 Jul 2014 16:53:03 +0000 (18:53 +0200)]
[BUGFIX] Wrong sys_refindex for deleted child records

Workspace actions using the DataHandler trigger a reprocessing
of the reference index. However, it happened that index entries
of the live workspace have been deleted or modified.

The reason for that is a missing SQL statement to limit those
actions to the current workspace only.

The result can be seen in e.g. the workspace module after
having deleted an IRRE child record and how the nesting could
not be determined correctly for that particular record.

Resolves: #59874
Releases: 6.2, 6.3
Change-Id: I850e2fe88999ce8db280d4ef426e43c85fff06da
Reviewed-on: https://review.typo3.org/31738
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[TASK] Update wrong copyright header in file BrowseLinks.php 33/31733/2
Michael Schams [Wed, 23 Jul 2014 01:54:56 +0000 (11:54 +1000)]
[TASK] Update wrong copyright header in file BrowseLinks.php

A new header in PHP files has been introduced with #59535. This
patch updates the copyright/license header of one file, which still
uses the old, outdated information.

Resolves: #60482
Releases: 6.3, 6.2
Change-Id: I642a4ce13331e2aadbd362988b963a8a5c576a29
Reviewed-on: https://review.typo3.org/31733
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix return value of DatabaseConnection::sql_free_result() 19/31719/2
Stefano Kowalke [Tue, 22 Jul 2014 10:57:50 +0000 (12:57 +0200)]
[BUGFIX] Fix return value of DatabaseConnection::sql_free_result()

In case of success the current implementation returns the result
of $res->free(). Unfortunately free() doesn't return anything.
That causes sql_free_result() to return NULL, which eventually
evaluates to FALSE.

Make sure the return value is correct and
return TRUE in case of success.

Resolves: #60457
Releases: 6.2, 6.3
Change-Id: I8756d4d2a321adc88738b9ac418207c63b312c86
Reviewed-on: https://review.typo3.org/31719
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fix minor issues in functional testing framework 04/31704/2
Helmut Hummel [Sun, 20 Jul 2014 15:03:22 +0000 (17:03 +0200)]
[BUGFIX] Fix minor issues in functional testing framework

The bootstrap for frontend functional tests has some
minor issues, that are now fixed:

* json_decode returns null not false when not successfull
* Properly set the SERVER_PORT
* Use correct array key in error message
* Avoid notices with relative URLs

Releases: 6.2, 6.3
Resolves: #60413
Change-Id: I3ff07f01729d3403374759edbaa5ddcccd2e889a
Reviewed-on: https://review.typo3.org/31704
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] sys_collection_entries column too small 98/31698/2
Wouter Wolters [Thu, 10 Jul 2014 18:37:44 +0000 (20:37 +0200)]
[BUGFIX] sys_collection_entries column too small

Set sys_collection_entries to varchar(64). This is the max
table name length on MySQL.

Resolves: #60180
Releases: 6.3,6.2
Change-Id: I253e6eb6cb35db9e6d13a716bfc5c8d89db4ca7e
Reviewed-on: https://review.typo3.org/31698
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Send test email in Install Tool as HTML 84/31684/2
Wouter Wolters [Thu, 10 Jul 2014 19:27:20 +0000 (21:27 +0200)]
[BUGFIX] Send test email in Install Tool as HTML

Explicitly set the format of the email body to text/html.

Resolves: #60251
Releases: 6.3, 6.2
Change-Id: I350b0f4cb9e69cd20dbd439647f56cd9c641b501
Reviewed-on: https://review.typo3.org/31684
Reviewed-by: Pascal Dürsteler <pascal.duersteler@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Avoid PHP warning in TypoScriptFrontendController 85/31685/2
Markus Klein [Mon, 7 Jul 2014 21:05:36 +0000 (23:05 +0200)]
[BUGFIX] Avoid PHP warning in TypoScriptFrontendController

TypoScriptFrontendController throws a PHP warning on access to
$BE_USER->user['uid'] which might not be set.
Fix this by simply adding an empty() check.

Resolves: #60126
Releases: 6.3, 6.2
Change-Id: I7005baf73bce55d862b4b6b61697c2aa0a877c7b
Reviewed-on: https://review.typo3.org/31685
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[CLEANUP] Final cleanup of TCA Overrides 24/31624/2
Helmut Hummel [Mon, 14 Jul 2014 22:49:33 +0000 (00:49 +0200)]
[CLEANUP] Final cleanup of TCA Overrides

Some of the files still miss the die statement in
the first line. To be consistent, add it to every
file.

One file had a check for TYPO3_MODE === BE which
is wrong in these files because the result is
cached.

If the first hit with empty cache is done in a FE
request, a wrong result would be cached.

Releases: 6.2, 6.3
Resolves: #60317
Change-Id: I839499100da28ba11d5dcbf81fde87b30b61de81
Reviewed-on: https://review.typo3.org/31624
Reviewed-by: Markus Klein <klein.t3@mfc-linz.at>
Tested-by: Markus Klein <klein.t3@mfc-linz.at>
5 years ago[TASK] Fix composer branch alias for 6.2 branch 05/31605/2
Helmut Hummel [Sat, 12 Jul 2014 21:38:51 +0000 (23:38 +0200)]
[TASK] Fix composer branch alias for 6.2 branch

The composer.json file wrongly configures the
master branch to be aliased to 6.2.x-dev

Fix it by aliasing our TYPO3_6-2 branch to 6.2.x-dev

Releases: 6.2
Change-Id: I89d91aa011cc384e0868913bbbe3add50585866e
Reviewed-on: https://review.typo3.org/31605
Reviewed-by: Christian Opitz <christian.opitz@netresearch.de>
Tested-by: Christian Opitz <christian.opitz@netresearch.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Use PATH_site in cache identifier for package cache 80/31580/2
Helmut Hummel [Thu, 10 Jul 2014 16:10:10 +0000 (18:10 +0200)]
[BUGFIX] Use PATH_site in cache identifier for package cache

The package cache writes paths to extension directories
(TYPO3_LOADED_EXT) into the cache.

This will result in wrong caches when the same
TYPO3 instance is called from a different absolute
directory e.g. from a different mount or symlink.

To avoid this, the cache identifier now includes
PATH_site which is the current absolute path
of the TYPO3 instance.

Additionally we now only include the modification
time of the package states file instead of the
md5 of the complete content into account, which should
be much faster and also enough.

Resolves: #58288
Releases: 6.2, 6.3
Change-Id: I7c8de41c608beab282f2b8bbeab39f257a9a6a6f
Reviewed-on: https://review.typo3.org/31580
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[TASK] Extend Regular DataHandler functional tests 88/31588/2
Oliver Hader [Wed, 25 Jun 2014 13:02:24 +0000 (15:02 +0200)]
[TASK] Extend Regular DataHandler functional tests

* add third tt_content element with localization in live context
* add new tt_content delete placeholder in different workspace
* populate changes to all scenarios in live and workspace context

Releases: 6.2, 6.3
Resolves: #59881
Change-Id: I644e264048a5c33c0a613d5f8440975cabd40721
Reviewed-on: https://review.typo3.org/31588
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Clarify exception message for addPlugin() 62/31562/2
Helmut Hummel [Thu, 10 Jul 2014 13:52:52 +0000 (15:52 +0200)]
[TASK] Clarify exception message for addPlugin()

Add verbosity to the exception message to make it
more clear what is going wrong.

Releases: 6.2, 6.3
Resolves: #60225
Change-Id: I7bb4a16ff94d05b8b97633383d42c61aa600b1cf
Reviewed-on: https://review.typo3.org/31562
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix page module styling in Languages view 35/31535/2
Tomita Militaru [Tue, 8 Jul 2014 09:44:18 +0000 (12:44 +0300)]
[BUGFIX] Fix page module styling in Languages view

Change in height of table header row for Languages view.

Resolves: #56714
Releases: 6.3, 6.2
Change-Id: Ic6bab8a99695798ecfc115209aec41e241870925
Reviewed-on: https://review.typo3.org/31535
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Collapse icon for accordion not centered in Install Tool 26/31526/2
Wouter Wolters [Tue, 8 Jul 2014 21:24:04 +0000 (23:24 +0200)]
[BUGFIX] Collapse icon for accordion not centered in Install Tool

Resolves: #60192
Releases: 6.3,6.2
Change-Id: I4bacce041ca3be3dce4cae1a7407ab3fdf301ff0
Reviewed-on: https://review.typo3.org/31526
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Log errors after initial t3d import also if pages are created 23/31523/2
Marc Bastian Heinrichs [Wed, 14 May 2014 10:33:07 +0000 (12:33 +0200)]
[TASK] Log errors after initial t3d import also if pages are created

Errors are only logged if no pages are created on initial data.t3d
import. They should be logged generally.

Resolves: #58798
Releases: 6.3, 6.2
Change-Id: Ia859d12ec567a1b64bb9b65dd41f5ba996de3139
Reviewed-on: https://review.typo3.org/31523
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Followup to CacheBackend patch 21/31521/2
Markus Klein [Tue, 8 Jul 2014 21:00:10 +0000 (23:00 +0200)]
[BUGFIX] Followup to CacheBackend patch

Re-add a missing use statement that vanished during rebase.

Resolves: #59587
Releases: 6.3, 6.2, 6.1
Change-Id: I16ac1b9d5a00c4300202eaef493de43fc988a81d
Reviewed-on: https://review.typo3.org/31521
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Too many tags by identifier in CacheBackends 18/31518/3
Alexander Opitz [Tue, 17 Jun 2014 07:58:32 +0000 (09:58 +0200)]
[BUGFIX] Too many tags by identifier in CacheBackends

This applies to Apc/Memcached/Wincache/Xcache backends.

After an array_merge the values aren't unique. This leads to duplicate
tags per identifier. This patch changes that and also moves the
findTagsByIdentifier call out of the foreach loop.

Resolves: #59587
Releases: 6.3, 6.2, 6.1
Change-Id: Id31e16fa4bba11038ba692a483fb9a33808d95fa
Reviewed-on: https://review.typo3.org/31518
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Set TYPO3 version to 6.2.5-dev 13/31513/2
TYPO3 Release Team [Tue, 8 Jul 2014 13:05:27 +0000 (15:05 +0200)]
[TASK] Set TYPO3 version to 6.2.5-dev

Change-Id: Ic7579af60139fe36862ddeb124c3fe8711750acc
Reviewed-on: https://review.typo3.org/31513
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.4 12/31512/2 6.2.4 TYPO3_6-2-4
TYPO3 Release Team [Tue, 8 Jul 2014 13:04:53 +0000 (15:04 +0200)]
[RELEASE] Release of TYPO3 6.2.4

Change-Id: I2f41d693c2f9b7c0e919e5c1566d3a3fba99178d
Reviewed-on: https://review.typo3.org/31512
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Fix wrong type hint for emitAfterExtensionT3DImportSignal() 07/31507/2
Markus Klein [Tue, 8 Jul 2014 10:55:07 +0000 (12:55 +0200)]
[BUGFIX] Fix wrong type hint for emitAfterExtensionT3DImportSignal()

Fix a wrong type hint for the second parameter in
InstallUtility::emitAfterExtensionT3DImportSignal(). The parameter is of
type integer and not array.

Resolves: #60179
Releases: 6.3, 6.2
Change-Id: Iccfb7445bd374edaecfd3408380034dbec82e539
Reviewed-on: https://review.typo3.org/31507
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Superfluous SQL queries on copying records 02/31502/2
Oliver Hader [Thu, 3 Jul 2014 11:12:20 +0000 (13:12 +0200)]
[BUGFIX] Superfluous SQL queries on copying records

On copying a page in the backend there are lots of superfluous
SQL queries containing "... WHERE uid=0". The reason for that
is, that DataHandler::recordInfo() is called for each field
which then tries to fetch the database record for the given
uid "NEW...". Casting the new record placeholder to an integer
value ends up with the "uid=0" condition.

In a test with copying a page with some sub-pages, there was a
total of about 1300 SQL queries, 300 of them have been those
superfluous "uid=0" SELECT statements.

Resolves: #58357
Releases: 6.2, 6.3
Change-Id: Ib7006a7ceb52376032df8eaefaa918407718a482
Reviewed-on: https://review.typo3.org/31502
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Followup to read only filemounts 01/31501/2
Helmut Hummel [Tue, 8 Jul 2014 09:57:28 +0000 (11:57 +0200)]
[BUGFIX] Followup to read only filemounts

Fix tests by provide proper mocking of the storage

Resolves: #49391
Resolves: #57979
Releases: 6.2, 6.3
Change-Id: I2cd9e1bcffd082e861a7c8ae2fba6c68b461a8cc
Reviewed-on: https://review.typo3.org/31501
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Re-introduce read-only file mounts 96/31496/2
Lorenz Ulrich [Mon, 23 Jun 2014 13:41:17 +0000 (15:41 +0200)]
[BUGFIX] Re-introduce read-only file mounts

This re-introduces the read-only file mounts that were silently dropped
in TYPO3 6.0.

File mounts can be added by User TSconfig the same way they were added
in TYPO3 4.x. But since FAL added Storages, the storage needs to be
configurable.

options.folderTree.altElementBrowserMountPoints = 3:/test

This adds the folder "test" of storage 3 as read-only mount in the File
List and the Element Browser. The old syntax is still supported:

options.folderTree.altElementBrowserMountPoints = documents

If no storage is configured, it is assumed that the folder is in the
default storage.

Resolves: #49391
Resolves: #57979
Documentation: #59648
Releases: 6.3, 6.2
Change-Id: I648c8ae15d4add98cd55e2f9c27d89d8e49d6152
Reviewed-on: https://review.typo3.org/31496
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Movements pollute colPos value of content elements 92/31492/2
Nicole Cordes [Tue, 8 Jul 2014 07:53:33 +0000 (09:53 +0200)]
[BUGFIX] Movements pollute colPos value of content elements

Due to commit I148ca1b023226f2f99417b3baf238b72346e721f the information
concerning previous and next content elements in one row is messed up.
This patch helps to build information which depends on colPos again and
prevents records being moved to another column.

Resolves: #48939
Resolves: #49055
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I3a15321ee11a1f7d96b58b8b7a5ab14098664b22
Reviewed-on: https://review.typo3.org/31492
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Update phpdoc @return of exec_SELECTgetSingleRow() 90/31490/2
Markus Klein [Tue, 8 Jul 2014 08:12:21 +0000 (10:12 +0200)]
[TASK] Update phpdoc @return of exec_SELECTgetSingleRow()

DatabaseConnection::exec_SELECTgetSingleRow() may return FALSE if no row
is found. This is not reflected in the phpdoc for the return value.

This patch adds the necessary information to the doc header.

Resolves: #60172
Releases: 6.3, 6.2
Change-Id: Ia07868c2a1e8fad5b1d53d89ff0a959c2bcf9e3a
Reviewed-on: https://review.typo3.org/31490
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1 80/31480/2
Alexander Bigga [Fri, 27 Jun 2014 12:57:39 +0000 (14:57 +0200)]
[BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1

Using the TCA select renderMode=tree with the option
minitems=1 AND maxitems=1
leads to two bugs since TYPO3 4.5:

First #48943
* A new table entry won't mark the field selection as required. The yellow
  question mark is missing and you can save the entry.
* Once you select a checkbox in the tree and unselect it again, the
  required-check is working.

Second: #31637
* You load an existing table entry with a selection of e.g. a category
  which has been hidden or deleted. The selected checkbox won't be shown,
  but the required-check fails.
* Even worse: You can't select another category as the form thinks you
  have already selected one item (maxitem=1). You can fix this only by
  manipulating the database directly.

The reason for these bugs can be found in
DataPreprocessor::renderRecord_selectProc(). For maxitems = 1 the
foreign_table element ids for the tree will be fetched by getDataIdList().
These elements won't be checked whether they are valid (hidden/deleted).
This check is done in selectAddForeign() which is used for maxitems > 1.

The patch uses the same procedure as for maxitems > 1 in case
of renderMode = tree.

Resolves: #48943
Resolves: #31637
Releases: 6.3, 6.2, 6.1
Change-Id: I078ff524ea73951f2121d2c233a46bc2ae562952
Reviewed-on: https://review.typo3.org/31480
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix suggest wizard item selection 79/31479/2
Benoit Chenu [Mon, 2 Jun 2014 11:44:36 +0000 (13:44 +0200)]
[BUGFIX] Fix suggest wizard item selection

When selecting an item in a suggest list, the first label is always
taken instead of the clicked one.

Resolves: #55835
Releases: 6.3, 6.2
Change-Id: I7590cb290ee19fd807260ef5767805a23ef088b0
Reviewed-on: https://review.typo3.org/31479
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] LiveSearchToolbarItem not initialized correctly 77/31477/2
Gernot Schulmeister [Mon, 7 Jul 2014 21:33:42 +0000 (23:33 +0200)]
[BUGFIX] LiveSearchToolbarItem not initialized correctly

Initialising the LiveSearchToolbarItem class with two leading
backslashes \\ prevents XClasses of the LiveSearchToolbarItem
to be found by the GeneralUtility:makeInstance() function.

Resolves: #59959
Releases: 6.3, 6.2
Change-Id: Iab6bb31379090fa5770ed20f8fa8113e61071fe0
Reviewed-on: https://review.typo3.org/31477
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix position of buttons in RTE full screen mode 76/31476/2
Markus Klein [Mon, 7 Jul 2014 21:20:49 +0000 (23:20 +0200)]
[BUGFIX] Fix position of buttons in RTE full screen mode

Update the HTML markup for the action buttons in the RTE full screen
view to properly position the buttons there.

Releases: 6.3, 6.2
Resolves: #60119
Change-Id: I0c06dd5fa5a7975a3ddcddb58c3b44d41da2192a
Reviewed-on: https://review.typo3.org/31476
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Refactor extension upload controller 67/31467/2
Nicole Cordes [Fri, 4 Jul 2014 22:17:32 +0000 (00:17 +0200)]
[TASK] Refactor extension upload controller

The upload and install functions are needed by the extension coreapi.
In order to support the extension, the UploadExtensionFileController
is refactored and necessary functions are extracted to public functions.

Resolves: #59999
Releases: 6.2, 6.3
Change-Id: I21e734d1ecae2e7c8e7c3f72e129ef1f57532886
Reviewed-on: https://review.typo3.org/31467
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere 65/31465/2
Julian Hofmann [Wed, 8 Jan 2014 17:22:33 +0000 (18:22 +0100)]
[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere

Using PAGE_TSCONFIG_*-values in the foreign_table_where-clause limits
the entries. This where clause is also used for the suggest wizard, but
the markers are not replaced there.
PAGE_TSCONFIG_*-values are now supported in the suggest wizard too.

Resolves: #54843
Releases: 6.3, 6.2
Documentation: #60160
Change-Id: Ieb53d48ca0ddf22bbbbc4aed4d1e83220a82ec09
Reviewed-on: https://review.typo3.org/31465
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Move signals to own emit functions 52/31452/2
Nicole Cordes [Mon, 7 Jul 2014 07:49:33 +0000 (09:49 +0200)]
[TASK] Move signals to own emit functions

Two new signals were introduced with the patch
https://review.typo3.org/#/c/27746/. This patch moves the dispatch of
the signals into own functions to improve the tracing of signals.

Resolves: #60133
Releases: 6.3, 6.2
Change-Id: Iecb7ff25ec31556c939dff6b0cf8749ebd3ff997
Reviewed-on: https://review.typo3.org/31452
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Report migration errors in TceformsUpdateWizard 28/31428/2
Steffen Müller [Wed, 2 Apr 2014 20:38:31 +0000 (22:38 +0200)]
[BUGFIX] Report migration errors in TceformsUpdateWizard

TceformsUpdateWizard should report errors if a migration
failed due to a missing source file.

Resolves: #57575
Releases: 6.3, 6.2
Change-Id: I68af9a5155f7d6190a22cc4986ef4a467b747737
Reviewed-on: https://review.typo3.org/31428
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Detect missing files in empty storage 27/31427/2
Robert Vock [Tue, 3 Jun 2014 11:56:15 +0000 (13:56 +0200)]
[BUGFIX] Detect missing files in empty storage

Improve the check for missing files by properly treating
the case when a storage is empty.

Change-Id: I8fba9be2622a4cd742c0065b68a8daf77f8a484a
Resolves: #54414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31427
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] Wrong image reference handling during flexform copying 25/31425/2
Alexey Gafiulov [Thu, 19 Jun 2014 16:12:42 +0000 (22:12 +0600)]
[BUGFIX] Wrong image reference handling during flexform copying

References in flexforms having type=inline are not processed correctly
during copy.

Fix this by properly applying the reference field check.

Resolves: #59664
Releases: 6.3, 6.2, 6.1
Change-Id: I1abfa001ba420531ca0c59903e82b1509e0819e0
Reviewed-on: https://review.typo3.org/31425
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[FEATURE] Add signal slots to SoftReferenceIndex 23/31423/2
Alexander Stehlik [Mon, 10 Mar 2014 09:42:59 +0000 (10:42 +0100)]
[FEATURE] Add signal slots to SoftReferenceIndex

This patch adds two signal slot dispatch calls to the SoftReferenceIndex
in the getTypoLinkParts() method and the setTypoLinkPartsElement()
methods.

These slots allow third party link handlers to generate their own
soft reference data.

Resolves: #21396
Releases: 6.3, 6.2
Change-Id: If2bbcd1757ed480f31c1bdccd69bba2a77df9a8f
Reviewed-on: https://review.typo3.org/31423
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Optimize invocation of cObj::checkIf 18/31418/2
Oliver Hader [Mon, 20 Jan 2014 15:52:37 +0000 (16:52 +0100)]
[TASK] Optimize invocation of cObj::checkIf

The stdWrap property "if" can be used to allow output only if a
defined criterion is met. However, the checkIf() method gets
called even if the property is not set in TypoScript.

Fix this by adding a quick empty() check to all calls.
Also optimizes the code structure to exit early in case the if
does not evaluate to TRUE.

Resolves: #55173
Releases: 6.3, 6.2
Change-Id: Ie1178a5df2e98fd19b848aa2300c901c1200f555
Reviewed-on: https://review.typo3.org/31418
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suggest wizard doesn't work in page flexforms 21/31421/2
Bernhard Kraft [Wed, 18 Jun 2014 08:04:28 +0000 (10:04 +0200)]
[BUGFIX] Suggest wizard doesn't work in page flexforms

When using the suggest wizard from within a flexform in a page it
doesn't work properly. The $row variable was only set when processing
tables other than pages but is required for proper flexform handling.

Change-Id: I0eec29b3c7266bae809e2753cdee726a4c50b1ab
Resolves: #59642
Releases: 6.3, 6.2, 6.1
Reviewed-on: https://review.typo3.org/31421
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove non-needed URL parameter for standard search 19/31419/2
Tomita Militaru [Tue, 12 Nov 2013 14:57:56 +0000 (16:57 +0200)]
[BUGFIX] Remove non-needed URL parameter for standard search

Removes parameter to prevent duplicate content, speaking
url problems and overloaded urls.

Resolves: #51189
Releases: 6.3, 6.2, 6.1
Change-Id: I076d2f87ac7a1d0d9d831cf3293d060318750c7d
Reviewed-on: https://review.typo3.org/31419
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Support dots in page.meta 06/31406/2
Markus Klein [Sat, 28 Jun 2014 14:56:36 +0000 (16:56 +0200)]
[BUGFIX] Support dots in page.meta

The parsing of the meta tag TypoScript configuration does a too greedy
check on dots and hence breaks support for examples like DC.author.

Fix this by completely refactoring the meta tag generation and add unit
tests.

Resolves: #59890
Releases: 6.3, 6.2
Change-Id: Id534efff30903d96aee1677989d1bd6d3dd1644b
Reviewed-on: https://review.typo3.org/31406
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[CLEANUP] Ensure all variables are set before usage 80/31380/3
Markus Klein [Sun, 22 Jun 2014 00:46:21 +0000 (02:46 +0200)]
[CLEANUP] Ensure all variables are set before usage

This also applies for return values of functions. These are corrected
too if necessary.

Furthermore, some code style updates are done for better readability.

This patch contains no functional changes.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: I1e26e0516d79324244948caf091cd836d5f8d3c6
Reviewed-on: https://review.typo3.org/31380
Reviewed-by: Fabien Udriot
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Travis-ci: Disable apc in PHP 5.3 04/31404/2
Christian Kuhn [Sun, 6 Jul 2014 16:23:19 +0000 (18:23 +0200)]
[TASK] Travis-ci: Disable apc in PHP 5.3

apc on cli seems to be flaky, disable this php module for
now to see if that help stabilizing travis-ci builds again.

Change-Id: I7e6caa6c2c2d70a26e217e8fbf10a2d79b01f335
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31404
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] ext_emconf files 00/31400/2
Christian Kuhn [Sun, 6 Jul 2014 15:19:31 +0000 (17:19 +0200)]
[CLEANUP] ext_emconf files

Quite some keys in ext_emconf are obsolete and can be removed.
See related issue for a list of keys.

Change-Id: Id12c2e3d61569cc1e84226ef75120ae4261922fb
Resolves: #60128
Related: #58365
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31400
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Remove unused EM_CONF variables 99/31399/3
Benjamin Mack [Wed, 30 Apr 2014 13:36:24 +0000 (15:36 +0200)]
[TASK] Remove unused EM_CONF variables

The ext_emconf.php are created when e.g. an extension
is downloaded from TER. Based on the data from TER the
extension information is built, but not needed anymore.

There are some values that are not in use in the current
6.2 system anymore, and just make ext_emconf.php
more complicated, as the current EM only runs with TER2
anyway.

The patch cleans up values when writing ext_emconf.php
for an extension. As soon as only 6.2+ is supported, the
TER could remove the values to be shipped in the
xml.gz files, thus saving resources (not much but I'm in
favor of a clean system).

Releases: 6.2,6.3
Resolves: #58365
Change-Id: Ic15247f57b557971e9a7c608e4dadd2080e976a3
Reviewed-on: https://review.typo3.org/31399
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] ClearCacheOnLoad camelCased does not work 98/31398/3
Susanne Moog [Sun, 6 Jul 2014 15:10:10 +0000 (17:10 +0200)]
[BUGFIX] ClearCacheOnLoad camelCased does not work

The em_conf setting "clearCacheOnLoad" is both used in
camelCase and lower case but only the latter one is
supported by the extension manager.

Change-Id: I637ace3bef07353b7a44c991f79d01da8e8b5547
Fixes: #60127
Releases: 6.2,6.3
Reviewed-on: https://review.typo3.org/31398
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Replace module token in be shortcut returnUrl 96/31396/2
Frans Saris [Sun, 6 Jul 2014 12:34:46 +0000 (14:34 +0200)]
[BUGFIX] Replace module token in be shortcut returnUrl

During the addition of the token check for mod.php the token
in the BE shortcut url was already replaced (#56359) but
not in the returnUrl parameter that can be present.

This patch makes sure that also the module token is replaced in
the returnUrl param.

Resolves: #59963
Releases: 6.3, 6.2
Change-Id: I12b9d6022240d0399825aade21b0879bfbc7eb6c
Reviewed-on: https://review.typo3.org/31396
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Allow colon in TypoScript key 89/31389/3
Markus Klein [Sat, 28 Jun 2014 15:19:32 +0000 (17:19 +0200)]
[BUGFIX] Allow colon in TypoScript key

The TypoScript parser does not properly parse the := operator.
It searches for : only and hence wrongly breaks a TypoScript key apart.

Fix this by detecting the full operator sequence ":=", do not rely
on ":" only.

Resolves: #59965
Releases: 6.3, 6.2
Change-Id: I6401c87b45432d4d74c4092edeb333d4d9d5914e
Reviewed-on: https://review.typo3.org/31389
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated correctly 87/31387/2
Wouter Wolters [Sat, 18 May 2013 18:55:23 +0000 (20:55 +0200)]
[BUGFIX] Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated correctly

Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated
correctly in the backend.

Change-Id: Ieda08a1df71117b5ac90f2c68260f5171570ff63
Resolves: #16392
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31387
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Sysext form uses old TCA 85/31385/3
Markus Klein [Tue, 24 Jun 2014 13:38:46 +0000 (15:38 +0200)]
[BUGFIX] Sysext form uses old TCA

Sysext form overrides TCA for tt_content with some completely outdated
configuration.

Fix this to the new TCA of tt_content.

Resolves: #59837
Releases: 6.3, 6.2
Change-Id: Ic2d1d75b767925755160bd337ec6fdfbddc308ab
Reviewed-on: https://review.typo3.org/31385
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Extensionmanager: Dependency errors are not reset 83/31383/3
Nicole Cordes [Fri, 4 Jul 2014 22:34:19 +0000 (00:34 +0200)]
[BUGFIX] Extensionmanager: Dependency errors are not reset

Due to changes in https://review.typo3.org/#/c/29845/ dependency errors
are collected and if one error occurred it is returned for every check
regardless of the key. This patch adds a reset for the error array on
every new dependency check.

Resolves: #60106
Releases: 6.3, 6.2
Change-Id: Id734ba1fe8981ffd270d79d4971ac9de9b72b4b4
Reviewed-on: https://review.typo3.org/31383
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Update ADOdb to 5.19 77/31377/2
Andreas Fernandez [Thu, 26 Jun 2014 15:46:52 +0000 (17:46 +0200)]
[TASK] Update ADOdb to 5.19

Updated ADOdb from 5.18 to 5.19 fixing several bugs.

Resolves: #59911
Releases: 6.3, 6.2
Change-Id: I3173c8b14b3d653f29d4992029dbaa9129200fa2
Reviewed-on: https://review.typo3.org/31163
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/31377

5 years ago[BUGFIX] Missing label for EM "update"-dependency 71/31371/3
Markus Klein [Sat, 5 Jul 2014 14:57:34 +0000 (16:57 +0200)]
[BUGFIX] Missing label for EM "update"-dependency

Add the missing label for "update"-dependencies to EM locallang.xlf

Resolves: #59974
Releases: 6.3, 6.2
Change-Id: I8e8f1681cd486c2fbb7491c41c5f711c86e64ed0
Reviewed-on: https://review.typo3.org/31371
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Re-add unit tests for ExtensionCompatibilityTester 70/31370/3
Susanne Moog [Fri, 20 Jun 2014 10:23:21 +0000 (12:23 +0200)]
[TASK] Re-add unit tests for ExtensionCompatibilityTester

The tests for the ExtensionCompatibilityTester are currently skipped.
This patch removes the broken tests and leaves the working ones.

Releases: 6.3, 6.2
Resolves: #59700
Change-Id: I10a49d0dddf2807bd50944837e31f0105374c8c9
Reviewed-on: https://review.typo3.org/31370
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Correctly check stack in DownloadQueue 69/31369/2
Markus Klein [Sun, 29 Jun 2014 09:43:34 +0000 (11:43 +0200)]
[BUGFIX] Correctly check stack in DownloadQueue

The extension manager's DownloadQueue does now properly check
the stack when adding extensions to the queue.

Resolves: #59975
Releases: 6.3, 6.2, 6.1
Change-Id: I90e9699608c6d0f3ebd44dd54eb0f471a4e082d9
Reviewed-on: https://review.typo3.org/31369
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix position of TCEforms required field icon 68/31368/2
Frans Saris [Wed, 25 Jun 2014 08:08:17 +0000 (10:08 +0200)]
[BUGFIX] Fix position of TCEforms required field icon

If a palette is placed directly after a form field the icon to
open the pallete is placed inside the formfield wrapper. As result
the position of the required field icon is wrong.

This patch moves the palette icon outside of the wrapper.

Resolves: #59865
Releases: 6.2, 6.3
Change-Id: I35a3d4728a0dfb5ed315731366cc5ca04a7aa87e
Reviewed-on: https://review.typo3.org/31368
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Incomplete mock in ext:install 62/31362/2
Christian Kuhn [Sat, 5 Jul 2014 16:01:21 +0000 (18:01 +0200)]
[BUGFIX] Incomplete mock in ext:install

"ExtensionCompatibilityTesterTests" triggers loadBaseTca() that
loads TCA and TCA overrides of all active packages. Since the
unit test package manager activates all extensions found, this
may lead to unexpected effects with extensions hanging around
in typo3conf/ext.
The patch creates a backup of the package manager and mocks it
properly in some tests.

Change-Id: Ia5b1ccb449f1611837e6436cab226820b22a9047
Resolves: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31362
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Warning in addPlugin() 61/31361/2
Christian Kuhn [Sat, 5 Jul 2014 16:10:42 +0000 (18:10 +0200)]
[BUGFIX] Warning in addPlugin()

ExtensionManagementUtility::addPlugin() may raise a warning if
a subarray of TYPO3_LOADED_EXT is not set for whatever reason.
The patch sanitizes this.

Change-Id: I4fb8c24bcdebd6b04e856ecad5da07e624d95da4
Resolves: #60122
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31361
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Clean up buildBaseTcaFromSingleFiles() 60/31360/2
Christian Kuhn [Sat, 5 Jul 2014 16:07:17 +0000 (18:07 +0200)]
[TASK] Clean up buildBaseTcaFromSingleFiles()

The method uses two different approaches to get a list of active
packages, this is cleaned up to use the package manager only.

Change-Id: Ifc73d36ed0020914b0f7cf0b479010f91d1eba7f
Resolves: #60121
Related: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31360
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Removed clickMenu code around header icon in info window 58/31358/2
Frans Saris [Thu, 19 Jun 2014 15:58:41 +0000 (17:58 +0200)]
[BUGFIX] Removed clickMenu code around header icon in info window

The header icon in the ElementInfo screen has a click link added
but this doesn't work and doesn't make sense as shown links would
be in the wrong context.

This patch removes the javasript to open the clickmenu from the icons.

Resolves: #56250
Releases: 6.3, 6.2
Change-Id: I2b907188958f166a129617da36585c07be3a143c
Reviewed-on: https://review.typo3.org/31358
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Move TCA modification of EXT:core to TCA/Overrides. 52/31352/2
Anja Leichsenring [Tue, 10 Jun 2014 19:01:45 +0000 (21:01 +0200)]
[BUGFIX] Move TCA modification of EXT:core to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Ia2ae5e6c9a00aade1a65a6a89ecf809a0931025f
Resolves: #59464
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31352
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of saltedpasswords to TCA/Overrides 51/31351/2
Anja Leichsenring [Fri, 20 Jun 2014 14:57:30 +0000 (16:57 +0200)]
[BUGFIX] Move TCA modification of saltedpasswords to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I328cbcb718ee33beec19379ea6047a18cdc370b0
Resolves: #59704
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31351
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Empty class selector crashes Update image 50/31350/2
Francois Suter [Fri, 27 Jun 2014 13:40:35 +0000 (15:40 +0200)]
[BUGFIX] Empty class selector crashes Update image

Prevent the Update image dialog box to crash when trying to access
an empty class selector.

Resolves: #59938
Releases: 6.2, 6.3
Change-Id: Ida2c3dfb185064071fcdcda158f64e330562aa01
Reviewed-on: https://review.typo3.org/31350
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Cleanup EXT:version 49/31349/2
Wouter Wolters [Sun, 22 Jun 2014 20:56:32 +0000 (22:56 +0200)]
[TASK] Cleanup EXT:version

* Update phpDoc where needed
* Import use statements where possible

Resolves: #59857
Releases: 6.3, 6.2
Change-Id: I786db3b377dbe0cc90441ea6618ce05fc67b087b
Reviewed-on: https://review.typo3.org/31349
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Updating deactivated extensions installs them 48/31348/2
Nicole Cordes [Fri, 4 Jul 2014 22:59:48 +0000 (00:59 +0200)]
[BUGFIX] Updating deactivated extensions installs them

If you update a deactivated extension it becomes activated afterwards.
This patch change from the installExtension function to
downloadMainExtension function because on updates it is enough to
download the new extension.

Resolves: #59631
Releases: 6.3, 6.2
Change-Id: Idec8c1f3521fa03241def5e171718b42cc31ce6b
Reviewed-on: https://review.typo3.org/31348
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of EXT:felogin to TCA/Overrides. 47/31347/2
Jost Baron [Mon, 9 Jun 2014 10:15:55 +0000 (12:15 +0200)]
[BUGFIX] Move TCA modification of EXT:felogin to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Resolves: #59462
Related: #59414
Releases: 6.3,6.2
Change-Id: I0bd42865f199b7fcccc1ee9133776271a1af2bcd
Reviewed-on: https://review.typo3.org/31347
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Init variable in GeneralUtility::createVersionNumberedFilename 46/31346/2
Jost Baron [Tue, 1 Jul 2014 12:22:31 +0000 (14:22 +0200)]
[BUGFIX] Init variable in GeneralUtility::createVersionNumberedFilename

The variable '$doNothing' was not initialized, leading to PHP notices.

Resolves: #60116
Releases: 6.3, 6.2
Change-Id: I38473b73d4b1ebeb4b1dcbea5ba24d005c520487
Reviewed-on: https://review.typo3.org/31346
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Use string as constant name in FormProtectionFactory. 45/31345/2
Jost Baron [Tue, 1 Jul 2014 12:31:35 +0000 (14:31 +0200)]
[BUGFIX] Use string as constant name in FormProtectionFactory.

Currently the constant itself is used, which leads to PHP notices if it is
not defined yet.

Resolves: #60115
Releases 6.2,6.3
Change-Id: I6932f958a9cb0d01be5910860ebbd78f2c67c58a
Reviewed-on: https://review.typo3.org/31345
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:form to TCA/Overrides. 41/31341/2
Anja Leichsenring [Tue, 10 Jun 2014 20:10:03 +0000 (22:10 +0200)]
[BUGFIX] Move TCA modification of EXT:form to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I789ea89318d76d0c709229139b0f5296042cded7
Resolves: #59466
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31341
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:t3editor to TCA/Overrides 42/31342/2
Anja Leichsenring [Fri, 20 Jun 2014 15:04:19 +0000 (17:04 +0200)]
[BUGFIX] Move TCA modification of EXT:t3editor to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I1f92a7b536ffb19d30bb580ea30452fc488cd0f6
Resolves: #59705
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31342
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:cms to TCA/Overrides. 43/31343/2
Anja Leichsenring [Tue, 10 Jun 2014 18:52:23 +0000 (20:52 +0200)]
[BUGFIX] Move TCA modification of EXT:cms to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Idb1be39c754d5566e52623103477b94887077cdb
Resolves: #59463
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30648
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 57b9fd213897663b4c12d025375a8564cb7d60b2)
Reviewed-on: https://review.typo3.org/31343
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:openid to TCA/Overrides 44/31344/2
Anja Leichsenring [Fri, 20 Jun 2014 09:46:16 +0000 (11:46 +0200)]
[BUGFIX] Move TCA modification of EXT:openid to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I7b5240eccde3d49531bb734adf26ee623829dc59
Resolves: #59698
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30910
Reviewed-by: Olivier Dobberkau
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 920f93cc4a150c74e91a65d0309291327e600c39)
Reviewed-on: https://review.typo3.org/31344
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:csc to TCA/Overrides 39/31339/2
Anja Leichsenring [Tue, 10 Jun 2014 19:56:42 +0000 (21:56 +0200)]
[BUGFIX] Move TCA modification of EXT:csc to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I3a357ddff0fe5d6f16caa67b4085372c27594234
Resolves: #59465
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31339
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of indexed_search to TCA/Overrides 40/31340/2
Anja Leichsenring [Tue, 10 Jun 2014 20:31:58 +0000 (22:31 +0200)]
[BUGFIX] Move TCA modification of indexed_search to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: If5998b9c86bc5f7b106fd3f1c9213842b8ae242d
Resolves: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31340
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tooltip for a shortcut in list view shows id=0 37/31337/2
Wouter Wolters [Fri, 4 Jul 2014 19:02:17 +0000 (21:02 +0200)]
[BUGFIX] Tooltip for a shortcut in list view shows id=0

In the list view the tooltip for a shortcut always shows
id=0 because the field shortcut is not fetched from the database.
Add this to the list of fields to select.

Resolves: #60033
Releases: 6.3,6.2
Change-Id: Id4949e6699657a57975977b3450f54bc3216d06d
Reviewed-on: https://review.typo3.org/31328
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 683ae94fb8bdf022981c9045c81e37149c32160e)
Reviewed-on: https://review.typo3.org/31337

5 years ago[BUGFIX] Give extension key to addPlugin() in registerPlugin() 36/31336/2
Christian Kuhn [Sat, 5 Jul 2014 11:44:19 +0000 (13:44 +0200)]
[BUGFIX] Give extension key to addPlugin() in registerPlugin()

With patch #59770 ExtensionManagementUtility::addPlugin() signature
was extended to get the extensionKey as parameter in order to not
use $GLOBALS['_EXTKEY'] anymore if possible.
The parameter is used to determine correct path to plugin icons if
the icon path is not given otherwise.
The patch changes extbase ExtensionUtility::registerPlugin() to give
the extensionKey to addPlugin, too.
With this patch registerPlugin() can be used in TCA/Overrides.
Some tests are added to verify the icon path calculation since it is
not trivial to follow the code flow with all its options and global
array access.

Change-Id: I2dd709ef7ca304bc8c4fda1e7911f18bfe7ad04c
Resolves: #60109
Related: #59770
Related: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31336
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Unit tests to addPlugin() 35/31335/2
Anja Leichsenring [Sat, 5 Jul 2014 11:51:35 +0000 (13:51 +0200)]
[TASK] Unit tests to addPlugin()

Add unit tests to ExtensionManagementUtility::addPlugin() verifying
the new third parameter $extensionKey is handled properly.

Change-Id: I0257755d0708f12141c78fb97e6e342daf7a6281
Resolves: #60110
Related: #60109
Related: #59414
Related: #59770
Related: #59468
Releases: 6.2, 6.3
Reviewed-on: https://review.typo3.org/31335
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix property access for ObjectStorage 14/31314/2
Markus Klein [Mon, 9 Jun 2014 10:02:51 +0000 (12:02 +0200)]
[BUGFIX] Fix property access for ObjectStorage

When enabling access to the content of ObjectStorages by
integer number, it was overlooked that property access might
be desired too, which has also been working before.

Fix this by not aborting the access when addressing a
non-integer property on ObjectStorages.

Resolves: #59412
Releases: 6.3, 6.2
Change-Id: I59b83ed0bf0c965efcdf0aad9440d634953a221e
Reviewed-on: https://review.typo3.org/31314
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix usergroup condition in user TSconfig 51/31151/2
Markus Klein [Tue, 24 Jun 2014 14:18:59 +0000 (16:18 +0200)]
[BUGFIX] Fix usergroup condition in user TSconfig

usergroup conditions in user TSconfig are currently failing as
the list of groups the user is part of, is not yet compiled when
the TSconfig is evaluated.

This can be fixed by moving the group evaluation some lines upwards,
as this does not influence the remaining code.

Resolves: #59813
Releases: 6.3, 6.2, 6.1
Change-Id: Id3189ea5cd31936bdf538e2bb163ecc2d46ed6a0
Reviewed-on: https://review.typo3.org/31151
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Two png files should have filemode 664 95/31295/2
Martin Bless [Wed, 2 Jul 2014 16:33:24 +0000 (18:33 +0200)]
[BUGFIX] Two png files should have filemode 664

Resolves: #60065
Releases: 6.3,6.2
Change-Id: I27917fed2a65f9810176b4afa716e8e752d7eff1
Reviewed-on: https://review.typo3.org/31295
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Create a Getter for CacheManager inside Datahandler 89/31289/3
Stefano Kowalke [Wed, 2 Jul 2014 11:26:16 +0000 (13:26 +0200)]
[TASK] Create a Getter for CacheManager inside Datahandler

At the moment the CacheManager is created by
GeneralUtility::makeInstance(
  'TYPO3\\CMS\\Core\\Cache\\CacheManager'
); within the code. This makes the particular method untestable.

Solution: Create a Getter which creates and returns the instance.
This getter can be mocked.

Resolves: #60059
Releases: 6.2, 6.3
Change-Id: I9f83ec017da94778e542410cc9d03faacddc245c
Reviewed-on: https://review.typo3.org/31289
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring