Packages/TYPO3.CMS.git
2 years ago[TASK] Remove AppVeyor configuration 25/51225/3
Mathias Schreiber [Mon, 9 Jan 2017 19:15:22 +0000 (20:15 +0100)]
[TASK] Remove AppVeyor configuration

AppVeyor is kind of broken by design.
Most of the times something is messed up, dependencies don't work or it
simply times out.

For the time being we will drop AppVeyor and discuss a dedicated,
fast windows testing infrastructure with Microsoft DX in February.

Releases: master
Resolves: #79226
Change-Id: Ie9487283d309e1f07113e3571ac3bc8ad4ad2050
Reviewed-on: https://review.typo3.org/51225
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][FEATURE] Allow reloading of backend topbar 83/51183/4
Andreas Fernandez [Sat, 7 Jan 2017 19:14:37 +0000 (20:14 +0100)]
[!!!][FEATURE] Allow reloading of backend topbar

A new API is introduced that allows to reload the backend’s topbar.
The reload may be triggered via JavaScript and PHP.

As the registered events of the toolbar items within the topbar get lost
after reloading, the event registration for these toolbar items needs
some adoption.

The topbar is now reloaded in case of:
- updating the user's avatar
- after configuring an extension
- opening the EXT:belog module from the System Information menu

Resolves: #79196
Releases: master
Change-Id: Ib6b65d7327c9db2b818ad9ad549cb2f2f00d1595
Reviewed-on: https://review.typo3.org/51183
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove range from sorting field 01/51001/3
Georg Ringer [Tue, 20 Dec 2016 07:06:57 +0000 (08:06 +0100)]
[BUGFIX] Remove range from sorting field

The range configuration for a sorting field doesn't make any sense
and can lead to unexpected bugs as sorting can be rewritten

Resolves: #78986
Releases: master, 7.6, 6.2
Change-Id: I738877e6f9587d2570506f695fb7426a7536a964
Reviewed-on: https://review.typo3.org/51001
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] IconFactory check arrays for key 71/50971/3
Alexander Opitz [Thu, 15 Dec 2016 10:47:25 +0000 (11:47 +0100)]
[BUGFIX] IconFactory check arrays for key

This reduces PHP notices, as we check arrays before acessing them.

Resolves: #78992
Releases: master, 7.6
Change-Id: Ib0fc72be9e7957a27990d60dde844068ca9e24d1
Reviewed-on: https://review.typo3.org/50971
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Introduce abstract class AbstractAjaxController 48/51148/8
Mona Muzaffar [Wed, 4 Jan 2017 15:31:56 +0000 (16:31 +0100)]
[TASK] Introduce abstract class AbstractAjaxController

Extract duplicate code in method and let FormFlexAjaxController
and FormInlineAjaxController extend from abstract class.

Change-Id: Idef25a758b6df857419983f0e6c93441103954a7
Resolves: #79159
Releases: master
Reviewed-on: https://review.typo3.org/51148
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Simplify module menu loading functionality 09/51209/2
Benni Mack [Mon, 9 Jan 2017 06:24:50 +0000 (07:24 +0100)]
[TASK] Simplify module menu loading functionality

As there is no relative path functionality but only absolute
URLs (without the domain name but just prepended) the functionality
of stripping the siteUrl is removed, thus allowing to remove the hardcoded
"/typo3/" name in the URL and the siteUrl configuration option as well.

Resolves: #79212
Releases: master
Change-Id: I03a065950bb0401970a618bf30c71d69d6ed2188
Reviewed-on: https://review.typo3.org/51209
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] ext:beuser delete button title attribute 02/51202/4
Josef Glatz [Sun, 8 Jan 2017 21:20:45 +0000 (22:20 +0100)]
[TASK] ext:beuser delete button title attribute

Add missing title attribute to delete button in the backend user
listing module.

Resolves: #79203
Releases: master
Change-Id: I511fdce6d29cf8c38682e08f14d2cbb33d127c77
Reviewed-on: https://review.typo3.org/51202
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FOLLOWUP][TASK] Remove iconv support and use mbstring-polyfill 15/51215/3
Benni Mack [Mon, 9 Jan 2017 12:05:26 +0000 (13:05 +0100)]
[FOLLOWUP][TASK] Remove iconv support and use mbstring-polyfill

The method csConv->strtrunc() is missing in the deprecation.

Resolves: #78670
Releases: master
Change-Id: I95284f2ded36f61410806494dd5cd8f1db22c586
Reviewed-on: https://review.typo3.org/51215
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Remove hardcoded ContextHelpWindows settings 14/51214/3
Wouter Wolters [Mon, 9 Jan 2017 10:26:59 +0000 (11:26 +0100)]
[TASK] Remove hardcoded ContextHelpWindows settings

The values are hardcoded and not replaceable. We can put the
hardcoded values in JavaScript directly.

Resolves: #79215
Releases: master
Change-Id: I64742cef34b73d88bbc0f44cfc959556555b2fad
Reviewed-on: https://review.typo3.org/51214
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Replace ExtDirect State for module menu with jQuery 08/51208/4
Benni Mack [Mon, 9 Jan 2017 06:07:56 +0000 (07:07 +0100)]
[TASK] Replace ExtDirect State for module menu with jQuery

The obsolete State Provider for storing and retrieving the information
if the backend module menu should be collapsed or not
should not use ExtDirect but instead us the native Storage functionality
already in place for TYPO3.

The namespace (BackendComponents.States.typo3-module-menu) is
kept for now (see BackendController.php for details on ExtDirect), but could
easily be modified.

Resolves: #79211
Releases: master
Change-Id: I4de6b46ea0f18201cb8bb0af6077c1d9dfffcec7
Reviewed-on: https://review.typo3.org/51208
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix typo in ext:backend fluid template 01/51201/2
Josef Glatz [Sun, 8 Jan 2017 20:54:28 +0000 (21:54 +0100)]
[BUGFIX] Fix typo in ext:backend fluid template

Resolves: #79202
Releases: master, 7.6
Change-Id: Ie47e6b42a7429ce75a8d750c7e7aa7f1c1cb9bec
Reviewed-on: https://review.typo3.org/51201
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Remove leftover info about config.uniqueLinkVars 04/51204/3
Josef Glatz [Sun, 8 Jan 2017 23:14:31 +0000 (00:14 +0100)]
[BUGFIX] Remove leftover info about config.uniqueLinkVars

Remove obsolete info about a removed setting in tsref.xml
and remove one duplicate `to` just two lines later.

Resolves: #79208
Related: #62888
Releases: master, 7.6
Change-Id: I4c2a437edb657eb380ffb2377947977a850da497
Reviewed-on: https://review.typo3.org/51204
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[TAKS] Add missing variables in WorkspaceService doc comments 98/51198/2
Tymoteusz Motylewski [Sun, 8 Jan 2017 13:35:00 +0000 (14:35 +0100)]
[TAKS] Add missing variables in WorkspaceService doc comments

Resolves: #79200
Releases: master, 7.6
Change-Id: I745f9762122dba5f2e1ecca8deafd440a78f8329
Reviewed-on: https://review.typo3.org/51198
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:tstemplate: Removed double escaping of page name 46/51046/6
Michael Oehlhof [Mon, 26 Dec 2016 22:01:57 +0000 (23:01 +0100)]
[BUGFIX] EXT:tstemplate: Removed double escaping of page name

Because the escaping takes place when the PageZero template is rendered
by the view, there is no need to escape it in the controller.

Resolves: #79096
Resolves: #79060
Releases: master
Change-Id: I3e06e2829e0d1d916b941329f835b4e7f5e29398
Reviewed-on: https://review.typo3.org/51046
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Functional tests for free mode translation 50/51150/3
Tymoteusz Motylewski [Thu, 5 Jan 2017 16:25:37 +0000 (17:25 +0100)]
[TASK] Functional tests for free mode translation

Functional tests for following scenarios:
- free-mode translation of a record in non-default language
(live and in workspaces)
- copy page translated in free mode (workspaces, live is already covered)

Resolves: #79170
Releases: master, 7.6
Change-Id: Iff69e2b4333dfff7511871573352b270add4de01
Reviewed-on: https://review.typo3.org/51150
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[!!!][TASK] Removed optional fluid typoscript template 05/51105/9
Frans Saris [Tue, 3 Jan 2017 11:36:17 +0000 (12:36 +0100)]
[!!!][TASK] Removed optional fluid typoscript template

The typoscript template was meant as an example/showcase on how to
use Fluid Widgets in FE. The current used includes are outdated or
broken.

Resolves: #78988
Releases: master
Change-Id: I5c30b017c10d6244d6aa559d395e351dd242d48d
Reviewed-on: https://review.typo3.org/51105
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Get folder’s identifier for exception message 78/51178/2
Andreas Fernandez [Sat, 7 Jan 2017 16:18:49 +0000 (17:18 +0100)]
[BUGFIX] Get folder’s identifier for exception message

The identifier of the folder object is now retrieved and used in the
exception message.

Resolves: #79194
Releases: master, 7.6
Change-Id: Iebea177434c6913bab705df119d750b497238252
Reviewed-on: https://review.typo3.org/51178
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[FOLLOWUP][TASK] Update copyright year to 2017 75/51175/2
Andreas Fernandez [Sat, 7 Jan 2017 15:56:24 +0000 (16:56 +0100)]
[FOLLOWUP][TASK] Update copyright year to 2017

Added some files that were not updated with the original change.

Resolves: #79165
Releases: master, 7.6, 6.2
Change-Id: If8298c220ca7171d34e21aff9e49917ac8618686
Reviewed-on: https://review.typo3.org/51175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Update copyright year to 2017 38/51138/2
Wouter Wolters [Thu, 5 Jan 2017 10:12:36 +0000 (11:12 +0100)]
[TASK] Update copyright year to 2017

Resolves: #79165
Releases: master,7.6,6.2
Change-Id: Ia3211ad00a3b6bd915b0a099bdb8d98a8b12dc7f
Reviewed-on: https://review.typo3.org/51138
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Show file title in CE uploads 31/50931/3
Frans Saris [Mon, 12 Dec 2016 10:47:04 +0000 (11:47 +0100)]
[BUGFIX] Show file title in CE uploads

Resolves: #78900
Releases: master, 7.6
Change-Id: Ia44c039083d44eda463ee1819f6dc20353ce7f8a
Reviewed-on: https://review.typo3.org/50931
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:form - load custom form editor templates 63/51163/2
Ralf Zimmermann [Fri, 6 Jan 2017 13:55:12 +0000 (14:55 +0100)]
[BUGFIX] EXT:form - load custom form editor templates

Avoid javascript errors if a custom form editor templates is used.

Resolves: #79184
Releases: master
Change-Id: I5a769234dc9088e34b2ab69cf82ac613fcf82210
Reviewed-on: https://review.typo3.org/51163
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Fix sorting in language list 40/51040/3
Markus Sommer [Fri, 23 Dec 2016 13:48:06 +0000 (14:48 +0100)]
[BUGFIX] Fix sorting in language list

* Add sorting field for A/D
* disable senseless sorting of actions

Resolves: #79085
Releases: master, 7.6
Change-Id: Ib7b31c43522d31dcecf9e97042b98be434616068
Reviewed-on: https://review.typo3.org/51040
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Prevent fatal error in TemplatePaths without TS 48/51048/3
Claus Due [Tue, 27 Dec 2016 13:33:51 +0000 (14:33 +0100)]
[BUGFIX] Prevent fatal error in TemplatePaths without TS

This fixes an issue with Fluid being asked to render a
template at an execution point where no TS can be
resolved (ConfigurationManager "get full typoscript"
returns null).

Casting the potentially null return value to an array
completely avoids the issue, since Fluid is perfectly
capable of generating fallback expected paths which
always point to the right extension resources folders.

Change-Id: I3e07fb0248cb9d0f1faa560e6f72a47e41314763
Releases: master
Resolves: #79098
Reviewed-on: https://review.typo3.org/51048
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Missing language label "Access capabilities" 13/51113/3
DavidsWONG [Wed, 4 Jan 2017 11:55:22 +0000 (12:55 +0100)]
[BUGFIX] Missing language label "Access capabilities"

Used as tab label in sys_file_storage

Releases: master
Resolves: #79152
Change-Id: I37407b09d7829185e171aa3eb0632b06f4a5e3a4
Reviewed-on: https://review.typo3.org/51113
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Clean up @see annotation in DataHandler functional tests 10/51110/2
Tymoteusz Motylewski [Tue, 3 Jan 2017 22:48:13 +0000 (23:48 +0100)]
[TASK] Clean up @see annotation in DataHandler functional tests

Resolves: #79146
Releases: master, 7.6
Change-Id: I567031de638d5a03c4e38796b4bfd17569c361e7
Reviewed-on: https://review.typo3.org/51110
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Check in TcaMigration if the type is set 17/51017/4
Georg Ringer [Thu, 22 Dec 2016 08:30:51 +0000 (09:30 +0100)]
[BUGFIX] Check in TcaMigration if the type is set

The type field is essential for TCA and must be checked if available.

Resolves: #79059
Releases: master
Change-Id: I6b5a94db0372e25a18ecb21a3966cece8cc9f207
Reviewed-on: https://review.typo3.org/51017
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Reload pagetree after hide / unhide page in click menu 42/51042/3
Gianluigi Martino [Sat, 24 Dec 2016 09:18:12 +0000 (10:18 +0100)]
[TASK] Reload pagetree after hide / unhide page in click menu

Pagetree reload now after hide / unhide page in click menu with the
correct status

Resolves: #79090
Releases: master
Change-Id: I5312115c51096094914cf29d3832c0f1e36eaf0b
Reviewed-on: https://review.typo3.org/51042
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Mona Muzaffar
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] FormEngine group element top/bottom buttons 11/51111/3
Christian Kuhn [Wed, 4 Jan 2017 10:38:48 +0000 (11:38 +0100)]
[BUGFIX] FormEngine group element top/bottom buttons

The sort top/bottom buttons in group element no longer depend
on the number of selected items. This is inconvenient anyway
since these sorting buttons only appeared after saving when
a bunch of items was selected, but not immediately.
The patch additionally fixes a failing acceptance test.

Change-Id: Ice0d179e7c74c3a1227c727c672b40844d6852c8
Resolves: #79149
Related: #78899
Releases: master
Reviewed-on: https://review.typo3.org/51111
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] Make copy mode of translation modal use localize 45/47645/37
Tymoteusz Motylewski [Fri, 30 Dec 2016 23:48:56 +0000 (00:48 +0100)]
[BUGFIX] Make copy mode of translation modal use localize

...  omitting TransOrigPointer

While translating elements with the localization modal we have to
make sure that the "Copy" mode does more than just a plain copy
followed by an update of the sys_language_uid. Otherwise related
elements will just be copied along but don't get a new language.

This patch replaces the copy action with a new action called
copyToLanguage. It behaves like localize action but does not set
TransOrigPointer fields, so child elements get the correct
language and are not connected to a language parent.

Resolves: #75400
Releases: master, 7.6
Change-Id: If57af3c94c67824ab8bbbc62a8c6bea283e96fca
Reviewed-on: https://review.typo3.org/47645
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[!!!][TASK] Improve flex and TCA handling in FormEngine 79/50879/49
Christian Kuhn [Sat, 3 Dec 2016 20:59:52 +0000 (21:59 +0100)]
[!!!][TASK] Improve flex and TCA handling in FormEngine

The patch adapts a series of nasty form engine areas to more solid
code. The evaluate condition code is rewritten and works much better
in flex form scenarios. The suggest wizard and svg tree are much
more solid in flex forms. The group element is rewritten
towards a better readable and easier to refactor code, dropping
method dbFileIcons(). A bunch of issues is resolved along the way.

* TCA "default" now works in flex form section container elements
* The "displayCond" parser is now strict and throws exceptions on
  invalid syntax and wrong referenced fields to help debugging
  faulty display conditions
* TCA displayCond on flex fields can now be prefixed with the
  sheet name and can reference field values from neighbor sheets
* TCA displayCond now works with flex section containers
* TCA flex section container now throw an exception if select or
  group fields configure a MM relation - this is not supported
* TCA ctrl requestUpdate field is dropped, onChange=reload is now allowed
  not only on flex form fields, but also on normal columns fields
* TCA tree now works as section container element and initializes
  correctly on new records and new containers
* GroupElement rewrite to drop dbFileIcons()
* config option maxitems now optional for type=group and type=select
  and defaults to "many items allowed"
* inline now works in "fancy" flex situations with "new" records
  by handing the final dataStructureIdentifier around
* FormEngine no longer loads extJS

Change-Id: Id1d081627529cc1502bb198389e5bd69372815cd
Resolves: #78899
Resolves: #72307
Resolves: #75646
Resolves: #76637
Resolves: #72106
Resolves: #78824
Resolves: #76793
Resolves: #68247
Resolves: #69715
Related: #78460
Related: #67198
Related: #72294
Releases: master
Reviewed-on: https://review.typo3.org/50879
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[SECURITY] Protect Mailtransport 93/51093/5
Wouter Wolters [Mon, 2 Jan 2017 12:05:36 +0000 (13:05 +0100)]
[SECURITY] Protect Mailtransport

Fix CVE-2016-10074 by disallowing potentially unsafe shell characters.

Resolves: #79114
Releases: master, 8.5, 7.6, 6.2
Change-Id: I8578b63c8c571964c2d52a65e4bfbf705c20f816
Reviewed-on: https://review.typo3.org/51093
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Allow definition of template paths in backend module 79/51079/2
Susanne Moog [Sat, 31 Dec 2016 09:59:38 +0000 (10:59 +0100)]
[FEATURE] Allow definition of template paths in backend module

BackendTemplateView now allows overwriting of template paths to add your own
locations for templates, partials and layouts in a BackendTemplateView based
backend module.

Change-Id: I2d8c4b432ff23a3e9b8b527af4697f31082f64b7
Releases: master
Resolves: #79124
Reviewed-on: https://review.typo3.org/51079
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Mona Muzaffar
Reviewed-by: Mona Muzaffar
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Use correct type in PageRepository::getDomainStartPage for column fe_group 96/51096/2
Manuel Selbach [Mon, 2 Jan 2017 14:11:17 +0000 (15:11 +0100)]
[BUGFIX] Use correct type in PageRepository::getDomainStartPage for column fe_group

Strict DBMS will throw an exception for a query where to compare an integer against a column with string values.
There will no "magic" type casting processed, thus we have to use a string instead of an integer.

Change-Id: I740d1797c92f203e83ddfec2ab00df42cc5c53aa
Resolves: #79131
Releases: master
Reviewed-on: https://review.typo3.org/51096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Update d3 to 4.4.0 37/50937/3
Andreas Fernandez [Mon, 12 Dec 2016 18:00:20 +0000 (19:00 +0100)]
[TASK] Update d3 to 4.4.0

* Add identity.reflectX and identity.reflectY to d3.geoIdentity.
* Add zoom.interpolate to control zoom transition behavior.
* Allow double-click and double-tap zoom transitions to be disabled.
* Fix handling of a zoom.translateExtent smaller than the zoom.extent.
* Fix handling of zero-valued nodes in squarified treemaps.
* Fix parsing of unusual number formats in color specifications.
* Fix implementations of force.initialize to allow isolation.
* Fix d3.geoPath’s default projection and contex to be null, not undefined.
* Improve performance of d3.path.

Resolves: #78964
Releases: master
Change-Id: I8bdb677b1eb851789a8b5146330621da0331b7e3
Reviewed-on: https://review.typo3.org/50937
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Update autosize to 3.0.20 35/50935/3
Andreas Fernandez [Mon, 12 Dec 2016 17:43:02 +0000 (18:43 +0100)]
[TASK] Update autosize to 3.0.20

v.3.0.20 - 2016-12-04
Fixed minor bug where the resized event would not fire under specific
conditions when changing the overflow.

v.3.0.19 - 2016-11-23
Bubble dispatched events. Merged #319.

Resolves: #78962
Releases: master
Change-Id: I998cff2bf46e14e73abbdf6729d39146b562f8a2
Reviewed-on: https://review.typo3.org/50935
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Ensure correct field ordering in CSV export 44/50944/3
Nicole Cordes [Mon, 12 Dec 2016 22:01:14 +0000 (23:01 +0100)]
[BUGFIX] Ensure correct field ordering in CSV export

Due to patch https://review.typo3.org/48998/ the whole database record
is fetched from the database instead of only the visible fields. This
screws up the CSV export as this on relies of the field sorting of the
database row. This patch ensures a correct sorting of the row fields
before they are added to the CSV export.

Resolves: #78908
Releases: master, 7.6
Change-Id: I64f0213695c0cd13fecaa96343a5b1d9af1582f4
Reviewed-on: https://review.typo3.org/50944
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[TASK] Add functional test covering copying a page translated in free mode 82/51082/3
Tymoteusz Motylewski [Sat, 31 Dec 2016 17:35:13 +0000 (18:35 +0100)]
[TASK] Add functional test covering copying a page translated in free mode

This test is a safe net before implementing features like l10n_source

Releases: master, 7.6
Resolves: #79126
Change-Id: I89f5b819735623a33468a8e5898a1b7825aa0c9b
Reviewed-on: https://review.typo3.org/51082
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] EXT:viewpage: Added page title as headline 45/51045/3
Michael Oehlhof [Mon, 26 Dec 2016 00:45:06 +0000 (01:45 +0100)]
[TASK] EXT:viewpage: Added page title as headline

Resolves: #77573
Releases: master
Change-Id: If4aaa1f4f9f49e39ecdaee12fc8568ed3839a0ea
Reviewed-on: https://review.typo3.org/51045
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Update TYPO3 Icons to 0.0.14 81/51081/2
Benjamin Kott [Sat, 31 Dec 2016 16:20:10 +0000 (17:20 +0100)]
[TASK] Update TYPO3 Icons to 0.0.14

Resolves: #79125
Releases: master
Change-Id: I8fdfd139cad85e6d39586ee36e6c6dcc886525e0
Reviewed-on: https://review.typo3.org/51081
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] EXT:Scheduler: Adjust return type of convertRangeToListOfValues 38/51038/2
Michael Oehlhof [Fri, 23 Dec 2016 12:59:14 +0000 (13:59 +0100)]
[BUGFIX] EXT:Scheduler: Adjust return type of convertRangeToListOfValues

Resolves: #79086
Releases: master
Change-Id: I47e77f5bc8915d972bd9c19fe8c95f77aea4be7f
Reviewed-on: https://review.typo3.org/51038
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Remove relations from MM table 03/50103/4
Nicole Cordes [Fri, 7 Oct 2016 11:58:00 +0000 (13:58 +0200)]
[BUGFIX] Remove relations from MM table

If extbase deletes an object it doesn't delete its relations in an
MM table. This patch adds the check for a possible MM relation table and
ensures all relations get deleted as well. If the parent table supports
a deleted flag, no relations will be deleted to be able to restore the
parent record again.

Resolves: #78128
Releases: master, 7.6
Change-Id: Ibe2497c05838e261f9c67a80216385d6e60607cb
Reviewed-on: https://review.typo3.org/50103
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Robert Jelinek <robert.jelinek@riir.at>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FOLLOWUP][BUGFIX] Respect SQL table names max length in install tool 72/50872/3
Manuel Glauser [Sat, 3 Dec 2016 14:01:56 +0000 (15:01 +0100)]
[FOLLOWUP][BUGFIX] Respect SQL table names max length in install tool

Consider the table and column name length limitations of the
various database platforms when calling / executing the
database analyser.

Resolves: #78636
Releases: master
Change-Id: I78ad5ea849c722ebc3448beb043dac4846e4d731
Reviewed-on: https://review.typo3.org/50872
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Fix interaction with versions on "All workspaces" tab 05/51005/3
Oliver Hader [Tue, 20 Dec 2016 12:08:57 +0000 (13:08 +0100)]
[BUGFIX] Fix interaction with versions on "All workspaces" tab

Interacting with workspace versions using the "All workspaces"
tab in the workspace module was not possible. The process tried
to use the current workspace, which in this case was the virtual
workspace with ID -98 - which of course did not exist.

Change-Id: If512ef8ccc838348230531450e82b25a00f27908
Resolves: #79048
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Use TYPO3_SSL for the URL schema enforcement test 52/49752/4
Patrick Kollodzik [Fri, 2 Sep 2016 11:44:49 +0000 (13:44 +0200)]
[TASK] Use TYPO3_SSL for the URL schema enforcement test

The enforement of the url_schema field should not be based
on the requested URL schema, but on the TYPO3_SSL enviroment
variable.

This will make it possible to switch the URL schema
based on enviroment variables.

Resolves: #77781
Releases: master
Change-Id: I8fec7d7787af3397051a256bc5222f2b006ef7c0
Reviewed-on: https://review.typo3.org/49752
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[!!!][TASK] Remove legacy CLI-related constants and variables 64/51064/3
Benni Mack [Thu, 29 Dec 2016 16:28:47 +0000 (17:28 +0100)]
[!!!][TASK] Remove legacy CLI-related constants and variables

The constants TYPO3_cliKey and TYPO3_cliInclude are removed,
same goes for $GLOBALS['temp_cliScriptPath'] and
$GLOBALS['temp_cliKey'] which have been marked as deprecated
and not used in CLI context anymore.

Resolves: #79120
Releases: master
Change-Id: I2207ff6eb62bf83bbc0e2af1513eeb74a16e8be2
Reviewed-on: https://review.typo3.org/51064
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Deprecate DatabaseConnection based prepared statements in Extbase 77/50177/5
Benni Mack [Mon, 10 Oct 2016 19:16:04 +0000 (21:16 +0200)]
[TASK] Deprecate DatabaseConnection based prepared statements in Extbase

Extbase has a way to set raw statements with PreparedStatements
based on DatabaseConnection. This functionality has been marked
as deprecated as Doctrine DBAL shows a superior way of doing
so natively within the database directly.

Resolves: #78225
Releases: master
Change-Id: I915526fa27e53c92fa9d017be8b6e555fcfe944e
Reviewed-on: https://review.typo3.org/50177
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FEATURE] Allow modification of typolink params 75/51075/4
Mathias Schreiber [Fri, 30 Dec 2016 16:49:09 +0000 (17:49 +0100)]
[FEATURE] Allow modification of typolink params

Added a hook to typolink if link type is "page" to be able
to modify page links (for example enriching them with further
information from the current page row).

Resolves: #79121
Releases: master
Change-Id: If7c21339bcc80319986d1a555c559d7964878c50
Reviewed-on: https://review.typo3.org/51075
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Do not use realpath for temporary file names 90/50490/6
Stefan Froemken [Thu, 3 Nov 2016 10:44:51 +0000 (11:44 +0100)]
[BUGFIX] Do not use realpath for temporary file names

Generating a temporary file with the PHP function tempnam,
returns the realpath of the file. There are however
situations where PATH_site has some symlinks or mounts, thus
comparing those paths will fail.

Instead of just using the path the function returns, we only
use the filename and prefix that with PATH_site, so that
the check if the temporary path is within PATH_site will succeed.

Resolves: #70106
Releases: master, 7.6, 6.2
Change-Id: I39a1830ff1a5791aa3fdc91056e3870fbb6dde1f
Reviewed-on: https://review.typo3.org/50490
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Krist <mail@alex-krist.de>
Tested-by: Alexander Krist <mail@alex-krist.de>
Reviewed-by: Daniela Grammlich <grammlich@punkt.de>
Tested-by: Daniela Grammlich <grammlich@punkt.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Add CSH button to CreateFolder module 47/51047/4
Michael Oehlhof [Mon, 26 Dec 2016 23:15:19 +0000 (00:15 +0100)]
[TASK] Add CSH button to CreateFolder module

Resolves: #70596
Releases: master
Change-Id: I66187bf8de87cfd77b5be0e889d27c86df641dbc
Reviewed-on: https://review.typo3.org/51047
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Check for loaded EXT:version in getLiveVersionIdOfRecord 50/50950/4
Thomas Hohn [Mon, 12 Dec 2016 11:41:10 +0000 (12:41 +0100)]
[BUGFIX] Check for loaded EXT:version in getLiveVersionIdOfRecord

Omit SQL queries for each record by checking whether the "version"
extension is loaded in BackendUtility->getLiveVersionIdOfRecord()

Resolves: #78974
Releases: master, 7.6
Change-Id: If702866803d0c2b1eafc9a0c003b0e3e71c91367
Reviewed-on: https://review.typo3.org/50950
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[TASK] Remove unused property in PageRepository 63/51063/3
Benni Mack [Thu, 29 Dec 2016 16:01:15 +0000 (17:01 +0100)]
[TASK] Remove unused property in PageRepository

The public property $versioningPreview_where_hid_del
is not in use anymore due to the refactoring of
Doctrine DBAL and can be removed, as it is always
empty and not used in the TYPO3 Core.

Resolves: #79119
Releases: master
Change-Id: Ibf68917dd0ca34c2dd114ab7331d6c5a7611863c
Reviewed-on: https://review.typo3.org/51063
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] CE "menu" subtype "keywords" generated wrong SQL 67/51067/4
Susanne Moog [Fri, 30 Dec 2016 08:50:39 +0000 (09:50 +0100)]
[BUGFIX] CE "menu" subtype "keywords" generated wrong SQL

When using the content element Menu with subtype "keywords"
the generated SQL contained non-replaced prepared statement
params resulting in a query error.

The whole query was rewritten to use the doctrine query builder directly.

Change-Id: I688a0f61eabf93c05e08841d57888be6f02226c7
Resolves: #79115
Releases: master
Reviewed-on: https://review.typo3.org/51067
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[!!!][TASK] Migrate VersionsCommand to SymfonyConsole 05/50905/5
Benni Mack [Thu, 29 Dec 2016 12:35:11 +0000 (13:35 +0100)]
[!!!][TASK] Migrate VersionsCommand to SymfonyConsole

The lowlevel command for showing and cleaning up versioned
records in the database is migrated to a native symfony console
command.

It shows more structured information, and the code is structured
better.

Additionally, the different cleanups can be triggered by the "action"
option.

Resolves: #79109
Releases: master
Change-Id: Ic58ab4b2fa6743042875459af031e02c552cc17f
Reviewed-on: https://review.typo3.org/50905
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Remove unused property in Package object 62/51062/2
Benni Mack [Thu, 29 Dec 2016 15:12:06 +0000 (16:12 +0100)]
[TASK] Remove unused property in Package object

The protected property $classAliases is removed as it is
not used at all.

Resolves: #79111
Releases: master
Change-Id: Id2ce41ac2d5d89c1059f86bd3754e7121465abba
Reviewed-on: https://review.typo3.org/51062
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Add separate sorting direction to getMenu methods 66/51066/5
Susanne Moog [Fri, 30 Dec 2016 08:40:43 +0000 (09:40 +0100)]
[BUGFIX] Add separate sorting direction to getMenu methods

Since the doctrine change the sorting direction has to be passed as
separate parameter, the methods getMenu, getMenuForPages and
getSubpagesForPages now have a parameter for that.

Change-Id: Ib83c7c47ede4972eee187832c704f549ccaa520a
Resolves: #79113
Releases: master
Reviewed-on: https://review.typo3.org/51066
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Check for valid BEuser record for avatar creation 58/51058/3
Anja Leichsenring [Thu, 29 Dec 2016 12:14:42 +0000 (13:14 +0100)]
[BUGFIX] Check for valid BEuser record for avatar creation

A not valid BeUser record can not be retrieved from DB and must
not be passed to the AvatarViewHelper render() method to avoid
errors.

Resolves: #79104
Releases: master
Change-Id: I99ffedf9704f87b71e6ebeacc7136c31b0300fe4
Reviewed-on: https://review.typo3.org/51058
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update momentjs to 2.17.1 and moment-timezone to 0.5.10 38/50938/2
Andreas Fernandez [Mon, 12 Dec 2016 18:04:46 +0000 (19:04 +0100)]
[TASK] Update momentjs to 2.17.1 and moment-timezone to 0.5.10

Resolves: #78965
Releases: master
Change-Id: I3c91c1f3b14a05c4e1120033354b9855ddb1e4eb
Reviewed-on: https://review.typo3.org/50938
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Split fluid styled content rendering definitions 55/51055/4
Benjamin Kott [Wed, 28 Dec 2016 23:36:11 +0000 (00:36 +0100)]
[TASK] Split fluid styled content rendering definitions

Moving the rendering definitions for content elements to dedicated
files provides a better overview over the configuration and creates
a single responsibility per configuration file.

Resolves: #79102
Releases: master

Change-Id: Iecdecaf224c3db2f8d4f319963e09f7ea0dab45b
Reviewed-on: https://review.typo3.org/51055
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Tobias Wollender <tliegl@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:Scheduler: Removed unneccesary Annotation from CronCommand 39/51039/2
Michael Oehlhof [Fri, 23 Dec 2016 13:18:26 +0000 (14:18 +0100)]
[TASK] EXT:Scheduler: Removed unneccesary Annotation from CronCommand

The unneccesary @return annotation is removed from the
function __construct.

Resolves: #79087
Releases: master
Change-Id: Ib588d8e641e7ec4a81b36ffef151b2c885458fd2
Reviewed-on: https://review.typo3.org/51039
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update ckeditor to 4.6.1 39/50939/2
Andreas Fernandez [Mon, 12 Dec 2016 18:14:42 +0000 (19:14 +0100)]
[TASK] Update ckeditor to 4.6.1

New Features:
* The callback parameter in the CKEDITOR.ajax.post method became optional.

Fixed Issues:
* [Blink, WebKit] Fixed: Cannot select all editor content when a widget or
a non-editable element is the first or last element of the content. Also
fixes this issue in the Select All plugin.
* [Blink, WebKit, IE8] Fixed: Browser hangs when a table is inserted in
the place of a selected list with an empty last item.
* Fixed: Improved the Color Button plugin which will now normalize the CSS
background property if it only contains a color value. This fixes missing
background colors when using Paste from Word.
+ [Blink, WebKit] Fixed: Error thrown occasionally by an uninitialized
editable for multiple CKEditor instances on the same page.

Resolves: #78966
Releases: master
Change-Id: I2e711c363dcc8a4a00f7e88828105de987968da4
Reviewed-on: https://review.typo3.org/50939
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] felogin: remove default css 53/51053/9
Josef Glatz [Thu, 22 Dec 2016 12:43:02 +0000 (13:43 +0100)]
[!!!][TASK] felogin: remove default css

There is no need for this css style. Whenever you start a
new installation, you write your CSS for your website by your
own. Therefore it makes no sense to only style the label tag
of EXT:felogin plugins with `display: block;`.

Resolves: #79100
Releases: master
Change-Id: If346eef97a6066077f08d9fb8b944a2543d7cafe
Reviewed-on: https://review.typo3.org/51053
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Update phpunit to version 5.7.4 34/51034/2
Anja Leichsenring [Thu, 22 Dec 2016 21:43:13 +0000 (22:43 +0100)]
[TASK] Update phpunit to version 5.7.4

Resolves: #79082
Releases: master
Change-Id: I1de2911243d5dfd8a172d9dac60cbe93f36c26f8
Reviewed-on: https://review.typo3.org/51034
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][TASK] Extract testing framework for TYPO3 35/51035/11
Anja Leichsenring [Thu, 22 Dec 2016 21:55:00 +0000 (22:55 +0100)]
[FOLLOWUP][TASK] Extract testing framework for TYPO3

Acceptance Tests are not found, path needs adjustment,
References need to be adjusted to the new paths.

Resolves: #79025
Releases: master
Change-Id: Id2fcfeb4e5171c89c421e0af75ddaa7e6acf6cf3
Reviewed-on: https://review.typo3.org/51035
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Integrate driver into functional test bootstrap 14/50914/4
Manuel Selbach [Fri, 9 Dec 2016 09:47:11 +0000 (10:47 +0100)]
[TASK] Integrate driver into functional test bootstrap

According to doctrine migration functional tests should be processed against
different dbms. Thus, we have to integrate the driver to the bootstrap. The
driver can be set by environment variable name 'typo3DatabaseDriver'.

Change-Id: Ia725285a695fbb0e11555c7371cfd2165ba30d77
Resolves: #78930
Releases: master
Reviewed-on: https://review.typo3.org/50914
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Ensure consistent handling of BLOBs 83/50883/8
Morton Jonuschat [Sun, 4 Dec 2016 19:40:00 +0000 (11:40 -0800)]
[TASK] Ensure consistent handling of BLOBs

Set PDO attributes to ensure that BLOB fields are returned as strings to PHP,
the way MySQL does. Update INSERT/UPDATE statements that deal with BLOB field
to declare the proper parameter type so that the driver can do the required
encoding/escaping when sending the data to the DBMS.

Releases: master
Resolves: #78884
Change-Id: I1618da9130549bd95ce0410420ecdee40cc3632d
Reviewed-on: https://review.typo3.org/50883
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update datatables to 1.10.13 36/50936/2
Andreas Fernandez [Mon, 12 Dec 2016 17:55:39 +0000 (18:55 +0100)]
[TASK] Update datatables to 1.10.13

See a list of fixes at https://cdn.datatables.net/1.10.13/

Resolves: #78963
Releases: master
Change-Id: Ic59257fd90ce552d8b59596aaf47ba92d59087b7
Reviewed-on: https://review.typo3.org/50936
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Testing Framework: Move fluid base test and ensure BC 23/51023/5
Susanne Moog [Thu, 22 Dec 2016 14:45:51 +0000 (15:45 +0100)]
[TASK] Testing Framework: Move fluid base test and ensure BC

After the merge of #79025 now the fluid base test case for viewhelpers
should be moved to the testing framework.

A compat layer for the old namespaces is introduced.

Additionally some small leftovers in documentation and CI configuration were fixed.

Change-Id: I78b9670a1ee1fadb4f4c36265c3a51cd1e879e50
Releases: master
Resolves: #79075
Reviewed-on: https://review.typo3.org/51023
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Remove wrong queryBuilder usage in prepareCacheFlush 24/51024/3
Wouter Wolters [Thu, 22 Dec 2016 15:05:59 +0000 (16:05 +0100)]
[BUGFIX] Remove wrong queryBuilder usage in prepareCacheFlush

Due to a wrong queryBuilder being used the parameters stay empty.
Use the correct queryBuilder to prevent SQL errors.

Resolves: #79077
Releases: master
Change-Id: I62b28f7eeb0a1cc4d481e63a46f9784159116b6e
Reviewed-on: https://review.typo3.org/51024
Reviewed-by: Steffen Ritter <info@rs-websystems.de>
Tested-by: Steffen Ritter <info@rs-websystems.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[!!!][TASK] Extract testing framework for TYPO3 25/50125/18
Susanne Moog [Sun, 18 Dec 2016 12:12:41 +0000 (13:12 +0100)]
[!!!][TASK] Extract testing framework for TYPO3

Add testing framework component for independent usage

Resolves: #79025
Releases: master
Change-Id: I23cfd2ed42108d7d80ec776e778a1ac2d5293e55
Reviewed-on: https://review.typo3.org/50125
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Show loading label while scanning broken extensions 79/50979/4
Nicole Cordes [Thu, 15 Dec 2016 22:30:04 +0000 (23:30 +0100)]
[BUGFIX] Show loading label while scanning broken extensions

When switching to Bootstrap in the Install Tool, the class adjustment
for the loading message in LoadExtensions.html was missing. This patch
ensures the correct class is used to show the message.

Resolves: #79010
Related: #78376
Releases: master, 7.6
Change-Id: I9c467dd3e0cf7c801ac25774425df7e1d85b4c0a
Reviewed-on: https://review.typo3.org/50979
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Add missing getTemplatePathAndFilename() in TemplatePaths 04/51004/7
Daniel Lorenz [Tue, 20 Dec 2016 11:43:27 +0000 (12:43 +0100)]
[BUGFIX] Add missing getTemplatePathAndFilename() in TemplatePaths

The StandaloneView getTemplatePathAndFilename() calls
a method that the fluid standalone extension doesn't implement anymore,
hence the method is added to the Core's TemplatePaths class.

Additionally, a lot of type checks are added to ensure that the correct
object types are present in all usages.

Resolves: #79045
Releases: master
Change-Id: I3ec766a29c31d299451f33dd079a56e9a5855c69
Reviewed-on: https://review.typo3.org/51004
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Update TYPO3 version to TYPO3 8.6-dev 09/51009/2
Wouter Wolters [Tue, 20 Dec 2016 17:46:36 +0000 (18:46 +0100)]
[TASK] Update TYPO3 version to TYPO3 8.6-dev

Resolves: #79055
Releases: master
Change-Id: I09921a6c4fc013af2a01b498712d282559028b37
Reviewed-on: https://review.typo3.org/51009
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Add default values from setup.txt and raise override to 20 77/50977/4
Boris Schauer [Thu, 15 Dec 2016 13:36:40 +0000 (14:36 +0100)]
[BUGFIX] Add default values from setup.txt and raise override to 20

Update the indexed_search extension documentation with
proper TypoScript values for overriding templates.

Resolves: #79006
Releases: master, 7.6

Change-Id: Ie034d6b192675fa1a453622b90296d39c80d2447
Reviewed-on: https://review.typo3.org/50977
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Set title for select icons 97/50997/2
Marco Huber [Mon, 19 Dec 2016 16:50:02 +0000 (17:50 +0100)]
[BUGFIX] Set title for select icons

Use the select options label as title instead of
an uninitialized variable.

Resolves: #79037
Releases: master, 7.6
Change-Id: I690b687f5dd854556ac799d89c8462f4ce9966a4
Reviewed-on: https://review.typo3.org/50997
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Set TYPO3 version to 8.5.1-dev 08/51008/2
TYPO3 Release Team [Tue, 20 Dec 2016 14:11:14 +0000 (15:11 +0100)]
[TASK] Set TYPO3 version to 8.5.1-dev

Change-Id: I3f4991ebbf3117a062c8d3d63fd731990401ebe3
Reviewed-on: https://review.typo3.org/51008
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 8.5.0 07/51007/2 8.5.0 TYPO3_8-5-0
TYPO3 Release Team [Tue, 20 Dec 2016 14:10:25 +0000 (15:10 +0100)]
[RELEASE] Release of TYPO3 8.5.0

Change-Id: I0bc2ac481447671f0354375d9433ed0b9a2f47c8
Reviewed-on: https://review.typo3.org/51007
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[BUGFIX] setPartialRootPaths in the backend tabs menu 48/50948/4
Alexander Opitz [Tue, 13 Dec 2016 09:16:43 +0000 (10:16 +0100)]
[BUGFIX] setPartialRootPaths in the backend tabs menu

Adding the root paths to the partials, which aren't autoguessed anymore.

Resolves: #78969
Releases: master
Change-Id: I578fd21ed0b232198301f73c702569980ed82906
Reviewed-on: https://review.typo3.org/50948
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[DOCS] 8.5 Documentation 91/50991/4
Mathias Schreiber [Sat, 17 Dec 2016 16:55:23 +0000 (17:55 +0100)]
[DOCS] 8.5 Documentation

Added all documentation for CMS v8.5

Resolves: #
Releases: master
Change-Id: I6756ecd38a2d50553bcfc8687707b5c08f894435
Reviewed-on: https://review.typo3.org/50991
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FOLLOWUP][TASK] Remove support for transForeignTable in TCA 03/51003/2
Oliver Hader [Tue, 20 Dec 2016 10:29:18 +0000 (11:29 +0100)]
[FOLLOWUP][TASK] Remove support for transForeignTable in TCA

Some variable names have not been adjusted correctly.

Resolves: #78191
Releases: master
Change-Id: I107b9c5d146fb4a027d6457194c1c4e46f06cd8c
Reviewed-on: https://review.typo3.org/51003
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Allow t3:// syntax to be parsed by lib.parseFunc 00/51000/5
Benni Mack [Mon, 19 Dec 2016 20:36:21 +0000 (21:36 +0100)]
[BUGFIX] Allow t3:// syntax to be parsed by lib.parseFunc

When introducing the new t3:// linking syntax for typolink,
we also allowed to use them in the RTE without using <link>
anymore, which is really cool. However, the frontend (= TypoScript)
cannot deal with that yet.

A clean function within parseFunc should "transformLinks" with typolink.
For the time being, a parseFunc.tags.A is introduced to allow
the transformations to be rendered correctly.

It *could* have a side-effect that certain attributes
within parseFunc.tags.A are rendered twice, but can be solved
at a later point by sanitizing the attributes quite simple.

Resolves: #79041
Releases: master
Change-Id: Ib8da2a88b67a633fc89a5c1ddee90c8e14f5b27b
Reviewed-on: https://review.typo3.org/51000
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Re-set RTEHtmlArea as default RTE 99/50999/2
Benni Mack [Mon, 19 Dec 2016 19:54:10 +0000 (20:54 +0100)]
[TASK] Re-set RTEHtmlArea as default RTE

Due to the unfinished integration of CKEditor
in the TYPO3 Core, the default installation
should still use HtmlArea as default RTE
for new installations.

Resolves: #79040
Releases: master
Change-Id: If153ac427dad596ba470bb346d2257c9e0282a44
Reviewed-on: https://review.typo3.org/50999
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Installation process hangs with PHP 7.1 98/50998/3
Oliver Hader [Mon, 19 Dec 2016 17:56:03 +0000 (18:56 +0100)]
[TASK] Installation process hangs with PHP 7.1

The lengthy switch/case part of the Lexer class seems to be
too much for PHP 7.1.0. Albeit this seems to be a PHP bug,
this patch is provided to help others and to clean up the
mentioned switch/case code.

Change-Id: I0e8e4ca55f2e15d0445874b44a04742645670570
Resolves: #79039
Releases: master
Reviewed-on: https://review.typo3.org/50998
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Streamline EXT:form unit test 94/50994/2
Oliver Hader [Sun, 18 Dec 2016 12:21:09 +0000 (13:21 +0100)]
[TASK] Streamline EXT:form unit test

EXT:form's FormManagerControllerTest tries to mock
static method calls of BackendUtility. The methods
to be mocked are now wrapped directly instead of
"wrapping" the reference to the class name.

Change-Id: I7c6381fe093ecc28b85e235fcb425f6048c8ff0c
Resolves: #79023
Releases: master
Reviewed-on: https://review.typo3.org/50994
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Exception in EXT:form due to invalid array lookup 95/50995/5
Oliver Hader [Sun, 18 Dec 2016 13:15:43 +0000 (14:15 +0100)]
[BUGFIX] Exception in EXT:form due to invalid array lookup

Due to the changes of ArrayUtility in issue #77732
EXT:form now has to deal with these problems:

+ core's ArrayUtility uses a slash "/" as delimiter,
  but Extbase's ArrayUtility used a dot "."
+ core's ArrayUtility throws an exception if value is
  not defined, Extbase's ArrayUtility returned null

Change-Id: I26b043a28e376c99d50a9a36703b5927b09ee934
Resolves: #79024
Releases: master
Reviewed-on: https://review.typo3.org/50995
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Re-enable styling for workspace preview bar 95/50795/5
Benni Mack [Mon, 28 Nov 2016 16:24:17 +0000 (17:24 +0100)]
[BUGFIX] Re-enable styling for workspace preview bar

The workspace preview functionality (comparing versions etc)
is broken due to missing stylings since TYPO3 8.4

The patch fixes the CSS styles.

Resolves: #78820
Releases: master
Change-Id: I6ede8ee1913e91c0095d695ce2e5d90c16dbd5f7
Reviewed-on: https://review.typo3.org/50795
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP] Add functional test for cache backend flushByTags 24/50924/9
Claus Due [Sun, 11 Dec 2016 00:00:36 +0000 (01:00 +0100)]
[FOLLOWUP] Add functional test for cache backend flushByTags

Followup to https://review.typo3.org/#/c/50537/ to add
functional tests covering the new SQL operations.

Change-Id: I7a686fe2ed10d53506ff36d99a21f10379a9656d
Resolves: #78951
Releases: master
Reviewed-on: https://review.typo3.org/50924
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] FormArrayUtility not found 93/50993/2
Oliver Hader [Sun, 18 Dec 2016 10:20:23 +0000 (11:20 +0100)]
[BUGFIX] FormArrayUtility not found

The FormArrayUtility of EXT:form cannot be found and
results in a PHP fatal error. Reason for that is the
ArrayUtility cleanup in issue #77732.

Change-Id: Iaa4ad928e664a56aac2d71ed39faecbb67e38864
Resolves: #79022
Releases: master
Reviewed-on: https://review.typo3.org/50993
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Optimize cache handling in ReflectionService 53/50953/8
Helmut Hummel [Tue, 13 Dec 2016 22:39:13 +0000 (23:39 +0100)]
[BUGFIX] Optimize cache handling in ReflectionService

Method reflection objects are used temporarily to extract information
from methods. This information is eventually stored in the cache.
However the method reflection objects themselves must stay outside the cache
because they cannot be serialized. They also do not provide much value
as the information is stored in the cache anyway.
The only additional info these reflections provided is whether a method
existed or not in the class, which we now also cache as plain array.

Furthermore the information whether cache relevant properties were
updated and the cache needs to be saved again is now reset once it was
written. This ensures that the cache is only written once even the
ReflectionService is used multiple times.

Resolves: #78915
Resolves: #78977
Releases: master, 7.6, 6.2
Change-Id: I1d00f596633adab886c0db0dfddd71358fb67303
Reviewed-on: https://review.typo3.org/50953
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Stefan Rotsch <stefan.rotsch@aoe.com>
Tested-by: Stefan Rotsch <stefan.rotsch@aoe.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Load page info when only getting external tables 55/50955/3
Johannes Schlier [Wed, 14 Dec 2016 12:46:45 +0000 (13:46 +0100)]
[BUGFIX] Load page info when only getting external tables

Previously the PageLayoutView would only set the page info when getting
the tt_content of the page in function ‘getTable_tt_content’.
If a user only has rights to view/edit records from other tables, but
not tt_content, the page info is null, as ‘getTable_tt_content’ is never
called.

Resolves: #78991
Releases: master, 7.6
Change-Id: Iabcad89a23b245e8c6a8e23fa420fcab5c1ea8e4
Reviewed-on: https://review.typo3.org/50955
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years agoRevert "[BUGFIX] Reflection Cache does not save methodReflections" 63/50963/4
Helmut Hummel [Thu, 15 Dec 2016 00:20:22 +0000 (01:20 +0100)]
Revert "[BUGFIX] Reflection Cache does not save methodReflections"

Internal PHP classes including the \ReflectionMethod are not serlializable. Doing so results in a fatal error at some point.
The reported issue must be solved differently.

This reverts commit a5c1e222bf9858f5a44af1007cd9e1677b9a534d.

Reverts: #78915
Resolves: #78977
Releases: master, 7.6, 6.2
Change-Id: I1161b97eb04d0b1ba8ca59b3008d3f62c6ea1cf5
Reviewed-on: https://review.typo3.org/50963
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Update seiyria-bootstrap-slider to 9.5.3 40/50940/3
Andreas Fernandez [Mon, 12 Dec 2016 18:21:38 +0000 (19:21 +0100)]
[TASK] Update seiyria-bootstrap-slider to 9.5.3

Resolves: #78967
Releases: master
Change-Id: Ic8801470c886701a43acedfeb74a8085352774db
Reviewed-on: https://review.typo3.org/50940
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix RTE in Inline Elements 54/50954/6
Helmut Hummel [Tue, 13 Dec 2016 23:57:05 +0000 (00:57 +0100)]
[BUGFIX] Fix RTE in Inline Elements

HTMLArea needs a global JavaScript variable to work correctly.
Before the change done for #77600, this variable was always initialized
by including a JS file when any backend editing form was rendered.

In this mentioned cleanup, this initialization code was moved to
the place where the RTE is actually rendered. But because this can
also happen in an Ajax request, where the needed JS calls are returned
as array and evaluated line by line with `eval`, the code to initialize
the global variable did not work, because it was prefixed with `var`

This lead to a JS error at a later point where the global var is accessed.

To fix this, we force to set/ initialize the global variable, by prefixing
it with the "super global" object `window`. Now the global `HTMLArea` variable
is also initialized when this code is executed in a `eval` context,
when loading RTE fields of IRRE records via Ajax.

Resolves: #78972
Related: #77600
Releases: master
Change-Id: I7bf1386d3f6f395223bb82d870de0c7868733f67
Reviewed-on: https://review.typo3.org/50954
Reviewed-by: David Greiner <hallo@davidgreiner.de>
Tested-by: David Greiner <hallo@davidgreiner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[FOLLOWUP][TASK] TCA: Streamline field position in tabs 61/50961/3
Helmut Hummel [Wed, 14 Dec 2016 20:47:16 +0000 (21:47 +0100)]
[FOLLOWUP][TASK] TCA: Streamline field position in tabs

Fix some typos and a leading newline in a PHP file

Related: #78383
Releases: master
Change-Id: I483b09abf02a9f109350284e31cba15848004e5c
Reviewed-on: https://review.typo3.org/50961
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[TASK] Deprecate Extbase's ArrayUtility 96/49696/20
Benni Mack [Wed, 31 Aug 2016 19:17:16 +0000 (21:17 +0200)]
[TASK] Deprecate Extbase's ArrayUtility

The copied methods from ArrayUtility can be removed
and be replaced with some PHP native functionality
or the equivalent functionality.

Resolves: #77732
Releases: master
Change-Id: I6c5f4bced77f40f5000d8fb0abb151d54fbc1c8e
Reviewed-on: https://review.typo3.org/49696
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Add Support for Doctrine DBAL Queries in Extbase 78/50178/8
Benni Mack [Mon, 10 Oct 2016 19:19:40 +0000 (21:19 +0200)]
[FEATURE] Add Support for Doctrine DBAL Queries in Extbase

To fully utilize Extbase in conjunction with Doctrine DBAL,
Extbases' StorageBackend now supports native QueryBuilder
and Doctrine DBAL Statements, which can be used for prepared
statements.

Resolves: #78116
Releases: master
Change-Id: I73b5a9588465e345029b7985327fb0cd0d7875df
Reviewed-on: https://review.typo3.org/50178
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Fluidification of ShortcutToolbarItem 43/50943/2
Susanne Moog [Mon, 12 Dec 2016 20:18:16 +0000 (21:18 +0100)]
[FOLLOWUP][TASK] Fluidification of ShortcutToolbarItem

No changes to parameters in language labels are allowed therefore
a new label for the bookmark description is needed.

Change-Id: Ib1997282905eb8321b903235581d9931449c85d8
Resolves: #77800
Releases: master
Reviewed-on: https://review.typo3.org/50943
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
2 years ago[BUGFIX] Fix exception in QuickEdit mode for empty pages 10/50910/3
Manuel Selbach [Thu, 8 Dec 2016 22:22:15 +0000 (23:22 +0100)]
[BUGFIX] Fix exception in QuickEdit mode for empty pages

If there is no content on a page the parameter $this->eRParts[1] will be
set to e.g. /new/1 which is not an integer value and it will throw an
exception here on certain dbms, thus let's check that before as there could
not be a history on a new record and skip the query to prevent the error.

Change-Id: If33c5de067b7685e5723ceb7aa1586640abc99d8
Resolves: #78925
Releases: master, 7.6, 6.2
Reviewed-on: https://review.typo3.org/50910
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Order extensions by integerVersion instead of version 00/50900/5
Ulrik Høyer Kold [Thu, 8 Dec 2016 14:53:16 +0000 (15:53 +0100)]
[BUGFIX] Order extensions by integerVersion instead of version

Return the results of findByExtensionKeyOrderedByVersion ordered by
column 'integerVersion' instead of 'version' in order to avoid a wrong
order for version numbers like "1.9.2" and "1.10.0".

Releases: master, 7.6
Resolves: #78923
Change-Id: I89f5cf54aa4ee7ac87c5af2aa4ac3946d53f10d6
Reviewed-on: https://review.typo3.org/50900
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Reflection Cache does not save methodReflections 13/50913/3
Valentin Despa [Fri, 9 Dec 2016 09:22:42 +0000 (10:22 +0100)]
[BUGFIX] Reflection Cache does not save methodReflections

The cached data of the Reflection Cache (table cf_extbase_reflection)
is not stored in its complete form.

The data/part of property 'methodReflections' is NOT stored in the cache.
As a result, the Reflection Cache will be deleted/inserted each time the
methodReflections property is needed

Resolves: #78915
Releases: master,7.6,6.2
Change-Id: I7b2f7477132abca2e10826bed6e78cb1195d2b26
Reviewed-on: https://review.typo3.org/50913
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Lowlevel: Clean up $versionSwapmode 04/50904/3
Benni Mack [Tue, 25 Oct 2016 05:44:41 +0000 (07:44 +0200)]
[TASK] Lowlevel: Clean up $versionSwapmode

The versionSwapmode is a orphan with a multivalue
which can easily be handled as boolean since TYPO3 6.0,
where workspaces mode "1" (page-based branching model)
was not supported anymore.

Resolves: #78947
Releases: master
Change-Id: I9b9887a306769f39f2e085110819cce4fe514067
Reviewed-on: https://review.typo3.org/50904
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>