Packages/TYPO3.CMS.git
22 months ago[BUGFIX] Fix keepItems and removeItems handling with 0 values 23/54623/2
Helmut Hummel [Sun, 12 Nov 2017 18:27:49 +0000 (19:27 +0100)]
[BUGFIX] Fix keepItems and removeItems handling with 0 values

TSConfig properties keepItems and removeItems are checked
with a weak in_array() test (third argument not set to true),
which leads to the situation, that arbitrary string values
are treated equal to integer 0

This is now fixed by flipping the array and check for the
array index. This works nicely because PHP silently
converts strings which look like integer to integer for the keys.

Tests are added which cover these cases and demonstrate
the failure before the change.

Resolves: #82980
Releases: 8.7, master
Change-Id: I544a221674fa89d302cb6c1bcca506847c6f7f0f
Reviewed-on: https://review.typo3.org/54623
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
22 months ago[FOLLOWUP][TASK] FAL-based database fields moved to integer 68/54668/2
Oliver Hader [Thu, 16 Nov 2017 17:19:56 +0000 (18:19 +0100)]
[FOLLOWUP][TASK] FAL-based database fields moved to integer

Remove duplicated "image" field definition in test scenario.

Related: #69909
Releases: master, 8.7
Change-Id: Ie87e2e62e036fa70fb837f9bd05f2c3ba13019fa
Reviewed-on: https://review.typo3.org/54668
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
22 months ago[BUGFIX] Avoid invalid references in DataMapProcessor 55/54655/6
Oliver Hader [Wed, 15 Nov 2017 15:07:57 +0000 (16:07 +0100)]
[BUGFIX] Avoid invalid references in DataMapProcessor

If DataMapProcessor is called with a non-reference id, e.g.
zero (0), this submission is considered as a reference. Since
there is no database record having UID 0, the synchronization
process fails with the following exeception:

#1486233164: Child record was not processed

To solve this behavior, invalid references (empty/zero) are
not considered anymore to compare references. Besides that,
values for localized records that are configured to be
synchronized are sanitized correctly now.

Resolves: #83009
Releases: master, 8.7
Change-Id: Ie370007521c45dac8bca03978a387b4662952b1d
Reviewed-on: https://review.typo3.org/54655
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
22 months ago[FEATURE] Replace @inject with @TYPO3\CMS\Extbase\Annotation\Inject 90/54590/10
Alexander Schnitzler [Wed, 8 Nov 2017 13:57:33 +0000 (14:57 +0100)]
[FEATURE] Replace @inject with @TYPO3\CMS\Extbase\Annotation\Inject

This patch introduces the usage of doctrine annotations.
Therefore the AnnotationRegistry is configured during the
bootstrap and the annotation "TYPO3\CMS\Extbase\Annotation\Inject"
is evaluated when building a ClassSchema for a class.

On top of that this patch puts the static variable
$ignoredTags into the DocCommentParser class, which
saved quite some bytes of RAM when reconstituting
the ClassSchema objects from the cache.

Resolves: #82869
Releases: master
Change-Id: I99d17706395ebc0c308c7f611c59f207fe0b6233
Reviewed-on: https://review.typo3.org/54590
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[BUGFIX] Fix notices in UserAuthentication 52/54652/3
Tymoteusz Motylewski [Wed, 15 Nov 2017 14:20:07 +0000 (15:20 +0100)]
[BUGFIX] Fix notices in UserAuthentication

Resolves: #83003
Releases: master, 8.7
Change-Id: Iceaa7ab9bd436322229e591677c0aee16cd69f5c
Reviewed-on: https://review.typo3.org/54652
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[BUGFIX] Add correct conversion of RTE pageTS config 11/54511/8
Frans Saris [Tue, 31 Oct 2017 15:32:51 +0000 (16:32 +0100)]
[BUGFIX] Add correct conversion of RTE pageTS config

Add all pageTS.RTE options to config without dots appended to the key
to be able to override the RTE config with pageTS like before.

Resolves: #82865
Releases: master, 8,7
Change-Id: Idb7d7d3b39d44ec37be8f93cc9de8b42b9c8a55c
Reviewed-on: https://review.typo3.org/54511
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
22 months ago[BUGFIX] Remove "[newlog()] " from DataHandler log info 60/54660/2
Benni Mack [Thu, 16 Nov 2017 11:10:55 +0000 (12:10 +0100)]
[BUGFIX] Remove "[newlog()] " from DataHandler log info

DataHandlers' newlog() function is a shorthand method that
should act as a simple API, which it does, but it also adds
a "[newlog()] " info in front of the error message, which is
completely useless and only clutters DB and the log module.

Resolves: #83012
Releases: master, 8.7
Change-Id: I9e1ea083461de9cdf66fad1a30019e51130a0186
Reviewed-on: https://review.typo3.org/54660
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[BUGFIX] Use correct parameters for trimExplode 40/54640/3
Wouter Wolters [Tue, 14 Nov 2017 18:05:15 +0000 (19:05 +0100)]
[BUGFIX] Use correct parameters for trimExplode

In QueryBuilder::quoteIdentifiersForSelect the 3rd parameter of
trimExplode is inserted. To prevent notices array_pad is added.

Resolves: #82995
Releases: master,8.7
Change-Id: If35efcf5c8c3fd5b0360ae8795f9b92ae87250ab
Reviewed-on: https://review.typo3.org/54640
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
22 months ago[BUGFIX] Fix some PHP Notices thrown when rendering page module 58/54558/9
Tymoteusz Motylewski [Mon, 6 Nov 2017 08:12:26 +0000 (09:12 +0100)]
[BUGFIX] Fix some PHP Notices thrown when rendering page module

Resolves: #82921
Releases: master, 8.7
Change-Id: Id26239e65321aa3653de849932a0be7e626bd653
Reviewed-on: https://review.typo3.org/54558
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Do not iterate over empty logger configuration 53/54653/2
Tymoteusz Motylewski [Wed, 15 Nov 2017 14:23:32 +0000 (15:23 +0100)]
[BUGFIX] Do not iterate over empty logger configuration

Fixes PHP notices thrown by accessing non existing array key.

Resolves: #83004
Releases: master
Change-Id: Ib5ff0ace0c9eb9a9987693176c4bee25026e2eb8
Reviewed-on: https://review.typo3.org/54653
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[FEATURE] Add hook for used/unused content record processing 11/53811/15
Claus Due [Sat, 26 Aug 2017 19:28:43 +0000 (21:28 +0200)]
[FEATURE] Add hook for used/unused content record processing

This patch adds a new hook to determine whether a content record is
used or not. Since the default decision is fairly basic (only checks if
$columns contains $record['colPos']) a hook makes it possible for third
party extensions to change the decision and validate on their own.

Included rst file shows how to register to the hook and provides example
code how to determine the result.

Resolves: #82213
Releases: master
Change-Id: Id338254dae6575ba7b91141c10a42b99401614c9
Reviewed-on: https://review.typo3.org/53811
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[BUGFIX] FileStorageExtractionTask breaks if file not found 69/51969/7
Thomas Hohn [Tue, 7 Mar 2017 07:19:46 +0000 (08:19 +0100)]
[BUGFIX] FileStorageExtractionTask breaks if file not found

Before the file is processed a extra check is done to be sure the file
exists. If the file doesn't exist it's marked as missing.

Resolves: #80061
Releases: master, 8.7
Change-Id: Ifda396b75d2ace0ce126057a4e118856b15c05e0
Reviewed-on: https://review.typo3.org/51969
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Allow all fields in felogin hook "forgotPasswordMail" 28/54628/5
Tom Novotny [Mon, 13 Nov 2017 14:56:51 +0000 (15:56 +0100)]
[TASK] Allow all fields in felogin hook "forgotPasswordMail"

Return all fields to ease the work with hooks.
Intention is not having to query again in hook
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['felogin']['forgotPasswordMail']
to change "Hello [username],..." to "Hello [fist_name] [last_name],..."
in password forgot mail to user.

Change-Id: I18e18845e61d36aadd043758f902dc6627ad5f37
Resolves: #82996
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54628
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[TASK] Extend untangleFilesArray function test in RequestBuilder 19/54619/5
Joshua Westerheide [Sat, 11 Nov 2017 16:42:05 +0000 (17:42 +0100)]
[TASK] Extend untangleFilesArray function test in RequestBuilder

Check for cases where the files array is nested more complex or
keywords (e.g. "error") are used as field names.

Run `curl -F "d0[]=@d12.txt" -F "d0[d1][d2][d3]=@d12.txt"
-F "error=@error_file.txt" localhost:8080` against a custom
php script to generate the testing $_FILES array.

Resolves: #82976
Releases: master, 8.7, 7.6
Change-Id: I51fb9da7c87871b6bb1e8ac4de317973f307dd49
Reviewed-on: https://review.typo3.org/54619
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[BUGFIX] Ensure "pid" and "parentid" of pages - inline fields are correct 32/54632/6
Benni Mack [Mon, 13 Nov 2017 19:33:53 +0000 (20:33 +0100)]
[BUGFIX] Ensure "pid" and "parentid" of pages - inline fields are correct

When doing translations with pages and inline elements (e.g. pages.media),
there is an inconsistency when an additional inline element is added to the
TRANSLATED page (e.g. language=1).

Current (wrong) when adding a translation to a page
- localized IRRE children get pid = default page ID (correct)
- localized IRRE children only localization get parentid = default page ID (should be translated page ID)

Current (wrong) behaviour when adding a IRRE child only available in a translation:
- parentid gets localized page => correct
- pid gets set to localized page => must be default language

The patch corrects this behaviour by always set
- the relation (parentid) to the localized page ID
- the page ID (pid) to the default language page ID

Additionally, when adding an Inline element (IRRE) via AJAX
on page properties, the PID gets resolved correctly to be sent
to DataHandler.

Resolves: #82983
Releases: master
Change-Id: Id8bf39524ee608acf452e2b7103087d4299c1e28
Reviewed-on: https://review.typo3.org/54632
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Do not silently ignore exceptions in ImageViewhelper 61/54561/5
Sascha Egerer [Fri, 3 Nov 2017 19:48:56 +0000 (20:48 +0100)]
[TASK] Do not silently ignore exceptions in ImageViewhelper

Exceptions in the ImageViewhelper are currently silently ignored.
So you'll get no information if a wrong value has been passed
to the src attribute or if there went something wrong.
The exception is not rethrown as Fluid viewhelper exception so
it will be catched and logged in Production Context by the
AbstractViewhelper that calls the render method.

Change-Id: I95124ebb945366d260b4351ccb85d61a399c50b5
Resolves: #82918
Releases: master
Reviewed-on: https://review.typo3.org/54561
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
23 months ago[BUGFIX] Stabilize Language Acceptance tests 31/54631/10
Mathias Schreiber [Mon, 13 Nov 2017 17:57:01 +0000 (18:57 +0100)]
[BUGFIX] Stabilize Language Acceptance tests

Stabilize the acceptance tests to activate and deactivate a language by
checking only for the alerts instead of the enabled/disabled rows.

Additionally make the download a language test fail immediately if the
language is enabled.

Resolves: #82972
Releases: master, 8.7
Change-Id: Ib380b464a24188dbbee37296ddda0f0bb5c44f5e
Reviewed-on: https://review.typo3.org/54631
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Remove orderBy in count query 38/54638/2
Susanne Moog [Tue, 14 Nov 2017 14:19:25 +0000 (15:19 +0100)]
[BUGFIX] Remove orderBy in count query

OrderBy does not make sense in a count only query and
fails on SQL Server, hence it is removed.

Change-Id: I676d1913f75c29dd71345dbc0f626e99df0d242f
Resolves: #82994
Releases: master
Reviewed-on: https://review.typo3.org/54638
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Handle variadic arguments in Extbase DebuggerUtility 00/54600/5
Mathias Brodala [Thu, 9 Nov 2017 08:42:04 +0000 (09:42 +0100)]
[BUGFIX] Handle variadic arguments in Extbase DebuggerUtility

Variadic arguments are optional but do not have a default value, thus
properly check this.

Also render the variadic operator ("...") in the output.

Resolves: #82956
Releases: master, 8.7
Change-Id: I10e3528d9cffcdd03ae4711b139898f569ac3775
Reviewed-on: https://review.typo3.org/54600
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Add label to page ID field in PageLinkHandler 75/54575/4
Georg Ringer [Tue, 7 Nov 2017 07:08:42 +0000 (08:08 +0100)]
[BUGFIX] Add label to page ID field in PageLinkHandler

Add the missing label and adopt styling of the additional
field which allows to link to a page by providing the page ID.

Resolves: #82888
Releases: master, 8.7
Change-Id: I33ab92f235391add5d3da00a0251ee11eb936933
Reviewed-on: https://review.typo3.org/54575
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[TASK] Deprecate usage of @inject with non-public properties 18/54618/7
Alexander Schnitzler [Sat, 11 Nov 2017 13:53:26 +0000 (14:53 +0100)]
[TASK] Deprecate usage of @inject with non-public properties

When using private or protected properties for Dependency Injection
via `@inject`, Extbase needs to use the object reflection API to
make these properties settable from the outside, which is quite
slow and cannot be cached in any way. Therefore property injection
should only work for public properties.

Releases: master
Resolves: #82975
Change-Id: Ia9c6eb48c34c46634e626f7cd97a2e743a6aba7b
Reviewed-on: https://review.typo3.org/54618
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[BUGFIX] Add FLUIDTEMPLATE to t3editor code completion 14/54614/6
Andreas Fernandez [Sun, 5 Nov 2017 12:09:17 +0000 (13:09 +0100)]
[BUGFIX] Add FLUIDTEMPLATE to t3editor code completion

With this patch t3editor is now aware of `FLUIDTEMPLATE`, thus supported
by code completion.

Resolves: #82967
Releases: master, 8.7
Change-Id: I82cc9bd22a5a0829ea634eb5cfda4bc8e589c1cc
Reviewed-on: https://review.typo3.org/54614
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[TASK] Upgrade chromedriver to 2.33 29/54629/4
Christian Kuhn [Mon, 13 Nov 2017 16:53:48 +0000 (17:53 +0100)]
[TASK] Upgrade chromedriver to 2.33

Use latest chromedriver to deal with youngest chrome
in acceptance tests.

Change-Id: I7d637022fa9e327e771198625943b11b986b5a04
Resolves: #82987
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54629
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Improve performance iterating local files 76/54576/4
Stephan Großberndt [Tue, 7 Nov 2017 08:44:24 +0000 (09:44 +0100)]
[BUGFIX] Improve performance iterating local files

Improve performance iterating local files by avoiding multiple calls to
SplFileInfo.

Releases: master, 8.7
Resolves: #82936
Change-Id: I54b347ad4734d9083b67c7840ff3ab228c07f4bc
Reviewed-on: https://review.typo3.org/54576
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
23 months ago[BUGFIX] Fix path-resolution for template-resource in EXT:felogin 22/54622/4
Daniel Siepmann [Sun, 12 Nov 2017 13:50:40 +0000 (14:50 +0100)]
[BUGFIX] Fix path-resolution for template-resource in EXT:felogin

Do not use frontend inclusion API for private template resource.
Instead resolve to full absolute path for inclusion.

Releases: master, 8.7
Resolves: #82978
Resolves: #82979
Change-Id: Iadd3a8386b967aeb8b5ffdb28baeb73c2a0f2734
Reviewed-on: https://review.typo3.org/54622
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[FOLLOWUP][TASK] Migrate pages_language_overlay into pages 91/54591/2
Benni Mack [Wed, 8 Nov 2017 13:25:24 +0000 (14:25 +0100)]
[FOLLOWUP][TASK] Migrate pages_language_overlay into pages

An additional SQL index is added to the database.

Resolves: #82445
Releases: master
Change-Id: I94d1eab5f492b465fafbf3620b0f532e1403be76
Reviewed-on: https://review.typo3.org/54591
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots 07/54007/7
Oliver Hader [Fri, 8 Sep 2017 10:43:03 +0000 (12:43 +0200)]
[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots

If checkbox/radiobox values contain dots, these are falsely evaluated as
array lookup paths. Fix this by passing in separate path segments instead
which may contain dots.

Resolves: #82210
Releases: master, 8.7
Change-Id: Ib3d0d1abbeb4fdf84da427f6bea0d597ba9aade6
Reviewed-on: https://review.typo3.org/54007
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[BUGFIX] Add missing code-block:: php line in feature rst file 12/54612/2
Frans Saris [Fri, 10 Nov 2017 10:54:40 +0000 (11:54 +0100)]
[BUGFIX] Add missing code-block:: php line in feature rst file

Resolves: #82964
Releases: master, 8.7
Change-Id: Iccaae0c2aeefa7c82b3df50956424509acea4233
Reviewed-on: https://review.typo3.org/54612
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Show deleted page actions in record history 80/54580/5
Helmut Hummel [Tue, 7 Nov 2017 14:09:08 +0000 (15:09 +0100)]
[BUGFIX] Show deleted page actions in record history

Because users have no access to deleted pages,
the access check always fails, leading to delete page
actions not being shown in the history despite being
properly tracked.

We now check this case and do a more lightweight check
so that we still have the permissions checked,
but can show deleted pages without disclosing unwanted
information.

Resolves: #45056
Releases: 7.6, 8.7, master
Change-Id: Id919a24651c18a351f9723e86610b525a4f4726c
Reviewed-on: https://review.typo3.org/54580
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Update typo3/cms-composer-installers 70/54570/3
Alexander Opitz [Mon, 6 Nov 2017 12:05:21 +0000 (13:05 +0100)]
[TASK] Update typo3/cms-composer-installers

Update the lock file to pull in the latest (1.4.5) release.
This version is marked as PHP 7.2 compatible.
composer command: composer update typo3/cms-composer-installers

Releases: 8.7, master
Resolves: #82898
Change-Id: I6c491ae7e93f656c01a9ef12d88969057b182ba7
Reviewed-on: https://review.typo3.org/54570
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[TASK] EXT:form - cache merged YAML settings 06/54106/7
Ralf Zimmermann [Sun, 10 Sep 2017 16:51:35 +0000 (18:51 +0200)]
[TASK] EXT:form - cache merged YAML settings

Cache the merged YAML settings into the assets cache to improve the
performance.

Resolves: #82373
Releases: master, 8.7
Change-Id: I601364d5957f26f1b369b513534936820f72b78e
Reviewed-on: https://review.typo3.org/54106
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Reduce PHP queries of pagetree SQL 74/54574/13
Benni Mack [Tue, 7 Nov 2017 06:36:31 +0000 (07:36 +0100)]
[TASK] Reduce PHP queries of pagetree SQL

The TYPO3 Backend PageTree, built in TYPO3 4.5, has
some strange quirks resolving DB records, doing
a lot of queries for fetching a single page multiple
times. This is unnecessary because this can be fetched
with one query, which happens anyway. Additionally,
the WSOL should only happen when a workspace is selected.

Explicitly querying for "-1" pid etc. should be handled
via SQL, and not explicitly implemented by the page tree.

Bottom line: Remove one SQL-query per page which is loaded.

As most of the PHP classes will be restructured with the upcoming
ExtJS / ExtDirect removal, the removed methods will be part
of the breaking change of ExtJS removal.

Resolves: #82945
Releases: master
Change-Id: I7b1d79b40d0e9212cc0884c9440e5725e4f74d8e
Reviewed-on: https://review.typo3.org/54574
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[BUGFIX] Properly encode text in JS in install tool 86/54586/4
Susanne Moog [Wed, 8 Nov 2017 14:30:11 +0000 (15:30 +0100)]
[BUGFIX] Properly encode text in JS in install tool

Several times the install tool was using html()
instead of text(). Use text() whenever possible.

Resolves: #82949
Releases: master
Change-Id: I9a199d33f233a3b6c6b82965d4bc169999a3452a
Reviewed-on: https://review.typo3.org/54586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Update ext:styleguide to 9.0.0 92/54592/4
Christian Kuhn [Wed, 8 Nov 2017 14:54:06 +0000 (15:54 +0100)]
[TASK] Update ext:styleguide to 9.0.0

The v9/master branch of styleguide generates correct
page localizations of styleguide demo data pages in
table pages instead of pages_language_overlay.

Change-Id: I1186f421cb4c5f05e508d19e60b9a580a7c3d5dc
Resolves: #82952
Related: #82445
Releases: master
Reviewed-on: https://review.typo3.org/54592
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Update ext:styleguide to 8.0.13 88/54588/3
Christian Kuhn [Wed, 8 Nov 2017 13:03:51 +0000 (14:03 +0100)]
[TASK] Update ext:styleguide to 8.0.13

This is probably the last version with v8 and v9
in sync before branching off styleguide v8.

Styleguide introduced a new table with 8.0.13, one
of the acceptance tests that uses a rather hard coded
xpath now needs a slightly different selector to cope
with that.

Change-Id: I7ef4f840807963e6a93a90bda394657b8c36c6a0
Resolves: #82951
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54588
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[FOLLOWUP][FEATURE] Load new content element wizard via modal instead of new page 87/54587/3
Andreas Fernandez [Wed, 8 Nov 2017 12:31:17 +0000 (13:31 +0100)]
[FOLLOWUP][FEATURE] Load new content element wizard via modal instead of new page

Ensure that jQuery is available in NewRecordController.

Resolves: #75676
Releases: master
Change-Id: Idf437554fb136e8e4ae18ce0d229d6b3ed8a58e4
Reviewed-on: https://review.typo3.org/54587
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
23 months ago[FEATURE] Load new content element wizard via modal instead of new page 99/52999/40
Cybercraft [Thu, 1 Jun 2017 16:22:40 +0000 (18:22 +0200)]
[FEATURE] Load new content element wizard via modal instead of new page

Instead of having the new content element wizard in a separate module page
it will be opened in a modal now.

Resolves: #75676
Releases: master
Change-Id: If117fe3f2d55a4163bcb5c153b47938953050348
Reviewed-on: https://review.typo3.org/52999
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
23 months ago[!!!][TASK] Migrate pages_language_overlay into pages 72/51272/88
Benni Mack [Thu, 2 Nov 2017 11:29:51 +0000 (12:29 +0100)]
[!!!][TASK] Migrate pages_language_overlay into pages

The patch migrates all data from pages_language_overlay into pages,
and moves all API calls to overlay pages.

The following restrictions are set:
* Backend is always showing pages only for "sys_language_uid=0"
  for the page tree, element browser (e.g. "linking to default
  language page"), except where explicitly requested like the Page
  Module => Languages view.
* pid and sorting are always the same for all translations and
  their default language page
* Elements on a page are always keeping the field "pid" to the
  default language page (no change)
* Permission checks for Backend users are always made against
  the default language page (perms_* fields and webmounts)

Resolves: #82445
Releases: master
Change-Id: I62536e21d7110fa434c75fbd4470a3f53b79d260
Reviewed-on: https://review.typo3.org/51272
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[!!!][TASK] Remove sys_domain.forced database field 40/54540/8
Benni Mack [Fri, 3 Nov 2017 10:43:48 +0000 (11:43 +0100)]
[!!!][TASK] Remove sys_domain.forced database field

The DB setting "sys_domain.forced" is confusing and does not make sense
nowadays, especially with nested domain records - where the rootline is now
correctly traversed with the RootLine utility.

Resolves: #82926
Releases: master
Change-Id: I874c54aeb03c0b62c9a1cebc9d629cee7550ec0b
Reviewed-on: https://review.typo3.org/54540
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[BUGFIX] Add workspace overlay for translated page title 83/54583/2
Georg Ringer [Tue, 7 Nov 2017 19:40:29 +0000 (20:40 +0100)]
[BUGFIX] Add workspace overlay for translated page title

The title of a translated page must be overlayed with the
workspace version.

Resolves: #65607
Releases: master, 8.7, 7.6
Change-Id: If10260f196776a16a53968b78542827ecbc145fe
Reviewed-on: https://review.typo3.org/54583
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] TcaMigration should not skip on existing overrideChildTca 93/52693/5
Malte Koitka [Wed, 3 May 2017 07:42:16 +0000 (09:42 +0200)]
[BUGFIX] TcaMigration should not skip on existing overrideChildTca

If an overideChildTca key is already added by a TYPO3 core
function like ExtensionManagementUtility::getFileFieldTCAConfig()
the TCA migration should not be skipped. Otherwise the config will
be incomplete and result in missing fields.

The migration is changed that old "foreign_types",
"foreign_selector_fieldTcaOverride" and "foreign_record_defaults"
are merged into new "overrideChildTca", but the new settings
are keps (take precedence) if given.

Resolves: #80719
Resolves: #81045
Releases: master, 8.7
Change-Id: Ic8a0338e0a9882b3b1e7abcd3123fbd7aa2b3505
Reviewed-on: https://review.typo3.org/52693
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Unify Backend module registration for Extbase modules 31/54531/13
Benni Mack [Thu, 2 Nov 2017 14:03:23 +0000 (15:03 +0100)]
[TASK] Unify Backend module registration for Extbase modules

This patch unifies the Backend module registration for Extbase modules
like it has already been done for all other Backend modules using PSR-7
entry-points. This way backend route dispatching and module registration
has been simplified.

The entrypoint for Extbase Backend modules is now
\TYPO3\CMS\Extbase\Core\Bootstrap->handleBackendRequest()
which returns a PSR-7 response object.

The following functionality has been marked as deprecated as it was
solely built to handle Extbase modules when conf.php and index.php were
still in style:

ExtensionManagementUtility::configureModule()
$GLOBALS['TBE_MODULES']['_configuration'][$name]['configureModuleFunction']

Releases: master
Resolves: #82902
Related: #58621
Change-Id: I7956b350d650ed52bc7b5d83db20df386d79eb65
Reviewed-on: https://review.typo3.org/54531
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[TASK] Filter duplicate cache commands from CacheQueue 69/54569/2
Benjamin Rannow [Mon, 6 Nov 2017 11:58:49 +0000 (12:58 +0100)]
[TASK] Filter duplicate cache commands from CacheQueue

under the right condition multiple duplicate cache commands are executed

for Example: save a record in Backend can course multiple 'pages'
commands will be executed, if the record has inline records.

flushing '20' times the 'pages' cache is unnecessary.

Resolves: #82930
Releases: master, 8.7
Change-Id: I69e581cb7f12acbd8172b2ca88e89f93ebfbe4b4
Reviewed-on: https://review.typo3.org/54569
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Apply JS CGL on SvgTree files 72/54572/2
Tymoteusz Motylewski [Mon, 6 Nov 2017 21:59:23 +0000 (22:59 +0100)]
[TASK] Apply JS CGL on SvgTree files

In order to make page tree smaller and easier to review,
this patch applies new JS CGLs on SvgTree related files.

Releases: master
Resolves: #82935
Change-Id: I5c9b8b889b21e77b4bcd7add2236eb849d204356
Reviewed-on: https://review.typo3.org/54572
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Add Fluid expressions and pre-processors global config 95/54395/4
Claus Due [Sat, 14 Oct 2017 12:19:49 +0000 (14:19 +0200)]
[TASK] Add Fluid expressions and pre-processors global config

This patch moves a previously hardcoded list of Fluid
implementations from the RenderingContext constructor,
to TYPO3_CONF_VARS. Extensions and site administrators
can then add their own implementations to this array and
have them be used in every RenderingContext.

See included RST file for further information on usage.

Change-Id: I6190ceb410e1121ea935a31237cb8bcd0b2f0417
Resolves: #82763
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54395
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mattias Nilsson <tollepjaer@gmail.com>
Tested-by: Mattias Nilsson <tollepjaer@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
23 months ago[BUGFIX] Element file browser respects allowedExtensions 20/54520/2
Christian Kuhn [Wed, 1 Nov 2017 13:05:33 +0000 (14:05 +0100)]
[BUGFIX] Element file browser respects allowedExtensions

The type=input, renderType=inputLink field control has an option
"allowedExtensions" to restrict the file element browser to specific
file endings. This option is now correctly considered in file browser.

Change-Id: Ic42bd0de06002f308d7db4098c704ca2574e4018
Resolves: #82861
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54520
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[BUGFIX] Fix path to language file in SelectTreeElement 71/54571/2
Tymoteusz Motylewski [Mon, 6 Nov 2017 20:38:21 +0000 (21:38 +0100)]
[BUGFIX] Fix path to language file in SelectTreeElement

Fixes missing labels in the svg category tree toolbar.

Releases: master
Resolves: #82934
Change-Id: Iac29bc35b40894630599b3fbec48daf870a8777a
Reviewed-on: https://review.typo3.org/54571
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[TASK] Updated Examples for Usage 46/54546/2
Dandy Umlauft [Fri, 3 Nov 2017 16:49:12 +0000 (17:49 +0100)]
[TASK] Updated Examples for Usage

Added default and inline usage for the optional attribute "allowedTags"

Maybe you have to think about the name, cause in
http://php.net/manual/de/function.strip-tags.php the second parameter is
called "allowableTags", and not "allowedTags" This can lead to a quick
overlooked error ;)

Releases: master
Resolves: #82912
Change-Id: Icc3cab9a931790e621f5593ea487c9b23b779e30
Reviewed-on: https://review.typo3.org/54546
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
23 months ago[TASK] Update typo3/cms-composer-installers 68/54568/2
Helmut Hummel [Mon, 6 Nov 2017 11:03:16 +0000 (12:03 +0100)]
[TASK] Update typo3/cms-composer-installers

Update the lock file to pull in the latest release.
composer command: composer update typo3/cms-composer-installers

Releases: 8.7, master
Resolves: #82898
Change-Id: Idde56a61ce718da2d06cc70fc0e53b834ac44981
Reviewed-on: https://review.typo3.org/54568
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
23 months ago[!!!][TASK] Remove hardly used pagetree related TS options 60/54560/3
Benni Mack [Sun, 5 Nov 2017 15:37:11 +0000 (16:37 +0100)]
[!!!][TASK] Remove hardly used pagetree related TS options

The following pageTSconfig options are removed:

- options.pageTree.excludeDoktypes
No doktypes are exclueded anymore in search.

- options.pageTree.disableIconLinkToContextmenu
Icon Links are always selected (option had no effect anymore).

- options.pageTree.searchInAlias
Alias is now always searched for.

- options.pageTree.hideFilter
The filter is always shown, this feature should not be available
on a per-user basis.

Resolves: #82919
Releases: master
Change-Id: Ie0031fef9948bf758e880b04662210d74e27688b
Reviewed-on: https://review.typo3.org/54560
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Eugene Kenah Djomo <kdeugene@yahoo.fr>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[TASK] Add parameter gclid to excludedParameters for cHash generation 62/54562/2
Georg Ringer [Mon, 6 Nov 2017 08:27:02 +0000 (09:27 +0100)]
[TASK] Add parameter gclid to excludedParameters for cHash generation

The parameter 'gclid' is used as click identifier for Google AdWords
and must not be used during the cHash generation.

Resolves: #82927
Releases: master, 8.7
Change-Id: Id279238738550cfbd0b86e6decf94a86230535ee
Reviewed-on: https://review.typo3.org/54562
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Fix PHP Notices in cached ext_localconf.php 57/54557/2
Tymoteusz Motylewski [Sat, 4 Nov 2017 20:05:16 +0000 (21:05 +0100)]
[BUGFIX] Fix PHP Notices in cached ext_localconf.php

Resolves: #82920
Releases: master, 8.7
Change-Id: I7a533f56ec68a119c19aad6c87de9dfc2e59dc6a
Reviewed-on: https://review.typo3.org/54557
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
23 months ago[BUGFIX] Replace forgotten back button to new button API 22/53722/2
Wouter Wolters [Thu, 17 Aug 2017 12:36:55 +0000 (14:36 +0200)]
[BUGFIX] Replace forgotten back button to new button API

With #69884 the new button API was introduced but the back button
in DatabaseRecordList was forgotten. The button is now done with
the new API.

Resolves: #82056
Releases: master
Change-Id: Icc6480af3a1b4a04e7222dc92cdb58bf9549007d
Reviewed-on: https://review.typo3.org/53722
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[!!!][TASK] Remove TS option page.stylesheet 49/54549/2
Georg Ringer [Fri, 3 Nov 2017 18:49:01 +0000 (19:49 +0100)]
[!!!][TASK] Remove TS option page.stylesheet

Remove the TypoScript option 'page.stylesheet' in favor of
using `page.includeCSS`.

Resolves: #82915
Releases: master
Change-Id: If8bb68a1520c23096ab0729caba681031c6a5401
Reviewed-on: https://review.typo3.org/54549
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[!!!][TASK] Remove the TS option page.bodyTagMargins 48/54548/2
Georg Ringer [Fri, 3 Nov 2017 17:39:37 +0000 (18:39 +0100)]
[!!!][TASK] Remove the TS option page.bodyTagMargins

The option 'page.bodyTagMargins' is rarly used and can be removed.
Any style information should be placed in a CSS file.

Resolves: #82914
Releases: master
Change-Id: Ib34ae835d0e50653b70f7ecf9573f42fbcca83a6
Reviewed-on: https://review.typo3.org/54548
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
23 months agoRevert "[BUGFIX] Set _localizedUid in OriginColumnName" 51/54551/4
Helmut Hummel [Sat, 4 Nov 2017 00:59:24 +0000 (02:59 +0200)]
Revert "[BUGFIX] Set _localizedUid in OriginColumnName"

This reverts commit 68e8530319faea18fbc61eee55fc00298582e8de.

The patch needs to be reverted due to wrong implementation.
The desired goal is not achievable at all with the current code base.

Reverts: #66535
Releases: master, 8.7
Change-Id: Ibd8eb7c4023d1b9f0e0de8b75d66193d66b89147
Reviewed-on: https://review.typo3.org/54551
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[FOLLOWUP][FEATURE] Add MetaTag API 54/54554/2
Mathias Schreiber [Sat, 4 Nov 2017 14:28:40 +0000 (15:28 +0100)]
[FOLLOWUP][FEATURE] Add MetaTag API

Bring back the meta generator which got lost in the original patch

Resolves: #81464
Releases: master
Change-Id: I5c68e35bdab953c8ff3df3afd85099439ed42787
Reviewed-on: https://review.typo3.org/54554
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Refactor implementation of PaginateWidget 76/53376/2
Claus Due [Sun, 2 Jul 2017 00:04:07 +0000 (02:04 +0200)]
[TASK] Refactor implementation of PaginateWidget

Refactors templates to minimise the impact of using the
uncompilable PaginateWidget. By moving the Widget to
a separate partial and the body rendered by the Widget
to another partial the impact is reduced to a minimum,
because the uncompilable template has just two nodes.

Change-Id: I6f1d528ed0c45d776c4952596ac5a8828d04f477
Resolves: #81766
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53376
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
23 months ago[FEATURE] Add Meta Tag API 10/53110/23
Mathias Schreiber [Sun, 4 Jun 2017 07:50:28 +0000 (09:50 +0200)]
[FEATURE] Add Meta Tag API

TYPO3 now allows to set, get and unset meta tags with an clear and
concise API. This API allows it to set any meta tag via an extension
while having the possibility to get the current content of a given meta
tag.
Unsetting meta tags allows to remove unwanted tags from 3rd party code.

Resolves: #81464
Resolves: #22992
Resolves: #52471

Releases: master
Change-Id: I31c2c29e29242ad9c2fadf2b625ae04288cc3bb5
Reviewed-on: https://review.typo3.org/53110
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
23 months ago[FEATURE] Add possibility to get a label in a specific language 67/53967/4
Markus Hoelzle [Thu, 7 Sep 2017 14:45:39 +0000 (16:45 +0200)]
[FEATURE] Add possibility to get a label in a specific language

Add possibility to get a label in a specific language in
LocalizationUtility::translate() and the TranslateViewHelper

Change-Id: I8589e2b155e57eed3124ed48b0d859fe7796ff3b
Resolves: #82354
Related: #81834
Releases: master
Reviewed-on: https://review.typo3.org/53967
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
23 months ago[!!!][FEATURE] Added deleted field for scheduler task 56/51656/7
Pascal Rinker [Mon, 13 Feb 2017 12:57:30 +0000 (13:57 +0100)]
[!!!][FEATURE] Added deleted field for scheduler task

Add a deleted flag to database table "tx_scheduler_task".
Any task execution will also consider this field.

Resolves: #79777
Releases: master
Change-Id: I9f96ae9b255042ebf4ba3c812726cbf5ba4fa41c
Reviewed-on: https://review.typo3.org/51656
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] Remove TypoScript option config.typolinkCheckRootline 45/54545/3
Benni Mack [Fri, 3 Nov 2017 14:52:51 +0000 (15:52 +0100)]
[TASK] Remove TypoScript option config.typolinkCheckRootline

The TypoScript option 'config.typolinkCheckRootline' was introduced
back in TYPO3 v4.x when there was no proper rootline cache or sys_domain
cache in place, in order to resolve the proper domain.

This now has changed, and this option can be removed in order to simplify
page link generation.

When in a multi-site setup, this option MUST be active otherwise it will
result in ugly and hard-to-debug side-effects.

For a single-site setup having this option disabled will result in a marginal
performance decrease (one SQL query more) when linking to a page with a
sys_domain record available.

A deprecation notice is thrown if your TypoScript setup still includes this option.

Resolves: #82909
Releases: master
Change-Id: I36abcdd1e2eabe2da66d8edd720a5a27ec306ede
Reviewed-on: https://review.typo3.org/54545
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] FormEngine: returnUrl handling in inline 43/54543/3
Christian Kuhn [Fri, 3 Nov 2017 11:42:09 +0000 (12:42 +0100)]
[BUGFIX] FormEngine: returnUrl handling in inline

If an inline child, opened via ajax request, generates links leaving
the current records and opening a different one, on closing that
record the returnUrl is wrong and points to the url of the inline
ajax request.
The original return url of the main record is lost in the compile chain.
The returnUrl data provider sets $data['returnUrl'] to current url if not
otherwise given.
The patch hands over the original return url to the inline ajax controller
and lets it 'sink down' in the data compile chain to inline children so
the original return url is available when container or elements generate urls.
Additionally some broken 'returnURL' handling in InlineRecordContainer
and jsfunc.inline.js is cleaned up and removed.

Change-Id: Ia47dc8cee068fc9c4d1c5e16c1960b1a58fcb2f5
Resolves: #82525
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54543
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Kjeld Schumacher <k.schumacher@familie-redlich.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Set JS .editorconfig indent style to 2 spaces 34/54534/3
Tymoteusz Motylewski [Thu, 2 Nov 2017 15:23:25 +0000 (16:23 +0100)]
[TASK] Set JS .editorconfig indent style to 2 spaces

Resolves: #82900
Releases: master
Change-Id: I9e80f662981dc107d5bcd1e4fc28bcf9d2ff3b4a
Reviewed-on: https://review.typo3.org/54534
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Remove unused ExtJS inclusion in System->Log 42/54542/2
Benni Mack [Fri, 3 Nov 2017 11:04:19 +0000 (12:04 +0100)]
[BUGFIX] Remove unused ExtJS inclusion in System->Log

Resolves: #82908
Releases: master
Change-Id: I96d661e294a737e36a084d4fa7423cc9257d1578
Reviewed-on: https://review.typo3.org/54542
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[TASK] Deprecate ClientUtility 38/54538/4
Georg Ringer [Thu, 2 Nov 2017 19:37:19 +0000 (20:37 +0100)]
[TASK] Deprecate ClientUtility

The class ClientUtility is outdated and not used anymore and can be
deprecated.

Resolves: #82903
Releases: master
Change-Id: I616b4518bfebac8239ecca0b48cad1b037c0ba6d
Reviewed-on: https://review.typo3.org/54538
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] Make SVG category tree use JS Icon API 68/54468/7
Tymoteusz Motylewski [Tue, 24 Oct 2017 11:27:08 +0000 (13:27 +0200)]
[TASK] Make SVG category tree use JS Icon API

This change make SVG tree expect icon identifier instead of icon source
in JSON node data.
Tree fetches icon source via JS Icon API only once per icon type.
This makes JSON response few times smaller.

Resolves: #82849
Releases: master
Change-Id: I8954837f68cee3bcc316bc56e30788e0d16c81d6
Reviewed-on: https://review.typo3.org/54468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Ensure cache tags are strings in workspaces 35/54535/2
Susanne Moog [Thu, 2 Nov 2017 15:24:33 +0000 (16:24 +0100)]
[BUGFIX] Ensure cache tags are strings in workspaces

On SQLServer you cannot insert integers in varchar
columns therefore the workspaces module ajax requests
are failing and you cannot use the module.

Cast the workspaceId to a string before using it as a
cache tag.

Change-Id: I0827dd6dddd9203fb7846934a034b826a515cdf3
Resolves: #82901
Releases: master
Reviewed-on: https://review.typo3.org/54535
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[!!!][TASK] Streamline ExtensionManagementUtility 23/54523/5
Benni Mack [Thu, 2 Nov 2017 05:54:47 +0000 (06:54 +0100)]
[!!!][TASK] Streamline ExtensionManagementUtility

The following functionality within this API class is marked as deprecated:
- siteRelPath()
- getExtensionKeyByPrefix()
- removeCacheFiles()
- second parameter of isLoaded()

Additionally, the following more strict rules apply now:
- addNavigationComponent() always requires an $extensionKey
- First parameter of addLLrefForTCAdescr() must not be empty
- addService() requires $serviceType and $info to be non-empty
- addPlugin() always requires an $extensionKey
- addStaticFile() throws exceptions if no extension key or path is set
- addTypoScript() expects $type to be either "setup" or "constants"

This is meant for extension developers using the current API more properly
than before.

Resolves: #82899
Releases: master
Change-Id: Ie5beddd4787da25f05f76ff37c6ec55a92257001
Reviewed-on: https://review.typo3.org/54523
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Add checks to ReflectionService to have correct return values 10/54510/6
Markus Klein [Tue, 31 Oct 2017 06:51:35 +0000 (07:51 +0100)]
[BUGFIX] Add checks to ReflectionService to have correct return values

Resolves: #82885
Releases: master, 8.7
Change-Id: I422f920187186fe83b6043f806fc1be9a16c8a25
Reviewed-on: https://review.typo3.org/54510
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[!!!][TASK] Migrate EXT:version into EXT:workspaces 14/54514/8
Benni Mack [Tue, 31 Oct 2017 20:24:43 +0000 (21:24 +0100)]
[!!!][TASK] Migrate EXT:version into EXT:workspaces

The concept of versioning records based on how it is
integrated into TYPO3 only makes sense in conjunction
with workspaces / stages. All other methods are not
supported. Thus, the logic of versioning of records
is moved into EXT:workspaces, making EXT:version
obsolete.

Checks against EXT:version is now handled against
"workspaces" throughout the core, with a fallback
within ExtensionManagementUtility::isLoaded().

Resolves: #82896
Releases: master
Change-Id: I8887b868892c8aa6c36db7d2841f6edf5476d6f7
Reviewed-on: https://review.typo3.org/54514
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[CLEANUP] Minor argument and comment cleanup 24/54524/2
Benni Mack [Thu, 2 Nov 2017 06:16:55 +0000 (07:16 +0100)]
[CLEANUP] Minor argument and comment cleanup

Some methods are called with default arguments, which can be omitted
when calling the methods.

Additionally, some PHPdoc comments was wrongly defined, which were
modified.

No change of behaviour.

Resolves: #82897
Releases: master
Change-Id: I1a22e7e3c4aff74f32c67bacb406a6a97d96b0d0
Reviewed-on: https://review.typo3.org/54524
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Handle returnUrl for access module 04/54504/2
Markus Klein [Mon, 30 Oct 2017 19:56:30 +0000 (20:56 +0100)]
[BUGFIX] Handle returnUrl for access module

With this fix the access module again returns to the correct
page the user expects it to return to.

Resolves: #82883
Releases: master, 8.7, 7.6
Change-Id: I76953aa1547365db6fbbea772d786e1ad9bfc184
Reviewed-on: https://review.typo3.org/54504
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Access module preselects owner/group when changed via AJAX 07/54507/2
Markus Klein [Mon, 30 Oct 2017 20:42:05 +0000 (21:42 +0100)]
[BUGFIX] Access module preselects owner/group when changed via AJAX

Resolves: #79915
Releases: master, 8.7, 7.6
Change-Id: Ie3b573857ff011295be198633a0f6868b1ff55b6
Reviewed-on: https://review.typo3.org/54507
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[!!!][TASK] Remove global variable PARSETIME_START 17/54517/3
Benni Mack [Wed, 1 Nov 2017 11:34:37 +0000 (12:34 +0100)]
[!!!][TASK] Remove global variable PARSETIME_START

The global variable $GLOBALS['PARSETIME_START'] is removed,
as it has been superseded by $GLOBALS['TYPO3_MISC']['microtime_start']
for a long time already.

Resolves: #82893
Releases: master
Change-Id: Ic738ebb1ae4dd19aff426fcd32b8f7a3594ca2e4
Reviewed-on: https://review.typo3.org/54517
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] Show allowed media sources in "Add media by URL" modal 37/54437/10
Gianluigi Martino [Wed, 18 Oct 2017 15:16:52 +0000 (17:16 +0200)]
[TASK] Show allowed media sources in "Add media by URL" modal

In the modal view of "Add media by URL" the possible sources from where
media can be embedded are now shown.

Resolves: #82545
Releases: master, 8.7
Change-Id: I07ffedcf074b6af1e03113375f3d110916e3b034
Reviewed-on: https://review.typo3.org/54437
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
23 months ago[TASK] Unify spelling of "YAML" throughout the core 16/54516/3
Riccardo De Contardi [Wed, 1 Nov 2017 10:54:46 +0000 (11:54 +0100)]
[TASK] Unify spelling of "YAML" throughout the core

The correct spelling of the abbreviation is "YAML".
Standardized throughout the comments.

Resolves: #82459
Releases: master
Change-Id: I60847674b5dd8fc6222ae18c226f8ab584e3be84
Reviewed-on: https://review.typo3.org/54516
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
23 months ago[BUGFIX] Set _localizedUid in OriginColumnName 76/54376/5
Alexander Opitz [Tue, 7 Jul 2015 12:28:10 +0000 (14:28 +0200)]
[BUGFIX] Set _localizedUid in OriginColumnName

While saving an object the _localizedUid will be saved into the DB
column which is defined in TranslationOriginalColumnName.

Resolves: #66535
Releases: master,8.7
Change-Id: Ib23b97f90e805bd1107a3aac5b199f010ab231b3
Reviewed-on: https://review.typo3.org/54376
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Remove obsolete IE6 condition in debug exception handler 15/54515/3
Benni Mack [Tue, 31 Oct 2017 20:40:55 +0000 (21:40 +0100)]
[TASK] Remove obsolete IE6 condition in debug exception handler

Some very lonesome IE6 check can be removed for
debugging purposes now, since IE6 support has been dropped
for a long time, and for debugging purposes especially this
use-case does not exist anymore.

Resolves: #82891
Releases: master
Change-Id: I166d5becea3b1c6a53e1a1e50dcb1731332229e6
Reviewed-on: https://review.typo3.org/54515
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[FOLLOWUP][BUGFIX] Ensure absolute paths for &eID=dumpFile 89/53789/5
Helmut Hummel [Wed, 23 Aug 2017 11:01:36 +0000 (13:01 +0200)]
[FOLLOWUP][BUGFIX] Ensure absolute paths for &eID=dumpFile

This follow-up patch ensures the link is properly generated when
generating it from a Backend context, e.g., when embedding an image
within CKEditor and when TYPO3 is within a subdirectory.

Change-Id: I9783344c70c8cdfd6660a69dff72b251b2964c16
Resolves: #81486
Releases: master
Reviewed-on: https://review.typo3.org/53789
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
23 months ago[BUGFIX] Move doctrine initalization to connect() method 32/54432/4
Alexander Stehlik [Wed, 18 Oct 2017 02:40:16 +0000 (04:40 +0200)]
[BUGFIX] Move doctrine initalization to connect() method

The event and custom type initalization of doctrine is moved
to an overwritten connect() method in the Connection class.

This prevents a premature establishment of a database connection
by calls to getDatabasePlatform().

This fixes the page unavailable during the connectToDB() in
the Frontend request handling.

Change-Id: Id6087002c7cbb9ed3938c4627d63b77515a7108f
Releases: master, 8.7
Resolves: #82795
Reviewed-on: https://review.typo3.org/54432
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
23 months ago[FOLLOWUP][!!!][TASK] Replace ClassInfo with ClassSchema 82/54482/2
Alexander Schnitzler [Fri, 27 Oct 2017 10:23:36 +0000 (12:23 +0200)]
[FOLLOWUP][!!!][TASK] Replace ClassInfo with ClassSchema

Increase test coverage of ClassSchema and ReflectionService

Releases: master
Resolves: #57594
Resolves: #55654
Change-Id: If413dc0b428f94dffef13e1875e3a7af4f9939b7
Reviewed-on: https://review.typo3.org/54482
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[BUGFIX] EXT:form - really disable records overview in redirect finisher 35/54435/2
Mathias Brodala [Wed, 18 Oct 2017 07:38:42 +0000 (09:38 +0200)]
[BUGFIX] EXT:form - really disable records overview in redirect finisher

Resolves: #82786
Releases: master, 8.7
Change-Id: I9cdfbcd5e0f25b832ea546f1b8c70a9f544b31aa
Reviewed-on: https://review.typo3.org/54435
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Catch UnknownLinkHandlerException in InputLinkElement 69/54469/4
Georg Ringer [Tue, 24 Oct 2017 14:37:27 +0000 (16:37 +0200)]
[BUGFIX] Catch UnknownLinkHandlerException in InputLinkElement

Catch another exception to avoid a breaking backend.

Resolves: #82850
Releases: master, 8.7
Change-Id: I349aae21932beb5d45c1cec1b1211d3400d1d969
Reviewed-on: https://review.typo3.org/54469
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Fix foreign_table_where GROUP BY handling 73/54473/5
Wolfgang Klinger [Wed, 25 Oct 2017 10:39:31 +0000 (12:39 +0200)]
[BUGFIX] Fix foreign_table_where GROUP BY handling

Unpack the array elements before passing them on

Resolves: #82159
Releases: master, 8.7
Change-Id: I6a094927f595d42fc15bb96a9dbc1d313a7808b0
Reviewed-on: https://review.typo3.org/54473
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Show default site name in installation wizard 90/54490/2
Nicole Cordes [Sat, 28 Oct 2017 10:44:33 +0000 (12:44 +0200)]
[BUGFIX] Show default site name in installation wizard

Currently in step 4 the input box for the site name is empty. This patch
re-adds the default site name from FactoryConfiguration.php as initial
value.

Resolves: #82876
Releases: master
Change-Id: I391254cf7ae6e5f8aa45003035aebaf513e733d3
Reviewed-on: https://review.typo3.org/54490
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[!!!][BUGFIX] Throw exception on invalid charset 71/54471/3
Mathias Brodala [Wed, 25 Oct 2017 07:45:08 +0000 (09:45 +0200)]
[!!!][BUGFIX] Throw exception on invalid charset

This gives users a clear hint if e.g. config.metaCharset contains
an invalid value instead of showing a blank page.

Change-Id: I9cdb37cc7e61af10e2d1985ef43f488e53b17a48
Resolves: #82852
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54471
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[BUGFIX] Ensure correct page is selected in page tree 91/54491/3
Helmut Hummel [Sat, 28 Oct 2017 10:35:24 +0000 (12:35 +0200)]
[BUGFIX] Ensure correct page is selected in page tree

There are several actions in the backend that should
trigger a certain page to be selected in the tree.

Among others these are: open documents toolbar, live search,
favorites.

Fix every scenario in which these actions are triggered
(e.g. page tree was already initialized or not), make
sure the desired page will always be selected and
properly store the selection in the various states
so that the selection persists tree refreshes.

In addition we ensure that the content frame will
be called with the correct id, if the module uses
the page tree as navigation component.

Releases: master, 8.7
Resolves: #82877
Change-Id: I1904c02b2246f01202c6607a9b718aebe0e33341
Reviewed-on: https://review.typo3.org/54491
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
23 months ago[BUGFIX] Fix usages of config.additionalHeaders 85/54485/4
Markus Klein [Fri, 27 Oct 2017 13:49:00 +0000 (15:49 +0200)]
[BUGFIX] Fix usages of config.additionalHeaders

Update some internal usages of config.additionalHeaders in tests
and other places to use the correct new syntax.

Resolves: #82871
Releases: master, 8.7
Change-Id: I44868a736751647c3aa62bd5dc29f0bce5588c10
Reviewed-on: https://review.typo3.org/54485
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] Add .tsconfig files to .editorconfig 93/54493/3
Peter Kraume [Sun, 29 Oct 2017 12:06:28 +0000 (13:06 +0100)]
[TASK] Add .tsconfig files to .editorconfig

Add definition for new TSConfig filetype .tsconfig to .editorconfig
file.

Change-Id: I3fd87abc8a8fe554692f61e548e37d4d02f74fa4
Resolves: #82879
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54493
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Flexform Form ID should not contain brackets 71/52771/7
Benjamin Serfhos [Thu, 11 May 2017 12:30:15 +0000 (14:30 +0200)]
[BUGFIX] Flexform Form ID should not contain brackets

Using brackets in flexform elements caused the javascript to be disabled
for the element.
While using a custom form id that can be used as HTML id="" this is
bypassed and fixes all javascript interaction.

Releases: master, 8.7
Resolves: #80908
Change-Id: I91f39b2fed61076b7139603fedc7b268546d64cd
Reviewed-on: https://review.typo3.org/52771
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
23 months ago[!!!][TASK] Remove DB field pages.no_cache 89/54489/4
Benni Mack [Fri, 27 Oct 2017 19:22:21 +0000 (21:22 +0200)]
[!!!][TASK] Remove DB field pages.no_cache

Having an option to completely disable the page rendering
cache available per page for editors is a real risk. This
option is largely hard to understand for an editor,
or an admin.

Integrators can still use `config.no_cache = 1` in
TypoScript on a condition basis to achieve the same
result.

Resolves: #82878
Releases: master
Change-Id: Ie6989acc0044a75e711253e4304f9b2b9d96a7e1
Reviewed-on: https://review.typo3.org/54489
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Only fetch fileReferences from localized table if column exist 79/54479/5
Benjamin Kott [Thu, 26 Oct 2017 15:54:56 +0000 (17:54 +0200)]
[BUGFIX] Only fetch fileReferences from localized table if column exist

Only if a localized table also contains the requested column for file
references it will overlay the previous generated resultset.

Resolves: #82860, #67741
Releases: master, 8.7
Change-Id: I21fd60454123488ea312d6c6241f2622eab3f14c
Reviewed-on: https://review.typo3.org/54479
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[BUGFIX] Do not turn E_USER_DEPRECATED errors into exceptions 67/54467/2
Markus Klein [Mon, 23 Oct 2017 16:12:35 +0000 (18:12 +0200)]
[BUGFIX] Do not turn E_USER_DEPRECATED errors into exceptions

Also use the silent upgrade wizard to correct existing settings.

Resolves: #82721
Releases: master
Change-Id: I8d163799cf0d1acfaaa9c2589a70b932144b6dc6
Reviewed-on: https://review.typo3.org/54467
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Avoid race condition in JS Icon API 70/54470/3
Tymoteusz Motylewski [Tue, 24 Oct 2017 19:46:44 +0000 (21:46 +0200)]
[BUGFIX] Avoid race condition in JS Icon API

Now promise is cached instead of promise result, to avoid race condition
when requesting the same icon multiple times.
Now API will do just one ajax call per icon, even if the other API call
is made before the first one finishes.

Resolves: #82851
Releases: master, 8.7
Change-Id: I4110f84d32c7f1856c1664a02d3c9a2ba59168a6
Reviewed-on: https://review.typo3.org/54470
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Allow multiline strings in foreign_table_where 74/54474/3
Wolfgang Klinger [Wed, 25 Oct 2017 11:48:15 +0000 (13:48 +0200)]
[BUGFIX] Allow multiline strings in foreign_table_where

Add the ’s’ (PCRE_DOTALL) modifier to regular expressions.

Resolves: #82854
Releases: master, 8.7
Change-Id: Ib5feaba0272e45dce1bc0b4cfedb11f5eb0b10c2
Reviewed-on: https://review.typo3.org/54474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[FOLLOWUP][BUGFIX] Allow longer file-endings in typoscript directory includes 60/54460/2
Benni Mack [Fri, 20 Oct 2017 14:10:52 +0000 (16:10 +0200)]
[FOLLOWUP][BUGFIX] Allow longer file-endings in typoscript directory includes

Adds missing unit tests for this change.

Resolves: #82543
Releases: master, 8.7
Change-Id: Ica7f5c2f99dd991042e3c1166f7806534bf24421
Reviewed-on: https://review.typo3.org/54460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Do not force content_fallback to default page language 26/54426/7
Benni Mack [Tue, 17 Oct 2017 22:06:21 +0000 (00:06 +0200)]
[BUGFIX] Do not force content_fallback to default page language

If a page translation is not available, the TypoScript option
`config.sys_language_mode` has the option
`content_fallback;listofuids` to define to which other language
translations should be fallen back.

However, if NONE of the defined page translations are available,
a fallback to the DEFAULT language is made (because the
foreach just does not apply) which can not be stopped at all.

To define an explicit 404 when a translated page NOR its
fallbacks are available the special keyword "pageNotFound" is added,
which can be added to
`config.sys_language_mode = content_fallback;3,2,pageNotFound`
and if none of 3,2 are available, a page not found message
is thrown.

Resolves: #82794
Releases: master, 8.7
Change-Id: I90af4e9f9685ffc7db8c562207e3df08786c0ca9
Reviewed-on: https://review.typo3.org/54426
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] MenuProcessor doesn't accept necessary sub keys 44/54444/2
Thorben Nissen [Thu, 19 Oct 2017 08:28:43 +0000 (10:28 +0200)]
[BUGFIX] MenuProcessor doesn't accept necessary sub keys

Adds subproperty keys for levels, expandAll, includeSpacer and
titleField to $allowedConfigurationKeys.
Adds the subproperty keys also $removeConfigurationKeysForHmenu.

Resolves: #82810
Releases: master, 8.7
Change-Id: Idd2e50b0b7a203ce0a0ecc490199bdf5305bef47
Reviewed-on: https://review.typo3.org/54444
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[FEATURE] Introduce new @import syntax for TS includes 46/54446/6
Benni Mack [Thu, 19 Oct 2017 14:27:16 +0000 (16:27 +0200)]
[FEATURE] Introduce new @import syntax for TS includes

The original '<INCLUDE_TYPOSCRIPT...>' syntax is hard to understand,
error-prone and overloaded with features.

This patch introduces a new way to include files based on SymfonyFinder
and simple logic to allow to include files or folders:

The following syntax (leaned towards SASS imports) is added:
Imports one file:

- @import 'EXT:myext/Configuration/TypoScript/myfile.typoscript'

Imports all files in a folder (always sorted by name):
- @import 'EXT:myext/Configuration/TypoScript/*'
- @import 'EXT:myext/Configuration/TypoScript/'

Imports all files ending with ".typoscript":
- @import 'EXT:myext/Configuration/TypoScript/*.typoscript'

Automatically adds '.typoscript' file ending and includes setup.typoscript
- @import 'EXT:myext/Configuration/TypoScript/setup'

This is all done with Symfony Finder to find the files.

Resolves: #82812
Releases: master
Change-Id: I4b64a087ef8c6aa85063c19c1882c9ed3448d9b5
Reviewed-on: https://review.typo3.org/54446
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>