Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Catch exceptions in LinkBrowser 23/51923/3
Georg Ringer [Wed, 1 Mar 2017 22:57:32 +0000 (23:57 +0100)]
[BUGFIX] Catch exceptions in LinkBrowser

If a folder or file is linked which does not exist, the UI must not
break.

Resolves: #80087
Releases: master
Change-Id: I9027234065c33f68db6af24f1dae9735d46d2584
Reviewed-on: https://review.typo3.org/51923
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Incorrect usages of string as array in QueryGenerator 15/51915/8
Christer Vindberg [Wed, 1 Mar 2017 11:46:47 +0000 (12:46 +0100)]
[BUGFIX] Incorrect usages of string as array in QueryGenerator

Changed so an empty $queryConfig is always an array.

$queryConfig is declared as an array but can be used as an array or
string, therefore in PHP 7.1 an exception was thrown.

Resolves: #80075
Releases: master, 7.6
Change-Id: Ifd8b89e0ccce4f93a6c7bee5afe10bf52fa73634
Reviewed-on: https://review.typo3.org/51915
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Use LanguageService::$moduleLabels as fallback in ModuleLoader 32/51932/2
Nicole Cordes [Thu, 2 Mar 2017 23:18:17 +0000 (00:18 +0100)]
[TASK] Use LanguageService::$moduleLabels as fallback in ModuleLoader

As the property moduleLabels of the LanguageService was deprecated with
8, it should be used as fallback for module labels unless it is removed
completely. This raises compatibility possibilities for extensions as
otherwise an empty module is shown in the module list.

Resolves: #80107
Releases: master
Change-Id: I5fc306b2bd2c2ba221ad877cec3914f07d2ff584
Reviewed-on: https://review.typo3.org/51932
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Felogin: Only wrap header/message if not empty 34/51934/3
Benni Mack [Fri, 3 Mar 2017 10:21:16 +0000 (11:21 +0100)]
[BUGFIX] Felogin: Only wrap header/message if not empty

When adding felogin template the wraps defined by default
of EXT:felogin are always outputted even though it just adds
an empty div/h3 tag around, which looks odd in most installations.

The patch adds a proper required tag to see if the value is actually not
empty.

Resolves: #80110
Releases: master, 7.6
Change-Id: Ia9e4c7d3dc294b30db3f10cdde96f95899aa18ef
Reviewed-on: https://review.typo3.org/51934
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] SchemaMigrator: Don't add indexes on changed columns 28/51928/8
Morton Jonuschat [Fri, 3 Mar 2017 03:15:10 +0000 (19:15 -0800)]
[BUGFIX] SchemaMigrator: Don't add indexes on changed columns

Adding or changing an index on MySQL could sometimes fail due
to a dependency between the index definition and the column types.
On MySQL indexes on TEXT/BLOB types might require defining a
prefix length so that the index does not exceed storage limits.

Implement a check when migrating the database in a mode that
only adds fields and indexes such that added indexes do not touch
columns that require changes.

Also update the detection of required database changes in the
upgrade wizard so it does not get stuck on database changes
which will not be performed in that phase.

Resolves: #80096
Resolves: #80043
Releases: master
Change-Id: I4fa403e8429f9f59a6316d0f425d36673a690e31
Reviewed-on: https://review.typo3.org/51928
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[FOLLOWUP][BUGFIX] Add query restrictions for all tables in query 12/51912/4
Tymoteusz Motylewski [Wed, 1 Mar 2017 14:17:03 +0000 (15:17 +0100)]
[FOLLOWUP][BUGFIX] Add query restrictions for all tables in query

This patch ensures a correct table name is used within the restrictions
to be able to find TCA information.

Resolves: #79615
Releases: master
Change-Id: I1e96531602bfb5debeb0a1202ed91eb90cc31032
Reviewed-on: https://review.typo3.org/51912
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Default saltedPWHashingMethod Pbkdf2 35/51935/3
Christian Futterlieb [Fri, 3 Mar 2017 11:59:22 +0000 (12:59 +0100)]
[TASK] Default saltedPWHashingMethod Pbkdf2

Change default saltedPWHashingMethod to Pbkdf2 in order to use the
most secure salting method that is available by default.

Change-Id: I4cd06731fe5aee177f4809fd604c8f770232062f
Releases: master
Resolves: #80112
Reviewed-on: https://review.typo3.org/51935
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Futterlieb <christian@futterlieb.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Improve migration steps of BE viewhelper attributes deprecation 27/51927/5
Tymoteusz Motylewski [Thu, 2 Mar 2017 11:59:06 +0000 (12:59 +0100)]
[TASK] Improve migration steps of BE viewhelper attributes deprecation

Resolves: #80097
Releases: master
Change-Id: Ia0d4448bfa257bb3f77f12baaa210bc1af1b6b57
Reviewed-on: https://review.typo3.org/51927
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[CLEANUP] Streamline Avatar-related code in EXT:backend 08/51908/4
Benni Mack [Tue, 28 Feb 2017 19:54:22 +0000 (20:54 +0100)]
[CLEANUP] Streamline Avatar-related code in EXT:backend

- Add proper comments to all PHP code, remove all unnecessary
comments (e.g. "get height" for getHeight() method).
- Move Icon functionality to ViewHelpers instead of doing everything
in PHP.

Resolves: #80066
Releases: master
Change-Id: I5c814824f57112e9603f5994e051f7eb6dd85e45
Reviewed-on: https://review.typo3.org/51908
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Ensure pageTS is overriding on top-level RTE syntax 17/51917/4
Benni Mack [Wed, 1 Mar 2017 11:51:10 +0000 (12:51 +0100)]
[BUGFIX] Ensure pageTS is overriding on top-level RTE syntax

If using RTE.classesAnchor before, the new Richtext class
did not merge the values together. This is now solved by
doing proper overlays.

Resolves: #80078
Releases: master
Change-Id: Ia76696065a22207ed40974cc0da8b2842120c45d
Reviewed-on: https://review.typo3.org/51917
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Deprecate \TYPO3\CMS\Core\Core\Bootstrap::loadExtensionTables 18/51918/3
Nicole Cordes [Wed, 1 Mar 2017 12:17:37 +0000 (13:17 +0100)]
[TASK] Deprecate \TYPO3\CMS\Core\Core\Bootstrap::loadExtensionTables

With the patch https://review.typo3.org/51892 we have introduced single
functions to handle loading of information correctly. We can now remove
the wrapper function and call the new ones instead.

Resolves: #80079
Releases: master
Change-Id: I0d61f0d5760ae3c61fa96dc16329365d5f4182a5
Reviewed-on: https://review.typo3.org/51918
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[!!!][TASK] Always include pageId in cHash calculation 83/51883/5
Benni Mack [Tue, 28 Feb 2017 06:17:43 +0000 (07:17 +0100)]
[!!!][TASK] Always include pageId in cHash calculation

The option $TYPO3_CONF_VARS[FE][cHashIncludePageId]
was included as part of a security fix to stay backwards-compatible
with existing installations.

The option was only there as a intermediate step, however
the cHash calculation should always contain the pageID,
so the option is removed and should be enabled by default.

The change removes the option via a silent configuration
updater in the Install Tool, removes the status report and
changes the cHash calculation to always include a pageId,
and if the page ID is not given, an exception is now
thrown all the time.

Resolves: #80050
Releases: master
Change-Id: Iac8eef1273848309da62deb24160f1c14ef338f4
Reviewed-on: https://review.typo3.org/51883
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate page.insertClassesFromRTE 14/51914/4
Benni Mack [Wed, 1 Mar 2017 11:30:18 +0000 (12:30 +0100)]
[TASK] Deprecate page.insertClassesFromRTE

The TypoScript option which fetches TSconfig to
load RTE specific classes and writes inline CSS
has been marked as deprecated, as the cross-dependency
for RTE/pageTSconfig/TypoScript is superseeded by
modern techniques of having a separate frontend from
the backend styling - using contents.css for that
case, and LESS/SASS/preprocessing for frontend
rendering.

Resolves: #80076
Releases: master
Change-Id: I865174823a358252bd3bb47ab4af274d19795472
Reviewed-on: https://review.typo3.org/51914
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Enable rte_ckeditor instead of rtehtmlarea for new installations 16/51916/3
Christian Kuhn [Wed, 1 Mar 2017 11:47:46 +0000 (12:47 +0100)]
[TASK] Enable rte_ckeditor instead of rtehtmlarea for new installations

To embrace rte_ckeditor instead of rtehtmlarea, ckeditor extension is
now marked as "partOfFactoryDefault" instead of htmlarea, affecting
new instances.
Additionally mark rte_ckeditor as stable and rtehtmlarea as obsolete.

Change-Id: I5da1dcd5e069b32d266003f9c3ce5d86b227d947
Resolves: #80077
Releases: master
Reviewed-on: https://review.typo3.org/51916
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
2 years ago[TASK] Remove unnecessary RTE default configuration 13/51913/3
Benni Mack [Wed, 1 Mar 2017 10:52:12 +0000 (11:52 +0100)]
[TASK] Remove unnecessary RTE default configuration

As the default preset is now always fetched,
the base RTE configuration in FormEngine can be
reduced again, and everything is fetched from the
Yaml/pageTS configuration.

Resolves: #80074
Releases: master
Change-Id: I21b1d4ded26e1b563d60c97b11e1de4eaa65fb19
Reviewed-on: https://review.typo3.org/51913
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Add language debug mode to All Configuration 56/51856/4
Thomas Hohn [Sat, 25 Feb 2017 14:30:45 +0000 (15:30 +0100)]
[TASK] Add language debug mode to All Configuration

Renamed $TYPO3_CONF_VARS['BE']['lang']['debug'] to
$TYPO3_CONF_VARS['BE']['languageDebug'] in order to
be able to set value in install-tool.

Resolves: #71095
Releases: master
Change-Id: I49cf8516db5d535a8fe2cac6330ce2ebc3aba783
Reviewed-on: https://review.typo3.org/51856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Better fallback configuration for CKEDITOR 20/51820/8
Anders Kostending [Fri, 24 Feb 2017 09:04:35 +0000 (10:04 +0100)]
[BUGFIX] Better fallback configuration for CKEDITOR

If in TCA ['config']['richtextConfiguration'] is not set,
fall back to 'default' configuration.

Resolves: #79756
Releases: master
Change-Id: I83d90a8bb52cec84257809674b46fdf69f6fb815
Reviewed-on: https://review.typo3.org/51820
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not convert special characters to entities in CKEDITOR 10/51910/3
Anders Kostending [Wed, 1 Mar 2017 08:24:22 +0000 (09:24 +0100)]
[BUGFIX] Do not convert special characters to entities in CKEDITOR

Using these configurations æ, ø and å will be
stored the same ways as with RTE HTMLArea.

Resolves: #80032
Releases: master
Related: #79756
Change-Id: Iddf85b3bcde0587361cfc5d2bd09917da04fcb5e
Reviewed-on: https://review.typo3.org/51910
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make LocalizationRepository handle copied records 06/51406/7
Tymoteusz Motylewski [Tue, 28 Feb 2017 21:25:52 +0000 (22:25 +0100)]
[BUGFIX] Make LocalizationRepository handle copied records

Improve LocalizationRepository queries to handle case
when records were copied from another page (thus t3_origuid)
is pointing to records from the other page.

Now LocalizationRepository uses l10n_source field instead of t3_origuid.
Tests for LocalizationRepository covering the case were added.

Resolves: #79443
Resolves: #78599

Releases: master, 7.6
Change-Id: Ibae4a276ea814f0ce3d453cffef1d22afeff1eb9
Reviewed-on: https://review.typo3.org/51406
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Mächler <admin@bithost.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Add query restrictions for all tables in query 02/51902/5
Tymoteusz Motylewski [Tue, 28 Feb 2017 15:51:01 +0000 (16:51 +0100)]
[BUGFIX] Add query restrictions for all tables in query

QueryBuilder::getQueriedTables now returns an array with table
alias as a key and table name as value.
If a table doesn't have an alias, both key and value are containing
table name.

This change is needed to make query restriction classes add restrictions
for all tables in case the self inner join is made.
A test covering the case was added to QueryBuilderTest.

Releases: master
Resolves: #79615
Change-Id: Ibf797189334ed86db0fce1a4ef3f0898cb0ada11
Reviewed-on: https://review.typo3.org/51902
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Patrick Broens <patrick@patrickbroens.nl>
Tested-by: Patrick Broens <patrick@patrickbroens.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Streamline cookie options / remove cookieHttpOnly 08/50808/18
Benni Mack [Wed, 1 Feb 2017 05:51:17 +0000 (06:51 +0100)]
[BUGFIX] Streamline cookie options / remove cookieHttpOnly

The TYPO3_CONF_VARS[SYS][cookieHttpOnly] option is removed
as all cookies set by the TYPO3 Core are HttpOnly by default
in order to avoid client side script access.

This option was previously turned on by default but configurable
as old browser did not support this option all the time (see
https://www.owasp.org/index.php/HttpOnly#Browsers_Supporting_HttpOnly
for more details).

The be_lastLoginProvider and workspaces cookies now
set the httpOnly flag properly as well.

Resolves: #78835
Releases: master
Change-Id: I12538508a6f97888d7ad0b2f5f028bcde2844d6d
Reviewed-on: https://review.typo3.org/50808
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Add ext:frontend as dependency for CSC/FSC 06/51906/2
Josef Glatz [Tue, 28 Feb 2017 18:13:00 +0000 (19:13 +0100)]
[TASK] Add ext:frontend as dependency for CSC/FSC

EXT:css_styled_content and EXT:fluid_styled_content
must depend on EXT:frontend.

Resolves: #80064
Releases: master
Change-Id: I116209ac78c7cabe6bc0a90512b4526564556d2e
Reviewed-on: https://review.typo3.org/51906
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Deprecate jQuery and extJS arguments for BE viewhelpers 94/51794/6
Benni Mack [Wed, 22 Feb 2017 09:24:21 +0000 (10:24 +0100)]
[TASK] Deprecate jQuery and extJS arguments for BE viewhelpers

The BE-related viewhelpers <f:be.container> and <f:be.pageRenderer>
have properties to activate ExtJS and jQuery with various options.

1. ExtJS will be removed in TYPO3 v9, and using ExtJS in custom
backend modules is deprecated.

2. jQuery is now always loaded with DocumentTemplate and
ModuleTemplate, so the option does not work at all. All occurrences
use RequireJS modules which resolve their dependencies to
jQuery within the JS module.

All places in the TYPO3 Core where these options have been
used are removed.

Resolves: #80047
Releases: master
Change-Id: Ie89cb59e8ed7d9bc6cb27a6593a0aaa293fb3538
Reviewed-on: https://review.typo3.org/51794
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Correctly parse displayCond FIELD value with colons 36/51836/3
Claus Due [Fri, 24 Feb 2017 16:59:09 +0000 (17:59 +0100)]
[BUGFIX] Correctly parse displayCond FIELD value with colons

This patch prevents exploding match texts which contain
colons before matching the value against the field value.

Change-Id: Iebaf8f4cc440b1d5a07467b6947d7880d0dc9f81
Resolves: #79981
Releases: master
Reviewed-on: https://review.typo3.org/51836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] FluidStyledContent: use correct partial for audio filetype 05/51905/2
Josef Glatz [Tue, 28 Feb 2017 17:39:24 +0000 (18:39 +0100)]
[BUGFIX] FluidStyledContent: use correct partial for audio filetype

Resolves: #80063
Related: #79622
Releases: master
Change-Id: I13b785b0c1bdd89b2d6a1a89db118ae9d5484065
Reviewed-on: https://review.typo3.org/51905
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Implement connection timeout option for Redis backend 99/51799/4
Arno Schoon [Thu, 23 Feb 2017 09:37:54 +0000 (10:37 +0100)]
[BUGFIX] Implement connection timeout option for Redis backend

Allow an option for connectionTimeout to be set for the Redis cache backend

Resolves: #79966
Releases: master
Change-Id: I9a4d1abb07f4e199a8c1a53a6fc3de6ddf613140
Reviewed-on: https://review.typo3.org/51799
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Richard Haeser <richardhaeser@gmail.com>
Tested-by: Richard Haeser <richardhaeser@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Always use system getFrom() when sending emails 85/51885/3
Benni Mack [Tue, 28 Feb 2017 06:40:09 +0000 (07:40 +0100)]
[BUGFIX] Always use system getFrom() when sending emails

When instantiating MailMessage() and no valid sender is
given, a fallback is used in different places of TYPO3. To ensure
that all mails sent out (e.g. when instantiated via extensions)
have a proper From() header, the default fallback is set
just before sending the emails.

Resolves: #80055
Releases: master
Change-Id: I6b740b2dcf5a84437fac2e9bf60aac3321e91377
Reviewed-on: https://review.typo3.org/51885
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Set file size to 0 instead to string in ImportExport 76/51876/3
Georg Ringer [Mon, 27 Feb 2017 19:28:55 +0000 (20:28 +0100)]
[BUGFIX] Set file size to 0 instead to string in ImportExport

To avoid errors with PHP 7.1 which is more strict regarding
strings and integers, the file size for soft refs must be
set to 0 instead of an empty string.

Resolves: #79644
Releases: master, 7.6
Change-Id: I246e5ac1599da50b97dac3bdb4fcc959af813ce9
Reviewed-on: https://review.typo3.org/51876
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add helper method to deprecate ViewHelper attributes 07/51707/9
Frank Naegler [Wed, 15 Feb 2017 17:38:56 +0000 (18:38 +0100)]
[TASK] Add helper method to deprecate ViewHelper attributes

This patch introduce a new helper method for deprecations in ViewHelper
classes. The new method can detect the template path and log the path.

Resolve: #79840
Releases: master
Change-Id: Id3f9392e115db846fbfab8daa8158931a5e51d16
Reviewed-on: https://review.typo3.org/51707
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[SECURITY] Prevent possible XSS in Fluid templates 93/51893/2
Nicole Cordes [Tue, 28 Feb 2017 10:23:37 +0000 (11:23 +0100)]
[SECURITY] Prevent possible XSS in Fluid templates

This patch ensures proper encoding of the output of if-ViewHelpers when
using in inline notation.

The regular expression to find possibly affected usages is:
\{\s*f:if\s*\(.+,\s*(?:then|else):(?>\s*)[^']

Resolves: #79911
Releases: master, 7.6
Security-Commit: 25113a810a8b9203f61ef694e0ef0a42dc349a72
Security-Bulletin: TYPO3-CORE-SA-2017-003
Change-Id: I09fea4c7d9dc845d1be23a34627dcc277da089f9
Reviewed-on: https://review.typo3.org/51893
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Prevent login of restricted users 92/51892/2
Nicole Cordes [Tue, 28 Feb 2017 10:23:24 +0000 (11:23 +0100)]
[SECURITY] Prevent login of restricted users

As the new restriction handling relies on TCA information, we need to
load the TCA before any authentication starts. To prevent double loading
if a backend user is available the bootstrap API for loading TCA and
extension configuration is separated into two own functions.

Furthermore this patch resolves a wrong table parameter handling.

Resolves: #79761
Releases: master
Security-Commit: 936bf33bc337b9a00ca0b1ed4ba4d5d19b0999a1
Security-Bulletin: TYPO3-CORE-SA-2017-002
Change-Id: I2add4e96b9b1308756022c532395ce7bbc160bf2
Reviewed-on: https://review.typo3.org/51892
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Mark ExtJS related API calls as deprecated 95/51795/3
Benni Mack [Wed, 22 Feb 2017 09:28:44 +0000 (10:28 +0100)]
[TASK] Mark ExtJS related API calls as deprecated

ExtensionManagementUtility::addExtJSModule
and ExtensionManagementUtility::registerExtDirectComponent
are marked as deprecated, however, as the latter is still
in use, it does not trigger a deprecation log message yet,
but it should be clear for Extension Developers to not depend
on that method anymore.

Resolves: #80048
Releases: master
Change-Id: If8a14d75c8117e9325d2fff0d5c696e967ec873b
Reviewed-on: https://review.typo3.org/51795
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Multiple InlineCSS overrides each other 79/51879/2
Haco [Tue, 21 Feb 2017 12:01:09 +0000 (13:01 +0100)]
[BUGFIX] Multiple InlineCSS overrides each other

The 'Default CSS' (eg. from extensions) & 'Specific Page CSS'
(from TYPO3) can now be used together when "inlineStyle2TempFile = 0"
is set.

Resolves: #77534
Releases: master, 7.6
Change-Id: I22bb68938068a82691ce2132866ef191eac672fd
Reviewed-on: https://review.typo3.org/51879
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FOLLOWUP][TASK] Update bower components to the latest versions 81/51881/2
Josef Glatz [Tue, 28 Feb 2017 04:30:28 +0000 (05:30 +0100)]
[FOLLOWUP][TASK] Update bower components to the latest versions

The version number of bower dependencies should reflect
the one of the installed version:

* bootstrap-datetimepicker.js v4.17.43 to v4.17.45
* bootstrap-slider.min.js v9.5.3 to v9.7.2
* moment-timezone.js v0.5.10 to v0.5.11

Related: #79803
Releases: master
Change-Id: I57e7f0009a3bfd0fdd5c257967de69fd7c1b531c
Reviewed-on: https://review.typo3.org/51881
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove deprecated TCA requestUpdate in ctrl section 80/51880/2
Josef Glatz [Tue, 28 Feb 2017 03:58:06 +0000 (04:58 +0100)]
[BUGFIX] Remove deprecated TCA requestUpdate in ctrl section

An already deprecated TCA ctrl field requestUpdate was
apparently introduced by accident while streamlining
FSC and CSC.

Resolves: #80049
Related: #78899
Related: #79622
Releases: master
Change-Id: I41e613ffc99b17124deeb446ff6b5e24ec464f36
Reviewed-on: https://review.typo3.org/51880
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Update bower components to the latest versions 66/51666/2
Faton Haliti [Tue, 14 Feb 2017 09:52:21 +0000 (10:52 +0100)]
[TASK] Update bower components to the latest versions

Updates:

* bootstrap-datetimepicker.js
* bootstrap-slider.min.js
* moment-timezone.js

Resolves: #79803
Releases: master
Change-Id: I71774dcf92d802e4da2422d1dd7efec907555877
Reviewed-on: https://review.typo3.org/51666
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Update autocomplete JS widget for BE 81/51781/4
Markus Klein [Mon, 20 Feb 2017 00:41:08 +0000 (01:41 +0100)]
[TASK] Update autocomplete JS widget for BE

Resolves: #79938
Releases: master, 7.6
Change-Id: I50e84f11595ea6e79280084bfbf94d75be646de1
Reviewed-on: https://review.typo3.org/51781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Only check if a record lives in a workspace if extension is installed 28/49628/5
Andreas Fernandez [Mon, 29 Aug 2016 16:00:28 +0000 (18:00 +0200)]
[BUGFIX] Only check if a record lives in a workspace if extension is installed

The reference index checks if a record type is enabled for workspaces and
if a record exists in the currently selected workspace. However, this is
not required if EXT:workspaces is not installed at all as a lot of useless
queries could be run.

It's now checked whether the extension is installed before doing further
workspace processing of the record.

Resolves: #77676
Related: #64253
Releases: master, 7.6
Change-Id: I94aab84fce72e8b852783820b34065ab1e051ea5
Reviewed-on: https://review.typo3.org/49628
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove redundant Fluid overrides 03/51803/3
Claus Due [Thu, 23 Feb 2017 14:14:37 +0000 (15:14 +0100)]
[TASK] Remove redundant Fluid overrides

Since Fluid 2.3.0 is now the minimum required version,
we can drop several of the classes/methods TYPO3
uses to change/extend Fluid's behavior. The features
provided by the classes are now provided by Fluid.

Change-Id: I781ef4e6aeedc7aabb4cd3bac0ec8a7416de1ab9
Resolves: #79972
Releases: master
Reviewed-on: https://review.typo3.org/51803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid page path floating left in DocHeader 75/51875/3
Georg Ringer [Mon, 27 Feb 2017 07:37:21 +0000 (08:37 +0100)]
[BUGFIX] Avoid page path floating left in DocHeader

Fix the position of the page path in DocHeader.

Resolves: #80045
Releases: master
Change-Id: If50725fcb4342011562b008fd98d248a0367a4be
Reviewed-on: https://review.typo3.org/51875
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Add SystemStatusCheck for PostgreSQL 68/51368/6
Manuel Selbach [Fri, 20 Jan 2017 08:59:49 +0000 (09:59 +0100)]
[TASK] Add SystemStatusCheck for PostgreSQL

The SystemStatusCheck for PostgreSQL checks the server and the libpq version.
It’s important to use the correct libpq version as this will lead to problems
if it differs to much from the server version.

Change-Id: I370b57cc8e516624ee7a299b0c3710d834175386
Resolves: #79331
Releases: master
Reviewed-on: https://review.typo3.org/51368
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Replace FileInfoHook with renderType 74/51874/8
Anja Leichsenring [Mon, 27 Feb 2017 14:00:18 +0000 (15:00 +0100)]
[TASK] Replace FileInfoHook with renderType

Switch a userFunc to a proper renderType used in fileinfo field
of sys_file and sys_file_metadata table.

Resolves: #80039
Releases: master
Change-Id: I7093027716cb43fa2f00044f51d918cc8f91ee6e
Reviewed-on: https://review.typo3.org/51874
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add addTop/removeTop row in backend layout wizard 70/51870/4
Georg Ringer [Mon, 27 Feb 2017 07:37:21 +0000 (08:37 +0100)]
[TASK] Add addTop/removeTop row in backend layout wizard

Improve the backend layout wizard by providing additional buttons to
add and remove rows at the top.

Resolves: #80009
Releases: master
Change-Id: I85b2361cc63431e59f64265091323b2c6f2cf2b9
Reviewed-on: https://review.typo3.org/51870
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move CSV fixtures handling to FunctionalTestCase 38/51838/5
Tymoteusz Motylewski [Mon, 27 Feb 2017 08:45:03 +0000 (09:45 +0100)]
[TASK] Move CSV fixtures handling to FunctionalTestCase

Usage of CSV fixtures is now possible for all functional tests.
Previously it was available only for DataHandler tests.
This patch is backward compatible.

Resolves: #80007
Releases: master, 7.6
Change-Id: I6aa69825ac144b8c955b51a61060a822163511ca
Reviewed-on: https://review.typo3.org/51838
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FOLLOWUP][TASK] Enhance DataHandler translation and synchronization handling 84/51784/5
Oliver Hader [Tue, 21 Feb 2017 20:52:20 +0000 (21:52 +0100)]
[FOLLOWUP][TASK] Enhance DataHandler translation and synchronization handling

Copying a page translation having an 1:n monoglot inline relation leads
to an SQL error which is silently put to sys_log in DataHandler. Besides
that, the inline children are superfluously duplicated since there is no
connection between those copied records anymore.

Resolves: #79856
Releases: master
Change-Id: Ife5cfdea1c1d9dff764ea3d28e0a35a83d5919e1
Reviewed-on: https://review.typo3.org/51784
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Upgrade Wizard "Split menu types.." fails 58/51858/7
Thomas Hohn [Sat, 25 Feb 2017 16:11:24 +0000 (17:11 +0100)]
[BUGFIX] Upgrade Wizard "Split menu types.." fails

Show warning if table tt_content doesn't have column
menu_type instead of SQL error.

Resolves: #79813
Releases: master
Change-Id: Ibb6e260f45e65c2fc563be129d2da43c05a9eaf6
Reviewed-on: https://review.typo3.org/51858
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Uncaught exception in Install tool 61/51861/7
Thomas Hohn [Sun, 26 Feb 2017 15:05:33 +0000 (16:05 +0100)]
[BUGFIX] Uncaught exception in Install tool

Fixes an uncaught exception in the Install tool if the file
ext_tables_static+adt.sql contains invalid CREATE TABLE
statements.

Resolves: #80025
Releases: master
Change-Id: I8417b34c944f359feb16f5e44277b61fb289eea1
Reviewed-on: https://review.typo3.org/51861
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Update layout of navigation in DocHeader 31/51831/9
Jasmina Liessmann [Fri, 24 Feb 2017 13:46:26 +0000 (14:46 +0100)]
[TASK] Update layout of navigation in DocHeader

Use Bootstrap grid for arrangement of navigation items.
Shorten the characters of the current page title in DocHeader to
title length defined in user settings or default to '50'.

Resolves: #79849
Releases: master
Change-Id: I0825818cd961b8bb7f928cb1389537506d5ed40b
Reviewed-on: https://review.typo3.org/51831
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <service@enobe.de>
Tested-by: Joerg Kummer <service@enobe.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EM: Add title attribute to showAllVersions links 69/51869/3
Josef Glatz [Mon, 27 Feb 2017 06:00:18 +0000 (07:00 +0100)]
[BUGFIX] EM: Add title attribute to showAllVersions links

Add meaningful title attributes to all links which leads to the
showAllVersions action.

Resolves: #80029
Releases: master, 7.6
Change-Id: I85b9ee21514fbffd84734c4149d67237abb19652
Reviewed-on: https://review.typo3.org/51869
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Prevent different constants marker in TS parsing 88/50088/6
Nicole Cordes [Tue, 4 Oct 2016 13:21:57 +0000 (15:21 +0200)]
[BUGFIX] Prevent different constants marker in TS parsing

Currently each time the TypoScript is parsed a new marker for constants,
which are replaces by their value, is generated. This prevents conditions
with replaced constants to be displayed as active. This patch ensures
markers are generated by constants values and therefore stay the same
in different requests.

Resolves: #78142
Related: #72413
Releases: master, 7.6
Change-Id: I4eea83908927ac48930abdd731e7412c04e529c1
Reviewed-on: https://review.typo3.org/50088
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[TASK] Upgrade wizard to merge fe_session_data to fe_sessions 50/51850/10
Thomas Hohn [Sat, 25 Feb 2017 11:25:11 +0000 (12:25 +0100)]
[TASK] Upgrade wizard to merge fe_session_data to fe_sessions

Added a upgrade wizard to merge fe_session_data to fe_sessions
in order to avoid loosing session data when introducing the
new session framework.

Resolves: #79721
Releases: master
Change-Id: Iee2eb9b3096d8916382c01d7d1ad90fcc150f397
Reviewed-on: https://review.typo3.org/51850
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Restore operability for USER displayConds 37/51837/3
Claus Due [Fri, 24 Feb 2017 17:01:33 +0000 (18:01 +0100)]
[BUGFIX] Restore operability for USER displayConds

Parsing of the displayCond value was referencing the
incorrect array, causing the parsed displayCond to no
longer be correct. Referencing the correct array solves
the problem by generating the correct "named
condition array" based on the input.

Change-Id: Ia0cae240387ec8f24ea66b593b6824f9bb6b6dc5
Resolves: #79822
Releases: master
Reviewed-on: https://review.typo3.org/51837
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix PHP warning in TcaMigration 76/51776/3
Georg Ringer [Tue, 21 Feb 2017 07:17:34 +0000 (08:17 +0100)]
[BUGFIX] Fix PHP warning in TcaMigration

Check if defaultExtras exists before accessing it.

Resolves: #79929
Releases: master
Change-Id: I0a85012b335e10b3744aeb847246e4dabbb23f54
Reviewed-on: https://review.typo3.org/51776
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Reduce length of a very long .rst filename 66/51866/3
Christian Kuhn [Sun, 26 Feb 2017 22:03:34 +0000 (23:03 +0100)]
[TASK] Reduce length of a very long .rst filename

To reduce headaches on windows, a very long filename
is shortened in length.

Change-Id: I53086fa0018b7628d13a7b1330685c0a4e2f0189
Resolves: #80028
Releases: master
Reviewed-on: https://review.typo3.org/51866
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Remove ses_name from tables fe_sessions and be_sessions 21/51821/12
Thomas Hohn [Fri, 24 Feb 2017 09:10:55 +0000 (10:10 +0100)]
[TASK] Remove ses_name from tables fe_sessions and be_sessions

Both fe_session and be_session table currently have a combined
primary key on ses_id / ses_name which is not needed by the new
session framework.

In addition the field ses_name is dropped.

Resolves: #79720
Releases: master
Change-Id: I4827d4ebfa0e04a303fca21ae865c99188d1a81a
Reviewed-on: https://review.typo3.org/51821
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix parameter type in BackendModuleRequestHandler 91/51791/3
Markus Hoelzle [Wed, 22 Feb 2017 08:38:40 +0000 (09:38 +0100)]
[BUGFIX] Fix parameter type in BackendModuleRequestHandler

The function
\TYPO3\CMS\Core\Authentication\BackendUserAuthentication
->getPagePermsClause accepts only an integer value as parameter,
but a boolean value is given in
TYPO3\CMS\Backend\Http\BackendModuleRequestHandler->dispatchModule

Resolves: #79949
Releases: master
Change-Id: I6d0e6049ce2f68f361853f5c5ea50984c9448347
Reviewed-on: https://review.typo3.org/51791
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Detect the conversion to string "0" in stdWrap_csConv 25/48425/8
Elmar Hinz [Wed, 1 Jun 2016 06:40:09 +0000 (08:40 +0200)]
[BUGFIX] Detect the conversion to string "0" in stdWrap_csConv

Check for the return value of the converter to be of type string or
return the input. The string "0" is detected.

If the return string of the converter is the empty string, return the
input. This is done to keep the previous behaviour apart from the "0"
issue.

Update the method comment.

Resolves: #76413
Releases: master
Change-Id: I1dc214a6b7cad5815d96c9cdb671862ee99b3063
Reviewed-on: https://review.typo3.org/48425
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FOLLOWUP][TASK] Compare password hashes in constant time 53/51853/2
Christian Futterlieb [Sat, 25 Feb 2017 13:33:38 +0000 (14:33 +0100)]
[FOLLOWUP][TASK] Compare password hashes in constant time

Apply constant-time comparison to the fallback password checks as well.

Change-Id: I8d2aa6448c95266a45b2862f12f1a5d8259f4f0b
Releases: master
Resolves: #79888
Related: #79795
Reviewed-on: https://review.typo3.org/51853
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Installtool blocked when session file is empty 35/51835/4
Timo Schmidt [Fri, 24 Feb 2017 15:38:36 +0000 (16:38 +0100)]
[BUGFIX] Installtool blocked when session file is empty

When the session information is fetched from the file system it can
happen that the session file is empty.

We should check for the file length and only read it, when the file
length is larger then 0.

Change-Id: I8857efc54f76c56984bc3486064b622b05e488b8
Resolves: #79955
Releases: master
Reviewed-on: https://review.typo3.org/51835
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Use correct check in search if list module is available 08/51808/3
Georg Ringer [Thu, 23 Feb 2017 18:25:36 +0000 (19:25 +0100)]
[BUGFIX] Use correct check in search if list module is available

The check if the list module is available for the user must be
extended to check for false as well.

Resolves: #79974
Releases: master, 7.6
Change-Id: Icd1e2c2cff3f37ce6763bc4f64d4011443226a68
Reviewed-on: https://review.typo3.org/51808
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] TCA: Make ###CURRENT_PID### work in foreign_table_where in IRRE 34/50934/5
Nicole Cordes [Mon, 12 Dec 2016 16:53:10 +0000 (17:53 +0100)]
[BUGFIX] TCA: Make ###CURRENT_PID### work in foreign_table_where in IRRE

The patch adds the current database row to the data passed to the select
field rendered by foreign_selector of IRRE.
This data is necessary to properly resolve the ###CURRENT_PID### marker
in a foreign_table_where clause.

Resolves: #78960
Releases: master, 7.6
Change-Id: I17f6b4a78d20c101ef7caab227d23c87f138e8ce
Reviewed-on: https://review.typo3.org/50934
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] DateTime parse error on edit pages field newUntil 59/51859/3
Joerg Kummer [Sat, 25 Feb 2017 18:28:12 +0000 (19:28 +0100)]
[BUGFIX] DateTime parse error on edit pages field newUntil

Remove TCA config 'max' limit for datetime fields to avoid DateTime
parse errors. No other renderType='inputDateTime' fields in core
TCA have this limit set. Field pages.newUntil should too.

Resolves: #80022
Releases: master
Change-Id: I2b90a1f69d5b3f4f644faa3fab5d15bba6ca67ae
Reviewed-on: https://review.typo3.org/51859
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <service@enobe.de>
Tested-by: Joerg Kummer <service@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update layout of field 'style' in link wizard (RTE, CKeditor) 43/51843/2
Jasmina Liessmann [Fri, 24 Feb 2017 21:02:53 +0000 (22:02 +0100)]
[TASK] Update layout of field 'style' in link wizard (RTE, CKeditor)

Use Bootstrap grid for form field 'style' in link wizard.

Resolves: #80011
Releases: master
Change-Id: Icb62d5f4e8cc3990b774ddf0ba56ab9fb301d17c
Reviewed-on: https://review.typo3.org/51843
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Tested-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] DB Check causes PHP warnings and errors 13/51813/9
Thomas Hohn [Fri, 24 Feb 2017 07:26:56 +0000 (08:26 +0100)]
[BUGFIX] DB Check causes PHP warnings and errors

In DatabaseIntegrityCheck the method selectNonEmptyRecordsWithFkeys
also needs to take the BLOB into account or else it will fail with
a PHP warning. Furthermore the returned tableColumns list may contain
quoted fields names if the field name can be interpreted as a keyword
for the used connection platform. This patch ensures the correct
column information is received before further processing is started.

Additionally the "Record Statics" module is fixed by checking for an
empty TCA table field which invokes an exception.

Resolves: #79347
Resolves: #79991
Resolves: #79992
Releases: master
Change-Id: Ie455abd2da90d7dabc773ec345b5c8a87b0b5836
Reviewed-on: https://review.typo3.org/51813
Reviewed-by: Christer V <cvi@systime.dk>
Tested-by: Christer V <cvi@systime.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Limit maximum key length on sys_refindex 28/51828/2
Claus Due [Fri, 24 Feb 2017 12:55:48 +0000 (13:55 +0100)]
[BUGFIX] Limit maximum key length on sys_refindex

Prevents issues if key length exceeds maximum key
lengt for the SQL server. Keys are now kept below a
255 byte limit.

Change-Id: I8e0c2a167f94695dd728c777368fac9e779678d8
Resolves: #79993
Releases: master
Reviewed-on: https://review.typo3.org/51828
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Respect IRRE parent config in Ajax calls 83/51783/3
Helmut Hummel [Sat, 25 Feb 2017 19:32:39 +0000 (20:32 +0100)]
[BUGFIX] Respect IRRE parent config in Ajax calls

The code to transfer the inline parent context to form engine
in Ajax requests exists but is currently non functional in some
situations.

The config is stored as array, which is hashed by serializing
the array, and building the hash on that string. However
that string is not transferred over the wire,
but the json encoded array.

If a float value was present at some place in this array,
json_encode and json_decode will add a slight offset
to these numbers than if the value is serialized.

To avoid such errors, the hmac is now calculated and
checked against the json encoded value.

We also clean up the code in this area to avoid duplication
and improve the hash calculation and comparison.

By doing so, we can clean up and simplify the flex form handling
for IRRE fields as well.

Resolves: #79999
Releases: master
Change-Id: I049d699f9f30edad0a9c8b06bbc3970e2cdac417
Reviewed-on: https://review.typo3.org/51783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Improve unstable language tests 32/51832/4
Joerg Kummer [Fri, 24 Feb 2017 13:58:48 +0000 (14:58 +0100)]
[TASK] Improve unstable language tests

The notification js object gets "duration" as additional default value.
This can be increased for acceptance tests to ensure
notifications don't vanish before they are tested.
Activate two ac tests again that were disabled for that reason.

Resolves: #79963
Releases: master
Change-Id: Ib7bf046e7de1999fc693e08eeefc7d4c420bddae
Reviewed-on: https://review.typo3.org/51832
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <service@enobe.de>
Tested-by: Joerg Kummer <service@enobe.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Prevent installing incompatible extensions without confirmation 34/51834/3
Nicole Cordes [Fri, 24 Feb 2017 15:32:09 +0000 (16:32 +0100)]
[BUGFIX] Prevent installing incompatible extensions without confirmation

Currently it is possible to install incompatible extensions without
confirming the overlay popup. This patch prevents submitting the
overlay if the button is still disabled.

Resolves: #80005
Releases: master, 7.6
Change-Id: Ia68539cb9ce2a82f1e90aef3823f60cfadee2ce1
Reviewed-on: https://review.typo3.org/51834
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] If User TSConfig disables avatar it gets lost when saved 60/51860/4
Thomas Hohn [Sun, 26 Feb 2017 11:01:33 +0000 (12:01 +0100)]
[BUGFIX] If User TSConfig disables avatar it gets lost when saved

If the user is not allow to modify the avatar it gets
lost since there was no distinction between deleted and
not allowed to modify causing the avatar to be deleted
on save.

Resolves: #80002
Releases: master
Change-Id: I1cf6fa93c2af1122c481b52860990c2433d86594
Reviewed-on: https://review.typo3.org/51860
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Remove indeterministic test ensureCorrectPostOrderingByCategoryTitle 44/51844/2
Morton Jonuschat [Sat, 25 Feb 2017 07:02:00 +0000 (23:02 -0800)]
[BUGFIX] Remove indeterministic test ensureCorrectPostOrderingByCategoryTitle

The test only works on MySQL with disabled SQL MODE ONLY_FULL_GROUP_BY.
All standard conformant database setups fail this test as the result of
the query is not deterministic due to GROUP BY being evaluated before
ORDER BY.

Change-Id: Ib6d4599e0f5682e8b72971d0f35ef00cfa8d3e6a
Resolves: #80014
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51844
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Tested-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] EXT:info_pagetsconfig Optimized view on page 0 43/51043/4
Michael Oehlhof [Sun, 25 Dec 2016 21:57:29 +0000 (22:57 +0100)]
[BUGFIX] EXT:info_pagetsconfig Optimized view on page 0

If there are no pages containing Page TSconfig settings in the page
configuration an info FlashMessage is shown instead of an empty table.

Resolves: #78509
Releases: master
Change-Id: I4a5cda38746187a1147e5500e77b516cb9a85fd6
Reviewed-on: https://review.typo3.org/51043
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Install tool upgrade wizards fail on postgres 62/51862/2
Christian Kuhn [Sun, 26 Feb 2017 16:15:02 +0000 (17:15 +0100)]
[BUGFIX] Install tool upgrade wizards fail on postgres

Controller class UpgradeWizard of install tool method performUpdate()
calls getDatabaseConnection() (old TYPO3_DB) and connects. This was
done in the past to receive the list of executed queries during
upgrade and is now implemented in the single upgrade classes directly.

If running postgres, the connect attempt of old database class tries
to connect to a mysql instance and runs into a timeout.

Remove this TYPO3_DB left over from the install tool to successfully
execute upgrade wizards on non-mysql platforms.

Change-Id: Ia87ae4bce1c4f4992527f0fa6fbddebdb6e3733c
Resolves: #80026
Releases: master
Reviewed-on: https://review.typo3.org/51862
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Detect TEXT/BLOB changes in schema analyzer 07/51807/10
Thomas Hohn [Thu, 23 Feb 2017 17:54:21 +0000 (18:54 +0100)]
[BUGFIX] Detect TEXT/BLOB changes in schema analyzer

Length changes of TEXT/BLOB type are not analyzed by the Doctrine
schema analyzer as only MySQL has different length version of these
fields. Add a custom column comparator that compares the different
fields length on MySQL to properly detect changes in field type.

Resolves: #79722
Releases: master
Change-Id: I2e448dcde02c3fa370496b4920dfad536fbafcd6
Reviewed-on: https://review.typo3.org/51807
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid duplicates if ReferenceIndex is unable to finish 03/50803/14
Claus Due [Tue, 29 Nov 2016 11:58:38 +0000 (12:58 +0100)]
[BUGFIX] Avoid duplicates if ReferenceIndex is unable to finish

Solves an issue where DB may end up containing duplicates
if the reference indexer is unable to finish, e.g. if memory
or max execution time are exhausted. Such cases would
leave duplicate indexed references. The patch avoids those
duplicates by ensuring that the patch does not contain a
sorting value, which lets the reference indexer retrieve the
original reference even if it has a new sorting.

Further an update wizard is added that allows to rewrite the hash of
existing records.

Resolves: #78829
Releases: master
Change-Id: I145aa60460c5904a83b6c8373f107c7bfce8b434
Reviewed-on: https://review.typo3.org/50803
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Update readme of EXT:lowlevel 39/51839/6
Georg Ringer [Fri, 24 Feb 2017 18:31:58 +0000 (19:31 +0100)]
[TASK] Update readme of EXT:lowlevel

The lowlevel CLI tasks have been migrated to symfony commands and
therefore the readme has to be updated as well.

Resolves: #79996
Releases: master
Change-Id: If584569680bfcf769056b39b5472571deeb21807
Reviewed-on: https://review.typo3.org/51839
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Don't render header of content element shortcut 08/51708/3
Georg Ringer [Wed, 15 Feb 2017 18:09:04 +0000 (19:09 +0100)]
[BUGFIX] Don't render header of content element shortcut

The header of the element "shortcut" states "not visible in frontend"
and it should not be shown (like it was previously).

Resolves: #79825
Releases: master
Change-Id: I87db1e47211983f259c0323a6b0b684e23f012e2
Reviewed-on: https://review.typo3.org/51708
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove unused TCA property `localizeReferences` from tests 48/51848/5
Anja Leichsenring [Sat, 25 Feb 2017 10:36:24 +0000 (11:36 +0100)]
[TASK] Remove unused TCA property `localizeReferences` from tests

irre_tuturial test extension uses TCA setting 'localizeReferences',
but that setting does not exist and has no meaning in TCA. Remove it.

Resolves: #80015
Releases: master
Change-Id: I421b392cb7dec2c9530d86f926fd0169efe99b82
Reviewed-on: https://review.typo3.org/51848
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Add support for multi-line INSERT statements in static data 54/51854/5
Thomas Hohn [Sat, 25 Feb 2017 14:03:05 +0000 (15:03 +0100)]
[BUGFIX] Add support for multi-line INSERT statements in static data

Join consecutive lines for INSERT statements in ext_tables_static+adt.sql
using a space instead of a linefeed to avoid parser errors.

Resolves: #78892
Releases: master
Change-Id: Ide550419b7ef41109a660a671b8aba65a33eb6b3
Reviewed-on: https://review.typo3.org/51854
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Fix dynamic variable name parts in Fluid 41/51841/3
Helmut Hummel [Fri, 24 Feb 2017 19:23:24 +0000 (20:23 +0100)]
[BUGFIX] Fix dynamic variable name parts in Fluid

The dynamic variable syntax does currently work in Fluid standalone,
but not with the variable provider used for TYPO3 CMS (as promised)

To fix this, we copy the necessary code to the CMS variable provider
as it is only a few lines.

Cover that with tests and apply it in the image cropper UI as one example.

Resolves: #79997
Releases: master
Change-Id: I3a811b0d496b12191d2ccbaa9c07525f4cf8f340
Reviewed-on: https://review.typo3.org/51841
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Init permissions in context menu 52/51852/2
Susanne Moog [Sat, 25 Feb 2017 13:31:15 +0000 (14:31 +0100)]
[BUGFIX] Init permissions in context menu

The current user permissions were not initialized
for the context menu resulting in non-existing
permissions for editors (and no possibility to copy
a page).

Change-Id: I8fe747a1f19b4bea794b7fdbd676e7f366eea695
Resolves: #80019
Releases: master
Reviewed-on: https://review.typo3.org/51852
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Steffen Frese
Tested-by: Steffen Frese
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] InvalidXmlFileException for invalid locallang.xml 61/51761/9
Sascha Egerer [Sun, 19 Feb 2017 20:34:53 +0000 (21:34 +0100)]
[BUGFIX] InvalidXmlFileException for invalid locallang.xml

Throw a meaningful InvalidXmlFileException when an invalid locallang.xml
file is detected.

Resolves: #79908
Releases: master, 7.6
Change-Id: Idc5586166d2475edeaeef407128525ea57fb9a09
Reviewed-on: https://review.typo3.org/51761
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Anders Kostending <aha@systime.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Faton Haliti <fha@systime.dk>
Tested-by: Faton Haliti <fha@systime.dk>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Don't update passwords if left untouched 29/51829/4
Mads Jensen [Sat, 25 Feb 2017 10:58:19 +0000 (11:58 +0100)]
[BUGFIX] Don't update passwords if left untouched

Fixes a bug where editing a backend user record without updating the
password would result in the password being set to
the string literal "*********".

This reverts #79576 because the fix for showing the password hash in the readable
field was wrong and causing this bug.

Instead of forcing the database value in the hidden field to be asterisks,
we now correctly set the type of the human readable field to be password.

This triggers a special handling in the form engine JavaScript, not filling
the human readable field with the database value and switching to type text
when entering a new password.

Resolves: #79714
Reverts: #79576
Releases: master
Change-Id: Ia465293272131c32bbb9fd9b0d3916676e130996
Reviewed-on: https://review.typo3.org/51829
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mads Lønne Jensen <mlj@systime.dk>
Tested-by: Mads Lønne Jensen <mlj@systime.dk>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Faton Haliti <fha@systime.dk>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Opening links in pop-up windows 30/51830/3
Christer Vindberg [Fri, 24 Feb 2017 13:33:34 +0000 (14:33 +0100)]
[BUGFIX] Opening links in pop-up windows

Moved the check for if the target is coded as a JS open window link,
to a later stage in the function.

Since Css Styled Content and Fluid Styled Content was refactored,
the target might not be set until later in the typoLink
function. This caused pop links to stop working, moving the check for a
pop up link target to a later stages fixes the problem.

Resolves: #79918
Releases: master
Change-Id: Ie27fa3142df83c33ba3ad465ecb35c0f6e571f86
Reviewed-on: https://review.typo3.org/51830
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Faton Haliti <fha@systime.dk>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Timo Hund <timo.hund@yahoo.com>
Tested-by: Timo Hund <timo.hund@yahoo.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Correct handling of ObjectStorage objects in PaginateController 75/51475/3
Nicole Cordes [Mon, 30 Jan 2017 18:01:32 +0000 (19:01 +0100)]
[BUGFIX] Correct handling of ObjectStorage objects in PaginateController

The current implementation for getting paginated items from ObjectStorage
objects in TYPO3\CMS\Fluid\ViewHelpers\Widget\Controller\PaginateController
enforces null items if the count of objects is lower than the
itemsPerPage count. This patch calculates the correct count and returns
valid items only.

Resolves: #79559
Releases: master, 7.6
Change-Id: I5746d83120474d6246da949f67096459ed1076d7
Reviewed-on: https://review.typo3.org/51475
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Matthes
Tested-by: Christian Matthes
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Ignore invalid files in LocalDriver::getDirectoryItemList 55/51655/2
Nicole Cordes [Mon, 13 Feb 2017 13:22:39 +0000 (14:22 +0100)]
[BUGFIX] Ignore invalid files in LocalDriver::getDirectoryItemList

Due to some security changes in GeneralUtility::validPathStr some
wrongly encoded files are now returned as invalid. This breaks e.g. the
file list.
This patch adds a try/catch block to ignore invalid files and return the
valid ones.

Resolves: #79776
Releases: master, 7.6, 6.2
Change-Id: Iaa3697b04c123bba61a426fdf39ee3959f68b705
Reviewed-on: https://review.typo3.org/51655
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobias Liebig <tobias.liebig@typo3.org>
Tested-by: Tobias Liebig <tobias.liebig@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Fix CSS layout of cropper UI for Firefox 42/51842/3
Raphael Okon [Fri, 24 Feb 2017 15:59:17 +0000 (16:59 +0100)]
[BUGFIX] Fix CSS layout of cropper UI for Firefox

The fix is to remove previously introduced CSS hacks
and provide a cleaner and leaner base

Resolves: #79998
Resolves: #79989
Releases: master
Change-Id: Ic63b3acaf46f50f92a3c44578c28748dfca74351
Reviewed-on: https://review.typo3.org/51842
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Improve layout of ImageManipulation preview 10/51810/5
jliessmann [Thu, 23 Feb 2017 19:36:23 +0000 (20:36 +0100)]
[TASK] Improve layout of ImageManipulation preview

Use bootstrap grid to arrange image thumbnails

Resolves: #79960
Releases: master
Change-Id: I99ef6fc159c1497ea5464ef33398cf799c91a534
Reviewed-on: https://review.typo3.org/51810
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Joerg Kummer <service@enobe.de>
Tested-by: Joerg Kummer <service@enobe.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Indexed search causes 404 because of missing cHash 09/51809/2
Christer Vindberg [Thu, 23 Feb 2017 19:27:53 +0000 (20:27 +0100)]
[BUGFIX] Indexed search causes 404 because of missing cHash

When [FE][pageNotFoundOnCHashError] = true, searching with Indexed search
 in FE causes an 404, because the POST action is missing the cHash.

Resolves: #79970
Releases: master
Change-Id: If4f205ddfd264b1213ef696265fda0a8a6d9f29c
Reviewed-on: https://review.typo3.org/51809
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Add missing jQuery context for EM modal 26/51826/2
Nicole Cordes [Fri, 24 Feb 2017 11:59:13 +0000 (12:59 +0100)]
[BUGFIX] Add missing jQuery context for EM modal

This patch adds the modal context to be able to confirm the installation
of an incompatible extension.

Resolves: #79995
Releases: master
Change-Id: I84187076684eb1fb4ee69679f8003ec115a6bf2c
Reviewed-on: https://review.typo3.org/51826
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Remove last references to _cli_lowlevel 14/51814/3
Thomas Hohn [Fri, 24 Feb 2017 07:49:21 +0000 (08:49 +0100)]
[TASK] Remove last references to _cli_lowlevel

Some references to the _cli_lowlevel were still present
and have been removed.

Resolves: #79986
Releases: master

Change-Id: I79473cc422a21761b3474facb4f981501ed7f545
Reviewed-on: https://review.typo3.org/51814
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christer V <cvi@systime.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Scale images in content element preview 02/51802/3
Mads Jensen [Thu, 23 Feb 2017 14:09:07 +0000 (15:09 +0100)]
[BUGFIX] Scale images in content element preview

Added CSS to ensure images are contained in parent element.

Resolves: #79971
Releases: master
Change-Id: I38a4038af067166d771d012e2ddc0e2983060513
Reviewed-on: https://review.typo3.org/51802
Reviewed-by: Morten Pless <mpl@systime.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Timo Hund <timo.hund@yahoo.com>
Tested-by: Timo Hund <timo.hund@yahoo.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Exception when setting "language" to "all" for content elements 04/51804/8
Timo Schmidt [Thu, 23 Feb 2017 13:59:44 +0000 (14:59 +0100)]
[BUGFIX] Exception when setting "language" to "all" for content elements

Currently you get an error in the backend when you try to set the
language to "all" for a new or existing content element (integer was
expected but null received triggers PHP strict type error).

The reason for this is, that the DataMapProcessor tries to sychronize
elements from tt_content with uid 0.

This patch adds an integration test that content elements without an
existing source do not get synronized.

Resolves: #79853
Releases: master
Change-Id: I67d4b35efe1564c13e9faf085c4848f2d0313998
Reviewed-on: https://review.typo3.org/51804
Tested-by: Claus Due <claus@phpmind.net>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Morten Pless <mpl@systime.dk>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[TASK] Disable ensureCorrectPostOrderingByCategoryTitle on postgres 18/51818/2
Christian Kuhn [Fri, 24 Feb 2017 08:41:37 +0000 (09:41 +0100)]
[TASK] Disable ensureCorrectPostOrderingByCategoryTitle on postgres

A recently added test in extbase query building reveals a
non-trivial-to-fix issue of the created query with postgres.
This is the last issue we have with functionals on postgres, to
have them running as pre-merge tests we for now disable the offending
tests on that database platform, and handle the real fix in a
separate issue.

Change-Id: I830af04ecdb41fa968421521e9860c388f74d75b
Resolves: #79987
Related: #79988
Related: #79931
Related: #79932
Related: #79330
Releases: master
Reviewed-on: https://review.typo3.org/51818
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate BackendUtility::getRecordsByField 78/51078/9
Morton Jonuschat [Fri, 30 Dec 2016 22:33:58 +0000 (14:33 -0800)]
[TASK] Deprecate BackendUtility::getRecordsByField

Deprecate BackendUtility::getRecordsByField() as it has a flawed design
due to passing SQL fragments. This contradicts the goal of using named
parameters for all queries in the core and requires passing the original
QueryBuilder object in addition to the stringified constraint.

Replace all calls to the method with direct usage of the QueryBuilder and
deprecate the method.

Resolves: #79122
Releases: master
Change-Id: I8b040b98e20271aff84ef16fb89b59a406d54003
Reviewed-on: https://review.typo3.org/51078
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix non-302 redirects for PSR-7 response objects 02/51002/2
Benjamin Franzke [Tue, 20 Dec 2016 06:26:42 +0000 (07:26 +0100)]
[BUGFIX] Fix non-302 redirects for PSR-7 response objects

All redirect status codes (e.g. 201,301,303,307) are incorrectly
sent as 302.

We need to set the response code before setting the Location header,
as a call to header('Location: ...'); sets the response code
implicitly to 302 (unless it has already been set to 201 or 3xx) [1].
By settings the status code/header first, header('Location: ..') will
not change the status code, if the PSR-7 response object contains a
proper redirect status code.

[1] http://php.net/manual/en/function.header.php
    The second special case is the "Location:" header.
    Not only does it send this header back to the browser, but it also
    returns a REDIRECT (302) status code to the browser unless the 201
    or a 3xx status code has already been set.

Change-Id: Ifa076e6393c6ed42d93959fe8c3a5b79cee145a4
Fixes: #79043
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51002
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Marco Huber <mail@marco-huber.de>
Tested-by: Marco Huber <mail@marco-huber.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Add rowDescription for fe_users 45/51745/2
Josef Glatz [Sat, 18 Feb 2017 19:48:41 +0000 (20:48 +0100)]
[TASK] Add rowDescription for fe_users

Add a description field also for fe_users records which
could be used as for already known other record types.

Resolves: #79894
Releases: master
Change-Id: Ia1d7ad7746a0b7dd3ebb809864e290db97ac228d
Reviewed-on: https://review.typo3.org/51745
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Rearrange search form fields in page/list module 12/51812/4
Jasmina Liessmann [Thu, 23 Feb 2017 21:17:12 +0000 (22:17 +0100)]
[TASK] Rearrange search form fields in page/list module

Use Bootstrap grid for arrangement of search form fields.

Resolves: #79848
Releases: master
Change-Id: Ied1b30a2ba81b339ac93a9a874720b43623e6e66
Reviewed-on: https://review.typo3.org/51812
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Update jquery match height plugin 11/51811/2
Helmut Hummel [Thu, 23 Feb 2017 20:15:09 +0000 (21:15 +0100)]
[TASK] Update jquery match height plugin

Fix the changed path as well

Resolves: #79980
Releases: master
Change-Id: I5b23e4bb56f47d151b506439c4e46b9c0838bd87
Reviewed-on: https://review.typo3.org/51811
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Fix functional tests for EXT:impexp on PostgreSQL 74/51774/8
Morton Jonuschat [Mon, 20 Feb 2017 17:14:16 +0000 (09:14 -0800)]
[BUGFIX] Fix functional tests for EXT:impexp on PostgreSQL

Introduce dedicated fixures for the export data based on the database
platform being tested. Due to mysqlnd and PDO based drivers returning
different types of values (mainly int vs string) the resulting XML
is dependent on the database.

Change-Id: I776cfbc28c7355e72c21fa89097077f94225e223
Resolves: #79798
Releases: master
Reviewed-on: https://review.typo3.org/51774
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Compare password hashes in constant time 37/51737/11
Christian Futterlieb [Sat, 18 Feb 2017 10:51:07 +0000 (11:51 +0100)]
[TASK] Compare password hashes in constant time

In order to avoid time-based hash-based attacks, the native
PHP security functions are used instead of simple string
comparisons, when comparing passwords with hashes.

Change-Id: I0dbe2c12c5017f9d71ea7628ddd35d919510ac12
Releases: master
Resolves: #79888
Related: #79795
Reviewed-on: https://review.typo3.org/51737
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mads Lønne Jensen <mlj@systime.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>