Packages/TYPO3.CMS.git
5 years ago[TASK] Fix typos all over the core 23/27523/2
Georg Ringer [Mon, 10 Feb 2014 06:51:19 +0000 (07:51 +0100)]
[TASK] Fix typos all over the core

Change-Id: I40990623e3d53e70666438acafc27275ac36b621
Resolves: #55827
Releases: 6.2
Reviewed-on: https://review.typo3.org/27523
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] "else if" in GeneralUtility breaks the build 21/27521/3
Oliver Klee [Sun, 9 Feb 2014 20:59:44 +0000 (21:59 +0100)]
[BUGFIX] "else if" in GeneralUtility breaks the build

Resolves: #55822
Releases: 6.2
Change-Id: I32dd5119a3580df3990997d1c812f33c062c39ba
Reviewed-on: https://review.typo3.org/27521
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Use PHP native htmlspecialchars_decode() 73/27473/3
Łukas Jurys [Sat, 8 Feb 2014 18:21:37 +0000 (19:21 +0100)]
[BUGFIX] Use PHP native htmlspecialchars_decode()

Method Generalutility::htmlspecialchars_decode()
was replaced by htmlspecialchars_decode().
Also  Generalutility::htmlspecialchars_decode()
has been marked as deprecated

Resolves: #54777
Releases: 6.2
Change-Id: Idc9b12d8a1dc2746ee0f742c37c640118c9f69c3
Reviewed-on: https://review.typo3.org/27473
Reviewed-by: Oliver Klee
Reviewed-by: Karol Lamparski
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix CSS-path to default .t3-icon image 94/27494/3
Stefan Neufeind [Sun, 9 Feb 2014 00:36:23 +0000 (01:36 +0100)]
[BUGFIX] Fix CSS-path to default .t3-icon image

There is no such icon in
typo3/sysext/backend/Resources/Public/gfx/

Usually the default-icon is overwritten in CSS
anyhow by specifying the icon to use, so the
bug does not show. But the path is still wrong.

Change-Id: Ie321cecfb888664a3ec782933e72cfa89e6f41ec
Resolves: #55799
Releases: 6.2
Reviewed-on: https://review.typo3.org/27494
Tested-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Remove unstable GeneralUtilityTest::getUrl* 18/27518/4
Christian Kuhn [Sun, 9 Feb 2014 18:48:24 +0000 (19:48 +0100)]
[BUGFIX] Tests: Remove unstable GeneralUtilityTest::getUrl*

Two tests check getUrl() by calling some resource on typo3.org.
This smells funny and the tests are unstable if network, dns
or typo3.org is down or slow. Mocking is not easily possible
with the lowlevel nature of getUrl().
The tests are removed for now.

Change-Id: I85a83345404c833a67c2f532e820fd28bb7c08e7
Resolves: #55821
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/27518
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] improve handling of TYPO3 version 09/27509/5
Jigal van Hemert [Sun, 9 Feb 2014 12:01:45 +0000 (13:01 +0100)]
[BUGFIX] improve handling of TYPO3 version

getNumericTypo3Version() needs to be more flexible when converting
the defined version number into one that can be used by the EM.

Resolves: #23902
Releases: 6.2
Change-Id: Ie2ed54c1383e3c6ff9631608e2e9e471ef109952
Reviewed-on: https://review.typo3.org/27509
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Duplicate exception code 62/27462/3
Przemysław Krukowski [Sat, 8 Feb 2014 14:40:58 +0000 (15:40 +0100)]
[BUGFIX] Duplicate exception code

Exception codes are unique now.

Resolves: #52294
Releases: 6.2
Change-Id: I4ad49b1ff0342ea36147b6ba0b01d270d9d9f3c5
Reviewed-on: https://review.typo3.org/27462
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Improve revExplode performance 55/27255/5
Andreas Wolf [Sat, 1 Feb 2014 18:50:18 +0000 (19:50 +0100)]
[TASK] Improve revExplode performance

``GeneralUtility::revExplode()`` is implemented in a very
performance-intensive way: it always does a complete cycle with multiple
array operations, be it necessary or not.

To make the method more performant, it is split into different cases.
Currently, the only used value for the ``$count`` in the core is 2, but
we have to implement all others, too, of course. The performance
increase for $count=2 is greater than 50%; the others will at maximum be
as bad as the old implementation, plus a very tiny overhead for checking
the value of ``$count``.

Change-Id: I79d9a87b790935415c636ee87e6a6db952e0baa4
Resolves: #55564
Releases: 6.2
Reviewed-on: https://review.typo3.org/27255
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] file_list: use t3-table & semantic HTML in localization 12/27512/4
Felix Kopp [Sun, 9 Feb 2014 13:17:28 +0000 (14:17 +0100)]
[TASK] file_list: use t3-table & semantic HTML in localization

Brings the central table mark-up and style definition "t3-table"
to file_list backend module. Thanks to the unification few lines
of duplicated css definitions can be tossed.

Also moves the localization icons into the html table row. This
is a semantic clean-up and gives every file entry one table row.
-> Buttons can be added to title cell since cell is always visible.

Note: RequireJS module is moved to EXT: file_list.

By hiding the flag icons from within html right away there
is no flashing between render & ready (JS hide()).

Change-Id: Ic84450b8327c9533037ea21054799d6ad9d8d74b
Resolves: #55810
Releases: 6.2
Reviewed-on: https://review.typo3.org/27512
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove old class files from ext:openid 07/27507/2
Christian Kuhn [Sun, 9 Feb 2014 11:48:06 +0000 (12:48 +0100)]
[TASK] Remove old class files from ext:openid

Removes old class files from ext:openid except the two
current entry points for _eid and _return.

Change-Id: Ibdeca07881aad92af28c9f0e81c42a4ee1b600c2
Resolves: #55808
Related: #47756
Releases: 6.2
Reviewed-on: https://review.typo3.org/27507
Reviewed-by: Oliver Klee
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Add unit tests for getFilesInDir() 10/27410/5
Michiel Roos [Fri, 7 Feb 2014 13:07:27 +0000 (14:07 +0100)]
[TASK] Add unit tests for getFilesInDir()

Change-Id: I740b4f481f05ac7bb32028739d534dbb1c41864c
Resolves: #55762
Releases: 6.2
Reviewed-on: https://review.typo3.org/27410
Tested-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Allow to render the same TS object twice 12/25512/7
Markus Klein [Tue, 19 Nov 2013 17:36:53 +0000 (18:36 +0100)]
[BUGFIX] Allow to render the same TS object twice

CONTENT/RECORDS elements prevent to render the same object twice.

Resolves: #53768
Resolves: #28745
Releases: 6.2, 6.1, 6.0
Change-Id: I30750f2dc848521999c3734129439d7f6f90aae1
Reviewed-on: https://review.typo3.org/25512
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Stefano Kowalke
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
5 years ago[TASK] Remove old class files from ext:recycler 05/27505/3
Christian Kuhn [Sun, 9 Feb 2014 10:54:39 +0000 (11:54 +0100)]
[TASK] Remove old class files from ext:recycler

Change-Id: I5d2233c5eb0860740e1858bf2f96a919fee26e5e
Resolves: #55804
Related: #47756
Releases: 6.2
Reviewed-on: https://review.typo3.org/27505
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[!!!][TASK] Set f:format.date format to system default 56/27456/7
Felix Kopp [Sat, 8 Feb 2014 13:12:24 +0000 (14:12 +0100)]
[!!!][TASK] Set f:format.date format to system default

TYPO3 configuration knows a global date format configuration
within the installation tool. See TYPO3_CONF_VARS/SYS/ddmmyy.

Use this global format as the default for all fluid based date
format outputs if not overwritten in place.

Change-Id: I508d7f61f63760aa1301f52663c432feeb539bf4
Resolves: #55790
Releases: 6.2
Reviewed-on: https://review.typo3.org/27456
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Type safe check for $BE_USER in index_ts.php 63/27463/3
Łukas Jurys [Sat, 8 Feb 2014 15:05:05 +0000 (16:05 +0100)]
[BUGFIX] Type safe check for $BE_USER in index_ts.php

Resolves: #41593
Releases: 6.2
Change-Id: I3863789ad2489055169f3f008cb4dac0085fde82
Reviewed-on: https://review.typo3.org/27463
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Reviewed-by: Michał Jankiewicz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove duplicated method in Rtehtmlarea\SelectImage 14/27414/4
Tymoteusz Motylewski [Fri, 7 Feb 2014 14:06:21 +0000 (15:06 +0100)]
[TASK] Remove duplicated method in Rtehtmlarea\SelectImage

fileList() of Rtehtmlarea\SelectImage is almost an exact copy
of the parent implementation from ElementBrowser.

The patch removes fileList() from SelectImage and merges changes
to ElementBrowser.

It also fixes some bugs in magic image selector from RTE:
* Missing columns
* Wrong links to info page
* Fix "import selection" option

Resolves: #55765
Releases: 6.2
Change-Id: I78cb23de16b9516f953628aad10cf548f558bfd7
Reviewed-on: https://review.typo3.org/27414
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] CSV-Download not working in IE and HTTPS backend 02/20902/4
Wouter Wolters [Sat, 18 May 2013 19:22:16 +0000 (21:22 +0200)]
[BUGFIX] CSV-Download not working in IE and HTTPS backend

When using a HTTPS backend the download of CSV is not
working in Internet Explorer browser versions lower then 9.
Add the needed header to fix this problem.

Change-Id: Iefa63fb37d57491fb73bfd504b6caed5b76c8cac
Resolves: #16491
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/20902
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] "t3-table" (Web>List) & tree sprites (AbstractTreeView) 38/27438/3
Felix Kopp [Sat, 8 Feb 2014 00:08:50 +0000 (01:08 +0100)]
[TASK] "t3-table" (Web>List) & tree sprites (AbstractTreeView)

Brings tree-level icons based on sprite icons utility for treeviews
and abstract tree view (e.g. Web>Info Localization, Web>Perm).

Refactors the Web>Perm permission matrix table and edit
view. Both are now based on table.t3-table unified CSS.

All individual CSS styles for Web>Perm are obsolete now
since only standard core styles are necessary and used.

Change-Id: Icd8bcc476891bc44107acfbe1b81bafd6fd4e3c0
Resolves: #55784
Related: #45502
Releases: 6.2
Reviewed-on: https://review.typo3.org/27438
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Spelling of namespace \TYPO3\CMS\Tstemplate 15/27415/4
Peter Niederlag [Fri, 7 Feb 2014 13:46:15 +0000 (14:46 +0100)]
[BUGFIX] Spelling of namespace \TYPO3\CMS\Tstemplate

In some places a wrong namespace \TYPO3\CMS\TsTemplate was used.
\TYPO3\CMS\Tstemplate is the correct namespace for the tstemplate
sysext.

This fixes a problem in links between TSOB and Template Analyzer.

Resolves: #55764
Releases: 6.2
Change-Id: Iad84baa842b68f18468c1ff6b92c75c09710815e
Reviewed-on: https://review.typo3.org/27415
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove old class files from ext:t3editor 60/27460/3
Christian Kuhn [Sat, 8 Feb 2014 14:22:20 +0000 (15:22 +0100)]
[TASK] Remove old class files from ext:t3editor

Change-Id: Id7cd8fdaecf663462b8d02a4bf2ca272293cea4f
Resolves: #55792
Related: #47756
Releases: 6.2
Reviewed-on: https://review.typo3.org/27460
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Wrong colspan in DatabaseRecordList 48/27448/5
Marcin Sągol [Sat, 8 Feb 2014 11:54:22 +0000 (12:54 +0100)]
[BUGFIX] Wrong colspan in DatabaseRecordList

If the List Module is in extended view, the colspan of the footer
is wrong if there are more than 20 records of a type.

Fix this by increasing the colspan with one if the List Module is
extended view.

Resolves: #55443
Releases: 6.2
Change-Id: I4c9a45cdab3d1c5267566663fbb6c7cbb702f32a
Reviewed-on: https://review.typo3.org/27448
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Default parameters in ExtensionUtility::registerModule 17/26717/3
Felix Kopp [Thu, 9 Jan 2014 10:34:28 +0000 (11:34 +0100)]
[TASK] Default parameters in ExtensionUtility::registerModule

Adds default parameter array() for controllerActions in registerModule.
This way an own main module group can be added with

\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule(
'VENDOR.' . $_EXTKEY,
'newMainGroup'
);

Change-Id: I1218a5069d7787f65e77d1d23a58d307461f7743
Resolves: #54869
Releases: 6.2
Reviewed-on: https://review.typo3.org/26717
Reviewed-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Add mapping between .pps, .ppsx and powerpoint 57/27457/5
matw [Sat, 8 Feb 2014 13:24:36 +0000 (14:24 +0100)]
[TASK] Add mapping between .pps, .ppsx and powerpoint

Add missing mapping between pps, ppsx
and the powerpoint application.

Resolves: #53833
Releases: 6.2
Change-Id: I9ecd8ec899bb24245326ca42a469ee41de9b2c79
Reviewed-on: https://review.typo3.org/27457
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix "action" labels in BE log 61/27361/2
Thorsten Kahler [Wed, 5 Feb 2014 15:28:55 +0000 (16:28 +0100)]
[BUGFIX] Fix "action" labels in BE log

Add missing label action_1_5 and fix label action_1_4.

Resolves: #55698
Releases: 6.2, 6.1
Change-Id: I7f04aaf9d8b53cbe3109dbf72f4fddb0c089e9ad
Reviewed-on: https://review.typo3.org/27361
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Jan Bartnik
Tested-by: Jan Bartnik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Add (>) icon to execute button (Scheduler) 51/27451/2
Felix Kopp [Sat, 8 Feb 2014 12:35:58 +0000 (13:35 +0100)]
[TASK] Add (>) icon to execute button (Scheduler)

Scheduler backend module comes with an execute button.
Add icon to the button.

Change-Id: I842683c4b332a87653474237a893dd65d5bd1b5d
Resolves: #55789
Releases: 6.2
Reviewed-on: https://review.typo3.org/27451
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Typo in drag-drop area 41/27441/3
Łukas Jurys [Sat, 8 Feb 2014 10:27:00 +0000 (11:27 +0100)]
[BUGFIX] Typo in drag-drop area

Fixed typo from
"Drop & Drop to upload files"
to
"Drag & drop to upload files"

Resolves: #55756
Releases: 6.2
Change-Id: I35ebde8ee46fe673764c25019551130810241677
Reviewed-on: https://review.typo3.org/27441
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Use count on storage after initialization of LazyObjectStorage 57/27357/2
Marc Bastian Heinrichs [Wed, 5 Feb 2014 12:42:32 +0000 (13:42 +0100)]
[BUGFIX] Use count on storage after initialization of LazyObjectStorage

The count in LazyObjectStorage for relation type HAS_MANY has
to use the count on storage items after initialization. Otherwise
the wrong count is returned for a not persisted storage.

Resolves: #54724
Releases: 6.2, 6.1, 6.0
Change-Id: I817ce86dde11b175e6a5765a8f6518770ba75f28
Reviewed-on: https://review.typo3.org/27357
Reviewed-by: Wouter Wolters
Reviewed-by: Nico de Haen
Tested-by: Nico de Haen
Tested-by: Peter Beernink
Reviewed-by: Stefan Neufeind
Reviewed-by: Marcin Sągol
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[TASK] Move TCEForms JS Code to external file - part 1 71/18971/5
Benjamin Mack [Tue, 2 Jul 2013 12:23:05 +0000 (14:23 +0200)]
[TASK] Move TCEForms JS Code to external file - part 1

Parts of the JavaScript code used in TCEforms is put
inline, coming from the PHP file. There is no concept of
using HTML5-data attributes  to store information.
Plus, most of the JS functions are inline in the HTML
output and called in onclick etc. handlers in the HTML
elements.

Thus, the functionality cannot be abstracted from the
markup, and the JS functionality cannot be cached by
the browser.

Previously, the JS functionality is based on plain
MSIE4-compatible JS code without any framework
(no prototype, jQuery etc), and are not in any namespace.

This approach extracts TCEforms JS code to an external
file (AMD module / RequireJS), and rewrite it to current
jQuery and JS standards. But since the JS code
of TCEforms is very complicated,
it is hard to do it all at once, and the task is split
into separate parts.

The beginning marks the functionality around select
fields in TCEforms, the functions for importing values
from the Element browser, from any other source.

The patch does this:

* Extract the static functions from the PHP code to
an external JS file, in a new RequireJS module named
"TYPO3/CMS/Backend/FormEngine.js"
* Add options that are page-specific (backPath,
formName, callback fn) to PHP so JS can access it.
* Add classes and data-attributes and remove
onclick... functionality in order to reduce the HTML
code and split the data from the logic.
* Functionality for icons like "move up" etc are rewritten
* Functionality for adding elements from a two-select
(like "Access" element in pages) is rewritten, using
CSS classes and data attributes.

By keeping the global variables for the old functionality,
the old functions still work as expected.

Resolves: #46357
Releases: 6.2
Change-Id: I3b9936143342d99eec3058cd55fefdb006060cd4
Reviewed-on: https://review.typo3.org/18971
Reviewed-by: Andreas Wolf
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Tested-by: Felix Kopp
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] "New page" wizard discloses existence of pages outside DB mount 32/22632/5
Nicole Cordes [Sat, 27 Jul 2013 21:13:06 +0000 (23:13 +0200)]
[BUGFIX] "New page" wizard discloses existence of pages outside DB mount

When creating a new page inside the top level of a DB mount which is
only a sub tree, the pages up and down from the DB mount root will be
displayed in the position selector if the logged-in user has read
permissions for these pages. This is unwanted information disclosure as
the permissions should not matter for pages which are outside the DB
mount.

Resolves: #18797
Releases: 6.2, 6.1, 6.0
Change-Id: I98008bc7f4308c9fb32dae645325e7cb1b44e413
Reviewed-on: https://review.typo3.org/22632
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Update Swift Mailer to 5.0.3 87/27387/2
Stefan Neufeind [Thu, 6 Feb 2014 20:23:04 +0000 (21:23 +0100)]
[TASK] Update Swift Mailer to 5.0.3

Change-Id: I2fdd722f56e69c2c6b2bae23d9944973eed3c066
Resolves: #55745
Releases: 6.2
Reviewed-on: https://review.typo3.org/27387
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] RTE MagicImage should use FAL processing API 63/23663/10
Stanislas Rolland [Fri, 31 Jan 2014 22:40:08 +0000 (17:40 -0500)]
[TASK] RTE MagicImage should use FAL processing API

The RTE magic still copies images to the old upload folder and
does not use the processed file functions of FAL.

This patch changes the RTE magic so storage 0 is not used any more
and that the FAL API is used for processing the images.

Resolves: #51807
Releases: 6.2
Change-Id: I07d609f9e638d79e785be4ebfd25631c70e3d141
Reviewed-on: https://review.typo3.org/23663
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Pass path instead of object to fileExistsInFolder 12/27412/2
Tymoteusz Motylewski [Fri, 7 Feb 2014 13:30:53 +0000 (14:30 +0100)]
[BUGFIX] Pass path instead of object to fileExistsInFolder

In ResourceStorage in the method getUniqueName second argument
passed to fileExistsInFolder should be string instead of object.

This fixes an exception thrown when trying to insert magic image
in the RTE.

Resolves: #55763
Releases: 6.2
Change-Id: I4ed624d4ea5a3602936cf8493052ef111a391990
Reviewed-on: https://review.typo3.org/27412
Reviewed-by: Michiel Roos
Reviewed-by: Marcin Sągol
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Remove rollover functionality from TMENU 96/27396/2
Benjamin Mack [Fri, 7 Feb 2014 08:12:52 +0000 (09:12 +0100)]
[TASK] Remove rollover functionality from TMENU

The TMENU code has "RO" functionality in its class.
This code might be used from TMENU_LAYERS, but
not from the core itself. The core should remove the
according places. If extensions need this functionality
they could implement their own menu functionality.

The patch itself just removes the functionality of
rollovers, which is currently not documented nor used.

The idea of the content object with its extProc classes
is outdated and should be replaced by hooks and/or
signal slots.

As all methods that are removed, are private, they can
IMHO be removed directly.

In a second patch, there will be a hook interface
in order to manipulate the items.

Releases: 6.2
Resolves: #55751
Change-Id: Ibd5862124a6f8bc9f06254234cfbf179893c27cc
Reviewed-on: https://review.typo3.org/27396
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Typo in TypoScriptFrontendController 03/27403/2
Markus Klein [Fri, 7 Feb 2014 09:44:53 +0000 (10:44 +0100)]
[BUGFIX] Typo in TypoScriptFrontendController

$this->typ needs to be $this->type

Resolves: #55753
Releases: 6.2
Change-Id: I5414de0a00b4d0b7adecd783243990397cccb0b7
Reviewed-on: https://review.typo3.org/27403
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[CLEANUP] $LANG->JScharCode() => quoteJSvalue() 80/27380/6
Michiel Roos [Thu, 6 Feb 2014 15:36:35 +0000 (16:36 +0100)]
[CLEANUP] $LANG->JScharCode() => quoteJSvalue()

Replace JscharCode() with GeneralUtility::quoteJSvalue()

Instead of making JavaScript use a String.fromCharCode, it will now use
a sanitized quoted string.

Change-Id: Idf81d5524d4bbb60b515670aa13648aa52064905
Resolves: #55009
Releases: 6.2
Reviewed-on: https://review.typo3.org/27380
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Update copyright year to 2014 92/27392/2
Michael Schams [Thu, 6 Feb 2014 23:52:26 +0000 (10:52 +1100)]
[TASK] Update copyright year to 2014

This patch updates the named constant TYPO3_copyright_year and
updates the second year number to the current year: 1998-2014.

Resolves: #55747
Releases: 6.2
Change-Id: If3b9d9b25b6ec6a7d2c8a0327dc7b330f0f09f8c
Reviewed-on: https://review.typo3.org/27392
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Add functional test cases to DataHandler (workspace) 41/27241/7
Oliver Hader [Sat, 1 Feb 2014 18:52:53 +0000 (19:52 +0100)]
[TASK] Add functional test cases to DataHandler (workspace)

In addition to the functional test cases for data handling in
live, these test cases re-use the test scenarios to check the
behaviour in a particular workspace.

The current assertions only check the current behaviour. Parts
that are identified as faults are marked out with the ignore
operator "\*" in the CSV files.

Thus, these tests shall be used to compare the current state
with the target state in combination with accordant bug-fixes
for workspace data handling.

Resolves: #55563
Releases: 6.2
Change-Id: I5e35f0f450093416e5165fc399da3b454715a5d7
Reviewed-on: https://review.typo3.org/27241
Reviewed-by: Peter Kuehn
Tested-by: Peter Kuehn
Reviewed-by: Jigal van Hemert
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Add CSS libs functionality for page renderer 63/27163/5
Benjamin Mack [Fri, 31 Jan 2014 10:20:47 +0000 (11:20 +0100)]
[TASK] Add CSS libs functionality for page renderer

As with JS libraries, the PageRenderer should support
CSS files that should be included above CSS files.
This is necessary for e.g. normalize.css

The patch also adds the same procedure for
"includeCSSLibs" as with "includeCSSLibs" for the
frontend.

Releases: 6.2
Resolves: #55474
Change-Id: I3451b8170daa4fc8cf08f4f96771bed53ac04cdc
Reviewed-on: https://review.typo3.org/27163
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] CE Table does not allow multiple css classes 61/27161/2
Benjamin Mack [Thu, 30 Jan 2014 16:57:34 +0000 (17:57 +0100)]
[BUGFIX] CE Table does not allow multiple css classes

When using the content element "table", a
field within the flexform shows the possibility
to add an additional css class for the table.
however only one css class can be added.
When adding "myclass1 myclass2" this is not
possible as the evaluation is too strict.

Releases: 6.2
Resolves: #55470
Change-Id: I697184398067add518e750054dd327e741a91de7
Reviewed-on: https://review.typo3.org/27161
Reviewed-by: Benjamin Kott
Tested-by: Benjamin Kott
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Only set FE user cookie if session data or user logged in 30/27230/8
Benjamin Mack [Sat, 1 Feb 2014 12:48:13 +0000 (13:48 +0100)]
[TASK] Only set FE user cookie if session data or user logged in

Currently the FE session cookie is set on every request
and since 4.2 the sessionID is generated again on every
request unless the user is logged in. This is implemented
for avoiding the security problem of the
session fixation (see #19831).

If an installation does not use FE session cookies at all,
an option (TYPO3_CONF_VARS->FE->dontSetCookie)
never sets the cookie.

As the current behavior for non-logged-in FE calls
is not usable, the behaviour is changed to only set
the cookie if the user is logged in or the session data
is modified. The last example is helpful for websites
with e.g. a shopping cart on non-logged-in pages.
Currently, if an extension is trying to implement the
latter, the extension needs to hook or XCLASS the
FrontendUserAuthentication class to set the cookie
whenever needed.

Additionally, the security problem still exists if the
cookie is not set by TYPO3 itself, that's why the
cookie can only be set if there is a valid entry in
fe_user_sessions.

if using external caching (e.g. reverse proxies),
a "unneeded" cookie is always set currently,
which extensions like EXT:moc_varnish or
EXT:cachinfo mock to only set the cookie
if needed.

The attached patch removes the default-setting
of a cookie in the frontend, and only triggers
the setcookie() function when sessionData is
added or a user is logged-in.

Resolves: #55549
Releases: 6.2
Change-Id: If478bc00c2c55dda0cc38a898a1288098891671f
Reviewed-on: https://review.typo3.org/27230
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[TASK] Use speaking keys for new menu types 66/26566/2
Francois Suter [Fri, 27 Dec 2013 15:47:01 +0000 (16:47 +0100)]
[TASK] Use speaking keys for new menu types

The new menu "categories-based tt_content menu" uses a "speaking" key
for its type. The same should be applied to the other new menu type
introduced in TYPO3 CMS 6.2 (i.e. categories-based page menu).

Resolves: #54611
Releases: 6.2
Change-Id: I489a528050dcfeef83c1919155a3b11e599b195c
Reviewed-on: https://review.typo3.org/26566
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Michiel Roos
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Ambiguous output of deprecated RTE properties upgrade wizard 69/27369/2
Stanislas Rolland [Thu, 6 Feb 2014 07:04:53 +0000 (02:04 -0500)]
[BUGFIX] Ambiguous output of deprecated RTE properties upgrade wizard

Either some deprecated properties were found, but the wizard was unable
to replace them all automatically, in which case the wizard should
report a failure, or no deprecated properties were found or there are
no more deprecated properties left after the update, in which cases the
wizard should report a success.

Resolves: #51364
Release: 6.2
Change-Id: Ifcddd75f8b257de8ca12038550816f158306d8b5
Reviewed-on: https://review.typo3.org/27369
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] RTE Linking with file upload fails when no folder is selected 23/27323/3
Stanislas Rolland [Tue, 4 Feb 2014 15:58:17 +0000 (10:58 -0500)]
[BUGFIX] RTE Linking with file upload fails when no folder is selected

Solution: Catch exceptions raised when the potential target folder or
the default user upload folder does not exist.

Resolves: #48512
Releases: 6.2
Change-Id: Ic0218f218b045562d0ea5499ac0440848ddf3028
Reviewed-on: https://review.typo3.org/27323
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Make FileExtensionFilter case insensitive 59/27359/4
tritum_rz [Wed, 5 Feb 2014 14:43:45 +0000 (15:43 +0100)]
[BUGFIX] Make FileExtensionFilter case insensitive

Resolves: #55359
Resolves: #55614
Releases: 6.2
Change-Id: I8aceb208ba2f28967f08e9ac458d9a9da3de507b
Reviewed-on: https://review.typo3.org/27359
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Icons of folder tree of RTE image dialogue are erratic 46/27346/2
Stanislas Rolland [Tue, 4 Feb 2014 20:49:54 +0000 (15:49 -0500)]
[BUGFIX] Icons of folder tree of RTE image dialogue are erratic

Solution: Use same logic as for the link dialogue

Resolves: #53259
Release: 6.2
Change-Id: I3c283536895edb849782da7159866992e3d3d051
Reviewed-on: https://review.typo3.org/27346
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] adjust configuration handling to #55569 50/27350/2
Felix Oertel [Wed, 5 Feb 2014 08:09:42 +0000 (09:09 +0100)]
[BUGFIX] adjust configuration handling to #55569

In #55569 we got rid of the empty TypoScript generated by
default. The configurationManager relies on the empty
arrays to be present, before merging. This patch removes
this necessity.

Resolves: #55687
Releases: 6.2
Change-Id: I7f5ec4f7d120ffa45c8b526817debbc5fd38fe4f
Reviewed-on: https://review.typo3.org/27350
Tested-by: Christian Weiske
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Check folder access for inline uploader 02/27302/5
Alexander Stehlik [Mon, 3 Feb 2014 18:57:23 +0000 (19:57 +0100)]
[BUGFIX] Check folder access for inline uploader

Before the inline drag and drop upload functionality to the default
upload folder is enabled it is made sure that the upload folder
is initialized and that the user is allowed to add files.

Resolves: #55628
Releases: 6.2
Change-Id: Ia18678dc432c6f0addea33aa0389db54297435e3
Reviewed-on: https://review.typo3.org/27302
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Set TYPO3 version to 6.2-dev 28/27328/2
TYPO3 Release Team [Tue, 4 Feb 2014 18:50:28 +0000 (19:50 +0100)]
[TASK] Set TYPO3 version to 6.2-dev

Change-Id: I19dc6d19251bc6bb7ab26d1b98d1ccf4a37c06d4
Reviewed-on: https://review.typo3.org/27328
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.0beta5 27/27327/2 TYPO3_6-2-0beta5
TYPO3 Release Team [Tue, 4 Feb 2014 18:49:56 +0000 (19:49 +0100)]
[RELEASE] Release of TYPO3 6.2.0beta5

Change-Id: If8aa7427548911d665cb84db21c0553b16a4b964
Reviewed-on: https://review.typo3.org/27327
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years agoRevert "[BUGFIX] Frontend Login not added to CSC anymore" 19/27319/3
Ernesto Baschny [Tue, 4 Feb 2014 10:39:52 +0000 (11:39 +0100)]
Revert "[BUGFIX] Frontend Login not added to CSC anymore"

This reverts commit 373a90b8600e37c0c70d3b0771d18385eca3f961

Benni is working on a better solution to the problem.

Related: #55557
Change-Id: I749ea9beb3879d7503294a51107a4a3855f0105e
Reviewed-on: https://review.typo3.org/27319
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Page tree filter couldn't filter for id or title anymore 17/27317/3
Ernesto Baschny [Tue, 4 Feb 2014 08:43:14 +0000 (09:43 +0100)]
[BUGFIX] Page tree filter couldn't filter for id or title anymore

Bug was introduced by #54265, one "(int)" was forgotten.

Releases: 6.2
Resolves: #55642
Change-Id: Ie56b36be9d2f11b46687c2966d84e49f301ffede
Reviewed-on: https://review.typo3.org/27317
Reviewed-by: Daniel Siepmann
Tested-by: Daniel Siepmann
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Frontend Login not added to CSC anymore 33/27233/2
Benjamin Mack [Sat, 1 Feb 2014 15:02:03 +0000 (16:02 +0100)]
[BUGFIX] Frontend Login not added to CSC anymore

As felogin has no dependency for CSS Styled Content
it registers itself via
ExtensionManagementUtility::addTypoScript()
and does not hook in after css_styled_content, because
CSS styled content itself hasn't been initialized at that
time. Thus, felogin needs to have a dependency on
css_styled_content in order to still work as before.

Additionally, some unnecessary TypoScript code
was removed / cleaned up at the same time.

How to reproduce:
Add a login CE and you'll get a yellow error
message. Apply the patch, and the form will
show up (you need to uninstall / install an
extension first in order to have the dependecy
resolving take place).

Releases: 6.2
Resolves: #55557
Change-Id: I81e590038c10e793538419523ba37d3b29700b48
Reviewed-on: https://review.typo3.org/27233
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move cursor::pointer to complete header area in IRRE 85/27285/3
Georg Ringer [Mon, 3 Feb 2014 06:05:24 +0000 (07:05 +0100)]
[TASK] Move cursor::pointer to complete header area in IRRE

The whole header is clickable, thererfore move the css rule
to this place.

Change-Id: Ia864faba4976fc5e2e84299a42e2661a9566be1c
Resolves: #55611
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/27285
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] PHP ext bcmath and gmp needed for openid 09/27309/2
Markus Klein [Mon, 3 Feb 2014 22:54:39 +0000 (23:54 +0100)]
[TASK] PHP ext bcmath and gmp needed for openid

Mention PHP extensions bcmath and gmp in INSTALL.md,
because openid requires one of them to be installed.

Resolves: #55635
Releases: 6.2
Change-Id: I6ab651d3cb863a570b82fc33231e746e897bee96
Reviewed-on: https://review.typo3.org/27309
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] DatabaseConnection::isConnected() should use ping() 47/26447/3
Markus Klein [Mon, 16 Dec 2013 11:22:37 +0000 (12:22 +0100)]
[TASK] DatabaseConnection::isConnected() should use ping()

In some rare cases the database connection might be down, but
DatabaseConnection still has isConnected set to TRUE.
A call to isConnected() simply returns the member variable's value.

Improve the getter to also ping() the database if the class thinks
it is connected to verify the connection state.

The other methods of the class will still use the member variable
and not the getter method to avoid a ping() to the database on every
database interaction.

Resolves: #54323
Releases: 6.2, 6.1
Change-Id: I6bf090e5ab5f1d5539319ff10a1fb224036c4634
Reviewed-on: https://review.typo3.org/26447
Reviewed-by: Bill Dagou
Tested-by: Bill Dagou
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] addModule after/before not working 84/27284/12
Michiel Roos [Sun, 2 Feb 2014 23:19:25 +0000 (00:19 +0100)]
[BUGFIX] addModule after/before not working

The cleaned up addModule() method no longer adds the module after a
module, when the target module does not exist.

Expected behaviour: module added to the list.

Observed behaviour: module not added at all.

Change-Id: Ie0d1d0c98f9c7dde81636a40eb18a3a7816392f6
Resolves: #55608
Related: #55122
Releases: 6.2
Reviewed-on: https://review.typo3.org/27284
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Use $x[n] instead of substr($x, n, 1) 36/27136/8
Michiel Roos [Wed, 29 Jan 2014 20:38:28 +0000 (21:38 +0100)]
[TASK] Use $x[n] instead of substr($x, n, 1)

Change-Id: Ib58894a67f0292b9d62da81511ce12d3f16590ef
Resolves: #55445
Releases: 6.2
Reviewed-on: https://review.typo3.org/27136
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Unused TDParams in ColumnsContentObject() 86/26686/4
Michiel Roos [Tue, 7 Jan 2014 23:12:55 +0000 (00:12 +0100)]
[BUGFIX] Unused TDParams in ColumnsContentObject()

TypoScript configuration for TDParams is assigned to the PHP variable
$TDParams which is never used. The rest of the method uses $TDparams.

Change-Id: Ice8cd2ad2b4f1a8d68d62c3f2cfc4cfec3c3c210
Resolves: #54824
Releases: 6.2
Reviewed-on: https://review.typo3.org/26686
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years agoRevert "[TASK] Style buttons / invert (UX Vision)" 06/27306/3
Ernesto Baschny [Mon, 3 Feb 2014 18:28:57 +0000 (19:28 +0100)]
Revert "[TASK] Style buttons / invert (UX Vision)"

This reverts commit de4811fc2d809917076d21fa1ceaebcd42b82946

This is not in line with the rest of the backend yet.
The "UX vision" is for after 6.2.

Change-Id: Iab8880163b0cb668237617b1260b4126b16d1cb3
Reviewed-on: https://review.typo3.org/27306
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years agoRevert "[BUGFIX] Button typography" 07/27307/2
Ernesto Baschny [Mon, 3 Feb 2014 18:33:09 +0000 (19:33 +0100)]
Revert "[BUGFIX] Button typography"

This reverts commit 590f76cc4b3bc86ee06fafc1a2a30f90d5b1d56c

This is not in line with the rest of the backend yet.
The "UX vision" is for after 6.2.

Change-Id: Iabb64ac3a278a3a3e1423283a9267aa5996343f1
Reviewed-on: https://review.typo3.org/27307
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Button typography 01/27301/2
Felix Kopp [Mon, 3 Feb 2014 13:43:28 +0000 (14:43 +0100)]
[BUGFIX] Button typography

Removes share font from buttons. The current font does
not render adequately.

Change-Id: I8d2a998275e52fbb831abb9046f3711e82acc401
Resolves: #55624
Releases: 6.2
Reviewed-on: https://review.typo3.org/27301
Tested-by: Markus Klein
Reviewed-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Framework Packages aren't sorted properly 00/27300/2
Thomas Maroschik [Mon, 3 Feb 2014 13:26:46 +0000 (14:26 +0100)]
[BUGFIX] Framework Packages aren't sorted properly

In the package dependency resolver, the method
buildDependencyGraph builds the dependency graph
first for the framework packages and afterwards
for all left packages.

The filtering if a package is a framework package
happens by comparing the package path with PATH_typo3
and a sysext folder contant. But as PATH_typo3 is
absolute and the package path from the package states
configuration is relative to PATH_site, this filter
does not work.

The patch changes the path to a relativ one.

Fixes: #55623
Releases: 6.2
Change-Id: I2f57dee433054463ebfd17aab5f76b19986c2747
Reviewed-on: https://review.typo3.org/27300
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Style buttons / invert (UX Vision) 65/27265/4
Felix Kopp [Sun, 2 Feb 2014 14:57:52 +0000 (15:57 +0100)]
[TASK] Style buttons / invert (UX Vision)

Styles all buttons in the backend similar to UX vision paper.
Inverts buttons colors and changes font-family.

This patch does not bring styling to primary button: orange
or secondary button: silver.

Change-Id: I273e76a02083aedca4c6759948172b418e990ede
Resolves: #55592
Releases: 6.2
Reviewed-on: https://review.typo3.org/27265
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Unify: TCE input / TCE readonly / input 69/27269/2
Felix Kopp [Sun, 2 Feb 2014 16:44:58 +0000 (17:44 +0100)]
[BUGFIX] Unify: TCE input / TCE readonly / input

Unify form input fields with TCE forms input fields with
TCE forms readOnly text.

Change-Id: If17a9477bcedad33745b5e093b338472365a81cf
Resolves: #55599
Releases: 6.2
Reviewed-on: https://review.typo3.org/27269
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] File upload directly in Doc-module is missing 37/27237/4
Frans Saris [Sat, 1 Feb 2014 15:44:43 +0000 (16:44 +0100)]
[BUGFIX] File upload directly in Doc-module is missing

Since the introduction of FAL the option to upload a file
directly in your form has disappeared.

With this change the upload posibility is back with some extras.
* progress is shown
* drag&drop of files
* multiple file upload

The options is can be disabled just like before in the
user settings and for each field in TCA.

foreign_selector_fieldTcaOverride.config.appearance.fileUploadAllowed = 0

The upload button is only shown for browsers that support
drag&drop upload. And only for FAL fields (sys_file_reference).

Resolves: #55545
Releases: 6.2
Change-Id: I4b984099095d7f66c3d37023cd6c547b2ff5d59f
Reviewed-on: https://review.typo3.org/27237
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] Rendering inline TCEforms without AJAX is broken 04/12904/4
Alexander Jahn [Thu, 19 Jul 2012 10:13:32 +0000 (12:13 +0200)]
[BUGFIX] Rendering inline TCEforms without AJAX is broken

When loading tt_content as an inline record WITHOUT using AJAX,
some additional broken fields are rendered.

Change-Id: Ia5aaec79d0fb7c3266ea4f3a0c04d65b1af4b201
Fixes: #39048
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/12904
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Add silent config upgrader for upgrade wizard settings 51/26451/5
Markus Klein [Mon, 16 Dec 2013 15:49:20 +0000 (16:49 +0100)]
[BUGFIX] Add silent config upgrader for upgrade wizard settings

Add a migration function to the SilentConfigurationUpgradeService which
takes care of migrating the old class names used for the Install Tool
Upgrade Wizard's information storage to the new (namespaced) class names.

Resolves: #54457
Releases: 6.2
Change-Id: Ib6edb9ec3a8a1dc4873eb38e9a08bc8107db31bb
Reviewed-on: https://review.typo3.org/26451
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Cleanup EM list utility 39/27239/5
Helmut Hummel [Sat, 1 Feb 2014 17:45:37 +0000 (18:45 +0100)]
[TASK] Cleanup EM list utility

The EM has a lot of code related prior to
the inclusion of package management.

This change does a small cleanup in
ListUtility and calling code to make
better use of the new API.

Resolves: #55562
Releases: 6.2
Change-Id: I7aa5f5204ed3552fec617f2cd9e65dac2009486f
Reviewed-on: https://review.typo3.org/27239
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] tabmenu: Get rid of mouseOver/mouseOut 70/27270/3
Stefan Neufeind [Sun, 2 Feb 2014 16:54:19 +0000 (17:54 +0100)]
[TASK] tabmenu: Get rid of mouseOver/mouseOut

Tabmenu so far used mouseOver/mouseOut to set CSS-classes.
This is replaced with :hover functionality.

Change-Id: Ie62c017bca7bf26b1d48f1ae02ebab45090f3263
Resolves: #55600
Releases: 6.2
Reviewed-on: https://review.typo3.org/27270
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Various PHP Warnings with invalid credentials 26/27126/5
Xavier Perseguers [Wed, 29 Jan 2014 13:54:37 +0000 (14:54 +0100)]
[BUGFIX] Various PHP Warnings with invalid credentials

When invalid credentials are entered in the Backend login form, various
PHP warnings are raised such as

    PHP Warning: Illegal string offset 'uid'

because $user is not an array.

Resolves: #55434
Releases: 6.2, 6.1
Change-Id: I62b85816ce04720ed9fd236965c3a6f55effd093
Reviewed-on: https://review.typo3.org/27126
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Duplicate method in base tests 72/27272/2
Christian Kuhn [Sun, 2 Feb 2014 18:43:28 +0000 (19:43 +0100)]
[TASK] Duplicate method in base tests

extbase BaseTestCase extends core BaseTestCase and overrides
inject() with a duplicate. Remove dupe.

Change-Id: I96ce01c9754ce57cb5d10e9a322a8c5acb950647
Resolves: #55606
Releases: 6.2
Reviewed-on: https://review.typo3.org/27272
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Very short lifetime for cache_pagesection 28/27228/3
Andreas Wolf [Sat, 1 Feb 2014 11:28:31 +0000 (12:28 +0100)]
[BUGFIX] Very short lifetime for cache_pagesection

The default lifetime for the cache_pagesection is not set, so the
overall default of 3600 is used. This leads to the information in there
being repeatedly generated, though it does seldom change (it only
consists of information in the rootline, TypoScript configuration,
conditions etc.). Therefore, the lifetime is increased by this patch
again to 30 days. The cache is cleared nonetheless when clearing "all
caches".

The default lifetime for this cache was unlimited prior to the
introduction of the caching framework.

Change-Id: I98b307f11779174110ea2d5d79027771b44c5098
Resolves: #39295
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/27228
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Oliver Klee
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
5 years ago[BUGFIX] Fix failing tests on OSX Mavericks 71/27271/3
Helmut Hummel [Sun, 2 Feb 2014 17:40:30 +0000 (18:40 +0100)]
[BUGFIX] Fix failing tests on OSX Mavericks

Resolves: #55603
Releases: 6.2

Change-Id: I27efb6d19f580eba455cde92dd76628f72dce536
Reviewed-on: https://review.typo3.org/27271
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Remove unneeded padding in page module 36/26936/3
Georg Ringer [Mon, 20 Jan 2014 06:32:52 +0000 (07:32 +0100)]
[TASK] Remove unneeded padding in page module

Removes excessive top margin above Web>Page backend layout
cells. Brings gridCells equal heights and bottom spacing. Replaces
full white borders with adequate margins.

Change-Id: Ic5e7d3279c4facd969f171280d881b5620df4be7
Resolves: #55150
Related: #39971
Releases: 6.2
Reviewed-on: https://review.typo3.org/26936
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Default active extension handling in package manager 26/27226/6
Christian Kuhn [Sat, 1 Feb 2014 19:28:58 +0000 (20:28 +0100)]
[TASK] Default active extension handling in package manager

Integrate the definition of packages that should be activated at
first installation and packages that are required for a minimal
usable system in the package manager.

There are now three possible properties in Classes/Package.php:

* protected - Package can not be uninstalled in em.
* partOfFactoryDefault - Package is activated at first installation.
* partOfMinimalUsableSystem - Package is activated if
  PackageStates.php is missing. extensionmanager and t3skin are
  affected here, if PackageStates.php is deleted, the install tool
  will create a new one with those packages activated, so the backend
  is "usable" enough to activate further packages.

Resolves: #53988
Releases: 6.2
Change-Id: I4f5d3f0a7d3bcf332d1e8e6c29156f93bae8029c
Reviewed-on: https://review.typo3.org/27226
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Style "Download" button - element information 67/27267/2
Felix Kopp [Sun, 2 Feb 2014 15:27:59 +0000 (16:27 +0100)]
[TASK] Style "Download" button - element information

Brings button style to "Download" link with download icon.

Change-Id: I4edae8b861d9c6f98f156d8b538031dd8ca8f62c
Resolves: #55597
Releases: 6.2
Reviewed-on: https://review.typo3.org/27267
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Add "action-edit-download" sprite icon 66/27266/3
Felix Kopp [Sun, 2 Feb 2014 15:22:34 +0000 (16:22 +0100)]
[TASK] Add "action-edit-download" sprite icon

Brings an icon for download action. Icon is based on the
action-edit-upload sprite icon.

Change-Id: I4327c85c14dea3b69d8184259c5ac8729396d2e8
Resolves: #55594
Releases: 6.2
Reviewed-on: https://review.typo3.org/27266
Reviewed-by: Cedric Ziel
Tested-by: Cedric Ziel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Follow-up: Buttons CSS definition 60/27260/4
Felix Kopp [Sun, 2 Feb 2014 11:55:05 +0000 (12:55 +0100)]
[TASK] Follow-up: Buttons CSS definition

Moves definitions to CSS/structure.
Also fixes right margin for a.t3-button.

Change-Id: Ib51e8b7e3c11e0a4cf474b6322aaeaed11c63b55
Resolves: #55588
Related: #55539
Releases: 6.2
Reviewed-on: https://review.typo3.org/27260
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Add functional test cases to DataHandler (live) 88/27188/13
Oliver Hader [Fri, 31 Jan 2014 11:50:32 +0000 (12:50 +0100)]
[TASK] Add functional test cases to DataHandler (live)

This change-set adds new functional tests for the DataHandler
to ensure the correct behaviour in the Live Workspace. The
difference to current functional tests is, that here a more
complete picture is checked in the database instead of only
particular ids and values.

The tests use a DataSet, which is basically only a CSV file
that hold the record values for required tables. These CSV
files can easily be modified by any spreadsheet application.
The "Scenario" DataSets are used to define the scenario each
test case is based on - the "Assertion" DataSets are used to
acutally assert that the correct processing was done in
the DataHandler.

Resolves: #54855
Releases: 6.2
Change-Id: I5d748cde04a70b9c158d09f9a0bd337ef809fd02
Reviewed-on: https://review.typo3.org/27188
Reviewed-by: Peter Kuehn
Tested-by: Peter Kuehn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Add possibility to resolve a default storage 45/26945/6
Steffen Ritter [Mon, 20 Jan 2014 17:33:28 +0000 (18:33 +0100)]
[TASK] Add possibility to resolve a default storage

Before FAL a default upload folder has been retrived by setting
$GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'] . 'user_upload'.
With FAL this even could be placed on a remote system. Furthermore
we do not won't users to fiddle around with path like that anymore.

Each Storage already provides "getDefaultFolder" meant for uploads.
But still, if there are several storages, there is no way to figure
out which storage should be the default one for uploads, if it is
legacy code or just not configurable.

This patch introduces the concept of a default storage as a flag
which can be set within the storage record. The automatic creation
of /fileadmin/ - storage will have this flag already set.

Resolves: #55177
Releases: 6.2
Change-Id: I6684670c5acb023bc26596e9a55ca84bb5c41b40
Reviewed-on: https://review.typo3.org/26945
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[FEATURE] Bring tree icons in line-height 74/24474/8
Felix Kopp [Mon, 7 Oct 2013 21:55:42 +0000 (23:55 +0200)]
[FEATURE] Bring tree icons in line-height

Adds taller tree icons to EXT:t3skin and put them into a new
sprite category "treeline".

This allows to use these icons without breaks in line-height of 1.5em.

Icons are 30px tall due to:

- line height: 18px = 12px * 1.5em
- Padding top+bottom: 12px = 6px * 2

Change-Id: I8a295dbf55b6847e89250c9c221259386aa362e6
Resolves: #52599
Related: #52501
Related: #49592
Releases: 6.2
Reviewed-on: https://review.typo3.org/24474
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[FEATURE] Add maximumRecords evaluation for TCA type 'check' 46/26946/9
Oliver Hader [Mon, 20 Jan 2014 18:09:21 +0000 (19:09 +0100)]
[FEATURE] Add maximumRecords evaluation for TCA type 'check'

Allow the max items evaluation for checkboxes by setting the
accordant 'eval' property in the field configuration in TCA.

This makes it possible to have only e.g. 5 records that have a
checkbox set system-wide or PID-wide. If an editor
sets a another checkbox in record #6, it gets reverted
until another record was unchecked.

Parameters are "maximumRecordsChecked" and
"maximumRecordsCheckedInPid".

$tcaFieldConf = array(
'type' => 'check',
'eval' => 'maximumRecordsChecked',
'validation' => array(
 'maximumRecordsChecked' => 5
)
);

Change-Id: Ic33571fec15dcc9f83a61e2409256cce7dae8b12
Documentation: #55188
Resolves: #55187
Releases: 6.2
Reviewed-on: https://review.typo3.org/26946
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[CLEANUP] Remove $language from Extbase custom statement 58/27258/5
Felix Oertel [Sun, 2 Feb 2014 10:35:08 +0000 (11:35 +0100)]
[CLEANUP] Remove $language from Extbase custom statement

The parameter $language in extbase's custom statement is not
used anywhere and does not make any sense in use with dbal.

Releases: 6.2
Resolves: #55580
Change-Id: I9c7edda24918b328da66872ef782a6d0e83b0fff
Reviewed-on: https://review.typo3.org/27258
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
5 years ago[BUGFIX] PropertyMapper does not work with class aliasses 78/26578/3
Frans Saris [Sun, 29 Dec 2013 21:18:17 +0000 (22:18 +0100)]
[BUGFIX] PropertyMapper does not work with class aliasses

Currently the property mapper uses the classnames found
in the the class property annotations to find the right
TypeConverter. But for class aliases this breaks as the
alias is used and not the original classname.

There was already a getClassNameForAlias call but this was
to early.

This change moves the getClassNameForAlias() call from
doMapping() to findTypeConverter().

Releases: 6.2, 6.1
Resolves: #54289
Change-Id: Ie4ab3deb3c192290db62ea06826870d2fadba8a7
Reviewed-on: https://review.typo3.org/26578
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Add maxitems for field "metadata" in TCA 12/27112/2
Fabien Udriot [Wed, 29 Jan 2014 06:20:39 +0000 (10:20 +0400)]
[BUGFIX] Add maxitems for field "metadata" in TCA

Value "maxitems" => 1 must be added to field
`metadata` since it has a one-to-one relation.

Change-Id: Ie8771809b952e3b2aa441fcb222a6a3db301655e
Releases: 6.2
Resolves: #55411
Reviewed-on: https://review.typo3.org/27112
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Reviewed-by: Frans Saris
Reviewed-by: Stefan Froemken
Reviewed-by: Ingo Schmitt
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] The newRecordLinkAddTitle text is not understandable 09/23509/11
Tomita Militaru [Fri, 8 Nov 2013 15:18:10 +0000 (17:18 +0200)]
[BUGFIX] The newRecordLinkAddTitle text is not understandable

Separate the create new record label and the foreign table title
with a colon.

Resolves: #17955
Releases: 6.2
Change-Id: I0869f53e1e5ba0b49ded81e1605494fc2b44fdb0
Reviewed-on: https://review.typo3.org/23509
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Extbase registers unneeded code for plugins 48/27248/4
Benjamin Mack [Sat, 1 Feb 2014 21:51:01 +0000 (22:51 +0100)]
[BUGFIX] Extbase registers unneeded code for plugins

Every time when an extension is registering an extbase
plugin (in ext_localconf.php), the call triggers some
additional TypoScript code, which is basically empty
and does some superfluous code.

The attached patch removes the code inside the
registration process in order to remove the memory
footprint and have a small impact on performance
when bootstrapping TYPO3.

On a frontend script (eID), this makes approx.
2% of the bootstrap process until TSFE kicks in.

Releases: 6.2
Resolves: #55569
Change-Id: I39b810d06be57f436a68afaa717d5ec214b8797b
Reviewed-on: https://review.typo3.org/27248
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
5 years ago[TASK] Style the "add irre item" button 21/27221/5
Frans Saris [Fri, 31 Jan 2014 22:23:13 +0000 (23:23 +0100)]
[TASK] Style the "add irre item" button

This changes styles the buttons to add a new irre item like
the button to add images to a content element.

This patch also unifies button styles.

Resolves: #55539, #53218
Releases: 6.2
Change-Id: Ib07e51cfc6b6675671e1c6a2afd7bb0ebe379e1e
Reviewed-on: https://review.typo3.org/27221
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] Layout of page tree filter function broken 31/27231/2
Marcel Wieser [Sat, 1 Feb 2014 12:52:39 +0000 (13:52 +0100)]
[BUGFIX] Layout of page tree filter function broken

Small CSS fix to overwrite general margin
of paragraph tags in page tree indicator bar.

Resolves: #55536
Releases: 6.2
Change-Id: I9a4766a7fbc22f6ab2506f8a12463f5695813205
Reviewed-on: https://review.typo3.org/27231
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[CLEANUP] Let CSS Styled content use new classnames 34/27234/2
Benjamin Mack [Sat, 1 Feb 2014 15:04:56 +0000 (16:04 +0100)]
[CLEANUP] Let CSS Styled content use new classnames

With TYPO3 6.0, includeLibs for classes with
Namespaces / autoloader is not needed anymore.

The patch cleans up the TypoScript of CSS Styled
Content in order to use the new namings and
the superfluous call to includeLibs.

Releases: 6.2
Resolves: #55558
Change-Id: I94558a24479f220ce0fbebb54bb2f8479085c61c
Reviewed-on: https://review.typo3.org/27234
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Add possibility creating accessible mock for abstract classes 15/25315/4
Marc Bastian Heinrichs [Tue, 12 Nov 2013 15:09:30 +0000 (16:09 +0100)]
[TASK] Add possibility creating accessible mock for abstract classes

Resolves: #53564
Releases: 6.0, 6.1, 6.2
Change-Id: If7d69e4f87e368c1eef672cb68f1af92d6ae501b
Reviewed-on: https://review.typo3.org/25315
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Wrong result on empty string globalString condition 79/21979/2
Marc Bastian Heinrichs [Fri, 5 Jul 2013 21:45:30 +0000 (23:45 +0200)]
[BUGFIX] Wrong result on empty string globalString condition

A TypoScript condition like
"[globalString = GP:anEmptyGetPostVarKey = ]" returns a false
value instead of the expected true value.

Fixes: #45183
Releases: 4.5,6.0, 6.1, 6.2
Change-Id: I114b702f4b5ae5f68236874325e82974a8ba6107
Reviewed-on: https://review.typo3.org/21979
Tested-by: Philipp Gampe
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[CLEANUP] Remove initialization of Module Menu 42/27242/2
Benjamin Mack [Sat, 1 Feb 2014 21:36:17 +0000 (22:36 +0100)]
[CLEANUP] Remove initialization of Module Menu

The module menu and its view are instantiated
on every backend call, BE AJAX call etc although
it is only needed in the backend.php file where
it instantiates itself automatically anyways.

The patch removes the call in init.php and
in the TYPO3 Bootstrap as it is not needed
anymore.

Releases: 6.2
Resolves: #55565
Change-Id: I67b6fb54380485d35c070867abf67e3ed416f004
Reviewed-on: https://review.typo3.org/27242
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Add stdWrap on value property of TEXT 45/26445/3
Markus Klein [Mon, 16 Dec 2013 09:45:14 +0000 (10:45 +0100)]
[BUGFIX] Add stdWrap on value property of TEXT

As discussed back in 2010, the value property of the TEXT content object
should have stdWrap functionality as well, if the HTML content object
is deprecated.

Today the 6.0 TSref already mentions stdWrap for value and
the HTML cObject has been removed with 6.0 as well.

This fix now finally adds the stdWrap.

Resolves: #54371
Releases: 6.2, 6.1, 6.0
Change-Id: I1b7068b3715bc9f8aa4608d5f746c16b70562f3b
Reviewed-on: https://review.typo3.org/26445
Reviewed-by: Benjamin Mack
Reviewed-by: Chris topher
Tested-by: Chris topher
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Cleanup and simplify class alias handling 36/27236/5
Helmut Hummel [Sat, 1 Feb 2014 15:24:16 +0000 (16:24 +0100)]
[BUGFIX] Cleanup and simplify class alias handling

There were several issues with the implementation
of class alias handling. Most importantly the
early instance alias cache depended on TYPO3_MODE
which in turn triggered a full class cache
initialization when this cache was missing in one
context.

Additionally eval() calls needed to be used in
certain situations and the building of the cache
files introduced additional complexity.

With this change the cache for early instances
is completely removed and replaced by a simple
setAliasFoClassName() call.

Resolves: #55559
Releases: 6.2
Change-Id: I59958419f28a4ff1d6de4add94ee611b56070068
Reviewed-on: https://review.typo3.org/27236
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Extract package dependency sorting to separate class 01/27101/6
Thomas Maroschik [Tue, 28 Jan 2014 17:17:42 +0000 (18:17 +0100)]
[TASK] Extract package dependency sorting to separate class

The Package Manager got pretty big due to the custom
dependency resolving algorithm of CMS. Further the
algorithm relied upon the presence of package objects
which might not be fully present yet during bootstrapping.

This patch extracts the dependency handling from the
Package Manager and adapts it to work only on the
package states configuration.

Resolves: #55404
Releases: 6.2
Change-Id: I00e7a3769378b48bd3f3c285ea2b3c6d824dd061
Reviewed-on: https://review.typo3.org/27101
Tested-by: Thomas Maroschik
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Use (int) instead of intval() or (integer) 40/26740/23
Jo Hasenau [Sat, 1 Feb 2014 20:49:09 +0000 (21:49 +0100)]
[TASK] Use (int) instead of intval() or (integer)

This patch replaces most of around 1600 occurrences of
intval() and every (integer) in the whole core.
Additionally it changes GeneralUtility::intExplode to use references
and typecasting as well.
Some occurrences of strstr() together with intval() have been replaced
with strpos() as well.
And some superfluous intval calls have been removed or reduced
to a single one i.e. for protected variables or before loops.
Patch updated after Core CGL decision from 30.01.2014

Resolves: #54265
Releases: 6.2
Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
Reviewed-on: https://review.typo3.org/26740
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Category fields are not available in Functional Tests 38/27238/3
Oliver Hader [Sat, 1 Feb 2014 15:47:19 +0000 (16:47 +0100)]
[BUGFIX] Category fields are not available in Functional Tests

The category fields are defined dynamically and added to the
extension table configuration. Since the database definitions
are created before modifying this configuration, the category
fields are not available in Functional Tests.

Resolves: #55560
Releases: 6.2
Change-Id: Ie59e544309184d475428bc298f126c2776b4b5e7
Reviewed-on: https://review.typo3.org/27238
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Update RequireJS to 2.10 24/27224/2
Benjamin Mack [Sat, 1 Feb 2014 10:02:57 +0000 (11:02 +0100)]
[TASK] Update RequireJS to 2.10

Replace the existing RequireJS code
with the latest version, which is backwards-
compatible and fixes some requireJS bugs.
See http://requirejs.org/docs/download.html#releasenotes

Releases: 6.2
Resolves: #55543
Change-Id: I8ef64858b762a93db0c032509f100235424c2d9a
Reviewed-on: https://review.typo3.org/27224
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Cleanup EXT/requiredExt handling 32/27232/4
Christian Kuhn [Sat, 1 Feb 2014 14:05:37 +0000 (15:05 +0100)]
[TASK] Cleanup EXT/requiredExt handling

LocalConfiguration setting EXT/requiredExt was obsoleted with the
new package manger, the setting is removed by the PackageStates
migration code in install tool already.

* Remove further mentions of this setting
* Adapt method in ExtensionManagementUtility
* Streamline and remove some related units tests
* Move deletion of requiredExt setting to silent update
* Adapt an em view helper to new API

Change-Id: Ie9593c9791893bb4fb0714032efbfc06808b0a35
Resolves: #55555
Releases: 6.2
Reviewed-on: https://review.typo3.org/27232
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Daniel Siepmann
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn