Packages/TYPO3.CMS.git
4 months ago[DOCS] Add missing semicolon in rst file 22/62322/5
Franz Holzinger [Wed, 13 Nov 2019 21:56:11 +0000 (21:56 +0000)]
[DOCS] Add missing semicolon in rst file

Releases: master, 9.5
Resolves: #89676
Change-Id: Id215d40c18b28cf9b36a32b33c9a5e88d7840f5f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62322
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
4 months ago[TASK] Update dependency CmsComposerInstaller 26/62326/3
Benni Mack [Thu, 14 Nov 2019 12:05:04 +0000 (13:05 +0100)]
[TASK] Update dependency CmsComposerInstaller

This package should be raised to 2.2.3 as
this provides PHP 7.4 compatible tests.

This means, that this package is now shipped
with TYPO3 Core for all tarballs/zip distributions.

Composer-based installations will receive
the update automatically when doing a full
composer update.

Resolves: #89681
Releases: master, 9.5
Change-Id: I06991249984c21e02d287e1536a358760d629a9d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62326
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Rename USER_INT related variables in TSFE 09/62309/3
Benni Mack [Wed, 13 Nov 2019 07:52:06 +0000 (08:52 +0100)]
[TASK] Rename USER_INT related variables in TSFE

The cryptic variables $INTiS_config and internal names are improved
by using "nonCacheable" as naming (everywhere where possible,
not modifying public API methods).

Resolves: #89660
Releases: master
Change-Id: Ia03b1d612f1787f3d927a3724d20cb06caeddc38
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62309
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Johannes Schlier
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[DOCS] Fix minor typos in form documentation 19/62319/4
Chris Müller [Wed, 13 Nov 2019 18:38:37 +0000 (19:38 +0100)]
[DOCS] Fix minor typos in form documentation

Some typos are fixed. Additionally the spelling of "customise" was
adjusted to en-us.

Resolves: #89674
Releases: master, 9.5
Change-Id: I982c8438405677b6435e38cad5f7dbb6a6e886f7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62319
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Use correct ViewHelper namespace in PHPDoc of SubmitViewHelper 15/62315/3
Tomas Norre Mikkelsen [Wed, 13 Nov 2019 10:14:31 +0000 (11:14 +0100)]
[BUGFIX] Use correct ViewHelper namespace in PHPDoc of SubmitViewHelper

In the PHPDoc's example of SubmitViewHelper a wrong namespace was used.
This adds the correct ViewHelper namespace `f:form.submit`.

Resolves: #89667
Releases: master, 9.5
Change-Id: I7b247ca22527f82eb788119c975d4a46d579a087
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62315
Tested-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Re-order Frontend Content building process 13/62313/4
Benni Mack [Wed, 13 Nov 2019 09:08:51 +0000 (10:08 +0100)]
[TASK] Re-order Frontend Content building process

This patch streamlines the execution code when a base page is generated
by moving all logic into a few smaller methods to separate the actual
"cacheable page" logic from the PageRenderer population process,
and also adds more documentation to the methods.

In addition, some minor adjustments (site language is now
always available in v10) can be made, as some unnecessary
code execution (e.g. divSection assigment and unsetting
"JScode" explicitly) are made

Resolves: #89663
Releases: master
Change-Id: Ic2ac15a9767f452a89bace0d95fdc6f7f09af922
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62313
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Trigger nightly test builds with more time in between 10/62310/2
Anja Leichsenring [Wed, 13 Nov 2019 08:22:20 +0000 (09:22 +0100)]
[TASK] Trigger nightly test builds with more time in between

Resolves: #89661
Releases: master, 9.5, 8.7
Change-Id: I0b6bd4336037ede11f4218f5c6868025173e4470
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62310
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Move page layout resolving into a separate class 06/62306/4
Benni Mack [Tue, 12 Nov 2019 15:50:03 +0000 (16:50 +0100)]
[TASK] Move page layout resolving into a separate class

The functionality "getData = pagelayout" resolves the
selected backend layout for the current page, which is
used in TypoScript quite frequently.

In order to use this in e.g. TypoScript conditions, this
functionality is now extracted into a separate class,
and multiple unit tests are added.

Resolves: #89655
Releases: master
Change-Id: I5f2af5ec692c0dd98712c8916a7dc2fed8836a95
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62306
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Add empty alt attribute to decorative images 04/62304/6
Michael Telgkamp [Tue, 12 Nov 2019 13:35:18 +0000 (14:35 +0100)]
[BUGFIX] Add empty alt attribute to decorative images

Decorative images should have an empty alt attribute to hide
them from screenreaders.
See https://www.w3.org/WAI/WCAG21/Techniques/failures/F38

This patch adds the attribute to the images generated by the
icon provider classes using <img> tags.

Resolves: #89653
Releases: master
Change-Id: Ie3186902db3d479b6f2e464fbb578425ced43898
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62304
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Put logic of fetching page content from cache into more readable format 05/62305/4
Benni Mack [Tue, 12 Nov 2019 13:53:56 +0000 (14:53 +0100)]
[TASK] Put logic of fetching page content from cache into more readable format

The process of checking if
a) the page content (or parts of the page incl. instructions for uncached objects)
b) the TypoScript parsing for this set up
is available in cache via locking is now cleaned up a bit by

a) calling TemplateService (pagesection cache) with the required parameter directly (internal)
b) moving the "take cached data and move it into the TSFE properties" into a smaller
method

Resolves: #89654
Releases: master
Change-Id: I65ba3aedab38616194cbefdf7c51524a24a29643
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62305
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use Environment API to fetch application context 47/62247/4
Benni Mack [Fri, 8 Nov 2019 08:39:50 +0000 (09:39 +0100)]
[TASK] Use Environment API to fetch application context

The application context is stored in the Environment class since TYPO3 v9,
which is the correct place instead of GeneralUtility::getApplicationContext().

Resolves: #89631
Releases: master
Change-Id: I55de17ef3b9cbd0962a2c604913c736bd52ac6d3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62247
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[DOCS] Fix broken link in fluid_styled_content docs 97/62297/3
Jan [Mon, 11 Nov 2019 14:53:09 +0000 (14:53 +0000)]
[DOCS] Fix broken link in fluid_styled_content docs

Fixed a broken link which points to the "register extension key" page.

Releases: master, 9.5
Resolves: #89642
Change-Id: I5a5408b0690a0d3949cf27136ead1223a12a0304
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62297
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Use consistent checks for USER_INT logic 03/62303/4
Benni Mack [Tue, 12 Nov 2019 13:27:24 +0000 (14:27 +0100)]
[TASK] Use consistent checks for USER_INT logic

A few places in TYPO3 Core do manual checks if there
are non-cacheables on a page, which could be simplified
by just using the $TSFE->isINTincScript() method.

In addition, a safer check for a NON-empty INTincScript
value is used, instead of just a typecheck of array.

Resolves: #89652
Releases: master
Change-Id: I24b2b55b3705927720e36181926cf6e752bf0f66
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62303
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Move preparation of non-cacheable headerdata into TSFE 02/62302/4
Benni Mack [Tue, 12 Nov 2019 12:08:57 +0000 (13:08 +0100)]
[TASK] Move preparation of non-cacheable headerdata into TSFE

In order to centralize USER_INT ("non-cacheables") into TSFE logic,
some functionality is moved into TSFE regarding headerData,
JS and CSS inclusions.

Resolves: #89651
Releases: master
Change-Id: Ib0f6daa2306f6cba90f27db6baff5bae38403842
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62302
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Fix exception in IpAnonymizationTask after upgrade from TYPO3 8 00/62300/2
Stephan Großberndt [Tue, 12 Nov 2019 08:59:43 +0000 (09:59 +0100)]
[BUGFIX] Fix exception in IpAnonymizationTask after upgrade from TYPO3 8

This patch adds a cast to the property `$mask` before handing it over to
`IpAnonymizationUtility::anonymizeIp()` as this method requires `$mask`
to be an `int`. This is necessary as when the task was created and saved
in TYPO3 8 it was serialized as `string`.

Resolves: #89646
Releases: master, 9.5
Change-Id: Ie0745028882991204bfa5c25ec1a4bbb7955b7c2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62300
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[DOCS] Fix minor typo in changelog 94/62294/2
Sebastian Klein [Mon, 11 Nov 2019 10:29:02 +0000 (10:29 +0000)]
[DOCS] Fix minor typo in changelog

The word 'The' was misspelled.

Additionally, the readability of the last sentence was slightly improved.

Releases: master
Resolves: #89637
Change-Id: I21c76732ef5572b26fc5762b5445ba3612aabaf6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62294
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Listen to message when setting an avatar 92/62292/2
Andreas Fernandez [Mon, 11 Nov 2019 07:52:47 +0000 (08:52 +0100)]
[BUGFIX] Listen to message when setting an avatar

Due to the IRRE rewrite done in #88182 the avatar selection for backend
users broke, since the Setup module doesn't use FormEngine, yet.

The controller now adds dedicated JavaScript to listen to the
`typo3:elementBrowser:elementInserted` message sent by the Element
Browser to set the file reference uid correctly.

Resolves: #89634
Related: #88182
Releases: master
Change-Id: I5e6a56b35891ab380634540e9ed5ef0b3a96f082
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62292
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Remove dots from piVars set by _DEFAULT_PI_VARS 46/58846/12
Georg Ringer [Mon, 5 Nov 2018 17:57:34 +0000 (18:57 +0100)]
[BUGFIX] Remove dots from piVars set by _DEFAULT_PI_VARS

Make it possible to set defaults vars for plugins based on the
AbstractPlugin.

Resolves: #17283
Releases: master
Change-Id: Ic066fcf46f299554289e30eddf4529121c088881
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58846
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Move field "description" to SEO tab in page properties 02/62102/11
Kevin Appelt [Thu, 24 Oct 2019 16:27:41 +0000 (18:27 +0200)]
[TASK] Move field "description" to SEO tab in page properties

The description field is one of the most important fields
for SEO. When EXT:seo is installed, the description field can
be found on the SEO tab of the page properties. If EXT:seo
is not installed, the field will still be on the Metadata tab.

Resolves: #86516
Releases: master
Change-Id: I9d31f74bcc6e7f0f88a39e718b8437e2f92b30e6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62102
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Fix CGL in tests (static calls) 68/62268/2
Susanne Moog [Sun, 10 Nov 2019 06:49:40 +0000 (07:49 +0100)]
[TASK] Fix CGL in tests (static calls)

Resolves: #89630
Releases: master
Change-Id: I00021fb1aaf64f2fcc9ee5c8557837c1c90cff4d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62268
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Add fallback identifier to IRRE fields 65/62265/3
Susanne Moog [Sat, 9 Nov 2019 19:50:29 +0000 (20:50 +0100)]
[BUGFIX] Add fallback identifier to IRRE fields

In case of IRRE in site context not the full form engine variables
are available - therefor a fallback has been implemented.

Resolves: #89628
Releases: master, 9.5
Change-Id: I0c499d41354e4dc369f5a53f2109d8559b5e3bcb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62265
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Remove htmlspecialchars from path_Workspace 23/59023/9
Devid Messner [Tue, 4 Dec 2018 09:20:51 +0000 (10:20 +0100)]
[BUGFIX] Remove htmlspecialchars from path_Workspace

Remove htmlspecialchars in GridDataService
for path_Workspace and path_Live.

Resolves: #87069
Releases: master, 9.5
Change-Id: I1d5eff4b62ea9657efbe3c88c4a61b8e1b7cf1e3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59023
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Move clipboard inline JavaScript into separate modules 41/62041/2
Andreas Fernandez [Tue, 22 Oct 2019 08:27:20 +0000 (10:27 +0200)]
[TASK] Move clipboard inline JavaScript into separate modules

This patch moves the inline JavaScript for clipboard handling into a
separate module that is re-used in record list and in file list.

Additionally, the function `editList` only used in record list context
has been moved into the according module.

Resolves: #89476
Releases: master
Change-Id: I43c972aadd8cd097850139813a01c3560a9b202c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62041
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[TASK] Consistent version restrictions for PSR packages 60/62260/6
Aimeos [Sat, 9 Nov 2019 13:11:53 +0000 (13:11 +0000)]
[TASK] Consistent version restrictions for PSR packages

    composer require "psr/http-message":"^1.0"
    composer require "psr/log":"^1.0"

Releases: master
Resolves: #89626
Change-Id: Ieeceddba8ea49da1eac66f113f1c22623f479582
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62260
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] IRRE: Create a correct original value identifier 95/62195/4
Andreas Fernandez [Tue, 5 Nov 2019 12:43:37 +0000 (13:43 +0100)]
[BUGFIX] IRRE: Create a correct original value identifier

The value of `data-table-unique-original-value` was accidentally of type
array. This causes runtime errors since a string is expected.

This patch now creates a proper value passed to FormEngine to handle the
original unique value.

Resolves: #89588
Related: #87711
Releases: master, 9.5
Change-Id: I9184aa025f01196d0c206b5b86c712dc1049487f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62195
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[DOCS] Extend migration example of deprecation 84993 47/61947/3
Jörg Kummer [Thu, 10 Oct 2019 19:27:22 +0000 (19:27 +0000)]
[DOCS] Extend migration example of deprecation 84993

Change a variable name in migration example for
getPagesTSconfig().

Adds further migration example for getPagesTSconfig() when
retrieving a single value.

Releases: master
Resolves: #89394
Change-Id: I0180126cd531335a7775425d1f350587dd5f7be0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61947
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[FEATURE] Show link to online docs in extension manager 32/62032/8
Georg Ringer [Fri, 18 Oct 2019 23:51:28 +0000 (19:51 -0400)]
[FEATURE] Show link to online docs in extension manager

The export of extensions provided by https://extensions.typo3.org
has been extended with the link to the documentation.

This link is now shown in the list and detail view of extensions
in the extensions manager.

Resolves: #89458
Releases: master
Change-Id: If1439bd7b97d9c60c2811716edef97a6e4ed870d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62032
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Respect language restrictions for direct page title editing 37/60837/8
Gianluigi Martino [Wed, 29 May 2019 12:30:57 +0000 (14:30 +0200)]
[BUGFIX] Respect language restrictions for direct page title editing

If the user has no access to edit the title of the page due to language
restrictions, the pencil next to the title in the page module is
no longer visible.

Resolves: #88337
Releases: master, 9.5
Change-Id: Ia41821dd82821ad2c8d5a60dd053a43cadb0c361
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60837
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Make GifBuilder calculation of filename hash faster 34/62234/4
Benni Mack [Wed, 6 Nov 2019 22:11:57 +0000 (23:11 +0100)]
[BUGFIX] Make GifBuilder calculation of filename hash faster

The GifBuilder calculation does not need all of setup
to calculate the values for the filename.

Therefore, only the relevant parameters are used, making
the shortMD5 call faster, according to the ticket author.

Resolves: #64158
Releases: master
Change-Id: I9ffd1e1f8a14c8f3904e83f251122225562de606
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62234
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[BUGFIX] Allow usage of uid in slug generation via Ajax 70/62170/3
Johannes Schlier [Thu, 31 Oct 2019 12:04:37 +0000 (13:04 +0100)]
[BUGFIX] Allow usage of uid in slug generation via Ajax

This commit adds an option to the slug input type which allows it
to use the uid of a record when the update slug button is pressed
in the FormEngine.

Resolves: #89560
Releases: master, 9.5
Change-Id: Id645714f1b26e20e511022d1c74ea793964ffa19
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62170
Reviewed-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[FEATURE] Page title providers visible in admin panel 16/61116/9
Riny van Tiggelen [Fri, 21 Jun 2019 15:23:39 +0000 (17:23 +0200)]
[FEATURE] Page title providers visible in admin panel

The PageTitleProviders are now visible within the adminpanel debug panel.
Since this information is in no way available when the page is cached,
there's a message to view the page in uncached mode.

Resolves: #88609
Releases: master
Change-Id: I15b3187fb219ea488ea88950906545391994bc24
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61116
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Set default controller name in ExtbasePluginEnhancer 59/59659/4
Oliver Hader [Thu, 7 Feb 2019 09:05:15 +0000 (10:05 +0100)]
[BUGFIX] Set default controller name in ExtbasePluginEnhancer

The `defaultController` setting is only applied if both `action` and
`controller` parameters are empty. In Extbase context it happens that
only `action` is defined, but `controller` is empty (since linking to
the very same controller, just changing the action).

The behavior now is the following:
* set `action` and `controller` parameters to default if not given
* set `controller` parameter to default if not given

Resolves: #87337
Releases: master, 9.5
Change-Id: I3ee730f6bc665808c59cc07907467aa98c2de21a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59659
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Log invalid hash generation in FAL Indexer 93/59893/6
Susanne Moog [Thu, 7 Mar 2019 09:37:43 +0000 (10:37 +0100)]
[BUGFIX] Log invalid hash generation in FAL Indexer

The FAL Indexer uses the driver to get a hash for a file. In certain
circumstances (and with 3rd party drivers) the hash generated might be
null or invalid. In that case the ResourceStorage now throws an
exception to alert the developer to the wrong return value. At the same
time the Indexer catches and logs the exception to not interrupt the
whole indexing flow because of it.

For more information, please take a look at the ticket.

Resolves: #66397
Releases: master
Change-Id: I0f97cd23127e96b6d94161a9296750cbe3421075
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59893
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Consider all elements in typo3temp/assets/ when clearing 79/62179/6
Oliver Hader [Sun, 3 Nov 2019 11:15:09 +0000 (12:15 +0100)]
[BUGFIX] Consider all elements in typo3temp/assets/ when clearing

Only first level elements were considered when clearing assets in
typo3temp/assets/ using corresponding functionality in maintenance
section of the TYPO3 install tool.

Resolves: #89569
Releases: master, 9.5
Change-Id: I9237aa3c6200b57cf4da256531b25062f52708ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62179
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Add clarification and tests to SiteBasedRedirectResolver 15/59815/19
Benni Mack [Sat, 9 Nov 2019 13:35:52 +0000 (14:35 +0100)]
[TASK] Add clarification and tests to SiteBasedRedirectResolver

The original issue for endless redirect loops is already fixed via
https://forge.typo3.org/issues/88032
whereas the query does not result in 307's anymore.

Additional information on redirects is added as comment.

Resolves: #87814
Releases: master, 9.5
Change-Id: I8c97b85cc30d217fe793608da1f26be52e8f68dc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59815
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Make EXT:backend independent of EXT:install 99/61999/3
Daniel Siepmann [Tue, 15 Oct 2019 11:22:54 +0000 (13:22 +0200)]
[BUGFIX] Make EXT:backend independent of EXT:install

EXT:backend generates a URL to EXT:install, but has no dependency. This
can lead to composer setups with EXT:backend but without EXT:install,
leading to an exception while generating route.

Therefore a suggest is added as a hint to install also EXT:install.
Existing code is wrapped with an try / catch in order to work under both
circumstances.

Resolves: #89419
Releases: master, 9.5
Change-Id: Idedd299f218ae8f7ba9938800d2ac4a0c4e5614b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61999
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Karavas Aristeidis <aristeidis.karavas@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Decode tag attributes during HTML parsing 99/61799/9
Helmut Hummel [Tue, 24 Sep 2019 14:09:43 +0000 (16:09 +0200)]
[BUGFIX] Decode tag attributes during HTML parsing

When parsing HTML in parsefunc, we need to make sure
that the attributes that are extracted for further processing
are properly HTML decoded, as per definition they are encoded in
the HTML being parsed.

At the same time we revert a decode that was applied in ExternalUrlLinkBuilder,
as this is the wrong place to handle HTML decoding, as the link builder
is as well called with data from other contexts (TypoScript, data from link fields)
that must not have the URL HTML encoded.

This fix is required to allow email links to add subject and body arguments like:
test@foo.test?subject=foo%20bar&body=baz

and not have the ampersand in the url double encoded when generating links
from RTE content.

Additionally we need to properly encode the masked value for the JavaScript
URI, to prevent browsers from url decoding wrong values.

Releases: master, 9.5
Resolves: #89264
Related: #81625
Related: #80985
Change-Id: I3be2478df83cffc0dfe6af918eb224b4ee480b10
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61799
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[FEATURE] Use SiteLanguageAwareInterface to check for trait existence 93/61893/3
Christian Eßl [Sat, 5 Oct 2019 11:55:29 +0000 (13:55 +0200)]
[FEATURE] Use SiteLanguageAwareInterface to check for trait existence

In AspectFactory::enrich(), the function would use class_uses() to
determine, if an aspect uses the trait SiteLanguageAwareTrait. This
however would only work on classes that use this trait, not on classes
that inherit the class with the trait (For example XClasses).
To fix this, a SiteLanguageAwareInterface was introduced, which is
checked against.

Resolves: #87380
Releases: master
Change-Id: I55e90d40ec592dc15564c49f9437e7a2640ffb0d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[FEATURE] Provide a way to sort form lists in ext:form 96/61896/5
Christian Eßl [Sun, 6 Oct 2019 09:04:51 +0000 (11:04 +0200)]
[FEATURE] Provide a way to sort form lists in ext:form

Forms in ext:form were previously not sorted in any manner, but just
outputted in the order they were read from the filesystem's directories.

Forms can now be sorted by multiple keys in either ascending or
descending order.
Two new yaml settings were introduced: `sortByKeys` and `sortAscending`.

Resolves: #87798
Releases: master
Change-Id: I2aae2e79cbd39394040a5b1280469a756bf0c7ca
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61896
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Deactivate link element's explanation toggle after change 22/61422/9
Michael Straschek [Fri, 2 Aug 2019 22:13:53 +0000 (00:13 +0200)]
[BUGFIX] Deactivate link element's explanation toggle after change

Dynamically fetching/applying additional data for the link explanation
seems to be overdone, so we simply deactivate the toggle button and
remove the icon after selection/modification of the link target.
After persisting the record, the updated link explanation
will be visible.

Resolves: #88737
Releases: master, 9.5
Change-Id: I679abb2178aedfc8a29cccace99950a3a8acaab6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61422
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] RTE: Support anchors without `href` 24/60324/7
Thorben Nissen [Sun, 24 Mar 2019 16:06:07 +0000 (17:06 +0100)]
[BUGFIX] RTE: Support anchors without `href`

Removes enforcing of href attribute when storing RTE text into the
database. Removes adding of absolute scheme on a tags without href
attribute, when loading text from the database. Changes
ContentObjectRenderer::typolink to render a tag without href anyway, if
id or name attribute is present.
Adds unit tests.

Resolves: #87992
Releases: master, 9.5
Change-Id: I4dcd33e6f13dc6a1f364c96b425aa2f241653ae9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60324
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Use indexed menu item array for directory menu 62/61962/6
Alexander Stehlik [Fri, 11 Oct 2019 18:06:08 +0000 (20:06 +0200)]
[BUGFIX] Use indexed menu item array for directory menu

This prevents overwriting existing entries when a mount point
and its target have the same parent.

Resolves: #89402
Releases: master, 9.5
Change-Id: I1e527443410e0f875a95e803d4c3c026b089f5a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61962
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Reenable input field for page ID when setting a link via RTE 94/61194/7
Ioulia Kondratovitch [Sat, 29 Jun 2019 20:49:18 +0000 (22:49 +0200)]
[BUGFIX] Reenable input field for page ID when setting a link via RTE

Remove obsolete dot to make following setting work again:
RTE.default.buttons.link.pageIdSelector.enabled = 1

This now renders an input field for a page ID again when setting
a link via RTE.

Resolves: #88656
Releases: master, 9.5
Change-Id: I25a9cd20fd269f3f4f683ee6474f424897601a86
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61194
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Substitute form references for array keys as well in ext:form 90/61890/2
Christian Eßl [Sat, 5 Oct 2019 08:43:21 +0000 (10:43 +0200)]
[BUGFIX] Substitute form references for array keys as well in ext:form

In ext:form, string placeholders, like "{text-1}", can be used inside
the finisher to place form inputs, made by the user, inside fields like
the email subject, reploy to email and name, etc. These string
substitutions however were not done for array keys (only array values).

Resolves: #88550
Releases: master
Change-Id: I727850f3e15479215b56be4cd136d93644b0d435
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61890
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[TASK] Add forceUid option to Import Command 16/59416/4
Martin [Fri, 11 Jan 2019 17:46:58 +0000 (18:46 +0100)]
[TASK] Add forceUid option to Import Command

Add possibility to force UIDs from Command Line
when importing a t3d/xml file.

Releases: master
Resolves: #87414
Change-Id: I2117079fb0a4af46355448256750978075749fb3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59416
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[FEATURE] Support nomodule for JavaScript includes 08/58908/13
Guido Schmechel [Fri, 16 Nov 2018 22:42:53 +0000 (23:42 +0100)]
[FEATURE] Support nomodule for JavaScript includes

Add the property 'nomodule="nomodule"' to JavaScript files via TypoScript
page.includeJSlibs.<array>.nomodule = 1

This patch affects the TypoScript PAGE properties
* includeJSlibs
* includeJSFooterlibs
* includeJS
* includeJSFooter

Resolves: #86759
Releases: master
Change-Id: I88db40ac973c17148a87504998f1070eba8d74af
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58908
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[TASK] Deprecate \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController 62/62162/9
Alexander Schnitzler [Wed, 30 Oct 2019 18:53:58 +0000 (19:53 +0100)]
[TASK] Deprecate \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController

The AbstractController is an internal class which never
really had any functionality than to provide some basic
method for the ActionController.

If users implemented their own controllers and
extended the AbstractController directly, the further
execution led to an exception. Unless people used the
AbstractController and implemented the missing logic
of the ActionController themselves, they didn't have
a functional controller, therefore it's safe to assume
that nobody extends the AbstractController directly.

To be on the safe side however, the AbstractController
is properly deprecated and will not be removed until
TYPO3 11.0.

People are - and always have been - encouraged to
extend the ActionController.

Releases: master
Resolves: #89554
Change-Id: I86a45621f4d32249f94deec0d932a930d3a9824f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62162
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[FEATURE] Mark broken file links in RTE 91/62091/8
Sybille Peters [Thu, 7 Nov 2019 12:23:30 +0000 (13:23 +0100)]
[FEATURE] Mark broken file links in RTE

Broken file links are now marked in RTE with yellow background and red
border.

This patch uses the previously introduced event
:php:`BrokenLinkAnalysisEvent`.

The broken links are only detected if linkvalidator is installed and
has checked for broken links (e.g. via scheduler).

Resolves: #84990
Releases: master
Change-Id: Iddebe7f9358901c70f90f9751298ce2905684662
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62091
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
4 months ago[BUGFIX] Respect richtextConfiguration set via TCA 93/61193/12
Ioulia Kondratovitch [Sat, 29 Jun 2019 19:48:59 +0000 (21:48 +0200)]
[BUGFIX] Respect richtextConfiguration set via TCA

If richtextConfiguration is set via TCA for a specific text field
(e.g. for custom elements or within TCA-overrides),
respect the richtextConfiguration and prefer it over the general
RTE.default.preset

Removed 'richtextConfiguration' => 'default' from tt_content, since it is obsolete and breaks the logic of fallback.

New fallback order:
1. preset defined for a specific field via PageTS
2. richtextConfiguration defined for a specific field via TCA
3. general preset defined via PageTS
4. default

Resolves: #88655
Releases: master
Change-Id: I54271732ba862be4c05ccf62352ee685d72fb985
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61193
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update doctrine/dbal to minimum ^2.10 59/62259/3
Susanne Moog [Sat, 9 Nov 2019 09:55:54 +0000 (10:55 +0100)]
[TASK] Update doctrine/dbal to minimum ^2.10

    composer require doctrine/dbal:"^2.10"

Releases: master
Resolves: #89625
Change-Id: I1f0591d2544c34d1785c3cd3ee4b8a6d6643885f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62259
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add additional workspaces tests covering enable fields 55/62255/8
Oliver Hader [Fri, 8 Nov 2019 16:32:02 +0000 (17:32 +0100)]
[TASK] Add additional workspaces tests covering enable fields

Resolves: #89623
Releases: master, 9.5
Change-Id: Ibb2738c792173e8f40f0c98350629754379b74cb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62255
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Use correct icon for menu separator if hidden in menu 50/62250/3
Karsten Nowak [Fri, 8 Nov 2019 11:50:00 +0000 (12:50 +0100)]
[BUGFIX] Use correct icon for menu separator if hidden in menu

Now pages of doktype "menu separator" are using the correct icon
if `nav_hide` is set.

Resolves: #89615
Releases: master, 9.5, 8.7
Change-Id: I0d63b82e7e073fe12be6e073b0b364b5296f6ddf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62250
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Respect cacheHash excludedParameters in TSFE::reqCHash() 96/60296/22
Grigory Rechkin [Mon, 18 Mar 2019 12:32:05 +0000 (17:32 +0500)]
[BUGFIX] Respect cacheHash excludedParameters in TSFE::reqCHash()

* Requests with a parameter from "excludedParameters" settings
  will not raise a cHash comparison error
* Requests with configured enhancers will not raise the
  "Page ID is missing" error when used with additional parameters

Resolves: #87845
Releases: master, 9.5
Change-Id: I4312aa790d6660e0e7f9214841fe3d27c5f1b4ea
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60296
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
4 months ago[DOCS] Fix RTE preset example 51/62251/2
Daniel Siepmann [Fri, 8 Nov 2019 12:22:06 +0000 (13:22 +0100)]
[DOCS] Fix RTE preset example

The example for overwriting preset of a single field for specific type
(e.g. CType) was wrong. This is now fixed.

Also All examples were modified to create a better readable list to be
read from less specific to most specific with separated examples for
syntax and real world usage.

Resolves: #88858
Releases: master, 9.5
Change-Id: I759a606360b4e612e734cf70b7b992718d683dc9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62251
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Prevent indexing of XML sitemaps by search engines 53/62253/3
Chris Müller [Fri, 8 Nov 2019 13:41:22 +0000 (14:41 +0100)]
[BUGFIX] Prevent indexing of XML sitemaps by search engines

The content of a XML sitemap should not be listed on search engine result
pages. This patch adds the HTTP header "X-Robots-Tag:noindex" to the
XML sitemaps.

Resolves: #89617
Releases: master, 9.5
Change-Id: I307b15ebcb26973846edc17f9b46562c1d38db45
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62253
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
5 months ago[TASK] Extend TCA shadowColumns instead of overriding them 56/62256/2
Oliver Hader [Fri, 8 Nov 2019 17:00:18 +0000 (18:00 +0100)]
[TASK] Extend TCA shadowColumns instead of overriding them

ext:irre_tutorial is extending corresponding TCA settings now.

Resolves: #89624
Resolves: master, 9.5, 8.7
Change-Id: I943a343d37808b38c4c6b14164e12380cc316dba
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62256
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[BUGFIX] Don't escape decimal character group 20/62120/3
Matthias Vogel [Fri, 25 Oct 2019 19:09:23 +0000 (21:09 +0200)]
[BUGFIX] Don't escape decimal character group

Resolves: #87471
Releases: master, 9.5, 8.7
Change-Id: I0d139369c5ddc3acd8acbd278fe9841961002ca0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62120
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
5 months ago[TASK] Avoid using deprecated Doctrine types 49/62249/4
Oliver Hader [Fri, 8 Nov 2019 11:07:50 +0000 (12:07 +0100)]
[TASK] Avoid using deprecated Doctrine types

Issue #89592 upgraded Doctrine to v2.10.0 - usages of deprecated
`TYPE::*` constants have not been adjusted (see doctrine/dbal
changelog https://github.com/doctrine/dbal/releases/tag/v2.10.0).

Resolves: #89592
Releases: master
Change-Id: Ic7aacf5041f22016876ed9daae4d167b0d15c493
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62249
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[BUGFIX] Remove references to "alternativeTempPath" 54/62254/3
Benni Mack [Fri, 8 Nov 2019 13:57:38 +0000 (14:57 +0100)]
[BUGFIX] Remove references to "alternativeTempPath"

The previous TypoScript option "alternativeTempPath"
was removed some years ago (before 6.2), but the option
was still present in tsref.xml, which is now
removed.

Resolves: #89618
Releases: master, 9.5, 8.7
Change-Id: I9d97ef0afb8cf0f10329a68fbf1eaaed48661412
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62254
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[BUGFIX] Pluralize term dynamically 74/62174/2
Oliver Bartsch [Fri, 1 Nov 2019 11:21:37 +0000 (12:21 +0100)]
[BUGFIX] Pluralize term dynamically

This adds a static method `pluralize` to dynamically pluralize
a term which changes during runtime to prevent a grammatically
wrong number.

Resolves: #89565
Releases: master, 9.5
Change-Id: Ib335d610bf680d2e4ecb494b19a99534e59e2ebb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62174
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Fix PHPDoc of BackendUtility::getRecordLocalization 00/62200/6
Tomita Militaru [Tue, 5 Nov 2019 22:16:24 +0000 (23:16 +0100)]
[BUGFIX] Fix PHPDoc of BackendUtility::getRecordLocalization

Now the return annotation states out that an empty array will
be returned if no localized records can be found and FALSE only
if the table is not localizable.

Resolves: #89584
Releases: master
Change-Id: Ibd2d1c345b79eb099c935604151a7972e755085f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62200
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Kevin Ditscheid <kevin@the-coding-owl.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Kevin Ditscheid <kevin@the-coding-owl.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
5 months ago[TASK] Update doctrine/dbal to 2.10.0 03/62203/4
Manuel Selbach [Wed, 6 Nov 2019 10:49:51 +0000 (11:49 +0100)]
[TASK] Update doctrine/dbal to 2.10.0

With this change the new release of doctrine/dbal will be applied,
which will solve different bugfixes and introduce some new features.

For further information:

https://github.com/doctrine/dbal/releases/tag/v2.10.0

Resolves: #89592
Releases: master, 9.5
Change-Id: I30151e51372f1ecf349c28de78678924dc58dfc0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62203
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[BUGFIX] Fix tests in ConditionMatcher regarding applicationContext 43/62243/4
Benni Mack [Thu, 7 Nov 2019 21:17:18 +0000 (22:17 +0100)]
[BUGFIX] Fix tests in ConditionMatcher regarding applicationContext

The applicationContext tests were only checking
the string "applicationContext" and not the actual
object that was injected by the provider.

The change adapts the tests to make them actually
useful.

Resolves: #89612
Releases: master, 9.5
Change-Id: I1a155fa81817d42a8b4bd2ce853e0a0ed863c3e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62243
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[FEATURE] Make site title configurable per website language 01/62101/9
Richard Haeser [Thu, 24 Oct 2019 14:54:40 +0000 (16:54 +0200)]
[FEATURE] Make site title configurable per website language

The site title can now be configured with the site module instead of
using the sys_template record. If you don't need localized site titles
you can also set the title on a site base.

The site title in the sys_template record is deprecated now and will be
used as a fallback in v10.

Resolves: #85592
Releases: master
Change-Id: I1caea88ef9bb7c1a4550d68bff1ede91b6f5cb2a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62101
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: Chris Müller <typo3@krue.ml>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Chris Müller <typo3@krue.ml>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
5 months agoRevert "[TASK] Speed up DB query for tables with versions" 09/62209/2
Oliver Hader [Wed, 6 Nov 2019 19:13:52 +0000 (20:13 +0100)]
Revert "[TASK] Speed up DB query for tables with versions"

This reverts commit 98c74eb212b728db2818c256994c501a6173ab7b.

The change resulted in AJAX timeouts when dealing with lots of
database records on MySQL 5.6 - it was fine however on MySQL 5.7.

Reverts: #86945
Resolves: #89464
Releases: master, 9.5, 8.7
Change-Id: Ied400255186f5e72521d3318521c3edb0f4f7784
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62209
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[TASK] Enable php 7.4 for runTests.sh script 40/62240/2
Anja Leichsenring [Thu, 7 Nov 2019 15:06:18 +0000 (16:06 +0100)]
[TASK] Enable php 7.4 for runTests.sh script

The newly provided docker image with php7.4 can now
be used to execute tests with this PHP version.

Resolves: #89609
Releases: master, 9.5
Change-Id: Ia6309b50045a181502f880d029bc0ac1dcb9bf0a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62240
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Explicitly initialize DateTime picker for form fields 97/62197/3
Andreas Fernandez [Tue, 5 Nov 2019 13:51:40 +0000 (14:51 +0100)]
[BUGFIX] Explicitly initialize DateTime picker for form fields

The InputDateTimeElement now takes an element identifier to initialize a
field as a date time picker. The DateTimePicker module now uses an
optional element identifier to render the date time picker.

Resolves: #89586
Related: #87324
Releases: master
Change-Id: I65727fe503fed65b28e38f64b1a44b619087b937
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62197
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Johannes Schlier
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Johannes Schlier
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[FEATURE] Mark broken external links in RTE 47/56947/34
Sybille Peters [Sat, 12 May 2018 20:55:57 +0000 (22:55 +0200)]
[FEATURE] Mark broken external links in RTE

Before this change, only broken page links were marked
in RTE.

In general: If a broken link is to be marked in the RTE, extra
markup is automatically added by the transform db -> RTE function.
This will cause the broken link to stand out (yellow background
with red border).

With this patch the behaviour was extended to marking "external"
links as well. External links are checked by linkvalidator, using
existing linkvalidator table of broken links

In order to enable the external link checking, a new PSR-14 Event
has been defined. This makes the behaviour consistent and
configurable.

The link checking can also be done by other external extensions
using the introduced Event.

Performance considerations:

If installed, linkvalidator is used to check external links.
The implementation does not do the external link checking on
the fly by submitting a HTTP request to external webservers,
but uses the information already gathered in linkvalidator
tx_linkvalidator_link table instead. Thus, one DB query is
necessary for each link that is checked.

Resolves: #84990
Releases: master
Change-Id: Ic5992ab6238449b43b5c243dc0c45527ed9d0b48
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/56947
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Update Guzzle to latest version (6.4.1) 37/62237/2
Benni Mack [Thu, 7 Nov 2019 08:54:36 +0000 (09:54 +0100)]
[TASK] Update Guzzle to latest version (6.4.1)

Guzzle is our HTTP fetching library, which should
be updated to the latest version due to some
bugfixes regarding cookie handling.

Executed command:
composer update guzzlehttp/guzzle --with-all-dependencies

Resolves: #89602
Releases: master, 9.5
Change-Id: Ice5cbf96b5459b451872be6ff0ac11661b0e39b4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62237
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Improve accessibility of backend login 11/62211/3
Georg Ringer [Wed, 6 Nov 2019 20:21:26 +0000 (21:21 +0100)]
[BUGFIX] Improve accessibility of backend login

To improve the accessibility of the backend login,
the following changes are applied:

- Remove wrong role from login news
- Add aria-label to the input fields

The color contrast of the login button (white text on
orange background) needs to be tackled in a different commit
as it requires a lot of changes in other areas as well.

Resolves: #89596
Releases: master, 9.5
Change-Id: I31fc62c8f3e8f151b7172cf502842b0d2510b401
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62211
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
5 months ago[BUGFIX] SysLanguageViewHelper fetches proper DB connection 33/62233/2
Benni Mack [Wed, 6 Nov 2019 21:38:50 +0000 (22:38 +0100)]
[BUGFIX] SysLanguageViewHelper fetches proper DB connection

A simple copy/paste error fetches a wrong DB connection when having
multiple database connections configured.

Resolves: #89598
Releases: master, 9.5
Change-Id: I38b67a0a361e2ee00959aa0e6aa17a015aaf541d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62233
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[BUGFIX] Streamline SoftReferenceIndex references 96/62196/8
Nicole Cordes [Tue, 5 Nov 2019 13:20:07 +0000 (14:20 +0100)]
[BUGFIX] Streamline SoftReferenceIndex references

This patch streamlines the return values for softref type typoscript and typoscript_tag. Furthermore tests for the API method findRef() are added to ensure same return results.

Furthermore  a non-reachable part in findRef_typolink_tag is removed. As the incoming content is split by <a> tags, the <LINK> tag condition within this function will be never fulfilled.

Resolves: #88207
Related: #87652
Releases: master, 9.5
Change-Id: Ifca40c5d0e049c5b5d92a507a9d5ec0249e9953e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62196
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[DOCS] Fix explanation of content element TypoScript example 81/62181/5
Alexander Vidoni [Sun, 3 Nov 2019 14:24:21 +0000 (14:24 +0000)]
[DOCS] Fix explanation of content element TypoScript example

The example makes use of a reference, not a copy. This is now reflected
by the text.

Releases: master, 9.5
Resolves: #89571
Change-Id: I5d039de75f48b7524a32b036ec8d4d071b60d6f2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62181
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[TASK] Rename TSconfig labels section in page properties 02/62202/2
Tomita Militaru [Tue, 5 Nov 2019 22:54:15 +0000 (23:54 +0100)]
[TASK] Rename TSconfig labels section in page properties

"TypoScript Configuration" renamed to "Page TSconfig"
"Include Page TSconfig (from extensions)" renamed to "Include static
Page TSconfig (from extensions)".

Resolves: #89164
Releases: master
Change-Id: I815524f32c7668350c9959a011adf598eb4be3d1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62202
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] OtherLanguageContent: show fallback language icon 32/61432/5
Josef Glatz [Sat, 3 Aug 2019 13:57:58 +0000 (15:57 +0200)]
[BUGFIX] OtherLanguageContent: show fallback language icon

Since the default language can be different from site
configuration to site configuration, "flags-multiple" icon
is used instead of the fallback "default-not-found" icon
when no default language is configured (e.g. when editing
a translated sys_file_metadata record in filelist module).

Resolves: #88909
Releases: master
Change-Id: Ie755cc06b43e4b735000ab598f14853773d58ced
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61432
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
5 months ago[TASK] Remove mod.web_func filter in InfoPageTyposcriptConfigController 40/61340/3
Daniel Windloff [Tue, 23 Jul 2019 08:14:12 +0000 (10:14 +0200)]
[TASK] Remove mod.web_func filter in InfoPageTyposcriptConfigController

The func module has been removed. The according PageTsConfig filter
has been removed as well.

Resolves: #88821
Releases: master
Change-Id: I9ab509f518ab87e68a0e0c7d7fe91fdf7041493e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61340
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
5 months ago[TASK] Cleanup \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\ColumnMap 83/62083/6
Alexander Schnitzler [Tue, 29 Oct 2019 10:49:53 +0000 (11:49 +0100)]
[TASK] Cleanup \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\ColumnMap

This commit cleans up the ColumnMap class by removing
unused, superfluous methods and constants and by defining
the visibility of class constants and by adding references
to the TCA documentation.

Releases: master
Resolves: #89490
Change-Id: I3abecc0671312e75147e3a9a3213864f9d9b12bc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62083
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>
5 months ago[BUGFIX] Have backend layouts in DB respect workspace versions 01/60501/7
Benni Mack [Wed, 17 Apr 2019 19:52:09 +0000 (21:52 +0200)]
[BUGFIX] Have backend layouts in DB respect workspace versions

Resolves: #24737
Releases: master, 9.5
Change-Id: I5a5f1b0a26951266a0e90c46af670602247693e5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60501
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Susanne Moog <look@susi.dev>
5 months ago[BUGFIX] Remove 2nd double quotes from exception messages 93/62193/3
Daniel Siepmann [Tue, 5 Nov 2019 08:54:16 +0000 (09:54 +0100)]
[BUGFIX] Remove 2nd double quotes from exception messages

There were two double quotes within two exception messages.
That could lead to irritation whether one was part of header name
respectively the display condition string.

Resolves: #89583
Releases: master, 9.5
Change-Id: Idbe6efc296e1d064b14806fc248c2a23c9dadf24
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62193
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Check parsed url for query part in BE Shortcuts 78/62178/4
Oliver Bartsch [Sun, 3 Nov 2019 11:13:22 +0000 (12:13 +0100)]
[BUGFIX] Check parsed url for query part in BE Shortcuts

This change adds null coalescing operators at multiple places
in `ShortcutRepository` to avoid type errors if the shortcut url
doesn't contain a query part (e.g. coming from legacy URLs
when a TYPO3 v7 installation was migrated).

Resolves: #89533
Releases: master, 9.5
Change-Id: I9bd1bdf0cf2f8d8954c4bf9eada6c720f2103af1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62178
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
5 months ago[TASK] Initialize TSFE language at an earlier stage 83/62183/3
Benni Mack [Mon, 4 Nov 2019 09:12:22 +0000 (10:12 +0100)]
[TASK] Initialize TSFE language at an earlier stage

The languageService and pageRenderer instantiate their
language / locale information at a very late point, allowing
to only use TSFE's language features when TypoScript was loaded.

However, since TYPO3 v10, the SiteLanguage information is always
present in an earlier stage, so the initialization can happen earlier.

Resolves: #89575
Releases: master
Change-Id: Id9dc8268946041353430cb02e12631b048364acf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62183
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
5 months ago[BUGFIX] Add lang attribute to html tag in Backend 69/62169/6
Georg Ringer [Thu, 31 Oct 2019 11:16:38 +0000 (12:16 +0100)]
[BUGFIX] Add lang attribute to html tag in Backend

The current language of the TYPO3 Backend user is now added as
attribute 'lang' to the html tag of any module using the ModuleTemplate.

This improves accessibility, as it is used by screen readers that switch
language profiles to provide the correct accent and pronunciation.

In addition, DocumentTemplate behaves the same by adding
proper htmlspecialchars()

Resolves: #89559
Releases: master
Change-Id: I42132e24475b4aa7decbf5173e3717297eda897e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62169
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[BUGFIX] Fix stdWrap.replacement boolean properties handling 45/58945/3
Wolfgang Klinger [Sat, 24 Nov 2018 18:51:23 +0000 (19:51 +0100)]
[BUGFIX] Fix stdWrap.replacement boolean properties handling

Cast the properties useRegExp and useOptionSplitReplace
to boolean and fix the if condition logic.

Resolves: #85015
Releases: master, 9.5
Change-Id: I99b7bd1b793e1dfbd7584fe539eee878e39acbfd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58945
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] SoftReferenceIndex parses new TypoLink format correct 10/57610/18
Rémy DANIEL [Mon, 16 Jul 2018 11:21:49 +0000 (13:21 +0200)]
[BUGFIX] SoftReferenceIndex parses new TypoLink format correct

Since the introduction of the new TypoLink format like t3://page?uid=1
the SoftReferenceIndex is parsing these TypoLinks wrong, and does not
parse t3://record at all.

This patch adds the same parsing of typolinks than the one done by
LinkService, and removes old and duplicated code.

This patch also fixes the missing softref when a typolink contains an
anchor to a tt_content.

The signal `getTypoLinkParts` is removed from execution, because it
is not needed anymore, as all is handled via LinkService
capabilities directly.

Resolves: #84016
Releases: master, 9.5
Change-Id: I4b83cd43af938de084aebc1b4bf424e6bb2d9682
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/57610
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Don't process ifEmpty/ifBlank stdWrap if content is available 28/58928/4
Wolfgang Klinger [Wed, 21 Nov 2018 19:32:32 +0000 (20:32 +0100)]
[BUGFIX] Don't process ifEmpty/ifBlank stdWrap if content is available

Resolves: #86969
Releases: master, 9.5
Change-Id: I75c7d5a5467871b0a40df605059c0ebd1bca0438
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58928
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[DOCS] Use correct filename in documentation of fluid styled content 80/62180/5
Alexander Vidoni [Sun, 3 Nov 2019 13:00:51 +0000 (13:00 +0000)]
[DOCS] Use correct filename in documentation of fluid styled content

Use correct filename (like in previous paragraph).

Releases: master, 9.5, 8.7
Resolves: #89570
Change-Id: Ieb34118a18c302746677e11b7f15ab02690d435a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62180
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[BUGFIX] Fix parameter descriptions of bulkInsert 77/62177/4
Oliver Bartsch [Sun, 3 Nov 2019 00:41:27 +0000 (01:41 +0100)]
[BUGFIX] Fix parameter descriptions of bulkInsert

The `$data` array can contain column-value pairs or just the values.
The `$columns` array only contains the column names.

Resolves: #89538
Releases: master, 9.5
Change-Id: Ieb24407321f6899d5271975430d72a1f8b92335e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62177
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Update Fluid Standalone to 2.6.6 56/62156/4
Benni Mack [Wed, 30 Oct 2019 11:57:18 +0000 (12:57 +0100)]
[TASK] Update Fluid Standalone to 2.6.6

A new fluid standalone version 2.6.6 reverted the changes
that had regressions in v2.6.5 and v2.6.4.

Composer command: composer req typo3fluid/fluid:^2.6.6

Resolves: #89542
Releases: master, 9.5, 8.7
Change-Id: I30a29a3cc07a277bd4a72e83a67a6c3260adc5d7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62156
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[FEATURE] Provide feature flag for new translation server's export 27/62127/4
Georg Ringer [Mon, 28 Oct 2019 12:45:04 +0000 (13:45 +0100)]
[FEATURE] Provide feature flag for new translation server's export

The feature switch `betaTranslationServer` makes it possible for users
to test and use the new translation server.

The integration is currently work in progress but will be finished before
the LTS release of version 10.
Once the work has been stabilized and tested well,
the feature flag will be removed for 10 and backported for 9.

Resolves: #89526
Releases: master
Change-Id: Ic88e4b6568dbe53cd88e63a8a1dd39787219e9e4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62127
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Properly trimExplode allowed file extensions in IRRE / FAL 55/62155/4
Benni Mack [Wed, 30 Oct 2019 10:21:09 +0000 (11:21 +0100)]
[BUGFIX] Properly trimExplode allowed file extensions in IRRE / FAL

When a custom FAL / sys_file_reference inline element is registered, and
there are custom allowed file extensions, the property "elementBrowserAllowed"
is not properly run through "GeneralUtility::trimExplode()", however, all other
places do this properly.

The changes moves the trimExplode to the correct place, so uploading
of files directly in FormEngine works properly.

Resolves: #89540
Releases: master, 9.5
Change-Id: I9a486f8c932078629761bd86cc1d9455120fc7a5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62155
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Gorges <daniel.gorges@b13.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.com>
Reviewed-by: Susanne Moog <look@susi.dev>
5 months ago[BUGFIX] Correctly check TSFE->rootLine 12/62112/3
Markus Klein [Fri, 25 Oct 2019 12:56:40 +0000 (14:56 +0200)]
[BUGFIX] Correctly check TSFE->rootLine

The existing check on the data-type of $rootLine has to be adjusted
since the default value is now an array.

Resolves: #89512
Related: #89482
Releases: master, 9.5
Change-Id: Ia1d673ff2fe1f45e615c5bc6c81b574b63ec2e54
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62112
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Allow redirects to specific records 28/62128/3
Benni Mack [Mon, 28 Oct 2019 15:18:57 +0000 (16:18 +0100)]
[BUGFIX] Allow redirects to specific records

Creating links to specific records (LinkHandler functionality) does require
a global TSFE object. In addition, calling LinkBuilder directly will
result in a fatal error when linking e.g. to EXT:news records.

Currently, this is not possible as the RedirectService is not prepared for this.

The patch modifies the places accordingly.

Resolves: #87574
Releases: master, 9.5
Change-Id: Iebda76bad0a2681df30f2ea4c42cfd3b5cd4a39f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62128
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
5 months ago[BUGFIX] Remove more options from LinkBrowser in redirects 31/62131/4
Georg Ringer [Mon, 28 Oct 2019 21:00:35 +0000 (22:00 +0100)]
[BUGFIX] Remove more options from LinkBrowser in redirects

Hide the following options in the LinkBrowser of a sys_redirect record
because those don't work for redirects and confuse users:

 - mail
 - folder
 - telephone

Resolves: #89532
Releases: master, 9.5
Change-Id: I6d540ce96bb6e6dc19e35454bf70aca099be09f9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62131
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Provide UpgradeWizard for outdated be_users uc settings 06/61906/8
Christian Eßl [Wed, 2 Oct 2019 19:07:21 +0000 (21:07 +0200)]
[BUGFIX] Provide UpgradeWizard for outdated be_users uc settings

Backend users each have a serialized array of individual user
configuration, called "uc" persisted in the be_users table.
Before TYPO3 9.5, the structure of this configuration could sometimes
contain stdClass objects, which is no longer supported. Logging in as
a backend user with such an outdated "uc" array would then crash several
parts of the TYPO3 backend, because the BackendUserConfiguration class
will try to access an stdClass type configuration like an array.

An UpgradeWizard called "BackendUserConfigurationUpdate" is now
provided, which allows to update any outdated "uc" structure of all
backend users.

Resolves: #89269
Resolves: #89268
Resolves: #86398
Releases: master, 9.5
Change-Id: Ic2158b34e70c7f931f4ef8acc8c39af618e241e9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61906
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Apply proper typecast 53/62153/3
Oliver Bartsch [Tue, 29 Oct 2019 07:26:38 +0000 (08:26 +0100)]
[BUGFIX] Apply proper typecast

All database result values must be proper typecasted
as database drivers may use and return different data types.

Resolves: #89531
Related: #56351
Releases: master, 9.5
Change-Id: I2e48bd548b178aa1e684db0ff908259cdfec377f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62153
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Patrick Broens <patrick@patrickbroens.nl>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Patrick Broens <patrick@patrickbroens.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[TASK] Consolidate cache clearing in TypoScript edit backend controllers 34/61834/3
Benjamin Franzke [Wed, 25 Sep 2019 08:33:47 +0000 (10:33 +0200)]
[TASK] Consolidate cache clearing in TypoScript edit backend controllers

The TypoScript editing module "Template" currently has different
cache flush behaviours, depending on *how* the data is being modified:

 a) The DataHandler cache command 'all' is triggered when a TypoScript
    constant is changed via the ObjectBrowser or ConstantEditor
    controllers and when a new sys_template record is created.

 b) Tag-based cache clearing in group 'pages' is performed by the
    DataHandler when a TypoScript template is edited via
    "Edit the whole template record" button.
    Note: This is because the edit functionality is using
    the plain record_edit FromEngine controller which means
    EXT:tstemplate controllers only act as proxy here.

Note that both cases are wrong for sys_template records:

 * Case a) flushes too many caches:
   The DataHandler cache command 'all' flushes TCA, ext_localconf and
   Dependency Injection caches – since #75581 even opcache caches.
   All these (performance relevant) caches are never influenced by
   TypoScript and must not be flushed in production systems
   (results in slow responses due to cache rebuilds).

 * Case b) flushes too few caches:
   A sys_template record influences (in 99.9% cases) the page tree.
   By flushing the record via DataHandler tag flushed there
   are two caches being flushed:
   * pageId_[pidOfSysTemplateRecord]
   * sys_template_[uidOfSysTemplateRecord]
   * sys_template
   Non of these tags are assigned to page caches that rely on this
   sys_template record.

There are two options to consolidate cache clearing:

 * Use DataHandler tag-based flushing as in case b).
   The drawback: generates *a lot* of cache tags which
   are then flushed very rarely.

 * Flush the 'pages' cache group in both cases. This variant
   flushes a bit too much (of course, tags are more precise),
   as pages which did not rely on a currently modified
   sys_template record are flushed as well.

This change implements the latter option as we think the drawbacks of
flushing a bit too much is better than the drawback of generating a
ton of cache tags.
As all cases where the cache command 'all' was used, already modify
sys_template though DataHandler processing, we can remove the previous
cache commands and move the flush logic for all cases into a hook that
is triggered by the DataHandler when records are being created/changed.

Releases: master
Resolves: #89280
Change-Id: I4b705398634048ccf9fb7fe53acf2eb15fa55562
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61834
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <look@susi.dev>
5 months ago[BUGFIX] Display most searched words again 19/61619/3
Devid Messner [Wed, 4 Sep 2019 14:14:24 +0000 (16:14 +0200)]
[BUGFIX] Display most searched words again

Resolves: #89079
Releases: master, 9.5
Change-Id: Iac9f58064a54fb64ae7fad82d35bbbbaecd2ae95
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61619
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
5 months ago[DOCS] Use working examples in linkvalidator documentation 00/61700/5
linawolf [Fri, 13 Sep 2019 03:16:15 +0000 (03:16 +0000)]
[DOCS] Use working examples in linkvalidator documentation

Fields without softref are not being checked. Since pages:media does not
have softref set in its TCA it will never get checked. Field pages:url
has an unresolved issue since 6 years. So better don't mention it as an
example for configuration until it works.

The default configuration also contains the two fields.

Releases: master, 9.5
Resolves: #89163
Change-Id: Ia9968ef297cedb3d09747acffa4ca07fff2fa0c2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61700
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
5 months ago[BUGFIX] Use strict type checking for in_array() calls in JsonView 11/62111/2
Markus Klein [Fri, 25 Oct 2019 11:42:59 +0000 (13:42 +0200)]
[BUGFIX] Use strict type checking for in_array() calls in JsonView

If the JsonView traverses array with numeric indexes and an exclude
configuration is set, the first array element is now handled correctly.

The comparison of array index 0 with a string within in_array() yields
TRUE, hence the first element was skipped.

Resolves: #89510
Releases: master, 9.5, 8.7
Change-Id: I38561f7fc05dcefaf23f9178d5ba987591ffaf45
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62111
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Florian Weiss <typo3org@leblanc.at>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Florian Weiss <typo3org@leblanc.at>
Tested-by: Susanne Moog <look@susi.dev>
5 months ago[BUGFIX] Backup last typolink URL before processing ATagParams 26/62126/6
Alexander Stehlik [Sun, 27 Oct 2019 10:35:24 +0000 (11:35 +0100)]
[BUGFIX] Backup last typolink URL before processing ATagParams

This prevents typolinks called in the stdWrap of ATagParams
from modifying the original link URL.

Resolves: #89521
Releases: master, 9.5
Change-Id: Ief6d7c8a7345bab16b98d840e31807e5ab07763d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62126
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Susanne Moog <look@susi.dev>