Packages/TYPO3.CMS.git
9 months ago[FEATURE] Auto create management DB fields from TCA ctrl 21/57121/45
Christian Kuhn [Mon, 4 Jun 2018 12:13:23 +0000 (14:13 +0200)]
[FEATURE] Auto create management DB fields from TCA ctrl

Adds a class that auto creates TYPO3 "management" related database
columns and indexes based on TCA 'ctrl' information without having
them specified in ext_tables.sql. The feature .rst file outlines
field details.

Goals:
* Save extension developers time.
* Less copy+paste issues and different general fields definitions.
* Reduce number of boilerplate fields in ext_tables.sql.
* Bring schema of management fields under core control.

Non goals:
* No full substitution of ext_tables.sql by TCA: "Business"
  fields from 'columns' are NOT created automatically. This
  would require further thoughts and code disentangling.
* No new extension API.
* No "migration" approach or similar.

Notable patch details:
* The patch is a revamped version of issue #81234 that has been
  abandoned. As requested in the review of #81234, the code now
  hooks in after ext_tables.sql has been parsed into the doctrine
  schema.
* Field defintions of ext_tables.sql take precedence, auto fields
  are only added if ext_tables.sql does not define a column or index.
  This makes the patch fully backwards compatible.
* No deprecation for obsolete field definitions in ext_tables.sql
  is logged.
* Many core fields are aligned to a central definition and slightly
  change. For instance "uid" is now always an unsigned int.
* Reduce all core's ext_tables.sql files as well as the functional
  testing related ext_tables.sql files down to the business fields
* A relatively huge series of test adaptions: Especially the
  ext:impexp related functionals now create dumps with differently
  sorted fields - This is no problem during import.
* Field t3_origuid of sys_file_reference has never been registered
  in TCA as ['ctrl']['origUid'], is thus unused and removed as obsolete.
* The extension manager no longer applies possible destructive changes,
  it only adds missing columns and tables when loading / updating
  extensions. It however considers *all* ext_tables.sql files, not only
  the one the extension in question provides. See the important .rst
  file for details.

Change-Id: I640a7c7da3b63bac21a71102f253aa2d1bef4391
Resolves: #85160
Related: #81234
Releases: master
Reviewed-on: https://review.typo3.org/57121
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Make ckeditor link browser not drop additional link params 09/57009/2
Kevin Ditscheid [Fri, 18 May 2018 14:13:49 +0000 (16:13 +0200)]
[BUGFIX] Make ckeditor link browser not drop additional link params

Fix the link browser to not drop the additional link params if
editing a link with additional link params set.

Resolves: #85040
Releases: master, 8.7
Change-Id: I4c016f701b38e048aa999c4e96365019eae4a237
Reviewed-on: https://review.typo3.org/57009
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
9 months ago[TASK] Raise typo3/testing-framework to 3.6.0 34/57134/3
Christian Kuhn [Wed, 6 Jun 2018 22:14:31 +0000 (00:14 +0200)]
[TASK] Raise typo3/testing-framework to 3.6.0

composer updade typo3/testing-framework

The update brings a couple of cleanups and bug fixes
and an improved functional test case splitter script
now used in bamboo.

Resolves: #85171
Releases: master
Change-Id: I79e30fd4e93e4a1635a74e225d4801dfb1768ad4
Reviewed-on: https://review.typo3.org/57134
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] Streamline functional data handling tests 33/57133/3
Christian Kuhn [Wed, 6 Jun 2018 20:06:24 +0000 (22:06 +0200)]
[TASK] Streamline functional data handling tests

The various "AbstractActionTestCase" classes of the functional
data handling tests only prepare the scenario, while the extending
Test classes of ext:core and ext:workspaces then call parent and
add assertions.
The abstract test preparations thus must not have @test annotations,
they would be executed as casual tests without asserting anything
useful.
The patch removes those obsolete @test annotations and fixes
another test case that had wrong wrong naming and was not executed
for a while.

Resolves: #85170
Releases: master
Change-Id: Ibf6f9ef99f7eaeaeba1374962112d4a342c36567
Reviewed-on: https://review.typo3.org/57133
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] Have correct test class namespaces 32/57132/2
Christian Kuhn [Wed, 6 Jun 2018 18:36:00 +0000 (20:36 +0200)]
[BUGFIX] Have correct test class namespaces

phpunit tends to execute test case files even if the
file comes with a broken namespace and can't be autoloaded.

The patch hopefully fixes all test case files that are
positioned in a wrong folder, has an otherwise broken
namespace or is not yet registered as psr-4 require-dev.

Resolves: #85169
Releases: master
Change-Id: Id8da485b14ab65a883dd90e1a11cfd8e74d85780
Reviewed-on: https://review.typo3.org/57132
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Extend ResourceStorage API to check for applied filters 44/56844/3
Nicole Cordes [Thu, 3 May 2018 10:21:59 +0000 (12:21 +0200)]
[BUGFIX] Extend ResourceStorage API to check for applied filters

Currently only the DriverInterface cares about applied filters.
The ResourceStorage received a new API function to validate a file or
folder object against applied filters as well. This ensures proper
validation for objects fetched without driver calls.

Resolves: #84908
Releases: master, 8.7
Change-Id: I5e8d35215c99aacfb330fe0eb8cfd9259b9a4199
Reviewed-on: https://review.typo3.org/56844
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
9 months ago[FEATURE] Render basic SEO meta tags in frontend 17/57117/4
Richard Haeser [Sun, 3 Jun 2018 19:06:19 +0000 (21:06 +0200)]
[FEATURE] Render basic SEO meta tags in frontend

The SEO meta tags that can be set in the page properties, will be
rendered in frontend.

Resolves: #85147
Releases: master
Change-Id: I75e6d8e50b7c8616497ee7075fddcb182551bea4
Reviewed-on: https://review.typo3.org/57117
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
9 months ago[BUGFIX] Add transparent background for tables again 26/57126/2
Andreas Fernandez [Tue, 5 Jun 2018 06:54:45 +0000 (08:54 +0200)]
[BUGFIX] Add transparent background for tables again

Resolves: #85155
Related: #85065
Releases: master
Change-Id: I0a3d89678dc23318db3cc3a3845c9c7fb3931959
Reviewed-on: https://review.typo3.org/57126
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
9 months ago[BUGFIX] Avoid fatal error in scheduler 18/57118/2
Benni Mack [Mon, 4 Jun 2018 06:48:01 +0000 (08:48 +0200)]
[BUGFIX] Avoid fatal error in scheduler

The scheduler object cleans up execution
arrays on instantiation. Due to the PSR-3
refactoring, the logger is instantiated
after the constructor is called - resulting
in a fatal error ("Call to member function info()
on null") when cleaning up the execution array.

The patch manually instantiates a logger if
there isn't one already.

Resolves: #85148
Releases: master
Change-Id: I5ff3a06a2b9d7e511d5d243df545359a48bf84b1
Reviewed-on: https://review.typo3.org/57118
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Fix minor CGL error 23/57123/2
Christian Kuhn [Mon, 4 Jun 2018 13:54:11 +0000 (15:54 +0200)]
[BUGFIX] Fix minor CGL error

A minor CGL error slipped through with a patch that has
been merged based on a +1 from bamboo before the
'declare_equal_normalize' php-cs-fixer rule has been
established.
The change should make the bamboo nightly builds green again.

Resolves: #85152
Related: #84720
Releases: master
Change-Id: Iaaf08d429780a12bf38a2865a5ae696a73cfcffb
Reviewed-on: https://review.typo3.org/57123
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[BUGFIX] Set correct unit test namespaces 22/57122/3
Christian Kuhn [Mon, 4 Jun 2018 12:13:23 +0000 (14:13 +0200)]
[BUGFIX] Set correct unit test namespaces

Fix a series of core unit test classes to correct namespace.

Resolves: #85151
Releases: master
Change-Id: Ibfffae113ba3114acf616e65d48d8b508eee9353
Reviewed-on: https://review.typo3.org/57122
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Honor l18n_cfg settings in PageRepository 38/57038/8
Georg Ringer [Tue, 22 May 2018 14:22:35 +0000 (16:22 +0200)]
[BUGFIX] Honor l18n_cfg settings in PageRepository

If a page record is fetched from the database, the PageRepository needs
to care about the l18n_cfg setting for this page.

Resolves: #85063
Releases: master, 8.7
Change-Id: Ib0338a4725a3b569b91f27baa3a59cabee6fe2fb
Reviewed-on: https://review.typo3.org/57038
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
9 months ago[BUGFIX] Correctly define allowedSubProperties of TwitterCardMetaTagManager 99/57099/9
Richard Haeser [Wed, 30 May 2018 20:56:29 +0000 (22:56 +0200)]
[BUGFIX] Correctly define allowedSubProperties of TwitterCardMetaTagManager

The properties within the allowedSubProperties have to be arrays
because the AbstractMetaTagManager checks if the property as a key
exists in the allowSubProperties.

Resolves: #85126
Releases: master
Change-Id: Ie57a77f8d4100e0861958de73faa56d80709daad
Reviewed-on: https://review.typo3.org/57099
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
9 months ago[BUGFIX] Respect showAccessRestrictedPages in MenuProcessor 34/56834/4
Frederik Holz [Wed, 2 May 2018 15:41:09 +0000 (17:41 +0200)]
[BUGFIX] Respect showAccessRestrictedPages in MenuProcessor

Menues provided by MenuProcessor will display restricted
pages, if the configuration value is set to true. This is the
same behavior as known from pure TypoScript provided menues.

Resolves: #82755
Releases: master, 8.7
Change-Id: Idf600f3ce151e2accba828c69dc601e26771686c
Reviewed-on: https://review.typo3.org/56834
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
9 months ago[BUGFIX] Try to translate given help text of select items 89/56689/4
Georg Ringer [Mon, 16 Apr 2018 14:38:16 +0000 (16:38 +0200)]
[BUGFIX] Try to translate given help text of select items

Use the LanguageService for help texts of select items.
This can be tested with the element 'select_checkbox_3' of the
styleguide extension.

Resolves: #78984
Releases: master, 8.7
Change-Id: Idb6e63547ac480b18fcb1ca997d5d07e4bcb4e81
Reviewed-on: https://review.typo3.org/56689
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[TASK] Improve overall recycler performance 02/56102/11
Andreas Fernandez [Sun, 11 Mar 2018 21:09:06 +0000 (22:09 +0100)]
[TASK] Improve overall recycler performance

To improve the overall performance of the recycler, these things are done:

- Improve how permissions are checked for each record
  Instead of running multiple SQL requests per record, the check now
  instantly stops if the user is either an admin, or has no permission
  to modify a certain table.

- Drop sorting of records by page tree structure
  The records get sorted by the page tree structure, to mime the tree in
  a flat view. However, this feature is rather useless and also
  considered buggy in a huge record set.

Resolves: #84711
Releases: master, 8.7
Change-Id: I0c5177546489ce2a0ba84435fed3879267a5a871
Reviewed-on: https://review.typo3.org/56102
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
9 months ago[TASK] Update Install Tool text 25/56825/5
Tom Warwick [Sun, 29 Apr 2018 13:52:06 +0000 (14:52 +0100)]
[TASK] Update Install Tool text

This commit is intented to improve the language
used in the Install Tool and each of its modules.

[+] Review title,subtitle and description for
each action available and update/amend where required.

Resolves: #84891
Releases: master
Change-Id: I7f71f85ae86c37786870b2c30511673fe28da7c2
Reviewed-on: https://review.typo3.org/56825
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[!!!][TASK] Make all enumerations final 76/56976/8
Mathias Brodala [Wed, 16 May 2018 10:57:56 +0000 (12:57 +0200)]
[!!!][TASK] Make all enumerations final

Code which uses enumerations expects a known set of values, adding
more values by extending these classes leads to undefined behavior.

Since it is now impossible to create a mock of an enumeration also
drop a few Enumeration tests and stick to testing of the public API.

Resolves: #85025
Releases: master
Change-Id: I3d0238c85ae916052dc1aa503f7f8e39c1765ac6
Reviewed-on: https://review.typo3.org/56976
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[BUGFIX] Only list valid forms 08/57108/4
Ralf Zimmermann [Thu, 31 May 2018 20:05:27 +0000 (22:05 +0200)]
[BUGFIX] Only list valid forms

Only list valid forms within the form manger and the form plugin.

Valid forms have an "identifier" and a "type" and the type must be "Form".

Resolves: #85132
Releases: master, 8.7
Change-Id: I2f473925b3edf839d5f965136b6b02030671350a
Reviewed-on: https://review.typo3.org/57108
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
9 months ago[TASK] Move TSFE->getPageShortcut to PageRepository 06/57106/5
Benni Mack [Thu, 31 May 2018 18:40:04 +0000 (20:40 +0200)]
[TASK] Move TSFE->getPageShortcut to PageRepository

The method `getPageShortcut()` which is marked as private is moved to
PageRepository, as it only requires logic and methods from
PageRepository.

Resolves: #85130
Releases: master
Change-Id: I4c7296e085953377e0937b8d1efad0b97d1fb021
Reviewed-on: https://review.typo3.org/57106
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[BUGFIX] Fix method call matcher arguments config 10/57110/2
Mathias Brodala [Fri, 1 Jun 2018 10:31:50 +0000 (12:31 +0200)]
[BUGFIX] Fix method call matcher arguments config

Resolves: #85139
Releases: master
Change-Id: Iadcfdb2bcc5dd0ebf3eeb535171a43c3a54afe47
Reviewed-on: https://review.typo3.org/57110
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[BUGFIX] Fix extension data import on sqlite 03/57103/7
Susanne Moog [Thu, 31 May 2018 11:53:56 +0000 (13:53 +0200)]
[BUGFIX] Fix extension data import on sqlite

Sqlite limits the maximum number of variables
allowed in a query. When importing the extension
list the chunks are too big (> 999 variables).

This has been chunked to enable import on sqlite.

Resolves: #85129
Releases: master
Change-Id: If65476707946f4078a1b1e55128239aed07f6ed8
Reviewed-on: https://review.typo3.org/57103
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[TASK] Deprecate Backend Module Routing methods 48/57048/5
Benni Mack [Fri, 25 May 2018 09:15:29 +0000 (11:15 +0200)]
[TASK] Deprecate Backend Module Routing methods

Since TYPO3 v9.0, all routing in backend is handled unified, thus, the old
methods from historical reasons can be deprecated.

- BackendUtility::getModuleUrl()
- UriBuilder->buildUriFromModule()

Instead of guessing the name to a module route, an "id" for the route (like the path)
can be explictly given.

Resolves: #85113
Releases: master
Change-Id: I8cf2b9dc3a938dd7227dcc972e0782619ede4213
Reviewed-on: https://review.typo3.org/57048
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Correctly resolve RTE preset configuration for link browser 81/56881/7
Tymoteusz Motylewski [Tue, 29 May 2018 22:40:49 +0000 (00:40 +0200)]
[BUGFIX] Correctly resolve RTE preset configuration for link browser

Replaces hardcoded RTE configuration in BrowseLinksController
with one resolved by Formengine when rendering a field.
This takes into account e.g. column overrides.

The RTE configuration preset name is now kept by Formengine in
['processedTca']['columns'][$fieldName]['config']['richtextConfigurationName']

Then it's being passed as parameter P[richtextConfigurationName] from RTE field
to the BrowseinksController

Resolves: #84943
Releases: master, 8.7
Change-Id: Id4f1c350f6eb6dfad4d49ec759a23939bbc45eda
Reviewed-on: https://review.typo3.org/56881
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[BUGFIX] Fix inSet implementation for sqlite 07/57107/4
Susanne Moog [Thu, 31 May 2018 19:23:45 +0000 (21:23 +0200)]
[BUGFIX] Fix inSet implementation for sqlite

For SQLite inSet was implemented with a "like" substitution
which had various bugs. That implementation has
now been substituted with an "instr" implementation.

Resolves: #85131
Releases: master
Change-Id: Id4e8f7132800c991e49d4033d2b01f474b6aae3b
Reviewed-on: https://review.typo3.org/57107
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
9 months ago[BUGFIX] Handle access restrictions on recycler search 52/57052/9
Nicole Cordes [Fri, 25 May 2018 12:05:16 +0000 (14:05 +0200)]
[BUGFIX] Handle access restrictions on recycler search

Fetching a parent folder may throws an error if the user hasn't
access to the parent. This exception needs to be caught and the
search for an existing recycler folder needs to be stopped
immediately.

Furthermore the patch removes the comparison with the root level
folder but checks the parent folder doesn't equal the folder itself.

Another loop is fixed by calling moveFile on the correct
ResourceStorge and not the current one.

Resolves: #85079
Related: #81836
Releases: master, 8.7
Change-Id: I51f5e20d7fa7da9b350ac0ca60cab05866a4d337
Reviewed-on: https://review.typo3.org/57052
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
9 months ago[BUGFIX] Statement::rowCount not reliable for SELECT queries 83/50083/10
Susanne Moog [Thu, 31 May 2018 13:43:36 +0000 (15:43 +0200)]
[BUGFIX] Statement::rowCount not reliable for SELECT queries

Concerning the usage of Statement::rowCount() the Doctrine DBAL
documentation states the following:

  Returns the number of rows affected by the last
  DELETE, INSERT, or UPDATE statement
  executed by the corresponding object.

For default configurations using MySQL as platform,
rowCount() is returning the expected
value for SELECT statements as well.
However, on other DBMS this value will be zero
as mentioned in the documentation - for instance
SQLite is a candidate for that.

For retrieving the row count for given criteria, the count()
expression has to be used explicitly.

Resolves: #78129
Releases: master
Change-Id: Id28d72a1a21e8615ec45b63d4aecc100d03a39a3
Reviewed-on: https://review.typo3.org/50083
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Deprecate Redirecting UrlHandler Hook Concept 96/57096/3
Tymoteusz Motylewski [Wed, 30 May 2018 21:50:42 +0000 (23:50 +0200)]
[TASK] Deprecate Redirecting UrlHandler Hook Concept

The concept for custom UrlHandlers, introduced in TYPO3 v7 for extracting JumpURL
into a TER extension has been deprecated in favor of PSR-15.

These could be registered via
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['urlProcessing']['urlHandlers']

The methods related to that functionality have been deprecated.
- $TSFE->initializeRedirectUrlHandlers()
- $TSFE->redirectToExternalUrl()

However, the core-internal calls have been marked with a property to ensure
that no deprecation warning is triggered, but the functionality can be kept.

Resolves: #85124
Releases: master
Change-Id: Ie49d7200618d2b8ffdd5394ea9c649c123719b07
Reviewed-on: https://review.typo3.org/57096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
9 months ago[TASK] Make FileBackendTest.php notice free 54/56654/2
Jan Helke [Sat, 14 Apr 2018 11:17:48 +0000 (13:17 +0200)]
[TASK] Make FileBackendTest.php notice free

Releases: master
Resolves: #84720
Change-Id: If13dfe85fcb41ce3a361fbb184d95c5ddffaf958
Reviewed-on: https://review.typo3.org/56654
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[TASK] Deprecate usages of CharsetConverter in core 97/57097/4
Benni Mack [Wed, 30 May 2018 20:20:56 +0000 (22:20 +0200)]
[TASK] Deprecate usages of CharsetConverter in core

CharsetConverter is still instantiated in some places and not needed at all times.

The following places have CharsetConverter completely removed (as internal property):
- PageRenderer
- SearchController
- Indexer

The AbstractHierarchicalFilesystemDriver's shorthand method getCharsetConversion()
has been deprecated, as drivers should instantiate the CharsetConversion themself.

Indexed Search's Lexer has a public property "csObj" which has been switched to
protected, where a deprecation message will be thrown.

Resolves: #85125
Releases: master
Change-Id: I48fd110ecd25bb6a4225a3d2141edc5fc3b92673
Reviewed-on: https://review.typo3.org/57097
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[BUGFIX] Allow value for CLI command cleanup:versions --action argument 55/57055/3
Simon Gilli [Fri, 25 May 2018 17:48:07 +0000 (19:48 +0200)]
[BUGFIX] Allow value for CLI command cleanup:versions --action argument

Allow the usage of a value for --action argument of the CLI command
cleanup:versions as mentioned in the documentation and the
implementation.

Resolves: #85085
Related: #79109
Related: #82653
Releases: master, 8.7
Change-Id: I6c07303728bcb527b44a6c5bf811870f25398a21
Reviewed-on: https://review.typo3.org/57055
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[FEATURE] Use new TypoScript and TSConfig files extension 83/57083/6
Tymoteusz Motylewski [Tue, 29 May 2018 20:29:56 +0000 (22:29 +0200)]
[FEATURE] Use new TypoScript and TSConfig files extension

It was decided to use .typoscript and .tsconfig
The patch renames the files and adds little BC layer which allows
you to include TypoScript files using old (.txt) file extension.

Resolves: #81686
Releases: master
Change-Id: Id6784e4f573e2e0b060f37d241c07216ac5678e1
Reviewed-on: https://review.typo3.org/57083
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Deprecate PageRepository->versioningPreview 47/57047/9
Benni Mack [Fri, 25 May 2018 08:40:05 +0000 (10:40 +0200)]
[TASK] Deprecate PageRepository->versioningPreview

PageRepository has two public properties regarding
fetching records for versioned records:
- versioningPreview (bool)
- versioningWorkspaceId (int)

In order to allow previews of versions, a workspace ID
has to be set - otherwise it fetches live records.

Basically things like: $versioningPreview=false,
$versioningWorkspaceId=3 will make things more confusing.

Instead, versioningPreview is not in use anymore,
and PageRepository solely relies on the parameter
of the workspaceId set.

Resolves: #85078
Releases: master
Change-Id: I70f028854ebc1a83d6d5af18de507284ae89b2ac
Reviewed-on: https://review.typo3.org/57047
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] Fix indexed search TypoScript settings documentation 89/57089/7
Harry Glatz [Wed, 30 May 2018 10:44:36 +0000 (12:44 +0200)]
[BUGFIX] Fix indexed search TypoScript settings documentation

Releases: master, 8.7
Resolves: #85117
Related: #32030
Change-Id: I6af62c8337865e8a76c2dd8593f5afa38e0c2d26
Reviewed-on: https://review.typo3.org/57089
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[BUGFIX] Remember selected page in fsMod and refactor page selection 76/57076/3
Tymoteusz Motylewski [Mon, 28 May 2018 16:55:29 +0000 (18:55 +0200)]
[BUGFIX] Remember selected page in fsMod and refactor page selection

Currently selected page is remembered in the fsMod js object.
The JS code responsible for handling click on the node text and node
background is refactored. Now both uses node.checked property.

Resolves: #85100
Resolves: #85106
Releases: master
Change-Id: I08768e82a62e942c247d968df707bf64426e1dab
Reviewed-on: https://review.typo3.org/57076
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Deprecate T3_ERR_SV_ constants 95/57095/3
Benni Mack [Wed, 30 May 2018 19:26:21 +0000 (21:26 +0200)]
[TASK] Deprecate T3_ERR_SV_ constants

The following constants related to the Services in TYPO3 have been moved into AbstractService
as class constants, effectively moving them in the right context.

- T3_ERR_SV_GENERAL
- T3_ERR_SV_NOT_AVAIL
- T3_ERR_SV_WRONG_SUBTYPE
- T3_ERR_SV_NO_INPUT
- T3_ERR_SV_FILE_NOT_FOUND
- T3_ERR_SV_FILE_READ
- T3_ERR_SV_FILE_WRITE
- T3_ERR_SV_PROG_NOT_FOUND
- T3_ERR_SV_PROG_FAILED

The Extension scanner will detect usages of these constants. The constants will
be removed in TYPO3 v10.

Resolves: #85123
Releases: master
Change-Id: I9df12e51deda77903aff83769d4f2a532b2676fb
Reviewed-on: https://review.typo3.org/57095
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[TASK] Deprecate various functionality in CharsetConverter 94/57094/3
Benni Mack [Wed, 30 May 2018 13:29:38 +0000 (15:29 +0200)]
[TASK] Deprecate various functionality in CharsetConverter

Due to native support and a polyfill for mb_string(), lot of functionality of
CharsetConverter was simplified throughout TYPO3 in the last release
to ensure faster charset conversion.

Many methods and properties within CharsetConverter can be deprecated
now:
- CharsetConverter->synonyms
- CharsetConverter->parse_charset()
- Fourth parameter of CharsetConverter->conv()
- CharsetConverter->convArray()
- CharsetConverter->utf8_to_entities()
- CharsetConverter->entities_to_utf8()
- CharsetConverter->crop()
- CharsetConverter->convCaseFirst()
- CharsetConverter->utf8_char2byte_pos()

Additionally the following public properties have been changed to have a "protected"
visibility, as this only reflects internal state:
- CharsetConverter->noCharByteVal
- CharsetConverter->parsedCharsets
- CharsetConverter->toASCII
- CharsetConverter->twoByteSets
- CharsetConverter->eucBasedSets

Resolves: #85122
Releases: master
Change-Id: Ic67dd1cffa36cd625c844ae82fdca8447a317efe
Reviewed-on: https://review.typo3.org/57094
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] Add Site Configuration to ConfigurationController 44/56644/5
Simon Gilli [Fri, 13 Apr 2018 01:26:06 +0000 (03:26 +0200)]
[TASK] Add Site Configuration to ConfigurationController

Add the Site Configuration to the ConfigurationController to
simplify debugging and enable its inspection at the backend.

Resolves: #84709
Releases: master
Change-Id: Ib0720f372a2d27873fda9931c8753c7ed6a98750
Reviewed-on: https://review.typo3.org/56644
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[TASK] Deprecate JavaScriptEncoder class 93/57093/2
Benni Mack [Wed, 30 May 2018 17:25:09 +0000 (19:25 +0200)]
[TASK] Deprecate JavaScriptEncoder class

The JavaScriptEncoder class was superseded with GeneralUtility::quoteJSvalue() in TYPO3 6.2
and is not used anymore. It is marked as deprecated.

Resolves: #85120
Releases: master
Change-Id: I13cb97e3ff6bb23d937a5193d392f92eb759ba9d
Reviewed-on: https://review.typo3.org/57093
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] CharsetConverter: Remove Case Folding 90/57090/2
Benni Mack [Wed, 30 May 2018 12:44:05 +0000 (14:44 +0200)]
[TASK] CharsetConverter: Remove Case Folding

Special Case Folding within CharsetConverter is not used anymore, and can be removed.

The public property $caseFolding used as runtime cache is removed, as it was never possible
to fill it either to have it accessed from the outside.

The SpecialCasing.txt file has no meaning anymore and can be removed.

Resolves: #85118
Releases: master
Change-Id: Ib770fe99a97ac06c4f9c485e960c681ab21c9113
Reviewed-on: https://review.typo3.org/57090
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[TASK] Change visibility of CharsetConverter init methods 88/57088/3
Benni Mack [Wed, 30 May 2018 09:44:32 +0000 (11:44 +0200)]
[TASK] Change visibility of CharsetConverter init methods

Various CharsetConverter methods are there for initialization conversion,
which are marked as @private and are only used within the class.

The patch switches the method signatures from public to protected.

The following methods are affected:
- initCharset()
- initUnicodeData()
- initCaseFolding()
- initToASCII()

Resolves: #85116
Releases: master
Change-Id: I153123068cbfbf0baee729aab7dc0946913d5d7c
Reviewed-on: https://review.typo3.org/57088
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
9 months ago[TASK] Consistent date and time rendering in FormEngine 41/57041/3
Georg Ringer [Wed, 23 May 2018 09:07:30 +0000 (11:07 +0200)]
[TASK] Consistent date and time rendering in FormEngine

Use methods of BackendUtility to have a consistent look of date and
time fields in the backend.

Resolves: #85002
Releases: master, 8.7
Change-Id: I6f0b6aca1530524ff3f83922a1b4b2dd72b1ea84
Reviewed-on: https://review.typo3.org/57041
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Always prefer HTTPS for cross-domain links 82/57082/2
Mathias Brodala [Tue, 29 May 2018 14:17:23 +0000 (16:17 +0200)]
[BUGFIX] Always prefer HTTPS for cross-domain links

This expands the logic for forced absolute URLs to all cases and
ensures HTTPS is kept for cross-domain links if possible.

Resolves: #85111
Releases: master, 8.7
Change-Id: I7840a47d0ae9a3f9571ae8ddcf9cdc35b59cc4fa
Reviewed-on: https://review.typo3.org/57082
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[BUGFIX] Allow writing temp files in composer mode 46/57046/3
Benni Mack [Fri, 25 May 2018 07:40:49 +0000 (09:40 +0200)]
[BUGFIX] Allow writing temp files in composer mode

The new Environment API allows to set the project path
outside of the web root, also moving typo3temp/var/
to env:PROJECT_PATH + var/.

However, the main method GeneralUtility::writeFileToTypo3tempDir()
which is used for adding online media, charset conversion etc.
is not adapted to allow files outside of typo3temp/
which needs adaptions wo also check for PROJECT_PATH + var/
in addition.

Some generic tests were added to ensure the existing functionality
still works.

Resolves: #85077
Releases: master
Change-Id: I664e152ecba39fbb86605af12e83f3ef10f878f9
Reviewed-on: https://review.typo3.org/57046
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Petra Arentzen <typo3@pegu.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[BUGFIX] Initialize AdminPanel only if enabled by user 77/57077/3
Susanne Moog [Mon, 28 May 2018 20:29:19 +0000 (22:29 +0200)]
[BUGFIX] Initialize AdminPanel only if enabled by user

The admin panel can be disabled via the frontend UI by
click. When the admin panel is disabled the initialize
methods should not be called. This has been fixed.

Resolves: #85104
Releases: master
Change-Id: I966b5887b03b4fb8d3f63e9556b00a37384f9dfc
Reviewed-on: https://review.typo3.org/57077
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] Make TypoScriptParserTest.php notice free 62/57062/2
Jan Helke [Mon, 28 May 2018 11:48:24 +0000 (13:48 +0200)]
[TASK] Make TypoScriptParserTest.php notice free

Releases: master
Resolves: #85091
Change-Id: I501b401a7553e969324ff79821780944ce240e5f
Reviewed-on: https://review.typo3.org/57062
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] Make Tests/Unit/Tree/ notice free 60/57060/3
Jan Helke [Mon, 28 May 2018 11:41:56 +0000 (13:41 +0200)]
[TASK] Make Tests/Unit/Tree/ notice free

Releases: master
Resolves: #85089
Change-Id: Idb85307b51e609f147ccfeacce710256778f96a2
Reviewed-on: https://review.typo3.org/57060
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
9 months ago[TASK] Clarify changelog file placement 99/56999/5
Mathias Brodala [Fri, 18 May 2018 09:08:59 +0000 (11:08 +0200)]
[TASK] Clarify changelog file placement

Releases: master
Resolves: #85039
Change-Id: I2e995aef69edd099d49b5915ab61c38e7d0af49e
Reviewed-on: https://review.typo3.org/56999
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[TASK] Deprecate 3rd argument in PageRepository->getRootLine() 75/57075/3
Benni Mack [Mon, 28 May 2018 20:10:06 +0000 (22:10 +0200)]
[TASK] Deprecate 3rd argument in PageRepository->getRootLine()

The third argument about catching errors can be achieved by building a try/catch
block around the method.

Resolves: #85105
Releases: master
Change-Id: I42f2b66e1b6267376e9352e76b9e58e9bde028f9
Reviewed-on: https://review.typo3.org/57075
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[TASK] Make RootlineUtilityTest.php notice free 64/57064/7
Jan Helke [Mon, 28 May 2018 11:52:28 +0000 (13:52 +0200)]
[TASK] Make RootlineUtilityTest.php notice free

Releases: master
Resolves: #85093
Change-Id: Ib5c8fbf7d4a69d05b0fb370440fba0bc755e5854
Reviewed-on: https://review.typo3.org/57064
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[TASK] Deprecate PhpOptionsUtility 71/57071/2
Benni Mack [Mon, 28 May 2018 18:20:07 +0000 (20:20 +0200)]
[TASK] Deprecate PhpOptionsUtility

The utility class was thinned out in the last TYPO3
versions and now is only used in EXT:install.

The functionality can be moved into EXT:install,
and PhpOptionsUtility can be deprecated, marked
as deprecated and awaiting removal in TYPO3 v10.0.

Resolves: #85102
Releases: master
Change-Id: Ie45720ad70cd2bdd2949553c94fcec15806cb458
Reviewed-on: https://review.typo3.org/57071
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[TASK] Remove inline JS from Permissions Module 78/57078/2
Tymoteusz Motylewski [Mon, 28 May 2018 21:39:15 +0000 (23:39 +0200)]
[TASK] Remove inline JS from Permissions Module

Resolves: #85107
Releases: master
Change-Id: I218ae9ae3a2eb6bcd23eef2073bf8b11139d58bc
Reviewed-on: https://review.typo3.org/57078
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
9 months ago[BUGFIX] Remove dummy JS code in PageLayoutController 73/57073/2
Tymoteusz Motylewski [Mon, 28 May 2018 19:30:59 +0000 (21:30 +0200)]
[BUGFIX] Remove dummy JS code in PageLayoutController

The statement does nothing so it is removed.

Resolves: #85103
Releases: master
Change-Id: Ib9b20392d837262bd3d98069d2998c8c6a372dfc
Reviewed-on: https://review.typo3.org/57073
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Clean up error handler for site handling 57/57057/4
Benni Mack [Sun, 27 May 2018 15:11:46 +0000 (17:11 +0200)]
[BUGFIX] Clean up error handler for site handling

This patch handles several issues related to the new
site error handling introduced in TYPO3 v9.2.0:

1. It adds unit tests
2. It adds a missing exception when an error handler
is configured which does not implement the PageErrorHandlerInterface
3. It fixes one minor issue in PageContentErrorHandler
where a wrong "InvalidArgumentException" was thrown
4. All PageErrorHandler logic was moved from EXT:frontend
to EXT:core, as this would be a penalty across packages -
the "Site" entity depends on them, so they must go to the same
package (core).

Releases: master
Resolves: #85101
Change-Id: Ibdc05024abd7c719dd8d5dcb3388bf1679b69990
Reviewed-on: https://review.typo3.org/57057
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Deprecate GeneralUtility::arrayToLogString() 56/57056/3
Benni Mack [Sun, 27 May 2018 13:13:38 +0000 (15:13 +0200)]
[TASK] Deprecate GeneralUtility::arrayToLogString()

The method arrayToLogString() within GeneralUtility is deprecated in favor of using
own implementations, based on PSR-3.

Still, the one place where this method was in use - ListSysLogCommand -
moved the logic into its own protected method.

Resolves: #85086
Releases: master
Change-Id: If6815a5ea9e459258408458b97b7ee4ad901bd40
Reviewed-on: https://review.typo3.org/57056
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Properly validate DateTimeImmutable objects 54/57054/3
Mathias Brodala [Fri, 25 May 2018 13:10:21 +0000 (15:10 +0200)]
[BUGFIX] Properly validate DateTimeImmutable objects

Change-Id: I29159e835d362e3f0e06c2145e84c1119df152cf
Resolves: #85083
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57054
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[TASK] Cleanup t3editor controllers and docs 51/57051/3
Benni Mack [Fri, 25 May 2018 10:23:01 +0000 (12:23 +0200)]
[TASK] Cleanup t3editor controllers and docs

EXT:t3editor has some AJAX controllers which can be simplified:
- Unused properties are removed
- Unrelated "LANG" calls can be streamlined, resulting in a lowered
  memory footprint
- Rootline resolving is done directly via the existing class
- Remove obsolete usage of PhpFrontend in phpDoc in T3editor base class

Resolves: #85081
Releases: master
Change-Id: Ia5669d161c59881e509d9b7e881cc555ef2b44c1
Reviewed-on: https://review.typo3.org/57051
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Ensure Extbase translation tests fulfill expectations 50/57050/3
Nicole Cordes [Fri, 25 May 2018 10:14:15 +0000 (12:14 +0200)]
[BUGFIX] Ensure Extbase translation tests fulfill expectations

Ensure the test is executed as expected.

Resolves: #85082
Releases: master, 8.7
Change-Id: Ia0dfbdc12eeefbb28996f69dade4298b1464afa6
Reviewed-on: https://review.typo3.org/57050
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Improve language labels of the form editor 10/57010/3
Björn Jacob [Fri, 18 May 2018 14:22:37 +0000 (16:22 +0200)]
[TASK] Improve language labels of the form editor

Resolves: #85048
Releases: master
Change-Id: I7c0048c52c0fe4b8e76fbbef474e3093e7787c37
Reviewed-on: https://review.typo3.org/57010
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
9 months ago[TASK] Optimize the tree of the form editor 07/57007/3
Benjamin Burse [Fri, 18 May 2018 13:06:41 +0000 (15:06 +0200)]
[TASK] Optimize the tree of the form editor

- remove linebreak in root node
  -> instead use text-overflow: ellipsis
- fix indentation of tree elements
  -> move triangles indicating subtrees to the left
- changed tooltip message to only show "id = <element-id>"

Resolves: #85042
Releases: master
Change-Id: I2621974c2688ac5e03a7e39e8c4f6ad94e15e9a4
Reviewed-on: https://review.typo3.org/57007
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
9 months ago[TASK] Remove leftover ExtJs comments and CSS 40/57040/2
Wouter Wolters [Tue, 22 May 2018 19:49:14 +0000 (21:49 +0200)]
[TASK] Remove leftover ExtJs comments and CSS

Resolves: #85065
Releases: master
Change-Id: I0c9b151874acf0d4f725cff029ce5392ae054779
Reviewed-on: https://review.typo3.org/57040
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
9 months ago[!!!][TASK] Remove support for non namespaced classes in Extbase 90/56990/10
Alexander Schnitzler [Thu, 17 May 2018 09:49:24 +0000 (11:49 +0200)]
[!!!][TASK] Remove support for non namespaced classes in Extbase

Non-namespaced classes will no longer be respected in Extbase.
This affects all places where Extbase magic happens, like translating
the model name to repository name (and vice versa).

If you still use class names with underscores, especially models,
repositories and controllers you need to act now.

Releases: master
Resolves: #85036
Change-Id: Ide5923159027802e723dff49729bba52a74c2639
Reviewed-on: https://review.typo3.org/56990
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Only validate method params if needed 70/56970/7
Alexander Schnitzler [Tue, 15 May 2018 13:46:29 +0000 (15:46 +0200)]
[BUGFIX] Only validate method params if needed

Controller action arguments have been validated on
creation, which caused superfluous CPU cycles if the
action controller later detected, that an argument
should not have been validated at all due to an
@Extbase\IgnoreValidation annotation.

To fix this, arguments get an empty result on creation.
When setting the argument value, only the validation
results of the property mapping are merged with the
argument result.

ActionController::initializeActionMethodValidators does
only create validator instances for method arguments
that need to be validated, thus a whole bunch of checks
disappears in callActionMethod().

Releases: master
Resolves: #85012
Change-Id: Iaecf36718477a9216f8d36a993a137eb7b677227
Reviewed-on: https://review.typo3.org/56970
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Add SYS/ipAnonymization to DefaultConfiguration 27/57027/7
Andreas Fernandez [Tue, 22 May 2018 09:44:55 +0000 (11:44 +0200)]
[BUGFIX] Add SYS/ipAnonymization to DefaultConfiguration

Resolves: #85060
Related: #84053
Releases: master, 9.2, 8.7, 7.6
Change-Id: I04dba093dc8e423adbf75e2198c31e5c013864cb
Reviewed-on: https://review.typo3.org/57027
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[BUGFIX] Prevent PHP notice in TreeController 19/57019/3
Frank Naegler [Tue, 22 May 2018 07:22:52 +0000 (09:22 +0200)]
[BUGFIX] Prevent PHP notice in TreeController

With #81987 we have introduced code, which could cause PHP notices.
This patch changes the check to prevent such notices.

Resolves: #85057
Related: #81987
Releases: master
Change-Id: I85e85501c2593b8abacac1d8296148d03d57f407
Reviewed-on: https://review.typo3.org/57019
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
9 months ago[TASK] Change some site configuration details 01/57001/9
Christian Kuhn [Fri, 18 May 2018 10:07:52 +0000 (12:07 +0200)]
[TASK] Change some site configuration details

Some first experiences with the new v9.2 site configuration
show us that people think site configuration can be extended
just like any other TCA, but that's not the case. The
patch changes some details to make more clear site
configuration is not just some other sort of TCA with the
same feature set.

* Do not prefix site_* with sys_ anymore to abstract
  better from db tables
* Rename configuration folder SiteConfigurationTca/
  to SiteConfiguration/ to make it more clear this
  is not straight TCA
* Do not load SiteConfiguration into GLOBALS['TCA']
  to distinct from TCA
* Mark extending site configuration experimental, add
  a documentation example and explain what is not working.

Change-Id: I87890ccd07ca73c4ef1f7690c61f8d2185baf575
Resolves: #85050
Releases: master
Reviewed-on: https://review.typo3.org/57001
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[FEATURE] Preserve image rotation if orient is saved in exif 79/48079/13
Stefan Froemken [Wed, 11 May 2016 13:58:25 +0000 (15:58 +0200)]
[FEATURE] Preserve image rotation if orient is saved in exif

Some digicams like iPhone do not rotate images
by default. They add a direction entry into the exif
meta data.

ImageMagick can read this entry if -auto-orient is set.

The patch add the rotation detection to the ImageInfo object and the
IM/GD commands that read files.

Resolves: #69274
Releases: master
Change-Id: I4b1193daf1c321a3d4beb8d76974012ee42470f6
Reviewed-on: https://review.typo3.org/48079
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[TASK] Deprecate methods and constants in ValidatorResolver 88/56888/8
Alexander Schnitzler [Tue, 8 May 2018 13:06:46 +0000 (15:06 +0200)]
[TASK] Deprecate methods and constants in ValidatorResolver

Several methods and constants in the ValidatorResolver class
are now marked as deprecated because they are no longer needed
to resolve validators.

As these methods and constants are to be considered internal api
it is very unlikely that anyone is affected by this change.

Releases: master
Resolves: #85005
Change-Id: If5fdb34766c84de1b16854f14df23fc2ddaff750
Reviewed-on: https://review.typo3.org/56888
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
10 months ago[BUGFIX] Use better icons for backend layout grid editor actions 62/56962/2
Mathias Brodala [Tue, 15 May 2018 08:01:33 +0000 (10:01 +0200)]
[BUGFIX] Use better icons for backend layout grid editor actions

Change-Id: Ie2ca536b5e1bd6e28e46af8073aaff4e298ddecf
Resolves: #85008
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56962
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
10 months ago[TASK] Allow overriding the confirmation message finisher 05/57005/4
Björn Jacob [Fri, 18 May 2018 12:48:21 +0000 (14:48 +0200)]
[TASK] Allow overriding the confirmation message finisher

Since #80187 it is possible to use the confirmation message finisher
within the form editor. This patch adds the missing possibility to
override the finisher within the content element.

Resolves: #85047
Related: #80187
Releases: master
Change-Id: I55e91972e1eb5ce0b636a8286423f4af2202ca03
Reviewed-on: https://review.typo3.org/57005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
10 months ago[TASK] Log message when typolink fails 95/56995/2
Mathias Brodala [Thu, 17 May 2018 13:39:44 +0000 (15:39 +0200)]
[TASK] Log message when typolink fails

We log this as debug to not fill system logs by default.

Resolves: #85034
Releases: master, 8.7
Change-Id: Ica686e42fa7a2ef09f2f5c4bf9b91781f5c14dc9
Reviewed-on: https://review.typo3.org/56995
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
10 months ago[TASK] Correct misspelled word in "UriBuilder.php" 04/57004/2
Bernhard Kraft [Fri, 18 May 2018 12:09:33 +0000 (14:09 +0200)]
[TASK] Correct misspelled word in "UriBuilder.php"

Fix a typo in doc comments.

Resolves: #85046
Releases: master
Change-Id: I3b7674593288accd43b2d4779f878e0eceee63a2
Reviewed-on: https://review.typo3.org/57004
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
10 months ago[BUGFIX] Use proper fallback value of files per page in file list module 03/57003/2
Oliver Hader [Fri, 18 May 2018 10:31:42 +0000 (12:31 +0200)]
[BUGFIX] Use proper fallback value of files per page in file list module

In case TSconfig options.file_list.filesPerPage is not defined the
resulting value falls back to 1 - however this should be the same as
defined in FileList::$iLimit, which is 40 per default.

Resolves: #85043
Releases: master
Change-Id: I33b024b81697350aeae54251e1ea66a36efc4d43
Reviewed-on: https://review.typo3.org/57003
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
10 months ago[BUGFIX] Prevent endless loop in recycler folder detection 85/56985/3
Alexander Stehlik [Wed, 16 May 2018 21:16:22 +0000 (23:16 +0200)]
[BUGFIX] Prevent endless loop in recycler folder detection

Compare folder identifiers instead of folder objects because
objects pointing to the same folder might still be different
object instances.

Change-Id: I78e21b9e68fbaae245d12ac4efb96312b246a847
Releases: master, 8.7
Resolves: #85019
Reviewed-on: https://review.typo3.org/56985
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Skip adding child elements if a nested form element is unknown 73/56773/8
Ralf Zimmermann [Sat, 21 Apr 2018 08:06:37 +0000 (10:06 +0200)]
[BUGFIX] Skip adding child elements if a nested form element is unknown

Skip adding child elements within the form factory if a nested form
element is unknown.

Resolves: #84833
Releases: master, 8.7
Change-Id: I1cbb87b4c460bd45b58aa6bcca27a88c61a7e92f
Reviewed-on: https://review.typo3.org/56773
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
10 months ago[TASK] Improve form documentation 97/56997/4
Björn Jacob [Thu, 17 May 2018 15:27:55 +0000 (17:27 +0200)]
[TASK] Improve form documentation

* introduce new role for inline YAML code styles
* fix some internal and external links

Resolves: #85037
Releases: master, 8.7
Change-Id: Ie5581bcc911914c49511ff86c5679f04c45c9f00
Reviewed-on: https://review.typo3.org/56997
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
10 months ago[TASK] Improved form editor hints and validations 81/56981/7
Daniela Pohl [Thu, 17 May 2018 14:31:38 +0000 (16:31 +0200)]
[TASK] Improved form editor hints and validations

- improved margin between field and hint for "special form" element
- styled custom error message hint -> this also applies for
  "single select" element : "inactive option"
- fixed validator and finisher margins
- styled hints for required textareas

Resolves: #82339
Releases: master
Change-Id: I3cd215eb967ccd6f0901a72675513a2619521d11
Reviewed-on: https://review.typo3.org/56981
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
10 months ago[TASK] Make honeypot field accessible 92/56992/5
Björn Jacob [Thu, 17 May 2018 11:35:51 +0000 (13:35 +0200)]
[TASK] Make honeypot field accessible

The honeypot field now passes the accessibility tests WCAG 2.0 (tested
with Google Lighthouse).

Instead of inserting a label tag or a title attribute - which would be
counterproductive by revealing the purpose of the honeypot - the patch
adds an aria-hidden attribute.

Resolves: #75591
Releases: master, 8.7
Change-Id: Ie4b0b7a245f5c0edf3e01ece60dcb638b2f9bdc1
Reviewed-on: https://review.typo3.org/56992
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
10 months ago[TASK] Document 'defaultValue' handling of form 91/56991/4
Björn Jacob [Thu, 17 May 2018 10:58:52 +0000 (12:58 +0200)]
[TASK] Document 'defaultValue' handling of form

The form framework supports setting a 'defaultValue' for most
of the form elements. This patch adds some information about
this setting and outlines the difference to the 'prependOptionValue'
setting.

Resolves: #82422
Releases: master, 8.7
Change-Id: Ic3bbe76ebe69ac0655e11ba501d62ee19b2d143f
Reviewed-on: https://review.typo3.org/56991
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
10 months ago[BUGFIX] Add missing docs for youtube no-cookie domain change 86/56986/4
Mathias Brodala [Thu, 17 May 2018 07:13:20 +0000 (09:13 +0200)]
[BUGFIX] Add missing docs for youtube no-cookie domain change

The doc file was only added for v7, it must also be added to master
and v8.

Resolves: #85029
Related: #84843
Releases: master, 8.7
Change-Id: I2e372eae6bc90a0da0e441237b087b98319a183e
Reviewed-on: https://review.typo3.org/56986
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
10 months ago[TASK] Remove saltedpasswords FE.enabled 79/56979/6
Christian Kuhn [Wed, 16 May 2018 14:29:38 +0000 (16:29 +0200)]
[TASK] Remove saltedpasswords FE.enabled

Manually configuring clear-text password storage in TYPO3 for
frontend users by explicitly setting the ext:saltedpasswords
extension configuration "FE.enabled = 0" has been a bad idea
for a very long time already. The feature has been dropped
for backend users in core v6.2 and is now finally dropped
for frontend users with this patch, too.
No third party service must rely on clear-text password storing
in 2018 anymore, the TYPO3 authentication services provide
an API to process credentials upon user login for authentication
and authorisation purposes.

Resolves: #85027
Related: #85026
Releases: master
Change-Id: I600f598e969ac99a83f3b57362b251b48116fd58
Reviewed-on: https://review.typo3.org/56979
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Keep RecordListController->modTSconfig public 87/56987/2
Christian Kuhn [Thu, 17 May 2018 07:29:20 +0000 (09:29 +0200)]
[BUGFIX] Keep RecordListController->modTSconfig public

For now, we have to keep property modTSconfig public in
RecordListController since it is used from DatabaseRecordList
via infamous $GLOBALS['SOBE'] and otherwise shows deprecation
notices in list module :(

Resolves: #85030
Related: #85016
Releases: master
Change-Id: I40bdd54a89e2282d8403b633fb08c505b214c338
Reviewed-on: https://review.typo3.org/56987
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
10 months ago[BUGFIX] ActionController must not register superfluous validators 01/56901/6
Alexander Schnitzler [Wed, 9 May 2018 13:43:36 +0000 (15:43 +0200)]
[BUGFIX] ActionController must not register superfluous validators

\TYPO3\CMS\Extbase\Mvc\Controller\ActionController::initializeActionMethodValidators
registers a superfluous property validator for simple types. As these
kinds of validators are added through method getBaseValidatorConjunction,
the superfluous registration is removed.

Releases: master
Resolves: #84953
Change-Id: I02fe7863b9014aa6072653d536dfeed67a01deda
Reviewed-on: https://review.typo3.org/56901
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Set opt-in for override checkbox in TCA input elements 86/56486/5
Tim Schreiner [Thu, 29 Mar 2018 21:21:40 +0000 (23:21 +0200)]
[BUGFIX] Set opt-in for override checkbox in TCA input elements

When useOrOverridePlaceholder mode is used for TCA input type,
use opt-in for the checkbox when placeholder is empty.

In some cases, the placeholder can be empty. Especially when the
placeholder uses data from another field. When information is added
to the corresponding field, the input field does not take this in account
because the override checkbox is set by default.

This can lead to problems for title and alternative fields in the
sys_file_metadata table. When adding a file reference and setting the
title or alternative field afterwards in the original file, the reference
is still using the empty override from file reference.

Resolves: #84563
Releases: master, 8.7
Change-Id: I84a37d55a48464b6249fc8bcee405a7cd909016a
Reviewed-on: https://review.typo3.org/56486
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[TASK] Add clarification regarding honeypot and caching 83/56983/4
Björn Jacob [Wed, 16 May 2018 17:30:01 +0000 (19:30 +0200)]
[TASK] Add clarification regarding honeypot and caching

This patch adds some documentation regarding the automatic
inclusion of the honeypot and (static) site caching.

Resolves: #83212
Releases: master, 8.7
Change-Id: I9e7b56a8e515172f6a91274512db13488b41eacb
Reviewed-on: https://review.typo3.org/56983
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
10 months ago[FEATURE] Backend ViewHelpers for edit creation and editing 34/56934/23
Anja [Fri, 11 May 2018 14:37:30 +0000 (16:37 +0200)]
[FEATURE] Backend ViewHelpers for edit creation and editing

Provides Edit- and NewRecord[Link|Uri]ViewHelpers to be used
in all places of the backend, also for extensions.

Remove four dedicated classes from system extensions, that got
replaced with the new implementations.

Also: composer update typo3/testing-framework

Resolves: #84983
Releases: master
Change-Id: I7fc03db101d2f73b63b24e4175d2e02aafa06e95
Reviewed-on: https://review.typo3.org/56934
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
10 months ago[!!!][TASK] Make localization wizard independent of colPos 13/56813/24
Andreas Fernandez [Wed, 25 Apr 2018 17:40:15 +0000 (19:40 +0200)]
[!!!][TASK] Make localization wizard independent of colPos

The localization wizard in the page module offers now a global translate
action per page only. With this change, a user isn't anymore able to
translate content on column basis.

This streamlines the localization process as it lowers the risk of
creating broken localization setups (a.k.a "mixed mode") and it will
simplify the upcoming "Change mode" wizard that enables to switch
between "Free" and "Connected" modes.

Resolves: #84877
Releases: master
Change-Id: Ibfd4641c5a8d3622c86b5a8657af00b2b3122503
Reviewed-on: https://review.typo3.org/56813
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
10 months ago[BUGFIX] getTreeList must return comma-separated list 39/56139/12
Guido Schmechel [Tue, 13 Mar 2018 20:22:03 +0000 (21:22 +0100)]
[BUGFIX] getTreeList must return comma-separated list

While retrieving the list with begin as argument for a
recursive call, getTreeList builds the comma-separated list
correctly.

Resolves: #83328
Releases: master, 8.7, 7.6
Change-Id: I643477dd5c0cbfb67532dd96eb0b479e0cb532b8
Reviewed-on: https://review.typo3.org/56139
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
10 months ago[TASK] Add documentation for DatePicker formats 78/56978/6
Björn Jacob [Wed, 16 May 2018 15:06:16 +0000 (17:06 +0200)]
[TASK] Add documentation for DatePicker formats

This patch adds some documentation for the DatePicker
form element and the available date formats.

Resolves: #82508
Releases: master, 8.7
Change-Id: I1277c024112633ec7e38f4c8cbe30efb97375ce3
Reviewed-on: https://review.typo3.org/56978
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
10 months ago[TASK] Add functional tests for QueryGeneratorTest 74/56974/7
Alexander Schnitzler [Wed, 16 May 2018 10:21:30 +0000 (12:21 +0200)]
[TASK] Add functional tests for QueryGeneratorTest

Releases: master
Resolves: #85024
Change-Id: I623bff02e95056422c1faf859a7d34740ba6b60f
Reviewed-on: https://review.typo3.org/56974
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
10 months ago[TASK] Remove saltedpasswords bulk update task 77/56977/5
Christian Kuhn [Wed, 16 May 2018 09:45:09 +0000 (11:45 +0200)]
[TASK] Remove saltedpasswords bulk update task

This patch is one step into merging the salted passwords
extension code into the core extension, starting with removing
obsolete stuff: The bulk update task is a use-once-throw-away
task aimed to help upgrading systems older than 10 years.
It is removed now. The patch includes an extensive
important ReST file explaining details and alternatives.

Change-Id: I2e9064438e0ac257e95bb0768860f587d8e29375
Resolves: #85022
Releases: master
Reviewed-on: https://review.typo3.org/56977
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[TASK] Streamline TSconfig API 68/56968/7
Christian Kuhn [Tue, 15 May 2018 12:25:27 +0000 (14:25 +0200)]
[TASK] Streamline TSconfig API

Final patch to de-mess the user / page TSconfig related API.

Page TSconfig can be overriden in user TSconfig by prefixing the
path with 'page.' in user TSconfig. However, method
BackendUtility::getModTSconfig() violated this principle and
had a special merge strategy that allowed ommitting the 'page.'
prefix. This has been marked as deprecated in the TSconfig docs for
various years and has been lately removed in the docs altogether,
but the code still existed.
The patch moves this merge into BackendUtility::getPagesTSconfig()
and properly deprecates this case. Usages of getModTSconfig() are
changed to use getPagesTSconfig() directly, dropping the artificial
'properties' and 'value' sub arrays and omitting some rather expensive
string operations at the same time.
This obsoletes getModTSconfig() and a couple of related methods.

Additionally, BackendUserAuthentication->getTSConfig() has been
abused frequently to operate on different arrays than it's own userTS.
Those usages are dropped with the patch. Handing over arguments to
getTSConfig() is now deprecated, effectively reducing the method a getter.

This reduces the API down to BackendUtility::getPagesTSconfig($pid)
and BackendUserAuhtentiction->getTSConfig() both just returning the
entire array. This simplified API can now be documented in the docs.

Change-Id: I4bbb066c1d4e2edbc0182f7967897a1558cc3c0d
Resolves: #85016
Related: #84982
Releases: master
Reviewed-on: https://review.typo3.org/56968
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Fix deletion of invalid tasks 59/56959/3
Mathias Brodala [Mon, 14 May 2018 09:37:57 +0000 (11:37 +0200)]
[BUGFIX] Fix deletion of invalid tasks

If the class of a registered task is missing, e.g. because the related
extension has been removed, the task itself will be unserialized into
an __PHP_Incomplete_Class object. Checking the task execution is an
invalid access in this case and must be avoided for such tasks to be
deleted.

Resolves: #84973
Releases: master, 8.7
Change-Id: Iaec8a5e346a0d6257a942cbead50b214036ed700
Reviewed-on: https://review.typo3.org/56959
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[FEATURE] Show user TSconfig in Configuration module 71/56971/3
Christian Kuhn [Tue, 15 May 2018 15:57:53 +0000 (17:57 +0200)]
[FEATURE] Show user TSconfig in Configuration module

The configuration module gets a new entry showing the
user TSconfig of the currently logged in user.
Note it is not possible to show user TSconfig of a different
user this way, this array is thus basically restricted
to admin users.

Resolves: #85017
Releases: master
Change-Id: Ic078160b2da1f2f5e24f13f9ee9ee708bf9a267e
Reviewed-on: https://review.typo3.org/56971
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: Sascha Maier <sam@amedick-sommer.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
10 months ago[TASK] Remove setting style for broken links in RteHtmlParser 66/56966/2
Sybille Peters [Tue, 15 May 2018 09:35:51 +0000 (11:35 +0200)]
[TASK] Remove setting style for broken links in RteHtmlParser

This is a followup for issue #84987. The style that is now set by
CSS file in rte_ckeditor should no longer be set by a PHP method.

Resolves: #85007
Related: #84987
Releases: master
Change-Id: Ie05ed7153802e6a655b3e6e473129a92db613714
Reviewed-on: https://review.typo3.org/56966
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
10 months ago[BUGFIX] Add css for marking broken links in rte_ckeditor 43/56943/8
Sybille Peters [Sat, 12 May 2018 18:39:29 +0000 (20:39 +0200)]
[BUGFIX] Add css for marking broken links in rte_ckeditor

The styling for broken page links that was added in
RteHtmlParser::markBrokenLinks is by default removed by ckeditor
so this functionality is no longer available by default.

Page links which link to a non-existing page currently already
get the additional attribute a[data-rte-error]. This patch adds
CSS to visually style broken links with a red border and yellow
background. This is the same styling that was previously used.

This is done by adding the plugin showbrokenlinks.

The style is still added in markBrokenLinks. These attributes
will be removed by ckeditor by default. However, the functionality
is kept to function as fallback.

Resolves: #84987
Releases: master, 8.7
Change-Id: I63e1e1db248fb2c343cdd19b41424621b684e87e
Reviewed-on: https://review.typo3.org/56943
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
10 months ago[TASK] Add additional test to ArrayUtility::getValueByPath() 63/56963/2
Christian Kuhn [Tue, 15 May 2018 08:29:56 +0000 (10:29 +0200)]
[TASK] Add additional test to ArrayUtility::getValueByPath()

Verify getValueByPath() can return a sub part of a given array.

Resolves: #85009
Releases: master
Change-Id: Idc77809b960534d2b2694002c792f42d710ffa81
Reviewed-on: https://review.typo3.org/56963
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[FEATURE] Replace @validate with @Extbase\Validate 70/54870/14
Alexander Schnitzler [Tue, 8 May 2018 10:24:49 +0000 (12:24 +0200)]
[FEATURE] Replace @validate with @Extbase\Validate

This patch introduces the "TYPO3\CMS\Extbase\Annotation\Validate"
annotation that replaces the @validate annotation which is
deprecated from now on.

Releases: master
Resolves: #83167
Change-Id: I9a0a3804cfb7429eaf81ec2b3ffa21c3a3d84c63
Reviewed-on: https://review.typo3.org/54870
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Fix display of indexed search advanced search fields 58/56958/5
Gianluca Piccolo [Mon, 14 May 2018 07:42:45 +0000 (09:42 +0200)]
[BUGFIX] Fix display of indexed search advanced search fields

There were some advanced search fields in indexed search that
disappeared after the last update.

In SearchController, method processExtendedSearchParameters, there were
some non-existing variables that were used in some conditions.
With this patch, those variables are initialized before the conditions
and all the advanced search fields in indexed search are shown again.

Releases: master, 8.7
Resolves: #84995
Change-Id: I69aef4c7a3d869d519e84866929f4724c61eabd7
Reviewed-on: https://review.typo3.org/56958
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
10 months ago[BUGFIX] Keep state of extendedSearch 47/55547/5
Peter Niederlag [Wed, 15 Nov 2017 09:53:54 +0000 (10:53 +0100)]
[BUGFIX] Keep state of extendedSearch

formAction has set a bunch of variables that are required by
the frontend for the extendedSearch

Inside searchAction this parameters were not set resulting in
the extendedSearch section being empty in frontend after searching.

With this change the processing of the variables is extracted
into a method and called from formAction and searchAction.

Releases: master, 8.7
Resolves: #82064
Change-Id: Ia21c445ef0aa72e8e084e9bd021bc5caa7a1e74b
Reviewed-on: https://review.typo3.org/55547
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>