Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Fix getTemplatePathAndFilename on StandaloneView 21/51021/7
Claus Due [Thu, 22 Dec 2016 12:28:46 +0000 (13:28 +0100)]
[BUGFIX] Fix getTemplatePathAndFilename on StandaloneView

This patch avoids calling a non-existing method and instead calls
upon TemplatePaths to resolve the template file - which is closer
to the original behavior.

Change-Id: Ib2669056e59bf1a6524e35e02e1f677226a5efa5
Resolves: #79073
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/51021
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add component card 99/53099/8
maikh [Sat, 3 Jun 2017 16:53:41 +0000 (18:53 +0200)]
[TASK] Add component card

Add card component.
Rebuild "about" start page with new card component

Change-Id: I059fae38c96455dc08ff143bd68da3f05fb63fa6
Resolves: #81462
Releases: master
Reviewed-on: https://review.typo3.org/53099
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
2 years ago[BUGFIX] Fix height of the modal content 23/53023/8
Jasmina Liessmann [Fri, 2 Jun 2017 10:15:47 +0000 (12:15 +0200)]
[BUGFIX] Fix height of the modal content

Fix height of the modal content to avoid misbehavior in IE11.

Resolves: #81232
Releases: master, 8.7
Change-Id: I302915e1efcd2040f78db8052dc2e09e06f1dfe4
Reviewed-on: https://review.typo3.org/53023
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make TemplatePaths->fillDefaultsByPackageName sort paths 38/52938/3
Claus Due [Wed, 24 May 2017 15:41:14 +0000 (17:41 +0200)]
[BUGFIX] Make TemplatePaths->fillDefaultsByPackageName sort paths

Due to the sequence of methods being called from this method,
it is necessary to sort TS-configured paths right when they are
resolved instead of passing the unsorted array further down.

Patch also sorts methods protected below public; true diff is
one line. Toggle this line between before/after and run the test
to see the problem demonstrated.

See issue description for a more detailed reasoning.

Change-Id: I0317c4ee683c2fac2c7def7c6d79f947afc4b078
Resolves: #81340
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52938
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Prevent thumbnail generation for non image files 07/53107/6
maikh [Sat, 3 Jun 2017 21:33:01 +0000 (23:33 +0200)]
[TASK] Prevent thumbnail generation for non image files

Check files if they are image files before thumbnail generation.

Change-Id: I7dae2ccbb5ab93e582d21efe8f7d29cf7006a1c3
Resolves: #81147
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53107
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Streamline icons for "new" actions 05/53105/2
Daniel Windloff [Sat, 3 Jun 2017 19:59:08 +0000 (21:59 +0200)]
[FOLLOWUP][TASK] Streamline icons for "new" actions

- actions-add
Link to one new record or a wizard to select the type
of the record
- actions-page-new
Link to one new page record
- actions-document-new
Link to create multiple new records (EditDocumentController)

Resolves: #81428
Releases: master
Change-Id: Ic95a4b3b7727e96a2da818633d03cba7a1c7bde7
Reviewed-on: https://review.typo3.org/53105
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] mssql: A series of functional test fixes 02/53102/2
Christian Kuhn [Mon, 22 May 2017 13:39:09 +0000 (15:39 +0200)]
[TASK] mssql: A series of functional test fixes

A couple of straight patches withis functional test cases
for mssql compatibility:
* Set identity where records with uids are inserted
* Quote LOB fields correctly
* A change to cope with [] encapsulated field and table names

Change-Id: I103021550fbe5c62f15e82454c766d67fc0dc63f
Resolves: #81465
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53102
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Drop ext:typo3db_legacy 12/52612/5
Christian Kuhn [Wed, 26 Apr 2017 13:17:01 +0000 (15:17 +0200)]
[!!!][TASK] Drop ext:typo3db_legacy

The extension containing legacy $GLOBALS['TYPO3_DB'] has been moved to
github at https://github.com/FriendsOfTYPO3/typo3db_legacy
and is available as TER extension and now dropped from core.
An upgrade wizard is added to dowload and install the extension
if needed.

Change-Id: Id99794844e39632a3451e19c7a7d55d47bc3118c
Resolves: #81023
Releases: master
Reviewed-on: https://review.typo3.org/52612
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Tested-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Hide empty descriptions in textmedia in page module 92/53092/2
Jigal van Hemert [Sat, 3 Jun 2017 15:30:39 +0000 (17:30 +0200)]
[BUGFIX] Hide empty descriptions in textmedia in page module

In the Page module with textmedia content elements the descriptions
are shown below the thumbnails of linked media. If there is no
description an empty line is now suppressed.

Resolves: #81408
Releases: master, 8.7, 7.6
Change-Id: I9f342908f179550bcf2156328117c464bb8c672f
Reviewed-on: https://review.typo3.org/53092
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove bower and update Gruntfile.js 89/53089/3
Johannes Goslar [Sat, 3 Jun 2017 13:23:25 +0000 (15:23 +0200)]
[TASK] Remove bower and update Gruntfile.js

Resolves: #81459
Releases: master, 8.7
Change-Id: I213c8d52d8c5ed0d027c1c6e7d01e9bec49ce506
Reviewed-on: https://review.typo3.org/53089
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Tested-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move bower dependencies to npm 78/53078/7
Johannes Goslar [Fri, 2 Jun 2017 22:18:01 +0000 (00:18 +0200)]
[TASK] Move bower dependencies to npm

Resolves: #81448
Resolves: #81449
Resolves: #81450
Releases: master, 8.7
Change-Id: Ic87b62f09d607e7f37491ebec2ea4619bc1aff70
Reviewed-on: https://review.typo3.org/53078
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] DocumentEditController save with translation broken 30/52730/2
Markus Sommer [Fri, 5 May 2017 11:48:09 +0000 (13:48 +0200)]
[BUGFIX] DocumentEditController save with translation broken

With changing the input type=image to input type=submit,
the x/y values are no longer transferred the
EditDocumentController checked for, and content is no
longer saved. Adapt the controller code for the new parameters.

Resolves: #76649
Releases: 8.7, master

Change-Id: I921b92f1086e142592fc84083656c4baecd43aa7
Reviewed-on: https://review.typo3.org/52730
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Show hidden sub group items in be_groups records 85/53085/4
Markus Sommer [Sat, 3 Jun 2017 12:26:25 +0000 (14:26 +0200)]
[TASK] Show hidden sub group items in be_groups records

Show hidden records in the subgroup list of be_group
records, too.

Change-Id: Iaca85f22bdf8a4c308b59fd37bd75b4a913614a0
Resolves: #81452
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53085
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Marco Christian Krenn <krenn@webconsulting.at>
Tested-by: Marco Christian Krenn <krenn@webconsulting.at>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][FEATURE] Collect lost elements and show them separately 82/53082/4
Cybercraft [Sat, 3 Jun 2017 11:46:56 +0000 (13:46 +0200)]
[FOLLOWUP][FEATURE] Collect lost elements and show them separately

Add missing RST file for new feature

Resolves: #67884
Releases: master
Change-Id: I9d7ffa4203cbcec5dac2b5359f418faeaf5462fa
Reviewed-on: https://review.typo3.org/53082
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove CSH on bottom of page module 79/53079/2
Marco Christian Krenn [Sat, 3 Jun 2017 11:13:27 +0000 (13:13 +0200)]
[TASK] Remove CSH on bottom of page module

CSH buttons on bottom of page are removed, text on the top CSH button
is rewriten.

Resolves: #81454
Releases: master
Change-Id: Ie04f8eab19eef996b258808986c05317535b72dc
Reviewed-on: https://review.typo3.org/53079
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Prohibit editing of uneditable labels in pagetree 63/53063/4
Johannes Goslar [Fri, 2 Jun 2017 20:15:16 +0000 (22:15 +0200)]
[BUGFIX] Prohibit editing of uneditable labels in pagetree

Resolves: #81445
Releases: master, 8.7
Change-Id: Ie88eb7ce2fdaf7429377062e86996847f7e9bfa9
Reviewed-on: https://review.typo3.org/53063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Avoid jumping of form fields on focus 69/53069/4
Jasmina Liessmann [Fri, 2 Jun 2017 22:20:30 +0000 (00:20 +0200)]
[BUGFIX] Avoid jumping of form fields on focus

Use absolute position for hints of remaining
characters to prevent form fields from being
moved down.

Resolves: #81447
Related: #77069
Releases: master, 8.7
Change-Id: I8df8cd25955a6ed44bfa5ee727f439856960167f
Reviewed-on: https://review.typo3.org/53069
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Add edit icon to Backend User "Compare" view 76/53076/3
Markus Sommer [Sat, 3 Jun 2017 10:30:21 +0000 (12:30 +0200)]
[FEATURE] Add edit icon to Backend User "Compare" view

Change-Id: I828ed0219033ea8f5ed075eaa4d72c84cdf37414
Resolves: #53685
Releases: master
Reviewed-on: https://review.typo3.org/53076
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Streamline preview icons 57/53057/3
Daniel Windloff [Fri, 2 Jun 2017 17:09:57 +0000 (19:09 +0200)]
[TASK] Streamline preview icons

Usage:
- actions-view-page
Preview a single page record
- actions-view
Preview a single record (except pages)
- actions-document-view
Preview images or documents.
(Preview multiple records)

Resolves: #81429
Releases: master
Change-Id: I7a537b8b171981bcfe3b55d4d4156192f660ba3c
Reviewed-on: https://review.typo3.org/53057
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] Collect lost elements and show them separately from backend layout 40/53040/14
Cybercraft [Fri, 2 Jun 2017 13:20:58 +0000 (15:20 +0200)]
[FEATURE] Collect lost elements and show them separately from backend layout

Resolves: #67884
Releases: master
Change-Id: I7c14886e5dc1c81d7d816e5f2eb5d36afb8cdbf9
Reviewed-on: https://review.typo3.org/53040
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Streamline icons for "new" actions 73/53073/3
Daniel Windloff [Sat, 3 Jun 2017 08:14:00 +0000 (10:14 +0200)]
[TASK] Streamline icons for "new" actions

Usage:
- actions-add-placeholder
Link to wizards / controller where the selection
between serveral kinds of new records can be made
- actions-add
Link to creation form for all records
except pages (EditDocumentController)
-actions-page-new
Link to creation form for page record
-actions-document-new
Link to create multiple new records

Resolves: #81428
Releases: master
Change-Id: I10ced54f5cd8c09c095a699fd0994a9dd5fa0f05
Reviewed-on: https://review.typo3.org/53073
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] CSH on popup window - more link leads to non-existent page 65/53065/4
Oliver Hader [Fri, 2 Jun 2017 21:13:38 +0000 (23:13 +0200)]
[BUGFIX] CSH on popup window - more link leads to non-existent page

Opening CSH help popups from another popup (e.g. add/edit wizard) fails
since the resolved CSH URI is not valid.

Resolves: #80665
Releases: master, 8.7
Change-Id: I16f4dcd037cdb7ab210c083272d0941c979da205
Reviewed-on: https://review.typo3.org/53065
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Move jquery to npm 66/53066/3
Johannes Goslar [Fri, 2 Jun 2017 22:02:01 +0000 (00:02 +0200)]
[TASK] Move jquery to npm

Resolves: #81446
Change-Id: I10fd5950636d2e4b992e1a03f1720759d9e7c55d
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53066
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use reference for label 'bodytext' in CType 'textpic' 64/53064/2
Jasmina Liessmann [Fri, 2 Jun 2017 21:08:14 +0000 (23:08 +0200)]
[TASK] Use reference for label 'bodytext' in CType 'textpic'

Resolves: #81352
Releases: master, 8.7
Change-Id: I7f55e6998ebde5d8d90e7b6bcd05f4550f6ce09a
Reviewed-on: https://review.typo3.org/53064
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] npm script for grunt css build 59/53059/2
Christian Kuhn [Fri, 2 Jun 2017 17:37:45 +0000 (19:37 +0200)]
[TASK] npm script for grunt css build

Execute with "npm run build-css"

Change-Id: Ib5d57df2c6b1281baa245b36ba466524f8db65c0
Resolves: #81442
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53059
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Raise styleguide to 8.0.12 51/53051/6
Christian Kuhn [Fri, 2 Jun 2017 15:39:08 +0000 (17:39 +0200)]
[TASK] Raise styleguide to 8.0.12

A series of bug fixes and most TCA example records
are now multi language aware and the generator creates
multi language data records.

Change-Id: I5fca90642fde64269d08c9fc9f41ad5f949ed8ef
Resolves: #81441
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53051
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update display of form fields in module 'view' 53/53053/2
Jasmina Liessmann [Fri, 2 Jun 2017 16:40:02 +0000 (18:40 +0200)]
[TASK] Update display of form fields in module 'view'

Adapt style of other modules to form fields in module 'view', correct position of resize handle bar.

Resolves: #77576
Releases: master, 8.7
Change-Id: I7366016902ebca8e7da984a52a3b83d8dd227f79
Reviewed-on: https://review.typo3.org/53053
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Add visual difference for elapsed endtime 27/53027/4
Markus Sommer [Fri, 2 Jun 2017 10:33:45 +0000 (12:33 +0200)]
[TASK] Add visual difference for elapsed endtime

Add an icon which indicates that the time is ahead of the endtime of the
record.

Change-Id: I04b3fcd48b554a6a15606ec580f38b2470f0327c
Resolves: #3464
Releases: Master, 8.7
Reviewed-on: https://review.typo3.org/53027
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Update TYPO3 Icons and add to icon registry 49/53049/4
maikh [Fri, 2 Jun 2017 15:03:44 +0000 (17:03 +0200)]
[TASK] Update TYPO3 Icons and add to icon registry

Change-Id: Ibc94a1f0434db96f09ee421cf64867c5779290e7
Resolves: #81426
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53049
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Maik Hagenbruch <typo3@hagenbruch.info>
Tested-by: Maik Hagenbruch <typo3@hagenbruch.info>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Marco Christian Krenn <krenn@webconsulting.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Flexform section container expand / collapse 34/47934/5
Christian Kuhn [Wed, 27 Apr 2016 11:36:16 +0000 (13:36 +0200)]
[BUGFIX] Flexform section container expand / collapse

Change-Id: Ie35ced0d902497a6eacf2d3e9a8463cdd2066ac8
Resolves: #71183
Releases: master
Reviewed-on: https://review.typo3.org/47934
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use actions-remove to remove items from list 39/53039/2
Daniel Windloff [Fri, 2 Jun 2017 13:15:46 +0000 (15:15 +0200)]
[TASK] Use actions-remove to remove items from list

Replaced icons:
-icon-actions-selection-delete
-icon-actions-close

Use actions-remove for remove items from list actions,
that do not change db entries.

Resolves: #81422
Releases: master
Change-Id: I8d11eea1e5801118ebe91faa04187ecda14e5a80
Reviewed-on: https://review.typo3.org/53039
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Add spinner on loading search result 47/53047/2
Markus Sommer [Fri, 2 Jun 2017 14:10:47 +0000 (16:10 +0200)]
[FEATURE] Add spinner on loading search result

Change-Id: I6137830f3ce6c272286161b39fe5c7e82754ce96
Resolves: #81313
Releases: master
Reviewed-on: https://review.typo3.org/53047
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Tested-by: Johannes Goslar <jogo@kronberger-spiele.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add type hints and fix PHPDoc in extbase DataMapFactory 37/52937/3
Stephan Großberndt [Wed, 24 May 2017 13:56:34 +0000 (15:56 +0200)]
[TASK] Add type hints and fix PHPDoc in extbase DataMapFactory

While this is technically a breaking change it only affects internal API.

Releases: master, 8.7
Resolves: #81336
Change-Id: I700caafcfe7f889bba90c03ae7f7010d8228c64a
Reviewed-on: https://review.typo3.org/52937
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Disable a series of functional tests with mssql 42/53042/2
Christian Kuhn [Fri, 2 Jun 2017 13:44:37 +0000 (15:44 +0200)]
[TASK] Disable a series of functional tests with mssql

Disable mysql specific tests for mssql. This list is
nearly identical to the postgres skipped tests.
Only a couple of additional skips are added in extbase where
extbase relies on non standard query constructs that postgres
and mysql support, but mssql doesn't. This will need a more
intrusive change later, but can't be solved easily now.

Change-Id: I0db8f8f094498ff47255c6cd08c03644b58ff4ca
Resolves: #81424
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53042
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update display of table in log module 36/53036/3
Jasmina Liessmann [Fri, 2 Jun 2017 12:57:18 +0000 (14:57 +0200)]
[TASK] Update display of table in log module

Add the possibility to scroll the table respecting the viewport, wrap words in the column 'Details' on desktops

Resolves: #80994
Releases: master, 8.7
Change-Id: Ib684d1747979390b7fa83b30846139bbc17879b8
Reviewed-on: https://review.typo3.org/53036
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][FEATURE] Configurable Route Parameters 37/53037/2
Oliver Hader [Fri, 2 Jun 2017 13:11:56 +0000 (15:11 +0200)]
[FOLLOWUP][FEATURE] Configurable Route Parameters

Switch to new parameters definition for route systeminformation_render.

Resolves: #81409
Releases: master
Change-Id: Icbc85825051e6623e8099aded21957c3d1de3558
Reviewed-on: https://review.typo3.org/53037
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Editing all records after deleting one throws exception 31/53031/9
Oliver Hader [Fri, 2 Jun 2017 11:55:40 +0000 (13:55 +0200)]
[BUGFIX] Editing all records after deleting one throws exception

If some record has been removed in the list module and after that
the "edit marked" button is clicked, an exception is thrown concerning
the just removed record.

The list of records to be edited is now determined from the visible
elements of the list.

Resolves: #75966
Releases: master, 8.7
Change-Id: I2c77dd2d92cda038a1009c318a2ee6650bd82963
Reviewed-on: https://review.typo3.org/53031
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Remove unused IconRegistry instance 38/53038/2
Mona Muzaffar [Fri, 2 Jun 2017 13:08:36 +0000 (15:08 +0200)]
[CLEANUP] Remove unused IconRegistry instance

Resolves: #81421
Releases: master
Change-Id: I7639eb080cd40397d1199b29a9c7abb160915767
Reviewed-on: https://review.typo3.org/53038
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Raise testing-framework to 1.0.7 34/53034/3
Christian Kuhn [Fri, 2 Jun 2017 12:35:50 +0000 (14:35 +0200)]
[TASK] Raise testing-framework to 1.0.7

A couple of bug fixes and preparations for mssql support.

Change-Id: Ia8f874d03a37250d739e6939e36bb04455a85fc4
Resolves: #81419
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53034
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not show hidden tables in LiveSearch 26/53026/2
Susanne Moog [Fri, 2 Jun 2017 10:20:37 +0000 (12:20 +0200)]
[BUGFIX] Do not show hidden tables in LiveSearch

LiveSearch did not check whether the tables were
allowed to be shown (via TCA ctrl hideTable) and
displayed results that were not available after
clicking 'show all'.

Change-Id: I90f61e1156c446cd399c0f26b96bbd30c747554d
Releases: master, 8.7
Resolves: #75651
Reviewed-on: https://review.typo3.org/53026
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Johannes Goslar <jogo@kronberger-spiele.de>
2 years ago[FEATURE] Configurable Route Parameters 00/53000/11
Johannes Goslar [Thu, 1 Jun 2017 16:21:17 +0000 (18:21 +0200)]
[FEATURE] Configurable Route Parameters

Routes definitions are extended by the possibility to defined default
parameters. Those parameters can be overridden during the regular URI
generation process.

Several AjaxRoutes inhibited the backend session update to not keep the
session alive by periodic polling. Those `skipSessionUpdate` parameters
have been removed from the specific URI generation invocations and moved
to the central route definitions.

Resolves: #81409
Releases: master
Change-Id: I1b7c5cfbb3a10cce774e72406115cbac3e2023f1
Reviewed-on: https://review.typo3.org/53000
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Remove disabled button in inline records 70/52970/4
Johannes Schlier [Tue, 30 May 2017 15:23:24 +0000 (17:23 +0200)]
[BUGFIX] Remove disabled button in inline records

If the info icon is disabled it is now removed completely.
Previously the logic for new records was not caught correctly, so that
the case for the enabled icon with a new record was executed.
Disabling the icon should remove it completely,
as a disabled non-clickable icon is not helpful and confusing for editors.
This is now done, and the case for the enabled icon with new records is
also correctly caught.

Resolves: #81380
Releases: master, 8.7
Change-Id: I1c78a99a83efa3c88e3a6337df9cd0c8a959ea7b
Reviewed-on: https://review.typo3.org/52970
Reviewed-by: Daniel Windloff <daniel.jc.windloff@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Tested-by: Daniel Windloff <daniel.jc.windloff@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add background-color to Link Wizard Attribute Container 92/52992/4
Marco Christian Krenn [Thu, 1 Jun 2017 12:55:33 +0000 (14:55 +0200)]
[BUGFIX] Add background-color to Link Wizard Attribute Container

Background color was added to the Link Wizard Attribute Container,
to fit with the leading tab navigation.

Releases: master, 8.7
Resolves: #81404
Change-Id: Idcc009ec2b02da367a1ed749e3a5c746fed43717
Reviewed-on: https://review.typo3.org/52992
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use Fluid standalone TagBuilder object 46/52946/2
Benni Mack [Fri, 26 May 2017 15:43:43 +0000 (17:43 +0200)]
[BUGFIX] Use Fluid standalone TagBuilder object

When instantiating the tag-based viewhelpers and
extbase is in the game, the class alias map is not
taken place, because there is a class expected
which is only in the class alias map, but not
existing anymore.

Instead, the Fluid standalone's TagBuilder object
should be used.

Resolves: #81350
Releases: master, 8.7
Change-Id: I1d3d73a65b4948474dd68c42f43ead454c842ecb
Reviewed-on: https://review.typo3.org/52946
Reviewed-by: Johannes Schlier <johannes.schlier@b13.de>
Tested-by: Johannes Schlier <johannes.schlier@b13.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fixed broken links in file reference list 50/52950/2
Christer Vindberg [Mon, 29 May 2017 08:49:01 +0000 (10:49 +0200)]
[BUGFIX] Fixed broken links in file reference list

Changed so file reference list icon and title links don't throw an
exception

The fluid template used a url as a pageUid, which caused typo3 to
throw an exception.

Resolves: #81357
Releases: master, 8.7
Change-Id: Ibbb8d7d51d1b65e9178082f59e34fdfbb501d2fa
Reviewed-on: https://review.typo3.org/52950
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Faton Haliti <fha@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Raise required PCRE version 36/52936/2
Stephan Großberndt [Wed, 24 May 2017 14:09:18 +0000 (16:09 +0200)]
[BUGFIX] Raise required PCRE version

Warn about an outdated PCRE version which is not compatible to PHP 7.0
in the Install Tool to make aware of possible PHP crashes in the TYPO3
backend.

Releases: master, 8.7
Resolves: #81335
Change-Id: I0db145146eb02bcab81a83195f375c87ae85f3e4
Reviewed-on: https://review.typo3.org/52936
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][BUGFIX] Exchange flag icons from SVG to PNG 19/53019/2
Marco Christian Krenn [Fri, 2 Jun 2017 09:27:01 +0000 (11:27 +0200)]
[FOLLOWUP][BUGFIX] Exchange flag icons from SVG to PNG

Remove flag SVG's from grunt and bower.

Resolves: #76291
Releases: master
Change-Id: I5698c5b23e74848a0330f080845d1d471ac37523
Reviewed-on: https://review.typo3.org/53019
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] SystemInformationMenu: Automatically refresh counter badge 01/53001/5
Johannes Goslar [Thu, 1 Jun 2017 16:22:31 +0000 (18:22 +0200)]
[TASK] SystemInformationMenu: Automatically refresh counter badge

Automatically reload the SystemInformation every 5 minutes.

Resolves: #68920
Releases: master, 8.7
Change-Id: Ie21d345d6bcbbae30f0fd77f084c22b1b2a0f6f2
Reviewed-on: https://review.typo3.org/53001
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Replace pagetree gifs with svg 12/53012/2
Markus Sommer [Thu, 1 Jun 2017 20:59:48 +0000 (22:59 +0200)]
[TASK] Replace pagetree gifs with svg

Change-Id: Ifd4c06ebb7bb670d8f4c17ffbe6b781ee4dfe4da
Resolves: #81412
Releases: master
Reviewed-on: https://review.typo3.org/53012
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Change order of preferred extension icons 02/53002/2
Georg Ringer [Thu, 1 Jun 2017 16:56:49 +0000 (18:56 +0200)]
[TASK] Change order of preferred extension icons

Prefer svg over png icons.

Resolves: #81396
Releases: master, 8.7
Change-Id: Ide44eb1f0c841c788516424fbff01bd319c79104
Reviewed-on: https://review.typo3.org/53002
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Exchange flag icons from SVG to PNG 11/53011/2
Marco Christian Krenn [Thu, 1 Jun 2017 20:53:05 +0000 (22:53 +0200)]
[BUGFIX] Exchange flag icons from SVG to PNG

All flag icons are exchanged to PNG to reduce file size and
fix viewport rendering problem in IE11.

Moved following flag icons from IconRegistry to registerFlags

* flag-an
* flag-cs
* flag-qc

Removed icon 'flag-fam', this was the famfamfam flag and has no use

Remove US states flags

Releases: master, 8.7
Resolves: #76291
Change-Id: I3d45b76901c2584680c8fcaa49aa0fed308405fc
Reviewed-on: https://review.typo3.org/53011
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid unnecessarily fetching file for processing 74/52874/2
Helmut Hummel [Sat, 20 May 2017 09:29:45 +0000 (11:29 +0200)]
[BUGFIX] Avoid unnecessarily fetching file for processing

Files that are not configured as images, won't be processed,
but are still unnecessarily fetched for processing.

To avoid this, we change the processing API, that fetching
only happens, if the file is then used by following code.

In addition we avoid showing a non descriptive thumb
in FileInfoElement, which is used when editing meta data of the file.

Resolves: #81279
Releases: master, 8.7, 7.6
Change-Id: Ie68aa02b1b6149ddb7fbda346ac312d3646e260c
Reviewed-on: https://review.typo3.org/52874
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years agoRevert "[BUGFIX] Avoid duplicates if ReferenceIndex is unable to finish" 21/52921/3
Christian Kuhn [Tue, 23 May 2017 20:39:31 +0000 (22:39 +0200)]
Revert "[BUGFIX] Avoid duplicates if ReferenceIndex is unable to finish"

This reverts commit c2a9726c4efb23d76c084e3319b29f74c14ccdce
from review https://review.typo3.org/#/c/50803/
due to regression in #81320

Change-Id: I496e13ce9efe743a5607e12b46a3fdc90e2f17c2
Resolves: #81320
Reverts: #78829
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52921
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Combine lint task for ci integration and correct code violations 07/53007/3
Benjamin Kott [Thu, 1 Jun 2017 19:05:19 +0000 (21:05 +0200)]
[TASK] Combine lint task for ci integration and correct code violations

Resolves: #81411
Releases: master, 8.7
Change-Id: I2b0f848ee6db870e78d8d102ef48ba2b417f91d7
Reviewed-on: https://review.typo3.org/53007
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix display of content area in modal windows in backend 98/52998/3
Jasmina Liessmann [Thu, 1 Jun 2017 16:17:40 +0000 (18:17 +0200)]
[BUGFIX] Fix display of content area in modal windows in backend

Add scroll possibility for modal body.

Resolves: #81387
Releases: master
Change-Id: I11d54473a6996bee534ea5663cc0de5a4552b66e
Reviewed-on: https://review.typo3.org/52998
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Remove duplicate ViewHelper from extensionmanager 03/52903/3
Claus Due [Mon, 22 May 2017 15:19:02 +0000 (17:19 +0200)]
[TASK] Remove duplicate ViewHelper from extensionmanager

JSON encoding ViewHelper from Fluid is fully compatible.
Also removes a number of unused arguments in the Fluid
template - note that removed ViewHelper declared it was
a tag based ViewHelper which supports additionalAttributes,
but did not render a tag, which is why all the attributes were
simply ignored and unused.

Change-Id: I8d59f5a5e8971aac2b63be86c0a51aaf56437306
Resolves: #81301
Releases: master
Reviewed-on: https://review.typo3.org/52903
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove deprecated f:switch and f:case 15/52915/5
Claus Due [Mon, 22 May 2017 19:02:48 +0000 (21:02 +0200)]
[!!!][TASK] Remove deprecated f:switch and f:case

Counterparts exist in Fluid engine.

Change-Id: I7fd0bc3b5569196858a8f5aa6967de2bf76385b1
Resolves: #81307
Resolves: #81106
Releases: master
Reviewed-on: https://review.typo3.org/52915
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Module menu clicks with slow connections opens standalone module 96/52996/2
Oliver Hader [Thu, 1 Jun 2017 13:57:50 +0000 (15:57 +0200)]
[BUGFIX] Module menu clicks with slow connections opens standalone module

If loading the backend using a slow internet connection an early click on
any item in the module menu on the left side causes the link to be opened
directly. The reason is, that JavaScript and thus click handlers are not
completely loaded yet. Thus, the regular DOM behavior of anchor tags is
executed.

To circumvent this behavior, href-arguments have to be disabled and the
module URL moved to a dedicated new data-attribute. As a result all items
that trigger a module change have to be adjusted as well.

Resolves: #80565
Releases: master, 8.7
Change-Id: I4687e6594eb539acc0d299dc8fc02e6820019911
Reviewed-on: https://review.typo3.org/52996
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove FormatViewHelper of EXT:cshmanual 26/52926/2
Georg Ringer [Wed, 24 May 2017 06:07:11 +0000 (08:07 +0200)]
[TASK] Remove FormatViewHelper of EXT:cshmanual

Instead of using a custom viewhelper in the EXT:cshmanual use the
ViewHelpers of fluid and chain those.

Resolves: #81324
Releases: master

Change-Id: I7b936b0d684333909c71f35bfe8156a51688646a
Reviewed-on: https://review.typo3.org/52926
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <service@enobe.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Require bower and have node build scripts 03/53003/2
Christian Kuhn [Thu, 1 Jun 2017 17:06:43 +0000 (19:06 +0200)]
[TASK] Require bower and have node build scripts

In preperation of a scss linter and typescript linter
we require bower as root dev dependency and register
some happy little scripts.

Change-Id: I425fd848a4012065fc7d955be0ae961f0f2ee8c4
Resolves: #81410
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53003
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid jumping of form fields on focus 97/52997/3
Jasmina Liessmann [Thu, 1 Jun 2017 14:11:43 +0000 (16:11 +0200)]
[BUGFIX] Avoid jumping of form fields on focus

Use absolute position for hints of remaining
characters to prevent form fields from being
moved down.

Resolves: #77069
Releases: master, 8.7
Change-Id: Iacba62543b036309e17828ab86f1986eb65f36a0
Reviewed-on: https://review.typo3.org/52997
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Add NPM package lock file 93/52993/4
Benjamin Kott [Thu, 1 Jun 2017 13:05:27 +0000 (15:05 +0200)]
[TASK] Add NPM package lock file

The file describes the exact tree that was generated, such that
subsequent installs are able to generate identical trees, regardless
of intermediate dependency updates.

https://docs.npmjs.com/files/package-lock.json

Resolves: #81406
Releases: master
Change-Id: I8c2f0d7a8d6a1d0cd7434d8e753a32d387b32f8f
Reviewed-on: https://review.typo3.org/52993
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] trigger Backend.doLayout() on window resize 91/52991/2
Johannes Goslar [Thu, 1 Jun 2017 12:26:47 +0000 (14:26 +0200)]
[BUGFIX] trigger Backend.doLayout() on window resize

Resolves: #78464
Releases: master, 8.7
Change-Id: I8d861df1e047213a355d145e05a9131386c7439f
Reviewed-on: https://review.typo3.org/52991
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[TASK] Functionals: Rename "@group mysql" to "@group not-postgres" 84/52984/3
Christian Kuhn [Wed, 31 May 2017 20:28:12 +0000 (22:28 +0200)]
[TASK] Functionals: Rename "@group mysql" to "@group not-postgres"

Functional tests annotated with "@group mysql" are currently ignored
if running tests on postgres via "--exclude-group mysql" argument.
With mssql we have some tests that run fine with mysql and postgres,
but not with mssql.
To improve handling, "@group mysql" annotation is renamed
to "@group not-postgres". Tests not available on postgres and mssql
will then later have a second annotation "@group not-mssql".
This way its easier to keep track which tests go red on which DBMS.

Change-Id: I2522b00352f1a7d61479588a22cdd9ea5d454ca3
Resolves: #81394
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52984
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Reduce cache gets in MarkerBasedTemplateService 74/52974/2
Claus Due [Tue, 30 May 2017 22:42:10 +0000 (00:42 +0200)]
[CLEANUP] Reduce cache gets in MarkerBasedTemplateService

Multiple calls to get() from cache can be condensed to one.

Change-Id: I1d949fcbc0c91afdbfb2d0e2bc3d9c1b4dfd475a
Resolves: #81385
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52974
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Refactor ext:impexp functional tests 80/52980/6
Christian Kuhn [Wed, 31 May 2017 15:18:15 +0000 (17:18 +0200)]
[TASK] Refactor ext:impexp functional tests

The ext:impexp functional tests are rather hard to read and
follow. The patch untangles them to make them better maintainable:

* Combine the two different import / export abstract classes into 1 class
* Don't inherit from AbstractDataHandlerActionTestCase anymore
* Give single test cases better file names and do not hide them in sub dirs
* Move all fixtures to Fixtures/ dir
* Use less helper methods to import and test things
* File paths are more straight and with less helper magic

Change-Id: Iae36771b94045f99444f394129cbcf183168b584
Resolves: #81393
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52980
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix typos in upgrade wizards of Install Tool 73/52973/2
Georg Ringer [Tue, 30 May 2017 19:57:46 +0000 (21:57 +0200)]
[TASK] Fix typos in upgrade wizards of Install Tool

Use the term "Upgrade wizard" instead of "Update wizard"
for the buttons of the single steps as the main menu item
is also called "Upgrade wizard".

Resolves: #81383
Releases: master, 8.7
Change-Id: I8047ae45101533a67fa4488af7040acc49af563f
Reviewed-on: https://review.typo3.org/52973
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[FOLLOWUP][TASK] Squeeze every bit of performance from CGL fixer 39/52939/2
Elmar Hinz [Wed, 24 May 2017 16:10:23 +0000 (18:10 +0200)]
[FOLLOWUP][TASK] Squeeze every bit of performance from CGL fixer

Support case sensitve file systems again.

Releases: master, 8.7
Resolves: #80814
Change-Id: I82274b328e9cfa75fb35360145d7a668d1270dc3
Reviewed-on: https://review.typo3.org/52939
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Ensure correct URL generation with http_build_query() 34/52934/4
Markus Klein [Wed, 24 May 2017 12:09:42 +0000 (14:09 +0200)]
[BUGFIX] Ensure correct URL generation with http_build_query()

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
This does not seem appropriate for URLs generated by TYPO3.

Use the optional parameters of http_build_query() to get the desired
functionality.

Releases: master, 8.7, 7.6
Resolves: #81366
Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf
Reviewed-on: https://review.typo3.org/52934
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Extbase: Pass parameter to real raw queries 63/52863/2
Daniel Goerz [Fri, 19 May 2017 12:02:56 +0000 (14:02 +0200)]
[BUGFIX] Extbase: Pass parameter to real raw queries

Resolves: #81272
Releases: master, 8.7
Change-Id: Iac3d486697b8c52fbace185ab1a55c514847db07
Reviewed-on: https://review.typo3.org/52863
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[CLEANUP] Remove unused parameter in workspaces hook implementation 24/52924/6
Georg Ringer [Wed, 24 May 2017 05:05:38 +0000 (07:05 +0200)]
[CLEANUP] Remove unused parameter in workspaces hook implementation

Remove the last parameter of method makeEditForm_accessCheck
in BackendUtilityHook as it is unused.

Resolves: #81290
Releases: master
Change-Id: I46a8d88273765762c6dbc8793b76e35b5a2b6653
Reviewed-on: https://review.typo3.org/52924
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Properly escape <> in Install Tool Check. 25/52925/3
Georg Ringer [Wed, 24 May 2017 05:47:12 +0000 (07:47 +0200)]
[BUGFIX] Properly escape <> in Install Tool Check.

Escape the < > in the check of the Windows Apache ThreadStackSize.

Resolves: #81134
Releases: master, 8.7
Change-Id: Iaa73e61438766f413ba7aeeaebac0fcbf41f1a99
Reviewed-on: https://review.typo3.org/52925
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Make encoding of parameters for cHash independent of PHP settings 22/52922/2
Markus Klein [Tue, 23 May 2017 20:51:35 +0000 (22:51 +0200)]
[BUGFIX] Make encoding of parameters for cHash independent of PHP settings

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
Our code relies on having a simple ampersand as this character.
If the PHP is set to a different configuration the code will fail.

This is fixed by enforcing the ampersand. Moreover we force RFC3986
encoding to ensure that decoding with rawurldecode() does the right
thing.

Releases: master, 8.7
Resolves: #81293
Change-Id: I321c7bba03ee597adc29a2f8429b8fc9ac3b709d
Reviewed-on: https://review.typo3.org/52922
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Carsten Falkenberg <office@limebox.de>
Tested-by: Carsten Falkenberg <office@limebox.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Explicit cast to string for VersionState object 16/52916/3
Christian Kuhn [Mon, 22 May 2017 21:12:31 +0000 (23:12 +0200)]
[BUGFIX] Explicit cast to string for VersionState object

Some DB drivers are picky on their arguments not being
objects. Add an explicit cast to string for a VersionState
object just before it's fed to a query as argument.

Change-Id: I81c8f9dded7068ad7bf817e034aa67a29f28290c
Resolves: #81309
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52916
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use correct constructor argument for TableDiff 72/52872/6
Stephan Großberndt [Fri, 19 May 2017 17:33:14 +0000 (19:33 +0200)]
[BUGFIX] Use correct constructor argument for TableDiff

Using the correct datatype "string" instead of a
\Doctrine\DBAL\Schema\Identifier as TableDiff->name prevents exceptions
if another SchemaEventSubscriber is registered.

Releases: master, 8.7
Resolves: #81276
Change-Id: If273a165604ff3149d8e5aba2c0b5ccbdef8102d
Reviewed-on: https://review.typo3.org/52872
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Avoid DBAL\Exception on unknown data type in Install Tool 58/52858/2
Stephan Großberndt [Fri, 19 May 2017 06:35:30 +0000 (08:35 +0200)]
[BUGFIX] Avoid DBAL\Exception on unknown data type in Install Tool

Using $connection->getSchemaManager()->listTableNames() instead of
->listTables() in Install Tool prevents a DBAL\Exception as the table
details are not requested - which are not used anyway, so this is
faster too.

Releases: master, 8.7
Resolves: #81264
Change-Id: I35db1b6fa743ad4869bf2ba24717320f0f009995
Reviewed-on: https://review.typo3.org/52858
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Re-enable passing tests in SchemaMigratorTest 05/52905/2
Stephan Großberndt [Mon, 22 May 2017 16:00:00 +0000 (18:00 +0200)]
[TASK] Re-enable passing tests in SchemaMigratorTest

Re-enable the tests passing tests changeExistingColumn() and
installDoesNotAddIndexOnChangedColumn() in SchemaMigratorTest.

Resolves: #81302
Releases: master, 8.7
Change-Id: Idaf9d87c16d58864c6de3353ec68be46ae93024f
Reviewed-on: https://review.typo3.org/52905
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Squeeze every bit of performance from CGL fixer 17/52417/14
Claus Due [Tue, 11 Apr 2017 18:23:31 +0000 (20:23 +0200)]
[TASK] Squeeze every bit of performance from CGL fixer

This patch reduces the amount of time required to check
CGL to less than 3% of what it was before when xdebug
is loaded and the script is asked to check ~100 files.

Time before: 17m
Time after: 23.3s

Change-Id: I533ac3bfd03922362ccd6180caf6df2bfecd5bac
Releases: master, 8.7
Resolves: #80814
Reviewed-on: https://review.typo3.org/52417
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Extract datahandling framework to testing-framework 28/52728/9
Anja Leichsenring [Sat, 20 May 2017 16:36:34 +0000 (18:36 +0200)]
[TASK] Extract datahandling framework to testing-framework

Ext:core comes with a little testing framework for functional tests,
that is pretty useful for all kind of DataHandler related tests. Those
classes are better located in the testing-framework package to be
available.

Change-Id: I429e801b7318fda3a96acb4f5f63bb75050fb3e3
Resolves: #81154
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52728
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove usage of PATH_typo3conf from ConfigurationManager 79/52879/5
Anja Leichsenring [Sat, 20 May 2017 17:57:23 +0000 (19:57 +0200)]
[TASK] Remove usage of PATH_typo3conf from ConfigurationManager

Resolves: #81284
Releases: master, 8.7
Change-Id: I59730f5807d27bbc7eb232917763daa89f41315a
Reviewed-on: https://review.typo3.org/52879
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cache results in doesRecordExist_pageLookUp 16/51516/12
Thomas Hohn [Fri, 3 Feb 2017 09:00:02 +0000 (10:00 +0100)]
[TASK] Cache results in doesRecordExist_pageLookUp

Copying big sub-trees can benefit from caching the calls
to doesRecordExist_pageLookUp in a run-time cache since
there are a lot of identical calls to the database.

In addition the signature was adjusted - see also the already
merged issue #77391 which altered the signature.

Resolves: #79610
Releases: master
Change-Id: I2da164193f13759123d57c17985be46e7bd7667b
Reviewed-on: https://review.typo3.org/51516
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Tested-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Acceptance test installing TYPO3 on mysql 80/52880/5
Christian Kuhn [Sat, 20 May 2017 19:12:30 +0000 (21:12 +0200)]
[TASK] Acceptance test installing TYPO3 on mysql

A basic acceptance tests clicking through installer
using a mysql db connection, checking backend login
and "blank" site frontend output works.

Change-Id: Ie14d9c6fd8280d382b4041f98fa04ed00ef8386c
Resolves: #81285
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52880
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Claus Due <claus@phpmind.net>
2 years ago[BUGFIX] Embed parameters in SQL fragment create by getSelectQuery 72/52472/7
Christer Vindberg [Tue, 18 Apr 2017 10:28:07 +0000 (12:28 +0200)]
[BUGFIX] Embed parameters in SQL fragment create by getSelectQuery

Use quoted/escaped values embedded in the SQL fragment instead of named
parameters in QueryGenerator::getSelectQuery. The values of named
parameters get lost when the SQL fragment is returned and subsequently
used in a query.

Resolves: #80872
Releases: master, 8.7
Change-Id: If22bf24b75d2aa0efe36e587e38e7c590f3ec34a
Reviewed-on: https://review.typo3.org/52472
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Tested-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Minor CGL cleanup makes php-cs-fixer happy 89/52889/2
Christian Kuhn [Sun, 21 May 2017 12:43:04 +0000 (14:43 +0200)]
[TASK] Minor CGL cleanup makes php-cs-fixer happy

Change-Id: I4ce5bae6d200bbd7eba6679136375c71cfb6e268
Resolves: #81289
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52889
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update typo3/testing-framework to 1.0.6 85/52885/3
Christian Kuhn [Sat, 20 May 2017 23:23:05 +0000 (01:23 +0200)]
[TASK] Update typo3/testing-framework to 1.0.6

A couple of bug fixes and a setup for acceptance tests
of the installation procedure.

Change-Id: I97c211acb6f65a48ee90a45885887f8d16f800b9
Resolves: #81287
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52885
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Review comment and sig of addMountPointParameterToPage() 77/52877/4
Elmar Hinz [Sat, 20 May 2017 13:03:14 +0000 (15:03 +0200)]
[CLEANUP] Review comment and sig of addMountPointParameterToPage()

Releases: master, 8.7
Resolves: #81280
Change-Id: I8689827c9e33202e7659a39bb55e7a9bfd792aa2
Reviewed-on: https://review.typo3.org/52877
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup .gitignore components directory 81/52881/2
Christian Kuhn [Sat, 20 May 2017 19:19:48 +0000 (21:19 +0200)]
[TASK] Cleanup .gitignore components directory

The components/ directory has been a temporary directory in v8 phase,
does not exist anymore and can be removed from .gitignore.

Change-Id: I0f690c8fb38733dc8d168a7e43078dffc60450ea
Resolves: #81286
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52881
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make sure relative URL receives a proper host part for errorpage 59/52859/5
Anja Leichsenring [Fri, 19 May 2017 09:46:40 +0000 (11:46 +0200)]
[BUGFIX] Make sure relative URL receives a proper host part for errorpage

If the code given for PageNotFound_handling is a relative URL, the host
determination gets skipped, resulting in a redirect of the markup of
the page instead a proper redirect.

Change-Id: Id9c26cba813c212438368cee031673dc59db360b
Resolves: #81267
Relates: #81031
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52859
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prevent duplicated special char in backend breadcrumb 20/52820/3
Thomas Schur [Wed, 17 May 2017 11:09:03 +0000 (13:09 +0200)]
[BUGFIX] Prevent duplicated special char in backend breadcrumb

Prevent duplicated special char conversion of page title in
TYPO3 backend breadcrumb and fix title cropping

Resolves: #81242
Releases: master, 8.7
Change-Id: Id7710d8d8f79e20b20f43569558833d3d3f68f16
Reviewed-on: https://review.typo3.org/52820
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix typo in rst file 55/52855/2
Josef Glatz [Thu, 18 May 2017 14:31:50 +0000 (16:31 +0200)]
[BUGFIX] Fix typo in rst file

Related: #81171
Resolves: #81258
Releases: master
Change-Id: I2a07571bb45aefd5927498dee5604edb99ba271b
Reviewed-on: https://review.typo3.org/52855
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
2 years ago[BUGFIX] Remove doubled SQL query in PageRepository 54/52754/3
Benni Mack [Thu, 11 May 2017 06:22:13 +0000 (08:22 +0200)]
[BUGFIX] Remove doubled SQL query in PageRepository

The method PageRepository->checkWorkspaceAccess() does a SQL query to fetch
the workspace record, then hands it over to BE_USER->checkWorkspace which has the
same functionality - to fetch the full workspace record.

As this is redundant code, the PageRepository code can be simplified a lot by just leaving
the workspaceCache property.

Resolves: #81187
Releases: master, 8.7
Change-Id: Ia82febb2269084ea9101acfc36a1c9aa20950290
Reviewed-on: https://review.typo3.org/52754
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Page tree request in a workspaces times out 06/52506/4
Oliver Hader [Wed, 19 Apr 2017 19:24:38 +0000 (21:24 +0200)]
[BUGFIX] Page tree request in a workspaces times out

Tryign to determine workspace versions for a particular database table
results in a very long process execution time and possible timeout due
to the following reasons:

* in general a bug was introduced during the Doctrine DBAL migration
  which leads to misbehaviors in resolving versions for pages
* the SQL query implicitly creates an INNER JOIN with a huge result
  set that takes a long query time
* invalid types leading to possible flaws when using prepared statements

The SQL query has been split into using sub-queries now.

Change-Id: I4e4f69815bd73f0562f7ffbd6d411b417be7a18a
Resolves: #80898
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52506
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Streamline icons (order/style) in InlineRecordContainer 04/50104/13
Daniel Windloff [Fri, 7 Oct 2016 12:05:47 +0000 (14:05 +0200)]
[TASK] Streamline icons (order/style) in InlineRecordContainer

In order to be consistent, change the button order and styling
(according to the list module) in the InlineRecordContainer.

Resolves: #78174
Releases: master, 8.7
Change-Id: I2f4498f1e822785c2b26dab697ec4fe26aae5ef0
Reviewed-on: https://review.typo3.org/50104
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix wrong comment in TSFE for xhtmlDoctype property 00/52800/3
Jochen Greiner [Sat, 13 May 2017 17:11:52 +0000 (19:11 +0200)]
[BUGFIX] Fix wrong comment in TSFE for xhtmlDoctype property

The comment was wrong because the TSFE-Controller
takes care of setting this option internally.

Resolves: #81219
Releases: master, 8.7
Change-Id: If4af5b5aefa2758063e595e9e3e0b55892c7df27
Reviewed-on: https://review.typo3.org/52800
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Render prepended option tag always in first place 01/51501/4
Marcus Schwemer [Sun, 22 Jan 2017 21:24:39 +0000 (22:24 +0100)]
[BUGFIX] Render prepended option tag always in first place

Currently the prepend option is rendered together with the options
argument from select viewhelper. Using the option "optionsAfterContent"
renders also the prepend option after the children. The preprend
option is now rendered always in the first place.

Resolves: #79584
Releases: master, 8.7
Change-Id: Ia58c3b7d9b26d00cbda4d7ebce2a881a7129b331
Reviewed-on: https://review.typo3.org/51501
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Typo3DBQueryParser fails to wrap subselect in braces 17/52817/2
Thomas Maroschik [Wed, 17 May 2017 10:30:18 +0000 (12:30 +0200)]
[BUGFIX] Typo3DBQueryParser fails to wrap subselect in braces

When the Typo3DBQueryParser converts Extbase queries to Doctrine
queries, it creates subselects for certain relation constraints.
It fails to wrap the subselect in braces for has-many relations
which leads to sql exceptions.

This patch introduces braces around those subselects.

Change-Id: Ie9721a01bf166391770c7a1471272af0e15f9ccb
Fixes: #81240
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52817
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use different field for logging in EXT:scheduler 53/52553/4
Georg Ringer [Fri, 21 Apr 2017 20:37:36 +0000 (22:37 +0200)]
[BUGFIX] Use different field for logging in EXT:scheduler

The public method Scheduler::log accepts an optional $code as 3rd
parameter. Add this information to the parameter $details of
BackendUserAuthentication::writelog as otherwise it will be
casted to an integer and its information will be lost.

Resolves: #80592
Releases: master, 8.7
Change-Id: Iab5f1d285976e9e88795ebbe75faff9f689b1a8c
Reviewed-on: https://review.typo3.org/52553
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Drop dedicated edit view in EXT:tstemplate 96/52696/9
Andreas Fernandez [Wed, 3 May 2017 18:19:24 +0000 (20:19 +0200)]
[!!!][TASK] Drop dedicated edit view in EXT:tstemplate

Triggering ext:t3editor out-of-bound of FormEngine is pretty tricky and
blocks further development of t3editor. To streamline this, the
current implementation of t3editor within ext:tstemplate is revamped
and now uses FormEngine directly to edit "constants" and "setup" of
template records.
Some hooks are now obsolete and dropped along the way.

Resolves: #81171
Releases: master
Change-Id: Iab62a15828bfb82bc9f8ad11f705bb4529a38734
Reviewed-on: https://review.typo3.org/52696
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Update comment of PageRepository::getMountPointInfo() 42/52842/6
Elmar Hinz [Thu, 18 May 2017 10:48:05 +0000 (12:48 +0200)]
[CLEANUP] Update comment of PageRepository::getMountPointInfo()

Update the comment of the mehtod PageRepository::getMountPointInfo().
Add hint addressing to the usage of recursive mount points.

Change-Id: I095563cb940e25f8c5f004497d407733faf4cbcc
Releases: master, 8.7
Resolves: #81254
Reviewed-on: https://review.typo3.org/52842
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Bootstrap: Load TCA configuration on every request 53/52753/3
Benni Mack [Thu, 11 May 2017 06:18:22 +0000 (08:18 +0200)]
[TASK] Bootstrap: Load TCA configuration on every request

By moving Bootstrap::loadBaseTca() to the configure() call of the
TYPO3 Bootstrap, the global TCA variable is now populated very early
and it is obvious that this logic is then part of the actual system setup,
and does not need to be handled by any RequestHandler anymore.

Considering TCA is necessary for a TYPO3 environment to run,
this change might be very helpful.

Please note that the Install Tool application does not call
configure(), so this is not affected.

This also removes some issues related to Extbase
Command controllers in CLI handling.

Side effects:
- eID requests now have full TCA loaded as well at any time
- TCA is now loaded BEFORE entering any request handler check
- TCA is now loaded before e.g. BackendRouting initialization, and other Backend security checks

Easy to test the current behaviour:
- Clear all caches via install tool
- Call CLI command extbase:help which will result in a Warning / Exception

Resolves: #72222
Resolves: #81201
Releases: master
Change-Id: I31a0de0d0b039eb6180123678c61d3f26435dd63
Reviewed-on: https://review.typo3.org/52753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>