Packages/TYPO3.CMS.git
5 years ago[!!!][SECURITY] Remove old backend_layout wizard 21/28121/2
Wouter Wolters [Thu, 6 Mar 2014 20:44:02 +0000 (21:44 +0100)]
[!!!][SECURITY] Remove old backend_layout wizard

Keeping the old wizard script would not solve
the CSRF attack vector as they could still
be referenced in this kind of attack.

Because of that, we remove it now.

This change provides a backwards compatibility layer.

It will however break code which link to the
old scripts directly in other places.

Resolves: #56625
Releases: 6.2
Change-Id: I07577dca0e16cf095e114799ace4a6e344ad5aa3
Reviewed-on: https://review.typo3.org/28121
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] ExtendedFileUtility.php: func_delete 19/28019/2
Rico Sonntag [Tue, 4 Mar 2014 07:23:26 +0000 (08:23 +0100)]
[BUGFIX] ExtendedFileUtility.php: func_delete

This fixes an issue within method func_delete trying to catch a file
access exception instead of expected folder access exception during
delete of an folder.

Change-Id: Iaf76100cd668ef4b1a36a5d9052a6f185ffa6b7b
Resolves: #56511
Releases: 6.2
Reviewed-on: https://review.typo3.org/28019
Reviewed-by: Frans Saris
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] FAL readonly: Directory copying results in BE exception 94/27994/2
Rico Sonntag [Mon, 3 Mar 2014 13:51:55 +0000 (14:51 +0100)]
[BUGFIX] FAL readonly: Directory copying results in BE exception

Changed parent class of folder permission exceptions to
InsufficientFolderAccessPermissionsException so excecption
could be catched properly.

Change-Id: I1c85e4c0e4652f1e3394fd58f98d95ea6ca8cc34
Resolves: #56494
Releases: 6.2
Reviewed-on: https://review.typo3.org/27994
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] UnitTests create SQL error if openid is installed 90/28090/3
Philipp Gampe [Thu, 6 Mar 2014 02:07:16 +0000 (03:07 +0100)]
[BUGFIX] UnitTests create SQL error if openid is installed

AbstractUserAuthenticationTest is actually supposed to test
processLoginData from AuthenticationService from ext:sv.
However it fails to properly setup all auth parameters, therefore auth
services that depend on further settings fail.

This moves the test to the actually tested code (extension sv).
The test is adopted accordingly.

Additionally both tests are cleaned up from unneeded setUp/tearDown
functions.

Resolves: #56586
Releases: 6.2
Change-Id: I7406a56e5274ea54d400c1c116a8ea81c5cf4cea
Reviewed-on: https://review.typo3.org/28090
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Remove superflous check in getModuleUrl 18/28118/3
Helmut Hummel [Thu, 6 Mar 2014 19:51:59 +0000 (20:51 +0100)]
[BUGFIX] Remove superflous check in getModuleUrl

There is a check in getModuleUrl that checks
access rights to modules and returns false
if this is not the case.

However access rights are checked in each
module independently anyway.

So we remove this check here.

Resolves: #56611
Releases: 6.2
Change-Id: I63901cba3e882aab23de17929a461f08bd899cf1
Reviewed-on: https://review.typo3.org/28118
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Remove wrong quoting 19/28119/3
Helmut Hummel [Thu, 6 Mar 2014 20:33:21 +0000 (21:33 +0100)]
[BUGFIX] Remove wrong quoting

While moving the element browser to a module
quoting was added in several places.

However quoting DocumentTemplate::issueCommand
calls does not work, as the returned string
contains JavaScript.

Remove the quoting in these places.

Resolves: #56622
Releases: 6.2
Change-Id: I1b9ec8b4a5900940a5c5dfd81ed712f2994ecef3
Reviewed-on: https://review.typo3.org/28119
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] concatenateCSS may produce invalid css 23/22623/7
Stefan Neufeind [Sun, 24 Nov 2013 22:11:18 +0000 (23:11 +0100)]
[BUGFIX] concatenateCSS may produce invalid css

css-files with statements like @import might become corrupted. This is due
a wrong regex in case no quotes (single or double) are provided.

Adjust regex and add testcases.

Resolves: #50491
Releases: 6.2, 6.1
Change-Id: I8c35be97147da51e3cfc4be6de114f3c19c1abca
Reviewed-on: https://review.typo3.org/22623
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Redirect to distributions after first login 66/27866/5
Benjamin Mack [Wed, 26 Feb 2014 12:24:55 +0000 (13:24 +0100)]
[TASK] Redirect to distributions after first login

For the users to select a distribution, the installation should
redirect directly to the extension manager, after the first
login of the admin, who set up the site.

Then, the list of TER extensions is loaded initially and all
distributions are shown.

For this to happen, the install tool needs to add another option
that sets a UC flag in the just created admin user.
This UC flag is evaluated when the start module is to be shown.

Also, it adds some more logic when redirecting to the start module
to allow to directly jump to a modfunc/action.

Additionally, the distribution action should initially load all
extensions from TER on first hit.

Releases: 6.2
Resolves: #56321
Change-Id: I1e86b5804011e84f7936514e4b88c4a257905e56
Reviewed-on: https://review.typo3.org/27866
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Fatal error in database connect install step 02/28102/2
Christian Kuhn [Thu, 6 Mar 2014 12:57:45 +0000 (13:57 +0100)]
[TASK] Fatal error in database connect install step

Patch df239a6d599 renamed bootstrap method setCoreCacheToNullBackend
to disableCoreAndClassesCache but missed a usage in installer.

Change-Id: Ie4939384a7c476c489d8734ecd7badf5f0dcebdc
Resolves: #56605
Related: #56583
Releases: 6.2
Reviewed-on: https://review.typo3.org/28102
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Reduce memory footprint of unit test suite 89/28089/2
Christian Kuhn [Wed, 5 Mar 2014 22:37:38 +0000 (23:37 +0100)]
[TASK] Reduce memory footprint of unit test suite

Switching to transientMemoryBackend for some caches raises the
memory footprint of unit test. Change the bootstrap a bit to not
use this cache backend in unit tests.

Change-Id: I3bc4774c4c9c6a24314681491bfdf23a9eab570d
Resolves: #56585
Related: #56583
Releases: 6.2
Reviewed-on: https://review.typo3.org/28089
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Follow up: Remove icon doesn't work 10/28010/4
Nicole Cordes [Mon, 3 Mar 2014 22:18:51 +0000 (23:18 +0100)]
[BUGFIX] Follow up: Remove icon doesn't work

With patch 6711c14 the function setFormValueManipulate was corrected but
if called it returns an array instead of the first form element. This
patch makes sure that the first object is always returned.

Resolves: #56221
Releases: 6.2
Change-Id: I03445afcb15d9323cd899974ac1cf378945e4ecb
Reviewed-on: https://review.typo3.org/28010
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Make text in All Configuration selectable 82/27882/2
Markus Klein [Wed, 26 Feb 2014 20:36:13 +0000 (21:36 +0100)]
[BUGFIX] Make text in All Configuration selectable

Remove the click function on the whole item.
This prevents selecting the text.
The input fields are be enough to select them easily.

Resolves: #56350
Releases: 6.2
Change-Id: I929ef24383460964288696d268959b32fae3b705
Reviewed-on: https://review.typo3.org/27882
Reviewed-by: Jost Baron
Tested-by: Jost Baron
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Add functional tests for impexp irre records 93/27993/3
Marc Bastian Heinrichs [Fri, 28 Feb 2014 17:56:33 +0000 (18:56 +0100)]
[TASK] Add functional tests for impexp irre records

This patch adds functional tests for exporting and
importing all irre_tutorial relation types.

Resolves: #56287
Releases: 6.2
Change-Id: I9fe650151cca11e1f7fcb0d4b1d3ebdbbc0b75ad
Reviewed-on: https://review.typo3.org/27993
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix no caching behavior of bootstrap 88/28088/4
Helmut Hummel [Thu, 27 Feb 2014 14:09:23 +0000 (15:09 +0100)]
[BUGFIX] Fix no caching behavior of bootstrap

Install Tool and tests are intended to work
without caches being active.

Currently this functionality is broken in bootstrap
because it is applied too late and does not
respect classes cache.

Resolves: #56583
Releases: 6.2
Change-Id: I45bb11d3b7951b189c1f12c3da6969285575d72b
Reviewed-on: https://review.typo3.org/28088
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Extend functional tests with creation of additional folders 79/27779/4
Marc Bastian Heinrichs [Fri, 21 Feb 2014 17:32:41 +0000 (18:32 +0100)]
[TASK] Extend functional tests with creation of additional folders

Extends the functional tests with the possibility to create additional
folders inside the TYPO3 CMS test instance created within typo3temp.

Resolves: #56194
Releases: 6.2
Change-Id: I3271b3877fc953a2d876e56fc18af823d2e2a609
Reviewed-on: https://review.typo3.org/27779
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Bernhard Kraft
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Functional tests for persisting relations in Extbase 92/27492/4
Tymoteusz Motylewski [Sat, 8 Feb 2014 20:33:13 +0000 (21:33 +0100)]
[TASK] Functional tests for persisting relations in Extbase

Add functional tests for persisting 1:M and M:M relations
in Extbase.
This patch adds blog_example as an fixture extension.

Resolves: #55786
Releases: 6.2
Change-Id: If90c854c9cb86fd45dcdbc14319a0a416e9447a0
Reviewed-on: https://review.typo3.org/27492
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Import/Export Module uses module dispatcher 63/28063/7
Anja Leichsenring [Tue, 4 Mar 2014 20:35:35 +0000 (21:35 +0100)]
[TASK] Import/Export Module uses module dispatcher

Change-Id: I1ac785adf3b0573a50954855befdda838fd01c33
Resolves: #55671
Releases: 6.2
Reviewed-on: https://review.typo3.org/28063
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] MySQLi for DBAL 75/27875/14
Markus Klein [Wed, 26 Feb 2014 16:24:46 +0000 (17:24 +0100)]
[TASK] MySQLi for DBAL

Properly implement MySQLi for DBAL native mode.

Resolves: #50752
Releases: 6.2
Change-Id: I0c36e7d2828c94cc7c726757f3adc086ffd68015
Reviewed-on: https://review.typo3.org/27875
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Make browse_links.php a wizard 81/27981/4
Helmut Hummel [Sun, 2 Mar 2014 18:01:34 +0000 (19:01 +0100)]
[TASK] Make browse_links.php a wizard

Resolves: #56470
Releases: 6.2
Change-Id: I7bf8c20ab7e084efca352840f88007a574f7e270
Reviewed-on: https://review.typo3.org/27981
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] userPermissions => recursiveDeleteFolder 30/28030/2
Rico Sonntag [Tue, 4 Mar 2014 11:46:13 +0000 (12:46 +0100)]
[BUGFIX] userPermissions => recursiveDeleteFolder

This commit fixed the backend user/groups TCA to set the right option
to allow recursive deletion of folders.

Change-Id: I6f763ce820a09aa8b3f555ff6dfc5666fd7f81bf
Resolves: #56527
Releases: 6.2
Reviewed-on: https://review.typo3.org/28030
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Export binary data from sys_file records 64/27364/11
Marc Bastian Heinrichs [Wed, 5 Feb 2014 19:51:34 +0000 (20:51 +0100)]
[TASK] Export binary data from sys_file records

Until now files from TCA type group internal_type
file or file_reference were included as binary data in
the export only. Include also the binary data from
sys_file records in a separate array.

Resolves: #55431
Releases: 6.2
Change-Id: I9a1b1f090705f6a42ff34f98ec95b62a3a79c9c1
Reviewed-on: https://review.typo3.org/27364
Reviewed-by: Bernhard Kraft
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix executable permissions on files 72/28072/2
Thomas Luzat [Wed, 5 Mar 2014 11:15:09 +0000 (12:15 +0100)]
[BUGFIX] Fix executable permissions on files

A large number of files were stored with executable permissions. This
may be a (minor) security risk and can be confusing. The patch removes
the executable permissions on all files but:

* typo3/cli_dispatch.phpsh
* typo3/cleaner_check.sh
* typo3/cleaner_fix.sh

Resolves: #56571
Releases: 6.2
Change-Id: Ib6a9fb19fe716d7d5405d5a7120b50269bdbf5f8
Reviewed-on: https://review.typo3.org/28072
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Could not parse where clause 96/27996/6
Xavier Perseguers [Mon, 3 Mar 2014 14:37:01 +0000 (15:37 +0100)]
[BUGFIX] Could not parse where clause

SQL parser is unable to parse the complex Upgrade Wizard query. As we
know that it is compatible with DBMS we actively support (MySQL,
PostgreSQL, Oracle, MS SQL), a pragmatic solution is implemented to
bypass the parser while keeping compatibility with DBAL and its remapping
feature.

Releases: 6.2
Fixes: #56390
Change-Id: I54c01a3eca73668be579fb45e6fea907664290d6
Reviewed-on: https://review.typo3.org/27996
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Allow search for FAL related DB records 28/27928/3
Benjamin Mack [Fri, 28 Feb 2014 08:24:22 +0000 (09:24 +0100)]
[BUGFIX] Allow search for FAL related DB records

The backend search is currently not
working for file collections etc as there
is no searchFields string provided.

The patch adds them, and also
adds it to non-visible records like
sys_file and sys_file_records as they
might be used in a different
visualization when having a filesearch
service.

The patch is easily testable if you
take a file collection and name it
"my collection". Searching in the list
module on that page for "collection"
does not show anything without
the patch.

see
https://review.typo3.org/#/c/16725/9

Releases: 6.2
Resolves: #56410
Change-Id: I0e99b3b291f085b81560e8f823d3e258a8645fc0
Reviewed-on: https://review.typo3.org/27928
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Set TYPO3 version to 6.2-dev 62/28062/2
TYPO3 Release Team [Tue, 4 Mar 2014 20:41:18 +0000 (21:41 +0100)]
[TASK] Set TYPO3 version to 6.2-dev

Change-Id: Ie70bf11000e9b70f60bbd6923ab1516904164edd
Reviewed-on: https://review.typo3.org/28062
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.0beta6 61/28061/2 TYPO3_6-2-0beta6
TYPO3 Release Team [Tue, 4 Mar 2014 20:40:49 +0000 (21:40 +0100)]
[RELEASE] Release of TYPO3 6.2.0beta6

Change-Id: I034ed6f244869918e9e3b7c189a629825d76df79
Reviewed-on: https://review.typo3.org/28061
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] OpCache XCache cannot be cleared if xcache.admin.enable_auth 59/28059/5
Ernesto Baschny [Tue, 4 Mar 2014 20:16:06 +0000 (21:16 +0100)]
[BUGFIX] OpCache XCache cannot be cleared if xcache.admin.enable_auth

We can only clear the opcache in XCache if xcache.admin.enable_auth is not
set, else you get a fatal error.

Resolves: #56554
Related: #55252
Releases: 6.2
Change-Id: Ia33afc4141852c58266f6c7dfedec82f4c35148d
Reviewed-on: https://review.typo3.org/28059
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Install Tool: Optimize class structure 65/24665/11
Markus Klein [Sat, 12 Oct 2013 11:15:14 +0000 (13:15 +0200)]
[TASK] Install Tool: Optimize class structure

Refine the class and interface structure of
Install Tool actions.

Resolves: #52736
Releases: 6.2
Change-Id: Id1b0107670859e140169767233ba9944822e0d8d
Reviewed-on: https://review.typo3.org/24665
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove EXT/extListArray from DefaultConfiguration 54/28054/2
Christian Kuhn [Tue, 4 Mar 2014 19:20:46 +0000 (20:20 +0100)]
[TASK] Remove EXT/extListArray from DefaultConfiguration

extListArray is obsolete and can be removed. It is already taken
core off in the install tool upgrade process.

Change-Id: Ie9b86f28deebd3aab1031a725d72d852374e5607
Resolves: #56552
Releases: 6.2
Reviewed-on: https://review.typo3.org/28054
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Cache Identifiers shorten the MD5 hash 78/27878/2
Michiel Roos [Wed, 26 Feb 2014 19:14:10 +0000 (20:14 +0100)]
[BUGFIX] Cache Identifiers shorten the MD5 hash

Cache Identifiers shorten the MD5 hash - This is superfluous substr() work
without any gain - remove it.

Change-Id: I0061337afb74df2f29aae69f868a1a0bbe3ad966
Resolves: #56313
Releases: 6.2
Reviewed-on: https://review.typo3.org/27878
Reviewed-by: Dmitry Dulepov
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Setting capabilities to readonly show always drag+drop dialog 46/27946/6
Rico Sonntag [Fri, 28 Feb 2014 13:57:47 +0000 (14:57 +0100)]
[BUGFIX] Setting capabilities to readonly show always drag+drop dialog

If a driver is readonly, the upload button in the file list disappears,
but the DragUploader is still activated - on the whole page.
Clicking anywhere on the list page causes an upload file selection to
pop up. Additionally the new button is shown but has no functionality.
The patch removes DragUploader and superfluous button.

Change-Id: I3f6c2e932d9f66feb6590f08229ddaaad06e688e
Resolves: #56443
Releases: 6.2
Reviewed-on: https://review.typo3.org/27946
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Rico Sonntag
Tested-by: Rico Sonntag
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Improve usability with multiple tabs open 54/27954/7
Helmut Hummel [Fri, 28 Feb 2014 18:28:51 +0000 (19:28 +0100)]
[TASK] Improve usability with multiple tabs open

When the backend user session expires, currently
a popup window is shown which asks the user to
relogin when salted passwords or rsaauth are used
(which is currently our default).

However when a user works with multiple browser tabs
open, it is easy to overlook this popup. When realizing
that the session is expired and the user logs
into the backend again in one tab, the session
is authenticated in all other open tabs, but a
new CSRF protection token has been generated, which
makes working in this tab impossible, especially
because the tokens are now checked for virtually
any action.

This changes cleans up the AjaxLogin functionality
by making use of the new Ajax API introduced lately
and functionality is added so that AjaxLogin also
works with rsaauth and saltedpasswords enabled.

Additionally the form protection framework is slightly
reworked to better support the re-login and token
restore functionality in the AjaxLogin.

The "showRefreshLoginPopup" functionality is still
kept, because AjaxLogin can still not handle
OpenID logins.

Resolves: #56453
Releases: 6.2
Change-Id: Ic6c3415f292d346293c7d2c775288f4ba62ebc15
Reviewed-on: https://review.typo3.org/27954
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Use new way to register backend_layout wizard 77/27977/7
Wouter Wolters [Sun, 2 Mar 2014 15:33:11 +0000 (16:33 +0100)]
[TASK] Use new way to register backend_layout wizard

Resolves: #56471
Releases: 6.2
Change-Id: I8bd844326566715201ab3ae82811c945566b5b88
Reviewed-on: https://review.typo3.org/27977
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[CLEANUP] Enhance TCA - FAL migration for tt_content 21/25621/21
Benjamin Mack [Mon, 16 Dec 2013 15:50:56 +0000 (16:50 +0100)]
[CLEANUP] Enhance TCA - FAL migration for tt_content

The upgrade wizard to migrate the fields like e.g.
tt_content->image and pages->media fetches all records
of each table and loops over them. This is basic, and not
very clever, especially when the max_execution_time is
less than the upgrade wizards needs to process all fields
or if the memory_limit is reached because ALL of the
records are fetched.

Thus, the patch modifies the behavior in the following ways:
* As all TCA value are switched from text to integer
 (the value itself, not the DB field yet) the SQL is done to
only fetch records that are not empty, not integer
(and not deleted). This reduces the memory footprint
massively.
* The check for a record is now done for each table and
then for each field of the table (as the SQL has been changed).
* The field is only marked as "done" if no more records were
found in the migration run.
* Also, the redudant myfile_05.jpg are not moved if the
first file with that name (myfile.jpg) was moved already.

The migration wizard can now be run multiple times
(and the counter shows how many records are left).

Furthermore the wizard hides itself now once all migrations
are done.

Resolves: #53845
Resolves: #53891
Releases: 6.2
Change-Id: I835a07158e6869d80b4426d9774754421963ef81
Reviewed-on: https://review.typo3.org/25621
Reviewed-by: Jigal van Hemert
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Fix OpcodeCache for PHP 5.3 48/28048/4
Alexander Opitz [Tue, 4 Mar 2014 16:54:30 +0000 (17:54 +0100)]
[BUGFIX] Fix OpcodeCache for PHP 5.3

In PHP 5.3 anonymous functions can't be bound to static/self so an extra
call to a public function is needed.

Resolves: #56546
Related: #55252
Releases: 6.2
Change-Id: I56fc8c4ae92e50c35e972413540b43ec1fa714fc
Reviewed-on: https://review.typo3.org/28048
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] New filename does not get sanitized 06/27806/5
Frans Saris [Mon, 24 Feb 2014 07:27:23 +0000 (08:27 +0100)]
[BUGFIX] New filename does not get sanitized

When adding a new file through the ResourceStorage there
is a check to see if the file already exists. But this check
does not sanitize the target filename, so it could happen that
you get a false positive because when the file really is added
to the file system the target filename is sanitized.

This patch sanitizes the file name before the fileExists check.

Releases: 6.2, 6.1
Resolves: #55299
Change-Id: I519220040448b08883146caf463ed58544a18453
Reviewed-on: https://review.typo3.org/27806
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] TCA maximumRecordsChecked should display message 64/27264/3
Benjamin Mack [Sun, 2 Feb 2014 14:38:45 +0000 (15:38 +0100)]
[BUGFIX] TCA maximumRecordsChecked should display message

The new eval function "maximumRecordsChecked"
silently disables the checkbox again when the
maximum number of records has been reached.

The patch adds a log entry for the user on saving
the record.

You can test this change with #55177.

Resolves: #55590
Releases: 6.2
Change-Id: Ie8489f6b8fe519130689098968ae28fabe7c7b8e
Reviewed-on: https://review.typo3.org/27264
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] ADOdb: Invalid override method signature 02/20602/4
Xavier Perseguers [Tue, 7 May 2013 19:19:47 +0000 (21:19 +0200)]
[BUGFIX] ADOdb: Invalid override method signature

Classes are not overriding the method with a compatible list
of parameters.

Fixes: #48034
Releases: 6.2
Change-Id: I1e288cb90e12e3dc50b38c13bd76988f0be16cab
Reviewed-on: https://review.typo3.org/20602
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] getLabelsFromItemsList() returns no value 89/27689/4
Xavier Perseguers [Tue, 18 Feb 2014 13:01:31 +0000 (14:01 +0100)]
[BUGFIX] getLabelsFromItemsList() returns no value

Method getLabelsFromItemsList() is expected to return an empty list
when the column is populating items from a foreign_table configuration
option. Method getProcessedValue() is explicitly checking this to
retrieve the label from the corresponding foreign record if it could not
be resolved from the list of static items.

This reverts commits 5dd32b83e7085ed44713c9b97d5c2c47d820765e and
9596d4da3ac8110a76cb3eadabb9307b67971793 and moves the business logic
into method getProcessedValue().

Releases: 6.2, 6.1
Fixes: #54131
Change-Id: I15dcf0c4bcb76ecc85de8e3202b1376a24981b06
Reviewed-on: https://review.typo3.org/27689
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Use FAL functions for image rendering 11/25511/13
Alexander Stehlik [Sun, 2 Feb 2014 17:07:35 +0000 (18:07 +0100)]
[TASK] Use FAL functions for image rendering

Instead of relying on the backward compatiblity layer of the
FrontendContentAdapterService when rendering images with
css_styled_content the render_textpic method is modified so that it
is also be possible to use FAL functions and properties for image
rendering.

The captionsSplit / imageTextSplit constants are removed because
every image has its own properties for that with FAL and they are
not needed any more.

The globalCaption rendering was removed because the captions are now
always attached to a single image.

The longdescURL handling was also removed because the files do not
have this property at the moment and the longdescURL field for
tt_content records is also not visible in the Backend.

Resolves: #53764
Releases: 6.2
Change-Id: I1d9c8ad1d7a498816e724960613818a05d587d4f
Reviewed-on: https://review.typo3.org/25511
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[CLEANUP] Enhance RTE Magic Image FAL migration wizard 22/25622/2
Benjamin Mack [Thu, 21 Nov 2013 18:27:54 +0000 (19:27 +0100)]
[CLEANUP] Enhance RTE Magic Image FAL migration wizard

If the RTE magic images FAL migration upgrade wizard in the
install tool ever fails (due to max_execution_time) or some
SQL error, then the migration stops and can be run again.

However, if the wizard is run again, it always checks
if the source file still exists. The wizard should rather
check if the target file exists, if not, move the source file
to the target file.

As a separate "step" in this wizard, if the target file (already)
exists, then the DB change can be done.

Additionally, a typo for the output is fixed as well.

Resolves: #53846
Releases: 6.2
Change-Id: Id7c3b6176997848210d83c54cd133819ab15f435
Reviewed-on: https://review.typo3.org/25622
Reviewed-by: Wouter Wolters
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Upgrade Wizard for FAL references, check for missing tables 14/25414/6
Ernesto Baschny [Thu, 14 Nov 2013 21:43:37 +0000 (22:43 +0100)]
[TASK] Upgrade Wizard for FAL references, check for missing tables

In case sys_file_reference contains references to tables that no longer
exist physically (i.e. for extensions that were deinstalled and tables
then deleted through "Database Compare"), the sys_reference_table
upgrade wizard now no longer fails with an exception. Instead the buggy
rows will be deleted from the table.

Resolves: #53650
Releases: 6.2
Change-Id: I6a95b4abef77848de3ed97a1cf9b212434be7c98
Reviewed-on: https://review.typo3.org/25414
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Break out of foreach if there're no rows in table 54/27554/8
Stefan Froemken [Tue, 11 Feb 2014 18:10:11 +0000 (19:10 +0100)]
[BUGFIX] Break out of foreach if there're no rows in table

Instead of using a slow COUNT on huge tables, we add an
additional query here, which tries to get the first
found record in oder to test if records exists
or not. This new query is extremely fast, because it
uses indexes. It only needs one huge table
like sys_log in your database to see a performance
boost in BE list module.

Resolves: #55891
Releases: 6.2
Change-Id: I920729421bcece8af3b7cdd5f53446e5a1be5300
Reviewed-on: https://review.typo3.org/27554
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Cannot use contain with multivalued static enumeration column 87/27787/4
Xavier Perseguers [Sat, 1 Mar 2014 10:17:21 +0000 (11:17 +0100)]
[BUGFIX] Cannot use contain with multivalued static enumeration column

When a column is defined as a multivalued static enumeration:
'somecolumn' => array(
    'exclude' => 0,
    'label' => 'Some label',
    'config' => array(
        'type' => 'select',
        'items' => array(
            array('Option 1', 1),
            array('Option 2', 2),
            array('Option 3', 3),
            array('Option 4', 4),
        ),
        'size' => 4,
        'maxitems' => 4,
        'eval' => ''
    ),
),
it is not possible to query the domain model using operation "contains":
$value = 2;
$query->matching(
    $query->contains('somecolumn', $value)
);

Releases: 6.2, 6.1
Fixes: #56205
Change-Id: If898db7f355ad931d1c8b55febc2f59f19b0f38b
Reviewed-on: https://review.typo3.org/27787
Reviewed-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Flush opcode caches while saving PHP files. 24/27024/20
Alexander Opitz [Thu, 23 Jan 2014 13:43:36 +0000 (14:43 +0100)]
[BUGFIX] Flush opcode caches while saving PHP files.

After manipulating PHP files, which we include with "require" we should
clear the opcode cache, if there is one installed.

So we introduce OpcodeCacheUtility to handle the clearing of the opcode
cache. Also to have a way to give feedback to the install tool which
can show the quality of the opcode cache in use. It also checks if an
opcode cache is enabled in the configuration, not only if the extension
is installed.

Use of this opcode cache clearing is added to the ConfigurationManager,
PackageManager and the cache (Simple)FileBackend.

Make use of this data in the SystemEnvironmentCheck.

Resolves: #55252
Releases: 6.2, 6.1, 6.0
Change-Id: I881f3fbe055c9566663c2c3c238de62ae30f7149
Reviewed-on: https://review.typo3.org/27024
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Make standard-search working with EXT:form installed 42/28042/2
Oliver Hader [Tue, 4 Mar 2014 15:08:34 +0000 (16:08 +0100)]
[BUGFIX] Make standard-search working with EXT:form installed

The standard-search relies on basic form-functionality.
But if EXT:form is installed, that functionality is overlaid
and the result is wrong.

Provide a flag so that standard-search can request to use
the "basic" form-functionality, preventing EXT:form from
dealing with it.

Change-Id: I52cbd6cecc7222217ff766393dd37ad9d1a9aa30
Resolves: #50274
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/28042
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] DBAL's quoteFieldNames() returns an empty string 64/27864/10
Andreas Fernandez [Wed, 26 Feb 2014 16:20:51 +0000 (17:20 +0100)]
[BUGFIX] DBAL's quoteFieldNames() returns an empty string

DBAL's DatabaseConnection::INSERTquery() builds an array. The keys
(fields) are mapped through quoteFieldNames(), which returns an empty
string. DBAL's SqlParser tries to use $GLOBALS['TYPO3_DB'], which is
not available here.

Resolves: #56306
Releases: 6.2
Change-Id: I97eff8f796fcb8d530d16ff5f6111ebd5d28d5ce
Reviewed-on: https://review.typo3.org/27864
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Install Tool re-order menu items 02/28002/4
Wouter Wolters [Mon, 3 Mar 2014 19:50:26 +0000 (20:50 +0100)]
[TASK] Install Tool re-order menu items

Current Order:

* Welcome
* Important actions
* System environment
* Configuration Presets
* Folder structure
* Test setup
* Upgrade Wizard
* All configuration
* Clean up
* Logout from Install Tool

New proposed order:

* Important Actions
* Configuration Presets
* All Configuration
* Upgrade Wizard
* System environment
* Folder Structure
* Test Setup
* Cleanup

"Logout" is put below the menu as a link and "Welcome"
is just the first screen but without any menu item for it.

Resolves: #56497
Releases: 6.2
Change-Id: I20a3c363e5039b875c0aef2d23353f981dabee6b
Reviewed-on: https://review.typo3.org/28002
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Jan Helke
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] IdentityProperties were not set 01/21101/3
Stefan Froemken [Mon, 11 Mar 2013 17:36:49 +0000 (18:36 +0100)]
[BUGFIX] IdentityProperties were not set

After submitting an invalid form twice, extbase tries to
create the related submodel instead of edit.
This is because of the missing __identity part
for the related submodel

Resolves: #46185
Releases: 6.0, 6.1, 6.2
Change-Id: If3ec15b9eff0fc8d9a7dc682518cbfd72bb4665b
Reviewed-on: https://review.typo3.org/21101
Reviewed-by: Stefan Neufeind
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Install css_styled_content by default 58/27858/4
Nicole Cordes [Tue, 25 Feb 2014 22:36:57 +0000 (23:36 +0100)]
[BUGFIX] Install css_styled_content by default

As felogin and some other extensions don't work without
css_styled_content it should be enabled by default as well. This patch
adds the Package class to install the extension by default.

Resolves: #56292
Releases: 6.2
Change-Id: I9aad88966c0c292cdff865276dc131f358a52697
Reviewed-on: https://review.typo3.org/27858
Reviewed-by: Dmitry Dulepov
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] CSS: Button style :active and :hover 83/27983/2
Felix Kopp [Sun, 2 Mar 2014 23:28:31 +0000 (00:28 +0100)]
[TASK] CSS: Button style :active and :hover

Brings visual illusion for :active / click state.
Bugfixes :hover on <button>

Resolves: #56480
Releases: 6.2
Change-Id: I08d38c50d23f5fbcf591dbd54edca34944568591
Reviewed-on: https://review.typo3.org/27983
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Fix warnings on felogin / Use correct usergroup-column 00/28000/4
Stefan Neufeind [Mon, 3 Mar 2014 19:04:43 +0000 (20:04 +0100)]
[BUGFIX] Fix warnings on felogin / Use correct usergroup-column

PHP Warning: Illegal string offset 'usergroup' is shown when
trying to login to the frontend while currently already being
logged into the backend.

Also the usergroup-column needs to be fetched from
$this->fe_user->usergroup_column.

Change-Id: Ia9772262616e9bd62e0827b0f211b8efe77ea80b
Resolves: #56508
Releases: 6.2
Reviewed-on: https://review.typo3.org/28000
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Make TS content templates more flexible 87/27587/5
Benjamin Mack [Wed, 12 Feb 2014 17:24:57 +0000 (18:24 +0100)]
[TASK] Make TS content templates more flexible

If an extension used static content ID 43 (content default),
it also added itself (during each runtime of ext_localconf.php)
to all available content blocks.
The original way is problematic as an extension that
provides content templates may be included after
an extension that wants to add itself after all content
templates.
This is now more confusing as the package manager
resolves the ordering of extensions and now,
CSS Styled Content gets loaded after felogin and
indexed_search.

To resolve this problem completely, the additional
TypoScript for each "contentRenderingTemplate",
a TS template that provides default content renderings,
is added to one global default TypoScript and is only
merged at the TemplateService class.

Therefore the extension loading ordering does not
matter anymore.

Resolves: #55942
Resolves: #55174
Resolves: #55557
Releases: 6.2
Change-Id: Id0c983bf96a3a76fde2183c57a17066ef8fd4ac8
Reviewed-on: https://review.typo3.org/27587
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix PHP warnings on fe_user log out 62/27362/4
Markus Klein [Wed, 5 Feb 2014 16:21:16 +0000 (17:21 +0100)]
[BUGFIX] Fix PHP warnings on fe_user log out

PHP Warning: Illegal string offset is thrown in some places
if an fe_user logs out.

Resolves: #55696
Releases: 6.2
Change-Id: I532a27c0d2fc4b80d3a3f92da0079f4e9517d06c
Reviewed-on: https://review.typo3.org/27362
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Klee
Reviewed-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Double escape of title in indexed search 49/27849/3
Markus Klein [Tue, 25 Feb 2014 17:08:56 +0000 (18:08 +0100)]
[BUGFIX] Double escape of title in indexed search

SearchController::compileSingleResultRow() causes double
htmlspecialchars() call on $title.

This patch removes the general htmlspecialchars() call since
$title will be escaped in linkPage() anyway.
The only place which requires escaping has the call added now.

Resolves: #56262
Releases: 6.2, 6.1, 6.0
Change-Id: Ic94fe7fe7d2145fc539adcdf21faf42c33f5b32e
Reviewed-on: https://review.typo3.org/27849
Reviewed-by: Stefan Neufeind
Reviewed-by: Dragan Tomic
Tested-by: Dragan Tomic
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Wrong handling of delimiter in revExplode() 26/27926/5
Markus Klein [Fri, 28 Feb 2014 01:41:30 +0000 (02:41 +0100)]
[BUGFIX] Wrong handling of delimiter in revExplode()

The delimiter has to be reversed for the case of limit 2,
as the search is performed on the non-reversed string.
Otherwise the function will yield different results for
limits greater than 2.

Resolves: #56405
Releases: 6.2
Change-Id: I077d38918d98fbe2e5cd153c75b115e0d95734f8
Reviewed-on: https://review.typo3.org/27926
Reviewed-by: Georg Tiefenbrunn
Tested-by: Georg Tiefenbrunn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Always fetch related objects if relation set by child 49/27949/3
Helmut Hummel [Sat, 1 Mar 2014 20:41:43 +0000 (21:41 +0100)]
[BUGFIX] Always fetch related objects if relation set by child

If the DataMapper shall map a 1:N relation for
a property of a domain object and the element
type of this property is another domain object
and not a storage type, the data mapper must
always fetch the related elements from persistence
and cannot rely on the persistence session lookup.

This is the case because the relation to the parent
is set on the child side and not the other way around.
The column in the parent row is useless in that case
and does not hold the id of the child.

We can also not rely on the persistence session
because we do not know the identifier of the child
until we fetched it.

Resolves: #56442
Releases: 6.2, 6.1
Change-Id: Icc3ebf9b825f6380691c60839621f01ca9875e4e
Reviewed-on: https://review.typo3.org/27949
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[TASK] Remove condensed mode leftovers 80/27980/2
Helmut Hummel [Sun, 2 Mar 2014 18:05:48 +0000 (19:05 +0100)]
[TASK] Remove condensed mode leftovers

The condensed mode user setting has been removed
three years ago with #24585

Now also remove the leftover parts.
Keep the language labels to not interfere
with older versions.

Resolves: #56479
Releases: 6.2
Change-Id: I8cb3ebc5aac162357ce1d343eed1031156ccd749
Reviewed-on: https://review.typo3.org/27980
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Make sysexts composer names standards compliant 03/25503/4
Thomas Maroschik [Tue, 19 Nov 2013 10:49:53 +0000 (11:49 +0100)]
[TASK] Make sysexts composer names standards compliant

Resolves: #53753
Releases: 6.2
Change-Id: I3acb81c71796bc84ada29e6cdf6141be07f69ca3
Reviewed-on: https://review.typo3.org/25503
Reviewed-by: Christian Opitz
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[BUGFIX] Mock locked records for DataProviderTest 75/27975/4
Helmut Hummel [Sun, 2 Mar 2014 14:53:38 +0000 (15:53 +0100)]
[BUGFIX] Mock locked records for DataProviderTest

The DataProviderTest calls BackendUtility::isRecordLocked
statically. We cannot mock that call, but we can
"mock" a locked record so that BackendUtility::isRecordLocked
does not query the database.

Resolves: #56472
Releases: 6.2
Change-Id: I268a7a900a0f2dcbf248f6a4d856354c7b1cdcd6
Reviewed-on: https://review.typo3.org/27975
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Update database schema as first and last update wizard 40/27240/8
Stephan Großberndt [Sat, 1 Feb 2014 17:23:01 +0000 (18:23 +0100)]
[TASK] Update database schema as first and last update wizard

Introduces two new upgrade wizards in the Install tool.

The first wizard - added as first step of the upgrade wizards - adds
tables, fields and keys to comply to the database schema. When this is
necessary no other wizards can be executed until these are created.

The second wizard - added as last step of the upgrade wizards - changes
tables, fields and keys to comply to the database schema. When other
upgrade wizards are available, this one is not available to make sure
they have all necessary fields.

In order to make sure they are added as first and last step they are
added in UpdateWizard instead of ext_localconf.php.

The former "Final step" is now optional and has been renamed to "Hint".
The buttons to start the update wizards from the list have been renamed
from "Next" to "Execute".

Resolves: #53890
Releases: 6.2
Change-Id: I866b558df3325acca3122bbd4e0c2285447fcdf3
Reviewed-on: https://review.typo3.org/27240
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[!!!][SECURITY] Remove old wizard scripts 56/27956/7
Helmut Hummel [Fri, 28 Feb 2014 20:38:52 +0000 (21:38 +0100)]
[!!!][SECURITY] Remove old wizard scripts

Keeping the old wizard script would not solve
the CSRF attack vector as they could still
be referenced in this kind of attack.

Because of that, we remove them now.

This change provides a backwards compatibility
layer in FormsEngine which takes care of rewriting
URLs which have been referenced in TCA.

Also the priority is changed in code. This means
that extension authors can reference both
configurations to stay compatible with older
TYPO3 versions.

It will however break code which link to the
old scripts directly in other places.

Resolves: #56454
Releases: 6.2
Change-Id: I15f5d929f16fdd53a8b87cd32440a3d6ce59b6ed
Reviewed-on: https://review.typo3.org/27956
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix StorageRepository::findByStorageType 15/27915/3
Marc Bastian Heinrichs [Thu, 27 Feb 2014 20:02:46 +0000 (21:02 +0100)]
[BUGFIX] Fix StorageRepository::findByStorageType

Since optimizing the retrieval of Storages the
findByStorageType() doesn't find any (also right ones)
storage, because of a wrong comparison.
This fixes also the localDriverStorageCache in
ResourceFactory, finding a bestMatchingStorageByLocalPath
in ResourceFactory, getting the right storage for a local
path as fileIdentifier and creation of duplicate entries
in sys_file with storage 0.

Resolves: #56400
Releases: 6.2
Change-Id: I75ac357dff498f1a209d4c42896bdeddab3641ad
Reviewed-on: https://review.typo3.org/27915
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Use new way to register colorpicker wizard 45/27945/5
Alexander Schnitzler [Fri, 28 Feb 2014 14:00:01 +0000 (15:00 +0100)]
[TASK] Use new way to register colorpicker wizard

Resolves: #56436
Releases: 6.2
Change-Id: Ia789abbbdf7ab11a4ab13ea6aa195bc79ba6dc25
Reviewed-on: https://review.typo3.org/27945
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Undefined variable $multiSelectId in FormEngine 59/27959/3
Wouter Wolters [Sat, 1 Mar 2014 14:01:39 +0000 (15:01 +0100)]
[BUGFIX] Undefined variable $multiSelectId in FormEngine

There is a undefined variable $multiSelectId in FormEngine. This
is introduced with #46357

Resolves: #56457
Releases: 6.2
Change-Id: I88fd4f9b36e6421b338011a1cc31c22987019dc9
Reviewed-on: https://review.typo3.org/27959
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[CLEANUP] Followup to wizard changes 57/27957/2
Helmut Hummel [Fri, 28 Feb 2014 21:15:38 +0000 (22:15 +0100)]
[CLEANUP] Followup to wizard changes

The new wizards scripts lacked a proper description.
Add the description the original files had.

Related: #56431
Releases: 6.2
Change-Id: I482d0a8c11d827c3e14da140d800df6d2caeefdc
Reviewed-on: https://review.typo3.org/27957
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Use new way to register rte wizard 51/27951/4
Alexander Schnitzler [Fri, 28 Feb 2014 16:07:23 +0000 (17:07 +0100)]
[TASK] Use new way to register rte wizard

Resolves: #56437
Releases: 6.2
Change-Id: I0eea59f46c74fe50eb2554898a9f64fa2a26a9b1
Reviewed-on: https://review.typo3.org/27951
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Use new way to register forms wizard 47/27947/4
Alexander Schnitzler [Fri, 28 Feb 2014 14:42:22 +0000 (15:42 +0100)]
[TASK] Use new way to register forms wizard

Resolves: #56438
Releases: 6.2
Change-Id: Ic5a22f6ded5bf3b5d8a6442497444296a6b3bfaa
Reviewed-on: https://review.typo3.org/27947
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove superflous require_once in t3editor hook 48/27848/3
Alexander Schnitzler [Tue, 25 Feb 2014 16:58:58 +0000 (17:58 +0100)]
[TASK] Remove superflous require_once in t3editor hook

\TYPO3\CMS\T3editor\Hook\FileEditHook::save() requires
init.php which is not necessary at all as the method
itself is only called through ajax.php, which requires
init.php itself anyway.

Resolves: #55676
Releases: 6.2
Change-Id: Iaaf0805b73ebbb97e6689bcaa8064dc350187e66
Reviewed-on: https://review.typo3.org/27848
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Use new way to register table wizard 42/27942/3
Alexander Schnitzler [Fri, 28 Feb 2014 13:37:31 +0000 (14:37 +0100)]
[TASK] Use new way to register table wizard

Resolves: #56435
Releases: 6.2
Change-Id: I180929980ade8c26a6e086f2f65d2e76cbeb19cd
Reviewed-on: https://review.typo3.org/27942
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Title field disappears after using addToAllTCAtypes() 02/27702/5
Michiel Roos [Tue, 18 Feb 2014 21:17:03 +0000 (22:17 +0100)]
[BUGFIX] Title field disappears after using addToAllTCAtypes()

Change-Id: Ia7db1d1b3613badc84ca3ee44ce68c154004f135
Resolves: #56080
Releases: 6.2
Reviewed-on: https://review.typo3.org/27702
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Do not log with severity 1320177676 95/27895/5
Christian Weiske [Thu, 27 Feb 2014 12:37:43 +0000 (13:37 +0100)]
[BUGFIX] Do not log with severity 1320177676

Extbase logged a code smell with a severity of 1320177676
instead of 1 ("notice").

Change-Id: If28c2d66713bdedb3094af22f8f7a00a504d995d
Resolves: #56378
Releases: 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/27895
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Add IconUtility::getSpriteIconForResource() 90/27790/5
Frans Saris [Sat, 22 Feb 2014 19:48:54 +0000 (20:48 +0100)]
[TASK] Add IconUtility::getSpriteIconForResource()

With the introduction of FAL the files and folders are
objects and so there is more info than just a name/extension
to determine the right icon. And with file_metadata
you have the possibility to even add more info to
a file (access rights etc).

This patch adds a new method to the IconUtility API for
generating the sprite icon for a resource. There is also
a hook where other extensions can hook in and change
the icon, options and overlays.

Furthermore, all calls in the core are changed to
IconUtility::getSpriteIconForFile where a
File or Folder object was available.

Resolves: #56211
Documentation: #56412
Releases: 6.2
Change-Id: Ifae61dd65d690fffd90c66568e2647ebd403bce5
Reviewed-on: https://review.typo3.org/27790
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Markus Klein
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Use new way to register list wizard 41/27941/6
Alexander Schnitzler [Fri, 28 Feb 2014 13:19:58 +0000 (14:19 +0100)]
[TASK] Use new way to register list wizard

Resolves: #56434
Releases: 6.2
Change-Id: Ia776874ca247b11a769a1c17ee1e6ec65047ac4c
Reviewed-on: https://review.typo3.org/27941
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Use new way to register add wizard 39/27939/3
Alexander Schnitzler [Fri, 28 Feb 2014 12:53:51 +0000 (13:53 +0100)]
[TASK] Use new way to register add wizard

Resolves: #56432
Releases: 6.2
Change-Id: Id78b3182ed6710a09a82ce69bd1f5b72f9e2a3e0
Reviewed-on: https://review.typo3.org/27939
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] @return for TYPO3\CMS\Sv\AuthenticationService::authUser 31/27931/3
Christian Weiske [Fri, 28 Feb 2014 09:55:13 +0000 (10:55 +0100)]
[BUGFIX] @return for TYPO3\CMS\Sv\AuthenticationService::authUser

Adjust the @return documentation of authUser() to match the actual
implementation in
TYPO3\CMS\Core\Authentication\AbstractUserAuthentication

Change-Id: I2d94cdfee6c58de80c7ec2be2b644b5fcd6c9a97
Resolves: #56421
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/27931
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Adding new records in edit mode broken 35/27935/5
Andre Hähnel [Fri, 28 Feb 2014 12:00:41 +0000 (13:00 +0100)]
[BUGFIX] Adding new records in edit mode broken

It was not possible anymore to use the "add new record" button
in TCA select fields on records with pid > 0.

This patch makes it work again; the redirect to the original page
gets prevented when a pid is set. This was handled the same way
in 4.6 and 6.1.

Change-Id: Iec058818405385efdacaebf5080f339371356810
Resolves: #56248
Related: #54085
Releases: 6.2
Reviewed-on: https://review.typo3.org/27935
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix double quotes in ElementBrowser JS 24/27924/3
Markus Klein [Thu, 27 Feb 2014 23:56:39 +0000 (00:56 +0100)]
[BUGFIX] Fix double quotes in ElementBrowser JS

Double quotes must not be used around JS code
created by GeneralUtility::quoteJSvalue()

Resolves: #56406
Releases: 6.2
Change-Id: Ideff0a2ca475dad140a904a770561fa75f4019b9
Reviewed-on: https://review.typo3.org/27924
Reviewed-by: Thomas Sperling
Tested-by: Thomas Sperling
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[SECURITY] Protect core Ajax calls against CSRF 77/27877/5
Helmut Hummel [Wed, 26 Feb 2014 19:04:10 +0000 (20:04 +0100)]
[SECURITY] Protect core Ajax calls against CSRF

The backend ajax handler that are directly registered
in DefaultConfiguration.php are now CSRF protected
if necessary.

Resolves: #56356
Releases: 6.2
Change-Id: Ia592f7f2b51c20326600b97d2ce10a5e5fdbfde7
Reviewed-on: https://review.typo3.org/27877
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Make sure M parameter is first in URL 16/27916/4
Helmut Hummel [Thu, 27 Feb 2014 21:04:00 +0000 (22:04 +0100)]
[BUGFIX] Make sure M parameter is first in URL

Although the order of GET parameters in the URL
does not matter, the M parameter should come first
in the URL.

Resolves: #56404
Releases: 6.2
Change-Id: Id79f2f55fff2430ecce8a76bbba526dc7d175b40
Reviewed-on: https://review.typo3.org/27916
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Nicole Cordes
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix GET parameter order in unit tests 17/27917/3
Helmut Hummel [Thu, 27 Feb 2014 21:10:57 +0000 (22:10 +0100)]
[BUGFIX] Fix GET parameter order in unit tests

The order of GET parameters changed, so we have
to adapt the tests.

Resolves: #56403
Releases: 6.2
Change-Id: I6fb8d231c71fa020677313127d453be3eab500ce
Reviewed-on: https://review.typo3.org/27917
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[FEATURE] Add API to CSRF protect Ajax calls in Backend 73/27873/8
Helmut Hummel [Wed, 26 Feb 2014 14:47:15 +0000 (15:47 +0100)]
[FEATURE] Add API to CSRF protect Ajax calls in Backend

This change adds API to register Ajax ids with
their handler and to get an Ajax URL for
a specific AjaxID.

A token check is added to the ajax.php dispatcher
script. To stay backwards compatible, the token
is only checked, if the AjaxId is registered not
using the new API.

The new API will be used by TYPO3 core in
consecutive changes.

Resolves: #56345
Documentation: #56347
Releases: 6.2
Change-Id: I188a9312b0f4239040e461ba09dc9c8f2b93a68b
Reviewed-on: https://review.typo3.org/27873
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Additional SignalSlot after init in EditDocumentController 96/27896/2
Julian Kleinhans [Thu, 27 Feb 2014 13:12:21 +0000 (14:12 +0100)]
[TASK] Additional SignalSlot after init in EditDocumentController

Adds a new SignalSlot possibility after the init method call.

Resolves: #56381
Releases: 6.2
Change-Id: I2357f81c40b123a7cd2eef57ef142a9e934dbc35
Reviewed-on: https://review.typo3.org/27896
Reviewed-by: Julian Kleinhans
Tested-by: Julian Kleinhans
Reviewed-by: Tomas Norre Mikkelsen
Reviewed-by: Erik Frister
Reviewed-by: Joh. Feustel
Reviewed-by: Stefan Rotsch
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[CLEANUP] Remove security_level option from Authentications 25/27825/3
Benjamin Mack [Tue, 25 Feb 2014 08:22:38 +0000 (09:22 +0100)]
[CLEANUP] Remove security_level option from Authentications

The option security_level option was deprecated
since 4.7 and can now be removed.

Also do some cleanup in related code.

Releases: 6.2
Resolves: #56256
Change-Id: I48dcb788ca654aea14fb7125128c564fd373b550
Reviewed-on: https://review.typo3.org/27825
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Speed up updating the extension list 76/27876/4
Benjamin Mack [Wed, 26 Feb 2014 17:51:46 +0000 (18:51 +0100)]
[TASK] Speed up updating the extension list

The process of updating the TER
extension list takes approx 1 minute
because the extension manager needs
to mark all "latest versions". This is done
via a large UPDATE query on fields
without indices, additionally this is done
in PHP and not in SQL with a
simple subselect.

Additionally the SQL file does not set
appropriate indices at all, which is also
done in this patch.

Releases: 6.2
Resolves: #56354
Change-Id: Ic46994fa1b16cce9912950520955185f3f95fe1a
Reviewed-on: https://review.typo3.org/27876
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Filename sorting in filelist is broken 81/27881/2
Frans Saris [Wed, 26 Feb 2014 20:25:11 +0000 (21:25 +0100)]
[BUGFIX] Filename sorting in filelist is broken

The sorting by filename in the filelist is broken since the
introduction of sys_file_metadata. It tries to sort the file list
by property file. Before sys_file_metadata it couldn't find this
property and sorted by the default value name. But after introduction
of sys_file_metadata it has an property file, his own sys_file uid.

This patch fixes the sorting behaviour when sorting by filename.

Resolves: #56128
Releases: 6.2
Change-Id: Icd25bc2aafed4baafbaa7d9f87ce755fe9e64579
Reviewed-on: https://review.typo3.org/27881
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGIFX] Fix Redirect after switch-to-user 97/27897/3
Helmut Hummel [Thu, 27 Feb 2014 13:18:14 +0000 (14:18 +0100)]
[BUGIFX] Fix Redirect after switch-to-user

The compatibility layer introduced in #55809
causes trouble with the user switch feature.

User switch intentionally redirects to index.php
but the compatibility layer kicks in and redirects
back to the user module, finally leading to an
endless redirect.

This can be resolved by checking for modules which
have been changed and need that compatibility layer.

Resolves: #56364
Releases: 6.2
Change-Id: I74d8c57335af66068383b49dc7d43ea480e631b8
Reviewed-on: https://review.typo3.org/27897
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Oliver Hader
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix reference to FileListLocalisation.js 61/27861/2
Markus Klein [Wed, 26 Feb 2014 00:13:37 +0000 (01:13 +0100)]
[BUGFIX] Fix reference to FileListLocalisation.js

FileListLocalisation.js was moved from backend to filelist
with #55810, but it was forgotten to adapt the reference
in InlineElement.

Resolves: #55979
Releases: 6.2
Change-Id: I102ffe25c255f8ac39a49d4022ee3ab73ff1914c
Reviewed-on: https://review.typo3.org/27861
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Frans Saris
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Revert "[TASK] Use a 401 header if login is not successful" 88/27888/9
Michael Knabe [Thu, 27 Feb 2014 11:27:51 +0000 (12:27 +0100)]
[BUGFIX] Revert "[TASK] Use a 401 header if login is not successful"

This reverts commit 9974f36d2736e21875a76d33a9dd7ceb440a100d.

The 401 header code is used with HTTP based authentication schemes,
based on RFC 2617.

This is not the case here.

Resolves: #55966
Reverts: #51803
Releases: 6.2, 6.1, 6.0, 4.5
Change-Id: I134f0f1d575f3e8d4c37c2af62df8eca3f01f817
Reviewed-on: https://review.typo3.org/27888
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Fix link for workspace preview 93/27893/2
Helmut Hummel [Thu, 27 Feb 2014 11:42:01 +0000 (12:42 +0100)]
[BUGFIX] Fix link for workspace preview

The absolute link generated for mailings to
workspace editors misses the page id.

The uid has been accidentally removed with
commit for #56359

Resolves: #56375
Releases: 6.2
Change-Id: I521aee2b96c542c27a911ffeab5d9bfffc8b9a46
Reviewed-on: https://review.typo3.org/27893
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix module access regressions 83/27883/3
Helmut Hummel [Wed, 26 Feb 2014 20:37:14 +0000 (21:37 +0100)]
[BUGFIX] Fix module access regressions

During the addition of the token check for mod.php
some places have been missed where a correct
token needs to be added.

Resolves: #56359
Releases: 6.2
Change-Id: I435cb36641fe96ecf050c915d200f94cbb31ce9f
Reviewed-on: https://review.typo3.org/27883
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Avoid to get a file object with the uid zero 04/27304/3
Marc Bastian Heinrichs [Mon, 3 Feb 2014 17:34:58 +0000 (18:34 +0100)]
[BUGFIX] Avoid to get a file object with the uid zero

At some points where a file object is retrieved, a check for
the interpretation as integer is done for the method
argument only. If the argument is 0 a exception will be
thrown from the ResourceFactory.
A file object should only be fetched if the uid is an integer
greater than zero.

Resolves: #55530
Releases: 6.2
Change-Id: I9399d58bac4a48344769ac00207b64e25eea630e
Reviewed-on: https://review.typo3.org/27304
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Do not save failed token messages in session 79/27879/2
Helmut Hummel [Wed, 26 Feb 2014 19:20:07 +0000 (20:20 +0100)]
[BUGFIX] Do not save failed token messages in session

In #30272 the backend formprotection has been changed
to not save flash messages in the user session if
the current request is an Ajax request.

Unfortunately the check for that is broken
since the TYPO3_AJAX global is reset in the
bootstrap now.

Introduce a method which uses the request type
constants and adapt the tests accordingly.

Resolves: #56357
Releases: 6.2
Change-Id: Idae8be036b3747ea71509cc37008a4d694390627
Reviewed-on: https://review.typo3.org/27879
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Respect all filemounts in file collection 19/27119/3
Alexander Stehlik [Thu, 30 Jan 2014 10:43:13 +0000 (11:43 +0100)]
[BUGFIX] Respect all filemounts in file collection

The directory selector in a file collection now displays the folders
of all filemounts of a user. Before only the folders of the first
filemount were displayed.

Resolves: #55414
Releases: 6.2
Change-Id: Ic47f5163e2cfc7c89edcba4119f06620ed0fd56e
Reviewed-on: https://review.typo3.org/27119
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[!!!][SECURITY] Add CSRF protection to mod.php 36/27636/8
Helmut Hummel [Fri, 14 Feb 2014 22:56:38 +0000 (23:56 +0100)]
[!!!][SECURITY] Add CSRF protection to mod.php

Add a token check in mod.php and token generation
to BackendUtility::getModuleUrl()

Adapt code to use BackendUtility::getModuleUrl()
in every place where links are hardcoded.

Releases: 6.2
Resolves: #55509
Change-Id: I952c40fc1004a0a8d77c929927d37e1d93dcfef4
Reviewed-on: https://review.typo3.org/27636
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Allow record insert on rootlevel 66/24166/9
Benjamin Serfhos [Mon, 30 Sep 2013 15:01:24 +0000 (17:01 +0200)]
[BUGFIX] Allow record insert on rootlevel

The DataHandler function checkRecordInsertAccess() does
now check the configuration for the root level.

Resolves: #52386
Releases: 6.2, 6.1, 6.0
Change-Id: I1810ea847e631ea6b242346a0271f491fd60fdf9
Reviewed-on: https://review.typo3.org/24166
Reviewed-by: Leon de Rijke
Tested-by: Leon de Rijke
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Followup: Ajax handler TYPO3_tcefile::process is broken 39/27739/11
Frans Saris [Wed, 19 Feb 2014 20:41:23 +0000 (21:41 +0100)]
[BUGFIX] Followup: Ajax handler TYPO3_tcefile::process is broken

Upload action was taken care of, but the ajax handler can be just
for all commands that ExtendedFileUtility->processData can handle.

This change checks the result set and flattens
data only when needed.

Resolves: #56084
Releases: 6.2, 6.1
Change-Id: Ic1a0bd9084b9eb206b9b53960890d22d2a9c56f5
Reviewed-on: https://review.typo3.org/27739
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Fixen broken tests for getTreeList 59/27859/2
Markus Klein [Tue, 25 Feb 2014 22:59:20 +0000 (23:59 +0100)]
[TASK] Fixen broken tests for getTreeList

Resolves: #56294
Releases: 6.2
Change-Id: I1d86f1899447feaa301474f4ed247a0ecc6c1a6e
Reviewed-on: https://review.typo3.org/27859
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Wrong usage of intExplode in getTreeList 89/27089/9
Stefan Froemken [Tue, 28 Jan 2014 10:44:46 +0000 (11:44 +0100)]
[BUGFIX] Wrong usage of intExplode in getTreeList

getTreeList calls intExplode which converts empty
arrays to 0. This patch removes empty arrays
within intExplode.

Resolves: #55384
Releases: 6.2
Change-Id: Id4ca1a15edf2cc2617d85bda765461c4cb1f105c
Reviewed-on: https://review.typo3.org/27089
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] Don't modify variables in tree view 50/27850/3
Jigal van Hemert [Tue, 25 Feb 2014 20:08:44 +0000 (21:08 +0100)]
[BUGFIX] Don't modify variables in tree view

The lowlevel array browser tries to modify the array that
is displayed if it's an object.
Now that TYPO3_LOADED_EXT is a simulated array (an object
which implements array access) modifying the data leads to
a fatal error. Instead the iterated value is now modified.

Releases: 6.2
Resolves: #54449
Change-Id: Ib1d3eb5cc76a4180ea0891d88c16191cd16f36e2
Reviewed-on: https://review.typo3.org/27850
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters