Packages/TYPO3.CMS.git
6 years ago[TASK] Introduce relative line-heights 21/23021/3
Felix Kopp [Sat, 10 Aug 2013 12:51:34 +0000 (14:51 +0200)]
[TASK] Introduce relative line-heights

The line-height for the backend was fixed to 14px.
But line-heights should be relative to the font-size.

With this standard line-heights are 1.5 x font-size.

Change-Id: I2c098141b4905b1ac7bf756266e77dd2078ea6f2
Resolves: #51000
Releases: 6.2
Reviewed-on: https://review.typo3.org/23021
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] UnitTests.xml cleanup 24/23124/2
Christian Kuhn [Fri, 16 Aug 2013 09:28:54 +0000 (11:28 +0200)]
[TASK] UnitTests.xml cleanup

Minor cleanup in UnitTests.xml, BackupGlobals can be enabled
by default.

Resolves: #51101
Releases: 6.2

Change-Id: Ia1271d60bf29a5ac7adb98116d9d7a7a43f00b47
Reviewed-on: https://review.typo3.org/23124
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix file permission methods in BackendUserAuthentication 37/23037/6
Helmut Hummel [Wed, 7 Aug 2013 16:33:37 +0000 (18:33 +0200)]
[BUGFIX] Fix file permission methods in BackendUserAuthentication

Take default TSConfig file permissions into account:

File permissions configured in User TSConfig,
are not taken into account, because the properties
from the getTSConfig method are returned in a
'properties' key of an array but the top level
array is used. Use getTSConfigProp instead.

Fix the bit wise check for old file permissions:

XOR the value is wrong because it gives the wrong
result if more bits are set. Use AND operation
to properly check if a specific bit is not set.

Check if the user is admin in getFilePermissionsForStorage()

Add tests to confirm the desired behaviour.

Releases: 6.0, 6.1, 6.2
Resolves: #51004
Change-Id: Ia5d6fa1cb47a74306fe5465a0e70c2f2aea2a4b8
Reviewed-on: https://review.typo3.org/23037
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Avoid usage of subheader in mailform 91/22391/3
Francois Suter [Wed, 17 Jul 2013 20:07:01 +0000 (22:07 +0200)]
[BUGFIX] Avoid usage of subheader in mailform

Since TYPO3 CMS 4.7 the subheader field is rendered by lib.stdheader
if the chosen doctype is HTML 5. However the old mailform (ab)uses this
field for storing the recipient e-mail address. The subheader must
not be displayed in this case.

Resolves: #46094
Releases: 6.2, 6.1, 6.0, 4.7
Change-Id: I19d13e65b941e2514a9c4a12cb37f015661e9d8f
Reviewed-on: https://review.typo3.org/22391
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] storagePid is lost when persistence.recursive is set 86/23086/5
Steffen Müller [Tue, 13 Aug 2013 18:55:01 +0000 (20:55 +0200)]
[BUGFIX] storagePid is lost when persistence.recursive is set

If recursive storagePid is set via TypoScript, the storagePid
itself is missing in the list of pids.

Resolves: #51064
Releases: 6.2, 6.1
Change-Id: I5f06911bb60b847e4a97b5690e57557d4dec66b7
Reviewed-on: https://review.typo3.org/23086
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Typing after abbr or acronym tag is difficult 84/22684/2
Stanislas Rolland [Tue, 30 Jul 2013 03:16:15 +0000 (23:16 -0400)]
[BUGFIX] Typing after abbr or acronym tag is difficult

Solution: After inserting the abbreviation, position the cursor
after and outside the inserted tag.

Resolves: #47806
Releases: 6.0, 6.1, 6.2
Change-Id: I4e8c47cf031fe3df2772ed47cb42122b8db9a646
Reviewed-on: https://review.typo3.org/22684
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
6 years ago[BUGFIX] Fix inconsistencies in getTSConfig in BackenuserAuth 32/23032/4
Helmut Hummel [Sat, 10 Aug 2013 21:18:05 +0000 (23:18 +0200)]
[BUGFIX] Fix inconsistencies in getTSConfig in BackenuserAuth

BackenuserAuthentication::getTSConfig() behaves
inconsistently when an object string is given with
multiple sections but no result in the actual TSConfig
of the user. Other than noted in the method declaration,
the method returns an empty array instead of an array
where the 'properties' key is null.

Additionally we fix a bug which caused wrong results
if "0" was used as a key in configuration and accessed
with something like "permissions.file.0"

Resolves: #51007
Releases: 6.0, 6.1, 6.2
Change-Id: I80fc7398c1955ff77d052377e3ba81bb8aea01cf
Reviewed-on: https://review.typo3.org/23032
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[FEATURE] Intgrate CSS class "lead" for introductions 50/23050/2
Felix Kopp [Mon, 12 Aug 2013 08:02:53 +0000 (10:02 +0200)]
[FEATURE] Intgrate CSS class "lead" for introductions

The most relevant text should always be highly visible.
Integrate the CSS class "lead" for introductions.

Lead brings a slightly larger font size and should be used
for the first short introduction text only.

"Lead" is a semantical annotation.
Follow-ups: Bring lead texts for all backend modules.

Change-Id: I10305c2d2ed66526d7e882aceff17b5d317cfbb3
Resolves: #51022
Releases: 6.2
Reviewed-on: https://review.typo3.org/23050
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Reposition TYPO3 logo text 47/23047/2
Felix Kopp [Sun, 11 Aug 2013 22:21:53 +0000 (00:21 +0200)]
[BUGFIX] Reposition TYPO3 logo text

Brings logo text "TYPO3" in line with module menu text.

Change-Id: Ief21e7ded4f8085e2f661304b55861211f202955
Resolves: #51015
Releases: 6.2
Reviewed-on: https://review.typo3.org/23047
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Visual feedback on hover: spot text links 19/23019/2
Felix Kopp [Sat, 10 Aug 2013 11:15:16 +0000 (13:15 +0200)]
[TASK] Visual feedback on hover: spot text links

Text links are not spotted easily. Give TYPO3 an easy visual feedback
for text links on hover. Hover on table rows also pumps up text links.

Change-Id: Ie255df54a5c556160f0e0826c87ff6425907bcb0
Resolves: #50997
Releases: 6.2
Reviewed-on: https://review.typo3.org/23019
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] EXT: beuser remove spaces from links 48/23048/3
Felix Kopp [Sun, 11 Aug 2013 22:28:45 +0000 (00:28 +0200)]
[TASK] EXT: beuser remove spaces from links

Removes excessive spaces from within links / a-tags.

Change-Id: Ica8b6d365282dc3a0e6588a5099404c6b4bc7c73
Resolves: #51016
Releases: 6.2
Reviewed-on: https://review.typo3.org/23048
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Installer: Ask for username during initial setup 82/22982/2
Stefan Neufeind [Fri, 9 Aug 2013 06:55:01 +0000 (08:55 +0200)]
[TASK] Installer: Ask for username during initial setup

Good security-practice is to choose a username different
than "admin".

Change-Id: Ib4a70b491f1f9a9112b8cd37db43664186d7192d
Resolves: #50949
Releases: 6.2
Reviewed-on: https://review.typo3.org/22982
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] EXT: extensionmanager PNG icon 46/23046/3
Felix Kopp [Sun, 11 Aug 2013 21:16:51 +0000 (23:16 +0200)]
[FEATURE] EXT: extensionmanager PNG icon

Use transparent PNG version of backend module icon for
EXT: extensionmanager in module menu instead of GIF.

Change-Id: I424a082c6a294be5f49d4c2a9dd976cb014d5096
Resolves: #51014
Releases: 6.2
Reviewed-on: https://review.typo3.org/23046
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] EXT: be_user - improve listing 20/23020/4
Felix Kopp [Sat, 10 Aug 2013 11:36:58 +0000 (13:36 +0200)]
[TASK] EXT: be_user - improve listing

Backend user's username and real name are tightly coupled. These
texts should stand right next to each other. Merged username and
real name columns. When real name is unknown, not a problem.

Also adds link to the primary action / edit view to user listing.

Change-Id: I16d06771ad302fe64232e068e12663d87c07d79d
Resolves: #50999
Resolves: #50994
Related: #50998
Releases: 6.2
Reviewed-on: https://review.typo3.org/23020
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Allow reading files if storage is not browsable 34/23034/2
Helmut Hummel [Sat, 10 Aug 2013 21:26:42 +0000 (23:26 +0200)]
[BUGFIX] Allow reading files if storage is not browsable

Whether a storage is browsable or not should not
affect the possibility to read a file with a
given identifier.

Releases: 6.0, 6.1, 6.2
Resolves: #51010

Change-Id: Ic754143ed39a277f14c488c5b0d4c050dde027df
Reviewed-on: https://review.typo3.org/23034
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Take into account all file and folder permissions 35/23035/3
Helmut Hummel [Sat, 10 Aug 2013 17:40:47 +0000 (19:40 +0200)]
[BUGFIX] Take into account all file and folder permissions

When handling the old file permission settings from
user or user group records, all current FAL user
permissions should be set accordingly, to not allow
file actions with FAL which were not allowed before.

In particular no write / change actions should be
allowed if no permissions are granted in the records.

Releases: 6.0, 6.1, 6.2
Resolves: #51005
Related: #51007

Change-Id: I873f23ed02428842621c8256df5792e54abbfe2c
Reviewed-on: https://review.typo3.org/23035
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Add signal in ResourceFactory for storage creation 33/23033/2
Helmut Hummel [Sun, 11 Aug 2013 16:28:42 +0000 (18:28 +0200)]
[TASK] Add signal in ResourceFactory for storage creation

We miss a central place to adapt or change
configuration for a resource storage.

Add a signal in the resource factory to be able
to post process a storage object after creation.

Releases: 6.0, 6.1, 6.2
Resolves: #51011
Change-Id: Iace95bc50ab149b4e62dd85c01417b3a3e6bf1cf
Reviewed-on: https://review.typo3.org/23033
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] rtehtmlarea acronym error with static_info_tables 6.0+ 64/22664/2
Stanislas Rolland [Mon, 29 Jul 2013 16:33:06 +0000 (12:33 -0400)]
[BUGFIX] rtehtmlarea acronym error with static_info_tables 6.0+

Problem: Editing acronym records fails with Static Info Tables 6.0+ as
tx_staticinfotables_div->selectItemsTCA does not exist anymore.
Solution: Use suggest wizard

Resolves: #50502
Releases: 6.0, 6.1, 6.2
Change-Id: I69e564662df19f0625ec3e71b05e91c7ed5edfc8
Reviewed-on: https://review.typo3.org/22664
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
6 years ago[BUGFIX] Invalid allowed value for color space 23/23023/4
Tomita Militaru [Sat, 10 Aug 2013 16:29:12 +0000 (19:29 +0300)]
[BUGFIX] Invalid allowed value for color space

The array with allowed color space names contains an invalid value
(grey), which is replaced by the correct one (gray).

Resolves: #50287
Releases: 6.2, 6.1
Change-Id: I96a2a1c4b55fc32e95a68f0f8ff0304d8de7bc51
Reviewed-on: https://review.typo3.org/23023
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Added autofocus attribute to textfield and textarea 94/21994/2
Tim Spiekerkoetter [Sat, 6 Jul 2013 10:35:35 +0000 (12:35 +0200)]
[FEATURE] Added autofocus attribute to textfield and textarea

The ViewHelpers f:form.textfield and f:form.textarea were lacking the
HTML5 "autofocus" attribute. It is available for button, input and
textarea. Now Fluid reflects this correctly by adding this attribute to
the initializeArguments methods for TextareaViewHelper and
TextfieldViewHelper.

Resolves: #48689
Releases: 6.2
Change-Id: I00480dc4e76b2854dc0be36d150d32c7b432d93d
Reviewed-on: https://review.typo3.org/21994
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Mixed up parameters in call to replaceMarkersInWhereClause 12/23012/3
Anja Leichsenring [Fri, 9 Aug 2013 15:01:47 +0000 (17:01 +0200)]
[BUGFIX] Mixed up parameters in call to replaceMarkersInWhereClause

The patch for #21892 breaks functionality due to a mixed up parameters
list in BackendUtility.

Resolves: #50976
Releases: 6.2
Change-Id: I46585d995ec345561f605a19202d91614ad5e8d8
Reviewed-on: https://review.typo3.org/23012
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Reports module tries to load not-installed extension 26/22726/4
Wouter Wolters [Tue, 30 Jul 2013 22:28:37 +0000 (00:28 +0200)]
[BUGFIX] Reports module tries to load not-installed extension

When you select a report from an extension, the reports module
will remember this when you re-open it. But if you have
uninstalled the extension in the meantime, the reports module
will throw an exception. This is fixed by checking the
$reportClass. If this is NULL then redirect to indexAction.

Change-Id: Ifad4e6ee8dc651a3d6b1360486fd5a7cb2abf111
Resolves: #48523
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22726
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] number_format() expects parameter 1 to be double 36/22936/4
Wouter Wolters [Wed, 7 Aug 2013 17:46:54 +0000 (19:46 +0200)]
[BUGFIX] number_format() expects parameter 1 to be double

In stdWrap function numberFormat $content is a string.
Make sure this is a float value when it is passed into
PHP function number_format.

Change-Id: If4a98ae8238264f94f771c997fbe6cac98311912
Resolves: #50868
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22936
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Workspaces and Version update wizard isn't skippable 80/22680/4
Wouter Wolters [Mon, 29 Jul 2013 23:42:51 +0000 (01:42 +0200)]
[BUGFIX] Workspaces and Version update wizard isn't skippable

When you skip the update wizard for workspaces and version
you always get the wizard back. The update wizard is not marked
as done when you don't want to install the extensions.

To fix this we need to copy some functions from AbstractUpdate
because the update wizard for workspaces and version extend the
SystemExtension update wizard.

Change-Id: I4f7f3e8606cdf41db5737b5f4dd22d8faf4a4acb
Resolves: #47734
Releases: 6.2
Reviewed-on: https://review.typo3.org/22680
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[FEATURE] Uninstall broken ext in install tool 72/22972/3
Susanne Moog [Thu, 8 Aug 2013 18:29:22 +0000 (20:29 +0200)]
[FEATURE] Uninstall broken ext in install tool

Adds buttons to uninstall incompatible extensions
to the install tool extension compatibility tester.
You may install extensions one-by-one or all at
once.

Change-Id: I717e127128f0f26e5b6711e0c1db04cf8d8cbfce
Resolves: #50940
Releases: 6.2
Reviewed-on: https://review.typo3.org/22972
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Form: "Redirect" postprocessor 07/18307/8
Christian Kuhn [Thu, 8 Aug 2013 18:58:05 +0000 (20:58 +0200)]
[FEATURE] Form: "Redirect" postprocessor

* Implements a basic postprocessor to perform a redirect.
* Adds it to the form-wizard.
* Enables prepared ExtJS-code for removing a postprocessor.

Resolves: #44482
Resolves: #38094
Releases: 6.2
Change-Id: I7e09bc9aa9821ac20e890343eb95c34c010dfba3
Reviewed-on: https://review.typo3.org/18307
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Ignore case in file extension filter 24/22724/5
Alexander Stehlik [Sat, 3 Aug 2013 18:14:10 +0000 (20:14 +0200)]
[BUGFIX] Ignore case in file extension filter

This patch makes the FileExtensionFilter case insensitive.

If the filter is configured to allow files with the ".EXT"
extension it will now also allow files with an ".ext"
extension.

Additionally the order of a data provider method in the
FileExtensionFilterTest has been corrected.

Resolves: #50568
Releases: 6.2, 6.1, 6.0
Change-Id: I5761ab7f06116ef847caeb2ae786e580730c0e6b
Reviewed-on: https://review.typo3.org/22724
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Substitution of default markers in single function 61/22661/5
Nicole Cordes [Mon, 29 Jul 2013 15:48:25 +0000 (17:48 +0200)]
[FEATURE] Substitution of default markers in single function

In the function
TYPO3\CMS\Backend\Utility\BackendUtility::exec_foreign_table_where_query
a lot of default markers (like CURRENT_PID, etc.) are replaced.
It would be useful to have this substitution available as single
function, so that it can be called without executing some query.

Resolves: #21892
Releases: 6.2
Change-Id: I4da8279d1b95566690bb0934ac00299e4f4fee3e
Reviewed-on: https://review.typo3.org/22661
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Correctly set user storage permissions 21/22921/2
Helmut Hummel [Wed, 7 Aug 2013 11:00:39 +0000 (13:00 +0200)]
[BUGFIX] Correctly set user storage permissions

With FAL a new way to define file permissions
(for storages) has been introduced. You can set
these in User TsConfig instead of doing it
in the user record.

There is a backwards compatibility layer, which should
set the permissions according to the database entry
in case no permissions have been set in TsConfig.
This however does not work, because of a wrong check
for existence of UserTsConfig properties.

Instead of checking for an array (which is always the case),
we have to check if the array is not empty.

Releases: 6.0, 6.1, 6.2
Resolves: #50872
Change-Id: I0ec30a1ae96c4b6916a3e46c7222f832c44f603e
Reviewed-on: https://review.typo3.org/22921
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Oliver Hader
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Introduce AbstractHierarchicalFilesystemDriver 16/22916/3
Steffen Ritter [Wed, 7 Aug 2013 09:09:55 +0000 (11:09 +0200)]
[TASK] Introduce AbstractHierarchicalFilesystemDriver

There are many tasks which apply to all drivers working on an
Hierarchical FileSystem (NFS, WebDav, LocalDriver, ....).
When it comes to security we dont want custom drivers to implement
that all on their own, but provide it by the System.

Introducing AbstractHierarchicalFilesystemDriver enables us to
do so, without breaking compatibility (Base class, interface
and Classname stay the same).

Releases: 6.2, 6.1, 6.0
Resolves: #50867
Change-Id: Ib1b45c6ad384f82f7a5138372ed91269b8db38c2
Reviewed-on: https://review.typo3.org/22916
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Failing Resource\FactoryTest on Windows systems 94/22894/3
Nicole Cordes [Tue, 6 Aug 2013 20:00:25 +0000 (22:00 +0200)]
[BUGFIX] Failing Resource\FactoryTest on Windows systems

Two tests in class TYPO3\CMS\Core\Tests\Unit\Resource\FactoryTest fail
with warnings. This is because of two single issues.

First of all the test depends on a folder which (might) belong to an own
storage other than storage 0 (fileadmin). This patch changes fileadmin
to the typo3 folder as this one should be not included in any storage.

On the other hand on Windows systems a full path contains always a colon
which breaks any storage check. To solve this we have to fix any
absolute path beforehand as it is done in the sub functions as well.

Resolves: #50843
Releases: 6.2, 6.1, 6.0
Change-Id: I950a3c81222155da403ca1eb7b920e8682033450
Reviewed-on: https://review.typo3.org/22894
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] Indexing of external files does not work in indexed_search 95/22595/2
Wouter Wolters [Fri, 26 Jul 2013 15:35:17 +0000 (17:35 +0200)]
[BUGFIX] Indexing of external files does not work in indexed_search

After the namespace change a wrong replace was done in
indexed_search. Replace it with the correct class.

Change-Id: I35295f4fecde241ec3004a8ee6b7dd71d5e34e93
Resolves: #47106
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22595
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Callback in CrawlerHook of indexed_search sysext buggy 97/22897/2
Marius Büscher [Tue, 6 Aug 2013 21:53:37 +0000 (23:53 +0200)]
[BUGFIX] Callback in CrawlerHook of indexed_search sysext buggy

The property $callBack pointed to a Controller that was not existing.
Now it points back to the Hook.

Resolves: #50562
Releases: 6.2, 6.1, 6.0
Change-Id: I79e0ce73a23d98c5922ead43480202b3445282b2
Reviewed-on: https://review.typo3.org/22897
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Failing tests in Resource\Driver\LocalDriverTest on Windows 95/22895/2
Nicole Cordes [Tue, 6 Aug 2013 20:22:06 +0000 (22:22 +0200)]
[BUGFIX] Failing tests in Resource\Driver\LocalDriverTest on Windows

The test createdFilesAreEmpty depends on another test which returns a
mocked object. In the mock two returnValues for getIdentifier() and
getName() were set. But due to PHPUnit architecture mocked functions
belong to the test there were defined and cannot be shared. This is why
the mock has to be initialized within the test itself. The test only
works because on unix system you can open a folder which returns an
empty string.

Furthermore if you use any php function to get a folder path we have to
fix the containing backslashes.

Finally due to some errors we have to rewind any iterator of class
RecursiveIteratorIterator as otherwise a wrong index is returned.

Resolves: #50844
Releases: 6.2, 6.1, 6.0
Change-Id: I13f9efbd1618056fcd66220e3de5e12af79e4dc6
Reviewed-on: https://review.typo3.org/22895
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Backup singletons in unit tests prior to other setUp operations 38/22838/3
Nicole Cordes [Tue, 6 Aug 2013 10:22:51 +0000 (12:22 +0200)]
[BUGFIX] Backup singletons in unit tests prior to other setUp operations

If the singleton management is changed in unit tests, a local copy of
the previous stage is done to re-construct this state in tearDown().
This has to be done before any other instantiation in setUp() is
initiated which might register additional singletons.

Resolves: #50812
Releases: 6.2, 6.1, 6.0
Change-Id: I7788a5788aca6777040b777aeceb0558f96022b2
Reviewed-on: https://review.typo3.org/22838
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] PHP warning in ext:documentation 93/22893/3
Wouter Wolters [Tue, 6 Aug 2013 19:18:28 +0000 (21:18 +0200)]
[BUGFIX] PHP warning in ext:documentation

PHP warning will be thrown if typo3conf/Documentation
does not exists. Add a check to prevent the warning.

Change-Id: Ia9def8bb5b36da888eba3817ded9b348f48c37a3
Resolves: #50841
Releases: 6.2
Reviewed-on: https://review.typo3.org/22893
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Test in Configuration\ConfigurationManagerTest fails in backend 96/22896/3
Nicole Cordes [Tue, 6 Aug 2013 20:53:37 +0000 (22:53 +0200)]
[BUGFIX] Test in Configuration\ConfigurationManagerTest fails in backend

When running the tests in the PHPUnit backend, the path of the current
working directory is typo3/ (where mod.php is included). Therefore the
test canWriteConfigurationReturnsTrueIfDirectoryAndFilesAreWritable
fails as it deals with paths relative to the root directory. We have to
use absolute paths to ensure files in typo3temp folder exist.

Resolves: #50845
Releases: 6.2, 6.1
Change-Id: I7859978c31cf523c8803316fdac8c067d00042cc
Reviewed-on: https://review.typo3.org/22896
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[FEATURE] Adds register values to FilesContentObj 47/21747/3
Lars Peipmann [Sun, 30 Jun 2013 14:23:27 +0000 (16:23 +0200)]
[FEATURE] Adds register values to FilesContentObj

Adds FILE_NUM_CURRENT and FILES_COUNT to the register
for each file.

Use case:
10 = FILES
10 {
references {
table = tt_news
uid.field = uid
fieldName = media
}
renderObj = COA
renderObj {
10 = TEXT
10.value = Render first file two times
10.if.isFalse.data = register:FILE_NUM_CURRENT
20 = TEXT
20.value = file {register:FILE_NUM_CURRENT} of {register:FILES_COUNT}
20.insertData = 1
}
}

Resolves: #49480
Releases: 6.2
Change-Id: I3eca404210ee21f73cea0860fa0be7cc39b4632f
Reviewed-on: https://review.typo3.org/21747
Reviewed-by: Lars Peipmann
Tested-by: Lars Peipmann
Tested-by: Wouter Wolters
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Load documentation extension by default 68/22668/3
Xavier Perseguers [Mon, 29 Jul 2013 18:14:35 +0000 (20:14 +0200)]
[TASK] Load documentation extension by default

The documentation extension should be loaded by default for new
websites and should be suggested in Install Tool when upgrading.

Resolves: #50536
Releases: 6.2
Change-Id: I97755b96cf0ccce849e986650d5deca37cde294a
Reviewed-on: https://review.typo3.org/22668
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Fix EmConfUtility::fixEmConf conflicts generation 46/22746/3
Sascha Egerer [Thu, 1 Aug 2013 09:46:42 +0000 (11:46 +0200)]
[BUGFIX] Fix EmConfUtility::fixEmConf conflicts generation

EmConfUtility::fixEmConf generates a string instead
of an array for "$emConf['constraints']['conflicts']"

Resolves: #50628
Releases: 6.2, 6.1, 6.0
Change-Id: I37e026569e761b8550a9b0e6a1cb10835f6c899b
Reviewed-on: https://review.typo3.org/22746
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Use proper implementation of a wordwrap 40/22840/5
Georg Ringer [Tue, 6 Aug 2013 12:17:09 +0000 (14:17 +0200)]
[BUGFIX] Use proper implementation of a wordwrap

The page module uses a custom implementation of a wordwrap
as this was not supported by the browser in those earlier days.

The big drawback is that there is no UTF8 support for this which
leads to empty preview boxes when e.g. using Japanese.

Change-Id: I7caab8e14a9a0b7ccbd38c692b0cf98635967567
Resolves: #15797
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/22840
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Incorrect check for empty folder 74/22674/4
Philipp Gampe [Mon, 29 Jul 2013 20:15:32 +0000 (22:15 +0200)]
[BUGFIX] Incorrect check for empty folder

The condition in ResourceStorage::deleteFolder is wrong.
Negate the isFolderEmpty() clause.

Resolves: #50125
Releases: 6.2, 6.1, 6.0
Change-Id: Ia60f3e97ff8d1e0cc2671cec1b31cfc995c235b1
Reviewed-on: https://review.typo3.org/22674
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Use magic __CLASS__ in getInstance()-methods 41/22741/2
Stefan Neufeind [Thu, 1 Aug 2013 01:20:23 +0000 (03:20 +0200)]
[TASK] Use magic __CLASS__ in getInstance()-methods

Some classes contain static getInstance()-methods that return
an instance of themselves. Instead of using the correct namespace
and classname everywhere, just use __CLASS__.

Change-Id: I22770505acded0c54b07dd0e239976ad01fdf893
Resolves: #50615
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22741
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] MySQLi: Allow persistent connections again 13/22813/2
Stefan Neufeind [Mon, 5 Aug 2013 08:31:20 +0000 (10:31 +0200)]
[BUGFIX] MySQLi: Allow persistent connections again

For a persistent connection the hostname needs to be
prefixed with "p:". This was already prepared in the
code, however that variable was not yet used.

Change-Id: I01e20fd69239d0772ca9b371af0058316541f2a9
Resolves: #50781
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/22813
Reviewed-by: Philipp Gampe
Tested-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix failing test in StorageRepositoryTest 36/22836/9
Anja Leichsenring [Tue, 6 Aug 2013 08:18:00 +0000 (10:18 +0200)]
[BUGFIX] Fix failing test in StorageRepositoryTest

With #50803 the usage of the constant TYPO3_MODE was introduced. This
leads to the failing test, after the constant can not be redefined
for test purposes.

To work around this, a method that can be mocked is introduced, and
specifically set to "FE" for this test to work again.

Resolves: #50809
Relates: #50803
Releases: 6.2, 6.1, 6.0
Change-Id: I7319d8ccef530feff69a7f9885df24dba0beed4d
Reviewed-on: https://review.typo3.org/22836
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
6 years ago[BUGFIX] Fix empty href parameter 89/22789/6
Anja Leichsenring [Sat, 3 Aug 2013 13:38:46 +0000 (15:38 +0200)]
[BUGFIX] Fix empty href parameter

In case the link target is not available (maybe hidden), the behaviour
known from the Core is to render the link text, but no a tag. The pageVH
renders the link, but the href parameter will be empty.

Resolves: #50751
Releases: 6.2, 6.1, 6.0
Change-Id: I526aa0e3d42f8aba867b3f996bac2366dc1f6d19
Reviewed-on: https://review.typo3.org/22789
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Fatal error: "enableFields on non-object" in extension manager 30/22830/3
Ernesto Baschny [Mon, 5 Aug 2013 20:28:05 +0000 (22:28 +0200)]
[BUGFIX] Fatal error: "enableFields on non-object" in extension manager

Don't rely on $TSFE object to detect if we are in a frontend context. Rely
on TYPO3_MODE constant instead.

Releases: 6.2, 6.1, 6.0
Resolves: #50803
Change-Id: I06ea2692dab7683c7284e5f3ff45036d72c64999
Reviewed-on: https://review.typo3.org/22830
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Cleanup update wizard in Install Tool 54/22754/4
Wouter Wolters [Thu, 1 Aug 2013 15:51:04 +0000 (17:51 +0200)]
[TASK] Cleanup update wizard in Install Tool

Cleanup the update wizard classes and move all
classes to one folder instead of the two that
are used now.

Change-Id: Id6a000fe75892d1596984954b2b2f8a78eaf0483
Resolves: #50670
Releases: 6.2
Reviewed-on: https://review.typo3.org/22754
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] FAL: Image Processing doesn't respect GFX "thumbnails_png" 20/22420/3
Benjamin Mack [Fri, 19 Jul 2013 13:16:05 +0000 (15:16 +0200)]
[BUGFIX] FAL: Image Processing doesn't respect GFX "thumbnails_png"

The Task Interface of the File Abstraction Layer defines the
target file extension for graphcal tasks. Previously this was done
with the option "thumbnails_png" from the TYPO3_CONF_VARS.

However, checking for that parameter is not done anymore within
FAL/AbstractGraphicalTask. Thus, all .gif images are shown as .png
files, even though TYPO3 is not configured like that.

This can be seen when using GM, thumbnails_png=0, and creating
a preview image of an animated GIF. The preview will not be shown
for some images then.

The patch introduces the existing option back in to 6.x/FAL.

Releases: 6.2, 6.1, 6.0
Resolves: #50193
Change-Id: Ie539fe1aa1ab7366129a156be8ce9b05a5f8d5d2
Reviewed-on: https://review.typo3.org/22420
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[FEATURE] Find best-matching local storage instead of default-storage 90/18290/10
Stefan Neufeind [Fri, 15 Feb 2013 02:21:57 +0000 (03:21 +0100)]
[FEATURE] Find best-matching local storage instead of default-storage

If no storage-UID is given usually the default-storage will be
used ("legacy-storage"). Some problems with not up-to-date
index-records etc. can be prevented by using a matching storage
instead of falling back to the default-storage (ID 0).

Implement search for best matching storage.

Resolves: #45498
Releases: 6.2
Change-Id: Ife00d68314fe43804227bb26280d0d475cbaf10b
Reviewed-on: https://review.typo3.org/18290
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] ControllerExtensionName can not be resolved in CLI mode 10/22410/5
Achim Fritz [Thu, 18 Jul 2013 18:35:59 +0000 (20:35 +0200)]
[BUGFIX] ControllerExtensionName can not be resolved in CLI mode

This fixes the resolution of the controllerExtensionName in CLI
context.

Change-Id: Ic0363a4e1b055aff813ddf8620403df5a4fa872f
Resolves: #49288
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/22410
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] MySQL: Use ENGINE (not TYPE) for storage-engine 92/22592/3
Stefan Neufeind [Fri, 26 Jul 2013 13:19:35 +0000 (15:19 +0200)]
[BUGFIX] MySQL: Use ENGINE (not TYPE) for storage-engine

Using TYPE is deprecated since a MySQL 4.x and was removed in MySQL
5.5. Core already uses ENGINE but SqlParser turned that into TYPE,
leading to errors.

From https://dev.mysql.com/doc/refman/5.0/en/storage-engines.html:
"The older term TYPE is supported as a synonym for ENGINE for
backward compatibility, but ENGINE is the preferred term and TYPE
is deprecated."

Change-Id: I6607d3e726c43cb74ca00f33ec2332de4f6a76d8
Resolves: #50466
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22592
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[CLEANUP] Remove useless CSS file in EXT:documentation 63/22763/2
Xavier Perseguers [Fri, 2 Aug 2013 09:26:19 +0000 (11:26 +0200)]
[CLEANUP] Remove useless CSS file in EXT:documentation

Releases: 6.2
Resolves: #50728
Change-Id: I2de2182d094b8e8eb5373c38f57e20331ea3d4d6
Reviewed-on: https://review.typo3.org/22763
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
6 years ago[BUGFIX] selected = 1 doesn't work in FormContentObject 82/20282/3
Wouter Wolters [Sun, 28 Apr 2013 22:01:20 +0000 (00:01 +0200)]
[BUGFIX] selected = 1 doesn't work in FormContentObject

Wrong variable is used to set selected correctly.

Change-Id: I90623339c4d13eb07d7e5ef87e1b4e3aa8cf147e
Resolves: #43893
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/20282
Reviewed-by: uwe trotzek
Tested-by: uwe trotzek
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix invalid global for getData hooks 35/22735/3
Alexander Stehlik [Wed, 31 Jul 2013 16:21:31 +0000 (18:21 +0200)]
[BUGFIX] Fix invalid global for getData hooks

Replace the invalid usage of $TYPO3_CONF_VARS with
$GLOBALS['TYPO3_CONF_VARS'] for getting the hook
configuration in ContentObjectRenderer::getData().

This bug was introduced with issue #50606 in 6.2 only.

Resolves: #50606
Related: #50258
Releases: 6.2
Change-Id: Ib553f8c0dacd891e4bd392481ef7b4773386287f
Reviewed-on: https://review.typo3.org/22735
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Create BE-user in Install Tool with a salted password 76/22676/3
Wouter Wolters [Mon, 29 Jul 2013 22:31:23 +0000 (00:31 +0200)]
[FEATURE] Create BE-user in Install Tool with a salted password

Introduce the possibility to salt the password when creating
a new Backend User in the Install Tool. When Saltedpasswords
is installed and backend usage is enabled the password will
be salted with saltedpasswords. Otherwise the md5 hashing method
is still used.

Change-Id: I30b2fab2c4158c878e849f061f0d464b501b62bc
Resolves: #31407
Releases: 6.2
Reviewed-on: https://review.typo3.org/22676
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
6 years ago[TASK] Raise PHP version requirement to 5.3.7 62/22662/3
Christian Kuhn [Mon, 29 Jul 2013 15:53:03 +0000 (17:53 +0200)]
[TASK] Raise PHP version requirement to 5.3.7

PHP versions smaller than 5.3.7 have some bugs that are worked
around with some nasty hacks in current core. It was already
decided on TYPO3 Active Contributor Meeting in Nuernberg to
not support these versions with the upcoming LTS that will have
to support so many different PHP versions already: Younger 5.3,
5.4, 5.5 and later on in the lifecycle of the product maybe even
more.

The patch drops compatibility code for versions smaller than 5.3.7.

Change-Id: I3344d797f0c2f23f5135257b98c1b05c80871399
Resolves: #50529
Releases: 6.2
Reviewed-on: https://review.typo3.org/22662
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Cleanup ext:func 68/22268/6
Wouter Wolters [Fri, 12 Jul 2013 18:53:20 +0000 (20:53 +0200)]
[TASK] Cleanup ext:func

- Remove require_once calls
- Replace global $LANG and $BACK_PATH

Change-Id: I279bf7a1a59ed3dbf490a6b875977915ef503d13
Resolves: #49989
Releases: 6.2
Reviewed-on: https://review.typo3.org/22268
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Travis setup without Introduction package 23/22723/2
Christian Kuhn [Tue, 30 Jul 2013 14:29:35 +0000 (16:29 +0200)]
[TASK] Travis setup without Introduction package

In travis, the introduction package is used to import the database
schema to successfully run the unit tests.
This is now substituted with a small php based script in the
travis integration repository, that basically imports the base schema
by running code similar to the according step in the installation
process. Cloning the introduction package is no longer needed.
Travis will now for automatically adapt to database schema changes
defined in ext_tables.sql scripts and without changing foreign
repositories anymore.

Change-Id: If246650acfabde119d4e02c78d5449ab8d44feef
Resolves: #50571
Releases: 6.2
Reviewed-on: https://review.typo3.org/22723
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup ext:info and ext:info_pagetsconfig 71/22271/5
Wouter Wolters [Fri, 12 Jul 2013 19:46:59 +0000 (21:46 +0200)]
[TASK] Cleanup ext:info and ext:info_pagetsconfig

- Remove require_once calls
- Replace global $LANG and $BACK_PATH
- Make some function calls use real boolean

Change-Id: I6e913e183a8357076b55d84c961e1104d643e81e
Resolves: #49992
Releases: 6.2
Reviewed-on: https://review.typo3.org/22271
Reviewed-by: Oliver Klee
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[SECURITY] fileDenyPattern ignored in file-list module 12/22712/2
Jigal van Hemert [Tue, 30 Jul 2013 12:39:57 +0000 (14:39 +0200)]
[SECURITY] fileDenyPattern ignored in file-list module

Change-Id: Icf4b3452c3b039f12335e184161083cbcbd3acec
Fixes: #47452
Releases: 6.0, 6.1, 6.2
Security-Commit: 15cd3daec85c16cf0e810c41f5005810876fc99b
Security-Bulletin: TYPO3-CORE-SA-2013-002
Reviewed-on: https://review.typo3.org/22712
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] XSS in 3rd party library Flowplayer 11/22711/2
Oliver Hader [Tue, 30 Jul 2013 12:39:42 +0000 (14:39 +0200)]
[SECURITY] XSS in 3rd party library Flowplayer

Change-Id: I6bb53b23ca4df6f8d4b8ee801bd99a1a5c32f5b2
Fixes: #49209
Releases: 4.7, 6.0, 6.1, 6.2
Security-Commit: 7d306dbb20eb3a6b1dbee6c9896835c50dda87eb
Security-Bulletin: TYPO3-CORE-SA-2013-002
Reviewed-on: https://review.typo3.org/22711
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] XSS in 3rd party library Audio Player 10/22710/2
Oliver Hader [Tue, 30 Jul 2013 12:39:34 +0000 (14:39 +0200)]
[SECURITY] XSS in 3rd party library Audio Player

Update player.swf of version 2.0.4.6 from
http://wordpress.org/plugins/audio-player/

Change-Id: Ib9ba8c7f02279c42d619154b9b79cc38a8e2c41b
Fixes: #49210
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Security-Commit: 0391f9dad3698a519b0f6785d210accddc708238
Security-Bulletin: TYPO3-CORE-SA-2013-002
Reviewed-on: https://review.typo3.org/22710
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] EM unit test is broken 86/22686/2
Xavier Perseguers [Tue, 30 Jul 2013 05:21:10 +0000 (07:21 +0200)]
[BUGFIX] EM unit test is broken

Follow-up: #50441
Releases: 6.2
Change-Id: I008a3b08ff84b050118d9b37adc6e61e9ddd9279
Reviewed-on: https://review.typo3.org/22686
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Deleted flag is not updated during file indexing 60/22660/3
Oliver Hader [Mon, 29 Jul 2013 14:31:44 +0000 (16:31 +0200)]
[BUGFIX] Deleted flag is not updated during file indexing

If sys_file records (file objects) have set the deleted flag, it
won't be removed once the file is physically available again
with the same file name (identifier).

Change-Id: Id6dc7466764ac3994606204edadc9c2a7d2106c8
Fixes: #50525
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22660
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[FEATURE] Add a timestamp when downloading an extension 69/22669/2
Xavier Perseguers [Mon, 29 Jul 2013 18:25:18 +0000 (20:25 +0200)]
[FEATURE] Add a timestamp when downloading an extension

When downloading an extension within the Extension Manager, a
timestamp should be automatically added to the filename.

Resolves: #50441
Releases: 6.2
Change-Id: I86c00b814715b126a655f2c73b40b955b328acff
Reviewed-on: https://review.typo3.org/22669
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[BUGFIX] MailUtility breakLinesForEmail cuts text wrong and discard rest 78/21978/5
Tim Lochmueller [Fri, 5 Jul 2013 21:26:50 +0000 (23:26 +0200)]
[BUGFIX] MailUtility breakLinesForEmail cuts text wrong and discard rest

Now the substrStart pointer increases in case that the line is longer
than the lineWidth parameter.

Resolves: #49396
Releases: 6.2, 6.1, 6.0
Change-Id: I87b3622c2ada7efdcb4c1992c1cfa43635d68f09
Reviewed-on: https://review.typo3.org/21978
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[FEATURE] stdWrap replacement: add optionSplit-support 98/15898/6
Stefan Neufeind [Mon, 22 Oct 2012 23:28:34 +0000 (01:28 +0200)]
[FEATURE] stdWrap replacement: add optionSplit-support

With optionSplit the "replace"-parameter can be
different depending on the occurence of the string
(first/middle/last-part, ...).

Change-Id: Ic71adfbc05e6c963098d47847475f731eb577af2
Resolves: #42287
Releases: 6.2
Reviewed-on: https://review.typo3.org/15898
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years agoRevert "[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay" 70/22670/2
Anja Leichsenring [Mon, 29 Jul 2013 19:10:57 +0000 (21:10 +0200)]
Revert "[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay"

This reverts commit ef71d61619d7da17131c38531308d4abbfa8dbf5

The patch introduces a regression. We have no easy fix for it, so the patch gets reverted. Sorry for now, we come back to the problem.

Change-Id: Iad674e88ea488d3bcee4d306b3e5c935a4c90334
Reviewed-on: https://review.typo3.org/22670
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years agoRevert "[BUGFIX] sys_file record doesn't get flagged as delete" 65/22665/2
Oliver Hader [Mon, 29 Jul 2013 16:39:26 +0000 (18:39 +0200)]
Revert "[BUGFIX] sys_file record doesn't get flagged as delete"

This reverts commit 18bb6574966d6fdff944e8fd5f95e9225dae4365

Change-Id: I2cd6c4a03c3336e73bfe81fa86f222ce5a352f7d
Reviewed-on: https://review.typo3.org/22665
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Properly double-backslash some backslashes in strings 48/19948/4
Stefan Neufeind [Sat, 13 Apr 2013 21:58:01 +0000 (23:58 +0200)]
[TASK] Properly double-backslash some backslashes in strings

Resolves: #47198
Releases: 6.2
Change-Id: I56c1221b58ce08868ff755c4a54b0fa9f4447aff
Reviewed-on: https://review.typo3.org/19948
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Workspace selector in top toolbar cannot scroll 12/21912/4
Georg Ringer [Fri, 5 Jul 2013 09:41:09 +0000 (11:41 +0200)]
[BUGFIX] Workspace selector in top toolbar cannot scroll

If there are too many workspaces defined, some of them cannot
be accessed using the workspace selector in in the top toolbar
due to a missing scrolling behaviour of that component.

Fixes: #11014
Releases: 6.2, 6.1, 6.0
Change-Id: Iaae51ebb2524116b8673a9cc81d612fd845b2d29
Reviewed-on: https://review.typo3.org/21912
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Detection of curlProxyServer settings is incorrect 81/18481/5
Dmitry Dulepov [Tue, 26 Feb 2013 13:53:17 +0000 (17:53 +0400)]
[BUGFIX] Detection of curlProxyServer settings is incorrect

Parsing of 'curlProxyServer' option during the bootstrap is incorrect.
It produces wrong host and port part in 'proxy_host' and 'proxy_port'
system options.

Change-Id: I12f66acef697dbec9b065edcba8ad0d8f78c4e01
Resolves: #45834
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/18481
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] vfsStream: Use namespaced version from phpunit follow-up 49/22649/2
Wouter Wolters [Sun, 28 Jul 2013 19:53:38 +0000 (21:53 +0200)]
[TASK] vfsStream: Use namespaced version from phpunit follow-up

Follow-up for #50496

Change-Id: I7f0f453100d3024492387b241013cc7088089103
Resolves: #50504
Releases: 6.2
Reviewed-on: https://review.typo3.org/22649
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Backend documentation module 22/22622/5
Xavier Perseguers [Sat, 27 Jul 2013 13:15:35 +0000 (15:15 +0200)]
[FEATURE] Backend documentation module

The documentation module brings back access to extension manuals and
lets official TYPO3 documents (such as guidelines, tutorials and
references) as well as custom documents to be listed in a central place.

Resolves: #50486
Releases: 6.2
Change-Id: Ib35a48f72682844f1bfe569763a561a89e7d810b
Reviewed-on: https://review.typo3.org/22622
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
6 years ago[FEATURE] INCLUDE_TYPOSCRIPT all files from directory (recursive) 31/9431/13
Loek Hilgersom [Wed, 19 Dec 2012 21:47:27 +0000 (22:47 +0100)]
[FEATURE] INCLUDE_TYPOSCRIPT all files from directory (recursive)

Include all TypoScript files from a directory tree:
<INCLUDE TYPOSCRIPT: source="DIR:directorypath" extensions="ts">
This includes all files from the directory, including subdirs.
If the additional property extensions=".." is provided, only
files with these file extensions are included. This allows e.g.
to include both setup and constants from the same directory tree,
using different file extensions for each.
Order in which files are included is alphabetically, first files,
then directories.

Change-Id: Ie3ca7eea47b61326dfc1f60743051be13b8aee2f
Resolves: #34621
Releases: 6.2
Reviewed-on: https://review.typo3.org/9431
Tested-by: Sebastian Michaelsen
Reviewed-by: Ronald Klomp
Tested-by: Ronald Klomp
Reviewed-by: Rens Admiraal
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] RTE wizard can't "save document and view page" 11/20111/6
Stanislas Rolland [Tue, 23 Apr 2013 15:47:46 +0000 (11:47 -0400)]
[BUGFIX] RTE wizard can't "save document and view page"

Including the full fieldConfig from TCA may produce too long an URL.
In IE, the RTE wizard simply does not open.

Solution: Remove the fieldConfig parameter not used by the RTE wizard.

Revolves: #43637
Resolves: #43631
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Change-Id: Idd855d56d6a7ed92d40d9a788bc11efb3f535ed3
Reviewed-on: https://review.typo3.org/20111
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Support custom translation servers for extensions 87/22587/2
Xavier Perseguers [Fri, 26 Jul 2013 12:41:43 +0000 (14:41 +0200)]
[FEATURE] Support custom translation servers for extensions

Use of signal/slot to post-process the mirror URL when fetching
localization packages for a given extension key.

Resolves: #50467
Releases: 6.2
Change-Id: I6a0edc0a6765da05458c191f968f72068132b87b
Reviewed-on: https://review.typo3.org/22587
Reviewed-by: Stefan Neufeind
Reviewed-by: Begoña
Reviewed-by: Frans Saris
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
6 years ago[FEATURE] Add check if local extensions can be loaded 47/22047/13
Susanne Moog [Sat, 6 Jul 2013 17:17:45 +0000 (19:17 +0200)]
[FEATURE] Add check if local extensions can be loaded

Add a check in the install tool that checks if all local
extensions can be loaded without fatal errors by including
ext_localconf and ext_tables files.

Change-Id: I30ff00af83e59681c52901ecc09889f5c3cd4243
Releases: 6.2
Resolves: #49760
Reviewed-on: https://review.typo3.org/22047
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Adjust namespacing in Extbase-testcases 32/22232/2
Stefan Neufeind [Thu, 11 Jul 2013 21:30:33 +0000 (23:30 +0200)]
[TASK] Adjust namespacing in Extbase-testcases

Classes created for testing should run inside
separate testing-namespace and not pollute
the global namespace.
We also need to extend from \\TYPO3\\...
instead of just TYPO3\\... then.

Change-Id: I0577327a3b3a7ee1be089bf381b153dd1a1a5602
Resolves: #42984
Releases: 6.2
Reviewed-on: https://review.typo3.org/22232
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] vfsStream: Use namespaced version from phpunit 34/22634/3
Stefan Neufeind [Sat, 27 Jul 2013 22:18:17 +0000 (00:18 +0200)]
[TASK] vfsStream: Use namespaced version from phpunit

Newest phpunit introduced a namespaced version of
vfsStream together with the fix for #50230.
Although a migration-layer with the old classnames
was added, the namespaced classes should now
directly be used.

Change-Id: I1832f5690b9ea2b3f9fea5b7a1c2b39f8637f761
Resolves: #50496
Releases: 6.2
Reviewed-on: https://review.typo3.org/22634
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Check lightweight cases before class_exists if possible 27/22627/3
Stefan Neufeind [Sat, 27 Jul 2013 20:22:23 +0000 (22:22 +0200)]
[TASK] Check lightweight cases before class_exists if possible

If other checks like "in_array" can be done first that are more
lightweight than calling class_exists and potentially causing
(multiple) autoloaders (without success) to search for files.

Resolves: #50494
Releases 6.2

Change-Id: I9b2010c09591fd02eefdc57f869edd80d4106e14
Reviewed-on: https://review.typo3.org/22627
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Add a clear all cache button to install tool 33/22633/2
Christian Kuhn [Sat, 27 Jul 2013 21:09:58 +0000 (23:09 +0200)]
[FEATURE] Add a clear all cache button to install tool

This implements a clear all cache functionality to the install tool.

The implementation is different from the existing backend solution
so that it at least partly clears caches even if some broken
extension is loaded that would kill the operation.

To achieve that, first a low level removal of typo3temp/Cache is
performed, then all table names starting with "cf_" are truncated
with direct database calls. After that ext_localconf and ext_tables
of extension are loaded (this may fatal) and the final cache
configuration is then feeded to the cache manager that executes
the usual flushCaches() call.

Change-Id: Ibd717b0d34bd5b8737a73acebf4632fed38c4d8c
Resolves: #50495
Releases: 6.2
Reviewed-on: https://review.typo3.org/22633
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Use real boolean value for pi_getLL third param 93/22593/2
Wouter Wolters [Fri, 26 Jul 2013 13:24:53 +0000 (15:24 +0200)]
[TASK] Use real boolean value for pi_getLL third param

Make use of boolean value TRUE as third parameter in
pi_getLL function.

Change-Id: I688187fcb5130b9d3b49fabeee36c67cf300e3dc
Resolves: #50469
Releases: 6.2
Reviewed-on: https://review.typo3.org/22593
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Debug exception handler: set exit code on CLI 40/17240/4
Christian Weiske [Wed, 19 Dec 2012 13:50:40 +0000 (14:50 +0100)]
[BUGFIX] Debug exception handler: set exit code on CLI

Sets the exit code to 1 when an exception is caught by the debug exception
handler, so that the error state can be checked automatically.

Change-Id: Ic89a79f2ded0b4b9ccc58a4789d9416f260fd88a
Fixes: #44118
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/17240
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Class loader tries to load classes it cannot load 40/22440/4
Andreas Wolf [Sat, 20 Jul 2013 10:19:13 +0000 (12:19 +0200)]
[BUGFIX] Class loader tries to load classes it cannot load

If a class file from a third-party package is loaded which does not
follow the Vendor\Product\Classname convention (e.g. Product\Classname),
the class loader still tries to access the third component of the class
name, leading to a warning (and thus an exception, depending on your
configuration).

To fix this problem, the class loader now checks in advance if it can
possibly load this class (or rather if the classname conforms to the
specification for the CMS universe).

Change-Id: I1cd3964b9486ea591fb373533fd6cef4e9ce3989
Resolves: #50217
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22440
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Better distinction of fields in the backend 03/22603/4
Ingo Pfennigstorf [Fri, 26 Jul 2013 19:26:51 +0000 (21:26 +0200)]
[TASK] Better distinction of fields in the backend

This patch enables a better distinction of form elements in the
backend.

Change-Id: Id5bd87eeb68aaa68ccbc284d874a22a1ff0577bb
Fixes: #50460
Releases: 6.2
Reviewed-on: https://review.typo3.org/22603
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[CLEANUP] Avoid double parsing of includes 12/22612/2
Francois Suter [Fri, 26 Jul 2013 20:08:52 +0000 (22:08 +0200)]
[CLEANUP] Avoid double parsing of includes

The Template Analyzer BE module parses TypoScript for
included files twice.

Resolves: #50473
Releases: 6.2
Change-Id: I5794b55d22e3ca139112477cd28c5ad4477e97cc
Reviewed-on: https://review.typo3.org/22612
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Add tests for ContentObjectRenderer::getData() 73/22473/3
Stefan Neufeind [Sun, 21 Jul 2013 19:42:13 +0000 (21:42 +0200)]
[TASK] Add tests for ContentObjectRenderer::getData()

* Adds unittests
* Cleanup and fix some things along the way
* Some modes didn't allow to be executed without
  adding a dummy-value (e.g. "parameters")

Change-Id: I2b4ff89c828384c852e6fbf9f82c55e6ebbac281
Resolves: #50258
Releases: 6.2
Reviewed-on: https://review.typo3.org/22473
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Run phpLint and phpUnit in different travis builds 24/22624/2
Christian Kuhn [Sat, 27 Jul 2013 18:15:05 +0000 (20:15 +0200)]
[TASK] Run phpLint and phpUnit in different travis builds

phpLint checks php files for compilation errors in travis before
the unit tests are executed. This takes quite some time.
The patch configures travis to run phpLint and phpUnit in different
builds to speed up the process. Additionally, phpLint environment
does not clone phpunit and the introduction package and does no
database initialization.

Change-Id: Ie25ade5b6a8fcf4c4dc0752fc8662c433ea3c33c
Resolves: #50492
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22624
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Adds fileReferenceUid to content rendering 59/21759/3
Lars Peipmann [Mon, 1 Jul 2013 09:28:43 +0000 (11:28 +0200)]
[TASK] Adds fileReferenceUid to content rendering

FrontendContentAdapterService saves the file uid but not the
file reference uid.

This commits adds the file reference uid.

Change-Id: I5af09521d5dadc194ec567aec24792def370aedc
Resolves: #49535
Releases: 6.2
Reviewed-on: https://review.typo3.org/21759
Reviewed-by: Andreas Wolf
Reviewed-by: Lars Peipmann
Reviewed-by: Steffen Ritter
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Fix disappearing table head in extension manager 11/22611/3
Ingo Pfennigstorf [Fri, 26 Jul 2013 19:52:58 +0000 (21:52 +0200)]
[BUGFIX] Fix disappearing table head in extension manager

This is a sass recompilation of the extension manager scss that fixes
the problem of disappearing table heads.

Change-Id: I7b708f34798714170bed1cbf1b76599990c9dd6f
Fixes: #50440
Releases: 6.2
Reviewed-on: https://review.typo3.org/22611
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[TASK] Provide information about import action in TCEmain to hooks 15/10515/9
Stefan Galinski [Tue, 27 Nov 2012 01:31:50 +0000 (02:31 +0100)]
[TASK] Provide information about import action in TCEmain to hooks

While importing T3D files the TCEmain currently fires the required
processing on records just as if the editor is generating the records. If
extensions hook into TCEmain, there is no way to differenciate this
situation from the regular editing mode - which might provide unexpected
results, i.e. wrong IRRE relations.

Solution is to provide a boolean to indicate that TCEmain has been called
during an import action which extensions could use to recognize this
situation.

Change-Id: I4fe429fb88f8ec24a7fda885f38ddfbdb4a642f5
Resolves: #36031
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/10515
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Use @inject annotation in extensionmanager 19/22619/3
Ingo Pfennigstorf [Fri, 26 Jul 2013 23:12:43 +0000 (01:12 +0200)]
[TASK] Use @inject annotation in extensionmanager

This patch removes all occurences of injectFooBar methods from the
extensionmanager sysext and replaces them with the @inject
annotation.

Releases: 6.2
Fixes: #50482
Change-Id: Idc55d15e3a4d6086529864e4013478983b9c45e7
Reviewed-on: https://review.typo3.org/22619
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Make BackendUtility::viewOnClick honor doc 26/14826/8
Kasper Ligaard [Fri, 21 Sep 2012 12:27:28 +0000 (14:27 +0200)]
[BUGFIX] Make BackendUtility::viewOnClick honor doc

Make parameter $alternativeUrl work as documented in the docblock
and also as it worked until #22157.
This patch preserves the hook and basically just puts in an
if-statement. Also adding a unit test.

Change-Id: I7d67af438b0a0af51ca7662b3f8286aeec827c77
Fixes: #41165
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/14826
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Kasper Ligaard
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[TASK] Remove empty .gitmodules file 13/22613/2
Christian Kuhn [Fri, 26 Jul 2013 21:02:46 +0000 (23:02 +0200)]
[TASK] Remove empty .gitmodules file

With removal of git submodules the .gitmodules file is empty
and can be removed now.

Change-Id: I453f63c0852825b46e9ea62f87385d9eace25134
Resolves: #50480
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22613
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Failures in em unit tests due to phpunit update 04/22604/2
Christian Kuhn [Fri, 26 Jul 2013 19:30:43 +0000 (21:30 +0200)]
[BUGFIX] Failures in em unit tests due to phpunit update

Young phpunit versions seem to handle clones a bit differently,
resulting in test failures in extension manager tests. The tests
are adapted a bit to fix this.

Change-Id: If70561743f68a62167e41ee4c23ae96b56f83ab9
Resolves: #50478
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22604
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] FAL wrong \RecursiveIteratorIterator usage 02/22602/2
Christian Kuhn [Fri, 26 Jul 2013 18:54:23 +0000 (20:54 +0200)]
[BUGFIX] FAL wrong \RecursiveIteratorIterator usage

If using \RecursiveIteratorIterator on \RecursiveDirectoryIterator,
flag SELF_FIRST must be used, otherwise only leaves (files) and not
also directories are returned. This behavior is a bit dependent on
the PHP version used, younger versions (> 5.3.3 seem to do it
correctly).

Furthermore, in copyFolderWithinStorage() $itemSubPath contains
the "relative" path part and not only the node name, checking
equality to "." or ".." fails then if handling sub directories.
So, directories may be created multiple times, resulting in mkdir()
warnings. This is fixed by getting the node name itself and using
that for comparison.

Resolves: #50476
Releases: 6.2, 6.1, 6.0

Change-Id: Ifac4b28f4e02ec8a9bf5891739cf66c1e1074af9
Reviewed-on: https://review.typo3.org/22602
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] FAL does not copy subfolders cleanly 96/22596/2
Christian Kuhn [Fri, 26 Jul 2013 15:43:19 +0000 (17:43 +0200)]
[BUGFIX] FAL does not copy subfolders cleanly

If full structures with sub folders are copied around in FAL
local driver, sub folders are not correctly created in the
target directory.

This is detected in unit tests after recent vfsStream updates in
ext:phpunit.

The patch adds a flag to the Iterator code to also include
directories to fix the issue.

Additionally, the existing two unit tests also tested multiple other
methods of the local driver and are functional tests. The patch moves
those two tests to the functional section and adds three simple unit
tests with correct mocking instead.

Change-Id: I30d3c8bd5c6538b3fe23405d97bcddff6c1ff405
Releases: 6.2, 6.1, 6.0
Resolves: #50472
Reviewed-on: https://review.typo3.org/22596
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Use real boolean value for getLL second param 38/22538/2
Wouter Wolters [Wed, 24 Jul 2013 14:34:06 +0000 (16:34 +0200)]
[TASK] Use real boolean value for getLL second param

Make use of boolean value TRUE as second parameter in
getLL function.

Change-Id: I15fe034159e4bb8ecb7c15f8f6e915975fca7c9b
Resolves: #50393
Releases: 6.2
Reviewed-on: https://review.typo3.org/22538
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind