Packages/TYPO3.CMS.git
6 months ago[BUGFIX] Fixing login logo height in IE 20/57320/3
Roberto Presedo [Fri, 22 Jun 2018 21:41:16 +0000 (23:41 +0200)]
[BUGFIX] Fixing login logo height in IE

Resolves: #78592
Releases: master, 8.7
Change-Id: Ia7b3a25f6af61fce5376a68c1188c9564d603a23
Reviewed-on: https://review.typo3.org/57320
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Robert Vierke <robert.vierke+typo3@gmail.com>
Reviewed-by: Maik Peuser <maik.peuser@verdure.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Update complete database after extension installation 29/57429/11
Nicole Cordes [Sun, 1 Jul 2018 14:54:19 +0000 (16:54 +0200)]
[BUGFIX] Update complete database after extension installation

If an extension and its dependencies get installed, the whole
database needs to be updated instead of executing each extensions
SQL on its own.

Resolves: #79094
Releases: master, 8.7
Change-Id: I9a870e0efb6af241eeae563adbaa14af100edaec
Reviewed-on: https://review.typo3.org/57429
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Stabilize acceptance tests 60/57460/2
Christian Kuhn [Wed, 4 Jul 2018 14:22:37 +0000 (16:22 +0200)]
[TASK] Stabilize acceptance tests

This is one patch in the 'stabilize acceptance tests'
again mission. It changes various details in the Cest files.
At the same time changes within typo3/testing-framework
and the bamboo test execution are prepared, the version
bumps for those will follow with single patches later.

Resolves: #85470
Releases: master
Change-Id: I6ebe2499337e075f818b2726886ed02d743bb144
Reviewed-on: https://review.typo3.org/57460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Michael Bodnarchuk <davert.ua@gmail.com>
Tested-by: Michael Bodnarchuk <davert.ua@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Improve custom CE explanation in FSC 53/57453/4
Mathias Brodala [Tue, 3 Jul 2018 07:26:53 +0000 (09:26 +0200)]
[TASK] Improve custom CE explanation in FSC

Resolves: #85459
Releases: master, 8.7
Change-Id: I1732782fa920ffa0f7bfd42016a45ac6437bff0a
Reviewed-on: https://review.typo3.org/57453
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Karavas Aristeidis <aristeidis.karavas@gmail.com>
Tested-by: Karavas Aristeidis <aristeidis.karavas@gmail.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[BUGFIX] Fix „templates“ of Extension scanner 56/57456/2
Andreas Fernandez [Tue, 3 Jul 2018 11:36:28 +0000 (13:36 +0200)]
[BUGFIX] Fix „templates“ of Extension scanner

Due to a wrong change on the template container, the extension scanner
broke. This change recovers the functionality.

Resolves: #85464
Related: #85455
Releases: master
Change-Id: I3c62e89c59f0424e5381b485f7a11319a303296c
Reviewed-on: https://review.typo3.org/57456
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[BUGFIX] Fix „templates“ of Upgrade Wizards 55/57455/2
Andreas Fernandez [Tue, 3 Jul 2018 07:45:37 +0000 (09:45 +0200)]
[BUGFIX] Fix „templates“ of Upgrade Wizards

Due to a wrong change on the template container, the upgrade wizards
broke. This change recovers the functionality.

Resolves: #85460
Related: #85455
Releases: master
Change-Id: Iac97a9fac50fb7d7df60f163ba334d0f0012f1aa
Reviewed-on: https://review.typo3.org/57455
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Store System Maintenance tokens in data attributes 51/57451/3
Andreas Fernandez [Mon, 2 Jul 2018 14:42:23 +0000 (16:42 +0200)]
[TASK] Store System Maintenance tokens in data attributes

The tokens used in the System Maintenance area are stored in hidden
`<div>` elements, which is syntactically wrong and considered bad
practice.
Instead, the tokens are now stored in data attributes.

Resolves: #85455
Releases: master
Change-Id: I3a3be24897caa56c20355f0d36c7e7c4ae702640
Reviewed-on: https://review.typo3.org/57451
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[BUGFIX] Use correct type for getSections $mode parameter comment 84/57384/2
Tymoteusz Motylewski [Tue, 26 Jun 2018 20:40:12 +0000 (22:40 +0200)]
[BUGFIX] Use correct type for getSections $mode parameter comment

Resolves: #85399
Releases: master
Change-Id: I981886a920a0229fcb2f9fbb12ff7c914c563fb6
Reviewed-on: https://review.typo3.org/57384
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Synchronize .rst files between core versions 49/57449/2
Christian Kuhn [Mon, 2 Jul 2018 13:14:53 +0000 (15:14 +0200)]
[TASK] Synchronize .rst files between core versions

Resolve some minor differences between v8 and master
according to Changelog/Howto.rst. v7 is ok.

Resolves: #85454
Releases: master, 8.7
Change-Id: I07aba0283b09a5f0c2a2b4336cae4df17bbb46af
Reviewed-on: https://review.typo3.org/57449
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Deprecate ContentObjectRenderer->calcIntExplode() 38/57438/5
Benni Mack [Mon, 2 Jul 2018 10:04:31 +0000 (12:04 +0200)]
[TASK] Deprecate ContentObjectRenderer->calcIntExplode()

The method ContentObjectRenderer->calcIntExplode() is only used
within GraphicalMenuObject and can be migrated into the method call.

Resolves: #85451
Releases: master
Change-Id: Ia463fa8698d63a0aaa9a1810da6660d53e670f73
Reviewed-on: https://review.typo3.org/57438
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
6 months ago[BUGFIX] Display documentation changelog files with same issue number 09/57409/4
Anja [Thu, 28 Jun 2018 16:45:33 +0000 (18:45 +0200)]
[BUGFIX] Display documentation changelog files with same issue number

By using a hash instead of the issue number as array key, no file gets
lost any longer due to collision. Same issue numbers for documentation
files are quite common, e.g. when a new feature deprecates replaced code.

Change-Id: I3aef23b3bbc0d63486b1f75c38a54648991633b5
Resolves: #85420
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57409
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Streamline initialization of PageRepository 31/57431/5
Benni Mack [Sun, 1 Jul 2018 15:24:21 +0000 (17:24 +0200)]
[TASK] Streamline initialization of PageRepository

PageRepository ($TSFE->sys_page) has an init() function, which sets
some public properties, but is also called from the constructor.

However, there is the ominous $TSFE->setSysPageWhereClause()
which can only be set once the frontend user groups have been resolved.

In order to achieve that, the usergroup initialization within TSFE has
been moved before the intantiation of $TSFE->sys_page, allowing the
pagerepository constructor to set the variables directly, moving all
of the initialization code into PageRepository itself.

Resolves: #85450
Releases: master
Change-Id: I53dbdc0531076a47bcdf04617bfb1eae70e74279
Reviewed-on: https://review.typo3.org/57431
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[TASK] Make search field in install tool document viewer clearable 12/57412/2
Anja [Thu, 28 Jun 2018 18:29:42 +0000 (20:29 +0200)]
[TASK] Make search field in install tool document viewer clearable

The clear button comes in handy after every performed search to
empty the search input field without need for several keystrokes
or the need to mark all chars and press the backspace key.

Change-Id: Ica0242934664c6639ade99a3fc52de1b043d3ed3
Resolves: #85421
Releases: master
Reviewed-on: https://review.typo3.org/57412
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christoph Pascher <c.pascher@browserwerk.de>
Tested-by: Christoph Pascher <c.pascher@browserwerk.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[TASK] Decouple TemplateService->getFileName 03/57403/10
Benni Mack [Thu, 28 Jun 2018 07:22:46 +0000 (09:22 +0200)]
[TASK] Decouple TemplateService->getFileName

TemplateService in TYPO3 frontend is responsible for
fetching sys_template records and sorting TypoScript
related things out, but also contains one method,
which is nowadays completely separate from
sys_template: "getFileName".

This method checks for valid syntax and returns
a proper string then (resolves "EXT:... syntax"
and valdiates against available paths).

The logic is frontend-related, thus moved
to EXT:frontend/FilePathSanitizer.

The old functionality in TemplateService is
deprecated, along with the public property "fileCache".

Resolves: #85445
Releases: master
Change-Id: Id52ef476d0cd6a67de2560a0e427339b7310427e
Reviewed-on: https://review.typo3.org/57403
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Adapt glitches of context patch 36/57436/3
Christian Kuhn [Mon, 2 Jul 2018 08:54:28 +0000 (10:54 +0200)]
[BUGFIX] Adapt glitches of context patch

Some type hinting related and test changes from the main
context patch are fixed with the patch.

Resolves: #85447
Related: #85389
Releases: master
Change-Id: I674fd1cc253929643361a71ad7c5084d4429ddc5
Reviewed-on: https://review.typo3.org/57436
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Make ckeditor link browser not drop CSS-Classes if editing again 87/57387/2
Frédéric Lebel [Wed, 27 Jun 2018 02:57:49 +0000 (02:57 +0000)]
[BUGFIX] Make ckeditor link browser not drop CSS-Classes if editing again

Fix the link browser to not drop the CSS-Class value with multiple classes
if editing the same link.

Resolves: #85182
Releases: master, 8.7
Change-Id: Id7819f25c6a456c379de406816e44d7d1d76157e
Reviewed-on: https://review.typo3.org/57387
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Remove unused Doctrine restriction 34/57434/2
Benni Mack [Sun, 1 Jul 2018 18:13:56 +0000 (20:13 +0200)]
[BUGFIX] Remove unused Doctrine restriction

During the Doctrine DBAL refactoring, an
additional check for $TSFE->sys_page->showHiddenRecords
was introduced.

First of all: This check is not needed
as the restriction container is checking for
the REAL value correctly by using
$TSFE->showHiddenRecords.

Additionally, it checks for an invalid
property on PHP object property, which
is never a good idea.

Resolves: #85446
Releases: master, 8.7
Change-Id: Ib9dd0aa0197ee7d8379110a8067c31eba2ff73e8
Reviewed-on: https://review.typo3.org/57434
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Migrate Extbase Typo3DbBackend to Context API 01/57401/5
Benni Mack [Thu, 28 Jun 2018 05:27:39 +0000 (07:27 +0200)]
[TASK] Migrate Extbase Typo3DbBackend to Context API

Due to the introduction of Contexts, it is now possible
for Extbase to use the global context and to modify
it to set up a new instance of "PageRepository"
with just a context initialized. This way,
dependencies to $BE_USER and $TSFE->sys_page
are removed.

In further steps, the method should actually just work
with the context object which should be handed in,
however, some more work regarding language handling
has to be implemented first.

Resolves: #85413
Releases: master
Change-Id: If657d25943d92a69a754a29c22461d43b97c4095
Reviewed-on: https://review.typo3.org/57401
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[BUGFIX] Fix regressions and leftovers in Context API 96/57396/12
Benni Mack [Wed, 27 Jun 2018 13:31:53 +0000 (15:31 +0200)]
[BUGFIX] Fix regressions and leftovers in Context API

Some usages where now-deprecated properties are used,
have been adjusted.

The RST file has been enhanced to clarify when to clone
the context, and when to override an aspect.

Additionally, the usage within TemplateService has been
optimized to also receive an optional context object,
similar to the initial patch's PageRepository approach.

Resolves: #85408
Related: #85389
Releases: master
Change-Id: I178ff07cbfe999a90bf7d5dd4f20a6170876d003
Reviewed-on: https://review.typo3.org/57396
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Streamline FAL pre-emit signals for createFile and setContent 18/57418/2
Oliver Hader [Fri, 29 Jun 2018 13:02:29 +0000 (15:02 +0200)]
[TASK] Streamline FAL pre-emit signals for createFile and setContent

In order to streamline the FAL API the following signals have been added.
The according post-processing signals have been available already before:

+ ResourceStorageInterface::SIGNAL_PreFileCreate
+ ResourceStorageInterface::SIGNAL_PreFileSetContents

Resolves: #85434
Releases: master, 8.7
Change-Id: I41fc07afbc4e1a393c8a26fe02f431a7b62015d8
Reviewed-on: https://review.typo3.org/57418
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
6 months ago[BUGFIX] Adjust Headline of documentation file 10/57410/4
Anja [Thu, 28 Jun 2018 17:20:43 +0000 (19:20 +0200)]
[BUGFIX] Adjust Headline of documentation file

With the correct delimiter, the category feature for the documentation
file can be properly retrieved and does not get sorted into its
own, exclusive category.

Change-Id: I228c46377190c3d1bd0eb5459df8d63975a6895b
Resolves: #85422
Reselases: master, 8.7
Reviewed-on: https://review.typo3.org/57410
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
6 months ago[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer 41/57341/9
Daniel Goerz [Sat, 23 Jun 2018 12:45:01 +0000 (14:45 +0200)]
[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer

This patch moves the logic from the render method of the
YouTube and Vimeo Renderer to dedicated methods to keep
the render methods themselves as short, clean and simple as
possible.

Also $options is initialized as an empty array as stated
in the interface.

Functionality, Output and Behavior stay unchanged.

Resolves: #85362
Releases: master, 8.7
Change-Id: I00bfc9d7e3bbf97d8a68fbf825a6cf3dd8b2d3aa
Reviewed-on: https://review.typo3.org/57341
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
6 months ago[BUGFIX] Ensure extension icon exists before calling ImageInfo 93/57393/2
Nicole Cordes [Wed, 27 Jun 2018 10:07:39 +0000 (12:07 +0200)]
[BUGFIX] Ensure extension icon exists before calling ImageInfo

As the extension icon is not required, this patch prevents warnings
that are triggered because no image size can be fetched.

Resolves: #85363
Releases: master, 8.7
Change-Id: I4c98fbaed385b2f269e940b8531c45e948ab8d36
Reviewed-on: https://review.typo3.org/57393
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
6 months ago[TASK] Migrate "GFX/processor_effects" to boolean 91/57391/5
Mathias Brodala [Wed, 27 Jun 2018 07:27:30 +0000 (09:27 +0200)]
[TASK] Migrate "GFX/processor_effects" to boolean

Ensure "GFX/processor_effects" is a true boolean as suggested in
the settings module and silently migrate integer/string values
accordingly.

Resolves: #83591
Releases: master
Change-Id: I006e907e75e273009333363a4d42661183ba8721
Reviewed-on: https://review.typo3.org/57391
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[BUGFIX] Separate icon and text in inline record control buttons 04/57404/2
Mathias Brodala [Thu, 28 Jun 2018 09:47:17 +0000 (11:47 +0200)]
[BUGFIX] Separate icon and text in inline record control buttons

Resolves: #85415
Releases: master, 8.7
Change-Id: I5cee4230bb415dcb3d7dfcd0aae7614489cec7eb
Reviewed-on: https://review.typo3.org/57404
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Drop usages of PATH_typo3, PATH_typo3conf 42/57242/11
Christian Kuhn [Fri, 15 Jun 2018 20:06:42 +0000 (22:06 +0200)]
[TASK] Drop usages of PATH_typo3, PATH_typo3conf

After PATH_site usages have been dropped, this patch drops
the other path related constants PATH_typo3 and PATH_typo3conf.

Next steps (out of scope for this patch):
- Make typo3conf/l10n/ flexible (= var/labels)
- Move PackageStates and autoload/autoload-tests into typo3conf/ext/typo3/
- Analyze usages of "typo3conf" and "typo3/sysext" strings currently hardcoded

Change-Id: I4f0ca5dfab363fd3c14d030592318b9659721ecb
Resolves: #85286
Releases: master
Reviewed-on: https://review.typo3.org/57242
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Do not cache results of LiveSearch 98/57398/2
Andreas Fernandez [Wed, 27 Jun 2018 16:50:13 +0000 (18:50 +0200)]
[TASK] Do not cache results of LiveSearch

Resolves: #85412
Releases: master, 8.7
Change-Id: I7cac1b53f9cc7c7fa3c6c9e1752b7b2513d39c5d
Reviewed-on: https://review.typo3.org/57398
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[TASK] Add Error Codes to Page Failure Reasons 01/57201/8
Benni Mack [Tue, 12 Jun 2018 12:23:01 +0000 (14:23 +0200)]
[TASK] Add Error Codes to Page Failure Reasons

A new class with constants is added to make the TYPO3 internal errors
why a page cannot be displayed in the frontend more speakable.

Resolves: #17794
Releases: master
Change-Id: I8b9999e95f109666a524ee9157f89f498b21ca6d
Reviewed-on: https://review.typo3.org/57201
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[FEATURE] Add Contexts for storing data access modes 04/57104/21
Benni Mack [Thu, 21 Jun 2018 20:23:58 +0000 (22:23 +0200)]
[FEATURE] Add Contexts for storing data access modes

A new "Context" concept is added which allows to keep
the state of common TYPO3 Request Data in form of
so-called Aspects.

An aspect contains properties which can be fetched,
but only the ones that are really necessary, instead of
exposing a full object (e.g. BE_USER).

The main goal is to centralize some global variables
distributed in various places.

In the first step the following variables are considered:

- $TSFE->showHiddenPages
- $TSFE->showHiddenRecords
- $TSFE->beUserLogin
- $TSFE->gr_list
- $TSFE->loginUser
- $GLOBALS[SIM_EXEC_TIME]
- $GLOBALS['BE_USER']->workspace

For now the Context is a singleton object, but should
be fetched from a DI container.

Sometimes a custom context is necessary, so it is
cloned (see usage in TSFE).

The difference to the PSR-7 request attributes is that the
context is ONLY related to data access (like permissions / visibility)
and also independent if TYPO3 is running via HTTP or CLI
(thus, can be used in CLI mode as well).

Next Steps:
- Migrate PageRepository->versioningWorkspaceId
- Migrate TSFE->simUserGroup
- Use DateTimeAspect everywhere
- Introduce Language + Page Aspects
- Introduce the context object into ContentObjectRenderer and cObjects
- Use Contexts in RestrictionContainers
- Use Contexts in TYPO3 Backend
- Decouple sys_page behaviour from TSFE where applicable
- Ensure TypoScript conditions continue to work / have a documented alternative

Resolves: #85389
Releases: master
Change-Id: I9e27e581a1632fcd8c3c6a9e0954b76b91f42c52
Reviewed-on: https://review.typo3.org/57104
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Bürk <stefan.buerk@pure-metal.de>
Tested-by: Stefan Bürk <stefan.buerk@pure-metal.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[!!!][TASK] Drop "documentation" extension 85/57385/7
Christian Kuhn [Tue, 26 Jun 2018 20:35:46 +0000 (22:35 +0200)]
[!!!][TASK] Drop "documentation" extension

The docs team is working on a new docs.typo3.org rendering
chain that can come with some new long awaited features.
One blocker is the core internal documentation extension
that needs various hard to maintain resources from
docs.typo3.org.

The suggested solution was to drop the backend inline
manual fetching and display and thus obsolete the
extension.

For v8 and below, the 'latest' state of the various
json, xml and zip files the extension relies on, will
be frozen by the docs team to not break the module.

The documentation extension has various flaws, it for
instance tends to download outdated manual versions, the
acceptance within the community is not very high
and people are used to look up latest docs online.

The patch drops ext:documentation from the core to
free up the docs team from maintaining the clumsy
requirements at some point in time entirely.

Resolves: #85398
Releases: master
Change-Id: I4152381c49d3223b2586a742388cdf940aafe983
Reviewed-on: https://review.typo3.org/57385
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[!!!][FEATURE] Add property to disable form elements/finishers 49/57049/14
Ralf Zimmermann [Fri, 25 May 2018 09:30:33 +0000 (11:30 +0200)]
[!!!][FEATURE] Add property to disable form elements/finishers

Add a new rendering option called 'enabled' to control
the visibility for form elements and finishers.

Releases: master
Resolves: #85080
Change-Id: I593df2cfa4ca15ed3ac39b8774e5cd8bde8d24de
Reviewed-on: https://review.typo3.org/57049
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
6 months ago[BUGFIX] Re-Init CKEditor after re-sorting of inline records 82/57382/4
Frank Naegler [Tue, 26 Jun 2018 20:01:22 +0000 (22:01 +0200)]
[BUGFIX] Re-Init CKEditor after re-sorting of inline records

This patch triggers an event and uses this event to re-init the
CKEditor after re-sorting inline records.

Resolves: #79468
Releases: master, 8.7
Change-Id: Ib7d0ad6c1b0cb6b292b3dfa8488a6528ff74ceee
Reviewed-on: https://review.typo3.org/57382
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Only import extensions from 2015+ into EM 06/57306/5
Benni Mack [Fri, 22 Jun 2018 19:06:47 +0000 (21:06 +0200)]
[TASK] Only import extensions from 2015+ into EM

As proposed here https://decisions.typo3.org/t/reduce-size-of-extension-manager-db-table/329/
the EM only imports entries into the database from
TER that are uploaded from 2015-11-10 on, reducing
the database table size by 2/3.

As long as extensions.xml from TER does not
restrict this (e.g. by version) this reduces
import time when updating the extension list
and search handling within the Extension Manager.

Resolves: #85393
Releases: master
Change-Id: I1d45cde0fc895d0edb978729dc4b42df70e97d5c
Reviewed-on: https://review.typo3.org/57306
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Add LoginType enumeration 90/57390/2
Benni Mack [Wed, 27 Jun 2018 06:17:39 +0000 (08:17 +0200)]
[TASK] Add LoginType enumeration

A new enumeration class "LoginType" is added to simplify readability and validation
of correct strings within the TYPO3 Authentication process.

Resolves: #85402
Releases: master
Change-Id: Ib53ed304de5662f5bd8628509a229b2832ff18fa
Reviewed-on: https://review.typo3.org/57390
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Repair relative path resolvement in ResourceCompressor 03/56803/11
Pascal Rinker [Wed, 25 Apr 2018 09:51:47 +0000 (11:51 +0200)]
[BUGFIX] Repair relative path resolvement in ResourceCompressor

This patch repairs the relative path resolvment when using EXT:
for JavaScript/CSS paths.

Resolves: #84261
Releases: master, 8.7
Change-Id: Ieeb35041bf049728c41465edb617529550629258
Reviewed-on: https://review.typo3.org/56803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[TASK] Remove console.log call in ContextHelp.js 83/57383/2
Frank Naegler [Tue, 26 Jun 2018 20:19:50 +0000 (22:19 +0200)]
[TASK] Remove console.log call in ContextHelp.js

Resolves: #85397
Releases: master
Change-Id: If0551d96a751474b7281c71c84262da2fa0e7816
Reviewed-on: https://review.typo3.org/57383
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Move csh handling to backend extension 81/57381/2
Christian Kuhn [Tue, 26 Jun 2018 19:10:15 +0000 (21:10 +0200)]
[TASK] Move csh handling to backend extension

The core and documentation team decided to drop the inline
manual view from core for various reasons that will be further
outlined with a second patch.

The documentation extension currently does both the manual
display, and also the "csh" rendering. The latter has been
merged from ext:cshmanual into ext:documentation quite
recently with core version v9.0.

The patch extracts this csh handling from ext:documentation
again and puts it into ext:backend. The patch is similar to
the v9.0 patch, only slight additions are applied along the way.
This changes also unmarks the documentation extension from
"partOfMinimalUsableSystem" since the direct dependency of
ext:backend to ext:documentation is gone with the csh merge
into backend extension.

Resolves: #85396
Related: #81574
Releases: master
Change-Id: Ib5d8f50d097696bf88f0d1e26be9cac40f1e2578
Reviewed-on: https://review.typo3.org/57381
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Make TSConfig preview configuration work again 80/57380/2
Tymoteusz Motylewski [Tue, 26 Jun 2018 18:52:41 +0000 (20:52 +0200)]
[BUGFIX] Make TSConfig preview configuration work again

Fixes regression introduced in https://review.typo3.org/#/c/56693/
the Page TSConfig is now properly fetched.

Resolves: #85395
Releases: master
Change-Id: I6b1d521139f84d3d55db1cb40167140134f0eba6
Reviewed-on: https://review.typo3.org/57380
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Deprecate TYPO3\CMS\Core\Database\PdoHelper 79/57379/2
Christian Kuhn [Tue, 26 Jun 2018 17:55:18 +0000 (19:55 +0200)]
[TASK] Deprecate TYPO3\CMS\Core\Database\PdoHelper

The PdoHelper class with its single method importSql() has
been added for the Pdo cache backend which is also still
the only usage of that helper class.
With the migration to doctrine, that class feels misplaced
and obsolete. The code is moved over as protected method
into Pdo cache backend directly and the PdoHelper class
is marked as deprecated.

Resolves: #85394
Releases: master
Change-Id: I4a22bd193caefced3cc601b2c1cf79f12961981d
Reviewed-on: https://review.typo3.org/57379
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Fix override handling for element specific field values 48/57348/3
Frank Naegler [Sat, 23 Jun 2018 18:09:58 +0000 (20:09 +0200)]
[BUGFIX] Fix override handling for element specific field values

This patch fixes a broken JavaScript code which removes the field and
placeholder divs in FormeEngine.js field override handling.

Resolves: #84689
Related: #79440
Related: #70032
Releases: master, 8.7
Change-Id: I91d40b6ff7baa9fa9ea121458a7a9faaa00ec6f9
Reviewed-on: https://review.typo3.org/57348
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
6 months ago[BUGFIX] RTE: Disable autolink functionality in source-mode 71/57371/2
Josef Glatz [Mon, 25 Jun 2018 20:21:10 +0000 (22:21 +0200)]
[BUGFIX] RTE: Disable autolink functionality in source-mode

Limit the functionality only to the wysiwyg-mode. This also
prevents javascript errors in source-mode.

Resolves: #85332
Releases: master, 8.7
Change-Id: I0adc30400fb27745713f0a86b7916a8865609428
Reviewed-on: https://review.typo3.org/57371
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[TASK] CKEditor RTE: Add button to insert soft hyphen 44/57344/8
Josef Glatz [Sat, 23 Jun 2018 12:21:57 +0000 (14:21 +0200)]
[TASK] CKEditor RTE: Add button to insert soft hyphen

This patch re-adds a missing functionality to CKEditor.

Due to the move from htmlArea to CKEditor, the well-known and actually
important button/shortcut "soft hyphen" for text in responsive webdesign
was gone.

The button is added per default to the existing CKEditor presets "default"
and "full". Existing translations from htmlArea have been migrated and
more were added.

Pasting a soft hyphen is possible via the UI button and a keyboard
shortcut: 'CTRL' + '-'. The shortcut can be deactivated in custom
RTE presets.

Resolves: #85361
Releases: master, 8.7
Change-Id: Iec97f4c9d1ede269e2df5cb4fe795df0ef5ca558
Reviewed-on: https://review.typo3.org/57344
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Sebastian Klein <laitnin@gmx.net>
Tested-by: Sebastian Klein <laitnin@gmx.net>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[TASK] Use trait for public method access deprecation 00/57300/9
Mathias Brodala [Fri, 22 Jun 2018 16:13:56 +0000 (18:13 +0200)]
[TASK] Use trait for public method access deprecation

Resolves: #85344
Releases: master
Change-Id: I47e42e974ea14f91b192c6521196c972c404b442
Reviewed-on: https://review.typo3.org/57300
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[BUGFIX] CKEditor: show selectAll button in preset "full" 68/57368/2
Josef Glatz [Mon, 25 Jun 2018 15:45:07 +0000 (17:45 +0200)]
[BUGFIX] CKEditor: show selectAll button in preset "full"

Resolves: #85383
Releases: master, 8.7
Change-Id: I108167eef9ba1028991d332d952c68cecd0fa649
Reviewed-on: https://review.typo3.org/57368
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
6 months ago[BUGFIX] Remove usage of non core tables in linkvalidator configuration 50/57350/2
Georg Ringer [Sat, 23 Jun 2018 18:34:29 +0000 (20:34 +0200)]
[BUGFIX] Remove usage of non core tables in linkvalidator configuration

To avoid possible errors the non core table tt_news is removed from
the linkvalidator configuration.

Resolves: #85328
Releases: master, 8.7
Change-Id: I47df2adf743197354dfd685a1b259a2c1a5053c7
Reviewed-on: https://review.typo3.org/57350
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Update momentjs components 79/57179/3
Frank Naegler [Mon, 11 Jun 2018 12:23:52 +0000 (14:23 +0200)]
[TASK] Update momentjs components

yarn upgrade moment@2.22.2
yarn upgrade moment-timezone@0.5.20

Resolves: #85223
Releases: master
Change-Id: If353c4ac8d5c41ff51112745faa6e3c2b2356221
Reviewed-on: https://review.typo3.org/57179
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Use unique keys for includeJSLibs and addJsFooterLibrary 49/57349/3
Georg Ringer [Sat, 23 Jun 2018 18:23:52 +0000 (20:23 +0200)]
[BUGFIX] Use unique keys for includeJSLibs and addJsFooterLibrary

As both TS configurations use its key the latter must use a prefix
to avoid an instant override of rendered JS file.

Resolves: #85353
Releases: master, 8.7
Change-Id: Icb685eb0ed278aafead274c1fcf86436c9e6865d
Reviewed-on: https://review.typo3.org/57349
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
6 months ago[BUGFIX] Do not link l18n_cfg restricted pages 76/57276/2
Nicole Cordes [Wed, 20 Jun 2018 20:48:16 +0000 (22:48 +0200)]
[BUGFIX] Do not link l18n_cfg restricted pages

Prevent linking a page that is either restricted for the default
language or where any fallback is forbidden.

Resolves: #85063
Releases: master, 8.7
Change-Id: I9dd1f7b5b357c60114f72898ddffa9ecf7305bf2
Reviewed-on: https://review.typo3.org/57276
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
6 months ago[BUGFIX] Better handling of requests in ExternalLinktype 11/57011/12
Sybille Peters [Fri, 18 May 2018 18:03:07 +0000 (20:03 +0200)]
[BUGFIX] Better handling of requests in ExternalLinktype

- Always check for existing response
- If HEAD request fails, a GET request should always be triggered
- Restructured, moved some local variables to class variables
- In case of redirect loop, output exception message instead of
  location and status code

Resolves: #83611
Resolves: #85067
Releases: master, 8.7
Change-Id: I1cf6ef4e3dbaa5fbc683affc7cf96a0dbeea75cd
Reviewed-on: https://review.typo3.org/57011
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[TASK] Unsplit the save button of the sites configuration module 46/57346/3
Patrick Schriner [Sat, 23 Jun 2018 16:20:29 +0000 (18:20 +0200)]
[TASK] Unsplit the save button of the sites configuration module

Resolves: #85365
Releases: master
Change-Id: Ie7a5bd60218b2dc9293a5a53995e5a63685c6288
Reviewed-on: https://review.typo3.org/57346
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
6 months ago[TASK] Avoid thousands of removeDotsFromTs in TemplatePaths 94/57294/2
Claus Due [Fri, 22 Jun 2018 13:16:59 +0000 (15:16 +0200)]
[TASK] Avoid thousands of removeDotsFromTs in TemplatePaths

This patch avoids calling GeneralUtility::removeDotsFromTs
on the entire TS array, instead selectively calling it only on
the sub-array and only if a sub-array was actually resolved.

In my extremely small testing setup this patch avoids 1,100
calls in FE and 6,000 calls in BE (in page module with fluid
previews being rendered).

Change-Id: I7195aa310711d82de4861df8dcb2a9fbda309520
Releases: master, 8.7
Resolves: #85341
Reviewed-on: https://review.typo3.org/57294
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
6 months ago[BUGFIX] Calculate count of records instead of using a query 47/57347/2
Georg Ringer [Sat, 23 Jun 2018 17:32:08 +0000 (19:32 +0200)]
[BUGFIX] Calculate count of records instead of using a query

Calculate the count of records within the code instead of using a
query which is conceptionally wrong using limit and offset.

Resolves: #85359
Releases: master
Change-Id: I5b4356fb860b73d64585f28a3bd4384a7884715a
Reviewed-on: https://review.typo3.org/57347
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: David Bruchmann <davidbruchmann@gmail.com>
Tested-by: David Bruchmann <davidbruchmann@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
6 months ago[FEATURE] Add support to CurrencyViewHelper for mdash 31/57331/6
Timo Poppinga [Fri, 22 Jun 2018 23:45:00 +0000 (01:45 +0200)]
[FEATURE] Add support to CurrencyViewHelper for mdash

If the option `useDash` is set and a round value is given,
the decimal place is rendered as a dash.
Do tests refactor, using value data provider for all tests.

Change-Id: Idd1a0216c7ff58394cf676bf14fb2042c823e4d6
Resolves: #85356
Releases: master
Reviewed-on: https://review.typo3.org/57331
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Marcus Schwemer <ms@schwemer.de>
Tested-by: Marcus Schwemer <ms@schwemer.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
6 months ago[BUGFIX] Fetch Vimeo preview in higher quality 97/57297/3
Frans Saris [Fri, 22 Jun 2018 14:12:48 +0000 (16:12 +0200)]
[BUGFIX] Fetch Vimeo preview in higher quality

Resolves: #85176
Releases: master, 8.7
Change-Id: Ic90137b3e58cc7c178eb899448a2efa828f9fb25
Reviewed-on: https://review.typo3.org/57297
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Maik Peuser <maik.peuser@verdure.de>
Tested-by: Maik Peuser <maik.peuser@verdure.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
6 months ago[CLEANUP] Introduce early returns in class LinkAnalyzer 27/57127/2
Andreas Wolf [Tue, 5 Jun 2018 18:47:51 +0000 (20:47 +0200)]
[CLEANUP] Introduce early returns in class LinkAnalyzer

Some methods in the class were deeply nested and thus hard to
understand; the early returns make the flow more linearly and more
easily comprehensible.

Change-Id: Ibce7cea04933ffa28ad28b13b6f38e13741b99bb
Resolves: #85161
Releases: master
Reviewed-on: https://review.typo3.org/57127
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
6 months ago[TASK] Remove IP address from details field of sys_log entry 13/57313/9
Georg Ringer [Fri, 22 Jun 2018 20:40:35 +0000 (22:40 +0200)]
[TASK] Remove IP address from details field of sys_log entry

Avoid persisting the IP address of a login action twice and just use
the one of the IP field.

Additionally the anoymize scheduler task can now remove all unwanted IP
addresses from the logs.

Be aware that the anonymization of the sys_log entries only
works for new entries that were generated after this patch. Older
entries have to be deleted or the details field needs to be
cleared manually.

Resolves: #85316
Releases: master, 8.7, 7.6
Change-Id: I9c5c65d52462a82047324390bc3e6b970a8f8840
Reviewed-on: https://review.typo3.org/57313
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
6 months ago[BUGFIX] Remove reset of GFX/processor_effects to -1 19/57319/4
Marc Willmann [Fri, 22 Jun 2018 21:32:00 +0000 (23:32 +0200)]
[BUGFIX] Remove reset of GFX/processor_effects to -1

When entering the Install Tool and the GFX/processor is set to
GraphicsMagick the value for GFX/processor_effects is reset to -1,
overwriting any value that might have been set before.
Also adjust tests for the new expectations.

Resolves: #83591
Releases: master, 8.7
Change-Id: I7baa247a404166332a9a727983bb5eb83dfe37af
Reviewed-on: https://review.typo3.org/57319
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[BUGFIX] Fix collection of allowed pages in suggest receiver 94/57194/4
Alexander Stehlik [Mon, 11 Jun 2018 20:03:50 +0000 (22:03 +0200)]
[BUGFIX] Fix collection of allowed pages in suggest receiver

When using the pidList and pidDepth TSconfig settings of the
suggest wizard the recursive collection of the allowed
pages does not abort too early any more due to an invalid condition.

Resolves: #85229
Relates: #77049
Releases: master, 8.7
Change-Id: I2c94f5cc64f57be1319f9e76ed05310fbea0db16
Reviewed-on: https://review.typo3.org/57194
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[TASK] Show speaking exception message if form definition is invalid 30/57330/2
Ralf Zimmermann [Fri, 22 Jun 2018 23:46:48 +0000 (01:46 +0200)]
[TASK] Show speaking exception message if form definition is invalid

Show a speaking exception message within the frontend if the
form definition is invalid.

Releases: master, 8.7
Resolves: #85357
Change-Id: Ifcb0684c9b5136c5dee5ac6b54732fcde02d82cf
Reviewed-on: https://review.typo3.org/57330
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[BUGFIX] Support fragment/section for record links 48/54348/6
Mathias Brodala [Tue, 10 Oct 2017 10:58:20 +0000 (12:58 +0200)]
[BUGFIX] Support fragment/section for record links

This allows for setting fragments e.g. by adding a custom recordlist
RecordLinkHandler.

Resolves: #82717
Releases: master, 8.7
Change-Id: I1535a3bb5e446e2f154cd6214e5665887ae6fd0d
Reviewed-on: https://review.typo3.org/54348
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[FEATURE] Use HTML5 field types and attributes in FormEngine 28/57328/5
Andreas Fernandez [Fri, 22 Jun 2018 23:00:31 +0000 (01:00 +0200)]
[FEATURE] Use HTML5 field types and attributes in FormEngine

The FormEngine renders now HTML5 specific field types and attributes
based on its `eval` config.

Resolves: #85355
Releases: master
Change-Id: I66fa54e5b475e519b75b04f33a3c1c55cef2646e
Reviewed-on: https://review.typo3.org/57328
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Patrick Schriner <patrick.schriner@diemedialen.de>
Tested-by: Patrick Schriner <patrick.schriner@diemedialen.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[BUGFIX] Unknown OS icon instead of windows as fallback 06/56806/6
Jan Stockfisch [Wed, 25 Apr 2018 14:38:48 +0000 (16:38 +0200)]
[BUGFIX] Unknown OS icon instead of windows as fallback

Resolves: #84870
Releases: master
Change-Id: Ia89f4ba0aa70616e185cad6cc29858157ef0e656
Reviewed-on: https://review.typo3.org/56806
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
6 months ago[FEATURE] Add interval presets for cron command field of scheduler task 93/57293/5
Georg Ringer [Fri, 22 Jun 2018 12:44:10 +0000 (14:44 +0200)]
[FEATURE] Add interval presets for cron command field  of scheduler task

Improve the usability by having presets for the cron command field
of a scheduler task.

Resolves: #44297
Releases: master
Change-Id: Iedf4da6c36bc3a77ac2886401efedbfd491c5005
Reviewed-on: https://review.typo3.org/57293
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jonas Götze <jonnsn@gmail.com>
Tested-by: Jonas Götze <jonnsn@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[BUGFIX] Language selector not shown in default page without translation 74/56774/3
Patrick Broens [Sat, 21 Apr 2018 08:55:13 +0000 (10:55 +0200)]
[BUGFIX] Language selector not shown in default page without translation

When editing a page, the language selector in the upper left corner is
not visible when the page is in the default language and does not have a
translation yet. When the page has at least one translation, the language
selector is visible, which is inconsistent behaviour.

This patch adds a check for the table. When the languages for the page
table are fetched, all languages are fetched.

Resolves: #84834
Releases: master
Change-Id: Ib482fecef6cbddcbf945e0e4d944e181c27a115c
Reviewed-on: https://review.typo3.org/56774
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Hellmund <developement@hellmund.eu>
Reviewed-by: Florian Mast <flo.mast@web.de>
Tested-by: Florian Mast <flo.mast@web.de>
Reviewed-by: Ruslan Steiger <steiger.ruslan@gmail.com>
Tested-by: Ruslan Steiger <steiger.ruslan@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
6 months ago[TASK] Recommend lockSSL option in reports module 98/57298/5
Josef Glatz [Fri, 22 Jun 2018 13:53:33 +0000 (15:53 +0200)]
[TASK] Recommend lockSSL option in reports module

Introduce a new status for $GLOBALS['TYPO3_CONF_VARS']['BE']['lockSSL'].

The new check is only shown if the backend is accessed through
HTTPS.

The information about the usage of ext:rsaauth is removed within
the ext:saltedpasswords status message, because it is marked as
deprecated.

Resolves: #85343
Releases: master
Change-Id: I3e78a94adec7d113c7fe43d18690ef822a99768d
Reviewed-on: https://review.typo3.org/57298
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[TASK] Improve styling of "caches flushed" notification 26/57326/3
Andreas Wolf [Fri, 22 Jun 2018 22:34:47 +0000 (00:34 +0200)]
[TASK] Improve styling of "caches flushed" notification

Change-Id: I1a2459097dfe513b4e40793a74506b56ea858649
Resolves: #85354
Releases: master
Reviewed-on: https://review.typo3.org/57326
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Marc Willmann <mw@f7.de>
Tested-by: Marc Willmann <mw@f7.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[BUGFIX] Remove Byte Order Mark from TypoScript includes 15/57315/5
Andreas Fernandez [Fri, 22 Jun 2018 20:52:13 +0000 (22:52 +0200)]
[BUGFIX] Remove Byte Order Mark from TypoScript includes

If TypoScript files have a Byte Order Mark (BOM) set, the TypoScript
parser may fail as the invisible characters disturb the parsing process.

The BOM gets removed from the TypoScript strings with this patch.

Resolves: #56483
Releases: master, 8.7
Change-Id: I59318f9d2d92efb224d62906fb404fcb41459f8f
Reviewed-on: https://review.typo3.org/57315
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[TASK] Improve number fields in the setup module 18/57318/2
Georg Ringer [Fri, 22 Jun 2018 21:25:40 +0000 (23:25 +0200)]
[TASK] Improve number fields in the setup module

Improve fields holding numbers in the setup module by using the type "number"
and reducing the size.

Resolves: #68301
Releases: master
Change-Id: Ibc55e5d30e9714c7c775e2a82480d7b84cf4420a
Reviewed-on: https://review.typo3.org/57318
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Add allow="autoplay; fullscreen" to YouTube/Vimeo iframes 99/57299/5
Frans Saris [Fri, 22 Jun 2018 18:44:29 +0000 (20:44 +0200)]
[BUGFIX] Add allow="autoplay; fullscreen" to YouTube/Vimeo iframes

With the new chrome auto play policies we need to add a additional allow
attribute to the iframe to support autoplay.

https://developers.google.com/web/updates/2017/09/autoplay-policy-changes

Resolves: #85233
Releases: master, 8.7
Change-Id: I19116a011b410933cf020b5b9606dc32d61e698d
Reviewed-on: https://review.typo3.org/57299
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Robert Vierke <robert.vierke+typo3@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
6 months ago[TASK] Ask confirmation to install "adminpanel" extension 10/57310/4
Mathias Brodala [Fri, 22 Jun 2018 19:50:57 +0000 (21:50 +0200)]
[TASK] Ask confirmation to install "adminpanel" extension

Resolves: #84789
Releases: master
Change-Id: I5b59519eb3497c7c459efe1f238c91f4fe7e9e19
Reviewed-on: https://review.typo3.org/57310
Reviewed-by: Aljoscha Weber <aweber@w-commerce.de>
Tested-by: Aljoscha Weber <aweber@w-commerce.de>
Reviewed-by: Jonas Götze <jonnsn@gmail.com>
Tested-by: Jonas Götze <jonnsn@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[TASK] Fix typo in Install Tool description 16/57316/2
Sebastian Klein [Fri, 22 Jun 2018 20:31:50 +0000 (22:31 +0200)]
[TASK] Fix typo in Install Tool description

Removes the superfluous word 'the' in the Install Tool.
It is found in the description of [SYS][systemLog].

Resolves: #85352
Releases: master
Change-Id: Ibe42f73447bc02b13bbd3f013ea8638aef0177db
Reviewed-on: https://review.typo3.org/57316
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[TASK] Open modals in install tool with better sizes 11/57311/3
Frank Naegler [Fri, 22 Jun 2018 20:13:44 +0000 (22:13 +0200)]
[TASK] Open modals in install tool with better sizes

Resolves: #85348
Releases: master
Change-Id: Id9edf5f83719d5923fd410dc8dcf719280cc0095
Reviewed-on: https://review.typo3.org/57311
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
6 months ago[BUGFIX] Display the action-icons "Insert inside" and "Insert after" in white 12/57312/3
Aljoscha Weber [Fri, 22 Jun 2018 20:25:59 +0000 (22:25 +0200)]
[BUGFIX] Display the action-icons "Insert inside" and "Insert after" in white

Added a new css-rule to display the icon in the dropown in the colored
Toolbar.

Resolves: #85135
Releases: master
Change-Id: I794ae36e65d94e39b69e031e3b632e8cfc881608
Reviewed-on: https://review.typo3.org/57312
Reviewed-by: Jonas Götze <jonnsn@gmail.com>
Tested-by: Jonas Götze <jonnsn@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[TASK] Remove NULL initialization and redundant assignments 43/57243/2
Wouter Wolters [Sun, 17 Jun 2018 14:15:31 +0000 (16:15 +0200)]
[TASK] Remove NULL initialization and redundant assignments

Class properties explicitly initialized with NULL and
redundant assignments in constructors are removed.

Resolves: #85287
Releases: master
Change-Id: I44c565a0b54e7e98ffa6d2d1de5335a6212a5742
Reviewed-on: https://review.typo3.org/57243
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[BUGFIX] Allow setting "ready to publish" workspace state again 01/57301/4
Oliver Hader [Fri, 22 Jun 2018 17:16:40 +0000 (19:16 +0200)]
[BUGFIX] Allow setting "ready to publish" workspace state again

The "ready to publish" workspace state has the internal negative
identifier -10 which is not supported anymore since system fields
are auto-generated and t3ver_stage defined to be of type unsigned
(positive) integer.

Resolves: #85345
Releases: master
Change-Id: I2cb1f3f5bc65ec30fb510c5f2d2f9fbb9e0d55e9
Reviewed-on: https://review.typo3.org/57301
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Aljoscha Weber <aweber@w-commerce.de>
Tested-by: Aljoscha Weber <aweber@w-commerce.de>
Reviewed-by: Jonas Götze <jonnsn@gmail.com>
Tested-by: Jonas Götze <jonnsn@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
6 months ago[TASK] Add details for named keys in translation arguments 02/57302/4
Mathias Brodala [Fri, 22 Jun 2018 18:16:48 +0000 (20:16 +0200)]
[TASK] Add details for named keys in translation arguments

Releases: master
Resolves: #85347
Change-Id: I4214d2cbbf46a1fef78e0ee27793ff7f8f8e0cc2
Reviewed-on: https://review.typo3.org/57302
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
6 months ago[BUGFIX] Fix exception for folder move/copy between storages 58/57258/5
Mathias Brodala [Mon, 18 Jun 2018 13:35:22 +0000 (15:35 +0200)]
[BUGFIX] Fix exception for folder move/copy between storages

This ensures that the user is shown the correct error message.

Resolves: #85302
Releases: master, 8.7
Change-Id: Ide2c1231fa1ec5bcbd710c1b3810253ce2bfe3c4
Reviewed-on: https://review.typo3.org/57258
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Tested-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
6 months ago[TASK] Add .ddev to ignore 80/57280/3
Harry [Thu, 21 Jun 2018 09:08:44 +0000 (11:08 +0200)]
[TASK] Add .ddev to ignore

Resolves: #85324
Releases: master, 8.7, 7.6
Change-Id: I90461715f59cd74c72571151f3e37cb4ee374b7f
Reviewed-on: https://review.typo3.org/57280
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Replace nested dirname calls with using the levels parameter 48/57248/2
Wouter Wolters [Sun, 17 Jun 2018 14:57:09 +0000 (16:57 +0200)]
[TASK] Replace nested dirname calls with using the levels parameter

Resolves: #85292
Releases: master
Change-Id: I3abfce7fb91b007769c63aaff4da6c1b672ef947
Reviewed-on: https://review.typo3.org/57248
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Make functional tests run with sql_mode STRICT_TRANS_TABLES 86/57286/2
Tymoteusz Motylewski [Thu, 21 Jun 2018 11:08:41 +0000 (13:08 +0200)]
[BUGFIX] Make functional tests run with sql_mode STRICT_TRANS_TABLES

The text columns do not support default value.
Let's change the definition of the columns in irre_tutorial to varchar.

Resolves: #85329
Releases: master
Change-Id: Ida0d98b114a78289a5f695d7097c6d067c1e5556
Reviewed-on: https://review.typo3.org/57286
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
7 months ago[TASK] Allow preload Tag in VideoTagRenderer 74/57274/2
Guido Schmechel [Wed, 20 Jun 2018 16:27:28 +0000 (18:27 +0200)]
[TASK] Allow preload Tag in VideoTagRenderer

Add the preload parameter to the VideoTagRenderer.

Resolves: #84523
Releases: master, 8.7
Change-Id: I961eee2c204d74321854a3a6f093225e2f873aba
Reviewed-on: https://review.typo3.org/57274
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Add modestbranding to YouTubeRenderer 73/57273/2
Guido Schmechel [Wed, 20 Jun 2018 15:59:33 +0000 (17:59 +0200)]
[TASK] Add modestbranding to YouTubeRenderer

Add the modestbranding parameter to the YoutubeRender.

Resolves: #85114
Releases: master, 8.7
Change-Id: Id76c0dd9ec764c820c2319c5dd57069e18c2cc71
Reviewed-on: https://review.typo3.org/57273
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[TASK] Unsplit the splitbutton 93/56693/36
Patrick Broens [Mon, 16 Apr 2018 18:27:45 +0000 (20:27 +0200)]
[TASK] Unsplit the splitbutton

This patch splits the splitbutton into several separate buttons, which
all serve a single action. Modals are used for guiding the user
to prevent possible data loss based on their actions.

Concept: Rachel Foucard
Proofread: Tom Warwick
Resolves: #84753
Releases: master
Change-Id: I58bfe7621b1bc03ef9222bca740dbbe050c07fc9
Reviewed-on: https://review.typo3.org/56693
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[BUGFIX] Correct HTML markup in database analyzer 96/57296/3
Benjamin Kott [Fri, 22 Jun 2018 14:01:19 +0000 (16:01 +0200)]
[BUGFIX] Correct HTML markup in database analyzer

HTML lists must only contain list items.

Resolves: #85342
Releases: master
Change-Id: I7eed0814e14a28d0cb49863b0cb9f73041728e73
Reviewed-on: https://review.typo3.org/57296
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
7 months ago[TASK] Revert "[BUGFIX] Honor l18n_cfg settings in PageRepository" 77/57277/3
Nicole Cordes [Thu, 21 Jun 2018 08:43:31 +0000 (10:43 +0200)]
[TASK] Revert "[BUGFIX] Honor l18n_cfg settings in PageRepository"

This reverts commit 7e8a72cfde06597eca5c4d30ecbdb6b3ab7a541d.

Handling l18n_cfg in PageRespository is the wrong place and breaks
current core behaviour. The problem needs to be resolved somewhere else.

Reverts: #85063
Resolves: #85339
Releases: master
Change-Id: Ic61c64be8769ba85208efa7635dcb1f1cbaa2f08
Reviewed-on: https://review.typo3.org/57277
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
7 months ago[TASK] Document description column added to pages table 89/57289/2
Mathias Brodala [Thu, 21 Jun 2018 14:21:41 +0000 (16:21 +0200)]
[TASK] Document description column added to pages table

Resolves: #85313
Releases: master
Change-Id: I7bf70b4abf1240dfc803f0908b810659d73b4bf6
Reviewed-on: https://review.typo3.org/57289
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
7 months ago[TASK] Add notes field for table pages 70/57270/3
Georg Ringer [Wed, 20 Jun 2018 07:51:04 +0000 (09:51 +0200)]
[TASK] Add notes field for table pages

The table pages should have the notes field as well.

Resolves: #85313
Releases: master
Change-Id: I47e52334fca49097665b54bd49c77021e586ce90
Reviewed-on: https://review.typo3.org/57270
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
7 months ago[TASK] Unify simulate user settings for Backend admins 59/57159/7
Christian Kuhn [Sat, 9 Jun 2018 14:12:33 +0000 (16:12 +0200)]
[TASK] Unify simulate user settings for Backend admins

The "Simulate user" functionality of the "User settings"
module for backend admins is UX wise a distaster: This
functionality is hidden behind the settings of the currently
logged-in backend user in the toolbar, which then magically
allows to change foreign user settings.

A much better approach to administrate user settings of other
users is to fully switch to the target user using the
"Backend User" module.

Additionally, if an admin user changes specific user settings of
existing or new users over and over again (eg. backend language),
sane defaults should be configured via User TSconfig "setup."
instead.

The patch unifies this functionality by removing the additional
simulate backend user selector from user settings module.

Resolves: #85196
Releases: master
Change-Id: If0abf5a7ca3a62c669540e6ada3d61b08022fc09
Reviewed-on: https://review.typo3.org/57159
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Only query default language PIDs in suggest wizard 65/57265/2
Benni Mack [Mon, 18 Jun 2018 17:25:01 +0000 (19:25 +0200)]
[BUGFIX] Only query default language PIDs in suggest wizard

Due to the removal of "pages_language_overlay", the page IDs for
FormEngine's suggest wizard contains page IDs of all languages, however
it is defined that the "pid" field is only limited to the default language.

Adding a check for `sys_language_uid=0` ensures that the pid IN
query is much smaller than before.

Resolves: #85308
Releases: master
Change-Id: I21e2c706dc3d73986e027cb9e014e3f69980d3ba
Reviewed-on: https://review.typo3.org/57265
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
7 months ago[TASK] Improve wording of upgrade wizards in Install Tool 72/57272/3
Georg Ringer [Wed, 20 Jun 2018 15:02:23 +0000 (17:02 +0200)]
[TASK] Improve wording of upgrade wizards in Install Tool

Change the misleading headling "Available wizards" and
switch color of progress bar to success if 100% reached.

Resolves: #85299
Releases: master, 8.7
Change-Id: I6e08da59313fe9efc51f3e4e061a4d3068cadc80
Reviewed-on: https://review.typo3.org/57272
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: David Bruchmann <davidbruchmann@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
7 months ago[BUGFIX] Avoid prev/next arrows if only 1 system news is shown 75/57275/2
Georg Ringer [Wed, 20 Jun 2018 17:15:30 +0000 (19:15 +0200)]
[BUGFIX] Avoid prev/next arrows if only 1 system news is shown

If only one system news is shown, it makes no sense to render arrows
to switch to other news records. Therefore those should only be
shown if there are at least 2 records.

Resolves: #85322
Releases: master, 8.7
Change-Id: I636b90121729bb2f12c2313a3cb7e8b858367970
Reviewed-on: https://review.typo3.org/57275
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
7 months ago[BUGFIX] Allow redirect from typo3/install again 62/57262/2
Benni Mack [Mon, 18 Jun 2018 16:16:37 +0000 (18:16 +0200)]
[BUGFIX] Allow redirect from typo3/install again

Due to refactorings of constants, Environment:isCli()
needs to be initialized now. This breaks the
existing redirect from typo3/install/ to
typo3/install.php, due to non-initialized Environment
API.

In this case, the environment is initialized.

Resolves: #85306
Releases: master
Change-Id: I20a86f4a304951b7b075a3eec7142c4e1c99d06c
Reviewed-on: https://review.typo3.org/57262
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[TASK] Show infobox for records which are set to readOnly 53/57253/2
Georg Ringer [Sun, 17 Jun 2018 18:44:00 +0000 (20:44 +0200)]
[TASK] Show infobox for records which are set to readOnly

Records can be set to readOnly by setting 'readOnly` in the TCA ctrl section.
Inform editors by rendering an infobox above the record.

Additionally improve the code of the record note rendering.

Resolves: #85244
Releases: master, 8.7
Change-Id: I46c84f18b22332c5691f7fb41836a0b97f8dafa2
Reviewed-on: https://review.typo3.org/57253
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
7 months ago[BUGFIX] Cast database result uid to int 47/57247/2
Susanne Moog [Sun, 17 Jun 2018 14:45:10 +0000 (16:45 +0200)]
[BUGFIX] Cast database result uid to int

As the OrphanRecordsCommand is using strict types
the results in row['uid'] has been casted to int
before usage in further methods as it is returned
as string from the database.

Resolves: #85288
Releases: master
Change-Id: Ia7a8f0f2be37b4b35a246f95049e20d717cbf767
Reviewed-on: https://review.typo3.org/57247
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
7 months ago[BUGFIX] Cast uid from database to int in TableWizard 50/57250/2
Susanne Moog [Sun, 17 Jun 2018 15:12:38 +0000 (17:12 +0200)]
[BUGFIX] Cast uid from database to int in TableWizard

Resolves: #85294
Releases: master
Change-Id: Id15a7dc0896a7031272ef5dde41606aaebaaec9c
Reviewed-on: https://review.typo3.org/57250
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Merge str_replace calls when applied to a variable sequentially 46/57246/3
Wouter Wolters [Sun, 17 Jun 2018 14:44:59 +0000 (16:44 +0200)]
[TASK] Merge str_replace calls when applied to a variable sequentially

Resolves: #85291
Releases: master
Change-Id: Ia8db330043ccd2d123be8d6257189774969a951c
Reviewed-on: https://review.typo3.org/57246
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Bürk <stefan.buerk@pure-metal.de>
Tested-by: Stefan Bürk <stefan.buerk@pure-metal.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Replace array_push with normal array assignment 45/57245/2
Wouter Wolters [Sun, 17 Jun 2018 14:39:05 +0000 (16:39 +0200)]
[TASK] Replace array_push with normal array assignment

Direct array assignment works faster than invoking php functions

Resolves: #85290
Releases: master
Change-Id: I607b11ddd96114e14a04988887f3b3139d4ae06a
Reviewed-on: https://review.typo3.org/57245
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Fix wrong strlen check in DoubleMetaPhoneUtility 52/57252/2
Wouter Wolters [Sun, 17 Jun 2018 17:23:41 +0000 (19:23 +0200)]
[BUGFIX] Fix wrong strlen check in DoubleMetaPhoneUtility

while (strlen($this->primary) < 4 || strlen($this->secondary < 4)) {

should be

while (strlen($this->primary) < 4 || strlen($this->secondary) < 4) {

Resolves: #85296
Releases: master,8.7
Change-Id: I1820218410538c095f3e3c907190726f8e970410
Reviewed-on: https://review.typo3.org/57252
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Drop child methods that are exactly the same 44/57244/3
Wouter Wolters [Sun, 17 Jun 2018 14:30:10 +0000 (16:30 +0200)]
[TASK] Drop child methods that are exactly the same

Resolves: #85289
Releases: master
Change-Id: Ia35e8e36f4d9d97924ff105c549b26d851f5df40
Reviewed-on: https://review.typo3.org/57244
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Replace last occurrences of PATH_site with Environment API 41/57241/3
Benni Mack [Fri, 15 Jun 2018 19:54:03 +0000 (21:54 +0200)]
[TASK] Replace last occurrences of PATH_site with Environment API

Resolves: #85285
Releases: master
Change-Id: I4d12f7add6f536b3a412e554c8a6c4d64fd677e4
Reviewed-on: https://review.typo3.org/57241
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>