Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Show empty icon in checkbox'ed select field 20/33220/5
Axel Kummer [Thu, 9 Oct 2014 07:11:14 +0000 (09:11 +0200)]
[BUGFIX] Show empty icon in checkbox'ed select field

When a select field has config option renderMode=checkbox, icons
are rendered between checkbox and the label. If no icon is defined,
TYPO3 ought to show an empty icon.
This is broken and a red question mark appears.
This patch fixes the problem so that the empty icon is rendered again.

Change-Id: I2c54695463d98bd7b8bfa66642bd861e7a2ca7a8
Resolves: #62116
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33220
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Weiske <christian.weiske@netresearch.de>
Tested-by: Christian Weiske <christian.weiske@netresearch.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fix typo in ChecboxElement 49/33249/2
Stefan Froemken [Fri, 10 Oct 2014 11:35:04 +0000 (13:35 +0200)]
[BUGFIX] Fix typo in ChecboxElement

When calling the deprected method getSingleField_typeCheck
a wrong class name is called.
It has to be CheckboxElement instead of ChecboxElement

Resolves: #62149
Releases: master
Change-Id: Ie3db582ea40bb5e55ac4f59ac6c89364304f5723
Reviewed-on: http://review.typo3.org/33249
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Static access to Enumeration constants 53/32353/3
Sascha Egerer [Mon, 25 Aug 2014 14:46:23 +0000 (16:46 +0200)]
[BUGFIX] Static access to Enumeration constants

To get all available constants for a TYPO3\CMS\Core\Type\Enumeration
an instance of the Enumeration is required. This is changed by
defining the `getConstants` method as static and using
`get_called_class()` instead of `get_class($this)`.

Resolves: #61090
Releases: master,6.2
Change-Id: I45e8241c6f41a23a1748e620c000b6dd59d6f389
Reviewed-on: http://review.typo3.org/32353
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Improve namings of RadioElement 65/33165/3
Wouter Wolters [Sat, 4 Oct 2014 15:20:33 +0000 (17:20 +0200)]
[TASK] Improve namings of RadioElement

Resolves: #62034
Releases: master
Change-Id: I894923e9b84109b3b3badff3e94662a41e84d6d0
Reviewed-on: http://review.typo3.org/33165
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[FEATURE] RTE: Cleanup in SpellCheckingController 41/33241/2
Stanislas Rolland [Fri, 10 Oct 2014 02:14:17 +0000 (22:14 -0400)]
[FEATURE] RTE: Cleanup in SpellCheckingController

Add comments. Clearer Aspell command construction.

Releases: master
Resolves: #62138
Change-Id: Ib553d782bc2602c53540e7a532f14cdd4e62fbb8
Reviewed-on: http://review.typo3.org/33241
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] RTE Spellcheck: PHP warning in SpellCheckingController 39/33239/2
Stanislas Rolland [Fri, 10 Oct 2014 01:55:38 +0000 (21:55 -0400)]
[BUGFIX] RTE Spellcheck: PHP warning in SpellCheckingController

PHP warning in raised in
SpellCheckingController::fixPersonalDictionaryCharacterSet.
If the file does not exist, there is no need to fix anything.

Releases: master, 6.2
Resolves: #62137
Change-Id: I9b15f5cb016ac9d309fb19ad6230a79b885b16f3
Reviewed-on: http://review.typo3.org/33239
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] Possible race condition when creating directory 81/32881/6
Bernhard Kraft [Fri, 19 Sep 2014 08:58:36 +0000 (10:58 +0200)]
[BUGFIX] Possible race condition when creating directory

During various actions in the backend which require a cache directory
in typo3temp/ a race condition can occur while creating the directory.
The race condition is caused by GeneralUtility::createDirectoryPath.

There is a check whether the directory to be created already exists.
Later the directory is created using mkdir(). If in the meantime
another process creates the directory the exception will get thrown.

Resolves: #47269
Releases: master, 6.2
Change-Id: Iff46addd9ad6d738d1760f82a436dec9840c331d
Reviewed-on: http://review.typo3.org/32881
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] RTE Spellcheck:default ISO code dictionary should be lowercase 28/33228/2
Stanislas Rolland [Thu, 9 Oct 2014 14:25:48 +0000 (10:25 -0400)]
[BUGFIX] RTE Spellcheck:default ISO code dictionary should be lowercase

When no default dictionary is configured for the ISO code of the
language of current content, the ISO code itself is taken as the name
of the Aspell dictionary. This should be lowercase.

Releases: master, 6.2
Resolves: #62128
Change-Id: I346469b0c1cd8a44227576b0d17cf231c205f961
Reviewed-on: http://review.typo3.org/33228
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] RTE Spellcheck dialogue not correctly displayed 18/33218/2
Stanislas Rolland [Thu, 9 Oct 2014 05:55:48 +0000 (01:55 -0400)]
[BUGFIX] RTE Spellcheck dialogue not correctly displayed

The RTE Spellcheck dialogue is not correctly displayed: the suggestions
and dictionaries fieldsets are never displayed in Firefox and Chrome
due to size constraints. In IE, the trigger elements of the combo boxes
are truncated on the right.

Releases: master, 6.2
Resolves: #62114
Change-Id: Iebff324164dc5975403e2217dd06def77e2eba6f
Reviewed-on: http://review.typo3.org/33218
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] RTE Spellcheck dialogue opens with excessive height 16/33216/2
Stanislas Rolland [Thu, 9 Oct 2014 03:01:49 +0000 (23:01 -0400)]
[BUGFIX] RTE Spellcheck dialogue opens with excessive height

By default, the RTE Spellcheck dialogue opens with excessive height
in Firefox.

Releases: master, 6.2
Resolves: #62113
Change-Id: Ifd92417ddc7c688bb752c4460a4992daf7173651
Reviewed-on: http://review.typo3.org/33216
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] RTE references non-existent xml files 14/33214/2
Stanislas Rolland [Wed, 8 Oct 2014 21:54:03 +0000 (17:54 -0400)]
[BUGFIX] RTE references non-existent xml files

References should be to xlf files.

Releases: master, 6.2
Resolves: #62112
Change-Id: I670e0f7f8af422d710c85c76f87b25527ceb1c38
Reviewed-on: http://review.typo3.org/33214
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[BUGFIX] Do not use invalid TSConfig in linkvalidator 02/26502/7
Alexander Stehlik [Thu, 19 Dec 2013 21:37:53 +0000 (22:37 +0100)]
[BUGFIX] Do not use invalid TSConfig in linkvalidator

To display the linkvalidator error messages for linkhandler link types,
the name of the linked table is read from the TCA instead from page
TSconfig (from a hardcoded page UID 1).

Resolves: #54523
Releases: master, 6.2
Change-Id: I165813a03cd4574c20981e35a9e53cfdeacfc421
Reviewed-on: http://review.typo3.org/26502
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fix PHP warning with CTYPE=media 91/33191/6
Goran Medakovic [Tue, 7 Oct 2014 16:38:17 +0000 (18:38 +0200)]
[BUGFIX] Fix PHP warning with CTYPE=media

Check for array type before checking the variable with isset().
If the variable is a string the isset() will cause a PHP warning.

Resolves: #59544
Releases: master, 6.2
Change-Id: I766292a3dc0365a40acff5fd5f089f7ea78e0b70
Reviewed-on: http://review.typo3.org/33191
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] RTE Language extension refers to non-existent method 10/33210/3
Stanislas Rolland [Wed, 8 Oct 2014 20:14:11 +0000 (16:14 -0400)]
[BUGFIX] RTE Language extension refers to non-existent method

RTE Language extension refers to non-existent method
tx_staticinfotables_div::getCurrentLanguage in Static Info Tables.

Releases: master, 6.2
Resolves: #62111
Change-Id: I9a37a40da367f47da9ee3a015537e79d3ff5a88a
Reviewed-on: http://review.typo3.org/33210
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
5 years ago[TASK] Deprecate unused/non-unified DocumentTemplate code 67/33167/4
Benjamin Mack [Sun, 5 Oct 2014 07:37:30 +0000 (09:37 +0200)]
[TASK] Deprecate unused/non-unified DocumentTemplate code

There are certain parts in DocumentTemplate - one of the main rendering
classes for the Backend - that are not in use anymore or can be
accessed via the pageRenderer, which DocTemplate uses under the hood.

Additionally, certain options, like rendering XHTML or HTML3 in
the backend, are not needed anymore, as the whole code is targeted
to be HTML5 compatible.

The variables

* $inDocStyles
* $inDocStyles_TBEstyle

are unified within the main inDocStylesArray.

JScodeLibArray is not in use anymore and deprecated as well.
The method menuTable is not used anymore and also deprecated.

Releases: master
Resolves: #62038
Change-Id: I136fbd4e58b63d44d048e1b355413bff044be771
Reviewed-on: http://review.typo3.org/33167
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Show correct tooltip for page type "Mount Point" 80/33180/4
Georg Ringer [Tue, 7 Oct 2014 04:31:43 +0000 (06:31 +0200)]
[BUGFIX] Show correct tooltip for page type "Mount Point"

The tooltip of pages of the type "Mount Point" lacks the information
about the linked page because the needed fields are not retrieved.

Additionally the shortcut tooltip gets improved for the page tree.

Change-Id: I9c7c65094d23bbc0b0eb6100b0d6a62641c00d22
Resolves: #61951
Related: #60033
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33180
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[FEATURE] Template Path fallback for Fluid Standalone View 13/32613/17
Anja Leichsenring [Sat, 6 Sep 2014 20:46:49 +0000 (22:46 +0200)]
[FEATURE] Template Path fallback for Fluid Standalone View

TemplateView received the feature of template path fallback
configuration with issue #39868.
The same is missing for Standalone view and will be introduced
with this patch.

Change-Id: I1e854a356a4c7e9cfff773c8f56fe4a437f77920
Resolves: #61361
Related: #39868
Releases: master
Reviewed-on: http://review.typo3.org/32613
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[!!!][TASK] Execute remap handling of nested children earlier 91/31891/4
Oliver Hader [Mon, 28 Jul 2014 16:31:33 +0000 (18:31 +0200)]
[!!!][TASK] Execute remap handling of nested children earlier

If dealing with nested parent-child-structures, it happens that
the proper UID of a record (either parent or child) has not been
persisted yet and therefore it's only a "NEW..." which will be
replaced in a later step during several "remapping" actions.

If copying a page with many sub-pages and sub-records this
remap action is processed very late. Results are invalid record
relations (like content elements now having duplicated images
since the remapping has not updated the real parent pointer yet).

This patch is marked with [!!!] since side-effects can appear.
In case this change gets merged and it turns out that DataHandling
got worse, it's target to be reverted again.

Resolves: #60654
Releases: master
Change-Id: I9dc77630e832e2b9ab65840daf44931640c6d816
Reviewed-on: http://review.typo3.org/31891
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fluid tries to render folders as templates partials and layouts 51/23951/5
Krzysztof Adamczyk [Sat, 21 Sep 2013 13:42:31 +0000 (15:42 +0200)]
[BUGFIX] Fluid tries to render folders as templates partials and layouts

The file_exists checks in TemplateView and StandaloneView are true for
folders. This leads to unrendered partials with resorted paths.
Use is_file instead.

Releases: master, 6.2, 6.1
Resolves: #47188
Change-Id: I9c168f4793f173f6c2f848e6e3da1f6021ae9c06
Reviewed-on: http://review.typo3.org/23951
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Wrong spelled file name for breaking change 61863 93/33193/2
Wouter Wolters [Tue, 7 Oct 2014 19:52:08 +0000 (21:52 +0200)]
[BUGFIX] Wrong spelled file name for breaking change 61863

Resolves: #62090
Related: #61863
Releases: master
Change-Id: I9ab912a4fff64a4a5d3a4fa8aee59dc67a0d667b
Reviewed-on: http://review.typo3.org/33193
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Cleanup of Template module 75/33175/3
Georg Ringer [Mon, 6 Oct 2014 19:10:55 +0000 (21:10 +0200)]
[TASK] Cleanup of Template module

* Remove rendering with tables in "Template Analyzer"
* Remove button "Set Conditions" in "TypoScript Object Browser"
  if no conditions are available.

Resolves: #62063
Releases: master
Change-Id: I326c1bdacfb52883d2872002c09eb826f4f6703e
Reviewed-on: http://review.typo3.org/33175
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Remove empty values in pageOverlayFields 81/33181/2
Nils Blattner [Tue, 7 Oct 2014 08:47:58 +0000 (10:47 +0200)]
[BUGFIX] Remove empty values in pageOverlayFields

$GLOBALS['TYPO3_CONF_VARS']['FE']['pageOverlayFields'] might contain
empty values. Remove those.

Resolves: #62068
Releases: master, 6.2
Change-Id: I79337d9d8dca17fc840a331c8839147054d1b3f0
Reviewed-on: http://review.typo3.org/33181
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Provide correct FormEngine instance to userFunc 74/33174/4
Alexander Opitz [Mon, 6 Oct 2014 15:25:26 +0000 (17:25 +0200)]
[BUGFIX] Provide correct FormEngine instance to userFunc

Use the FormEngine while calling the UserFunction inside the UserElement
as this was expected before splitting the elements out of FormEngine
class.

Resolves: #62060
Releases: master
Change-Id: I249b6a50cb95ee69c34b9d1d6a24ac19934e66a1
Reviewed-on: http://review.typo3.org/33174
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Readd frame setting to image configuration 79/33179/3
Manfred Rutschmann [Tue, 7 Oct 2014 03:36:13 +0000 (05:36 +0200)]
[BUGFIX] Readd frame setting to image configuration

The setting "frame" is missing in the processing information in
image handling.

Change-Id: I24410d28daa8017995cc9b352c328dff3f329748
Resolves: #62053
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33179
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Make FAL work in the flexform field having dot in the name 06/33106/4
Tymoteusz Motylewski [Thu, 2 Oct 2014 12:09:32 +0000 (14:09 +0200)]
[BUGFIX] Make FAL work in the flexform field having dot in the name

Fixes regression introduced in I6599c3ce7eea493e2bfaa29312775bf1659ded69
During the change from prototype to jQuery few places missed
escaping of the dot in the id of the DOM node.

This patch fixes these places and also few other jQuery related bugs
E.g. we have to use "object.length" to test if jQuery selector
was found.

Resolves: #62001
Related: #58475
Releases: master
Change-Id: I9bb661c5bf58aa9b73106a1e48f2206465a8974e
Reviewed-on: http://review.typo3.org/33106
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Rendering classes for InputElement results in broken HTML 78/33178/2
Wouter Wolters [Mon, 6 Oct 2014 20:34:46 +0000 (22:34 +0200)]
[BUGFIX] Rendering classes for InputElement results in broken HTML

In this patch a missing logDeprecatedFunction is also added.

Resolves: #62066
Releases: master
Change-Id: I0432b7e10e705b2c08c464eb43cfd1ae03f73a9b
Reviewed-on: http://review.typo3.org/33178
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
5 years ago[BUGFIX] Correct path to font awesome fonts 77/33177/2
Georg Ringer [Mon, 6 Oct 2014 20:25:55 +0000 (22:25 +0200)]
[BUGFIX] Correct path to font awesome fonts

The path needs to be corrected.

Resolves: #62065
Releases: master
Change-Id: I22b9b3384faba114438375ad3826bb96eb613d27
Reviewed-on: http://review.typo3.org/33177
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[BUGFIX] Buttongroup for icons in toolbar not floated to the left 76/33176/3
Wouter Wolters [Mon, 6 Oct 2014 19:55:16 +0000 (21:55 +0200)]
[BUGFIX] Buttongroup for icons in toolbar not floated to the left

Fix a left over for removing styles which were missed in #61890

Resolves: #62064
Releases: master
Change-Id: I8121e901986cfa40388eba53f073184dc9b7f317
Reviewed-on: http://review.typo3.org/33176
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[CLEANUP] Always use HSC in TS labels in BE 07/32707/4
Benjamin Mack [Wed, 10 Sep 2014 14:01:13 +0000 (16:01 +0200)]
[CLEANUP] Always use HSC in TS labels in BE

The ExtendedTemplateService class contains
a switch "ext_noSpecialCharsOnLabels" which
is never used in the core. It is used to call a wrapper
function that simple doesn't do HSC() if the
option is set.

The method and option can be deprecated.

Releases: master
Resolves: #61513
Change-Id: I90e1f3728287b9f4dfa93f4cfc6875b5314a0eb3
Reviewed-on: http://review.typo3.org/32707
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[TASK] Remove styling code in FormEngine/TCA 75/32975/8
Benjamin Mack [Thu, 25 Sep 2014 18:37:39 +0000 (20:37 +0200)]
[TASK] Remove styling code in FormEngine/TCA

FormEngine uses a combination
of classes and styles, which is very
complicated and not usable. A new way
of handling the styling is needed.
All old methods are deprecated and not in use
anymore.

At a later step, proper classes can be introduced
and styling can be done in LESS cleanly
without any PHP magic.

Releases: master
Resolves: #61890
Change-Id: Ie72226e1c6d795b3d8b53220fbcbee9e059935a6
Reviewed-on: http://review.typo3.org/32975
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
5 years ago[FEATURE] Refactor EXT: t3skin CSS to Less & variables 70/33170/3
Felix Kopp [Sun, 5 Oct 2014 19:09:10 +0000 (21:09 +0200)]
[FEATURE] Refactor EXT: t3skin CSS to Less & variables

Make use of Less hierarchy and constraints. Dissolves "visual" and
"structure" folders in order to use Less variables for "Visual"
layout at a later point.

This patch:
+ moves Less files
+ merges visual and structure sub-folders
+ merges several CSS classes into hierarchical format.

Patch explicitly does not yet:
+ refactor CSS definitions
+ removes duplicated CSS definitions
+ make use of Bootstrap where applicable.

Layout in the backend before and after this patch does not change.

Resolves: #62042
Releases: master
Change-Id: Ic9045a565c3a81808431c217379ffb375807c071
Reviewed-on: http://review.typo3.org/33170
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Remove TBE_STYLES mainColors from PHP 68/33168/2
Benjamin Mack [Sun, 5 Oct 2014 08:20:07 +0000 (10:20 +0200)]
[TASK] Remove TBE_STYLES mainColors from PHP

TYPO3 uses $TBE_STYLES to define certain
variables like background colors in PHP that
can be overridden with extensions.

In order to streamline the rendering of the
backend that should completely done via
LESS / CSS, the corresponding PHP parts are
removed, as they should have no effect
anyway - this is already done via CSS.

Releases: master
Resolves: #62039
Change-Id: I81533c1d2912fc25b96f106974e5cd625b827c90
Reviewed-on: http://review.typo3.org/33168
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
5 years ago[TASK] Base DynTab on Bootstrap and re-color 30/33130/2
Felix Kopp [Thu, 2 Oct 2014 22:21:50 +0000 (00:21 +0200)]
[TASK] Base DynTab on Bootstrap and re-color

Base the DynTab tabs on <ul> and Bootstrap nav-tab. Also
base the tab colors on Bootstrap variables and remove colors
as well as gradient.

Related: #62002
Releases: master
Change-Id: Ibff2f3633512538b323af465e55ef9d08fc8bfd3
Reviewed-on: http://review.typo3.org/33130
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[CLEANUP] Remove unused code from old backend 62/33162/3
Benjamin Mack [Sat, 4 Oct 2014 12:24:12 +0000 (14:24 +0200)]
[CLEANUP] Remove unused code from old backend

Prior to TYPO3 CMS 4.5 there were still some
variables which are not used anymore since then.

The menuReset() function does not exist anymore
as well as the CSS class "navFrameHL".

Releases: master
Resolves: #62033
Change-Id: Ie7bda9d4e3d6f2090548d133768543236112b2cb
Reviewed-on: http://review.typo3.org/33162
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Improve namings of CheckboxElement 22/33122/4
Wouter Wolters [Thu, 2 Oct 2014 18:32:27 +0000 (20:32 +0200)]
[TASK] Improve namings of CheckboxElement

Use better namings for variables in CheckboxElement.

Count of selectedItems is done multiple times.
Better is to do the counting once and use the result in the
other places.

Resolves: #62012
Releases: master
Change-Id: Id0cced22902dafc33ef086a964e3f9a61891bff6
Reviewed-on: http://review.typo3.org/33122
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Add empty extension compatibility6 27/33127/6
Anja Leichsenring [Thu, 2 Oct 2014 20:56:21 +0000 (22:56 +0200)]
[TASK] Add empty extension compatibility6

This is a placeholder extension taking deprecated functionality
into child care to prolong the adaption phase for updating
individuals.
After all function have been moved, this extension will
be released to TER and removed from TYPO3 CMS core.

Change-Id: I8df0ecefcebdf3f2fe304529e6a79065254dee8e
Resolves: #62014
Relates: #62013
Releases: master
Reviewed-on: http://review.typo3.org/33127
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[TASK] CSS: Remove horizontal gray lines "uppercase" 79/32979/3
Felix Kopp [Thu, 25 Sep 2014 21:45:01 +0000 (23:45 +0200)]
[TASK] CSS: Remove horizontal gray lines "uppercase"

Class "uppercase" had been used to create visual hierarchy in backend
modules. Now we have H1-H6.

Resolves: #37925
Releases: master
Change-Id: I10eda8bb8a2d49f66c4d587e4cb35fc51be58712
Reviewed-on: http://review.typo3.org/32979
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[TASK] Performance improvement on indexing process 75/20275/8
Ralf Hettinger [Sun, 28 Apr 2013 19:48:54 +0000 (21:48 +0200)]
[TASK] Performance improvement on indexing process

Use exec_INSERTmultipleRows instead of exec_INSERTquery for
submitting indexer results to table index_rel. This may save _a lot_
of I/O load, especially when a page contains many words to be indexed.

Skip words marked as stopWords to prevent flooding of index_rel table.

Resolves: #38742
Resolves: #18599
Releases: master
Change-Id: Ia729e6632124692cabe7d5ebe079db7d6795b809
Reviewed-on: http://review.typo3.org/20275
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Introduce AbstractFormElement for FormEngine elements 15/33115/3
Markus Klein [Thu, 2 Oct 2014 16:19:05 +0000 (18:19 +0200)]
[TASK] Introduce AbstractFormElement for FormEngine elements

This is a follow up to #61958 which improves the code structure.

Resolves: #62011
Related: #61958
Releases: master
Change-Id: Ia89be0cfaa0779414652e5f5791b3920aa0d9927
Reviewed-on: http://review.typo3.org/33115
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[FEATURE] Allow svg files as image format for extension icons 72/32372/7
Ingo Pfennigstorf [Tue, 26 Aug 2014 08:47:51 +0000 (10:47 +0200)]
[FEATURE] Allow svg files as image format for extension icons

This adds the possibility to add extension icons in svg format.

Resolves: #61185
Releases: 6.3
Change-Id: I52463b8a26b19da17ccdcead3f82864719bace50
Reviewed-on: http://review.typo3.org/32372
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Move TCA renderings to designated classes 45/33045/9
Georg Ringer [Mon, 29 Sep 2014 19:35:19 +0000 (21:35 +0200)]
[TASK] Move TCA renderings to designated classes

The FormEngine class is a big chunk of many methods.
As a first step, the rendering of the different TCA types
are moved into designated classes.

Resolves: #61958
Releases: master
Change-Id: Ieaf894ac6400537ea3a4fa9495e131e0e09fc19a
Reviewed-on: http://review.typo3.org/33045
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Split up typolink() functionality in multiple methods - Part 1 85/21785/11
Benjamin Mack [Tue, 9 Sep 2014 16:36:41 +0000 (18:36 +0200)]
[TASK] Split up typolink() functionality in multiple methods - Part 1

The cObj->typolink() method is one of the biggest code chunks in
the CMS core, and one of the most central ones for the frontend.
However, it is hard to test, debug and understand. That's why certain
separate parts can be split up in multiple methods.

The first step provides the following changes:

* More readable variables within the method
* Split up the detection, whether it is a mail link,
  external url etc in a separate method
* Split up the string explode functionality of "23 - myclass"
  into a separate method

There are unit tests missing. Also, resolving each link type
could be put in a separate method as well in a further step.

Resolves: #49575
Releases: master
Change-Id: I40fe9367d65d6f6b7a857f5972765d1c2eb561ca
Reviewed-on: http://review.typo3.org/21785
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
5 years ago[TASK] Improve comment of GeneralUtility::makeInstance() 91/32991/5
Roland Waldner [Sat, 27 Sep 2014 09:08:54 +0000 (11:08 +0200)]
[TASK] Improve comment of GeneralUtility::makeInstance()

A note about the fact, that ObjectManager::get() is injecting
dependencies may be helpful.

Resolves: #61916
Releases: master
Change-Id: I4067036ae5d95877245e150c9f7ca91dea3c954e
Reviewed-on: http://review.typo3.org/32991
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
5 years ago[BUGFIX] Search word markup for UTF8 characters in summary 69/20269/4
Ralf Hettinger [Sun, 28 Apr 2013 18:20:42 +0000 (20:20 +0200)]
[BUGFIX] Search word markup for UTF8 characters in summary

Fix usage of preg_split to use the modifier /u so that search words
are correctly split in a summary.

Resolves: #26172
Releases: master, 6.2, 6.1
Change-Id: I90d8676f5724f194434811378eb8598eaf04cb9e
Reviewed-on: http://review.typo3.org/20269
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Removes useless icon used in BE login template 79/33079/4
Eric Chavaillaz [Tue, 30 Sep 2014 13:00:24 +0000 (15:00 +0200)]
[TASK] Removes useless icon used in BE login template

In the backend login template there is an old logo which
is not used anymore. We can remove it.

Resolves: #61963
Releases: master
Change-Id: I18ad8d1b57a8c0ca8223ac89a356f5b93370645c
Reviewed-on: http://review.typo3.org/33079
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[BUGFIX] BE login template: fix invalid HTML structure 78/33078/3
Eric Chavaillaz [Tue, 30 Sep 2014 12:53:59 +0000 (14:53 +0200)]
[BUGFIX] BE login template: fix invalid HTML structure

In the backend login template a div tag is nested within a dl tag.
This is prohibited by the HTML specification.
This patch reverses the tag ordering.

Resolves: #61962
Releases: master, 6.2
Change-Id: I4e6410111a2ede2f9294cf390d7e96eedbeb58f6
Reviewed-on: http://review.typo3.org/33078
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Fix functional tests for EXT:impexp 64/33064/4
Oliver Hader [Tue, 30 Sep 2014 08:50:24 +0000 (10:50 +0200)]
[TASK] Fix functional tests for EXT:impexp

After issue #61944 has been merged, sys_file_reference.link does
not support NULL values anymore (which is fine). However, in the
past the default has been NULL and also has been written in the
accordant functional test data assertions.

Thus, NULL assertions are removed from the test. The change of
the "size" property by 5 bytes can be explained by a difference
in serializing NULL values and serializing an empty string.

Releases: master, 6.2
Related: #61944
Change-Id: Ia8700d6b6e374412e3300f12f4d6bb341deb4cfe
Reviewed-on: http://review.typo3.org/33064
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE 61/33061/2
Michael Schams [Mon, 29 Sep 2014 09:54:35 +0000 (19:54 +1000)]
[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE

This patch fixes invalid JavaScript code (adds a missing closing
bracket), that prevents BE users from creating links to anchor tags
in the RTE.

This is a regression fix to #41413.

Resolves: #61943
Releases: master, 6.2
Change-Id: I8e085e01885333d612cf6776495be259b00a093a
Reviewed-on: http://review.typo3.org/33061
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years agoRevert "[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE" 58/33058/2
Markus Klein [Tue, 30 Sep 2014 09:26:31 +0000 (11:26 +0200)]
Revert "[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE"

This reverts commit 9bcebec002224bbc2a0dcd38cff032a14f2e075e.

The commit message of the original patch references a wrong
issue number and the target versions seem to be wrong too.

Change-Id: I9d910e6ad046d8864ef6c03594b632349f84b50b
Resolves: #61968
Reverts: #61943
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33058
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE 20/33020/3
Michael Schams [Mon, 29 Sep 2014 09:54:35 +0000 (19:54 +1000)]
[BUGFIX] Fix JavaScript error that prevents links to anchor tags in RTE

This patch fixes invalid JavaScript code (adds a missing closing
bracket), that prevents BE users from creating links to anchor tags
in the RTE.

This is a regression fix to #60919.

Resolves: #61943
Releases: master, 6.2, 6.1, 4.7, 4.5
Change-Id: I90ecba126191322048a2c4aca7835d3795764324
Reviewed-on: http://review.typo3.org/33020
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[DB] Increase max length of link fields 21/33021/4
Lars Malach [Mon, 29 Sep 2014 10:21:48 +0000 (12:21 +0200)]
[DB] Increase max length of link fields

The current core supports links with the maximum length of 256 chars in
header links of tt_content elements and links in table
sys_file_reference.

External links can have much more than 256 chars.

Increasing the maximum length to 1024 should be enough - even current
browsers are supporting much more than 1024 chars.

Resolves: #61944
Releases: master, 6.2
Change-Id: I2031ebef959de696bc320b927ec1a462bcd5dd72
Reviewed-on: http://review.typo3.org/33021
Reviewed-by: Achim Fritz <af@lightwerk.com>
Tested-by: Achim Fritz <af@lightwerk.com>
Reviewed-by: Markus Blaschke <typo3@schattenjaeger.net>
Tested-by: Markus Blaschke <typo3@schattenjaeger.net>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[FEATURE] Usability improvements by top searchbox in list module 97/30997/13
Frank Nägler [Sat, 21 Jun 2014 13:10:41 +0000 (15:10 +0200)]
[FEATURE] Usability improvements by top searchbox in list module

For a better user experience in the list module, it makes sense to display
the search box at the top and not at the bottom of the page.
If a user works with a lot of records in the list module it is really
annoying to scroll down, the position in the top is more ergonomic.

With the new search icon in the doc header it is possible to toggle the
new search toolbar. if the user enter a search term and the results in
the list module are filtered, the search toolbar is visible by default.

This patch works also with the searchbox in the page module. The
searchbox in the ElementBrowser is always visible, but also now on top
above the table.

Resolves: #59763
Documentation: #59763
Related: #61777
Releases: master
Change-Id: I25e81b5f5b914cb75bf30de16fcc2da9edd7f6e6
Reviewed-on: http://review.typo3.org/30997
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Change explanatory text of SYS error reporting config variables 18/33018/2
Daniel Minder [Mon, 29 Sep 2014 09:28:30 +0000 (11:28 +0200)]
[BUGFIX] Change explanatory text of SYS error reporting config variables

Unify explanatory text of the variables [SYS][errorHandlerErrors],
[SYS][exceptionalErrors], [SYS][syslogErrorReporting] and
[SYS][belogErrorReporting] so that formatting, link to PHP doc and
the numerical default values are similar.

Resolves: #61942
Releases: master, 6.2
Change-Id: Iacdbf18ad5c181c499c23c4c50cebffc6736236c
Reviewed-on: http://review.typo3.org/33018
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Use input type "email" in Install-Tool 05/33005/2
Georg Ringer [Sun, 28 Sep 2014 20:29:49 +0000 (22:29 +0200)]
[TASK] Use input type "email" in Install-Tool

Using the type "email" for the test section is state of the art and
avoid user errors because the browser checks the syntax before allowing
a submit.

Resolves: #61936
Releases: master
Change-Id: Idfeb7503d933b2758bbd3e7f7b9e20085a4a79ab
Reviewed-on: http://review.typo3.org/33005
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] DBAL admin_query() check array before accessing it 96/32996/2
Markus Klein [Sun, 28 Sep 2014 13:59:09 +0000 (15:59 +0200)]
[BUGFIX] DBAL admin_query() check array before accessing it

Move the $parsedQuery array access after the is_array() check in
DatabaseConnection::admin_query() to avoid PHP warnings.

Releases: master, 6.2
Resolves: #61929
Change-Id: I641d1e0d1dbe0001bd7082fbed1ce5ddb35172f8
Reviewed-on: http://review.typo3.org/32996
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[FEATURE] Followup: Introduce read-only column for file mounts 95/32995/2
Frans Saris [Sun, 28 Sep 2014 09:05:32 +0000 (11:05 +0200)]
[FEATURE] Followup: Introduce read-only column for file mounts

Added missing feature document for http://review.typo3.org/31096

Resolves: #59830
Releases: master
Change-Id: Id71c579e7e12ba6ad6a58cdae949f9165bb1bc60
Reviewed-on: http://review.typo3.org/32995
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[CLEANUP] Cleanup code of TS module overview 44/32644/7
Georg Ringer [Mon, 8 Sep 2014 14:41:21 +0000 (16:41 +0200)]
[CLEANUP] Cleanup code of TS module overview

The file handling has been removed some versions ago but some code
has not been removed.

Resolves: #61444
Releases: master
Change-Id: I369c15e999d087b7bf1ffb96529ab91d21b03a52
Reviewed-on: http://review.typo3.org/32644
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] indexed_search/Indexer: correct frequency mapping for 1 56/20356/4
Ralf Hettinger [Tue, 30 Apr 2013 14:15:54 +0000 (16:15 +0200)]
[BUGFIX] indexed_search/Indexer: correct frequency mapping for 1

There was a slight glitch in indexed_search's indexer, which resulted in
a wrong frequency mapping if the ratio between number of current word /
all words is exactly 1.
The "frequency" for this word is now mapped to the highest possible
value.

Resolves: #47745
Releases: master, 6.2
Change-Id: I1c9945b9550b80ad969f907f0bf1f14c3ae872f9
Reviewed-on: http://review.typo3.org/20356
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix indexed_search page browsing calculation 32/31632/5
Markus Klein [Tue, 15 Jul 2014 17:30:24 +0000 (19:30 +0200)]
[BUGFIX] Fix indexed_search page browsing calculation

Fix the calculation of pages shown by the indexed_search page browsers
to avoid negative page numbers or numbers exceeding the maximum available
page number.

Resolves: #60346
Releases: master, 6.2
Change-Id: I97de1c1afe42e29d450733f6741bca049f9803f6
Reviewed-on: http://review.typo3.org/31632
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Remove last call to wrapLabels 89/32989/2
Jigal van Hemert [Fri, 26 Sep 2014 21:32:12 +0000 (23:32 +0200)]
[BUGFIX] Remove last call to wrapLabels

Make editing of the entire TypoScript template record possible by
removing the last remaining call to FormEngine::wrapLabels().

Resolves: #61915
Releases: master
Change-Id: I5d7b70df3b5352e9e2c781cfa2f5d33cb27ad798
Reviewed-on: http://review.typo3.org/32989
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 years ago[!!!][TASK] Remove deprecated file type FILETYPE_SOFTWARE 55/32955/2
Wouter Wolters [Wed, 24 Sep 2014 18:40:50 +0000 (20:40 +0200)]
[!!!][TASK] Remove deprecated file type FILETYPE_SOFTWARE

Resolves: #61859
Releases: master
Change-Id: I30360e021faa8f252a11a7aad6247aedbbc175ca
Reviewed-on: http://review.typo3.org/32955
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Remove unimplemented function in FormEngine 76/32976/2
Benjamin Mack [Thu, 25 Sep 2014 18:41:14 +0000 (20:41 +0200)]
[TASK] Remove unimplemented function in FormEngine

There is a function wrapLabels which does not do
anything for ages.
As it is empty, I suggest to remove it completely
instead of deprecating it.

Releases: master
Resolves: #61891
Change-Id: Ic0ebb366f663f43803321d823bb6d41ec579b052
Reviewed-on: http://review.typo3.org/32976
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[!!!][TASK] Remove deprecated connectDB from EidUtility 60/32960/3
Wouter Wolters [Wed, 24 Sep 2014 21:13:56 +0000 (23:13 +0200)]
[!!!][TASK] Remove deprecated connectDB from EidUtility

Resolves: #61863
Releases: master
Change-Id: Ie46706b237a350ad36a10550232c3a2b6c09e5e5
Reviewed-on: http://review.typo3.org/32960
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[!!!][TASK] Remove deprecated function int_from_ver 56/32956/3
Wouter Wolters [Wed, 24 Sep 2014 18:49:03 +0000 (20:49 +0200)]
[!!!][TASK] Remove deprecated function int_from_ver

Resolves: #61860
Releases: master
Change-Id: I14491a32d3b85dbe3635721d6ad03c691897771a
Reviewed-on: http://review.typo3.org/32956
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Remove TypoScript option from fixture extension 61/32961/3
Wouter Wolters [Wed, 24 Sep 2014 21:21:25 +0000 (23:21 +0200)]
[TASK] Remove TypoScript option from fixture extension

The TypoScript option rewrittenPropertyMapper is not of any
use anymore and can safely be removed.

Resolves: #61864
Releases: master
Change-Id: Ib9c76be598b24858e58b7e2a2e7bb7fe3acc3605
Reviewed-on: http://review.typo3.org/32961
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[!!!][TASK] Remove deprecated isDisplayCondition function from FormEngine 47/32947/4
Wouter Wolters [Tue, 23 Sep 2014 21:21:41 +0000 (23:21 +0200)]
[!!!][TASK] Remove deprecated isDisplayCondition function from FormEngine

Resolves: #61828
Releases: master
Change-Id: Id5c2d81fdff9cb6960749f93b10db1107aa8ed49
Reviewed-on: http://review.typo3.org/32947
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Remove deprecated check in llXmlAutoFileName for typo3_src/tests 57/32957/2
Wouter Wolters [Wed, 24 Sep 2014 19:09:48 +0000 (21:09 +0200)]
[TASK] Remove deprecated check in llXmlAutoFileName for typo3_src/tests

Resolves: #61862
Releases: master
Change-Id: I899916a6ee9bb0684fd91d76fca99b32a1c8f6b9
Reviewed-on: http://review.typo3.org/32957
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Change input type of search-fields from text to search 03/32903/6
Ingo Pfennigstorf [Sun, 21 Sep 2014 18:18:16 +0000 (20:18 +0200)]
[TASK] Change input type of search-fields from text to search

This changes the html input type for the search-fields from
"text" to the semantically correct "search".

Releases: master
Resolves: #61777
Change-Id: Id8a5fc9155a89898e5aede0a2e2e82f99b967529
Reviewed-on: http://review.typo3.org/32903
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Tested-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[FEATURE] Add AbstractCondition for TS conditions 95/32695/11
Benjamin Mack [Tue, 9 Sep 2014 19:42:37 +0000 (21:42 +0200)]
[FEATURE] Add AbstractCondition for TS conditions

In order to streamline conditions and make
TypoScript conditions more flexible, an abstract class
AbstractCondition is introduced. Any class can extend
this abstract class, and TypoScript seamlessly calls
the class's main function that can completely flexibly
deal with the value that is set after the class.

possible conditions are:

[ACME\TypoScriptLovePackage\BennisCondition]

[ACME\TypoScriptLovePackage\BennisCondition = 7]

[ACME\TypoScriptLovePackage\BennisCondition = 7, != 6]

where the TypoScript Condition can deal with =/!= etc
by itself.

Additionally, this change fixes one bug, where the
AbstractConditionMatcher would check on a condition name
and would not match, then there is an additional
run through the subclass although not needed.

Releases: master
Resolves: #61489
Change-Id: I891edd367bb29b042cbbf6aa368cbf173dc3815d
Reviewed-on: http://review.typo3.org/32695
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[!!!][TASK] Remove classFile option in makeInstanceService 44/32944/2
Wouter Wolters [Tue, 23 Sep 2014 18:01:50 +0000 (20:01 +0200)]
[!!!][TASK] Remove classFile option in makeInstanceService

Resolves: #61821
Releases: master
Change-Id: I5b9426f003c762f1f152545eac43c8a095e73b92
Reviewed-on: http://review.typo3.org/32944
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[!!!][TASK] Remove magic setter for $fromTC 46/32946/3
Wouter Wolters [Tue, 23 Sep 2014 18:25:16 +0000 (20:25 +0200)]
[!!!][TASK] Remove magic setter for $fromTC

Resolves: #61823
Releases: master
Change-Id: I5997954508ecdddb10fc286f5be40fe27cc75d6f
Reviewed-on: http://review.typo3.org/32946
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Change input type for backend search result limit to "number" 04/32904/3
Ingo Pfennigstorf [Sun, 21 Sep 2014 18:24:58 +0000 (20:24 +0200)]
[TASK] Change input type for backend search result limit to "number"

This changes the html input type for the backend search result limit
from "text" to the html5 attribute "number".

Releases: master
Resolves: #61778
Change-Id: I28aac40a61e6d6499cd6aa72beda5bb765c25d01
Reviewed-on: http://review.typo3.org/32904
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[!!!][TASK] Remove deprecated getUniqueFields function from DataHandler 45/32945/3
Wouter Wolters [Tue, 23 Sep 2014 18:12:50 +0000 (20:12 +0200)]
[!!!][TASK] Remove deprecated getUniqueFields function from DataHandler

Resolves: #61822
Releases: master
Change-Id: I1d150653fed952560f08a9faab719128f38f66c4
Reviewed-on: http://review.typo3.org/32945
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[!!!][TASK] Remove deprecated PhpOptionsUtility functions 43/32943/2
Wouter Wolters [Tue, 23 Sep 2014 17:45:30 +0000 (19:45 +0200)]
[!!!][TASK] Remove deprecated PhpOptionsUtility functions

Resolves: #61820
Releases: master
Change-Id: Ib5057059f0d0da56c419b931341baae2fec891f2
Reviewed-on: http://review.typo3.org/32943
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 years ago[!!!][TASK] Remove deprecated mail functionality 07/32907/6
Wouter Wolters [Sun, 21 Sep 2014 20:10:29 +0000 (22:10 +0200)]
[!!!][TASK] Remove deprecated mail functionality

Resolves: #61783
Releases: master
Change-Id: Iebe604aca73cee6efc834b1e8c678cd49ce265fc
Reviewed-on: http://review.typo3.org/32907
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[!!!][TASK] Remove deprecated TCA functions 10/32910/5
Wouter Wolters [Sun, 21 Sep 2014 20:56:35 +0000 (22:56 +0200)]
[!!!][TASK] Remove deprecated TCA functions

Resolves: #61785
Releases: master
Change-Id: I6c03f24ec217a5d3ae7826bd5f8bbc696084b1c0
Reviewed-on: http://review.typo3.org/32910
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Suhosin triggers warnings in Install Tool 22/27822/4
Wouter Wolters [Mon, 24 Feb 2014 22:27:18 +0000 (23:27 +0100)]
[BUGFIX] Suhosin triggers warnings in Install Tool

When Suhosin runs in simulation mode, violations are logged
as usual, but nothing is blocked or removed from the request.

Add an extra check to isSuhosinLoaded, to prevent unneeded
warnings.

Resolves: #55886
Releases: master, 6.2
Change-Id: Idd07872d31d51ed3266fcf330e825187656167a8
Reviewed-on: http://review.typo3.org/27822
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[!!!][TASK] Remove deprecated DocumentTemplate classes 06/32906/7
Wouter Wolters [Sun, 21 Sep 2014 19:42:09 +0000 (21:42 +0200)]
[!!!][TASK] Remove deprecated DocumentTemplate classes

* MediumDocumentTemplate
* SmallDocumentTemplate
* StandardDocumentTemplate

Resolves: #61782
Releases: master
Change-Id: I9ccc81e1d62f6e662e356b584eb2db61eea55016
Reviewed-on: http://review.typo3.org/32906
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[!!!][TASK] Remove deprecated isLocalconfWritable function 27/32927/4
Wouter Wolters [Mon, 22 Sep 2014 20:11:57 +0000 (22:11 +0200)]
[!!!][TASK] Remove deprecated isLocalconfWritable function

Resolves: #61802
Releases: master
Change-Id: Iaa0b8a546b33b2c919987e12f684c356a9dfdf67
Reviewed-on: http://review.typo3.org/32927
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years agoRevert "[BUGFIX] Invalid rendering of high resolution icons in lists" 31/32931/2
Oliver Hader [Tue, 23 Sep 2014 11:52:48 +0000 (13:52 +0200)]
Revert "[BUGFIX] Invalid rendering of high resolution icons in lists"

This reverts commit 97b928e9d5a596b029f43895f887cdeea85b7fa3.

Change-Id: Ib27e83ff31b20c9ba03e34a184dae18a779672d9
Resolves: #61813
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32931
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[!!!][TASK] Remove deprecated TypeHandlingService 11/32911/5
Wouter Wolters [Sun, 21 Sep 2014 21:16:59 +0000 (23:16 +0200)]
[!!!][TASK] Remove deprecated TypeHandlingService

Resolves: #61786
Releases: master
Change-Id: Ib30130a238fd07a5937328e242e41f4643267ffa
Reviewed-on: http://review.typo3.org/32911
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Add documentation for ClickMenuController code removal 12/32912/3
Markus Klein [Sun, 21 Sep 2014 23:00:00 +0000 (01:00 +0200)]
[TASK] Add documentation for ClickMenuController code removal

Follow up to https://review.typo3.org/32905

Resolves: #61781
Releases: master
Change-Id: I5fe7107795124c297d837dfe01b06b83bd5b6373
Reviewed-on: http://review.typo3.org/32912
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Invalid rendering of high resolution icons in lists 12/32812/3
Eric Chavaillaz [Sun, 21 Sep 2014 11:51:40 +0000 (13:51 +0200)]
[BUGFIX] Invalid rendering of high resolution icons in lists

When using high resolution icons (png) in backend modules (32x32) and
this module can be enabled/disabled in the be_groups/be_users records,
the icon is displayed bigger than desired.

This patch introduces width and height attributes in the "getIconHtml"
method to prevent this visual bug.

Resolves: #61656
Releases: master, 6.2
Change-Id: Ida484f794ab632eef8c693e41ee2b5f5d26c5e8f
Reviewed-on: http://review.typo3.org/32812
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] Remove deprecated inlcude_once array in ClickMenuController 05/32905/2
Wouter Wolters [Sun, 21 Sep 2014 19:38:07 +0000 (21:38 +0200)]
[TASK] Remove deprecated inlcude_once array in ClickMenuController

Resolves: #61781
Releases: master
Change-Id: I0ad4479fb733288d170ee3a06e778ff4890ecd6e
Reviewed-on: http://review.typo3.org/32905
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Do not check file extension on local file 17/32817/2
Alexander Opitz [Wed, 17 Sep 2014 07:56:17 +0000 (09:56 +0200)]
[BUGFIX] Do not check file extension on local file

If a file is uploaded and file extension deny pattern is set,
we should not test this temporary file for extension permissions.
Also on adding a file into a storage do not need to test the
extension of the local file, the extension of the target file is
enough.

Resolves: #58367
Releases: master, 6.2
Change-Id: I95b1685746150e2b03c56a5680785ae0b2388cd9
Reviewed-on: http://review.typo3.org/32817
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Add permission checks to edit icons in filelist and context menu 62/32462/9
Franz Koch [Wed, 27 Aug 2014 20:39:10 +0000 (22:39 +0200)]
[BUGFIX] Add permission checks to edit icons in filelist and context menu

In filelist as well as in context menus the edit/info/cut/copy/paste
icons are always shown and not disabled/removed if related FAL object
doesn't allow these actions. These changes fix this.

Resolves: #61261
Releases: 6.2, 6.3
Change-Id: I318a1112e9ee3c2fda4db219364663c89161320c
Reviewed-on: http://review.typo3.org/32462
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
5 years ago[FEATURE] Introduce read-only column for file mounts 96/31096/6
Lorenz Ulrich [Mon, 23 Jun 2014 13:41:17 +0000 (15:41 +0200)]
[FEATURE] Introduce read-only column for file mounts

File mount records get a new flag "read only".
This flag replaces the virtual flag introduced earlier,
so it can be defined natively in the record.

Resolves: #59830
Releases: 6.3
Change-Id: I11c738cb4740ea20b9088cc796ea0fb7ced1107a
Reviewed-on: http://review.typo3.org/31096
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Bernhard Kraft <kraftb@think-open.at>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[TASK] Use FLUIDTEMPLATE for rendering module Configuration 78/32778/9
Frank Nägler [Mon, 15 Sep 2014 12:14:32 +0000 (14:14 +0200)]
[TASK] Use FLUIDTEMPLATE for rendering module Configuration

As cleanup and improvement for the backend it is important to remove the
HTML code from the PHP logic. This patch removes the HTML code and uses
StandaloneView to render the content of the module.

The markup was removed as far as possible.

Resolves: #61604
Releases: 6.3
Change-Id: Ic515c790d1d76499cc18ecd633a570de9bfff2ca
Reviewed-on: http://review.typo3.org/32778
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[CLEANUP] Unqoute integer in BackendUserSessionRepository 87/32887/2
Andreas Fernandez [Fri, 19 Sep 2014 13:46:22 +0000 (15:46 +0200)]
[CLEANUP] Unqoute integer in BackendUserSessionRepository

In the method "findByBackendUser" in BackendUserSessionRepository,
the beuser uid used in the WHERE condition is casted to int and is
then quoted again.
This is not necessary and breaks the SQL for some DBMS.

Resolves: #61743
Releases: master, 6.2
Change-Id: Ibff2b6189efa16b8d7ce0acbc1637ce374f5f24d
Reviewed-on: http://review.typo3.org/32887
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] add _loadRealInstance in f:form ViewHelper 34/31934/5
Stefan Froemken [Fri, 1 Aug 2014 13:01:15 +0000 (15:01 +0200)]
[BUGFIX] add _loadRealInstance in f:form ViewHelper

If you edit a form containing subproperties of your domain model,
f:form VH will add some hidden fields to identify your related
domain models (__identity).
But in case of @lazy annotations, these fields will not be
rendered because of a missing _loadRealInstance call
in AbstractFormViewHelper object.

Releases 6.3, 6.2
Resolves: #60726
Change-Id: I67864e5b80752ff4350efabc72bd2b0a89d33bad
Reviewed-on: http://review.typo3.org/31934
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] LocalDriver->calculateBasePath doesn't properly sanitize 48/32548/6
Bernhard Kraft [Mon, 1 Sep 2014 13:36:01 +0000 (15:36 +0200)]
[BUGFIX] LocalDriver->calculateBasePath doesn't properly sanitize

The method "calculateBasePath" of Resource/Driver/LocalDriver.php
does not properly sanitize the passed value.

It misses to use the return value of "canonicalizeAndCheckFilePath".

Change-Id: I8f2561e4a3b432d869ba7931f3ce5877714699c0
Resolves: #61295
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32548
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
5 years ago[TASK] Update RequireJS to 2.1.15 81/32781/2
Jan Kiesewetter [Mon, 15 Sep 2014 12:50:26 +0000 (14:50 +0200)]
[TASK] Update RequireJS to 2.1.15

Resolves: #61608
Releases: master
Change-Id: Ic3ba3542bea23d852327d77821610f19844ee1e3
Reviewed-on: http://review.typo3.org/32781
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
5 years ago[BUGFIX] Invalid closure in AbstractMenuContentObject 73/32873/3
Francois Suter [Thu, 18 Sep 2014 20:09:15 +0000 (22:09 +0200)]
[BUGFIX] Invalid closure in AbstractMenuContentObject

Issue #58792 introduced a closure in AbstractMenuContentObject.php
which is not PHP 5.3 compatible. Since TYPO3 6.2 must still
support PHP 5.3, and master should be for now.
The closure is replaced by a simple loop.

Resolves: #61721
Releases: 6.2, master
Change-Id: Icc65bf8f8feec1bc62fcf83d8a2f464db3141c0d
Reviewed-on: http://review.typo3.org/32873
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Extbase behaviour concerning workspaces 88/30688/6
Oliver Hader [Tue, 10 Jun 2014 10:03:29 +0000 (12:03 +0200)]
[BUGFIX] Extbase behaviour concerning workspaces

Issue #26732 introduced some behaviour into Extbase that cannot
work on the long-run. The usual behaviour of TYPO3 is "fetch
live, then overlay". Avoiding that chain might lead to
several side-effects.

This change integrates a new property "_versionedUid" than
contains the specific uid of the versioned record (this is
similar to the already existing _localizedUid property).
Besides that, changes of issue #26732 are reverted.

Functional frontend tests are enabled for live and workspace
for all IRRE ForeignField scenarios.

Resolves: #59107
Releases: 6.2, 6.3
Change-Id: Idc46fb86830bc3d750972adade178cf9c618ece5
Reviewed-on: http://review.typo3.org/30688
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[FEATURE] Migrate open-docs counter to .badge 20/32820/5
Felix Kopp [Wed, 17 Sep 2014 10:23:46 +0000 (12:23 +0200)]
[FEATURE] Migrate open-docs counter to .badge

During streamline of the backend we make use of the Bootstrap .badge
component. The Badge can be attached to every toolbar / menu item to
show a notification / counter.

An input field is the wrong component: no input is possible.
Also CSS can be removed for the former inline input.

Resolves: #61675
Releases: master
Change-Id: Ie0c0d15b84d43c54a5f72ad2e564c2990832612e
Reviewed-on: http://review.typo3.org/32820
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Workspace Preview not working with lockSSL=3 51/32851/2
Oliver Hader [Thu, 18 Sep 2014 08:07:05 +0000 (10:07 +0200)]
[BUGFIX] Workspace Preview not working with lockSSL=3

The workspace preview does not work with lockSSL=3 being defined
in the Install Tool. First it looks like a CSS issue, in the end
it boils down that the preview IFRAMEs are not correctly
initialized in Workspaces\Hook\TypoScriptFrontendControllerHook.

The mentioned hook is only called once for the request to the
first IFRAME showing the website frontend preview and won't be
called for further.

The reason is, that cache expire headers are sent that prevent
the client to update the preview on each preview request.
That's why the mentioned hook is not called and the IFRAMEs
are not initialized properly. No-Cache headers are sent if a
backend user object is initialized correctly - and that's the
actual bug, a wrong but strict PHP condition, comparing a string
(lockSSL) with an integer value.

The comparison flaw was integrated with issue #54265

Change-Id: I13c5c2f22f5b43b49f8eead88f1bc82daf415cbb
Resolves: #61699
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32851
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[TASK] Always show action icons in tables (em, docs) 97/32797/3
Felix Kopp [Tue, 16 Sep 2014 09:49:26 +0000 (11:49 +0200)]
[TASK] Always show action icons in tables (em, docs)

The goal to hide actions icons has not been reached. Since the
hiding the icons is worse than showing all icons we revert to
the prior behaviour.

In the long run secondary and extended options / actions will
have to move into the Clickmenu. Show only primary actions.

Resolves: #55828
Releases: master, 6.2
Change-Id: Ibf3731822f5a06f1cd04989140d4f11ec5675c65
Reviewed-on: http://review.typo3.org/32797
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Indexed Search: Add missing return statement 25/32825/2
Markus Klein [Wed, 17 Sep 2014 12:09:21 +0000 (14:09 +0200)]
[BUGFIX] Indexed Search: Add missing return statement

Add missing return statement to searchMetaphone() method.

Resolves: #61679
Releases: master, 6.2
Change-Id: Ia87909a3f41fffea4a311c1d682aa97b8d7d5414
Reviewed-on: http://review.typo3.org/32825
Tested-by: Andy Amber <bernstein@barum.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] FormEngine fix inline paddings and hierarchy 19/32819/2
Felix Kopp [Wed, 17 Sep 2014 09:50:45 +0000 (11:50 +0200)]
[BUGFIX] FormEngine fix inline paddings and hierarchy

Fix inline paddings in FormEngine main sections. Also define FormEngine
".checkbox" to be  constrained within FormEngine. Brings improved header
palette hierarchy by setting <h3>.

Resolves: #61672
Releases: master
Change-Id: I9ae611ff60b282d10a0c3b7d102d8426947e043e
Reviewed-on: http://review.typo3.org/32819
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[TASK] t3skin: Base table.t3-table on Bootstrap 35/32735/4
Felix Kopp [Thu, 11 Sep 2014 19:01:42 +0000 (21:01 +0200)]
[TASK] t3skin: Base table.t3-table on Bootstrap

Base the common <table class="t3-table"> on Bootstrap
predefined classes .table, .table-hover and .table-striped.

This way we benefit of future Bootstrap browser fixes.

Resolves: #61546
Releases: master
Change-Id: Iaebfd3a661ace31f13cf7d1ac491352f468fd5c0
Reviewed-on: http://review.typo3.org/32735
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>