Packages/TYPO3.CMS.git
5 years ago[TASK] Remove wrong deprecation comment in EXT:form 20/28320/2
Wouter Wolters [Wed, 12 Mar 2014 19:35:12 +0000 (20:35 +0100)]
[TASK] Remove wrong deprecation comment in EXT:form

Resolves: #56842
Releases: 6.2
Change-Id: I709607157776100043969f0ffa8f801ba83bc6aa
Reviewed-on: https://review.typo3.org/28320
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Correctly validate New Content Element entries 88/27588/4
Ludwig Rafelsberger [Wed, 12 Feb 2014 19:36:09 +0000 (20:36 +0100)]
[BUGFIX] Correctly validate New Content Element entries

Each entry in the New Content Element wizard is tested to be valid,
i.e. the tt_content_defValues defined by that entry must be allowed
for the current BE user. Also, an entry may not select values that are
removed via TSconfig.

Setting TCEFORM.tt_content.[column].keepItems acts as a whitelist of
allowed values for *that* column. But the validity checks are done
hardcoded against the *CType* column.

Resolves: #23864
Releases: 6.2, 6.1
Change-Id: I5b6578f35552bd571fc822ac72f8f5fe12fe11f7
Reviewed-on: https://review.typo3.org/27588
Reviewed-by: Stefan Neufeind
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Missing localizeChildrenAtParentLocalization for CSV tests 99/28299/2
Oliver Hader [Wed, 12 Mar 2014 13:59:34 +0000 (14:59 +0100)]
[BUGFIX] Missing localizeChildrenAtParentLocalization for CSV tests

The "localizeChildrenAtParentLocalization" behaviour needs to be
set to automatically localize children for IRRE CSV functional
tests as well.

Resolves: #56819
Releases: 6.2
Change-Id: I14a09e715ad9674922776de450d519583770e0f5
Reviewed-on: https://review.typo3.org/28299
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] InvalidArgumentException in ActionControllerTest 00/28300/2
Oliver Hader [Wed, 12 Mar 2014 15:16:26 +0000 (16:16 +0100)]
[BUGFIX] InvalidArgumentException in ActionControllerTest

The cache identifier causing the exception looks like this:
randomviewobjectpattern_@package_mycontroller_myaction_myformat

However, "@package" should be "@extension" in that regard and
besides that, the cache identifier using the vendor names shall
be used in the tests.

Resolves: #56822
Releases: 6.2
Change-Id: Ic78a8690559486efcbc7f5da7219a445f3f6707f
Reviewed-on: https://review.typo3.org/28300
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Follow-up to "Add functional tests for generic persistence" 97/28297/2
Ernesto Baschny [Wed, 12 Mar 2014 13:50:35 +0000 (14:50 +0100)]
[TASK] Follow-up to "Add functional tests for generic persistence"

Test directory changed from "Relation" to "Persistence".

Resolves: #55661
Related: #55360
Related: #55167
Releases: 6.2

Change-Id: I422dbfb6bdad4215bdc70dea775917cf3159605f
Reviewed-on: https://review.typo3.org/28297
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Add functional tests for generic persistence 62/28262/7
Felix Oertel [Tue, 11 Mar 2014 15:39:13 +0000 (16:39 +0100)]
[TASK] Add functional tests for generic persistence

To backup the changes in Extbase's generic persistence,
we add some functional tests.

Resolves: #55661
Related: #55360
Related: #55167
Releases: 6.2
Change-Id: I0b845618b1cec9788ca36ac59e25ea6779f01cb6
Reviewed-on: https://review.typo3.org/28262
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] FollowUp to #56797 in I1f15fbd262036b6b2d0159cd0e9613ad7135a296 96/28296/3
Steffen Ritter [Wed, 12 Mar 2014 13:23:36 +0000 (14:23 +0100)]
[BUGFIX] FollowUp to #56797 in I1f15fbd262036b6b2d0159cd0e9613ad7135a296

Somehow a double $this->$this slipped into the cleanup on line 390
which now fatals. This needs to be fixed.

Resolves: #56797
Releases: 6.2
Change-Id: Ibb23b5f56c95106c4fea6e9a3ba09fbc9f9905dd
Reviewed-on: https://review.typo3.org/28296
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Wrong namespace in functional test of FluidTemplate cObject 94/28294/2
Philipp Gampe [Wed, 12 Mar 2014 13:13:35 +0000 (14:13 +0100)]
[BUGFIX] Wrong namespace in functional test of FluidTemplate cObject

Resolves: #56816
Releases: 6.2
Change-Id: I3abed35a5e27bdc9db2b18d5caa13681ef5a9305
Reviewed-on: https://review.typo3.org/28294
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Download link for absolute file path 68/28168/5
Marian Pollzien [Fri, 7 Mar 2014 16:26:58 +0000 (17:26 +0100)]
[BUGFIX] Download link for absolute file path

Support FAL adapters that return absolute urls as public file url

Change-Id: I68f2675a1a5137e6d0c5cadee7b21e82e8730fdf
Resolves: #56659
Releases: 6.2
Reviewed-on: https://review.typo3.org/28168
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Use prepared statements in generic persistence 26/27426/19
Felix Oertel [Tue, 4 Feb 2014 15:42:29 +0000 (16:42 +0100)]
[TASK] Use prepared statements in generic persistence

While Typo3DbBackend claims to be the glue between Extbase
and TYPO3, it hardly uses the TYPO3 DB API.

This patch enhances getObjectData- and getObjectCountByQuery
- the main methods used when dealing with domain models
through a repository - to use the TYPO3 DB API. In conjunction
this enables Extbase to use the preparedStatement introduced
in TYPO3 4.5.

Because prepared queries might not be desirable in all circum-
stances, they are disabled by default. They can be enable on
a per-query-basis via
  $query->getQuerySettings()->setUsePreparedStatement(TRUE);

Prepared statements will *only* be used for SELECT queries.

* consistent use of the TYPO3 DB API
  use exec_SELECTgetRows and exec_SELECTcountRows() even for
  non-prepared queries. This should help a lot along the way
  to support DBAL.

* preparedStatement in custom statements
  When using custom statements, it's now possible to use a pre-
  pared statement in $query->statement(), instead of a query-
  string. The prepared statement has to be initialized already
  though, because Extbase cannot take care of splitting your
  custom query string. The parameters are given as array in the
  second argument as usual.

* deprecated using parameters in non-prepared custom statement
  If a custom query string is used with $query->statement(),
  giving the parameters in the second argument is deprecated.

* get count working
  Counting - especially with limit and offset - has been broken
  for quite some time now. By refactoring the limit and offset
  parameters and adapting exec_SELECTcountRows() this should
  now work again.

The next step is to separate the query parsing from the backend
and introduce an intelligent query cache. This will work as a
drop-in-replacement. The @todo-annotations are intended to stay
there for the next patch.

Resolves: #55360
Releases: 6.2
Change-Id: I91a3fd69470df178a8a5465511e50766b50d7f52
Reviewed-on: https://review.typo3.org/27426
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[CLEANUP] ClassLoader 79/28279/7
Markus Klein [Wed, 12 Mar 2014 12:52:20 +0000 (13:52 +0100)]
[CLEANUP] ClassLoader

Add methods to better structure class information loading/creation.
This is necessary as the follow up patches will need this code
more often.

Resolves: #56797
Releases: 6.2
Change-Id: I1f15fbd262036b6b2d0159cd0e9613ad7135a296
Reviewed-on: https://review.typo3.org/28279
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Sebastian Fischer
Reviewed-by: Patrick Broens
Tested-by: Patrick Broens
5 years ago[TASK] Enable info icon for inline fileReference elements 91/28291/2
Frans Saris [Wed, 12 Mar 2014 11:22:52 +0000 (12:22 +0100)]
[TASK] Enable info icon for inline fileReference elements

The editor has no way to find the origin of the shown files when
you add file to a content element for instance.

This patch changes the default settings of
ExtensionManagementUtility::getFileFieldTCAConfig() so
the info icon is shown.

Resolves: #56804
Releases: 6.2
Change-Id: I00752e73f891285525a7aae1a9c5caddfacc13d4
Reviewed-on: https://review.typo3.org/28291
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Outside storages can never be marked as public 24/28224/3
Fabien Udriot [Mon, 10 Mar 2014 14:23:50 +0000 (15:23 +0100)]
[BUGFIX] Outside storages can never be marked as public

There are some edge cases where "is_public"
can never be true within a storage record in the BE,
for instance for storage located outside
the document root or for storage driven by special driver
such as Flickr, ...

Change-Id: Id7ce8006f182c98d7a908c2e6c49e0c66a7c9da4
Releases: 6.2
Resolves: #56730
Reviewed-on: https://review.typo3.org/28224
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Reduce record data in functional test failure message 85/28285/2
Oliver Hader [Mon, 10 Mar 2014 19:14:10 +0000 (20:14 +0100)]
[TASK] Reduce record data in functional test failure message

If records are found in a database table that are not part of
the assertion data-set, currently the whole record array from
the database is shown as failure.
The assertion has information about the fields that should have
been asserted. To keep a better overview, the failure message
is reduced now to exactly those fields.

Resolves: #56803
Releases: 6.2
Change-Id: Ib8f2afd0d464e8a4b850929277508770ff56eb91
Reviewed-on: https://review.typo3.org/28285
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Remove functional workspaces DataHandlerTest 88/28288/2
Oliver Hader [Wed, 12 Mar 2014 10:35:40 +0000 (11:35 +0100)]
[TASK] Remove functional workspaces DataHandlerTest

DataHandling::canChangeTtContentInTheWorkspace() is now covered
by DataHandling\Regular\Modify\ActionTest::modifyContent() with
additional assertions. The mentioned test class can be removed.

Resolves: #56805
Releases: 6.2
Change-Id: I968c593f50cd7453db87e1c4fe9e0478cf045381
Reviewed-on: https://review.typo3.org/28288
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Only valid package names will be processed. 86/28286/3
Daniel Siepmann [Wed, 12 Mar 2014 10:00:34 +0000 (11:00 +0100)]
[BUGFIX] Only valid package names will be processed.

To prevent the extension manager from further steps while
invalid package keys exists in the system, the package keys are
validated earlier.

This prevents further actions that will lead to rewrite
of PackageState.php and invalid opcode cache.

Change-Id: Ib8d9f25dc1d6c97b94a59b15255b96d5a1960093
Resolves: #56532
Releases: 6.2
Reviewed-on: https://review.typo3.org/28286
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Split functional workspaces DataHandling test execution 89/28289/2
Oliver Hader [Wed, 12 Mar 2014 10:42:38 +0000 (11:42 +0100)]
[BUGFIX] Split functional workspaces DataHandling test execution

Travis-CI stops after 10 minutes of not having received any data,
unfortunately it seems that the execution of the whole bunch of
functional workspaces tests takes longer,
see https://travis-ci.org/TYPO3/TYPO3.CMS/jobs/20590551

The "solution" is to explicitly split up these tests for
parallel execution in Travis-CI.

Resolves: #56806
Releases: 6.2
Change-Id: Ib5e67e6793adb9d7896ce89872ccfa080ca849bd
Reviewed-on: https://review.typo3.org/28289
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Text changes in the Install Tool 87/28287/3
Cynthia Mattingly [Wed, 12 Mar 2014 09:07:38 +0000 (10:07 +0100)]
[TASK] Text changes in the Install Tool

Fix many small grammar and typo issues. Rewrite some larger
portions of text to be more clear to the user. These
rewrites are listed in the issue tracker.

Resolves: #56754
Related: #51965
Releases: 6.2
Change-Id: I72f3ccbbeb815d93e904154b5da0ad48213ed63c
Reviewed-on: https://review.typo3.org/28287
Reviewed-by: Sebastian Fischer
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Adapt ShowPic popup to use FAL 52/28252/6
Steffen Ritter [Tue, 11 Mar 2014 13:07:00 +0000 (14:07 +0100)]
[BUGFIX] Adapt ShowPic popup to use FAL

If not using own Lightboxes TYPO3 ships a custom solution
of an image-enlarge popup. This combines an eID for rendering
the image as well as a short JavaScript snippet opening that
in a new window.

The php code for rendering that link as well as the popup code
itself are not fal aware and to image-processing on their own.
As a result this feature is only able to deal with files in local
file system.

This change refactors both imageLinkWrap as well as
ShowImageController to use and work on FAL objects.

Releases: 6.2
Resolves: #56723
Change-Id: Iebf1379b8f72cf57d69a06b0b7540cbd8ccb32c1
Reviewed-on: https://review.typo3.org/28252
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Remove baseUri from the Storage 71/28271/4
Fabien Udriot [Tue, 11 Mar 2014 19:17:17 +0000 (20:17 +0100)]
[BUGFIX] Remove baseUri from the Storage

The baseUri in the Storage has a Getter and is the
only thing initialized in the "processConfiguration"
method of a Storage. Due to the fact that "baseUri"
is not a field in the storage-table this never could
be set, and therefore always has been null.

It appears that this has been a left over from earlier
days and it is save to remove this, since the getter
always returned NULL (and as a result was unusable).
In addition the processConfiguration and its signals
are removed as they have and never had an effect anyhow.

Change-Id: I3416ee393a1eb3d0f1ea5fc588a351bb1555cdba
Releases: 6.2
Resolves: #56783
Reviewed-on: https://review.typo3.org/28271
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Language labels taken from wrong language file 55/28255/7
Patrick Broens [Tue, 11 Mar 2014 13:58:46 +0000 (14:58 +0100)]
[BUGFIX] Language labels taken from wrong language file

The module "Pagetree overview" in Web > Info is showing an empty
selectbox because the language labels for this dropdown are called from
the wrong language file.

This patch changes the calls to the language labels

Change-Id: I791598933704752fd6d5ed0d987f43bde1811452
Resolves: #56762
Releases: 6.2
Reviewed-on: https://review.typo3.org/28255
Reviewed-by: Sebastian Müller
Tested-by: Sebastian Müller
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Different button behaviour Page module views 19/28219/3
Patrick Broens [Mon, 10 Mar 2014 12:40:22 +0000 (13:40 +0100)]
[BUGFIX] Different button behaviour Page module views

In the Page module the button behaviour for adding new content elements
"Add a new record at this place" is different in the "columns" and
"languages" view.

The columns view shows the all buttons in a column when hovering over this
column, the languages view will show one button when hovering over this
hidden button. A backend user needs to know where the button is.

The languages view should have the same behaviour as the columns view.

Change-Id: Ia1b98de5b8622c7586bd03e7769ba4aa39121e38
Resolves: #56722
Releases: 6.2, 6.1
Related: #56720
Reviewed-on: https://review.typo3.org/28219
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Add functional tests for TCA types select and group/db 23/27823/7
Oliver Hader [Mon, 24 Feb 2014 23:22:43 +0000 (00:22 +0100)]
[TASK] Add functional tests for TCA types select and group/db

The tests for TCA types 'select' and 'group' include for each
* Modify in live
* Modify in workspace
* Publish in workspace
* PublihAll in workspace

Resolves: #56707
Releases: 6.2
Change-Id: I4bd8584f01122d0c4a974618d00e126b91270589
Reviewed-on: https://review.typo3.org/27823
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Typecast cookie value to string 81/28281/2
Georg Ringer [Wed, 12 Mar 2014 06:28:41 +0000 (07:28 +0100)]
[BUGFIX] Typecast cookie value to string

The cookie might be null, therefore the INSERTquery fails in
indexed_search.

As a solution, use a type cast to string.

Change-Id: If9e650ee713c75420859813546d138000b3023ff
Resolves: #55989
Releases: 6.2
Reviewed-on: https://review.typo3.org/28281
Reviewed-by: Christian Kuhn
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Index on sys_file_processedfile is too large 72/28272/3
Ernesto Baschny [Tue, 11 Mar 2014 19:31:32 +0000 (20:31 +0100)]
[BUGFIX] Index on sys_file_processedfile is too large

Resolves: #56786
Related: #54234
Releases: 6.2
Change-Id: I9c91f3e989e65df559542135d0b84025dacbbaf2
Reviewed-on: https://review.typo3.org/28272
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Add Publish and PublishAll DataHandler workspaces tests 36/28236/4
Oliver Hader [Tue, 11 Mar 2014 19:46:27 +0000 (20:46 +0100)]
[TASK] Add Publish and PublishAll DataHandler workspaces tests

Extend current functional action tests with those actions:
* modification (Modify)
* publish single records (Publish)
* publish all records in a workspace (PublishAll)

The Publish and PublishAll tasks extend the accordant basic
Modify functional tests.

Resolves: #56708
Related: #56710
Releases: 6.2
Change-Id: I1f7a70df39585c29b3b4ff5675b5147610f254f2
Reviewed-on: https://review.typo3.org/28236
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Update ADOdb to 5.18 53/28253/5
Andreas Fernandez [Tue, 11 Mar 2014 13:33:19 +0000 (14:33 +0100)]
[TASK] Update ADOdb to 5.18

Update ADOdb to current version 5.18 which fixes various bugs
and adds PHP 5.4 compatibility.

Resolves: #56761
Releases: 6.2
Change-Id: I5d46f52f8beb2407a40a3ee5796b00229b79992f
Reviewed-on: https://review.typo3.org/28253
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Add possibility to assert error log entries 86/27886/3
Oliver Hader [Thu, 27 Feb 2014 09:51:23 +0000 (10:51 +0100)]
[TASK] Add possibility to assert error log entries

During the action tests it might happen, that errors occur.
To assert expected or unexpected error log entries in the
sys_log table, this functionality shall be added to the
functional testing framework.

Resolves: #56369
Releases: 6.2
Change-Id: I07806e69cb7f575c844a3adf442233a82fa01505
Reviewed-on: https://review.typo3.org/27886
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Use clean DataHandler for each functional test action 22/28222/3
Oliver Hader [Mon, 10 Mar 2014 13:53:12 +0000 (14:53 +0100)]
[BUGFIX] Use clean DataHandler for each functional test action

Currently the DataHandler is reused in functional tests which
leads to unexpected behaviour for copied/deleted records. The
regular use case in the backend is to use a new DataHandler
instance for each HTTP request.

Resolves: #56729
Releases: 6.2
Change-Id: Iea685f58625e6ef611d543e375a8c24c1595008d
Reviewed-on: https://review.typo3.org/28222
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Tests: Incomplete mocking in ext:frontend 74/28274/2
Christian Kuhn [Tue, 11 Mar 2014 20:21:42 +0000 (21:21 +0100)]
[BUGFIX] Tests: Incomplete mocking in ext:frontend

Improve the fluid standalone tests by not calling __construct() of
a dependency.
Additionally, renderWorksWithNestedFluidtemplate() not only tests
the standalone view, but also its connection to the content object
renderer, so this is more a functional than a unit test. The test
is streamlined and moved to the functional test suite.

Change-Id: I3ae357de4861395622bc6f70aeed6011c7760cde
Resolves: #56788
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28274
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Incomplete mocking in ext:beuser 75/28275/2
Christian Kuhn [Tue, 11 Mar 2014 20:37:41 +0000 (21:37 +0100)]
[BUGFIX] Tests: Incomplete mocking in ext:beuser

The module data storage test subject calls several static
dependencies that can not be mocked without code refactoring. Those
dependencies do database stuff in the end, so DB needs to be properly
mocked for this test.

Change-Id: Id882b3a3a785940b5499c9afeff67f193c480e3b
Resolves: #56791
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28275
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Alignment of button "add a new element at this place" 17/28217/2
Patrick Broens [Mon, 10 Mar 2014 12:19:49 +0000 (13:19 +0100)]
[BUGFIX] Alignment of button "add a new element at this place"

In the page module using the "Languages" view, the buttons "add a new
element at this place" are wrongly aligned.

This patch fixes this issue by adding a div which controls this alignment
by CSS

Change-Id: I9de8a47368682ed0b33c2ebfa0a590402c1ca8ef
Resolves: #56720
Releases: 6.1, 6.2
Reviewed-on: https://review.typo3.org/28217
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mocking in ext:scheduler 73/28273/2
Christian Kuhn [Tue, 11 Mar 2014 19:47:34 +0000 (20:47 +0100)]
[BUGFIX] Tests: Incomplete mocking in ext:scheduler

Use getMock() instead of new() to create the test subject in order to
suppress execution of __construct() of parent AbstractTask.

Change-Id: Id0c297b845db7064b15a859eefa71830ab12074d
Resolves: #56787
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28273
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] FollowUp to #56660 70/28270/2
Steffen Ritter [Tue, 11 Mar 2014 19:09:18 +0000 (20:09 +0100)]
[BUGFIX] FollowUp to #56660

Fixes the unit-test according to the changes in review
https://review.typo3.org/#/c/28195/.

Since the BasePath (and therefore vfs://...) cannot be
handover anymore on initialize() it has to be injected
via _set().

Releases: 6.2
Resolves: #56660
Change-Id: I88d03f0305ff08810d6fea82c5c891b1a7a99771
Reviewed-on: https://review.typo3.org/28270
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Styling and placement of Toggle All button install tool 43/28243/2
Patrick Broens [Tue, 11 Mar 2014 08:45:54 +0000 (09:45 +0100)]
[TASK] Styling and placement of Toggle All button install tool

The "Toggle All" button in the install tool is currently clickable plain
text, which should be a button. It also needs to move to the fixed footer,
so it's always accessible.

This patch changes the plain text to a button and moves the button to the
fixed footer

Change-Id: I25a57e7a7f0f25fe2fe204f68fe2ee4dbbf1ade0
Resolves: #55469
Releases: 6.2
Reviewed-on: https://review.typo3.org/28243
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] PackageManager initialize() signature is incompatible 95/28195/7
Wouter Wolters [Sun, 9 Mar 2014 15:22:23 +0000 (16:22 +0100)]
[BUGFIX] PackageManager initialize() signature is incompatible

PackageManagerInterface contains following method declaration:

 public function initialize(\TYPO3\Flow\Core\Bootstrap $bootstrap);

however in the PackageManager the signature is:

  public function initialize(\TYPO3\Flow\Core\Bootstrap $bootstrap,
    $packagesBasePath = FLOW_PATH_PACKAGES,
    $packageStatesPathAndFilename = '')

This will create a fatal error on some versions of php and when running
unit tests on hhvm (of CMS), see
http://php.net/manual/en/language.oop5.interfaces.php

"The class implementing the interface must use the exact same method
signatures as are defined in the interface. Not doing so will result
in a fatal error."

This change updates the method signature of the PackageManager to be in
line with the interface.

Resolves: #56660
Related: #56409
Releases: 6.2
Change-Id: Iab7ae0d6d9809abe7cb6f9b73adb77f06d2f0820
Reviewed-on: https://review.typo3.org/28195
Reviewed-by: Thomas Maroschik
Reviewed-by: Sebastian Müller
Reviewed-by: Sebastian Fischer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove wrong storage->isPublic() check in localFolderTree 72/27772/3
Frans Saris [Fri, 21 Feb 2014 12:47:45 +0000 (13:47 +0100)]
[BUGFIX] Remove wrong storage->isPublic() check in localFolderTree

In localFolderTree->ext_isLinkable() is a check for storage->isPublic()
but the isPublic flag has nothing to do with the fact if links
to the files can be created.

This change removes this check.

Resolves: #56183
Releases: 6.2
Change-Id: Ia0e264b46259c0bd284a789a4eab48cf9a9e3b14
Reviewed-on: https://review.typo3.org/27772
Reviewed-by: Wouter Wolters
Reviewed-by: Sebastian Fischer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] DatabaseConnection must be initialized 54/28254/3
Xavier Perseguers [Tue, 11 Mar 2014 13:45:11 +0000 (14:45 +0100)]
[BUGFIX] DatabaseConnection must be initialized

The install tool forgets to initialize the database connection.

Change-Id: Ib7355e4f931c7152a6d13df99ed550c1b61eacf9
Fixes: #56763
Releases: 6.2
Reviewed-on: https://review.typo3.org/28254
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] DBAL: Incomplete database configuration 45/28045/6
Xavier Perseguers [Tue, 11 Mar 2014 15:08:26 +0000 (16:08 +0100)]
[BUGFIX] DBAL: Incomplete database configuration

When no database connection is established, handler_init() is used. But
at this point, the credentials are unkown and the method returns void.

As all parameters of method sql_pconnect() are deprecated, move the
_DEFAULT initialization into method handler_init() to get credentials
into the DBAL configuration.

Resolves: #56257
Releases: 6.2
Change-Id: Ifd908fab1382434d376a9358d0ae9c3af083616e
Reviewed-on: https://review.typo3.org/28045
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Inconsistent visual appearance Install Tool 25/28225/5
Patrick Broens [Mon, 10 Mar 2014 14:41:01 +0000 (15:41 +0100)]
[BUGFIX] Inconsistent visual appearance Install Tool

The install tool function System Environment is not according to the
style sheet of the install tool. This is due to the fact phpinfo() is
called on this page which comes with its own CSS styles. These styles
are influencing the visual appearence of the rest of the page.

This patch adds a new utility class to cleanup the output of phpinfo()
before assigning it to the view. It also comes with our own CSS for
phpinfo().

Change-Id: Ib0b087cae4bf5db723b0e9c3481619c984ef674f
Resolves: #55116
Releases: 6.2
Reviewed-on: https://review.typo3.org/28225
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Add api tag to ElementBrowser::setRecordList() 37/28237/4
Alexander Stehlik [Tue, 11 Mar 2014 06:09:41 +0000 (07:09 +0100)]
[TASK] Add api tag to ElementBrowser::setRecordList()

This method was introduced in TYPO3 6.2 with the purpose to be used
by Extensions. Therefore the @deprecated tag is replaced with an
@api tag.

Resolves: #56742
Releases: 6.2
Change-Id: Ia48a8c6997c26318a6fea50af32cd73f1138bb2b
Reviewed-on: https://review.typo3.org/28237
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix alignment for button "copy default content elements" 14/28214/2
Patrick Broens [Mon, 10 Mar 2014 10:44:05 +0000 (11:44 +0100)]
[BUGFIX] Fix alignment for button "copy default content elements"

In the page module in the "languages" view, the alignment of the button
"copy default content elements" is off. The button needs some padding on
the left side.

This patch fixes this by adding a div which gets the padding. It also
replaces the br's in front of this button with CSS for spacing.

Change-Id: Ic21097e8db078f2a2612c89d9496bf20fa5c0585
Resolves: #56636
Releases: 6.2
Reviewed-on: https://review.typo3.org/28214
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Create new processor registry 58/27958/9
Frans Saris [Fri, 28 Feb 2014 22:34:57 +0000 (23:34 +0100)]
[TASK] Create new processor registry

File processing might be different for external storages.
Therefore it must be possible to register your own File Processors
and make the registry driver aware.

Resolves: #56775
Releases: 6.2
Change-Id: I187f6f987f7b0bc92989ed38cbef248449a7f59f
Reviewed-on: https://review.typo3.org/27958
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Add FAL support for import in sys extension impexp 36/27836/8
Marc Bastian Heinrichs [Fri, 21 Feb 2014 15:31:05 +0000 (16:31 +0100)]
[TASK] Add FAL support for import in sys extension impexp

Until now only files from TCA type group internal_type file or
file_reference could be imported and exports from version 6.x
including sys_file records leads to exceptions on importing.
The patch adds support for handling record types introduced
with the File Abstraction Layer.

Resolves: #55532
Resolves: #55528
Resolves: #55906
Releases: 6.2
Change-Id: I7521c84094b0a0424e13c5f91c26b630bbbccbfe
Reviewed-on: https://review.typo3.org/27836
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] PHP Runtime Notice in saltedpasswords 61/28261/2
Xavier Perseguers [Tue, 11 Mar 2014 15:23:11 +0000 (16:23 +0100)]
[BUGFIX] PHP Runtime Notice in saltedpasswords

Declaration of method compareUident() should be compatible with its
parent class.

Change-Id: I66979bd76b204bbb762c41037cdaae5f006debb5
Fixes: #56769
Releases: 6.2
Reviewed-on: https://review.typo3.org/28261
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Layout category tree is broken 50/28250/2
Patrick Broens [Tue, 11 Mar 2014 10:43:02 +0000 (11:43 +0100)]
[BUGFIX] Layout category tree is broken

There are several issues with the layout of the category tree.

When hovering the whole element, the categories (text) get underlined.
The categories text is not aligned properly with the icon and checkbox.
The glow on a checkbox with focus is bigger than the checkbox itself.

This patch fixes these issues by adding CSS for the tree when used in
TCEforms.

Change-Id: Id9faaf906c786a95246d12f15821372648fc44b6
Resolves: #56752
Releases: 6.2
Reviewed-on: https://review.typo3.org/28250
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[FEATURE] Allow Storages outside the webroot 60/27760/11
Steffen Ritter [Thu, 20 Feb 2014 17:26:20 +0000 (18:26 +0100)]
[FEATURE] Allow Storages outside the webroot

Storages can be marked as not public or be outside of webroot.
There are no direct links to the files posible.

This change adds a eID implementation to create urls to these files.
It also implements a hook in het eID dispatcher that makes is possible
to add custom security/access checks when delivering files.

Releases: 6.2
Resolves: #36420
Change-Id: Ie7fc9c8a674a3200ea2b29d1adc17327d10bd6e5
Reviewed-on: https://review.typo3.org/27760
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Wrong note in ResourceFactory 23/28223/3
Frans Saris [Mon, 10 Mar 2014 14:23:52 +0000 (15:23 +0100)]
[BUGFIX] Wrong note in ResourceFactory

A note in the phpdoc header of ResourceFactory states it is a
lowlevel API. But this is wrong as at least since 6.2 this is
the public API and therefor this note is removed.

Resolves: #56731
Releases: 6.2
Change-Id: I90ed0dafa12656efe6d037abebee7b92de54a6f7
Reviewed-on: https://review.typo3.org/28223
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Flash messages are not shown with AJAX requests 00/28200/4
Xavier Perseguers [Sun, 9 Mar 2014 16:56:21 +0000 (17:56 +0100)]
[BUGFIX] Flash messages are not shown with AJAX requests

Due to the use of DragUploader to upload files, flash messages
are not shown immediately but after manually reloading the page.

Change-Id: Ia2e8750792bd04209b5a1f2ce0e2a63f970ba3a8
Fixes: #56561
Releases: 6.2
Reviewed-on: https://review.typo3.org/28200
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Return ProcessedFile instead of File if possible 53/27753/9
Steffen Ritter [Thu, 20 Feb 2014 12:16:55 +0000 (13:16 +0100)]
[TASK] Return ProcessedFile instead of File if possible

You can query the FAL-API for files by their filename. If the file resides
in the processing-folder of a storage it is a valid file to the storage.
Therefore creating a file-object and indexing it would be a valid thing.

Since this is not intended additionally to the storage the ResourceFactory
must know about that, too. This change implements this awareness, so there
is no way to create a FileObject for files which reside within the
processing folder.
In 6.0 and 6.1 there has been a dirty workaround for that by marking those
files as not indexable which was removed silently when introducing the new
indexer.

Releases: 6.2
Resolves: #54234
Change-Id: I274c47717560a6efc175fa94aacc4770a578fd3f
Reviewed-on: https://review.typo3.org/27753
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Missing argument in ReferenceIntegrity updater 33/28233/2
Eric Chavaillaz [Mon, 10 Mar 2014 16:55:35 +0000 (17:55 +0100)]
[BUGFIX] Missing argument in ReferenceIntegrity updater

When trying to use the upgrade wizards, a fatal error
is thrown because the mandatory where_clause is missing
in a call to exec_SELECTquery.

Resolves: #56737
Releases: 6.2
Change-Id: I4814b9c2b0b30cea11e81bbf64d94ba8213a07cb
Reviewed-on: https://review.typo3.org/28233
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Multiple Set-Cookie headers for deleting FE cookie 27/28227/3
Nicole Cordes [Mon, 10 Mar 2014 15:21:29 +0000 (16:21 +0100)]
[BUGFIX] Multiple Set-Cookie headers for deleting FE cookie

In the current master every time when removeCookie is triggered a
Set-Cookie header is generated. A cookie should only be deleted if it
was set before. As removeCookie can handle different cookie names, the
check is performed before calling removeCookie function.

Resolves: #56733
Releases: 6.2
Change-Id: I518220ce2def8d9db901b1e8daa87de745317629
Reviewed-on: https://review.typo3.org/28227
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Oliver Klee
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Remove loadExtensionTables() from unit test bootstrap 35/28235/3
Christian Kuhn [Mon, 10 Mar 2014 18:01:19 +0000 (19:01 +0100)]
[TASK] Remove loadExtensionTables() from unit test bootstrap

With proper mocking in place, loadExtensionTables() can be
removed from unit test bootstrap.
This speeds up the test suite quite a bit since the huge
$GLOBALS['TCA'] is no longer initialized and gives backup code
of phpunit less headaches.

Change-Id: I9ac96047a49914f3c6ab7acc318bbc36488b6c5b
Resolves: #56739
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28235
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Improve mocking in IconUtilityTest 20/28220/2
Christian Kuhn [Mon, 10 Mar 2014 13:26:42 +0000 (14:26 +0100)]
[BUGFIX] Tests: Improve mocking in IconUtilityTest

The IconUtility tests depend on initialized $GLOBALS['TBE_STYLES']
and sometimes on initialized $GLOBALS['TCA']. This dependency is
removed by properly setting up needed arrays now, this also makes
the tests more obvious and easier to understand.
Additionally, the static cache property introduced with #56110 now
uses late static binding, enabling the tests to extend the class
and route any static cache changes to an test internal overlay
class to not pollute the static property of the base class.

Change-Id: I01166058da051a26d7aa2df315858468828ed346
Resolves: #56725
Related: #51436
Related: #56110
Releases: 6.2
Reviewed-on: https://review.typo3.org/28220
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Change notification level for missing opcode cache 16/28216/3
Sebastian Müller [Mon, 10 Mar 2014 11:22:10 +0000 (12:22 +0100)]
[BUGFIX] Change notification level for missing opcode cache

Now the notification level is set to notice instead of warning.
Therefore no email notification will be send if the user has not
set his cache or his cache has only medium performance

Resolves: #55392
Releases: 6.2
Change-Id: I90758ba658477a4b92f1a110228eb7950648ec39
Reviewed-on: https://review.typo3.org/28216
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Improve mocking in ext:belog 15/28215/2
Christian Kuhn [Mon, 10 Mar 2014 10:57:53 +0000 (11:57 +0100)]
[BUGFIX] Tests: Improve mocking in ext:belog

The subject method initialize() calls some static dependencies
that can not be mocked. They do DB actions in the end. The patch
now mocks TYPO3_DB to suppress this DB call.

Change-Id: I43b0e002bfab081ed41a5c259011f465b507a74b
Resolves: #56718
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28215
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Wrong IRC URL for Packagist 11/28211/2
Fabien Udriot [Mon, 10 Mar 2014 09:31:02 +0000 (10:31 +0100)]
[BUGFIX] Wrong IRC URL for Packagist

Packagist complains about current IRC URL format.

Change-Id: Id8abcad6525c06d6941144cd2e1e8ea372cc975a
Releases: 6.2
Resolves: #56713
Reviewed-on: https://review.typo3.org/28211
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[BUGFIX] Tests: Improve Mocking in ext:extbase 07/28207/3
Anja Leichsenring [Sun, 9 Mar 2014 23:39:10 +0000 (00:39 +0100)]
[BUGFIX] Tests: Improve Mocking in ext:extbase

Change-Id: I61f7f92da42d691b0556f1e53b20d39eb082c12f
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28207
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Improve TCA mocking in BackendUtility 06/28206/3
Christian Kuhn [Sun, 9 Mar 2014 23:20:17 +0000 (00:20 +0100)]
[BUGFIX] Tests: Improve TCA mocking in BackendUtility

ext:core BackendUtilityTest no longer depends on initialized TCA.

Change-Id: I5b97b86d57da15b6176dd3033ec8fda1f4209f85
Resolves: #56699
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28206
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:frontend 04/28204/2
Anja Leichsenring [Sun, 9 Mar 2014 22:28:24 +0000 (23:28 +0100)]
[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:frontend

To reduce dependencies of tests and improve readability, some tests
can be improved by better mocking of $GLOBALS['TCA'].

Change-Id: Ib38f2dd94288c5c4f8940d3c8c969ea0459ebbcb
Resolves: #56698
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28204
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:core 03/28203/2
Christian Kuhn [Sun, 9 Mar 2014 22:16:39 +0000 (23:16 +0100)]
[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:core

To reduce dependencies of tests and improve readability, some tests
can be improved by better mocking of $GLOBALS['TCA']

Change-Id: I7dee44b5a98f2384c2b77c51ebc678ff15669475
Resolves: #56696
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28203
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Added composer.json for the TYPO3 CMS project 23/27423/5
Christian Opitz [Fri, 7 Feb 2014 16:17:33 +0000 (17:17 +0100)]
[TASK] Added composer.json for the TYPO3 CMS project

Added a composer.json file that contains
* name, description, keywords, homepage and license
* authors (core team and community)
* several support addresses
* requirements (php, php extensions and the composer typo3 installer)
* suggestions for php extensions
* branch alias for current development version (6.2)
* the packages, that are provided (system extensions)

Resolves: #55770
Releases: 6.2
Change-Id: Ibb94787ee12f9e580dedb1652c444f35e51d1aa9
Reviewed-on: https://review.typo3.org/27423
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[TASK] Add missing logDeprecatedFunction() to getAliasForClassName() 72/27172/4
Stefan Neufeind [Sun, 9 Mar 2014 18:20:43 +0000 (19:20 +0100)]
[TASK] Add missing logDeprecatedFunction() to getAliasForClassName()

Function is already deprecated but didn't write to
deprecation-log so far.

Resolves: #55481
Releases: 6.2
Change-Id: I5b8150e7b2d7be8fdc87a3a4a93932a04cb2cb09
Reviewed-on: https://review.typo3.org/27172
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Tests: Simplify unit test bootstrap 99/28199/2
Christian Kuhn [Sun, 9 Mar 2014 16:00:31 +0000 (17:00 +0100)]
[TASK] Tests: Simplify unit test bootstrap

There is no need to initialize $GLOBALS['BE_USER'] anymore
in unit tests since mocking of this dependency is complete.

Change-Id: I21ab751d4b66ba2d9658becbd6e0fcd16d139c4b
Resolves: #56689
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28199
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Resolve incomplete mocking for sysext:fluid 98/28198/3
Anja Leichsenring [Sun, 9 Mar 2014 15:43:26 +0000 (16:43 +0100)]
[BUGFIX] Resolve incomplete mocking for sysext:fluid

Some Tests in sysext:backend rely on an existing BackendUserAuth object.
In order to decouple the tests from the TYPO3 Environment,
those are mocked now.

Change-Id: Ibfd9de2f5a7673eecca61c35e59852017edd2f0d
Resolves: #56688
Relates: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28198
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mocking in be_user 96/28196/2
Christian Kuhn [Sun, 9 Mar 2014 15:31:45 +0000 (16:31 +0100)]
[BUGFIX] Tests: Incomplete mocking in be_user

ModuleDataStorageServiceTest now mocks $GLOBALS['BE_USER']
to not rely on instantiation of this global.

Change-Id: I5ab6b962d95f2ab183dfc1b1b53dea7deaa464c5
Resolves: #56687
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28196
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Resolve incomplete mocking for sysext:backend 93/28193/4
Anja Leichsenring [Sun, 9 Mar 2014 15:07:18 +0000 (16:07 +0100)]
[BUGFIX] Resolve incomplete mocking for sysext:backend

Some Tests in sysext:backend rely on an existing BackendUserAuth object.
In order to decouple the tests from the TYPO3 Environment,
those are mocked now.

Change-Id: I2760f301aeb79e963a87f02258df04306a68cec6
Resolves: #56686
Relates: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28193
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mock in ResourceFactoryTest 92/28192/3
Christian Kuhn [Sun, 9 Mar 2014 15:03:32 +0000 (16:03 +0100)]
[BUGFIX] Tests: Incomplete mock in ResourceFactoryTest

FAL ResourceFactoryTest retrieveFileOrFolderObject* not only
tests the method but also lots of not mocked dependencies. The
tests are renamed and changed to stick to test the subject only.

Resolves: #56684
Related: #51436
Releases: 6.2
Change-Id: If247e923b8e79995279ad48bdc35f5b8976bfd57
Reviewed-on: https://review.typo3.org/28192
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Reduce unit test bootstrap 90/28190/2
Christian Kuhn [Sun, 9 Mar 2014 13:13:02 +0000 (14:13 +0100)]
[TASK] Reduce unit test bootstrap

With the removal of $GLOBALS['FILEMOUNTS'] the unit test no longer
depend on initialization of backend user mounts. Remove this
bootstrap line.

Change-Id: Ie9860dd7b15a4baff330c8e3cad16d3ae3092e75
Resolves: #56681
Related: #55547
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28190
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Introduce failsafe view in install tool 67/27067/11
Helmut Hummel [Thu, 6 Mar 2014 08:40:41 +0000 (09:40 +0100)]
[BUGFIX] Introduce failsafe view in install tool

The installer does not work, if doc comment reflection
is broken, so we need to make the first install step
more robust by using inject methods and introducing
a failsafe view which does simple php templating
in case critical errors (like doc comments disabled)
occur.

Resolves: #55352
Releases: 6.2
Change-Id: I424d6a290b65ae023ec19a745477cfaecdef72c7
Reviewed-on: https://review.typo3.org/27067
Tested-by: Alexander Opitz
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] ResourceStorage::SIGNAL_PreFileAdd should be triggered earlier 99/28099/4
Xavier Perseguers [Thu, 6 Mar 2014 10:43:16 +0000 (11:43 +0100)]
[BUGFIX] ResourceStorage::SIGNAL_PreFileAdd should be triggered earlier

The PreFileAdd signal should be triggered before the file exist check.
So the name and/or content can be manipulated before the target filename
is checked.

Change-Id: I0bbe32a4efa395a99278c480210310bd7466f259
Fixes: #56394
Releases: 6.2
Reviewed-on: https://review.typo3.org/28099
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Wrong file icon in info popup 19/27819/4
Frans Saris [Mon, 24 Feb 2014 20:55:40 +0000 (21:55 +0100)]
[BUGFIX] Wrong file icon in info popup

In the info popup of a file/folder the wrong icon is shown.

This patch changes it so IconUtility::getSpriteIconForResource()
is used and moves the rendering of the header to the
DocumentTemplate.

Resolves: #56251
Releases: 6.2
Change-Id: I7fc40af85b8bc623112bcec29c2409221a937718
Reviewed-on: https://review.typo3.org/27819
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Deprecate insertModuleFunction "$classPath" parameter 62/24462/9
Ernesto Baschny [Mon, 7 Oct 2013 16:45:32 +0000 (18:45 +0200)]
[TASK] Deprecate insertModuleFunction "$classPath" parameter

Deprecates the need to specify the $classPath when registering a submodule
with ExtensionManagementUtility::insertModuleFunction. Remove the
parameter's usage throughout the system extensions.

Also re-adds the removed include_once that were removed without proper
deprecation before (see #49992).

Resolves: #52594
Releases: 6.2
Change-Id: I090278b8e2e7a15e05b14dca757ae2b8ef1e5fb4
Reviewed-on: https://review.typo3.org/24462
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Unnatural processing order in IRRE tests 87/27887/4
Oliver Hader [Thu, 27 Feb 2014 11:18:18 +0000 (12:18 +0100)]
[BUGFIX] Unnatural processing order in IRRE tests

The IRRE tests for creating and modifying records first process
offer, hotel then content which is the unnatural order compared
to the processing delivered by the FormEngine (t3lib_TCEforms).
To avoid incorrect testing behaviour and invalid testing
results, the order is changed to content, hotel and offer
(parent to child).

Resolves: #56374
Releases: 6.2
Change-Id: Ib14fc2d50b493e4be982faeba77401b320868639
Reviewed-on: https://review.typo3.org/27887
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Install Tool does not save Extbase object cache Configuration 75/28175/3
Michiel Roos [Fri, 7 Mar 2014 20:57:59 +0000 (21:57 +0100)]
[BUGFIX] Install Tool does not save Extbase object cache Configuration

Change-Id: I1ee28a5af824b048863c61321a226bf7c9843f77
Resolves: #55556
Releases: 6.2
Reviewed-on: https://review.typo3.org/28175
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[FEATURE] TypoScript property escapeJsValue 77/28177/3
Jigal van Hemert [Sat, 8 Mar 2014 08:46:39 +0000 (09:46 +0100)]
[FEATURE] TypoScript property escapeJsValue

The stdWrap property escapeJsValue allows content to be
included in JavaScript strings.

Resolves: #56642
Documentation: #56665
Releases: 6.2
Change-Id: I43f59889caec1a89970b94c93c93894d589243c9
Reviewed-on: https://review.typo3.org/28177
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Improve AbstractDataHandlerActionTestCase 16/27816/6
Marc Bastian Heinrichs [Mon, 24 Feb 2014 15:21:33 +0000 (16:21 +0100)]
[TASK] Improve AbstractDataHandlerActionTestCase

Improvements for the AbstractDataHandlerActionTestCase to
get better functional test results in general and working
functional tests in impexp (e.g. for FlexForm XML):

* collect all fail messages before calling fail()
* check records for left rows that was not assigned in csv
* do strict compare if value is NULL
* compare XML, e.g. FlexForm

Resolves: #56241
Releases: 6.2
Change-Id: Ic21c27261cbe18dc5fd37c4869c10264880b731e
Reviewed-on: https://review.typo3.org/27816
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] Cleanup jumpToUrl() and unused JS in Backend 80/28180/4
Benjamin Mack [Sat, 8 Mar 2014 10:43:06 +0000 (11:43 +0100)]
[CLEANUP] Cleanup jumpToUrl() and unused JS in Backend

The jumpToUrl() is defined in every
second module as inline JS. As the
duplicated code is erroneous and
can be shimmed completely, the
function is added to every doc-template
code by default, but can be overriden and
removed completely - which is still the case
in some existing modules.

Additionally the variable "script_ended"
is not used at all anymore, and was removed
as well.

Releases: 6.2
Resolves: #56667
Change-Id: I716611bffce402c5f423c3d64c763d6675a79d14
Reviewed-on: https://review.typo3.org/28180
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Make Import/Export work with Package Manager 83/28183/4
Benjamin Mack [Sat, 8 Mar 2014 11:29:56 +0000 (12:29 +0100)]
[BUGFIX] Make Import/Export work with Package Manager

When displaying the import/export backend module
there are warnings and an empty extension list,
because the extension Selector does not use the
API to fetch the extension list, but does a raw
$TYPO3_LOADED_EXT instead.

Resolves: #56670
Releases: 6.2
Change-Id: I851cc1f7e01acd9f743559a9400340364280ba7e
Reviewed-on: https://review.typo3.org/28183
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Use function for temp. page tree in BrowseLinks too 79/28179/2
Markus Klein [Sat, 8 Mar 2014 10:38:29 +0000 (11:38 +0100)]
[TASK] Use function for temp. page tree in BrowseLinks too

The new introduced function ElementBrowser::getTemporaryTreeMountCancelNotice()
shall also be used in its subclass to remove code duplication.

Resolves: #56666
Releases: 6.2
Change-Id: I0d7aca1c0695479f7ced9323098c0e7b04f1abda
Reviewed-on: https://review.typo3.org/28179
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Extension upload as zip on Windows systems ignores directories 11/26911/2
Wouter Wolters [Fri, 17 Jan 2014 20:13:58 +0000 (21:13 +0100)]
[BUGFIX] Extension upload as zip on Windows systems ignores directories

Using DIRECTORY_SEPARATOR on Windows environments is a "\" instead of
a "/". Fix this by replacing the constant with '/'.

Resolves: #53740
Resolves: #53346
Releases: 6.2
Change-Id: Ia745a17fd47c527b57e78babef76b67f30af0454
Reviewed-on: https://review.typo3.org/26911
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Temporary DB tree mount notice missing in ElementBrowser 01/17101/12
Lorenz Ulrich [Tue, 11 Dec 2012 14:57:18 +0000 (15:57 +0100)]
[BUGFIX] Temporary DB tree mount notice missing in ElementBrowser

If "Stop Page Tree" is set for a page, it is possible to set temporary
DB tree mounts in the element browser/link browser.
If such a tree mount is set, a notice is displayed right above the tree.

This notice is necessary to cancel this temporary mount.
Currently the ElementBrowser misses this notice when used
for e.g. header_link.

Change-Id: I942aad0e54d17ceb793008850f0563bb416503be
Fixes: #43885
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/17101
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove deprecated doDisplayTopFrameCM 20/28120/2
Wouter Wolters [Thu, 6 Mar 2014 20:38:29 +0000 (21:38 +0100)]
[TASK] Remove deprecated doDisplayTopFrameCM

Resolves: #56623
Releases: 6.2
Change-Id: Ib24adf0029f23053b1218340cb11b6390964fefd
Reviewed-on: https://review.typo3.org/28120
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[CLEANUP] Remove references to $GLOBALS['FILEMOUNTS'] 27/27227/6
Benjamin Mack [Sat, 1 Feb 2014 11:19:38 +0000 (12:19 +0100)]
[CLEANUP] Remove references to $GLOBALS['FILEMOUNTS']

Global filemounts are not supported with FAL anymore
as the implementation is done via file storages directly.
All references to the global FILEMOUNTS is removed as
it was an empty array since 6.0.

Next step (but not part of this patch) is to clean up the
functions in BasicFileUtility that make use of the filemounts.

Releases: 6.2
Resolves: #55547
Change-Id: I07e08afe54c174d1c3a67c41645819e5831fd1e3
Reviewed-on: https://review.typo3.org/27227
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove unused function BackendUtility::updatePagesTSconfig() 28/25228/4
Philipp Gampe [Sat, 9 Nov 2013 08:51:55 +0000 (09:51 +0100)]
[TASK] Remove unused function BackendUtility::updatePagesTSconfig()

The function is not used in the core and marked as @internal since the
beginning of the time (revision 1). Therefore it is removed directly.

Resolves: #53471
Releases: 6.2
Change-Id: Ib74fa65b24caa9879b16921e13e3d0bed894b712
Reviewed-on: https://review.typo3.org/25228
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix Misleading CommandController naming for Language update 11/24511/5
Cedric Ziel [Wed, 9 Oct 2013 23:12:14 +0000 (01:12 +0200)]
[BUGFIX] Fix Misleading CommandController naming for Language update

Due to CommandControllers' nature, an UpdateCommandController leads to the
execution of `cli_dispatch.phpsh extbase update:update`.

This patch fixes it to `cli_dispatch.phpsh extbase language:update`.

Also contains a minor change and adds a type-hint for IDE's.

Resolves: #54128
Releases: 6.2
Change-Id: I1b21b8f715bfd1928f1e857846c0542d90705b6f
Reviewed-on: https://review.typo3.org/24511
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Allow user update without password changes in sys_action 77/27377/4
Nicole Cordes [Thu, 6 Feb 2014 10:59:45 +0000 (11:59 +0100)]
[BUGFIX] Allow user update without password changes in sys_action

If you want to edit a user within the sys_action module, you have to
set a (new) password as otherwise the record won't be updated. This
patch allows an empty password field for updates while new users
still need a defined password.

Resolves: #25700
Releases: 6.2
Change-Id: I37c20a706b15ebce458033c4f5fe4016236ef1d8
Reviewed-on: https://review.typo3.org/27377
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Deprecate usage of $GLOBALS['typo3CacheManager'] 01/28101/7
Helmut Hummel [Thu, 6 Mar 2014 10:53:07 +0000 (11:53 +0100)]
[TASK] Deprecate usage of $GLOBALS['typo3CacheManager']

* Replace all instances of $GLOBALS['typo3CacheManager']
  in the core with a makeInstance call.
* Adapt the tests.
* Make use of dependency injection where possible.
* Add compatibility layer with deprecation message
  for $GLOBALS['typo3CacheManager'] and $GLOBALS['typo3CacheFactory']

Resolves: #56597
Releases: 6.2
Change-Id: Idb035723626b24cfd768204bf24987171f5b0feb
Reviewed-on: https://review.typo3.org/28101
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] Improve code style for FormEngine::getTSCpid() 67/28167/2
Alexander Stehlik [Fri, 7 Mar 2014 15:22:49 +0000 (16:22 +0100)]
[CLEANUP] Improve code style for FormEngine::getTSCpid()

The PHPDoc is fixed. The method returns an array and not an integer.

Additionally the class variable that is used in this method for
storing the cached values is added as a property.

Releases: 6.2
Resolves: #56658
Change-Id: I6010cf97781001cd760c891da3df3bfb7a605b73
Reviewed-on: https://review.typo3.org/28167
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] SoftReferenceIndex typolink lacks support for title attributes 83/28083/8
Marc Bastian Heinrichs [Wed, 5 Mar 2014 16:07:20 +0000 (17:07 +0100)]
[BUGFIX] SoftReferenceIndex typolink lacks support for title attributes

The SoftReferenceIndex parses and rebuilds typolink tags, but the
support for the title attributes was missing.
This leads to lost title attributes on typolinks in exports from impexp.

Resolves: #56580
Releases: 6.2, 6.1, 6.0, 4.5
Change-Id: I9bf5c02b79ae4c9024322f0da99dcca37b678daa
Reviewed-on: https://review.typo3.org/28083
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Warn about apc.enable_cli=0 on command line 35/28035/4
Christian Weiske [Tue, 4 Mar 2014 13:18:50 +0000 (14:18 +0100)]
[BUGFIX] Warn about apc.enable_cli=0 on command line

When running a CLI script via typo3/cli_dispatch.phpsh,
using the APC caching backend will lead to errors like
> TYPO3 Exception #1232986877: Could not set value.

This patch checks if TYPO3 is running on CLI, and validates the
apc.enable_cli setting to give a proper error message.

Change-Id: Icbeb619fc2054634274b492df94dbbc89958a8b6
Resolves: #25274
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/28035
Reviewed-by: Ernesto Baschny
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Refactor init() function of ElementBrowser 31/27631/10
Tymoteusz Motylewski [Fri, 14 Feb 2014 12:29:01 +0000 (13:29 +0100)]
[TASK] Refactor init() function of ElementBrowser

Splits huge method (~450 lines) into several small methods,
in the similar way it was done for BrowseLinks and SelectImage.

It also removes some duplicated code between these classes.
This patch is not changing functionality, just moving code around.

Resolves: #55983
Releases: 6.2
Change-Id: I916058485acb9d9abe0086785763edc721a360f0
Reviewed-on: https://review.typo3.org/27631
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] RTE on first new IRRE record keeps loading in IE 24/27624/2
Stanislas Rolland [Thu, 13 Feb 2014 21:20:49 +0000 (16:20 -0500)]
[BUGFIX] RTE on first new IRRE record keeps loading in IE

Problem: IE raises a syntax error when it encounters html comments in
the JavaScript code. The html comments are added by the page renderer.
Solution: There is no need for the page renderer to wrap inline
javascript as html comments.

Resolves: #55457
Releases: 6.2, 6.1
Change-Id: Iae180a73778ca3bb1c9934c887315b969888b10d
Reviewed-on: https://review.typo3.org/27624
Reviewed-by: Oliver Klee
Tested-by: Leon de Rijke
Tested-by: Simon Ouellet
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Default size for group-type fields 16/28116/4
Christian Plattner [Thu, 6 Mar 2014 17:09:34 +0000 (18:09 +0100)]
[BUGFIX] Default size for group-type fields

Missing size property on group-type fields causes various
problems, like missing controls (move to top and move to
bottom) or misbehaving JS. Adding a default size ensures
that a forgotten size property does not break everything.

Additionally the size property is added to the sys_collection
table, since all Core tables should be cleanly defined.

Resolves: #23552
Documentation: #56627
Releases: 6.1, 6.2
Change-Id: Idafb1912f9702fddf85b7c2c222f408419e50ecf
Reviewed-on: https://review.typo3.org/28116
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Add cache to IconUtility::getSpriteIcon() 13/27713/8
Michiel Roos [Wed, 19 Feb 2014 11:03:25 +0000 (12:03 +0100)]
[TASK] Add cache to IconUtility::getSpriteIcon()

Cache calls to getSpriteIcon() that only use the first parameter.

Change-Id: I63e7dbaf81473b733a73f4a964e419dae0650f5f
Resolves: #56110
Releases: 6.2
Reviewed-on: https://review.typo3.org/27713
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Consolidate regexp for utf8 and non-utf8 file systems 39/23439/13
Lucas Bremgartner [Thu, 14 Nov 2013 23:45:26 +0000 (00:45 +0100)]
[TASK] Consolidate regexp for utf8 and non-utf8 file systems

This patch enables the @ character to be usable now
also for non-utf8 file systems.

Resolves: #50538
Releases: 6.2, 6.1
Change-Id: I72ce24393003af8733af6fc650e69781df4a272c
Reviewed-on: https://review.typo3.org/23439
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[!!!][SECURITY] Remove old backend_layout wizard 21/28121/2
Wouter Wolters [Thu, 6 Mar 2014 20:44:02 +0000 (21:44 +0100)]
[!!!][SECURITY] Remove old backend_layout wizard

Keeping the old wizard script would not solve
the CSRF attack vector as they could still
be referenced in this kind of attack.

Because of that, we remove it now.

This change provides a backwards compatibility layer.

It will however break code which link to the
old scripts directly in other places.

Resolves: #56625
Releases: 6.2
Change-Id: I07577dca0e16cf095e114799ace4a6e344ad5aa3
Reviewed-on: https://review.typo3.org/28121
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] ExtendedFileUtility.php: func_delete 19/28019/2
Rico Sonntag [Tue, 4 Mar 2014 07:23:26 +0000 (08:23 +0100)]
[BUGFIX] ExtendedFileUtility.php: func_delete

This fixes an issue within method func_delete trying to catch a file
access exception instead of expected folder access exception during
delete of an folder.

Change-Id: Iaf76100cd668ef4b1a36a5d9052a6f185ffa6b7b
Resolves: #56511
Releases: 6.2
Reviewed-on: https://review.typo3.org/28019
Reviewed-by: Frans Saris
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] FAL readonly: Directory copying results in BE exception 94/27994/2
Rico Sonntag [Mon, 3 Mar 2014 13:51:55 +0000 (14:51 +0100)]
[BUGFIX] FAL readonly: Directory copying results in BE exception

Changed parent class of folder permission exceptions to
InsufficientFolderAccessPermissionsException so excecption
could be catched properly.

Change-Id: I1c85e4c0e4652f1e3394fd58f98d95ea6ca8cc34
Resolves: #56494
Releases: 6.2
Reviewed-on: https://review.typo3.org/27994
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] UnitTests create SQL error if openid is installed 90/28090/3
Philipp Gampe [Thu, 6 Mar 2014 02:07:16 +0000 (03:07 +0100)]
[BUGFIX] UnitTests create SQL error if openid is installed

AbstractUserAuthenticationTest is actually supposed to test
processLoginData from AuthenticationService from ext:sv.
However it fails to properly setup all auth parameters, therefore auth
services that depend on further settings fail.

This moves the test to the actually tested code (extension sv).
The test is adopted accordingly.

Additionally both tests are cleaned up from unneeded setUp/tearDown
functions.

Resolves: #56586
Releases: 6.2
Change-Id: I7406a56e5274ea54d400c1c116a8ea81c5cf4cea
Reviewed-on: https://review.typo3.org/28090
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters