Packages/TYPO3.CMS.git
3 years ago[TASK] Doctrine: migrate ext:backend/Backend/ToolbarItems 19/47719/4
Jan Helke [Fri, 15 Apr 2016 18:32:59 +0000 (20:32 +0200)]
[TASK] Doctrine: migrate ext:backend/Backend/ToolbarItems

Releases: master
Resolves: #75697
Change-Id: I9105289b14a3c2dba07275ff2690291c5cfba508
Reviewed-on: https://review.typo3.org/47719
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Peter Foerger <pfoerger@mac.com>
Tested-by: Peter Foerger <pfoerger@mac.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Doctrine: Migrate BackendUserAuthentication::getPagePermsClause 46/48446/2
Morton Jonuschat [Sat, 4 Jun 2016 09:10:40 +0000 (11:10 +0200)]
[TASK] Doctrine: Migrate BackendUserAuthentication::getPagePermsClause

Migrate the getPagePermsClause() method to Doctrine and add Tests.

Change-Id: Ib8ac3dd557ecd011f8a37c9f4a7f86a861ded4a9
Resolves: #75556
Releases: master
Reviewed-on: https://review.typo3.org/48446
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Doctrine: migrate tstemplate/TypoScriptTemplateModuleController 19/47819/5
Christoph Kratz [Wed, 20 Apr 2016 16:48:43 +0000 (18:48 +0200)]
[TASK] Doctrine: migrate tstemplate/TypoScriptTemplateModuleController

Resolves: #75824
Releases: master
Change-Id: Iae855b27058a366d0e4ee691d8cfd259ba66991e
Reviewed-on: https://review.typo3.org/47819
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Doctrine: migrate ext:backend/Controller/EditDocumentController 18/47818/9
Jonathan IROULIN [Wed, 20 Apr 2016 16:15:19 +0000 (18:15 +0200)]
[TASK] Doctrine: migrate ext:backend/Controller/EditDocumentController

In addition to switching the QueryBuilding to Doctrine the grouping
of retrieved in ``getLanguages()`` has been updated to be compatible
with MySQL ONLY_FULL_GROUP_BY mode by limiting the selected columns
and grouping the result by all of them.

Resolves: #75784
Releases: master
Change-Id: I1fdac9ba736d93df257e117abc5f0960d69ab7c6
Reviewed-on: https://review.typo3.org/47818
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Doctrine: migrate EXT:viewpage 80/47880/6
Michael Oehlhof [Sat, 23 Apr 2016 22:42:32 +0000 (00:42 +0200)]
[TASK] Doctrine: migrate EXT:viewpage

Resolves: #75889
Releases: master
Change-Id: Ib781df6abfa77813d6d12107820d401f72859539
Reviewed-on: https://review.typo3.org/47880
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Render the creator of a record in ElementInformationController 56/48456/2
Georg Ringer [Mon, 6 Jun 2016 08:05:03 +0000 (10:05 +0200)]
[BUGFIX] Render the creator of a record in ElementInformationController

The ElementInformationController must show the creator user and not
the current one.

Resolves: #76461
Releases: master, 7.6
Change-Id: Ibeae9970783aa6d0fc3b0e190956140c872a9ac9
Reviewed-on: https://review.typo3.org/48456
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Fix password evaluation for TCA input field 52/48452/3
mtoscanelli [Sun, 5 Jun 2016 09:34:58 +0000 (11:34 +0200)]
[BUGFIX] Fix password evaluation for TCA input field

Password evaluation is only used for display purpose.

Skip password evaluation value processing.
Set the correct value in main and human readable fields.

Resolves: #76456
Releases: master, 7.6
Change-Id: I58d1e2b9922ee21b7ccacb83e7989c9c9c2df02f
Reviewed-on: https://review.typo3.org/48452
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Raise version number in INSTALL.md 48/48448/4
Wouter Wolters [Sat, 4 Jun 2016 10:54:22 +0000 (12:54 +0200)]
[TASK] Raise version number in INSTALL.md

Resolves: #76454
Releases: master
Change-Id: I840d9b53840168017a42601ae8eb5c6439a54e1d
Reviewed-on: https://review.typo3.org/48448
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Do not manipulate minitems/maxitems 15/48415/4
Markus Klein [Tue, 31 May 2016 10:19:47 +0000 (12:19 +0200)]
[BUGFIX] Do not manipulate minitems/maxitems

We must only manipulate minitems and maxitems for valdiation
when we have a select-field with renderType selectTree.
The existing check is not enough, since it lacks the check
for the actual type and applies the changes also if
any other type is used and minitems=maxitems=1.

Resolves: #76388
Releases: master, 7.6
Change-Id: I9697521a710c3debc49f40c2c4db87baac8f2d97
Reviewed-on: https://review.typo3.org/48415
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Checkboxes with itemProcFunc are not saved 82/48082/8
Anja Leichsenring [Wed, 11 May 2016 14:54:51 +0000 (16:54 +0200)]
[BUGFIX] Checkboxes with itemProcFunc are not saved

Retrieve items added by an itemProcFunc before validating the current
set of selected checkboxes.

This fixes the bug that a item set consisting of mixed predefined and
dynamically added items always stored all predefined checkboxes as
selected (and no dynamic items).

It also fixes the case that a checkbox list consisting of purely
dynamically added items would never store a selection in the database,
showing all checkboxes as unselected.

Resolves: #76147
Releases: master, 7.6
Change-Id: I254a2936974f5bb5fbb6800a17667b66e1a86ca2
Reviewed-on: https://review.typo3.org/48082
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Use `enableMultiSelectFilterTextfield` in pages and tt_content 39/48439/2
Andreas Fernandez [Fri, 3 Jun 2016 10:03:41 +0000 (12:03 +0200)]
[TASK] Use `enableMultiSelectFilterTextfield` in pages and tt_content

Enable the usage of `enableMultiSelectFilterTextfield` for the field
`fe_group` in the TCA of pages and tt_content.

Resolves: #76444
Releases: master, 7.6
Change-Id: Ia4b3fd509b8a5e338f5f46e0fd49e89d600da982
Reviewed-on: https://review.typo3.org/48439
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Load CSH for flexforms again 83/48383/4
Wouter Wolters [Sun, 29 May 2016 10:48:35 +0000 (12:48 +0200)]
[BUGFIX] Load CSH for flexforms again

The cshKey is not correctly set up. Check for array as well and use
the first key if it exists.

Resolves: #73574
Releases: master,7.6
Change-Id: I263806a4628ea0cdb28413eefa3f9d2af4141a2c
Reviewed-on: https://review.typo3.org/48383
Tested-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Reset styles after drag and drop 62/47962/9
Markus Sommer [Fri, 29 Apr 2016 08:16:20 +0000 (10:16 +0200)]
[BUGFIX] Reset styles after drag and drop

* Store original styles to DragDrop.originalStyles
* Add originalStyles to DragDrop array
* Reset the style attribute after drag and drop.

Resolves: #75978
Releases: master
Change-Id: Ib8af4e86911f27bc8beb6469ce678e34756ac9dc
Reviewed-on: https://review.typo3.org/47962
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Natural sorting for integer keys 05/48405/5
Frank Naegler [Mon, 30 May 2016 14:22:05 +0000 (16:22 +0200)]
[BUGFIX] Natural sorting for integer keys

LocalDriver has a sorting bug if multiple files have
the same timestamp or size.
This patch adds a character to the sorting key to sort correctly.

Resolves: #73754
Releases: master, 7.6
Change-Id: Ie1ae0c11eea5a3bdf9ad23b0d4855364e5a62bab
Reviewed-on: https://review.typo3.org/48405
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Marco Bresch <marco.bresch@starfinanz.de>
Tested-by: Eugene Kenah Djomo <kdeugene@yahoo.fr>
Reviewed-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Optimize template handling for FSC: Bullets 07/48407/4
Frank Naegler [Mon, 30 May 2016 16:00:06 +0000 (18:00 +0200)]
[TASK] Optimize template handling for FSC: Bullets

Split the bullets template from FSC into partials.

Resolves: #75333
Releases: master
Change-Id: I5dd191f534f2ecf1c604c682e60374382c2b8f14
Reviewed-on: https://review.typo3.org/48407
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[BUGFIX] CSS inline style for image border gets corrupted after saving 08/48408/2
Frank Naegler [Mon, 30 May 2016 16:33:33 +0000 (18:33 +0200)]
[BUGFIX] CSS inline style for image border gets corrupted after saving

Resolves: #66844
Releases: master, 7.6, 6.2
Change-Id: I20fe7367433fe98a118890cc95306ee5e45504f4
Reviewed-on: https://review.typo3.org/48408
Tested-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[TASK] Make base test classes always available 28/48428/6
Helmut Hummel [Wed, 1 Jun 2016 17:03:13 +0000 (19:03 +0200)]
[TASK] Make base test classes always available

To ease the usage of the core with extensions,
we move the base test classes into a different place
to be able to make them available when typo3/cms is pulled in
as dependency, e.g. for testing extensions or in projects.

This is a non breaking change, as the classes will be available
in any case after that.

By doing so, we can nicely cleanup the .gitattributes file

Resolves: #76425
Releases: master
Change-Id: I639f08a4e3e5dd73aa47570d326b72c64452acaf
Reviewed-on: https://review.typo3.org/48428
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[!!!][TASK] Doctrine: Simplify restriction handling 49/48049/29
Helmut Hummel [Fri, 3 Jun 2016 05:46:45 +0000 (07:46 +0200)]
[!!!][TASK] Doctrine: Simplify restriction handling

To make the set of restrictions that are in effect when creating queries
with the QueryBuilder becomes more understandable,
we need to remove the QueryContext and the magic applied to that and replace it
with the following behavior:

delete, hidden, starttime, endtime restrictions are always enabled
and need to be removed if needed.
Other restrictions need to be provided manually depending on the desired result.

Resolves: #76167
Resolves: #76264
Releases: master
Change-Id: Iaf0cb08475ed44966838c3fbdd5756d3ba6ebcc1
Reviewed-on: https://review.typo3.org/48049
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[FOLLOWUP][TASK] Exclude non-production files from Git archives 36/48436/2
Nicole Cordes [Fri, 3 Jun 2016 06:52:25 +0000 (08:52 +0200)]
[FOLLOWUP][TASK] Exclude non-production files from Git archives

Disable Github API usage to receive the TYPO3 sources.

Resolves: #65570
Resolves: #68998
Resolves: #70810
Releases: master
Change-Id: Ic5ee615c933e397afc54d7aa8cb06b8656f2f33d
Reviewed-on: https://review.typo3.org/48436
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[FOLLOWUP][TASK] Automatically select the custom preset when values are changed 10/48410/3
Wouter Wolters [Mon, 30 May 2016 20:14:35 +0000 (22:14 +0200)]
[FOLLOWUP][TASK] Automatically select the custom preset when values are changed

When input field is changed the checkbox is checked directly, not
after it loses the focus.

Resolves: #76365
Releases: master
Change-Id: I8673612bcd8b21d1692188c73d8501f7937c047f
Reviewed-on: https://review.typo3.org/48410
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[FOLLOWUP][TASK] Remove $db property in UserAuthentication classes 37/48437/2
Nicole Cordes [Fri, 3 Jun 2016 09:04:03 +0000 (11:04 +0200)]
[FOLLOWUP][TASK] Remove $db property in UserAuthentication classes

This patch adds a comment why the empty constructor function in
the AbstractUserAuthentication has to stay.

Resolves: #76353
Releases: master
Change-Id: I9634d15579fed97a3f2f553a317117bad57eec5c
Reviewed-on: https://review.typo3.org/48437
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[FOLLOWUP][TASK] Exclude non-production files from Git archives 32/48432/2
Georg Ringer [Thu, 2 Jun 2016 05:26:59 +0000 (07:26 +0200)]
[FOLLOWUP][TASK] Exclude non-production files from Git archives

Use sources instead of distributions.

Resolves: #65570
Resolves: #68998
Resolves: #70810
Releases: master
Change-Id: I638534c808e8ddb9cc9da15f7bcd538c64434476
Reviewed-on: https://review.typo3.org/48432
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Remove wrong example in ShortcutButton 30/48430/2
Wouter Wolters [Wed, 1 Jun 2016 18:17:27 +0000 (20:17 +0200)]
[TASK] Remove wrong example in ShortcutButton

Resolves: #76415
Releases: master,7.6
Change-Id: I7e5694cfe1c104fdd3cb764af39acad690ffc4b9
Reviewed-on: https://review.typo3.org/48430
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Seifert <christian-f-seifert@gmx.de>
Tested-by: Christian Seifert <christian-f-seifert@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Exclude non-production files from Git archives 57/46357/10
Mathias Brodala [Fri, 6 Mar 2015 13:52:46 +0000 (14:52 +0100)]
[TASK] Exclude non-production files from Git archives

This excludes various directories and files from release
archives as generated by Github and fetched via Composer.

These files and directories are not relevant for production
and excluding them reduces the size of release archives.

Such files are usually identified as security risk in security
reviews and should therefore be removed by default from production systems.

As an addition it also avoids issues with long file paths when installing
on Windows systems.

Resolves: #65570
Resolves: #68998
Resolves: #70810
Releases: 7.6, master
Change-Id: I615e0c7a4cafaea471c79e88e9df2c78c55b92ac
Reviewed-on: https://review.typo3.org/46357
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Set $escapeOutput to false for ValidationResultsViewHelper 20/48420/2
Georg Ringer [Tue, 31 May 2016 13:40:43 +0000 (15:40 +0200)]
[BUGFIX] Set $escapeOutput to false for ValidationResultsViewHelper

The ViewHelper must not escape its output

Resolves: #76400
Releases: master
Change-Id: Iefeeddfca3f1427dfbf72c8dd672aefb1ea03500
Reviewed-on: https://review.typo3.org/48420
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Properly reset package manager in unit tests 21/48421/2
Christian Kuhn [Tue, 31 May 2016 14:06:49 +0000 (16:06 +0200)]
[BUGFIX] Properly reset package manager in unit tests

Package manager is a static property in ExtensionManagementUtility
that needs proper reset if a test fiddled with it.
Use the proxy class at places where this is not done yet.

Change-Id: I86d3813e1a4cbcb24c05507923694e498ffcb03d
Resolves: #76402
Releases: master
Reviewed-on: https://review.typo3.org/48421
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Always execute pbkdf2 tests 22/48422/2
Christian Kuhn [Tue, 31 May 2016 14:46:07 +0000 (16:46 +0200)]
[BUGFIX] Always execute pbkdf2 tests

The test annotation "@requires function hash_pbkdf2" doesn't
work for whatever reason, those tests are always skipped.
Since PHP7 always comes with hash_pbkdf2() built-in, the patch
now just drops the annotation.

Change-Id: Ice3adcebbeadf2c01e81960144c842bc4af268d2
Resolves: #76404
Releases: master
Reviewed-on: https://review.typo3.org/48422
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
3 years ago[BUGFIX] Get current locale without changing environment 16/48416/2
Christian Kuhn [Tue, 31 May 2016 10:19:22 +0000 (12:19 +0200)]
[BUGFIX] Get current locale without changing environment

Two tests in ext:form change the environment when they try to
back up the current locale:
setlocale(LC_NUMERIC, null): "the locale names will be set from
the values of environment variables", should be
setlocale(LC_NUMERIC, 0): "the locale setting is not affected,
only the current setting is returned"
In my case my default LC_NUMERIC is "C" and after call with 'null'
it is set to and returns 'de_DE.utf8', so it changes the internal
state to something else than before and the reset from backup does
not work properly. This leads to hard to debug problems if other
locale depending tests are executed later.
As a fun fact, phpunit suffers from the same issue and its
api method "setlocale()" that should take care of proper reset
messes this up, too. A pull request is pending to fix that.

The patch fixes the affected unit tests and cleans them up
along the way. Another patch to improve the overall situation
regarding locale handling in unit tests will follow later.

Change-Id: I2295b46cc6934a48e4d71ef5170deb83fb9264b6
Resolves: #76389
Releases: master
Reviewed-on: https://review.typo3.org/48416
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Only show CSH icon when EXT:context_help is loaded 04/48404/2
Benni Mack [Mon, 30 May 2016 12:38:33 +0000 (14:38 +0200)]
[BUGFIX] Only show CSH icon when EXT:context_help is loaded

When having EXT:context_help uninstalled an empty button is shown in
Web => Info => PageTSconfig, because the text could not be fetched.

Solution: Only show the button if there is a text inside.

Resolves: #76376
Releases: master, 7.6
Change-Id: I06b14a7f6166ec1e9bca412b3b3404762fc7d7b6
Reviewed-on: https://review.typo3.org/48404
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Automatically select the custom preset when values are changed 94/48394/5
Markus Klein [Sun, 29 May 2016 13:59:38 +0000 (15:59 +0200)]
[TASK] Automatically select the custom preset when values are changed

If the user changes a field in a custom preset in the Install Tool
the custom preset's radio box must be selected too.

Resolves: #76365
Releases: master, 7.6
Change-Id: Iee499d61574e88ef094d690bea7ff827aa7507dc
Reviewed-on: https://review.typo3.org/48394
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Upgrade to phpunit 5.3 00/48400/2
Christian Kuhn [Mon, 30 May 2016 10:05:52 +0000 (12:05 +0200)]
[TASK] Upgrade to phpunit 5.3

No notable fancy new features as far as I can see,
just a new minor.

Change-Id: I3363d8a7efa6e774315124536b680a7e84f14bb1
Resolves: #76372
Releases: master
Reviewed-on: https://review.typo3.org/48400
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Travis: Active memcached and redis tests 03/48403/2
Christian Kuhn [Mon, 30 May 2016 10:23:16 +0000 (12:23 +0200)]
[TASK] Travis: Active memcached and redis tests

In the early php7 days on travis redis.so and
memcached.so were missing, so the tests were skipped.
Load the two modules now to executed those tests again.

Change-Id: Ic772604bca24696e94596dd29862a70bcc2a560d
Resolves: #76375
Releases: master
Reviewed-on: https://review.typo3.org/48403
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Ensure correct return type for AbstractFile getters 95/48195/4
Markus Klein [Tue, 17 May 2016 12:23:24 +0000 (14:23 +0200)]
[BUGFIX] Ensure correct return type for AbstractFile getters

Resolves: #76212
Releases: master, 7.6
Change-Id: I7b7ded93ff1d31f00f8d067f9697cd8f71305881
Reviewed-on: https://review.typo3.org/48195
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Deprecate CacheFactory 22/48322/3
Benni Mack [Fri, 27 May 2016 11:18:59 +0000 (13:18 +0200)]
[TASK] Deprecate CacheFactory

CacheManager and CacheFactory are tightly coupled and
a different implemenation of the CacheFactory is not
in sight and doesn't seem to be needed.
The single method from CacheFactory is moved into
CacheManager now and the factory is marked as deprecated
and unused.

Resolves: #76370
Releases: master
Change-Id: I380edef47ebfd6d2cab044a562467c3b685ec96c
Reviewed-on: https://review.typo3.org/48322
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Minor update various composer dependencies 99/48399/2
Christian Kuhn [Sun, 29 May 2016 19:02:48 +0000 (21:02 +0200)]
[TASK] Minor update various composer dependencies

* minor cms-composer-installers
* various symfony 2nd level dependencies
* minor codeception
* guzzle

Change-Id: I690d4d3290120cd7fe18097313eeabcef11f6276
Resolves: #76369
Releases: master
Reviewed-on: https://review.typo3.org/48399
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[CLEANUP] Remove superfluous partials of Install Tool 95/48395/2
Markus Klein [Sun, 29 May 2016 14:02:47 +0000 (16:02 +0200)]
[CLEANUP] Remove superfluous partials of Install Tool

Resolves: #76366
Releases: master
Change-Id: Ic9a384f078b99d352445e8c262a7609972b39357
Reviewed-on: https://review.typo3.org/48395
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Update FontAwesome to 4.6.3 43/48343/3
Wouter Wolters [Fri, 27 May 2016 15:36:02 +0000 (17:36 +0200)]
[TASK] Update FontAwesome to 4.6.3

Resolves: #76335
Releases: master
Change-Id: Ide084d1511d83925c0b1de6666256802a52ba594
Reviewed-on: https://review.typo3.org/48343
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Allow typesList=0 when using makeCategorizable 64/48364/6
Wouter Wolters [Sat, 28 May 2016 15:41:50 +0000 (17:41 +0200)]
[BUGFIX] Allow typesList=0 when using makeCategorizable

Due to a wrong condition which is using !empty() typesList=0 is not possible.
Change the condition to check this the correct way.

Resolves: #76141
Releases: master, 7.6
Change-Id: Ieca9bd2a59e42d112c4eb8058bd76da8d73b86ab
Reviewed-on: https://review.typo3.org/48364
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Add hint what to do when a CSRF token check failed 72/48372/2
Wouter Wolters [Sat, 28 May 2016 18:48:10 +0000 (20:48 +0200)]
[TASK] Add hint what to do when a CSRF token check failed

Resolves: #75776
Releases: master, 7.6
Change-Id: I499c8a4e87e1abda99179329b69b7cdd67f7a748
Reviewed-on: https://review.typo3.org/48372
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Cleanup loading labels in Preview and Backend controller 42/48342/2
Wouter Wolters [Fri, 27 May 2016 15:23:49 +0000 (17:23 +0200)]
[TASK] Cleanup loading labels in Preview and Backend controller

Remove not used labels too.

Resolves: #76334
Releases: master
Change-Id: I27325f29639bd189c29923ef1fb734a91fd25e74
Reviewed-on: https://review.typo3.org/48342
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Clean up acceptance tests 40/48340/3
Christian Kuhn [Fri, 27 May 2016 14:46:47 +0000 (16:46 +0200)]
[TASK] Clean up acceptance tests

Merge the login related tests into one test case
and use the default \AcceptanceTester to do the tests.

Change-Id: I7e018fb1cdf10aada9854931736f87593ceeff10
Resolves: #76331
Releases: master
Reviewed-on: https://review.typo3.org/48340
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Fix output of DebugUtility 88/48288/12
Helmut Hummel [Wed, 25 May 2016 17:26:52 +0000 (19:26 +0200)]
[BUGFIX] Fix output of DebugUtility

This change prettifies the output of the debug output
methods, by using the Extbase DebuggerUtility for that purpose.

The benefits are consistent, well readable, properly encoded output
for every case the class provides.

In the long run, this class should be replaced with
a more object oriented approach.

Resolves: #76302
Releases: master, 7.6
Change-Id: Iacbb48701f6c98139bd7db86795952a123e076da
Reviewed-on: https://review.typo3.org/48288
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] FormEngine: Inline records open after first save 78/48378/3
Christian Kuhn [Sat, 28 May 2016 20:52:56 +0000 (22:52 +0200)]
[BUGFIX] FormEngine: Inline records open after first save

After creating and saving new inline elements, those elements
should be open by default. This was the case earlier, but broke
somewhere during FormEngine refactoring.

The patch restores this functionality. However, this patch is
restricted for master only since various scenarios are possible
that lead to funny open/close state. Those need further work.

Change-Id: I3b7dd6ebb5141f00317ef508b94ac41f4d44d265
Resolves: #76360
Releases: master
Reviewed-on: https://review.typo3.org/48378
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Correct type for constants linkWrap height and width 75/48375/4
Wouter Wolters [Sat, 28 May 2016 19:33:14 +0000 (21:33 +0200)]
[BUGFIX] Correct type for constants linkWrap height and width

The height and width have a default value with a "m" in it.
This is stripped of because the wrong data type is used. Use string
instead to circumvent the automatic stripping of the letter "m".

Resolves: #75520
Releases: master,7.6
Change-Id: I36c18e955db50ecd981efd24a0f842706d8d0fdc
Reviewed-on: https://review.typo3.org/48375
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Better explain when a cookie with a lifetime will be set 63/48363/2
Wouter Wolters [Sat, 28 May 2016 15:01:56 +0000 (17:01 +0200)]
[TASK] Better explain when a cookie with a lifetime will be set

A cookie with a lifetime will only be set when the option permalogin
is greater than or equals to 0. If this is not true it will become
a session cookie.

Resolves: #76168
Releases: master,7.6
Change-Id: Ibd5d431107713a118c93295d0f08df721bc3b6c4
Reviewed-on: https://review.typo3.org/48363
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Remove unused variables from LiveSearch getRecordArray 62/48362/3
Wouter Wolters [Sat, 28 May 2016 14:21:51 +0000 (16:21 +0200)]
[BUGFIX] Remove unused variables from LiveSearch getRecordArray

Resolves: #76248
Releases: master, 7.6
Change-Id: Iadf5c209bf12ad199ae92f654d2348b70001c053
Reviewed-on: https://review.typo3.org/48362
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Display content_date in sys_file_metadata TCA 43/48243/2
Stephan Großberndt [Mon, 23 May 2016 11:35:57 +0000 (13:35 +0200)]
[TASK] Display content_date in sys_file_metadata TCA

Display content_creation_date and content_modification_date of images,
audio files and videos in the TCA of sys_file_metadata records.

Resolves: #76267
Releases: master, 7.6
Change-Id: I77dd1b35f5ba7e1f4dbd975ad1ad339e8a0ada6e
Reviewed-on: https://review.typo3.org/48243
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Remove double encoded module URL in InfoModuleController 74/48374/2
Wouter Wolters [Sat, 28 May 2016 19:20:22 +0000 (21:20 +0200)]
[BUGFIX] Remove double encoded module URL in InfoModuleController

Resolves: #75551
Releases: master
Change-Id: Icff1d2b11661a32fd3fa28feea69c07ce3086034
Reviewed-on: https://review.typo3.org/48374
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Remove unused OpendocsToolbarItem->getDatabaseConnection 68/48368/2
Stephan Großberndt [Sat, 28 May 2016 16:38:48 +0000 (18:38 +0200)]
[TASK] Remove unused OpendocsToolbarItem->getDatabaseConnection

Resolves: #76356
Releases: master
Change-Id: I47c8b35eded79d6010b14e828f47b0790c09a6e9
Reviewed-on: https://review.typo3.org/48368
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove unused functions in FormEngineUtility 69/48369/2
Stephan Großberndt [Sat, 28 May 2016 16:42:40 +0000 (18:42 +0200)]
[TASK] Remove unused functions in FormEngineUtility

The functions getLanguageService() and getDatabaseConnection() in
FormEngineUtility are not used and can be removed.

Resolves: #76357
Releases: master
Change-Id: I2883152c7ec3f40f80c280f360488a06b0ef9ba8
Reviewed-on: https://review.typo3.org/48369
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove unused SystemInformationToolbarItem->getDatabaseConnection 65/48365/3
Stephan Großberndt [Sat, 28 May 2016 16:04:35 +0000 (18:04 +0200)]
[TASK] Remove unused SystemInformationToolbarItem->getDatabaseConnection

Since the introduction of doctrine getDatabaseConnection in
SystemInformationToolbarItem is no longer used and can be removed.

Resolves: #76354
Releases: master
Change-Id: I675ada2355bfe48b93de66cea03a3f0fc290d382
Reviewed-on: https://review.typo3.org/48365
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove $db property in UserAuthentication classes 66/48366/2
Markus Klein [Sat, 28 May 2016 16:14:18 +0000 (18:14 +0200)]
[TASK] Remove $db property in UserAuthentication classes

Resolves: #76353
Releases: master
Change-Id: I90799c3652e7edd8ee3048f39b50237470fed19b
Reviewed-on: https://review.typo3.org/48366
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Use noncapturing expression for vendor|typo3_src in _.htaccess 60/48360/4
Stephan Großberndt [Sat, 28 May 2016 12:17:21 +0000 (14:17 +0200)]
[TASK] Use noncapturing expression for vendor|typo3_src in _.htaccess

Resolves: #76352
Releases: master, 7.6
Change-Id: I8332c93f1171d030d4198091779c8f1242c9337b
Reviewed-on: https://review.typo3.org/48360
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Add comment explaining spamProtectEmailAddresses=ascii 59/48359/2
Stephan Großberndt [Sat, 28 May 2016 12:08:51 +0000 (14:08 +0200)]
[TASK] Add comment explaining spamProtectEmailAddresses=ascii

Resolves: #76351
Releases: master
Change-Id: Ic6971eaa4f2bf195022334c103e5af0a6079aed3
Reviewed-on: https://review.typo3.org/48359
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Deprecate the argument 'hsc' for getLL, getLLL and sL 53/48353/4
Valentin Despa [Sat, 28 May 2016 11:22:03 +0000 (13:22 +0200)]
[TASK] Deprecate the argument 'hsc' for getLL, getLLL and sL

This patch deprecates the parameter 'hsc' within the following
methods of TYPO3\CMS\Lang\LanguageService:

    * getLL
    * getLLL
    * sL

Resolves: #71917
Releases: master
Change-Id: I0aa9d0ad12d20719f2367459765dccb57cac69e8
Reviewed-on: https://review.typo3.org/48353
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Deprecate path prefixes in callUserFunction and getUserObj 52/48352/5
Benni Mack [Sat, 28 May 2016 11:31:04 +0000 (13:31 +0200)]
[TASK] Deprecate path prefixes in callUserFunction and getUserObj

The possibility to call "GeneralUtility::callUserFunc()"
and "getUserObj()" with the first parameter containing the file reference
to the function or class separated by a colon is deprecated.

An example is "EXT:realurl/class.tx_realurl.php:tx_realurl->encodeSpURL".

Calling one of the methods above with this syntax now triggers a
deprecation message.

It is encouraged to use the common autoloading functionality of
composer or via the fallback autoloader by TYPO3 to achieve the
same functionality.

Resolves: #76345
Releases: master
Change-Id: Iaaa2f825d330681199f0b0928727b93bbd3c73a7
Reviewed-on: https://review.typo3.org/48352
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Display version selector in info module 51/48351/2
Stephan Großberndt [Sat, 28 May 2016 10:49:23 +0000 (12:49 +0200)]
[BUGFIX] Display version selector in info module

This patch restores the version selector in info module which was
broken during the fluidification of the info module.

Resolves: #76343
Related: #74360
Releases: master
Change-Id: I5488f5b7ca7efd28c5508c1e1e50cf55d3e14f38
Reviewed-on: https://review.typo3.org/48351
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove second parameter of getLL part 4/3 50/48350/2
Markus Klein [Sat, 28 May 2016 10:36:27 +0000 (12:36 +0200)]
[TASK] Remove second parameter of getLL part 4/3

Remove the second parameter of getLL and replace it
with htmlspecialchars directly in the code.

Resolves: #76321
Related: #71917
Releases: master
Change-Id: I71ed4d93c48731cad8cf88cc1de002190f38ba9a
Reviewed-on: https://review.typo3.org/48350
Reviewed-by: Valentin Despa <info@vdespa.de>
Tested-by: Valentin Despa <info@vdespa.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Use a getter for the LanguageService in ext:version 37/48337/7
Wouter Wolters [Fri, 27 May 2016 14:06:04 +0000 (16:06 +0200)]
[TASK] Use a getter for the LanguageService in ext:version

Resolves: #76330
Releases: master
Change-Id: Ifff1c2bf9af25bf1a57de4f80ce356dad3462b64
Reviewed-on: https://review.typo3.org/48337
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Cache requireJS configuration 30/42730/12
Markus Klein [Tue, 18 Aug 2015 19:59:20 +0000 (21:59 +0200)]
[TASK] Cache requireJS configuration

This avoids lots of filesystem I/O because it does not crawl all
extensions on each BE request anymore.

Resolves: #69172
Releases: master
Change-Id: Ibe83caed164f78f51718fbd34e334f980a8e40d8
Reviewed-on: https://review.typo3.org/42730
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Unit test to cover stdWrap_stripHTML 42/48242/5
Elmar Hinz [Mon, 23 May 2016 07:03:42 +0000 (09:03 +0200)]
[TASK] Unit test to cover stdWrap_stripHTML

Resolves: #76261
Releases: master
Change-Id: I64ed81604b92e1c929a5252b396c0d3a21098c2b
Reviewed-on: https://review.typo3.org/48242
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Deprecate DocumentTemplate methods 69/47769/8
Benni Mack [Tue, 19 Apr 2016 05:27:23 +0000 (07:27 +0200)]
[TASK] Deprecate DocumentTemplate methods

This patch deprecates the following parameters/methods within
DocumentTemplate:

* sectionFlag (is internal)
* viewPageIcon()
* getHeader()
* getResourceHeader()
* header()
* icons()
* t3Button()
* wrapScriptTags()
* loadJavascriptLib()
* getContextMenuCode()

Resolves: #72859
Releases: master
Change-Id: I589c364ec506793439ac007b002cf28a6e1ca69d
Reviewed-on: https://review.typo3.org/47769
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Add proper comments in DefaultConfiguration options 41/48341/2
Benni Mack [Fri, 27 May 2016 15:06:27 +0000 (17:06 +0200)]
[BUGFIX] Add proper comments in DefaultConfiguration options

Some descriptions of options in DefaultConfiguration are not visible in
the Install Tool. These are added and made sure to be rendered
in the Install Tool.

Resolves: #76333
Releases: master, 7.6
Change-Id: I87d90b7614d5c90a1d212d0a214ef26dc2d5fcfc
Reviewed-on: https://review.typo3.org/48341
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove second parameter of sL - Part 3/3 46/48346/3
Valentin Despa [Fri, 27 May 2016 17:23:10 +0000 (19:23 +0200)]
[TASK] Remove second parameter of sL - Part 3/3

Remove the second parameter of sL and replace it
with htmlspecialchars directly in the code.

Resolves: #76325
Related: #71917
Releases: master
Change-Id: I6668eea01d80446a6b6f2ec95435c6e3d93cb0c3
Reviewed-on: https://review.typo3.org/48346
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Remove second parameter of sL - Part 2/3 44/48344/3
Valentin Despa [Fri, 27 May 2016 16:20:33 +0000 (18:20 +0200)]
[TASK] Remove second parameter of sL - Part 2/3

Remove the second parameter of sL and replace it
with htmlspecialchars directly in the code.

Resolves: #76325
Related: #71917
Releases: master
Change-Id: Ibaae459cb81a4fb9616e953d772603acf85e4d11
Reviewed-on: https://review.typo3.org/48344
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove second parameter of sL - Part 1/3 38/48338/2
Valentin Despa [Fri, 27 May 2016 14:10:07 +0000 (16:10 +0200)]
[TASK] Remove second parameter of sL - Part 1/3

Remove the second parameter of sL and replace it
with htmlspecialchars directly in the code.

Resolves: #76325
Related: #71917
Releases: master
Change-Id: I6267c45daeddf9a652ad63acb014c824721df25f
Reviewed-on: https://review.typo3.org/48338
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Fix undefined property rUri in TableController 34/48334/2
Wouter Wolters [Fri, 27 May 2016 13:38:27 +0000 (15:38 +0200)]
[BUGFIX] Fix undefined property rUri in TableController

Resolves: #76329
Releases: master,7.6
Change-Id: Ie5320e71aa8ded5b744997b6f1ca71c3542aa2f0
Reviewed-on: https://review.typo3.org/48334
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] unserialize() without objects in impexp 33/48333/2
Christian Kuhn [Fri, 27 May 2016 13:19:42 +0000 (15:19 +0200)]
[TASK] unserialize() without objects in impexp

Change-Id: I09d769584dc4389d0d6e0d2ffa3e8e1b0fa571ad
Resolves: #76327
Releases: master
Reviewed-on: https://review.typo3.org/48333
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Remove second parameter of getLL part 3/3 32/48332/3
Wouter Wolters [Fri, 27 May 2016 13:21:09 +0000 (15:21 +0200)]
[TASK] Remove second parameter of getLL part 3/3

Remove the second parameter of getLL and replace it
with htmlspecialchars directly in the code.

Resolves: #76321
Related: #71917
Releases: master
Change-Id: I513c5915c9273c906b6b828d65425ac8ee485e12
Reviewed-on: https://review.typo3.org/48332
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Remove second parameter of getLL part 2/3 30/48330/2
Wouter Wolters [Fri, 27 May 2016 12:20:21 +0000 (14:20 +0200)]
[TASK] Remove second parameter of getLL part 2/3

Remove the second parameter of getLL and replace it
with htmlspecialchars directly in the code.

Resolves: #76321
Related: #71917
Releases: master
Change-Id: Ieabcf550883ebcf85fe13232caab249b0f37e4b1
Reviewed-on: https://review.typo3.org/48330
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Obsolete unserialize(serialize()) 27/48327/3
Christian Kuhn [Fri, 27 May 2016 11:36:13 +0000 (13:36 +0200)]
[TASK] Obsolete unserialize(serialize())

There is a funny comment for this call within TypoScriptParser.
Reading the code, there seems to be no part that works with
references on this variable in setVal().

The patch now removes this odd construct. In the
unlikely case some issue still pops up later, we would
at least have a clear way to reproduce then ...

Change-Id: I70f5f8915386a7a4b5038d66611b4ec359f5c1fa
Resolves: #76323
Releases: master
Reviewed-on: https://review.typo3.org/48327
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] IconViewHelper should generate absolute URLs 21/48321/4
Benni Mack [Fri, 27 May 2016 11:16:09 +0000 (13:16 +0200)]
[TASK] IconViewHelper should generate absolute URLs

This change allows the IconViewHelper in the reports module
to be used not just from typo3/ (e.g. if a person puts typo3/index.php
to a different place or wants to show the reports in the install tool).

Resolves: #76322
Releases: master
Change-Id: I7067654b3fff5ac75fb9883b708ddb28a9ddc7d1
Reviewed-on: https://review.typo3.org/48321
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Doctrine: Use compatible charset name for database connection 10/48310/3
Morton Jonuschat [Fri, 27 May 2016 08:23:35 +0000 (10:23 +0200)]
[BUGFIX] Doctrine: Use compatible charset name for database connection

Use the charset name 'utf8' instead of 'utf-8' for MySQL connections as
some MySQL server versions silently ignore the connection charset name
'utf-8' and work with the global default connection charset instead.
Using 'utf8' as charset name doesn't exhibit this behavior.

Also changes the silent upgrade wizard to only set the default driver
and connection charset if no value has been configured, this avoids
silently changing non-default values for these options.

Change-Id: I94e1e7c557aff890cec357ef9ee069ae9aa052c6
Resolves: #76265
Releases: master
Reviewed-on: https://review.typo3.org/48310
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Unit test to cover stdWrap_char 07/48307/4
Elmar Hinz [Fri, 27 May 2016 07:22:04 +0000 (09:22 +0200)]
[TASK] Unit test to cover stdWrap_char

Releases: master
Resolves: #76316
Change-Id: I40c05c0d6a342b3d3c19dc164ae7716076aa3df2
Reviewed-on: https://review.typo3.org/48307
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Unit test to cover stdWrap_brTag 93/48293/4
Elmar Hinz [Thu, 26 May 2016 10:05:30 +0000 (12:05 +0200)]
[TASK] Unit test to cover stdWrap_brTag

Resolves: #76307
Releases: master
Change-Id: Ie75ab139102cedb6e5bc01ffb59bbf51c900dded
Reviewed-on: https://review.typo3.org/48293
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Unit test to cover stdWrap_rawUrlEncode 84/48284/4
Elmar Hinz [Wed, 25 May 2016 07:51:32 +0000 (09:51 +0200)]
[TASK] Unit test to cover stdWrap_rawUrlEncode

Resolves: #76294
Releases: master
Change-Id: Ifca415dd965473cde9cec29ca21a476491540845
Reviewed-on: https://review.typo3.org/48284
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Fix broken disable overlay in FormEngine 10/48110/3
Frank Naegler [Fri, 13 May 2016 08:24:55 +0000 (10:24 +0200)]
[BUGFIX] Fix broken disable overlay in FormEngine

Resolves: #75397
Releases: master, 7.6
Change-Id: I7cb4f04e38e3d9f755aaf92012eb56d71a1ad6f7
Reviewed-on: https://review.typo3.org/48110
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Re-enables fileDenyPattern check for admin users 10/32610/12
Torben Hansen [Thu, 26 May 2016 19:20:23 +0000 (21:20 +0200)]
[BUGFIX] Re-enables fileDenyPattern check for admin users

When an admin user tries to upload a file which has a fileextension
that is included in the fileDenyPattern, the upload is denied.

With the security fix in #51326 admin users are now able to change
the extension of a file to any value, since the fileDenyPattern is
not checked for admin users. This leads to the situation, that admin
users can create/rename files in the filelist with a fileextension
of their choice.

To keep the behavior consistent, this patch re-enables the check
of the fileDenyPattern for admin users in the filelist.

Resolves: #60173
Releases: master, 7.6, 6.2
Change-Id: I3b819e70cf2218a4580203ac7b7a6b0c3c5087ab
Reviewed-on: https://review.typo3.org/32610
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[TASK] unserialize() without objects for extConf 14/48314/4
Christian Kuhn [Fri, 27 May 2016 10:22:18 +0000 (12:22 +0200)]
[TASK] unserialize() without objects for extConf

To mitigate potential "unsecure unserialize()" issues, the new PHP7
feature to allow only specific classes or to totally deny object
creation is rolled out throughout the core in v8.

Since a lot of places use unserialize() and some are critical or
hard to understand, this is done with a series of patches for
single areas.

This patch denies object creation at all places where
$GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['anExtension'] is
unserialized() - the extension manager and ext_conf_template.txt
handling never handles objects at this place, so it should be
safe to deny objects at all places.

Change-Id: Ie96e6fb6837418fd765f883b216b7a9c5af5795d
Resolves: #76320
Releases: master
Reviewed-on: https://review.typo3.org/48314
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Deprecate single slash comments in TypoScript 51/48051/17
Elmar Hinz [Mon, 9 May 2016 19:59:37 +0000 (21:59 +0200)]
[TASK] Deprecate single slash comments in TypoScript

Double slash one-line comments are standard in many languages.
Make them standard in TypoScript, too.

Deprecated:
  / Line comment headed by single slash

Resolves: #76104
Releases: master
Change-Id: Id78391f973cdf8147bf91b269996f31d475de717
Reviewed-on: https://review.typo3.org/48051
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Remove second parameter of getLL part 1/3 20/48320/5
Wouter Wolters [Fri, 27 May 2016 11:04:16 +0000 (13:04 +0200)]
[TASK] Remove second parameter of getLL part 1/3

Remove the second parameter of getLL and replace it
with htmlspecialchars directly in the code.

Resolves: #76321
Related: #71917
Releases: master
Change-Id: Iaccd3e31b235632fac9022e9120a35426bd5d99b
Reviewed-on: https://review.typo3.org/48320
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Deprecate MenuViewHelperTrait 11/48111/7
Frank Naegler [Fri, 27 May 2016 10:53:10 +0000 (12:53 +0200)]
[TASK] Deprecate MenuViewHelperTrait

The MenuViewHelperTrait has been marked as deprecated.
All methods of the Trait have been implemented in a new
AbstractMenuViewHelper class.

Resolves: #75209
Releases: master
Change-Id: Ie8cad645c80c3cb7814dd2b69f22feb729334779
Reviewed-on: https://review.typo3.org/48111
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Optimise comment of $sortedConf in the stdWrap function 32/48132/6
Elmar Hinz [Sat, 14 May 2016 09:10:38 +0000 (11:10 +0200)]
[TASK] Optimise comment of $sortedConf in the stdWrap function

Explain the creation and name of the variable in concise words.

Resolves: #76195
Related: #76194
Releases: master
Change-Id: Ifff61c38dbb4ea07f79cb42cfe7f6aca41e5fbe1
Reviewed-on: https://review.typo3.org/48132
Reviewed-by: Olaf Schmidt-Wischhöfer <osw@eadi.org>
Tested-by: Olaf Schmidt-Wischhöfer <osw@eadi.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[FOLLOWUP][BUGFIX] Check if `$rows` is an array before iteration 18/48318/2
Andreas Fernandez [Fri, 27 May 2016 10:49:41 +0000 (12:49 +0200)]
[FOLLOWUP][BUGFIX] Check if `$rows` is an array before iteration

Use `$table` for logging instead of the hardcoded `pages` table.

Resolves: #74125
Releases: master, 7.6
Change-Id: I13b4306bdc54cf461d23c401d54c04983059df46
Reviewed-on: https://review.typo3.org/48318
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Check if `$rows` is an array before iteration 11/48311/6
Andreas Fernandez [Fri, 27 May 2016 08:59:26 +0000 (10:59 +0200)]
[BUGFIX] Check if `$rows` is an array before iteration

In case `$rows` in the method `DataHandler::copySpecificPage()` is null,
the foreach loop will throw an error.
`$rows` may become null if an extension brings TCA but the table does not
have `uid` field, for example.

It's now checked whether the result being iterated is an array, otherwise
an error is logged.

Resolves: #74125
Releases: master, 7.6
Change-Id: I20cb101155632309b9e08600fcd33e655c1c9d2f
Reviewed-on: https://review.typo3.org/48311
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[FOLLOWUP][TASK] Deprecate removeBadHTML 13/48313/3
Frank Naegler [Fri, 27 May 2016 09:58:32 +0000 (11:58 +0200)]
[FOLLOWUP][TASK] Deprecate removeBadHTML

Mark stdWrap_removeBadHTML as deprecated in doc comment.

Resolves: #15415
Releases: master
Change-Id: I4534a8b93b731f8e736752e712c0c13293b0b05d
Reviewed-on: https://review.typo3.org/48313
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Deprecate removeBadHTML 01/48301/4
Wouter Wolters [Thu, 26 May 2016 18:50:36 +0000 (20:50 +0200)]
[TASK] Deprecate removeBadHTML

Resolves: #15415
Releases: master
Change-Id: Iac92d6d36e2a84b069fa7c4a17d2dc567d952309
Reviewed-on: https://review.typo3.org/48301
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Update the comment of stdWrap_char to include ASCII limitation 06/48306/3
Elmar Hinz [Fri, 27 May 2016 07:03:53 +0000 (09:03 +0200)]
[TASK] Update the comment of stdWrap_char to include ASCII limitation

The PHP char() function only works reliably with ASCII codes
independent of the actual char set.

See http://php.net/manual/en/function.chr.php

Releases: master
Resolves: #76315
Change-Id: Ia87b95239fc4678f297571704f031003f84a5759
Reviewed-on: https://review.typo3.org/48306
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Fix page permissions SQL clause in BackendConfigurationManager 20/48220/4
Morton Jonuschat [Fri, 20 May 2016 04:50:26 +0000 (06:50 +0200)]
[BUGFIX] Fix page permissions SQL clause in BackendConfigurationManager

Instead of passing the simple value "1" to QueryGenerator->getTreeList()
use a page permission clause created using $BE_USER->getPagePermsClause()
when determining the recursive storage pids. Passing the unprocessed value
"1" causes invalid SQL statements and does not perform any access checks.

Releases: master, 7.6
Resolves: #75912
Change-Id: I6edadd627c0a9c01a78c3cb55805455fed710d14
Reviewed-on: https://review.typo3.org/48220
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[!!!][BUGFIX] Load popup configuration in case backend submodules are opened in a... 76/48276/7
Andreas Fernandez [Tue, 24 May 2016 13:11:57 +0000 (15:11 +0200)]
[!!!][BUGFIX] Load popup configuration in case backend submodules are opened in a new tab

It's possible to open some backend modules (e.g. RTE or
EditDocumentController) in a new tab. However, the configuration for
popups is missing in such case, causing e.g. opening the "Insert image"
wizard of RTE is not possible anymore.

Place configuration inline in TYPO3.settings to not have this problem of
missing configuration.

Resolves: #76285
Releases: master
Change-Id: I1405dd90e4e00fc709d504af2ed0a936a6374fce
Reviewed-on: https://review.typo3.org/48276
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Deprecate RemoveXSS 02/48102/16
Georg Ringer [Thu, 12 May 2016 13:04:36 +0000 (15:04 +0200)]
[TASK] Deprecate RemoveXSS

Due to the wrong approach of RemoveXSS it is not 100%
safe and does not keep its promise.

Resolves: #76164
Releases: master
Change-Id: I8aa0a05f7866041f392441fa852bae5a7c202142
Reviewed-on: https://review.typo3.org/48102
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Settings: Display titleLen and thumbsByDefault in editFunctionsTab 90/48290/2
Markus Klein [Wed, 25 May 2016 21:51:23 +0000 (23:51 +0200)]
[BUGFIX] Settings: Display titleLen and thumbsByDefault in editFunctionsTab

Resolves: #76303
Releases: master, 7.6
Change-Id: Ia03f62ccc1c7c989a4284de36ac814758c63d288
Reviewed-on: https://review.typo3.org/48290
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Simplify and harden pagination Fluid JS usage 91/48291/5
Helmut Hummel [Wed, 25 May 2016 22:34:01 +0000 (00:34 +0200)]
[TASK] Simplify and harden pagination Fluid JS usage

Fluid variables must never be used in JavaScript context.
Instead they should be put into data attributes, which can be
accessed from JavaScript easily.

Resolves: #76304
Releases: master
Change-Id: I16c0d6b265ad446d73cbe285be7653d1a8ebcfd2
Reviewed-on: https://review.typo3.org/48291
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Output HTML code only if requested 87/48287/2
Helmut Hummel [Wed, 25 May 2016 16:28:14 +0000 (18:28 +0200)]
[BUGFIX] Output HTML code only if requested

When adding visibility information in DebuggerUtility
it was not respected that this utility can also be used to output in cli.

Add the missing condition and output HTML only if requested.

Additionally when the property has nested objects,
the visibility info must be right after the property not after
every nested object.

Also prettify object type output on command line on the go.

Resolves: #76301
Related: #76008
Releases: master
Change-Id: If82192bf9d1fb0ca1dc843242167d01b1a915f6e
Reviewed-on: https://review.typo3.org/48287
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[TASK] Improve rendering of file paths in reports 82/48282/3
Georg Ringer [Tue, 24 May 2016 21:22:32 +0000 (23:22 +0200)]
[TASK] Improve rendering of file paths in reports

By using the <code>-tag, the output of paths is improved:

- XCLASS usage
- Path to ENABLE_INSTALL_TOOL
- Path to deprecation log

Resolves: #76288
Releases: master, 7.6
Change-Id: I591009cd52ba1dec6d25ff135e76b7b536b84193
Reviewed-on: https://review.typo3.org/48282
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 years ago[BUGFIX] Don't HSC URI in JS in BE paginate VH 83/48283/3
Jigal van Hemert [Tue, 24 May 2016 21:41:05 +0000 (23:41 +0200)]
[BUGFIX] Don't HSC URI in JS in BE paginate VH

The URI is HSC'd by default. Using the output unformatted produces
a correct URI for use inside JS.

Resolves: #76289
Releases: master
Change-Id: Iec7b9aaa0a26ec9acfe6ba49924373965a989a2f
Reviewed-on: https://review.typo3.org/48283
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Do not escape system information label with HTML 86/48286/2
Markus Klein [Wed, 25 May 2016 12:07:17 +0000 (14:07 +0200)]
[BUGFIX] Do not escape system information label with HTML

Resolves: #76296
Releases: master
Change-Id: I039e031ff6f46c94d474c35c43de372cfc5b0fc2
Reviewed-on: https://review.typo3.org/48286
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Suggest wizard inserts correct items again 77/48277/2
Markus Klein [Tue, 24 May 2016 13:41:03 +0000 (15:41 +0200)]
[BUGFIX] Suggest wizard inserts correct items again

The patch for #70463 introduced a regression which caused
added elements to include HTML markup.

Resolves: #76286
Releases: master, 7.6
Change-Id: I596602b03fd65f2e8d95171c2f2f79ff57006f14
Reviewed-on: https://review.typo3.org/48277
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Add a few additional tests for PageRepository 78/48078/2
Helmut Hummel [Wed, 11 May 2016 12:50:55 +0000 (14:50 +0200)]
[TASK] Add a few additional tests for PageRepository

Resolves: #76150
Releases: master
Change-Id: Ia51ec33ba4aacabc884292d4a9508ce0d2c4cd9d
Reviewed-on: https://review.typo3.org/48078
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Remove reintroduced obsolete LocalConfiguration settings 38/48238/2
Wouter Wolters [Sun, 22 May 2016 12:43:46 +0000 (14:43 +0200)]
[TASK] Remove reintroduced obsolete LocalConfiguration settings

With the introduction of Doctrine DBAL the obsolete settings of
all upgrade wizards related to TYPO3 CMS 7 are added again.

Remove them now again.

Resolves: #76258
Related: #75454
Releases: master
Change-Id: Ib86591525724b2fd189038a04dfa645815f4fe55
Reviewed-on: https://review.typo3.org/48238
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>