Packages/TYPO3.CMS.git
3 years ago[!!!][TASK] Removed deprecated code from FlashMessage 18/46918/5
Michael Oehlhof [Fri, 26 Feb 2016 16:18:34 +0000 (17:18 +0100)]
[!!!][TASK] Removed deprecated code from FlashMessage

Resolves: #72438
Releases: master
Change-Id: I39cbe8d45dc4f3b711e4dd9b5442fa07ba106257
Reviewed-on: https://review.typo3.org/46918
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[FOLLOWUP][BUGFIX] Switch-User feature uses wrong user id for logging 19/46919/2
Christian Kuhn [Fri, 26 Feb 2016 16:20:47 +0000 (17:20 +0100)]
[FOLLOWUP][BUGFIX] Switch-User feature uses wrong user id for logging

For master, the username partial is inlined to the main template to
suppress a whitespace issue with fluid.
For 7.6, the inlining went wrong and a variable change is applied.

Change-Id: Ibe3626b581d0203307be1347e6708bc15cb3db9d
Resolves: 71580
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46919
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Remove deprecated call in InlineRecordContainer 16/46916/2
Frank Naegler [Fri, 26 Feb 2016 15:55:49 +0000 (16:55 +0100)]
[BUGFIX] Remove deprecated call in InlineRecordContainer

This patch removes the usage of the deprecated FlashMessage->render
method and add a custom markup instead.

Resolves: #73703
Releases: master, 7.6
Change-Id: I1c84aa0c353a26fdc62d7d16fca5cdfc22326156
Reviewed-on: https://review.typo3.org/46916
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Sys actions: Removed call to deprecated method render() 97/46797/3
Michael Oehlhof [Sun, 21 Feb 2016 17:28:40 +0000 (18:28 +0100)]
[BUGFIX] Sys actions: Removed call to deprecated method render()

Call of FlashMessage->render() was replaced with appropriate code if

getTask
* the action is not found
* the action had no type defined

viewNewBackendUser
* the action configuration is not finished
* the user has been created

viewSqlQuery
* query is empty (not built)
* query is not configured
* required sysext lowlevel is not installed

viewRecordList
* the action configuration is not finished
* not enough rights to access the list view or the page

Resolves: #73587
Releases: master, 7.6
Change-Id: I9140d337cc52d1be7974771d3929f727266a9cc6
Reviewed-on: https://review.typo3.org/46797
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Deprecate no longer used method getFlashMessageForMissingFile 96/46796/4
Michael Oehlhof [Sun, 21 Feb 2016 13:00:42 +0000 (14:00 +0100)]
[TASK] Deprecate no longer used method getFlashMessageForMissingFile

Deprecate no longer used method
BackendUtility::getFlashMessageForMissingFile

Resolves: #73585
Releases: master
Change-Id: I680b5d5b82b1b293d20b0738903ba2e16405c38a
Reviewed-on: https://review.typo3.org/46796
Reviewed-by: Christian Brinkert <christian.brinkert@googlemail.com>
Tested-by: Christian Brinkert <christian.brinkert@googlemail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Removed call to render() after getFlashMessageForMissingFile 54/45554/8
Michael Oehlhof [Sun, 3 Jan 2016 01:30:51 +0000 (02:30 +0100)]
[BUGFIX] Removed call to render() after getFlashMessageForMissingFile

Replace calls to deprecated method render() and to the function
getFlashMessageForMissingFile() with appropriate html code.

Resolves: #72508
Releases: master, 7.6
Change-Id: I90846f8349726e88dfa6aa77ab595fe28280e81b
Reviewed-on: https://review.typo3.org/45554
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Remove security fix for older PHP versions 11/46911/3
Alexander Opitz [Fri, 26 Feb 2016 14:44:40 +0000 (15:44 +0100)]
[TASK] Remove security fix for older PHP versions

As we are only supporting PHP 7.0, we can remove the security check
for older PHP versions. The header() function do not support multi
line headers any more.

Resolves: #73700
Related: #58816
Releases: master
Change-Id: I0f3e8f013111fc062058428388749f9f6450ff48
Reviewed-on: https://review.typo3.org/46911
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Switch-User feature uses wrong user id for logging 90/45490/4
Oliver Hader [Tue, 29 Dec 2015 14:07:12 +0000 (15:07 +0100)]
[BUGFIX] Switch-User feature uses wrong user id for logging

Issue #17643 introduced logging for a simulated backend user
(switch-user) and thus logs by using the original admin user.

This is a regression in PageLayoutController::renderQuickEdit
since the used backend user id is different to the persisted
one. Besides that, all actions are performed with the permissions
of the simulated user - thus, logging with a different user seems
to wrong. The sys_log.log_data field (array) is used to transport
the information of the original (admin) user.

This change reverts the initial change of issue #17643 and adds
the initial intention of that issue as addition to the persisted
data in sys_log.log_data. All affected components are adjusted as
well to visualize that a user has been simulated (log view, record
history and lowlevel_cleaner syslog command).

Resolves: #71580
Releases: master, 7.6
Change-Id: If12df60563afd1f0746d43e62f824b20f139df8c
Reviewed-on: https://review.typo3.org/45490
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Scheduler: Removed call to deprecated method render() 00/46900/3
Michael Oehlhof [Thu, 25 Feb 2016 22:01:45 +0000 (23:01 +0100)]
[BUGFIX] Scheduler: Removed call to deprecated method render()

Call of FlashMessage->render() when configuring a task with the class
"File Abstraction Layer: Extract metadata in storage" for the
"Registered extractors" was replaced with appropriate code.

Resolves: #73685
Releases: master, 7.6
Change-Id: I1265ad845c2e951c9a5a242f74fa336a26645a88
Reviewed-on: https://review.typo3.org/46900
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Remove WinCache, XCache opcode support 98/46898/3
Alexander Opitz [Fri, 26 Feb 2016 08:34:40 +0000 (09:34 +0100)]
[TASK] Remove WinCache, XCache opcode support

Xcache do not support PHP7 and WinCache removed opcode cache handling
in first PHP7 compatible version. So we can remove this support.

Resolves: #72415
Releases: master
Change-Id: I1f5e855e94ca8e7a941425113d1473180abe5ed0
Reviewed-on: https://review.typo3.org/46898
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Module recordlist: Removed call to deprecated method render() 84/46884/5
Michael Oehlhof [Wed, 24 Feb 2016 23:15:30 +0000 (00:15 +0100)]
[BUGFIX] Module recordlist: Removed call to deprecated method render()

Call of FlashMessage->render() was replaced with appropriate code if
a temporary mount point is set in DatabaseBrowser and PageLinkHandler.

Resolves: #73661
Releases: master, 7.6
Change-Id: If11b9b1a6447807ff9e567b2288c198fa0eea961
Reviewed-on: https://review.typo3.org/46884
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Use button instead of question mark for CSH in QuickEdit 24/46824/3
Daniel Goerz [Tue, 23 Feb 2016 08:44:38 +0000 (09:44 +0100)]
[TASK] Use button instead of question mark for CSH in QuickEdit

Change-Id: Ieba334b767e25c586b78dfcbe48ee1e56742596c
Resolves: #73615
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46824
Reviewed-by: Ralf Merz <info@merzilla.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Codeception login success and click about module 89/46689/6
Roland Golla [Mon, 15 Feb 2016 22:59:03 +0000 (23:59 +0100)]
[TASK] Codeception login success and click about module

Adds a test to login and logout an admin and an editor user.

Resolves: #73448
Releases: master
Change-Id: I8f7657a569230f910c58610095691b59fa45346b
Reviewed-on: https://review.typo3.org/46689
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] travis-ci: Silence selenium and php server 99/46899/2
Christian Kuhn [Thu, 25 Feb 2016 16:46:59 +0000 (17:46 +0100)]
[TASK] travis-ci: Silence selenium and php server

codeception creates fine output in case something goes wrong,
it looks as if we can throw away selenium and php server output
to console for now to have a better overview in travis again.

Change-Id: Idbc9f257fdbb41a6bb7d12c756cea5c7679852dc
Resolves: #73681
Releases: master
Reviewed-on: https://review.typo3.org/46899
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Field pageIdSelector in RTE link popup is visible when enabled 60/46460/3
Franz Kugelmann [Wed, 3 Feb 2016 13:53:55 +0000 (14:53 +0100)]
[BUGFIX] Field pageIdSelector in RTE link popup is visible when enabled

When pageIdSelector is configured to be enabled,
a new key is added to $fieldDefinitions.
But it has no effect as long as this key is not set additionally in
$this->linkAttributes.
This patch adds this missing piece.

Resolves: #73090
Releases: master, 7.6
Change-Id: I86f83bc3292144e06c7fcc179469c715c80dcb16
Reviewed-on: https://review.typo3.org/46460
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Add rel Attribute to pagination 43/46843/6
Gianluigi Martino [Tue, 23 Feb 2016 15:45:51 +0000 (16:45 +0100)]
[TASK] Add rel Attribute to pagination

Add rel="next" and rel="prev" to pagination for SEO optimization

Change-Id: Ia206b87042418f5bbe6de9a736753e9f9536ead6
Resolves: #73589
Releases: master
Reviewed-on: https://review.typo3.org/46843
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Convert colPos in backend layout wizard to number 80/46880/3
Andreas Fernandez [Wed, 24 Feb 2016 18:12:57 +0000 (19:12 +0100)]
[BUGFIX] Convert colPos in backend layout wizard to number

The method `setColumn` in the backend layout wizard sanitizes the
value by wrapping it into a <p> tag and fetching its text which strips
off any HTML. This returns a string.

However, the code later checks after performing a save action whether
the value is a number. The value gets converted to a number in
`setColumn` to recover the functionality.

Change-Id: I686657e170668adf71f278fa537aa5510e3e2241
Resolves: #73656
Releases: master
Reviewed-on: https://review.typo3.org/46880
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Remove some < PHP 7 quirks 95/46895/3
Christian Kuhn [Thu, 25 Feb 2016 14:46:57 +0000 (15:46 +0100)]
[TASK] Remove some < PHP 7 quirks

Code snippets dedicated to PHP smaller than version 7 can
be removed after requirement has been raised.

Change-Id: Id04dca218e5d12c3e6d7d2a68fa8f88a812ccf0c
Resolves: #73674
Releases: master
Reviewed-on: https://review.typo3.org/46895
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Update Install.md for TYPO3 8 and PHP 7 97/46897/2
Benni Mack [Thu, 25 Feb 2016 15:50:25 +0000 (16:50 +0100)]
[TASK] Update Install.md for TYPO3 8 and PHP 7

Resolves: #73679
Releases: master
Change-Id: Id1203471ce44dcce86777abcb5c9b444df934a49
Reviewed-on: https://review.typo3.org/46897
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[!!!][TASK] Raise PHP requirement to 7.0 78/46878/8
Christian Kuhn [Wed, 24 Feb 2016 15:58:40 +0000 (16:58 +0100)]
[!!!][TASK] Raise PHP requirement to 7.0

TYPO3 CMS 8 requires at least PHP 7.0

Change-Id: I9fad64c48270a4ac1122fb28f52da5579d46e629
Resolves: #73655
Releases: master
Reviewed-on: https://review.typo3.org/46878
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Set selected CSS class on image in RTE 82/46882/2
Markus Klein [Wed, 24 Feb 2016 20:09:55 +0000 (21:09 +0100)]
[BUGFIX] Set selected CSS class on image in RTE

Fix a copy&paste error in the javascript to set the selected class
on the image.

Resolves: #73657
Releases: master, 7.6
Change-Id: I8b7e3580185221f98d16c8fd48fe9f9fc21cfd52
Reviewed-on: https://review.typo3.org/46882
Reviewed-by: Harald <eisner.harald@online.de>
Tested-by: Harald <eisner.harald@online.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Stage buttons shown in frontend without user being repsonsible 96/46596/2
Oliver Hader [Thu, 11 Feb 2016 15:12:35 +0000 (16:12 +0100)]
[BUGFIX] Stage buttons shown in frontend without user being repsonsible

The workspace preview in the frontend shows the buttons to the previous
and next stage if the user is not responsible for the current stage.
Clicking the button does not forward the records to the names stage
however - this is caught by DataHandlerHook in EXT:version.

Resolves: #73243
Releases: master, 7.6, 6.2
Change-Id: I233629cb393d5786048ab7ead39cd3316780b488
Reviewed-on: https://review.typo3.org/46596
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] PageLinkHandler: Fix wrong function casing of sL() call 85/46885/2
Markus Klein [Thu, 25 Feb 2016 06:35:58 +0000 (07:35 +0100)]
[BUGFIX] PageLinkHandler: Fix wrong function casing of sL() call

Resolves: #73662
Releases: master, 7.6
Change-Id: I46561ecfa2186c1b065acbffe154f375b823e839
Reviewed-on: https://review.typo3.org/46885
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Missing return false in ClickMenu force browser scrolling top 77/46877/2
Frank Naegler [Wed, 24 Feb 2016 15:29:47 +0000 (16:29 +0100)]
[BUGFIX] Missing return false in ClickMenu force browser scrolling top

Resolves: #73652
Related: #73044
Releases: master
Change-Id: Iaeecf307b00bc67c2a8a598cc45d21aa95771a53
Reviewed-on: https://review.typo3.org/46877
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Remove css_styled_content as part of the factory default 51/46851/4
Wouter Wolters [Tue, 23 Feb 2016 18:42:09 +0000 (19:42 +0100)]
[BUGFIX] Remove css_styled_content as part of the factory default

Resolves: #73558
Releases: master, 7.6
Change-Id: Iaf7bdf486a0b0229233181cca8b4c7ef68bf9bbc
Reviewed-on: https://review.typo3.org/46851
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Check if user have permission to cut records 74/46774/5
Gianluigi Martino [Fri, 19 Feb 2016 12:01:51 +0000 (13:01 +0100)]
[TASK] Check if user have permission to cut records

Only show cut icons when the user has write-permissions on the
specific record.

Change-Id: I0d5a1153faf448f9c1c6c0948f2cdf8f78cab8f6
Resolves: #73564, #73472
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46774
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Acceptance login test with bad credentials 24/46624/12
Roland Golla [Fri, 12 Feb 2016 16:28:06 +0000 (17:28 +0100)]
[TASK] Acceptance login test with bad credentials

Test backend login with bad credentials and verify an
error message is rendered.

Resolves: #73213
Releases: master
Change-Id: Ic97b9a95d5d8060e2f05b89a9fc2a273ad713c05
Reviewed-on: https://review.typo3.org/46624
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] PageLayoutView: Removed call to deprecated method render() 67/46867/2
Michael Oehlhof [Tue, 23 Feb 2016 23:28:33 +0000 (00:28 +0100)]
[BUGFIX] PageLayoutView: Removed call to deprecated method render()

Call of FlashMessage->render() was replaced with appropriate code if
*CType 'list' list_type has invalid value
*CType not defined

Resolves: #73638
Releases: master, 7.6
Change-Id: Ic6342e8eae8bace4d855d6471dd2ccefd339efc1
Reviewed-on: https://review.typo3.org/46867
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Acceptance tests in controlled environment 27/46727/8
Christian Kuhn [Tue, 16 Feb 2016 19:19:26 +0000 (20:19 +0100)]
[TASK] Acceptance tests in controlled environment

To successfully run acceptance tests we need to create
a "controlled environment" that is separated from any
existing core environment. A standalone instance is
created that has its own set of loaded extensions,
an own database and an own web path.

The patch refactors and simplifies the existing set up
code of unit and functional test environments to be
better reusable to achieve this.

Change-Id: I6c4a818fa82d2723075888ad8a60b30acb5ed30e
Resolves: #68113
Releases: master
Reviewed-on: https://review.typo3.org/46727
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Use proper URL for file list of returnUrl in file_upload 29/46729/3
Benni Mack [Tue, 16 Feb 2016 19:58:36 +0000 (20:58 +0100)]
[BUGFIX] Use proper URL for file list of returnUrl in file_upload

When the file upload controller is called (which is almost
impossible to call these days) and no return URL is given
(which is again almost impossible), then the URL is invalid.

The patch uses the proper getModuleUrl() call which is
sufficient.

Resolves: #73506
Releases: master, 7.6
Change-Id: I49830e84cb10c14ccb84ea932927898899e58e70
Reviewed-on: https://review.typo3.org/46729
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[!!!][TASK] Remove possibility for index.php?32 12/46812/3
Benni Mack [Mon, 22 Feb 2016 17:07:24 +0000 (18:07 +0100)]
[!!!][TASK] Remove possibility for index.php?32

A Frontend request could previously be called with
index.php?id=[id] or just index.php?[id].

The support for calling pages through the syntax of index.php?[id]
was removed, along with the method $TSFE->setIDfromArgV.

Resolves: #73602
Releases: master
Change-Id: Ic0f0131e15e72281ab8324785c42c3887deed5cb
Reviewed-on: https://review.typo3.org/46812
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[TASK] Optimize IconRegistry and IconFactory 08/46808/5
Frank Naegler [Mon, 22 Feb 2016 12:13:17 +0000 (13:13 +0100)]
[TASK] Optimize IconRegistry and IconFactory

Add a runtime cache for icons and remove the calls to getDeprecationSettings.

Resolves: #73606
Releases: master
Change-Id: I28fe3721db105cbd41c8beb45afc36903e3f945f
Reviewed-on: https://review.typo3.org/46808
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[TASK] Clipboard: Use new modal confirmation dialog for "Delete Elements" 97/45997/8
Michael Oehlhof [Sat, 16 Jan 2016 11:08:09 +0000 (12:08 +0100)]
[TASK] Clipboard: Use new modal confirmation dialog for "Delete Elements"

Clipboard: Use new modal confirmation dialog for the menu item
"Delete Elements"

Resolves: #72350
Releases: master, 7.6
Change-Id: Icb4a9c428802af4bc09152010b264c1c02b2eb74
Reviewed-on: https://review.typo3.org/45997
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Update DataTables to 1.10.1 49/46849/2
Wouter Wolters [Tue, 23 Feb 2016 18:28:31 +0000 (19:28 +0100)]
[TASK] Update DataTables to 1.10.1

Resolves: #73627
Releases: master
Change-Id: I017c97bf415b630d183d91086ae17e66295e6a1b
Reviewed-on: https://review.typo3.org/46849
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Scheduler: Removed call to deprecated method render() 58/46658/3
Michael Oehlhof [Sun, 14 Feb 2016 19:40:03 +0000 (20:40 +0100)]
[BUGFIX] Scheduler: Removed call to deprecated method render()

Call of FlashMessage->render() if the task object is not valid
was replaced with appropriate code.

Resolves: #73427
Releases: master, 7.6
Change-Id: I2f21e46814d369519756f35b27ee7b546a6b6938
Reviewed-on: https://review.typo3.org/46658
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Translate permission labels in DragUploader 56/46856/2
Wouter Wolters [Tue, 23 Feb 2016 19:40:19 +0000 (20:40 +0100)]
[BUGFIX] Translate permission labels in DragUploader

Resolves: #73464
Releases: master,7.6
Change-Id: Ibe2579552703c30eda2e22c8ef6caf738da18265
Reviewed-on: https://review.typo3.org/46856
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Remove aboutmodules icon from Gruntfile.js 50/46850/2
Wouter Wolters [Tue, 23 Feb 2016 18:33:40 +0000 (19:33 +0100)]
[TASK] Remove aboutmodules icon from Gruntfile.js

The module has been merged into EXT:about

Resolves: #73633
Releases: master
Change-Id: I931113ee7ca7454c2a5fd6d8a1e83b5dabed08cc
Reviewed-on: https://review.typo3.org/46850
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Fix old classnames in extensionmanager 58/46858/2
Stephan Großberndt [Tue, 23 Feb 2016 20:11:40 +0000 (21:11 +0100)]
[TASK] Fix old classnames in extensionmanager

Fix documentation in extensionmanager pointing to outdated classnames.

Releases: master, 7.6
Resolves: #73636
Change-Id: Idfd277cde8674dc7a6fae7eb7786150a941ad0ba
Reviewed-on: https://review.typo3.org/46858
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Set correct variable type in Extension model 48/46848/3
Wouter Wolters [Tue, 23 Feb 2016 18:20:25 +0000 (19:20 +0100)]
[BUGFIX] Set correct variable type in Extension model

In the Extension model from the extension manager the variable type of
$dependencies is wrong. This should be
\TYPO3\CMS\Extensionmanager\Domain\Model\Dependency
instead of Tx_Extensionmanager_Utility_Dependency.

Resolves: #73624
Releases: master, 7.6
Change-Id: Ibbdd9933ff6c312ad7759574be425b4e57eb1f04
Reviewed-on: https://review.typo3.org/46848
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Check correctly if showitem key exists in TcaMigration 52/46852/2
Wouter Wolters [Tue, 23 Feb 2016 19:02:18 +0000 (20:02 +0100)]
[BUGFIX] Check correctly if showitem key exists in TcaMigration

Resolves: #73529
Releases: master, 7.6
Change-Id: Id4f6558b1130bcff8e70f1f0e0dfe38645d33c7f
Reviewed-on: https://review.typo3.org/46852
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[SECURITY] Limit the search results per page 36/46836/2
Benni Mack [Tue, 23 Feb 2016 10:45:57 +0000 (11:45 +0100)]
[SECURITY] Limit the search results per page

Indexed Search allows to show up to 100.000
entries per page by configuring the paging
entry via a GET/POST variable, leading to a
possible DoS attack.

The max limit is set to 100 entries per page,
as a reasonable limit for the website search
results.

Resolves: #73458
Releases: master, 7.6, 6.2
Security-Commit: ea0c1c4377b1111e4a822981a6a948b96dc0215f
Security-Bulletins: TYPO3-CORE-SA-2016-005, 006, 007, 008
Change-Id: I7d2ff1c3ba388a9bfc0be0cd905a8e24a14f13d8
Reviewed-on: https://review.typo3.org/46836
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] Escape output of tt_content.default 35/46835/2
Georg Ringer [Tue, 23 Feb 2016 10:45:39 +0000 (11:45 +0100)]
[SECURITY] Escape output of tt_content.default

Escape the value of the field CType in tt_content.default.

Resolves: #73450
Releases: master, 7.6, 6.2
Security-Commit: fa4f42b5e20e08fa154be29de867e1c01d4f7e1c
Security-Bulletins: TYPO3-CORE-SA-2016-005, 006, 007, 008
Change-Id: Iaa185caac5e08d3ba03121b45edca2fd98afa741
Reviewed-on: https://review.typo3.org/46835
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[SECURITY] XML entity expansion 34/46834/2
Benni Mack [Tue, 23 Feb 2016 10:45:30 +0000 (11:45 +0100)]
[SECURITY] XML entity expansion

Remote XML entites can be loaded in places where TYPO3 expects
only local files to be fetched. All places are changed so
the option to load entities is disabled.

Resolves: #61269
Releases: master, 7.6, 6.2
Security-Commit: 736a7ef0823893047843c6a7f5e72b220bfd4697
Security-Bulletins: TYPO3-CORE-SA-2016-005, 006, 007, 008
Change-Id: I26701fc2ffb5aed7ccbd96c168aef571d012091e
Reviewed-on: https://review.typo3.org/46834
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] RTE Image Wizard 97/45697/10
Markus Klein [Tue, 15 Dec 2015 10:12:32 +0000 (11:12 +0100)]
[BUGFIX] RTE Image Wizard

Make inserting/editing images in RTE possible again.

Resolves: #71494
Releases: master, 7.6
Change-Id: If561562d9330c39544b7bd514a273641538d03f8
Reviewed-on: https://review.typo3.org/45697
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Check correctly for allowed localization action 53/46753/4
Andreas Fernandez [Thu, 18 Feb 2016 11:47:03 +0000 (12:47 +0100)]
[BUGFIX] Check correctly for allowed localization action

The localization wizard currently disallows creating copies if a column
has elements. There are now two flags which influence the allowed
actions. The wizard now checks whether there are translations or
standalone content elements and negates one of the flags.

Change-Id: Ief40d311959943f2f7e901b80e4b29931f2894d2
Resolves: #73538
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46753
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Ralf Merz <info@merzilla.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[TASK] Replace JavaScript confirm dialog in User settings 10/46810/4
Frank Naegler [Mon, 22 Feb 2016 14:36:34 +0000 (15:36 +0100)]
[TASK] Replace JavaScript confirm dialog in User settings

This patch replaces the old JavaScript confirm dialog in user settings
module, which was used on the button "Reset Configuration and
Clear Temporary Data".

Resolves: #73600
Releases: master, 7.6
Change-Id: I24f872c5828aebfa08b2936e64abf57713182fbc
Reviewed-on: https://review.typo3.org/46810
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] IRRE child records cannot be synchronized/localized correctly 13/46813/3
Oliver Hader [Mon, 22 Feb 2016 17:14:29 +0000 (18:14 +0100)]
[BUGFIX] IRRE child records cannot be synchronized/localized correctly

IRRE child records are not synchronized or localized inside a localized
parent record. The DataHandler command contains the target language that
shall be used for the new localized child elements. Since currently an
array is transmitted, all localized children are created for the first
language (sys_language_uid=1), which is the result of "(int)array(123)".

Resolves: #71596
Releases: master, 7.6
Change-Id: Ic34380c7f773449b62bd1e14318f1ea8c081536f
Reviewed-on: https://review.typo3.org/46813
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Ralf Merz <info@merzilla.de>
Tested-by: Ralf Merz <info@merzilla.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Remove adodb diff 15/46815/2
Christian Kuhn [Mon, 22 Feb 2016 19:58:33 +0000 (20:58 +0100)]
[TASK] Remove adodb diff

There is a list of patches we applied to adodb manually in
typo3/sysext/adodb/Documentation/Index.rst. This, together
with 'git log' should be enough in case adodb is updated.
The diff file is pain to maintain and also does not
contain all changes that were done to adodb.

Change-Id: If0525ce90b637541d659569f697377f011b8ad37
Resolves: #73607
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46815
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Switch ViewHelper restored for safe deprecation 48/46548/5
Claus Due [Tue, 9 Feb 2016 20:00:32 +0000 (21:00 +0100)]
[BUGFIX] Switch ViewHelper restored for safe deprecation

This change restores the previous f:switch and f:case
ViewHelpers. Once deprecation period for f:case argument
"default" is over both classes can be safely deleted.

Change-Id: Ie0d79ef69d145e851f4f27187696a5a5297b3a80
Resolves: #73197
Releases: master
Reviewed-on: https://review.typo3.org/46548
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] User settings: Removed call to deprecated method render() 94/46794/5
Michael Oehlhof [Sat, 20 Feb 2016 22:42:41 +0000 (23:42 +0100)]
[BUGFIX] User settings: Removed call to deprecated method render()

Call of FlashMessage->render() was replaced with appropriate code when
* setup was saved
* temporary data was cleared
* Notice for activated changes
* password is updated
* selected language is not available

Resolves: #73581
Releases: master, 7.6
Change-Id: I68432729334eb905e3aae112d42ae45177a70809
Reviewed-on: https://review.typo3.org/46794
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Fix minor flaws in wizard component 88/46788/7
Andreas Fernandez [Fri, 19 Feb 2016 20:48:20 +0000 (21:48 +0100)]
[BUGFIX] Fix minor flaws in wizard component

After closing the wizard the internal settings object stays an object and
is not converted to an array.

Wizard.getComponent() now generates the markup if Wizard.show()
was not called before. Also, the method now returns only the generated
markup and not the (missing) modal window.

Also, the events of the wizard component are now used and not the
bootstrap modal events.

The documentation is adjusted a bit and Localization.js is fixed.

Change-Id: I0f7efd5f50247ae70fbd14600ce204c22949703d
Resolves: #73575
Releases: master
Reviewed-on: https://review.typo3.org/46788
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] feedit: Double encoding of labels 47/46247/5
Christian Weiske [Tue, 26 Jan 2016 15:08:20 +0000 (16:08 +0100)]
[BUGFIX] feedit: Double encoding of labels

Translated labels containing UTF-8 characters were double-encoded
in frontend editing.

extGetLL() already runs htmlspecialchars() on labels, so we do not have
to do that again in FrontendEditPanel.
This fixes the titles of the admin panel buttons.

Also, since we can expect all pages to be UTF-8 now, we can drop the forced
conversion of UTF-8 characters to XML entities.
This fixes the confirmation popup texts.

Resolves: #63131
Releases: master, 7.6
Change-Id: I49faff20ff4da8434868534d566c0d3da85e30c6
Reviewed-on: https://review.typo3.org/46247
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Weiske <typo3@cweiske.de>
Tested-by: Christian Weiske <typo3@cweiske.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
3 years ago[!!!][TASK] Make TimeTracker a singleton 20/46520/11
Benni Mack [Mon, 8 Feb 2016 19:47:08 +0000 (20:47 +0100)]
[!!!][TASK] Make TimeTracker a singleton

By declaring the TimeTracker class as singleton, there is no
need anymore for $GLOBALS['TT'].

Change-Id: I412fbdcbd2c60dcaae4dc592bea48a7d059f7e95
Resolves: #73504
Releases: master
Reviewed-on: https://review.typo3.org/46520
Reviewed-by: Michiel Roos <michiel@maxserv.com>
Tested-by: Michiel Roos <michiel@maxserv.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
3 years ago[BUGFIX] Linkvalidator: Removed call to deprecated method render() 92/46792/2
Michael Oehlhof [Sat, 20 Feb 2016 00:02:16 +0000 (01:02 +0100)]
[BUGFIX] Linkvalidator: Removed call to deprecated method render()

Call of FlashMessage->render() if user not have access to these listings
and when no broken links to be displayed were replaced with appropriate
code.

Resolves: #73576
Releases: master, 7.6
Change-Id: I86ce5c1dd49ea40aeb26be8f9da1060b1f6dc65d
Reviewed-on: https://review.typo3.org/46792
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Form wizard: Removed call to deprecated method render() 65/46765/2
Michael Oehlhof [Thu, 18 Feb 2016 22:59:25 +0000 (23:59 +0100)]
[BUGFIX] Form wizard: Removed call to deprecated method render()

Call of FlashMessage->render() if no reference to record
was replaced with appropriate code.

Resolves: #73546
Releases: master, 7.6
Change-Id: I3fa0285ccd68d7a62d63df60b488bb1fb561a243
Reviewed-on: https://review.typo3.org/46765
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[FEATURE] Add wizard component 51/46651/11
Andreas Fernandez [Sun, 14 Feb 2016 16:20:45 +0000 (17:20 +0100)]
[FEATURE] Add wizard component

This patch adds a wizard component. The component allows
to add "slides" combined with a callback.

The localization wizard used in the Page module is converted
to the module wizard.

Change-Id: Id60830370a85ced2425c14a593352a9f165ff4c2
Resolves: #73429
Releases: master
Reviewed-on: https://review.typo3.org/46651
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Add missing new_content_element overrides in PageLayoutView 81/46681/5
Richard Haeser [Mon, 15 Feb 2016 19:50:33 +0000 (20:50 +0100)]
[BUGFIX] Add missing new_content_element overrides in PageLayoutView

Add the missing override possibilities in PageLayoutView as introduced
by issue #70055. Also add check if the override attribute of
newContentElementWizard is set in the tsConfig array.

Change-Id: Iaa5952c3dedca2b3dfec84e36d55e453e7ad690e
Resolves: #73444
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46681
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Unit tests for getFileAbsFileName 83/46783/2
Christian Kuhn [Fri, 19 Feb 2016 16:26:31 +0000 (17:26 +0100)]
[TASK] Unit tests for getFileAbsFileName

Change-Id: If2d8c342e6632ab86a7744ac6d019fcc1f7af74c
Resolves: #73572
Related: #73516
Releases: master
Reviewed-on: https://review.typo3.org/46783
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Re-allow minor symfony dependencies 41/46741/3
Nicole Cordes [Wed, 17 Feb 2016 10:04:22 +0000 (11:04 +0100)]
[TASK] Re-allow minor symfony dependencies

Some extensions have a dependency to symfony/console or symfony/finder
versions lower than 3.0. As there is no specific need to enforce
versions 3.0, we can re-allow versions 2.7 and 2.8 as well.

Resolves: #73517
Releases: master
Change-Id: I91fe74c7e46bf6d9dbea52ab2d86d1caa10e33c3
Reviewed-on: https://review.typo3.org/46741
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[!!!][TASK] Drop usage of TypoScript includeLibs 39/46739/4
Benni Mack [Tue, 16 Feb 2016 23:44:40 +0000 (00:44 +0100)]
[!!!][TASK] Drop usage of TypoScript includeLibs

The TypoScript option includeLibs within
USER/USER_INT and COA/COA_INT is removed.

The methods
$TSFE->includeLibraries() and $cObj->includeLibs()
have been marked as deprecated.

ExtensionManagementUtility::addPItoST43() does not add
the option "includeLibs" to the TypoScript anymore. Its second
method parameter is unused now.

Resolves: #73514
Releases: master
Change-Id: I613cd4fc7a8239c9a090242e3db7e45ec95bc322
Reviewed-on: https://review.typo3.org/46739
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Add keyboard binding in install tool for all configuration search 71/46771/2
Frank Naegler [Fri, 19 Feb 2016 11:02:00 +0000 (12:02 +0100)]
[TASK] Add keyboard binding in install tool for all configuration search

If the all configuration module is open and the new filter searchbox is available,
the keyboard shortcuts cmd+f / ctrl+f are used to focus the filter field.

Resolves: #73560
Releases: master, 7.6
Change-Id: Ifeb726819a3b7b1a3e03271be836d4b61aa85fa0
Reviewed-on: https://review.typo3.org/46771
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Avoid session file race-condition in Install Tool 50/46750/4
Markus Klein [Thu, 18 Feb 2016 00:23:24 +0000 (01:23 +0100)]
[BUGFIX] Avoid session file race-condition in Install Tool

Implement proper locking when accessing the session data file
to avoid race-conditions, which cause random logouts.

Resolves: #73531
Releases: master, 7.6
Change-Id: Ibc14ff771602601fd38af582c1b8a15e3f6dfb4b
Reviewed-on: https://review.typo3.org/46750
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Make text translatable in ShortcutMenu JavaScript 28/46728/4
Wouter Wolters [Tue, 16 Feb 2016 19:48:30 +0000 (20:48 +0100)]
[TASK] Make text translatable in ShortcutMenu JavaScript

Resolve the todo's for translations and notification.

Resolves: #73505
Releases: master, 7.6
Change-Id: I43cb48fcd7efeb388ed5c54c9df7464ee4e0472d
Reviewed-on: https://review.typo3.org/46728
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[TASK] Move "Save and close" to the last position in scheduler 72/46772/3
Andreas Fernandez [Fri, 19 Feb 2016 11:07:59 +0000 (12:07 +0100)]
[TASK] Move "Save and close" to the last position in scheduler

The "Save and close" link in the split button for scheduler tasks
is moved to the last position to ensure a more consistent UI.

The "Save and close" is at the last position when editing pages,
content elements etc.

Change-Id: I649dd2941a64ea11183eb5e8711b490933481c35
Resolves: #73561
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46772
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Ralf Merz <info@merzilla.de>
Reviewed-by: Richard Haeser <richardhaeser@gmail.com>
Tested-by: Richard Haeser <richardhaeser@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Switch acceptance tests to cest format 84/46684/4
Roland Golla [Mon, 15 Feb 2016 20:14:34 +0000 (21:14 +0100)]
[TASK] Switch acceptance tests to cest format

Cest is the format recommended by codeception. It allows
more control and better abstraction.

Resolves: #73525
Releases: master
Change-Id: Icf434fd53af5653890a5174dc478d647c1bffd1c
Reviewed-on: https://review.typo3.org/46684
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Move Modal.getSeverityClass to Severity module 78/46678/8
Andreas Fernandez [Mon, 15 Feb 2016 17:22:35 +0000 (18:22 +0100)]
[TASK] Move Modal.getSeverityClass to Severity module

The method ``Modal.getSeverityClass`` is moved to the severity
module. The new method is called `Severity.getCssClass`.

Change-Id: I826ed7ff66ad726de8a97b0b1f0ace45d776d11c
Resolves: #73442
Releases: master
Reviewed-on: https://review.typo3.org/46678
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Render correct colPos in section menus again 45/46745/4
Daniel Goerz [Wed, 17 Feb 2016 12:31:12 +0000 (13:31 +0100)]
[BUGFIX] Render correct colPos in section menus again

Resolves: #73521
Related: #71733
Releases: master, 7.6
Change-Id: Iddaea99304a3ab2ae69153a4da12c210adeda6f1
Reviewed-on: https://review.typo3.org/46745
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Fix save and view page for a new page record 36/46736/3
Wouter Wolters [Tue, 16 Feb 2016 22:24:58 +0000 (23:24 +0100)]
[BUGFIX] Fix save and view page for a new page record

The current page id is not set correctly because the popViewId
contains not the uid of the created page. Because it is meant
to fetch the uid of the current page anyway we can
use the record id.

Resolves: #73428
Resolves: #73475
Releases: master,7.6
Change-Id: I4c34547d9a9cf8acd1de01473e931d0fb6a634d8
Reviewed-on: https://review.typo3.org/46736
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Move BE Login BrowserLanguage detection to Locales 34/46734/2
Benni Mack [Tue, 16 Feb 2016 21:59:59 +0000 (22:59 +0100)]
[TASK] Move BE Login BrowserLanguage detection to Locales

The CharsetConverter contains the calculation to find the
right language based on the browsers language settings
if no backend user has been logged in (Backend Login),
and chooses the TYPO3 language based on that.

This code does not belong to the CharsetConverter but
rather to the locales object.

Resolves: #73511
Releases: master
Change-Id: I4361d0e3a842efd0c5b69837776fe0c397edd593
Reviewed-on: https://review.typo3.org/46734
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Thomas Schlumberger <thomas@b13.de>
Tested-by: Thomas Schlumberger <thomas@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Remove leftover backPath and thumbs.php variables 38/46738/2
Benni Mack [Tue, 16 Feb 2016 22:33:32 +0000 (23:33 +0100)]
[TASK] Remove leftover backPath and thumbs.php variables

Resolves: #73512
Releases: master
Change-Id: Ib0add5b4a07bd43a68a46d29fe0f13d448240966
Reviewed-on: https://review.typo3.org/46738
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Thomas Schlumberger <thomas@b13.de>
Tested-by: Thomas Schlumberger <thomas@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Discourage usage of $LANG->csConvObj and parserFactory 08/46708/5
Benni Mack [Tue, 16 Feb 2016 11:45:29 +0000 (12:45 +0100)]
[TASK] Discourage usage of $LANG->csConvObj and parserFactory

The csConvObj is decoupled from LanguageService and
not used directly anymore.

Any calls directly to the property csConvObj should be avoided
as was marked as deprecated.

Same goes with the property "parserFactory" of the
LanguageService class. The parser factory is not called
from the language object anymore and the property can be
removed.

Resolves: #73482
Releases: master
Change-Id: I94d7fca658c2b9e8cffc62f5bdb0c5ce83c894a2
Reviewed-on: https://review.typo3.org/46708
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] Catch submit event while saving shortcut with enter 26/46726/2
Wouter Wolters [Tue, 16 Feb 2016 19:10:17 +0000 (20:10 +0100)]
[BUGFIX] Catch submit event while saving shortcut with enter

To save the shortcut with an enter in the input field we need to
catch the submit event and use the same save mechanism as when
using the submit button.

Resolves: #73477
Releases: master,7.6
Change-Id: Icbe78ca2e3082e9eb9aa7a2b70c362d0aaa43934
Reviewed-on: https://review.typo3.org/46726
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] travis-ci on PHP7 only 32/46732/2
Christian Kuhn [Tue, 16 Feb 2016 20:51:48 +0000 (21:51 +0100)]
[TASK] travis-ci on PHP7 only

TYPO3 CMS 8 will rely on PHP version 7. Previous PHP version
tests can be removed from travis-ci.

Change-Id: I976b33d8a50c6ab7a97a45e6828229df531a82cd
Resolves: #73509
Releases: master
Reviewed-on: https://review.typo3.org/46732
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Remove backPath from compressor 25/46725/5
Benni Mack [Tue, 16 Feb 2016 19:09:26 +0000 (20:09 +0100)]
[TASK] Remove backPath from compressor

Resolves: #73502
Releases: master
Change-Id: Ic22688bc426725ff95a414600f740d19a82530ce
Reviewed-on: https://review.typo3.org/46725
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Update Fluid dependency to 1.0.4 33/46733/2
Claus Due [Tue, 16 Feb 2016 21:28:09 +0000 (22:28 +0100)]
[TASK] Update Fluid dependency to 1.0.4

This change updates the composer dependency for typo3fluid/fluid
to version 1.0.4 which solves:

https://github.com/TYPO3Fluid/Fluid/pull/69
https://github.com/TYPO3Fluid/Fluid/pull/75

Change-Id: I6340b0d93b4b70b5e1e13dd7a2f5d177af8b7c02
Resolves: #73510
Releases: master
Reviewed-on: https://review.typo3.org/46733
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Absolute web path in acceptance test 31/46731/2
Christian Kuhn [Tue, 16 Feb 2016 20:14:59 +0000 (21:14 +0100)]
[BUGFIX] Absolute web path in acceptance test

Change-Id: I0dbf8514bd3b7dc7d182dde5d6e52f451bc79c42
Resolves: #73507
Related: #73479
Releases: master
Reviewed-on: https://review.typo3.org/46731
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Don't convert labels for charsets in Extbase/Fluid 11/46711/2
Benni Mack [Tue, 16 Feb 2016 13:01:45 +0000 (14:01 +0100)]
[BUGFIX] Don't convert labels for charsets in Extbase/Fluid

When Extbase/Fluid initially were introduced, it was possible
to store non-UTF8-data in the database. A charset array within
CharsetConverter checked if a special language (e.g. russian)
had its own character set. The LocalizationUtility then converted
the value from the original character set to utf-8 which is not
needed anymore, as every input data is expected to be UTF-8.

Labels coming from TypoScript are now expected to be UTF-8  as well.

Resolves: #73487
Releases: master, 7.6
Change-Id: I2292c587b7709257d8efcb58f4e5c0a4c191c944
Reviewed-on: https://review.typo3.org/46711
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Tested-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Code cleanup for AbstractUserAuthentication 22/46722/2
Benni Mack [Tue, 16 Feb 2016 16:53:51 +0000 (17:53 +0100)]
[TASK] Code cleanup for AbstractUserAuthentication

This is a pre-patch for the session backend patch.

Resolves: #73500
Releases: master
Change-Id: I7454673d5063c2d77069f790014ede8e86589585
Reviewed-on: https://review.typo3.org/46722
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Remove unused variable includeHierarchy 18/46718/2
Wouter Wolters [Tue, 16 Feb 2016 15:09:07 +0000 (16:09 +0100)]
[TASK] Remove unused variable includeHierarchy

The variable includeHierarchy in BackendUserAuthentication was unused
even in TYPO3 4.5, and is not in use in any TER extension. This piece
of code can safely be removed without breaking anything.

Resolves: #73496
Releases: master
Change-Id: I33117977ec5ae08eddf2a4533ef0f54d983cea14
Reviewed-on: https://review.typo3.org/46718
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
3 years ago[BUGFIX] Correctly add backend.css after extRelPath change 03/46703/5
Patrick Schriner [Tue, 16 Feb 2016 10:59:43 +0000 (11:59 +0100)]
[BUGFIX] Correctly add backend.css after extRelPath change

Due to wrong calculation of the file path the CSS files doesn't get
added any more.

Change-Id: I84391d6e9d318b285b0a22bc70e170c8a2505da9
Resolves: #73479
Releases: master
Reviewed-on: https://review.typo3.org/46703
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Use correct palettes for pages.media sys_file_references 13/46713/3
Benni Mack [Tue, 16 Feb 2016 13:42:49 +0000 (14:42 +0100)]
[BUGFIX] Use correct palettes for pages.media sys_file_references

When using pages.media and videos / audios, then the wrong
fields for a palette are shown.

The patch changes the palettes to use the same as in e.g.
tt_content.assets.

Resolves: #73489
Releases: master, 7.6
Change-Id: Ifa1fd44e3ffd9a498aaf05dc34f59b6777c8c299
Reviewed-on: https://review.typo3.org/46713
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[SECURITY] XSS in Link Validator 98/46698/2
Steffen Müller [Tue, 16 Feb 2016 10:44:06 +0000 (11:44 +0100)]
[SECURITY] XSS in Link Validator

Properly escape error message when showing broken links
in EXT:linkvalidator

Resolves: #72240
Releases: master, 7.6, 6.2
Security-Commit: 04451826c9017729dbf02ffdb605efe0ad24e19e
Security-Bulletinsp: TYPO3-CORE-SA-2016-001, 002, 003, 004
Change-Id: I21b2b803fd19f149010dd47e7d84b3890fd590b3
Reviewed-on: https://review.typo3.org/46698
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[!!!][TASK] Remove flashmessage_compatibility.js from core 83/46683/3
Frank Naegler [Mon, 15 Feb 2016 20:04:05 +0000 (21:04 +0100)]
[!!!][TASK] Remove flashmessage_compatibility.js from core

The flashmessage_compatibility.js is deprecated since TYPO3 7 and is now
removed from core.

The deprecated flashmessage_compatibility.js is loaded at first and takes
place in ``TYPO3.Severity``. The singleton check of
``TYPO3/CMS/Backend/Severity`` detects that ``TYPO3.Severity`` is already
existing and stops the execution. In fact, ``TYPO3/CMS/Backend/Severity``
is never used.

Resolves: #73445
Releases: master
Change-Id: I87982cd9b6880448d430c77bd16ddfbb4bdc7991
Reviewed-on: https://review.typo3.org/46683
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Replace csConvObj calls 27/46627/4
Benni Mack [Fri, 12 Feb 2016 17:10:35 +0000 (18:10 +0100)]
[TASK] Replace csConvObj calls

The CharsetConverter object is agnostic
of charset and environment, and a singleton on top.

There are still several calls in the TYPO3 core
that tries to fetch csConv from TSFE or LANG
which relies heavily on the environment.

The calls are replaced with simple instance
calls where possible.

Resolves: #73441
Releases: master
Change-Id: I098f17b1cdbcc1ebbbb7359cfec518c93597aad4
Reviewed-on: https://review.typo3.org/46627
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] ManageReferenceIndex: Removed call to deprecated method render() 36/46636/2
Michael Oehlhof [Sat, 13 Feb 2016 00:07:12 +0000 (01:07 +0100)]
[BUGFIX] ManageReferenceIndex: Removed call to deprecated method render()

Call of FlashMessage->render() was replaced with appropriate code.

Resolves: #73420
Releases: master, 7.6
Change-Id: Id6ec612974a1813bf8becd843d25a48b663766aa
Reviewed-on: https://review.typo3.org/46636
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Recordlist: Removed call to deprecated method render() 37/46637/2
Michael Oehlhof [Sat, 13 Feb 2016 13:52:02 +0000 (14:52 +0100)]
[BUGFIX] Recordlist: Removed call to deprecated method render()

Call of FlashMessage->render() if no records are on the page
was replaced with appropriate code.

Resolves: #73421
Releases: master, 7.6
Change-Id: If10a5a0ec4f71df6008369c83a9ab6a56c812d4e
Reviewed-on: https://review.typo3.org/46637
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Function menu: Removed call to deprecated method render() 81/46581/3
Michael Oehlhof [Wed, 10 Feb 2016 22:12:39 +0000 (23:12 +0100)]
[BUGFIX] Function menu: Removed call to deprecated method render()

Call of FlashMessage->render() if no modules have been registered
was replaced with appropriate code.

Resolves: #73221
Releases: master, 7.6
Change-Id: I982e2d7d5b677e77a7f170a505f426780ac77089
Reviewed-on: https://review.typo3.org/46581
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Add logic to include languageLablelFiles via return structure 34/46434/4
Frank Naegler [Mon, 1 Feb 2016 15:56:43 +0000 (16:56 +0100)]
[TASK] Add logic to include languageLablelFiles via return structure

Adds a structure to accept language files like EXT:foo/bar.xlf
in FormEngine elements that are added in inline ajax and on
page load.

Since it is very hard for FormEngine element developers to
handle this case without bugs in own code and renders label
handling useless otherwise, this patch is requested for 7.6, too.

Resolves: #73072
Releases: master, 7.6
Change-Id: Icbfe707000931037b9579bb8bc6a96dfca023d3e
Reviewed-on: https://review.typo3.org/46434
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Reallow custom request context in getUrl 08/46208/3
Sascha Egerer [Sun, 24 Jan 2016 11:23:40 +0000 (12:23 +0100)]
[BUGFIX] Reallow custom request context in getUrl

In b4813ddb55ab789ddd13e02234f147a44d2af1ed an patch
has been introduced which respects the default stream context
when requesting urls. But the change prevents that custom
stream options (headers) can be set.

The default stream context should be used and extended by the
given custom headers.

Change-Id: I6ec6d23498e194055cefc1c6c63db7c161ee03c6
Resolves: #72907
Related: #70374
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46208
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Ralf Merz <info@merzilla.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Restore update wizard to add TER repository in EM 03/46303/6
Wouter Wolters [Thu, 28 Jan 2016 22:29:23 +0000 (23:29 +0100)]
[BUGFIX] Restore update wizard to add TER repository in EM

This adds the update wizard again for TER repository in EM.

Resolves: #72917
Releases: master, 7.6
Change-Id: I1d4d6750c1e989a4ca3fadbcf6e753555ae26f5f
Reviewed-on: https://review.typo3.org/46303
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Acceptance tests with travis-ci 60/46660/5
Christian Kuhn [Sun, 14 Feb 2016 11:15:26 +0000 (12:15 +0100)]
[TASK] Acceptance tests with travis-ci

Set up a basic test system in .travis.yml to run
the login acceptance test with selenium and
phantomjs headless browser in travis-ci.

Change-Id: I944ec6ffcf73e4a138271303dfce8aa7aa121b26
Resolves: #68110
Releases: master
Reviewed-on: https://review.typo3.org/46660
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[TASK] Prophecy update from 1.5.0 to 1.6.0 65/46665/2
Christian Kuhn [Mon, 15 Feb 2016 09:33:44 +0000 (10:33 +0100)]
[TASK] Prophecy update from 1.5.0 to 1.6.0

Change-Id: I22f53a2be313ae3306a54a0983efda14285b725f
Resolves: #73430
Releases: master
Reviewed-on: https://review.typo3.org/46665
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Stick psr/log version to 1.0.0 in composer.json 26/46626/3
Frank Naegler [Fri, 12 Feb 2016 17:08:55 +0000 (18:08 +0100)]
[TASK] Stick psr/log version to 1.0.0 in composer.json

Resolves: #73382
Releases: master
Change-Id: I606a6be641c16edc23cace307d326aad78ceeaf1
Reviewed-on: https://review.typo3.org/46626
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Enable file upload from Frontend context 04/46504/3
Xavier Perseguers [Fri, 5 Feb 2016 16:31:45 +0000 (17:31 +0100)]
[BUGFIX] Enable file upload from Frontend context

Change-Id: Ie2bf887fc9ec49f39af1ffe85bf0aea69c29fe8c
Releases: master, 7.6
Resolves: #73154
Reviewed-on: https://review.typo3.org/46504
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
3 years ago[TASK] Avoid hardcoded path for file list icons 07/46407/2
Mathias Brodala [Sat, 30 Jan 2016 16:57:31 +0000 (17:57 +0100)]
[TASK] Avoid hardcoded path for file list icons

Resolves: #73038
Releases: master
Change-Id: I1816693076689df16552e216ebf4fdc9e927a502
Reviewed-on: https://review.typo3.org/46407
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] Indexed Search: Data too long for column 'cookie' 43/46643/3
Wouter Wolters [Sat, 13 Feb 2016 16:28:01 +0000 (17:28 +0100)]
[BUGFIX] Indexed Search: Data too long for column 'cookie'

The Extbase version tries to write a 32 character
hash into the column. Make it varchar(32)

Resolves: #72909
Releases: master,7.6
Change-Id: I007e4f6b6c191c3a2d62492d13593e2ae266e446
Reviewed-on: https://review.typo3.org/46643
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[TASK] Enable codeception and add simple mouse test 66/46566/5
Roland Golla [Wed, 10 Feb 2016 09:40:01 +0000 (10:40 +0100)]
[TASK] Enable codeception and add simple mouse test

Resolves: #73216
Releases: master
Change-Id: I0390afebbf296748452dd85a0fd5f34fb53adff4
Reviewed-on: https://review.typo3.org/46566
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Data in request may be null instead of an array 29/46229/2
Xavier Perseguers [Mon, 25 Jan 2016 14:24:46 +0000 (15:24 +0100)]
[BUGFIX] Data in request may be null instead of an array

Change-Id: I85f8c80ca29a7795242c9c284f235c6520b2a72d
Releases: master, 7.6
Resolves: #72933
Reviewed-on: https://review.typo3.org/46229
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] InvalidArgumentException in PaginateViewHelper 63/46463/3
Patrick Schriner [Wed, 3 Feb 2016 14:52:33 +0000 (15:52 +0100)]
[BUGFIX] InvalidArgumentException in PaginateViewHelper

The argument validation of Standalone Fluids AbstractViewHelper
fails for methods defining arguments with multiple types, like
@param QueryResultInterface|ObjectStorage|array.

To solve this, the corresponding argument definition of the argument
$objects in the PaginateViewHelper has been changed to mixed.
Type validation of the $objects argument is done inside
the corresponding method.

Change-Id: I2f0a36e0cdb36657a96636b5c1af1def76b8b775
Resolves: #73105
Related: #73048
Releases: master
Reviewed-on: https://review.typo3.org/46463
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Fixed Exception when updating the ReferenceIndex 35/46635/3
Michael Oehlhof [Fri, 12 Feb 2016 23:49:19 +0000 (00:49 +0100)]
[BUGFIX] Fixed Exception when updating the ReferenceIndex

Now there is no Exception if a table has no columns definition.

Resolves: #73419
Releases: master,7.6
Change-Id: Iedbdb3073f7b6a72baa7263966dfa3c493bdb89c
Reviewed-on: https://review.typo3.org/46635
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>