Packages/TYPO3.CMS.git
18 months ago[BUGFIX] Error in record info when displaying references 17/56217/2
Saskia Schreiber [Fri, 16 Mar 2018 12:10:06 +0000 (13:10 +0100)]
[BUGFIX] Error in record info when displaying references

This fixes the regression introduced in task #84284
(PSR-7 rewrite of ElementInformationController).

getRecordActions() expects the full request as third parameter,
not the requestUri parameter.

Resolves: #84342
Related: #84284
Releases: master
Change-Id: I8fe91098cadfeaf7c90edf202c2ad7e2aa039abe
Reviewed-on: https://review.typo3.org/56217
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make WidgetRequestBuilderTest notice free 04/56204/3
Jan Helke [Fri, 16 Mar 2018 09:11:43 +0000 (10:11 +0100)]
[TASK] Make WidgetRequestBuilderTest notice free

It also throws now an exception, is no fluid-widget-id was given.
Also this exception is covered by a test.

Releases: master
Resolves: #84329
Change-Id: Ibeb7a404f2ab2ebfa0b233279facee978ded41aa
Reviewed-on: https://review.typo3.org/56204
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Use ServerRequestInterface in File/FileUploadController 06/56206/7
Mathias Brodala [Fri, 16 Mar 2018 09:53:17 +0000 (10:53 +0100)]
[TASK] Use ServerRequestInterface in File/FileUploadController

* deprecate public properties
* deprecate public (non-routed) methods
* fix rendering of "Overwrite" checkbox

Change-Id: Ia5b15ad5fd32ab156cab5f3231bbf0c2b78a617c
Resolves: #84326
Releases: master
Reviewed-on: https://review.typo3.org/56206
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Trigger submit of RSA encrypted form properly 42/56142/2
Andreas Fernandez [Wed, 14 Mar 2018 08:29:55 +0000 (09:29 +0100)]
[BUGFIX] Trigger submit of RSA encrypted form properly

The change of #76120 changed the selector of possible submit buttons.
However, in Firefox a submit is not triggered when a focussed submit
element is clicked via JavaScript.

The code is changed to enforce a submit of the form instead.

RsaEncryptionWithLib.min.js created with:
../../../../../../Build/node_modules/uglify-js/bin/uglifyjs \
RsaLibrary.js RsaEncryption.js > RsaEncryptionWithLib.min.js

Resolves: #84253
Related: #76120
Releases: master, 8.7, 7.6
Change-Id: Id30f4536dccec28edc0d909114c8fde71614bc30
Reviewed-on: https://review.typo3.org/56142
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
18 months ago[BUGFIX] Use correct returnUrl for AddWizard caller 13/56213/2
Anja [Fri, 16 Mar 2018 11:15:16 +0000 (12:15 +0100)]
[BUGFIX] Use correct returnUrl for AddWizard caller

The wrong property has been used to construct the return
URL for the redirect. This has been corrected.

Change-Id: I0d2011a153a34e6c272c69c5a88d66eb498b0707
Resolves: #84336
Relates: #84195
Releases: master
Reviewed-on: https://review.typo3.org/56213
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
18 months ago[BUGFIX] Call autocomplete only if field is available 11/56211/2
Andreas Fernandez [Fri, 16 Mar 2018 11:07:38 +0000 (12:07 +0100)]
[BUGFIX] Call autocomplete only if field is available

Resolves: #84335
Related: #82592
Related: #82969
Releases: master
Change-Id: I6afa442fdfb86e2ffeff0b3c39c12ed2c7e8df6c
Reviewed-on: https://review.typo3.org/56211
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
18 months ago[TASK] Remove StandaloneViewTest 05/56205/3
Jan Helke [Fri, 16 Mar 2018 09:47:25 +0000 (10:47 +0100)]
[TASK] Remove StandaloneViewTest

The "unit" test is basically a test of controller-like
glue code and does not add value. Remove it.

Releases: master
Resolves: #84330
Change-Id: I5ec5c9a148c07b5090f5de34aa2caa3e7f031b3e
Reviewed-on: https://review.typo3.org/56205
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
18 months ago[TASK] Make AbstractWidgetViewHelperTest notice free 03/56203/2
Jan Helke [Fri, 16 Mar 2018 08:35:26 +0000 (09:35 +0100)]
[TASK] Make AbstractWidgetViewHelperTest notice free

Releases: master
Resolves: #84325
Change-Id: I1c1a90dd0eb214aa1a5d655207eaf3e01401d489
Reviewed-on: https://review.typo3.org/56203
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Expose interfaces of AjaxDataHandler 41/56041/4
Andreas Fernandez [Wed, 7 Mar 2018 20:02:31 +0000 (21:02 +0100)]
[BUGFIX] Expose interfaces of AjaxDataHandler

Since the AjaxDataHandler is meant to be used in other modules as well,
the interfaces responsible for the response and the messages need to be
public to be able to write type-safe callbacks.

Resolves: #84172
Releases: master
Change-Id: Ib49f25181bc8c83a0cdc89da3a9b466b6bd25d59
Reviewed-on: https://review.typo3.org/56041
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Make reloadFrames() non-static 02/56202/3
Andreas Fernandez [Fri, 16 Mar 2018 07:23:22 +0000 (08:23 +0100)]
[BUGFIX] Make reloadFrames() non-static

This patch makes the reloadFrames() method non-static, as the method is
required in an instance context.

Resolves: #84323
Related: #82597
Releases: master
Change-Id: I3bdcfdc91721bb2c145fd42ae4448b09a72e636e
Reviewed-on: https://review.typo3.org/56202
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[TASK] Use ServerRequestInterface in LoginController 76/56176/25
Łukasz Uznański [Thu, 15 Mar 2018 16:09:32 +0000 (17:09 +0100)]
[TASK] Use ServerRequestInterface in LoginController

Replace _GP, getIndpEnv usages

Resolves: #84274
Releases: master
Change-Id: Ic90a83214b0c7cb8d4334f5b72c581968f193766
Reviewed-on: https://review.typo3.org/56176
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
18 months ago[BUGFIX] checkIntegrityCsvFixtures.php displays error reason 24/56124/6
Markus Klein [Mon, 12 Mar 2018 23:25:16 +0000 (00:25 +0100)]
[BUGFIX] checkIntegrityCsvFixtures.php displays error reason

- output details about the columns if a mismatch is detected
- support windows paths for output formatting

Resolves: #84228
Releases: master, 8.7
Change-Id: I02bee0cb4ff99c18632907395989ea7f96c1c625
Reviewed-on: https://review.typo3.org/56124
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Respect empty allowedMimeTypes for file uploads 69/55869/5
Ralf Zimmermann [Thu, 22 Feb 2018 23:13:26 +0000 (00:13 +0100)]
[BUGFIX] Respect empty allowedMimeTypes for file uploads

Make it possible to allow all mime types (except php) within file upload
form elements.
Since there are some default mime types configured within the ext:form
standard setup, you have to remove this default mime types within your
form definition (or reconfigure the default values within your custom
ext:form setup).

FileUpload:

properties:
  allowedMimeTypes:
    0: null
    1: null
    2: null
    3: null

ImageUpload:

properties:
  allowedMimeTypes:
    0: null
    1: null
    2: null

Releases: master, 8.7
Resolves: #82670
Change-Id: Ifa07cceb47978b913f36b8607d4df4724ae22eef
Reviewed-on: https://review.typo3.org/55869
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[TASK] Use ServerRequestInterface in File/EditFileController 83/56183/7
Anja [Thu, 15 Mar 2018 17:49:18 +0000 (18:49 +0100)]
[TASK] Use ServerRequestInterface in File/EditFileController

Use ServerRequestInterface object introduced earlier throughout the
controller instead accessing the global variables directly.

Visibility of properties and methods became more restrictive and will
report external usage by throwing deprecated errors.

Change-Id: I70764c6b1feb8da39c9a441dc2c22de838da3a43
Resolves: #84295
Releases: master
Reviewed-on: https://review.typo3.org/56183
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Cast return value of postProcessDatabaseInsert to integer 18/56118/4
Susanne Moog [Thu, 15 Mar 2018 14:03:13 +0000 (15:03 +0100)]
[BUGFIX] Cast return value of postProcessDatabaseInsert to integer

Connection::lastInsertId returns a string but
DataHandler::postProcessDatabaseInsert has a strict integer return
value, so the value has to be casted to integer on return.

Additionally, when using sqlserver doctrine fails to fetch the last
inserted id under certain circumstances. An additional retrieval
method was introduced to mitigate that error.

Resolves: #84219
Releases: master, 8.7
Change-Id: I94dc0dc964aef26380703f641691c6a80ec5180d
Reviewed-on: https://review.typo3.org/56118
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make MethodArgumentDroppedMatcherTest notice free 87/56187/3
Jan Helke [Thu, 15 Mar 2018 19:37:00 +0000 (20:37 +0100)]
[TASK] Make MethodArgumentDroppedMatcherTest notice free

Resolves: #84314
Releases: master
Change-Id: Ic8cba1972407b51d7deedb40bc4161dc19ab1601
Reviewed-on: https://review.typo3.org/56187
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make MethodArgumentRequiredMatcherTest notice free 89/56189/3
Jan Helke [Thu, 15 Mar 2018 19:42:47 +0000 (20:42 +0100)]
[TASK] Make MethodArgumentRequiredMatcherTest notice free

Releases: master
Resolves: #84316
Change-Id: Icf9cf8fe0dcd67be550c918d59e4cec34562ea32
Reviewed-on: https://review.typo3.org/56189
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make MethodArgumentRequiredStaticMatcherTest notice free 90/56190/3
Jan Helke [Thu, 15 Mar 2018 19:46:34 +0000 (20:46 +0100)]
[TASK] Make MethodArgumentRequiredStaticMatcherTest notice free

Releases: master
Resolves: #84317
Change-Id: Ib758d64aa3613d7af4885338f8cf856412fbd6f9
Reviewed-on: https://review.typo3.org/56190
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make MethodCallMatcherTest notice free 92/56192/3
Jan Helke [Thu, 15 Mar 2018 19:52:23 +0000 (20:52 +0100)]
[TASK] Make MethodCallMatcherTest notice free

Releases: master
Resolves: #84319
Change-Id: Iabb6167b952d5cbd456b9829452ca835f432af30
Reviewed-on: https://review.typo3.org/56192
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make MethodArgumentDroppedStaticMatcherTest notice free 88/56188/3
Jan Helke [Thu, 15 Mar 2018 19:40:00 +0000 (20:40 +0100)]
[TASK] Make MethodArgumentDroppedStaticMatcherTest notice free

Releases: master
Resolves: #84315
Change-Id: I6bb30f6289d5c5a9e5c36f21ab89cf4b84b5bad7
Reviewed-on: https://review.typo3.org/56188
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Remove dependency to extbase from reports module 25/56125/10
Georg Ringer [Tue, 13 Mar 2018 08:13:36 +0000 (09:13 +0100)]
[TASK] Remove dependency to extbase from reports module

Simplify the reports module by removing usage of extbase.

Resolves: #84231
Releases: master
Change-Id: I33d55e60b454b0945a7a98f7cafb15bfc69dc18d
Reviewed-on: https://review.typo3.org/56125
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[TASK] Make ArrayDimensionMatcherTest notice free 86/56186/2
Jan Helke [Thu, 15 Mar 2018 19:16:38 +0000 (20:16 +0100)]
[TASK] Make ArrayDimensionMatcherTest notice free

Resolves: #84313
Releases: master
Change-Id: I0834cf0cf8fb8aa802b1e4b1a005192cd5e2c276
Reviewed-on: https://review.typo3.org/56186
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make MethodCallStaticMatcherTest notice free 93/56193/3
Jan Helke [Thu, 15 Mar 2018 19:54:32 +0000 (20:54 +0100)]
[TASK] Make MethodCallStaticMatcherTest notice free

Releases: master
Resolves: #84320
Change-Id: I7f1d2f09609a60586c8b894ff7e939f956c10833
Reviewed-on: https://review.typo3.org/56193
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make MethodArgumentUnusedMatcherTest notice free 91/56191/3
Jan Helke [Thu, 15 Mar 2018 19:50:02 +0000 (20:50 +0100)]
[TASK] Make MethodArgumentUnusedMatcherTest notice free

Releases: master
Resolves: #84318
Change-Id: I04cf297b740ec6022a70f8b48d4d7be48e72854b
Reviewed-on: https://review.typo3.org/56191
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Use ServerRequestInterface in ContentElement/NewContentElementController 80/56180/10
Mathias Brodala [Thu, 15 Mar 2018 16:28:56 +0000 (17:28 +0100)]
[TASK] Use ServerRequestInterface in ContentElement/NewContentElementController

Change-Id: I247fc40072fb84fdb6dffe406786426ff5b9e10e
Resolves: #84307
Releases: master
Reviewed-on: https://review.typo3.org/56180
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make AbstractCoreMatcherTest notice free 85/56185/2
Jan Helke [Thu, 15 Mar 2018 19:03:23 +0000 (20:03 +0100)]
[TASK] Make AbstractCoreMatcherTest notice free

Resolves: #84312
Releases: master
Change-Id: Iee54bf0b2ff71668b666020dbcba7ca2dcc03296
Reviewed-on: https://review.typo3.org/56185
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[FEATURE] Show value of fields in debug mode 47/56147/11
Georg Ringer [Wed, 14 Mar 2018 13:55:47 +0000 (14:55 +0100)]
[FEATURE] Show value of fields in debug mode

If the configuration `['BE']['debug']` is enabled and the current user is an administrator,
the value of select, radio and checkbox fields which are generated by
the `FormEngine` is appended to its label.

Resolves: #83748
Releases: master
Change-Id: I735bd3c83b5b12eb3cddcc66d1b92d48cf5e5991
Reviewed-on: https://review.typo3.org/56147
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[TASK] Extract html into fluid template from info module in admin panel 59/56159/7
Joerg Boesche [Thu, 15 Mar 2018 11:53:08 +0000 (12:53 +0100)]
[TASK] Extract html into fluid template from info module in admin panel

The info module should use a fluid template instead of
the old php-html mixed data structure.

Resolves: #84286
Releases: master
Change-Id: Idcd0a21c8f7b3410ca7e67f746d45031652dce07
Reviewed-on: https://review.typo3.org/56159
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[TASK] Extract html into fluid template from preview module in admin panel 67/56167/9
Tobi Kretschmann [Thu, 15 Mar 2018 13:56:32 +0000 (14:56 +0100)]
[TASK] Extract html into fluid template from preview module in admin panel

The preview module should use a fluid template instead of
the old php-html mixed data structure.

Resolves: #84211
Releases: master
Change-Id: I6b0a449216ff5b591eb123fdd2f9641fafeba3d8
Reviewed-on: https://review.typo3.org/56167
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[TASK] Use ServerRequestInterface in ContentElement/ElementInformationController 72/56172/8
Saskia Schreiber [Thu, 15 Mar 2018 14:47:01 +0000 (15:47 +0100)]
[TASK] Use ServerRequestInterface in ContentElement/ElementInformationController

This patch changes the ElementInformationController to consistently
use the ServerRequestInterface object instead of GeneralUtility
for the retrieval of POST/GETvars and server environment variables.

Also, to prepare for refactoring in v10,
all public properties and methods except mainAction() will throw
a deprecation notice if called.

Resolves: #84284
Releases: master
Change-Id: I5e9e22833aa0868319daef6d3744966f2f35fbb8
Reviewed-on: https://review.typo3.org/56172
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make L10nModeUpdaterTest notice free 84/56184/2
Jan Helke [Thu, 15 Mar 2018 17:53:23 +0000 (18:53 +0100)]
[TASK] Make L10nModeUpdaterTest notice free

Resolves: #84311
Releases: master
Change-Id: I494b83a27e333eed77837bee2586e448f5903566
Reviewed-on: https://review.typo3.org/56184
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Use ServerRequestInterface in MoveElementController 63/56163/12
Mathias Brodala [Thu, 15 Mar 2018 12:27:04 +0000 (13:27 +0100)]
[TASK] Use ServerRequestInterface in MoveElementController

Change-Id: Id817e4aa991ddfccaf1fcb6838d7354bc64235d6
Resolves: #84285
Releases: master
Reviewed-on: https://review.typo3.org/56163
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make LogRecordTest notice free 78/56178/4
Sascha Löffler [Thu, 15 Mar 2018 16:10:44 +0000 (17:10 +0100)]
[TASK] Make LogRecordTest notice free

Resolves: #84309
Releases: master
Change-Id: I494c587ae28d4370e6c6da8edd467beba8eb436a
Reviewed-on: https://review.typo3.org/56178
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
18 months ago[TASK] Make SilentConfigurationUpgradeServiceTest notice free 82/56182/2
Jan Helke [Thu, 15 Mar 2018 17:37:09 +0000 (18:37 +0100)]
[TASK] Make SilentConfigurationUpgradeServiceTest notice free

Resolves: #84310
Releases: master
Change-Id: I6a3418fe449badd8beb1ec04f3d522c05696ce94
Reviewed-on: https://review.typo3.org/56182
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make DirectoryNodeTest notice free 77/56177/3
Jan Helke [Thu, 15 Mar 2018 16:10:24 +0000 (17:10 +0100)]
[TASK] Make DirectoryNodeTest notice free

Resolves: #84302
Releases: master
Change-Id: I6d0ea9879d4b4b37282b5446809ef28a01fdec51
Reviewed-on: https://review.typo3.org/56177
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make FileNodeTest notice free 79/56179/3
Jan Helke [Thu, 15 Mar 2018 16:15:17 +0000 (17:15 +0100)]
[TASK] Make FileNodeTest notice free

Resolves: #84304
Releases: master
Change-Id: Ib45020524a699ae94f93ef6181e06100ccff1ffd
Reviewed-on: https://review.typo3.org/56179
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Use ServerRequestInterface in LogoutController 64/56164/9
Łukasz Uznański [Thu, 15 Mar 2018 13:24:04 +0000 (14:24 +0100)]
[TASK] Use ServerRequestInterface in LogoutController

Set public methods deprecated, replace them by protected
methods and use them in class, set declare strict types.

Resolves: #84275
Releases: master
Change-Id: I4351a3a422347d643353b41188f07a6965e5e92a
Reviewed-on: https://review.typo3.org/56164
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make LocalizationUtilityTest notice free 71/56171/5
Jan Helke [Thu, 15 Mar 2018 14:55:56 +0000 (15:55 +0100)]
[TASK] Make LocalizationUtilityTest notice free

Releases: master
Resolves: #84281
Change-Id: Ibf5135a154c01bcd612f59a1ba9660f0f59fe5c6
Reviewed-on: https://review.typo3.org/56171
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
18 months ago[TASK] Make ClassNamingUtilityTest notice free 54/56154/10
Jan Helke [Thu, 15 Mar 2018 10:53:29 +0000 (11:53 +0100)]
[TASK] Make ClassNamingUtilityTest notice free

Releases: master
Resolves: #84277
Change-Id: Ia0f884a217c9cceaf07b91cb34042f7c708356cf
Reviewed-on: https://review.typo3.org/56154
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
18 months ago[TASK] Make AbstractNodeTest notice free 75/56175/2
Jan Helke [Thu, 15 Mar 2018 16:03:31 +0000 (17:03 +0100)]
[TASK] Make AbstractNodeTest notice free

Resolves: #84301
Releases: master
Change-Id: I06da4d2dcebdb1dedd6609dca8b4239f9a48c9cf
Reviewed-on: https://review.typo3.org/56175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Make LinkNodeTest notice free 81/56181/3
Jan Helke [Thu, 15 Mar 2018 16:37:53 +0000 (17:37 +0100)]
[TASK] Make LinkNodeTest notice free

Resolves: #84305
Releases: master
Change-Id: Iecdf134051c03acc76452c637522a1201efff517
Reviewed-on: https://review.typo3.org/56181
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
18 months ago[FEATURE] Add debug attribute to RenderViewHelper 73/56173/5
Frank Naegler [Thu, 15 Mar 2018 15:37:18 +0000 (16:37 +0100)]
[FEATURE] Add debug attribute to RenderViewHelper

Resolves: #84216
Releases: master
Change-Id: I5eda479d37e31ad9d246ef3808f74a9c96d981c2
Reviewed-on: https://review.typo3.org/56173
Reviewed-by: Hendrik Stender <h.stender@neusta.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[TASK] Make LocalizationFactoryTest notice free 60/56160/4
Jan Helke [Thu, 15 Mar 2018 11:54:39 +0000 (12:54 +0100)]
[TASK] Make LocalizationFactoryTest notice free

Resolves: #84282
Releases: master
Change-Id: I8ba82db0dd83cf8bc8c2011bb5760f44763de109
Reviewed-on: https://review.typo3.org/56160
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
18 months ago[BUGFIX] Use correct identifier for page tree icons binding 74/56174/2
Tymoteusz Motylewski [Thu, 15 Mar 2018 15:57:48 +0000 (16:57 +0100)]
[BUGFIX] Use correct identifier for page tree icons binding

The `stateIdentifier` is correct for nodes, but for icons `identifier`
 should be used.

Resolves: #84300
Releases: master
Change-Id: If014a19e4472d9737ee09c75970fd78e2615f150
Reviewed-on: https://review.typo3.org/56174
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Use ServerRequestInterface in File/CreateFolderController 68/56168/7
Anja [Thu, 15 Mar 2018 14:03:59 +0000 (15:03 +0100)]
[TASK] Use ServerRequestInterface in File/CreateFolderController

Use ServerRequestInterface object introduced earlier throughout the
controller instead accessing the global variables directly.

Visibility of properties and methods became more restrictive and will
report external usage by throwing deprecated errors.

Change-Id: Icf13b2b74507652541245453fd45558e7a24ea13
Resolves: #84289
Releases: master
Reviewed-on: https://review.typo3.org/56168
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Use ServerRequestInterface in FileSystemNavigationFrameController 56/56156/13
Łukasz Uznański [Thu, 15 Mar 2018 10:44:46 +0000 (11:44 +0100)]
[TASK] Use ServerRequestInterface in FileSystemNavigationFrameController

Change public properties to protected, add protected methods in
replacement of public, deprecate public methods, rewrite _GP

Resolves: #84273
Releases: master
Change-Id: I927829018e4e477e8176bfc3df0a21582f5d2261
Reviewed-on: https://review.typo3.org/56156
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Activate email validation for pages.author_email 55/56155/3
Josef Glatz [Thu, 15 Mar 2018 10:31:15 +0000 (11:31 +0100)]
[TASK] Activate email validation for pages.author_email

Activate email validation for pages.author_email as the field
is intended to hold an e-mail address of the author.

Resolves: #84279
Releases: master
Change-Id: Ib025ef413379fd94c4956401bce5a4bbc76bdb3f
Reviewed-on: https://review.typo3.org/56155
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[TASK] Make LocallangXmlParserTest notice free 69/56169/4
Sascha Löffler [Thu, 15 Mar 2018 14:22:19 +0000 (15:22 +0100)]
[TASK] Make LocallangXmlParserTest notice free

Resolves: #84283
Releases: master
Change-Id: I9a047f95ca3cc57d951a36d5b9910678900e100f
Reviewed-on: https://review.typo3.org/56169
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
18 months ago[TASK] Extract html into fluid template from TS debug module in admin panel 53/56153/4
Joerg Boesche [Thu, 15 Mar 2018 09:27:57 +0000 (10:27 +0100)]
[TASK] Extract html into fluid template from TS debug module in admin panel

The TS debug module should use a fluid template instead of
the old php-html mixed data structure.

Resolves: #84271
Releases: master
Change-Id: I351f2a2f67ad21b06859d9da1cd7bad7e1ae0e1d
Reviewed-on: https://review.typo3.org/56153
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Hendrik Stender <h.stender@neusta.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[BUGFIX] Fix redirect after page/content move 65/56165/4
Mathias Brodala [Thu, 15 Mar 2018 13:26:35 +0000 (14:26 +0100)]
[BUGFIX] Fix redirect after page/content move

Change-Id: Ic72670657631c6f0ae792be4bcbd76fa63c0ac33
Resolves: #84292
Releases: master
Reviewed-on: https://review.typo3.org/56165
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
18 months ago[BUGFIX] LinkHandler creates wrong TS configuration 52/56152/2
Stefan Froemken [Thu, 15 Mar 2018 09:06:45 +0000 (10:06 +0100)]
[BUGFIX] LinkHandler creates wrong TS configuration

DatabaseRecordLinkBuilder creates a wrong
TypoScript configuration because of using
array_merge_recursive which joins all array elements
instead of replacing them.

Resolves: #84116
Releases: master,8.7
Change-Id: I212b70f86baf2929f9466fa665cec30fe477c6b8
Reviewed-on: https://review.typo3.org/56152
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wolfgang Wagner <wolfgang.wagner.fn@gmail.com>
Reviewed-by: Pascal Rinker <prinker@jweiland.net>
Tested-by: Pascal Rinker <prinker@jweiland.net>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[TASK] Notice free ExtensionUtility testing 61/56161/3
Anja [Thu, 15 Mar 2018 11:55:34 +0000 (12:55 +0100)]
[TASK] Notice free ExtensionUtility testing

Change-Id: I090939179f545acaaecb77f0c6ce7addabcde090
Resolves: #84278
Releases: master
Reviewed-on: https://review.typo3.org/56161
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Throw exception when StringUtility is called with array 58/56158/5
Sascha Löffler [Thu, 15 Mar 2018 10:34:59 +0000 (11:34 +0100)]
[TASK] Throw exception when StringUtility is called with array

Throw exception when calling StringUtility with array and
remove suppressNotices in StringUtilityTest.

Change-Id: Ic2b7075f2943bda284d4747b8aaa4f4b6fb70e3b
Resolves: #84276
Releases: master
Reviewed-on: https://review.typo3.org/56158
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Make RecordBrowser highlight selected record again 70/54370/18
Stanislas Rolland [Wed, 11 Oct 2017 21:54:27 +0000 (17:54 -0400)]
[BUGFIX] Make RecordBrowser highlight selected record again

When using the element browser wizard with a configured record link
handler, the record browser now highlights the currently linked
record again.

Resolves: #82739
Releases: master, 8.7
Change-Id: Iba47f18bf150bb4646729c6a5ecdae46b7d56754
Reviewed-on: https://review.typo3.org/54370
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
18 months ago[BUGFIX] Accept configuration for external plugins from presets in ckeditor 57/52857/7
Marcus Schwemer [Thu, 18 May 2017 20:57:25 +0000 (22:57 +0200)]
[BUGFIX] Accept configuration for external plugins from presets in ckeditor

Currently the default configuration of an external
plugin is always used for the configuration. This patch takes care
of a proper merging of the configuration.

The configuration of the extension is taken as default. If a
custom configuration in a preset is available, both configurations
will be merged.

Resolves: #81263
Releases: master,8.7
Change-Id: I4fc7c4f6f6ab40fe06e495e3ff98e067427c7d03
Reviewed-on: https://review.typo3.org/52857
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[BUGFIX] Apply potential changes after form editor save operation 58/55958/2
Ralf Zimmermann [Wed, 28 Feb 2018 23:21:36 +0000 (00:21 +0100)]
[BUGFIX] Apply potential changes after form editor save operation

Apply potential form definition changes within the form editor,
if the form definition changes while saving it.
This is possible through the hook ['ext/form']['beforeFormSave']

Releases: master
Resolves: #84081
Change-Id: I0c20e0d20f9ec9ec8ccc0f279f68f9b4ebdfc306
Reviewed-on: https://review.typo3.org/55958
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jurian Janssen <jurian.janssen@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[BUGFIX] Database compare must show errors 96/56096/2
Guido Schmechel [Sun, 11 Mar 2018 14:12:33 +0000 (15:12 +0100)]
[BUGFIX] Database compare must show errors

If database compare fails because of wrong SQL,
it shows now the error message.

Resolves: #84137
Releases: master, 8.7
Change-Id: Ie9b92b5ee656f5d5bfe1e5bdac52afa6c61eff03
Reviewed-on: https://review.typo3.org/56096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
18 months ago[BUGFIX] Restore getUrl support for list of headers 46/56046/7
Felix Buenemann [Wed, 7 Mar 2018 22:39:24 +0000 (23:39 +0100)]
[BUGFIX] Restore getUrl support for list of headers

The change of \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl()
from cURL to GuzzleHttp the format of the $requestHeaders param was
implicitly changed from an array of header strings to an associative
array where the key is the header name and the value is either a single
or an array of values for that header.

This adds back support for the old list of headers format by detecting a
non-associative array and converting it to the Guzzle key/value(s) style.

At the same time the 'old' way is deprecated.

Resolves: #84171
Related: #70056
Releases: master, 8.7
Change-Id: I41b23993957288dfd5294129fa8039aab717461d
Reviewed-on: https://review.typo3.org/56046
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[TASK] Remove Install Tool password from module "All Configuration" 46/56146/2
Georg Ringer [Wed, 14 Mar 2018 12:55:59 +0000 (13:55 +0100)]
[TASK] Remove Install Tool password from module "All Configuration"

To simplify the available options, the setting "Install Tool Password"
is removed from the All Configuration module. There is a separate section
"Change Install Tool Password" anyway.

Resolves: #82432
Releases: master
Change-Id: I90dd255d2c63f1b3a9193f52770417ee0245d648
Reviewed-on: https://review.typo3.org/56146
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[BUGFIX] Correctly reference sys_file_metadata.language in TCA 99/56099/5
Christian Heindl [Sun, 11 Mar 2018 19:14:38 +0000 (20:14 +0100)]
[BUGFIX] Correctly reference sys_file_metadata.language in TCA

Palette "language" does not exists on table "sys_file_metadata" resulting
in an empty "language" tab, when editing a file's metadata.
Thus referencing language field directly.

Releases: master, 8.7
Resolves: #84200
Change-Id: I44b2b169bbce7948826fdade9f10a760b32df2c7
Reviewed-on: https://review.typo3.org/56099
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[TASK] Use ServerRequestInterface in EditDocumentController 18/56018/17
Christian Kuhn [Tue, 6 Mar 2018 01:07:56 +0000 (02:07 +0100)]
[TASK] Use ServerRequestInterface in EditDocumentController

A controller reads information from the request object and creates
and returns a response object.

Backend controllers in TYPO3 however have a history of being messy:
They read information from GET/POST using these super globals
directly, or by calling helper methods like _GP(), getIndpEnv()
and others.
Some controllers don't even return a response object to be further
processable by PSR-15 middlewares, but call stuff like
HttpUtility::redirect() to write a response and die.
Furthermore, especially the old and most important backend
controllers have tons of public properties and methods. This makes
refactoring towards good controller code hard. But controllers
shouldn't expose much public API: They usually should not be called from
outside, except their main entry methods that take the request object
in order to turn it into a response object. Everything else should be
protected and used internally only.

The patch takes EditDocumentController as one of the most complex
and important backend controllers and refactors it:

* (Nearly) all methods and properties are protected.
* All request dependant data is read from $request->getParsedBody(),
  $request->getQueryParams() or $request->getAttribute('serverParams').

This patch is very careful and tries to be fully backwards compatible in
v9. In case some extension still uses properties or methods of this
controller, a series of different strategies have been used to retain
compatibility:

* Properties made protected use PublicPropertyDeprecationTrait
  to trigger_error() if accessed.
* Nearly all properties are kept, keep their state and type to not
  break a possible 3rd party usage.
* Nearly everything made protected or deprecated is configured to be
  scanned by extension scanner, except a couple of properties that
  would create too many false positives. Those are marked as not scanned
  in the deprecation ReST file.
* Various methods need $request now. They are always called with that
  argument, but fall back to $GLOBALS['TYPO3_REQUEST'] and
  trigger_error() if not given.
* Some methods are kept with their old signature as public and are
  set to deprecated, but trigger_error() to then call a new protected
  method with a better name and a more strict sigature.
* Some methods are kept public in v9, but test if they were called from
  outside to then trigger_error() telling they will be set to protected
  in v10.
* A couple of properties still must be public since other core
  functionality reads from them directly. Those are marked with
  an @todo and @internal to have freedom in v10 for further cleanup.
* Some (non core) hooks or signals may now trigger deprecation log
  entries if they try to set properties or call methods. Those need
  detailed handling later and may hand over specific properties instead
  of full "pObj". This will be a topic later if the main signal/hook
  handling gets more love. As a general alternative, some hooks or signal
  usages could also be turned into a PSR-15 middleware instead. In case
  of EditDocumentController, the write access of the two existing signal
  may eventually be removed altogether later, since an existing slot
  could probably better achieve the same job by being converted into a
  middleware that manipulates $request if it needs to write.

Changing controllers this way gives the core much more freedom
to refactor and significantly improve controller code in v10, after
now deprecated code from patches like these have been removed.

Change-Id: I3527c43c52f6e738f34ac0a21efc1ac904a3f6d2
Resolves: #84195
Releases: master
Reviewed-on: https://review.typo3.org/56018
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[TASK] Streamline/Fix backend labels by removing superfluous colons 30/56130/7
Josef Glatz [Sat, 10 Mar 2018 17:45:32 +0000 (18:45 +0100)]
[TASK] Streamline/Fix backend labels by removing superfluous colons

Column labels across common tables have many mixed labels
with/without colons. Many longer existing labels still have colons.

Streamlining the backend makes the appearance more uniform.

Releases: master
Resolves: #84241
Change-Id: I456f85973a8220760303efb47600e8bcea01029e
Reviewed-on: https://review.typo3.org/56130
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[BUGFIX] Make hidden records searchable in top search 40/56140/2
Georg Ringer [Wed, 14 Mar 2018 07:06:06 +0000 (08:06 +0100)]
[BUGFIX] Make hidden records searchable in top search

Hidden records must be found by the top search again.

Resolves: #84248
Releases: master, 8.7
Change-Id: Ic41eff5ab3300746c7fe6a78f9ce2a305372f7ab
Reviewed-on: https://review.typo3.org/56140
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
18 months ago[BUGFIX] Create instance of ToggleSearchToolbox 41/56141/2
Andreas Fernandez [Wed, 14 Mar 2018 07:11:17 +0000 (08:11 +0100)]
[BUGFIX] Create instance of ToggleSearchToolbox

Resolves: #84251
Releases: master
Change-Id: Ib4f62be18d8175f03fe0456f61a7eed56a3b877a
Reviewed-on: https://review.typo3.org/56141
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[BUGFIX] Remove HTML from Install Tool ajax response. 38/56138/2
Georg Ringer [Tue, 13 Mar 2018 15:16:23 +0000 (16:16 +0100)]
[BUGFIX] Remove HTML from Install Tool ajax response.

Remove the not needed <i> tag which is escaped and looks strange.

Resolves: #84194
Releases: master

Change-Id: I19a8bdc6eee65487fc0d8317895b8fa44ba917ea
Reviewed-on: https://review.typo3.org/56138
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
18 months ago[TASK] Add missing documentation files and correct errors 31/56131/3
Susanne Moog [Tue, 13 Mar 2018 11:33:16 +0000 (12:33 +0100)]
[TASK] Add missing documentation files and correct errors

Resolves: #84242
Releases: master, 8.7, 7.6
Change-Id: I049c053dee291e7c31dbf5c81aacde0619d0f244
Reviewed-on: https://review.typo3.org/56131
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
18 months ago[BUGFIX] Ensure TSconfig order is identical in BE and FE 22/56122/2
Markus Klein [Mon, 12 Mar 2018 22:04:29 +0000 (23:04 +0100)]
[BUGFIX] Ensure TSconfig order is identical in BE and FE

Make sure the inclusion order of TSconfig (files and record field)
are identical in BE and FE. As BE and FE use different algorithms,
FE is adjusted to match the BE behaviour, which is the expected one.

Resolves: #84227
Releases: master, 8.7
Change-Id: Idb4afbd736ed65890850ee75d572a55c3a5ab24d
Reviewed-on: https://review.typo3.org/56122
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[BUGFIX] Handle config.absRefPrefix on JS/CSS files correctly again 08/56108/8
Oliver Hader [Mon, 12 Mar 2018 12:10:42 +0000 (13:10 +0100)]
[BUGFIX] Handle config.absRefPrefix on JS/CSS files correctly again

Issue #77589 introduced automatic resolving of relative paths during
v8.4.0 development in the PageRenderer component. Doing this in some
backend context is fine - however if applied for frontend rendering,
config.absRefPrefix was not applied anymore to these files.

Reason for this behavior is applying PathUtility::getAbsoluteWebPath
which prefixes files with /<TYPO3_SITE_PATH>/ - however absRefPrefix
only works on relative URIs. Extending the absRefPrefix patterns in
TypoScriptFrontendController::setAbsRefPrefix() by mentioned prefix
would adjust explicitly defined absolute paths as well.

To solve this bug, the prefix /<TYPO3_SITE_PATH>/ is
not applied in frontend rendering contexts anymore.

Resolves: #83630
Releases: master, 8.7
Change-Id: Ib01f698c14fb646173ec24e26027c7d657700f87
Reviewed-on: https://review.typo3.org/56108
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
18 months ago[BUGFIX] Add upgrade wizard to keep sorting of sys_language records 30/55930/6
Georg Ringer [Tue, 27 Feb 2018 20:40:12 +0000 (21:40 +0100)]
[BUGFIX] Add upgrade wizard to keep sorting of sys_language records

To keep the sorting after an upgrade from 7.6 to 8.7 and later, an
upgrade wizard is added.

Resolves: #82538
Releases: master, 8.7
Change-Id: If1b5fbc56d445239bc6e4eaecb695889aeb9819b
Reviewed-on: https://review.typo3.org/55930
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
18 months ago[TASK] Apply code cleanup 80/56080/3
Ralf Zimmermann [Fri, 9 Mar 2018 17:28:25 +0000 (18:28 +0100)]
[TASK] Apply code cleanup

* Reapply usage of null coalescing operator from review:54810 that have
  been lost by the revert review:55422
* Prevent E_NOTICES within InheritancesResolverService
* Fix typos in unit tests

Releases: master
Resolves: #84189
Change-Id: If77ff3eddf51fa821314800cebaaf76d482b22e7
Reviewed-on: https://review.typo3.org/56080
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Add functional test for runtimeActivatedPackages 12/56112/4
Nicole Cordes [Mon, 12 Mar 2018 14:32:44 +0000 (15:32 +0100)]
[TASK] Add functional test for runtimeActivatedPackages

Resolves: #84215
Releases: master, 8.7, 7.6
Change-Id: I9a642bb90278b22e61b97634022d3ab7af514e10
Reviewed-on: https://review.typo3.org/56112
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[TASK] Extract html into fluid template from cache module in admin panel 10/56110/7
Joerg Boesche [Mon, 12 Mar 2018 13:31:29 +0000 (14:31 +0100)]
[TASK] Extract html into fluid template from cache module in admin panel

The Cache module should use a fluid template instead of
the old php-html mixed data structure.

Resolves: #84209
Releases: master
Change-Id: Ib1a564c7af7e99007b890017037b9b095e7208b0
Reviewed-on: https://review.typo3.org/56110
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Render tags in ReST files 15/56115/3
Andreas Fernandez [Mon, 12 Mar 2018 15:41:09 +0000 (16:41 +0100)]
[TASK] Render tags in ReST files

This patch renders the tags of the ReST files in the panel of each change
log. The color of each tag is automatically adjusted to the severity of
the change.

Resolves: #84226
Releases: master
Change-Id: Iadc4fe1f01bb3d10b2ffd85fd85a516b22a685c3
Reviewed-on: https://review.typo3.org/56115
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Sort tags in „View Upgrade Documentation“ by name 13/56113/2
Andreas Fernandez [Mon, 12 Mar 2018 15:13:21 +0000 (16:13 +0100)]
[TASK] Sort tags in „View Upgrade Documentation“ by name

Resolves: #84217
Releases: master
Change-Id: Icd5e917f0b3d8fcd3f0a9ab5f9f763f87189f3a9
Reviewed-on: https://review.typo3.org/56113
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Add missing element description field to form editor 16/56116/4
Benjamin Kott [Mon, 12 Mar 2018 17:47:23 +0000 (18:47 +0100)]
[BUGFIX] Add missing element description field to form editor

To avoid the unsetting of previously set element descriptions for
input fields in the form editor, the field elementDescription was
added to all supported element types and is now available to editors.

Resolves: #84225
Releases: master, 8.7
Change-Id: Ide68a1fc95670d98df4e243436e93aa812bf9290
Reviewed-on: https://review.typo3.org/56116
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[BUGFIX] Correct automatic grid column calculation for forms 03/56103/5
Benjamin Kott [Mon, 12 Mar 2018 09:23:15 +0000 (10:23 +0100)]
[BUGFIX] Correct automatic grid column calculation for forms

The calculation now only includes direct children of the
row elements to produce a meaningful division
of the available space. If the available space is already
consumed by elements the next auto calculated
elements will now consume the space of a full row.

Resolves: #84207
Releases: master, 8.7
Change-Id: I5dabddbcd8c7b84236fdbbef3925d27197e99a39
Reviewed-on: https://review.typo3.org/56103
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[BUGFIX] Update fluid from 2.5.2 to 2.5.3 06/56106/2
Christian Kuhn [Mon, 12 Mar 2018 12:09:18 +0000 (13:09 +0100)]
[BUGFIX] Update fluid from 2.5.2 to 2.5.3

composer update typo3fluid/fluid

This fixes a count bug in if conditions and
a template resolving issue.

Resolves: #83812
Releases: master, 8.7
Change-Id: Ie5845614ffeac50dc5a5796d587d61015c4f1059
Reviewed-on: https://review.typo3.org/56106
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
18 months ago[BUGFIX] Streamline package management in PackageManager 87/55687/42
Nicole Cordes [Mon, 12 Feb 2018 20:30:43 +0000 (21:30 +0100)]
[BUGFIX] Streamline package management in PackageManager

This bugfix resolves an issue that all available Packages
are scanned at each request. At the same time, it fixes
an issue related to runtimeActivatedPackages.

We now
- resolve package key with api usage
- distinguish between registered and available packages
- remove superfluous exception annotations
- prevent superfluous scans on getPackage() and isPackageAvailable() calls

Releases: master, 8.7
Resolves: #83820
Change-Id: I2b8bff3d4bb5287fd76418217653477c77467a8e
Reviewed-on: https://review.typo3.org/55687
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
18 months ago[BUGFIX] For links across domains check if absRefPrefix is set 79/56079/2
Stefan Neufeind [Fri, 9 Mar 2018 16:42:27 +0000 (17:42 +0100)]
[BUGFIX] For links across domains check if absRefPrefix is set

Prevent PHP-error if absRefPrefix is not set.

Resolves: #84188
Releases: master, 8.7
Change-Id: Ic04184554281cdcaa74037290930aa0110696a07
Reviewed-on: https://review.typo3.org/56079
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Two forgotten calls use inline action map 05/56105/3
Christian Kuhn [Mon, 12 Mar 2018 10:52:22 +0000 (11:52 +0100)]
[BUGFIX] Two forgotten calls use inline action map

Follow up for #84199 changing two call to use the
new map.

Resolves: #84210
Related: #84199
Releases: master
Change-Id: I1b251c5a759470ad97ca70bed2f5c0cb921f3159
Reviewed-on: https://review.typo3.org/56105
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Protect a forgotten AbstractFormEngineAjaxController method 00/56100/3
Christian Kuhn [Sun, 11 Mar 2018 19:41:27 +0000 (20:41 +0100)]
[BUGFIX] Protect a forgotten AbstractFormEngineAjaxController method

With refactoring in #79159 one method has accidently been set
public while it is obvious it should be protected. Fix that. Patch
is not considered to be breaking since the method is an internal
method of that abstract class.

Resolves: #84201
Related: #79159
Releases: master, 8.7
Change-Id: I0c04ff2d3fe9d68420c80af8831df361eb6f8a13
Reviewed-on: https://review.typo3.org/56100
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Move IRRE actions to a map and export inline 98/56098/2
Andreas Fernandez [Sun, 11 Mar 2018 17:55:17 +0000 (18:55 +0100)]
[TASK] Move IRRE actions to a map and export inline

The possible requests done in jsfunc.inline.js are now stored in a map
that holds the method (e.g. "create") and points to a specific route for
AJAX requests.
Additionally, the inline object is made public for the time being and
explicitly marked as internal.

This allows overriding specific routes, which is required for the
upcoming "Sites" module.

Resolves: #84199
Releases: master
Change-Id: Ief9fc1382e60a6b894e2970f9349f9b03913d021
Reviewed-on: https://review.typo3.org/56098
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Unify value for $report['lib'] to GuzzleHttp 40/56040/3
Felix Buenemann [Wed, 7 Mar 2018 19:30:43 +0000 (20:30 +0100)]
[BUGFIX] Unify value for $report['lib'] to GuzzleHttp

GeneralUtility::getUrl() now always returns 'GuzzleHttp' as lib
in the report, instead of returning
"GuzzleHttp" if an exception was caught and "http" otherwise.

Resolves: #84170
Related: #70056
Releases: master, 8.7
Change-Id: I6a28cb7921a3d784c37912c12f9b250f6b4d493c
Reviewed-on: https://review.typo3.org/56040
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
18 months ago[BUGFIX] Simulate submit button for rsaauth form submit 71/48371/5
Nicole Cordes [Sat, 28 May 2016 17:12:38 +0000 (19:12 +0200)]
[BUGFIX] Simulate submit button for rsaauth form submit

This patch adds the name and value of the first submit button found in a
form to the input field used to send the form.

Resolves: #76120
Releases: master, 8.7, 7.6
Change-Id: I3f0fdc7e933267689114d5bcf62d3fcfe2db5146
Reviewed-on: https://review.typo3.org/48371
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Set correct default connection charset "utf8" 81/56081/2
Wolfgang Klinger [Fri, 9 Mar 2018 21:12:14 +0000 (22:12 +0100)]
[BUGFIX] Set correct default connection charset "utf8"

Resolves: #84180
Releases: master, 8.7
Change-Id: Id868d3f379d131c3a51e039e6a862e4dcabf2fda
Reviewed-on: https://review.typo3.org/56081
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
18 months ago[BUGFIX] Properly HTML encode site name in page module 83/56083/2
Helmut Hummel [Fri, 9 Mar 2018 21:14:09 +0000 (22:14 +0100)]
[BUGFIX] Properly HTML encode site name in page module

Resolves: #84191
Releases: master, 8.7, 7.6
Change-Id: Id0f2da6f77b3c01293478329503dc922ccd7e72c
Reviewed-on: https://review.typo3.org/56083
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[TASK] Remove duplicate IconFactory instantiation 75/56075/2
Ralf Zimmermann [Fri, 9 Mar 2018 12:00:15 +0000 (13:00 +0100)]
[TASK] Remove duplicate IconFactory instantiation

Remove duplicate IconFactory instantiation within PageLayoutView

Releases: master
Resolves: #84186
Change-Id: I2fded29170ded49901c02ae4cdb0bcf056dce591
Reviewed-on: https://review.typo3.org/56075
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Assign elementClassAttribute to ImageUpload element 61/56061/3
Benjamin Kott [Thu, 8 Mar 2018 14:22:52 +0000 (15:22 +0100)]
[BUGFIX] Assign elementClassAttribute to ImageUpload element

Resolves: #84179
Releases: master, 8.7
Change-Id: I061674ab878dbfbd2483c17e46a48e2f606ddd87
Reviewed-on: https://review.typo3.org/56061
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
18 months ago[BUGFIX] Proper returnUrl editing permissions from context menu 71/56071/3
Christian Kuhn [Fri, 9 Mar 2018 00:03:44 +0000 (01:03 +0100)]
[BUGFIX] Proper returnUrl editing permissions from context menu

Context menu on pages -> More options -> Access call the
permissions module without proper returnUrl, doc header
"save and close" then fails redirecting to last view.
Fix using similar tec as used in other places like filelist
by providing a proper returnUrl.

Resolves: #83685
Releases: master, 8.7
Change-Id: Ib2136caaee8278438de3ff56faf5a940b7caf1d1
Reviewed-on: https://review.typo3.org/56071
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
18 months ago[BUGFIX] Do not mark "current" links as broken 54/56054/2
Susanne Moog [Thu, 8 Mar 2018 09:53:25 +0000 (10:53 +0100)]
[BUGFIX] Do not mark "current" links as broken

The linkhandler can resolve pages by uid or by using the
special keyword "current" which links the current page id.

The RteHtmlParser marked links to "current" as broken as the check
on whether the page record exists fails with a non-int uid.

The check has been disabled for links to the current page, as in that
context "current" has to be a valid page record (else content could
not be edited on it).

Resolves: #83423
Releases: master, 8.7
Change-Id: Iefde294a5f84e28a5faa1bc1262b7cc84e625f7e
Reviewed-on: https://review.typo3.org/56054
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Let RedirectCacheService not rely on having redirects cached 50/56050/2
Andreas Fernandez [Thu, 8 Mar 2018 07:58:15 +0000 (08:58 +0100)]
[BUGFIX] Let RedirectCacheService not rely on having redirects cached

RedirectCacheService::getRedirects() relies on having the redirects
cached. This assumption may lead to issues (e.g. in case a Redis server
fails), causing TypeErrors.

The code is changed to return the composed array in case the initial
cache request misses.

Resolves: #84070
Releases: master
Change-Id: I148db9ccbf28a2f93761fbf4b2cb632e27787b2d
Reviewed-on: https://review.typo3.org/56050
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] DatabaseRecordLinkBuilder respect now other typoscript settings 26/55426/4
René Pflamm [Mon, 22 Jan 2018 15:02:04 +0000 (16:02 +0100)]
[BUGFIX] DatabaseRecordLinkBuilder respect now other typoscript settings

If typolinks are generated using LinkHandler, the values defined in
typoscript (such as classes and titles) are now retained.

Resolves: #81903
Releases: master, 8.7
Change-Id: I9ec63e2cf972a3c4e7439b9259c63e2ab9b4b60d
Reviewed-on: https://review.typo3.org/55426
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Decouple Bootstrap and Application engaging a PSR-11 container 73/55773/51
Benjamin Franzke [Thu, 8 Feb 2018 20:21:05 +0000 (21:21 +0100)]
[TASK] Decouple Bootstrap and Application engaging a PSR-11 container

In order to avoid global state and to support full-application
subrequests (later on), bootstraping, application initialization
and application execution needs to be decoupled.
(To be able to initialize a frontend Application in backend
Application context, the frontend Application may not re-execute
bootstraping code.)

That means from now on:
 * Bootstrap is limited to stateless bootstrapping
   => setting up package manager and configuration
 * A (new) Container (PSR-11) performs class initialization
   => e.g. `new Frontend/Http/Application()`
 * Application performs execution
   => checking possible (application specific) redirects
   => offloading work to the request handler

This commit transforms Bootstrap into a (static) bootstrap utility
that returns a container (minimal, static PSR-11 implementation).
The entry-point scripts execute the bootstraper and use
the returned container to initialize and run the application.

This commit acts as a starting point for a broader PSR-11 container
support in TYPO3. We do – on purpose – use an own, very limited, anonymous
and static there is no configuration) PSR-11 implemententation for now.
This interim container implementation will be replaced by whatever
PSR-11 supporting container solution we use later on.
That keeps the necessary Bootstrap refactoring seperate from the
introduction of a full dependency injection container implementation.

All existing bootstrap methods keep working as before but the non-static
method invocation should be deprecated at some point.

typo3/cms-cli is adapted for the changed entry point script with:
https://github.com/TYPO3/cms-cli/pull/1

typo3/testing-framework is adapted in
https://github.com/TYPO3/testing-framework/pull/55

This patch brings one important behavioral change:

The install tool redirect (if essential configuration is missing) is
perfomed during application execution – after the configuration has been
loaded (falling back to failsafe mode if missing) – now. Previously the
application performed the redirect before it would call Bootstraps
configure() method. Now that the Application is decoupled from bootstrap,
the bootstrapper ensures it can always create an Application class, in
order for the application to be in charge of the decision what should
happen if essential configuration is missing.

Dependency changes:

composer require psr/container:^1.0
composer require typo3/cms-cli:^2.0
composer require typo3/testing-framework:^3.2 --dev

Change-Id: Idc59665dfcf7250a8a42b3d908a5a2376067700c
Releases: master
Resolves: #83951
Reviewed-on: https://review.typo3.org/55773
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
18 months ago[BUGFIX] Assign elementErrorClassAttribute to ImageUpload and FileUpload element 63/56063/3
Benjamin Kott [Thu, 8 Mar 2018 15:16:21 +0000 (16:16 +0100)]
[BUGFIX] Assign elementErrorClassAttribute to ImageUpload and FileUpload element

Resolves: #84181
Releases: master, 8.7
Change-Id: If55767b54071809e9622f9c29829bf4a76c66409
Reviewed-on: https://review.typo3.org/56063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[BUGFIX] Allow empty date/time in strict database modes 62/56062/3
Oliver Hader [Thu, 8 Mar 2018 14:57:53 +0000 (15:57 +0100)]
[BUGFIX] Allow empty date/time in strict database modes

Empty date/time values are represented by the FormEngine as empty
string (''). Trying to persist this value in database management systems
using strict mode (which is enabled per default in MySQL 5.7),
will cause an SQL error since field types do not match.

Since it's known for the TYPO3 core which field types are used in
particular database tables, it's also possible to enforce this
type to be casted to integer values. This is done by using the
according TCA evaluation function 'int'.

Resolves: #82756
Releases: master, 8.7
Change-Id: I487caae785a3943916bceebc0c484d58e900a841
Reviewed-on: https://review.typo3.org/56062
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[BUGFIX] Allow range options to work for date/time fields 20/56020/7
Jigal van Hemert [Tue, 6 Mar 2018 10:22:35 +0000 (11:22 +0100)]
[BUGFIX] Allow range options to work for date/time fields

Date and time fields can contain ISO-8601 values. To apply lower and
upper limits the value must first be converted to a UNIX timestamp.

Resolves: #83240
Releases: master, 8.7
Change-Id: Ic15e9486cf7a4bcdf557c8a197d957ad88302b61
Reviewed-on: https://review.typo3.org/56020
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
18 months ago[BUGFIX] Recycler selectall feature has wrong data in rst file 59/56059/2
Oskar Dydo [Thu, 8 Mar 2018 13:15:05 +0000 (14:15 +0100)]
[BUGFIX] Recycler selectall feature has wrong data in rst file

Feature #81310 has wrong .rst file. The file should be corresponding to forge id not review id.

Resolves: #84176
Related: #81310
Releases: master
Change-Id: Iefddf9ba82534cb978d8ec3915d5fc34085646f3
Reviewed-on: https://review.typo3.org/56059
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[TASK] Migrate ModuleMenu to TypeScript 00/56000/6
Andreas Fernandez [Sun, 4 Mar 2018 16:56:47 +0000 (17:56 +0100)]
[TASK] Migrate ModuleMenu to TypeScript

This commit migrates the ModuleMenu to TypeScript. The following changes
are additionally done with with patch:

- NavigationComponentInterface requires a `initialize()` method
- Storage/Persistent.set() accepts objects as value
- ModuleMenu.App.ensurePageInTreeSelected is broken since #82426
  and has been removed

Resolves: #82597
Releases: master
Change-Id: I1dc8a79f7953a1e2504b0e7fd978c2e841ec93f4
Reviewed-on: https://review.typo3.org/56000
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
18 months ago[BUGFIX] Remove a duplicate ReST file 55/56055/2
Christian Kuhn [Thu, 8 Mar 2018 10:37:24 +0000 (11:37 +0100)]
[BUGFIX] Remove a duplicate ReST file

ReST file back ported to v8 should be added to 8.7.x/ folder in
core master branch only. Patch for issue #82093 copied the file
to master/ folder, this dupe is removed again.

https://docs.typo3.org/typo3cms/extensions/core/latest/Changelog/Howto.html
for more details on this.

Resolves: #84175
Related: #82093
Releases: master
Change-Id: Ibcd26da62b2c5d7a270a54c5fbe0d72964da6675
Reviewed-on: https://review.typo3.org/56055
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
18 months ago[BUGFIX] Change getUrl() $report['content_type'] to string 43/56043/3
Felix Buenemann [Thu, 8 Mar 2018 08:18:34 +0000 (09:18 +0100)]
[BUGFIX] Change getUrl() $report['content_type'] to string

In the conversion of \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl()
from cURL to GuzzleHttp the type of the $report['content_type'] field
was changed from a string to an array of strings.

This changes the field back to a string.

Also updated ErrorController getUrl test double to reflect the changes.

Resolves: #84173
Related: #84167
Releases: master, 8.7
Change-Id: Ia0eb60c42e920d66ce63afd0bd659c4b56d6d05b
Reviewed-on: https://review.typo3.org/56043
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>