Packages/TYPO3.CMS.git
3 years ago[BUGFIX] ExtensionManager: Make viewhelpers compatible with PHP 7.0 17/45217/5
Morton Jonuschat [Fri, 11 Dec 2015 20:34:52 +0000 (21:34 +0100)]
[BUGFIX] ExtensionManager: Make viewhelpers compatible with PHP 7.0

This patch changes viewhelpers that inherit from the fluid
ActionViewHelper but have a different method signature for render() to
inherit from a base viewhelper that doesn't have a default render()
method, removing the incompatibilities.

Resolves: #72183
Releases: master
Change-Id: Ifb3479b39d972056c2cf8c431f6dc580f5b2630c
Reviewed-on: https://review.typo3.org/45217
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
3 years ago[FOLLOWUP][BUGFIX] Fix initialization for checked attributes 46/45246/2
Markus Klein [Mon, 14 Dec 2015 16:28:30 +0000 (17:28 +0100)]
[FOLLOWUP][BUGFIX] Fix initialization for checked attributes

Only specify a *single* type information for parameters, otherwise
Fluid fails to extract the right type and does not validate the boolean
expressions anymore.

Resolves: #67225
Releases: master
Change-Id: Ibf9873a74e94fb731a3440da25024853663e9c7e
Reviewed-on: https://review.typo3.org/45246
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Set default value for list_type 08/45208/4
Marco Huber [Fri, 11 Dec 2015 11:04:59 +0000 (12:04 +0100)]
[BUGFIX] Set default value for list_type

Set the default value for list_type to an empty string in the
database to match the default value in the TCA.

Resolves: #72171
Related: #32209
Releases: master
Change-Id: I46ed9935571e3b3d8dbfb6bec232ffd8f63a35f0
Reviewed-on: https://review.typo3.org/45208
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Return passed $text if EXT:context_help is not installed 36/45236/2
Andreas Fernandez [Mon, 14 Dec 2015 11:50:38 +0000 (12:50 +0100)]
[BUGFIX] Return passed $text if EXT:context_help is not installed

Return `$text` instead of an empty string if EXT:context_help
is not installed. This shows the field label again but hides the
help buttons.

Resolves: #72205
Related: #71659
Releases: master
Change-Id: I6dba5e40c05e2555ad73d71eb6d177990225a0b4
Reviewed-on: https://review.typo3.org/45236
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[TASK] Install: Added clearer to All Configuration search field 30/45230/3
Michael Oehlhof [Sun, 13 Dec 2015 23:18:28 +0000 (00:18 +0100)]
[TASK] Install: Added clearer to All Configuration search field

Resolves: #71381
Releases: master
Change-Id: I7aca3ffbcd85a3a2a564ade34d8da77d5b1d2bc4
Reviewed-on: https://review.typo3.org/45230
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Correctly evaluate content edit permissions for users 31/45231/3
Markus Klein [Sun, 13 Dec 2015 23:34:28 +0000 (00:34 +0100)]
[BUGFIX] Correctly evaluate content edit permissions for users

Users are permitted to edit content of a page, even though
they are not permitted to edit the page itself.

Resolves: #72172
Releases: master
Change-Id: Ie2e60beec5a04632cf1cb7fef32929cab51408c2
Reviewed-on: https://review.typo3.org/45231
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Add favicon for the Install Tool 24/45224/3
Georg Ringer [Sat, 12 Dec 2015 19:40:46 +0000 (20:40 +0100)]
[TASK] Add favicon for the Install Tool

Readd a favicon for the Install Tool.

Change-Id: I9b0974ff7c7d7cd2e30ecb0819bc90e28ae57219
Resolves: #72165
Releases: master
Reviewed-on: https://review.typo3.org/45224
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[FEATURE] Mocking of concrete methods in abstract classes 30/45130/2
Stefan Rotsch [Fri, 4 Dec 2015 14:40:13 +0000 (15:40 +0100)]
[FEATURE] Mocking of concrete methods in abstract classes

Allows mocking of concrete methods when testing protected functions
in abstract classes.

Introduces a new parameter which will be passed to the corresponding
PHPUnit method when creating a mock object of an abstract class.

Change-Id: I9cbe510633300184666c6204a4d0c5be7d417ef4
Resolves: #72062
Releases: master
Reviewed-on: https://review.typo3.org/45130
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[TASK] Add a space after colon 27/45227/6
Göran Bodenschatz [Sat, 12 Dec 2015 22:46:53 +0000 (23:46 +0100)]
[TASK] Add a space after colon

According traditional and modern English-language writing there has to
be a space after colon.

Resolves: #72191
Releases: master
Change-Id: I59e01ad167963886903d1096cfe15d26de01e6e2
Reviewed-on: https://review.typo3.org/45227
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] FormEngine: Determine IRRE expanded state in data provider 26/44826/14
Andreas Allacher [Fri, 20 Nov 2015 14:06:00 +0000 (15:06 +0100)]
[BUGFIX] FormEngine: Determine IRRE expanded state in data provider

The expanded/collapsed state of inline and combination child records
is determined within the TcaInlineExpandCollapseState provider instead
of the display container so that the concerns are appropriately
separated.

Change-Id: I8152a9f4f689b1c409a9f14d2e29515ab3d91860
Resolves: #71728
Releases: master
Reviewed-on: https://review.typo3.org/44826
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[FOLLOWUP][BUGFIX] Wrong overloading of AbstractController::redirect() 16/45216/4
Morton Jonuschat [Fri, 11 Dec 2015 19:47:36 +0000 (20:47 +0100)]
[FOLLOWUP][BUGFIX] Wrong overloading of AbstractController::redirect()

This patch adds the missing parameters for the redirect method so that
the method signature matches between BackendModuleController and
AbstractController. As the parameters are all optional this is a
non-breaking change.

Resolves: #71303
Resolves: #72168
Releases: master
Change-Id: I8c7d55d1a1b01e1e7cdc3859e6a99eded5008802
Reviewed-on: https://review.typo3.org/45216
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Indexed Search: Bring back html5 placeholder 20/45220/5
Tymoteusz Motylewski [Fri, 11 Dec 2015 23:58:25 +0000 (00:58 +0100)]
[BUGFIX] Indexed Search: Bring back html5 placeholder

The placeholder for the search box of the AbstractPlugin
based plugin was removed by accident in
https://review.typo3.org/6657

This change brings it back.

Resolves: #68381
Releases: master
Change-Id: If876c204b305d6cc67f27fed5a3ca29a894c4b99
Reviewed-on: https://review.typo3.org/45220
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Support \DateTimeInterface in fluid Format\DateViewHelper 18/45218/2
Morton Jonuschat [Fri, 11 Dec 2015 21:38:02 +0000 (22:38 +0100)]
[TASK] Support \DateTimeInterface in fluid Format\DateViewHelper

This patch changes the fluid DateViewHelper to check for date objects
implementing \DateTimeInterface so that \DateTime as well as
\DateTimeImmutable can be supplied as parameter.

Resolves: #72149
Releases: master
Change-Id: I3c3e2648168b283f8ec1fc35845a449c63d0b6ff
Reviewed-on: https://review.typo3.org/45218
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Add quotes to classname in exception 25/45225/2
Georg Ringer [Sat, 12 Dec 2015 20:09:11 +0000 (21:09 +0100)]
[TASK] Add quotes to classname in exception

Add quotes to the class name in the exception to improve debugging.

Change-Id: If68cf9e5d7d7277b5172ed9a56083c95ca0c69ae
Resolves: #66510
Releases: master
Reviewed-on: https://review.typo3.org/45225
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] Fix sorting by extension name 84/45184/5
Patrick Schriner [Wed, 25 Nov 2015 19:14:22 +0000 (20:14 +0100)]
[BUGFIX] Fix sorting by extension name

Introduce a custom column sort for the "Extension" (name) column as that
column can contain HTML which breaks a direct string comparison.

The existing ExtensionManager.compare function is renamed to
versionCompare to circumvent misunderstandings.

Resolves: #72102
Releases: master
Change-Id: I46c120458bc7e9da15c1d7d810b7a003bbbd2937
Reviewed-on: https://review.typo3.org/45184
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[TASK] Fluid: Include jquery libs should be include using https 21/45221/3
Gianluigi Martino [Sat, 12 Dec 2015 13:21:49 +0000 (14:21 +0100)]
[TASK] Fluid: Include jquery libs should be include using https

Change-Id: Ice723e93cab0ef63d17b97df1a81b6e025c620de
Resolves: #72169
Releases: master
Reviewed-on: https://review.typo3.org/45221
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] RTE LinkHandler handle required classes 72/45172/3
Andreas Allacher [Mon, 7 Dec 2015 17:22:46 +0000 (18:22 +0100)]
[BUGFIX] RTE LinkHandler handle required classes

RTE LinkHandler now also handles
RTE.classes.<class>.requires correctly.

Change-Id: I8f50018f522dd9f0b885af7192c003f7fda325b7
Resolves: #71985
Releases: master
Reviewed-on: https://review.typo3.org/45172
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
3 years ago[BUGFIX] Indexed Search: Display links to external files 42/45142/4
Tymoteusz Motylewski [Sat, 5 Dec 2015 13:29:06 +0000 (14:29 +0100)]
[BUGFIX] Indexed Search: Display links to external files

Indexed search is rendering links to external files now.
Indexed search will not check if the file exists before displaying
search results. As a side effect this change also improves performance.

This change is affecting only the AbstractPlugin based plugin.
Extbase version do not have this check.

Resolves: #44381
Releases: master
Change-Id: Iae4e5b2f2cc575853f25c674cbb4307bdf3efa17
Reviewed-on: https://review.typo3.org/45142
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
3 years ago[BUGFIX] Make ToggleExtensionInstallationStateViewHelper PHP 7 compliant 60/45160/4
Michael Oehlhof [Sun, 6 Dec 2015 23:12:38 +0000 (00:12 +0100)]
[BUGFIX] Make ToggleExtensionInstallationStateViewHelper PHP 7 compliant

Match the declaration of the render function with the function
declaration of the base class.

In addition cleanup some code.

Resolves: #71304
Releases: master
Change-Id: I26527229ccf47928e954c412b4046d55c228e9de
Reviewed-on: https://review.typo3.org/45160
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] ExportPageTreeView wrapTitle() signature is incompatible 11/45211/5
Markus Sommer [Fri, 11 Dec 2015 13:11:50 +0000 (14:11 +0100)]
[BUGFIX] ExportPageTreeView wrapTitle() signature is incompatible

ExportPageTreeView contains following method declaration:

 public function wrapTitle($title, $v);

however in the AbstractTreeView the signature is:

 public function wrapTitle($title, $row, $bank = 0);

This will create a PHP warning on PHP7.

This change updates the method signature of the ExportPageTreeView to be
in line with the AbstractTreeView.

Resolves: #72176
Releases: master
Change-Id: Icc6cb69ffd4860f882157239e25135e2a6744a65
Reviewed-on: https://review.typo3.org/45211
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Localize FAL error messages 90/44490/10
Mathias Schreiber [Mon, 2 Nov 2015 21:49:17 +0000 (22:49 +0100)]
[BUGFIX] Localize FAL error messages

FAL error messages were taken directly from the sys_log entries and
then put into flash messages. Now we provide proper translations for
the flash messages.

Resolves: #71255
Releases: master
Change-Id: I56985957fee865d5e86f66a63b22d8e88a097007
Reviewed-on: https://review.typo3.org/44490
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Replace GeneralUtility::inList() with comparison 39/37139/7
Jo Hasenau [Mon, 23 Feb 2015 20:27:06 +0000 (21:27 +0100)]
[TASK] Replace GeneralUtility::inList() with comparison

Using direct comparisons instead of GeneralUtility::inList() is faster
and uses less memory.

Releases: master
Resolves: #55626
Change-Id: I0acfe07fbd796ba017dd64d6987139bfb80db898
Reviewed-on: https://review.typo3.org/37139
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] FormEngine: Handle empty arrays in display conditions 14/45214/2
Morton Jonuschat [Fri, 11 Dec 2015 14:38:59 +0000 (15:38 +0100)]
[BUGFIX] FormEngine: Handle empty arrays in display conditions

Records passed to the EvaluateDisplayConditions provider can contain
array values which can be empty in the case of new records. Handle this
condition in the evaluator.

Resolves: #71824
Releases: master
Change-Id: Ie5aa3f74913059f2a1e5933a8314dee6cb0fa1fa
Reviewed-on: https://review.typo3.org/45214
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[CLEANUP] ImportExport classes 03/45203/4
Markus Klein [Wed, 9 Dec 2015 18:00:11 +0000 (19:00 +0100)]
[CLEANUP] ImportExport classes

Resolves: #72156
Releases: master
Change-Id: I3582dfd8304d07536bf68104141a5fcabb12bd89
Reviewed-on: https://review.typo3.org/45203
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Use IconFactory in System Information Panel 12/45212/2
Frank Nägler [Fri, 11 Dec 2015 13:17:30 +0000 (14:17 +0100)]
[TASK] Use IconFactory in System Information Panel

Resolves: #72178
Releases: master
Change-Id: Ia1de64625280ad0cd50e56c80f3ea6efc2c0e86a
Reviewed-on: https://review.typo3.org/45212
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Track pids of deleted/moved records to clear cache 66/39766/8
Jigal van Hemert [Wed, 27 May 2015 21:45:29 +0000 (23:45 +0200)]
[BUGFIX] Track pids of deleted/moved records to clear cache

Clearing caches is done after all operations. The pid can't be read from
the deleted or from the old location of the moved record so an array
remembers these pids for the clear cache operation.

Resolves: #61017
Releases: master, 6.2
Change-Id: I4552d2b9b2a6ea475563fd62a62f29a57fe9df70
Reviewed-on: https://review.typo3.org/39766
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[TASK] Make JavaScript Icon API a singleton 96/45196/4
Andreas Fernandez [Wed, 9 Dec 2015 15:41:02 +0000 (16:41 +0100)]
[TASK] Make JavaScript Icon API a singleton

The JavaScript Icon API is now a singleton. This ensures the code is only
executed once and especially the cache is shared between all requests.

Resolves: #72126
Releases: master
Change-Id: Iafd61b90d2414f655e6500bc564b90490afc58b0
Reviewed-on: https://review.typo3.org/45196
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
3 years ago[BUGFIX] Show error message in page module for invalid backend layout 46/45146/4
Georg Ringer [Wed, 9 Dec 2015 15:32:21 +0000 (16:32 +0100)]
[BUGFIX] Show error message in page module for invalid backend layout

If there is a backend layout selected with no colPos defined inside the backend layout option, then the page
module fatals with an error.

A error message is now shown to display that at least one
colPos parameter must be set.

Resolves: #67276
Releases: master
Change-Id: I02120be981607d35efa31f49cc0ee4cc992172e4
Reviewed-on: https://review.typo3.org/45146
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
3 years ago[BUGFIX] Correctly handle whitespace in format.date VH 00/45200/2
Markus Klein [Thu, 10 Dec 2015 14:23:24 +0000 (15:23 +0100)]
[BUGFIX] Correctly handle whitespace in format.date VH

Child content may contain line breaks or other whitespace.
Trim the content before processing it.

Resolves: #72152
Releases: master
Change-Id: Ibf5d3fb2c5ca74bb045c4278f0852c47e2131eab
Reviewed-on: https://review.typo3.org/45200
Reviewed-by: Felix Rauch <rauch@skaiamail.de>
Tested-by: Felix Rauch <rauch@skaiamail.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
3 years ago[TASK] Configuration: Make searchbox clearable and fix scroll position 02/45202/4
Josef Glatz [Thu, 10 Dec 2015 18:17:13 +0000 (19:17 +0100)]
[TASK] Configuration: Make searchbox clearable and fix scroll position

This patches ensures the page is scrolled to the right position
upon opening a subtree.
Additionally, the "clear search" button is added to the search field.

Releases: master
Resolves: #72155
Change-Id: I4227ab0d362b8be2bb531dd341fb30e5d50d37ab
Reviewed-on: https://review.typo3.org/45202
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] Determine returnUrl when deleting pages in EditDocumentController 26/45126/9
Andreas Fernandez [Mon, 7 Dec 2015 20:08:31 +0000 (21:08 +0100)]
[BUGFIX] Determine returnUrl when deleting pages in EditDocumentController

Determine the returnUrl based on the current module and record. If the
delete action if for a record in the table "pages" the backend needs to
perform a partial reload to avoid trying to access the deleted page. In
all other cases the predetermined returnUrl is ok.

Resolves: #72058
Resolves: #72081
Related: #71425
Releases: master
Change-Id: Id019f2b4a6f60cb850322d6667094b832c62a8e0
Reviewed-on: https://review.typo3.org/45126
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] Move default avatar image from background css to img tag 91/45191/3
Michael Oehlhof [Tue, 8 Dec 2015 23:49:23 +0000 (00:49 +0100)]
[BUGFIX] Move default avatar image from background css to img tag

If a transparent avatar image is assigned the default avatar no longer
shines through.

Resolves: #70220
Releases: master
Change-Id: I889c706616876d45d0d9a371b96591ec27aa264c
Reviewed-on: https://review.typo3.org/45191
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] Use correct title for links to create new records 95/45195/2
Georg Ringer [Wed, 9 Dec 2015 13:34:47 +0000 (14:34 +0100)]
[BUGFIX] Use correct title for links to create new records

If records can not be sorted, the title of the link should just state
'Create new record' instead of 'create new record after this record'.

Change-Id: I270ff1043b31366fbb8c90a259d52583a178f301
Resolves: #69934
Releases: master
Reviewed-on: https://review.typo3.org/45195
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Hide CSH button if context_help is disabled 97/45197/4
Gianluigi Martino [Wed, 9 Dec 2015 15:38:00 +0000 (16:38 +0100)]
[BUGFIX] Hide CSH button if context_help is disabled

Do not show the help icon if the extension "context_help" is not installed.

Change-Id: Ia23c5c1a2d61a1e24e9de96def2fdb6a0a69b99f
Resolves: #71659
Releases: master
Reviewed-on: https://review.typo3.org/45197
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[TASK] Update T3Icons to 0.0.9 87/45187/2
Benjamin Kott [Tue, 8 Dec 2015 19:50:08 +0000 (20:50 +0100)]
[TASK] Update T3Icons to 0.0.9

Resolves: #27475
Resolves: #72056
Releases: master
Change-Id: I3439bfcea56367b44a81db2fa9dc77272cb246e1
Reviewed-on: https://review.typo3.org/45187
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] LiveSearch: Don't trigger select on valid input 77/45177/3
Michael Oehlhof [Mon, 7 Dec 2015 22:45:36 +0000 (23:45 +0100)]
[BUGFIX] LiveSearch: Don't trigger select on valid input

Disable automatically selecting a valid search result. Otherwise, if
there is only one suggestion provided and the suggestion perfectly
matches the search string, the result is auto selected and no longer
visible/clickable.

Resolves: #71584
Releases: master
Change-Id: I239bf1dac9ce5b4851af4f48f3771d47ae1d8384
Reviewed-on: https://review.typo3.org/45177
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] Fix initialization for checked attributes 46/40646/9
Frederic Gaus [Thu, 25 Jun 2015 14:10:00 +0000 (16:10 +0200)]
[BUGFIX] Fix initialization for checked attributes

Fix the phpDoc for checked attributes in CheckboxViewHelper
and RadioViewHelper

Fix the inititialization of the multiple parameter of the
CheckboxViewHelper

Resolves: #67225
Releases: master
Change-Id: I53dc8793e95f0c45077559ea14f92f268e0a834a
Reviewed-on: https://review.typo3.org/40646
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Remove slash in description 85/45185/2
Boris Schauer [Tue, 8 Dec 2015 14:53:32 +0000 (15:53 +0100)]
[BUGFIX] Remove slash in description

Resolves: #72108
Change-Id: I076bbec8614ae9da807befba27fba7be72a037c2
Reviewed-on: https://review.typo3.org/45185
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Prefix all CSS for admin panel 73/45173/2
Wouter Wolters [Mon, 7 Dec 2015 17:49:46 +0000 (18:49 +0100)]
[BUGFIX] Prefix all CSS for admin panel

Resolves: #72091
Releases: master
Change-Id: I2666cbc431a6c3a9bda6640fd8f123fd58d86ba4
Reviewed-on: https://review.typo3.org/45173
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[FOLLOWUP][BUGFIX] ImageViewHelper should catch exceptions 66/45166/3
Andreas Allacher [Mon, 7 Dec 2015 09:57:36 +0000 (10:57 +0100)]
[FOLLOWUP][BUGFIX] ImageViewHelper should catch exceptions

We also need to catch RuntimeException and InvalidArgumentException
InvalidArgumentException might be thrown if a storage does not exist.
RuntimeException if a file is outside a storage.

Change-Id: I994d8e7ef8b515f23ccc01847cefac0202f14b6f
Releases: master, 6.2
Resolves: #71686
Reviewed-on: https://review.typo3.org/45166
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Hide report notice in about module for editors 68/45168/2
Georg Ringer [Mon, 7 Dec 2015 12:25:19 +0000 (13:25 +0100)]
[BUGFIX] Hide report notice in about module for editors

Editors are not allowed to see the reports module, therefore the link
'Please check the status report for more information' does not work.
Furthermore those users can't change anything which is reported, so
don't show this information at all.

Displaying less warnings which can not be changed improve the usability.

Change-Id: I552b34f4bc1e249c51abc166699597b1678a61f9
Resolves: #72084
Releases: master
Reviewed-on: https://review.typo3.org/45168
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Use strict authMode access check for list_type 65/45165/2
Georg Ringer [Mon, 7 Dec 2015 09:37:24 +0000 (10:37 +0100)]
[BUGFIX] Use strict authMode access check for list_type

Enforcing a strict authMode check is required to make sure
that editors only see those content elements of type CType='list'
which they are allowed to see.

Change-Id: I47f92a03a3dacbbf686fd9592ea679a40f3a828b
Resolves: #32209
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/45165
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Ralf Merz <info@merzilla.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Display prev & next icons in workspace module again 59/45159/3
Georg Ringer [Sun, 6 Dec 2015 20:10:19 +0000 (21:10 +0100)]
[BUGFIX] Display prev & next icons in workspace module again

As the workspace module is not working with the new icon API yet,
show the icons by adding them in the CSS file directly.

Change-Id: Ib49d8d8ed33034ed0cfdb59a3f2b022fb0ef8fee
Resolves: #71797
Releases: master
Reviewed-on: https://review.typo3.org/45159
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Ralf Merz <info@merzilla.de>
Tested-by: Ralf Merz <info@merzilla.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Removed delete icon in toolbar for sys_file_metadata 62/45162/6
Michael Oehlhof [Mon, 7 Dec 2015 00:28:38 +0000 (01:28 +0100)]
[BUGFIX] Removed delete icon in toolbar for sys_file_metadata

Resolves: #71678
Releases: master
Change-Id: I28e13da627a5b9312f36e1811ede5fbe3bd415bb
Reviewed-on: https://review.typo3.org/45162
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] Re-validate after remove IRRE element 99/45099/3
Frank Nägler [Wed, 2 Dec 2015 20:41:20 +0000 (21:41 +0100)]
[BUGFIX] Re-validate after remove IRRE element

Resolves: #72014
Releases: master
Change-Id: I035336ec841eef1bc2c8c7875a71f7df316f134e
Reviewed-on: https://review.typo3.org/45099
Reviewed-by: Armin Ruediger Vieweg <armin@v.ieweg.de>
Tested-by: Armin Ruediger Vieweg <armin@v.ieweg.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Show correct icon for textmedia in page module 61/45161/2
Michael Oehlhof [Mon, 7 Dec 2015 00:06:08 +0000 (01:06 +0100)]
[BUGFIX] Show correct icon for textmedia in page module

Resolves: #70144
Releases: master
Change-Id: I9a5d6360b5f58fe46e65c6be508a3d7c6859015d
Reviewed-on: https://review.typo3.org/45161
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[TASK] Allow to define multiple inlineLocalizeSynchronize commands 54/44354/3
Oliver Hader [Thu, 29 Oct 2015 12:59:53 +0000 (13:59 +0100)]
[TASK] Allow to define multiple inlineLocalizeSynchronize commands

The inlineLocalizeSynchronize command in DataHandler currently
supports these formats:
* [parent][13][inlineLocalizeSynchronize] = field,14
* [parent][13][inlineLocalizeSynchronize] = field,localize
* [parent][13][inlineLocalizeSynchronize] = field,synchronize

Since the sub-commands "localize" and "synchronize" address the
whole parent scope, the particular definition of a child-id (14
in this case) is only considered for one child-element. Localizing
different children would then result in multiple independent
DataHandler processings.

The scope of this change is to extend the API to define multiple
child-ids and define the proper language, which is currently
determined from the parent-element magically.

The current string configuration format is changed to be an array,
legacy configurations are converted to the new format:

[parent][13][inlineLocalizeSynchronize] = [
  field: name of the parent field,
  language: id of the target language,
  action: either "localize" or "synchronize",
  ids: array of child-ids to be localized [1, 2, 3]
]
Either "action" or "ids" must be defined.

Resolves: #71126
Releases: master, 6.2
Change-Id: Ic7e1293a44047bfd69017e240dd8563a1dffa423
Reviewed-on: https://review.typo3.org/44354
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 years ago[BUGFIX] DebuggerUtility should return css when requested. 47/45147/2
Benni Mack [Sat, 5 Dec 2015 15:12:16 +0000 (16:12 +0100)]
[BUGFIX] DebuggerUtility should return css when requested.

The DebuggerUtility of Extbase should only echo the CSS when
the debug info is echoed as well, otherwise it should be
returned just like the option describes it.

Resolves: #60893
Releases: master
Change-Id: I7196df201cb5974308aaf103aac5d63e63c02e61
Reviewed-on: https://review.typo3.org/45147
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 years ago[BUGFIX] RTE: Use correct settings 36/44736/8
Andreas Allacher [Mon, 16 Nov 2015 16:10:12 +0000 (17:10 +0100)]
[BUGFIX] RTE: Use correct settings

RTE linkhandler properties and classes are now handled correctly.

Change-Id: I943c561e357848b30ae74a3d86062189273b91e5
Releases: master
Resolves: #71248
Reviewed-on: https://review.typo3.org/44736
Tested-by: Renzo Bauen <info@conpassione.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Render flag icons correctly in backend 56/45156/2
Michael Oehlhof [Sun, 6 Dec 2015 12:22:04 +0000 (13:22 +0100)]
[BUGFIX] Render flag icons correctly in backend

Resolves: #71505
Releases: master
Change-Id: Icd915e9919b46d6e8dca5feb0741a4db6b4c7a5e
Reviewed-on: https://review.typo3.org/45156
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
3 years ago[BUGFIX] Re-implement GFX[thumbnails] for Backend 38/45138/2
Benni Mack [Sat, 5 Dec 2015 12:38:59 +0000 (13:38 +0100)]
[BUGFIX] Re-implement GFX[thumbnails] for Backend

The option to disable thumbnails globally for every
backend user in various places does not work anymore,
but is still quite useful. The patch re-introduces the option
to not show the thumbnail in various places.

Resolves: #60497
Releases: master
Change-Id: I28e8bf86563032df8008c7de9aa7861bb5c0e2c0
Reviewed-on: https://review.typo3.org/45138
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] ColorPicker: Use absolute web path for exampleImg 40/45140/2
Benni Mack [Sat, 5 Dec 2015 12:58:19 +0000 (13:58 +0100)]
[BUGFIX] ColorPicker: Use absolute web path for exampleImg

The Example Image of the color picker is currently hardcoded (also with ..)
to the typo3/ directory.
This hinders integrators to allow any other file outside of typo3/ to be shown.

The patch corrects the path resolving part of the Color Picker.

Resolves: #70428
Releases: master
Change-Id: I2fb5a6b7379ee1cb5fd6e76d8081f2f72f91a098
Reviewed-on: https://review.typo3.org/45140
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Let FormEngine Slider wizard save data again 45/45145/2
Benni Mack [Sat, 5 Dec 2015 14:45:59 +0000 (15:45 +0100)]
[BUGFIX] Let FormEngine Slider wizard save data again

Due to a change in FormEngine slider rewrite, the parameters
do not get handed over to the TBE_EDITOR update signal,
thus any changes on the slider do not reflect the actual field
that is sent to the server again.

Using apply() correctly as well as a document.ready()
statement makes this functionality work again.

Resolves: #71977
Releases: master
Change-Id: Ib033015d0c3869da487e9163ceca303bd1b436c8
Reviewed-on: https://review.typo3.org/45145
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Use "id" attribute for HMENU images in HTML5 41/45141/2
Benni Mack [Sat, 5 Dec 2015 13:06:54 +0000 (14:06 +0100)]
[BUGFIX] Use "id" attribute for HMENU images in HTML5

When setting no config.doktype=html5, then the TYPO3
Frontend renders everything as HTML5, except for
the "name" attribute for before/after logic of HMENUs,
which should use "id" attributes.

The "default" option needs to be taken into account
in order to use "id" instead of "name".

Resolves: #62487
Releases: master
Change-Id: If4cccffd499de4c81b862fa2a2e0fb194ac3bcec
Reviewed-on: https://review.typo3.org/45141
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 years ago[TASK] Use root paths for fluid templates in indexed_search 18/45118/3
Daniel Goerz [Thu, 3 Dec 2015 22:23:52 +0000 (23:23 +0100)]
[TASK] Use root paths for fluid templates in indexed_search

The extbase/fluid plugin of indexed search still uses the deprecated
rootPath for templates, partials and layouts. This patch adjusts the
typoscript to use rootPaths.

Change-Id: I7fc164d3ef14aaa1674f3f7940e2cd921a0a9216
Resolves: #72051
Releases: master
Reviewed-on: https://review.typo3.org/45118
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
3 years ago[TASK] Remove unused properties in $LANG 37/45137/2
Benni Mack [Sat, 5 Dec 2015 12:06:32 +0000 (13:06 +0100)]
[TASK] Remove unused properties in $LANG

The properties $charsetArray and $typo3_help_url
inside LanguageService are not needed and are outdated,
thus they can be removed.

Resolves: #72069
Releases: master
Change-Id: Icc6bc48297b361b2797614214176e463d25f683f
Reviewed-on: https://review.typo3.org/45137
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Make t3skin frame dimension overrides default 36/45136/2
Benni Mack [Sat, 5 Dec 2015 12:04:27 +0000 (13:04 +0100)]
[TASK] Make t3skin frame dimension overrides default

The TBE_STYLES settings in t3skin are not needed since
the default should be actually the whole backend setting.

The patch changes the settings accordingly.

Resolves: #72068
Releases: master
Change-Id: I7de0c3d8da0c3bdc9f58b56960a073193832ce0e
Reviewed-on: https://review.typo3.org/45136
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] sys_note not displayed in footer -list 33/45133/2
Gianluigi Martino [Fri, 4 Dec 2015 23:00:33 +0000 (00:00 +0100)]
[BUGFIX] sys_note not displayed in footer -list

No notes displayed in the list view footer

Change-Id: I54461133797db0a7a309b2b31407a41e29d1ba5d
Resolves: #72066
Releases: master
Reviewed-on: https://review.typo3.org/45133
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Avoid overly large regex in substituteMarkerArrayCached 97/45097/2
Markus Klein [Wed, 2 Dec 2015 20:15:11 +0000 (21:15 +0100)]
[BUGFIX] Avoid overly large regex in substituteMarkerArrayCached

Fetch the actually used markers from the content and only
generate the replace regex for those.
This avoids problems where 1000 markers may be passed in,
but only 10 are actually used.

Resolves: #44270
Releases: master, 6.2
Change-Id: I05f60960949e945249b045a8ae8e8430f7d8f7e6
Reviewed-on: https://review.typo3.org/45097
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] FormEngine: show inline children found by RelationHandler 75/45075/3
Nicole Cordes [Tue, 1 Dec 2015 15:21:36 +0000 (16:21 +0100)]
[BUGFIX] FormEngine: show inline children found by RelationHandler

Currently only inline children with a proper default parent are added to
the result array for alternative languages. This patch ensures that all
inline children found by the RelationHandler are added and shown in the
backend as well.

Resolves: #71712
Releases: master
Change-Id: I21febbe5947bb61c098a95cf498d7dfb874f1212
Reviewed-on: https://review.typo3.org/45075
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Streamline JavaScript calls to ModuleMenu reload 88/45088/2
Benni Mack [Wed, 2 Dec 2015 13:45:11 +0000 (14:45 +0100)]
[TASK] Streamline JavaScript calls to ModuleMenu reload

There are several versions (partly legacy) of how to
trigger a reload of the Module Menu. This is now
streamlined.

Additionally the NewContentElementController does
not reload the module menu anymore on loading.

Resolves: #72024
Releases: master
Change-Id: I58fc274f22d0312b0616e20e379225f77540fbb3
Reviewed-on: https://review.typo3.org/45088
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] File Recycler collect deleted files again 76/45076/6
Michael Oehlhof [Tue, 1 Dec 2015 21:46:21 +0000 (22:46 +0100)]
[BUGFIX] File Recycler collect deleted files again

Check if a _recycler_ folder exists along the path from the storage root
to the file. If a matching folder is found move the file or folder to be
deleted to the closest _recycler_ folder instead of immediately removing
them from the local filesystem.

Resolves: #66247
Resolves: #45327
Releases: master
Change-Id: Iac000095b86e7c888461aeb0347b9548d8edcd90
Reviewed-on: https://review.typo3.org/45076
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Avoid wrong SQL query in fe_login user group redirect 47/39447/6
Frederic Gaus [Mon, 11 May 2015 15:07:11 +0000 (17:07 +0200)]
[BUGFIX] Avoid wrong SQL query in fe_login user group redirect

Ensure that no invalid group data is collected and check
if any group is set at all before running the SQL query.

Change-Id: I5792ff606d60ba5e5a108ed18c2ec91e354f85ff
Resolves: #64966
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/39447
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Ignore placeholders when copying records 76/11076/24
Oliver Hader [Sat, 31 Oct 2015 19:46:46 +0000 (20:46 +0100)]
[BUGFIX] Ignore placeholders when copying records

Copying records would make placeholders for draft elements visible in the
copy. This is due to the fact that t3ver_state information is removed upon
copy and the records itself are not ignored either. To circument that, now
only relevant records are selected for each scope, being live workspace or
any draft workspace. This also means, that new placeholders are copied if
the process has been initiated on a real draft workspace, which does not
happen if the duplication process was triggered in the live workspace.

Resolves: #36946
Resolves: #42075
Releases: master, 6.2
Change-Id: I0952d1a46d1cc02e0ec97f7cbbc9abc700e00c07
Reviewed-on: https://review.typo3.org/11076
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] EXT:lang Add a litle space between the search field and the table 48/45048/2
Michael Oehlhof [Sun, 29 Nov 2015 11:46:29 +0000 (12:46 +0100)]
[TASK] EXT:lang Add a litle space between the search field and the table

Resolves: #71955
Releases: master
Change-Id: I900f5edddaeef523647c15f4a677256f723b281f
Reviewed-on: https://review.typo3.org/45048
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Ralf Merz <info@merzilla.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Bring back the toggle button in install tool 10/45110/7
Gianluigi Martino [Thu, 3 Dec 2015 14:47:00 +0000 (15:47 +0100)]
[TASK] Bring back the toggle button in install tool

This patch brings back the toggle button for all configuration in install tool

Resolves: #71387
Releases: master
Change-Id: I827f3389c564857e76f215f6e9c6d22cddb2728f
Reviewed-on: https://review.typo3.org/45110
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Remove NOT NULL from optional text fields in system extensions 39/45039/6
Tomas Norre Mikkelsen [Sun, 29 Nov 2015 10:00:29 +0000 (11:00 +0100)]
[BUGFIX] Remove NOT NULL from optional text fields in system extensions

Removes NOT NULL requirement from TEXT database columns where the field is
not required to be filled in the backend. This aligns TCA definition and
database configuration, allowing to skip those fields when creating
records as MySQL doesn't allow default values for TEXT columns.

Resolves: #71952
Releases: master
Change-Id: Ic863899c6343a8e8c603a265c85dd906ad834568
Reviewed-on: https://review.typo3.org/45039
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] DBAL: Fix renaming of tables in Install Tool 24/45124/2
Morton Jonuschat [Fri, 4 Dec 2015 09:51:55 +0000 (10:51 +0100)]
[BUGFIX] DBAL: Fix renaming of tables in Install Tool

Add handling of the RENAME action to compileALTERTABLE() to allow the
InstallTool to rename a table before suggesting to drop it permanently.

Resolves: #72036
Releases: master
Change-Id: Ie0886594b09e9b3fc19e6c68ecdbc1dcaeeae46b
Reviewed-on: https://review.typo3.org/45124
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Replace editOnClick in Page Layout Module 94/44494/4
Benni Mack [Fri, 4 Dec 2015 09:51:03 +0000 (10:51 +0100)]
[TASK] Replace editOnClick in Page Layout Module

Replaces all JavaScript code for building URLs
with proper <a href=""> HTML output.

Resolves: #71261
Releases: master
Change-Id: I40b2adc52936cfb8d7d4b0e5f7742d3391ed2a98
Reviewed-on: https://review.typo3.org/44494
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[FOLLOWUP][BUGFIX] ImageViewHelper should catch exceptions 23/45123/3
Benni Mack [Fri, 4 Dec 2015 08:39:49 +0000 (09:39 +0100)]
[FOLLOWUP][BUGFIX] ImageViewHelper should catch exceptions

The Uri/ImageViewHelper should catch exceptions as well.

Releases: master
Resolves: #71686
Change-Id: I63d472070cd2e9f8db28c646684ce0c32b1c08e1
Reviewed-on: https://review.typo3.org/45123
Reviewed-by: Andreas Allacher <andreas.allacher@gmx.at>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Catch security exceptions in global JS module 93/45093/2
Markus Klein [Wed, 2 Dec 2015 15:39:21 +0000 (16:39 +0100)]
[BUGFIX] Catch security exceptions in global JS module

The storage JS module is loaded in the top window.
In case this windows has been opened by some other page
(different domain) then a security exception is thrown
by the browsers, which kills the execution.

Catch exceptions when accessing the opener to avoid
this particular edge case.

Resolves: #71857
Releases: master
Change-Id: Ifa19d1f70eae71ac46c66bb759580d82ce5b6c99
Reviewed-on: https://review.typo3.org/45093
Reviewed-by: Eckard Gehrke <eckard.gehrke@gmx.de>
Tested-by: Eckard Gehrke <eckard.gehrke@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Change name of correct pagetree entry after renaming 77/44977/3
Martin Gebert [Fri, 27 Nov 2015 12:51:45 +0000 (13:51 +0100)]
[BUGFIX] Change name of correct pagetree entry after renaming

* The first parameter to TreeEditor.complete and
TreeEditor.beforecomplete is the TreeEditor, not the edited node.
Reflect this in the code.
* In TreeEditor.updateNodeText, update the node provided as parameter
instead of the current editNode.
* In saveTitle, remove the first parameter, because it's used in the
wrong way (code assumes i'ts a node, but it's actually a TreeEditor) and
is not necessary.
* In saveTitle, store the current editNode, in case treeEditor.editNode
changes before the ajax call completes.

Resolves: #56371
Releases: master
Change-Id: I9446969701f0e24bcc048305ea06819228982826
Reviewed-on: https://review.typo3.org/44977
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Refer to correct naming of link handler TSconfig option 21/45121/2
Markus Klein [Fri, 4 Dec 2015 00:27:27 +0000 (01:27 +0100)]
[BUGFIX] Refer to correct naming of link handler TSconfig option

Resolves: #71664
Releases: master
Change-Id: If656d6f5f6641013968b73b0165f58d0a75ab3b5
Reviewed-on: https://review.typo3.org/45121
Reviewed-by: Andreas Allacher <andreas.allacher@gmx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] TCA Time Field allow 0:00 as valid input 58/45058/3
Frank Nägler [Mon, 30 Nov 2015 12:26:41 +0000 (13:26 +0100)]
[BUGFIX] TCA Time Field allow 0:00 as valid input

Resolves: #56668
Releases: master
Change-Id: I9ec1519ffbdde09b74165efc00074ceef3b38f84
Reviewed-on: https://review.typo3.org/45058
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] ImageViewHelper should catch exceptions 96/44796/3
Andreas Allacher [Thu, 19 Nov 2015 13:27:33 +0000 (14:27 +0100)]
[BUGFIX] ImageViewHelper should catch exceptions

The ImageViewHelper should catch the following exceptions:
1.) \UnexpectedValueException:
This can happen if a file has been replaced with a folder.

2.) \TYPO3\CMS\Core\Resource\Exception\ResourceDoesNotExistException
If a file was deleted (or renamed directly in the file system).
Such a scenario should still result in a proper page.

Change-Id: I73fa4c279d779a524c0a10021df56529dde052fc
Releases: master, 6.2
Resolves: #71686
Reviewed-on: https://review.typo3.org/44796
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Only show search on non-empty pages 90/45090/4
Andreas Fernandez [Wed, 2 Dec 2015 14:45:58 +0000 (15:45 +0100)]
[BUGFIX] Only show search on non-empty pages

If a page has neither content nor subpages, do not show the search button
in the backend.

Resolves: #72027
Releases: master
Change-Id: Iff2657a203f25123c288ea48e6fc553483bdd254
Reviewed-on: https://review.typo3.org/45090
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Optimize backend checkboxes check / uncheck all 61/45061/9
Frank Nägler [Mon, 30 Nov 2015 13:03:30 +0000 (14:03 +0100)]
[TASK] Optimize backend checkboxes check / uncheck all

This patch optimises the handling of SelectCheckBoxElements.
The checkbox also shows a tooltip now.

Resolves: #71021
Releases: master
Change-Id: If850d489fdc1f3f7909d3695a4509904daea3f18
Reviewed-on: https://review.typo3.org/45061
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] DebuggerUtility: Treat null results of lazy objects correctly 00/45100/2
Markus Klein [Wed, 2 Dec 2015 20:54:38 +0000 (21:54 +0100)]
[BUGFIX] DebuggerUtility: Treat null results of lazy objects correctly

Resolves: #71951
Releases: master, 6.2
Change-Id: I590f1915fad84e09a6e45988d1adf17f61598c46
Reviewed-on: https://review.typo3.org/45100
Reviewed-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Tested-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Disable debug for Fluid Ajax Widget 82/45082/2
Benni Mack [Wed, 2 Dec 2015 12:22:39 +0000 (13:22 +0100)]
[BUGFIX] Disable debug for Fluid Ajax Widget

If TYPO3_CONF_VARS[FE][debug] is enabled then the
parseTime is added at the end of each frontend output.

When having AJAX responses, this might be problematic
as the expected output contains more than what is needed.

Explicitly setting debug=0 for the page type 7076 resolves
the problem in Fluid.

Releases: master
Resolves: #71793
Change-Id: I6295286232dd0b1e4257b4e9a3928837ba6e9a1b
Reviewed-on: https://review.typo3.org/45082
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Render previews for all files in FSCs upload CE 81/45081/2
Daniel Goerz [Wed, 2 Dec 2015 09:08:37 +0000 (10:08 +0100)]
[BUGFIX] Render previews for all files in FSCs upload CE

Change-Id: I418e2985efb11a3074cf9ee15935b3274c316165
Resolves: #71994
Releases: master
Reviewed-on: https://review.typo3.org/45081
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Fix MySQL specific language query in LocalizationController 98/45098/2
Morton Jonuschat [Wed, 2 Dec 2015 20:20:38 +0000 (21:20 +0100)]
[BUGFIX] Fix MySQL specific language query in LocalizationController

Change the SQL statement used to query for available source languages to
be standards compliant by grouping on the queried field instead of the
counterpart in the joined tt_content table.

Resolves: #72017
Releases: master
Change-Id: I6902411f11e82a96513db640bc197e67ecba1e89
Reviewed-on: https://review.typo3.org/45098
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Enable disabled FAL functional test assertions 91/45091/3
Oliver Hader [Wed, 2 Dec 2015 15:00:55 +0000 (16:00 +0100)]
[TASK] Enable disabled FAL functional test assertions

Resolves: #72028
Releases: master
Change-Id: I6092222a2726f06aae26967183161971c4ead858
Reviewed-on: https://review.typo3.org/45091
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Add php7 to the list of known php files 83/45083/2
Benni Mack [Wed, 2 Dec 2015 12:27:26 +0000 (13:27 +0100)]
[TASK] Add php7 to the list of known php files

Releases: master
Resolves: #72019
Change-Id: I60a1458bdffb5df9c177d183f1229bcba930c95a
Reviewed-on: https://review.typo3.org/45083
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Do not load ContextHelp JS if no BE user is there 89/45089/2
Markus Klein [Wed, 2 Dec 2015 14:41:37 +0000 (15:41 +0100)]
[BUGFIX] Do not load ContextHelp JS if no BE user is there

This avoids to load the JS for the BE login for instance.

Resolves: #72026
Releases: master
Change-Id: I12827386e1e6d97b6c0dda5a6ddd0cd393659781
Reviewed-on: https://review.typo3.org/45089
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Reintroduce support for reverseProxySSL 01/44001/6
ajahn [Mon, 12 Oct 2015 08:06:44 +0000 (10:06 +0200)]
[BUGFIX] Reintroduce support for reverseProxySSL

Creating a backend request relies on TYPO3_CONF_VARS which
is not set yet.
This breaks requests when using a reverse proxy for SSL
because HTTP is used as scheme even thogh HTTPS should be used.

Change-Id: Id3f5fe2189f5bcc017da8ebcc21cc43920917aa0
Resolves: #70525
Releases: master
Reviewed-on: https://review.typo3.org/44001
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Cleanup unused variable in AbstractUserAuthentication 84/45084/2
Benni Mack [Wed, 2 Dec 2015 12:38:01 +0000 (13:38 +0100)]
[TASK] Cleanup unused variable in AbstractUserAuthentication

The variable global database info is removed as it
is never used.

Resolves: #72020
Releases: master
Change-Id: I22bde60fbedb66a67f6738f00c722879f24a82e3
Reviewed-on: https://review.typo3.org/45084
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Always show close button for temporary web mounts 74/45074/3
Andreas Fernandez [Tue, 1 Dec 2015 13:25:33 +0000 (14:25 +0100)]
[BUGFIX] Always show close button for temporary web mounts

Position the close button absolutely to always show the
close button on the right side.

Resolves: #71983
Releases: master
Change-Id: Ic809fa3e994a9897bb24e368883d6807139b0251
Reviewed-on: https://review.typo3.org/45074
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[TASK] Add language to images in filemetadata 21/44221/3
Stephan Großberndt [Thu, 22 Oct 2015 11:37:41 +0000 (13:37 +0200)]
[TASK] Add language to images in filemetadata

Also make the order the same for text and application.

Resolves: #70950
Releases: master
Change-Id: I90601ba98d7af18223d7cb93de47ba30f598f8c0
Reviewed-on: https://review.typo3.org/44221
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Use correct path for content rendering template inclusion 80/45080/3
Markus Klein [Wed, 2 Dec 2015 01:48:39 +0000 (02:48 +0100)]
[BUGFIX] Use correct path for content rendering template inclusion

Resolves: #70044
Releases: master
Change-Id: Ibc10dce2d445583eea879efe4d13219be8f547c8
Reviewed-on: https://review.typo3.org/45080
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] toTop Link reloads page with baseUrl in fluid_styled_content 53/45053/5
Gianluigi Martino [Sun, 29 Nov 2015 18:45:28 +0000 (19:45 +0100)]
[BUGFIX] toTop Link reloads page with baseUrl in fluid_styled_content

When using fluid_styled_content toTop option, the page reload if baseUrl
is set.

Change-Id: I6216dc6ddc6b56696710e234144c4b2bd7ac87dd
Resolves: #71695
Releases: master
Reviewed-on: https://review.typo3.org/45053
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] FormEngine: Select correct FlexForm DS for inline records 14/44914/3
Morton Jonuschat [Mon, 23 Nov 2015 11:12:08 +0000 (12:12 +0100)]
[BUGFIX] FormEngine: Select correct FlexForm DS for inline records

If an inline field is defined within a FlexForm that has multiple data
structures defined the FormAjaxInlineController always selects the
default data structure due to missing context information.

This patch transmits the required context within the AJAX request to
enable selecting the appropriate data structure for the flexform.

It also changes the method to determine the path through the flexform
data structure to work in the case of an inline element configured
within a flexform within another inline element.

Resolves: #71436
Related: #70918
Related: #71564
Related: #71655
Releases: master
Change-Id: I7ecd174b78997ad3b1d1513a15a78cdc7bac23ff
Reviewed-on: https://review.typo3.org/44914
Tested-by: Armin Ruediger Vieweg <armin@v.ieweg.de>
Tested-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Tested-by: Felix Rauch <rauch@skaiamail.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Christopher Orth <corthmail@gmail.com>
Tested-by: Torsten <info@by-torsten.com>
Tested-by: Philipp Wrann <philippwrann@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Show hidden templates in tstemplate 67/40767/6
Frederic Gaus [Tue, 30 Jun 2015 12:11:12 +0000 (14:11 +0200)]
[BUGFIX] Show hidden templates in tstemplate

Show hidden templates in backend module tstemplate

Resolves: #52223
Releases: master
Change-Id: Ida5f2bc2d57155e4e1c5057d3a6fd156774302c5
Reviewed-on: https://review.typo3.org/40767
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Allow overlaying of records for all languages again 41/44941/4
Mathias Schreiber [Wed, 25 Nov 2015 15:44:58 +0000 (16:44 +0100)]
[BUGFIX] Allow overlaying of records for all languages again

Return records with sys_language_uid=-1 untouched instead of
completely dropping them.

This is actually a problem up higher in the calling stack but
should be fixed properly in the near future.

Resolves: #71621
Releases: master
Change-Id: Ib39f200d4a4cb6ee538f45e0bccca845f10e1e16
Reviewed-on: https://review.typo3.org/44941
Reviewed-by: Joschi Kuphal <joschi@tollwerk.de>
Tested-by: Joerg Kummer <service@enobe.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] DBAL: Properly compile CAST statement after OR condition 70/45070/3
Morton Jonuschat [Mon, 30 Nov 2015 18:39:31 +0000 (19:39 +0100)]
[BUGFIX] DBAL: Properly compile CAST statement after OR condition

Properly output the CAST statement after the combination of
using FIND_IN_SET followed by an OR condition.

Resolves: #71979
Releases: master
Change-Id: If9dbdd0743c3bda43e23260ef78752176dd1b85d
Reviewed-on: https://review.typo3.org/45070
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] ImageManipulationElement: Fix PHPDoc block comment 72/45072/2
Josef Glatz [Tue, 1 Dec 2015 08:19:59 +0000 (09:19 +0100)]
[BUGFIX] ImageManipulationElement: Fix PHPDoc block comment

Releases: master
Resolves: #71992
Change-Id: Ida543d0abc24e51a7f510fc180f491239ba3059c
Reviewed-on: https://review.typo3.org/45072
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Shortcut to first sub-page with move placeholder does not work 62/45062/2
Oliver Hader [Mon, 30 Nov 2015 13:44:33 +0000 (14:44 +0100)]
[BUGFIX] Shortcut to first sub-page with move placeholder does not work

Shortcuts to the first sub-page with that one being moved in a workspace
lead to an exception in previewing in a workspace context. Reason is that
the move-placeholder of the valid target in the live workspace is being
disabled in a workspace which is not checked further.

Resolves: #71984
Releases: master
Change-Id: I671611b63f9baea5ff310bcbd30b42e6378580c9
Reviewed-on: https://review.typo3.org/45062
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Empty grid list in frontend workspace preview 07/44307/3
Oliver Hader [Mon, 26 Oct 2015 23:06:56 +0000 (00:06 +0100)]
[BUGFIX] Empty grid list in frontend workspace preview

The grid list of the frontend workspace preview stayed empty due to
several JavaScript issues. First one is a CORS thingy with local
document.domain values being set and for the list IFRAME being set
too late (and thus running into CORS error). Besides that the tabs
component is only available in the backend workspace module and
leads to another error if expected and used in the frontend preview.

Resolves: #66169
Releases: master, 6.2
Change-Id: I5bf3dd7760c9382527d85e6e7e8e0ad5dca81c05
Reviewed-on: https://review.typo3.org/44307
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Move FSC templates one level up 56/45056/2
Markus Klein [Mon, 30 Nov 2015 11:15:49 +0000 (12:15 +0100)]
[BUGFIX] Move FSC templates one level up

This make the configuration less misleading.

Resolves: #71781
Releases: master
Change-Id: Ic2e593520f52dabc1ccce136d05f465f6bd96ec9
Reviewed-on: https://review.typo3.org/45056
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
3 years ago[TASK] Add possibility to purge workspaces move placeholder 68/45068/2
Oliver Hader [Mon, 30 Nov 2015 16:20:30 +0000 (17:20 +0100)]
[TASK] Add possibility to purge workspaces move placeholder

During resolving references in a workspace context overlays and
delete-placeholder are considered and it's possible to define
whether they are kept or substituted. This mechanism is missing
for move-placeholders as well.

Resolves: #71990
Releases: master, 6.2
Change-Id: Id0a5326c968b5ceaca2af4c092f9907a91797823
Reviewed-on: https://review.typo3.org/45068
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Extend regular workspaces DataHandler functional tests 66/45066/3
Oliver Hader [Mon, 30 Nov 2015 15:13:59 +0000 (16:13 +0100)]
[TASK] Extend regular workspaces DataHandler functional tests

The following actions are added:
* delete content and copy either draft or live page
* change content sorting and copy either draft or live page
* move content around and copy either draft or live page

Resolves: #71988
Releases: master, 6.2
Change-Id: I398fc9f0e7f91a9a944c74868d2718fdf19aa9f8
Reviewed-on: https://review.typo3.org/45066
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>