Packages/TYPO3.CMS.git
6 years ago[BUGFIX] Fix PHP warning when writing to Backend user log 16/23116/4
Alexander Stehlik [Thu, 15 Aug 2013 16:05:10 +0000 (18:05 +0200)]
[BUGFIX] Fix PHP warning when writing to Backend user log

The writelog method for the BackendUserAuthentication object is now
checking if there is actually an uid available in the user array
before it tries to access it.

This prevents a PHP warning about an illegal string offset when writing
log messages in an authentication service.

Releases: 6.0, 6.1, 6.2
Resolves: #49328
Change-Id: I006c6b0ccd8f03292715a7d7ab8e457914637d93
Reviewed-on: https://review.typo3.org/23116
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Display relations' titles when TCA label field is type inline 02/23902/4
Claus Due [Thu, 19 Sep 2013 11:34:09 +0000 (13:34 +0200)]
[BUGFIX] Display relations' titles when TCA label field is type inline

This change adds a case to treat "inline" TCA types the same way
"select" is treated when building the record's label value.

Before, if record used field of type "inline" as TCA label field, TYPO3
would display fx "3" (number of related records as stored in field
on parent record).

After, TYPO3 will display fx "Record1, Record2, Record2" if "inline"
field contains three related records named thusly.

Fixes: #52133
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ie06f09368e81505cb1e5989b61ae98add54b05ba
Reviewed-on: https://review.typo3.org/23902
Reviewed-by: Benjamin Rau
Tested-by: Benjamin Rau
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Cedric Ziel
Tested-by: Cedric Ziel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGIFX] Missing rendering for newer menus 74/23674/2
Francois Suter [Sun, 8 Sep 2013 14:22:14 +0000 (16:22 +0200)]
[BUGIFX] Missing rendering for newer menus

Rendering is missing in css_styled_content for menu types
8 and 9 (introduced in 6.0 and 6.2 respectively) for older
versions of the static templates (i.e. below 6.0).

Add them down to 4.5.

Resolves: #51837
Releases: 6.2
Change-Id: I5f6f9068ceb89851c67b3c1ee2bd580936498c70
Reviewed-on: https://review.typo3.org/23674
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Faulty expand/collapse behavior in Element Browser 34/22934/3
Oliver Hader [Wed, 7 Aug 2013 17:01:53 +0000 (19:01 +0200)]
[BUGFIX] Faulty expand/collapse behavior in Element Browser

On using the element browser in combination with files, the
expand/collapse behavior is wrong. On opening a collapsed folder,
an AJAX call fetches the sub-nodes that will be added to the DOM
tree. However, the calling scope of the original rendering
process and the AJAX call differ a lot.
The only possibility to get this working is to transfer the
scope and rebuild it in the AJAX context.

Change-Id: I1bf7b56ae2d82d15e0246bd651f77793adde705b
Fixes: #45859
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22934
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Markus Schubath
Tested-by: Markus Schubath
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Form Wizard: Adds mouse pointer to docheader icons 74/23874/2
Ernesto Baschny [Tue, 17 Sep 2013 16:03:03 +0000 (18:03 +0200)]
[BUGFIX] Form Wizard: Adds mouse pointer to docheader icons

Resolves: #50907
Releases: 6.2, 6.1, 6.0
Change-Id: I232498fea18b270e9436aeaf710f728a62365a4b
Reviewed-on: https://review.typo3.org/23874
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Fix cropping of transparent gifs with im6. 96/13996/8
Stefan Neufeind [Thu, 25 Apr 2013 12:06:49 +0000 (14:06 +0200)]
[BUGFIX] Fix cropping of transparent gifs with im6.

The usage of the ! operator to force cropping empty image
canvas is inverted between ImageMagick v4 and v6 while
GraphicsMagick accepts both syntaxes. Because im4 is
deprecated, we can always use im6 syntax.

Fixes: #19045
Releases: 6.2, 6.1, 6.0
Change-Id: Iee1260a94f2686a512ce1b1df65c384319a4c4de
Reviewed-on: https://review.typo3.org/13996
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Felix Buenemann
Tested-by: Felix Buenemann
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[FEATURE] Allow multiple category fields per table 72/23772/20
Sebastian Michaelsen [Wed, 11 Sep 2013 15:07:13 +0000 (17:07 +0200)]
[FEATURE] Allow multiple category fields per table

It is only possible to do one makeCategorizable() call per
table, because if you do more the later calls would overwrite the
previous category field declaration. That's because of the way
the registry stores the category fields - it can only store one
field per table. This change improves that and allow multiple
fields pers table.

Additionally, a custom label can be set in the options array
for each category field.

Resolves: #51921
Releases: 6.2
Change-Id: I96d1235176109395339e9841564edadc0c71147d
Reviewed-on: https://review.typo3.org/23772
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[TASK] Remove GFX/im_mask_temp_ext_noloss setting 37/23837/3
Christian Kuhn [Sat, 14 Sep 2013 23:38:54 +0000 (01:38 +0200)]
[TASK] Remove GFX/im_mask_temp_ext_noloss setting

im_mask_temp_ext_noloss setting is a bugfix for a no longer supported
Image Magick 5 version. It can be removed.

Change-Id: I1001c3fc8fa924ec16e24a9e790a0decf2771bcc
Resolves: #52012
Releases: 6.2
Reviewed-on: https://review.typo3.org/23837
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Remove GFX/im_combine_filename setting 36/23836/3
Christian Kuhn [Sat, 14 Sep 2013 23:31:07 +0000 (01:31 +0200)]
[TASK] Remove GFX/im_combine_filename setting

Image Magick support for versions 4 and 5 was dropped. The setting
to differentiate combine from composite is obsolete now and composite
is used always.

Change-Id: I0fbc847167d340fd83315285745c63d53225891a
Resolves: #52011
Releases: 6.2
Reviewed-on: https://review.typo3.org/23836
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove BE/TSconfigConditions setting 38/23838/2
Christian Kuhn [Sat, 14 Sep 2013 23:58:07 +0000 (01:58 +0200)]
[TASK] Remove BE/TSconfigConditions setting

Did you know there is an option to disable condition parsing in
TS config? It is removed with the patch.

Change-Id: If6ce720a4416af80b7deb293160e8b712c04ff0d
Resolves: #52013
Releases: 6.2
Reviewed-on: https://review.typo3.org/23838
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove GFX/im_no_effects setting 35/23835/2
Christian Kuhn [Sat, 14 Sep 2013 23:08:24 +0000 (01:08 +0200)]
[TASK] Remove GFX/im_no_effects setting

Support for Image Magick version 4 and 5 was dropped, allowed
settings for im_version_5 are "im6" and "gm". As soon as one
of this is set for im_version_5, bootstrap automatically sets
"im_no_effects" to 1. In effect, this value is *always* one, so
it is obsolete and can be removed from the system.

Change-Id: Ieb798352aebaae4943018a225518591a952a8bcb
Resolves: #52010
Releases: 6.2
Reviewed-on: https://review.typo3.org/23835
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Install tool: Use sRGB colorspace in presets 40/23840/6
Christian Kuhn [Sun, 15 Sep 2013 13:50:08 +0000 (15:50 +0200)]
[BUGFIX] Install tool: Use sRGB colorspace in presets

Image Magick versions 6.7 and above need sRGB as colorspace,
otherwise images are too dark. This also works for older versions
like 6.6. Use sRGB as default is image configuration presets.

Change-Id: I7c50ee932b1335892eb228b10fc00136cfc54527
Resolves: #52017
Releases: 6.2
Reviewed-on: https://review.typo3.org/23840
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] SQL error in install tool if no root page available 33/23833/2
Steffen Müller [Sat, 14 Sep 2013 15:53:11 +0000 (17:53 +0200)]
[BUGFIX] SQL error in install tool if no root page available

Resolves: #52008
Releases: 6.2
Change-Id: I8fd7546ca6a293c6e9d11dd46d37a8cc89cf9620
Reviewed-on: https://review.typo3.org/23833
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Install tool sanitizes image generation output 97/23797/7
Wouter Wolters [Thu, 12 Sep 2013 20:04:28 +0000 (22:04 +0200)]
[BUGFIX] Install tool sanitizes image generation output

If execute path to ImageMagick or GraphicsMagick is not configured
correctly, the "Test setup" image tests in the install tool may show
false positives and do not render an error message that the image
generation faild.
The patch adds checks and displays an error message if for example
['GFX']['im_path'] is set to an invalid path.
There are other issues in this area, for example existing test
image files may be re-used with a broken configuration. These
are also fixed with this patch.

Change-Id: Id3cf116b80371379eae9c9dc348d9daee9d5b074
Resolves: #35070
Releases: 6.2
Reviewed-on: https://review.typo3.org/23797
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Don't set extensions checked by default in InstallSysExtsUpdate 27/23827/2
Wouter Wolters [Sat, 14 Sep 2013 11:59:57 +0000 (13:59 +0200)]
[TASK] Don't set extensions checked by default in InstallSysExtsUpdate

In the InstallSysExtsUpdate update wizard the extensions are checked
by default. This gives the indication that the extensions need
to be installed. In fact they are optional and therefore should
not be checked by default.

Change-Id: Ic61ad081b08d1906d224a29c79702db3fe1597e1
Resolves: #47733
Releas: 6.2
Reviewed-on: https://review.typo3.org/23827
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[FEATURE] Show string value for PHP error codes in install tool 94/23794/9
Wouter Wolters [Thu, 12 Sep 2013 17:29:56 +0000 (19:29 +0200)]
[FEATURE] Show string value for PHP error codes in install tool

"All configuration" in install tool shows the integer representation
of the bit mask of the PHP error codes in settings like
['SYS']['errorHandlerErrors']. This change adds a view helper to
show the current setting in an E_* constants representation.

Resolves: #51376
Releases: 6.2
Change-Id: Ia69251d97c07b1180f8e7ad99b687b5639396892
Reviewed-on: https://review.typo3.org/23794
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Improve description of config preset in install tool 32/23832/4
Steffen Müller [Sat, 14 Sep 2013 14:39:23 +0000 (16:39 +0200)]
[TASK] Improve description of config preset in install tool

Resolves: #52007
Releases: 6.2
Change-Id: I4c8bb6930040a9f3a5c5bc92c9638a98a2668daf
Reviewed-on: https://review.typo3.org/23832
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[FEATURE] Conditions support in backend layouts 97/23697/2
Alexey Gafiulov [Thu, 5 Sep 2013 15:58:11 +0000 (21:58 +0600)]
[FEATURE] Conditions support in backend layouts

Resolves: #47588
Releases: 6.2
Change-Id: I266f28472ffd78443b107d7ad6577603aecbc584
Reviewed-on: https://review.typo3.org/23697
Reviewed-by: Jo Hasenau
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[BUGFIX] Configuration controller fatals with local-only extension 38/23738/4
Sebastian Fischer [Wed, 11 Sep 2013 08:01:14 +0000 (10:01 +0200)]
[BUGFIX] Configuration controller fatals with local-only extension

If the settings of a local-only extension get saved the configuration
controller fatals. This is because the result of the extension model
repository does not get checked, if it really is a model.

With this fix the instance is first checked and afterwards the category
is read from the model.

Resolves: #51902
Releases: 6.2
Change-Id: I543aa0960f3c2ba1877189b44e47aa7f86c81928
Reviewed-on: https://review.typo3.org/23738
Reviewed-by: Sebastian Michaelsen
Tested-by: Sebastian Michaelsen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Improve status messages of install tool 22/23822/4
Steffen Müller [Fri, 13 Sep 2013 20:49:59 +0000 (22:49 +0200)]
[TASK] Improve status messages of install tool

Resolves: #51995
Releases: 6.2
Change-Id: Ic1f2459b58f5376a306a6e8c910398ce6e4a9efe
Reviewed-on: https://review.typo3.org/23822
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Install Tool System environment warning badges look ugly 24/23824/3
Ernesto Baschny [Fri, 13 Sep 2013 21:25:27 +0000 (23:25 +0200)]
[BUGFIX] Install Tool System environment warning badges look ugly

The badges are now aligned and don't jump around when
the menu entry is selected. The left menu gets more room.

Releases: 6.2
Resolves: #51997
Change-Id: Ia9eb44467243781677df6a8046d6c2c864e70ad8
Reviewed-on: https://review.typo3.org/23824
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up install tool module 23/23823/3
Helmut Hummel [Fri, 13 Sep 2013 21:21:00 +0000 (23:21 +0200)]
[TASK] Clean up install tool module

Resolves: #51996
Releases: 6.2
Change-Id: I5afca17c80931f3f9946fa5f33dc29fd1f572644
Reviewed-on: https://review.typo3.org/23823
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[FEATURE] Install tool: Left menu at fixed position 98/23798/10
Ernesto Baschny [Fri, 13 Sep 2013 17:26:09 +0000 (19:26 +0200)]
[FEATURE] Install tool: Left menu at fixed position

* Streamlines install tool main template.
* Adds a ContextService and use that in the templates.
  No more huge if/then/else constructs to differentiate
  standalone and backend modes.
* Fixes the left menu (and TYPO3 logo), letting the
  rest scroll up and down.
* In backend mode the menu and content starts right on top
  (no further headers to make scrolling look good)

Releases: 6.2
Resolves: #50910
Change-Id: Ie2ec277026a82332b533af51a37e7f308dd24e8c
Reviewed-on: https://review.typo3.org/23798
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
6 years ago[TASK] Add new icon for ext:reports 18/23818/3
Wouter Wolters [Fri, 13 Sep 2013 17:22:14 +0000 (19:22 +0200)]
[TASK] Add new icon for ext:reports

Add a new icon for ext:reports-module and adjust the
IconViewHelper. Removes 2 old icons.

Change-Id: Iff731cc27ad8e6323aea8c6c01c036f3a776b3e2
Related: #41631
Resolves: #51993
Releases: 6.2
Reviewed-on: https://review.typo3.org/23818
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Install tool: Fixed document header 12/23812/2
Christian Kuhn [Fri, 13 Sep 2013 16:02:19 +0000 (18:02 +0200)]
[BUGFIX] Install tool: Fixed document header

The document header is not at a fixed position but "scrolls away".
Fix this by adding a missing t3skin structure .css that defines this.

Change-Id: Ia1b3209db1b5fa08157002bca950110830e2403e
Resolves: #51989
Related: #50910
Releases: 6.2
Reviewed-on: https://review.typo3.org/23812
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Also consider JPEG files for IM/GM 10/23810/2
Markus Klein [Fri, 13 Sep 2013 14:37:32 +0000 (16:37 +0200)]
[BUGFIX] Also consider JPEG files for IM/GM

The Core does not check for the JPEG file extension
when converting images with IM/GM.

Resolves: #51981
Releases: 6.2, 6.1, 6.0
Change-Id: I148ecb0d3c71fdee563476c33865cd18420b2384
Reviewed-on: https://review.typo3.org/23810
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Use a 401 header if login is not successful 49/23649/5
Georg Ringer [Fri, 6 Sep 2013 08:00:04 +0000 (10:00 +0200)]
[TASK] Use a 401 header if login is not successful

If login is not correct, a 401 should be used instead of a 200.

Change-Id: Ia2fa139e89fe19df77bb0530b4fbce502506f524
Resolves: #51803
Releases: 6.2,6.1,6.0,4.5
Reviewed-on: https://review.typo3.org/23649
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGFIX] Replace SHOW DATABASE by query to schema 37/23637/6
Alexander Opitz [Thu, 5 Sep 2013 12:55:47 +0000 (14:55 +0200)]
[BUGFIX] Replace SHOW DATABASE by query to schema

The SQL query "SHOW DATABASE" may be restricted on the SQL Server.
Since MySQL 5.0 (which is minimum since TYPO3 CMS 4.7) we can also query
the information_schema table to gather the information to which table
we have access.

Resolves: #47744
Releases: 6.2, 6.1
Change-Id: Ie65abadeed54cbc54bee401bdc1aab18ffc8eea6
Reviewed-on: https://review.typo3.org/23637
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Call to undefined method setTemplateFile 34/23734/2
Wouter Wolters [Tue, 10 Sep 2013 17:13:11 +0000 (19:13 +0200)]
[BUGFIX] Call to undefined method setTemplateFile

Call to undefined method when setting
'pageHeaderFooterTemplateFile' in TypoScriptFrontendController.
This needs to be called on the page renderer object.

Change-Id: Ic4407addb5d22f09fc4cd6482cc79ad5af724582
Resolves: #51891
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23734
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Use lambda functions instead of create_function 82/23782/4
Christoph Dörfel [Thu, 12 Sep 2013 09:57:47 +0000 (11:57 +0200)]
[TASK] Use lambda functions instead of create_function

Make use of the possibilities of PHP 5.3+ and replace all
instances of create_function with an inlined function call.

Change-Id: I3ebabd56efe5d7e3ee07cffbf1f3bb6b5c85e7ff
Resolves: #51937
Releases: 6.2
Reviewed-on: https://review.typo3.org/23782
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Christoph Dörfel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[TASK] Install tool: Sort "All configuration" sections 91/23791/4
Christian Kuhn [Thu, 12 Sep 2013 15:12:18 +0000 (17:12 +0200)]
[TASK] Install tool: Sort "All configuration" sections

Order the sections in all configuration alphabetically.

Change-Id: I2096d2b0d8892e93a5740d0ad2b7dee1ddceb93e
Resolves: #47740
Releases: 6.2
Reviewed-on: https://review.typo3.org/23791
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Improve Installer database selection step 70/23770/4
Markus Klein [Wed, 11 Sep 2013 22:53:01 +0000 (00:53 +0200)]
[TASK] Improve Installer database selection step

Make the following adaption:
 * Change the order of the two options.
 * Preselect the first, empty, existing database.
 * Add a hint, that the user must have sufficient privileges
   to create a new database.

Resolves: #51931
Releases: 6.2
Change-Id: I823a194ddd1dc3aad2d560354bce20855c5c372c
Reviewed-on: https://review.typo3.org/23770
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Install tool shows docheader in backend 89/23789/2
Christian Kuhn [Thu, 12 Sep 2013 12:56:15 +0000 (14:56 +0200)]
[BUGFIX] Install tool shows docheader in backend

Install tool should show a document header if called in backend.
It includes some .css files from t3skin to do that. Those files
were moved around in issue #51134, not adapted in install tool,
resulting in 404 and missing document header. The patch adapts
templates to include files at new locations.

Change-Id: I9df6950ec3e218c175b012d9ef4233c5b5f6c925
Resolves: #51952
Related: #51134
Releases: 6.2
Reviewed-on: https://review.typo3.org/23789
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Installing TYPO3 -> Installing TYPO3 CMS 84/23784/2
Christian Kuhn [Thu, 12 Sep 2013 12:15:24 +0000 (14:15 +0200)]
[BUGFIX] Installing TYPO3 -> Installing TYPO3 CMS

Use correct product name in title tag and box during installation.

Change-Id: I21141aa06c12c1abf7fff83e1e33148be6c6373f
Resolves: #51946
Releases: 6.2
Reviewed-on: https://review.typo3.org/23784
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Install tool: Refactor db connect configuration settings 94/23394/12
Christian Kuhn [Wed, 28 Aug 2013 09:35:42 +0000 (11:35 +0200)]
[TASK] Install tool: Refactor db connect configuration settings

Refactor needsExecution() logic to make sure the mandatory settings
(username, password, host, port) are present in LocalConfiguration.php
before trying to establish a database connection using these settings.

This fixes a possible redirect loop if some of the mandatory settings
were not present, but the database connection check still succeeded.

Change-Id: Ifbf98a4bdcb62d9d29b7fbc1f3a03d3a7d621492
Resolves: #51433
Releases: 6.2
Reviewed-on: https://review.typo3.org/23394
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix phpDoc comment for addStaticFile() 81/23781/3
Alexander Stehlik [Thu, 12 Sep 2013 09:57:51 +0000 (11:57 +0200)]
[BUGFIX] Fix phpDoc comment for addStaticFile()

The method
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addStaticFile()
should be called in ext_tables.php files since it manipulates the
TCA.

Resolves: #51939
Releases: 6.2
Change-Id: I75f099fb5d64ee1e11867c41728b2747a666ebfd
Reviewed-on: https://review.typo3.org/23781
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix SQL error for sys_file 67/23767/3
Markus Klein [Wed, 11 Sep 2013 22:06:15 +0000 (00:06 +0200)]
[BUGFIX] Fix SQL error for sys_file

Regression for SQL error introduced with #51562.

Resolves: #51929
Releases: 6.2, 6.1
Change-Id: Ib9756234fed6284c5c7547284dff9f3308360c35
Reviewed-on: https://review.typo3.org/23767
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Install Tool: Improve UX for foldout sections 55/23755/2
Markus Klein [Wed, 11 Sep 2013 15:44:48 +0000 (17:44 +0200)]
[BUGFIX] Install Tool: Improve UX for foldout sections

Change the cursor and add an arrow for foldout sections
in the Install Tool.

Resolves: #49188
Releases: 6.2
Change-Id: Iaf8f17b420f0716a23b5a6d8d4ebbbaa815a9143
Reviewed-on: https://review.typo3.org/23755
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[TASK] Move StorageRepositoryTest tests to AbstractRepositoryTest 62/23762/4
Anja Leichsenring [Wed, 11 Sep 2013 16:59:28 +0000 (18:59 +0200)]
[TASK] Move StorageRepositoryTest tests to AbstractRepositoryTest

All tests in the class belong to AbstractRepository, so the tests move.

Change-Id: I5e78e0d61a2d8f8bcfd06d871a909b749417e616
Resolves: #51923
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23762
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Empty __call() function hides implementation errors 63/23763/2
Anja Leichsenring [Wed, 11 Sep 2013 17:06:53 +0000 (19:06 +0200)]
[BUGFIX] Empty __call() function hides implementation errors

Throw an Exception if this method hits.

Change-Id: Ide94043bb008e1dfaf19b452570ce70d5f2aa432
Resolves: #51924
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/23763
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Move forgotten getEnvironmentMode() 59/23759/3
Anja Leichsenring [Wed, 11 Sep 2013 16:47:30 +0000 (18:47 +0200)]
[BUGFIX] Move forgotten getEnvironmentMode()

getWhereClauseForEnabledFields() moved from StorageRepository
to AbstractRepository, but getEnvironmentMode() stayed
in StorageRepository although getWhereClauseForEnabledFields()
relies on it. Move getEnvironmentMode() as well.

Change-Id: Id252c8bd3b9e09a2c38d5ea1ebe6497dd76c12ae
Resolves: #51562
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23759
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] FAL ResourceStorage must not access sys_file table directly 70/23470/4
Steffen Ritter [Wed, 11 Sep 2013 15:45:47 +0000 (17:45 +0200)]
[TASK] FAL ResourceStorage must not access sys_file table directly

The ResourceStorage accesses the index table sys_file directly via
a call to the $GLOBALS[TYPO3_DB]. The interaction with the sys_file
index table should be managed only by an according repository to
allow changes within that mechanism.

This patch rearranges the factory method to use the according
call within the FileRepository and adapts it, as the FileRepository
will return a file Object instead of an array.

This serves as a preparation for further indexing optimisations,
which need IndexRecords to be handled centrally.

Releases: 6.2, 6.1, 6.0
Resolves: #51519
Change-Id: I5aa2d212b936b218db1808ea3d0384b8292287a9
Reviewed-on: https://review.typo3.org/23470
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Follow-Up: Missing signals on adding file 52/23752/2
Stefan Neufeind [Wed, 11 Sep 2013 15:04:37 +0000 (17:04 +0200)]
[BUGFIX] Follow-Up: Missing signals on adding file

Mocked driver needs to return a proper "file" on calls to addFile().

Change-Id: Iddfc2f9b7e71101ad229a513727f65f64d654d45
Releases: 6.2, 6.1, 6.0
Resolves: #50795
Reviewed-on: https://review.typo3.org/23752
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Enable allWrap.splitChar on all includeJS/includeCSS properties 69/23669/5
Christoph Dörfel [Thu, 5 Sep 2013 16:06:47 +0000 (18:06 +0200)]
[FEATURE] Enable allWrap.splitChar on all includeJS/includeCSS properties

The includeJS/includeCSS properties of the PAGE object feature an
allWrap property which replaces all pipe symbols with the generated
tag. This behaviour differs from how wraps are handled in TYPO3.
A splitChar can now be defined for the allWrap property and the wrap
works like the standard wrap method from the ContentObject class.

Resolves: #51782
Releases: 6.2
Change-Id: Ic2687394c209b0f58185f37a64b14dff30efd2a1
Reviewed-on: https://review.typo3.org/23669
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGFIX] Missing signals on adding file 23/22823/6
Andreas Wolf [Mon, 5 Aug 2013 13:28:01 +0000 (15:28 +0200)]
[BUGFIX] Missing signals on adding file

There are signals for most operations performed in the file storage, but
not for adding a file. Especially this operation is interesting for
things like file indexing, automatic generation of variants (renditions)
etc., therefore this patch adds the two missing signals.

Change-Id: I0def7b44ff8977a42916e01388604fcbf2d6d299
Resolves: #50795
Release: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22823
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Remove sys_file.deleted flag and it's usage 67/23567/4
Ernesto Baschny [Tue, 3 Sep 2013 19:39:50 +0000 (21:39 +0200)]
[TASK] Remove sys_file.deleted flag and it's usage

This also fixes the 'Uncaught TYPO3 Exception #1317178604
No file found for given UID.' that appears when some sys_file
entries have a deleted flag set by mistake.

Resolves: #51562
Releases: 6.2, 6.1, 6.0
Change-Id: Id23636d2732f3562b8a155025656b26041c9a4e2
Reviewed-on: https://review.typo3.org/23567
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Install tool configuration system 21/23321/15
Christian Kuhn [Mon, 12 Aug 2013 15:57:03 +0000 (17:57 +0200)]
[TASK] Install tool configuration system

The patch implements a "configuration system" to the install tool
that bundles several settings to enable them on click
depending on system capabilities.

A "feature" is represented by a set of configuration options that
are filled by different presets. Presets have a priority, the
best preset is the first one. Presets can be available or
not available and active or not. For example the "image handling"
feature has the presets "GraphicsMagick" and "ImageMagick 6" and
a "Custom" preset if the others do not fit.

This first patch implements "Charset conversion", "Image handling",
"Development / Production" and "Extbase object cache" settings.

During installation the available preset with highest priority
are configured.

Change-Id: I7304ef001717989720924e7ae03951eb3874adfd
Resolves: #51454
Releases: 6.2
Reviewed-on: https://review.typo3.org/23321
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Follow-up: Fix fileinfo property mapping in ResourceStorage 16/23716/4
Stefan Neufeind [Mon, 9 Sep 2013 22:11:50 +0000 (00:11 +0200)]
[BUGFIX] Follow-up: Fix fileinfo property mapping in ResourceStorage

Adjust unittest to changed conditions.

Change-Id: Ia885ba544a159cb1666464cece30c3e6ea3558b6
Fixes: #49386
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23716
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
6 years ago[FEATURE] Enable/disable cascading deletion of child elements 51/22551/5
Christoph Niewerth [Thu, 25 Jul 2013 08:06:36 +0000 (10:06 +0200)]
[FEATURE] Enable/disable cascading deletion of child elements

Deleting a record will also delete all child records,
which are configured as type inline (field, list) within.
This patch adds a behaviour configuration option "enableCascadingDelete"
which is by default treated as true. If set to FALSE or '' or 0
deletion of inline child records will be disabled.

Resolves: #50391
Releases: 6.2
Change-Id: I7462e7721cd140880edeea82664ce4721aea63a7
Reviewed-on: https://review.typo3.org/22551
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Exception using cObject FORM in TypoScript 37/6537/5
Andreas Bouche [Fri, 4 Nov 2011 09:32:09 +0000 (10:32 +0100)]
[BUGFIX] Exception using cObject FORM in TypoScript

Through a bug introduced by #31120, an Exception is thrown when a
TypoScript FORM object should be rendered.

Change-Id: Ie67484fd014620ea229a7bee8bfebd063a3b57ae
Fixes: #31572
Releases: 6.2, 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/6537
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Fix fileinfo property mapping in ResourceStorage::setFileContents 34/21634/3
Thomas Maroschik [Mon, 24 Jun 2013 14:33:02 +0000 (16:33 +0200)]
[BUGFIX] Fix fileinfo property mapping in ResourceStorage::setFileContents

Fixes the handling of the mismatch between the file info property
"mimetype" and the file object property "mime_type" by using the
exposed API methods.

Fixes: #49386
Releases: 6.2, 6.1, 6.0
Change-Id: If948de2a8bead340ae97097b3e4e391a27296362
Reviewed-on: https://review.typo3.org/21634
Reviewed-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[FEATURE] FAL missing files report 43/23143/8
Frans Saris [Fri, 16 Aug 2013 20:11:59 +0000 (22:11 +0200)]
[FEATURE] FAL missing files report

Adds a report about files flagged as missing.

Resolves: #51097
Releases: 6.2
Change-Id: I95f55fe9f0da9247e6960663dd315e82e18cc2b6
Reviewed-on: https://review.typo3.org/23143
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Fix missing translation in ext:reports 11/23711/2
Wouter Wolters [Mon, 9 Sep 2013 20:16:44 +0000 (22:16 +0200)]
[BUGFIX] Fix missing translation in ext:reports

Fix missing translation for ext:sv in ext:reports.
This was not trasfered to the new location for
the locallang.xlf file.

Change-Id: I594d9c89afbc42c5b6447fc2306a88d3c027b40e
Resolves: #51873
Releases: 6.2
Reviewed-on: https://review.typo3.org/23711
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Extbase scheduler task serialization 34/23634/3
arjenhoekema [Thu, 5 Sep 2013 07:49:11 +0000 (09:49 +0200)]
[BUGFIX] Extbase scheduler task serialization

When using Command Controllers as scheduled tasks the Extbase
Scheduled Task is serialized. Some singleton properties like
'objectManager', 'commandManager' and 'taskExecutor' are serialized
leading to duplicates of this objects.

Added magic "__sleep" and "__wakeup" methods destructing and
re-constructing the above objects.

Resolves: #50723
Releases: 6.2, 6.1, 6.0
Change-Id: I0a84487a1d8885f75dd4b4eaf004bb0dc93645c2
Reviewed-on: https://review.typo3.org/23634
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Cleanup 20/23620/4
Wouter Wolters [Wed, 4 Sep 2013 17:45:48 +0000 (19:45 +0200)]
[TASK] Cleanup

Replace \' with " in exceptions

Add missing PHP closing tag in StoragePermissionsAspect

Eestructure a select query in the
BackendUserAuthentication class.

Change-Id: Id161c761288be93b8f43a2f855254ac954c32d5b
Resolves: #51744
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23620
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Replace double quotes in exceptions 19/23619/2
Wouter Wolters [Wed, 4 Sep 2013 17:34:48 +0000 (19:34 +0200)]
[TASK] Replace double quotes in exceptions

Replace double quotes in exceptions to single quotes

Change-Id: I1a98d783d34eaf4f131b14ab27098c6a4759c9a0
Resolves: #51743
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23619
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Ignore userTSConfig if not set in getModTSconfig() 01/23701/2
Helmut Hummel [Mon, 9 Sep 2013 18:06:17 +0000 (20:06 +0200)]
[BUGFIX] Ignore userTSConfig if not set in getModTSconfig()

It can happen that settings that are not defined in
userTSConfig can overwrite pageTSConfig settings
with a null value because of the change in #51007

This case is now checked so that in this case
the original pageTSConfig value is preserved.

Resolves: #51871
Releases: 6.0, 6.1, 6.2
Change-Id: I3fa356a1e5aa20716a6bc83f7c76b8b755fc0bbf
Reviewed-on: https://review.typo3.org/23701
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Do not add trailing slashes to files 96/23696/2
Helmut Hummel [Mon, 9 Sep 2013 15:13:09 +0000 (17:13 +0200)]
[BUGFIX] Do not add trailing slashes to files

In the security fix #50883 a canonicalize method
for folders has been used where items could
either be files or folders.

This added a trailing slash to files which triggered
a basedir PHP warning if basedir is configured
in PHP.

Use the canonicalize method for file paths instead
to fix this issue.

Resolves: #51761
Releases: 6.0, 6.1, 6.2
Change-Id: I9ef4b6a90ca257ad0104115bd7d48c4de68f135f
Reviewed-on: https://review.typo3.org/23696
Reviewed-by: Simon Schick
Tested-by: Simon Schick
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[FEATURE] Show upload form for extensions in Get Extensions section 39/23639/3
Ingo Pfennigstorf [Thu, 5 Sep 2013 13:36:22 +0000 (15:36 +0200)]
[FEATURE] Show upload form for extensions in Get Extensions section

This patch adds the upload form to the "Get Extensions" section in the
ExtensionManager.

Change-Id: Id8e698ba0d1c2cc1dddec61bba902d4913e1b01c
Resolves: #51776
Releases: 6.2
Reviewed-on: https://review.typo3.org/23639
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[FEATURE] Enhance youtube id getting 16/23616/4
Steffen Ritter [Wed, 4 Sep 2013 11:23:59 +0000 (13:23 +0200)]
[FEATURE] Enhance youtube id getting

The preg_match to fetch the video id from an url do cover only a few
variation. The enhancement covers a lot more possibilities

Releases: 6.2
Fixes: #51728
Change-Id: Ie9d0b3b5dbfff4e129d37fcf351d1d8c5fcdfc98
Reviewed-on: https://review.typo3.org/23616
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Fix viewObjectNamePattern regression in Extbase 68/23668/2
Alexander Schnitzler [Sat, 7 Sep 2013 10:19:14 +0000 (12:19 +0200)]
[BUGFIX] Fix viewObjectNamePattern regression in Extbase

http://forge.typo3.org/issues/47609 introduced an Extbase
regression by changing the behaviour of viewObjectNamePattern
in the ActionController without deprecating it first.

This patch fixes this regression but keeps the wanted behaviour
by resetting the value of viewObjectNamePattern and introducing
a namespacedViewObjectNamePattern with the namespaced pattern.

Resolves: #51758
Releases: 6.2, 6.1, 6.0
Change-Id: Ie32b178e1799c396e969fd48f81f9fe6243f6e70
Reviewed-on: https://review.typo3.org/23668
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Filename not displayed in selector (file_reference) 58/23058/5
Martin Borer [Thu, 5 Sep 2013 21:29:49 +0000 (23:29 +0200)]
[BUGFIX] Filename not displayed in selector (file_reference)

The selector values in BE-fields with type group->file_reference are
empty. The filename should be displayed at this place.

Resolves: #47414
Releases: 6.2, 6.1, 6.0
Change-Id: I9fa237d2cd14ff0e9b347736090bd2171eb8a747
Reviewed-on: https://review.typo3.org/23058
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Check whether data was successfully imported in the functional test 40/23640/2
Tymoteusz Motylewski [Thu, 5 Sep 2013 15:17:35 +0000 (17:17 +0200)]
[TASK] Check whether data was successfully imported in the functional test

Exception is thrown when fixture data can not be loaded into database.

Resolves: #51783
Releases: 6.2
Change-Id: If23657555940cb98954e0ec72ee7d8be53bea1b4
Reviewed-on: https://review.typo3.org/23640
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[BUGFIX] Follow-up to IRRE override strategy 26/23526/4
Steffen Ritter [Sun, 1 Sep 2013 07:39:16 +0000 (09:39 +0200)]
[BUGFIX] Follow-up to IRRE override strategy

In #49685 a more usable behavior of the override strategy
has been introduced for FAL usages. The new output from
TCEforms (FormEngine) lacks proper escaping of JavaScript
and HTML-Code.

This followup adds proper encoding and makes the
newly introduced isNew() method more robust.

Backports of the original patch will have to include
this patch-set directly.

Resolves: #51818
Related: #49685
Releases: 6.2
Change-Id: I2914b4606de4bee0f93861a2de0574362c98d166
Reviewed-on: https://review.typo3.org/23526
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Disable caching for ADMCMD_view parameter 58/23558/2
Philipp Kitzberger [Tue, 3 Sep 2013 14:11:31 +0000 (16:11 +0200)]
[BUGFIX] Disable caching for ADMCMD_view parameter

This prevents that previewing a page leads to an entry for this page
in the TYPO3 cache table because contents on this page might be set
hidden.

Resolves: #51682
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I154d790454bf6bf0215b83e493919107a6c5bd93
Reviewed-on: https://review.typo3.org/23558
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Enable ProcessedFiles to do file exists 60/23660/6
Helmut Hummel [Fri, 6 Sep 2013 10:53:15 +0000 (12:53 +0200)]
[BUGFIX] Enable ProcessedFiles to do file exists

Make storage 0 folder readable, browsable and writable
to mitigate the problems that arise with non
readable processing directories.

Also allow file exists in general if the
identifier in subject is in processing folder.

Resolves: #51808
Releases: 6.0, 6.1, 6.2
Change-Id: I1959d7911d955592db1771d608e8fafcc26c45e9
Reviewed-on: https://review.typo3.org/23660
Reviewed-by: Horst-Dietrich Frank
Tested-by: Horst-Dietrich Frank
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jakob Hombsch
Tested-by: Jakob Hombsch
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Suggest wizard broken when used in a repeating flexform element 90/20990/7
Gabe Blair [Thu, 23 May 2013 00:03:10 +0000 (17:03 -0700)]
[BUGFIX] Suggest wizard broken when used in a repeating flexform element

Get correct fieldConfig when in repeating flexform. Adjust
JavaScript a bit to make this work.

Resolves: #48474
Releases: 6.2, 6.1, 6.0
Change-Id: I7c8a5ecfc2f1d7cfb10ca86a40a3429d3a60ee1f
Reviewed-on: https://review.typo3.org/20990
Reviewed-by: Zach Davis
Tested-by: Zach Davis
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Replace old images by sprite 46/23546/5
Krzyszrtof Adamczyk [Mon, 2 Sep 2013 19:38:35 +0000 (21:38 +0200)]
[BUGFIX] Replace old images by sprite

Adding new images to sprite

Resolves: #50573
Releases: 6.2
Change-Id: I586c206bc84dd44230a6b56ea6e9deaf1d63849f
Reviewed-on: https://review.typo3.org/23546
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Piotr Molewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Recreate processig folder without permission checks 33/23633/6
Helmut Hummel [Thu, 5 Sep 2013 07:45:13 +0000 (09:45 +0200)]
[BUGFIX] Recreate processig folder without permission checks

When fetching the processing folder and it does not
exist, it is created on the fly. This should be done
without checking permissions. However by making
storage 0 not browsable, permissions will be checked
when fetching subfolders.

Instead we now fetch the folder objects directly
from the driver, where no permission checks are done.

Resolves: #51747
Releases: 6.0, 6.1, 6.2
Change-Id: I1a4c3b183323151c436969a478c669adb3856476
Reviewed-on: https://review.typo3.org/23633
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Do not register storage factory slot during install 21/23621/3
Helmut Hummel [Wed, 4 Sep 2013 17:55:56 +0000 (19:55 +0200)]
[BUGFIX] Do not register storage factory slot during install

In install tool context TYPO3_MODE is set to BE
but there is no backend user initialized.
Because of that the storage permission aspect
fails as it requires a valid backend user object.

Do not register the slot when in install tool context.

Releases: 6.0, 6.1, 6.2
Resolves: #51733
Change-Id: I2da95ccd357b730b97bcf99bef21b18c04469274
Reviewed-on: https://review.typo3.org/23621
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] mounts of same storage had same subfolder count in Filelist 81/20981/5
Simon Schick [Wed, 22 May 2013 17:42:14 +0000 (19:42 +0200)]
[BUGFIX] mounts of same storage had same subfolder count in Filelist

When you opened the filelist module as user who just was allowed to see
a bunch of filemounts, the filemounts had either all or none the expand-
icon, based on the first file-mount of this storage the user has access
to.

Resolves: #48467
Releases: 6.2, 6.1, 6.0
Change-Id: I1e6a29e351a643f52c0f7a42fde38c9d9b2fc5cb
Reviewed-on: https://review.typo3.org/20981
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[SECURITY] Prohibit accessing storage 0 from backend UI 08/23608/2
Steffen Ritter [Wed, 4 Sep 2013 11:23:59 +0000 (13:23 +0200)]
[SECURITY] Prohibit accessing storage 0 from backend UI

Manually accessing backend entry-points regarding files passing
an identifier with storage 0 may allow unfiltered access for read,
write, rename, create and delete actions.

The user interface must never deal with storage 0. Therefore
implement checks for storage 0 as protection.

Change-Id: Ia387dfac3057760800171163ff91cd9f55cab4b5
Releases: 6.2, 6.1, 6.0
Fixes: #50886
Security-Commit: b813a875ad76aa7860b76602eb1f32dcfc9fadcd
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23608
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] Identifiers may refer to resources outside the storage 07/23607/2
Steffen Ritter [Wed, 4 Sep 2013 11:23:51 +0000 (13:23 +0200)]
[SECURITY] Identifiers may refer to resources outside the storage

The Driver needs to canonicalize all incoming identifiers at first,
and than check for their validity on every action performed.
If a canonicalized path resided inside a storage it does not contain
any ../ anymore.
An exception is thrown in that case.

Change-Id: I6114be2a517bb44753f92bea1b3b7dfdd42a2f1f
Releases: 6.2, 6.1, 6.0
Fixes: #50883
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23607
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] Deny arbitrary code execution possibility for editors 98/23598/2
Helmut Hummel [Wed, 4 Sep 2013 11:14:17 +0000 (13:14 +0200)]
[SECURITY] Deny arbitrary code execution possibility for editors

Because the filename is sanitized in the driver
after the check for denied file extensions is
performed, it was still possible to rename files
with denied file extensions.

We now perform the file extension check
on the final filename which is going to be used
by the driver.

This change makes the sanitizing method public
and introduces a basic implementation in
AbstractDriver to not break existing driver
implementations.

Fixes: #51495
Releases: 6.2, 6.1, 6.0
Change-Id: I2c055b7b070a5e13c2172d1f20fdcd83ee597e08
Security-Commit: de60d4ef37fc582e6349d5fa8ed13ec30d4892ff
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23598
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] Refactor and fix FAL user permission handling 97/23597/2
Helmut Hummel [Wed, 4 Sep 2013 11:14:05 +0000 (13:14 +0200)]
[SECURITY] Refactor and fix FAL user permission handling

* User permissions are only applied to storage objects
  that are attached to a member variable of
  BackendUserAuthentication. This is error prone
  and leads to insufficient (no) checks if the code
  fetches a storage directly from the factory
  (like edit document controller does)
  Instead, apply the permissions by using a signal
  in StorageFactory directly after the storage object
  is built.

* Refactor the mount point handling, especially the
  user and group home directories, which was completely
  broken after the introduction of FAL. File mounts
  are now also applied to the storage on creation.

* Make fallback storage 0 read only and not browsable.

Fixes: #51327
Releases: 6.2, 6.1, 6.0
Change-Id: If1fa18486cf051a7f4489e36691d42786386df63
Security-Commit: 936dbaf5d16acd36b668dcf033eb343fc5e2f7bf
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23597
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] Add possibility to en-/disable file permission checks 96/23596/2
Helmut Hummel [Wed, 4 Sep 2013 11:13:56 +0000 (13:13 +0200)]
[SECURITY] Add possibility to en-/disable file permission checks

For admins and for front end request, we must be able
to deactivate permission checks completely, while
it must be possible to restrict backend users
to not have any file permissions thus, not be able to
see/change any file.

Fixes: #51326
Releases: 6.2, 6.1, 6.0

Change-Id: I0b2ba16562d412e4a3bb523a54f7de317ea25c25
Security-Commit: eceac26733d6dff1826b149494532fb321274611
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23596
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[SECURITY] Check permissions in all actions of ResourceStorage 95/23595/2
Steffen Ritter [Wed, 4 Sep 2013 11:13:48 +0000 (13:13 +0200)]
[SECURITY] Check permissions in all actions of ResourceStorage

The ResourceStorage omits checks for the configured user and
group permissions within the actions on that Storage.

This patch refines some naming within the security methods
as well as adding security checks to every method.

PHP file extensions are now also removed from the
text file extension list.

Releases: 6.2, 6.1, 6.0
Fixes: #51079
Change-Id: I95a6d89da7eb2b6ea52afea1c49b1df8acb00707
Security-Commit: f5d926ec7a99098ad42117cf2e0b3b67dae057a4
Security-Bulletin: TYPO3-CORE-SA-2013-003
Reviewed-on: https://review.typo3.org/23595
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[FEATURE] CLI command to install and uninstall extensions by key 35/23535/4
Claus Due [Sun, 1 Sep 2013 21:26:28 +0000 (23:26 +0200)]
[FEATURE] CLI command to install and uninstall extensions by key

This change adds a CommandContoller for EXT:extensionmanager;
this new ComandController contains two actions (install, uninstall)
which is then handled by the Utility which contains the actual logic.

Usage example: ./typo3/cli_dispatch.phpsh extbase extension:install [key]

Resolves: #51629
Releases: 6.2
Change-Id: I3561a427f4eff4c5041326f706ed8c77bbbbe9be
Reviewed-on: https://review.typo3.org/23535
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Extend Share font character set 82/23482/4
Jigal van Hemert [Fri, 30 Aug 2013 01:04:43 +0000 (03:04 +0200)]
[BUGFIX] Extend Share font character set

The four variations of the Share font contain now over 550 glyphs.
The bold-italic variation is also added to complete the font family.

Change-Id: I04578cc7da74319662428e688e8152403dfc04b1
Resolves: #49996
Releases: 6.2
Reviewed-on: https://review.typo3.org/23482
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[FEATURE] Add "Hide in menus" checkbox in crpages wizard 31/23531/2
eric.chavaillaz [Sun, 1 Sep 2013 13:52:21 +0000 (15:52 +0200)]
[FEATURE] Add "Hide in menus" checkbox in crpages wizard

Add a checkbox to directly hide pages in the crpages wizard
of the "functions" module.

Resolves: #51017
Releases: 6.2
Change-Id: Iff6abfe862bd0a0f0e2e8ff3064c4a4f6ea001d9
Reviewed-on: https://review.typo3.org/23531
Reviewed-by: Tomita Militaru
Tested-by: Tomita Militaru
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] excludeFromUpdates flag ignored 98/23098/5
Francois Suter [Wed, 14 Aug 2013 11:51:22 +0000 (13:51 +0200)]
[BUGFIX] excludeFromUpdates flag ignored

Since the 6.0 Extension Manager, the "excludeFromUpdates" state
is ignored. It should be checked for and the update button in the
list view hidden in such a case.

Resolves: #51018
Releases: 6.0, 6.1, 6.2
Change-Id: I734331d1b85728dc86732f66ad495a9f83cd0aca
Reviewed-on: https://review.typo3.org/23098
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Faulty check for missing SMTP port 04/23504/5
Tomita Militaru [Sat, 31 Aug 2013 07:56:41 +0000 (10:56 +0300)]
[BUGFIX] Faulty check for missing SMTP port

Check also for null port to avoid a fatal error.

Resolves: #31998
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ibf45b3c0783a70e5afba33f90d1d8e05f76834cf
Reviewed-on: https://review.typo3.org/23504
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Backend Layout Grid Wizard not fully visible in Mac Firefox 22 83/23483/2
Roland Schenke [Fri, 30 Aug 2013 08:30:16 +0000 (10:30 +0200)]
[BUGFIX] Backend Layout Grid Wizard not fully visible in Mac Firefox 22

Under Firefox the outer table's height and width of the backend layout
wizard is set to 100%. Since there is content before the table, this
leads to the table being cut of, as there are no scrollbars. According
to the suggestion of Philipp Gampe the table's height and width are
changed to 90%.

Resolves: #50424
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I589fdfd8de0a8d6ebb4b3ee4fd2a173341116016
Reviewed-on: https://review.typo3.org/23483
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[TASK] Remove old class files in ext:rsaauth 01/23501/3
Wouter Wolters [Fri, 30 Aug 2013 17:46:04 +0000 (19:46 +0200)]
[TASK] Remove old class files in ext:rsaauth

Remove old class files in ext:rsaauth

Change-Id: I2bb437295adcccf5475e8c0f65b5bcd9cea17415
Resolves: #51596
Releases: 6.2
Reviewed-on: https://review.typo3.org/23501
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[TASK] Remove old class files in ext:taskcenter 99/23499/2
Wouter Wolters [Fri, 30 Aug 2013 17:24:08 +0000 (19:24 +0200)]
[TASK] Remove old class files in ext:taskcenter

Remove old class files in ext:taskcenter

Change-Id: Ia998f65eb9c4b4e9b0abe1d5d63b145f36335434
Resolves: #51594
Releases: 6.2
Reviewed-on: https://review.typo3.org/23499
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove old class files in ext:sys_action 00/23500/2
Wouter Wolters [Fri, 30 Aug 2013 17:34:20 +0000 (19:34 +0200)]
[TASK] Remove old class files in ext:sys_action

Remove old class files in ext:sys_action

Change-Id: I89941f8ace57e1b5470cc3038ffcc583a84eb1b4
Resolves: #51595
Releases: 6.2
Reviewed-on: https://review.typo3.org/23500
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove old class files in ext:perm 02/23502/2
Wouter Wolters [Fri, 30 Aug 2013 18:00:22 +0000 (20:00 +0200)]
[TASK] Remove old class files in ext:perm

Remove old class files in ext:perm

Change-Id: I8dc580ce07a3489a27ed92f427b504e9959af2ba
Resolves: #51597
Releases: 6.2
Reviewed-on: https://review.typo3.org/23502
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove old class files in ext:extensionmanager 03/23503/2
Wouter Wolters [Fri, 30 Aug 2013 18:54:35 +0000 (20:54 +0200)]
[TASK] Remove old class files in ext:extensionmanager

Remove old class files in ext:extensionmanager

Change-Id: I2c5589b0feb37b8608eae6241e0f6c35d61e9a38
Resolves: #51599
Releases: 6.2
Reviewed-on: https://review.typo3.org/23503
Reviewed-by: Oliver Klee
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup ext:sv 81/23481/3
Wouter Wolters [Thu, 29 Aug 2013 22:20:13 +0000 (00:20 +0200)]
[TASK] Cleanup ext:sv

* Remove old class files
* Move image and language files to ExtBase structure
* Delete unused CSS file

Change-Id: Icbf13d62397f0f5a1eb2bcccd76e9b81541d27b1
Resolves: #51593
Releases: 6.2
Reviewed-on: https://review.typo3.org/23481
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Incomplete mocking in ext:frontend getImgResourceHook test 87/23487/3
Christian Kuhn [Fri, 30 Aug 2013 12:23:27 +0000 (14:23 +0200)]
[BUGFIX] Incomplete mocking in ext:frontend getImgResourceHook test

A global variable is reset to not call a sub section of the method
under test that may trigger errors.

Change-Id: If486523f231c7463804ac03a663834a820cdd3f1
Releases: 6.2
Resolves: #51581
Reviewed-on: https://review.typo3.org/23487
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Install Tool: Warning: touch() Utime failed: Permission denied 77/23477/3
Ernesto Baschny [Thu, 29 Aug 2013 17:18:29 +0000 (19:18 +0200)]
[BUGFIX] Install Tool: Warning: touch() Utime failed: Permission denied

Despite getting rid of this warning, extending the lifetime of this file
gets more robust by a second method, which is recreating it (which should
be possible even if the file is not owned by the PHP process).

Resolves: #51542
Releases: 6.2
Change-Id: Icb7805ee1f6a08654c3f11eb317a2ad3cadbad76
Reviewed-on: https://review.typo3.org/23477
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Sprite manager cache improvement 78/23478/3
Christian Kuhn [Thu, 29 Aug 2013 19:40:15 +0000 (21:40 +0200)]
[BUGFIX] Sprite manager cache improvement

The sprite manager cache entry is created and then required
directly again. This may lead to runtime issues if the file
is required already before it is fully written.
The patch optimizes that by setting the runtime information
directly from the given data.

Change-Id: I3f6250d8513dad32e266538a075abc8e3daeb68c
Resolves: #51544
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23478
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Add distribution management to extension manager 76/23476/4
Susanne Moog [Thu, 29 Aug 2013 15:56:44 +0000 (17:56 +0200)]
[FEATURE] Add distribution management to extension manager

To install distribution like the introduction or government
package, the extension manager needs a distribution management.

The distribution management consists of a controller that shows
all available distributions and additions to several actions.
The controller lists the packages to be installed. After
click on installing the distribution extension is downloaded,
all dependencies get resolved via the existing dependency
handling and the user is redirected to the configuration. Upon
saving the configuration the user is redirected to a package
welcome side from where he can jump directly to Web>View and
Web>page.

Resolves: #51537
Releases: 6.2
Change-Id: I4aeecc2d2c2d44bdc138bd502d1b2317d33325fd
Reviewed-on: https://review.typo3.org/23476
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Make use of "use"-statement for BackendUtility 82/23182/9
Stefan Neufeind [Sun, 18 Aug 2013 13:34:04 +0000 (15:34 +0200)]
[TASK] Make use of "use"-statement for BackendUtility

Change-Id: I5d631cf408758e89c69b129bb414d1ee14289bdd
Resolves: #51158
Releases: 6.2
Reviewed-on: https://review.typo3.org/23182
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] header element is rendered in lib.stdheader in all HTML5 cases 49/20149/3
Patrick Broens [Thu, 25 Apr 2013 10:50:40 +0000 (12:50 +0200)]
[BUGFIX] header element is rendered in lib.stdheader in all HTML5 cases

According to the HTML5 specs the header element should be used for
grouping elements. Currently the header element is used if there is any
content in lib.stdheader, for instance a single hx.

This patch fixes this by wrapping lib.stdheader with the header element
only when the date is added to the header. Otherwise it will use the
default div wrapping.

Change-Id: I3e1335e1b1d64962a8488b8177d72eb1126e89dd
Fixes: #47575
Releases: 6.2
Reviewed-on: https://review.typo3.org/20149
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Skip tests that rely on internet connection 45/23445/5
Anja Leichsenring [Thu, 29 Aug 2013 09:54:36 +0000 (11:54 +0200)]
[TASK] Skip tests that rely on internet connection

Some tests in GeneralUtilityTest rely on a working internet
connection and fail if offline. Skip those tests if no needed.

Change-Id: Ia5e828cee6a834b971ad8d9c7da0598867a275f8
Resolves: #51496
Releases: 6.2
Reviewed-on: https://review.typo3.org/23445
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] TCA 'group' selectedListStyle with 'width' breaking layout 91/23391/3
Ernesto Baschny [Tue, 27 Aug 2013 22:47:50 +0000 (00:47 +0200)]
[BUGFIX] TCA 'group' selectedListStyle with 'width' breaking layout

The problem came from a row of icons which was always rendered below
the select list with a hardcoded width of "250px", regardless if there
was content or not. Solution is not to render this icon row if there are
no icons, thus allowing the select list to be reduced in width.

Releases: 6.2, 6.1, 6.0
Resolves: #50707
Change-Id: I23520c1c547de1155091e38c69013a18fed9e559
Reviewed-on: https://review.typo3.org/23391
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Database integrity check fatal error 24/23424/4
Stefan Fürst [Wed, 28 Aug 2013 14:08:10 +0000 (16:08 +0200)]
[BUGFIX] Database integrity check fatal error

If a file or directory below uploads/ is not readable by the
executing user, the integrity check system in db check module
menu may fatal. This is sanatized by the patch.

Resolves: #51460
Releases: 6.2, 6.1, 6.0
Change-Id: Ide3401c014aa7bec33585083f81f30c00100da09
Reviewed-on: https://review.typo3.org/23424
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Add missing categories menu utility 66/23466/2
Francois Suter [Thu, 29 Aug 2013 13:38:09 +0000 (15:38 +0200)]
[BUGFIX] Add missing categories menu utility

When the feature introducing categories-based page menu was
introduced, a utility class was eventually forgotten. This
patch restores it.

Resolves #51524
Releases: 6.2

Change-Id: I447b22a80252eb8c7ede80daa11cfc7db5144479
Reviewed-on: https://review.typo3.org/23466
Reviewed-by: Francois Suter
Tested-by: Francois Suter
6 years ago[CLEANUP] Adjust usage of ContentObjectRenderer->getTreeList() 92/23092/10
Anja Leichsenring [Wed, 14 Aug 2013 09:19:44 +0000 (11:19 +0200)]
[CLEANUP] Adjust usage of ContentObjectRenderer->getTreeList()

In ContentObjectRenderer->getQuery() the pid where clause is build
using getTreeList() to fetch recursive pids. But for the inclusion
of the uppermost pid, string concatenation is used.
The method getTreeList() offers the option to include the uppermost
pid into the returned result by passing it as a negative value. Method
getQuery() should use this opportunity instead of doing its own magic.

Additionally some cleanup is done for getTreeList, optimizing the
returned string, and unittests were added.

Resolves: #51067
Resolves: #51503
Releases: 6.2
Change-Id: Ie72103ca66d847cb0eb0f3ef5e33a1896d86de5b
Reviewed-on: https://review.typo3.org/23092
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn