Packages/TYPO3.CMS.git
10 months ago[TASK] Update bamboo to gerrit notification url 70/58970/3
Christian Kuhn [Wed, 28 Nov 2018 15:21:23 +0000 (16:21 +0100)]
[TASK] Update bamboo to gerrit notification url

Resolves: #87026
Releases: master, 8.7, 7.6
Change-Id: Idfbf4bbf0bab8a6e4bedc37e92903ed2c85af494
Reviewed-on: https://review.typo3.org/58970
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 months ago[BUGFIX] Allow `<s>` tag in RTE processing 57/58957/2
Andreas Fernandez [Tue, 27 Nov 2018 09:40:32 +0000 (10:40 +0100)]
[BUGFIX] Allow `<s>` tag in RTE processing

`lib.parseFunc` is now capable of handling the `<s>` tag by adding it to
`allowTags`. The list already contains `<strike>`, but this is a
non-valid tag in HTML5. For compatibility reasons, both tags exist now.

Resolves: #87012
Releases: master, 8.7
Change-Id: I113b7721c9483735dff0875f8c7bffb276f09e5b
Reviewed-on: https://review.typo3.org/58957
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
10 months ago[BUGFIX] Only fetch default language page for tree lists 67/58967/4
Benni Mack [Wed, 28 Nov 2018 07:03:05 +0000 (08:03 +0100)]
[BUGFIX] Only fetch default language page for tree lists

Due to the removal of pages_language_overlay the queries
for fetching trees have to work as before - mainly because the
concept of the "pid" (= storagePid) works the same - records on a
page have the pid of the default language, not of any translation.

Therefore, the used queries have to be built to check for
sys_language_uid=0.

Resolves: #87020
Related: #86961
Releases: master
Change-Id: Ie7740b6a32618a213d569362a58b9f8e5ed7824d
Reviewed-on: https://review.typo3.org/58967
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
10 months ago[BUGFIX] Correct label for aspect ratio 1.91:1 61/58961/2
Josef Glatz [Tue, 27 Nov 2018 13:33:13 +0000 (14:33 +0100)]
[BUGFIX] Correct label for aspect ratio 1.91:1

Releases: master
Resolves: #87017
Change-Id: I6af6cceab344cd54bace6547505e555ece81efe3
Reviewed-on: https://review.typo3.org/58961
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
10 months ago[BUGFIX] Drop GROUP BY clause in Info > PageTS Config 62/58962/5
Andreas Fernandez [Tue, 27 Nov 2018 15:18:22 +0000 (16:18 +0100)]
[BUGFIX] Drop GROUP BY clause in Info > PageTS Config

The GROUP BY clause used in InfoPageTypoScriptConfigController's
`getOverviewOfPagesUsingTSConfig()` is dropped, as grouping by
a unique value doesn't make any sense.

Resolves: #87019
Related: #76484
Releases: master, 8.7
Change-Id: I0054064fb6f0bba9b65737bf323db364377bb4e6
Reviewed-on: https://review.typo3.org/58962
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[TASK] Log a warning if fluid-based preview template couldn't be rendered 60/58960/6
Josef Glatz [Tue, 27 Nov 2018 12:24:32 +0000 (13:24 +0100)]
[TASK] Log a warning if fluid-based preview template couldn't be rendered

A warning is logged if the fluid-based preview template for a
content element could not be rendered.

The logged warning includes
- the UID of the content element
- the resulting path to the template file
- and the exception message

Resolves: #87015
Releases: master, 8.7
Change-Id: I2cd100a5140a07845145b16259b7cbe3e5eed852
Reviewed-on: https://review.typo3.org/58960
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
10 months ago[BUGFIX] Enlarge scheduler object DB field 53/58953/2
Benni Mack [Mon, 26 Nov 2018 14:51:45 +0000 (15:51 +0100)]
[BUGFIX] Enlarge scheduler object DB field

The serialized PHP object is stored within the database field
"serialized_task_object". When serializing this could lead to several
issues.

One particular issue is that the object has lots of data or dependencies,
it cannot be stored at all in this database field.

Although we know that this implementation detail of scheduler is a rather
bad idea, we can only fix this by enlarging the field from "blob" to
"mediumblob" for now.

Resolves: #87006
Releases: master, 8.7
Change-Id: I2b335f258fe18b494033bde28eff76f2e67d34bb
Reviewed-on: https://review.typo3.org/58953
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months agoRevert "[BUGFIX] Improve Performance for Inline Elements" 36/58936/3
Oliver Hader [Fri, 23 Nov 2018 12:38:31 +0000 (13:38 +0100)]
Revert "[BUGFIX] Improve Performance for Inline Elements"

This reverts commit be62d64d6b17b51b997cd88c5da7805587fc93db.

The fix introduced breaking behavior on for additional processings like
`label_userFunc` based on the expanded/collapsed state (which is stored
in the users `uc` blob).

Change-Id: I12a31391fd3f6e50946d0f98d21939a501a95eee
Releases: master
Related: #82100
Reviewed-on: https://review.typo3.org/58936
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Fix full example in `Feature-86826-RecursiveRecordSitemap` 29/58929/2
Andreas Fernandez [Wed, 21 Nov 2018 20:21:41 +0000 (21:21 +0100)]
[BUGFIX] Fix full example in `Feature-86826-RecursiveRecordSitemap`

Some missing TypoScript is added to the documentation file
`Feature-86826-RecursiveRecordSitemap.rst` to get an additional,
functional sitemap.

Resolves: #86971
Releases: master
Change-Id: I48711f176fdb7345d02946f1bc666a0c751a54cc
Reviewed-on: https://review.typo3.org/58929
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
10 months ago[BUGFIX] User Setup: Check if languages have been configured 27/58927/3
Andreas Fernandez [Wed, 21 Nov 2018 19:11:29 +0000 (20:11 +0100)]
[BUGFIX] User Setup: Check if languages have been configured

On a fresh installation of TYPO3, no system languages are configured
which breaks the "User Setup" module. An additional check for
`EXTCONF/lang/availableLanguages` is added to fix the issue.

Resolves: #86970
Related: #86796
Releases: master
Change-Id: I5ac39ce2b3a7705d29844ea1805a304af58d839f
Reviewed-on: https://review.typo3.org/58927
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Fix outdated link in docs 16/58916/3
Philipp Kitzberger [Tue, 20 Nov 2018 09:37:35 +0000 (10:37 +0100)]
[BUGFIX] Fix outdated link in docs

That linked resource is just not available under that URL anymore.

Releases: master, 8.7
Resolves: #86951
Change-Id: I22ca04e00d7ce74f5d3a7f072c27d20bbfd193a2
Reviewed-on: https://review.typo3.org/58916
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
10 months ago[BUGFIX] Remove unused `fieldChangeFunc` in GroupElement 10/58910/2
Andreas Fernandez [Sun, 18 Nov 2018 19:47:01 +0000 (20:47 +0100)]
[BUGFIX] Remove unused `fieldChangeFunc` in GroupElement

The class GroupElement defines a `fieldChangeFunc` which is unused in
this context. Since this never caused an issue, it's assumed to be save
to remove the change handler.

This allows further cleanup in the FormEngine JavaScript land, e.g.
deprecating `setFormValueManipulate()`.

Resolves: #86948
Releases: master
Change-Id: I51f8c0c6bf3cd383ba2e12e29f329ceb979a9799
Reviewed-on: https://review.typo3.org/58910
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Strip tags only from strings in ArrayUtility::stripTagsFromValuesRecursive 00/58900/8
Wolfgang Klinger [Thu, 15 Nov 2018 16:45:15 +0000 (17:45 +0100)]
[BUGFIX] Strip tags only from strings in ArrayUtility::stripTagsFromValuesRecursive

Prevent an implicit type cast to string through strip_tags.
Ignore any scalar values other than string,
but preserve the possibility of an object's __toString conversion.

Resolves: #86938
Releases: master, 8.7
Change-Id: I27cb7834dc9e838f60f0d1bda94ab2c4e4011043
Reviewed-on: https://review.typo3.org/58900
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer<strong style="color:red">x</strong> <georg.ringer@gmail.com>
Tested-by: Georg Ringer<strong style="color:red">x</strong> <georg.ringer@gmail.com>
10 months ago[TASK] Check number of file extensions 07/58907/3
Guido Schmechel [Fri, 16 Nov 2018 21:46:34 +0000 (22:46 +0100)]
[TASK] Check number of file extensions

Show the add media and text form only if at least
one file extension exists.

Resolves: #86925
Releases: master, 8.7
Change-Id: I37c23800f1ddda78b7f248c0de9e970a73976c4a
Reviewed-on: https://review.typo3.org/58907
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[TASK] Add searchFields in TCA for sys_news, sys_action and sys_note 05/58905/5
Wolfgang Klinger [Fri, 16 Nov 2018 17:06:02 +0000 (18:06 +0100)]
[TASK] Add searchFields in TCA for sys_news, sys_action and sys_note

Resolves: #86932
Releases: master, 8.7
Change-Id: Ic699b0af99fb73bfdb91e3dbbb3e6f3e41335b5b
Reviewed-on: https://review.typo3.org/58905
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] CSS selector in extension configuration modal too specific 99/58899/4
Jonas Eberle [Thu, 15 Nov 2018 15:10:44 +0000 (16:10 +0100)]
[BUGFIX] CSS selector in extension configuration modal too specific

The .typo3-install class is not present in the current modal. This
re-introduces the margin above the "save" button.

Resolves: #86893
Releases: master
Change-Id: I4b8c291742636dd19e48fcf259de0ab65f8a1b3b
Reviewed-on: https://review.typo3.org/58899
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Cast file resource pointer in UploadFileReferenceConverter 68/58868/3
Georg Ringer [Wed, 7 Nov 2018 21:39:40 +0000 (22:39 +0100)]
[BUGFIX] Cast file resource pointer in UploadFileReferenceConverter

The return value of the hmac check is a string and must be casted to
an integer as the method using the value requires an integer.

Resolves: #86878
Releases: master, 8.7
Change-Id: Ic6db911c213eb668141ba0c849ff8a627a6f94dc
Reviewed-on: https://review.typo3.org/58868
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[TASK] Explain "recursive" in record sitemap 03/58903/3
Jonas Eberle [Fri, 16 Nov 2018 11:07:20 +0000 (12:07 +0100)]
[TASK] Explain "recursive" in record sitemap

Follow-up commit to provide explanation for parameter `recursive` in:
A recursive configuration makes it a lot easier to provide
a sitemap for all records without touching the configuration
if a new sysfolder is created.

Resolves: #86826
Releases: master
Change-Id: I8c51d6ca066ecae684e4ab5a655c71e2dbe4fc24
Reviewed-on: https://review.typo3.org/58903
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
10 months ago[FEATURE] Support recursive in record sitemap 22/58822/8
Georg Ringer [Thu, 1 Nov 2018 22:03:56 +0000 (23:03 +0100)]
[FEATURE] Support recursive in record sitemap

A recursive configuration makes it a lot easier to provide
a sitemap for all records without touching the configuration
if a new sysfolder is created.

Resolves: #86826
Releases: master
Change-Id: I77d49a8fd45eeb8e5bf32575d6c986f66e9c9c55
Reviewed-on: https://review.typo3.org/58822
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Add RootPage to Slug Candidates 01/58901/3
Achim Fritz [Thu, 15 Nov 2018 18:54:35 +0000 (19:54 +0100)]
[BUGFIX] Add RootPage to Slug Candidates

The slug candidates resolving now takes "/" into account,
allowing to find the root page as well. This way, the PageRouter
applies Route Enhancers to the root page as well,
so segments like "/my-news-plugin/" also applies to
"/".

Resolves: #86939
Releases: master
Change-Id: I56015e1d5bf4a8e9e12c4ebcef8bdc95e1d5c8e2
Reviewed-on: https://review.typo3.org/58901
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Tested-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Select proper records in DBAL workspace restrictions 41/56941/7
Benni Mack [Thu, 15 Nov 2018 10:28:11 +0000 (11:28 +0100)]
[BUGFIX] Select proper records in DBAL workspace restrictions

A new WorkspaceRestriction is added to solve all issues
once and for all.

For now, this restriction is used to only show
records in pagetree without having duplicated.

Resolves: #84985
Releases: master, 8.7
Change-Id: I22d5f276460107802bef3d390e6781434f1c28d3
Reviewed-on: https://review.typo3.org/56941
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Tested-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Remove caches if a site is deleted 96/58896/4
Steffen Dietrich [Wed, 14 Nov 2018 12:23:53 +0000 (13:23 +0100)]
[BUGFIX] Remove caches if a site is deleted

This patch fixes a pseudo-site-error in the backend after a
created site is deleted and the page module is shown.
After deleting the site the cache gets automatically cleared.

Resolves: #85985
Releases: master
Change-Id: I42157fe61a0a624be875d2a777147a657a973d2f
Reviewed-on: https://review.typo3.org/58896
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Tested-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Cast PSR-7 Uri object to string in preview links 97/58897/3
Achim Fritz [Wed, 14 Nov 2018 18:00:38 +0000 (19:00 +0100)]
[BUGFIX] Cast PSR-7 Uri object to string in preview links

When generating the workspace preview links, the Uri
object needs to be case to string.

Resolves: #86928
Releases: master
Change-Id: I4eca3742044ee886923632297d5402467333acd9
Reviewed-on: https://review.typo3.org/58897
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[TASK] Remove obsolete .rst file 94/58894/2
Christian Kuhn [Wed, 14 Nov 2018 10:14:46 +0000 (11:14 +0100)]
[TASK] Remove obsolete .rst file

The .rst file for issue #86881 needs to be removed again,
the patch has been reverted.

Resolves: #86926
Related: #86881
Related: #86891
Change-Id: I2e07887f76bf88b4c7a72efead80bb4866f7fb7c
Reviewed-on: https://review.typo3.org/58894
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Check Tsconfig in page module for value of content element 89/58889/2
Georg Ringer [Tue, 13 Nov 2018 12:46:53 +0000 (13:46 +0100)]
[BUGFIX] Check Tsconfig in page module for value of content element

In case a content element is added with TsConfig its label can't be
loaded from TCA but the TsConfig must be checked.

Resolves: #86909
Releases: master, 8.7
Change-Id: I2de2b73dcd4799a45aece330f377e86bd2bf596f
Reviewed-on: https://review.typo3.org/58889
Reviewed-by: Soren Malling <soren@meteko.dk>
Tested-by: Soren Malling <soren@meteko.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Set proper caching lifetime of meta tags and titles 91/58891/2
Richard Haeser [Tue, 13 Nov 2018 20:54:01 +0000 (21:54 +0100)]
[BUGFIX] Set proper caching lifetime of meta tags and titles

Use the lifetime of the current page for caching the meta tags and titles

Resolves: #86234
Releases: master
Change-Id: I4ec46df3e3557d03bd8ff14fc738740a328fc64c
Reviewed-on: https://review.typo3.org/58891
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
10 months agoRevert "[BUGFIX] Set BackendUserAspect earlier to make it usable in TSConfig" 45/58845/3
Oliver Hader [Mon, 5 Nov 2018 18:02:36 +0000 (19:02 +0100)]
Revert "[BUGFIX] Set BackendUserAspect earlier to make it usable in TSConfig"

This reverts commit 52c391df3d4070d7bb192c724597141111e70b21.

When a backend user has set a workspace, this needs
to happen AFTER the user has been initialized (and
the proper workspace has been set), otherwise all
workspace queries are nailed down to "wsid=-99".

Resolves: #86856
Related: #86229
Releases: master
Change-Id: Iee804f99639e1957421818f7ed2bff134b269244
Reviewed-on: https://review.typo3.org/58845
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
11 months ago[TASK] Move latest rst files to correct directory 77/58877/4
Georg Ringer [Thu, 8 Nov 2018 21:02:18 +0000 (22:02 +0100)]
[TASK] Move latest rst files to correct directory

Resolves: #86891
Releases: master
Change-Id: If9a3d35b4eb08d9f2f08aca4b7a23da4ac91f46f
Reviewed-on: https://review.typo3.org/58877
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months agoRevert "[FEATURE] Support feature toggle in expression language" 78/58878/2
Anja Leichsenring [Fri, 9 Nov 2018 11:14:14 +0000 (13:14 +0200)]
Revert "[FEATURE] Support feature toggle in expression language"

This reverts commit c0d321c2c0f0e4eb8b839a83a787e104183092da.

Reason for revert: this was a feature merged before branching, I apologize.

Change-Id: I36125cac4d56bb0d87f6ba3a76093af6201bee4c
Reviewed-on: https://review.typo3.org/58878
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Only render hreflang tag when multiple languages are available 37/58837/2
Richard Haeser [Sat, 3 Nov 2018 14:21:13 +0000 (15:21 +0100)]
[TASK] Only render hreflang tag when multiple languages are available

Make sure the hreflang tags are only rendered when there is more than 1
language enabled for the current page.

Resolves: #86545
Releases: master
Change-Id: Ib2bbccbc25544a4d162e7cb6da0ffc50a31df2ba
Reviewed-on: https://review.typo3.org/58837
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
11 months ago[TASK] Respect alternative web mounts in suggest wizard 93/57193/4
Alexander Stehlik [Mon, 11 Jun 2018 19:48:17 +0000 (21:48 +0200)]
[TASK] Respect alternative web mounts in suggest wizard

The suggest wizard now respects temporary page tree mount
points and altElementBrowserMountPoints from the TSconfig.

The detection and adjustment of element browser mountpoints
is centralized in the backend user.

Resolves: #64215
Releases: master
Change-Id: Ic8eaf0cd2155051db0f3bed0678087ec72b9fadb
Reviewed-on: https://review.typo3.org/57193
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Correctly create schema diff for renamed fields and indexes 87/58787/5
Helmut Hummel [Mon, 29 Oct 2018 23:30:03 +0000 (00:30 +0100)]
[BUGFIX] Correctly create schema diff for renamed fields and indexes

TYPO3's schema migrator has code to create drop and add fields
statements out of renamed columns detected by doctrine.

This code however is never triggered, when using a MySQL connection
with tableoptions set, because then a new TableDiff object is created,
which does not contain the renamedColumns any more.

This fix tackles the issue in various places:

1. The charset is pulled out as well of the information_schema,
so that it is set in source and target schema objects and
table options stay the same for source and target schema.

2. The newly created table differences objects receive
the detected renamed columns and idexes.

Releases: master
Resolves: #86793
Change-Id: Iee6bc47ccf066cf9ccd7692af34e437e57695144
Reviewed-on: https://review.typo3.org/58787
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Use FlashMessageRendererResolver in ReferenceIndex 65/58865/2
Georg Ringer [Wed, 7 Nov 2018 13:51:47 +0000 (14:51 +0100)]
[BUGFIX] Use FlashMessageRendererResolver in ReferenceIndex

To avoid exceptions while calling the referenceindex:update via CLI the
FlashMessageRendererResolver must be used.

Resolves: #86877
Releases: master
Change-Id: I800454c8f35d753be8cdadf40179f0585ca75259
Reviewed-on: https://review.typo3.org/58865
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Skip language -1 in preview url generation 12/58612/3
Georg Ringer [Thu, 11 Oct 2018 06:49:08 +0000 (08:49 +0200)]
[BUGFIX] Skip language -1 in preview url generation

Resolves: #86623
Releases: master
Change-Id: Ic7e6c8dd5b7232f2ee2e3f84664b25835e782677
Reviewed-on: https://review.typo3.org/58612
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Raphael Graf <r@undefined.ch>
Tested-by: Raphael Graf <r@undefined.ch>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Improve Performance for Inline Elements 19/54519/17
Tymoteusz Motylewski [Mon, 14 May 2018 10:46:14 +0000 (12:46 +0200)]
[BUGFIX] Improve Performance for Inline Elements

Invisible and not translated records will not be retrieved anymore.

Currently every inline element will be translated even if the default
language is requested. This causes a massive performance leak because not only
the current record is loaded, but every other record with the same pid.

Not expanded inline children will be also be ignored.

Resolves: #82100
Releases: master
Change-Id: I3cbe0039f5d15c921d81fc3e634ef38aa06cd18a
Reviewed-on: https://review.typo3.org/54519
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Remove leftovers of "options.uploadFieldsInTopOfEB" 72/58872/4
Georg Ringer [Thu, 8 Nov 2018 12:55:52 +0000 (13:55 +0100)]
[TASK] Remove leftovers of "options.uploadFieldsInTopOfEB"

With #80463 - before v8 LTS - the setting
"options.uploadFieldsInTopOfEB" has been removed from the templates,
no need to check the value inside the PHP code anymore.

Resolves: #86885
Related: #86848
Releases: master, 8.7
Change-Id: I40c333aeba2987a57fe26353f00ac55a74da7878
Reviewed-on: https://review.typo3.org/58872
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Remove double encoding of dataStructureIdentifier 55/58855/5
Stefan Froemken [Tue, 6 Nov 2018 11:18:02 +0000 (12:18 +0100)]
[BUGFIX] Remove double encoding of dataStructureIdentifier

As dataStructureIdentifier of FlexForms will be transferred
as JSON-encoded string, there is no need to call "json_encode"
again on that string.

Resolves: #86864
Releases: master
Change-Id: I813c9297a8dae24ae584a3606831a8fda5642df9
Reviewed-on: https://review.typo3.org/58855
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Send payload of image cropping wizard via POST 85/58785/5
Andreas Fernandez [Mon, 29 Oct 2018 22:04:10 +0000 (23:04 +0100)]
[BUGFIX] Send payload of image cropping wizard via POST

The image cropper wizard configuration can become very large, which
might break the wizard as the configuration is sent via query parameters
and "Request-URI Too Long" might kick in.

The payload is now sent via POST to bypass this issue. As our Modal API
is currently not capable of sending AJAX requests via POST, the logic
regarding the icon spinner is duplicated for the time being.

Resolves: #82225
Releases: master, 8.7
Change-Id: I7106b62fcc09101bc5147277225d1b8e89133d5c
Reviewed-on: https://review.typo3.org/58785
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Detect proper TsConfig for blinding settings in tree provider 71/58871/2
Georg Ringer [Thu, 8 Nov 2018 09:44:38 +0000 (10:44 +0100)]
[BUGFIX] Detect proper TsConfig for blinding settings in tree provider

Due the refactoring with #84993 the tsconfig coulnd't be loaded correctly if
a subarray must be accessed.

Resolves: #86882
Releases: master
Change-Id: Ie4450d77889d260a1d29f728ce3d0216736bb15a
Reviewed-on: https://review.typo3.org/58871
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Fix various issues in Core Updater 40/58840/2
Andreas Fernandez [Sun, 4 Nov 2018 18:58:58 +0000 (19:58 +0100)]
[BUGFIX] Fix various issues in Core Updater

- The click event for the update button is now bound to the modal and not
to the origin document, as this doesn't work in backend context.
- Fix rendering of flash messages
- Render error messages properly
- Fix download path of versions
- Drop unavailable "clear cache" action

Resolves: #86830
Releases: master
Change-Id: I51aa474ad1267df5c6d200c14c8b6cb2c499f20d
Reviewed-on: https://review.typo3.org/58840
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
11 months ago[BUGFIX] Show adminpanel module in safari 62/58862/2
Josef Glatz [Tue, 6 Nov 2018 17:50:23 +0000 (18:50 +0100)]
[BUGFIX] Show adminpanel module in safari

This patch makes the new adminpanel frontend usable
in Apple Safari.

Resolves: #86251
Releases: master
Change-Id: I1d14f8069b873be06ad009ab7862a857be798883
Reviewed-on: https://review.typo3.org/58862
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Marco Pfeiffer <m4pfeiffer@gmail.com>
Tested-by: Marco Pfeiffer <m4pfeiffer@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Use sys_language isocode for SiteLanguage 74/58874/3
Alexander Opitz [Thu, 8 Nov 2018 14:44:36 +0000 (15:44 +0100)]
[BUGFIX] Use sys_language isocode for SiteLanguage

The PseudoSiteFinder transfers the iso code from sys_language
in the correct field for SiteLanguage. Also respect the hidden
field from database as enabled field in SiteLanguage.

Resolves: #86888
Releases: master
Change-Id: I5cf233b3c5d9fc8501e45bd3040263e7a69bb26b
Reviewed-on: https://review.typo3.org/58874
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[FEATURE] Support feature toggle in expression language 69/58869/5
Frank Naegler [Wed, 7 Nov 2018 22:00:23 +0000 (23:00 +0100)]
[FEATURE] Support feature toggle in expression language

Resolves: #86881
Releases: master
Change-Id: Ib9325081b572f22936cc28cbc1f8b977f9c1b0bf
Reviewed-on: https://review.typo3.org/58869
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Ignore provided pages for sitemap menu 52/58852/2
Georg Ringer [Tue, 6 Nov 2018 07:15:02 +0000 (08:15 +0100)]
[BUGFIX] Ignore provided pages for sitemap menu

The sitemap menu doesn't show the pages field and therefore
it must not be used in the MenuProcessor configuration as well.

Resolves: #85693
Releases: master, 8.7

Change-Id: I286054cc58982fa0db4fed0af82d7c065b1700a4
Reviewed-on: https://review.typo3.org/58852
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Include DB queries with free mode records 59/58859/3
Benni Mack [Tue, 6 Nov 2018 15:24:06 +0000 (16:24 +0100)]
[BUGFIX] Include DB queries with free mode records

With the new site handling, the overlayType for fetching
records in the frontend context is always set to
OVERLAYS_ON_WITH_FLOATING, which resolves to
the previous TypoScript settings:
- config.sys_language_overlay = 1
- styles.content.get.select.includeRecordsWithoutDefaultTranslation = 1

However, the place where "includeRecordsWithoutDefaultTranslation"
is evaluated does not check for the actual
Language Aspect of the Context API, which makes
it impossible to fetch records without "l10n_parent"
= (free mode), except for setting this option
explicitly on each TypoScript "select." query.

The patch moves the functionality into a separate method,
which allows to better unit test all options.

Resolves: #86627
Releases: master
Change-Id: I3a9005dcf13ddd26962da0d2ed930929c3f3b288
Reviewed-on: https://review.typo3.org/58859
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Chris Müller <typo3@krue.ml>
Reviewed-by: Chris Müller <typo3@krue.ml>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Remove fluid namespace in sitemap template 66/58866/3
Georg Ringer [Wed, 7 Nov 2018 13:59:13 +0000 (14:59 +0100)]
[TASK] Remove fluid namespace in sitemap template

There is no need to keep the fluid namespace definition in the template.

Resolves: #86873
Releases: master
Change-Id: I3f7a31a68aad5f67b37fd49b4098071c3c88cd4f
Reviewed-on: https://review.typo3.org/58866
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Add reports.html to acceptance tests 56/58856/3
Steffen Dietrich [Tue, 6 Nov 2018 11:45:10 +0000 (12:45 +0100)]
[BUGFIX] Add reports.html to acceptance tests

Add additional option to create reports.html upon
codeception runs on local execution of acceptance tests.

Resolves: #86867
Releases: master
Change-Id: I8f7fae03b430f51d47eb0285cc62171f7807c024
Reviewed-on: https://review.typo3.org/58856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Hide internal prefix "cat:" in tags of upgrade docs 47/58847/4
Georg Ringer [Mon, 5 Nov 2018 19:28:52 +0000 (20:28 +0100)]
[BUGFIX] Hide internal prefix "cat:" in tags of upgrade docs

The prefix "cat:" is used internally and it doesn't make sense to
show it to a regular user. Neither does it provide more output nor is
"cat" a regular word.

Resolves: #86858
Releases: master, 8.7
Change-Id: I8c48819814767c1ef4367c49da9ab3685081dceb
Reviewed-on: https://review.typo3.org/58847
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Use correct value for eventPid in DataHandler 57/58857/2
Benni Mack [Tue, 6 Nov 2018 13:51:44 +0000 (14:51 +0100)]
[BUGFIX] Use correct value for eventPid in DataHandler

When using workspaces and the record properties
should be shown, the wrong field (_ORIG_pid instead of
t3ver_oid) is used. This is introduced by
a cleanup patch of mine 1y ago, where an accidental
null coalescense evaluation is used.

Resolves: #86868
Related: #82769
Releases: master
Change-Id: I2505f103608350f37c6bf769de4368b62ed67d55
Reviewed-on: https://review.typo3.org/58857
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Fix isMissing called on Null error 49/58849/7
Bernhard Sirlinger [Mon, 5 Nov 2018 21:12:40 +0000 (22:12 +0100)]
[BUGFIX] Fix isMissing called on Null error

Add a Null check in FileLinktype->checkLink
function

Resolves: #86857
Releases: master,8.7
Change-Id: I2cc270dd7b8392fa8fd240c6efca3894f0ce3273
Reviewed-on: https://review.typo3.org/58849
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[FEATURE] Improve creation of URL query strings from arrays 79/55079/40
Stefan Neufeind [Mon, 18 Dec 2017 18:46:47 +0000 (19:46 +0100)]
[FEATURE] Improve creation of URL query strings from arrays

Adds a new method HttpUtility::buildQueryString() using
http_build_query() instead of reimplementing the encoding-process like
the old method GeneralUtility::implodeArrayForUrl() did.

As the parameter $rawurlencodeParamName of implodeArrayForUrl() was set
to "false" by default and used in several places without manually
setting it to "true" using that method could lead to potentially unsafe
non-encoded parameter names.

Some unit-tests had wrong URLs with non-encoded braces [...], which were
adapted to be properly escaped as well.

Resolves: #83334
Releases: master
Change-Id: Ifbaad912f0d658671356dc7bdf1579dacff272df
Reviewed-on: https://review.typo3.org/55079
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Force word breaks in callouts 20/58820/6
Andreas Fernandez [Thu, 1 Nov 2018 20:10:52 +0000 (21:10 +0100)]
[BUGFIX] Force word breaks in callouts

The CSS of callouts is adjusted to enforce word breaks to prevent
overlapping the container.

Resolves: #86827
Releases: master
Change-Id: I91be87f22b3f3192f594f028575dfb9f36191b81
Reviewed-on: https://review.typo3.org/58820
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Tested-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Respect DateTimeImmutable in Extbase 88/57388/7
Benni Mack [Wed, 27 Jun 2018 05:44:03 +0000 (07:44 +0200)]
[BUGFIX] Respect DateTimeImmutable in Extbase

The DateTimeConverter and DataMapper of Extbase now checks for
DateTimeInterface, and can thus handle DateTimeImmutable, otherwise
Extbase cannot handle these kinds of formats.

Resolves: #72053
Releases: master
Change-Id: Ic922e715a31e1d02f5f6daa18415e8376788da8b
Reviewed-on: https://review.typo3.org/57388
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months agoRevert "[BUGFIX] Set constraints in `FrontendRestrictionContainer` depending on works... 38/58838/2
Frank Naegler [Sat, 3 Nov 2018 14:51:33 +0000 (16:51 +0200)]
Revert "[BUGFIX] Set constraints in `FrontendRestrictionContainer` depending on workspace context"

This reverts commit c3e7779c61cc567b9a1cbf5fec747748e5059464.

Change-Id: Ic2d68767d463b94ab42814848396b8f019e8cb15
Releases: master
Resolves: #86845
Reverts: #85742
Reviewed-on: https://review.typo3.org/58838
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Raise testing-framework and styleguide 17/58817/8
Christian Kuhn [Thu, 1 Nov 2018 13:36:54 +0000 (14:36 +0100)]
[TASK] Raise testing-framework and styleguide

Acceptance tests of testing-framework have been refactored
a bit to be easier usable by extensions. Core needs some
adaptions to cope with that. styleguide has been
slightly improved and is raised along the way.

composer require --dev typo3/testing-framework ~4.11.1
composer require --dev typo3/cms-styleguide ~9.2.2

Change-Id: Ifc5fbc1192618017e6cd5e80452463eafe527d79
Resolves: #86839
Releases: master
Reviewed-on: https://review.typo3.org/58817
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Show correct ReST file for @validate annotation 27/58827/5
Alexander Schnitzler [Fri, 2 Nov 2018 12:21:35 +0000 (13:21 +0100)]
[BUGFIX] Show correct ReST file for @validate annotation

The extension scanner didn't show the correct ReST file. Instead
of the file for @validate, it has shown the file for @inject.

Also, the file explaining the @validate annotation mentioned the
@inject annotation.

Releases: master
Resolves: #86840
Relates: #83617
Change-Id: I73f35a0fdf32b999b1b95754bd4366ece75f0ea6
Reviewed-on: https://review.typo3.org/58827
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Make `LoginRefresh.submitForm a lambda function 19/58819/2
Andreas Fernandez [Thu, 1 Nov 2018 19:39:14 +0000 (20:39 +0100)]
[BUGFIX] Make `LoginRefresh.submitForm a lambda function

The function `LoginRefresh.submitForm` is changed to be a lambda
function. Reason is that `this` is now bound to the class, previously it
was bound to the event target.

Resolves: #86822
Releases: master
Change-Id: Ie4c072ebfe2867966636eec99818cc1e5b0a0ab3
Reviewed-on: https://review.typo3.org/58819
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Keep existing validation errors for recursive domain relations 77/56677/6
Markus Klösges [Mon, 16 Apr 2018 08:43:24 +0000 (10:43 +0200)]
[BUGFIX] Keep existing validation errors for recursive domain relations

Do not overwrite already generated validation errors when a property
validator leads to a recursive validate() call to the currently
validated GenericObjectValidator.

Resolves: #84475
Releases: master, 8.7
Change-Id: Ifbdb28ddcf6a8e7f1517801ebcd6634149b2bd5d
Reviewed-on: https://review.typo3.org/56677
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Changed label for page_tree_stop 28/58828/2
teilzeitphilosoph [Fri, 2 Nov 2018 13:46:48 +0000 (14:46 +0100)]
[TASK] Changed label for page_tree_stop

Clearified the message of the label of the field.
Added tooltip for a better explanation.

Resolves: #84580
Releases: master, 8.7
Change-Id: I13488115161a949193b2c5765b29407437f6b1ea
Reviewed-on: https://review.typo3.org/58828
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Set constraints in `FrontendRestrictionContainer` depending on workspace... 22/57822/8
Andreas Fernandez [Sun, 5 Aug 2018 16:12:31 +0000 (18:12 +0200)]
[BUGFIX] Set constraints in `FrontendRestrictionContainer` depending on workspace context

The `FrontendRestrictionContainer` must not respect the hidden flag, if
the request happens in a workspace context. The reason is that for
example pages that are created in a workspace have a hidden LIVE version,
which makes overlaying impossible.

This patch changes the behavior to act the same as
`PageRepository::enableFields()` does.

Resolves: #85742
Releases: master, 8.7
Change-Id: I5f1b12bcd8a63daf7eaa9bc9c065b96c343f6ab6
Reviewed-on: https://review.typo3.org/57822
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Tested-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Fix translated file relation with sql_mode=ONLY_FULL_GROUP_BY 13/58813/2
Mathias Brodala [Wed, 31 Oct 2018 16:34:11 +0000 (17:34 +0100)]
[BUGFIX] Fix translated file relation with sql_mode=ONLY_FULL_GROUP_BY

The SQL mode ONLY_FULL_GROUP_BY enforces all fields used in "GROUP BY"
to be present in "SELECT".

See https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_only_full_group_by

Resolves: #85159
Releases: master, 8.7
Change-Id: Iff7895dd9703557ca0b91613516bdb3391b4d4f6
Reviewed-on: https://review.typo3.org/58813
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Provide effectivePid for flexforms segment 97/58797/5
Patrick Lenk [Tue, 30 Oct 2018 11:20:36 +0000 (12:20 +0100)]
[BUGFIX] Provide effectivePid for flexforms segment

Custom ckeditor config is now loaded in flexforms.

Resolves: #83809
Related: #81748
Releases: master, 8.7
Change-Id: I9c0fe85d81f3e34209cd52afee18594e49020f54
Reviewed-on: https://review.typo3.org/58797
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Allow type 'text' in site configuration 18/58818/4
Georg Ringer [Thu, 1 Nov 2018 19:31:38 +0000 (20:31 +0100)]
[TASK] Allow type 'text' in site configuration

As yaml supports multiline text, it should be also allowed inside the
site configuration.
With #86214 the type 'text' has been allowed within inline relations.

Resolves: #86825
Releases: master
Change-Id: I2f0172e061cd277e23cf44390930864c7481c98b
Reviewed-on: https://review.typo3.org/58818
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Change cursor type hovering CE in language view 16/58816/2
Gianluigi Martino [Thu, 1 Nov 2018 11:41:31 +0000 (12:41 +0100)]
[TASK] Change cursor type hovering CE in language view

Change cursor type to "move" hovering content elements if you are in page
module and in language view. Same as in columns view in page module.

Resolves: #86820
Releases: master
Change-Id: Ib176fb4b415d8b9a64548c48aa0e9fc6f9077c26
Reviewed-on: https://review.typo3.org/58816
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Limit available languages in user setup module 21/58821/2
Georg Ringer [Thu, 1 Nov 2018 20:14:17 +0000 (21:14 +0100)]
[BUGFIX] Limit available languages in user setup module

Limit the available languages not only to the ones having a
translation but also if it is in the list of available languages
which are defined in the LocalConfiguration.php

Resolves: #86796
Releases: master
Change-Id: Ib08619cfaa7fcd2a829dad6bce932a29a450f21c
Reviewed-on: https://review.typo3.org/58821
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Add missing translation value for save_and_close in form engine 11/58811/2
Joerg Kummer [Wed, 31 Oct 2018 14:39:24 +0000 (15:39 +0100)]
[BUGFIX] Add missing translation value for save_and_close in form engine

Changes syntax for translation key and add default language value.

Resolves: #86799
Releases: master
Change-Id: Ic273fc845d1af9e9cda29c049239c4ff045de120
Reviewed-on: https://review.typo3.org/58811
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Preben Rather Sørensen <preben@rather.dk>
Tested-by: Preben Rather Sørensen <preben@rather.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Adding 3 to "TYPO" 10/58810/5
Jonathan I [Wed, 31 Oct 2018 14:30:31 +0000 (15:30 +0100)]
[BUGFIX] Adding 3 to "TYPO"

On other "TYPO3" references the "3" is present but not on this occurence.
Add the "3" to "TYPO" in order to have "TYPO3".

Releases: master, 8.7
Resolves: #86816
Change-Id: I21cfe6b10ca1757645c407014b3acbc41b7d7570
Reviewed-on: https://review.typo3.org/58810
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Migrate FormEngineFlexForm to TypeScript 34/56234/6
Andreas Wolf [Fri, 16 Mar 2018 15:12:52 +0000 (16:12 +0100)]
[TASK] Migrate FormEngineFlexForm to TypeScript

Change-Id: I3151b16f72baf31e13f841ecc95be4ca389cf36e
Resolves: #82587
Releases: master
Reviewed-on: https://review.typo3.org/56234
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Migrate FormEngineSuggest to TypeScript 20/56220/9
Andreas Fernandez [Fri, 16 Mar 2018 12:41:20 +0000 (13:41 +0100)]
[TASK] Migrate FormEngineSuggest to TypeScript

The FormEngineSuggest module is migrated to TypeScript now. In the same
step, the usage of jQuery is reduced and dead code has been removed.

Resolves: #82589
Releases: master
Change-Id: I87cf7aafdb68815c9406f5fa29661bf5af6acd85
Reviewed-on: https://review.typo3.org/56220
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Migrate LayoutModule/Paste.js to TypeScript 80/56280/5
Andreas Wolf [Sat, 17 Mar 2018 10:00:43 +0000 (11:00 +0100)]
[TASK] Migrate LayoutModule/Paste.js to TypeScript

Change-Id: I1eb5996b08a6aaaac8ef5d179c2e509f68c15cb3
Resolves: #84169
Releases: master
Reviewed-on: https://review.typo3.org/56280
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Resolve strict type assertion in RecordStateFactory 07/58807/2
Oliver Hader [Wed, 31 Oct 2018 06:44:37 +0000 (07:44 +0100)]
[BUGFIX] Resolve strict type assertion in RecordStateFactory

Applying a strict "string" type to values that are "null" will
lead to type errors for TCA properties that are not configured
- most probably for "languageField", "transOrigPointerField"
or "translationSource".

see https://github.com/georgringer/news/issues/776

Resolves: #86809
Releases: master
Change-Id: I53e9a48f196b8a87c97620346474528a0cf3877e
Reviewed-on: https://review.typo3.org/58807
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Adjust FrontendUserImageUpdateWizard 95/58795/3
Alexander Grein [Tue, 30 Oct 2018 10:44:15 +0000 (11:44 +0100)]
[BUGFIX] Adjust FrontendUserImageUpdateWizard

Make "Mark undone" and the migration itself work again.

Resolves: #86751
Releases: master
Change-Id: I0f2455b36a4de5e202892c26745d91fdc828161a
Reviewed-on: https://review.typo3.org/58795
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Correct clickjacking header in backend 04/58804/8
Chris Müller [Tue, 30 Oct 2018 18:58:51 +0000 (19:58 +0100)]
[BUGFIX] Correct clickjacking header in backend

The clickjacking header in the backend was not correctly set
according to
https://developer.mozilla.org/de/docs/Web/HTTP/Headers/X-Frame-Options

Resolves: #86808
Releases: master
Change-Id: I42aa89950122fb3a875f075b5966c83d8b69f1d9
Reviewed-on: https://review.typo3.org/58804
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Execute scheduler tasks ordered by next execution time 90/58790/5
Sascha Egerer [Tue, 30 Oct 2018 09:52:04 +0000 (10:52 +0100)]
[BUGFIX] Execute scheduler tasks ordered by next execution time

When executing scheduler tasks the next execution time of the task
should be used to define the execution order.

Resolves: #86795
Releases: master, 8.7
Change-Id: Id678c74a60491aa3c8be8a33534b71ac37245217
Reviewed-on: https://review.typo3.org/58790
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Allow overlay for all root level records 17/57417/6
Mathias Brodala [Fri, 29 Jun 2018 09:24:32 +0000 (11:24 +0200)]
[BUGFIX] Allow overlay for all root level records

Instead of a hardcoded list of tables allowed on root level use
the information from TCA instead.

Resolves: #85429
Releases: master
Change-Id: I1a7d96b1912f63e6461c321d5dd5685b5df4c656
Reviewed-on: https://review.typo3.org/57417
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[TASK] Add PHP 7.3 to bamboo core master testing 03/58803/3
Christian Kuhn [Tue, 30 Oct 2018 17:55:05 +0000 (18:55 +0100)]
[TASK] Add PHP 7.3 to bamboo core master testing

Bamboo core master pre-merge now tests with PHP 7.3 rc3,
especially PHP linting and unit tests.
Bamboo core nightly extends the suite with further permutations
including PHP 7.3. Only functional testing with microsoft mssql
sqlsrv is missing, the php module is not yet released to PHP 7.3.

Resolves: #86806
Releases: master
Change-Id: I26379a1e9b592f5d4c078b296f873834b18c83d2
Reviewed-on: https://review.typo3.org/58803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Run functional tests without xdebug on bamboo 01/58801/2
Christian Kuhn [Tue, 30 Oct 2018 14:41:54 +0000 (15:41 +0100)]
[TASK] Run functional tests without xdebug on bamboo

With the increased number of functional tests in v9 we
should squeeze out as much performance as possible from
the tests so waiting for bamboo is not so annoying. Not
loading xdebug gives us roughly 10-30% for functionals.

Resolves: #86801
Releases: master, 8.7
Change-Id: Ic7b9dd4dd0c71799ecb7207fc0e7170f98729545
Reviewed-on: https://review.typo3.org/58801
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Show correct namespace in example block of CommaSeparatedValueProcessor 99/58799/2
Joerg Boesche [Tue, 30 Oct 2018 13:27:29 +0000 (14:27 +0100)]
[BUGFIX] Show correct namespace in example block of CommaSeparatedValueProcessor

Resolves: #86800
Releases: master, 9.5, 8.7
Change-Id: I243589ee7e619f26e99e27d34c626e848a1ee80a
Reviewed-on: https://review.typo3.org/58799
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
11 months ago[BUGFIX] Update karma 82/58782/4
Andreas Fernandez [Mon, 29 Oct 2018 18:52:25 +0000 (19:52 +0100)]
[BUGFIX] Update karma

karma is used for JavaScript based unit tests. The currently installed
version is aged and doesn't compile on newer systems anymore, thus the
package is updated to a recent version.

Used command:
yarn add karma@^3.1.0 --dev

Resolves: #86798
Releases: master, 8.7
Change-Id: I1cea78cf3759227a2cd09b8560f37121ae580202
Reviewed-on: https://review.typo3.org/58782
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[TASK] Test fully built css in bamboo 88/58788/5
Christian Kuhn [Tue, 30 Oct 2018 08:28:11 +0000 (09:28 +0100)]
[TASK] Test fully built css in bamboo

Extend the "Lint scss ts" bamboo job to also build css
next to js and only after that verify with git status
no file changed. This should prevent outdated css as
recently fixed with #86789.
Additionally switch from npm to direct grunt calls,
to be in sync with runTests.sh and to allow kicking
npm from the docker images entirely.

Change-Id: I5134d43c5f5d524005242eee59aa743b6e49219a
Resolves: #86794
Related: #86789
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58788
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[TASK] Set TYPO3 version to 9.5.2-dev 96/58796/2
Oliver Hader [Tue, 30 Oct 2018 10:46:34 +0000 (11:46 +0100)]
[TASK] Set TYPO3 version to 9.5.2-dev

Change-Id: If96e59eef0e6be1eac2e58e2d50cf79ba70d6b16
Reviewed-on: https://review.typo3.org/58796
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[RELEASE] Release of TYPO3 9.5.1 94/58794/2 v9.5.1
Oliver Hader [Tue, 30 Oct 2018 10:45:16 +0000 (11:45 +0100)]
[RELEASE] Release of TYPO3 9.5.1

Change-Id: Ic1c6183af103b9c957b85d046ff2564348f165bc
Reviewed-on: https://review.typo3.org/58794
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[TASK] Move FieldControl/ListModule handling to module 49/58649/5
Andreas Fernandez [Thu, 18 Oct 2018 13:27:42 +0000 (15:27 +0200)]
[TASK] Move FieldControl/ListModule handling to module

The FieldControl `ListModule` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86647
Releases: master
Change-Id: Ibf47ee8ebaea584f88ccb9615681bd579e4cd305
Reviewed-on: https://review.typo3.org/58649
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[TASK] Move FieldControl/InsertClipboard handling to module 24/58624/4
Andreas Fernandez [Sat, 13 Oct 2018 10:54:05 +0000 (12:54 +0200)]
[TASK] Move FieldControl/InsertClipboard handling to module

The FieldControl `InsertClipboard` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86646
Releases: master
Change-Id: I42ded87ab9152d92d07f3fe5b40b327d979aad4a
Reviewed-on: https://review.typo3.org/58624
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[TASK] Move FieldControl/TableWizard handling to module 50/58650/3
Andreas Fernandez [Thu, 18 Oct 2018 13:32:23 +0000 (15:32 +0200)]
[TASK] Move FieldControl/TableWizard handling to module

The FieldControl `TableWizard` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86649
Releases: master
Change-Id: I1cb71ad317f737afb0d943a4278583888737bcab
Reviewed-on: https://review.typo3.org/58650
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Move FieldControl/AddRecord handling to module 48/58648/6
Andreas Fernandez [Thu, 18 Oct 2018 13:19:41 +0000 (15:19 +0200)]
[TASK] Move FieldControl/AddRecord handling to module

The FieldControl `AddRecord` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86642
Releases: master
Change-Id: I0d4e44719f38d4dd0e2355e3aeab6551e1725fb7
Reviewed-on: https://review.typo3.org/58648
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[TASK] Move FieldControl/ResetSelection handling to module 51/58651/9
Andreas Fernandez [Thu, 18 Oct 2018 14:07:19 +0000 (16:07 +0200)]
[TASK] Move FieldControl/ResetSelection handling to module

The FieldControl `ResetSelection` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86648
Releases: master
Change-Id: I478d5ae5567f38fb7cf75c30ab8ac7e2c021224e
Reviewed-on: https://review.typo3.org/58651
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Unsplit split buttons in TableController 84/58784/2
Andreas Fernandez [Mon, 29 Oct 2018 21:26:39 +0000 (22:26 +0100)]
[BUGFIX] Unsplit split buttons in TableController

The controller of the table wizard doesn't use split buttons anymore.

Resolves: #86792
Releases: master
Change-Id: I1d4c1f0d2a6a47dc9d997148fa70f6ea82b058cc
Reviewed-on: https://review.typo3.org/58784
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Re-build backend.css 83/58783/2
Andreas Fernandez [Mon, 29 Oct 2018 19:08:34 +0000 (20:08 +0100)]
[BUGFIX] Re-build backend.css

Since #86449, the backend.css is stale. This patch refreshes the build of
our CSS.

Used command:
grunt css

Resolves: #86789
Related: #86449
Releases: master
Change-Id: I5705c9680f3302a5b4ea6a0be013a49405979acb
Reviewed-on: https://review.typo3.org/58783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[TASK] Clean up PharStreamWrapperInterceptor 81/58781/2
Oliver Hader [Mon, 29 Oct 2018 18:01:22 +0000 (19:01 +0100)]
[TASK] Clean up PharStreamWrapperInterceptor

* fix spacing issue
* remove superfluous method

Resolves: #86788
Releases: master
Change-Id: I2825819663ef90cd8ba84578e3153faa62047f54
Reviewed-on: https://review.typo3.org/58781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
11 months ago[BUGFIX] Ignore unique evaluation in l10n_mode exclude 51/56151/9
Christoph Lehmann [Wed, 14 Mar 2018 22:17:53 +0000 (23:17 +0100)]
[BUGFIX] Ignore unique evaluation in l10n_mode exclude

The l10n_mode "exclude" explains to copy the field value from
source language, so unique evaluation should be ignored for
translated records.

Resolves: #84267
Resolves: #83572
Releases: master, 8.7
Change-Id: I6a086cb1fc447dda2cbcfe27f33ba9f3dd714f53
Reviewed-on: https://review.typo3.org/56151
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Render correct paging label 79/58779/4
Andreas Fernandez [Mon, 29 Oct 2018 13:58:40 +0000 (14:58 +0100)]
[BUGFIX] Render correct paging label

In case of paging in any record list, the page browser is rendered in top
and on bottom of ther record list.

The upper browser now renders the paging correctly by calculating the
offset of items of the previous page instead of hard-coding a "1".

Resolves: #86787
Releases: master, 8.7
Change-Id: Ib7c8856f248107ea9d17aeabe83a564189f69abf
Reviewed-on: https://review.typo3.org/58779
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Improve styling of upload form in extension manager 67/58467/4
Georg Ringer [Sat, 29 Sep 2018 17:50:57 +0000 (19:50 +0200)]
[TASK] Improve styling of upload form in extension manager

- Add missing id attribute
- Use bootstrap styling
- Use styled button

Resolves: #86449
Releases: master
Change-Id: I782226bc4326ecac4df1d3f8186b3d84d7e21fb7
Reviewed-on: https://review.typo3.org/58467
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Update typo3/testing-framework to 4.10.0 21/58621/6
Nicole Cordes [Fri, 12 Oct 2018 10:07:05 +0000 (12:07 +0200)]
[TASK] Update typo3/testing-framework to 4.10.0

Update from 4.9.0 to 4.10.0.
Notable change: The fluid RenderingContextFixture is
now provided by typo3/testing-framework, so core
namespace references can be adapted.

composer require --dev typo3/testing-framework ~4.10.0

Change-Id: Ifff354a2d418e09f08cf8818c3cd12ab87bf1ba8
Resolves: #86786
Releases: master
Reviewed-on: https://review.typo3.org/58621
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
11 months ago[BUGFIX] Respect endOfRange in pagination 50/57650/4
Guido Schmechel [Sat, 21 Jul 2018 12:55:14 +0000 (14:55 +0200)]
[BUGFIX] Respect endOfRange in pagination

If prepareObjectsSlice is called in the pagination with a QueryResult,
the endOfRange is calculated and used for each page.

This ensures that the maximum limit is not exceeded.

Resolves: #85585
Releases: master
Change-Id: I13f2ce910cbb4102782aafffca0ff7d193620735
Reviewed-on: https://review.typo3.org/57650
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Disable caching if fluid debugging is enabled 46/58646/7
Georg Ringer [Thu, 18 Oct 2018 07:42:48 +0000 (09:42 +0200)]
[BUGFIX] Disable caching if fluid debugging is enabled

Resolves: #86675
Releases: master
Change-Id: Ife47f1fe8c78899785fbad73e21e2a2bf9b8441a
Reviewed-on: https://review.typo3.org/58646
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser 96/58096/5
Frans Saris [Fri, 31 Aug 2018 08:21:13 +0000 (10:21 +0200)]
[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser

The fileBrowser now passes the related pid, table and field to
getDefaultUploadFolder().

Resolves: #86053
Releases: master, 8.7
Change-Id: I954753ee84b4107b37ba45cbd08917f4c4be17d9
Reviewed-on: https://review.typo3.org/58096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Always use default language for uniqueInSite 22/58722/5
Benni Mack [Fri, 26 Oct 2018 16:55:33 +0000 (18:55 +0200)]
[BUGFIX] Always use default language for uniqueInSite

SlugHelper fetches records of the same language, and takes the
pageId of the _current_ language record (uid), which is wrong.
For records, it must be 'pid', for pages it must be 'uid', but for
translated pages it must be 'pages.l10n_parent'.

Resolves: #86625
Releases: master
Change-Id: I7af6f0438f5a90169505069c557792d4e7b08b7c
Reviewed-on: https://review.typo3.org/58722
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Added default cropping ratio for social media images 74/58774/3
Richard Haeser [Mon, 29 Oct 2018 08:38:41 +0000 (09:38 +0100)]
[TASK] Added default cropping ratio for social media images

Most of the social networks use the 1.91:1 aspect ratio for images that
belong to the page that is shared.

Now og:image and twitter:image will be rendering an image with a 1.91:1
ratio by default.

Resolves: #86419
Releases: master
Change-Id: Icd3588363f64659f66ba25d4f44a57afff5c1fe1
Reviewed-on: https://review.typo3.org/58774
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Update TypoScript include 84/58184/3
Nick [Tue, 4 Sep 2018 12:52:52 +0000 (14:52 +0200)]
[TASK] Update TypoScript include

TypoScript include method with ext_typoscript_setup.txt should be removed,
this file is deprecated since July 2005.

Releases: master
Resolves: #86143
Change-Id: If30c52159a4e9242ed5645eebc45cd524c8c55ad
Reviewed-on: https://review.typo3.org/58184
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>