Packages/TYPO3.CMS.git
6 months ago[TASK] Deprecate internal_type=file and file_reference 14/58414/3
Benni Mack [Thu, 27 Sep 2018 16:57:26 +0000 (18:57 +0200)]
[TASK] Deprecate internal_type=file and file_reference

TCA "type=group" with "internal_type=file" and "internal_type=file_reference"
are the last parts of content related file handling that circumvent FAL.

All usages in the core have been changed since TYPO3 v6 until TYPO3 v9.

To prepare and unlock further file system related works in v10, it is
important we finally get rid of these parts that low level handles
uploads/ and other legacy functionality.

The patch finds any usages via TcaMigration, notes them as
deprecated and adds a series of hints to core places that can be
removed in v10. Note there is probably some hidden handling
left in the core, this is partially hard to find. We may stumble
upon more details in v10, but will have the freedom to remove
them then.

Resolves: #86406
Releases: master
Change-Id: I94f2fa6364277497e85e513f1bfd34cc0acf1390
Reviewed-on: https://review.typo3.org/58414
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Deprecate $GLOBALS['TYPO3_LOADED_EXT'] 08/58408/6
Benjamin Franzke [Thu, 27 Sep 2018 08:31:08 +0000 (10:31 +0200)]
[TASK] Deprecate $GLOBALS['TYPO3_LOADED_EXT']

$GLOBALS['TYPO3_LOADED_EXT'] is defined as the "old" way
since the introduction of the PackageManager in 2013:
https://review.typo3.org/19605
(The class description of LoadExtensionArrayElement states:
Class to simulate the "old" extension information array element)

This old way should finally be removed to reduce site effects
(pollution of the global scope) of the PackageManager class.
It's marked as deprecated now, to be removed in v10.

All existing usaged are rewritten to use the PackageManager API.

Releases: master
Resolves: #86404
Change-Id: Ic53f5155828ef2ea711a1961e08f8e020e3f836a
Reviewed-on: https://review.typo3.org/58408
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Use interface SiteInterface as return type instead of Site 03/58403/2
Georg Ringer [Wed, 26 Sep 2018 18:07:46 +0000 (20:07 +0200)]
[BUGFIX] Use interface SiteInterface as return type instead of Site

To avoid exceptions the proper return type must be used.

Resolves: #86390
Releases: master
Change-Id: I3741582936cb1e1b530012a1c7fb8ff3ab6da934
Reviewed-on: https://review.typo3.org/58403
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
6 months ago[BUGFIX] Use correct column order in override dialog 89/58389/2
Andreas Fernandez [Tue, 25 Sep 2018 16:25:49 +0000 (18:25 +0200)]
[BUGFIX] Use correct column order in override dialog

Resolves: #86152
Releases: master, 8.7
Change-Id: I677c6d0405b833caf8a62f7f560b2e9b97679b36
Reviewed-on: https://review.typo3.org/58389
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Fix formEngine SelectCheckBox word-wrap on small screens 00/58400/2
Josef Glatz [Wed, 26 Sep 2018 17:00:09 +0000 (19:00 +0200)]
[BUGFIX] Fix formEngine SelectCheckBox word-wrap on small screens

This patch enables word-wrap in a form element `type=select`
with `renderType=selectCheckBox` on small screen devices like
tablet portrait. It prevents the list from sticking out of the right
viewport border.

Only the case when TYPO3_CONF_VARS/BE/debug = false was
taken into account.

Resolves: #86391
Releases: master
Change-Id: Ia894b0a7481feb7a083bc583ff037063093f4e9c
Reviewed-on: https://review.typo3.org/58400
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Tested-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Run silent upgraders after install tool login 98/58398/2
Christian Kuhn [Wed, 26 Sep 2018 15:19:23 +0000 (17:19 +0200)]
[BUGFIX] Run silent upgraders after install tool login

On successful login to standalone install tool, the routing
should jump to the silent upgraders and not to the main layout
directy to make sure the upgraders are executed at least once
before the maintenance view is loaded.

Resolves: #86386
Releases: master
Change-Id: I1246493671645d899780bb9ff1b08ed5682115a3
Reviewed-on: https://review.typo3.org/58398
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Allow linking to a targetSite without currentSite 97/58397/2
Susanne Moog [Wed, 26 Sep 2018 08:49:15 +0000 (10:49 +0200)]
[BUGFIX] Allow linking to a targetSite without currentSite

In case no current site exists in a context (for example currently
eID or other scripting contexts), the pageLinkBuilder threw an error
when linking to a page with a site configuration. The necessity for
having a current site config has been removed, the pageLinkBuilder
can now be used without a current site object and will then always
generate absolute URLs to the target site.

Resolves: #86384
Releases: master
Change-Id: Id8c984c4ac3837d7b4da37a99d43410c6db34187
Reviewed-on: https://review.typo3.org/58397
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[TASK] Mitigate argon2i hash issues 02/58402/4
Christian Kuhn [Wed, 26 Sep 2018 17:30:55 +0000 (19:30 +0200)]
[TASK] Mitigate argon2i hash issues

* Let the "stored hash uses not supported mechanism" bubble up.
  Instead of just a "login failed", an error is raised hinting
  that something is broken.
* Improve exception message #1533818591: If an upgrade or new
  installation has been performed on a system that does support
  argon2i, users are upgraded to this mechanism. If the instance
  is later deployed to a server that does not support argon2i, the
  hash comparison will fail.
* Improve exception message #1533822084: This one is usually only
  raised if a core upgrade from v8 to v9 has just been performed on
  an instance that does not support argon2i, and a backend login is
  executed before the install tool silent configuration upgrader
  configured the system properly.
* Wiki pages with more details:
  https://wiki.typo3.org/Exception/CMS/1533818591
  https://wiki.typo3.org/Exception/CMS/1533822084

Resolves: #86392
Releases: master
Change-Id: I51e4ee9a198b9b92feec43c37a8b6b9b41c1b6f9
Reviewed-on: https://review.typo3.org/58402
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[TASK] Further improvements for the site configuration 99/58399/4
Josef Glatz [Wed, 26 Sep 2018 14:01:43 +0000 (16:01 +0200)]
[TASK] Further improvements for the site configuration

This patch enhances the self declaration of the site
configuration form elements.

- TCA descriptions were added to specific elements to
  provide a better clarity on how to use them.
- First char uppercase on existing descriptions.
- Input fields gets properly trimmed now.
- Additional placeholders were added.

Beside that, all missing PHPDoc blocks are added to
the previously added UserFunctions class.

Releases: master
Resolves: #86387
Related: #85887
Change-Id: I684bb2044e4bb7ce3a6c60bf4656e83260fedafe
Reviewed-on: https://review.typo3.org/58399
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[TASK] Deprecate GeneralUtility::_GETset() 44/58344/7
Benni Mack [Thu, 20 Sep 2018 06:44:41 +0000 (08:44 +0200)]
[TASK] Deprecate GeneralUtility::_GETset()

The functionality of _GETset() is really broken by design
when thinking about having a non-global state.

On top $TSFE->mergingWithGetVars(), which was mainly used
in RealURL, is deprecated, as this needs to go within a PSR-15
middlware (I actually did that in a fork already for realurl v1).

Resolves: #86389
Releases: master
Change-Id: I7081ed48131237f9d1b0da6a4ddf252a34a02072
Reviewed-on: https://review.typo3.org/58344
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[TASK] Fix syntax highlighting in Changelog for ImplementStaticRoutes 09/58409/2
Daniel Siepmann [Thu, 27 Sep 2018 08:39:14 +0000 (10:39 +0200)]
[TASK] Fix syntax highlighting in Changelog for ImplementStaticRoutes

Use yaml as default highlighting. Add markup for code blocks.

Also add highlighting for file names.

Resolves: #86214
Releases: master
Change-Id: I716c9bf80f86e3188409d173d767469a84a28e82
Reviewed-on: https://review.typo3.org/58409
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
6 months ago[BUGFIX] Prevent closing a record after changes made with „toggle all“ 92/58392/4
Josef Glatz [Tue, 25 Sep 2018 18:20:16 +0000 (20:20 +0200)]
[BUGFIX] Prevent closing a record after changes made with „toggle all“

This patch prevents closing a form without showing the modal
to inform the backend user about unsaved changes if values of
an element with renderType `selectCheckBox` were changed
through a „toggle all“ checkbox.

Resolves: #86377
Releases: master, 8.7
Change-Id: I8a0ffd7ae0104739fdb66a1863e7012c0d30c84e
Reviewed-on: https://review.typo3.org/58392
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[TASK] Add facades for symfony/routing components 01/58401/4
Benni Mack [Wed, 26 Sep 2018 17:42:21 +0000 (19:42 +0200)]
[TASK] Add facades for symfony/routing components

We heavily rely on Symfony Routing for TYPO3 routing,
however we want to encapsulate this as much as possible
to allow us to use a different routing system if a better one
comes up.

In order to proceed with Route Enhancers we introduce
our own objects to extend them, and to typehint against
these objects in the next patches.

Some minor code preparations have been made as well.

Resolves: #86393
Releases: master
Change-Id: Id50186aa1a5ad57e097e6ff85e15d0f925bd63ef
Reviewed-on: https://review.typo3.org/58401
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[TASK] Add more info to some rst files 91/58391/4
Susanne Moog [Tue, 25 Sep 2018 16:46:45 +0000 (18:46 +0200)]
[TASK] Add more info to some rst files

During upgrading missing information in some rst files has been added
to ease upgrading for others.

Resolves: #86376
Releases: master
Change-Id: I4027e9b6e7da9ca663549fbe6489d1eea5671152
Reviewed-on: https://review.typo3.org/58391
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Clean up Routing API 49/58149/9
Oliver Hader [Tue, 25 Sep 2018 07:51:52 +0000 (09:51 +0200)]
[TASK] Clean up Routing API

The PageUriBuilder is gone, as all is centralized in the
PageRouter now, which acts as the centralized place to resolve
Requests ("matchRequest") and to create URLs ("generateUri")
for pages that have a site configuration.

RouterInterface is the abstract interface which is intended to be
used within Backend as well in the future, and provides a good basis
for both cases (that's why page ID and SiteInterface is not hardcoded
in the API).

RouteResultInterface is introduced to allow further Result objects
like page-specific results, useful for future routing improvements.

Since PageUriBuilder was only used in cases where there was a
site, the Router is now bound to a site (see constructor).

When generating a URL, the PageRouter can receive a special
argument called "_language" to hand over a SiteLanguage object.

Resolves: #86388
Releases: master
Change-Id: Ib090d3373a88cb7c534557ef21b46dce646078b5
Reviewed-on: https://review.typo3.org/58149
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[TASK] Add more information to IRRE titles 85/58385/8
Frank Naegler [Tue, 25 Sep 2018 09:16:57 +0000 (11:16 +0200)]
[TASK] Add more information to IRRE titles

This patch put more information into IRRE titles of site configuration.

Resolves: #85887
Releases: master
Change-Id: I7d3df7b9513eb9cd591605eb450c4ae451b1fd75
Reviewed-on: https://review.typo3.org/58385
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] adminpanel: Do not use getTSConfig in a deprecated way 96/58396/2
Benjamin Franzke [Wed, 26 Sep 2018 06:35:20 +0000 (08:35 +0200)]
[BUGFIX] adminpanel: Do not use getTSConfig in a deprecated way

Since https://review.typo3.org/56968 handing over arguments
to getTSConfig() is deprecated.

As a drive-by we also fix some related wrong getTSConfig() mocks
in Unit/Middleware/AdminPanelInitiatorTest.php – they do not
produce errors, but these mocks are too unspecific, as they
still allow an argument to be passed.

Releases: master
Resolves: #86383
Related: #85016
Change-Id: I7254b5d0b87bc66da319728f7fe82aaa614b6a43
Reviewed-on: https://review.typo3.org/58396
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] Prevent closing a record after T3Editor content changes 94/58394/7
Josef Glatz [Tue, 25 Sep 2018 20:57:07 +0000 (22:57 +0200)]
[BUGFIX] Prevent closing a record after T3Editor content changes

This patch prevents closing a form without showing the modal
to inform the backend user about unsaved changes if values of
an element with renderType `t3editor` were changed within the
CodeMirror editor.

In addition to the fix, a CSS border is added if the code editor
content was changed to improve the user experience.

Releases: master
Resolves: #86380
Change-Id: I641180a531b879ece70e30d0a22c9e5878d02953
Reviewed-on: https://review.typo3.org/58394
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[BUGFIX] Fix noCacheHash argument of f:link.action ViewHelper 95/58395/2
Josef Glatz [Tue, 25 Sep 2018 21:25:09 +0000 (23:25 +0200)]
[BUGFIX] Fix noCacheHash argument of f:link.action ViewHelper

Resolves: #86379
Releases: master
Change-Id: I8eadc7d6cf242581601065ef780229e577149204
Reviewed-on: https://review.typo3.org/58395
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Allow running AbstractUpdate wizards on CLI 70/58370/7
Susanne Moog [Fri, 21 Sep 2018 14:27:45 +0000 (16:27 +0200)]
[TASK] Allow running AbstractUpdate wizards on CLI

To ease the update pain a compatibility layer for AbstractUpdate based
upgrade wizards has been implemented, that allows running "old" wizards
on CLI (enabling extension authors to support both v8 and v9 with one
wizard).

To get people to migrate to the new structure the methods in Abstract
Update have all been deprecated. As it is an abstract class this has
been done in all methods and the constructor as we cannot reliably know
which methods are overwritten.

Resolves: #86366
Relates: #86076
Releases: master
Change-Id: I3d4ba756ca37d82a918c1021c48b2f331e64f696
Reviewed-on: https://review.typo3.org/58370
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[BUGFIX] Show mount point pid in tooltip 72/58372/3
Guido Schmechel [Fri, 21 Sep 2018 19:48:38 +0000 (21:48 +0200)]
[BUGFIX] Show mount point pid in tooltip

Use either field mount_pid or display a note

Releases: master
Resolves: #86349
Change-Id: Iaed4f7ab527f02644670d980dc6f6feaef010537
Reviewed-on: https://review.typo3.org/58372
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[BUGFIX] Prevent saving of invalid records 86/58386/4
Frank Naegler [Tue, 25 Sep 2018 10:00:26 +0000 (12:00 +0200)]
[BUGFIX] Prevent saving of invalid records

This patch prevents saving an invalid record by click „close“
and „save“ in the modal.

Resolves: #86357
Releases: master
Change-Id: If7f581e9eaaf55dea463528563b7e679a6e65201
Reviewed-on: https://review.typo3.org/58386
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[TASK] Fix list items of 80700 rst file 83/58383/4
David Bruchmann [Mon, 24 Sep 2018 19:42:03 +0000 (21:42 +0200)]
[TASK] Fix list items of 80700 rst file

Add missing blank line before each list to have proper rendering.

Releases: master
Resolves: #86364
Change-Id: I4f8ee96e7996cfb925abad23ad950da7153c25cc
Reviewed-on: https://review.typo3.org/58383
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
6 months ago[BUGFIX] Respect editlock in history/undo-module 04/57804/7
Guido Schmechel [Sat, 4 Aug 2018 10:36:07 +0000 (12:36 +0200)]
[BUGFIX] Respect editlock in history/undo-module

Now the editlock information of the page is retreived and used
as condition for the rollback command icon.

Releases: master
Resolves: #69114
Change-Id: Ie3122a511c96ca6d6d7913e3e1efcfe3d4d84cd6
Reviewed-on: https://review.typo3.org/57804
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Process typolink syntax for redirect target field contents 74/58374/3
Jigal van Hemert [Sat, 22 Sep 2018 20:49:54 +0000 (22:49 +0200)]
[BUGFIX] Process typolink syntax for redirect target field contents

Resolves: #86355
Releases: master
Change-Id: I348a52aaccc481bc928e096d54818c5d572e7e5f
Reviewed-on: https://review.typo3.org/58374
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[TASK] CKEditor: enable autolink plugin per default 77/58377/2
Josef Glatz [Sun, 23 Sep 2018 13:27:56 +0000 (15:27 +0200)]
[TASK] CKEditor: enable autolink plugin per default

This patch activates the autolink functionality while
pasting an URL or an email address from the clipboard
to the CKEditor in WYSIWYG-mode.

Resolves: #83789
Releases: master
Change-Id: I0c23dc57406207614aca0d865b99ade3917ef15a
Reviewed-on: https://review.typo3.org/58377
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Fix scheduler TaskList partial 78/58378/2
Josef Glatz [Sun, 23 Sep 2018 14:58:24 +0000 (16:58 +0200)]
[BUGFIX] Fix scheduler TaskList partial

A translate VH was converted incorrectly in one of
the patchsets of #86291 before it was just merged
into the core.

Resolves: #86358
Related: #86291
Releases: master
Change-Id: Idead223d0a5ba988cb4d20e58d686c4e265b7eb1
Reviewed-on: https://review.typo3.org/58378
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Remove invalid parent constructor call and cleanup code 67/58367/7
Frank Naegler [Fri, 21 Sep 2018 10:17:16 +0000 (12:17 +0200)]
[BUGFIX] Remove invalid parent constructor call and cleanup code

Resolves: #86352
Releases: master
Change-Id: I30ed9f8f2b14819654fc496991b860b0bdf97d9c
Reviewed-on: https://review.typo3.org/58367
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Stabilize Extbase tests on PostgreSQL 81/58381/2
Tymoteusz Motylewski [Sun, 23 Sep 2018 18:54:47 +0000 (20:54 +0200)]
[TASK] Stabilize Extbase tests on PostgreSQL

Resolves: #86360
Releases: master, 8.7
Change-Id: I34e6b720a93bd86f863fbf4ae0b5efb6cccdc76d
Reviewed-on: https://review.typo3.org/58381
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Use right keys in typeicon_classes for site_errorhandling table 79/58379/2
Jigal van Hemert [Sun, 23 Sep 2018 15:09:20 +0000 (17:09 +0200)]
[BUGFIX] Use right keys in typeicon_classes for site_errorhandling table

The IRRE records show an icon depending on the type of error handler that
is configured. Because the wrong keys were used only the default
"not found" icon was displayed.

Resolves: #86359
Releases: master
Change-Id: I424fc17daa3d24dd8763b08d1b00994f49da5d91
Reviewed-on: https://review.typo3.org/58379
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Allow settings language labels via TS even if no xlf present 73/58373/2
Markus Klein [Fri, 21 Sep 2018 21:00:34 +0000 (23:00 +0200)]
[BUGFIX] Allow settings language labels via TS even if no xlf present

Re-establish the functionality to set language labels in TypoScript
even though no locallang.xlf file is present for the given extension.

Resolves: #86194
Releases: master
Change-Id: Ifcd31909fa594be892f93c1037941313011b74cf
Reviewed-on: https://review.typo3.org/58373
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Tested-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Use dark sorting icon in filelist module 63/58363/2
Georg Ringer [Fri, 21 Sep 2018 08:56:00 +0000 (10:56 +0200)]
[TASK] Use dark sorting icon in filelist module

Use the dark icons, just as in the list module.

Resolves: #86345
Releases: master
Change-Id: Ife258d11a1384076f1333e2c97a1c0a41599202f
Reviewed-on: https://review.typo3.org/58363
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
6 months ago[BUGFIX] Pass language mode to QuerySettings in default language too 51/58351/11
Tymoteusz Motylewski [Thu, 20 Sep 2018 13:35:52 +0000 (15:35 +0200)]
[BUGFIX] Pass language mode to QuerySettings in default language too

Introduction of the LanguageAspect changed the Extbase behavior, now it's
reintroduced.
When reviewing this patch please compare new code of
Typo3QuerySettings.php from this patch with state before
patch https://review.typo3.org/57424/ and compare
QueryLocalizedDataTest.php with one from v8 to see that
result is the same.

Resolves: #86332
Related: #85543
Releases: master
Change-Id: Ide9f5e1fe1875b942aac8d1187dc897cc1b20181
Reviewed-on: https://review.typo3.org/58351
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Remove a common set of false positives from extension scanner 60/58360/4
Christian Kuhn [Thu, 20 Sep 2018 19:32:27 +0000 (21:32 +0200)]
[TASK] Remove a common set of false positives from extension scanner

The patch removes a set of common methods and properties from
the extension scanner to show less weak matches:
* method init()
* class properties ->config, ->tmpl, ->id, ->returnUrl
Remember this only kicks methods and properties that are so common
that many extensions use them and there are more false positives
than actual matches.
Remember a green file does not mean nothing breaks and a red file does not
mean nothing works. It is not goal of the extension scanner to find
everything, and matches do not mean they are valid.
The above matcher configurations have only been removed since they
use a naming that is often also used in extension. The places where they are
used in core are usually deep in the API and it is rather unlikely a match found
by the scanner does really mean the deprecated / removed method or property
rather than just a false positive due to the common naming.
Other matchers should still be kept, even if they show false
positives in specific cases.
It should not be a goal of an extension developer to make the
extension scanner green.

Change-Id: Ifc27974fe9e854a93661cd1814f044f50a552119
Resolves: #86340
Releases: master
Reviewed-on: https://review.typo3.org/58360
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] Use proper events to trigger HTML5 validation in Install Tool 69/58369/2
Andreas Fernandez [Fri, 21 Sep 2018 10:56:06 +0000 (12:56 +0200)]
[BUGFIX] Use proper events to trigger HTML5 validation in Install Tool

The actions "Create admin" and "Change install tool password" now listen
to the `submit` event of their respective form to allow using the
HTML5-based field validation.

Resolves: #86344
Releases: master
Change-Id: I4e913d71e356f41d04b6b0b653445c48a3a671e1
Reviewed-on: https://review.typo3.org/58369
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[TASK] Performance optimizations for the form manager module 54/58054/12
Ralf Zimmermann [Mon, 27 Aug 2018 23:10:07 +0000 (01:10 +0200)]
[TASK] Performance optimizations for the form manager module

Speeds up the form manager module and the form plugin especially if
there are many forms within the TYPO3 instance.

Resolves: #86000
Releases: master, 8.7
Change-Id: Ic483029e0d1b1955d58e04496f97862c00b6d6a4
Reviewed-on: https://review.typo3.org/58054
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[BUGFIX] Fix site configuration caching 66/58366/4
Susanne Moog [Fri, 21 Sep 2018 09:52:25 +0000 (11:52 +0200)]
[BUGFIX] Fix site configuration caching

Resolves: #86350
Releases: master
Change-Id: Iae67211c8a3421a8cdd78a68c88d15da43f9e67e
Reviewed-on: https://review.typo3.org/58366
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[DOCS] Fix typo in variants for sites base feature 68/58368/4
Sascha Egerer [Fri, 21 Sep 2018 10:23:22 +0000 (12:23 +0200)]
[DOCS] Fix typo in variants for sites base feature

Related: #86303
Releases: master
Change-Id: I56e48fa481fc59dd7bda20a4cc76bf2d3b1826a4
Reviewed-on: https://review.typo3.org/58368
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[FEATURE] Allow multiple domain variants per site 06/58206/10
Georg Ringer [Fri, 7 Sep 2018 07:42:13 +0000 (09:42 +0200)]
[FEATURE] Allow multiple domain variants per site

Extend the site configuration by allowing multiple base domains
which are checked by the ConditionMatcher.

Resolves: #86303
Releases: master
Change-Id: Ib80821c80e88d86656b03d29b746e526f300fd95
Reviewed-on: https://review.typo3.org/58206
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[TASK] Improve install tool loading message 65/58365/4
Christian Kuhn [Fri, 21 Sep 2018 09:42:00 +0000 (11:42 +0200)]
[TASK] Improve install tool loading message

The first 'silent configuration update' ajax call in the install
tool does two things: As all others, it checks for a valid session,
if valid, it executes the update.
If session is not active, the 'enable install tool' file view is
loaded next. Not having a dedicated 'check session' call as first
step saves one ajax round trip.
The patch improves the status message to avoid confusion why the
silent configuration update is executed for login view.

Resolves: #86347
Related: #86347
Releases: master
Change-Id: Idfd1fbb449dca4acd641f86e42092d56246ee3a2
Reviewed-on: https://review.typo3.org/58365
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Change visibility of PageRepository->init 43/58343/10
Benni Mack [Thu, 20 Sep 2018 06:37:36 +0000 (08:37 +0200)]
[TASK] Change visibility of PageRepository->init

The init() method is now called implicitly within the constructor,
so the last part is to mark the method protected.

Resolves: #86338
Related: #85450
Releases: master
Change-Id: Ic4c49f1dfbc3d9cda2f9c2bfbbdf4de333d836c0
Reviewed-on: https://review.typo3.org/58343
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Re-add `self` assignments 59/58359/2
Andreas Fernandez [Thu, 20 Sep 2018 19:24:05 +0000 (21:24 +0200)]
[BUGFIX] Re-add `self` assignments

Some `self` assignments were removed that shouldn’t have been removed.
That was selfish, so they are added again.

Resolves: #86339
Related: #86330
Releases: master
Change-Id: I0ae875b60c9766b233d0a93a55d68bc7142a417d
Reviewed-on: https://review.typo3.org/58359
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Update Feature-82812-NewSyntaxForImportingTypoScriptFiles.rst 61/58361/2
Riny van Tiggelen [Thu, 20 Sep 2018 19:51:16 +0000 (21:51 +0200)]
[TASK] Update Feature-82812-NewSyntaxForImportingTypoScriptFiles.rst

Wrong order of directory names

Releases: master
Resolves: #86342
Change-Id: I8aaf9ad050bac017b5b5f2bca6d98bea69a9487b
Reviewed-on: https://review.typo3.org/58361
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
7 months ago[TASK] Update CKEditor from 4.9.1 to 4.10.1 24/58324/3
Josef Glatz [Tue, 18 Sep 2018 21:20:35 +0000 (23:20 +0200)]
[TASK] Update CKEditor from 4.9.1 to 4.10.1

Update CKEditor to the lastest version that fixes a lot of bugs.

Release notes:
https://ckeditor.com/cke4/release-notes
https://ckeditor.com/cke4/release/CKEditor-4.9.2
https://ckeditor.com/cke4/release/CKEditor-4.10.0
https://ckeditor.com/cke4/release/CKEditor-4.10.1

@types/ckeditor has also been updated.

Following commands were used to update dependencies:
- yarn upgrade ckeditor@4.10.1 -E -D
- yarn upgrade @types/ckeditor@4.9.1 -E -D
(As there is no newer types definition, version 4.9.1 must
be used)

The following command was used to update the files
in EXT:rte_ckeditor:
- yarn build

Releases: master
Resolves: #86305
Change-Id: I8e5210316454854b93c979e0e7ac1eea3b54e7d4
Reviewed-on: https://review.typo3.org/58324
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[TASK] Make DataMapper not a singleton 87/58287/21
Tymoteusz Motylewski [Sat, 15 Sep 2018 19:16:28 +0000 (21:16 +0200)]
[TASK] Make DataMapper not a singleton

DataMapper is not a singleton any more. Thanks to that, a further
refactoring can be done to pass aggregate root query configuration
to the DataMapper, which will allow to fix inconsistencies
in Extbase language handling.

The runtime cache of data maps is moved to DataMapFactory.

Resolves: #86268
Releases: master
Change-Id: I003451c4d07855ff25d695578c9ec7b443f630bc
Reviewed-on: https://review.typo3.org/58287
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[BUGFIX] Catch FileDoesNotExistException during persisting records 86/58286/2
Georg Ringer [Sat, 15 Sep 2018 17:17:34 +0000 (19:17 +0200)]
[BUGFIX] Catch FileDoesNotExistException during persisting records

Catch an exception which is thrown if a file of a sys_file_reference
relation does not exist anymore.

Resolves: #86267
Releases: master
Change-Id: Ie50ae07845964346bcd8e042a6a3d62a1e8084d3
Reviewed-on: https://review.typo3.org/58286
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Ensure consistent UI in panels of Settings > Configuration Presets 56/58356/2
Andreas Fernandez [Thu, 20 Sep 2018 17:26:55 +0000 (19:26 +0200)]
[BUGFIX] Ensure consistent UI in panels of Settings > Configuration Presets

The panels used in Settings > Configuration Presets do now have the same
UI than the other panels in the Install Tool.

Resolves: #86337
Releases: master
Change-Id: Iada1994fa77ff2fe78d5a81720bff6c97f14bccd
Reviewed-on: https://review.typo3.org/58356
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
7 months ago[TASK] Improve database analyzer UX 55/58355/3
Christian Kuhn [Thu, 20 Sep 2018 16:53:20 +0000 (18:53 +0200)]
[TASK] Improve database analyzer UX

Give earlier feedback when opening the database analyzer
modal, block the buttons again if executing changes and
update the progress bar with what is currently going on.

Resolves: #86335
Releases: master
Change-Id: Ib1e01427fc7bb364d9a030ca1978804a7c1a8b49
Reviewed-on: https://review.typo3.org/58355
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[TASK] Do not crash install tool if a modal fails 50/58350/4
Christian Kuhn [Thu, 20 Sep 2018 13:09:16 +0000 (15:09 +0200)]
[TASK] Do not crash install tool if a modal fails

* Direct action buttons (eg. clear cache) catch ajax errors
  and turn them into a notification, so the main frame of
  the install tool does not die.
* Server side errors triggered by ajax calls from within
  modals no longer kill the main install tool frame, but
  render the error message into the modal.
* Improved error display with more info on how to recover
  and a (collapsed) output of the generic server side
  error message or backtrace depending on error settings.

Resolves: #86330
Releases: master
Change-Id: I9fa7602d0ea26d979f832022e03b78975b9877af
Reviewed-on: https://review.typo3.org/58350
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Add first acceptance test for sites module 54/58354/2
Susanne Moog [Thu, 20 Sep 2018 15:24:46 +0000 (17:24 +0200)]
[TASK] Add first acceptance test for sites module

Resolves: #86334
Releases: master
Change-Id: Ie2d5b16844bed3b57679d9771b0b29280bf3bae9
Reviewed-on: https://review.typo3.org/58354
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Initialize site configuration for new sites 52/58352/3
Georg Ringer [Thu, 20 Sep 2018 13:46:28 +0000 (15:46 +0200)]
[BUGFIX] Initialize site configuration for new sites

Since a regression in #86323 the site configuration for new sites
must be initialized correctly to avoid exceptions.

Resolves: #86333
Related: #86323
Releases: master
Change-Id: I4d44c01e7789f62811208e1e29655c92821e6b95
Reviewed-on: https://review.typo3.org/58352
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Use SiteFinder in indexed_search 48/58248/6
Georg Ringer [Mon, 10 Sep 2018 17:42:54 +0000 (19:42 +0200)]
[TASK] Use SiteFinder in indexed_search

Instead of only supporting sys_domain records the
SiteFinder should be used for showing a related domain.

Resolves: #86218
Releases: master
Change-Id: Iec66aa4e4ad81449d8265fde7ac53c0aef454b3f
Reviewed-on: https://review.typo3.org/58248
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Silent upgrade wizard changes unrelated field definitions 53/58353/4
Christian Kuhn [Thu, 20 Sep 2018 14:20:10 +0000 (16:20 +0200)]
[BUGFIX] Silent upgrade wizard changes unrelated field definitions

The silent upgrade wizard that should add missing cache
database tables also tends to change fields of not related
tables. The good thing is that this silent upgrader is
not really needed anymore since the "check for missing fields"
step that is always executed afterwards does find and create
cache tables, too.

Resolves: #86228
Releases: master
Change-Id: I9747da74118a6af6368032aa63f6022e0f6c7514
Reviewed-on: https://review.typo3.org/58353
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[TASK] Provide more tests for Extbase rendering in languages 76/58276/13
Tymoteusz Motylewski [Fri, 14 Sep 2018 12:05:47 +0000 (14:05 +0200)]
[TASK] Provide more tests for Extbase rendering in languages

Some tests are just documenting current, buggy behavior.
So once bugs are fixed assertions needs to be updated.
See inline comments for details (and list of related issues below).

Resolves: #86327
Related: #45873
Related: #68672
Releases: master
Change-Id: I780f77fa95d3824a2dafd58a1a73df2bb5fac9e4
Reviewed-on: https://review.typo3.org/58276
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Improve the scheduler task group table listing 11/58311/15
Josef Glatz [Wed, 5 Sep 2018 04:29:28 +0000 (06:29 +0200)]
[TASK] Improve the scheduler task group table listing

This patch basically adjusts the HTML markup for the listAction
to make the scheduler task tables look like the recordlist module.
Toggling of the tables was migrated to Bootstrap collapse which
is already in use inside the TYPO3 Install Tool.

Furthermore, an infobox will now be displayed if erroneous
scheduler tasks are found and the instructions are improved.

A scheduler task group is hidden from now on, if a task group
does not have any executable tasks at all (what will happen when
all scheduler tasks  of a scheduler task group are shown in the
missingClasses scheduler task table).

Last but not least, automatic CGL were applied to the fluid
template. Incorrectly positioned CSS has been moved. Superfluous
CSS was removed.

Command `yarn build-css` was used to compile the CSS changes
for this patch.

Releases: master
Resolves: #86291
Change-Id: I4615841cd6e4db40b6633f47acfe625ea254ff10
Reviewed-on: https://review.typo3.org/58311
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
7 months ago[TASK] Streamline expressionLanguage usage in core 32/58232/33
Susanne Moog [Sat, 8 Sep 2018 14:12:08 +0000 (16:12 +0200)]
[TASK] Streamline expressionLanguage usage in core

* provide same functions across contexts / methods
* provide same way to extend expressionLanguage everywhere
* provide way to load context specific variables and functions
* prepare compile step

Resolves: #86196
Related: #86243
Releases: master
Change-Id: I86cc04ec7051293c195879f823d90d894d160ff0
Reviewed-on: https://review.typo3.org/58232
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[FEATURE] Allow static route resolving 15/58315/15
Susanne Moog [Tue, 18 Sep 2018 14:19:35 +0000 (16:19 +0200)]
[FEATURE] Allow static route resolving

Resolving for predefined routes has been introduced.

Static routes can be configured on a per-site level
to provide for example robots.txt or sitemap.xml
routes.

Routes are resolved directly after site resolving
in a middleware and directly return content if found.

Static routes can be configured to deliver static text
defined in site configuration or fetch content from
a file, page or url.

The GUI uses the link wizard for providing URLs.

Resolves: #86214
Releases: master
Change-Id: I6d07529cf535a02472b2e03a763a00ff049270e8
Reviewed-on: https://review.typo3.org/58315
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[BUGFIX] Provide page ID in pagetree overview 95/58295/9
Guido Schmechel [Sun, 16 Sep 2018 16:47:44 +0000 (18:47 +0200)]
[BUGFIX] Provide page ID in pagetree overview

Implement the page ID in pagetree and localization overview. And
make it controllable with User TS Config.

Resolves: #86269
Releases: master
Change-Id: Ie6fc1824aa3ecc781d3386017744c58604fb36e4
Reviewed-on: https://review.typo3.org/58295
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Deprecate extbase annotation @flushesCaches 28/58328/3
Anja [Wed, 19 Sep 2018 07:18:07 +0000 (09:18 +0200)]
[TASK] Deprecate extbase annotation @flushesCaches

The annotation has been introduced during backport from FLOW, but
was never implemented to do anything useful. It will be removed
without substitution.

Change-Id: I34e337ecfd81185a965beb4d2495256ba6b35670
Resolves: #85981
Releases: master
Related: #82703
Reviewed-on: https://review.typo3.org/58328
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Update styleguide to 9.2.1 48/58348/3
Christian Kuhn [Thu, 20 Sep 2018 10:00:22 +0000 (12:00 +0200)]
[TASK] Update styleguide to 9.2.1

A series of small patches have been applied to styleguide.

composer require --dev typo3/cms-styleguide:~9.2.1

Resolves: #86325
Releases: master
Change-Id: I94ba7a2e0d3c8a65fe5f21d3f7863d3984f34af3
Reviewed-on: https://review.typo3.org/58348
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Make edit button visible for admin 96/58296/3
Guido Schmechel [Sun, 16 Sep 2018 17:42:36 +0000 (19:42 +0200)]
[BUGFIX] Make edit button visible for admin

If user is logged in as admin, the edit buttons are always displayed.

Resolves: #86277
Releases: master
Change-Id: I80f96df09c2f4fab886e03cf5aa4cb91cb1bf06c
Reviewed-on: https://review.typo3.org/58296
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[DOCS] Fix typo for canonical link feature 46/58346/2
Xavier Perseguers [Thu, 20 Sep 2018 08:16:51 +0000 (10:16 +0200)]
[DOCS] Fix typo for canonical link feature

Related: #20051
Releases: master
Change-Id: I3891aaa4b62de99a86bf19b3500aabaec6daafc9
Reviewed-on: https://review.typo3.org/58346
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] add propertyName to _isDirty() check 45/58345/3
Daniel Lorenz [Thu, 20 Sep 2018 08:13:34 +0000 (10:13 +0200)]
[BUGFIX] add propertyName to _isDirty() check

_isDirty() without the propertyName returns false if
propertyValue is an instance of DomainObjectInterface.

Resolves: #86252
Related: #86083
Releases: master
Change-Id: I3b916f6b3a416de6cd120bd1ff0bf5cfd0926445
Reviewed-on: https://review.typo3.org/58345
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Streamline $TSFE->simUserGroup usages 42/58342/3
Benni Mack [Thu, 20 Sep 2018 06:27:14 +0000 (08:27 +0200)]
[TASK] Streamline $TSFE->simUserGroup usages

First, this patch streamlines some naming issue in $TSFE->applyPreviewSettings()
(introduced by myself).

On top, it sorts out the usages of $TSFE->simUserGroup within
EXT:adminpanel.

So far this patch is "just" cosmetics but allows to further
sort out "simUserGroup" in TYPO3 v10.0.

Resolves: #86322
Releases: master
Change-Id: I5fabb90f36b83e206b390e5c7b1a7191461f85fe
Reviewed-on: https://review.typo3.org/58342
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Remove superfluous indention level in site configuration yaml 41/58341/3
Susanne Moog [Wed, 19 Sep 2018 21:02:09 +0000 (23:02 +0200)]
[TASK] Remove superfluous indention level in site configuration yaml

The site configuration is in folder "sites" in a file called config and
does not need a "site" key to identify its purpose. To keep writing the
config as easy as possible the site configuration moved one level up and
now resides directly in config.yaml.

Additionally on writing top level keys that are not written by the GUI
will be kept, so extension authors can add additional configuration to
the site object without needing to configure the GUI (as that is hardly
extensible in the current state). Array keys // top level objects that
are configurable via GUI are however overwritten completely.

Resolves: #86323
Releases: master
Change-Id: I6100dbf53b0953e593a6156837de1fe013a74fae
Reviewed-on: https://review.typo3.org/58341
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] SiteResolver middleware must not care for non int id parameters 37/58337/7
Anja [Wed, 19 Sep 2018 12:50:56 +0000 (14:50 +0200)]
[BUGFIX] SiteResolver middleware must not care for non int id parameters

The FileList module uses the 'id' parameter to pass the directory around,
which makes the parameter a string in this case.
Site Resolver Middleware will no longer care for a parameter named 'id',
which is not strictly an integer.

Change-Id: Ib780ed4e27b78e8f8594ab8b4a6c31f90737a715
Resolves: #86153
Releases: master
Reviewed-on: https://review.typo3.org/58337
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[FEATURE] Add support for the "canonical" tag 71/58271/16
Kevin Appelt [Thu, 13 Sep 2018 20:58:47 +0000 (22:58 +0200)]
[FEATURE] Add support for the "canonical" tag

TYPO3 will now out-of-the box create the canonical tag if you have
installed the core extension SEO. The canonical tag is based on the
settings in the page properties. First it will check if you defined
a canonical link. If not, it will check for the Show content from page
and if both are not set, it will generate an absolute url to the
current page.

Resolves: #20051
Releases: master
Change-Id: I1ae01e419a1f822b8659bf71ba99523051a2e77c
Reviewed-on: https://review.typo3.org/58271
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[BUGFIX] Replace middlewares in stack on duplicate occurence 40/58340/4
Susanne Moog [Wed, 19 Sep 2018 14:39:12 +0000 (16:39 +0200)]
[BUGFIX] Replace middlewares in stack on duplicate occurence

Use array_replace_recursive instead of array_merge_recursive to
avoid an exception if a middleware is defined twice.

Additionally move the replacement out of the loop.

Resolves: #86319
Releases: master
Change-Id: Ie59fe1d54b9498475c630fd0043b0b5d193b608c
Reviewed-on: https://review.typo3.org/58340
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Mark internal $TSFE properties as protected 09/58309/3
Benni Mack [Tue, 18 Sep 2018 04:42:45 +0000 (06:42 +0200)]
[TASK] Mark internal $TSFE properties as protected

Due to some PHP4 legacy code, most properties in TSFE
were Public API. As some arguments are only used internally
within TSFE and _should_ only used internally, their
visibility has been modified to be protected, and the properties
themselves have also an additional @internal annotation.

For v9, accessing the properties from the outside will still
work but trigger a deprecation message.

Resolves: #86320
Releases: master
Change-Id: Idb15078c41b2128631e75f594e3aa1f0ca85f7ec
Reviewed-on: https://review.typo3.org/58309
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Init simulate usergroup correctly in admin panel 30/58330/3
Frank Naegler [Wed, 19 Sep 2018 09:01:10 +0000 (11:01 +0200)]
[BUGFIX] Init simulate usergroup correctly in admin panel

The PreviewModule must be run before initializeFrontendPreview is called,
to ensure the settings from adminpanel are available if the init preview happens.

Resolves: #84198
Releases: master
Change-Id: I74366e652b9195e46aaaa724f2de343b125343ed
Reviewed-on: https://review.typo3.org/58330
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Limit number of items per XML sitemap 27/58227/16
Richard Haeser [Sat, 8 Sep 2018 11:45:05 +0000 (13:45 +0200)]
[TASK] Limit number of items per XML sitemap

Sitemaps of pages are now by default limited to 1000 pages per sitemap
to avoid exceeding Google limits. It will generate multiple (paginated)
sitemaps if the number of items exceeds the number of items per sitemap.

Resolves: #86169
Releases: master
Change-Id: I006656239aa05632b1f58a2286475fcba0295b9b
Reviewed-on: https://review.typo3.org/58227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[BUGFIX] Cache generated meta tags 61/58261/9
Richard Haeser [Wed, 12 Sep 2018 19:17:44 +0000 (21:17 +0200)]
[BUGFIX] Cache generated meta tags

Cache generated meta tags to prevent losing meta tags when a
non-cached content element is on the page.

Resolves: #86234
Releases: master
Change-Id: I6d48feee40716fb07c694b787a329940d2740ad6
Reviewed-on: https://review.typo3.org/58261
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[BUGFIX] Add stdWrap for SVG content object renderMode=inline 19/58319/3
Josef Glatz [Tue, 18 Sep 2018 16:59:04 +0000 (18:59 +0200)]
[BUGFIX] Add stdWrap for SVG content object renderMode=inline

This patch adds stdWrap to the SVG content object if the
renderMode is set to inline.

This patch also adds the missing tsref configuration for the
EXT:t3editor auto completion.

Releases: master
Resolves: #86299
Change-Id: Ib812569ad9b06d19cddf181808799223d1126632
Reviewed-on: https://review.typo3.org/58319
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Thorsten Griebenow <tgr@starfinanz.de>
Reviewed-by: Marco Bresch <marco.bresch@starfinanz.de>
Tested-by: Marco Bresch <marco.bresch@starfinanz.de>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Streamline EM dependency resolving 23/58323/3
Josef Glatz [Tue, 18 Sep 2018 20:50:20 +0000 (22:50 +0200)]
[TASK] Streamline EM dependency resolving

Adjust the style of the action accordingly and
add a small description to the main header.

Resolves: #86304
Releases: master, 8.7
Change-Id: I37a199d0a9626d4c87354ada7bce662bb089418f
Reviewed-on: https://review.typo3.org/58323
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Remove unused reconstitutedEntitiesData from extbase Session 31/58331/3
Łukasz Uznański [Wed, 19 Sep 2018 09:27:22 +0000 (11:27 +0200)]
[TASK] Remove unused reconstitutedEntitiesData from extbase Session

This property is not used

Releases: master
Resolves: #86309
Change-Id: I38cba224bd765304040a6dfaea4546361fe8ecc1
Reviewed-on: https://review.typo3.org/58331
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Streamline paste modal color schema 34/58334/2
Josef Glatz [Wed, 19 Sep 2018 12:16:52 +0000 (14:16 +0200)]
[BUGFIX] Streamline paste modal color schema

This patch calls the paste modal with the severity level "warning"
to improve the UX between the page and the list backend module
while pasting e.g. a content element record.

Releases: master
Resolves: #86316
Change-Id: I7f58a3b6e3c5d87fc91b6a4d61457d32e125f118
Reviewed-on: https://review.typo3.org/58334
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[BUGFIX] Chunk requests in documentation viewer to improve performance 99/58299/11
Andreas Fernandez [Mon, 17 Sep 2018 04:54:39 +0000 (06:54 +0200)]
[BUGFIX] Chunk requests in documentation viewer to improve performance

Improve performance of „View Upgrade Documentation“ module by reading
changelogs in chunks.

At first, all available versions are loaded. After that, all files are
loaded chunked by their respective version.

Resolves: #86281
Releases: master
Change-Id: I4c07842d9389028c1899022721f66b866fb81919
Reviewed-on: https://review.typo3.org/58299
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Fetch configuration of FlexForm fields in edit wizard 93/56493/8
Christian Kuhn [Wed, 19 Sep 2018 11:37:49 +0000 (13:37 +0200)]
[BUGFIX] Fetch configuration of FlexForm fields in edit wizard

Supply flex data structure identifier and current path to
editPopup field control to fetch correct TCA config if this
wizard is enabled for select or group fields in flex forms.

Resolves: #78422
Releases: master, 8.7
Change-Id: Ic628824abb36e23935ad9b493a2e401fe8e734c7
Reviewed-on: https://review.typo3.org/56493
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Handle formEngine add wizard select in flex forms 32/58332/2
Christian Kuhn [Wed, 19 Sep 2018 10:27:58 +0000 (12:27 +0200)]
[BUGFIX] Handle formEngine add wizard select in flex forms

addRecord fieldControl fails for type=select fields
in flex forms in AddController since existing values
are not resolved to an array structure as it is done
for type=group fields. Handle that case.

Resolves: #86313
Related: #82049
Releases: master, 8.7
Change-Id: I59e6cb1c11adf1ac7ebaf0293daad24aa1fd01b4
Reviewed-on: https://review.typo3.org/58332
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Harden system maintainer handling 14/58314/6
Christian Kuhn [Tue, 18 Sep 2018 13:13:35 +0000 (15:13 +0200)]
[TASK] Harden system maintainer handling

Better information handling and restrictions for non
system maintainer trying to change admin flag or password
of system maintainers.

Resolves: #86297
Releases: master
Change-Id: I1849c6ed7edfb78327b4802f4bc9b20f1fd701aa
Reviewed-on: https://review.typo3.org/58314
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Use module state of reports module 36/58336/2
Christian Kuhn [Wed, 19 Sep 2018 12:42:50 +0000 (14:42 +0200)]
[BUGFIX] Use module state of reports module

The reports module stores its latest action selection in
backend user uc and should select that action on next
call again. This broke with the refactoring of #84231

Resolves: #86318
Related: #84231
Releases: master
Change-Id: If3cfe27361bcdc7b15c2f1cfaa34a8cc0c1e88c9
Reviewed-on: https://review.typo3.org/58336
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Improve UI of „Upgrade Wizard“ 94/58294/5
Andreas Fernandez [Sun, 16 Sep 2018 15:54:20 +0000 (17:54 +0200)]
[TASK] Improve UI of „Upgrade Wizard“

Loading the list of available upgrade wizards may take some time. To give
a hint what is currently done, the progress bar now shows a text that
describes the currently processed step. On initial load, the progress
bar of the "done" wizards is rendered as well.

When a upgrade wizard is about to get executed, the viewport scrolls to
the correct position now to attract attention.

Resolves: #86278
Releases: master
Change-Id: Ie9c7d4cdf7e125374f8560fca559e7821b204110
Reviewed-on: https://review.typo3.org/58294
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Migrate upgrade wizards in install extension 93/58293/8
Christian Kuhn [Sun, 16 Sep 2018 13:06:09 +0000 (15:06 +0200)]
[TASK] Migrate upgrade wizards in install extension

Resolves: #86201
Related: #86172
Releases: master
Change-Id: I9d38ca04ee8a71ff6ffa325a2f0ce2c8c6cde183
Reviewed-on: https://review.typo3.org/58293
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Use passed severity for modal construction 33/58333/2
Andreas Fernandez [Wed, 19 Sep 2018 11:50:36 +0000 (13:50 +0200)]
[BUGFIX] Use passed severity for modal construction

The `severity` parameter must be passed to `advanced()` to have a proper
styling of the modal header.

Resolves: #86315
Related: #82596
Releases: master
Change-Id: I8904700198fd2ac6d5a0ac7817c3232cc84da4d1
Reviewed-on: https://review.typo3.org/58333
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Add correct moment-timezone file 25/58325/5
Josef Glatz [Tue, 18 Sep 2018 21:43:20 +0000 (23:43 +0200)]
[BUGFIX] Add correct moment-timezone file

This patch adds the correct moment-timezone javascript
file v0.5.20 which did not make it with the former patch
for #85223.

The following command was used:
- yarn upgrade moment-timezone@0.5.20

Releases: master
Resolves: #86306
Related: #85223
Change-Id: Ifc23c4e3d94d308370a7bd9a8071b2a06592047f
Reviewed-on: https://review.typo3.org/58325
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months agoRevert "[TASK] Improve TranslateViewHelper compiling" 22/58322/2
Christian Kuhn [Tue, 18 Sep 2018 19:57:30 +0000 (21:57 +0200)]
Revert "[TASK] Improve TranslateViewHelper compiling"

The micro optimization introduced a bug, fixing the bug
would basically lead to the same code that is within
renderStatic() already. There is then no advantage in
having an inline compiled solution in comparison to a
static call to the class anymore. The initial patch and
its follow up are reverted.

This reverts commit e6f470ebd2ddac7f0c864fd7c18c3d12a9009c30.
This reverts commit 852ad1d9ad6f3bac4c977d2466d1875f9e632e01.

Resolves: #86292
Reverts: #82454
Releases: master
Change-Id: I573a4298b0b9aedf83d51416919204bf910ae4bf
Reviewed-on: https://review.typo3.org/58322
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
7 months ago[TASK] Ignore every .log file to simplify core development 21/58321/3
Josef Glatz [Tue, 18 Sep 2018 19:14:55 +0000 (21:14 +0200)]
[TASK] Ignore every .log file to simplify core development

This patch adds .log files to .gitignore.

Releases: master
Resolves: #86302
Change-Id: If19c37208fb6d2d7004a03daca8d58821f2fae42
Reviewed-on: https://review.typo3.org/58321
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Check $prefix in ActionTask 20/58320/2
Andreas Fernandez [Tue, 18 Sep 2018 18:43:33 +0000 (20:43 +0200)]
[BUGFIX] Check $prefix in ActionTask

Check if the prefix is not an empty string to avoid a warning thrown by
strpos().

Resolves: #86300
Related: #85477
Releases: master
Change-Id: I68a1fc83745594524c088600258c2925eccf3015
Reviewed-on: https://review.typo3.org/58320
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Deprecate FrontendBackendUserAuthentication methods 05/58305/3
Benni Mack [Mon, 17 Sep 2018 14:33:01 +0000 (16:33 +0200)]
[TASK] Deprecate FrontendBackendUserAuthentication methods

The last methods within FrontendBackendUser (BE_USER in FE mode)
are now deprecated in favor of Admin Panel and middlewares:
- checkBackendAccessSettingsFromInitPhp()
- extPageReadAccess()
- extGetTreeList()
- extGetLL()

Resolves: #86288
Releases: master
Change-Id: I6752589a4b7a5353ae1699f3786be743c6f1f13d
Reviewed-on: https://review.typo3.org/58305
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Execute TCA group data provider after columns override 26/53526/4
Sascha Egerer [Sat, 15 Jul 2017 17:19:15 +0000 (19:19 +0200)]
[BUGFIX] Execute TCA group data provider after columns override

The TCA group dataprovider is currently executet very early and before
the ColumnsOverride dataprovider. Because of that it is not possible
to override settings of a tca field of type group. The DataProviders
have been reorderd so that the GroupDataProvider is executed at a later point.

Resolves: #81618
Releases: master
Change-Id: Ic6f9e860b8a7abd5dd1e483dcb35c15f7b8e5ecf
Reviewed-on: https://review.typo3.org/53526
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[TASK] Suppress mount point resolving if there are none 90/58290/4
Christian Kuhn [Sun, 16 Sep 2018 08:03:31 +0000 (10:03 +0200)]
[TASK] Suppress mount point resolving if there are none

BE admins without mountpoints set have value '0' in
$this->groupData['webmounts']. If this is checked additonally
to empty string, some 'where uid=0' database calls can be suppressed.

Resolves: #86272
Releases: master
Change-Id: I4142034c3d3fac3c9319649fd39200da7955a8db
Reviewed-on: https://review.typo3.org/58290
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[DOCS] Explain that L10n signal/slot is not affected 13/58313/4
Xavier Perseguers [Tue, 18 Sep 2018 12:36:11 +0000 (14:36 +0200)]
[DOCS] Explain that L10n signal/slot is not affected

The breaking change documentation is adapted to explicitly mention that
the signal/slot registration is kept untouched.

This will prevent confusion for developers reading the list of breaking changes.

Related: #50467
Related: #62983
Related: #84131
Related: #84691
Releases: master
Change-Id: I43ff5a6882e84c29844495fa9f10e6a35f07b1ff
Reviewed-on: https://review.typo3.org/58313
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[BUGFIX] Add more migration hints for config.tx_extbase.objects 10/58310/5
Benjamin Franzke [Tue, 18 Sep 2018 06:55:41 +0000 (08:55 +0200)]
[BUGFIX] Add more migration hints for config.tx_extbase.objects

The suggested migration (xclasses) does not work for Models
mapped using the PropertyMapper.
It also fails if additional injections have been configured.
(though that could be fixed using
`GeneralUtility::makeInstance(ObjectManager::class)->get()`)

Change-Id: If22b98526fce575435662e731a4f2efca9a014f3
Releases: master
Resolves: #86290
Related: #86270
Reviewed-on: https://review.typo3.org/58310
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
7 months ago[BUGFIX] Do not mark wizards implementing RepeatableInterface done 01/58301/3
Christian Kuhn [Mon, 17 Sep 2018 11:03:05 +0000 (13:03 +0200)]
[BUGFIX] Do not mark wizards implementing RepeatableInterface done

Resolves: #86283
Releases: master
Change-Id: Id2fad147fd081e86ecb1b40e0b407b17f60c74d8
Reviewed-on: https://review.typo3.org/58301
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Add missing language file for ContextMenu 86/58186/3
Stefan Froemken [Tue, 4 Sep 2018 15:01:29 +0000 (17:01 +0200)]
[BUGFIX] Add missing language file for ContextMenu

Confirmation Modal shows buttons with translated button labels now, if
you try to delete a page from page-tree.

Resolves: #79879
Releases: master, 8.7
Change-Id: Iff2ed8205bdcc54b48ba301035cd0aac9c2de826
Reviewed-on: https://review.typo3.org/58186
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Fix casting in GalleryProcessing data processor 12/58312/3
Thomas [Tue, 18 Sep 2018 09:41:29 +0000 (11:41 +0200)]
[BUGFIX] Fix casting in GalleryProcessing data processor

Removing the integer casting, so that the cropVariant can also be a string identifier.

Resolves: #86294
Releases: master, 8.7
Change-Id: Id4a80a7b879ddb8539e8cf4b47eeff1fc111029e
Reviewed-on: https://review.typo3.org/58312
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[TASK] Migrate form upgrade wizard to new API 08/58308/4
Susanne Moog [Mon, 17 Sep 2018 18:59:47 +0000 (20:59 +0200)]
[TASK] Migrate form upgrade wizard to new API

Resolves: #86275
Releases: master
Change-Id: I767f02c75b5f505e9b7ec78e933513d427dba2ae
Reviewed-on: https://review.typo3.org/58308
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
7 months ago[BUGFIX] Don’t do greedy merges in extension scanner 02/58302/2
Andreas Fernandez [Mon, 17 Sep 2018 11:04:55 +0000 (13:04 +0200)]
[BUGFIX] Don’t do greedy merges in extension scanner

The extension scanner merges all matches into an array. This is done in a
loop, which is pretty greedy as it impacts CPU and RAM.

Instead, it's possible to do a single array_merge() at the end of the
loop.

See this document for reference:
https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop

Resolves: #86282
Releases: master
Change-Id: I09b45468dfd9f60ce6bd9e264ecfc3cbfcb54fa1
Reviewed-on: https://review.typo3.org/58302
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[TASK] Simplify PackageManager caching 82/58282/4
Benjamin Franzke [Sat, 15 Sep 2018 07:31:32 +0000 (09:31 +0200)]
[TASK] Simplify PackageManager caching

We do not want to pollute $GLOBALS to be able to inject PackageManager
as $GLOBALS['TYPO3_currentPackageManager']. to cache-restored Package
objects (during unserialize).
Therefore this patch drops the PackageManager dependency from the Package
class.

The global injected PackageManager was used to calculate the
package metadata on demand. Package metadata is a small array
that doesn't harm to be created during Package object construction,
(it's cached afterwards anyway).
This allows us to drop the PackageManager reference, which
simplifies serialize/unserialize logic (we can drop __sleep and __wakeup).

We also combine the PackageManger and PackageObjects cache
into one cache file instead of two. There is no advantage
in having to read two files from the filesystem. The prior argument
(introduced with the initial PackageManager patch in 2013) "so PHP does
not have to parse the serialized string" is actually invalid:
The serialized string has to be parsed anyway.
PHP did not need to parse the var_export'd variant, true.
BUT: The var_export'd variant is theoretically php opcache'able, while
reading a file and passing the file contents to serialize() is not.
That means the previous solution actually hampered native optimizations.

Ideally we could drop the serialize/unserialize thing and just use
var_export for Package objects, but for that to work the Package class
(and all of it's properties) would need to implement the magic
__set_state() method (which is used by var_export to create objects).
That's currently not possible, because the composerManifest (which
is read from json_decode) is a stdClass and does not provide a
__set_state() method. We'd need to rewrite all that code to an array
or so. Maybe something for a later patch.

As a drive-by fix we now hash the TYPO3_version value into the
cacheEntryIdentifier like other core caches do.

Change-Id: I764dc92c64165ede24c8020c44cd2360b3faa00c
Releases: master
Resolves: #86261
Reviewed-on: https://review.typo3.org/58282
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
7 months ago[BUGFIX] Omit checkbox for unselectable tree items 63/58263/3
Sebastian Michaelsen [Thu, 13 Sep 2018 09:49:42 +0000 (11:49 +0200)]
[BUGFIX] Omit checkbox for unselectable tree items

TCA select fields with renderType = 'selectTree' have the option
treeConfig.appearance.nonSelectableLevels, which doesn't seem
to work anymore since TYPO3 v7. The items are correctly flagged
with node.selectable = false in PHP but the JavaScript doesn't
check for that property.

Resolves: #84708
Releases: master, 8.7
Change-Id: Iefe98e1c9fd316f05c27ad1230d63236a7069bf1
Reviewed-on: https://review.typo3.org/58263
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>