Packages/TYPO3.CMS.git
8 months ago[DOCS] Explain that L10n signal/slot is not affected 13/58313/4
Xavier Perseguers [Tue, 18 Sep 2018 12:36:11 +0000 (14:36 +0200)]
[DOCS] Explain that L10n signal/slot is not affected

The breaking change documentation is adapted to explicitly mention that
the signal/slot registration is kept untouched.

This will prevent confusion for developers reading the list of breaking changes.

Related: #50467
Related: #62983
Related: #84131
Related: #84691
Releases: master
Change-Id: I43ff5a6882e84c29844495fa9f10e6a35f07b1ff
Reviewed-on: https://review.typo3.org/58313
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Add more migration hints for config.tx_extbase.objects 10/58310/5
Benjamin Franzke [Tue, 18 Sep 2018 06:55:41 +0000 (08:55 +0200)]
[BUGFIX] Add more migration hints for config.tx_extbase.objects

The suggested migration (xclasses) does not work for Models
mapped using the PropertyMapper.
It also fails if additional injections have been configured.
(though that could be fixed using
`GeneralUtility::makeInstance(ObjectManager::class)->get()`)

Change-Id: If22b98526fce575435662e731a4f2efca9a014f3
Releases: master
Resolves: #86290
Related: #86270
Reviewed-on: https://review.typo3.org/58310
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Do not mark wizards implementing RepeatableInterface done 01/58301/3
Christian Kuhn [Mon, 17 Sep 2018 11:03:05 +0000 (13:03 +0200)]
[BUGFIX] Do not mark wizards implementing RepeatableInterface done

Resolves: #86283
Releases: master
Change-Id: Id2fad147fd081e86ecb1b40e0b407b17f60c74d8
Reviewed-on: https://review.typo3.org/58301
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Add missing language file for ContextMenu 86/58186/3
Stefan Froemken [Tue, 4 Sep 2018 15:01:29 +0000 (17:01 +0200)]
[BUGFIX] Add missing language file for ContextMenu

Confirmation Modal shows buttons with translated button labels now, if
you try to delete a page from page-tree.

Resolves: #79879
Releases: master, 8.7
Change-Id: Iff2ed8205bdcc54b48ba301035cd0aac9c2de826
Reviewed-on: https://review.typo3.org/58186
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Fix casting in GalleryProcessing data processor 12/58312/3
Thomas [Tue, 18 Sep 2018 09:41:29 +0000 (11:41 +0200)]
[BUGFIX] Fix casting in GalleryProcessing data processor

Removing the integer casting, so that the cropVariant can also be a string identifier.

Resolves: #86294
Releases: master, 8.7
Change-Id: Id4a80a7b879ddb8539e8cf4b47eeff1fc111029e
Reviewed-on: https://review.typo3.org/58312
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Migrate form upgrade wizard to new API 08/58308/4
Susanne Moog [Mon, 17 Sep 2018 18:59:47 +0000 (20:59 +0200)]
[TASK] Migrate form upgrade wizard to new API

Resolves: #86275
Releases: master
Change-Id: I767f02c75b5f505e9b7ec78e933513d427dba2ae
Reviewed-on: https://review.typo3.org/58308
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Don’t do greedy merges in extension scanner 02/58302/2
Andreas Fernandez [Mon, 17 Sep 2018 11:04:55 +0000 (13:04 +0200)]
[BUGFIX] Don’t do greedy merges in extension scanner

The extension scanner merges all matches into an array. This is done in a
loop, which is pretty greedy as it impacts CPU and RAM.

Instead, it's possible to do a single array_merge() at the end of the
loop.

See this document for reference:
https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop

Resolves: #86282
Releases: master
Change-Id: I09b45468dfd9f60ce6bd9e264ecfc3cbfcb54fa1
Reviewed-on: https://review.typo3.org/58302
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[TASK] Simplify PackageManager caching 82/58282/4
Benjamin Franzke [Sat, 15 Sep 2018 07:31:32 +0000 (09:31 +0200)]
[TASK] Simplify PackageManager caching

We do not want to pollute $GLOBALS to be able to inject PackageManager
as $GLOBALS['TYPO3_currentPackageManager']. to cache-restored Package
objects (during unserialize).
Therefore this patch drops the PackageManager dependency from the Package
class.

The global injected PackageManager was used to calculate the
package metadata on demand. Package metadata is a small array
that doesn't harm to be created during Package object construction,
(it's cached afterwards anyway).
This allows us to drop the PackageManager reference, which
simplifies serialize/unserialize logic (we can drop __sleep and __wakeup).

We also combine the PackageManger and PackageObjects cache
into one cache file instead of two. There is no advantage
in having to read two files from the filesystem. The prior argument
(introduced with the initial PackageManager patch in 2013) "so PHP does
not have to parse the serialized string" is actually invalid:
The serialized string has to be parsed anyway.
PHP did not need to parse the var_export'd variant, true.
BUT: The var_export'd variant is theoretically php opcache'able, while
reading a file and passing the file contents to serialize() is not.
That means the previous solution actually hampered native optimizations.

Ideally we could drop the serialize/unserialize thing and just use
var_export for Package objects, but for that to work the Package class
(and all of it's properties) would need to implement the magic
__set_state() method (which is used by var_export to create objects).
That's currently not possible, because the composerManifest (which
is read from json_decode) is a stdClass and does not provide a
__set_state() method. We'd need to rewrite all that code to an array
or so. Maybe something for a later patch.

As a drive-by fix we now hash the TYPO3_version value into the
cacheEntryIdentifier like other core caches do.

Change-Id: I764dc92c64165ede24c8020c44cd2360b3faa00c
Releases: master
Resolves: #86261
Reviewed-on: https://review.typo3.org/58282
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Omit checkbox for unselectable tree items 63/58263/3
Sebastian Michaelsen [Thu, 13 Sep 2018 09:49:42 +0000 (11:49 +0200)]
[BUGFIX] Omit checkbox for unselectable tree items

TCA select fields with renderType = 'selectTree' have the option
treeConfig.appearance.nonSelectableLevels, which doesn't seem
to work anymore since TYPO3 v7. The items are correctly flagged
with node.selectable = false in PHP but the JavaScript doesn't
check for that property.

Resolves: #84708
Releases: master, 8.7
Change-Id: Iefe98e1c9fd316f05c27ad1230d63236a7069bf1
Reviewed-on: https://review.typo3.org/58263
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Trigger deprecation when using $TSFE->sys_language_* 03/58303/4
Benni Mack [Mon, 17 Sep 2018 12:11:32 +0000 (14:11 +0200)]
[BUGFIX] Trigger deprecation when using $TSFE->sys_language_*

When deprecating TSFE->sys_language_mode and TSFE->sys_language_uid
it was forgotten (by myself) to set the visibility to protected.

This way, the deprecation layer (with compat calls) is never
used, and legacy code gets wrong results.

Resolves: #86285
Related: #85543
Releases: master
Change-Id: I2d809b577e5265054f2f54d54ecfbb8e441b6bdc
Reviewed-on: https://review.typo3.org/58303
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Deprecate config.tx_extbase.objects and plugin.tx_%name%.objects 88/58288/5
Benjamin Franzke [Sun, 16 Sep 2018 05:01:31 +0000 (07:01 +0200)]
[TASK] Deprecate config.tx_extbase.objects and plugin.tx_%name%.objects

If we want to introduce a system wide container in v10,
the non deterministic behaviour of object (re)configurations
during runtime in extbase will be a problem.
Compiled containers like symfony DI do not allow runtime
reconfigurations.

Also the concept of per plugin overwrites is broken anyway,
and should therefore be dropped:
The "objects" configured through plugin.tx_%name%.objects
are are never reset, that means:
Plugin A might overwrite an object and plugin B will implictly use
that overriden class, despite not having configured that at all.
(depending on the fact whether plugin A is rendered before or not)

config.tx_extbase.object class overwrites can be replaced by XCLASSes.
If config.tx_extbase.object was/is used to conditionally overwrite
classes (through sys_template or conditions), these
occasions should be changed to XCLASSes as well. In that case the
conditional overwrite needs to be moved into the xclass itself.

Change-Id: I2ef839bcbb7f941c3afa0010767560d20e15f98b
Releases: master
Resolves: #86270
Reviewed-on: https://review.typo3.org/58288
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Streamline hooks and middlewares related to PSR-15 53/58253/6
Benni Mack [Wed, 12 Sep 2018 06:53:02 +0000 (08:53 +0200)]
[TASK] Streamline hooks and middlewares related to PSR-15

With PSR-15 it is not necessary to use any custom hooks during
the frontend request setup process anymore, as middlewares
are flexible enough to manipulate anything people want to do.

On top, various middlewares are also declared internal as
the usages are not really necessary to be publically exposed.
- typo3/cms-core/normalized-params-attribute
- typo3/cms-backend/legacy-document-template
- typo3/cms-backend/output-compression
- typo3/cms-backend/response-headers
- typo3/cms-frontend/timetracker
- typo3/cms-frontend/preprocessing
- typo3/cms-frontend/eid
- typo3/cms-frontend/content-length-headers
- typo3/cms-frontend/tsfe
- typo3/cms-frontend/output-compression
- typo3/cms-frontend/prepare-tsfe-rendering
- typo3/cms-frontend/shortcut-and-mountpoint-redirect

Resolves: #86279
Releases: master
Change-Id: I14fbd7b026acdc84fb23ca43cd395de5b7b9c4b6
Reviewed-on: https://review.typo3.org/58253
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Change visibility of TSFE properties and methods 83/58083/8
Benni Mack [Thu, 30 Aug 2018 10:55:12 +0000 (12:55 +0200)]
[TASK] Change visibility of TSFE properties and methods

The following properties have changed their
visibility to be protected from public.

* pageAccessFailureHistory
* workspacePreview (not in use anymore)
* ADMCMD_preview_BEUSER_uid (not in use anymore)
* debug (not in use anymore)
* MP_defaults (not in use anymore outside of TSFE)
* loginAllowedInBranch (use checkIfLoginAllowedInBranch())

The following methods have changed their signature to be
protected, as their purpose is to be called from within
TypoScriptFrontendController.

- tempPageCacheContent()
- realPageCacheContent()
- setPageCacheContent()
- clearPageCacheContent_pidList()
- setSysLastChanged()
- contentStrReplace()

Resolves: #86047
Releases: master
Change-Id: I98f54f4a75023b963b69c12457b73e5117469497
Reviewed-on: https://review.typo3.org/58083
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Destroy install tool session on backend user logout 97/58297/6
Christian Kuhn [Sun, 16 Sep 2018 19:05:26 +0000 (21:05 +0200)]
[TASK] Destroy install tool session on backend user logout

If a system maintainer used the install tool from within the
backend, the session is now destroyed on logout explicitely.

Resolves: #86249
Resolves: #85404
Releases: master
Change-Id: I6bf4f2a724ec85b60854e8f92c00a10e7614f140
Reviewed-on: https://review.typo3.org/58297
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Make hreflang generator use PSR7 interface 74/58274/7
Richard Haeser [Fri, 14 Sep 2018 09:28:09 +0000 (11:28 +0200)]
[TASK] Make hreflang generator use PSR7 interface

Use the Uri class to check if a host is given in the url
to determine if an absolute url should be generated.

Resolves: #86253
Releases: master
Change-Id: Ib84d391b0564f29352eda93a814f5d9b46696f37
Reviewed-on: https://review.typo3.org/58274
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Suppress avatar file resolving if there is none 91/58291/3
Christian Kuhn [Sun, 16 Sep 2018 08:16:15 +0000 (10:16 +0200)]
[TASK] Suppress avatar file resolving if there is none

Suppress a where uid=0 call on sys_file table if the
backend user has not avatar assigned.

Resolves: #86273
Releases: master
Change-Id: Id67e80dbb906ce27af3954f9c20ee49a5c7050ee
Reviewed-on: https://review.typo3.org/58291
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Suppress db call for rootline with uid 0 89/58289/7
Christian Kuhn [Sun, 16 Sep 2018 07:38:20 +0000 (09:38 +0200)]
[TASK] Suppress db call for rootline with uid 0

Page uid 0 has no rootline by definition. The patch adds an
early return to RootlineUtility to suppress some cache->get()
calls. This happens in BE quite often. Additionally, the
SiteFinder does not query RootlineUtility for page uid 0 at
all to save a series of instance creations.

Resolves: #86271
Releases: master
Change-Id: I63c819c6dcd5e5c7a0e226ae16b0ecd6cf391e30
Reviewed-on: https://review.typo3.org/58289
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Update wording in Core Upgrade dialog 92/58292/2
Michael Schams [Sun, 16 Sep 2018 08:47:48 +0000 (18:47 +1000)]
[BUGFIX] Update wording in Core Upgrade dialog

This change updates the text in the Core Upgrade dialog and fixes a
typo as well as introduces some basic styles.

Resolves: #86274
Releases: master
Change-Id: Ie6433a9fa3a5f8b8d1c808955872dda91d10788a
Reviewed-on: https://review.typo3.org/58292
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Fix fatal in SchedulerModuleController on some DB drivers 85/58285/4
Christian Kuhn [Sat, 15 Sep 2018 13:55:01 +0000 (15:55 +0200)]
[BUGFIX] Fix fatal in SchedulerModuleController on some DB drivers

Some DB drivers like pdo_mysql and our postgres flavor return
values from DB always as string. Classes with enabled strict_types
then tend to fail if those values that should be integers but are
strings are fed to functions that accept integers only. The patch
fixes two places in SchedulerModuleController where a db value
is directly sent to date(), which needs an int as second argument.

Resolves: #86263
Releases: master
Change-Id: I00ce0425774762fef235373f643f8b69bdd072bb
Reviewed-on: https://review.typo3.org/58285
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Provide loading indicator for Install Tool 81/58281/4
Markus Klein [Sat, 15 Sep 2018 08:26:27 +0000 (10:26 +0200)]
[TASK] Provide loading indicator for Install Tool

Resolves: #86259
Releases: master
Change-Id: I0a5c7020d879250cf38ca1975a8f63e65f1a0649
Reviewed-on: https://review.typo3.org/58281
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Migrate DatabaseRowsUpdateWizard to UpgradeWizardInterface 78/58278/2
Christian Kuhn [Fri, 14 Sep 2018 14:00:45 +0000 (16:00 +0200)]
[TASK] Migrate DatabaseRowsUpdateWizard to UpgradeWizardInterface

Resolves: #86200
Related: #86172
Releases: master
Change-Id: I9f6412ed7a6adb8b00f62cbca7476a49bed6985d
Reviewed-on: https://review.typo3.org/58278
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Prevent TypoScript condition expressions breaking TYPO3 80/58280/5
Frank Naegler [Fri, 14 Sep 2018 19:24:04 +0000 (21:24 +0200)]
[BUGFIX] Prevent TypoScript condition expressions breaking TYPO3

This patch introduces error handling to mitigate a missing type check
in the Symfony Expression Language handler. In case a condition
uses the "in" or "not in" check in combination with a non-array a PHP
warning is thrown.

Example: [1 in "foo"] or ["bar" in "foo,baz"]
These conditions are broken, but they will break the complete installation
including the backend. To mitigate the problem we do the following:

1) In FE an InvalidTypoScriptConditionException is thrown (if strictSyntax is enabled)
2) In FE catch this error silently and log it (if strictSyntax is disabled)
3) In BE catch this error silently and log it, but never break the backend.

Resolves: #86257
Releases: master
Change-Id: I2a54f819383775a300af6848cfc85e9f626bec21
Reviewed-on: https://review.typo3.org/58280
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Improve install tool temporary assets removal 37/57837/11
Christian Kuhn [Fri, 14 Sep 2018 21:01:16 +0000 (23:01 +0200)]
[BUGFIX] Improve install tool temporary assets removal

Maintenance > Remove temporary assets now properly lists
statistics for FAL processed files and allows to clear them.

Releases: master
Resolves: #83034
Change-Id: Ic9238c88648d98a76a0cbd4015820d51bffde0fa
Reviewed-on: https://review.typo3.org/57837
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[TASK] Improve .rst file formatting 79/58279/2
Christian Kuhn [Fri, 14 Sep 2018 17:51:06 +0000 (19:51 +0200)]
[TASK] Improve .rst file formatting

Resolves: #86256
Releases: master
Change-Id: I6b108342ebb7439657afec296c68de7ba45bf29e
Reviewed-on: https://review.typo3.org/58279
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Set BackendUserAspect earlier to make it usable in TSConfig 75/58275/3
Frank Naegler [Fri, 14 Sep 2018 11:01:41 +0000 (13:01 +0200)]
[BUGFIX] Set BackendUserAspect earlier to make it usable in TSConfig

This patch fix broken TSConfig condition because of missing backend user aspect.

Resolves: #86229
Releases: master
Change-Id: I6528b5d48a5b5711cad8710d4bfcc6222f9fef9c
Reviewed-on: https://review.typo3.org/58275
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Correct condition in TemplateService 77/58277/3
Christian Kuhn [Fri, 14 Sep 2018 12:22:38 +0000 (14:22 +0200)]
[BUGFIX] Correct condition in TemplateService

Issue #85092 introduced a copy & paste bug in TemplateService.

Resolves: #86255
Related: #85092
Releases: master
Change-Id: If0d92e0886e625db8793991f264628030ccfdad4
Reviewed-on: https://review.typo3.org/58277
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[TASK] Use SiteFinder in EXT:felogin 57/58257/5
Georg Ringer [Wed, 12 Sep 2018 18:06:46 +0000 (20:06 +0200)]
[TASK] Use SiteFinder in EXT:felogin

Instead of only checking the sys_domains with a database query
the SiteFinder and PseudoSiteFinder should be used.

Resolves: #86219
Releases: master
Change-Id: I99f9367258f9b19ef3a1310cb2fd61076083333c
Reviewed-on: https://review.typo3.org/58257
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
8 months ago[TASK] Migrate extension install upgrade wizards to new API 33/58233/4
Susanne Moog [Wed, 5 Sep 2018 21:22:34 +0000 (23:22 +0200)]
[TASK] Migrate extension install upgrade wizards to new API

Migrates all upgrade wizards based on the
`AbstractDownloadExtensionUpdate` class to the new API.

Related: #86172
Resolves: #86199
Releases: master
Change-Id: I79ffa702a1448bb66324074ef2debf41922d95e8
Reviewed-on: https://review.typo3.org/58233
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
8 months ago[BUGFIX] Make JavaScript of SlugElement a real independent instance 73/58273/4
Andreas Fernandez [Fri, 14 Sep 2018 08:17:23 +0000 (10:17 +0200)]
[BUGFIX] Make JavaScript of SlugElement a real independent instance

The JavaScript for the SlugElement is partially designed to be a
independent instance for each slug field. However, this does not work for
mass editing the slug fields, as the `initialize()` method is always
called on the same instance.

This patch does multiple things:

- The JavaScript is converted to a TypeScript basis, which allows better
  handling of each instance
- The "Regenerate slug" button is disabled in case the "feeder" fields
  are not available to avoid getting bogus values

Resolves: #86221
Releases: master
Change-Id: I458247beb597c77407e94ce633314ae2e2d7095a
Reviewed-on: https://review.typo3.org/58273
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
8 months ago[TASK] Make hreflang links absolute 62/58262/5
Richard Haeser [Wed, 12 Sep 2018 20:51:46 +0000 (22:51 +0200)]
[TASK] Make hreflang links absolute

Create absolute URL's for the hreflang links by using the configuration
of the current site.

Resolves: #86224
Releases: master
Change-Id: Id3196542875862b20145418956fcfdfcc3834241
Reviewed-on: https://review.typo3.org/58262
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[BUGFIX] Do not show wizards marked as done in install tool 70/58270/3
Susanne Moog [Thu, 13 Sep 2018 16:56:29 +0000 (18:56 +0200)]
[BUGFIX] Do not show wizards marked as done in install tool

Wizards marked as done are no longer displayed as executable
in the install tool, the missing state check has been included.

Resolves: #86246
Releases: master
Change-Id: Ic86910379f3bc2994f87a8408e81e32d5f28729a
Reviewed-on: https://review.typo3.org/58270
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Use correct language in l18n_cfg checks 67/58267/8
Daniel Goerz [Thu, 13 Sep 2018 13:12:25 +0000 (15:12 +0200)]
[BUGFIX] Use correct language in l18n_cfg checks

The check for pages.l18n_cfg is wrong now, as this is
always done against pages.sys_language_uid=0 records (as
"resolvePage" is called right before).

So, these if-statements have to go further south.

On top, the getPageOverlay call needs to be done - on top.

resolvePage -> get default language of page
getPageOverlay -> put the wanted translation on top

A fix for pages.alias has to be in place, as DataHandler
cannot handle pages.alias yet.

Resolves: #86242
Releases: master
Change-Id: Ief99e5f934f6e9d31973b9543cb9a6e599d2d33c
Reviewed-on: https://review.typo3.org/58267
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Use class name to mark upgrade wizards done 97/58197/4
Helmut Hummel [Thu, 6 Sep 2018 10:15:24 +0000 (12:15 +0200)]
[BUGFIX] Use class name to mark upgrade wizards done

To make the registry for done wizards consistent and stay backwards
compatible once all upgrade wizards are converted to use the
new interface, always store the class name of the wizard
instead of its identifier in the registry.

Additionally we now add checks for valid identifiers
to all API methods that receive one.

Releases: master
Resolves: #86165
Change-Id: I402852c90f5a8d3d0a05bacbd961a4bb4cb86d1e
Reviewed-on: https://review.typo3.org/58197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Adapt view related install tool details 69/58269/6
Christian Kuhn [Thu, 13 Sep 2018 14:35:42 +0000 (16:35 +0200)]
[BUGFIX] Adapt view related install tool details

With the install tool move to modals, various details on CSS
level broke: The modal HTML is on top level in backend and thus
not within the content-iframe, so styles defined in install.css
loaded in the iframe do not kick in. Since the standalone install
tool does not use iframes, there are various differences on view
level between standalone and embedded-in-backend version, usually
with the embedded version looking more ugly than standalone.

The install.css is not very different from backend.css anyway,
so we resolve various details with the patch, kick install.css
entirely and rely soley on backend.css, even for the installer.

Details:
* <hr> shows a border again in modals in embedded, broken since
  modal patch
* image processing view has borders and other details again in
  embedded verision, broken since modal patch
* removed 'fixed save button location' for 'all configuration' code.
  This broke with the modal patch, the code does not do anything
  useful at the moment. A solution needs a change of the modal js
  to render the buttons to modal-footer instead. This is too complex
  for this patch and may be done with another patch.
* A couple of classes to easily limit styles to installer and
  maintenance parts
* Remove left overs from old install-tool menu approach that
  have not been cleanup up, yet.

Resolves: #86245
Related: #84772
Releases: master
Change-Id: I4d21677331112a48f84b0cf48a574999128a15b7
Reviewed-on: https://review.typo3.org/58269
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Add postProcessMirrorUrl to language updater again 65/58265/2
Christian Kuhn [Thu, 13 Sep 2018 11:25:41 +0000 (13:25 +0200)]
[BUGFIX] Add postProcessMirrorUrl to language updater again

With moving the language pack updater to the install tool, a
signal got lost that allowed overriding the base download url
of language packs per extension.
The patch introduces this signal again.

Resolves: #84691
Related: #84131
Releases: master
Change-Id: I659a8829b292d9c268ee3ee9df851d971ba5ddd7
Reviewed-on: https://review.typo3.org/58265
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Delius <me@jandelius.eu>
Tested-by: Jan Delius <me@jandelius.eu>
Reviewed-by: Rico Drexler <rico.drexler@gmx.de>
Tested-by: Rico Drexler <rico.drexler@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Use SiteFinder for fetching related domain in page tree 93/58193/11
Georg Ringer [Wed, 5 Sep 2018 18:16:23 +0000 (20:16 +0200)]
[TASK] Use SiteFinder for fetching related domain in page tree

The SiteFinder retrieves the correct domain for root pages
also for pages having a site configuration.

Resolves: #86158
Releases: master
Change-Id: If99da2deea08ca7bbe05c13f37472a070ffc6d62
Reviewed-on: https://review.typo3.org/58193
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
8 months ago[BUGFIX] Evaluate config.defaultGetVars in middleware 66/58266/3
Benni Mack [Thu, 13 Sep 2018 11:41:29 +0000 (13:41 +0200)]
[BUGFIX] Evaluate config.defaultGetVars in middleware

The config.defaultGetVars is executed and $_GET is modified,
but not the middleware where this method is called.

In order to also modify the middleware's request object, the
option config.defaultGetVars is also evaluted again in the PSR-15
middleware.

Resolves: #86241
Related: #86046
Releases: master
Change-Id: I2238d93b4974a40b2228c099cef7c8a04bd6cf74
Reviewed-on: https://review.typo3.org/58266
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Allow recycler page in rootline in BE 43/58243/5
Susanne Moog [Wed, 12 Sep 2018 16:15:25 +0000 (18:15 +0200)]
[BUGFIX] Allow recycler page in rootline in BE

The recycler doktype should be allowed in rootline in BE.

Resolves: #86209
Releases: master
Change-Id: I173c2deca5cd395d566a6fd9d6499538ef20d2e6
Reviewed-on: https://review.typo3.org/58243
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Bring back the exception code in exception messages 60/58260/4
Anja Leichsenring [Wed, 12 Sep 2018 18:38:46 +0000 (20:38 +0200)]
[TASK] Bring back the exception code in exception messages

If an exception identifies itself with a code, display it
next to the Exception title.

Change-Id: Ib24b7ce4e0bef426dd4e0f4b7f25c4f5338e02c6
Resolves: #86238
Releases: master
Reviewed-on: https://review.typo3.org/58260
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Bring back the paths in exception messages 58/58258/6
Susanne Moog [Wed, 12 Sep 2018 18:14:19 +0000 (20:14 +0200)]
[TASK] Bring back the paths in exception messages

Resolves: #86237
Releases: master
Change-Id: Id139dcabb6367b03fb5584a6c7d4a673595eb88e
Reviewed-on: https://review.typo3.org/58258
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[BUGFIX] Fix undefined variable $applicationContext in Bootstrap.php 56/58256/2
Tymoteusz Motylewski [Wed, 12 Sep 2018 15:13:55 +0000 (17:13 +0200)]
[BUGFIX] Fix undefined variable $applicationContext in Bootstrap.php

Resolves: #86235
Releases: master
Change-Id: I1e75309abd8bc1aa38d861dae4a48a958b9750dd
Reviewed-on: https://review.typo3.org/58256
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Fix code formatting changelog rst files 54/58254/4
Tymoteusz Motylewski [Wed, 12 Sep 2018 11:32:55 +0000 (13:32 +0200)]
[TASK] Fix code formatting changelog rst files

Double backticks are now replace with single ones,
fixed some typos like missing colon.

Resolves: #86233
Releases: master
Change-Id: I5889a285a5b9a7d65b8bcf7931801298d539e9df
Reviewed-on: https://review.typo3.org/58254
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Deprecate BaseScriptClass and AbstractFunctionModule 49/58249/3
Christian Kuhn [Mon, 10 Sep 2018 21:48:19 +0000 (23:48 +0200)]
[TASK] Deprecate BaseScriptClass and AbstractFunctionModule

With latest refactorings, the good old backend module classes
BaseScriptClass (t3lib_SCbase) and AbstractFunctionModule
(t3lib_extobjbase) are finally unused.
These spaghetti classes have been a hindrance to refactor
modules that used them for a long time already due to their
hard to follow code flow, bad method namings, global variable
usages and having everything declared public.
It's time to get rid of them to unlock refactoring of controllers
and allow dropping of various global variables in v10.

Resolves: #86225
Releases: master
Change-Id: I3b5bb35b693c7991052f4e0855c2aae4e39f02a1
Reviewed-on: https://review.typo3.org/58249
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Deprecate @internal annotation in extbase commands 39/58039/7
Alexander Schnitzler [Sat, 25 Aug 2018 15:35:38 +0000 (17:35 +0200)]
[TASK] Deprecate @internal annotation in extbase commands

The @internal annotation – which is a regular phpDocumentor annotation
that is used to denote that associated structural elements are elements
internal to the application or library, has been misused by extbase to
tell if a command is internal and thus should not be exposed through
help texts, user documentation etc. – is deprecated without any
replacement.

TYPO3 does no longer support the use of the @internal annotation to
influence the behaviour of the code.

Releases: master
Resolves: #85980
Change-Id: I7f3b998b56e270b30e5193d494d35329f5608603
Reviewed-on: https://review.typo3.org/58039
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Catch non existing directories for import syntax 51/58251/2
Georg Ringer [Tue, 11 Sep 2018 17:27:05 +0000 (19:27 +0200)]
[BUGFIX] Catch non existing directories for import syntax

Catch exceptions for non existing directories which are imported using
the @import syntax for TypoScript and return those as warning in the
template module.

Resolves: #86230
Releases: master
Change-Id: Ie4a6376407eeeaa7a717cb01ede5cabefa8a443f
Reviewed-on: https://review.typo3.org/58251
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Add method getBase to SiteInterface 50/58250/2
Georg Ringer [Tue, 11 Sep 2018 05:53:06 +0000 (07:53 +0200)]
[TASK] Add method getBase to SiteInterface

Resolves: #86226
Releases: master
Change-Id: Idcffc65e6e040ab4f09e352f268aa4919c2abc59
Reviewed-on: https://review.typo3.org/58250
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Readd missing initialisation of $tsfe 52/58252/2
Georg Ringer [Tue, 11 Sep 2018 17:39:04 +0000 (19:39 +0200)]
[BUGFIX] Readd missing initialisation of $tsfe

During the refactoring of #85543 a line too much has been removed.
Readd the initialisation of $tsfe.

Resolves: #86223
Releases: master
Change-Id: Icd7bf93fe1d04e845b4a8cc497f171c7429d0d55
Reviewed-on: https://review.typo3.org/58252
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[FEATURE] Use utf8mb4 on mysql for new instances 40/56440/10
Lienhart Woitok [Fri, 23 Mar 2018 12:54:40 +0000 (13:54 +0100)]
[FEATURE] Use utf8mb4 on mysql for new instances

If installing a new TYPO3 instance on mysql, utf8mb4 is now used as
default charset for the database connection and as default collation.

Upgraders may change LocalConfiguration to use utf8mb4, too. They
however need to take care of changing their collations and setting
according table detaults on their own.

A reports status check verifies there is no mixed collation.

Resolves: #80398
Resolves: #82080
Resolves: #82551
Releases: master
Change-Id: I6bf464a22c6ed74631bf5aacff9c2cfe670077da
Reviewed-on: https://review.typo3.org/56440
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Lienhart Woitok <lienhart.woitok@netlogix.de>
Tested-by: Lienhart Woitok <lienhart.woitok@netlogix.de>
Reviewed-by: Georg Großberger <garfieldius67@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[TASK] Deprecate cObject FILE 28/58028/5
Benni Mack [Fri, 24 Aug 2018 16:14:04 +0000 (18:14 +0200)]
[TASK] Deprecate cObject FILE

The cObject FILE has a strange behaviour, and rather became low-level since
Fluid's rise in rendering Frontend.

FILE shows an image if the file is jpg,jpeg,gif,png (but not SVG), and if has a
different file ending, it will check if the file is less than 1MB, it will get its contents
and output that. If the file is 1 byte bigger, nothing is done.

This _magic_ is sketchy, and obsolete, as Fluid offers more flexibility nowadays.

Thus, cObject FILE will be removed from TYPO3 Core in v10.0, however due
to the flexibility of custom cObject, an extension author could just re-implement
the functionality in a custom extension within minutes.

Resolves: #85970
Releases: master
Change-Id: I792ec89486e29051da478c5ec0855d2f9cf913a1
Reviewed-on: https://review.typo3.org/58028
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Add functional tests for copying a record into another language 46/58246/7
Oliver Hader [Mon, 10 Sep 2018 14:40:21 +0000 (16:40 +0200)]
[TASK] Add functional tests for copying a record into another language

The expected behavior is that the copied record is not synchronized
when modifying the language parent record (since it is not in connected
mode).

Resolves: #86215
Releases: master, 8.7
Change-Id: Ibf58dd6daf877b172aea5c31ead8ea1277834bfc
Reviewed-on: https://review.typo3.org/58246
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Protect info extension 41/58241/2
Christian Kuhn [Sun, 9 Sep 2018 19:04:16 +0000 (21:04 +0200)]
[TASK] Protect info extension

Last patch in the protect controller patch series. This time the
Web->Info module controller no longer extends BaseScriptClass and
the single sub controller classed don't extend AbstractFunctionModule
anymore. The patch sets as much as possible to protected to allow
further refactoring of these classes in v10.

Resolves: #86210
Releases: master
Change-Id: I5c474e6cc0bc093c58b2e939e408b47020547a6b
Reviewed-on: https://review.typo3.org/58241
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Protect tstemplate extension 40/58240/2
Christian Kuhn [Sun, 9 Sep 2018 15:42:23 +0000 (17:42 +0200)]
[TASK] Protect tstemplate extension

The patch disentangles the tstemplate extension controller
classes. The main controller class no longer extends
BaseScriptClass and the sub controllers no longer extend
AbstractFunctionModule. The classes set as many properties
and methods to protected to allow further refactoring of this
module in v10.

Resolves: #86207
Releases: master
Change-Id: If9ad462a423be5f0e370e0894ebb848b822ee66b
Reviewed-on: https://review.typo3.org/58240
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Protect TaskModuleController Part 2 39/58239/3
Christian Kuhn [Sun, 9 Sep 2018 11:06:22 +0000 (13:06 +0200)]
[TASK] Protect TaskModuleController Part 2

TaskModuleController no longer extends BaseScriptClass. Properties
and methods are copied over to the controller and most of them are
set to protected. An instance of the controller class is given
to single class that fetch and set the one or the other information,
so not everything can be made protected. The patch should still
allow us to have more refactoring freedom in v10 in this area.

Resolves: #86204
Related: #86182
Releases: master
Change-Id: I171b22ddbcee67205234b6ca23acf9c95da6ac1b
Reviewed-on: https://review.typo3.org/58239
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Use 403 header instead of 401 header 99/57399/3
Markus Klein [Wed, 27 Jun 2018 17:00:12 +0000 (19:00 +0200)]
[BUGFIX] Use 403 header instead of 401 header

The usage of a 401 header must be accompanied by a valid
www-authenticate header, which does not support form-based logins.

Resolves: #85411
Releases: master, 8.7
Change-Id: I71062c58a7d846214f1fec41e78cce4ae72955f3
Reviewed-on: https://review.typo3.org/57399
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Prevent fatal error in DebugExceptionHandler 42/58242/2
Nicole Cordes [Sun, 9 Sep 2018 20:42:58 +0000 (22:42 +0200)]
[BUGFIX] Prevent fatal error in DebugExceptionHandler

This patch fixes an error if no argument was given for a trace step.

Resolves: #86211
Releases: master
Change-Id: Iee26940df2c463fc0badde245f9da92e73f6740e
Reviewed-on: https://review.typo3.org/58242
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Protect ImportExportController 28/58228/3
Christian Kuhn [Sat, 8 Sep 2018 12:04:16 +0000 (14:04 +0200)]
[TASK] Protect ImportExportController

To gain freedom in v10 refactoring this controller, the class
no longer extends BaseScriptClass, copies over properties and
methods from the base class and sets them to protected.

Resolves: #85031
Releases: master
Change-Id: I3c71ede5f2e00e93b5dc5cd0c9c540540d7e5058
Reviewed-on: https://review.typo3.org/58228
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Protect RecordListController 31/58231/2
Christian Kuhn [Sat, 8 Sep 2018 13:55:32 +0000 (15:55 +0200)]
[TASK] Protect RecordListController

Protect properties and methods of RecordListController. The two
hooks 'drawHeaderHook' and 'drawFooterHook' now receive an instance
of the PSR-7 request, handing over the parent object is deprecated
and will be removed in v10.
The sys_notes hooks are adapted accordingly and used as a migration
example in the .rst file.

Resolves: #86198
Releases: master
Change-Id: Idee82d2e675eefaee1ead7435bc17cfc3a48356b
Reviewed-on: https://review.typo3.org/58231
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Protect methods in AbstractLinkBrowserController 23/58223/2
Christian Kuhn [Fri, 7 Sep 2018 17:47:43 +0000 (19:47 +0200)]
[TASK] Protect methods in AbstractLinkBrowserController

Some public -> protected changes for AbstractLinkBrowserController
and BrowseLinksController

Resolves: #86193
Releases: master
Change-Id: I349dd5961ac2d90ede36a17c4d4ca550171e315e
Reviewed-on: https://review.typo3.org/58223
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Protect FileListController 26/58226/3
Christian Kuhn [Sat, 8 Sep 2018 09:50:26 +0000 (11:50 +0200)]
[TASK] Protect FileListController

Resolves: #86197
Releases: master
Change-Id: I3ad96b95e6e631adfe67ec83db60b8b9d5ec2045
Reviewed-on: https://review.typo3.org/58226
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Protect methods in ElementBrowserController 22/58222/2
Christian Kuhn [Fri, 7 Sep 2018 17:04:28 +0000 (19:04 +0200)]
[TASK] Protect methods in ElementBrowserController

Resolves: #86192
Releases: master
Change-Id: Id7076427c911af750748e47902e87c1c48b2d2d7
Reviewed-on: https://review.typo3.org/58222
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Deprecate second controller action argument 90/58190/5
Christian Kuhn [Wed, 5 Sep 2018 12:42:22 +0000 (14:42 +0200)]
[TASK] Deprecate second controller action argument

Core eid and backend dispatching uses only the $request object as
argument, but not the prepared $response object anymore. This was
a misconception in the first place.

The patch deprecates the second argument and logs deprecations
by reflecting the target action at runtime. This can be supressed
with a new feature toggle.

Resolves: #84196
Releases: master
Change-Id: I003aba6010957cd82e6910fb718ef531116296be
Reviewed-on: https://review.typo3.org/58190
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Deprecate ElementBrowserFramesetController 08/58208/2
Christian Kuhn [Fri, 7 Sep 2018 09:03:43 +0000 (11:03 +0200)]
[TASK] Deprecate ElementBrowserFramesetController

As far as I could find out, the 'browser' route target class
ElementBrowserFramesetController is unused for a while already.
I think it is unused since element browser and modal works in
v7 and v8, the FormEngine JS browserUrl route target is
always wizard_element_browser and searching for other things
like the bparams argument reveals no usages, either.
The patch deprecates the route and the controller.

Resolves: #86178
Releases: master
Change-Id: Ifed2e9210ef04f95944ddc2371e1ad616c73715f
Reviewed-on: https://review.typo3.org/58208
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Use ServerRequestInterface in PermissionAjaxController 07/58207/3
Christian Kuhn [Fri, 7 Sep 2018 07:48:51 +0000 (09:48 +0200)]
[TASK] Use ServerRequestInterface in PermissionAjaxController

Resolves: #86177
Releases: master
Change-Id: Idc357c62b4040165d3a5d04f291b84c69313402e
Reviewed-on: https://review.typo3.org/58207
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Prevent notice in InstallStatusReport 15/58215/5
Roland Golla [Fri, 7 Sep 2018 13:21:14 +0000 (15:21 +0200)]
[TASK] Prevent notice in InstallStatusReport

Add isset check before use is_array.
This will prevent a notice if the
array key does not exist.

Resolves: #86187
Releases: master
Change-Id: I6f74f2200981802ffe2d9ca527ed7230c0d75b27
Reviewed-on: https://review.typo3.org/58215
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Rework pseudo-site backend preview url generation 82/58182/5
Benjamin Franzke [Tue, 4 Sep 2018 09:25:43 +0000 (11:25 +0200)]
[TASK] Rework pseudo-site backend preview url generation

When there is no site configuration, no TCEMAN.preview
configuration and no sys_domain record available, the host
URL needs to be derived from TYPO3_SITE_URL.

This recently broke (and was fixed). Due to wrong logic
the protocol was added twice, resulting in URLs like:

http://http://hostname.tld/

It initially broke due to the site handling features, probably
with https://review.typo3.org/57949
A condition became dead, due to $domain being always set,
when it was null before that change (if a sys_domain record
could not be found).

The bug was fixed by adding an additional condition (without
removing the dead "else" condition) in https://review.typo3.org/c/58177/

This patch tries to clean this up by removing the new condition
(introduced in #58177) and rather restructure the code.

To circumvent those bugs and to avoid confusion what $domain
actually refers to (now always including the protocol) the
code is refactored to not re-assign $domain over and over again.

Change-Id: I155db1b91357bb6345da1ef469d32b0125344b16
Releases: master
Resolves: #86140
Reviewed-on: https://review.typo3.org/58182
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Deprecate TCA type=user without renderType 98/58198/3
Christian Kuhn [Thu, 6 Sep 2018 10:17:49 +0000 (12:17 +0200)]
[TASK] Deprecate TCA type=user without renderType

Using a custom renderType instead of a userFunc for
type=user TCA elements is much more flexible and suits
better into the overall FormEngine node construct.

The patch deprecates userFunc and outlines details on
how existing ones can be migrated over to custom renderTypes
without much hassle.

Resolves: #86163
Related: #86109
Releases: master
Change-Id: I2bad5f79dab5643efe7f8dc959e788b9426bfdd6
Reviewed-on: https://review.typo3.org/58198
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Protect methods in TaskModuleController 12/58212/3
Christian Kuhn [Fri, 7 Sep 2018 11:14:31 +0000 (13:14 +0200)]
[TASK] Protect methods in TaskModuleController

Resolves: #86182
Releases: master
Change-Id: I80b8b519ad530d5d98e284e0666cd6c2eb3f5603
Reviewed-on: https://review.typo3.org/58212
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Protected methods in ReportController 14/58214/3
Christian Kuhn [Fri, 7 Sep 2018 12:51:23 +0000 (14:51 +0200)]
[TASK] Protected methods in ReportController

There are only two methods in the report controller, calling
them via call_user_function() does not make much sense.
The patch simplifies the dispatcher logic and sets the two
actions to protected.
Note this does not affect the extendability of the reports
module itself.

Resolves: #86184
Related: #84231
Releases: master
Change-Id: Ia329b7de7251825028a5587899be3f6c694873e5
Reviewed-on: https://review.typo3.org/58214
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Adjust table field type to varchar 10/58210/3
Anja [Fri, 7 Sep 2018 10:01:21 +0000 (12:01 +0200)]
[BUGFIX] Adjust table field type to varchar

In order to create workspace stage records, the parenttable field
must not be a tinytext, else the not null restriction fails on
SQlite.

Change-Id: I38cb8fca0eb293100ab7d73433cc284307eb1d0d
Resolves: #85405
Releases: master
Reviewed-on: https://review.typo3.org/58210
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Do not let sites module render rootpages in workspaces 02/58202/3
Andreas Fernandez [Thu, 6 Sep 2018 14:26:14 +0000 (16:26 +0200)]
[BUGFIX] Do not let sites module render rootpages in workspaces

If root pages are configured in workspaces, such pages must not get
rendered in the sites module. The BackendWorkspaceRestriction is added
to prevent fetching such pages in the LIVE workspace.

Resolves: #86174
Releases: master
Change-Id: I35a614d41125516a65cd1d2bce917c04f6af57ac
Reviewed-on: https://review.typo3.org/58202
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Show unassigned sites in site module 92/58192/2
Georg Ringer [Wed, 5 Sep 2018 17:52:49 +0000 (19:52 +0200)]
[TASK] Show unassigned sites in site module

The site module displays now also sites with no valid related page anymore.
This can happen if the page is being removed.

Resolves: #86150
Releases: master
Change-Id: If75a33e6c2d189abd42746b52d0b828b7a7b38cb
Reviewed-on: https://review.typo3.org/58192
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Timo Hund <timo.hund@yahoo.com>
Tested-by: Timo Hund <timo.hund@yahoo.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Trigger `change` event after calculating slug 18/58218/3
Andreas Fernandez [Fri, 7 Sep 2018 14:43:09 +0000 (16:43 +0200)]
[BUGFIX] Trigger `change` event after calculating slug

When the slug is calculated by using the according button, the `event` is
now triggered to let the user know that the field value has changes and
to invoke the "You have unsaved changes" modal when closing the form.

Resolves: #86190
Related: #86077
Releases: master
Change-Id: I6eb4e11252562f53e637e3a1abdd7b02a8f73a5a
Reviewed-on: https://review.typo3.org/58218
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Use updated typo3/phar-stream-wrapper version 20/58220/2
Oliver Hader [Fri, 7 Sep 2018 15:22:59 +0000 (17:22 +0200)]
[TASK] Use updated typo3/phar-stream-wrapper version

Resolves: #86191
Releases: master
Change-Id: Ie65dac040f720c313835603bd2446a15e6670c14
Reviewed-on: https://review.typo3.org/58220
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Prevent crash in DatabaseIntegrityCheck 01/58201/3
Christian Kuhn [Thu, 6 Sep 2018 13:57:50 +0000 (15:57 +0200)]
[BUGFIX] Prevent crash in DatabaseIntegrityCheck

If a relation field (select / group) does not exist in db for
whatever reason, System -> DB check -> Database relations
crashes.

Resolves: #86167
Releases: master, 8.7
Change-Id: Id6a502d56b985f6410f40a1f547fe7b923e9d982
Reviewed-on: https://review.typo3.org/58201
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Protect methods in SetupModuleController 11/58211/2
Christian Kuhn [Fri, 7 Sep 2018 10:12:01 +0000 (12:12 +0200)]
[TASK] Protect methods in SetupModuleController

Resolves: #86180
Releases: master
Change-Id: I6277be526cb11d1c6120f13e763d47405aac84d0
Reviewed-on: https://review.typo3.org/58211
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Protect render() method in BackendController 09/58209/2
Christian Kuhn [Fri, 7 Sep 2018 09:41:02 +0000 (11:41 +0200)]
[TASK] Protect render() method in BackendController

Resolves: #86179
Releases: master
Change-Id: Ie61ab04889e36b5290a0d8f4fc1fb68dd95a87ac
Reviewed-on: https://review.typo3.org/58209
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Hide page alias in pagetree overview with sites 04/58204/3
Christian Kuhn [Thu, 6 Sep 2018 15:42:46 +0000 (17:42 +0200)]
[TASK] Hide page alias in pagetree overview with sites

If rendering page trees in Info -> Pagetree overview that has
a full Site configuration, hide the "alias" field - it is not
shown in FormEngine, either.
If rendering a PseudoSite (no site configuration), hide the
slug field.

Resolves: #86175
Releases: master
Change-Id: I46ccb150184e4b76799ab8636ac280eda269c76b
Reviewed-on: https://review.typo3.org/58204
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Use updated typo3/phar-stream-wrapper version 19/58219/2
Oliver Hader [Fri, 7 Sep 2018 14:42:53 +0000 (16:42 +0200)]
[TASK] Use updated typo3/phar-stream-wrapper version

Resolves: #86191
Releases: master
Change-Id: I45d265cd6866dff1ab8fc0a058973c24471ac357
Reviewed-on: https://review.typo3.org/58219
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[TASK] Deprecate old TypoScript condition syntax 09/58109/10
Frank Naegler [Fri, 31 Aug 2018 20:19:21 +0000 (22:19 +0200)]
[TASK] Deprecate old TypoScript condition syntax

Since the symfony expression language is available for TypoScript
conditions, the old condition syntax is being deprecated.

Resolves: #86068
Releases: master
Change-Id: Iae1f4b6e400afbab233561af54c98bc4a4a40792
Reviewed-on: https://review.typo3.org/58109
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
8 months ago[BUGFIX] Fix fatal in ReportsModule with upgrade wizards 13/58213/3
Christian Kuhn [Fri, 7 Sep 2018 12:39:46 +0000 (14:39 +0200)]
[BUGFIX] Fix fatal in ReportsModule with upgrade wizards

With the new upgrade wizard API the InstallStatusReport
has to be adapted a bit to prevent a fatal calling
shouldRenderWizard() on wizards that don't have this
method.

Resolves: #86183
Releases: master
Change-Id: I0551c0a823a0a6f670c0ca079a1f2f4475ccf583
Reviewed-on: https://review.typo3.org/58213
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Clean up UpgradeWizardsService API 99/58199/2
Helmut Hummel [Thu, 6 Sep 2018 10:44:16 +0000 (12:44 +0200)]
[TASK] Clean up UpgradeWizardsService API

Remove implementation details from public API methods

Releases: master
Resolves: #86166
Change-Id: I3605132946d4fa1e92eccfa91498290dab4762c2
Reviewed-on: https://review.typo3.org/58199
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Use ServerRequestInterface in RecyclerAjaxController 85/58185/3
Anja [Tue, 4 Sep 2018 14:26:39 +0000 (16:26 +0200)]
[TASK] Use ServerRequestInterface in RecyclerAjaxController

All values are available in the request object, no need to touch the
globals. The constructor of the controller is empty after the
replacement, so it can be removed.

Change-Id: Ieb0d714965716638d51a982a858341938700572f
Resolves: #86146
Releases: master
Reviewed-on: https://review.typo3.org/58185
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Ensure connection can be established multiple times 89/58189/3
Nicole Cordes [Wed, 5 Sep 2018 11:45:02 +0000 (13:45 +0200)]
[BUGFIX] Ensure connection can be established multiple times

This patch ensures a connection can be established multiple times
and is initialized correctly using the init commands on each fresh
connection call.

Resolves: #86154
Releases: master, 8.7
Change-Id: Ief2fb0855715333b124e8315c5f794008a5fb3d5
Reviewed-on: https://review.typo3.org/58189
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Trim search value in live search 88/58188/2
Georg Ringer [Wed, 5 Sep 2018 08:49:09 +0000 (10:49 +0200)]
[BUGFIX] Trim search value in live search

The query parameter of the live search should be trimmed.
The same behaviour is already used in the regular search in the list module which is
available in the live search by clicking on the button "show all".

Resolves: #86149
Releases: master, 8.7
Change-Id: I3ec2ac03f67fa8c0daaa11aaf3e4351d05949b83
Reviewed-on: https://review.typo3.org/58188
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Only add pages to XML sitemap with no_index = 0 91/58191/2
Richard Haeser [Wed, 5 Sep 2018 14:27:37 +0000 (16:27 +0200)]
[BUGFIX] Only add pages to XML sitemap with no_index = 0

Pages with no_index, follow shouldn't show up in XML sitemap. Only pages
that needs to be indexed.

Resolves: #86157
Releases: master
Change-Id: I609b321d8cd256ceac6599b6a0516c8b3994928b
Reviewed-on: https://review.typo3.org/58191
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Improve TCA of site_errorhandling 87/58187/2
Georg Ringer [Wed, 5 Sep 2018 06:11:23 +0000 (08:11 +0200)]
[TASK] Improve TCA of site_errorhandling

- Localize labels
- Use label_alt to show not only errorCode but also errorHandler

Resolves: #86148
Releases: master
Change-Id: I699117be14d5b2c14f6d9325f7a3f4ecabd1382c
Reviewed-on: https://review.typo3.org/58187
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Reveal usage as controller of TaskStatus::class 83/58183/5
Anja [Tue, 4 Sep 2018 12:27:10 +0000 (14:27 +0200)]
[TASK] Reveal usage as controller of TaskStatus::class

The class is called by two ajax routes and is therefore to be named,
placed and handled as the controller that it is.

Change-Id: I5106f5310041d3f0a993c2bf7ebe03ac51454cad
Resolves: #86142
Releases: master
Reviewed-on: https://review.typo3.org/58183
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Deprecate FrontendEditingController 67/58067/11
Benni Mack [Wed, 29 Aug 2018 07:59:57 +0000 (09:59 +0200)]
[TASK] Deprecate FrontendEditingController

The class is not in use anymore, only feedit instantiates the class for legacy reasons.

Also FrontendBackendUserAuthentication->frontendEdit which holds an instance of
that, is deprecated.

Resolves: #86110
Releases: master
Change-Id: I3ff2ae529dd920d2abf9908f2ae94ae4c2bf9c15
Reviewed-on: https://review.typo3.org/58067
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Set TYPO3 version to 9.5.0-dev 81/58181/2
Oliver Hader [Tue, 4 Sep 2018 12:09:35 +0000 (14:09 +0200)]
[TASK] Set TYPO3 version to 9.5.0-dev

Change-Id: I96b70e192770b6955f82a8106db386f2044e738b
Reviewed-on: https://review.typo3.org/58181
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[RELEASE] Release of TYPO3 9.4.0 80/58180/2 v9.4.0
Oliver Hader [Tue, 4 Sep 2018 12:07:49 +0000 (14:07 +0200)]
[RELEASE] Release of TYPO3 9.4.0

Change-Id: I10cf279d74af2cfc2964704ba31c6ce2b7be3493
Reviewed-on: https://review.typo3.org/58180
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Avoid insufficient workspace version constraint 60/58160/4
Oliver Hader [Mon, 3 Sep 2018 19:56:40 +0000 (21:56 +0200)]
[BUGFIX] Avoid insufficient workspace version constraint

Resolves: #86126
Releases: master
Change-Id: I7724cb1415742861a0c6496f4e3888787e6467d4
Reviewed-on: https://review.typo3.org/58160
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Resolve version move placeholder in RootlineUtility 78/58178/5
Oliver Hader [Tue, 4 Sep 2018 10:04:24 +0000 (12:04 +0200)]
[BUGFIX] Resolve version move placeholder in RootlineUtility

In order to correctly work with rootlines (e.g. when resolving
according sites and pseudo-sites for URL resolving and generation)
possible version move placeholders have to be resolved.

Resolves: #86137
Releases: master
Change-Id: Ief9841f7592018292c034c03c45343363cf79248
Reviewed-on: https://review.typo3.org/58178
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Move documentation files into 9.4 folder - part 3 66/58166/7
Anja [Mon, 3 Sep 2018 21:07:47 +0000 (23:07 +0200)]
[TASK] Move documentation files into 9.4 folder - part 3

The change also contains some documentation related improvements
in some code files, where the need occured.

Change-Id: I346fd70e20bd0765ac4cc663dc7e3fd73d02651b
Resolves: #86075
Releases: master
Reviewed-on: https://review.typo3.org/58166
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Do not double-prepend the URL scheme on preview URLs 77/58177/2
Benni Mack [Tue, 4 Sep 2018 09:19:15 +0000 (11:19 +0200)]
[BUGFIX] Do not double-prepend the URL scheme on preview URLs

When having a pseudo-site the view functionality is broken
due to some different handling how to deal with protocols.

Resolves: #86134
Releases: master
Change-Id: Ia3b08ce968ecfdce631ce9c7ff9c973cfb25eef5
Reviewed-on: https://review.typo3.org/58177
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Wrap error UnknownElement with proper HTML 73/58173/3
Georg Ringer [Tue, 4 Sep 2018 05:41:27 +0000 (07:41 +0200)]
[TASK] Wrap error UnknownElement with proper HTML

Show the error with a proper markup. Also hightlight type and
render type as code.

Resolves: #86133
Releases: master, 8.7
Change-Id: I79323aaff834c47e6ff875f8a584b2c88f42c51d
Reviewed-on: https://review.typo3.org/58173
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Allow getPagesTSconfig to be called without BE_USER 74/58174/2
Benni Mack [Tue, 4 Sep 2018 07:08:19 +0000 (09:08 +0200)]
[BUGFIX] Allow getPagesTSconfig to be called without BE_USER

Due to refactorings lately in BackendUtility::getPagesTSconfig() with
which results in a fatal error when clearing page cache while persisting an
extbase object.

The patch adds a test without a Backend User, and encapsulates this
with a simple if() statement. However, this also shows that some
other areas that are touched are not fully notice-free / strict, which
are tackled as well.

Resolves: #85310
Releases: master
Change-Id: I0f1318d395451e704e1783e841d96583efe2a560
Reviewed-on: https://review.typo3.org/58174
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Abort `nodeSelectedAfter` on unchecked nodes 36/57836/4
Andreas Fernandez [Wed, 8 Aug 2018 20:39:41 +0000 (22:39 +0200)]
[BUGFIX] Abort `nodeSelectedAfter` on unchecked nodes

If a node in the page tree is clicked, the `nodeSelectedAfter` event is
triggered for any active node that is being deactivated.

The event listener is now aborted if the event is called on a unchecked
node.

Resolves: #85787
Releases: master
Change-Id: I4fa5bbc4290b5ffd2ecb77a901dceb042dff3d27
Reviewed-on: https://review.typo3.org/57836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Tested-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[BUGFIX] Template module must respect workspaces 71/58171/2
Andreas Fernandez [Mon, 3 Sep 2018 21:50:12 +0000 (23:50 +0200)]
[BUGFIX] Template module must respect workspaces

The template module now respects the workspace constraint of the current
backend user and the stored sys_template records.

Resolves: #86131
Releases: master, 8.7
Change-Id: I0463844c4222957aede4b4ca749a3368cb399f81
Reviewed-on: https://review.typo3.org/58171
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Make debug exceptions scrollable in backend context 72/58172/2
Benjamin Kott [Mon, 3 Sep 2018 22:02:40 +0000 (00:02 +0200)]
[BUGFIX] Make debug exceptions scrollable in backend context

Resolves: #86132
Releases: master
Change-Id: I34a09ec83491b0f08e0a094680fbd93057ad76a4
Reviewed-on: https://review.typo3.org/58172
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[BUGFIX] Use same height for tree bar as for the right module 67/58167/3
Georg Ringer [Mon, 3 Sep 2018 21:17:10 +0000 (23:17 +0200)]
[BUGFIX] Use same height for tree bar as for the right module

Fix 1px off error in page tree toolbar.

Resolves: #86098
Releases: master
Change-Id: Ia1476d57b935159fc32e40a9134c7c7a1e9a6ef3
Reviewed-on: https://review.typo3.org/58167
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>