Packages/TYPO3.CMS.git
5 years ago[TASK] Fix tests for DirectoryNodeTest 13/28513/3
Markus Klein [Tue, 18 Mar 2014 21:20:02 +0000 (22:20 +0100)]
[TASK] Fix tests for DirectoryNodeTest

The tests have not been adjusted when
http://forge.typo3.org/issues/52668
was merged.

Resolves: #57055
Releases: 6.2
Change-Id: I259c7b5462d372f3244ee4c2e89a96cef0780478
Reviewed-on: https://review.typo3.org/28513
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Use correct warning icon in time tracker 75/28575/2
Alexander Stehlik [Thu, 20 Mar 2014 17:59:05 +0000 (18:59 +0100)]
[BUGFIX] Use correct warning icon in time tracker

The icon_warning2.gif is used instead of the deleted icon_warning.gif.

Resolves: #57116
Releases: 6.2
Change-Id: I3a902a0bfb362c29e8ff6b384b844bf1f7f63cf8
Reviewed-on: https://review.typo3.org/28575
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Invalid file used to compute image ratio in text with picture 58/28558/3
Xavier Perseguers [Thu, 20 Mar 2014 11:52:57 +0000 (12:52 +0100)]
[BUGFIX] Invalid file used to compute image ratio in text with picture

Fixes: #57075
Releases: 6.2
Change-Id: Ided1204857dabf4fb15045056cc8a14010a53ae9
Reviewed-on: https://review.typo3.org/28558
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Cached class loader misses are not considered 19/28419/12
Thomas Maroschik [Sat, 15 Mar 2014 12:28:51 +0000 (13:28 +0100)]
[BUGFIX] Cached class loader misses are not considered

The class loader caches if it doesn't find a class name
for subsequent calls. But currently it only checks for
NULL results from the cache and not the empty strings
returned from the cache and thus tries to resolve the
non existing class name over and over again.

The fix converts the empty string to a NULL and
changes the semantics of NULL to FALSE in the class
loader.

Fixes: #56933
Releases: 6.2
Change-Id: I4cd1a18b4a4496c287a937d6d9882ae21d3ee9a3
Reviewed-on: https://review.typo3.org/28419
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix import of type group internal_type file_reference 21/28021/6
Marc Bastian Heinrichs [Thu, 27 Feb 2014 18:31:39 +0000 (19:31 +0100)]
[BUGFIX] Fix import of type group internal_type file_reference

This patch fixes the import of fields type "group" "internal_type"
"file_reference" and adds functional tests for exporting and
importing records with fields of type "group" "internal_type"
"file" and "file_reference", the types for file handling before
introducing the File Abstraction Layer.

Resolves: #56516
Resolves: #56071
Releases: 6.2
Change-Id: I4298f27ee77a89230188aa0df1b187429d555188
Reviewed-on: https://review.typo3.org/28021
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Add SoftIndex parser typolink to link in sys_file_reference 84/28484/2
Marc Bastian Heinrichs [Mon, 17 Mar 2014 22:32:43 +0000 (23:32 +0100)]
[BUGFIX] Add SoftIndex parser typolink to link in sys_file_reference

The field "link" of the table "sys_file_reference" handles links. To
make the SoftReferenceIndex, which is used by impexp and
linkvalidator, work right, the “softref” key "typolink" should be
registered.

Resolves: #57010
Releases: 6.2, 6.1, 6.0
Change-Id: I95cb8dbfa0c6d84926cd57d1fe4e4dad93e9c21a
Reviewed-on: https://review.typo3.org/28484
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Frans Saris
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] clearCache.system does not show up 18/28518/5
Francois Suter [Wed, 19 Mar 2014 08:30:02 +0000 (09:30 +0100)]
[BUGFIX] clearCache.system does not show up

New TSconfig option clearCache.system does not work as expected
because class \TYPO3\CMS\Backend\Toolbar\ClearCacheToolbarItem
wrongly checks access to that option. Thus if only clearCache.system
is set the clear cache menu does not show up at all.

Resolves: #57064
Releases: 6.2
Change-Id: I51c9605c830a9099f21d254ae86d8d6cc430b02a
Reviewed-on: https://review.typo3.org/28518
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Named parameters in Extbase comparison queries 11/28511/6
Alexander Stehlik [Tue, 18 Mar 2014 20:28:17 +0000 (21:28 +0100)]
[BUGFIX] Named parameters in Extbase comparison queries

Instead of using unnamend parameters (?) in parseComparison() in the
Extbase Typo3DbQueryParser the matching parameter identifier will be
used for building the comparison SQL.

Additionally the non existing "$parameters" method parameter is removed
from a lot of method calls.

Resolves: #57053
Related: #55167
Releases: 6.2
Change-Id: I1123275af57e8803ecd792d65f91627cef54f501
Reviewed-on: https://review.typo3.org/28511
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Regenerate missing RTE magic image on rendering 84/27884/15
Stanislas Rolland [Wed, 26 Feb 2014 20:55:00 +0000 (15:55 -0500)]
[BUGFIX] Regenerate missing RTE magic image on rendering

Problem: Magic images inserted in RTE content may be missing,
for instance after flushing the _processed_ directory.
Solution: Regenerate any missing magic image when rendering the content
element.

Revolves: #56147
Releases: 6.2
Change-Id: Ifa156791bcd1c446c7ae61888465bb680abdf36d
Reviewed-on: https://review.typo3.org/27884
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Several typos in Page Browsing ViewHelper 58/27058/12
Benjamin Rau [Sun, 26 Jan 2014 13:00:26 +0000 (14:00 +0100)]
[BUGFIX] Several typos in Page Browsing ViewHelper

Fixing several typos and slips of the pen in the
PageBrowsing ViewHelper.

Without fixing all of them the page browsing ViewHelper
is not functional properly, that´s why i want to submit
them at once and also supply the fix for it.

That are these errors:
* Undefined but used class property prefixId
* Overwriting instead of appending content to already defined variable
* Not using UpperCamelCase for extensionName in Localization Utilty
* Accidentally using wrong variables
* Defining variable in for-loop which could be defined outside also
* Using undefined variable freeIndexUid

Resolves: #55340
Releases: 6.2, 6.1
Change-Id: I708a7af4876eba0e69fa666694315e0babcf6800
Reviewed-on: https://review.typo3.org/27058
Reviewed-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Reviewed-by: Cedric Ziel
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Use HTTP Status 307 for all page shortcut modes 33/27933/4 33/27933/5
Christoph Dörfel [Fri, 28 Feb 2014 10:22:51 +0000 (11:22 +0100)]
[BUGFIX] Use HTTP Status 307 for all page shortcut modes

Fixes cases where the shortcut page is cached by some
devices leading to exceptions or wrong behaviour.

Resolves: #56423
Releases: 6.2
Change-Id: I71252b13320417ecffa9c28db6af9476d667d58f
Reviewed-on: https://review.typo3.org/27933
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix impexp with images in RTE and links to files 05/28105/6
Marc Bastian Heinrichs [Thu, 27 Feb 2014 18:32:55 +0000 (19:32 +0100)]
[BUGFIX] Fix impexp with images in RTE and links to files

This patch fixes the import and export of RTE contents
including images and links to files as well as softreference
links to files (file:{uid}) and adds functional tests
for this use cases.

Resolves: #56089
Resolves: #56285
Related: #56286
Releases: 6.2
Change-Id: I29312b304d265581bf9f35bdc2692a19d2df5a93
Reviewed-on: https://review.typo3.org/28105
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Follow-up: Cleanup ext_localconf.php of sysexts 19/28519/5
Marc Bastian Heinrichs [Wed, 19 Mar 2014 08:52:12 +0000 (09:52 +0100)]
[TASK] Follow-up: Cleanup ext_localconf.php of sysexts

The Extbase implementation registrations don't have to
be initialized in BE mode only.

Resolves: #55593
Releases: 6.2
Change-Id: I78a643fba62d48734fc727d7bf78bf774e6c3ddd
Reviewed-on: https://review.typo3.org/28519
Reviewed-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Reviewed-by: Markus Kasten
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Catch exception in filelist when file is missing 84/28284/5
Frans Saris [Wed, 12 Mar 2014 08:48:37 +0000 (09:48 +0100)]
[BUGFIX] Catch exception in filelist when file is missing

The code responsible for rendering the thumbs belonging to a
record doesn't catch the exceptions when a file couldn't be found.

This change adds a try catch around the functions that
tries to retrieve the file and displays a flash message when
the file is missing.

Resolves: #56077
Releases: 6.2
Change-Id: Icc6550db43c8738c74fd7ea8faac6e99a54bc0f3
Reviewed-on: https://review.typo3.org/28284
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] RTE Linking with file upload fails 47/28247/4
Tymoteusz Motylewski [Tue, 11 Mar 2014 10:10:21 +0000 (11:10 +0100)]
[BUGFIX] RTE Linking with file upload fails

Catch exceptions raised when the potential target folder or
the default user upload folder does not exist.

The change  https://review.typo3.org/27323 from ticket
http://forge.typo3.org/issues/48512 should be applied
in few places more.

Resolves: #56751
Related: #48512
Releases: 6.2
Change-Id: I7446697d64a580203f8f772d4bba690542dd7cb2
Reviewed-on: https://review.typo3.org/28247
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Unify NULL default value handling 08/26408/9
Alexander Stehlik [Mon, 13 Jan 2014 10:20:06 +0000 (11:20 +0100)]
[TASK] Unify NULL default value handling

If a field is configured to allow NULL values ("eval" is set to "null")
and the default value in the TCA is explicitly set to NULL the value
will not be converted to a string.

Additionally the mode setting "useOrOverridePlaceholder" will not have
any influence any more on the default value when creating new records.

Resolves: #54412
Releases: 6.2
Documentation: #56584
Change-Id: Ica43a1af33e6f86dd042b66781acc0e9cd904cf9
Reviewed-on: https://review.typo3.org/26408
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Reviewed-by: Ernesto Baschny
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Fix automatic core updater 93/28393/9
Markus Klein [Tue, 18 Mar 2014 22:39:24 +0000 (23:39 +0100)]
[BUGFIX] Fix automatic core updater

AbstractCoreUpdate redefines the $view member to be
a JsonView, but does not re-implement the parent methods
that rely on $view being an AbstractView.

Fix this by re-implementing the initializeHandle() method.
This method can be merged with the former initializeCoreUpdate(),
which wasn't called at all in most actions.

Resolves: #56865
Releases: 6.2
Change-Id: I85260a0e57e915ac941569cfbdde1f96cdaec5e6
Reviewed-on: https://review.typo3.org/28393
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove obsolete node in import test data header xml 96/28496/2
Marc Bastian Heinrichs [Tue, 18 Mar 2014 16:07:07 +0000 (17:07 +0100)]
[BUGFIX] Remove obsolete node in import test data header xml

Resolves: #57045
Releases: 6.2
Change-Id: I439305e5143b3c51a03befc642caf66286264679
Reviewed-on: https://review.typo3.org/28496
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[TASK] Add ManyToMany copyPage functional test 88/28488/2
Oliver Hader [Tue, 18 Mar 2014 11:19:30 +0000 (12:19 +0100)]
[TASK] Add ManyToMany copyPage functional test

Add the copyPage() functional test for live and workspace.

Resolves: #57030
Releases: 6.2
Change-Id: Id9ddea21a50c449c3f2674d704c10fefb2da12ff
Reviewed-on: https://review.typo3.org/28488
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Failng Import/Export functional tests 12/28512/2
Oliver Hader [Tue, 18 Mar 2014 20:44:11 +0000 (21:44 +0100)]
[BUGFIX] Failng Import/Export functional tests

As a follow-up to issue #57046 (which fixed a bug in
sys_file_metadata pointing to sys_file_reference as
translation parent), these corrections need to be
updated in the functional test assertions as well.

Resolves: #57054
Releases: 6.2
Change-Id: I1a3d395fb4fcb1271d2684af38e5fc32a10463fc
Reviewed-on: https://review.typo3.org/28512
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Exception in Locker if typo3temp does not exist 82/28482/10
Alexander Opitz [Tue, 18 Mar 2014 11:15:05 +0000 (12:15 +0100)]
[BUGFIX] Exception in Locker if typo3temp does not exist

Follow-up to 2268f64c18b607ba39d06b1580afb0ccd786d6b1

If typo3temp does not exist, the Locker should throw an exception.
The ClassLoader needs to catch this exception and acts upon
depending on whether we are in the Installer or not.

When in the Installer, locking has to be skipped completely due to
missing typo3temp directory.

Resolves: #57008
Releases: 6.2
Change-Id: Ic595dc97826cd94d6f173b7c681194ed754ed3e0
Reviewed-on: https://review.typo3.org/28482
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix foreign_table for l10n_parent in sys_file_metadata 01/28501/2
Marc Bastian Heinrichs [Tue, 18 Mar 2014 16:40:21 +0000 (17:40 +0100)]
[BUGFIX] Fix foreign_table for l10n_parent in sys_file_metadata

Instead of sys_file_metadata sys_file_reference was configured.

Resolves: #57046
Releases: 6.2
Change-Id: I1194012cbacb0415993672338d6ac6ee0a515dc1
Reviewed-on: https://review.typo3.org/28501
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Cleanup ext_localconf.php of sysexts 86/27286/9
Benjamin Mack [Sun, 2 Feb 2014 14:58:46 +0000 (15:58 +0100)]
[TASK] Cleanup ext_localconf.php of sysexts

As TYPO3 is loading all ext_localconf.php on each call,
the existing code can be cleaned up by removing
old information, putting BE-only functionality in
TYPO3_MODE == 'BE' and install-tool only
in Install only mode.

Also, some hardcoded require_once statements are
removed.

Benefits are that FE does not need to load everything
all the time.

I haven't noticed any side-effects so far, but please
test extensively.

Resolves: #55593
Releases: 6.2
Change-Id: Ibc37e84cb2af05ddb6b227290330aad31037a018
Reviewed-on: https://review.typo3.org/27286
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Respect table mapping on caching 74/27874/8
Andreas Fernandez [Wed, 26 Feb 2014 15:51:37 +0000 (16:51 +0100)]
[BUGFIX] Respect table mapping on caching

The method analyzeFields() of DBAL's DatabaseConnection caches the
table structure. The cache always uses the real table name, ignoring
any mapping, which results in a RuntimeException:

"Could not update BLOB >>>> no WHERE clause found!"

The method now checks for a possible mapping and sets the alias
as table name.

Resolves: #56349
Releases: 6.2
Change-Id: I9599cebc8604103c3749bc142cd44b813f018a72
Reviewed-on: https://review.typo3.org/27874
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Simplify TYPO3_DB->cleanIntArray 34/28234/3
Bernhard Kraft [Mon, 10 Mar 2014 17:28:34 +0000 (18:28 +0100)]
[TASK] Simplify TYPO3_DB->cleanIntArray

Instead of iterating over the array and calling "intval" for each
element the "array_map" php function gets used.

Change-Id: I5ae699f9bc158eb0caebf1fc9ea8ebaa3cdd73ca
Resolves: #56738
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/28234
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Use language overlay for image rendering 10/28210/3
Alexander Stehlik [Mon, 10 Mar 2014 09:00:39 +0000 (10:00 +0100)]
[BUGFIX] Use language overlay for image rendering

In the image rendering TypoScript configuration of css_styled_content
the uid is removed from the references configuration of the FILES
content object.

This makes sure that the language overlay mechanism from the FILES
content object is used.

Resolves: #56712
Releases: 6.2
Change-Id: Iaea43ca006826facfba40a846da67704dd3154ea
Reviewed-on: https://review.typo3.org/28210
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[FEATURE] Execute native prepared queries 31/28231/10
Xavier Perseguers [Mon, 10 Mar 2014 15:41:14 +0000 (16:41 +0100)]
[FEATURE] Execute native prepared queries

As TYPO3 is now using mysqli, prepared queries are natively supported
and should be used.

DBAL, however, does not yet actually use native prepared queries but
falls back to standard queries by replacing placeholders and executing
the underlying SQL query.

Change-Id: If50da6e6d27af89e01c0439bcb9d39a85615a75d
Resolves: #27372
Releases: 6.2
Reviewed-on: https://review.typo3.org/28231
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Retry request on 403 in linkvalidator 89/26489/6
Alexander Stehlik [Thu, 19 Dec 2013 13:53:11 +0000 (14:53 +0100)]
[TASK] Retry request on 403 in linkvalidator

When the linkvalidator detects a 403 error when doing a HEAD request to
an external URL it will retry the request using the GET method.

Resolves: #54513
Releases: 6.2
Change-Id: Ib36b6cbb8e981b95c348afd5a063ca4f5040de75
Reviewed-on: https://review.typo3.org/26489
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Remove reference to old tx_templavoila nesting tag 82/26482/4
Claus Due [Wed, 18 Dec 2013 22:08:45 +0000 (23:08 +0100)]
[TASK] Remove reference to old tx_templavoila nesting tag

This change removes a reference to the old <tx_templavoila>
nesting tag which was switched away from in TYPO3 4.7, making
section objects inside sections in flexforms, use the proper
array index path "title" instead of "tx_templavoila.title".

Releases: 6.2
Resolves: #54503
Change-Id: I4c975cf4eed127ca90ead3d7566fbc826f5b78db
Reviewed-on: https://review.typo3.org/26482
Reviewed-by: Wouter Wolters
Reviewed-by: Fabien Udriot
Reviewed-by: Dmitry Dulepov
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[CLEANUP] Fix docheader param for Folder:addFile() 76/28476/2
Marc Bastian Heinrichs [Mon, 17 Mar 2014 17:24:45 +0000 (18:24 +0100)]
[CLEANUP] Fix docheader param for Folder:addFile()

Add missing conflictMode 'changeName'.

Releases: 6.2, 6.1, 6.0
Resolves: #57004
Change-Id: Ie5c32e96c1292dbaecc505d54240f1a7a5c720fe
Reviewed-on: https://review.typo3.org/28476
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Enrich many-to-many functional tests in live workspace 86/28486/2
Oliver Hader [Tue, 18 Mar 2014 08:39:22 +0000 (09:39 +0100)]
[TASK] Enrich many-to-many functional tests in live workspace

Resolves: #57014
Change-Id: Ib3a5688a111d3ce38c3672fad0a11b195839323d
Reviewed-on: https://review.typo3.org/28486
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Respect timezone in online Backend user list 62/28462/2
Alexander Stehlik [Mon, 17 Mar 2014 11:17:11 +0000 (12:17 +0100)]
[BUGFIX] Respect timezone in online Backend user list

To display the session timestamps in the online Backend users list
in the correct timezone the DateViewHelper will now create the
DateTime object because it already takes care of the correct timezone
handling.

Resolves: #56985
Releases: 6.2
Change-Id: I65003c3f5505f4fe96160f917131fe13a3a53416
Reviewed-on: https://review.typo3.org/28462
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Element browser doesn't use FAL info to for file dimensions 04/28404/2
Frans Saris [Fri, 14 Mar 2014 21:46:00 +0000 (22:46 +0100)]
[BUGFIX] Element browser doesn't use FAL info to for file dimensions

The dimensions of a file are fetch during indexing. These values
should be used as for remote files or certain filetype getimagesize()
will not work or give unwanted overhead.

Resolves: #56864
Releases: 6.2
Change-Id: I14ece9c0dbf414f4cb0759d3065a1c5b5782ca29
Reviewed-on: https://review.typo3.org/28404
Reviewed-by: Markus Klein
Reviewed-by: Tomita Militaru
Reviewed-by: Wouter Wolters
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Tested-by: Markus Klein
5 years ago[TASK] Use queryCache in generic persistence 55/27555/12
Felix Oertel [Tue, 11 Feb 2014 17:15:17 +0000 (18:15 +0100)]
[TASK] Use queryCache in generic persistence

At the moment extbase persistence is quite slow. To some degree,
the query building is responsible for that. For each and every
query the parseQuery() and buildQuery() methods are called.

This patch introduces a query cache to store the query structure.
This way a query can be reused, even when fired with different
parameters.

* Introduce a parameterIdentifier to the comparison
In the way the extbase query object model works, it's hard to
identify an object in a way which is unique and still compre-
hensible. To ease this, an identifier is introduced.

* Move parsing to an external QueryParser
All the query parsing is now seperated from the storageBackend.
The query parsing is mostly left the way it was, it should be
re-profiled later.

* introduce cache extbase_typo3dbbackend_queries

* No more statement handling by reference
Make getStatementParts() return the query and parameters in an
array instead of handing down the parameters by reference.

* Split up parseQuery in preparsing and real parsing with caching
In every call the query has to be preparsed to determine the
identifier and extract the parameters. The identifier can then
be used to look up the query structure in the cache. If it is
not (yet) cached, Extbase will do the real parsing which takes
some more time.

* Introduce useQueryCache to querySettings
Like preparedStatements, caching the queries does not always
make sense and will spam your cache under certain conditions.
It's enabled by default and can be disabled on a per-query-
basis.

* Use named parameter's placeholders
Instead of using "?" as parameter's placeholder and relying
on the right order of parameters in the array, named place-
holders are used to ensure the correct association.

* Move unit tests around to fit the new queryParser

Resolves: #55167
Releases: 6.2
Change-Id: I517c0500cad75cae96fd739f2ff7222db80b42a5
Reviewed-on: https://review.typo3.org/27555
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Follow-up: Use prepared statements in generic persistence 42/28442/3
Marc Bastian Heinrichs [Sun, 16 Mar 2014 13:57:21 +0000 (14:57 +0100)]
[TASK] Follow-up: Use prepared statements in generic persistence

Fixes using $query->statement() without parameters.

Resolves: #56915
Resolves: #55360
Releases: 6.2
Change-Id: Ia149313f5f9f719d7dba0a21a3eb39ea4f5052e8
Reviewed-on: https://review.typo3.org/28442
Reviewed-by: Markus Klein
Reviewed-by: Dennis J
Tested-by: Dennis J
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Documentation does not initialize signal slot dispatcher 81/28481/3
Philipp Gampe [Mon, 17 Mar 2014 21:36:10 +0000 (22:36 +0100)]
[BUGFIX] Documentation does not initialize signal slot dispatcher

The documentation module does not initialize the signal slot dispatcher
in its ext_localconf.php, but rather reuses the already set variable
from another core extension.

Create the object explicitly before using it.

Resolves: #57009
Releases: 6.2
Change-Id: Ifbd3199f9cef0b2d2d6dacc4569280c5e668822c
Reviewed-on: https://review.typo3.org/28481
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Prevent Inclusion of ResourceStorage from Bootstrap 16/28416/3
Thomas Maroschik [Sat, 15 Mar 2014 11:43:38 +0000 (12:43 +0100)]
[BUGFIX] Prevent Inclusion of ResourceStorage from Bootstrap

During bootstrapping the ResourceStorage and ResourceFactory
is loaded and evaluated just because of two constants containing
signal names used in ext_localconf. This introduces unnecessary
overhead especially in eID context.

The constants have been extracted to an interface that are way
faster parsed.

Resolves: #56335
Releases: 6.2
Change-Id: I509593d2720c595fa7e4f1c9b5c63fd09fea724c
Reviewed-on: https://review.typo3.org/28416
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Implement locking in ClassLoader 80/28480/2
Alexander Opitz [Fri, 7 Mar 2014 11:37:47 +0000 (12:37 +0100)]
[BUGFIX] Implement locking in ClassLoader

After cache clearing we can run in the situation that 2 processes will
rebuild the ClassLoader cache which will lead to a non useable cache,
which produces fatals. As the data is generated more than once the load
of the server increases per request while ClassLoader cache is build.

The implemented Locking will stop this issue. Every process waits till
the first is ready and then looks if data was generated and stops re-
generating the cache.

To-Do: Make it work also for first time installation when there is
no typo3temp/ directory yet.

Resolves: #55099
Releases: 6.2
Change-Id: I9c1916b5b5860e86fe19a1fc292d8ab5a196d960
Reviewed-on: https://review.typo3.org/28480
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Fields of type group file are not properly indexed 10/27310/10
Marc Bastian Heinrichs [Mon, 3 Feb 2014 22:52:43 +0000 (23:52 +0100)]
[BUGFIX] Fields of type group file are not properly indexed

If an record with a field of type "group", internal_type "file"
should be indexed in the ReferenceIndex an SQL error exception
gets thrown. So the relation to the file isn't represented in the
refindex. Thus those files are also missing in exports created
with system extension impexp.

This is caused by wrong array keys and incorrectly storing a file
relation as DB relation since merge of FAL.

Resolves: #56353
Resolves: #56352
Releases: 6.2, 6.1, 6.0
Change-Id: I78211efcb6bf3032811ef0b0e20ed7f98f9fa8fb
Reviewed-on: https://review.typo3.org/27310
Tested-by: Sebastian Fischer
Tested-by: Christian Zenker
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Ext:rtehtmlarea entry scripts cleanup 08/28208/3
Nicole Cordes [Sun, 9 Mar 2014 23:06:09 +0000 (00:06 +0100)]
[TASK] Ext:rtehtmlarea entry scripts cleanup

This patch turns all remaining RTE module scripts (mod4, mod5, mod6)
into CSRF protected wizards.

Resolves: #55674
Releases: 6.2
Change-Id: I8421ff05240f6eedcaf40c805d9dd92ea7d4c30b
Reviewed-on: https://review.typo3.org/28208
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Cleanup EXT:cshmanual 03/28303/7
Wouter Wolters [Wed, 12 Mar 2014 16:48:47 +0000 (17:48 +0100)]
[BUGFIX] Cleanup EXT:cshmanual

* Removed require_once which is deprecated.
* Introduced a use-statement for GeneralUtility
* Removed TYPO3_MOD_PATH
* Links generated by make_seeAlso() were double htmlspecialchars
  encoded after security patch https://review.typo3.org/27636

Resolves: #56826
Related: #55509
Releases: 6.2
Change-Id: I8effc7c6bf9828dde4f1c69754b207864b3122ba
Reviewed-on: https://review.typo3.org/28303
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Avoid superfluous IRRE child record duplication 52/26552/4
Alexander Stehlik [Mon, 23 Dec 2013 16:47:20 +0000 (17:47 +0100)]
[BUGFIX] Avoid superfluous IRRE child record duplication

If copying a page, all records on that page will be copied to
the accordant destination page. IRRE parent-child structures
are cloned along the way as well. However, if a table (that is
defined a IRRE child) is processed before the accordant parent
record, the parent itself will duplicate its children again.
This behaviour leads to superfluous duplicates and is wrong.

A check in DataHandler::copyRecord_procBasedOnFieldType() now
ensures that records are only copied once during the accordant
DataHander copy process.

Resolves: #44795
Releases: 6.2
Change-Id: Ia1e4129432f37c0dd6bfedb5fd69394e2c244d34
Reviewed-on: https://review.typo3.org/26552
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years agoRevert "[TASK] Declare getThisScript() in ElementBrowser as public" 78/28478/3
Markus Klein [Mon, 17 Mar 2014 19:44:45 +0000 (20:44 +0100)]
Revert "[TASK] Declare getThisScript() in ElementBrowser as public"

This reverts commit b2756fe7826d62fdc8442c887010890c268eabd8

A comment of Helmut Hummel was suggested, which was still missing.
This change will be repushed.

Releases: 6.2
Change-Id: I518af35f562350f9dde39678de52f69d58344677
Reviewed-on: https://review.typo3.org/28478
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Declare getThisScript() in ElementBrowser as public 37/28337/3
Georg Ringer [Thu, 13 Mar 2014 10:19:23 +0000 (11:19 +0100)]
[TASK] Declare getThisScript() in ElementBrowser as public

To make work in hooks easier, the method should be public

Resolves: #56721
Releases: 6.2
Change-Id: Ib0a0f17d5f9384a04a125ef08a079f4c272eddae
Reviewed-on: https://review.typo3.org/28337
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Avoid reference index records for images in RTE fields 92/28292/7
Marc Bastian Heinrichs [Mon, 17 Mar 2014 16:37:10 +0000 (12:37 -0400)]
[BUGFIX] Avoid reference index records for images in RTE fields

Since images in RTE fields are handled as relations to sys_file
records adding references to the reference index for the concrete
image paths are obsolete and causes trouble with impexp.

Resolves: #56811
Releases: 6.2
Change-Id: I26a2531f417ff8b628b69156a3a2236c99960d5e
Reviewed-on: https://review.typo3.org/28292
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Update $GLOBALS['TYPO3_LOADED_EXT'] on package change 59/28459/3
Alexander Opitz [Mon, 17 Mar 2014 10:44:26 +0000 (11:44 +0100)]
[BUGFIX] Update $GLOBALS['TYPO3_LOADED_EXT'] on package change

If a package is (un)installed we need to update
$GLOBALS['TYPO3_LOADED_EXT']. ExtensionManagementUtility depends on
the actuality of this array.

Resolves: #56978
Releases: 6.2
Change-Id: I969b84a624a6a9f74b87fdd85b9c4c3a7b49750a
Reviewed-on: https://review.typo3.org/28459
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[FEATURE] Show PHP Errors after checking compatibility of extensions 98/28298/4
Daniel Siepmann [Wed, 12 Mar 2014 13:59:51 +0000 (14:59 +0100)]
[FEATURE] Show PHP Errors after checking compatibility of extensions

The errors are logged in another log file and loaded as json afterwards.

Change-Id: I63458c0a4f64e6d8f4236667b6d22ff6b50aa1f3
Resolves: #51362
Releases: 6.2
Reviewed-on: https://review.typo3.org/28298
Reviewed-by: Tomita Militaru
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
5 years ago[BUGFIX] Order storages in treeview by name 02/28402/2
Frans Saris [Fri, 14 Mar 2014 21:07:51 +0000 (22:07 +0100)]
[BUGFIX] Order storages in treeview by name

The storages can not be ordered manualy and in list view they
are by default ordered by name.
But in the tree views (file module, element browser) there is
no ordering set.

This change sets the default ordering to name when the storageRowCache
is initialised.

Resolves: #56824
Releases: 6.2
Change-Id: I8e879920bc6da14156ce486b8c25b1b8820f896b
Reviewed-on: https://review.typo3.org/28402
Reviewed-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Reviewed-by: Christoph Lehmann
Tested-by: Christoph Lehmann
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Tests: Reduce unit test bootstrap 49/28449/3
Christian Kuhn [Sun, 16 Mar 2014 17:12:44 +0000 (18:12 +0100)]
[TASK] Tests: Reduce unit test bootstrap

The patch further reduces the unit test bootstrap: ext_localconf
of extensions is not loaded anymore and the cache framework is
no longer initialized. A test with incommplete mocking in this area
is fixed along the way.
Furthermore the core exception handling is no longer initialized,
so it does not depend on configuration options. A warning
triggered by a unit test will now reliable let the test fail.

Change-Id: I659441482a19eb6b434d520ecded6df8f5086820
Resolves: #51436
Related: #56967
Releases: 6.2
Reviewed-on: https://review.typo3.org/28449
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Finalize skinning of Sys_Note (Web>List & Web>Page) 05/28405/3
Felix Kopp [Fri, 14 Mar 2014 21:54:35 +0000 (22:54 +0100)]
[TASK] Finalize skinning of Sys_Note (Web>List & Web>Page)

Brings last styles according to layout defined by the UX team.

Resolves: #56960
Related: #26796
Releases: 6.2
Change-Id: Ie1c4bc57343555edac66362100a6ec659d953173
Reviewed-on: https://review.typo3.org/28405
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Tests: Remove extbase BaseTestCase 45/28445/3
Christian Kuhn [Sun, 16 Mar 2014 14:34:53 +0000 (15:34 +0100)]
[TASK] Tests: Remove extbase BaseTestCase

Lots of unit tests did inherit from extbase BaseTestCase. Meanwhile
all code of this abstract was merged to ext:core UnitTestCase and
with the refactoring of the core unit test boostrap the objectManager
that is still in this class does not work anymore.
The class is now removed, but since this is probably used in some
third party extensions, it is set as class alias to ext:core
UnitTestCase and marked as deprecated in a lecagy file, so IDEs
hint developers about this deprecation.

Change-Id: I31fb337e065aed7f03351cb04e13c68a98c93a34
Resolves: #56963
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28445
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Inherit from UnitTestCase in ext:extbase 41/28441/2
Christian Kuhn [Sun, 16 Mar 2014 13:51:22 +0000 (14:51 +0100)]
[TASK] Inherit from UnitTestCase in ext:extbase

Changes class inheritance from ext:exbase BaseTestCase
to ext:core UnitTestCase in ext:extbase

Change-Id: If2d2afbc05765b3ff1d8fa3fded17e6fb0eecd44
Resolves: #56961
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28441
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Tests: Inherit from UnitTestCase in ext:fluid 40/28440/4
Christian Kuhn [Sun, 16 Mar 2014 12:48:24 +0000 (13:48 +0100)]
[TASK] Tests: Inherit from UnitTestCase in ext:fluid

Changes class inheritance from ext:exbase BaseTestCase
to ext:core UnitTestCase in ext:fluid

Change-Id: I46667d9cb5a56f5bc29c4f2c3525c6556d5f802f
Resolves: #56958
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28440
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Tests: Do not extend from extbase BaseTestCase 34/28434/2
Christian Kuhn [Sun, 16 Mar 2014 01:00:07 +0000 (02:00 +0100)]
[TASK] Tests: Do not extend from extbase BaseTestCase

Changes all extensions except extbase and fluid to extend
from extbase ext:core UnitTestCase instead of ext:extbase
BaseTestCase.

Change-Id: Ifbb1542546f2622ece11471fd057ec469518488a
Resolves: #56949
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28434
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove renamed language command controller 33/28433/2
Ernesto Baschny [Sun, 16 Mar 2014 00:31:32 +0000 (01:31 +0100)]
[TASK] Remove renamed language command controller

Follow-up to 0d69c2d9e7b89ea63522d0b5e54aadf20ec1245d.

The renamed language command controller (language:update) was introduced
in 6.2, so we can simply remove the original name instead of deprecating
it.

This will only affect installations which are already using this task
since 6.2 alpha2.

Resolves: #54128
Releases: 6.2
Change-Id: Id6bb709bd30c9044c949c431aa2a595c1035c601
Reviewed-on: https://review.typo3.org/28433
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Set TYPO3 version to 6.2-dev 39/28439/2
TYPO3 Release Team [Sun, 16 Mar 2014 03:45:58 +0000 (04:45 +0100)]
[TASK] Set TYPO3 version to 6.2-dev

Change-Id: I58d0d08817eab7c2490d7dc65fad562ef436f402
Reviewed-on: https://review.typo3.org/28439
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.0beta7 38/28438/2 TYPO3_6-2-0beta7
TYPO3 Release Team [Sun, 16 Mar 2014 03:45:12 +0000 (04:45 +0100)]
[RELEASE] Release of TYPO3 6.2.0beta7

Change-Id: I7b0377514e702f15372338474753c2c2018b6c05
Reviewed-on: https://review.typo3.org/28438
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Check extensions in Install Tool broken 37/28437/2
Ernesto Baschny [Sun, 16 Mar 2014 03:07:23 +0000 (04:07 +0100)]
[BUGFIX] Check extensions in Install Tool broken

Since merging of 64c46b918ef016bdd1d799c5ca06e868d601f692, TYPO3_LOADED_EXT
is no longer an ArrayAccess but a regular array (like pre 6.2). This leaded
to an error in the Extension Manager important action "Check Extension",
causing an endless loop.

Catchable fatal error: Argument 2 passed to
TYPO3\CMS\Install\Controller\Action\Ajax\ExtensionCompatibilityTester
::loadExtLocalconfForExtension() must implement interface ArrayAccess,
array given

Resolves: #56952
Releases: 6.2
Change-Id: I02e83a8221653d62010952f84c17a8f6f6e185ea
Reviewed-on: https://review.typo3.org/28437
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Add htmlspecial to ShowPic file properties 36/28436/2
Ernesto Baschny [Sun, 16 Mar 2014 02:25:22 +0000 (03:25 +0100)]
[TASK] Add htmlspecial to ShowPic file properties

Follow-up to 2a85eeb6d623e74955703b254e24b958790c9a45

Resolves: #56723
Releases: 6.2
Change-Id: Ib3881b7be6f3cf87c0bc36a8a32fedcf2fa53029
Reviewed-on: https://review.typo3.org/28436
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Fix resource handling in image rendering 05/28305/4
Alexander Stehlik [Wed, 12 Mar 2014 17:41:37 +0000 (18:41 +0100)]
[BUGFIX] Fix resource handling in image rendering

The image rendering configuration of css_styled content is fixed so
that the image reference is correctly passed on through all further
methods.

The IMG_RESOURCE content object also accepts file or file reference
objects and will only pass on the file to TemplateService::getFileName()
if GIFBUILDER is used to prevent PHP warnings.

This fixes the image rendering after the imageLinkWrap function was
made FAL aware in #56723.

Releases: 6.2
Resolves: #56825
Change-Id: Ie6b0261de40b25aab26740b4d889a1eebc3e7a8c
Reviewed-on: https://review.typo3.org/28305
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Additional margin on top of ExtJS context menus 35/28435/2
Ernesto Baschny [Sun, 16 Mar 2014 01:07:05 +0000 (02:07 +0100)]
[BUGFIX] Additional margin on top of ExtJS context menus

Resolves: #56950
Releases: 6.2
Change-Id: I936f75be45447111083b9f5cae2e88d3fac1d2c5
Reviewed-on: https://review.typo3.org/28435
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Tests: Do not initialize TYPO3_DB in unit tests 32/28432/3
Christian Kuhn [Sat, 15 Mar 2014 23:19:00 +0000 (00:19 +0100)]
[TASK] Tests: Do not initialize TYPO3_DB in unit tests

Change-Id: I9d147353411314416cdf1f5196d18a127e8c5145
Resolves: #56948
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28432
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Incomplete mock of $GLOBALS['TYPO3_DB'] 31/28431/3
Christian Kuhn [Sat, 15 Mar 2014 22:52:05 +0000 (23:52 +0100)]
[BUGFIX] Tests: Incomplete mock of $GLOBALS['TYPO3_DB']

Still some unit tests rely on TYPO3_DB, mostly through the extbase
object manager. The patch fixes most occurrences and skips two
complex tests that should be moved to functional tests later.

This should be the final patch for tests accessing TYPO3_DB.

Change-Id: I8deb0fb9c13b47c8ce4262f041744def9e6b0e79
Resolves: #56947
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28431
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Improve performance of Bootstrap/PackageManager 29/28329/7
Thomas Maroschik [Sat, 15 Mar 2014 12:41:04 +0000 (13:41 +0100)]
[TASK] Improve performance of Bootstrap/PackageManager

This patch is a combined patch which tries to address
the findings from the Bootstrap/PackageManager/ClassLoader
performance analysis.

Resolves: #56934
Resolves: #56310
Resolves: #56331
Resolves: #56341
Resolves: #56538
Releases: 6.2
Change-Id: I269159906534f58eff59973ab30e170fadac10e4
Reviewed-on: https://review.typo3.org/28329
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Ensure cache clearing is done properly by EM 72/28372/8
Markus Klein [Thu, 13 Mar 2014 23:22:58 +0000 (00:22 +0100)]
[BUGFIX] Ensure cache clearing is done properly by EM

This fixes problems with access to classes from ext_localconf
files that were discarded from the classes cache at the wrong
time.

Resolves: #54906
Releases: 6.2
Change-Id: Icf650261a5ed72c36d332e3407ababf627968ab2
Reviewed-on: https://review.typo3.org/28372
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Tests: Replace objectManager with mock in ext:extbase 21/28421/5
Anja Leichsenring [Sat, 15 Mar 2014 15:25:22 +0000 (16:25 +0100)]
[BUGFIX] Tests: Replace objectManager with mock in ext:extbase

The usage of native objectManager in Extbase' BaseTestClass introduces
a dependency to the systems database. In order to reduce the unit test
bootstrap this dependency must be resolved.

Change-Id: I862664d4ca032d18f22b18677816bed1e1bc2a4a
Resolves: #56936
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28421
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] version entry script cleanup 09/28209/2
Nicole Cordes [Mon, 10 Mar 2014 00:50:13 +0000 (01:50 +0100)]
[TASK] version entry script cleanup

The patch adds usage of module dispatcher to enable CSRF protection to
version click module.

Resolves: #55675
Releases: 6.2
Change-Id: Ib31e419fd2a880052e93f3eea95d51c75d442e23
Reviewed-on: https://review.typo3.org/28209
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Prevent IconUtility to throw PHP Warning 65/28065/5
Caspar Stuebs [Tue, 4 Mar 2014 22:16:17 +0000 (23:16 +0100)]
[BUGFIX] Prevent IconUtility to throw PHP Warning

Do an array typecast while using function in_array()
Clean up the code to make it more clear

Change-Id: I97738ab4bc4e1e4c346cd25836e2b4d1f875ec23
Resolves: #56558
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/28065
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] FAL: Invalid title and broken layout 59/27259/3
Marcel Wieser [Sun, 2 Feb 2014 11:04:45 +0000 (12:04 +0100)]
[BUGFIX] FAL: Invalid title and broken layout

This fix resolves the issue of the wrong title for FAL irre relations.
Now the title of the sys_file metadata will be displayed,
if there's no title for the sys_file_reference.
Additionally the title, labels and placeholder
will be cropped if necessary.

Resolves: #55485
Releases: 6.2
Change-Id: I22b41931e10c565d83edb53ab9689311d13e811a
Reviewed-on: https://review.typo3.org/27259
Reviewed-by: Steffen Ritter
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Install Tool: Optimize permission checking and fixing 16/25416/10
Ernesto Baschny [Thu, 14 Nov 2013 12:44:02 +0000 (13:44 +0100)]
[TASK] Install Tool: Optimize permission checking and fixing

* Adjust default permissions back to "world readable" (775/664)
* Do not attempt to fix permissions on an existing folder structure
* Streamline the separation of Notices, Warnings and Errors
* Cosmetical optimizations in the "Folder Structure" item
* Also report if the default permissions are too insecure (i.e.
  world writeable / readable).

Note that the new defaults (775/664) are set to make the system work
by default on almost most scenarios, but the recommended secure setup
is still 770/660. This is on purpose to make the administrator aware
of it but will require manual intervention (i.e. "thinking") if this
setup will work or not (we cannot detect that automatically).

Resolves: #52668
Releases: 6.2
Change-Id: I77c72617fa58fd808ebc5fd818e94b48c2644102
Reviewed-on: https://review.typo3.org/25416
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Index on sys_file_processedfile is still too large 29/28429/2
Ernesto Baschny [Sat, 15 Mar 2014 20:59:25 +0000 (21:59 +0100)]
[BUGFIX] Index on sys_file_processedfile is still too large

On some systems even "332" characters is too large. To also cope with
potential utf8mb4 setups (1 char = 4 bytes), and staying under 1000 byte
limit, we reduce the amount of characters in the index to 249.

Resolves: #56786
Related: #54234
Releases: 6.2
Change-Id: I79452224f37ec2b6ca5b3a35044144eed787df67
Reviewed-on: https://review.typo3.org/28429
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Tests: Release ext:form tests from exbase base class 28/28428/2
Christian Kuhn [Sat, 15 Mar 2014 20:31:29 +0000 (21:31 +0100)]
[TASK] Tests: Release ext:form tests from exbase base class

Change-Id: I7e9f09fa747a07208bf248aa35fdf154cd1fa9c4
Resolves: #56943
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28428
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Release em tests from extbase base class 27/28427/3
Christian Kuhn [Sat, 15 Mar 2014 19:47:37 +0000 (20:47 +0100)]
[BUGFIX] Tests: Release em tests from extbase base class

Extbase BaseTestClass comes with a not mocked objectManager that
gives headaches if it is injected to a test subject. Releasing
the extensionmanager test classes from this and using core
UnitTestCase as parent reveals these parts in existing tests,
those are fixed with the patch.

Change-Id: Ia7acd7f838f9ac0eb2f44e0737893fc30c41ff55
Resolves: #56942
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28427
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years agoRevert "[BUGFIX] Implement locking in ClassLoader" 26/28426/3
Ernesto Baschny [Sat, 15 Mar 2014 19:36:47 +0000 (20:36 +0100)]
Revert "[BUGFIX] Implement locking in ClassLoader"

This reverts commit 76284d26065af1a0a5b141f5f16305a5821609fa

The implemented locking is fine, but currently breaks a fresh new
installation (when there is no typo3temp directory yet). We remove
this feature for the release of beta7 and merge it afterwards again
to be able to improve upon it during the next week before the release
candidate.

Change-Id: Ie69352e5c7e3a224b0a0c71457efe3dbb8d90aac
Reviewed-on: https://review.typo3.org/28426
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Tests: Skip some FAL tests 24/28424/4
Christian Kuhn [Sat, 15 Mar 2014 17:06:54 +0000 (18:06 +0100)]
[TASK] Tests: Skip some FAL tests

While the FAL tests were already streamlined and simplified a lot,
the ResourceStorageTest class is still a mixture of functional and
unit test that involves heavy set up code and still does not mock
dependencies properly.
This test class needs a rewrite and a clean separation of units
together with a number of working functional tests to be of any use.
For now, all tests that rely on initialized database are skipped and
marked as TODO.

Change-Id: I3191c809c50f4f19ab91b9a5b5f2f3ebc3fa47ff
Resolves: #56940
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28424
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove old hook for simulatestatic 91/27991/4
Markus Klein [Mon, 3 Mar 2014 12:25:12 +0000 (13:25 +0100)]
[TASK] Remove old hook for simulatestatic

The hook was introduced and deprecated when
simulatestatic was moved to TER for 6.0.

Furthermore the old wapversion.lib files are
not part of the Core anymore, hence we can remove
some more overhead.

Resolves: #56491
Releases: 6.2
Change-Id: Ib9c05895eed3539ac9e540b39d720038c5cacedb
Reviewed-on: https://review.typo3.org/27991
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mock in IndexerServiceTest 23/28423/2
Christian Kuhn [Sat, 15 Mar 2014 16:13:52 +0000 (17:13 +0100)]
[BUGFIX] Tests: Incomplete mock in IndexerServiceTest

Change-Id: Idad4b11894ee6e09e0b8eca9a057c7a776925a70
Resolves: #56939
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28423
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] inline BEUserAuth::getCookieName 18/28418/3
Thomas Maroschik [Sat, 15 Mar 2014 12:13:33 +0000 (13:13 +0100)]
[TASK] inline BEUserAuth::getCookieName

During bootstrapping in index_ts.php there is a check
for an existing be_typo_user cookie which enables
TimeTracking. The simple static getter triggers the loading
and parsing of BackendUserAuthentication and
AbstractUserAuthentication which are both pretty fat classes
and have an impact upon eID calls and frontend calls.

This patch inlines the cookie name retrieval and defers thus
the loading of the fat classes.

Resolves: #56316
Releases: 6.2
Change-Id: I5ce5cf92095dcb8820fb0e548e16e38a99f4f12e
Reviewed-on: https://review.typo3.org/28418
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Tests: Improve mocking in DatabaseConnectionTest 22/28422/2
Christian Kuhn [Sat, 15 Mar 2014 15:49:52 +0000 (16:49 +0100)]
[BUGFIX] Tests: Improve mocking in DatabaseConnectionTest

With the switch to mysqli object it is now possible to fully mock
and check the final database calls in DatabaseConnectionTest, the
test table can be removed after refactoring the tests.

Change-Id: I60e33f6af5b4be8111a21469d12e38843650e7c4
Resolves: #56938
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28422
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Tests: Refactor cache Typo3DatabaseBackend 20/28420/2
Christian Kuhn [Sat, 15 Mar 2014 14:28:21 +0000 (15:28 +0100)]
[TASK] Tests: Refactor cache Typo3DatabaseBackend

Tests of the Typo3DatabaseBackend are refactored to not depend on
initialized $GLOBALS['TYPO3_DB'] anymore, queries and quoting is
now performed to a mock object. Next to a better separation this
has the advantage of a nice speedup executing those tests.

Change-Id: I8fc23fec56a50e48f74422eac3ee4a07ed3669b9
Resolves: #56937
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28420
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Follow-up: .t3-table & .dblist-table 06/28406/2
Felix Kopp [Fri, 14 Mar 2014 22:16:09 +0000 (23:16 +0100)]
[BUGFIX] Follow-up: .t3-table & .dblist-table

Fixes different headers and columns paddings for .t3-table
and the former .typo3-dblist. Also fixes .row-header link
hover style where text links went black and dark gray.

Resolves: #56926
Releases: 6.2
Change-Id: I0e93ccc315f4740b87be7656df1d54cd40272be7
Reviewed-on: https://review.typo3.org/28406
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Improve mocking in ext:extbase 07/28407/6
Anja Leichsenring [Fri, 14 Mar 2014 23:02:15 +0000 (00:02 +0100)]
[BUGFIX] Tests: Improve mocking in ext:extbase

Unit tests reveal some warnings which are caused by incomplete
mocking. They all belong to $GLOBALS['LANG']

Change-Id: Ic2adda9984a530b82e259c1d8931015996f167ba
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28407
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Implement locking in ClassLoader 56/28156/21
Alexander Opitz [Fri, 7 Mar 2014 11:37:47 +0000 (12:37 +0100)]
[BUGFIX] Implement locking in ClassLoader

After cache clearing we can run in the situation that 2 processes will
rebuild the ClassLoader cache which will lead to a non useable cache,
which produces fatals. As the data is generated more than once the load
of the server increases per request while ClassLoader cache is build.

The implemented Locking will stop this issue. Every process waits till
the first is ready and then looks if data was generated and stops re-
generating the cache.

Resolves: #55099
Releases: 6.2
Change-Id: I109821b9c37ec99c5ec5dbc5bcef6223d1d0d153
Reviewed-on: https://review.typo3.org/28156
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Incomplete Mocking in ext:extensionmanager 12/28412/2
Anja Leichsenring [Sat, 15 Mar 2014 10:51:14 +0000 (11:51 +0100)]
[BUGFIX] Tests: Incomplete Mocking in ext:extensionmanager

After the removal of GLOBALS initialisation the extension raises
warnings in unittests.

Change-Id: I450932b1de1852302e4ae9861b250c5721f6032e
Resolves: #56930
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28412
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[TASK] Improve Locker 59/28159/19
Markus Klein [Fri, 7 Mar 2014 12:38:42 +0000 (13:38 +0100)]
[TASK] Improve Locker

Code cleanup for locker and fix of semaphore locking.
It is now possible to reuse a semaphore.

Resolves: #40420
Releases: 6.2
Change-Id: I843aca1f9fa3d070ce0a508a27d3c433725991fa
Reviewed-on: https://review.typo3.org/28159
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[BUGFIX] PublicURL calculation for storage 0 is wrong 95/28395/7
Steffen Ritter [Fri, 14 Mar 2014 18:04:13 +0000 (19:04 +0100)]
[BUGFIX] PublicURL calculation for storage 0 is wrong

Since the refactoring of the publicURL Feature and the possibility to
link to files via jump-scripts the generation of publicUrls for files
in storage zero is broken due to the fact that every relative base-path
for this URL is appended with a slash.

If the base-path has been empty (like for storage 0), appending a slash
makes it absolute.

This patch changes the behaviour to only append a slash on non-empty
paths.

Releases: 6.2
Resolves: #56927
Change-Id: I14e8bae0b64ed8dc537a5edbf57d9dce6ddf0932
Reviewed-on: https://review.typo3.org/28395
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Language labels missing in Localization Overview 60/28260/6
Patrick Broens [Tue, 11 Mar 2014 15:07:09 +0000 (16:07 +0100)]
[BUGFIX] Language labels missing in Localization Overview

The submodule "Localization Overview" of Web > Info is missing
language labels. These labels are requested from the wrong localization file.

This patch fixes this by changing the label calls to a different file.

Change-Id: Id6aaddf3e9bb88da30bb5008b875279b0b07daa5
Resolves: #56767
Releases: 6.2
Reviewed-on: https://review.typo3.org/28260
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Update requirejs to 2.1.11 89/28389/2
Jan Kiesewetter [Fri, 14 Mar 2014 14:21:11 +0000 (15:21 +0100)]
[TASK] Update requirejs to 2.1.11

Change-Id: I1daabdbb0e39badb3575f6cea9fd1d4bd1e95ba3
Resolves: #56913
Releases: 6.2
Reviewed-on: https://review.typo3.org/28389
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix thumbnail display for IRRE records 44/27844/5
Alexander Stehlik [Fri, 14 Mar 2014 11:39:05 +0000 (12:39 +0100)]
[BUGFIX] Fix thumbnail display for IRRE records

The system will only generate a thumbnail for IRRE records if the
related file object is an image file.

Additionally the UID of the file reference will be used as alternative
text and as title for the thumbnail so that it behaves like the icon
that is used for non-image files.

Resolves: #56274
Releases: 6.2
Change-Id: Ibe6530368434c384d5b7cca93e81b656c8c56383
Reviewed-on: https://review.typo3.org/27844
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Remove unmaintainable testclass 01/28401/4
Anja Leichsenring [Fri, 14 Mar 2014 20:54:10 +0000 (21:54 +0100)]
[TASK] Remove unmaintainable testclass

The test class contains only one test, but to execute this,
it depends on many classes which are not all properly mocked and a
nightmare to maintain. Additionally the test has nothing
to do with the execution of tasks, so subject scope is not met.

To keep test maintenance a doable task this test class in removed.

Change-Id: I97ac02040cb6dc711dcc300fb84c15c6785736e2
Resolves: #56924
Relates: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28401
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix Content-Disposition header sent by dumpFileContents 99/28399/3
Frans Saris [Fri, 14 Mar 2014 19:53:40 +0000 (20:53 +0100)]
[BUGFIX] Fix Content-Disposition header sent by dumpFileContents

This patch changes the Content-Disposition header so it is also
send when $asDownload isn't set with value inline and the filename
is between quotes.

Resolves: #56923
Releases: 6.2
Change-Id: Ic47c7d3743e7bac73936d20addbc61193e6fd49c
Reviewed-on: https://review.typo3.org/28399
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Remove ExtJS normalization 69/28069/6
Ernesto Baschny [Thu, 13 Mar 2014 19:29:02 +0000 (20:29 +0100)]
[BUGFIX] Remove ExtJS normalization

To avoid conflicts with normalize.css, we remove the normalization done by
ExtJS, which is loaded after the normalize.css now.

Resolves: #56418
Releases: 6.2
Change-Id: I8a5b633244c5074755d478d0497b8f438ef86b65
Reviewed-on: https://review.typo3.org/28069
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] RootlineUtility does not consider disablefield 77/28277/4
Christian Reiter [Tue, 11 Mar 2014 19:50:01 +0000 (20:50 +0100)]
[BUGFIX] RootlineUtility does not consider disablefield

Make sure RootlineUtility::enrichWithRelationFields() respects
the setting of $TCA[$table]['ctrl']['enablecolumns']['disabled'] when
fetching foreign data for the rootline.

Otherwise hidden relations from sys_file_reference are added to the
rootline and cause exceptions in the frontend, instead of being ignored.

Resolves: #56150
Releases: 6.2, 6.1
Change-Id: I21917fec1407a10818058da8ea879b0bb39441a4
Reviewed-on: https://review.typo3.org/28277
Tested-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Incomplete mocking in PreparedStatementTest 98/28398/2
Christian Kuhn [Fri, 14 Mar 2014 19:11:56 +0000 (20:11 +0100)]
[BUGFIX] Tests: Incomplete mocking in PreparedStatementTest

Release PreparedStatementTest from an active DB connection. The
quote tests are refactored a bit to find out in one specific test
if it is done for parameters.

Change-Id: I37853cd49368c2b23d0c2d6926fc806618674279
Resolves: #56922
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28398
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Refactor log writer tests in ext:core 96/28396/3
Christian Kuhn [Fri, 14 Mar 2014 18:24:24 +0000 (19:24 +0100)]
[BUGFIX] Tests: Refactor log writer tests in ext:core

Test files and class naming is adapted to subject class names in
ext:core Log/Writer and the DatabaseWriterTests are rewritten to
not depend on initialized database connection anymore.

Change-Id: Ifff4e5a064018bb5b0db3bf9eeb1b9232adfb262
Resolves: #56921
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28396
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Better mocking in ext:core 94/28394/2
Christian Kuhn [Fri, 14 Mar 2014 16:19:24 +0000 (17:19 +0100)]
[BUGFIX] Tests: Better mocking in ext:core

Some tests still rely on initialized $GLOBALS['TYPO3_DB']. The patch
handles some easy cases in ext:core.

Change-Id: I5b720154035cc5f8b156a9358806673daaf9c9ec
Resolves: #56918
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28394
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] JavaScript generation in RTE element browser 38/28338/2
Alexander Stehlik [Thu, 13 Mar 2014 10:23:21 +0000 (11:23 +0100)]
[BUGFIX] JavaScript generation in RTE element browser

The JavaScript in the RTE element browser is now initialized at the
end of the initialization process to make sure that all required
class variables (like $this->act) are initialized.

Resolves: #56860
Releases: 6.2
Change-Id: I39d3223921c5b17cffb31d98d62f02fa46663d27
Reviewed-on: https://review.typo3.org/28338
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Tests: Incomplete mocking in ext:fluid 90/28390/2
Christian Kuhn [Fri, 14 Mar 2014 14:26:43 +0000 (15:26 +0100)]
[BUGFIX] Tests: Incomplete mocking in ext:fluid

Change-Id: I4bd6ff219c3232211106e968fce45ee3f2dd674a
Resolves: #56914
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28390
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Incomplete mocking in backend condition matcher 88/28388/3
Christian Kuhn [Fri, 14 Mar 2014 14:17:25 +0000 (15:17 +0100)]
[BUGFIX] Tests: Incomplete mocking in backend condition matcher

Mock deterimenRootline to suppress calling database stuff
in dependencies.

Change-Id: I54938f9e20d52eda568c6520fa7bd72ec19b61e2
Resolves: #56912
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28388
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Remove not maintainable test 84/28384/3
Christian Kuhn [Fri, 14 Mar 2014 12:07:50 +0000 (13:07 +0100)]
[TASK] Remove not maintainable test

ext:backend test getNodesSetsIsMountPointField() works on getNode()
of PageTree DataProvider. The method has tons of dependencies that
are sometimes even static, and the method is recursive. It is very
hard to test properly and the current test is still not mocking
completly. The test is removed for now since it does not give us
much benefit and is hard to maintain in current state, the subject
method should be covered by tests again if it was refactored.

Change-Id: I344c584b4d6e3868471f4857a08223be3a5d03e4
Resolves: #56907
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28384
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn