Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Trigger extension update correctly 12/38012/2
Nicole Cordes [Sun, 22 Mar 2015 21:39:30 +0000 (22:39 +0100)]
[BUGFIX] Trigger extension update correctly

If you start the extension manager with a filtered list not all elements
receive the "click" event handler. Therefore the update function isn't
triggered but the link is processed directly. This patch changes the
Javascript so even hidden extension receive the event handler.

Resolves: #65906
Releases: master
Change-Id: Ib6c007db6ce34d12af0620bac49237d1e113e32b
Reviewed-on: http://review.typo3.org/38012
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Increase constrast of backend module menu 06/38006/2
Andreas Fernandez [Sun, 22 Mar 2015 19:13:27 +0000 (20:13 +0100)]
[TASK] Increase constrast of backend module menu

Resolves: #65898
Releases: master
Change-Id: Idb477309258749fc05309dc69f79165971370cba
Reviewed-on: http://review.typo3.org/38006
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[TASK] Set imagecols by default in PHP, not UserTSconfig 09/38009/3
Benjamin Mack [Sun, 22 Mar 2015 20:47:04 +0000 (21:47 +0100)]
[TASK] Set imagecols by default in PHP, not UserTSconfig

EXT:frontend defines "imagecols" with the default value "1"
but overrides it for TCAdefaults via UserTSconfig to "2".
This can be simplified by doing this directly in PHP.

Resolves: #65903
Releases: master
Change-Id: I72ef2d3f7845e298ccd3116340a887ae1a86e5f9
Reviewed-on: http://review.typo3.org/38009
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Remove notifications.js from EM 13/38013/2
Andreas Fernandez [Sun, 22 Mar 2015 21:44:49 +0000 (22:44 +0100)]
[TASK] Remove notifications.js from EM

Remove the ExtJS Dialog builder from EM as we don't use ExtJS there anymore.

Resolves: #65908
Releases: master
Change-Id: I012bb45145e975c538bd035be4b3285880a5ea6c
Reviewed-on: http://review.typo3.org/38013
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK][FOLLOWUP] Optimize loading of locallang strings in JavaScript 03/38003/2
Andreas Fernandez [Sun, 22 Mar 2015 17:07:36 +0000 (18:07 +0100)]
[TASK][FOLLOWUP] Optimize loading of locallang strings in JavaScript

Rename the method and check if TYPO3_MODE is FE before converting the strings
to UTF-8.

Resolves: #65899
Releases: master
Change-Id: I139f6ceb24a1243be23ad1aec42385f1db0eb121
Reviewed-on: http://review.typo3.org/38003
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] helhum/class-alias-loader version in composer.json 21/37921/2
Alexander Stehlik [Wed, 18 Mar 2015 12:56:20 +0000 (13:56 +0100)]
[BUGFIX] helhum/class-alias-loader version in composer.json

The version that is currently used in the core is 1.1.*.

The requirement for helhum/class-alias-loader is raised from
1.0.*@dev to 1.1.*@dev to match the version that is shipped with
the core.

Releases: master, 6.2
Resolves: #65804
Change-Id: I7603aa9271cea9c889bed65292e3ca1db9e9442b
Reviewed-on: http://review.typo3.org/37921
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Remove directory typo3/mod/ 04/38004/6
Benjamin Mack [Sun, 22 Mar 2015 17:19:12 +0000 (18:19 +0100)]
[TASK] Remove directory typo3/mod/

All main modules from the Backend are now
registered directly in the initialization and not
in separate files in order to avoid inclusion of
small PHP files. The mod/ directory can safely
be removed now.

Resolves: #65900
Releases: master
Change-Id: I175a8c8899fe1df4f891abd9fc6221419a9a7e93
Reviewed-on: http://review.typo3.org/38004
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Remove modernizr from Backend 01/38001/3
Benjamin Mack [Sun, 22 Mar 2015 16:10:39 +0000 (17:10 +0100)]
[TASK] Remove modernizr from Backend

Modernizr is not used in the TYPO3 Backend at all
anymore as modern browsers support the options
supported by modernizr we used up to 7.1 already.

It is therefore removed from the backend.

Resolves: #65896
Releases: master
Change-Id: I84a0e960f7ac0164564709a7821a7085a97a37c0
Reviewed-on: http://review.typo3.org/38001
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Remove charset conversion for ajax.php calls 94/37994/2
Benjamin Mack [Sun, 22 Mar 2015 11:24:27 +0000 (12:24 +0100)]
[TASK] Remove charset conversion for ajax.php calls

When ajax.php was introduced for TYPO3 CMS 4.2
the main target was to introduce a proper API to also
deal with different charsets used in the Backend.

Nowadays the request charset and the AJAX call
are the same (UTF-8 only) for all Backend calls,
so this functionality has no effect anymore and
can be safely removed.

Resolves: #65890
Releases: master
Change-Id: I9750b9272cb46af8b17fb066878a420d22c0c157
Reviewed-on: http://review.typo3.org/37994
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Make alt_file_navframe.php dispatched 11/37611/4
Wouter Wolters [Fri, 6 Mar 2015 18:19:53 +0000 (19:19 +0100)]
[TASK] Make alt_file_navframe.php dispatched

Resolves: #65293
Releases: master
Change-Id: I4528cdeb58b29ed5528222485254bcc7aba73dc3
Reviewed-on: http://review.typo3.org/37611
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Move typo3/js/extjs/* files to EXT:backend 97/37997/2
Benjamin Mack [Sun, 22 Mar 2015 14:22:37 +0000 (15:22 +0100)]
[TASK] Move typo3/js/extjs/* files to EXT:backend

In order to get the typo3/ directory cleaner, all files
related to extjs are moved to EXT:backend in
the appropriate place.

Resolves: #65894
Releases: master
Change-Id: Ib116309a6efb07b4a3bfb3bfb5cad1fe38b87529
Reviewed-on: http://review.typo3.org/37997
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FOLLOWUP] Initialize TYPO3.lang properly without ExtJS 02/38002/2
Frank Nägler [Sun, 22 Mar 2015 16:48:27 +0000 (17:48 +0100)]
[FOLLOWUP] Initialize TYPO3.lang properly without ExtJS

Removes console.log from Lang.js

Resolves: #65879
Releases: master
Change-Id: I2e848c3944e197efc61c92094c0f6321108f1aa0
Reviewed-on: http://review.typo3.org/38002
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Streamline lowlevel form fields 20/37620/4
Benjamin Kott [Sat, 7 Mar 2015 14:19:43 +0000 (15:19 +0100)]
[TASK] Streamline lowlevel form fields

Releases: master
Resolves: #65588
Change-Id: Ibe42acaf7ad540b75b94af06f3e5a45a6261c6a6
Reviewed-on: http://review.typo3.org/37620
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Initialize TYPO3.lang properly without ExtJS 99/37999/5
Andreas Fernandez [Sun, 22 Mar 2015 15:16:39 +0000 (16:16 +0100)]
[BUGFIX] Initialize TYPO3.lang properly without ExtJS

TYPO3.lang currently bases heavily on ExtJS module "Typo3Lang". Port the
base functionality to a new RequireJS module and transform the nested object
to a flat object.

Resolves: #65879
Releases: master
Change-Id: Icf28724a0ac43ef18191de75152b2654e2295ef7
Reviewed-on: http://review.typo3.org/37999
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Remove unneeded function call in TYPO3 Bootstrap 95/37995/5
Benjamin Mack [Sun, 22 Mar 2015 12:43:54 +0000 (13:43 +0100)]
[TASK] Remove unneeded function call in TYPO3 Bootstrap

The method "loadAdditionalConfigurationFromExtensions()"
inside the TYPO3 Bootstrap is just used as a wrapper
now for calling the extLocalconf method itself,
and only used within the Bootstrap class within the boostrap->loadTypo3LoadedExtAndExtLocalconf() method.

Resolves: #65892
Releases: master
Change-Id: I993221e2152ee9b0128dd61379828789fe033a2e
Reviewed-on: http://review.typo3.org/37995
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Open modal over complete backend and cleanup 81/37981/2
Frank Nägler [Fri, 20 Mar 2015 21:40:59 +0000 (22:40 +0100)]
[BUGFIX] Open modal over complete backend and cleanup

Open modal over complete backend window and not only on
current frame. And cleanup the old HTML on dismiss by register
the event 'modal-dismiss'.

Resolves: #65878
Releases: master
Change-Id: I9f9284344021d73d39643aba443c14d5f39e2cbc
Reviewed-on: http://review.typo3.org/37981
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Change duplicate lable key search to search_whole_database 00/38000/2
Jan Helke [Sun, 22 Mar 2015 15:48:04 +0000 (16:48 +0100)]
[BUGFIX] Change duplicate lable key search to search_whole_database

This patch fixes the issue that the Seach-button in the Configuration
module is wrongly names Search whole database.

Resolves: #65895
Related: #64137
Releases: master
Change-Id: Ifd4987ac569b20b2d1a55906db41741ec175e1b8
Reviewed-on: http://review.typo3.org/38000
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Use LOWER instead of LCASE 53/37953/2
Andreas Fernandez [Thu, 19 Mar 2015 13:47:35 +0000 (14:47 +0100)]
[TASK] Use LOWER instead of LCASE

Most databases have the lowercase function "LOWER", but MySQL has
also "LCASE", which is an alias for LOWER. Use LOWER now to
have a common method call.

Resolves: #65844
Releases: master, 6.2
Change-Id: I84aec1164817252b18e5affe804791e78dab94b0
Reviewed-on: http://review.typo3.org/37953
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] Download documentation for extension in documentation module 80/37980/2
Tymoteusz Motylewski [Fri, 20 Mar 2015 20:28:58 +0000 (21:28 +0100)]
[BUGFIX] Download documentation for extension in documentation module

Fix the warning when trying to download documentation
for extension in TYPO3 7.2

Resolves: #65877
Releases: master
Change-Id: I98624eb8f0bd5bddd5390151f9cb09b86f6b279e
Reviewed-on: http://review.typo3.org/37980
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Migrate cshmanual javascript to AMD module 37/37837/8
Frank Nägler [Sat, 14 Mar 2015 00:01:00 +0000 (01:01 +0100)]
[TASK] Migrate cshmanual javascript to AMD module

This patch remove the old contexthelp.js and introduce a new AMD
module. With the new ContextHelp we introduce bootstraps popover.

Resolves: #65735
Releases: master
Change-Id: If44dc2ed1301cbef10ce33100c4a2c6a1cbf73f3
Reviewed-on: http://review.typo3.org/37837
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] RTE: Paste structure does not remove on[event] attributes 60/37960/2
Stanislas Rolland [Thu, 19 Mar 2015 18:16:49 +0000 (14:16 -0400)]
[BUGFIX] RTE: Paste structure does not remove on[event] attributes

Fix regular expression.

Releases: master, 6.2
Resolves: #65853
Change-Id: I180c7a8b2f62a83d507d012ce82c7224ba0e9652
Reviewed-on: http://review.typo3.org/37960
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: formatblock configuration may raise JavaScript error 05/37805/3
Stanislas Rolland [Wed, 18 Mar 2015 21:38:56 +0000 (17:38 -0400)]
[BUGFIX] RTE: formatblock configuration may raise JavaScript error

The RTE then fails to load.
Solution: Check for the presence of configured formatblock options.

Releases: master
Resolves: #65710
Change-Id: I16045aa4ef02400b71ad0109acf2ff4ed1304ff0
Reviewed-on: http://review.typo3.org/37805
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[FEATURE] RTE: Add property buttons.abbreviation.removeFieldsets 87/34287/7
Stanislas Rolland [Fri, 6 Feb 2015 20:26:42 +0000 (15:26 -0500)]
[FEATURE] RTE: Add property buttons.abbreviation.removeFieldsets

The configuration property specifies a list of fieldsets to remove from
the abbreviation dialogue. Possible string values are: acronym,
definedAcronym, abbreviation, definedAbbreviation

Releases: master
Resolves: #63040
Resolves: #64165

Change-Id: I8c25279d8aa00b33f285ef8091d3f92ca25c1e1d
Reviewed-on: http://review.typo3.org/34287
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Paste structure fails in Google Chrome 54/37954/3
Stanislas Rolland [Thu, 19 Mar 2015 15:03:28 +0000 (11:03 -0400)]
[BUGFIX] RTE: Paste structure fails in Google Chrome

Solution: Always try to use clipboardData in all browsers.

Releases: master, 6.2
Resolves: #65693
Change-Id: I59f7f85de482b27a9f66de71baf22787026efae0
Reviewed-on: http://review.typo3.org/37954
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[FOLLOWUP][BUGFIX] Fix PHP warning in shouldFieldBeOverlaid() 28/37928/2
Markus Klein [Wed, 18 Mar 2015 16:26:50 +0000 (17:26 +0100)]
[FOLLOWUP][BUGFIX] Fix PHP warning in shouldFieldBeOverlaid()

We have to check the type of the variable properly.
In case we have a non-empty array, we must not run trim() on it.

Releases: master, 6.2
Resolves: #60998
Change-Id: I3bef04a3e64d4c811c71a110fa0bfba4fc3fc361
Reviewed-on: http://review.typo3.org/37928
Reviewed-by: Florian Engelke <engelke@louis.info>
Tested-by: Florian Engelke <engelke@louis.info>
Reviewed-by: Wolfgang Baumgartner <wolfgang.baumgartner@hswt.de>
Tested-by: Wolfgang Baumgartner <wolfgang.baumgartner@hswt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Set session cookie when FE_SESSION_KEY is used 13/34013/2
Nils Heuermann [Wed, 12 Nov 2014 13:29:42 +0000 (14:29 +0100)]
[BUGFIX] Set session cookie when FE_SESSION_KEY is used

When a FE_SESSION_KEY is set in get/post data the cookie for the
frontend user session should be set. Due to changes in #55549 this did
not happen any more. dontSetCookie is now set to FALSE so that the
cookie is set again.

Resolves: #62100
Releases: master, 6.2
Change-Id: Iba9ee3298ba6ff3323ce862c0943cff5d35495d8
Reviewed-on: http://review.typo3.org/34013
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FOLLOWUP][BUGFIX] DataHandler: Cache TCA field eval array 37/37937/4
Nicole Cordes [Wed, 18 Mar 2015 21:43:32 +0000 (22:43 +0100)]
[FOLLOWUP][BUGFIX] DataHandler: Cache TCA field eval array

This fixes failing functional tests.

Resolves: #63670
Releases: master
Change-Id: Ief6ec0d6a1d2f45a7b8cb512741af722807aad9d
Reviewed-on: http://review.typo3.org/37937
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] RTE: formattext configuration may raise JavaScript error 35/37935/2
Stanislas Rolland [Wed, 18 Mar 2015 21:17:39 +0000 (17:17 -0400)]
[BUGFIX] RTE: formattext configuration may raise JavaScript error

Check if any option is configured.

Releases: master
Resolves: #65830
Change-Id: I3e41d630cdbcee4eabfad81fa955ad3cb148a073
Reviewed-on: http://review.typo3.org/37935
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] DataHandler: Cache TCA field eval array 86/35186/16
Stephan Großberndt [Wed, 24 Dec 2014 00:21:32 +0000 (01:21 +0100)]
[BUGFIX] DataHandler: Cache TCA field eval array

Introduce a runtime cache for the eval values of TCA input and text
fields. This improves performance for bulk inserts since
DataHandler->checkValue_input and checkValue_text are called for each
according field of each record and the available evaluations do not
change during a call. If no eval is set, do not execute
checkValue_*_Eval functions at all.

Additionally align usages of getMemoryCache() to runtimeCache and
keys of nestedElementCalls and elementsToBeDeleted in cache_runtime.

Resolves: #63670
Releases: master, 6.2
Change-Id: I3d2122a61e3194402743fa0b364d6bd80d4e72dc
Reviewed-on: http://review.typo3.org/35186
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] Indexed_search: Fix access to 'blind' settings in extbase plugin 29/37929/2
Tymoteusz Motylewski [Tue, 17 Mar 2015 18:21:02 +0000 (19:21 +0100)]
[BUGFIX] Indexed_search: Fix access to 'blind' settings in extbase plugin

$this->settings['blind.'] always return null in extbase context,
we should use ['blind'] instead.

Resolves: #65816
Releases: master, 6.2
Change-Id: Ia64bf15dd6cde04f22b0184431c01e4d482fb113
Reviewed-on: http://review.typo3.org/37929
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Classes available in the Insert/Modify image dialogue 17/37917/3
Stanislas Rolland [Wed, 18 Mar 2015 02:23:05 +0000 (22:23 -0400)]
[BUGFIX] Classes available in the Insert/Modify image dialogue

Problem: If classes are configured for images, the current image
tab raises a JavaScript error.
Solution: Method parameter quotes should be escaped.

Releases: master
Resolves: #65330
Change-Id: I6b2a6dc7ec9154adf857e6c6286c419a00a02289
Reviewed-on: http://review.typo3.org/37917
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Resolve class name from aliases managed by composer 15/37915/3
Helmut Hummel [Fri, 13 Mar 2015 15:27:02 +0000 (16:27 +0100)]
[BUGFIX] Resolve class name from aliases managed by composer

The old class loader has API to return the original class name
when given an alias. This API was not respected when implementing
composer class loading with #64361 with the result that it was
broken for all classes and aliases managed by the composer class loader.

To address this issue, the composer class loader is now injected into
the old class alias map, so that it can resolve class names from aliases
managed by it.

Related: #64361
Resolves: #65667
Releases: 6.2, master
Change-Id: If0b5098d72147fe7d76e97ee61c81d87cad72b4b
Reviewed-on: http://review.typo3.org/37915
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Don't define extTarget = _top as default 97/37897/3
Benjamin Mack [Tue, 17 Mar 2015 08:56:29 +0000 (09:56 +0100)]
[TASK] Don't define extTarget = _top as default

In the past, External links not generated via RTE/parseFunc,
e.g. just plain typolink, had the target="_top" attribute, which
in sites without frames is the same as not setting the target.

As frames are extraordinary these days, the default should be
to not set the extTarget at all by default, but let CSS Styled
Content set the extTarget to blank.

Resolves: #65783
Releases: master
Change-Id: Ifba46110ad4d099691530421c34b54e9da502f69
Reviewed-on: http://review.typo3.org/37897
Reviewed-by: Thomas Schlumberger <thomas@b13.de>
Tested-by: Thomas Schlumberger <thomas@b13.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[FEATURE] Add backend user groups to backend user module 99/36499/14
Ingo Pfennigstorf [Mon, 2 Feb 2015 09:41:00 +0000 (10:41 +0100)]
[FEATURE] Add backend user groups to backend user module

The backend user module lacks the possibility to easily list and
edit backend user groups. Add this functionality now.

Resolves: #64686
Releases: master
Change-Id: I5ddbdd03de2248619e0937d4d35e3998cbc83e40
Reviewed-on: http://review.typo3.org/36499
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Tested-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[FOLLOWUP][BUGFIX] Handle exceptions in Logging API 38/37638/3
Steffen Müller [Sun, 8 Mar 2015 14:43:28 +0000 (15:43 +0100)]
[FOLLOWUP][BUGFIX] Handle exceptions in Logging API

Do not run exceptions through json_encode() but convert them to strings
first.

Resolves: #65577
Releases: master, 6.2
Change-Id: I8c893f64942f8ec18aed1cef5a276345b3f568fe
Reviewed-on: http://review.typo3.org/37638
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Use mod.linkvalidator settings in scheduler 13/26513/6
Alexander Stehlik [Sun, 1 Feb 2015 11:58:02 +0000 (12:58 +0100)]
[BUGFIX] Use mod.linkvalidator settings in scheduler

Since mod.linkvalidator is used in all other places in the linkvalidator
as TSConfig key it is now also used in the scheduler to override existing
TSConfig.

To maintain backward compatibility the old mod.tx_linkvalidator setting
will be respected and a deprecation warning will be logged.

Resolves: #51360
Releases: master
Change-Id: I6e6692d2ff6543f1154e4d64feb52efc5cdfcf83
Reviewed-on: http://review.typo3.org/26513
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Do not remove FE session cookie if fe_user is logged in 60/37160/4
Markus Klein [Tue, 24 Feb 2015 11:48:14 +0000 (12:48 +0100)]
[BUGFIX] Do not remove FE session cookie if fe_user is logged in

We ensure that the session cookie is preserved when a user is logged in
and the fe_login_mode is set to "all".

Resolves: #65223
Releases: master, 6.2
Change-Id: Id9e9d56b90215f6e0d7310ff191ab4488a802bb0
Reviewed-on: http://review.typo3.org/37160
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Code style cleanup EXT:backend/Classes/Backend/*.php 50/37850/2
Michael Oehlhof [Sun, 15 Mar 2015 08:32:21 +0000 (09:32 +0100)]
[TASK] Code style cleanup EXT:backend/Classes/Backend/*.php

Fixed code style issues "Unnecessary fully qualified name"

Resolves: #65739
Releases: master
Change-Id: I376b9ce9b1b075a8d5ffc7537b0738f227dc3e88
Reviewed-on: http://review.typo3.org/37850
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Enhance input clearer accessibility 64/37864/2
Benjamin Kott [Sun, 15 Mar 2015 18:48:53 +0000 (19:48 +0100)]
[TASK] Enhance input clearer accessibility

- Hide clearer for assistive technology
- Remove clearer from tabindex

Releases: master
Resolves: #65750
Change-Id: I97afb0820ffc1d374847bed405e7ccc272f36dec
Reviewed-on: http://review.typo3.org/37864
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Shorten namespaces in EXT:frontend 01/37801/6
Frank Nägler [Thu, 12 Mar 2015 22:27:03 +0000 (23:27 +0100)]
[TASK] Shorten namespaces in EXT:frontend

Resolves: #65706
Releases: master
Change-Id: Idaf2d06d8f0b209a8a052a9b7635092dd752ecfa
Reviewed-on: http://review.typo3.org/37801
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Correct typo of ActionService->getDataHandler() 57/37857/2
Stephan Großberndt [Sun, 15 Mar 2015 13:39:57 +0000 (14:39 +0100)]
[BUGFIX] Correct typo of ActionService->getDataHandler()

Fix typo in method name "getDataHander" of TYPO3\CMS\Core\Tests\
Functional\DataHandling\Framework\ActionService and its usages.

Resolves: #65746
Releases: master, 6.2
Change-Id: I85dd7fe93b89e51d156ab25dbdb2c84f40afa337
Reviewed-on: http://review.typo3.org/37857
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Allow to disable Info->PageTSconfig again 97/37697/2
Markus Klein [Tue, 10 Mar 2015 11:31:36 +0000 (12:31 +0100)]
[BUGFIX] Allow to disable Info->PageTSconfig again

The patch for #49992 changed the identifier for the module function
to the namespaced class name, which breaks the documented option
mod.web_info.menu.function.tx_infopagetsconfig_webinfo = 0

Change this back to 'tx_infopagetsconfig_webinfo' in order to make
the config option working again.

Resolves: #65638
Releases: master, 6.2
Change-Id: Ica197143da1e63d61d06100c0b0832096debce62
Reviewed-on: http://review.typo3.org/37697
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Replace uniqid() usages in Tests 56/37856/4
Stephan Großberndt [Sun, 15 Mar 2015 13:32:12 +0000 (14:32 +0100)]
[BUGFIX] Replace uniqid() usages in Tests

Replace usage of uniqid() with BaseTestCase->getUniqueId() and correct
method name in comments.

Resolves: #65744
Releases: master
Change-Id: I492c0aafb7ec58085872e031a5ec9ce234f301f2
Reviewed-on: http://review.typo3.org/37856
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FOLLOWUP][TASK] Remove initialization for fileFactory 62/37862/2
Markus Klein [Sun, 15 Mar 2015 17:56:10 +0000 (18:56 +0100)]
[FOLLOWUP][TASK] Remove initialization for fileFactory

The getter must not be public.

Resolves: #65734
Releases: master
Change-Id: I347bf403ee25e1abf9f34e39f2104a19e6bdb1f8
Reviewed-on: http://review.typo3.org/37862
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove initialization for fileFactory in AbstractContentObject 43/37843/4
Wouter Wolters [Sat, 14 Mar 2015 16:26:59 +0000 (17:26 +0100)]
[TASK] Remove initialization for fileFactory in AbstractContentObject

Resolves: #65734
Releases: master
Change-Id: I373838b19ebc6e4df010af498d4433ccbdb835c7
Reviewed-on: http://review.typo3.org/37843
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Use constants instead of raw bitmask values 55/37455/13
Andreas Fernandez [Mon, 2 Mar 2015 13:19:51 +0000 (14:19 +0100)]
[TASK] Use constants instead of raw bitmask values

The used bitmasks of JsConfirmation and Permission are put
into "enums" and their representing constants are used instead
of the raw bitmask values.

Resolves: #65455
Releases: master
Change-Id: I1910bb960b69836ea29c16c91d730ac74c22f929
Reviewed-on: http://review.typo3.org/37455
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Category fields are not added to TCA interface section 33/30333/5
Oliver Hader [Thu, 22 May 2014 13:41:37 +0000 (15:41 +0200)]
[TASK] Category fields are not added to TCA interface section

$TCA[<table>]['interface']['showRecordFieldList'] contains a list
of fields that is used for visualizing
* accordant element details (record info)
* differences in the workspaces detail view

Fields that are treated as category should appear automatically.
If using CategoryRegistry::add() in extensions, the option
property "interface" can be used to disable this automated
handling in the interface section - in that case it needs
to be FALSE.

Resolves: #59042
Releases: master, 6.2
Change-Id: Id51aaf5d057a70cb9b8c230da3f9335f74c9850a
Reviewed-on: http://review.typo3.org/30333
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FEATURE] Add API for requestedId 28/36828/3
Frederic Gaus [Wed, 11 Feb 2015 13:43:02 +0000 (14:43 +0100)]
[FEATURE] Add API for requestedId

Add an API to TypoScriptFrontendController to receive the original
requested ID.

Change-Id: I16a0ce39bd10bc94f47258e60ad4bfa33f6a59ea
Resolves: #52693
Releases: master
Reviewed-on: http://review.typo3.org/36828
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Show suited TYPO3 versions at distributions 90/37790/7
Andreas Fernandez [Thu, 12 Mar 2015 14:17:41 +0000 (15:17 +0100)]
[TASK] Show suited TYPO3 versions at distributions

Show the suited TYPO3 version of each distribution. If a distribution
does matches the used TYPO3 version, show the version numbers in a
"success" label.

Resolves: #65680
Releases: master, 6.2
Change-Id: Ib65834c1856b5d0cdde7e7bb477743b4d95e2dc4
Reviewed-on: http://review.typo3.org/37790
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Cygwin support 65/36765/3
Frederic Gaus [Mon, 9 Feb 2015 10:52:39 +0000 (11:52 +0100)]
[BUGFIX] Cygwin support

Cygwin is a GNU UNIX emulation layer for Windows systems.
With this patch the TYPO3 OS detection will recognize when
running on cygwin and thus TYPO3_OS won't be defined as 'WIN'.

Change-Id: I8e04b1858bcd0baa4aeeaf066f4e0b391dd08eb2
Resolves: #14523
Releases: master
Reviewed-on: http://review.typo3.org/36765
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Use local variable for $GLOBALS in PageRepository 02/37802/3
Wouter Wolters [Thu, 12 Mar 2015 22:44:46 +0000 (23:44 +0100)]
[TASK] Use local variable for $GLOBALS in PageRepository

Resolves: #65707
Releases: master
Change-Id: I6686cb9dff3f2d815d62183626f950b992897b96
Reviewed-on: http://review.typo3.org/37802
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Avoid fatal for unserializable extension configuration 61/37761/2
Stephan Großberndt [Wed, 11 Mar 2015 22:31:17 +0000 (23:31 +0100)]
[BUGFIX] Avoid fatal for unserializable extension configuration

unserialize() might not return an array if something is wrong in an
extensions configuration. Avoid the fatal error in
ArrayUtility::flatten() by making sure it is an (empty) array.

Resolves: #65576
Releases: master, 6.2
Change-Id: I8ba5fe4dd32e3c43398ef646a6a89518537e10ba
Reviewed-on: http://review.typo3.org/37761
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Missing use statement in FormEngineUtility 58/37858/2
Frank Nägler [Sun, 15 Mar 2015 15:38:18 +0000 (16:38 +0100)]
[BUGFIX] Missing use statement in FormEngineUtility

Resolves: #65749
Releases: master
Change-Id: I75e91b99750990bec19d3f8cc446f3948b35cd24
Reviewed-on: http://review.typo3.org/37858
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Use ::class instead of strings 98/37798/3
Frank Nägler [Thu, 12 Mar 2015 19:29:06 +0000 (20:29 +0100)]
[TASK] Use ::class instead of strings

In some cases makeInstance is used with strings instead
of ::class. This patch fix it.

Resolves: #65704
Releases: master
Change-Id: I69afa653f50efbebaa7456acfb5d20f401e639fb
Reviewed-on: http://review.typo3.org/37798
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Centralize duplicated SpriteManagerIconViewHelper 48/37848/3
Frank Nägler [Sat, 14 Mar 2015 23:17:29 +0000 (00:17 +0100)]
[TASK] Centralize duplicated SpriteManagerIconViewHelper

This patch removes the SpriteManagerIconViewHelper (duplicated with
#65111) from EXT:beuser and changes the templates to use the original
one from EXT:backend.

Resolves: #65737
Releases: master
Change-Id: I85ef64404d358b6e9fcb409957f65518c9e3a36f
Reviewed-on: http://review.typo3.org/37848
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Remove configuration for alt_db_navframe.php 04/37604/2
Wouter Wolters [Fri, 6 Mar 2015 17:48:42 +0000 (18:48 +0100)]
[TASK] Remove configuration for alt_db_navframe.php

Remove configuration for alt_db_navframe.php in typo3/mod/web/conf.php

Resolves: #65579
Releases: master
Change-Id: I6c4400abf3e8d9cbbc7934456794ee2bc3d3d31d
Reviewed-on: http://review.typo3.org/37604
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Make Repository::findByIdentifier() call the storage-backend 25/35325/3
Stefan Neufeind [Thu, 11 Dec 2014 22:10:39 +0000 (23:10 +0100)]
[TASK] Make Repository::findByIdentifier() call the storage-backend

Instead of creating a query itself, the Repository should
use existing functionality of the storage-backend.

Change-Id: I8f19b2e7f3c25bee2998d33e59727455d679b67d
Resolves: #63792
Releases: master
Reviewed-on: http://review.typo3.org/35325
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Use !empty instead of count in TextContentObject 42/37842/2
Wouter Wolters [Sat, 14 Mar 2015 16:11:59 +0000 (17:11 +0100)]
[TASK] Use !empty instead of count in TextContentObject

Resolves: #65733
Releases: master
Change-Id: I3f327981b95995be1199a20b186c554863bbc8fb
Reviewed-on: http://review.typo3.org/37842
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Fix CGL violations 35/37835/2
Frank Nägler [Fri, 13 Mar 2015 21:03:54 +0000 (22:03 +0100)]
[TASK] Fix CGL violations

Fix wrong case of TRUE, FALSE and NULL

Resolves: #65726
Releases: master
Change-Id: I2d6a96cb84c19f45538dfd76d96a9b85781e90d3
Reviewed-on: http://review.typo3.org/37835
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix wrong enforcement of pid 0 for rootLevel = -1 in impexp 66/31066/6
Marc Bastian Heinrichs [Mon, 23 Jun 2014 11:13:52 +0000 (13:13 +0200)]
[BUGFIX] Fix wrong enforcement of pid 0 for rootLevel = -1 in impexp

The importer had no support for setting TCA ctrl rootLevel = -1 and
forces the import to pid 0, when a normal page id is also allowed.

Resolves: #59616
Releases: master, 6.2
Change-Id: I224a6d0065c2031636fce494924fc892541ab350
Reviewed-on: http://review.typo3.org/31066
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] Add image cropping 77/34277/10
Frans Saris [Sun, 16 Nov 2014 20:54:33 +0000 (21:54 +0100)]
[FEATURE] Add image cropping

This patch adds the "infrastructure" for single image cropping:

* Extends LocalCropScaleMaskHelper to support the new crop setting
* Adjusts the ViewHelpers to support the crop setting
* Extends typoscript imgResource to support the crop setting
* Adds a new db field for sys_file_reference to hold the crop settings

The GUI will be added in a follow up #65585

Resolves: #65584
Releases: master
Change-Id: I76c6ccd1f3f38e3a47f830115c7748ea4a6b10cd
Reviewed-on: http://review.typo3.org/34277
Reviewed-by: Mateusz Wojtuła <matw88@gmail.com>
Tested-by: Mateusz Wojtuła <matw88@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP][TASK] Shorten namespaces in ContentObjects 10/37810/2
Frank Nägler [Fri, 13 Mar 2015 09:28:40 +0000 (10:28 +0100)]
[FOLLOWUP][TASK] Shorten namespaces in ContentObjects

follow up to fix broken unit tests.

Resolves: #65677
Releases: master
Change-Id: I3ccf2e3fd63a47bcad20d61a0634eb3a0c22d48c
Reviewed-on: http://review.typo3.org/37810
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[FEATURE] Get a file's text content if possible 56/36556/9
Ingo Renner [Sun, 1 Feb 2015 06:53:22 +0000 (22:53 -0800)]
[FEATURE] Get a file's text content if possible

Currently FAL only allows to extract meta data from files. This
patch allows to also extract text content from files. This can
be useful for search engines or providing snippets/teasers
in document archives.

Multiple text extractors can be registered to allow dealing with
different file types. A plain text extractor is provided by the core.

This is also a successor to the former textExtract service interface
implemented by several extensions: http://bit.ly/1D0x92M

Fixes: #36743
Releases: master
Change-Id: I1ce414c99fb26413eedd32422821e1a8802010de
Reviewed-on: http://review.typo3.org/36556
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
4 years ago[TASK] Shorten namespaces in ContentObjects 62/37762/5
Wouter Wolters [Wed, 11 Mar 2015 22:48:50 +0000 (23:48 +0100)]
[TASK] Shorten namespaces in ContentObjects

Resolves: #65677
Releases: master
Change-Id: Ie0f65aefc6300671201730739663e94bf5d8ac41
Reviewed-on: http://review.typo3.org/37762
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] FAL: Allow filenames like "0" 82/37782/3
Malte Muth [Thu, 12 Mar 2015 06:56:57 +0000 (07:56 +0100)]
[BUGFIX] FAL: Allow filenames like "0"

When sanitizing file names, the condition is now checks less greedy
and does not reject filenames like "0" anymore.

Change-Id: I8b7aab813390f836a4e4edb418b77a7525d247d0
Releases: master, 6.2
Resolves: #65673
Reviewed-on: http://review.typo3.org/37782
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Missing relations when saving flexform fields 67/37767/2
Stephan Großberndt [Wed, 11 Mar 2015 23:21:17 +0000 (00:21 +0100)]
[BUGFIX] Missing relations when saving flexform fields

This patch adds the missing parameter $table to the call of
getRelations_procDB when analyzing flexform fields.

Resolves: #65126
Releases: master, 6.2
Change-Id: Ie4ad34973882da8501881cff3146858581a05350
Reviewed-on: http://review.typo3.org/37767
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FOLLOWUP][TASK] Rewrite backend modules of indexed_search 94/37794/4
Tymoteusz Motylewski [Thu, 12 Mar 2015 16:52:32 +0000 (17:52 +0100)]
[FOLLOWUP][TASK] Rewrite backend modules of indexed_search

During some rebase of the indexed search backend module patch
http://review.typo3.org/32708

The code for new content element wizard was removed.
This patch adds it back.
It also removes superflous registration of typoscript.

Resolves: #34298
Relates: #61511
Releases: master
Change-Id: Ib9c95a0635670748b3da4c010590566f4c45694e
Reviewed-on: http://review.typo3.org/37794
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Speed and clean up RecordsContentObject 64/37764/3
Wouter Wolters [Wed, 11 Mar 2015 22:58:16 +0000 (23:58 +0100)]
[TASK] Speed and clean up RecordsContentObject

* Initialize variables only when needed
* Use empty instead of count
* Set count once and use a variable instead
* Import used classes

Resolves: #65679
Releases: master
Change-Id: I4dc52907a4a3bc75f49be01beefb2a1c1cab13b3
Reviewed-on: http://review.typo3.org/37764
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Add IE 11 detection to ExtJS 66/37766/2
Lorenz Ulrich [Wed, 11 Mar 2015 23:09:39 +0000 (00:09 +0100)]
[TASK] Add IE 11 detection to ExtJS

ExtJS 3.4.1 used in the TYPO3 Core does not ship browser detection for
Internet Explorer 11. Because IE 11 uses "Gecko" in the user-agent
string to be detected as a modern browser, ExtJS treats IE11 as Gecko
browser which leads to various problems with JavaScript features that
are not part of IE.

For financial and licensing reasons, TYPO3 cannot update to ExtJS 3.4.2
which includes the detection. Therefore, this change adds IE 11 detection
to ExtJS. ExtJS now returns true for "Ext.isIE" and "Ext.isIE11" and
false for "Ext.isGecko".

Resolves: #55774
Resolves: #55775
Resolves: #56192
Releases: master,6.2
Change-Id: Id86cde375aeba3a314db6baadad4446f38b23eb0
Reviewed-on: http://review.typo3.org/37766
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] Followup: Add missing semicolon 88/37788/2
Andreas Fernandez [Thu, 12 Mar 2015 13:02:18 +0000 (14:02 +0100)]
[BUGFIX] Followup: Add missing semicolon

Resolves: #65696
Releases: master
Change-Id: I3a2c97b7fc4d7dd683cdb3c580816f8c01916420
Reviewed-on: http://review.typo3.org/37788
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Call update event after drop only once 69/37769/3
Andreas Fernandez [Thu, 12 Mar 2015 08:35:28 +0000 (09:35 +0100)]
[BUGFIX] Call update event after drop only once

jQueryUI's sortable has an "update" and a "receive" event. If an element
is moved into another column, "update" is triggered two times, the
first call affects the source list, the second call affects the target
list. Also, "reveive" is triggered too, resulting in calling
"onSortUpdates" up to three times. This patch removes the "receive"
listener and calls "update" only on the targeted list.

Resolves: #65685
Releases: master
Change-Id: Ie9df35fb82fd22cccdedcbb58f4c0697213361e5
Reviewed-on: http://review.typo3.org/37769
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] PHP Warning in HistoryService 34/37734/3
Oliver Hader [Wed, 11 Mar 2015 14:43:01 +0000 (15:43 +0100)]
[BUGFIX] PHP Warning in HistoryService

Using the workspace module in the backend might show warnings
concerning the HistoryService if no history is available for
a particular record.

Resolves: #65668
Releases: master, 6.2
Change-Id: I0a80d714c0633568d4ee4827adb7502601b75b6b
Reviewed-on: http://review.typo3.org/37734
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Make Format/DateViewHelper compilable 37/37637/2
Anja Leichsenring [Sun, 8 Mar 2015 14:15:59 +0000 (15:15 +0100)]
[TASK] Make Format/DateViewHelper compilable

Change-Id: If678612b58b3d3fd302582b874a74e64dc016248
Resolves: #65597
Releases: master
Reviewed-on: http://review.typo3.org/37637
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Make Format/CurrencyViewHelper compilable 36/37636/2
Anja Leichsenring [Sun, 8 Mar 2015 13:47:38 +0000 (14:47 +0100)]
[TASK] Make Format/CurrencyViewHelper compilable

Change-Id: Ibc3a46edb317e6a8cfd17192ace88b7684280468
Resolves: #65596
Releases: master
Reviewed-on: http://review.typo3.org/37636
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Make Format/CDataViewHelper compilable 35/37635/2
Anja Leichsenring [Sun, 8 Mar 2015 13:15:37 +0000 (14:15 +0100)]
[TASK] Make Format/CDataViewHelper compilable

Change-Id: I3a558758f88c32124359b1ec9541266b30047b04
Resolves: #65595
Releases: master
Reviewed-on: http://review.typo3.org/37635
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Make CountViewHelper compilable 34/37634/2
Anja Leichsenring [Sun, 8 Mar 2015 12:54:37 +0000 (13:54 +0100)]
[TASK] Make CountViewHelper compilable

Change-Id: Ie3b1a50e22b1587ebd67385712727bab9608b1aa
Resolves: #65594
Releases: master
Reviewed-on: http://review.typo3.org/37634
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Make CaseViewHelper compilable 33/37633/3
Anja Leichsenring [Sun, 8 Mar 2015 12:37:14 +0000 (13:37 +0100)]
[TASK] Make CaseViewHelper compilable

Change-Id: I48c496c73d2b20b7b43994ff70336ceed6a36b70
Resolves: #65593
Releases: master
Reviewed-on: http://review.typo3.org/37633
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Use a typecast to ensure correct value 70/37770/2
Georg Ringer [Thu, 12 Mar 2015 08:56:48 +0000 (09:56 +0100)]
[BUGFIX] Use a typecast to ensure correct value

BackendUtility::getLabelsFromItemsList must use a typecast to compare
values.

Change-Id: I6efecbd4871e8435a41aa4310c5e6db19e9bb280
Resolves: #65689
Releases: master,6.2
Reviewed-on: http://review.typo3.org/37770
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Render configuration tree through CSS 53/37653/4
Benjamin Kott [Sun, 8 Mar 2015 22:41:22 +0000 (23:41 +0100)]
[TASK] Render configuration tree through CSS

Releases: master
Resolves: #65678
Change-Id: If73967831c4524ee3bb44deefcbaf8dbc7127a0c
Reviewed-on: http://review.typo3.org/37653
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Refactor getDynTabMenu function 78/37078/13
Frank Nägler [Sat, 21 Feb 2015 19:25:10 +0000 (20:25 +0100)]
[TASK] Refactor getDynTabMenu function

This patch deprecate the getDynTabMenu() function and
introduce a new function called getDynamicTabMenu()
The new function creates bootstrap HTML markup.
All places in the core was updated to use the new method.

Resolves: #65111
Releases: master
Change-Id: I0965c3cfc0b40da3ef76ef566df28c7c6ad38a71
Reviewed-on: http://review.typo3.org/37078
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] Replace DataHandler->exclude_array with key-based array 15/35315/11
Stephan Großberndt [Thu, 11 Dec 2014 17:57:22 +0000 (18:57 +0100)]
[!!!][TASK] Replace DataHandler->exclude_array with key-based array

Replace the public property array 'exclude_array' in DataHandler with a
protected property 'excludedTablesAndFields' using keys instead of
values. This change improves performance for bulk inserts since in
DataHandler->fillInFieldArray() many in_array()-checks can be avoided.

Resolves: #63784
Releases: master
Change-Id: I478319fea022c3eceaac35da9c093d1c43ecb2e4
Reviewed-on: http://review.typo3.org/35315
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Properly handle absolute links in typolink() 30/37730/2
Markus Klein [Wed, 11 Mar 2015 14:17:52 +0000 (15:17 +0100)]
[BUGFIX] Properly handle absolute links in typolink()

Fix a wrong assumption in the code that claims we link across domains.
If config.forceAbsoluteUrl is set, we might link to the same domain.

The patch adds a check, such that the assumption is correct afterwards.

Resolves: #65666
Releases: master, 6.2
Change-Id: I5a26522c625303637dee91a23dbf902f86a20bed
Reviewed-on: http://review.typo3.org/37730
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Correct upload field name for TCA internal_type file 23/37523/4
Wouter Wolters [Wed, 4 Mar 2015 14:46:16 +0000 (15:46 +0100)]
[BUGFIX] Correct upload field name for TCA internal_type file

Enforcing a file doesn't take the file upload field into
consideration. Correct the name of the check in JavaScript.

Resolves: #47372
Releases: master,6.2
Change-Id: I6958cc32afb72ac0998bb3c4ae99de14ba39aef8
Reviewed-on: http://review.typo3.org/37523
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Show information for recycler scheduler task 13/37713/2
Nicole Cordes [Tue, 10 Mar 2015 19:56:12 +0000 (20:56 +0100)]
[BUGFIX] Show information for recycler scheduler task

Due to a wrong language file path no setting information for the
CleanerTask of the recycler are shown.

Releases: master
Resolves: #65647
Change-Id: I21b45a0efd1e9c03d4b6bae6475826ac55262b6f
Reviewed-on: http://review.typo3.org/37713
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Re-enable menu configuration caching 02/35002/7
Martin Helmich [Wed, 3 Dec 2014 17:00:40 +0000 (18:00 +0100)]
[BUGFIX] Re-enable menu configuration caching

It is ensured that the menu configuration is always an array.

The PageRepository::getHash() method is extended to return the
raw cache content. This allows to cache empty arrays.

Change-Id: If92c80feabb8e68b66497827667b9fd0ab1c214e
Resolves: #63550
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35002
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Arjen Hoekema <arjenhoekema@gmail.com>
Tested-by: Arjen Hoekema <arjenhoekema@gmail.com>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Disallow shutdown of own backend account 89/37689/5
Andreas Fernandez [Tue, 10 Mar 2015 07:47:42 +0000 (08:47 +0100)]
[TASK] Disallow shutdown of own backend account

It's not possible to delete or disable one's own backend
user account in the list module anymore.

Resolves: #65633
Releases: master
Change-Id: Ia33db30827d2d24d66f6d70d73d9c66e461a7d7e
Reviewed-on: http://review.typo3.org/37689
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] DBAL: Set allowNull for insert and update queries to TRUE 45/36545/2
Armin Ruediger Vieweg [Sat, 31 Jan 2015 22:03:24 +0000 (23:03 +0100)]
[BUGFIX] DBAL: Set allowNull for insert and update queries to TRUE

When DBAL is installed, it was not possible to save NULL values to database, but
TCA fields with mode=useOrOverridePlaceholder fields strongly requires this.
Without the possibility to store NULL to database, "useOrOverridePlaceholder"
would always override the original value.

Resolves: #63991
Releases: master, 6.2
Change-Id: I23cd221431ba9d00e588942bc7c7030e9af805dc
Reviewed-on: http://review.typo3.org/36545
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Skip cache hash for URIs to non-cacheable actions 75/37675/3
Tymoteusz Motylewski [Mon, 9 Mar 2015 18:29:16 +0000 (19:29 +0100)]
[FOLLOWUP][BUGFIX] Skip cache hash for URIs to non-cacheable actions

Fix fatal error in page module when user is in some workspace

Resolves: #65629
Relates: #60272
Releases: master
Change-Id: I05a6b3bdccff8bfc49ff0c0619ee5db5e4de1a22
Reviewed-on: http://review.typo3.org/37675
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Use "user_auth" index for DataHandler:printLogErrorMessages 92/37692/3
Andreas Fernandez [Tue, 10 Mar 2015 10:41:07 +0000 (11:41 +0100)]
[BUGFIX] Use "user_auth" index for DataHandler:printLogErrorMessages

Add the database field "action" to the SQL query to be able to use
the "user_auth" index and speed up the query.

Resolves: #65634
Releases: master, 6.2
Change-Id: I3371367a2fb7c86ea4cf38ee8f7ce1e8a571ffb8
Reviewed-on: http://review.typo3.org/37692
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] Respect newlines in ['SYS']['binSetup'] 72/37672/5
Nicole Cordes [Mon, 9 Mar 2015 15:56:39 +0000 (16:56 +0100)]
[BUGFIX] Respect newlines in ['SYS']['binSetup']

If you separate the list of programs by new line (as suggested in the
Install Tool description), the programs aren't found.
The problem is that the newline is saved as string component by
the Install Tool. Therefore the new line separator (LF) has to
be replaced before splitting the value.

Releases: master, 6.2
Resolves: #65624
Change-Id: I39d8634265bf69d58ad4af3fd2eac913a14a3ef5
Reviewed-on: http://review.typo3.org/37672
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[FEATURE] Ask for old password when changing 24/10224/12
Georg Ringer [Thu, 25 Dec 2014 20:36:03 +0000 (21:36 +0100)]
[FEATURE] Ask for old password when changing

Following security best practices, a user should
to be able to update his password only when giving
the previous password. Currently no need to know
the current password when changing it.

Change-Id: Id0c52d8f7e0d06177c0e4f7076b71d5e6fbca466
Resolves: #35807
Releases: master
Reviewed-on: http://review.typo3.org/10224
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] EM: Prevent event stacking on update button 57/37657/4
Andreas Fernandez [Mon, 9 Mar 2015 08:12:40 +0000 (09:12 +0100)]
[BUGFIX] EM: Prevent event stacking on update button

Using the text filter calls "bindExtensionListActions" on each change.
This method invokes the registration of the "click" event handler every
time. Register the events in ready() once to solve the event stacking.

Resolves: #65606
Releases: master
Change-Id: Ie080f2e200a7d52af1a1c42dd6198c0567f122c7
Reviewed-on: http://review.typo3.org/37657
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[TASK] Remove nobr CSS class and nobr tags 17/37617/4
Jigal van Hemert [Sun, 8 Mar 2015 22:34:56 +0000 (23:34 +0100)]
[TASK] Remove nobr CSS class and nobr tags

Releases: master
Resolves: #65586
Change-Id: I32758dc4e57072955d3bc7f6a010a35f7253fd80
Reviewed-on: http://review.typo3.org/37617
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[TASK] Remove unused .typo3-red-background CSS class 18/37618/2
Benjamin Kott [Sat, 7 Mar 2015 12:58:10 +0000 (13:58 +0100)]
[TASK] Remove unused .typo3-red-background CSS class

Releases: master
Resolves: #65587
Change-Id: Ic397294ccaf29223df7348760d6d408efb1b20e7
Reviewed-on: http://review.typo3.org/37618
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] Handle exceptions in Logging API 02/37602/5
Markus Klein [Fri, 6 Mar 2015 17:16:38 +0000 (18:16 +0100)]
[BUGFIX] Handle exceptions in Logging API

Do not run exceptions through json_encode() but convert them to strings
first.

Resolves: #65577
Releases: master, 6.2
Change-Id: I46e743480b32010bff39784a3572a5fe96cf0859
Reviewed-on: http://review.typo3.org/37602
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Fix update button in Extension Manager 12/37612/2
Andreas Fernandez [Fri, 6 Mar 2015 18:39:41 +0000 (19:39 +0100)]
[BUGFIX] Fix update button in Extension Manager

The change If527b0e8fd77a059c8b25db16a926c5c80356331 introduced
a regression which broke the event listeners for the update buttons.
Change the JavaScript code to match the new markup.

Resolves: #65580
Releases: master
Change-Id: Ifbf857c88fad10f6e0411c48dadacf85bcfa425c
Reviewed-on: http://review.typo3.org/37612
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Remove deprecated "strict" PHPUnit option 96/37596/4
Mathias Brodala [Fri, 6 Mar 2015 13:43:04 +0000 (14:43 +0100)]
[TASK] Remove deprecated "strict" PHPUnit option

Resolves: #65569
Releases: master, 6.2
Change-Id: Ica1c3e9c90a0e4a97bd47afa1ea092fe9e957ef2
Reviewed-on: http://review.typo3.org/37596
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Install tool image tests broken 94/37594/2
Christian Kuhn [Fri, 6 Mar 2015 12:56:23 +0000 (13:56 +0100)]
[BUGFIX] Install tool image tests broken

Switching the image manipulation from hardcoded cache table to
the caching framework with #28484 triggers a fatal error in
the install tool image tests. This cache was not properly reset
in the install tool initialization.
The patch resolves this by cleaning up the cache initialization
that has been marked as todo since install tool rewrite. This
is solved for now.
The whole situation is still not perfect since bootstrap, install
tool and extensionmanager manipulate this stuff and the static Cache
class with its static properties in front of the caching framework
does not help to encapsulate and separate the different needs. A
further refactoring releasing the system from static dependencies
and direct global access would help here to reduce complexity with
another patch later.

Resolves: #54498
Related: #28484
Releases: master
Change-Id: Ied01a025ce8e5a3cce03732c95d0914e8fa7af23
Reviewed-on: http://review.typo3.org/37594
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Rewrite JavaScript of ext:documentation to RequireJS 78/37578/6
Wouter Wolters [Thu, 5 Mar 2015 22:12:33 +0000 (23:12 +0100)]
[TASK] Rewrite JavaScript of ext:documentation to RequireJS

Due to a JavaScript error in the current situation the code
is now ported to RequireJS.

Resolves: #65557
Releases: master
Change-Id: I3dab5fa8ba95088e60acca5d28f3829f201ddf76
Reviewed-on: http://review.typo3.org/37578
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix labels in linkvalidator 87/37587/2
Georg Ringer [Fri, 6 Mar 2015 09:39:58 +0000 (10:39 +0100)]
[BUGFIX] Fix labels in linkvalidator

Change the id which is referred in the label to make it
possible to toggle the checkbox by clicking on the label.

Resolves: #65564
Releases: master, 6.2

Change-Id: I4d4b8ac91b324405f5c94e2db7e6fd5205e85462
Reviewed-on: http://review.typo3.org/37587
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>