Packages/TYPO3.CMS.git
4 years ago[TASK] RTE: Use mutation observer instead of DOMAttrModified listener 12/36212/3
Stanislas Rolland [Fri, 23 Jan 2015 21:36:58 +0000 (16:36 -0500)]
[TASK] RTE: Use mutation observer instead of DOMAttrModified listener

DOMAttrModified is deprecated.
Use mutation observer when available.

Releases: master
Resolves: #64460
Change-Id: I5675d2a8ca7708c26e4db610d35a3f8388205b6e
Reviewed-on: http://review.typo3.org/36212
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE resizing is erratic 05/36205/4
Stanislas Rolland [Fri, 23 Jan 2015 18:56:16 +0000 (13:56 -0500)]
[BUGFIX] RTE resizing is erratic

A window resize event is triggered when the framework, including the
iframe, is resized using jQuery UI Resizable.
The window resize event must be stopped while risizing is being
performed.

Releases: master
Resolves: #64390
Change-Id: I1381cabc4c2965a8b677a17c0acd7458199b2bca
Reviewed-on: http://review.typo3.org/36205
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] Style output of ReferenceIndex results 02/36202/3
Andreas Fernandez [Fri, 23 Jan 2015 16:08:03 +0000 (17:08 +0100)]
[TASK] Style output of ReferenceIndex results

Put the results of "Check/update reference index" into a flashmessage.

Resolves: #22663
Releases: master
Change-Id: I17701a072a4feb4942c01e05c1dca71612ec55bb
Reviewed-on: http://review.typo3.org/36202
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 years ago[!!!][TASK] Gifbuilder: Always use full filename of original file as prefix 15/34015/7
Georg Ringer [Wed, 12 Nov 2014 14:41:12 +0000 (15:41 +0100)]
[!!!][TASK] Gifbuilder: Always use full filename of original file as prefix

As of now, images created with GIFBUILDER were created by a
hash in typo3temp/GB/. With the TypoScript option
config.meaningfulTempFilePrefix it was possible to prepend the
first X characters of the original filename in the filename.
This was due to some FS limitations on Windows.

With FAL the option was not used anymore, but Gifbuilder
still used this option.

In order to streamline the generation of temporary
files, images created by the Gifbuilder now contain
the full filename of the original file as well.

The TypoScript option "config.meaningfulTempFilePrefix"
has no effect anymore now.

Resolves: #62886
Releases: master
Change-Id: I746aa5d8c2e483212c28419dadb68a5cd5d1282d
Reviewed-on: http://review.typo3.org/34015
Reviewed-by: Eric Chavaillaz <eric@hemmer.ch>
Tested-by: Eric Chavaillaz <eric@hemmer.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Follow-up for RTE: Remove support for IE 8 and older 01/36201/2
Stanislas Rolland [Fri, 23 Jan 2015 15:52:18 +0000 (10:52 -0500)]
[TASK] Follow-up for RTE: Remove support for IE 8 and older

Releases: master
Resolves: #64445
Change-Id: I11cf58908a38bb3b3cf1aae3b6547abbff021f0e
Reviewed-on: http://review.typo3.org/36201
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] RTE: Remove support for IE 8 and older 93/36193/2
Stanislas Rolland [Fri, 23 Jan 2015 03:25:49 +0000 (22:25 -0500)]
[TASK] RTE: Remove support for IE 8 and older

Releases: master
Resolves: #64445
Change-Id: I527285ff64fb3f2202458d63d008781cf53bf129
Reviewed-on: http://review.typo3.org/36193
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] RTE: Use Bootstrap markup for the toolbar 86/36186/4
Stanislas Rolland [Thu, 22 Jan 2015 20:26:30 +0000 (15:26 -0500)]
[TASK] RTE: Use Bootstrap markup for the toolbar

Releases: master
Resolves: #64443
Change-Id: I165841b60563c87d2934fc6126f834b5f2f262c2
Reviewed-on: http://review.typo3.org/36186
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[FOLLOWUP][BUGFIX] DBAL: Repair AUTO_INCREMENT 90/36190/3
Markus Klein [Thu, 22 Jan 2015 21:26:51 +0000 (22:26 +0100)]
[FOLLOWUP][BUGFIX] DBAL: Repair AUTO_INCREMENT

Fix broken unit tests.
The number of statements changed now as AUTO_INCREMENT
is supported.

Resolves: #63705
Releases: master, 6.2
Change-Id: I855b43b9dda599f5588abdebffb460e7819d2a82
Reviewed-on: http://review.typo3.org/36190
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Avoid getUserObj-call for eval 'null' and non-existing hooks 87/35287/10
Stephan Großberndt [Thu, 11 Dec 2014 09:32:49 +0000 (10:32 +0100)]
[BUGFIX] Avoid getUserObj-call for eval 'null' and non-existing hooks

If the 'eval' definition of a TCA input or text does contain 'null' or
a value without a matching hook, we skip the useless call to
GeneralUtility::getUserObj().

This improves performance especially for bulk inserts with many text
fields.

Resolves: #63750
Releases: master, 6.2
Change-Id: I328f6b3f5e737fa472f7385afc0a2407d16eb1f8
Reviewed-on: http://review.typo3.org/35287
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[CLEANUP] Correct phpdoc in extbase's validator classes 43/36143/3
Frederic Gaus [Tue, 20 Jan 2015 16:46:58 +0000 (17:46 +0100)]
[CLEANUP] Correct phpdoc in extbase's validator classes

Set the correct @return in phpdoc of extbase validators.
Further correct some typos and remove disabled code including a
not needed comment in ValidatorInterface

Change-Id: I0966176eb4079f6c6fcd6f182e5c608acac0a01c
Resolves: #57453
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36143
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] DBAL: Repair AUTO_INCREMENT 83/35183/5
Andreas Fernandez [Tue, 9 Dec 2014 11:05:21 +0000 (12:05 +0100)]
[BUGFIX] DBAL: Repair AUTO_INCREMENT

This patch fixes the creation of fields with an AUTO_INCREMENT flag,
especially for DBMS that don't have built-in support for AI flags.

Resolves: #63705
Releases: master, 6.2
Change-Id: I7ebf743e0e0483af181b76f66a8cf158ebe775cc
Reviewed-on: http://review.typo3.org/35183
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] [FOLLOWUP] ext:beuser permission module throws query error 81/36181/5
Christian Kuhn [Thu, 22 Jan 2015 19:07:55 +0000 (20:07 +0100)]
[BUGFIX] [FOLLOWUP] ext:beuser permission module throws query error

A removed class property was still in use and results
in a wrong SQL query.

Related: #64416
Resolves: #64416
Releases: master
Change-Id: I4b2d17fe307a9137487101eacf64610a13f8a2db
Reviewed-on: http://review.typo3.org/36181
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Allow appending of element browser mounts 98/31898/13
Alexander Stehlik [Wed, 7 Jan 2015 15:10:25 +0000 (16:10 +0100)]
[FEATURE] Allow appending of element browser mounts

A new User TSconfig option is introduced that allows the alternative
element browser page tree mounts to be appended instead of beeing
replaced:

options.pageTree.altElementBrowserMountPoints.append

Additionally the handling of temporary mount points within the RTE
and the wizard element browser is unified. If a temporary mount
point is active the altElementBrowserMountPoints will be ignored.

Resolves: #50780
Documentation: #63009
Releases: master
Change-Id: I2a0b616b398131684a2c7c71a25b4b51ef6f0c50
Reviewed-on: http://review.typo3.org/31898
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Clean up "core" documentation 74/36174/2
Francois Suter [Thu, 22 Jan 2015 13:06:10 +0000 (14:06 +0100)]
[BUGFIX] Clean up "core" documentation

Clean all reStructuredText markup errors that generate
warnings during the rendering of the "core" sysext
documentation.

Furthermore a link is added to the "Howto" file, so that it
is easier to find the instructions in the rendered version.

Finally a Settings.yml file is added, just like all other
manuals, with a title and version number.

Resolves: #64431
Releases: master
Change-Id: Ic75cad4d1d364aceef04a06f96b7fd74d454559c
Reviewed-on: http://review.typo3.org/36174
Reviewed-by: Francois Suter <francois@typo3.org>
Tested-by: Francois Suter <francois@typo3.org>
4 years ago[TASK] Clean up ext:beuser permission module access checks 69/36169/5
Christian Kuhn [Wed, 21 Jan 2015 23:41:15 +0000 (00:41 +0100)]
[TASK] Clean up ext:beuser permission module access checks

The access module is restricted to admin users since core 6.0.
The patch removes left over code checks for non admin users.

Resolves: #64416
Related: #41229
Releases: master
Change-Id: I6fddc2eb1ae8a720c3d157993621fe201bd692e7
Reviewed-on: http://review.typo3.org/36169
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[TASK] RTE: Cleanup toolbar items API 62/36162/2
Stanislas Rolland [Wed, 21 Jan 2015 15:41:15 +0000 (10:41 -0500)]
[TASK] RTE: Cleanup toolbar items API

This is a follow-up to the migration of toolbar ExtJS items to
plain JavaScript.

Releases: master
Resolves: #64407
Change-Id: I3784f397015241020e9fdb4f0740b707decc0666
Reviewed-on: http://review.typo3.org/36162
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Highlight Image/link button when cursor is in image/link 52/36152/3
Stanislas Rolland [Wed, 21 Jan 2015 03:19:05 +0000 (22:19 -0500)]
[BUGFIX] RTE: Highlight Image/link button when cursor is in image/link

Toolbar image/link button should be highlighted when cursor is positioned
on image or in link.

Releases: master
Resolves: #64394
Change-Id: I4b9a8a5bf3ef6c369defd25e04ff261bbffb4091
Reviewed-on: http://review.typo3.org/36152
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] Move getFieldDefaultValue to FORM cObject 49/36149/3
Benjamin Mack [Tue, 20 Jan 2015 21:26:31 +0000 (22:26 +0100)]
[TASK] Move getFieldDefaultValue to FORM cObject

The method getFieldDefaultValue() inside
ContentObjectRenderer is part of the FORM
content object and is called there.
Thus, it is moved to the FormContentObject
class as a protected method. All calls to this
method are changed accordingly.

As the function is marked for private access,
it is moved without any further documentation
or deprecation.

Resolves: #64391
Releases: master
Change-Id: Ib99503973412b34e31eac976117b6d707f5b1577
Reviewed-on: http://review.typo3.org/36149
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Raise PHP requirement of EXT:core/composer.json 51/36151/2
Benjamin Mack [Tue, 20 Jan 2015 21:42:13 +0000 (22:42 +0100)]
[TASK] Raise PHP requirement of EXT:core/composer.json

Resolves: #64393
Releases: master
Change-Id: I3a184047c4af6c9b8656fc78c2d83a0ef3a9f4ec
Reviewed-on: http://review.typo3.org/36151
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] RTE: Icons not centered on buttons in toolbar 50/36150/2
Stanislas Rolland [Tue, 20 Jan 2015 21:39:37 +0000 (16:39 -0500)]
[BUGFIX] RTE: Icons not centered on buttons in toolbar

Releases: master
Resolves: #64392
Change-Id: I00027870aba8c29b0c25df4bad3c297063bb7c35
Reviewed-on: http://review.typo3.org/36150
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] RTE: Migrate toolbar ExtJS combos to plain JavaScript 30/36130/5
Stanislas Rolland [Tue, 20 Jan 2015 03:33:54 +0000 (22:33 -0500)]
[TASK] RTE: Migrate toolbar ExtJS combos to plain JavaScript

Releases: master
Resolves: #64368
Change-Id: I28bc9b10f28a46eed21a0d86248dedef50e01922
Reviewed-on: http://review.typo3.org/36130
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] Central function for escaping of shell-args 59/35959/6
Stefan Neufeind [Sun, 11 Jan 2015 22:43:14 +0000 (23:43 +0100)]
[TASK] Central function for escaping of shell-args

Instead of doing a (locale-aware) escaping in various
places use a central utility-function.

Change-Id: If0486b340543c33fc0794d754af81a4a666988c3
Resolves: #39928
Releases: master
Reviewed-on: http://review.typo3.org/35959
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Followup to DateTimePicker exchange 03/35703/2
Benjamin Mack [Thu, 1 Jan 2015 18:29:02 +0000 (19:29 +0100)]
[BUGFIX] Followup to DateTimePicker exchange

The DateTimePicker exchange from ExtJS
to moment.js and twbs led to the problem
that when using FormEngine in a popup
the Date Format is not set due to the nature
of not having an iframe but a popup.

Releases: master
Resolves: #64076
Change-Id: I6c1bf2019d9ae2292f207fbd553a373c567b53a3
Reviewed-on: http://review.typo3.org/35703
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Followup: Fix folder selection in ElementBrowser 56/35956/4
Frans Saris [Sun, 11 Jan 2015 18:57:14 +0000 (19:57 +0100)]
[BUGFIX] Followup: Fix folder selection in ElementBrowser

With the introduction of FAL folders are now addressed with their
combinedIdentifier. Parts of the ElementBrowser were not adjusted yet.

This patch makes sure the combinedIdentifier is used for folders
so you can also use/select folders from non-public and remote storages.

Resolves: #63651
Releases: master, 6.2
Change-Id: Id2f2021040950ade48f664c9576f5cd191afe324
Reviewed-on: http://review.typo3.org/35956
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] sysext:core/TypoScript 02/35802/9
Markus Klein [Mon, 5 Jan 2015 19:52:33 +0000 (20:52 +0100)]
[CLEANUP] sysext:core/TypoScript

Resolves: #64136
Resolves: #64320
Releases: master
Change-Id: Id578a02b98b4f4c5795e256c0c8d9120edf3609c
Reviewed-on: http://review.typo3.org/35802
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Remove space from CLI command in ext:lowlevel 26/36126/2
Wouter Wolters [Mon, 19 Jan 2015 21:43:28 +0000 (22:43 +0100)]
[BUGFIX] Remove space from CLI command in ext:lowlevel

Resolves: #64367
Releases: master
Change-Id: Ie86755a4b246cb8bc47753214d2b41cbd33d8373
Reviewed-on: http://review.typo3.org/36126
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fix fatal error for date validation in EXT:form on Windows 30/35530/5
Stephan Großberndt [Wed, 17 Dec 2014 00:54:14 +0000 (01:54 +0100)]
[BUGFIX] Fix fatal error for date validation in EXT:form on Windows

Use a mapping to date_create_from_format() in date validation of
EXT:form if strptime() is not available. This prevents a fatal error on
Windows because strptime() is not implemented on Windows platform.

Resolves: #63945
Releases: master, 6.2
Change-Id: I92f66597ce362cc8dae66b09ba19ed428055a6de
Reviewed-on: http://review.typo3.org/35530
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Use composer class loader for better performance 91/36091/10
Helmut Hummel [Sun, 18 Jan 2015 10:25:20 +0000 (11:25 +0100)]
[FEATURE] Use composer class loader for better performance

Require composer class loader early in the bootstrap gives us many benefits:

1. Very early classes can be found and loaded very early in the bootstrap
2. Get rid of complexity for default cases
3. Test classes will only loadable in testing context
4. Cache warmup will be much faster as much less files need to be written

Further details can be found on the wiki http://wiki.typo3.org/ComposerClassLoader

Resolves: #64361
Releases: master, 6.2
Change-Id: Ida22edf8383a9706726a8fdd11297b2983d17b1a
Reviewed-on: http://review.typo3.org/36091
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Add missing "Folders" label in ElementBrowser 57/35957/3
Frans Saris [Sun, 11 Jan 2015 19:29:33 +0000 (20:29 +0100)]
[BUGFIX] Add missing "Folders" label in ElementBrowser

Resolves: #64241
Releases: master, 6.2
Change-Id: If55b4e05ccd697a973e938b50f5cfd2f32a5d5b7
Reviewed-on: http://review.typo3.org/35957
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Deprecate SearchFormController->checkExistance 46/36046/3
Stephan Großberndt [Fri, 16 Jan 2015 16:09:42 +0000 (17:09 +0100)]
[TASK] Deprecate SearchFormController->checkExistance

Deprecate the function checkExistance (typo) in SearchFormController
and add a replacement checkExistence().

Releases: master
Resolves: #64315
Change-Id: I01d8b4d07f5f04e46052af296fbf93fed128e678
Reviewed-on: http://review.typo3.org/36046
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Post travis notification to #typo3-cms-coredev channel 13/36113/3
Helmut Hummel [Mon, 19 Jan 2015 16:59:19 +0000 (17:59 +0100)]
[TASK] Post travis notification to #typo3-cms-coredev channel

Change-Id: I4cd242dd7ae34b4d179acd494d4e84b10e37c6e6
Reviewed-on: http://review.typo3.org/36113
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Add shutdown function while class cache build 67/35167/7
Alexander Opitz [Mon, 8 Dec 2014 17:50:21 +0000 (18:50 +0100)]
[TASK] Add shutdown function while class cache build

With shutdown function we can check if PHP is shutdown while
cache generation, so we can remove leftovers from this process.

Resolves: #63683
Releases: master, 6.2
Change-Id: I4038c10c50287ec4cceca1c0e5a73c954f2d8c1d
Reviewed-on: http://review.typo3.org/35167
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FOLLOWUP] Strict order in redis test for uniqid() 10/36110/4
Christian Kuhn [Mon, 19 Jan 2015 16:09:13 +0000 (17:09 +0100)]
[FOLLOWUP] Strict order in redis test for uniqid()

Follows https://review.typo3.org/#/c/35665/

Stabilize redis tests a bit with a clear order,
otherwise tests may fail sometimes.

Related: #64055
Releases: master
Change-Id: Ibc472379ea8e4c453d7c52331cb23d5cf83b4d5d
Reviewed-on: http://review.typo3.org/36110
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP] Add PSR-4 autoload sections to composer.json 08/36108/2
Helmut Hummel [Mon, 19 Jan 2015 16:09:41 +0000 (17:09 +0100)]
[FOLLOWUP] Add PSR-4 autoload sections to composer.json

A bogus test, which tests Flow behavior which is not present
in TYPO3 CMS package management caused a test to fail.

Fix this test to actually test the correct thing.

Releases: master, 6.2
Change-Id: Ideff51a32c3cdf3471472f9df743da0b3387abdc
Reviewed-on: http://review.typo3.org/36108
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Add PSR composer definition to all sysexts 76/36076/6
Benjamin Mack [Sat, 17 Jan 2015 15:44:28 +0000 (16:44 +0100)]
[TASK] Add PSR composer definition to all sysexts

In order to deliver more information
in custom installations for use with composer,
the namespaces for using the composer
autoloader are added to each composer.json
of all system extensions.

Releases: master, 6.2
Resolves: #64356
Change-Id: Ic0fa9e0969a48f68cce8ceeb77dbef3b75e6e6f1
Reviewed-on: http://review.typo3.org/36076
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Wrapper for uniqid() fixes failing tests on Windows 65/35665/9
Stephan Großberndt [Mon, 29 Dec 2014 19:17:07 +0000 (20:17 +0100)]
[BUGFIX] Wrapper for uniqid() fixes failing tests on Windows

Create TYPO3\CMS\Core\Tests\BaseTestCase->getUniqueId() as a wrapper to
all uniqid()-calls from tests. This fixes fatal errors on tests in
Windows because multiple calls to uniqid() without parameters within
one second will return the same value.

TYPO3\CMS\Core\Tests\Functional\DataHandling\Framework\ActionService
does not inherit from BaseTestCase and thus gets its own implementation
for now.

Resolves: #64055
Releases: master, 6.2
Change-Id: I15536c0f1766ad89a3d8daf7260b0dbe81ef82f8
Reviewed-on: http://review.typo3.org/35665
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Faster garbage collection of caching framework 54/33254/10
Stephan Großberndt [Fri, 10 Oct 2014 22:03:31 +0000 (00:03 +0200)]
[BUGFIX] Faster garbage collection of caching framework

Do the garbage collection of the caching framework with a single DELETE
statement using JOIN instead of fetching all entries by identifier and
deleting them in a separate statement afterwards. This improves
performance especially for big installations.

For EXT:DBAL the old behaviour is kept since Oracle does neither
support subqueries nor DELETE statements with JOINs.

Removed test collectGarbageSelectsExpiredCacheEntries since
collectGarbage() doesn't perform a SELECT query anymore.

Resolves: #61814
Releases: master, 6.2
Change-Id: Ifca9065e274b85219ca81afa87724ce8884cc662
Reviewed-on: http://review.typo3.org/33254
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Reflect mysql comments in SchemaMigrator 78/21478/7
Nico de Haen [Sun, 18 Jan 2015 14:30:34 +0000 (15:30 +0100)]
[FEATURE] Reflect mysql comments in SchemaMigrator

This enables that the database migration and
comparison process includes mysql column comments.

Resolves: #49060
Releases: master

Change-Id: I8785690496bbc4fa80a8bf98ca75029c48f500f9
Reviewed-on: http://review.typo3.org/21478
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Older changelog not showing in "core" documentation 23/35323/3
Francois Suter [Thu, 11 Dec 2014 21:50:17 +0000 (22:50 +0100)]
[BUGFIX] Older changelog not showing in "core" documentation

Change the table of contents of the documentation of extension
"core", so that changes for "archived" version (i.e. 7.0) can
be easily navigated to.

Resolves: #63791
Releases: master
Change-Id: I2dbad6d449f3ae621a68ba81491865a976cc37a5
Reviewed-on: http://review.typo3.org/35323
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Disabled SystemEnvironment check in CLI context 54/35954/2
Frans Saris [Sun, 11 Jan 2015 16:47:25 +0000 (17:47 +0100)]
[BUGFIX] Disabled SystemEnvironment check in CLI context

SystemEnvironment check should not be run in CLI context as
this can give false results.

The php.ini used for CLI can be different from the one used
by the webserver. This may result in false warnings and/or
errors in the email report.

Resolves: #56569
Releases: master, 6.2
Change-Id: Id448853c98342e43f7d82fa7bab9954f2a26f949
Reviewed-on: http://review.typo3.org/35954
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Add PageRepository::getPagesOverlay() 54/36054/5
Christian Weiske [Fri, 16 Jan 2015 21:25:16 +0000 (22:25 +0100)]
[FEATURE] Add PageRepository::getPagesOverlay()

PageRepository::getMenu() calls getPageOverlay() for each single page
in a menu, causing a lot of queries to the SQL database.

This patch introduces getPagesOverlay() which is able to fetch multiple
page record overlays at once.
getMenu() is changed to make use of the new method.

It reduces the number of SQL requests on an uncached "features" page
from the introduction package from 721 to 648.

Change-Id: I014c08b6b63bcee99f94567240f1835077f60f0b
Resolves: #64258
Releases: master
Reviewed-on: http://review.typo3.org/36054
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Add hook to post-process countVersionsOfRecordsOnPage 71/32871/7
Oliver Hader [Thu, 18 Sep 2014 16:31:44 +0000 (18:31 +0200)]
[FEATURE] Add hook to post-process countVersionsOfRecordsOnPage

Hook to post-process BackendUtility::countVersionsOfRecordsOnPage
result. BackendUtility::countVersionsOfRecordsOnPage is used to
visualize workspace states in e.g. the page tree.

Resolves: #61725
Releases: master
Change-Id: I195167ff7989fb9b4ceeb910e2091fad9c9f475c
Reviewed-on: http://review.typo3.org/32871
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[FEATURE] Support 'has*' for properties in ObjectAccess 36/28036/4
Simon Schaufelberger [Tue, 4 Mar 2014 13:28:45 +0000 (14:28 +0100)]
[FEATURE] Support 'has*' for properties in ObjectAccess

Support calling object methods starting with 'has'.

Change-Id: Iec4913203b07fee70e6f5bb3ea9d980d2febc5c9
Resolves: #56529
Releases: master
Reviewed-on: http://review.typo3.org/28036
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Support multiple UID in PageRepository::getMenu() 42/36042/7
Christian Weiske [Fri, 16 Jan 2015 12:56:18 +0000 (13:56 +0100)]
[FEATURE] Support multiple UID in PageRepository::getMenu()

Instead of accepting only a single page ID, PageRepository::getMenu()
now also supports an array of page IDs.
This can be used to fetch the child pages of several pages with a
single SQL query.

Change-Id: I8a8b434177bf9b28a6295a746113c9519bbac997
Resolves: #64257
Releases: master
Reviewed-on: http://review.typo3.org/36042
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[CLEANUP] Improve the @param/@return/@var PHPDoc 85/35885/9
Oliver Klee [Wed, 7 Jan 2015 22:57:14 +0000 (23:57 +0100)]
[CLEANUP] Improve the @param/@return/@var PHPDoc

* use "resource" or MySQL result instead of "pointer"
* use the specific class instead of "object"
* drop the @param of some removed parameters
* fix a few typos in comments
* add the missing parameter name in some @param

This changeset does not add any type hinting in order to
not break any existing code.

Resolves: #38270
Releases: master
Change-Id: Ied64439162d45fccafd15694f56ce675b5001a71
Reviewed-on: http://review.typo3.org/35885
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Consider subfolder in absolute links 80/31780/13
Markus Klein [Thu, 24 Jul 2014 18:44:23 +0000 (20:44 +0200)]
[BUGFIX] Consider subfolder in absolute links

Ensure typolink considers the subfolder an instance might be running in
when creating absolute URLs and absRefPrefix is not set.

Resolves: #60545
Releases: master, 6.2
Change-Id: I8d3c2edc46bd01a9aa061cb695cb8795812cd305
Reviewed-on: http://review.typo3.org/31780
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] getRecordLocalization() must respect transForeignTable 92/11092/8
Martin Tepper [Wed, 9 May 2012 07:36:28 +0000 (09:36 +0200)]
[BUGFIX] getRecordLocalization() must respect transForeignTable

Function BackendUtility::getRecordLocalization() needs to respect
TCA['ctrl']['transForeignTable'] in order to work with pages table.

Change-Id: I4c1c9f0faf6de499fe094846874848c611af7cdd
Resolves: #36971
Releases: master
Reviewed-on: http://review.typo3.org/11092
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Collapsing state for ModuleMenu should be user-specific 27/34027/5
Benjamin Mack [Wed, 24 Dec 2014 01:33:21 +0000 (02:33 +0100)]
[BUGFIX] Collapsing state for ModuleMenu should be user-specific

Using SwitchUser Mode keeps the module menu
configuration (e.g. also closing help menu) the
same even if the user has switched (or does not
have the module available). This leads to unexpected
behaviour.

The change uses the new Storage API for JS
and uses the Persistent Storage instead of the
ClientStorage (localStorage) now.

Resolves: #62894
Releases: master
Change-Id: I10bb0ae5e8bc18e11646e9571a9314e5d3266ff6
Reviewed-on: http://review.typo3.org/34027
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Paginate should handle non-query-result objects 87/25687/16
Tom Ruether [Tue, 15 Jul 2014 16:09:14 +0000 (18:09 +0200)]
[FEATURE] Paginate should handle non-query-result objects

Sometimes it is necessary to use an object storage or
an array instead of a query result.

Resolves: #34944
Releases: master
Change-Id: Ibbfbb30f005f9a21d4f59e7db1d3d0c7046b6a51
Reviewed-on: http://review.typo3.org/25687
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Improve error message 'These fields are not properly updated' 07/35507/5
Georg Ringer [Tue, 16 Dec 2014 06:56:16 +0000 (07:56 +0100)]
[TASK] Improve error message 'These fields are not properly updated'

If something went wrong while updating a record via DataHandler show
the table name and record uid too instead of only the field names.

Resolves: #49000
Releases: master
Change-Id: I0e5291324ec2be511ffb12164e4c0aec6f48f096
Reviewed-on: http://review.typo3.org/35507
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] InstallStatusReport 93/36093/4
Oliver Klee [Sun, 18 Jan 2015 12:01:35 +0000 (13:01 +0100)]
[CLEANUP] InstallStatusReport

- reduce code duplication
- add some @var
- add a missing default case in a switch
- small code formatting fixes
- shorten types
- polish some comments
- add an accessor for $GLOBALS['LANG']
- move an onvertVersionNumberToInteger call out of a loop

Resolves: #64340
Releases: master
Change-Id: Iec21be743d684628b2a5845f3e3574d4a7256678
Reviewed-on: http://review.typo3.org/36093
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Hide foreign_selector if maxitems is reached 36/19336/5
Stefan Frömken [Wed, 27 Mar 2013 07:15:24 +0000 (08:15 +0100)]
[BUGFIX] Hide foreign_selector if maxitems is reached

If the number of elements is reached (maxitems) then
foreign_selector is still there. If maxitems is reached
it does not make sense keep showing this selector.

Resolves: #46552
Releases: master
Change-Id: Ic780c2dfae0fcaaf1938c142ae8731a9109ff1b0
Reviewed-on: http://review.typo3.org/19336
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Show FAL captions in Page module 13/36013/6
Mathias Schreiber [Wed, 14 Jan 2015 16:00:49 +0000 (17:00 +0100)]
[BUGFIX] Show FAL captions in Page module

The page module only showed the contents of the old field
tt_content.imagecaption.

With FAL in place we now show the description from the FAL references.

Resolves: #64281
Releases: 6.2, master
Change-Id: I868348e11e59dad3b2affc7114e3913e7f9e985a
Reviewed-on: http://review.typo3.org/36013
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Extend access control for pages 22/23922/10
Thorben Kapp [Fri, 20 Sep 2013 08:30:49 +0000 (10:30 +0200)]
[FEATURE] Extend access control for pages

Add a hook to the end of TYPO3\CMS\Frontend\Page\PageRepository->init()
to make it possible to adjust the where_hid_del and other parts which are
responsible for page visibility.

Resolves: #52131
Releases: master
Change-Id: I27a915d7c345ec09ecead00e575ddd57ed92e939
Reviewed-on: http://review.typo3.org/23922
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[TASK] RTE: Cleanup iframe initialization 98/36098/4
Stanislas Rolland [Sun, 18 Jan 2015 16:55:07 +0000 (11:55 -0500)]
[TASK] RTE: Cleanup iframe initialization

Releases: master
Resolves: #64343
Change-Id: I3be65963074d2c95f7617ac8a61ddc8b71adec8a
Reviewed-on: http://review.typo3.org/36098
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE fails to load in IE 11 with "Access denied" 94/36094/3
Stanislas Rolland [Sun, 18 Jan 2015 14:10:46 +0000 (09:10 -0500)]
[BUGFIX] RTE fails to load in IE 11 with "Access denied"

Fix identification of IE 11 as Internet Explorer by RTE.

Note: ExtJS 3.4 will still not recognize IE 11 as Internet Explorer.

Releases: master
Resolves: #55775
Change-Id: Ib2a52159f4c7ec92a3eb9a33203292be64632b13
Reviewed-on: http://review.typo3.org/36094
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Make treelist cache work with bigger trees 92/36092/2
Mathias Schreiber [Sun, 18 Jan 2015 10:41:07 +0000 (11:41 +0100)]
[BUGFIX] Make treelist cache work with bigger trees

If the result of a treelist call returns more characters than a normal
TEXT field in MySQL can handle TYPO3 acts unpredictable because of
a corrupted results in the query.
Changing the field to mediumtext for the time being should cover most
usecases.

Resolves: #22982
Releases: master
Change-Id: I8572accfd97101c80634bbd91abaff80e87f20d0
Reviewed-on: http://review.typo3.org/36092
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] Replace strlen() with === for zero length check 94/27794/10
Markus Klein [Sun, 23 Feb 2014 10:21:20 +0000 (11:21 +0100)]
[CLEANUP] Replace strlen() with === for zero length check

It is faster to compare a string with === '' to find out if it's empty
than to run strlen() on it.

The replacement rules are applied as follows:
 *    if (strlen($str))
   => if ((string)$str !== '')
 *    if (!is_string($str) || strlen($str) === 0)
   => if (!is_string($str) || $str === '')
 * If it can be seen easily that $str is a string,
   the typecast is omitted.

Change-Id: I888d70e42f925bd57ad23b873b72d6a38acb39ef
Resolves: #54091
Releases: master
Reviewed-on: http://review.typo3.org/27794
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[FEATURE] Add attribute "multiple" to f:form.upload viewhelper. 94/33194/7
Jost Baron [Tue, 7 Oct 2014 20:26:45 +0000 (22:26 +0200)]
[FEATURE] Add attribute "multiple" to f:form.upload viewhelper.

This makes it possible to upload multiple files with one upload field.

Resolves: #47666
Releases: master
Change-Id: If048a75d20472ee4bedbd64912a4f2d4a5c0205d
Reviewed-on: http://review.typo3.org/33194
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Respect HTTP headers from JsonView 39/34839/8
Helmut Hummel [Sun, 30 Nov 2014 22:16:46 +0000 (23:16 +0100)]
[BUGFIX] Respect HTTP headers from JsonView

When rendering the json view, headers are set to the response
which are then sent by Extbase after the plugin is rendered.

However this takes place before the core (TypoScriptFrontendController)
sends the same header unless deactivated.

This change adds a new property to TypoScriptFrontendController to
be able for plugins to set the content type header to be sent.

Additionally the JsonView now makes use of this.

This is a temporary solution unless we have a proper
request/response model for frontend rendering.

Releases: master
Resolves: #60624
Change-Id: I29fa92e21495864a3c7777bbb0bc8e375267850e
Reviewed-on: http://review.typo3.org/34839
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Trim submitted login-form-data before usage 43/35943/7
Stefan Neufeind [Sat, 10 Jan 2015 01:06:05 +0000 (02:06 +0100)]
[TASK] Trim submitted login-form-data before usage

Trimming form-data prevents common errors with copied
spaces, tabs or linebreaks in the formfields.

Change-Id: Id1ead90ef405c2c944f4c30e1e61e63597355b79
Resolves: #64229
Releases: master
Reviewed-on: http://review.typo3.org/35943
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[TASK] Improve error reporting on fixture loading 45/36045/2
Christian Weiske [Fri, 16 Jan 2015 14:53:47 +0000 (15:53 +0100)]
[TASK] Improve error reporting on fixture loading

Show the actual SQL error that happened when loading a fixture
file in the functional tests fails.

Change-Id: I1a7620a3fe1c37ed017f37b16a516b969319353e
Resolves: #64313
Releases: master
Reviewed-on: http://review.typo3.org/36045
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Standalone- and TemplateView must not require ucfirst file names 12/34812/26
Markus Klein [Thu, 27 Nov 2014 14:13:18 +0000 (15:13 +0100)]
[BUGFIX] Standalone- and TemplateView must not require ucfirst file names

There's no reason to require ucfirst file names for Layouts and Partials.
This patch allows free naming of Layouts, Partials and Templates.
For best performance we really suggest to stick to UpperCamelCase though.

Change-Id: I04049e2cd248288efb97e06cac3b5d8000fd1d52
Resolves: #63367
Resolves: #58087
Resolves: #64049
Releases: master
Reviewed-on: http://review.typo3.org/34812
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Add a check if TYPO3 version is maintained 11/35811/7
Frederic Gaus [Tue, 6 Jan 2015 08:08:51 +0000 (09:08 +0100)]
[FEATURE] Add a check if TYPO3 version is maintained

Modifies the status report of the install tool. Currently only
bugfix releases are taken into account. With this patch the reports
module will also show an error when the minor version is outdated
(e.g. 7.0 after the 7.1 release)

Change-Id: Ia147d5a4233b225bba435af590f72b77024181fa
Releases: master
Resolves: #62649
Reviewed-on: http://review.typo3.org/35811
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Passwords must be encrypted when saving records 12/35812/2
Nils Heuermann [Tue, 6 Jan 2015 08:35:37 +0000 (09:35 +0100)]
[BUGFIX] Passwords must be encrypted when saving records

Due to old class names in the formevals configuration passwords were
not encrypted by saltedpasswords. Using the namespaced class names in
the configuration ensures that the evaluator methods are called.

Resolves: #64140
Releases: master
Change-Id: I4cde0465bfe0bf4eccc2e7124b0ef8f29598ce14
Reviewed-on: http://review.typo3.org/35812
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] CSS3 function calc must retain whitespace 66/35366/3
Christian Futterlieb [Fri, 14 Nov 2014 18:17:10 +0000 (19:17 +0100)]
[BUGFIX] CSS3 function calc must retain whitespace

Whitespaces within CSS3 function 'calc' must not be stripped
because otherwise browsers won't recognize it anymore.

Although the CSS3 specification requires the whitespaces around
the additive expressions (+/-) only, it might be better to not
remove any whitespace within a calc function in terms of
simplicity.. the minifying is complex enough as it already is.

Resolves: #62463
Releases: master, 6.2
Change-Id: Ied0c02e132aafa97ce9fb6b0e9930898cb17efc1
Reviewed-on: http://review.typo3.org/35366
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[FEATURE] Allow nested array access in getData type field 40/36040/5
Mathias Schreiber [Fri, 16 Jan 2015 10:43:43 +0000 (11:43 +0100)]
[FEATURE] Allow nested array access in getData type field

In order to make Typoscript more consistent we now allow to use nested
access to arrays for the datatype "field".

Resolves: #20767
Releases: master
Change-Id: I801054175c94151b7799300c575e34a1a29c7086
Reviewed-on: http://review.typo3.org/36040
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[CLEANUP] Rename variable in addPItoST43 84/36084/2
Andreas Fernandez [Sat, 17 Jan 2015 19:20:40 +0000 (20:20 +0100)]
[CLEANUP] Rename variable in addPItoST43

Rename the variable $prefix to $suffix, since the variable holds a
suffix here.

Resolves: #64335
Releases: master
Change-Id: Ibb217cfa9f0b002ec6b269e6bd6b0bc632c8d14f
Reviewed-on: http://review.typo3.org/36084
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Improve Layout of CType Menu in page module 53/35953/13
Mathias Schreiber [Tue, 13 Jan 2015 12:01:40 +0000 (13:01 +0100)]
[TASK] Improve Layout of CType Menu in page module

CType menu will now display the selected menu_type and a headline.

Fixes: #39646
Releases: master
Change-Id: I69bf3900c791950487e57621579599437a4cc6e5
Reviewed-on: http://review.typo3.org/35953
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] Follow up: Fix broken SQL in DeprecatedRteProperties 79/36079/3
Andreas Fernandez [Sat, 17 Jan 2015 17:35:38 +0000 (18:35 +0100)]
[BUGFIX] Follow up: Fix broken SQL in DeprecatedRteProperties

Add a closing parenthesis that got lost in commit
I355893b51cf9e02c0cdfbdaf16fd7760c5687068. Also use $db instead of
$GLOBALS['TYPO3_DB'].

Resolves: #64333
Releases: master, 6.2
Change-Id: I53a7e166215b9fa18e94228194ed1f99a5bdb3ab
Reviewed-on: http://review.typo3.org/36079
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Set range for limit field 78/36078/2
Andreas Fernandez [Sat, 17 Jan 2015 17:01:32 +0000 (18:01 +0100)]
[BUGFIX] Set range for limit field

The PHP part forces the value of "showLimit" in the record search being
between 0 and 10000. The range is applied to the form field now.

Resolves: #64332
Releases: master
Change-Id: I1e72a22dd7a09b52ee4f207adf6914470d4c3eaa
Reviewed-on: http://review.typo3.org/36078
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Make AbstractConditionMatcherTest run on HHVM 58/36058/2
Tymoteusz Motylewski [Fri, 16 Jan 2015 23:19:49 +0000 (00:19 +0100)]
[TASK] Make AbstractConditionMatcherTest run on HHVM

AbstractConditionMatcherTest contains unnecessary method mocking
which is breaking the test in HHVM

Resolves: #64326
Releases: master
Change-Id: I97e81c632b4704541873f0dcd842a527bb482273
Reviewed-on: http://review.typo3.org/36058
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] Add Page TSConfig overview in Web->Info 39/36039/7
Mathias Schreiber [Fri, 16 Jan 2015 11:52:18 +0000 (12:52 +0100)]
[FEATURE] Add Page TSConfig overview in Web->Info

Analog to the pagetree overview of Web->Template the module
Web->Info->TSConfig will now show a list of pages holding TSConfig
settings if pid 0 is selected.

Fixes: #19833
Releases: master
Change-Id: I83ba1e14fe12ad4d1be80a694c9d4cb40dc85e0c
Reviewed-on: http://review.typo3.org/36039
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
4 years ago[TASK] Make array utility test do not depend on undefined behaviour 55/36055/4
Tymoteusz Motylewski [Fri, 16 Jan 2015 21:44:27 +0000 (22:44 +0100)]
[TASK] Make array utility test do not depend on undefined behaviour

ArrayUtilityTests expect that order of elements with the same value
will not change. PHP doesn't guarantee that, so it doesn't make
sense to test this behaviour.

This test fails under HHVM which has different sorting
implementation than PHP 5.

Actually PHP 7 is going into the same direction, so sooner
or later this test will fail also under PHP.
See https://github.com/php/php-src/pull/999
and https://github.com/facebook/hhvm/issues/4649

Resolves: #64322
Releases: master
Change-Id: Ie48e57456eee20ff9b1a0efc0ac38413f16c5de1
Reviewed-on: http://review.typo3.org/36055
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] RTE: WebKit may insert a span tag when backspacing a heading 35/36035/5
Stanislas Rolland [Fri, 16 Jan 2015 02:25:52 +0000 (21:25 -0500)]
[BUGFIX] RTE: WebKit may insert a span tag when backspacing a heading

It may happen, for example, when deleting an empty heading which is
followed by a paragraph, or when backspacing a paragraph or heading
which becomes merged with a preceding heading.
Remove the unwanted span element.

Releases: master, 6.2
Resolves: #59562
Change-Id: I820dfd0e39f2686e07d10b86af6deff59a57cc38
Reviewed-on: http://review.typo3.org/36035
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Incorrect identification of some key events in Chrome 59/36059/3
Stanislas Rolland [Sat, 17 Jan 2015 02:44:53 +0000 (21:44 -0500)]
[BUGFIX] RTE: Incorrect identification of some key events in Chrome

Processing of the browser event key property is incorrect and leads
to errors in Google Chrome which does not support this property.

Releases: master
Resolves: #64328
Change-Id: I79734c54169c9d639478f9da292b93233bf75c3d
Reviewed-on: http://review.typo3.org/36059
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Skip updates if InitialUpdateDatabaseSchema is needed 20/35020/2
Markus Klein [Thu, 4 Dec 2014 01:23:44 +0000 (02:23 +0100)]
[BUGFIX] Skip updates if InitialUpdateDatabaseSchema is needed

In case the InitialUpdateDatabaseSchema needs to add fields
to the database, we must not run any checks (like checkForUpdate)
of other updates, since they may require a new field to
be present already in the database, which would lead to
SQL errors.

Resolves: #63556
Releases: master
Change-Id: I39454c9bacc187276bf30fd55cd06874048d3d6a
Reviewed-on: http://review.typo3.org/35020
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] Correct the type of variable $lineNumberOffset 48/36048/2
Michael Oehlhof [Fri, 16 Jan 2015 18:06:41 +0000 (19:06 +0100)]
[CLEANUP] Correct the type of variable $lineNumberOffset

The variable $lineNumberOffset is used as an integer in the whole file,
but was declared as string.

Resolves: #64316
Releases: master
Change-Id: I7c898119c91a702212c0ae2e96340e6fc604b65e
Reviewed-on: http://review.typo3.org/36048
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] RTE: Incorrect event trigger in CopyPaste plugin 32/36032/2
Stanislas Rolland [Thu, 15 Jan 2015 20:15:19 +0000 (15:15 -0500)]
[BUGFIX] RTE: Incorrect event trigger in CopyPaste plugin

The trigger statement still uses the ExtJS syntax.

Releases: master
Resolves: #64304
Change-Id: Iacfd3e4f155efff9569f13785a87c5a649400098
Reviewed-on: http://review.typo3.org/36032
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Abbreviation record does not show up on standard pages 27/36027/2
Stanislas Rolland [Thu, 15 Jan 2015 17:11:30 +0000 (12:11 -0500)]
[BUGFIX] RTE: Abbreviation record does not show up on standard pages

Add the Abbreviation record in ext_tables.php.

Releases: master
Resolves: #64303
Change-Id: I2c8a449020097ebef753d48b3554db4f28ff0e2f
Reviewed-on: http://review.typo3.org/36027
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Make output of additionalCSS valid 28/36028/4
Mathias Schreiber [Thu, 15 Jan 2015 17:13:07 +0000 (18:13 +0100)]
[BUGFIX] Make output of additionalCSS valid

INTincScript_loadJSCode no longer wraps CSS in CDATA tags.
Doing so resulted in invalid CSS markup.

Fixes: #20339
Releases: 6.2, master
Change-Id: I5e9d3ff8867c8ba5dfbdc711ba3942124e68b911
Reviewed-on: http://review.typo3.org/36028
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Michael Stucki <michael.stucki@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] RTE: Incorrect tooltip of paste behaviour toggle in toolbar 26/36026/2
Stanislas Rolland [Thu, 15 Jan 2015 16:39:24 +0000 (11:39 -0500)]
[BUGFIX] RTE: Incorrect tooltip of paste behaviour toggle in toolbar

The tooltip for the paste behaviour toggle button in the toolbar
is broken.

Releases: master
Resolves: #64302
Change-Id: Ib816771627aa037af7f7dcc3686d8499b2c9dfbb
Reviewed-on: http://review.typo3.org/36026
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[CLEANUP] SqlParser 30/31730/11
Andreas Fernandez [Wed, 23 Jul 2014 07:05:08 +0000 (09:05 +0200)]
[CLEANUP] SqlParser

Introduce a few optimizations in
the SqlParser classes of "core" and "dbal".

* Change some regular expressions (see benchmark file in forge)
* Strict comparison
* Put often used variable manipulation into a new method
* Definition of $comparatorPatterns was in a while() without any
  modification on it, so make it a protected member

Resolves: #60479
Releases: master
Change-Id: Ica1d3686e30835b7540e159bb5a34127d206f054
Reviewed-on: http://review.typo3.org/31730
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE avoid exception on folder inaccessibility 05/35905/3
Markus Klein [Thu, 8 Jan 2015 14:59:55 +0000 (15:59 +0100)]
[BUGFIX] RTE avoid exception on folder inaccessibility

Catch exceptions that might occur when resolving the parent directory of
a file and the user does not have access to it.

Releases: master, 6.2
Resolves: #64187
Change-Id: I879b341e1eb4c639012da7bc7942d96131bf45b0
Reviewed-on: http://review.typo3.org/35905
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Support void elements without whitespace in parseFunc 04/36004/3
Steffen Müller [Tue, 13 Jan 2015 18:11:09 +0000 (19:11 +0100)]
[BUGFIX] Support void elements without whitespace in parseFunc

xhtml specs require void HTML elements like "<br>" to be
terminated with a "/", for example "<br />".
Whitespaces before the "/" are optional, so tags without
whitespaces are parsed by parseFunc, for example "<br/>"

Resolves: #64267
Releases: master, 6.2
Change-Id: I86a5857b93aeefbc457c309fe4fedd84578ac698
Reviewed-on: http://review.typo3.org/36004
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Remove width restriction for logo in backend 91/35991/2
Georg Ringer [Tue, 13 Jan 2015 11:46:16 +0000 (12:46 +0100)]
[TASK] Remove width restriction for logo in backend

Remove the restriction of 50px because it makes it very hard
to style the backend a bit different for a client, e.g. adding the
customer's name and the context.

Change-Id: I77e9f0d3e2c41565c34b8f385ba5bb7e673a8f6f
Resolves: #64260
Releases: master
Reviewed-on: http://review.typo3.org/35991
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Hidden content is displayed in view module 17/35817/4
Stefan Froemken [Tue, 6 Jan 2015 12:22:23 +0000 (13:22 +0100)]
[BUGFIX] Hidden content is displayed in view module

Since TYPO3 4.2.3 hidden content elements and hidden
pages are displayed in view page module. There are many people
in the community who wants them to be hidden by default.
This patch reactivates the old way from TYPO3 4.2.2. If you
want to see the hidden elements again you have to add
config.admPanel = 1 in your TypoScript. The checkboxes
in admPanel to display hidden records works now again.

Resolves: #20335
Releases: master, 6.2
Change-Id: I146518fbacf0b381bc7c705aa8cb6275af175712
Reviewed-on: http://review.typo3.org/35817
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add tx_indexedsearch as class alias again 07/36007/5
Mathias Schreiber [Wed, 14 Jan 2015 14:24:28 +0000 (15:24 +0100)]
[BUGFIX] Add tx_indexedsearch as class alias again

Registering a "pibase" frontend plugin with addPItoST43($_EXTKEY)
generates a TypoScript snipped for indexed_search like:

plugin.tx_indexdsearch = USER_INT
plugin.tx_indexedsearch.userFunc = tx_indexedsearch->main

The class will be instantiated and main() is called at render
time. There is no easy way to change this. In case of
indexed_search, the "old" class name "tx_indexedsearch" must
be kept as alias to the namespaced class name for the time being
to not trigger a "class not found" fatal error.

Fixes: #64280
Releases: master
Change-Id: I4f41b51b382f69a15ed4e5f19b044d5b9882ed80
Reviewed-on: http://review.typo3.org/36007
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Update vfsStream to 1.4 16/36016/2
Tymoteusz Motylewski [Wed, 14 Jan 2015 18:26:36 +0000 (19:26 +0100)]
[TASK] Update vfsStream to 1.4

Update vfsStream library version as it runs nicely on hhvm.
This library is used only in unit tests.
No functional changes are expected.

Resolves: #64285
Releases: master
Change-Id: I01cce99551b012841e13bdf5f7354e6850841521
Reviewed-on: http://review.typo3.org/36016
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] RTE: Toolbar items do not wrap correctly 15/36015/2
Stanislas Rolland [Wed, 14 Jan 2015 17:07:29 +0000 (12:07 -0500)]
[BUGFIX] RTE: Toolbar items do not wrap correctly

Fix total height of some items.

Releases: master, 6.2
Resolves: #64284
Change-Id: I4c01fde183c0046885eccad37a43d3eb78fae75c
Reviewed-on: http://review.typo3.org/36015
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Modify image dialogue is broken 05/36005/2
Stanislas Rolland [Tue, 13 Jan 2015 18:55:14 +0000 (13:55 -0500)]
[BUGFIX] RTE: Modify image dialogue is broken

Fix references to undefined variables.

Releases: master
Resolves: #64244
Change-Id: Ie5b99224c3a393b866248eca046cfbfa3365c83f
Reviewed-on: http://review.typo3.org/36005
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Install Tool: Make Upgrade Wizard compatible with Oracle 00/36000/2
Andreas Fernandez [Tue, 13 Jan 2015 14:50:46 +0000 (15:50 +0100)]
[BUGFIX] Install Tool: Make Upgrade Wizard compatible with Oracle

The wizards in the Install Tool crash with Oracle due to improper
quoting of the values. Wrap the values with fullQuoteStr() to
ensure correct quoting for the used DBMS.

Releases: master, 6.2
Resolves: #64263
Change-Id: I355893b51cf9e02c0cdfbdaf16fd7760c5687068
Reviewed-on: http://review.typo3.org/36000
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] EXT:adodb: Table names in ALTER TABLE are broken 55/35155/3
Andreas Fernandez [Mon, 8 Dec 2014 09:12:18 +0000 (10:12 +0100)]
[BUGFIX] EXT:adodb: Table names in ALTER TABLE are broken

Updating a table using the Oracle DBMS does not work due to improper
quoting in the oci8 datadict.

Resolves: #63659
Releases: master, 6.2
Change-Id: I831f4affebd161cfd22580506714bc6c7d70f207
Reviewed-on: http://review.typo3.org/35155
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Fix regression in prefixLocalAchors feature 89/35989/2
Helmut Hummel [Mon, 12 Jan 2015 17:23:49 +0000 (18:23 +0100)]
[BUGFIX] Fix regression in prefixLocalAchors feature

The security fix for #62723 missed an edge case were the
TypoScriptFrontendController main cObj property is not yet initialized.

Check for this case and create it.

Resolves: #63896
Releases: 4.5, 6.2, master
Change-Id: Ief9338453517e095d120007d8d13ba6405d6fbb8
Reviewed-on: http://review.typo3.org/35989
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Gassner <og@plan2.net>
Reviewed-by: georg kuehnberger <gk@plan2.net>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Peter Niederlag <peter.niederlag@typo3.org>
Tested-by: Peter Niederlag <peter.niederlag@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Pagepath is displayed incorrectly with slash (/) in page title 47/35947/3
Benjamin Mack [Sat, 10 Jan 2015 19:16:12 +0000 (20:16 +0100)]
[BUGFIX] Pagepath is displayed incorrectly with slash (/) in page title

If the current (!) page has a slash in the Page Name,
the first part of that page name is also displayed
in the Path at the upper right, which is not correct.

Resolves: #23179
Releases: master, 6.2
Change-Id: I1070f36f02067c291503c22822e84ee068a3e4d6
Reviewed-on: http://review.typo3.org/35947
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] cObjRenderer->prefixComment() needs parameter validation 73/35973/4
Philipp Gampe [Mon, 12 Jan 2015 17:14:17 +0000 (18:14 +0100)]
[BUGFIX] cObjRenderer->prefixComment() needs parameter validation

The method fails to validate the parameters leading to PHP notices
if the function is used incorrectly in TypoScript.

Resolves: #38969
Releases: master,6.2
Change-Id: If27d530cc70bb7ed4e9baa6f040b66ff2213223b
Reviewed-on: http://review.typo3.org/35973
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix query in abbreviation plugin of rtehtmlarea 64/35864/4
Alexander Stehlik [Wed, 7 Jan 2015 16:04:04 +0000 (17:04 +0100)]
[BUGFIX] Fix query in abbreviation plugin of rtehtmlarea

The comma seperated list of PIDs is not wrapped in quotes any more
to allow more than one page to be searched in.

Additionally invalid SQL queries with an empty IN parameter are
prevented by avoiding any query if the PID list is empty
and the user is locked to DB mounts.

Resolves: #64169
Releases: master, 6.2
Change-Id: I3cf35a900ea84a5f7110e8b262f7aaccb27f3267
Reviewed-on: http://review.typo3.org/35864
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] DBAL: Throw exception if query fails 65/35965/4
Andreas Fernandez [Mon, 12 Jan 2015 09:19:41 +0000 (10:19 +0100)]
[TASK] DBAL: Throw exception if query fails

Throw an exception if a SELECT query fails on DBAL to avoid subsequent
errors.

Resolves: #64245
Releases: master, 6.2
Change-Id: I7e263a3a0157200b0570be68d8153e69306acad3
Reviewed-on: http://review.typo3.org/35965
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Make TCEMAIN.translateToMessage work with lang files 48/35948/2
Benjamin Mack [Sat, 10 Jan 2015 20:04:51 +0000 (21:04 +0100)]
[BUGFIX] Make TCEMAIN.translateToMessage work with lang files

The option TCEMAIN.translateToMessage that prepends
a certain text to a message was apparantly available
with the functionality of "LLL:" in the past.

TCEMAIN.translateToMessage = LLL:EXT:foobar/locallang_be.xml:translateTo

The patch re-introduces the functionality
again which was missing since at least 4.7.

See forge for further details.

Resolves: #41906
Releases: master, 6.2
Change-Id: I7f30ba7fc1d6577073e8a75840762c0912ca5d2c
Reviewed-on: http://review.typo3.org/35948
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] Add async property to JavaScript files 00/34000/7
Arnd Messer [Tue, 11 Nov 2014 13:40:09 +0000 (14:40 +0100)]
[FEATURE] Add async property to JavaScript files

Add a property 'async="async"' to JavaScript files via TypoScript
page.includeJSlibs.<array>.async = 1

This patch affects the TypoScript PAGE properties
* includeJSlibs
* includeJSFooterlibs
* includeJS
* includeJSFooter

Resolves: #28382
Releases: master
Change-Id: I9a86edaba118370d4df9f11216998d808276b634
Reviewed-on: http://review.typo3.org/34000
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>