Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Let Web-View respect TCEMAIN.previewDomain 12/32512/2
Georg Kühnberger [Wed, 27 Aug 2014 14:04:31 +0000 (16:04 +0200)]
[BUGFIX] Let Web-View respect TCEMAIN.previewDomain

Added previewDomain in order to have Web-View functioning in the
same way like Page-Preview does.

Change-Id: I7193cd93a2b9b2d175e162d3fab0b837aefd2487
Fixes: #61226
Related: #30889
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32512
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add missing check in PreparedStatement->execute() 57/32457/2
Jacob Rasmussen [Wed, 27 Aug 2014 15:32:26 +0000 (17:32 +0200)]
[BUGFIX] Add missing check in PreparedStatement->execute()

When using prepared statements for inserts and updates, the
execute method currently fails due to a missing check on the
return value from $this->statement->result_metadata();

Resolves: #61229
Releases: 6.3, 6.2
Change-Id: Ida17f617915c36a0c2e91663eee64b4c358090e2
Reviewed-on: http://review.typo3.org/32457
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] SqlParser: Unify internal usage of tableType/engine 76/32376/2
Stefan Neufeind [Thu, 21 Aug 2014 19:50:05 +0000 (21:50 +0200)]
[TASK] SqlParser: Unify internal usage of tableType/engine

For create-table "tableType" was still used while an alter-table
used "engine".

Change-Id: Idee0e569e331ec66084484f1e8d55d9cab03ff9f
Resolves: #61129
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32376
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Missing stdWrap for select.recursive TypoScript property 09/32209/2
Matthias Kappenberg [Tue, 13 May 2014 11:09:24 +0000 (13:09 +0200)]
[TASK] Missing stdWrap for select.recursive TypoScript property

Processing stdWrap for the select.recursive TypoScript property
has just been forgotten in the original issue #18822 during the
development of TYPO3 4.6.

Change-Id: I34f2ac45e5112fbcc2becf7936f486f0b53d361a
Resolves: #55707
Releases: 6.3, 6.2, 6.1
Reviewed-on: http://review.typo3.org/32209
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Make context menus work with modules 38/32338/2
Helmut Hummel [Mon, 4 Aug 2014 16:30:44 +0000 (18:30 +0200)]
[BUGFIX] Make context menus work with modules

To make it possible to use the module dispatcher
with a click menu item, it is necessary to add
the CSRF token to the URL of the called click menu
functionality.

Resolves: #60635
Releases: 6.3, 6.2
Change-Id: I0b378c3ba4c22f25b10e39950d08568f608decdb
Reviewed-on: http://review.typo3.org/32338
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] EM using bad indexes 34/32334/2
Stefan Froemken [Mon, 23 Jun 2014 15:16:34 +0000 (17:16 +0200)]
[BUGFIX] EM using bad indexes

The extensionmanager uses bad indexes. It is better
to move col repository to the the end of the indexes.

Resolves: #59809
Releases: 6.3,6.2
Change-Id: I0bb8d5cdfc8591bb35485b204ad5e8dafd1b4d16
Reviewed-on: http://review.typo3.org/32334
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Remove non accessible pages from browse menu 33/32333/2
Kay Strobach [Wed, 14 May 2014 07:26:13 +0000 (09:26 +0200)]
[BUGFIX] Remove non accessible pages from browse menu

This patch enables the browse menu to skip inaccessible items
for prev and next links.

It makes use of the filterMenuPages method, which is already
applied to any kind of menu. Since it has not been applied
to the sections of the browse menu type, which are actually
menus themselves, inaccessible pages made browsing unusable.

This applies to missing translations as well.

Change-Id: I8779731139785dea72b078567912c96e3ad5c7ca
Resolves: #58792
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32333
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix call to undefined function when importing t3x 32/32332/2
René Bigler [Wed, 23 Jul 2014 22:06:38 +0000 (00:06 +0200)]
[BUGFIX] Fix call to undefined function when importing t3x

When importing a t3x file that contains files the function
"getFiles" of the object TYPO3\CMS\Core\Resource\Folder is called
which does not exist.

Resolves: #60474
Releases: 6.3, 6.2
Change-Id: Ibc392bced57a85ad6eae333406ff507af7faefd4
Reviewed-on: http://review.typo3.org/32332
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] QueryGenerator getTreeList negative ids 31/32331/2
Klaas Johan Kooistra [Thu, 31 Jul 2014 09:39:39 +0000 (11:39 +0200)]
[BUGFIX] QueryGenerator getTreeList negative ids

When persistence.recursive is configured when using a command controller no
records can be retrieved because the storagePid is negated in the
AbstractConfigurationManager, while claiming all implementations of getTreeList
support negative ids. Using abs() on the id when it is negative fixes this.
Also see the ContentObjectRenderer implementation of getTreeList

Change-Id: I7732290126a83a79204b8224d52a3cd878360e64
Resolves: #60697
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32331
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Collect correct information on elements in page 26/32326/2
Jigal van Hemert [Fri, 1 Aug 2014 04:55:35 +0000 (06:55 +0200)]
[BUGFIX] Collect correct information on elements in page

In the page module information on neighboring content elements is
collected while building the page layout. This information must
be remembered for other elements on the page instead of generated
new when rendering each element. This makes sure the move buttons and
edit buttons have the correct URLs.

Resolves: #60199
Releases: 6.3, 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I9fec256b145fe8aba229d8b026fba73871942347
Reviewed-on: http://review.typo3.org/32326
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Change fetch of maximum version using LEFT JOIN 88/32288/2
Andreas Fernandez [Fri, 8 Aug 2014 12:03:02 +0000 (14:03 +0200)]
[TASK] Change fetch of maximum version using LEFT JOIN

Currently, the method fetchMaximalVersionsForAllExtensions uses a
subselect to determine the highest available version. This solution is
rather inefficient and incomptabile to DBAL. The query is replaced by
a LEFT JOIN.

Resolves: #60857
Releases: 6.2, 6.3
Change-Id: I7ae3c523259bf260c41080aee269f6df33edb408
Reviewed-on: http://review.typo3.org/32288
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years agoRevert "[BUGFIX] Unified maxitems default value for group fields" 84/32284/2
Wouter Wolters [Fri, 25 Jul 2014 16:03:27 +0000 (18:03 +0200)]
Revert "[BUGFIX] Unified maxitems default value for group fields"

Unexpected behaviour. Default of maxitems in now 1 by default
which doesn't work if you need more items. Previously this
was possible. Revert this to have the old working
behaviour again.

Releases: 6.3,6.2
Resolves: #60263
Reverts: #55731
This reverts commit c578d47617f803c9ea167d88000e63a92c13fa93.

Change-Id: Ice5357aecb1969f11c6821cb81824d2d68200717
Reviewed-on: http://review.typo3.org/32284
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Make sure all new files are indexed 69/32269/2
Frans Saris [Tue, 5 Aug 2014 14:19:19 +0000 (16:19 +0200)]
[BUGFIX] Make sure all new files are indexed

If the FAL indexer scheduler task finds a index record with
same content hash as a new found file the file isn't added to the
index if it isn't marked as missing.

This patch changes the indexer so that new files with same
content hash are added when no index record is found for a missing
file with same content hash.

Resolves: #60764
Releases: 6.3, 6.2
Change-Id: Ifb7f9e6f48ba327c958a7aa0e0b71f0575cabdf7
Reviewed-on: http://review.typo3.org/32269
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Avoid DB error on writing to log 57/32257/2
Markus Klein [Tue, 19 Aug 2014 13:10:33 +0000 (15:10 +0200)]
[BUGFIX] Avoid DB error on writing to log

The writeLog() function of the ErrorHandler tries to log the IP that
caused the error. On CLI there is no IP hence a NULL value is being
tried to insert into the DB, where the DB field is NOT NULL.

Fix this by casting the IP to a string.

Resolves: #61051
Releases: 6.3, 6.2
Change-Id: Id46e97468bf825307258e907811d5f2c77c62161
Reviewed-on: http://review.typo3.org/32257
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] "Illegal mix of collations" in Upgrade Wizard 98/32198/2
Lars Trebing [Tue, 12 Aug 2014 15:20:58 +0000 (17:20 +0200)]
[BUGFIX] "Illegal mix of collations" in Upgrade Wizard

When directly comparing CAST(... AS CHAR) with a CHAR field (including
VARCHAR and TEXT) whose collation isn't the same as that of the database
connection, MySQL gives an error like this:

> Illegal mix of collations (utf8_general_ci,IMPLICIT) and
> (utf8_unicode_ci,IMPLICIT) for operation '<>'

Wrapping the right side of the comparison in CAST(... AS CHAR) as well
keeps the data unchanged while ensuring that both sides have the same
collation.

Change-Id: Icaec66412d6b6441ae30065ffb92565991e9a1e4
Resolves: #36754
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32198
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 years ago[TASK] Refactor file references relations retrieval 57/32157/3
Oliver Hader [Wed, 2 Jul 2014 10:20:27 +0000 (12:20 +0200)]
[TASK] Refactor file references relations retrieval

The retrieval of file references in BackendUtility
is currently bound to the thumbCode() method but
is useful for other components as well.

Resolves: #60054
Releases: master, 6.2
Change-Id: Id92bdeaed24d8924285a640f905ffd55db21da4d
Reviewed-on: http://review.typo3.org/32157
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[TASK] Simplify record icons in workspace module 56/32156/2
Oliver Hader [Mon, 30 Jun 2014 19:01:20 +0000 (21:01 +0200)]
[TASK] Simplify record icons in workspace module

The record details view renders record icons for both live and
versioned record. However, this representation is shown rather
stand-alone and can be combined with the accordant headers.

Resolves: #60015
Releases: master, 6.2
Change-Id: I2f468a06271f335c491d90d825f7bcef7a9db9f6
Reviewed-on: http://review.typo3.org/32156
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Admin panel shows wrong cache information 68/31868/2
Dmitry Dulepov [Tue, 25 Feb 2014 11:56:28 +0000 (15:56 +0400)]
[BUGFIX] Admin panel shows wrong cache information

When labels were extracted to translation files, a error was made
that changed the meaning of the admin panel entry. But the code
was not modified to reflect the change of the meaning. Thus the
admin panel shows that the page is cached when it is actually not
cached and vice versa. Additionally, it shows 0 and 1 for the
"Page cached" entry. This should be "yes" or "no", not numbers.

Change-Id: I2519593e7da08b71ccdd5d7dc3dd6ced7ecac3ac
Resolves: #56265
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31868
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Pascal Dürsteler <pascal.duersteler@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Extend install tool suhosin checks 52/32152/2
Oliver Hader [Wed, 16 Jul 2014 10:13:35 +0000 (12:13 +0200)]
[TASK] Extend install tool suhosin checks

Extend install tool suhosin checks by
* suhosin.get.max_name_length=200
* suhosin.post.max_name_length=200
* suhosin.request.max_varname_length=200

Resolves: #60356
Releases: 6.2, 6.3
Change-Id: I382e44832918799df58a912e95cd4b0c3f0b81a3
Reviewed-on: http://review.typo3.org/32152
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] JavaScript error in Install Tool 49/32149/3
Wouter Wolters [Fri, 25 Jul 2014 18:06:30 +0000 (20:06 +0200)]
[BUGFIX] JavaScript error in Install Tool

When using toggleButton in "Test setup" a JavaScript
error is thrown because the scrolling handler can only
be used if the fixed footer is available.

Add a check to prevent this JavaScript error.

Resolves: #60577
Releases: 6.3,6.2
Change-Id: Ie7628e83280f6af032b364586cdfb6b386663d9d
Reviewed-on: http://review.typo3.org/32149
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Use defaultMailFromName setting in install tool 51/32151/2
Oliver Hader [Mon, 4 Aug 2014 08:50:36 +0000 (10:50 +0200)]
[BUGFIX] Use defaultMailFromName setting in install tool

The defaultMailFromName setting is not used for sending
the test mails in the install tool.

Resolves: #60758
Releases: master, 6.2
Change-Id: I35e1b887de6b06bb5f301e037d6d412c18ac0b37
Reviewed-on: http://review.typo3.org/32151
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Show properties of stdClass object in <f:debug> 50/32150/2
Christian Weiske [Tue, 12 Aug 2014 12:13:20 +0000 (14:13 +0200)]
[BUGFIX] Show properties of stdClass object in <f:debug>

Using fluid's <f:debug> to get dumps of json_decode()d objects
does not work currently. The DebuggerUtility shows only properties
obtainable via ReflectionClass, which does not work for stdClass objects.

The patch introduces special handling of stdClass objects, using the
properties that actually exist in the object.

Change-Id: I3845178f6defdbceae4b867f45e5080f23443766
Fixes: #60912
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32150
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Updating "current_version" fails with some DBMS 48/32148/2
Andreas Fernandez [Fri, 8 Aug 2014 14:00:19 +0000 (16:00 +0200)]
[BUGFIX] Updating "current_version" fails with some DBMS

Updating the field "current_version" fails with some DMBS because
$uidsOfCurrentVersion has too many elements. This patch chunks
the array into multiple parts and updates the uids in each part.

Resolves: #60859
Releases: 6.2, 6.3
Change-Id: If63f855b250bf7c9b6cd7112f60392cfc8ccfd67
Reviewed-on: http://review.typo3.org/32148
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Correctly parse suhosin configuration 44/32144/2
Markus Klein [Wed, 13 Aug 2014 08:51:22 +0000 (10:51 +0200)]
[BUGFIX] Correctly parse suhosin configuration

The system environment check does not properly parse the suhosin
configuration option for whitelist.
Fix this by changing the code to be less strict about the actual syntax
of this option.

Resolves: #60925
Releases: 6.3, 6.2
Change-Id: I6797a313cedaaf1895cf7b4fddaae9811341006b
Reviewed-on: http://review.typo3.org/32144
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Failing cascaded delete action of localized elements 37/32137/2
Oliver Hader [Wed, 25 Jun 2014 13:50:02 +0000 (15:50 +0200)]
[BUGFIX] Failing cascaded delete action of localized elements

Having a record in live workspace with an accordant localization
leads to the fact that actions to the default language also have
an impact to all localizations.

In a workspace, first deleting the localization, then deleting
the record of the default language, ends up in actually having
reverted the previous deletion of the localization.

The solution is to check for delete placeholders in
DataHandler::deleteL10nOverlayRecords().

Resolves: #59113
Releases: master, 6.2
Change-Id: I888c83a58d591f57bc2ea75a49fa603a56a7f722
Reviewed-on: http://review.typo3.org/32137
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Publishing delete placeholder affects other workspaces 39/32139/2
Oliver Hader [Fri, 11 Jul 2014 08:49:51 +0000 (10:49 +0200)]
[BUGFIX] Publishing delete placeholder affects other workspaces

On publishing a delete placeholder all other versions shall be
deleted as well, since the original record will be deleted after
that action. However, this is only valid for the live workspace
and using the legacy version behavior there.

DataHandler::deleteVersionsForRecord() calls
BackendUtility::selectVersionsOfRecord(), but without the
additional, but required, $workspace argument. Thus, all other
versions in other workspaces are deleted as well. The SQL query
to determine versions needs to be limited to either the live
workspace (for legacy versions) and the current workspace.

Resolves: #60249
Releases: master, 6.2
Change-Id: If90511dc4ac2bc3dde6e58570e6bf10e4ac949db
Reviewed-on: http://review.typo3.org/32139
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Wrong nesting of deleted versioned child records 38/32138/2
Oliver Hader [Wed, 25 Jun 2014 11:19:13 +0000 (13:19 +0200)]
[BUGFIX] Wrong nesting of deleted versioned child records

If deleting an IRRE child reference, the nesting leving in the
workspace module is not shown correctly. The reason for that is,
that the sys_refindex entry points to the live id of the deleted
child record.

This change takes care of correct visualization only, but does not
touch the sys_refindex behavior in this case.

Resolves: #59853
Releases: master, 6.2
Change-Id: I09970d12ba10e528c150275952ec4c9ff8333a0a
Reviewed-on: http://review.typo3.org/32138
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Page Tree not always updated after workspace actions 36/32136/2
Oliver Hader [Mon, 23 Jun 2014 18:34:59 +0000 (20:34 +0200)]
[BUGFIX] Page Tree not always updated after workspace actions

After some workspace actions being performed in the workspaces
module in the TYPO3 Backend, the page tree does not get updated:
* discarding a single workspace version
* performing mass actions which output warnings

Resolves: #59828
Releases: 6.2, master
Change-Id: Ic9fb6613e8647ed351246ea18fcb3696e60ef7b2
Reviewed-on: http://review.typo3.org/32136
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[BUGFIX] Keep phpunit 4.1 branch 16/32116/2
Christian Kuhn [Tue, 12 Aug 2014 20:22:08 +0000 (22:22 +0200)]
[BUGFIX] Keep phpunit 4.1 branch

composer.json is configured to fetch latest phpunit 4.x branch.
Since 4.2 was just released stable, it will be used now.

phpunit 4.2 now relies on Ocramius/Instantiator to create mocks
that do not call a constructor during instantiation. This project
was created to cope with a recent security fix in PHP unserialize()
that rendered the old way of creating those mocks invalid.

The instantiator project however has issues with PHP versions
5.3 and 5.6 that lead to some failing tests and need further
investigation.

To not run into this during our next merges, the patch nails
phpunit to 4.1.x for now.

Change-Id: I5feb8346e0713fefe6c8fa899c76d3e040dd1973
Resolves: #60923
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32116
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Adjust variable name for install tool password hint 92/31992/2
Anja Leichsenring [Mon, 28 Jul 2014 13:32:16 +0000 (15:32 +0200)]
[BUGFIX] Adjust variable name for install tool password hint

Usage of $TYPO3_CONF_VARS is discouraged, instead
$GLOBALS['TYPO3_CONF_VARS'] should be used. The hint in next to the
install tool login mask spells the discouraged version, which is
corrected with this patch.

Change-Id: Ia7ded107a9b5670c0bc35da92993e84ad45c167e
Releases: master, 6.2
Resolves: #60639
Reviewed-on: http://review.typo3.org/31992
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Fetch related records for existing uids only 47/31947/2
Jo Hasenau [Thu, 24 Jul 2014 18:52:12 +0000 (20:52 +0200)]
[BUGFIX] Fetch related records for existing uids only

Before fetching related records from a foreign table, we must ensure
that there is a uid to be considered, since otherwise we will fetch
any record having a 0 value for that field.

There are method calls in the core, that don't provide a uid, so the
default value 0 is used, i.e. when fetching children of translated
gridelements, causing memory outage when tt_content is > 10000 records.

Resolves: #60494
Releases: 6.3, 6.2
Change-Id: I1105964f98f79074bb37dc1921180b493fac4bc6
Reviewed-on: http://review.typo3.org/31947
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Prevent exception in RTE filelinks upgrade wizard 33/31933/2
Mattias Nilsson [Fri, 1 Aug 2014 09:32:24 +0000 (11:32 +0200)]
[BUGFIX] Prevent exception in RTE filelinks upgrade wizard

When using the upgrade wizard for RTE filelinks and the record is
not an array it throws an exception.

To give the end user a better experience an additional condition
for checking that the variable is an array is added.

Resolves: #58898
Releases: 6.3, 6.2
Change-Id: I94ae6cc7272a63fd208267bf375b629cb5a4b2cc
Reviewed-on: http://review.typo3.org/31933
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Refine the error message of checkMaximumFileUploadSize 81/31881/2
Markus Klein [Sun, 27 Jul 2014 20:44:50 +0000 (22:44 +0200)]
[BUGFIX] Refine the error message of checkMaximumFileUploadSize

The Install Tool check the PHP configuration for the maximum file
upload size within the checkMaximumFileUploadSize() method.
This method issues an error message in case the values do not fit.
The error message outputs the values in MB which might give a
wrong indication to the user, as the values seem to be equal
although the check complains they are not.

Provide better output by giving those numbers in KB rather than MB,
which will show diverging numbers correctly then.

Resolves: #60627
Releases: 6.3, 6.2
Change-Id: I5faa4ceb4d7279278182716c31bf6d6dcb851052
Reviewed-on: http://review.typo3.org/31881
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Show loading spinner when Updating TER list on search module 64/31864/2
Sascha Egerer [Sat, 26 Jul 2014 13:02:27 +0000 (15:02 +0200)]
[BUGFIX] Show loading spinner when Updating TER list on search module

When you search for an extension in the Extension manager and then click
on the "Update Now" button to load the newest list from the TER, the
spinner was not displayed.

Also fixed some invalid HTML stuff and repositioned the spinner.

Resolves: #60600
Releases: 6.3, 6.2
Change-Id: I670d821248d14c0c1038b5995fc7daef2ead42d8
Reviewed-on: http://review.typo3.org/31864
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Fix Extbase language fallback in query parser 62/31862/2
Helmut Hummel [Sun, 27 Jul 2014 08:55:35 +0000 (10:55 +0200)]
[BUGFIX] Fix Extbase language fallback in query parser

Currently when TYPO3 is configured to do language fallback
and a record is translated in language A, but not
in language B and language B is requested, then this
record is excluded.

This is the case because of a wrong subselect condition.

Extbase selects records in the requested translation
or if no translation is available in the default language.
However the check if translation is available looks
for *any* translation not only for a translation in the
requested language. Thus the record from the default
language is not selected at all if there are translations
available in any other language.

Solution is to change the subselect condition to check
for the currently requested language.

Releases: 6.1, 6.2, master
Resolves: #60613
Change-Id: I8ebd68e1f5741d3557910ae2f8c2d19474548d01
Reviewed-on: http://review.typo3.org/31862
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Fix the help message of CLI 57/31857/2
Stefano Kowalke [Tue, 24 Jun 2014 11:26:41 +0000 (13:26 +0200)]
[BUGFIX] Fix the help message of CLI

The help command prints informations about a specific command.
This text is taken from the doc comment by reflection.

Currently the parser expects that type, variable name and comment
are separated by exactly one space, according to our CGL.

Relax the parsing to allow multiple whitespace characters (including tabs)
as separators when fetching the comment for an argument,
to support other coding styles.

Resolves: #59843
Releases: 6.3, 6.2
Change-Id: Id0a9c0ec00bf442adcbd428088744419200a69a0
Reviewed-on: http://review.typo3.org/31857
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[CLEANUP] Let expected exceptions test for code, not text 36/31836/2
Anja Leichsenring [Fri, 25 Jul 2014 19:33:02 +0000 (21:33 +0200)]
[CLEANUP] Let expected exceptions test for code, not text

When an exception is expected in DependencyUtilityTest, the correct
exception is tested by text. The change of wording of some of those
exceptions caused the related test to fail.

Testing for the exception code instead of the text opens the
possibility to adapt display messages, while the exception code stays
unchanged and stabilizes tests against false positives.

Change-Id: Ib1365c8d7166e522690bb9f8842adc8eb27f635b
Resolves: #60583
Relates: #53572
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31836
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Change wording for TYPO3 dependency errors 33/31833/2
Susanne Moog [Fri, 25 Jul 2014 17:44:29 +0000 (19:44 +0200)]
[BUGFIX] Change wording for TYPO3 dependency errors

The wording of a TYPO3 dependency error currently suggests
installing another TYPO3 version to make an extension usable -
that does not make sense.

Change the error message so it's clear that it's the extensions'
support that is missing.

Change-Id: I7a5f7acde7bebc9c3f7acda92e2522ffb979d478
Resolves: #53572
Fixes: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31833
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Install Tool image tests: black background after scaling 27/31827/2
Susanne Moog [Fri, 25 Jul 2014 15:05:48 +0000 (17:05 +0200)]
[BUGFIX] Install Tool image tests: black background after scaling

Transparent turns black unless you specify a different color
because transparent = unset color = 0 = black. We should fix this
by adding the "-opaque white -background white -flatten"
parameters for the convert action done
by the install tool.

Change-Id: I5dd5c41852a33159752702b68ce0a297b33cf569
Releases: 6.3, 6.2
Fixes: #60570
Reviewed-on: http://review.typo3.org/31827
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Extension manager page browser not disabled on list update 24/31824/2
Susanne Moog [Fri, 25 Jul 2014 17:22:53 +0000 (19:22 +0200)]
[BUGFIX] Extension manager page browser not disabled on list update

The extension list on "get extensions" only masks the table when
loading where it should also mask the page browser as you will get
errors when using it while the list is still loading.

The mask now covers the whole ter table content.

Change-Id: I404e4f1a5b9b62a53392491c911d654ce6f007b3
Releases: 6.2, 6.3
Fixes: #55317
Reviewed-on: http://review.typo3.org/31824
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[TASK] Add missing unit test for enumeration 19/31819/2
Sascha Egerer [Fri, 25 Jul 2014 16:00:56 +0000 (18:00 +0200)]
[TASK] Add missing unit test for enumeration

Add unit test that checks if the constructor throws
an exception if an invalid value is requested.

Resolves: #60572
Releases: 6.3, 6.2
Change-Id: I2179414f94bbd6465c5b780c71dfed3c91e71776
Reviewed-on: http://review.typo3.org/31819
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Respect global renderReadonly in Tceforms for tree 15/31815/2
Lorenz Ulrich [Tue, 24 Jun 2014 12:45:48 +0000 (14:45 +0200)]
[BUGFIX] Respect global renderReadonly in Tceforms for tree

The global renderReadonly status in Tceforms doesn't affect a
rendered tree because the check was forgotten when #25888 was
implemented. An additional check is added.

Resolves: #59849
Releases: 6.3, 6.2
Change-Id: Ic89ab2f39636dbbb7dc37941af8fe7be085fefcf
Reviewed-on: http://review.typo3.org/31815
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Menu-links generate two empty spaces at closing anchor 82/31682/2
Tomita Militaru [Tue, 12 Nov 2013 15:52:33 +0000 (17:52 +0200)]
[BUGFIX] Menu-links generate two empty spaces at closing anchor

Checks for ATagParams & access key code before adding empty
spaces between anchor parameters.

Resolves: #50566
Releases: 6.3, 6.2, 6.1
Change-Id: I57a2a2a06a97fc1eda6e0438bfdc6e210437e5bb
Reviewed-on: http://review.typo3.org/31682
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Adjust comment for default HTTP-userAgent 35/31735/2
Stefan Neufeind [Wed, 16 Jul 2014 21:14:06 +0000 (23:14 +0200)]
[BUGFIX] Adjust comment for default HTTP-userAgent

The default userAgent is for example TYPO3/6.2.4

Change-Id: I2412b901a3a42938a433e7d8a414de24587011a3
Resolves: #60365
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31735
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[TASK] Fix wrong named unit tests of the logging framework 04/31804/2
Sascha Egerer [Thu, 24 Jul 2014 20:50:44 +0000 (22:50 +0200)]
[TASK] Fix wrong named unit tests of the logging framework

Most of the unit tests for the logging framework have a
wrong filename and also a wrong classname.

Resolves: #60547
Releases: 6.3, 6.2
Change-Id: I5aaad54566bd33a9caf0d665655d9cb0f4552119
Reviewed-on: http://review.typo3.org/31804
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Add wrapper for GeneralUtility::getIndpEnv in ContentObjectRenderer 92/31792/2
Sascha Egerer [Fri, 25 Jul 2014 08:15:35 +0000 (10:15 +0200)]
[TASK] Add wrapper for GeneralUtility::getIndpEnv in ContentObjectRenderer

A wrapper function for GeneralUtility::getIndpEnv() is required
to mock these static calls in unit tests.

Resolves: #60549
Releases: 6.3, 6.2
Change-Id: I47b565f5a5bd9b2445847d38447c01cfa20954c7
Reviewed-on: http://review.typo3.org/31792
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Make call to isPackageKeyValid non-static 78/31778/2
Peter Niederlag [Thu, 24 Jul 2014 10:50:24 +0000 (12:50 +0200)]
[BUGFIX] Make call to isPackageKeyValid non-static

Function isPackagKeyValid on PackageManeger is not a static function
and must be called on an object instance.

Resolves: #59619
Releases: 6.3, 6.2
Change-Id: I03b068db00ccdf76b6e8658721e630b7de6ebfd8
Reviewed-on: http://review.typo3.org/31778
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Turn isOnSymmetricSide into static function 77/31777/2
Peter Niederlag [Thu, 24 Jul 2014 10:20:20 +0000 (12:20 +0200)]
[BUGFIX] Turn isOnSymmetricSide into static function

Function isOnSymmetricSide of RelationHandler is used as
static function all the time so we properly turn the function
declaration into a static one.

Resolves: #60516
Releases: 6.3, 6.2
Change-Id: I72a922596e69dca26e173dad5b42da76e0949865
Reviewed-on: http://review.typo3.org/31748
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
(cherry picked from commit 0674579840c2785323cba9d3e860c768f875ddf3)
Reviewed-on: http://review.typo3.org/31777

5 years ago[TASK] Keep the changes to PackageStates.php low 74/31774/2
Markus Klein [Fri, 28 Feb 2014 10:06:34 +0000 (11:06 +0100)]
[TASK] Keep the changes to PackageStates.php low

Introduce a sort operation of the packages before determining
the loading order.
This way the number of changes made to the PackageStates.php file
are reduced.

This is only a first step, further improvements have to be made
to finally resolve #56362.

Resolves: #56362
Releases: 6.3, 6.2
Change-Id: Id6cc4cc2d3f4d9f00e90f355bdede1afe20f57af
Reviewed-on: http://review.typo3.org/31774
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Add label for title of "Edit metadata" link 72/31772/2
Markus Klein [Sun, 20 Jul 2014 15:28:43 +0000 (17:28 +0200)]
[BUGFIX] Add label for title of "Edit metadata" link

Currently the title of the "Edit metadata" link in filelist is
hardcoded. Add a label to make it translatable.

Resolves: #60410
Releases: 6.3, 6.2
Change-Id: Id618dfcd96ae3b4558cf9d529e0cc7c3ae220f9a
Reviewed-on: http://review.typo3.org/31772
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[TASK] Remove skipped FAL functional tests 69/31769/2
Christian Kuhn [Thu, 24 Jul 2014 16:02:10 +0000 (18:02 +0200)]
[TASK] Remove skipped FAL functional tests

Utility/File/ExtendedFileUtilityTest.php contains some old FAL
related tests that are not maintained for quite some time, broken
and skipped.
Functional tests for FAL should be re-written if needed from scratch
so these tests are removed for now.

Resolves: #60541
Releases: 6.3, 6.2
Change-Id: Ib703f5c4bbd5d52ef5c67f0fc2f2387772c315fd
Reviewed-on: http://review.typo3.org/31769
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[TASK] Add a "save and close" button in the extensionmanager 66/31766/2
Eric Chavaillaz [Mon, 23 Jun 2014 16:08:17 +0000 (18:08 +0200)]
[TASK] Add a "save and close" button in the extensionmanager

Resolves: #59812
Releases: 6.3, 6.2
Change-Id: I3ccfbdd496af2fca9a72d2675393537eafffd075
Reviewed-on: http://review.typo3.org/31766
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Catch freshly introduced ResourceDoesNotExistException 65/31765/2
Anja Leichsenring [Thu, 24 Jul 2014 13:55:29 +0000 (15:55 +0200)]
[BUGFIX] Catch freshly introduced ResourceDoesNotExistException

Change #60506 introduced a new specific exception in case a file
reference can not be resolved. This new exception now needs to be
catched on the right places.

Change-Id: I545f4eb98386918903380cc3d0b34796a0917b3f
Resolves: #60529
Relates: #60506
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31765
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 years ago[BUGFIX] Fix resource exceptions 57/31757/2
Helmut Hummel [Wed, 23 Jul 2014 18:50:56 +0000 (20:50 +0200)]
[BUGFIX] Fix resource exceptions

When rendering the FILES content object,
exceptions due to missing file references and missing collections
are meant to be caught. However they are not, because
InvalidArgumentException and RuntimeException are thrown instead of
ResourceDoesNotExistException

Throw the appropriate exceptions instead and also
fix a wrong check in RecordCollection Repository, where
the return type is checked against NULL while the DB
call returns FALSE when no record is found.

Resolves: #60506
Releases: 6.2, 6.3
Change-Id: I9cea492d814850f75549d280c2de0defc8b91548
Reviewed-on: http://review.typo3.org/31757
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Set correct cookie when permalogin is enabled 54/31754/2
Gernot Schulmeister [Mon, 14 Jul 2014 21:17:37 +0000 (23:17 +0200)]
[BUGFIX] Set correct cookie when permalogin is enabled

Although permalogin is enabled we set a session cookie.
This happens because setSessionCookie is called too early
and we do not know yet whether the session should be permanent
and an according cookie shall be set or not.

Solution is to set $this->dontSetCookie = FALSE
which triggers setting the cookie at an appropriate time.

Resolves: #60264
Releases: 6.3, 6.2
Change-Id: Iad5ce8597f90c4a607a43ea4d3368d117fa6b4ed
Reviewed-on: http://review.typo3.org/31754
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Change sys_file.size type from INT to BIGINT 52/31752/2
Stefan Neufeind [Wed, 23 Jul 2014 11:05:37 +0000 (13:05 +0200)]
[BUGFIX] Change sys_file.size type from INT to BIGINT

Regular INT limits filesize to 2GB.

Change-Id: I525bd53bff6495630bd5880c8ef8789a1d9bbf26
Resolves: #60327
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/31752
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Complete datatable structure fe_groups 47/31747/2
Markus Guenther [Thu, 10 Jul 2014 15:24:34 +0000 (17:24 +0200)]
[BUGFIX] Complete datatable structure fe_groups

While creating frontend groups via extbase without any subgroup set,
the record will have the value NULL in the database
for the property subgroup.
This leads to an exception.

This patch only defines TSconfig, subgroups and description not
to accept NULL and to be consistent the tx_extbase_type gets
the default value 0.

Resolves: #60245
Releases: 6.3, 6.2
Change-Id: Ie402d4c47058755efe40cc762f4220ba7dc6b781
Reviewed-on: http://review.typo3.org/31747
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 years ago[BUGFIX] Catch all resource exceptions when parsing RTE links 45/31745/2
Helmut Hummel [Mon, 14 Jul 2014 16:00:30 +0000 (18:00 +0200)]
[BUGFIX] Catch all resource exceptions when parsing RTE links

The RteHtmlParser checks for valid links by trying to retrieve
a file or folder object. The FAL API will throw exceptions
if anything goes wrong with the given path.

Catch all these exceptions to ignore the invalid link
and act the same for invalid paths as for not found files/ folders

Releases: 6.2, 6.3
Resolves: #60316
Change-Id: I0752678eb8ed2b596c3a88536d957ec35c172d7b
Reviewed-on: http://review.typo3.org/31745
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Wrong sys_refindex for deleted child records 38/31738/2
Oliver Hader [Thu, 10 Jul 2014 16:53:03 +0000 (18:53 +0200)]
[BUGFIX] Wrong sys_refindex for deleted child records

Workspace actions using the DataHandler trigger a reprocessing
of the reference index. However, it happened that index entries
of the live workspace have been deleted or modified.

The reason for that is a missing SQL statement to limit those
actions to the current workspace only.

The result can be seen in e.g. the workspace module after
having deleted an IRRE child record and how the nesting could
not be determined correctly for that particular record.

Resolves: #59874
Releases: 6.2, 6.3
Change-Id: I850e2fe88999ce8db280d4ef426e43c85fff06da
Reviewed-on: https://review.typo3.org/31738
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 years ago[TASK] Update wrong copyright header in file BrowseLinks.php 33/31733/2
Michael Schams [Wed, 23 Jul 2014 01:54:56 +0000 (11:54 +1000)]
[TASK] Update wrong copyright header in file BrowseLinks.php

A new header in PHP files has been introduced with #59535. This
patch updates the copyright/license header of one file, which still
uses the old, outdated information.

Resolves: #60482
Releases: 6.3, 6.2
Change-Id: I642a4ce13331e2aadbd362988b963a8a5c576a29
Reviewed-on: https://review.typo3.org/31733
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
5 years ago[BUGFIX] Fix return value of DatabaseConnection::sql_free_result() 19/31719/2
Stefano Kowalke [Tue, 22 Jul 2014 10:57:50 +0000 (12:57 +0200)]
[BUGFIX] Fix return value of DatabaseConnection::sql_free_result()

In case of success the current implementation returns the result
of $res->free(). Unfortunately free() doesn't return anything.
That causes sql_free_result() to return NULL, which eventually
evaluates to FALSE.

Make sure the return value is correct and
return TRUE in case of success.

Resolves: #60457
Releases: 6.2, 6.3
Change-Id: I8756d4d2a321adc88738b9ac418207c63b312c86
Reviewed-on: https://review.typo3.org/31719
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 years ago[BUGFIX] Fix minor issues in functional testing framework 04/31704/2
Helmut Hummel [Sun, 20 Jul 2014 15:03:22 +0000 (17:03 +0200)]
[BUGFIX] Fix minor issues in functional testing framework

The bootstrap for frontend functional tests has some
minor issues, that are now fixed:

* json_decode returns null not false when not successfull
* Properly set the SERVER_PORT
* Use correct array key in error message
* Avoid notices with relative URLs

Releases: 6.2, 6.3
Resolves: #60413
Change-Id: I3ff07f01729d3403374759edbaa5ddcccd2e889a
Reviewed-on: https://review.typo3.org/31704
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] sys_collection_entries column too small 98/31698/2
Wouter Wolters [Thu, 10 Jul 2014 18:37:44 +0000 (20:37 +0200)]
[BUGFIX] sys_collection_entries column too small

Set sys_collection_entries to varchar(64). This is the max
table name length on MySQL.

Resolves: #60180
Releases: 6.3,6.2
Change-Id: I253e6eb6cb35db9e6d13a716bfc5c8d89db4ca7e
Reviewed-on: https://review.typo3.org/31698
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Send test email in Install Tool as HTML 84/31684/2
Wouter Wolters [Thu, 10 Jul 2014 19:27:20 +0000 (21:27 +0200)]
[BUGFIX] Send test email in Install Tool as HTML

Explicitly set the format of the email body to text/html.

Resolves: #60251
Releases: 6.3, 6.2
Change-Id: I350b0f4cb9e69cd20dbd439647f56cd9c641b501
Reviewed-on: https://review.typo3.org/31684
Reviewed-by: Pascal Dürsteler <pascal.duersteler@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[BUGFIX] Avoid PHP warning in TypoScriptFrontendController 85/31685/2
Markus Klein [Mon, 7 Jul 2014 21:05:36 +0000 (23:05 +0200)]
[BUGFIX] Avoid PHP warning in TypoScriptFrontendController

TypoScriptFrontendController throws a PHP warning on access to
$BE_USER->user['uid'] which might not be set.
Fix this by simply adding an empty() check.

Resolves: #60126
Releases: 6.3, 6.2
Change-Id: I7005baf73bce55d862b4b6b61697c2aa0a877c7b
Reviewed-on: https://review.typo3.org/31685
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[CLEANUP] Final cleanup of TCA Overrides 24/31624/2
Helmut Hummel [Mon, 14 Jul 2014 22:49:33 +0000 (00:49 +0200)]
[CLEANUP] Final cleanup of TCA Overrides

Some of the files still miss the die statement in
the first line. To be consistent, add it to every
file.

One file had a check for TYPO3_MODE === BE which
is wrong in these files because the result is
cached.

If the first hit with empty cache is done in a FE
request, a wrong result would be cached.

Releases: 6.2, 6.3
Resolves: #60317
Change-Id: I839499100da28ba11d5dcbf81fde87b30b61de81
Reviewed-on: https://review.typo3.org/31624
Reviewed-by: Markus Klein <klein.t3@mfc-linz.at>
Tested-by: Markus Klein <klein.t3@mfc-linz.at>
5 years ago[TASK] Fix composer branch alias for 6.2 branch 05/31605/2
Helmut Hummel [Sat, 12 Jul 2014 21:38:51 +0000 (23:38 +0200)]
[TASK] Fix composer branch alias for 6.2 branch

The composer.json file wrongly configures the
master branch to be aliased to 6.2.x-dev

Fix it by aliasing our TYPO3_6-2 branch to 6.2.x-dev

Releases: 6.2
Change-Id: I89d91aa011cc384e0868913bbbe3add50585866e
Reviewed-on: https://review.typo3.org/31605
Reviewed-by: Christian Opitz <christian.opitz@netresearch.de>
Tested-by: Christian Opitz <christian.opitz@netresearch.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
5 years ago[BUGFIX] Use PATH_site in cache identifier for package cache 80/31580/2
Helmut Hummel [Thu, 10 Jul 2014 16:10:10 +0000 (18:10 +0200)]
[BUGFIX] Use PATH_site in cache identifier for package cache

The package cache writes paths to extension directories
(TYPO3_LOADED_EXT) into the cache.

This will result in wrong caches when the same
TYPO3 instance is called from a different absolute
directory e.g. from a different mount or symlink.

To avoid this, the cache identifier now includes
PATH_site which is the current absolute path
of the TYPO3 instance.

Additionally we now only include the modification
time of the package states file instead of the
md5 of the complete content into account, which should
be much faster and also enough.

Resolves: #58288
Releases: 6.2, 6.3
Change-Id: I7c8de41c608beab282f2b8bbeab39f257a9a6a6f
Reviewed-on: https://review.typo3.org/31580
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 years ago[TASK] Extend Regular DataHandler functional tests 88/31588/2
Oliver Hader [Wed, 25 Jun 2014 13:02:24 +0000 (15:02 +0200)]
[TASK] Extend Regular DataHandler functional tests

* add third tt_content element with localization in live context
* add new tt_content delete placeholder in different workspace
* populate changes to all scenarios in live and workspace context

Releases: 6.2, 6.3
Resolves: #59881
Change-Id: I644e264048a5c33c0a613d5f8440975cabd40721
Reviewed-on: https://review.typo3.org/31588
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Clarify exception message for addPlugin() 62/31562/2
Helmut Hummel [Thu, 10 Jul 2014 13:52:52 +0000 (15:52 +0200)]
[TASK] Clarify exception message for addPlugin()

Add verbosity to the exception message to make it
more clear what is going wrong.

Releases: 6.2, 6.3
Resolves: #60225
Change-Id: I7bb4a16ff94d05b8b97633383d42c61aa600b1cf
Reviewed-on: https://review.typo3.org/31562
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix page module styling in Languages view 35/31535/2
Tomita Militaru [Tue, 8 Jul 2014 09:44:18 +0000 (12:44 +0300)]
[BUGFIX] Fix page module styling in Languages view

Change in height of table header row for Languages view.

Resolves: #56714
Releases: 6.3, 6.2
Change-Id: Ic6bab8a99695798ecfc115209aec41e241870925
Reviewed-on: https://review.typo3.org/31535
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Collapse icon for accordion not centered in Install Tool 26/31526/2
Wouter Wolters [Tue, 8 Jul 2014 21:24:04 +0000 (23:24 +0200)]
[BUGFIX] Collapse icon for accordion not centered in Install Tool

Resolves: #60192
Releases: 6.3,6.2
Change-Id: I4bacce041ca3be3dce4cae1a7407ab3fdf301ff0
Reviewed-on: https://review.typo3.org/31526
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Log errors after initial t3d import also if pages are created 23/31523/2
Marc Bastian Heinrichs [Wed, 14 May 2014 10:33:07 +0000 (12:33 +0200)]
[TASK] Log errors after initial t3d import also if pages are created

Errors are only logged if no pages are created on initial data.t3d
import. They should be logged generally.

Resolves: #58798
Releases: 6.3, 6.2
Change-Id: Ia859d12ec567a1b64bb9b65dd41f5ba996de3139
Reviewed-on: https://review.typo3.org/31523
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Followup to CacheBackend patch 21/31521/2
Markus Klein [Tue, 8 Jul 2014 21:00:10 +0000 (23:00 +0200)]
[BUGFIX] Followup to CacheBackend patch

Re-add a missing use statement that vanished during rebase.

Resolves: #59587
Releases: 6.3, 6.2, 6.1
Change-Id: I16ac1b9d5a00c4300202eaef493de43fc988a81d
Reviewed-on: https://review.typo3.org/31521
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Too many tags by identifier in CacheBackends 18/31518/3
Alexander Opitz [Tue, 17 Jun 2014 07:58:32 +0000 (09:58 +0200)]
[BUGFIX] Too many tags by identifier in CacheBackends

This applies to Apc/Memcached/Wincache/Xcache backends.

After an array_merge the values aren't unique. This leads to duplicate
tags per identifier. This patch changes that and also moves the
findTagsByIdentifier call out of the foreach loop.

Resolves: #59587
Releases: 6.3, 6.2, 6.1
Change-Id: Id31e16fa4bba11038ba692a483fb9a33808d95fa
Reviewed-on: https://review.typo3.org/31518
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Set TYPO3 version to 6.2.5-dev 13/31513/2
TYPO3 Release Team [Tue, 8 Jul 2014 13:05:27 +0000 (15:05 +0200)]
[TASK] Set TYPO3 version to 6.2.5-dev

Change-Id: Ic7579af60139fe36862ddeb124c3fe8711750acc
Reviewed-on: https://review.typo3.org/31513
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.4 12/31512/2 6.2.4 TYPO3_6-2-4
TYPO3 Release Team [Tue, 8 Jul 2014 13:04:53 +0000 (15:04 +0200)]
[RELEASE] Release of TYPO3 6.2.4

Change-Id: I2f41d693c2f9b7c0e919e5c1566d3a3fba99178d
Reviewed-on: https://review.typo3.org/31512
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Fix wrong type hint for emitAfterExtensionT3DImportSignal() 07/31507/2
Markus Klein [Tue, 8 Jul 2014 10:55:07 +0000 (12:55 +0200)]
[BUGFIX] Fix wrong type hint for emitAfterExtensionT3DImportSignal()

Fix a wrong type hint for the second parameter in
InstallUtility::emitAfterExtensionT3DImportSignal(). The parameter is of
type integer and not array.

Resolves: #60179
Releases: 6.3, 6.2
Change-Id: Iccfb7445bd374edaecfd3408380034dbec82e539
Reviewed-on: https://review.typo3.org/31507
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Superfluous SQL queries on copying records 02/31502/2
Oliver Hader [Thu, 3 Jul 2014 11:12:20 +0000 (13:12 +0200)]
[BUGFIX] Superfluous SQL queries on copying records

On copying a page in the backend there are lots of superfluous
SQL queries containing "... WHERE uid=0". The reason for that
is, that DataHandler::recordInfo() is called for each field
which then tries to fetch the database record for the given
uid "NEW...". Casting the new record placeholder to an integer
value ends up with the "uid=0" condition.

In a test with copying a page with some sub-pages, there was a
total of about 1300 SQL queries, 300 of them have been those
superfluous "uid=0" SELECT statements.

Resolves: #58357
Releases: 6.2, 6.3
Change-Id: Ib7006a7ceb52376032df8eaefaa918407718a482
Reviewed-on: https://review.typo3.org/31502
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Followup to read only filemounts 01/31501/2
Helmut Hummel [Tue, 8 Jul 2014 09:57:28 +0000 (11:57 +0200)]
[BUGFIX] Followup to read only filemounts

Fix tests by provide proper mocking of the storage

Resolves: #49391
Resolves: #57979
Releases: 6.2, 6.3
Change-Id: I2cd9e1bcffd082e861a7c8ae2fba6c68b461a8cc
Reviewed-on: https://review.typo3.org/31501
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Re-introduce read-only file mounts 96/31496/2
Lorenz Ulrich [Mon, 23 Jun 2014 13:41:17 +0000 (15:41 +0200)]
[BUGFIX] Re-introduce read-only file mounts

This re-introduces the read-only file mounts that were silently dropped
in TYPO3 6.0.

File mounts can be added by User TSconfig the same way they were added
in TYPO3 4.x. But since FAL added Storages, the storage needs to be
configurable.

options.folderTree.altElementBrowserMountPoints = 3:/test

This adds the folder "test" of storage 3 as read-only mount in the File
List and the Element Browser. The old syntax is still supported:

options.folderTree.altElementBrowserMountPoints = documents

If no storage is configured, it is assumed that the folder is in the
default storage.

Resolves: #49391
Resolves: #57979
Documentation: #59648
Releases: 6.3, 6.2
Change-Id: I648c8ae15d4add98cd55e2f9c27d89d8e49d6152
Reviewed-on: https://review.typo3.org/31496
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Movements pollute colPos value of content elements 92/31492/2
Nicole Cordes [Tue, 8 Jul 2014 07:53:33 +0000 (09:53 +0200)]
[BUGFIX] Movements pollute colPos value of content elements

Due to commit I148ca1b023226f2f99417b3baf238b72346e721f the information
concerning previous and next content elements in one row is messed up.
This patch helps to build information which depends on colPos again and
prevents records being moved to another column.

Resolves: #48939
Resolves: #49055
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I3a15321ee11a1f7d96b58b8b7a5ab14098664b22
Reviewed-on: https://review.typo3.org/31492
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Update phpdoc @return of exec_SELECTgetSingleRow() 90/31490/2
Markus Klein [Tue, 8 Jul 2014 08:12:21 +0000 (10:12 +0200)]
[TASK] Update phpdoc @return of exec_SELECTgetSingleRow()

DatabaseConnection::exec_SELECTgetSingleRow() may return FALSE if no row
is found. This is not reflected in the phpdoc for the return value.

This patch adds the necessary information to the doc header.

Resolves: #60172
Releases: 6.3, 6.2
Change-Id: Ia07868c2a1e8fad5b1d53d89ff0a959c2bcf9e3a
Reviewed-on: https://review.typo3.org/31490
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1 80/31480/2
Alexander Bigga [Fri, 27 Jun 2014 12:57:39 +0000 (14:57 +0200)]
[BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1

Using the TCA select renderMode=tree with the option
minitems=1 AND maxitems=1
leads to two bugs since TYPO3 4.5:

First #48943
* A new table entry won't mark the field selection as required. The yellow
  question mark is missing and you can save the entry.
* Once you select a checkbox in the tree and unselect it again, the
  required-check is working.

Second: #31637
* You load an existing table entry with a selection of e.g. a category
  which has been hidden or deleted. The selected checkbox won't be shown,
  but the required-check fails.
* Even worse: You can't select another category as the form thinks you
  have already selected one item (maxitem=1). You can fix this only by
  manipulating the database directly.

The reason for these bugs can be found in
DataPreprocessor::renderRecord_selectProc(). For maxitems = 1 the
foreign_table element ids for the tree will be fetched by getDataIdList().
These elements won't be checked whether they are valid (hidden/deleted).
This check is done in selectAddForeign() which is used for maxitems > 1.

The patch uses the same procedure as for maxitems > 1 in case
of renderMode = tree.

Resolves: #48943
Resolves: #31637
Releases: 6.3, 6.2, 6.1
Change-Id: I078ff524ea73951f2121d2c233a46bc2ae562952
Reviewed-on: https://review.typo3.org/31480
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix suggest wizard item selection 79/31479/2
Benoit Chenu [Mon, 2 Jun 2014 11:44:36 +0000 (13:44 +0200)]
[BUGFIX] Fix suggest wizard item selection

When selecting an item in a suggest list, the first label is always
taken instead of the clicked one.

Resolves: #55835
Releases: 6.3, 6.2
Change-Id: I7590cb290ee19fd807260ef5767805a23ef088b0
Reviewed-on: https://review.typo3.org/31479
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] LiveSearchToolbarItem not initialized correctly 77/31477/2
Gernot Schulmeister [Mon, 7 Jul 2014 21:33:42 +0000 (23:33 +0200)]
[BUGFIX] LiveSearchToolbarItem not initialized correctly

Initialising the LiveSearchToolbarItem class with two leading
backslashes \\ prevents XClasses of the LiveSearchToolbarItem
to be found by the GeneralUtility:makeInstance() function.

Resolves: #59959
Releases: 6.3, 6.2
Change-Id: Iab6bb31379090fa5770ed20f8fa8113e61071fe0
Reviewed-on: https://review.typo3.org/31477
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix position of buttons in RTE full screen mode 76/31476/2
Markus Klein [Mon, 7 Jul 2014 21:20:49 +0000 (23:20 +0200)]
[BUGFIX] Fix position of buttons in RTE full screen mode

Update the HTML markup for the action buttons in the RTE full screen
view to properly position the buttons there.

Releases: 6.3, 6.2
Resolves: #60119
Change-Id: I0c06dd5fa5a7975a3ddcddb58c3b44d41da2192a
Reviewed-on: https://review.typo3.org/31476
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Refactor extension upload controller 67/31467/2
Nicole Cordes [Fri, 4 Jul 2014 22:17:32 +0000 (00:17 +0200)]
[TASK] Refactor extension upload controller

The upload and install functions are needed by the extension coreapi.
In order to support the extension, the UploadExtensionFileController
is refactored and necessary functions are extracted to public functions.

Resolves: #59999
Releases: 6.2, 6.3
Change-Id: I21e734d1ecae2e7c8e7c3f72e129ef1f57532886
Reviewed-on: https://review.typo3.org/31467
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere 65/31465/2
Julian Hofmann [Wed, 8 Jan 2014 17:22:33 +0000 (18:22 +0100)]
[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere

Using PAGE_TSCONFIG_*-values in the foreign_table_where-clause limits
the entries. This where clause is also used for the suggest wizard, but
the markers are not replaced there.
PAGE_TSCONFIG_*-values are now supported in the suggest wizard too.

Resolves: #54843
Releases: 6.3, 6.2
Documentation: #60160
Change-Id: Ieb53d48ca0ddf22bbbbc4aed4d1e83220a82ec09
Reviewed-on: https://review.typo3.org/31465
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Move signals to own emit functions 52/31452/2
Nicole Cordes [Mon, 7 Jul 2014 07:49:33 +0000 (09:49 +0200)]
[TASK] Move signals to own emit functions

Two new signals were introduced with the patch
https://review.typo3.org/#/c/27746/. This patch moves the dispatch of
the signals into own functions to improve the tracing of signals.

Resolves: #60133
Releases: 6.3, 6.2
Change-Id: Iecb7ff25ec31556c939dff6b0cf8749ebd3ff997
Reviewed-on: https://review.typo3.org/31452
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Report migration errors in TceformsUpdateWizard 28/31428/2
Steffen Müller [Wed, 2 Apr 2014 20:38:31 +0000 (22:38 +0200)]
[BUGFIX] Report migration errors in TceformsUpdateWizard

TceformsUpdateWizard should report errors if a migration
failed due to a missing source file.

Resolves: #57575
Releases: 6.3, 6.2
Change-Id: I68af9a5155f7d6190a22cc4986ef4a467b747737
Reviewed-on: https://review.typo3.org/31428
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Detect missing files in empty storage 27/31427/2
Robert Vock [Tue, 3 Jun 2014 11:56:15 +0000 (13:56 +0200)]
[BUGFIX] Detect missing files in empty storage

Improve the check for missing files by properly treating
the case when a storage is empty.

Change-Id: I8fba9be2622a4cd742c0065b68a8daf77f8a484a
Resolves: #54414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31427
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] Wrong image reference handling during flexform copying 25/31425/2
Alexey Gafiulov [Thu, 19 Jun 2014 16:12:42 +0000 (22:12 +0600)]
[BUGFIX] Wrong image reference handling during flexform copying

References in flexforms having type=inline are not processed correctly
during copy.

Fix this by properly applying the reference field check.

Resolves: #59664
Releases: 6.3, 6.2, 6.1
Change-Id: I1abfa001ba420531ca0c59903e82b1509e0819e0
Reviewed-on: https://review.typo3.org/31425
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[FEATURE] Add signal slots to SoftReferenceIndex 23/31423/2
Alexander Stehlik [Mon, 10 Mar 2014 09:42:59 +0000 (10:42 +0100)]
[FEATURE] Add signal slots to SoftReferenceIndex

This patch adds two signal slot dispatch calls to the SoftReferenceIndex
in the getTypoLinkParts() method and the setTypoLinkPartsElement()
methods.

These slots allow third party link handlers to generate their own
soft reference data.

Resolves: #21396
Releases: 6.3, 6.2
Change-Id: If2bbcd1757ed480f31c1bdccd69bba2a77df9a8f
Reviewed-on: https://review.typo3.org/31423
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Optimize invocation of cObj::checkIf 18/31418/2
Oliver Hader [Mon, 20 Jan 2014 15:52:37 +0000 (16:52 +0100)]
[TASK] Optimize invocation of cObj::checkIf

The stdWrap property "if" can be used to allow output only if a
defined criterion is met. However, the checkIf() method gets
called even if the property is not set in TypoScript.

Fix this by adding a quick empty() check to all calls.
Also optimizes the code structure to exit early in case the if
does not evaluate to TRUE.

Resolves: #55173
Releases: 6.3, 6.2
Change-Id: Ie1178a5df2e98fd19b848aa2300c901c1200f555
Reviewed-on: https://review.typo3.org/31418
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suggest wizard doesn't work in page flexforms 21/31421/2
Bernhard Kraft [Wed, 18 Jun 2014 08:04:28 +0000 (10:04 +0200)]
[BUGFIX] Suggest wizard doesn't work in page flexforms

When using the suggest wizard from within a flexform in a page it
doesn't work properly. The $row variable was only set when processing
tables other than pages but is required for proper flexform handling.

Change-Id: I0eec29b3c7266bae809e2753cdee726a4c50b1ab
Resolves: #59642
Releases: 6.3, 6.2, 6.1
Reviewed-on: https://review.typo3.org/31421
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove non-needed URL parameter for standard search 19/31419/2
Tomita Militaru [Tue, 12 Nov 2013 14:57:56 +0000 (16:57 +0200)]
[BUGFIX] Remove non-needed URL parameter for standard search

Removes parameter to prevent duplicate content, speaking
url problems and overloaded urls.

Resolves: #51189
Releases: 6.3, 6.2, 6.1
Change-Id: I076d2f87ac7a1d0d9d831cf3293d060318750c7d
Reviewed-on: https://review.typo3.org/31419
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Support dots in page.meta 06/31406/2
Markus Klein [Sat, 28 Jun 2014 14:56:36 +0000 (16:56 +0200)]
[BUGFIX] Support dots in page.meta

The parsing of the meta tag TypoScript configuration does a too greedy
check on dots and hence breaks support for examples like DC.author.

Fix this by completely refactoring the meta tag generation and add unit
tests.

Resolves: #59890
Releases: 6.3, 6.2
Change-Id: Id534efff30903d96aee1677989d1bd6d3dd1644b
Reviewed-on: https://review.typo3.org/31406
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[CLEANUP] Ensure all variables are set before usage 80/31380/3
Markus Klein [Sun, 22 Jun 2014 00:46:21 +0000 (02:46 +0200)]
[CLEANUP] Ensure all variables are set before usage

This also applies for return values of functions. These are corrected
too if necessary.

Furthermore, some code style updates are done for better readability.

This patch contains no functional changes.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: I1e26e0516d79324244948caf091cd836d5f8d3c6
Reviewed-on: https://review.typo3.org/31380
Reviewed-by: Fabien Udriot
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Travis-ci: Disable apc in PHP 5.3 04/31404/2
Christian Kuhn [Sun, 6 Jul 2014 16:23:19 +0000 (18:23 +0200)]
[TASK] Travis-ci: Disable apc in PHP 5.3

apc on cli seems to be flaky, disable this php module for
now to see if that help stabilizing travis-ci builds again.

Change-Id: I7e6caa6c2c2d70a26e217e8fbf10a2d79b01f335
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31404
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn