Packages/TYPO3.CMS.git
6 years ago[TASK] Raise submodule pointer 12/18112/2
Christian Kuhn [Fri, 8 Feb 2013 11:36:24 +0000 (12:36 +0100)]
[TASK] Raise submodule pointer

Change-Id: I74915a4d522ef86b9575eae7b37401821acaf748
Reviewed-on: https://review.typo3.org/18112
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] No title tags for new enable/disable icons 04/18104/2
Thomas Löffler [Thu, 7 Feb 2013 22:50:15 +0000 (23:50 +0100)]
[BUGFIX] No title tags for new enable/disable icons

Follow-up bug after merged feature #25631

Releases: 6.1
Resolves: #45262
Change-Id: I4f7402bc54f71bd1a90586d46e3e6782319efb7e
Reviewed-on: https://review.typo3.org/18104
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Follow-up clean up to #24389 00/18100/2
Wouter Wolters [Thu, 7 Feb 2013 21:34:05 +0000 (22:34 +0100)]
[BUGFIX] Follow-up clean up to #24389

Change-Id: I2b5438edd23650fd63b1771c9d6a825ae1aaa210
Related: #24389
Releases: 6.1
Reviewed-on: https://review.typo3.org/18100
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX][Cache][PDO] Duplicate cache entry possible 44/9144/6
Leon Dietsch [Tue, 27 Nov 2012 01:12:52 +0000 (02:12 +0100)]
[BUGFIX][Cache][PDO] Duplicate cache entry possible

An identifier must be unique in the database. If some entry is set(),
the PdoBackend removes any entry with a given identifier if the cache
entry exists already. The remove() call is encapsulated with has(),
but has() returns FALSE if a cache entry is expired, so entries with
expired lifetime are not removed properly.
This leads to a \PDOException because of duplicate identifier.

The patch removes the check to has(), so set() will also remove
expired cache entries with this identifier before creating a new one.

Change-Id: Ife4e35223394805fc6d9e0b820a5d42789133f7b
Fixes: #34129
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/9144
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Enable multiple emails in reports task 19/18019/7
Thomas Löffler [Tue, 5 Feb 2013 00:05:38 +0000 (01:05 +0100)]
[FEATURE] Enable multiple emails in reports task

Possibility to insert multiple emails in
reports task to notify multiple people.

Resolves: #41002
Releases: 6.1
Change-Id: I931cd5af64d21bffb34bd024c1f362f06dcaf37c
Reviewed-on: https://review.typo3.org/18019
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tomita Militaru
Tested-by: Tomita Militaru
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX][Cache] Method parameter CGL fixes 92/18092/2
Christian Kuhn [Thu, 7 Feb 2013 20:13:15 +0000 (21:13 +0100)]
[BUGFIX][Cache] Method parameter CGL fixes

Change-Id: Ie237c62fcd25d0f4ac2430983183756c7aebc633
Resolves: #45257
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18092
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Speed up typoLink function by caching domain records 23/9023/14
Steffen Gebert [Tue, 14 Feb 2012 18:56:02 +0000 (19:56 +0100)]
[FEATURE] Speed up typoLink function by caching domain records

Cache the domain records in a runtime cache for improved rendering
of links generated with typolink function.

This change takes only effect, when
  config.typolinkCheckRootline = 1
is set, which otherwise costs immense performance in terms of huge
number of SQL queries.

Resolves: #24389
Releases: 6.1
Change-Id: I7c6bee1cd6ee1cb0901d926dd6ce9a22c00501ab
Reviewed-on: https://review.typo3.org/9023
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
6 years agoRevert "[BUGFIX] TS is fetched from cache incorrectly sometimes" 70/18070/2
Oliver Hader [Wed, 6 Feb 2013 18:37:44 +0000 (19:37 +0100)]
Revert "[BUGFIX] TS is fetched from cache incorrectly sometimes"

This reverts commit 4fbb2b5852a98b1eb3e935d79d612468896291f1

Change-Id: I2f936cabac3392f0c7eeb85cda9caad68b59553d
Reviewed-on: https://review.typo3.org/18070
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] TS is fetched from cache incorrectly sometimes 39/16939/3
Dmitry Dulepov [Mon, 3 Dec 2012 09:40:25 +0000 (13:40 +0400)]
[BUGFIX] TS is fetched from cache incorrectly sometimes

If $TYPO3_CONF_VARS['FE']['defaultTypoScript_constants'] or
$TYPO3_CONF_VARS['FE']['defaultTypoScript_setup'] are set in the Install
tool, cached TS will not be found in cache. This would result in TS
parsing every time when there are USER_INT objects on the page.
Generally it will slow down the page with USER_INT objects by at least
300% comparing to the cached version.

Change-Id: Ia0fd65a35897c71d60c48c0b03098ce67ad16c70
Resolves: #43540
Releases: 4.5, 4.6, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/16939
Reviewed-by: Adrian Dymorz
Tested-by: Adrian Dymorz
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Sebastian Michaelsen
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
6 years ago[BUGFIX] Crash after file upload on Windows without finfo 66/17466/4
Christian Weiske [Fri, 11 Jan 2013 15:52:54 +0000 (16:52 +0100)]
[BUGFIX] Crash after file upload on Windows without finfo

This patch checks if the finfo extension is available before using it
to determine the MIME type of a file.
If it is not available, the old function mime_content_type is used as
fallback.
When none of them are available, we give up.

This fixes a crash on Windows after uploading a file, since finfo
is by default not installed on PHP windows distributions.

Change-Id: I53a0eef3ee839c17ddaaeb303b9a0b9bae3ee485
Fixes: #37440
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17466
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Wrong SQL statements in TCA for sys_category 40/18040/3
Thomas Löffler [Tue, 5 Feb 2013 21:46:01 +0000 (22:46 +0100)]
[BUGFIX] Wrong SQL statements in TCA for sys_category

Copy and Paste problem. Table name
'tx_taxonomy_domain_model_concept' instead of
'sys_category'

Resolves: #44911
Releases: 6.0, 6.1
Change-Id: I92130a8dc5416b822edc71be148e35f193b5ea3b
Reviewed-on: https://review.typo3.org/18040
Reviewed-by: Wouter Wolters
Reviewed-by: Thomas Loeffler
Tested-by: Thomas Loeffler
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Move t3lib/stddb/DefaultConfiguration.php to EXT:core 42/18042/2
Christian Kuhn [Tue, 5 Feb 2013 21:57:47 +0000 (22:57 +0100)]
[TASK] Move t3lib/stddb/DefaultConfiguration.php to EXT:core

Moves t3lib/stddb/DefaultConfiguration.php to
EXT:core/Configuration/DefaultConfiguration.php

Change-Id: I8a4e00247e1ab27c566f8868744aa87ca615ad38
Resolves: #45188
Releases: 6.1
Reviewed-on: https://review.typo3.org/18042
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 39/18039/2
Christian Kuhn [Tue, 5 Feb 2013 21:42:41 +0000 (22:42 +0100)]
[TASK] Raise submodule pointer

Change-Id: I4db842e5e8b295395cec13a9feae35e51ab2d61d
Reviewed-on: https://review.typo3.org/18039
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Move t3lib/stddb/tables.sql to ext:core/ext_tables.sql 37/18037/2
Christian Kuhn [Tue, 5 Feb 2013 20:46:08 +0000 (21:46 +0100)]
[TASK] Move t3lib/stddb/tables.sql to ext:core/ext_tables.sql

After ext:core was put in place with 6.0, files like
stddbb/tables.sql can be located at this places.

Change-Id: I8a859b5c0b1d29b94a40d75f24e96873d4b63010
Resolves: #45187
Releases: 6.1
Reviewed-on: https://review.typo3.org/18037
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Add a disable/enable button to tasks overview 18/18018/4
Thomas Löffler [Mon, 4 Feb 2013 23:09:59 +0000 (00:09 +0100)]
[FEATURE] Add a disable/enable button to tasks overview

Adds an option in the task list to enable or disable
a scheduler task.

Releases: 6.1
Resolves: #25631
Change-Id: I6bd38be3207c9ccc59baf653a2da16bdf824ceab
Reviewed-on: https://review.typo3.org/18018
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Thomas Loeffler
Tested-by: Thomas Loeffler
Reviewed-by: Stefan Neufeind
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
6 years ago[TASK] ext:cms Remove some obsolete files 33/18033/2
Christian Kuhn [Tue, 5 Feb 2013 19:46:09 +0000 (20:46 +0100)]
[TASK] ext:cms Remove some obsolete files

* readme.txt: Old information, nobody overloads cms anyway
* tslib/GPL.txt: GPL.txt from root directory catches this
* tslib/README.txt: Only obsolete information
* tslib/index.html: Leftover when tslib was linked from root

Change-Id: Ibfb2ac039b7d48621d2a6e2050b42a127c3c4662
Resolves: #45185
Releases: 6.1
Reviewed-on: https://review.typo3.org/18033
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 32/18032/2
Christian Kuhn [Tue, 5 Feb 2013 19:08:59 +0000 (20:08 +0100)]
[TASK] Raise submodule pointer

Change-Id: If896fcf2e047fa8195fde284e85fe668474eea48
Reviewed-on: https://review.typo3.org/18032
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[!!!][TASK] Get rid of loadTCA and simplify FE cache behavior 78/17978/5
Christian Kuhn [Sun, 3 Feb 2013 11:13:25 +0000 (12:13 +0100)]
[!!!][TASK] Get rid of loadTCA and simplify FE cache behavior

The frontend rendering aims to not load the full TCA including
columns settings to reduce rendering time for full cache pages.

This approach is ridiculous complex and using it is so hard to get
right for developers that even core patches in this area are
usually broken. The current situation is neither simple
nor transparent.

Currently, if no page cache entry exists during rendering, the whole
ext_tables.php are executed, the page is rendered and stuffed to
cache. While the full TCA is available at this point, it is reduced
to the 'ctrl' sections for the next run, without 'columns', and
stuffed to cache. On next access, the cache entry is used,
ext_tables.php and TCA is not fully loaded. This leads to all sort of
problems, if for example those pages contain USER_INT plugins that
rely on some TCA settings. Furthermore, it might happen, that
different plugins or the core then requires the ext_tables files more
than once, which leads to funny problems if some developer does not
know this and uses require_once instead of require inside
ext_tables.php. Issues like that are very hard to track down.

The current implementation relies on the methods TSFE->includeTCA(),
TSFE->getCompressedTCarray() and GeneralUtility->loadTCA(), where
especially includeTCA() with its parameter is so hard to understand
that it is impossible to use in a correct way without digging through
the content rendering for hours.

The patch obsoletes all three of the above methods. Instead, from now
on, the bootstrap in the frontend is configured to always load the
full TCA including columns sections, even in full cached context.
The only exception are eID scripts, but the existing API to load
additional TCA in the eID controller is modified to also load all.

On the downside, this patch costs around 30% of additional
performance for the rendering of full cached pages. As soon as there
is some USER_INT on a page, or if a page is not cached, the overhead
is around zero. So, this patch costs performance for 'simple' pages,
while it is of no effect for anything more complex.

The goal is to reduce developer headaches at this point and to
make the frontend rendering better predictable and more easy
to maintain. It is furthermore one step to implement a better
configuration handling in the long run.

Change-Id: I5aecd542abe92f2de4ee0d40b5db44c493d304a3
Resolves: #45107
Releases: 6.1
Reviewed-on: https://review.typo3.org/17978
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
6 years ago[BUGFIX] Additional extTables script might not exist 94/17994/3
Philipp Gampe [Sun, 3 Feb 2013 21:59:25 +0000 (22:59 +0100)]
[BUGFIX] Additional extTables script might not exist

During https://review.typo3.org/17381, the constant
TYPO3_extTableDef_script is now always defined.

Change the bootstrap to only include the file if it really
exists.

Related: #44331
Fixes: #45122
Releases: 6.0, 6.1
Change-Id: I547c5e141b2395eb8b684ce245bb0440096f14df
Reviewed-on: https://review.typo3.org/17994
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup feedit 85/17985/2
Wouter Wolters [Sun, 3 Feb 2013 18:53:04 +0000 (19:53 +0100)]
[TASK] Cleanup feedit

Change-Id: I8eca6524c69ee71973411b4b791ee7b33bdcda82
Resolves: #45116
Releases: 6.1
Reviewed-on: https://review.typo3.org/17985
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup css_styled_content 84/17984/2
Wouter Wolters [Sun, 3 Feb 2013 18:24:11 +0000 (19:24 +0100)]
[TASK] Cleanup css_styled_content

Change-Id: Id229452ab6eac65d028555c5b42300be25da7e1a
Resolves: #45115
Releases: 6.1
Reviewed-on: https://review.typo3.org/17984
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup felogin 95/17995/2
Wouter Wolters [Sun, 3 Feb 2013 22:51:45 +0000 (23:51 +0100)]
[TASK] Cleanup felogin

Change-Id: I9ceeb1e7c142a3daaf20886f94c8a1d3295df99a
Resolves: #45123
Releases: 6.1
Reviewed-on: https://review.typo3.org/17995
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 93/17993/2
Christian Kuhn [Sun, 3 Feb 2013 20:11:33 +0000 (21:11 +0100)]
[TASK] Raise submodule pointer

Change-Id: I64cbba613ce7e0ab85a365330d52446964627f0f
Reviewed-on: https://review.typo3.org/17993
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 88/17988/2
Christian Kuhn [Sun, 3 Feb 2013 19:39:21 +0000 (20:39 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ie321c95f78ca21a5f5e7c821a716376066f58087
Reviewed-on: https://review.typo3.org/17988
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Deprecate 'path' of extra click menu option registration 65/17965/5
Wouter Wolters [Sat, 2 Feb 2013 19:46:51 +0000 (20:46 +0100)]
[TASK] Deprecate 'path' of extra click menu option registration

Deprecate option 'path' aption of the extendCMclasses registration
array, the autoloader should take care of finding and loading those.

Change-Id: Ibb3edcf3e87a0384f566be8dcdfa016b3731f943
Resolves: #45098
Releases: 6.1
Reviewed-on: https://review.typo3.org/17965
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup extra_page_cm_options 52/17952/3
Wouter Wolters [Sat, 2 Feb 2013 15:24:02 +0000 (16:24 +0100)]
[TASK] Cleanup extra_page_cm_options

Cleanup the code in extra_page_cm_options

Change-Id: I324115dae3514cc7b6f4ea350d244d13a3f6d818
Resolves: #45096
Releases: 6.1
Reviewed-on: https://review.typo3.org/17952
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Misspelling in scheduler documentation 50/17950/3
Tomita Militaru [Sat, 2 Feb 2013 13:38:11 +0000 (15:38 +0200)]
[BUGFIX] Misspelling in scheduler documentation

Corrects certain words / phrases from the documentation manual.

Fixes: #33936
Releases: 6.1, 6.0
Change-Id: I89ad923280cd1df6d126884e88987abaa9d5f7df
Reviewed-on: https://review.typo3.org/17950
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup cshmanual 81/17981/2
Wouter Wolters [Sun, 3 Feb 2013 17:09:49 +0000 (18:09 +0100)]
[TASK] Cleanup cshmanual

Change-Id: I6dfa4b07731c1a72d8893a20db3b355731ec0167
Resolves: #45113
Releases: 6.1
Reviewed-on: https://review.typo3.org/17981
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] tools_dbint needs to be called via mod.php 80/17980/2
Philipp Gampe [Sun, 3 Feb 2013 16:34:39 +0000 (17:34 +0100)]
[BUGFIX] tools_dbint needs to be called via mod.php

Fixes: #45112
Releases: 6.0, 6.1
Change-Id: I69b22d8d5fcb94e9b3cefcce600fd6b154de6c9d
Reviewed-on: https://review.typo3.org/17980
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup context_help 79/17979/2
Wouter Wolters [Sun, 3 Feb 2013 16:36:47 +0000 (17:36 +0100)]
[TASK] Cleanup context_help

Change-Id: I2ce8ebffab55d0f590f832e307a614f7a2581226
Resolves: #45111
Releases: 6.1
Reviewed-on: https://review.typo3.org/17979
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup sys_action 53/17953/5
Wouter Wolters [Sat, 2 Feb 2013 16:22:18 +0000 (17:22 +0100)]
[TASK] Cleanup sys_action

Change-Id: I873239c054069de8b9231f8efa8df9f292fed559
Resolves: #45097
Releases: 6.1
Reviewed-on: https://review.typo3.org/17953
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] IE9 compatibility clear cache menu 66/17966/3
Andreas Kiessling [Sun, 3 Feb 2013 09:54:02 +0000 (10:54 +0100)]
[BUGFIX] IE9 compatibility clear cache menu

The prototype library shipped with TYPO3 is not compatible with IE9
anymore. Since prototype will be replaced in the near future the easiest
solution is to use plain JavaScript.

Change-Id: I1dc732a61531fa585ed8e0ba6ce8df1b23f3b8bd
Resolves: #36364
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17966
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] OpenId needs library after removing classFile 54/17954/4
Jigal van Hemert [Sat, 2 Feb 2013 16:50:17 +0000 (17:50 +0100)]
[BUGFIX] OpenId needs library after removing classFile

After removing the classFile setting for services the OpenID
authentication service needs to have its library loaded
explicitly. Unlike the rest of the core this external
library doesn't use namespaces and can't rely on the autoloader.
Furthermore, the library might not have a unique name if
for example a second extensions delivers the same library,
therefor the problem is for now not solved with an ext_autoload
entry, but is required directly at where needed.

Change-Id: Ibb364ebbf3a16f63f61bef3b1987963b6c7f881a
Fixes: #45095
Related: #37115
Releases: 6.1
Reviewed-on: https://review.typo3.org/17954
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Hook call modifyDBRow in ContentContentObject 61/17961/2
Alina Fleser [Sat, 2 Feb 2013 11:11:28 +0000 (13:11 +0200)]
[BUGFIX] Hook call modifyDBRow in ContentContentObject

Replace $this->TYPO3_CONF_VARS with $GLOBALS['TYPO3_CONF_VARS']

Fixes: #44416
Releases: 6.0, 6.1, 4.7, 4.6, 4.5
Change-Id: I1f2b6a2479cc879c2a9144d03e176b74d895d52f
Reviewed-on: https://review.typo3.org/17961
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Install tool documentation default installTollPassword 60/17960/2
Tomita Militaru [Sat, 2 Feb 2013 10:55:40 +0000 (12:55 +0200)]
[BUGFIX] Install tool documentation default installTollPassword

The fatal error message instructs to use array position EXT instead
of position BE for installToolPassword.
Replaces EXT with BE in the error message.

Fixes: #44682
Releases: 6.0, 6.1
Change-Id: Ic262e9c9838dc07dc523e9a85cf92e8f1f79e634
Reviewed-on: https://review.typo3.org/17960
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Labels for grouping bookmarks are missing 55/17955/2
Bindea Silviu [Sat, 2 Feb 2013 13:55:25 +0000 (15:55 +0200)]
[BUGFIX] Labels for grouping bookmarks are missing

Using function sL to load locallang with labels for bookmarks

Fixes: #44691
Releases: 6.1, 6.0
Change-Id: I509aa06e379e1397fea50c6a2c137db3994eff2a
Reviewed-on: https://review.typo3.org/17955
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix misspelling in RTE meta menu 45/17945/2
Tomita Militaru [Sat, 2 Feb 2013 09:55:26 +0000 (11:55 +0200)]
[BUGFIX] Fix misspelling in RTE meta menu

Corrects the label for inserting unordered bullet lists.

Fixes: #43886
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: I4190dbcc8cadc90ae00d1ec1aa405a5a75863594
Reviewed-on: https://review.typo3.org/17945
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Impossible to save the TCA configuration 81/17381/4
Philipp Gampe [Sat, 5 Jan 2013 22:59:39 +0000 (23:59 +0100)]
[BUGFIX] Impossible to save the TCA configuration

The configuration module allows to save changes to the TCA array.

If no extTablesDefinitionScript is defined, constant
TYPO3_extTableDef_script is defined as empty. This results in an
attempt to write to a directory (because the filename is empty).
This is not obvious as the constant is not needed much and the
error message is misleading.

Solution is to fall back to the default value during bootstrap if
extTablesDefinitionScript is not set in LocalConfiguration.php.

Change-Id: Id759aa73146669cccae9a83d8452340f9f78927b
Fixes: #44331
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17381
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] load TCA before manipulation 71/17171/5
Jigal van Hemert [Sat, 15 Dec 2012 08:58:54 +0000 (09:58 +0100)]
[BUGFIX] load TCA before manipulation

Load the TCA before manipulating the contents in form and
css_styled_content, otherwise the checks for later calls to
loadTCA will fail while the TCA is not fully loaded.

Change-Id: Id2d96d8dab0fc53661689f778871ebb078272062
Resolves: #38505
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17171
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Restore support for Update script 80/16780/8
Francois Suter [Tue, 29 Jan 2013 19:31:52 +0000 (20:31 +0100)]
[BUGFIX] Restore support for Update script

The new EM is missing support for the class.ext_update.php script.
This patch restores it, giving it its own icon in the extension
list view.

Change-Id: Id5ea243bb689882959aa85cdbe700e784d83b2c0
Resolves: #43244
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/16780
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanups for CSS Styled Content 34/17834/3
Sebastian Michaelsen [Wed, 30 Jan 2013 12:06:00 +0000 (13:06 +0100)]
[TASK] Cleanups for CSS Styled Content

* Remove "@todo Define visibility" annotations from the render_*
methods. They are called from TS, they need to be public.
* Remove unused variables from the CssStyledContentController
* Don't pass the constants borderColor and rowSpace to
tt_content.image any more, they are not used there

Resolves: #44965
Releases: 6.1
Change-Id: Ia6ee55754c9af976952274e22c01565f15ec2038
Reviewed-on: https://review.typo3.org/17834
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Misspelled class name FrontendUserAuthtenication 25/17925/3
Christian Kuhn [Fri, 1 Feb 2013 15:21:54 +0000 (16:21 +0100)]
[BUGFIX] Misspelled class name FrontendUserAuthtenication

Fix class name, rename file, fix usage
FrontendUserAuth*ten*ication
FrontendUserAuth*ent*ication

Change-Id: Id851db64a50a5938496dd4411caaec0bf7ba85af
Fixes: #43464
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17925
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] add check for empty form values in FORM View 61/11361/5
Alexander Stehlik [Fri, 1 Feb 2013 12:32:15 +0000 (13:32 +0100)]
[BUGFIX] add check for empty form values in FORM View

If a FORM is submitted without any value a Fatal Error is thrown in
typo3/sysext/form/Classes/View/Confirmation/Confirmation.php on line
101. The patch adds a check for that case.

Fixes: #28606
Releases: 6.1, 6.0, 4.7, 4.6

Change-Id: I77cd57f0d56e9bdcf9517683ea21c3dc9ec1bc45
Reviewed-on: https://review.typo3.org/11361
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove classFile option from services 50/11150/5
Benjamin Mack [Sat, 12 May 2012 01:43:18 +0000 (20:43 -0500)]
[TASK] Remove classFile option from services

When using services (sv), one had to add "classFile" to the info
array when registering a service in order to find the entered
className. As this is now completely taken care of by the autoloader,
the option is obsolete and is now deprecated.

Note that once this is in, the documentation needs to be adjusted
as well.

Change-Id: Ic8817c80f7646e071ba71fa498972b70115715c5
Releases: 6.1
Resolves: #37115
Reviewed-on: https://review.typo3.org/11150
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] StorageRepository must respect 'deleted' flag 88/17588/4
Sebastian Michaelsen [Fri, 18 Jan 2013 10:44:47 +0000 (11:44 +0100)]
[BUGFIX] StorageRepository must respect 'deleted' flag

The FAL's Storage Repository find* methods also load
deleted file storages at the moment.

Reproduce:
* Create some "File Storage" records on the root page and
delete some of them
* Open the File module, it will showdeleted File Storages

Resolves: #44630
Releases: 6.1, 6.0
Change-Id: I5c60f16261508978ddbe47aa26b52be5b05a82bc
Reviewed-on: https://review.typo3.org/17588
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Rebuild sys_note to match extbase scheme 09/16909/9
Kai Vogel [Fri, 30 Nov 2012 22:35:12 +0000 (23:35 +0100)]
[FEATURE] Rebuild sys_note to match extbase scheme

This patch extends the sys_note extension and adds a controller and
model. Additionally it rewrites the repository to use the extbase
persistance layer. And it provides the possibility to modify the view
configuration via TypoScript.

Resolves: #43495
Releases: 6.1

Change-Id: I372e9fe0761875cd8967e920417d89cd5ad379b9
Reviewed-on: https://review.typo3.org/16909
Reviewed-by: Kai Vogel
Tested-by: Kai Vogel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Remove delete button for sys_file 17/17917/2
Helmut Hummel [Fri, 1 Feb 2013 10:27:16 +0000 (11:27 +0100)]
[BUGFIX] Remove delete button for sys_file

The edit view of file meta data currently has
a delete button, which sets the record of this
file to deleted, but does not delete the file itself.

It might be useful at some point
to use this to implement some recycler
functionality, but currently the FAL layer
has no support for it and a file with a deleted
meta data record is an inconsistent state
which has to be avoided by all means.

Resolves: #45065
Releases: 6.0, 6.1

Change-Id: I5033107cf4021d127e274bbe12e3aa08ea1b4ef6
Reviewed-on: https://review.typo3.org/17917
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[CLEANUP] Cleanup calls and docheaders in Core/Classes/Resource 93/17493/5
Anja Leichsenring [Sat, 12 Jan 2013 15:40:07 +0000 (16:40 +0100)]
[CLEANUP] Cleanup calls and docheaders in Core/Classes/Resource

In the Core/Classes/Resource Folder many calls to classes can be
used with shorthand syntax (without the namespace).

Many docheaders miss one or more @throws clauses for Exceptions to throw.

Resolves: #44476
Releases: 6.1, 6.0

Change-Id: Ia9c4b6e29fa924d42df8ff0e1e68ed607ce8256f
Reviewed-on: https://review.typo3.org/17493
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper 40/17540/4
Sebastian Michaelsen [Tue, 15 Jan 2013 10:05:09 +0000 (11:05 +0100)]
[TASK] Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper

Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper this
is not used anymore in the core.

Resolves: #44527
Releases: 6.1, 6.0

Change-Id: I06925b20d7399181be6bb2d5f5439cade1fca7c1
Reviewed-on: https://review.typo3.org/17540
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] DataHandler::getAutoVersionId() should be public 03/17903/2
Oliver Hader [Thu, 31 Jan 2013 18:17:41 +0000 (19:17 +0100)]
[TASK] DataHandler::getAutoVersionId() should be public

The method getAutoVersionId() in DataHandler/t3lib_TCEmain
should be public. The method is a helper to access the accordant
member variable that get's filled during workspace actions and
thus is useful in hooks as well.

Change-Id: Ie1f55d92b8e72e6ab68a563f0c1c52762239e102
Resolves: #45050
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17903
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Remove save and new button for sys_file 98/17898/2
Helmut Hummel [Thu, 31 Jan 2013 16:46:22 +0000 (17:46 +0100)]
[BUGFIX] Remove save and new button for sys_file

The save and new button does not make any sense for file
meta data, so we should not display it.

Resolves: #45044
Releases: 6.0, 6.1

Change-Id: Ic25edee5b208103f74c7d566acb93099bdd3c19f
Reviewed-on: https://review.typo3.org/17898
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] ext:aboutmodules broken link to ext:reports 76/17876/2
Christian Kuhn [Wed, 30 Jan 2013 21:11:36 +0000 (22:11 +0100)]
[BUGFIX] ext:aboutmodules broken link to ext:reports

ext:aboutmodules shows some message box if ext:reports
is installed and found some serious problem. The message
box has a link to reports module that is broken and fixed
by the patch.

Change-Id: I7d0b2b6573eb960028cb1de0463808eaf5860fbc
Resolves: #40218
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17876
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] displayWarningMessages uses wrong returnUrl 43/17543/4
Sebastian Michaelsen [Tue, 15 Jan 2013 13:29:33 +0000 (14:29 +0100)]
[BUGFIX] displayWarningMessages uses wrong returnUrl

The warning in the "About Modules" module about an
insecure admin offers a link to edit this user. Following
this link and then closing the form again leads to a 404.
The reason is a wrong returnUrl in
BackendUtility:: displayWarningMessages.

Resolves: #44537
Releases: 6.1, 6.0
Change-Id: I41d361d8b7314ac0bace8b8a5979a6f69128657c
Reviewed-on: https://review.typo3.org/17543
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] LocalConfiguration extListArray should be written without keys 11/17811/4
Jan-Erik Revsbech [Tue, 29 Jan 2013 19:46:05 +0000 (20:46 +0100)]
[BUGFIX] LocalConfiguration extListArray should be written without keys

When writing LocalConfiguration.php, arrays should be written without keys
if all the keys are numeric, even if the keys contain leaps.

Fixes: #44938
Releases: 6.1, 6.0
Change-Id: Ic1d929d54a75b091ecbe4f0f4b82049d507ccd95
Reviewed-on: https://review.typo3.org/17811
Reviewed-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Add missing labels for Extension Manager 12/17812/2
Wouter Wolters [Tue, 29 Jan 2013 21:18:01 +0000 (22:18 +0100)]
[BUGFIX] Add missing labels for Extension Manager

The Extension Manager is missing the labels when opening
the About Modules in the backend.

Change-Id: I4ea3a312e707dd1af22f6a693298170c32e19ecc
Fixes: #44941
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17812
Reviewed-by: Jan-Erik Revsbech
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Create CSS Styled Content TypoScript configuration for 6.0 30/17830/4
Sebastian Michaelsen [Wed, 30 Jan 2013 12:18:32 +0000 (13:18 +0100)]
[TASK] Create CSS Styled Content TypoScript configuration for 6.0

For backwards compatibility we keep versions of the CSS Styled
Content TypoScript configuration files selectable as rendering
template.

The current setup.txt and constants.txt are just copied into
the 6.0 folder. After this change the branches may diverge

Resolves: #44963
Releases: 6.1
Change-Id: I3eef95b796f7f05bb176044ee556a7bf6ab270a7
Reviewed-on: https://review.typo3.org/17830
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[FEATURE] FLUIDTEMPLATE cObj settings array support 49/17849/4
Christian Kuhn [Wed, 30 Jan 2013 16:43:13 +0000 (17:43 +0100)]
[FEATURE] FLUIDTEMPLATE cObj settings array support

extbase action controllers give a settings typoscript sub array
to the view, if it exists. This feature is very handy, it allows
full typoscript magic like constants access on this sub array.

The FLUIDTEMPLATE content object has a the variables typoscript
configuration, but this allows only other content objects in it. This
is unpractical if just some key-value nested array should be given
to the view.

The patch adds a settings property to the FLUIDTEMPLATE cObj that
behaves similar to the extbase action controller. If given, this
array is just assigned as is to the view.

Example:

lib.globalSettings {
# Access to constants works, too.
foo = value
}
page = PAGE
page.10 = FLUIDTEMPLATE
page.10 {
file = fileadmin/templates/MyTemplate.html
settings < lib.globalSettings
}

In the view, the value can then be used: {settings.foo}

Change-Id: Ie48911275832d422525e7d8891096fefcc0af152
Resolves: #23853
Releases: 6.1
Reviewed-on: https://review.typo3.org/17849
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Reset legacy fields if no relations are found 48/17848/2
Helmut Hummel [Wed, 30 Jan 2013 16:39:28 +0000 (17:39 +0100)]
[BUGFIX] Reset legacy fields if no relations are found

If you add multiple images to a tt_content element
but mark all of them hidden, an image is shown which has
the uid of the number of images added to the element.

This is the case because TYPO3 puts the relation count in the
field and the frontend adapter service does not reset
the field if no relations are found.

The solution is to set the legacy fields in any case.

This change adds a test which fails without a fix
and another test which shows that the original behaviour
is not affected.

Resolves: #44988
Releases: 6.0, 6.1

Change-Id: Ia4690fb0a68cd4d6832aef6712bc69adf00f8a5f
Reviewed-on: https://review.typo3.org/17848
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Remove obsolete flushByTags() from wincache 09/17809/2
Christian Kuhn [Tue, 29 Jan 2013 19:29:31 +0000 (20:29 +0100)]
[BUGFIX] Remove obsolete flushByTags() from wincache

Method flushByTags() was removed from the cache backend interface
since core version 4.6 and fully removed in 6.0. The wincache
backend still implements this method, but it is never used
anywhere, so it can be removed.

Change-Id: I038f1839f77b33173122bb8a0485dd005ee8a5a4
Fixes: #44937
Related: #35818
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17809
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Register suite integrity tests again 07/17807/2
Christian Kuhn [Tue, 29 Jan 2013 19:13:13 +0000 (20:13 +0100)]
[BUGFIX] Register suite integrity tests again

The integrity unit tests executed at the very bottom of the
test suite very accidentally removed during issue #40950.
Add them again.

Change-Id: Ifc59f201c98a79e1cf376e1c1e1124408cd37c10
Fixes: #44936
Related: #40950
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17807
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Accept template from content objects FLUIDTEMPLATE 41/16241/5
Helmut Hummel [Tue, 6 Nov 2012 19:40:38 +0000 (20:40 +0100)]
[FEATURE] Accept template from content objects FLUIDTEMPLATE

Add possibility to use content objects as Fluid
template source.

This adds a new property "template" to the FLUIDTEMPLATE
cObj to be in line with the TEMPLATE cObj

Resolves: #39767
Releases: 6.1

Change-Id: Iacd291f503ab88fb530f3b439e26cb755d17dee2
Reviewed-on: https://review.typo3.org/16241
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] FLUIDTEMPLATE cObj uses wrong template file 97/17797/2
Christian Kuhn [Tue, 29 Jan 2013 16:09:03 +0000 (17:09 +0100)]
[BUGFIX] FLUIDTEMPLATE cObj uses wrong template file

Due to some weird instance re-usage in the content object renderer,
the view object in FLUIDTEMPLATE content object must be re-created
for every call to render() to avoid some nasty cache issues.

Change-Id: If2ec0b171b8227aba9204d343a9e9010b69ecc78
Resolves: #44610
Related: #42182
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17797
Reviewed-by: Marcus Krause
Reviewed-by: Oliver Hader
Tested-by: Marcus Krause
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] EXT:reports Minor typo in HTML 77/17777/2
Christian Kuhn [Tue, 29 Jan 2013 09:12:49 +0000 (10:12 +0100)]
[TASK] EXT:reports Minor typo in HTML

Change-Id: I141db7aa51add26d1a0840ad80b4aa40c40d45db
Related: #44895
Releases: 6.1
Reviewed-on: https://review.typo3.org/17777
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] EXT:reports Improve xclass reporting 76/17776/4
Christian Kuhn [Mon, 28 Jan 2013 22:19:47 +0000 (23:19 +0100)]
[TASK] EXT:reports Improve xclass reporting

Since TYPO3 CMS 6.0, the XCLASS registration changed and the old
registration style does not work anymore. Additionally, 6.0 comes
with a basic check for old XCLASS registration to warn users about
that.

The patch adds a new report for newly registered XCLASS'es and
adapts the messages to better notify that neither old nor new
registrations are a real problem, but that those classes should
be kept an eye on during upgrading.

Change-Id: I8c0052b9c7fb0e88aff62a71c9592bf51bcec7ad
Resolves: #44895
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17776
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[TASK] Remove function usage ctype_alnum in PageRenderer 17/17017/3
Ingo Pfennigstorf [Fri, 7 Dec 2012 15:18:44 +0000 (16:18 +0100)]
[TASK] Remove function usage ctype_alnum in PageRenderer

This fixes the problem that on some servers the PHP ctype extension
is not installed by default and results in a blank backend screen
when trying to edit a page.

Fixes: #43726
Releases: 6.1, 6.0

Change-Id: Icb029a39107c092c06c9e70bbde0b2217e5860f7
Reviewed-on: https://review.typo3.org/17017
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] tt_content: exclude config fields 67/17767/3
Felix Kopp [Mon, 28 Jan 2013 15:45:44 +0000 (16:45 +0100)]
[BUGFIX] tt_content: exclude config fields

Adds missing option to restrict access for properties
in tt_content elements within backend user group:

* imageorient (Image orientation)
* imagecols (Image columns)

Without those options no minimal configuration
for backend user privileges can be setup.

Fixes: #44890
Release: 6.0, 6.1
Change-Id: Ia5ed4779db27f90fb7d44eb47c3290c523027a21
Reviewed-on: https://review.typo3.org/17767
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Backend groups: exclude config fields 66/17766/2
Felix Kopp [Mon, 28 Jan 2013 15:21:52 +0000 (16:21 +0100)]
[BUGFIX] Backend groups: exclude config fields

Adds missing option to restrict access to the fields:

* content_from_pid (Show content from different page)
* alias (Url alias)

within backend user group configuration.

Without these exclude fields backend user right can not
be stripped to the minimum: edit page title only.

Fixes: #40866
Releases: 6.0, 6.1
Change-Id: I1d5a1f08ea72cbeb11ade0302ebb0ecb7a5bfe2a
Reviewed-on: https://review.typo3.org/17766
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Possible warning in about module 68/17768/2
Christian Kuhn [Mon, 28 Jan 2013 16:47:21 +0000 (17:47 +0100)]
[BUGFIX] Possible warning in about module

ext:about includes ext_emconf.php files of loaded extensions.
The code raises a warning if those files are not found. This
can happen for example, if some extension is loaded in
LocalConfiguration "extList", but does not exist in the file
system.

Solution is to check for file existance before include.

Change-Id: Ic58adfc908ff02d5f0d9e79b69719d02c6b429ab
Fixes: #44892
Releases: 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/17768
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Make submit button save all tabs in extension manager 57/17757/3
Jan-Erik Revsbech [Mon, 28 Jan 2013 10:29:13 +0000 (11:29 +0100)]
[BUGFIX] Make submit button save all tabs in extension manager

Each category is rendered as separate sheets/tabs, but should
share a single form and submit button. Otherwise changes to
one sheet are not saved when clikting submit in another sheet.

Fixes: #44876
Related: #44559
Releases: 6.1, 6.0

Change-Id: Idce5c70c20faebe495b9241ac0f2f0ea0aec6c2a
Reviewed-on: https://review.typo3.org/17757
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] EM: Refactor Configuration handling 31/17731/3
Christian Kuhn [Sat, 26 Jan 2013 16:29:33 +0000 (17:29 +0100)]
[TASK] EM: Refactor Configuration handling

Classes ConfigurationUtility and ConfigurationItemRepository handle
the extension managers extension configuration settings.

Configuration sources are ext_conf_template.txt files,
LocalConfiguration.php and the extension manager configuration
forms. They all have different formats and structures, thus
the code to merge all that is not exactly easy.

This patch shifts some code around in order to make the current
handling better understandable for easier debugging. The API is
still not as simple as it should be, but for now some
code smell is solved:

* Use @inject annotation for dependency injection to reduce
  number of code lines.
* Remove dependency injected objects if possible and rely on
  injection of objectManager only if the object is not widely
  used in the class.
* Disentangle a method call chain from InstallUtility to
  ConfigurationUtility back to InstallUtility by removing method
  writeExtensionTypoScriptStyleConfigurationToLocalconf() from
  InstallUtility and merging functionality with
  ConfigurationUtility->writeConfiguration().
* Remove public method createArrayFromConstants() from
  ConfigurationItemRepository and move to ConfigurationUtility
  under new name
  getDefaultConfigurationFromExtConfTemplateAsFlatItemArray().
* Rename ConfigurationItemRepository->findByExtension() to
  findByExtensionKey() and always let it return an
  ObjectStorage, even if empty.
* Simplify several method signatures, mostly of protected methods
  to one parameter only, moving only the extension key around.
* Better encapsulating of low level code in protected methods
  instead of duplicated low level code in in entry methods
  or controller logic.
* Resolve code smell in unit tests with better mocking and
  structured tests.

Change-Id: I441280a3907e2487cd7fe7ba1856e9ef04c72a42
Resolves: #44818
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17731
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 42/17742/2
Christian Kuhn [Sat, 26 Jan 2013 21:23:41 +0000 (22:23 +0100)]
[TASK] Raise submodule pointer

Change-Id: I045cc3a5c7b1046f2339ca411027335371caeab3
Reviewed-on: https://review.typo3.org/17742
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Invalid description of noPHPscriptInclude 40/17040/3
dprecup [Sun, 9 Dec 2012 11:20:12 +0000 (13:20 +0200)]
[BUGFIX] Invalid description of noPHPscriptInclude

default of ['FE']['noPHPscriptInclude'] as documented in
t3lib/stddb/DefaultConfiguration.php is not 'media/scripts/' but
one one of 'typo3/ext/', 'typo3/sysext/' or 'typo3conf/ext'

Resolves: #43730
Releases: 6.0

Change-Id: Idb5f63ffc3c555a6b096077302b8e56cd0b82983
Reviewed-on: https://review.typo3.org/17040
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix error listing in belog 49/17049/5
Tomita Militaru [Sun, 9 Dec 2012 14:29:04 +0000 (16:29 +0200)]
[BUGFIX] Fix error listing in belog

Added an array with the error codes into the query constraint when
action Errors (-1) was selected.

Fixes: #43797
Releases: 6.0, 6.1
Change-Id: Iccf5db777d1e93bcad24fc72b3eef935464d3582
Reviewed-on: https://review.typo3.org/17049
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Use property injection in LanguageController 34/17534/4
Sebastian Michaelsen [Tue, 15 Jan 2013 09:03:51 +0000 (10:03 +0100)]
[TASK] Use property injection in LanguageController

\TYPO3\CMS\Lang\Controller\LanguageController has 4
inject* Methods which a pretty vanilla and can be replaced
by property injection.

Resolves: #44526
Releases: 6.1, 6.0

Change-Id: I37181e2bbbd12c9c7fe7b34fe8adafe6f4becec3
Reviewed-on: https://review.typo3.org/17534
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanups for sysext belog 70/17670/4
Sebastian Michaelsen [Wed, 23 Jan 2013 11:11:20 +0000 (12:11 +0100)]
[TASK] Cleanups for sysext belog

* Fix references to old classes
* Use property injection where possible

Resolves: #44744
Releases: 6.1, 6.0
Change-Id: I3076f48876fdc7566e85810eaf22aaa87d5c71e8
Reviewed-on: https://review.typo3.org/17670
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix problem with saving extension configuration in different tabs 80/16280/4
Jan-Erik Revsbech [Thu, 8 Nov 2012 00:38:58 +0000 (01:38 +0100)]
[BUGFIX] Fix problem with saving extension configuration in different tabs

The new ConfigurationUtility is working internally with configuration as
valued array, but the existing configuration is serialized in the old
nested format. When merging these two, exising configuration was not
merged correctly, resulting in error where configuration set in other tabs
was lost when saving.

Change-Id: I9007a0f80974A72610b3afc1e1dc76f7cad31fca
Fixes: #42775
Releases: 6.0
Change-Id: I9007a0f80974a72610b3afc1e1dc76f7cad31fca
Reviewed-on: https://review.typo3.org/16280
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Sebastian Michaelsen
Tested-by: Sebastian Michaelsen
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Add cursor:pointer to inline header 04/17704/2
Georg Ringer [Fri, 25 Jan 2013 14:01:41 +0000 (15:01 +0100)]
[TASK] Add cursor:pointer to inline header

the header + icon of a IRRE header should have a cursor:pointer as this is
the area which opens the related record

Change-Id: I71b91f049bf912661d6b6a1e38cb56ba0a9fea1e
Resolves: #44808
Releases: 6.1,6.0
Reviewed-on: https://review.typo3.org/17704
Reviewed-by: Wouter Wolters
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
6 years ago[BUGFIX] Avoid PHP Warning if there are empty columns in Page Module 62/17562/2
Roland Waldner [Wed, 16 Jan 2013 07:18:46 +0000 (08:18 +0100)]
[BUGFIX] Avoid PHP Warning if there are empty columns in Page Module

Change-Id: I218065a3445211d88ce131ecf23da3a947eb2e70
Resolves: #44540
Branches: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17562
Reviewed-by: Mattias Nilsson
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] EM: un/install visual feedback 91/17091/2
Felix Kopp [Tue, 11 Dec 2012 06:27:07 +0000 (07:27 +0100)]
[BUGFIX] EM: un/install visual feedback

Adds a visual feedback to the un/install button action in EM:
Masks the extension manager during un/install operations
are in progress - after success a page redirect is fired.

Introduces a CSS class that class can be added to any link in EM:
.onClickMaskExtensionManager

Change-Id: If7aa0b15eeab1afb162b103662a10920f4da149f
Fixes: #43856
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17091
Reviewed-by: Sebastian Michaelsen
Tested-by: Sebastian Michaelsen
Reviewed-by: Tobias Liebig
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Correct TCA inclusion for uploads rendering 50/17250/2
Alexander Stehlik [Thu, 20 Dec 2012 10:08:03 +0000 (11:08 +0100)]
[BUGFIX] Correct TCA inclusion for uploads rendering

In the method that renders the uploads in css_styled_content
the call to load the TCA was replaced with its Frontend
counterpart to enable access to the configuration of custom
fields in tt_content.

Fixes: #44145
Branches: 4.5, 4.6, 4.7, 6.0, 6.1

Change-Id: I26f67fcfbf11db25c80ebe93ddd1e81167d828a9
Reviewed-on: https://review.typo3.org/17250
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Remove deprecated code from "about" and "aboutmodules" 43/16843/6
Wouter Wolters [Wed, 28 Nov 2012 21:06:00 +0000 (22:06 +0100)]
[TASK] Remove deprecated code from "about" and "aboutmodules"

Remove deprecated code from "about" and "aboutmodules"

Change-Id: I2296d4039ce8ffd16a39c3643365886b1f696a69
Resolves: #44761
Releases: 6.1
Reviewed-on: https://review.typo3.org/16843
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Missing subcategories labels in EM 60/17660/4
Francois Suter [Tue, 22 Jan 2013 22:16:28 +0000 (23:16 +0100)]
[BUGFIX] Missing subcategories labels in EM

The (new) Extension Manager correctly uses subcategories for sorting
and grouping extension configuration options (in the configuration
form), but does not display the related labels. This makes the form
rather weird and unhelpful. This information must be restored.

Resolves: #44701
Releases: 6.0, 6.1
Change-Id: I0dde1d294edc403404ad39985f91e3772ef0b710
Reviewed-on: https://review.typo3.org/17660
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Add save only button to Scheduler task 90/17590/6
Lorenz Ulrich [Fri, 18 Jan 2013 14:17:06 +0000 (15:17 +0100)]
[TASK] Add save only button to Scheduler task

Scheduler tasks currently miss a save only button. Since Firefox and
Opera don't send the value of an <input type="submit">, the save and
save & close buttons are wrapped in a <button type="submit"> to ensure
saving and saving & closing is cross-browser compatible.

Change-Id: Ia5e32efc2e5e2af2943374c9a570a3a94b0511b4
Fixes: #44152
Releases: 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/17590
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
Reviewed-by: Christopher Seidel
Tested-by: Christopher Seidel
Reviewed-by: Francois Suter
Tested-by: Francois Suter
6 years ago[BUGFIX] IRRE forms not using full width 60/17560/2
Ingo Renner [Wed, 16 Jan 2013 00:09:51 +0000 (16:09 -0800)]
[BUGFIX] IRRE forms not using full width

In 4.7 IRRE forms used to be full width of the parent form.
A change introduced in 6.0 now causes the forms to collapse
to less than the full width.

Change-Id: Ie326a339c762c539440e6f70cc51b467e39a666c
Fixes: #44549
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17560
Reviewed-by: Gaëtan MARMASSE
Tested-by: Gaëtan MARMASSE
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
6 years ago[BUGFIX] Instantiate new classes in typo3/* files 50/17650/2
Francois Suter [Tue, 22 Jan 2013 13:11:33 +0000 (14:11 +0100)]
[BUGFIX] Instantiate new classes in typo3/* files

Most typo3/*.php files instantiate the new controllers, but some have
been forgotten. This doesn't break the backend thanks to the legacy
classes mapping, but breaks the XCLASSing mechanism.

Resolves: #44718
Releases: 6.0, 6.1
Change-Id: I0d5b44652f7e3c2c793f77fee7a90da283c0769b
Reviewed-on: https://review.typo3.org/17650
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] ConfigurationUtility loses extension key 00/17600/2
Francois Suter [Sat, 19 Jan 2013 20:56:44 +0000 (21:56 +0100)]
[BUGFIX] ConfigurationUtility loses extension key

The EM's ConfigurationUtility::getCurrentConfiguration() method looks for
the extension key at the wrong place. Rather than using the key
it receives as a parameter, it tries to get it from
$GLOBALS['TYPO3_LOADED_EXT'] where it does not exist.

Releases: 6.0, 6.1
Resolves: #44665
Change-Id: Ifc18dcc68eee7eb2b0d21ebdbec48e868c6b7d4d
Reviewed-on: https://review.typo3.org/17600
Reviewed-by: Francois Suter
Tested-by: Francois Suter
6 years ago[BUGFIX] array_merge_recursive_overrule: __UNSET for array values 96/17096/3
Sebastian Michaelsen [Tue, 11 Dec 2012 10:43:57 +0000 (11:43 +0100)]
[BUGFIX] array_merge_recursive_overrule: __UNSET for array values

Using __UNSET on keys that hold array values does not unset them.
However the documentation does not mention this restriction.
Therefore this is considered a bug and fixed by this patch.

Resolves: #43874
Releases: 6.1, 6.0, 4.7

Change-Id: Ie9f96c6f608da7e91fec2bc639dba9f3bcc8f426
Reviewed-on: https://review.typo3.org/17096
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig
6 years ago[TASK] Remove references to oldstyle Login News (TYPO3_CONF_VARS) 19/17519/3
Sebastian Michaelsen [Mon, 14 Jan 2013 11:16:58 +0000 (12:16 +0100)]
[TASK] Remove references to oldstyle Login News (TYPO3_CONF_VARS)

Adding Login News via
$GLOBALS['TYPO3_CONF_VARS']['BE']['loginNews'] is not longer
supported but there are still references to it in the code that should be
removed.

Resolves: #44506
Releases: 6.0, 6.1

Change-Id: I2c91c3209dc4a1dc55e570e569825acb3167150e
Reviewed-on: https://review.typo3.org/17519
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Fix incomplete mocking in ResourceStorage test 09/17509/3
Helmut Hummel [Sun, 13 Jan 2013 17:24:51 +0000 (18:24 +0100)]
[BUGFIX] Fix incomplete mocking in ResourceStorage test

Due to a not mocked FileRepository object, a warning
is issued which leads to a failed test.

Add a FileRepository mock and clean up all usage
of the FileRepository in ResourceStorage.

Fixes: #44439
Releases: 6.0, 6.1

Change-Id: I214fce4635d452764bd9edc8e11f863bd76961a6
Reviewed-on: https://review.typo3.org/17508
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/17509

6 years ago[BUGFIX] Persist files that are updated in ResourceStorage 78/17478/2
Helmut Hummel [Sat, 12 Jan 2013 14:46:39 +0000 (15:46 +0100)]
[BUGFIX] Persist files that are updated in ResourceStorage

When renaming or moving folders all files in that
folder needs to be updated. ResourceStorage handles
that, but the changes to the properties are not
persisted, which leads to inconsistent file records.

Persist updated files using the FileRepository and
clean up the code a bit.

Fixes: #44439
Releases: 6.0, 6.1

Change-Id: I9a21040fdd6741e030d812df165cd33959dd8db1
Reviewed-on: https://review.typo3.org/17478
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Use array in check for new CE button 02/17502/2
Jigal van Hemert [Sun, 13 Jan 2013 09:42:41 +0000 (10:42 +0100)]
[BUGFIX] Use array in check for new CE button

After #44470 the content elements in a column are stored in an array.
Checks for the new content element button, etcetera must check that
array instead of counting the elements in the query result that was used
before.

Change-Id: I6f9def862a4398ea0e8972b395d5a58a4dc4a241
Fixes: #44481
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17502
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years agoRevert "[BUGFIX] LocalDriver needs to respect "is_writeable"" 98/17498/2
Helmut Hummel [Sat, 12 Jan 2013 18:26:56 +0000 (19:26 +0100)]
Revert "[BUGFIX] LocalDriver needs to respect "is_writeable""

This change broke the tests

This reverts commit e9543738e14e235087d303abeb1492cf0c8e5f01

Change-Id: I6638ca1c82482bd1b9477fb343b7d566e8fe559c
Reviewed-on: https://review.typo3.org/17498
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Content elements in wrong column in page module 68/17468/3
Oliver Hader [Fri, 11 Jan 2013 17:29:34 +0000 (18:29 +0100)]
[BUGFIX] Content elements in wrong column in page module

If working on workspaces, it might happen that content elements
just appear in the wrong column. The reason is, that live(!)
content elements are selected using a specific column value and
then are overlaid with workspace data.

If the column value has been modified in a workspace, this is
currently just ignored during rendering.

Change-Id: I9eccc2ff5b7220544cd28ee6de8f55453c04a5d1
Fixes: #44470
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17468
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] LocalDriver needs to respect "is_writeable" 13/17413/9
Georg Ringer [Thu, 10 Jan 2013 09:37:21 +0000 (10:37 +0100)]
[BUGFIX] LocalDriver needs to respect "is_writeable"

The LocalDriver needs also to respect the flag "is_writeable".
This means: if the flag is not set, no folder/file can be edited/moved...

Change-Id: I6fc1edd452555381388bd5bfaa46dd8241dc853b
Fixes: #44370
Releases: 6.0,6.1
Reviewed-on: https://review.typo3.org/17413
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] FAL: update wizard fails if file does not exist 33/16533/6
Andreas Wolf [Sat, 17 Nov 2012 16:02:40 +0000 (17:02 +0100)]
[BUGFIX] FAL: update wizard fails if file does not exist

The FAL update wizard throws an exception during migration if a file is
missing. As we cannot do that much about a missing source file, we
should at least not fatal here, but give the user a warning message in
the logs instead.

Change-Id: I3ab0ecd8d8f60e782b7459d7f92f89d2c0a9fd40
Resolves: #42882
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/16533
Reviewed-by: Franz Holzinger
Tested-by: Franz Holzinger
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Problem with special character in files and folders 65/17465/3
Christian Weiske [Fri, 11 Jan 2013 15:23:21 +0000 (16:23 +0100)]
[BUGFIX] Problem with special character in files and folders

This patch sanitizes the file name when creating a new file
in the file list.
Folder names already get sanitized.

Change-Id: If97b4a2f41de1334a2b07add6afc1f9d99af3117
Fixes: #42873, #42933
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17465
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] File-Upload does not sanitize umlauts in filenames 64/17464/3
Christian Weiske [Fri, 11 Jan 2013 14:46:15 +0000 (15:46 +0100)]
[BUGFIX] File-Upload does not sanitize umlauts in filenames

This patch sanitizes file names for uploaded files, fixing thumbnail
and deletion issues for files with umlauts.

Change-Id: I9c02e357b7b37d1c09656ed14f50a8adb7593d52
Fixes: #42925
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17464
Reviewed-by: Tilo Baller
Tested-by: Tilo Baller
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Add access check in FAL renameFolder() 45/17445/3
Georg Ringer [Thu, 10 Jan 2013 09:55:43 +0000 (10:55 +0100)]
[BUGFIX] Add access check in FAL renameFolder()

Currently no access check is done when trying to rename a folder.
This is marked also as todo in the code.

Change-Id: Ie1909804c0ccc7cfa5c495ba98322cad7d712c96
Fixes: #44425
Releases: 6.1,6.0
Reviewed-on: https://review.typo3.org/17445
Reviewed-by: Andreas Wolf
Reviewed-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Adjust hooks after moving/namespacing 01/17001/3
Stefan Neufeind [Fri, 7 Dec 2012 00:09:07 +0000 (01:09 +0100)]
[BUGFIX] Adjust hooks after moving/namespacing

Change-Id: I4e8de22ee8b04bcee8dabbc3bce1203f68146f51
Fixes: #43676
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17001
Reviewed-by: Nicole Cordes
Reviewed-by: Tilo Baller
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Tilo Baller
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix array_merge when creating FAL access rights 46/17446/2
Georg Ringer [Thu, 10 Jan 2013 12:48:06 +0000 (13:48 +0100)]
[BUGFIX] Fix array_merge when creating FAL access rights

The arguments of array_merge need to be changed, otherwise
the default settings always win.

Change-Id: Ic430e5fdc2f8e5ec868ec2f5a7c0dd21c28a408c
Fixes: #44429
Releases: 6.1,6.0
Reviewed-on: https://review.typo3.org/17446
Reviewed-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel