Packages/TYPO3.CMS.git
8 months ago[BUGFIX] Adjust table field type to varchar 10/58210/3
Anja [Fri, 7 Sep 2018 10:01:21 +0000 (12:01 +0200)]
[BUGFIX] Adjust table field type to varchar

In order to create workspace stage records, the parenttable field
must not be a tinytext, else the not null restriction fails on
SQlite.

Change-Id: I38cb8fca0eb293100ab7d73433cc284307eb1d0d
Resolves: #85405
Releases: master
Reviewed-on: https://review.typo3.org/58210
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Do not let sites module render rootpages in workspaces 02/58202/3
Andreas Fernandez [Thu, 6 Sep 2018 14:26:14 +0000 (16:26 +0200)]
[BUGFIX] Do not let sites module render rootpages in workspaces

If root pages are configured in workspaces, such pages must not get
rendered in the sites module. The BackendWorkspaceRestriction is added
to prevent fetching such pages in the LIVE workspace.

Resolves: #86174
Releases: master
Change-Id: I35a614d41125516a65cd1d2bce917c04f6af57ac
Reviewed-on: https://review.typo3.org/58202
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Show unassigned sites in site module 92/58192/2
Georg Ringer [Wed, 5 Sep 2018 17:52:49 +0000 (19:52 +0200)]
[TASK] Show unassigned sites in site module

The site module displays now also sites with no valid related page anymore.
This can happen if the page is being removed.

Resolves: #86150
Releases: master
Change-Id: If75a33e6c2d189abd42746b52d0b828b7a7b38cb
Reviewed-on: https://review.typo3.org/58192
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Timo Hund <timo.hund@yahoo.com>
Tested-by: Timo Hund <timo.hund@yahoo.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Trigger `change` event after calculating slug 18/58218/3
Andreas Fernandez [Fri, 7 Sep 2018 14:43:09 +0000 (16:43 +0200)]
[BUGFIX] Trigger `change` event after calculating slug

When the slug is calculated by using the according button, the `event` is
now triggered to let the user know that the field value has changes and
to invoke the "You have unsaved changes" modal when closing the form.

Resolves: #86190
Related: #86077
Releases: master
Change-Id: I6eb4e11252562f53e637e3a1abdd7b02a8f73a5a
Reviewed-on: https://review.typo3.org/58218
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Use updated typo3/phar-stream-wrapper version 20/58220/2
Oliver Hader [Fri, 7 Sep 2018 15:22:59 +0000 (17:22 +0200)]
[TASK] Use updated typo3/phar-stream-wrapper version

Resolves: #86191
Releases: master
Change-Id: Ie65dac040f720c313835603bd2446a15e6670c14
Reviewed-on: https://review.typo3.org/58220
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Prevent crash in DatabaseIntegrityCheck 01/58201/3
Christian Kuhn [Thu, 6 Sep 2018 13:57:50 +0000 (15:57 +0200)]
[BUGFIX] Prevent crash in DatabaseIntegrityCheck

If a relation field (select / group) does not exist in db for
whatever reason, System -> DB check -> Database relations
crashes.

Resolves: #86167
Releases: master, 8.7
Change-Id: Id6a502d56b985f6410f40a1f547fe7b923e9d982
Reviewed-on: https://review.typo3.org/58201
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Protect methods in SetupModuleController 11/58211/2
Christian Kuhn [Fri, 7 Sep 2018 10:12:01 +0000 (12:12 +0200)]
[TASK] Protect methods in SetupModuleController

Resolves: #86180
Releases: master
Change-Id: I6277be526cb11d1c6120f13e763d47405aac84d0
Reviewed-on: https://review.typo3.org/58211
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Protect render() method in BackendController 09/58209/2
Christian Kuhn [Fri, 7 Sep 2018 09:41:02 +0000 (11:41 +0200)]
[TASK] Protect render() method in BackendController

Resolves: #86179
Releases: master
Change-Id: Ie61ab04889e36b5290a0d8f4fc1fb68dd95a87ac
Reviewed-on: https://review.typo3.org/58209
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Hide page alias in pagetree overview with sites 04/58204/3
Christian Kuhn [Thu, 6 Sep 2018 15:42:46 +0000 (17:42 +0200)]
[TASK] Hide page alias in pagetree overview with sites

If rendering page trees in Info -> Pagetree overview that has
a full Site configuration, hide the "alias" field - it is not
shown in FormEngine, either.
If rendering a PseudoSite (no site configuration), hide the
slug field.

Resolves: #86175
Releases: master
Change-Id: I46ccb150184e4b76799ab8636ac280eda269c76b
Reviewed-on: https://review.typo3.org/58204
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Use updated typo3/phar-stream-wrapper version 19/58219/2
Oliver Hader [Fri, 7 Sep 2018 14:42:53 +0000 (16:42 +0200)]
[TASK] Use updated typo3/phar-stream-wrapper version

Resolves: #86191
Releases: master
Change-Id: I45d265cd6866dff1ab8fc0a058973c24471ac357
Reviewed-on: https://review.typo3.org/58219
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[TASK] Deprecate old TypoScript condition syntax 09/58109/10
Frank Naegler [Fri, 31 Aug 2018 20:19:21 +0000 (22:19 +0200)]
[TASK] Deprecate old TypoScript condition syntax

Since the symfony expression language is available for TypoScript
conditions, the old condition syntax is being deprecated.

Resolves: #86068
Releases: master
Change-Id: Iae1f4b6e400afbab233561af54c98bc4a4a40792
Reviewed-on: https://review.typo3.org/58109
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
8 months ago[BUGFIX] Fix fatal in ReportsModule with upgrade wizards 13/58213/3
Christian Kuhn [Fri, 7 Sep 2018 12:39:46 +0000 (14:39 +0200)]
[BUGFIX] Fix fatal in ReportsModule with upgrade wizards

With the new upgrade wizard API the InstallStatusReport
has to be adapted a bit to prevent a fatal calling
shouldRenderWizard() on wizards that don't have this
method.

Resolves: #86183
Releases: master
Change-Id: I0551c0a823a0a6f670c0ca079a1f2f4475ccf583
Reviewed-on: https://review.typo3.org/58213
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Clean up UpgradeWizardsService API 99/58199/2
Helmut Hummel [Thu, 6 Sep 2018 10:44:16 +0000 (12:44 +0200)]
[TASK] Clean up UpgradeWizardsService API

Remove implementation details from public API methods

Releases: master
Resolves: #86166
Change-Id: I3605132946d4fa1e92eccfa91498290dab4762c2
Reviewed-on: https://review.typo3.org/58199
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Use ServerRequestInterface in RecyclerAjaxController 85/58185/3
Anja [Tue, 4 Sep 2018 14:26:39 +0000 (16:26 +0200)]
[TASK] Use ServerRequestInterface in RecyclerAjaxController

All values are available in the request object, no need to touch the
globals. The constructor of the controller is empty after the
replacement, so it can be removed.

Change-Id: Ieb0d714965716638d51a982a858341938700572f
Resolves: #86146
Releases: master
Reviewed-on: https://review.typo3.org/58185
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Ensure connection can be established multiple times 89/58189/3
Nicole Cordes [Wed, 5 Sep 2018 11:45:02 +0000 (13:45 +0200)]
[BUGFIX] Ensure connection can be established multiple times

This patch ensures a connection can be established multiple times
and is initialized correctly using the init commands on each fresh
connection call.

Resolves: #86154
Releases: master, 8.7
Change-Id: Ief2fb0855715333b124e8315c5f794008a5fb3d5
Reviewed-on: https://review.typo3.org/58189
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Trim search value in live search 88/58188/2
Georg Ringer [Wed, 5 Sep 2018 08:49:09 +0000 (10:49 +0200)]
[BUGFIX] Trim search value in live search

The query parameter of the live search should be trimmed.
The same behaviour is already used in the regular search in the list module which is
available in the live search by clicking on the button "show all".

Resolves: #86149
Releases: master, 8.7
Change-Id: I3ec2ac03f67fa8c0daaa11aaf3e4351d05949b83
Reviewed-on: https://review.typo3.org/58188
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Only add pages to XML sitemap with no_index = 0 91/58191/2
Richard Haeser [Wed, 5 Sep 2018 14:27:37 +0000 (16:27 +0200)]
[BUGFIX] Only add pages to XML sitemap with no_index = 0

Pages with no_index, follow shouldn't show up in XML sitemap. Only pages
that needs to be indexed.

Resolves: #86157
Releases: master
Change-Id: I609b321d8cd256ceac6599b6a0516c8b3994928b
Reviewed-on: https://review.typo3.org/58191
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Improve TCA of site_errorhandling 87/58187/2
Georg Ringer [Wed, 5 Sep 2018 06:11:23 +0000 (08:11 +0200)]
[TASK] Improve TCA of site_errorhandling

- Localize labels
- Use label_alt to show not only errorCode but also errorHandler

Resolves: #86148
Releases: master
Change-Id: I699117be14d5b2c14f6d9325f7a3f4ecabd1382c
Reviewed-on: https://review.typo3.org/58187
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Reveal usage as controller of TaskStatus::class 83/58183/5
Anja [Tue, 4 Sep 2018 12:27:10 +0000 (14:27 +0200)]
[TASK] Reveal usage as controller of TaskStatus::class

The class is called by two ajax routes and is therefore to be named,
placed and handled as the controller that it is.

Change-Id: I5106f5310041d3f0a993c2bf7ebe03ac51454cad
Resolves: #86142
Releases: master
Reviewed-on: https://review.typo3.org/58183
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Deprecate FrontendEditingController 67/58067/11
Benni Mack [Wed, 29 Aug 2018 07:59:57 +0000 (09:59 +0200)]
[TASK] Deprecate FrontendEditingController

The class is not in use anymore, only feedit instantiates the class for legacy reasons.

Also FrontendBackendUserAuthentication->frontendEdit which holds an instance of
that, is deprecated.

Resolves: #86110
Releases: master
Change-Id: I3ff2ae529dd920d2abf9908f2ae94ae4c2bf9c15
Reviewed-on: https://review.typo3.org/58067
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Set TYPO3 version to 9.5.0-dev 81/58181/2
Oliver Hader [Tue, 4 Sep 2018 12:09:35 +0000 (14:09 +0200)]
[TASK] Set TYPO3 version to 9.5.0-dev

Change-Id: I96b70e192770b6955f82a8106db386f2044e738b
Reviewed-on: https://review.typo3.org/58181
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[RELEASE] Release of TYPO3 9.4.0 80/58180/2 v9.4.0
Oliver Hader [Tue, 4 Sep 2018 12:07:49 +0000 (14:07 +0200)]
[RELEASE] Release of TYPO3 9.4.0

Change-Id: I10cf279d74af2cfc2964704ba31c6ce2b7be3493
Reviewed-on: https://review.typo3.org/58180
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Avoid insufficient workspace version constraint 60/58160/4
Oliver Hader [Mon, 3 Sep 2018 19:56:40 +0000 (21:56 +0200)]
[BUGFIX] Avoid insufficient workspace version constraint

Resolves: #86126
Releases: master
Change-Id: I7724cb1415742861a0c6496f4e3888787e6467d4
Reviewed-on: https://review.typo3.org/58160
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Resolve version move placeholder in RootlineUtility 78/58178/5
Oliver Hader [Tue, 4 Sep 2018 10:04:24 +0000 (12:04 +0200)]
[BUGFIX] Resolve version move placeholder in RootlineUtility

In order to correctly work with rootlines (e.g. when resolving
according sites and pseudo-sites for URL resolving and generation)
possible version move placeholders have to be resolved.

Resolves: #86137
Releases: master
Change-Id: Ief9841f7592018292c034c03c45343363cf79248
Reviewed-on: https://review.typo3.org/58178
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Move documentation files into 9.4 folder - part 3 66/58166/7
Anja [Mon, 3 Sep 2018 21:07:47 +0000 (23:07 +0200)]
[TASK] Move documentation files into 9.4 folder - part 3

The change also contains some documentation related improvements
in some code files, where the need occured.

Change-Id: I346fd70e20bd0765ac4cc663dc7e3fd73d02651b
Resolves: #86075
Releases: master
Reviewed-on: https://review.typo3.org/58166
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Do not double-prepend the URL scheme on preview URLs 77/58177/2
Benni Mack [Tue, 4 Sep 2018 09:19:15 +0000 (11:19 +0200)]
[BUGFIX] Do not double-prepend the URL scheme on preview URLs

When having a pseudo-site the view functionality is broken
due to some different handling how to deal with protocols.

Resolves: #86134
Releases: master
Change-Id: Ia3b08ce968ecfdce631ce9c7ff9c973cfb25eef5
Reviewed-on: https://review.typo3.org/58177
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Wrap error UnknownElement with proper HTML 73/58173/3
Georg Ringer [Tue, 4 Sep 2018 05:41:27 +0000 (07:41 +0200)]
[TASK] Wrap error UnknownElement with proper HTML

Show the error with a proper markup. Also hightlight type and
render type as code.

Resolves: #86133
Releases: master, 8.7
Change-Id: I79323aaff834c47e6ff875f8a584b2c88f42c51d
Reviewed-on: https://review.typo3.org/58173
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Allow getPagesTSconfig to be called without BE_USER 74/58174/2
Benni Mack [Tue, 4 Sep 2018 07:08:19 +0000 (09:08 +0200)]
[BUGFIX] Allow getPagesTSconfig to be called without BE_USER

Due to refactorings lately in BackendUtility::getPagesTSconfig() with
which results in a fatal error when clearing page cache while persisting an
extbase object.

The patch adds a test without a Backend User, and encapsulates this
with a simple if() statement. However, this also shows that some
other areas that are touched are not fully notice-free / strict, which
are tackled as well.

Resolves: #85310
Releases: master
Change-Id: I0f1318d395451e704e1783e841d96583efe2a560
Reviewed-on: https://review.typo3.org/58174
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Abort `nodeSelectedAfter` on unchecked nodes 36/57836/4
Andreas Fernandez [Wed, 8 Aug 2018 20:39:41 +0000 (22:39 +0200)]
[BUGFIX] Abort `nodeSelectedAfter` on unchecked nodes

If a node in the page tree is clicked, the `nodeSelectedAfter` event is
triggered for any active node that is being deactivated.

The event listener is now aborted if the event is called on a unchecked
node.

Resolves: #85787
Releases: master
Change-Id: I4fa5bbc4290b5ffd2ecb77a901dceb042dff3d27
Reviewed-on: https://review.typo3.org/57836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Tested-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[BUGFIX] Template module must respect workspaces 71/58171/2
Andreas Fernandez [Mon, 3 Sep 2018 21:50:12 +0000 (23:50 +0200)]
[BUGFIX] Template module must respect workspaces

The template module now respects the workspace constraint of the current
backend user and the stored sys_template records.

Resolves: #86131
Releases: master, 8.7
Change-Id: I0463844c4222957aede4b4ca749a3368cb399f81
Reviewed-on: https://review.typo3.org/58171
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Make debug exceptions scrollable in backend context 72/58172/2
Benjamin Kott [Mon, 3 Sep 2018 22:02:40 +0000 (00:02 +0200)]
[BUGFIX] Make debug exceptions scrollable in backend context

Resolves: #86132
Releases: master
Change-Id: I34a09ec83491b0f08e0a094680fbd93057ad76a4
Reviewed-on: https://review.typo3.org/58172
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[BUGFIX] Use same height for tree bar as for the right module 67/58167/3
Georg Ringer [Mon, 3 Sep 2018 21:17:10 +0000 (23:17 +0200)]
[BUGFIX] Use same height for tree bar as for the right module

Fix 1px off error in page tree toolbar.

Resolves: #86098
Releases: master
Change-Id: Ia1476d57b935159fc32e40a9134c7c7a1e9a6ef3
Reviewed-on: https://review.typo3.org/58167
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] use gmmktime in checkConditionMatcherForDateFunction unit test 65/58165/2
Jigal van Hemert [Mon, 3 Sep 2018 20:58:40 +0000 (22:58 +0200)]
[BUGFIX] use gmmktime in checkConditionMatcherForDateFunction unit test

The arguments are now treated as parts of a UTC date/time and
prevents different results depending on the system date.timezone
settings.

Releases: master
Resolves: #86128
Change-Id: Ieb336ea43eb246ec0e0c5a7db8194c03a0801f83
Reviewed-on: https://review.typo3.org/58165
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[BUGFIX] Ensure slug update wizard uses proper sorting 53/58153/2
Benni Mack [Mon, 3 Sep 2018 19:06:22 +0000 (21:06 +0200)]
[BUGFIX] Ensure slug update wizard uses proper sorting

If two subpages share the same name, it is important, that the first
page gets a proper name, and the second one follows the uniqueInSite pattern.

Also, sorting by workspaces (live first), PID and then sorting seems to be
just logical. I wonder why I did not add this before.

Resolves: #86120
Releases: master
Change-Id: I53f279034c2c61a31b50fc973721827f0c2685ba
Reviewed-on: https://review.typo3.org/58153
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Ensure version placeholders get updated on slug changes 50/58150/3
Oliver Hader [Mon, 3 Sep 2018 18:46:26 +0000 (20:46 +0200)]
[TASK] Ensure version placeholders get updated on slug changes

This change ensures that workspace version placeholders are kept
in sync when slug values (TCA type 'slug') are modified in their
specific workspace version. This is done implicitly without the
requirement to define shadowColumnsForNewPlaceholders in TCA.

Resolves: #86117
Releases: master
Change-Id: I11baab1e2154b5f3a043a29c08617c0ad360226a
Reviewed-on: https://review.typo3.org/58150
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Resolve workspace records for template module overview 82/57982/5
Oliver Hader [Tue, 21 Aug 2018 10:45:20 +0000 (12:45 +0200)]
[BUGFIX] Resolve workspace records for template module overview

BackendWorkspaceRestriction automatically resolves specific records
already for a given workspace. In most cases this seems to be fine to
omit the usual workspace overlay processing. However, especially when
dealing with references and page tree assignments, it just contains
wrong information.

For instance all workspace versions have the `pid` column set to -1
which of course cannot be resolved as valid page then.

Resolves: #85917
Releases: master, 8.7
Change-Id: Ibe20037b25770bea8f58d1a8bba785ca43ac26cb
Reviewed-on: https://review.typo3.org/57982
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Create root page with slug field filled on installation 62/58162/2
Benni Mack [Mon, 3 Sep 2018 20:19:43 +0000 (22:19 +0200)]
[BUGFIX] Create root page with slug field filled on installation

The root page should contain as best practice the "/" as slug,
after a successful installation.

Resolves: #86125
Releases: master
Change-Id: I2dced238f3482564f4c23fae6c191b68fc500b8e
Reviewed-on: https://review.typo3.org/58162
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Remove console.log() on wizard execution 63/58163/2
Andreas Fernandez [Mon, 3 Sep 2018 20:43:01 +0000 (22:43 +0200)]
[BUGFIX] Remove console.log() on wizard execution

Resolves: #86127
Releases: master
Change-Id: I2b900305cb505c52886b012d7d9a3303f6a0a233
Reviewed-on: https://review.typo3.org/58163
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[BUGFIX] Create proper FE links in Web->View module 57/58157/7
Christian Kuhn [Mon, 3 Sep 2018 19:40:11 +0000 (21:40 +0200)]
[BUGFIX] Create proper FE links in Web->View module

Resolves: #86124
Releases: master
Change-Id: Icb706e585af8e0c0acd993f15d17276024bc5503
Reviewed-on: https://review.typo3.org/58157
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Declare strict types in SlugEnricher 51/58151/2
Andreas Fernandez [Mon, 3 Sep 2018 19:03:57 +0000 (21:03 +0200)]
[BUGFIX] Declare strict types in SlugEnricher

Resolves: #86118
Related: #85937
Releases: master
Change-Id: Id913e98e360d06f8db61bbde8c49a131715f2240
Reviewed-on: https://review.typo3.org/58151
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Auto-generate slug when invalid characters are given 55/58155/2
Benni Mack [Mon, 3 Sep 2018 19:14:45 +0000 (21:14 +0200)]
[BUGFIX] Auto-generate slug when invalid characters are given

If a page title is like "!!!" this currently results in an invalid slug.

The generator now auto-generates something with "default-hashXYZ"
in order to always be unique on creation time.

Resolves: #86122
Releases: master
Change-Id: I453e2155c29f1bde4d05d481e0ae43913bc5ad8b
Reviewed-on: https://review.typo3.org/58155
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Cast return value of getLivePageUid to int 52/58152/2
Susanne Moog [Mon, 3 Sep 2018 19:02:47 +0000 (21:02 +0200)]
[BUGFIX] Cast return value of getLivePageUid to int

On database systems like sqlite fields like uid or
t3ver_oid are returned as string and need to be casted.

This casting has been added in PreviewUriBuilder
->getLivePageUid.

Resolves: #86119
Releases: master
Change-Id: I7fec760b0aee749e72a640488e1021681471c9ec
Reviewed-on: https://review.typo3.org/58152
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[TASK] Deprecate class AltPageTitleProvider 54/58154/3
Richard Haeser [Mon, 3 Sep 2018 19:13:05 +0000 (21:13 +0200)]
[TASK] Deprecate class AltPageTitleProvider

Because the usage of $GLOBALS['TSFE']->altPageTitle is deprecated
since version 9 and will be removed in version 10, the whole class
can be deprecated.

Resolves: #86121
Releases: master
Change-Id: Ifc846550d1132ac15e35fcd7e0357a45c015ee53
Reviewed-on: https://review.typo3.org/58154
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[TASK] Cleanup PageTitle API 56/58156/2
Richard Haeser [Mon, 3 Sep 2018 19:18:27 +0000 (21:18 +0200)]
[TASK] Cleanup PageTitle API

Some small indentation fixes.

Resolves: #86123
Releases: master
Change-Id: Idd5cc7f9cb206516930e5a888449d1204ee9ae11
Reviewed-on: https://review.typo3.org/58156
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[BUGFIX] Avoid database upgrade failures when adding slug field 46/58146/5
Oliver Hader [Mon, 3 Sep 2018 17:19:04 +0000 (19:19 +0200)]
[BUGFIX] Avoid database upgrade failures when adding slug field

When upgrading with e.g. MSSQL it should be noted, that the
pages.slug DB field should be a varchar database field (instead of
"text"), which can be null, allowing the field to be created when
upgrading an instance, without having the upgrade wizard run yet.

So all slug fields are set to null, and can be ommitted correctly.

Resolves: #86116
Releases: master
Change-Id: Iedf62d1a145c25d0ecbc9e25c163255173cdb2d7
Reviewed-on: https://review.typo3.org/58146
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[TASK] Revert "Move LocalConfiguration* files to config folder" 47/58147/4
Benni Mack [Mon, 3 Sep 2018 17:36:42 +0000 (19:36 +0200)]
[TASK] Revert "Move LocalConfiguration* files to config folder"

This reverts commit 277c677a967fcca5a158042465bfe35da9a3fa15.

This change was meant as a pre-cursor to the new config handling,
which needs some more thoughts on how to deal with AdditionalConfiguration.php
in the future, and is reverted for the time being.

Resolves: #86115
Reverts: #84623
Releases: master
Change-Id: Ib46666856b3ed797f574f10f2af024d29bdad956
Reviewed-on: https://review.typo3.org/58147
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[TASK] Switch UserStorageCapabilityService to a renderType 41/58141/4
Christian Kuhn [Mon, 3 Sep 2018 14:16:34 +0000 (16:16 +0200)]
[TASK] Switch UserStorageCapabilityService to a renderType

Using a TCA type=user with a custom renderType is much more
elegant since the registered element can then fully access
$this->data and has control of node expansion and all the
other goodies that come with own renderType in comparison
to the shabby limited type=user with userFunc.
The patch switches the 'is_public' type=user userFunc to
a proper renderType and fixes the incomplete HTML of this
field along the way.
Note a type=check with own renderType is not possible in
this case since the config has no items array.

Resolves: #86109
Releases: master
Change-Id: I72507a4660fc64e5c2df60768564a788a4c38a05
Reviewed-on: https://review.typo3.org/58141
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Use SiteLanguage in forms 69/57969/5
Julian Wundrak [Mon, 3 Sep 2018 07:27:26 +0000 (09:27 +0200)]
[BUGFIX] Use SiteLanguage in forms

TranslationService of forms only respect language sets in TypoScript.
Use SiteLanguage is the leading configuration and TypoScript as
fallback.

Resolves: #85909
Releases: master
Change-Id: I961161434e38916e8885af883523eff98f0b467c
Reviewed-on: https://review.typo3.org/57969
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Julian Wundrak <julian@wundrak.net>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Ensure that slugs are always calculated in DataHandler 98/58098/14
Oliver Hader [Sun, 2 Sep 2018 21:19:52 +0000 (23:19 +0200)]
[BUGFIX] Ensure that slugs are always calculated in DataHandler

When NOT using FormEngine to create a new page (e.g. in the pagetree
or via the "Create multiple pages" wizard), so just using DataHandler
magic is uttermost critical that a slug is always created, to ensure
the "uniqueInSite" functionality, and to access a page, even though
the page was created after the upgrade wizard has run.

Resolves: #86050
Resolves: #85937
Releases: master
Change-Id: I9eff3385c369a04a6f5a33d0b840b6a2b698891c
Reviewed-on: https://review.typo3.org/58098
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Only unlock records in BE user log off functionality 45/58145/5
Benni Mack [Mon, 3 Sep 2018 16:53:04 +0000 (18:53 +0200)]
[BUGFIX] Only unlock records in BE user log off functionality

The database table `sys_lockedrecords` should only be cleared via
the BackendUtility when a Backend user is logging off. Currently, this
is also called for Frontend Users, which actually removes everything
from the currently logged-in backend users with the same uid.

As this is very bad code design on many levels (lockRecords for
unlocking, no context for the authentication user object etc), this
should be encapsulated within the BackendUser object directly anyway.

For further abstractions, this could also be a hook or something else,
to be even cleaner.

Resolves: #86113
Releases: master, 8.7
Change-Id: I44d91064edb6ec9ef4c148e48b67bdf22da38869
Reviewed-on: https://review.typo3.org/58145
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Avoid suffixing base slug again 44/58144/4
Oliver Hader [Mon, 3 Sep 2018 16:51:35 +0000 (18:51 +0200)]
[BUGFIX] Avoid suffixing base slug again

When invoking slug generation on an empty or base slug (`/`), the
slug will become `//` - which is invalid and has to be avoided.

Resolves: #86114
Releases: master
Change-Id: I66aac94ec9be7992376806d59b7c3ef1bd0e142a
Reviewed-on: https://review.typo3.org/58144
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Suffix all interfaces with Interface 43/58143/3
Benni Mack [Mon, 3 Sep 2018 15:54:38 +0000 (17:54 +0200)]
[BUGFIX] Suffix all interfaces with Interface

The patch introducing interfaces for upgrade wizards had some mixed
namings, which are now corrected.

Resolves: #86112
Releases: master
Change-Id: I5ada026d00f9482b1c89fed63cb40a9ba6fb790e
Reviewed-on: https://review.typo3.org/58143
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Add missing documentation for typolink.language 42/58142/4
Benni Mack [Mon, 3 Sep 2018 15:19:41 +0000 (17:19 +0200)]
[TASK] Add missing documentation for typolink.language

The newly added functionality for typolink.language
within TypoScript receives a documentation file.

Resolves: #86057
Releases: master
Change-Id: I87031125f879950f926e118bf4b4bcc5a068f39f
Reviewed-on: https://review.typo3.org/58142
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Adjust LinkGeneratorTest for non-site scenario 40/58140/6
Oliver Hader [Mon, 3 Sep 2018 10:34:20 +0000 (12:34 +0200)]
[TASK] Adjust LinkGeneratorTest for non-site scenario

When using a Site according "slug" values have to be given in order to
have complete routing information. There won't be pages in sites that
explicitly have empty slugs.

Test cases for sites having slugs are available in
SlugLinkGeneratorTest.  In order to test legacy behavior without having
sites and slugs, the scenario of LinkGeneratorTest has been adjusted
accordingly.

Resolves: #86104
Releases: master
Change-Id: Iea57e62311fc663df772c12530a0c4d4c84aee0f
Reviewed-on: https://review.typo3.org/58140
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Add details to message for existing record localization 86/57586/5
Mathias Brodala [Fri, 13 Jul 2018 13:30:38 +0000 (15:30 +0200)]
[TASK] Add details to message for existing record localization

Resolves: #85549
Releases: master
Change-Id: I8a98da8842c6d15175debed5513bbc4bc2bb0a2c
Reviewed-on: https://review.typo3.org/57586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Fix migration docs for "language:update" command 39/58139/2
Mathias Brodala [Mon, 3 Sep 2018 12:31:15 +0000 (14:31 +0200)]
[BUGFIX] Fix migration docs for "language:update" command

Also add an example how to pass in multiple language ISO codes
which was done using commas back then and now using spaces.

Resolves: #85694
Related: #82315
Releases: master
Change-Id: I4088b6d313c90e5d882db243ea134250690808cf
Reviewed-on: https://review.typo3.org/58139
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Cleanup UpgradeWizard API 28/58128/10
Susanne Moog [Sun, 2 Sep 2018 15:50:06 +0000 (17:50 +0200)]
[TASK] Cleanup UpgradeWizard API

The upgrade wizard API has been in need of some cleanups
both architectural as well as functional. As a result the
API is now easier to use and more streamlined, and
commands available can also be listed.

Resolves: #86106
Resolves: #86101
Releases: master
Change-Id: I1b5eb3459f0650ac1ed9e85718bfa34eb07e403d
Reviewed-on: https://review.typo3.org/58128
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Allow page links to different languages within a site 08/58108/13
Benni Mack [Fri, 31 Aug 2018 20:57:58 +0000 (22:57 +0200)]
[BUGFIX] Allow page links to different languages within a site

Due to the refactoring process within links to a site, it is still
necessary to link to a translated page with a given "&L=" parameter.
This parameter is resolved, and a link to a page translation
is generated.

Fixes menu generation and typolink with the generated page title.

Resolves: #86067
Releases: master
Change-Id: I3e1208a2cdb438c68d4ed3dac1d0274ce07395dc
Reviewed-on: https://review.typo3.org/58108
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months agoRevert "[BUGFIX] Update all languages with CLI command" 37/58137/7
Mathias Brodala [Mon, 3 Sep 2018 11:16:38 +0000 (13:16 +0200)]
Revert "[BUGFIX] Update all languages with CLI command"

This change was not necessary since multiple values can be passed in
separated by spaces instead of commas just like any other Symfony command.

Example:

    bin/typo3 language:update de ja

This reverts commit f612f2e575feeedfaa8bf1b9db043344e0f015b6.

Change-Id: Ie87d8245082613b4185b859f635bf712094ca914
Resolves: #85694
Releases: master
Reviewed-on: https://review.typo3.org/58137
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Remove edit link to not existing record 38/58138/2
Anja [Mon, 3 Sep 2018 11:18:16 +0000 (13:18 +0200)]
[BUGFIX] Remove edit link to not existing record

As long as there is no site configuration record to edit,
the title displayed into Sites Module should not carry a link.

Change-Id: I3c177d4ba889a224577ab53c4d2350e04d57049e
Resolves: #86105
Relates: #86069
Releases: master
Reviewed-on: https://review.typo3.org/58138
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Update all languages with CLI command 86/57786/2
Guido Schmechel [Thu, 2 Aug 2018 21:26:16 +0000 (23:26 +0200)]
[BUGFIX] Update all languages with CLI command

Now it is possible to pass several Isocodes comma separated
by CLI and to update them.

Releases: master
Resolves: #85694
Change-Id: I1a618d6ed8c3abda650995d5d7d1eb523cff1bc1
Reviewed-on: https://review.typo3.org/57786
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Add more info about custom finishers to docs 02/57702/5
Susanne Moog [Fri, 27 Jul 2018 14:52:32 +0000 (16:52 +0200)]
[TASK] Add more info about custom finishers to docs

Resolves: #86103
Releases: master
Change-Id: I485ba2eb933734220381a66256d337ab9f3997ec
Reviewed-on: https://review.typo3.org/57702
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Do not fetch type=none fields from db in list module 33/58133/3
Christian Kuhn [Mon, 3 Sep 2018 00:48:04 +0000 (02:48 +0200)]
[BUGFIX] Do not fetch type=none fields from db in list module

A type=none TCA field is the only field type that is entirely ignored
by DataHandler. An incoming value for such a field is discarded in
checkValue_SW() method and not persisted to db.
The list and query modules should not try to fetch this field type
from database, and a type=none field should not be selectable in
list module single table view.
If a field exists in db and should just be formatted and displayed
readOnly, type=input with readOnly=true is a better option.

Resolves: #86092
Releases: master
Change-Id: Ie3b8e966de66bfd7820b6a17853d4ad591480502
Reviewed-on: https://review.typo3.org/58133
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Move documentation files into 9.4 folder - part 2 31/58131/5
Anja [Sun, 2 Sep 2018 18:29:24 +0000 (20:29 +0200)]
[TASK] Move documentation files into 9.4 folder - part 2

The change also contains some documentation related improvements
in some code files, where the need occured.

Change-Id: I2f587b405fea331c2e73342c879a4a20a5133351
Resolves: #86075
Releases: master
Reviewed-on: https://review.typo3.org/58131
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Set indexed_search set_id field from type=none to input readOnly 34/58134/2
Christian Kuhn [Mon, 3 Sep 2018 01:41:27 +0000 (03:41 +0200)]
[TASK] Set indexed_search set_id field from type=none to input readOnly

The indexed_search_config field set_id can be easily switched from
type=none to type=input with readOnly=true. This is semantically
more correct since the field does have a db representation and
is just meant to be not editable.

Resolves: #86093
Releases: master
Change-Id: I0cd5b7ab778a80aa9baaa4cf31089e90f3a86602
Reviewed-on: https://review.typo3.org/58134
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Make type=passthrough a formEngine element 35/58135/3
Christian Kuhn [Mon, 3 Sep 2018 02:42:02 +0000 (04:42 +0200)]
[TASK] Make type=passthrough a formEngine element

To be more consistent and have one special case less,
type=passthrough columns are now casual elements that
go through the NodeFactory of FormEngine just as all
other types.

Resolves: #86094
Releases: master
Change-Id: I08df7a15101aa8835cf3f1da9b8eb389add2c96e
Reviewed-on: https://review.typo3.org/58135
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Streamline PHPDoc comment matches function/method signature 29/58129/4
Wouter Wolters [Sun, 2 Sep 2018 16:03:56 +0000 (18:03 +0200)]
[TASK] Streamline PHPDoc comment matches function/method signature

Resolves: #86088
Releases: master
Change-Id: Ia011b8ca85b8665edd80a093844b5a60a5fe2e29
Reviewed-on: https://review.typo3.org/58129
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Do not use empty needle in strpos in SimpleFileBackend 32/58132/3
Jigal van Hemert [Sun, 2 Sep 2018 21:33:59 +0000 (23:33 +0200)]
[BUGFIX] Do not use empty needle in strpos in SimpleFileBackend

This only happens on Windows as the call is inside a condition
that tests for Windows OS.

Releases: master
Resolves: #86091
Change-Id: I0e7801d9e80cf675cc6d99d35cf6dd95c2cace44
Reviewed-on: https://review.typo3.org/58132
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Correct HTML nesting in RadioElement 36/58136/2
Christian Kuhn [Mon, 3 Sep 2018 02:48:54 +0000 (04:48 +0200)]
[BUGFIX] Correct HTML nesting in RadioElement

FormEngine RadioElements misses a closing div.

Resolves: #86095
Releases: master
Change-Id: If7041a4579f811fdd3c234815052762048103f89
Reviewed-on: https://review.typo3.org/58136
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Add missing @return phpDoc tags 27/58127/3
Wouter Wolters [Sun, 2 Sep 2018 15:24:58 +0000 (17:24 +0200)]
[TASK] Add missing @return phpDoc tags

Resolves: #86087
Releases: master
Change-Id: I6451f520eff1ce0281afda61b0c49eafc2a9a8cb
Reviewed-on: https://review.typo3.org/58127
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Remove enm1989/chromedriver dependency 66/57766/6
Christian Kuhn [Wed, 1 Aug 2018 20:41:21 +0000 (22:41 +0200)]
[TASK] Remove enm1989/chromedriver dependency

We don't need chromedriver as dev dependency anymore since
the acceptance tests use selenium via docker nowadays.
Executing ac tests locally will be simplified with another
patch, but using chromedriver is ditched already since
that does not lead to stable tests.

composer remove --dev enm1989/chromedriver

Change-Id: I7af8a1f4ba86ff4058a2726fb74f3d643836f95a
Resolves: #85716
Releases: master
Reviewed-on: https://review.typo3.org/57766
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
8 months ago[BUGFIX] Use runtime cache for getIndpEnv() for results which are NULL 05/58005/4
Michael Stucki [Thu, 23 Aug 2018 13:43:49 +0000 (15:43 +0200)]
[BUGFIX] Use runtime cache for getIndpEnv() for results which are NULL

isset() returns FALSE if a cached result is NULL.
Use array_key_exists() instead.

Resolves: #85946
Related: #69173
Releases: master, 8.7
Change-Id: I32bf695f7778213bacc51ed569250466685f1dac
Reviewed-on: https://review.typo3.org/58005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Cleanup parameter mismatches 23/58123/2
Wouter Wolters [Sun, 2 Sep 2018 10:40:10 +0000 (12:40 +0200)]
[TASK] Cleanup parameter mismatches

Cleanup function calls that use more parameters than their declaration.

Resolves: #86083
Releases: master
Change-Id: Ic662cf71db4262141fe8754346ff45654d26091d
Reviewed-on: https://review.typo3.org/58123
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Use PHP_OS constant instead off php_uname('s') 25/58125/2
Wouter Wolters [Sun, 2 Sep 2018 11:11:02 +0000 (13:11 +0200)]
[TASK] Use PHP_OS constant instead off php_uname('s')

Resolves: #86085
Releases: master
Change-Id: Ida3e389e0d0a1df713aaffcb8ab56756c1454279
Reviewed-on: https://review.typo3.org/58125
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Remove redundant parentheses 22/58122/3
Wouter Wolters [Sun, 2 Sep 2018 10:27:39 +0000 (12:27 +0200)]
[TASK] Remove redundant parentheses

Resolves: #86082
Releases: master
Change-Id: I4698f5f6b2a5b6995588d25b9cac3ec875e15b93
Reviewed-on: https://review.typo3.org/58122
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Cleanup unused PageUriBuilder options 95/58095/3
Benni Mack [Fri, 31 Aug 2018 07:29:35 +0000 (09:29 +0200)]
[TASK] Cleanup unused PageUriBuilder options

Due to the refactoring of the typolink method, the PageUriBuilder
is now only used for links to pages with a site configuration, so it
can be cleaned up.

This a first step in getting the PageUriBuilder API in shape.

As this class is new, and the options and the class is not public
API yet, this removal does not need any docs.

Resolves: #86052
Releases: master
Change-Id: I56205f4e3fec0e68bd317a45ae1d860f8d84a799
Reviewed-on: https://review.typo3.org/58095
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[TASK] Streamline phpDoc order of @param and @var 24/58124/2
Wouter Wolters [Sun, 2 Sep 2018 10:52:59 +0000 (12:52 +0200)]
[TASK] Streamline phpDoc order of @param and @var

Resolves: #86084
Releases: master
Change-Id: I6ebbe0756d799a3c04386c854f6e5e385eeac54f
Reviewed-on: https://review.typo3.org/58124
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Use labels and modal in Site module 21/58121/4
Georg Ringer [Sun, 2 Sep 2018 10:20:21 +0000 (12:20 +0200)]
[TASK] Use labels and modal in Site module

Use labels instead of hardcoded text and a modal
asking users if a site configuration should be really deleted.

Resolves: #86078
Releases: master
Change-Id: I49de820ef5e48f88c6449872cfee2eca617c46eb
Reviewed-on: https://review.typo3.org/58121
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Replace substr(...) with strpos(...) 66/57466/8
Wouter Wolters [Wed, 4 Jul 2018 18:13:44 +0000 (20:13 +0200)]
[TASK] Replace substr(...) with strpos(...)

strpos will use only CPU resources, substr also needs memory allocation.

Resolves: #85477
Releases: master
Change-Id: Ic25c99986f7e2e7237c10acaa75be8d0f6289f13
Reviewed-on: https://review.typo3.org/57466
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Add pdo_sqlite to list of additional PHP extensions 20/58120/4
Michael Schams [Sun, 2 Sep 2018 00:47:54 +0000 (10:47 +1000)]
[TASK] Add pdo_sqlite to list of additional PHP extensions

TYPO3 now supports SQLite as the DBMS, if PHP module "pdo_sqlite" is
installed and enabled in the system. This change adds the module to
the list of "additional PHP extensions" in file INSTALL.md as an
optional component.
Another outdated line is removed with the patch.

Resolves: #86079
Releases: master
Change-Id: Ic91166e0482bbb80b02937361e2863e9199cae67
Reviewed-on: https://review.typo3.org/58120
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Michael Schams <typo3@2018.schams.net>
Tested-by: Michael Schams <typo3@2018.schams.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[TASK] Link site title in sites module 07/58107/3
Georg Ringer [Fri, 31 Aug 2018 20:21:45 +0000 (22:21 +0200)]
[TASK] Link site title in sites module

To keep the module in sync with the regular list module
the title must be linked as well.

Resolves: #86069
Releases: master
Change-Id: Ice88210c3b532118295238209d799e619408c70f
Reviewed-on: https://review.typo3.org/58107
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[FEATURE] Add hreflang support 05/58105/12
Kevin Appelt [Fri, 31 Aug 2018 15:56:43 +0000 (17:56 +0200)]
[FEATURE] Add hreflang support

This feature adds an hreflang tag for multilanguage-websites (one-tree)
automatically, based on the new LanguageMenuProcessor.

The href is relative as long as the domain is the same.
If the domain differs the href become absolute.
x-default href is the first supported language.

Resolves: #75806
Releases: master
Change-Id: I06754f61d7a03f6894001be11c9ce2a37ac2106f
Reviewed-on: https://review.typo3.org/58105
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[TASK] Add recreate button to slug field 19/58119/2
Christian Kuhn [Sat, 1 Sep 2018 21:15:37 +0000 (23:15 +0200)]
[TASK] Add recreate button to slug field

Adds a second button next to the 'manually edit slug' button
in pages: If the title is changed, this button can be used
to recalculate a new slug from the changed title.

Resolves: #86077
Releases: master
Change-Id: I862413423cefa1f391321f6d5e5c3d5dba68397e
Reviewed-on: https://review.typo3.org/58119
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[FEATURE] XML Sitemap 57/58057/26
Richard Haeser [Tue, 28 Aug 2018 05:59:29 +0000 (07:59 +0200)]
[FEATURE] XML Sitemap

It is now possible to generate XML sitemaps for SEO purposes without
using 3rd-party plugins. When enabled, this new feature will create a
sitemapindex with one or more sitemaps in it. Out-of-the-box it will
have one sitemap containing all the pages of the current site and
language. Per site and per language you have the possibility to render
a different sitemap.

Resolves: #84525
Releases: master
Change-Id: Iad74b114b9dd37dbc4dd72e244437691fb8c31b5
Reviewed-on: https://review.typo3.org/58057
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[TASK] Move documentation files into 9.4 folder - part 1 18/58118/4
Anja [Sat, 1 Sep 2018 19:21:41 +0000 (21:21 +0200)]
[TASK] Move documentation files into 9.4 folder - part 1

Change-Id: I95be0b5c33b9f028d28de7be64a7d18f9554ff78
Resolves: #86075
Releases: master
Reviewed-on: https://review.typo3.org/58118
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[FEATURE] New API for UpgradeWizards 14/58114/5
Susanne Moog [Thu, 30 Aug 2018 21:45:52 +0000 (23:45 +0200)]
[FEATURE] New API for UpgradeWizards

Build a new Interface based API for UpgradeWizards that
can be used as a base for future improvements.

Resolves: #86076
Releases: master
Change-Id: Ia059dc295e00f5f39849d8dfbc009bf7d8652aba
Reviewed-on: https://review.typo3.org/58114
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[TASK] Refine DebugExceptionHandler 10/58110/8
Markus Poerschke [Sat, 1 Sep 2018 01:44:13 +0000 (03:44 +0200)]
[TASK] Refine DebugExceptionHandler

* Complete new design for the uncaught exception error page
* Show all exceptions by calling all ->getPreviousException
* Show function / method arguments with more detail
* Show code where exception was thrown

Resolves: #86070
Releases: master
Change-Id: I30bee3384cb1ea025e79246599e488540b10b98c
Reviewed-on: https://review.typo3.org/58110
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Properly create slug if adding new pages via FormEngine 17/58117/2
Christian Kuhn [Sat, 1 Sep 2018 19:06:30 +0000 (21:06 +0200)]
[BUGFIX] Properly create slug if adding new pages via FormEngine

Adding a page relative to another page (vanillaUid is negative then),
currently creates a slug as if the page in inside the related page.
This is because the vanillaUid is given to the JS and later fed to
the ajax slug creator.
Using 'effectivePid' instead which is the parent page uid if a
new page is added, or the uid of the page recod itself if the
page is edited, solves the issue.

Resolves: #86074
Releases: master
Change-Id: Ia3f89f615699d4e7be6bc1762bc95e17cc1939dc
Reviewed-on: https://review.typo3.org/58117
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[FEATURE] Add PageTitle API 81/57881/31
Richard Haeser [Sun, 12 Aug 2018 17:31:24 +0000 (19:31 +0200)]
[FEATURE] Add PageTitle API

It is now possible to set the title tag of a page by using
the PageTitle API. You can register your own providers and
set the priority of the provider so you are in control when
multiple extensions of a page trying to set the title.

Resolves: #85678
Releases: master
Change-Id: I1b0314f96b6af7bdad94b9865d2e2525b715d5c3
Reviewed-on: https://review.typo3.org/57881
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[FEATURE] Add commands for listing and showing sites 04/58104/9
Daniel Goerz [Fri, 31 Aug 2018 14:35:15 +0000 (16:35 +0200)]
[FEATURE] Add commands for listing and showing sites

This patch adds the following CLI commands:
site:list - shows a list of all configured sites
site:show - shows the configuration of a single site

Resolves: #86066
Releases: master
Change-Id: I9bfecceea7a28f81f99373ea847e868289de0c70
Reviewed-on: https://review.typo3.org/58104
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] typo3/testing-framework now flushes runtime caches 08/58008/5
Michael Stucki [Thu, 23 Aug 2018 14:40:50 +0000 (16:40 +0200)]
[TASK] typo3/testing-framework now flushes runtime caches

Unit test tearDown() now always calls
GeneralUtility::flushInternalRuntimeCaches() so most explicit
calls in unit tests can be removed.

composer require --dev typo3/testing-framework:~4.8.2

Resolves: #85948
Related: #85946
Releases: master, 8.7
Change-Id: I798047a06c3265404383540cacbd40d9719e7bfe
Reviewed-on: https://review.typo3.org/58008
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Do not remove LocalConfiguration if executing unit tests 13/58113/3
Christian Kuhn [Sat, 1 Sep 2018 13:04:44 +0000 (15:04 +0200)]
[BUGFIX] Do not remove LocalConfiguration if executing unit tests

Unit test and code for #84623 relies on constants PATH_typo3conf and
then removes LocalConfiguration and some other config files if the
test is executed. Since that can't be mocked, the test is removed
to prevent that side effect.

Resolves: #86072
Related: #84623
Releases: master
Change-Id: I3cd9a913e2655e6fcd1209fcfd8365cbcbb4a9ef
Reviewed-on: https://review.typo3.org/58113
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Allow config.linkVars to be added for linking to pages with site config 97/58097/2
Benni Mack [Fri, 31 Aug 2018 08:33:14 +0000 (10:33 +0200)]
[BUGFIX] Allow config.linkVars to be added for linking to pages with site config

Due to the refactoring yesterday, the TypoScript option
config.linkVars was removed, but is still a valid use-case to be added.

Resolves: #86054
Releases: master
Change-Id: I6d42c82f474668b62143982b8d9f2adf9b735935
Reviewed-on: https://review.typo3.org/58097
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Single slashes for classes in form docs 86/58086/4
Simon Schaufelberger [Thu, 30 Aug 2018 13:09:10 +0000 (15:09 +0200)]
[TASK] Single slashes for classes in form docs

Use single backslash in code block

Releases: master, 8.7
Resolves: #86039
Change-Id: I9d7755c3f0183f4be47fe227a28ac8e186de60f4
Reviewed-on: https://review.typo3.org/58086
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Correct global/multiple icon in site configuration overview 11/58111/2
Christian Kuhn [Sat, 1 Sep 2018 09:15:59 +0000 (11:15 +0200)]
[BUGFIX] Correct global/multiple icon in site configuration overview

Resolves: #86071
Releases: master
Change-Id: Ie7ded4da5329a82e2e1ef5f5a995b714abd9aa1d
Reviewed-on: https://review.typo3.org/58111
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
8 months ago[BUGFIX] Do not use deprecated class alias anymore 03/58103/2
Benni Mack [Fri, 31 Aug 2018 12:51:05 +0000 (14:51 +0200)]
[BUGFIX] Do not use deprecated class alias anymore

The class TYPO3\CMS\Lang\LanguageService is gone,
and only exists as class alias.

There are a few places where this class is still
used, and they are replaced.

Resolves: #86064
Releases: master
Change-Id: Ie6a9db14d3db9e3949a04f6ec146a006d792ae9f
Reviewed-on: https://review.typo3.org/58103
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[FEATURE] Add inline AJAX validation for TCA type slug 93/57993/21
Benni Mack [Wed, 22 Aug 2018 21:09:19 +0000 (23:09 +0200)]
[FEATURE] Add inline AJAX validation for TCA type slug

The TCA type slug field is "disabled" / "readonly" by default but
actually has a toggle button (like InputLinkField) to enable that field.

For new records it works like this:
- A title is entered, then the slug field gets prefilled "as-you-type"
  and the editor will see the URL directly. There is a check if the
- If a slug is manually entered:
- It is validated by "isUniqueInSite" to see if that slug is still
   free.
- If the slug is already taken, a proposal is shown below the input
   field to use the proposal for the slug. In any case, when saving,
   the same validation process kicks in anyways.

Existing records do not change their slug by changing the page title,
but only if the slug field gets modified directly.

So for existing records, the following use-cases exist, when a slug
gets manually modified:
- If the page slug is already in use, a proposal for another
  available slug is shown.
- If the page has subpages, a warning will be shown that all
  subpages need to be manually modified (not implemented yet)
- If the page slug will be changed on save, a message is shown that you
  should create a redirect (not implemented yet)

Resolves: #85931
Releases: master
Change-Id: Iabb5f02d43463b3a2bb70197cc8c9585bce1d32d
Reviewed-on: https://review.typo3.org/57993
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Missing initialization of typo3/phar-stream-wrapper 69/58069/11
Oliver Hader [Wed, 29 Aug 2018 12:54:50 +0000 (14:54 +0200)]
[BUGFIX] Missing initialization of typo3/phar-stream-wrapper

Functional tests now rely on \TYPO3\CMS\Core\Core\Bootstrap
is setting up the PharStreamWrapper and check that behavior.

Resolves: #86020
Releases: master
Change-Id: I34637eb42d68196b59e311bde975cff002748206
Reviewed-on: https://review.typo3.org/58069
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
8 months ago[BUGFIX] Expression Language should not crash Backend Modules 02/58102/2
Benni Mack [Fri, 31 Aug 2018 12:18:22 +0000 (14:18 +0200)]
[BUGFIX] Expression Language should not crash Backend Modules

When doing "[page["uid"] >= 284]" in a TypoScript condition, everything works
as expected in Frontend, but in BE it gets messy, as "page" HAS to be an array
to allow to validate this, but page does not always exist.

This comes from a wrong spec, claiming that conditionMatcher->getPage() always
returns an array, which is wrong. So let's make the code return an array all the time.

Resolves: #86062
Releases: master
Change-Id: Ia781c84ffa335fce5ba2d67bbe2997ceab5281b4
Reviewed-on: https://review.typo3.org/58102
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
8 months ago[TASK] Add frontend functional tests for pages having slugs 15/58015/17
Oliver Hader [Fri, 31 Aug 2018 07:39:35 +0000 (09:39 +0200)]
[TASK] Add frontend functional tests for pages having slugs

Functional tests for pages having site configuration and using slugs
are introduced. Existing tests (not relying on slugs) are still kept
in addition to the new tests in order to still have tests for legacy
"index.php?id=123" behavior.

Resolves: #85962
Releases: master
Change-Id: I7902bfd028f9c8a1d41f3573d72a2a7e96148b43
Reviewed-on: https://review.typo3.org/58015
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>