Markus Klein [Mon, 5 Jan 2015 15:28:18 +0000 (16:28 +0100)]
[BUGFIX] Linkvalidator: Fix invalid links
Fix the generation of edit links of records to comply with the standards.
Resolves: #64128
Releases: master, 6.2
Change-Id: Ie1fd5a220cf045c1e093c8dfa3ad58f4fa9fd94f
Reviewed-on: http://review.typo3.org/35810
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Georg Ringer [Mon, 5 Jan 2015 15:58:22 +0000 (16:58 +0100)]
[BUGFIX] Redirect to record after creating new root template
After clicking the button "Create template for a new site", the
user is redirected to the new template record.
Resolves: #62195
Releases: master, 6.2
Change-Id: I8d999760f09f5e81a5286a9a3790f6292bf3eb39
Reviewed-on: http://review.typo3.org/35803
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Stephan Großberndt [Fri, 31 Jan 2014 14:21:02 +0000 (15:21 +0100)]
[BUGFIX] Center icons vertically again in toolbar of page tree
The task #52497 introduced a regression. The default font-size 12px and
new default line-height of 18px set in body shifts the icons down. This
needs to be reset at least for toolbar icons in xtheme-t3skin.css.
Additionally removed the comment for styles no longer set in the
stylesheet.
Resolves: #55507
Related: #52497
Releases: 6.2
Change-Id: I02faf731ea41ad82338cbfc0b417f715ac0e13c1
Reviewed-on: http://review.typo3.org/35425
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Georg Ringer [Mon, 5 Jan 2015 16:09:21 +0000 (17:09 +0100)]
[BUGFIX] Use correct label in indexed_search template
The used label in the template must be changed to an existing one.
Resolves: #51113
Releases: master, 6.2
Change-Id: I8fbb2e69912a34a5203ca2342b39c94447fd77f7
Reviewed-on: http://review.typo3.org/35793
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Markus Klein [Sat, 3 Jan 2015 15:43:30 +0000 (16:43 +0100)]
[BUGFIX] Display BE layouts in correct order
When using the Languages view in Page module the Backend Layout
columns are now sorted correctly.
Releases: master, 6.2
Resolves: #60389
Change-Id: I74c010512ff405b143352755f8c862a55ef6c391
Reviewed-on: http://review.typo3.org/35757
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
(cherry picked from commit
4b15d478511087237e3789b66d8eee07e3ce2355)
Reviewed-on: http://review.typo3.org/35789
Markus Klein [Mon, 5 Jan 2015 13:33:33 +0000 (14:33 +0100)]
[BUGFIX] Fix error mode handling for lang file inclusion
Releases: master, 6.2
Resolves: #64126
Change-Id: I985cf10a97b742bc5f3357d3822aaa5256ff86e7
Reviewed-on: http://review.typo3.org/35788
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Torben Hansen [Fri, 12 Dec 2014 09:49:12 +0000 (10:49 +0100)]
[BUGFIX] Fixes position of suggest wizzard autocomplete result in IE
A 5 years old bug in script.aculo.us leads to the problem, that
autocomplete results of the suggest wizzard are displayed at a
wrong position for Internet Explorer browsers. Depending on the
screen resolution, the autocomplete results may even be out of the
visual area of the users screen.
Since script.aculo.us seems to be unmaintained, the patch is directly
applied to the script.aculo.us source files, so we at least can
provide a bugfix for TYPO3 users using Internet Explorer.
This patch also fixes an IE fix in script.aculo.us. Instead of using
javascript:false we now use about:blank as source for the IE fix
iframe, which prevents the text “false” being displayed when
autocompletion results appear in IE.
Resolves: #63604
Releases: master, 6.2
Change-Id: Ib0421a308bb0652b9aed8be73ab6c78900ebe13d
Reviewed-on: http://review.typo3.org/35786
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Benjamin Mack [Sun, 4 Jan 2015 15:12:59 +0000 (16:12 +0100)]
[BUGFIX] Return string on non-existent CASE cObject
Currently, when using a TypoScript CASE cObject
and the key property is not available then the default
key is used. If the default key is not existent
a TS warning is thrown. According to the documentation
an empty string should be returned.
Releases: master, 6.2
Resolves: #39772
Change-Id: I2c7872b066523b8075983fb7cabb6821fdfef54d
Reviewed-on: http://review.typo3.org/35784
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Stephan Großberndt [Tue, 9 Dec 2014 12:00:31 +0000 (13:00 +0100)]
[BUGFIX] Speed up BackendUtility->explodeSoftRefParserList
Due to improper checking for an empty array in
BackendUtility->explodeSoftRefParserList multiple trimExplode-calls per
record are executed. Fixing this check leads to an early return and
speeds up bulk inserting.
Resolves: #63674
Releases: master, 6.2
Change-Id: Id8969c33d8ebb109018159ada6a277ab5bfdd13c
Reviewed-on: http://review.typo3.org/35187
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit
522fba7db058c0c2783116d9772c2c2a561b6beb)
Reviewed-on: http://review.typo3.org/35775
Mathias Schreiber [Mon, 29 Dec 2014 08:39:57 +0000 (09:39 +0100)]
[TASK] Performance: Avoid using array_keys in foreach
This lowers the memory usage.
Iterate on the original array instead of an array_keys()-copy
which lowers memory usage and enhances performance.
Change-Id: If65fae1665e242667d621f086a55a22a8d5309ed
Resolves: #64004
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35708
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Wouter Wolters [Sat, 3 Jan 2015 16:35:51 +0000 (17:35 +0100)]
[BUGFIX] Non modules can't check module access
Resolves: #64098
Releases: master, 6.2
Change-Id: Ic71b026e18160fb92c8e215ecf2cfb6c86703661
Reviewed-on: http://review.typo3.org/35761
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Markus Klein [Mon, 8 Dec 2014 01:25:13 +0000 (02:25 +0100)]
[BUGFIX] Fix folder selection in ElementBrowser
Resolves: #63651
Releases: master, 6.2
Change-Id: Ica4b9dab922be15bffd67f1dbd90ea8e4522838d
Reviewed-on: http://review.typo3.org/35760
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Georg Ringer [Sat, 6 Dec 2014 20:34:50 +0000 (21:34 +0100)]
[BUGFIX] Autolink urls starting https:// as well
Currently only non ssl urls are automatically identified
and transformed to a link. Now also links starting with
https:// are identified.
Resolves: #63616
Releases: master, 6.2
Change-Id: I3a35c73263e2248c571ba835212ac59b3d7ec68b
Reviewed-on: http://review.typo3.org/35756
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Anja Leichsenring [Sat, 3 Jan 2015 12:26:26 +0000 (13:26 +0100)]
[BUGFIX] Page View Button misses tooltip in page language module
Add a title attribute to the view page button in page module,
when language mode is active.
Change-Id: I3c991173b2a46e33dcdff5ad6827b4ef6d4dc5fe
Resolves: #64095
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35755
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Mathias Schreiber [Fri, 2 Jan 2015 13:59:29 +0000 (14:59 +0100)]
[BUGFIX] Web->Function: empty frame if all related ext removed
Shows a meaningful error message if a module relies on submodules that
have not been registered yet.
Resolves: #21975
Releases: master, 6.2
Change-Id: Ibaf0ccae2a4d8f2aae066323d58dbacf321d107a
Reviewed-on: http://review.typo3.org/35746
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Markus Klein [Fri, 2 Jan 2015 19:25:47 +0000 (20:25 +0100)]
[!!!][BUGFIX] Respect selected target for shortcut mode 'Parent page'
The selected page is now respected when selecting the parent page
to use. An upgrade wizard ensures that existing shortcuts will not
break by removing the currently selected page.
The 6.2 version of this patch will only adjust the label to not
mention the "selected page" part, so the label matches
the current behaviour.
Change-Id: I51bc9239871d93728e84a4fe2e3b8bc9bb4a7404
Resolves: #57089
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35747
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Christian Ludwig [Wed, 12 Nov 2014 15:12:17 +0000 (16:12 +0100)]
[BUGFIX] Ignore --linebreak-- fields in removeDuplicatesForInsertion
ExtensionManagementUtility::removeDuplicatesForInsertion() ignores
--linebreak-- fields when looking for duplicates.
In addition the method uses less regular expressions to
make it more performant and easier to understand.
Resolves: #57824
Releases: master, 6.2
Change-Id: Ia064abe81501ec4649dc8fb1fe613d5e5497ff9c
Reviewed-on: http://review.typo3.org/35745
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Cornel Boppart [Sun, 26 Oct 2014 19:07:53 +0000 (20:07 +0100)]
[BUGFIX] Fix error in filelist after deleting file with broken refs
Always delete a file with corrupt relations.
Additionally issue a flash message informing about the broken references.
Resolves: #62480
Releases: master, 6.2
Change-Id: I3bfbcc1ec0dae4ebfe8356905ac2f0548bfaa12b
Reviewed-on: http://review.typo3.org/35743
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Benjamin Mack [Fri, 2 Jan 2015 11:04:54 +0000 (12:04 +0100)]
[BUGFIX] csc-uploads delivers broken CSS
In CSS Styled Content the CSS rule
ul.csc-uploads img { float: left; padding-right: 1em; vertical-align: top; }
causes images to be squeezed when they have the
width-attr (default=150, through
tt_content.uploads.20.renderObj.10.file.width) set
because the 1em is calculated inside the given
dimensions. The padding should be changed to
margin, otherwise all images are squeezed
horizontally regardless of the actual
dimension settings.
Releases: master, 6.2
Resolves: #59124
Change-Id: I171e4f3b048f0a0dc05476890d7af6f88c864874
Reviewed-on: http://review.typo3.org/35734
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Benjamin Mack [Fri, 2 Jan 2015 11:38:28 +0000 (12:38 +0100)]
[BUGFIX] sys_file uid should be visible in filelist
There are several cases where editors manually
link to files (<LINK file:123>Download PDF</LINK>),
f.e. in bulletlists, so they need a easy way to
find the uid of a specific file. A good place would
be the mouseover-text of files in the filelist –
like as the pages or tt_content elements have their
uid shown in the element's icon mouseover text.
Resolves: #59866
Releases: master, 6.2
Change-Id: Iec3e5043d01bfb3fac60d738ef7749fc0126c6b2
Reviewed-on: http://review.typo3.org/35733
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Benjamin Mack [Fri, 2 Jan 2015 10:19:21 +0000 (11:19 +0100)]
[BUGFIX] Change fe_users DB field size to 255 chars
When having email addresses as usernames the field
fe_users.username gets too small. Resizing to 255
characters solves a lot of problems. Same goes
for the email field.
Releases: master, 6.2
Resolves: #55484
Change-Id: I03e4fe1228a6b22d24ad222a9fab578059917847
Reviewed-on: http://review.typo3.org/35718
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit
5966dd4b1bdec1c356a96265246a928cc25b72cf)
Reviewed-on: http://review.typo3.org/35721
Torben Hansen [Sun, 14 Dec 2014 11:57:32 +0000 (12:57 +0100)]
[BUGFIX] Fix image rendering for renderMethod = table
Since the introduction of FAL to TYPO3, the rendering of images
using CSS styled content with renderMethod = table is broken.
Using a single image results in the image being rendered twice
and if you have multiple images in one content object, only the
last image is rendered multiple times (depending on the amount
of images in the content object).
This patch resolves both issues and loads the current image file
reference to the contentObjectRenderer while looping through the
images of the content object.
Resolves: #46864
Related: #47004
Releases: master, 6.2
Change-Id: If120267111e30de6438cecc5e14cea34bc6fa235
Reviewed-on: http://review.typo3.org/35704
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Benjamin Mack [Wed, 31 Dec 2014 11:50:46 +0000 (12:50 +0100)]
[BUGFIX] Type check fix in linkhandler link type
To determine if a link should be handled by the linkhandler link type
in the linkvalidator, the "type" entry in the $value array will be
checked instead of the $type variable which is always empty.
Change-Id: I95f39713ddc9c353acef51160892c08aa997b9ed
Resolves: #38639
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35689
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Benjamin Serfhos [Wed, 17 Dec 2014 11:45:56 +0000 (12:45 +0100)]
[BUGFIX] linkvalidator: Add headline fallback to prevent NULL on insert
While link checker adds the broken links in the database the content
element can have an empty header. Make sure the inserted record does
not fail of empty headline.
Change-Id: I9cd750a278fd514f6154659c9c8466c2713adfe7
Resolves: #63952
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35539
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit
e82a7638e2d6d998954a6b8b1024f3bf7a2a3348)
Reviewed-on: http://review.typo3.org/35688
Lorenz Ulrich [Tue, 6 Nov 2012 15:22:46 +0000 (16:22 +0100)]
[BUGFIX] deleteRecord_flexFormCallBack deletes file_references
Files that are referenced in a flexform
<type>group</type><internal_type>file_reference</internal_type>
will be deleted by deleteRecord_flexFormCallBack() in
t3lib_TCEmain, independent of the path or usage by other records.
For normal record fields (e.g. tt_content.images), only file
with the internal_type "file" are deleted. Files of
internal_type "file_reference" are respected and will not be
deleted. There is an appropriate condition in
t3lib_TCEmain::extFileFunctions().
But for flexform fields, this differentiation in handling
between both internal_types is missing.
Therefore using lowlevel_cleaner or the delete option in the
recycler will delete files that may be still in use. The
flexFormCallBack must be changed to delete only files of
internal_type "file".
Change-Id: I8519705f2155bf0d49ae10316c6622f670189e28
Fixes: #40052
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/16239
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit
fd7027708028a8da03e11ea26c20c4a2293ef840)
Reviewed-on: http://review.typo3.org/35687
Georg Ringer [Sun, 3 Nov 2013 13:34:35 +0000 (14:34 +0100)]
[TASK] Add absRefPrefix to responsive images
Responsive images must also use the absRefPrefix
as prefix.
Resolves: #53292
Releases: master, 6.2
Change-Id: I12f4ece9b2dda6fb1f56684aefd4013b4ee907a9
Reviewed-on: http://review.typo3.org/25138
Reviewed-on: http://review.typo3.org/35678
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Wouter Wolters [Tue, 9 Apr 2013 18:35:46 +0000 (20:35 +0200)]
[BUGFIX] Backend typolink fields not saved
Adds a trailing slash on input and a call to onchange for that field.
Change-Id: Ib17216aba9c0190018a44a04e2081cac19c0b84a
Resolves: #25946
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35622
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Frederic Gaus [Sat, 20 Dec 2014 20:12:33 +0000 (21:12 +0100)]
[BUGFIX] Fix notice of ttl of ENABLE_INSTALL_TOOL
This patch fixes the notice of the install tool protection status
in the reports module, which has been accidentally been removed
with #57072
Change-Id: Idfad1340a1bd395b67c9ff2a60fec69e6a0add97
Resolves: #64003
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35616
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Mathias Schreiber [Thu, 18 Dec 2014 09:45:12 +0000 (10:45 +0100)]
[BUGFIX] Prevent double content link checks
When a link points to a content element by using it's anchor behind
the page UID the reference index contains two entries for this link,
one for the linked page and one for the linked content element.
Since the content element is already checked when the page link is
validated by extracting the anchor element from the URL it is not
required to handle any other references than those starting with
"pages:". This prevents content elements from being treated as pages.
Resolves: #50772
Releases: master, 6.2
Change-Id: I5337ea01614eee2228fe09936f49a88b5ea96e5d
Reviewed-on: http://review.typo3.org/35598
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Stephan Großberndt [Wed, 17 Dec 2014 01:19:31 +0000 (02:19 +0100)]
[BUGFIX] Fix fatal in RsaAuth-PhpBackendTest with broken openssl config
If the openssl environment is not set up correctly (in Install Tool:
"PHP OpenSSL extension not working") the unit test
TYPO3\CMS\Rsaauth\Tests\Unit\Backend\PhpBackendTest causes a fatal PHP
error "Call to a member function isReady() on a non-object". This
happens because $this->subject->createNewKeyPair() returns NULL if
something goes wrong while setting up a openssl keypair.
Assert the keypair is not null before calling $keypair->isReady().
Resolves: #63948
Releases: master, 6.2
Change-Id: Iffde2b7eafe160d387568d08f627a2bb9852f32f
Reviewed-on: http://review.typo3.org/35597
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Stephan Großberndt [Fri, 12 Dec 2014 13:58:17 +0000 (14:58 +0100)]
[TASK] Lower memory use in ArrayUtil->mergeRecursiveWithOverrule
Iterate on the original array instead of an array_keys()-copy in
ArrayUtil->mergeRecursiveWithOverrule which lowers memory usage and
enhances performance.
Resolves: #63812
Releases: master, 6.2
Change-Id: I71acc9e1e730f1e782d0e74acd45637ce1b9f08e
Reviewed-on: http://review.typo3.org/35535
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Stephan Großberndt [Tue, 16 Dec 2014 22:42:07 +0000 (23:42 +0100)]
[BUGFIX] Fix failing PHPUnit-Tests on Windows due to uniqid()-calls
If in one test multiple objects are created and their names are created
with uniqid()-calls without params, they fail because they return the
same value.
Using md5(uniqid(microtime(), true)) instead makes object names unique.
Resolves: #63943
Releases: master, 6.2
Change-Id: Ib223d45f04946223c4a8ae9ce68a5c5b24459355
Reviewed-on: http://review.typo3.org/35529
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tim Lochmueller [Sun, 23 Mar 2014 16:48:01 +0000 (17:48 +0100)]
[BUGFIX] Cache backend usernames and workspace titles
Add a runtime cache for improved performance of user and
workspace titles in ext:belog. Those view helpers are
called twice per displayed row and should have a shortcut
if the name resolution was done already.
Resolves: #55653
Releases: master, 6.2
Change-Id: I62465faaebc13ba0dfe781350fa6c87cc87f54a6
Reviewed-on: http://review.typo3.org/35525
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Stephan Großberndt [Tue, 9 Dec 2014 11:29:54 +0000 (12:29 +0100)]
[BUGFIX] Better caching of TCA for bulk inserts
Introduces a runtime cache for the TCA types configuration. This
improves performance for bulk inserts since getTCAtypes is called for
each record of each table and the available types during a call do not
change.
Resolves: #63666
Releases: master, 6.2
Change-Id: Ia58352f1bae1e1eb57b87e5db0f1ad84e34ae37e
Reviewed-on: http://review.typo3.org/35521
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Markus Klein [Tue, 16 Dec 2014 16:20:19 +0000 (17:20 +0100)]
[BUGFIX] Remove calls to StringUtility::beginsWith()
The method does not exist in 6.2. Replace with a call to good old
GeneralUtility::isFirstPartOfString().
Resolves: #63937
Releases: 6.2
Change-Id: I3ee6650b062d2bca251db1993f4a52b8ad0048e0
Reviewed-on: http://review.typo3.org/35520
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Simon Schaufelberger [Thu, 19 Jun 2014 16:42:53 +0000 (18:42 +0200)]
[TASK] Improve error output in TS if INCLUDE_TYPOSCRIPT file not found
The TSOB should show if a file which should be included could not be found.
Due the fact that parts of the TypoScript parser are written with static
methods, the only way is to check the TypoScript lines for the string
"### ERROR".
Resolves: #17090
Releases: master, 6.2
Change-Id: I6679413e9ff7ca027e23e9b2d6927fd95f8f4595
Reviewed-on: http://review.typo3.org/35516
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Georg Ringer [Mon, 15 Dec 2014 19:26:13 +0000 (20:26 +0100)]
[BUGFIX] Unreadable directories must not crash filemount storages
If a *single* directory in the fileadmin tree can't be read, the whole
select box of the file mounts is empty.
Just hide the entry which is not readable
Resolves: #63915
Releases: master, 6.2
Change-Id: I96d5472bb284c259b986b88a766b0fa1e6dfca07
Reviewed-on: http://review.typo3.org/35512
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Georg Ringer [Wed, 22 Oct 2014 14:00:45 +0000 (16:00 +0200)]
[BUGFIX] Show correct default value of field type 'select' and MM relation
Given a field with TCA type "select" and a mm relation,
the selected categories of the default record are not shown
in the translated record.
Reason is because the uid is not transferred to the
BackendUtility::getProcessedValue method.
Resolves: #62397
Releases: master, 6.2
Change-Id: I4c98267e9d246c9b7efeaba2cdcecd7873e9feeb
Reviewed-on: http://review.typo3.org/35498
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Philipp Gampe [Thu, 16 Oct 2014 10:25:26 +0000 (12:25 +0200)]
[BUGFIX] linkvalidator: Fatal error: Call to a member function getUrl()
The external link checker tries to provide detailed information in case
an URL is not accessible. To do this, it analyses the stack trace
provided by the exception.
Replace the stacktrace parsing with a more reliable method by checking
the last event. In case of a loop, the last event contains the response
object in the 'data' key.
Resolves: #62266
Releases: master,6.2
Change-Id: I51aaf3d6af85877541e920afaee76e6cac368e7b
Reviewed-on: http://review.typo3.org/35471
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Mathias Brodala [Tue, 9 Dec 2014 07:59:54 +0000 (08:59 +0100)]
[BUGFIX] Fix new content element wizard links click area
This formats the links within the new content element wizard as
inline-block, thus ensuring the whole link area is clickable.
Resolves: #56063
Releases: master, 6.2
Change-Id: Id5d7e080787d434a89220ce361fb3cf3d911029e
Reviewed-on: http://review.typo3.org/35461
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Dietrich Heise [Wed, 28 May 2014 13:59:01 +0000 (15:59 +0200)]
[BUGFIX] Add case insensitive flag to trustedHostsPattern
Releases: master, 6.2, 4.5
Resolves: #59186
Change-Id: Iaa973faf5b3f287320fb187c3db2d8e30a486735
Reviewed-on: http://review.typo3.org/35444
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Georg Ringer [Sat, 13 Dec 2014 19:07:03 +0000 (20:07 +0100)]
[BUGFIX] Fix "Enable tab" for textareas inside inline elements
If a field is configured in the TCA by using
"'defaultExtras' => 'fixed-font : enable-tab'", the textarea
behaves different (pressing the tab produces a tab).
Since inline elements use AJAX, the js method which changes the behaviour
of the textarea needs to be reapplied.
Resolves: #33731
Releases: master, 6.2
Change-Id: Idbab5092f20675c9b912b80299059a8a0d05c3cb
Reviewed-on: http://review.typo3.org/35430
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Stefan Neufeind [Tue, 14 Feb 2012 12:17:20 +0000 (13:17 +0100)]
[BUGFIX] Allow attribute value "0" in EXT:form elements
If an attribute value of "0" is set in an EXT:form element (e.g.
TEXTLINE) currently the input element in the frontend is rendered with
an empty value "".
Do not check attribute values with empty() to allow "0" values.
Resolves: #31920
Releases: master, 6.2
Change-Id: I624c7da38c23429f68000e085dbd82c23fb7e834
Reviewed-on: http://review.typo3.org/35443
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Georg Ringer [Sat, 13 Dec 2014 23:32:58 +0000 (00:32 +0100)]
[TASK] Improve sorting of usergroups in adminpanel
To improve the usability, the usergroups are ordered by title and
the uid is added at the end to allow working with the keyboard.
Resolves: #17290
Releases: master, 6.2
Change-Id: Ie855a73e81a8b66265d4b94567db088f0991fd5d
Reviewed-on: http://review.typo3.org/35441
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Marco Huber [Mon, 11 Aug 2014 11:17:25 +0000 (13:17 +0200)]
[BUGFIX] Set Ext.SSL_SECURE_URL to prevent https issues in IE
Ext.SSL_SECURE_URL is javascript:false by default. But this throws the error
"SEC7111: HTTPS security is compromised by res://ieframe.dll/dnserrordiagoff.htm"
in IE. To prevent this we can use the clear.gif URL which is a valid
URL and doesn't create too much traffic
Resolves: #60886
Releases: master, 6.2
Change-Id: I618815318aab3f39aaca54e92ebec4f3d79827c4
Reviewed-on: http://review.typo3.org/35428
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Stephan Großberndt [Tue, 9 Dec 2014 14:42:19 +0000 (15:42 +0100)]
[BUGFIX] Better performance of DatabaseConnection->getDateTimeFormats
Currently each call to DatabaseConnection->getDateTimeFormats creates a
new array with default dateTimeFormats. Put this information into a
static class member and return this instead.
Resolves: #63669
Releases: master, 6.2
Change-Id: I457ad6b68fb6919782f349550e9efd07143d0de7
Reviewed-on: http://review.typo3.org/35427
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Markus Klein [Sun, 14 Dec 2014 12:21:36 +0000 (13:21 +0100)]
[TASK] Add note about AdditionalConfiguration.php to Install Tool
Add a note to clarify that AdditionalConfiguration.php is always
overruling any setting made within the Install Tool.
Furthermore we add a note to the ConfigurationManager that it is limited
to Core internal usage only.
Resolves: #60650
Releases: master, 6.2
Change-Id: Icaf7d4b1ce5b14ad0618e38e92a49a33405997f7
Reviewed-on: http://review.typo3.org/35412
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Patrick Broens [Thu, 2 May 2013 12:50:34 +0000 (14:50 +0200)]
[BUGFIX] Form localization depending on old class names
Since the introduction of the PHP namespaces some of the localisation of
FORM is not working anymore. The localisation label is depending on the
class name by using get_class(). The localisation is depending on the
old class names which has not been adapted afterwards.
This patch solves this issue by removing the get_class() calls by
using a constant.
Change-Id: I7ba846620732b61e05e210f227c02b63c1198284
Resolves: #47817
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35401
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Marc Neuhaus [Tue, 21 May 2013 07:49:37 +0000 (09:49 +0200)]
[BUGFIX] Don't override the class on the Form elementWrap
This Changeset fixes an issue, which made it impossible
to give the layout.elementWrap a class attribute, because it
is was simple overridden.
Now it checks if a class is set and appends the default csc-form-*
classes instead of overriding it.
Resolves: #48404
Releases: master, 6.2
Change-Id: I20fec83d28b2e727f268ee00dab830c39c5f15a1
Reviewed-on: http://review.typo3.org/35400
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Anja Leichsenring [Sat, 13 Dec 2014 14:47:17 +0000 (15:47 +0100)]
[TASK] Use better implementation for array check
To suppress PHP warnings the input parameter must always be an array.
If there is nothing to merge, the array_merge_overrule function
must not be called at all.
Change-Id: Ice369449da22ff62c09efa919272195bd141e836
Resolves: #63827
Relates: #63701
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35398
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Stefan Froemken [Tue, 29 Oct 2013 15:50:18 +0000 (16:50 +0100)]
[BUGFIX] Add autocomplete for t3editor FILES
Add autocomplete values for t3editor
because there was no implementation for new cObj FILES
Resolves: #53129
Releases: master, 6.2
Change-Id: Id4c5d7e51850546cb07ae289c96107834b8e7921
Reviewed-on: http://review.typo3.org/35394
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Steffen Müller [Sat, 13 Dec 2014 15:11:31 +0000 (16:11 +0100)]
[TASK] Extbase: Traverse validation results until first error
When deciding whether to call the action method or error method it's
sufficient to traverse results until the first error.
To improve performance break the foreach on first
found (not ignored) error.
Resolves: #63726
Releases: master, 6.2
Change-Id: I988cb5c8ac20518c359db75bb46fe6702c549cf6
Reviewed-on: http://review.typo3.org/35389
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Stefan Froemken [Tue, 9 Dec 2014 09:55:31 +0000 (10:55 +0100)]
[BUGFIX] Ensure argument is an array in ContentObjectRenderer
This patch ensures that at least an empty array is passed to the
array_replace_recursive function to avoid warnings during rendering.
Resolves: #63701
Releases: master, 6.2
Change-Id: I047f45bd5199216aec6f37a0c9b0526c455cad92
Reviewed-on: http://review.typo3.org/35387
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Helmut Hummel [Fri, 5 Dec 2014 23:51:44 +0000 (00:51 +0100)]
[CLEANUP] Clarify configuration preset description
The description of the configuration preset in
install tool is a bit misleading which causes people
to confuse this with the Application Context feature.
Remove the mentioning of application context from context preset
and move it to the top.
Releases: 6.2, master
Resolves: #63622
Change-Id: I8acc9032333f0ead6a35c2c7202a07d2668e7c51
Reviewed-on: http://review.typo3.org/35386
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Jochen Rau [Tue, 27 Nov 2012 01:07:01 +0000 (02:07 +0100)]
[BUGFIX] noTrimWrap = | || won't work inside a menu
The issue is caused by the implementation of optionSplit. This patch
solves this issue by checking for noTrimWrap.
Change-Id: I1d2a6705b679c2d11433902ca992bc907e520228
Fixes: #20793
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/7255
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit
4c95e01d44485e67a322bde8dc8d1c703782587a)
Reviewed-on: http://review.typo3.org/35375
Markus Klein [Fri, 12 Dec 2014 10:12:46 +0000 (11:12 +0100)]
[BUGFIX] Always disable jumpurl for external media
We always disable the global jumpurl feature when retrieving the URL for
an external media element like a video.
Resolves: #63807
Releases: master, 6.2
Change-Id: I3c108f4366869e39423bf1121ee7dfa125148a2a
Reviewed-on: http://review.typo3.org/35372
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Andreas Lappe [Mon, 28 Jul 2014 22:06:48 +0000 (00:06 +0200)]
[BUGFIX] Make filter respect hidden directories
Make the filename filter respect files in hidden directories,
so that files inside those are not indexed by default.
Resolves: #60649
Releases: master, 6.2
Change-Id: Ia0306cb8996964c4998d9d69b526c3d6a8da2ace
Reviewed-on: http://review.typo3.org/31889
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Kjeld Schumacher [Wed, 8 Aug 2012 18:53:19 +0000 (20:53 +0200)]
[BUGFIX] Fix gifbuilder imagesize calculation when condition is used
Change-Id: Ia3adede080a9d405dad17b670a7033bc6715a847
Fixes: #39625
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/13530
Reviewed-on: http://review.typo3.org/35371
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Stephan Großberndt [Tue, 9 Dec 2014 13:52:26 +0000 (14:52 +0100)]
[BUGFIX] Better performance for bulk inserts without static_write
In DataHandler->fillInFieldArray for every record to insert or update
current and new data are merged to be handed over to the static_write
functionality. If this functionality is disabled (which is the
default) the merged data is discarded again.
Checks if the static_write functionality is enabled and merges data
only if it is enabled. This drastically lowers memory usage for bulk
operations.
In master, the static_write functionality was removed completely,
for 6.2 the performance of this code section is improved.
Resolves: #63668
Releases: 6.2
Change-Id: I625a771a98a5f79bab3a8d22464895fcbdcf4068
Reviewed-on: http://review.typo3.org/35370
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Stanislas Rolland [Thu, 30 Oct 2014 02:34:49 +0000 (22:34 -0400)]
[BUGFIX] Click-enlarge problem when an image is inside ul li or ol li
lib.parseFunc_RTE is not correctly configured by css_styled_content.
ul and ol elements must be recursively parsed through lib.parseFunc_RTE
(not lib.parseFunc). li element must be included in
nonTypoTagStdWrap.encapsLines.encapsTagList so that unwrapped content
of li elements is not wrapped in paragraphs.
Releases: master, 6.2
Resolves: #61954
Change-Id: I916b385d32a11909f7c0b9b9458d86237da1be1b
Reviewed-on: http://review.typo3.org/33614
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Stephan Großberndt [Thu, 11 Dec 2014 15:13:14 +0000 (16:13 +0100)]
[!!!][TASK] Remove words and words_strings from ReferenceIndex
In ReferenceIndex->generateRefIndexData the strings from all input and
text fields were collected in $this->word_strings. But the array was
never accessed.
While both properties were removed in master, the 6.2 backport keeps
the properties, but does not fill word_strings anymore, so the patch
is less breaking but the performance improvement is still given.
Resolves: #63780
Releases: master, 6.2
Change-Id: I56d6a3e615cab44cbecff5a7d4dec42a1da29fc6
Reviewed-on: http://review.typo3.org/35349
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Stephan Großberndt [Wed, 10 Dec 2014 16:58:29 +0000 (17:58 +0100)]
[BUGFIX] Do not execute getDateTimeFormats for each input
Fetches the dateTimeFormats only for date- and datetime-fields instead
of unconditionally for each input.
Resolves: #63745
Releases: master, 6.2
Change-Id: I18fcdb8a991ebb82891d9da06a4ef2b01fbc104f
Reviewed-on: http://review.typo3.org/35320
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Stephan Großberndt [Thu, 11 Dec 2014 14:32:07 +0000 (15:32 +0100)]
[BUGFIX] Do not fetch TSconfig in process_datamap for non-page-records
In DataHandler->process_datamap for each record getTCEMAIN_TSconfig()
is executed, but the returned TSconfig is used only if table is "pages"
and status is "new".
Fetches the TSconfig only if table is "pages" and status is "new".
Resolves: #63778
Releases: master, 6.2
Change-Id: Ifded6daf2b5b6b61a9c95ba3962566450a07d72e
Reviewed-on: http://review.typo3.org/35318
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Helmut Hummel [Thu, 4 Dec 2014 22:44:40 +0000 (23:44 +0100)]
[BUGFIX] Allow recursive folder deletion
Remove the useless check for the number of existing
files in the ExtendedFileUtility.
We now let FAL try to delete recursively by default.
It will tell us, if the permissions do not suffice
for the current user.
Resolves: #63580
Releases: master, 6.2
Change-Id: Iec7ab95d493ce3594a4131b45e5bcb77de9e21b6
Reviewed-on: http://review.typo3.org/35317
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Markus Klein [Thu, 11 Dec 2014 16:17:23 +0000 (17:17 +0100)]
Revert "[BUGFIX] Fix broken form wizard with MSIE"
This reverts commit
0f1a9aa3c9dd7d710ecd8bf9a57d51a304bc2337.
The D&D functionality for fieldsets is broken.
Change-Id: I79c5e92dd8d80a1af1b665fb3df522f5503006bf
Reverts: #59305
Resolves: #63767
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35312
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Tymoteusz Motylewski [Fri, 20 Jun 2014 15:13:30 +0000 (17:13 +0200)]
[BUGFIX] Add more entropy to uniqid
uniqid() generates values based on current time,
subsequent calls may return the same value on a fast machine.
On Windows it's even worse, as uniqid()
has single-second-resolution out of the box.
Right now it is used in many places in the core,
also for creating temporary identifiers
for newly created records (in the datahandler).
The solution is to add a second parameter to
all calls (which adds more entropy).
see http://php.net/manual/en/function.uniqid.php
To make code consistent, this change adds the
second parameter to all occurences of uniqid.
Resolves: #59701
Resolves: #58602
Resolves: #59055
Releases: master, 6.2
Change-Id: Id791556d45b4289d75411ff19ae050144fbfe51b
Reviewed-on: http://review.typo3.org/33328
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Stephan Großberndt [Tue, 9 Dec 2014 11:17:15 +0000 (12:17 +0100)]
[BUGFIX] Memory consumption in DataHandler->processClearCacheQueue
Reduce memory consumption in DataHandler->processClearCacheQueue() for
bulk inserts by filling $tagsToClear as an associative array instead of
a normal array with array_unique()-call after each added record.
Resolves: #63615
Releases: master, 6.2
Change-Id: I74bef31fcf1f08665e51cee7efe847e32f501ef2
Reviewed-on: http://review.typo3.org/35232
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Alexander Stehlik [Tue, 9 Dec 2014 00:11:29 +0000 (01:11 +0100)]
[BUGFIX] Placeholder attribute without useOrOverridePlaceholder
The placeholder configuration for a TCA field will now be considered
independently from the "mode" being set to "useOrOverridePlaceholder".
If a placeholder is set in the TCA it will be rendered. The mode
setting only changes the behavior of the NULL checkbox.
Resolves: #59129
Releases: master, 6.2
Change-Id: Ice7681d644623a5e94cbdd22743ddf5aab8919a9
Reviewed-on: http://review.typo3.org/35175
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
TYPO3 Release Team [Wed, 10 Dec 2014 10:45:38 +0000 (11:45 +0100)]
[TASK] Set TYPO3 version to 6.2.10-dev
Change-Id: Ifed9c7aafda0c22185ed97301811c115cb5c4b43
Reviewed-on: http://review.typo3.org/35229
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
TYPO3 Release Team [Wed, 10 Dec 2014 10:45:08 +0000 (11:45 +0100)]
[RELEASE] Release of TYPO3 6.2.9
Change-Id: Ic2992ee3e513ffe74d6ba55d8d1fafbb9783ad36
Reviewed-on: http://review.typo3.org/35228
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
Helmut Hummel [Wed, 10 Dec 2014 10:07:58 +0000 (11:07 +0100)]
[!!!][SECURITY] Fix link spoofing in prefixLocalAnchors
Specially crafted request could lead to anchors prefixed
with URLs to domains controlled by the attacker on the
domain root page (home page). No other pages are affected!
Fix this by prefixing the anchors with a canonical URL
to the current request. This could lead to the situation
that the prefix does not match the current REQUEST_URI
which leads to a page reload instead of just "jumping" to the page section.
Additionally this change assures that REQUEST_URI always starts
with a slash, which mitigates similar attack vectors when using
getIndpEnv('REQUEST_URI')
To mitigate the impact of this breaking change, the REQUEST_URI
is used for anchor prefix if a backend user is logged in,
to not disturb the preview functionality of the home page.
In case prefixLocalAnchors is used in the HTML parser configuration
with prefixLocalAnchors = 2, always the canonical URL is used as prefix.
This change does *not* fix, that arbitrary (non functional) GET parameters
will be included in the generated prefix URL. To fix this it is recommended
to use absRefPrefix instead of baseUrl and prefixLocalAnchors.
Resolves: #62723
Releases: 4.5, 6.2, master
Security-Commit:
404fe57aefb1ffbbf8a918d4805f97055a78f160
Security-Bulletin: TYPO3-CORE-SA-2014-003
Change-Id: Icb07584bb1366d895a502b1ef7584593e2b6681a
Reviewed-on: http://review.typo3.org/35223
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Oliver Hader [Wed, 10 Dec 2014 09:33:59 +0000 (10:33 +0100)]
Revert "[BUGFIX] Memory consumption in DataHandler->processClearCacheQueue"
This reverts commit
31518c96e9c705a91898cce009d7f47be238bce7.
Change-Id: I64053da1d04716679c9e7227a9d6885ccd047fdb
Reviewed-on: http://review.typo3.org/35221
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Stephan Großberndt [Tue, 9 Dec 2014 11:17:15 +0000 (12:17 +0100)]
[BUGFIX] Memory consumption in DataHandler->processClearCacheQueue
Reduce memory consumption in DataHandler->processClearCacheQueue() for
bulk inserts by filling $tagsToClear as an associative array instead of
a normal array with array_unique()-call after each added record.
Resolves: #63615
Releases: master, 6.2
Change-Id: I1f557f435088cab3aa928ec3f44b0ded9265d7a7
Reviewed-on: http://review.typo3.org/35211
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
TYPO3 Release Team [Mon, 8 Dec 2014 14:19:21 +0000 (15:19 +0100)]
[TASK] Set TYPO3 version to 6.2.9-dev
Change-Id: Ib74e8729774357fcf758ea4beb14fe45ef30aba9
Reviewed-on: http://review.typo3.org/35161
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
TYPO3 Release Team [Mon, 8 Dec 2014 14:18:51 +0000 (15:18 +0100)]
[RELEASE] Release of TYPO3 6.2.8
Change-Id: I6854ba7093276dee590132c85013b18cf25ad5a9
Reviewed-on: http://review.typo3.org/35160
Reviewed-by: TYPO3 Release Team <typo3v4@typo3.org>
Tested-by: TYPO3 Release Team <typo3v4@typo3.org>
Sascha Egerer [Wed, 2 Jul 2014 07:07:58 +0000 (09:07 +0200)]
[BUGFIX] Render favicon tag only if file exists
The favicon defined by `page.shortcutIcon`
creates a <link rel="icon"> tag in the frontend.
This tag should only be renderd if the defined
icon exists.
Resolves: #24481
Releases: master, 6.2
Change-Id: Ia266c730c0ea517b03d6666502b68f41efaf1304
Reviewed-on: http://review.typo3.org/35157
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Oliver Hader [Mon, 8 Dec 2014 09:28:05 +0000 (10:28 +0100)]
[BUGFIX] Tiny syntax errors in jsfunc.inline.js
Resolves: #63660
Releases: 6.2
Change-Id: I5f2a28addbf7716af01730159657ce2874ee9392
Reviewed-on: http://review.typo3.org/35156
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Alexander Opitz [Thu, 4 Dec 2014 15:38:51 +0000 (16:38 +0100)]
[BUGFIX] Follow up: Escape element ID before used in jQuery selector
Resolves: #62676
Related: #62001
Releases: 6.2
Change-Id: I50b1e24159ad79174a12f3b5130e1bfd8e77e8a5
Reviewed-on: http://review.typo3.org/34874
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Markus Klein [Mon, 8 Dec 2014 01:10:37 +0000 (02:10 +0100)]
[BUGFIX] Properly define constant in CliBootstrap
Resolves: #63649
Releases: master, 6.2
Change-Id: I17dc3b8e868c1b49511fd5e039f8e37bd9d91a55
Reviewed-on: http://review.typo3.org/35154
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Stephan Großberndt [Sat, 6 Dec 2014 22:48:57 +0000 (23:48 +0100)]
[BUGFIX] Better caching of TSconfig in BackendUtility for bulk inserts
Changes the cache of pageTSconfig from creating a cached entry for each
page to creating a cached entry for each different TSconfig (including
userTSconfig) and a hash-cache for each page instead.
Resolves: #63629
Releases: master, 6.2
Change-Id: I3e4c70cd46cec26dda8574c058d828ec2e22a385
Reviewed-on: http://review.typo3.org/35145
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Zbigniew Jacko [Sat, 8 Feb 2014 12:01:26 +0000 (13:01 +0100)]
[FEATURE] Column of extension's last update
Add column 'Last Updated' in Extension Manager.
Resolves: #32436
Releases: master,6.2
Change-Id: Ib29a7c5ed8008d63cc2d7c5df170f71b2a1c399b
Reviewed-on: http://review.typo3.org/35143
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Paul Golmann [Wed, 20 Aug 2014 15:00:24 +0000 (17:00 +0200)]
[TASK] feedit: Bring back editNoPopup
* Restore edit_editNoPopup/forceNoPopup TSConfig options removed in #49640
* Initialize frontend editing when displayFieldEditIcons is set
Releases: master, 6.2
Resolves: #61095
Related: #43447
Related: #49640
Change-Id: I900a62b447a1a67265ce22cd73e150646344e090
Reviewed-on: http://review.typo3.org/35142
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Tim Lochmueller [Wed, 11 Sep 2013 12:54:29 +0000 (14:54 +0200)]
[BUGFIX] No RTE Transformation for subtype_value_field-fields of plugins
The RTE transformation depends on the result of BackendUtility
getTCAtypes. If the RTE field is in the subtypes_addlist of a plugin
the transformation is not performed. The patch adds the related
subtype fields to the return value.
Resolves: #51901
Releases: 6.2, master
Change-Id: I8bba3d03b5187b06fec5a9b5a0e151466d814d60
Reviewed-on: http://review.typo3.org/35139
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Tim Lochmueller [Thu, 13 Mar 2014 23:38:14 +0000 (00:38 +0100)]
[BUGFIX] orphan_records show extension manager tables
Configure the extension manager tables for a valid
orphan_records check in the lowlevel cleaner. Allow
the records on the root level.
Resolves: #55893
Releases: 6.2, 6.1
Change-Id: I0a00e329fbc56e80b07b452b533c6cf2b877019c
Reviewed-on: http://review.typo3.org/35138
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Helmut Hummel [Sun, 7 Dec 2014 12:16:38 +0000 (13:16 +0100)]
[CLEANUP] Fix return type of PathUtility::stripPathSitePrefix
Resolves: #63646
Releases: 6.2, master
Change-Id: I86279aec51fcc9ffa9a720463acdc48c92d2ba15
Reviewed-on: http://review.typo3.org/35133
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Christian Kuhn [Sat, 6 Dec 2014 12:04:18 +0000 (13:04 +0100)]
[TASK] Update to phpunit 4.4
As notable feature the new assertArraySubset() can be used
to compare sub array parts.
Change-Id: I981fe50652a8685410bd4101d72ad5dec9257bf5
Releases: 6.2, master
Resolves: #63625
Reviewed-on: http://review.typo3.org/35102
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Alexander Stehlik [Fri, 5 Dec 2014 17:59:36 +0000 (18:59 +0100)]
[BUGFIX] Redirect on direct access to overlaid mountpoint
When the user directly accesses a page that is a mountpoint that
should be overlaid with the contents of the mounted page, he will
be redirected to the target page within the mounpoint context.
Releases: master, 6.2
Resolves: #59382
Change-Id: Ie00c8210b39d2934b410d782799e4fc90efa8c5c
Reviewed-on: http://review.typo3.org/34458
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Helmut Hummel [Thu, 27 Nov 2014 22:14:45 +0000 (23:14 +0100)]
[BUGFIX] Properly check permissions with read only file mounts
Previously the permission check returned false if the
file or folder was within a read only file mount, but
also within a writable file mount.
Properly check this now and centralize the check in
isWithinFileMountBoundaries, which now has an additional
argument whether write access to file mounts should be checked or not.
Resolves: #63364
Related: #49391
Releases: master, 6.2
Change-Id: If90958b7d6e4d5aad1fbd172af06462ca2b9764f
Reviewed-on: http://review.typo3.org/34964
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Björn Fromme [Thu, 4 Dec 2014 13:48:16 +0000 (14:48 +0100)]
[BUGFIX] Ignore non-integer values for type in redirects
For redirects the parameter for page type is not validated as integer
resulting in invalid redirect urls. This patch checks for a valid integer
value and ignores it silently otherwise.
Resolves: #62527
Releases: master, 6.2
Change-Id: I9fd4564a3e4e13e4d64e27e090221e71edf06ae9
Reviewed-on: http://review.typo3.org/34193
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Nicole Cordes [Sat, 15 Nov 2014 00:24:24 +0000 (01:24 +0100)]
[BUGFIX] Exclude CDATA from t3lib_parsehtml->XHTML_clean
Due to commit https://review.typo3.org/#/c/30240/ the comments from
javascript is removed and now the javascript is parsed with
config.xhtml_cleaning = all. This patch prevents any CDATA content from
being parsed.
Resolves: #62967
Releases: master, 6.2, 4.5
Change-Id: Ib024c5c8f2b056e47d9222b9767b7a5e6923af8c
Reviewed-on: http://review.typo3.org/34192
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Markus Klein [Thu, 4 Dec 2014 10:43:28 +0000 (11:43 +0100)]
[BUGFIX] Hide empty settings in user settings
This ensures normal users do not see the "Admin functions" tab.
Releases: #63558
Resolves: 6.2
Change-Id: Ieee76e86ff35d7b8ffd64edbb004075d621e3b27
Reviewed-on: http://review.typo3.org/35026
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Stefan Weißwange [Sat, 8 Nov 2014 18:28:59 +0000 (19:28 +0100)]
[BUGFIX] Linkvalidator: Improve tolerance on HEAD-request error
Force second URL-request if first response had an HTTP-status-code
which indicates a client-error (4xx) or a server-error (5xx).
Resolves: #58145
Releases: master, 6.2
Change-Id: I5cb02a6345494ffbe23caba652628b91812aea37
Reviewed-on: http://review.typo3.org/35025
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Stefan Neufeind [Thu, 4 Dec 2014 01:21:19 +0000 (02:21 +0100)]
[FOLLOWUP][BUGFIX] objectManager->create is removed but still in use
Change-Id: I8aa8502a4a4188f2e665848745daccb75bca30c0
Resolves: #63552
Releases: 6.2
Reviewed-on: http://review.typo3.org/35019
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Markus Klein [Thu, 4 Dec 2014 01:15:05 +0000 (02:15 +0100)]
[FOLLOWUP][BUGFIX] Allow frontend requests from different document root
Fix broken unit test
Resolves: #63025
Releases: master, 6.2
Change-Id: I4c98bedb53cc83ffd1ddc18adfa8e383028704d4
Reviewed-on: http://review.typo3.org/35018
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Helmut Hummel [Mon, 17 Nov 2014 10:57:37 +0000 (11:57 +0100)]
[BUGFIX] Allow frontend requests from different document root
With a specially prepared index.php and using a page renderer hook
it is in general possible to deliver frontend requests
from a dedicated web folder.
However there are a few (hard coded) issues in TYPO3 which makes
this impossible.
Change GeneralUtility::getIndpEnv('TYPO3_SITE_URL') to check for
a TYPO3_PATH_WEB constant defined in a specially prepared index.php
in a "Web/" folder and provide the fluid stand alone view with
an absolute path (which is meant like that in the API anyways).
This change has no impact on a TYPO3 installation with a traditional
directory structure, but enables users to have a more secure setup
in an appropriate environment.
Resolves: #63025
Releases: 6.2, master
Change-Id: I571ceb6224c8030d1f5f99a45903cda3a8171313
Reviewed-on: http://review.typo3.org/34288
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Wouter Wolters [Wed, 3 Dec 2014 18:46:17 +0000 (19:46 +0100)]
[BUGFIX] objectManager->create is removed but still in use
Resolves: #63552
Releases: master, 6.2
Change-Id: I09f238b89c00cd0b6150a0f8763848b9da2f0f99
Reviewed-on: http://review.typo3.org/35015
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Andreas Fernandez [Wed, 3 Dec 2014 15:04:31 +0000 (16:04 +0100)]
[TASK] Remove unselected languages in LocalConfiguration
If selecting one ore more languages in EXT:lang, the complete
language tree is written in EXTCONF/lang/availableLanguages in
LocalConfiguration.php. Empty values in this array represent
unselected languages. This patch removes the empty values
from the language array.
Resolves: #63546
Releases: master, 6.2
Change-Id: I327f05c16f3824f1c91c8f2e095c5b5059b420b9
Reviewed-on: http://review.typo3.org/35011
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Dmitry Dulepov [Fri, 22 Feb 2013 09:16:34 +0000 (13:16 +0400)]
[BUGFIX] GeneralUtility::getUrl() fails to process redirects sometimes
If PHP's open_basedir is active, CURLOPT_FOLLOWLOCATION will be disabled
by PHP. In such case any redirects will not work. This causes problems
with extensions that fetch pages of the site and hit redirects. For
example, if the site uses http and parts of it use https, extensions
like "pagepath" or "solr" will not be able to work with "secondary"
protocol.
Change-Id: I2d9e50d2d00e4c8b0c930a929be7884fd0215c21
Resolves: #45741
Releases: 6.2, master
Reviewed-on: http://review.typo3.org/34306
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Steffen Müller [Mon, 24 Nov 2014 10:44:03 +0000 (11:44 +0100)]
[BUGFIX] Fix option to disable direct file upload
Direct file uploads for FAL fields can be disabled
with ...['appearance']['fileUploadAllowed'] = FALSE
Resolves: #63286
Releases: master, 6.2
Change-Id: I8fd6bd7ab385ba8acc4c7d18fb38507dc8689dbc
Change-Id: Ic93ec8047d2db9205fdf10bb4bce63b1559ca728
Reviewed-on: http://review.typo3.org/34979
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Philipp Kitzberger [Tue, 15 Jul 2014 08:15:42 +0000 (10:15 +0200)]
[TASK] TS path next to error msg in obj-browser
This outputs the TS path next to the error message in the object browser
when clicking on a node in the TS tree and not having a TS record on that
page.
Resolves: #60322
Releases: master, 6.2
Change-Id: I5c4243de851cb906b16d94d1f6ce114b4c9174c8
Reviewed-on: http://review.typo3.org/34963
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>