Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Fields of type group file are not properly indexed 10/27310/10
Marc Bastian Heinrichs [Mon, 3 Feb 2014 22:52:43 +0000 (23:52 +0100)]
[BUGFIX] Fields of type group file are not properly indexed

If an record with a field of type "group", internal_type "file"
should be indexed in the ReferenceIndex an SQL error exception
gets thrown. So the relation to the file isn't represented in the
refindex. Thus those files are also missing in exports created
with system extension impexp.

This is caused by wrong array keys and incorrectly storing a file
relation as DB relation since merge of FAL.

Resolves: #56353
Resolves: #56352
Releases: 6.2, 6.1, 6.0
Change-Id: I78211efcb6bf3032811ef0b0e20ed7f98f9fa8fb
Reviewed-on: https://review.typo3.org/27310
Tested-by: Sebastian Fischer
Tested-by: Christian Zenker
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Ext:rtehtmlarea entry scripts cleanup 08/28208/3
Nicole Cordes [Sun, 9 Mar 2014 23:06:09 +0000 (00:06 +0100)]
[TASK] Ext:rtehtmlarea entry scripts cleanup

This patch turns all remaining RTE module scripts (mod4, mod5, mod6)
into CSRF protected wizards.

Resolves: #55674
Releases: 6.2
Change-Id: I8421ff05240f6eedcaf40c805d9dd92ea7d4c30b
Reviewed-on: https://review.typo3.org/28208
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Cleanup EXT:cshmanual 03/28303/7
Wouter Wolters [Wed, 12 Mar 2014 16:48:47 +0000 (17:48 +0100)]
[BUGFIX] Cleanup EXT:cshmanual

* Removed require_once which is deprecated.
* Introduced a use-statement for GeneralUtility
* Removed TYPO3_MOD_PATH
* Links generated by make_seeAlso() were double htmlspecialchars
  encoded after security patch https://review.typo3.org/27636

Resolves: #56826
Related: #55509
Releases: 6.2
Change-Id: I8effc7c6bf9828dde4f1c69754b207864b3122ba
Reviewed-on: https://review.typo3.org/28303
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Avoid superfluous IRRE child record duplication 52/26552/4
Alexander Stehlik [Mon, 23 Dec 2013 16:47:20 +0000 (17:47 +0100)]
[BUGFIX] Avoid superfluous IRRE child record duplication

If copying a page, all records on that page will be copied to
the accordant destination page. IRRE parent-child structures
are cloned along the way as well. However, if a table (that is
defined a IRRE child) is processed before the accordant parent
record, the parent itself will duplicate its children again.
This behaviour leads to superfluous duplicates and is wrong.

A check in DataHandler::copyRecord_procBasedOnFieldType() now
ensures that records are only copied once during the accordant
DataHander copy process.

Resolves: #44795
Releases: 6.2
Change-Id: Ia1e4129432f37c0dd6bfedb5fd69394e2c244d34
Reviewed-on: https://review.typo3.org/26552
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years agoRevert "[TASK] Declare getThisScript() in ElementBrowser as public" 78/28478/3
Markus Klein [Mon, 17 Mar 2014 19:44:45 +0000 (20:44 +0100)]
Revert "[TASK] Declare getThisScript() in ElementBrowser as public"

This reverts commit b2756fe7826d62fdc8442c887010890c268eabd8

A comment of Helmut Hummel was suggested, which was still missing.
This change will be repushed.

Releases: 6.2
Change-Id: I518af35f562350f9dde39678de52f69d58344677
Reviewed-on: https://review.typo3.org/28478
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Declare getThisScript() in ElementBrowser as public 37/28337/3
Georg Ringer [Thu, 13 Mar 2014 10:19:23 +0000 (11:19 +0100)]
[TASK] Declare getThisScript() in ElementBrowser as public

To make work in hooks easier, the method should be public

Resolves: #56721
Releases: 6.2
Change-Id: Ib0a0f17d5f9384a04a125ef08a079f4c272eddae
Reviewed-on: https://review.typo3.org/28337
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Avoid reference index records for images in RTE fields 92/28292/7
Marc Bastian Heinrichs [Mon, 17 Mar 2014 16:37:10 +0000 (12:37 -0400)]
[BUGFIX] Avoid reference index records for images in RTE fields

Since images in RTE fields are handled as relations to sys_file
records adding references to the reference index for the concrete
image paths are obsolete and causes trouble with impexp.

Resolves: #56811
Releases: 6.2
Change-Id: I26a2531f417ff8b628b69156a3a2236c99960d5e
Reviewed-on: https://review.typo3.org/28292
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Update $GLOBALS['TYPO3_LOADED_EXT'] on package change 59/28459/3
Alexander Opitz [Mon, 17 Mar 2014 10:44:26 +0000 (11:44 +0100)]
[BUGFIX] Update $GLOBALS['TYPO3_LOADED_EXT'] on package change

If a package is (un)installed we need to update
$GLOBALS['TYPO3_LOADED_EXT']. ExtensionManagementUtility depends on
the actuality of this array.

Resolves: #56978
Releases: 6.2
Change-Id: I969b84a624a6a9f74b87fdd85b9c4c3a7b49750a
Reviewed-on: https://review.typo3.org/28459
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[FEATURE] Show PHP Errors after checking compatibility of extensions 98/28298/4
Daniel Siepmann [Wed, 12 Mar 2014 13:59:51 +0000 (14:59 +0100)]
[FEATURE] Show PHP Errors after checking compatibility of extensions

The errors are logged in another log file and loaded as json afterwards.

Change-Id: I63458c0a4f64e6d8f4236667b6d22ff6b50aa1f3
Resolves: #51362
Releases: 6.2
Reviewed-on: https://review.typo3.org/28298
Reviewed-by: Tomita Militaru
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
5 years ago[BUGFIX] Order storages in treeview by name 02/28402/2
Frans Saris [Fri, 14 Mar 2014 21:07:51 +0000 (22:07 +0100)]
[BUGFIX] Order storages in treeview by name

The storages can not be ordered manualy and in list view they
are by default ordered by name.
But in the tree views (file module, element browser) there is
no ordering set.

This change sets the default ordering to name when the storageRowCache
is initialised.

Resolves: #56824
Releases: 6.2
Change-Id: I8e879920bc6da14156ce486b8c25b1b8820f896b
Reviewed-on: https://review.typo3.org/28402
Reviewed-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Reviewed-by: Christoph Lehmann
Tested-by: Christoph Lehmann
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Tests: Reduce unit test bootstrap 49/28449/3
Christian Kuhn [Sun, 16 Mar 2014 17:12:44 +0000 (18:12 +0100)]
[TASK] Tests: Reduce unit test bootstrap

The patch further reduces the unit test bootstrap: ext_localconf
of extensions is not loaded anymore and the cache framework is
no longer initialized. A test with incommplete mocking in this area
is fixed along the way.
Furthermore the core exception handling is no longer initialized,
so it does not depend on configuration options. A warning
triggered by a unit test will now reliable let the test fail.

Change-Id: I659441482a19eb6b434d520ecded6df8f5086820
Resolves: #51436
Related: #56967
Releases: 6.2
Reviewed-on: https://review.typo3.org/28449
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Finalize skinning of Sys_Note (Web>List & Web>Page) 05/28405/3
Felix Kopp [Fri, 14 Mar 2014 21:54:35 +0000 (22:54 +0100)]
[TASK] Finalize skinning of Sys_Note (Web>List & Web>Page)

Brings last styles according to layout defined by the UX team.

Resolves: #56960
Related: #26796
Releases: 6.2
Change-Id: Ie1c4bc57343555edac66362100a6ec659d953173
Reviewed-on: https://review.typo3.org/28405
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Tests: Remove extbase BaseTestCase 45/28445/3
Christian Kuhn [Sun, 16 Mar 2014 14:34:53 +0000 (15:34 +0100)]
[TASK] Tests: Remove extbase BaseTestCase

Lots of unit tests did inherit from extbase BaseTestCase. Meanwhile
all code of this abstract was merged to ext:core UnitTestCase and
with the refactoring of the core unit test boostrap the objectManager
that is still in this class does not work anymore.
The class is now removed, but since this is probably used in some
third party extensions, it is set as class alias to ext:core
UnitTestCase and marked as deprecated in a lecagy file, so IDEs
hint developers about this deprecation.

Change-Id: I31fb337e065aed7f03351cb04e13c68a98c93a34
Resolves: #56963
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28445
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Inherit from UnitTestCase in ext:extbase 41/28441/2
Christian Kuhn [Sun, 16 Mar 2014 13:51:22 +0000 (14:51 +0100)]
[TASK] Inherit from UnitTestCase in ext:extbase

Changes class inheritance from ext:exbase BaseTestCase
to ext:core UnitTestCase in ext:extbase

Change-Id: If2d2afbc05765b3ff1d8fa3fded17e6fb0eecd44
Resolves: #56961
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28441
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Tests: Inherit from UnitTestCase in ext:fluid 40/28440/4
Christian Kuhn [Sun, 16 Mar 2014 12:48:24 +0000 (13:48 +0100)]
[TASK] Tests: Inherit from UnitTestCase in ext:fluid

Changes class inheritance from ext:exbase BaseTestCase
to ext:core UnitTestCase in ext:fluid

Change-Id: I46667d9cb5a56f5bc29c4f2c3525c6556d5f802f
Resolves: #56958
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28440
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Tests: Do not extend from extbase BaseTestCase 34/28434/2
Christian Kuhn [Sun, 16 Mar 2014 01:00:07 +0000 (02:00 +0100)]
[TASK] Tests: Do not extend from extbase BaseTestCase

Changes all extensions except extbase and fluid to extend
from extbase ext:core UnitTestCase instead of ext:extbase
BaseTestCase.

Change-Id: Ifbb1542546f2622ece11471fd057ec469518488a
Resolves: #56949
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28434
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove renamed language command controller 33/28433/2
Ernesto Baschny [Sun, 16 Mar 2014 00:31:32 +0000 (01:31 +0100)]
[TASK] Remove renamed language command controller

Follow-up to 0d69c2d9e7b89ea63522d0b5e54aadf20ec1245d.

The renamed language command controller (language:update) was introduced
in 6.2, so we can simply remove the original name instead of deprecating
it.

This will only affect installations which are already using this task
since 6.2 alpha2.

Resolves: #54128
Releases: 6.2
Change-Id: Id6bb709bd30c9044c949c431aa2a595c1035c601
Reviewed-on: https://review.typo3.org/28433
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Set TYPO3 version to 6.2-dev 39/28439/2
TYPO3 Release Team [Sun, 16 Mar 2014 03:45:58 +0000 (04:45 +0100)]
[TASK] Set TYPO3 version to 6.2-dev

Change-Id: I58d0d08817eab7c2490d7dc65fad562ef436f402
Reviewed-on: https://review.typo3.org/28439
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.0beta7 38/28438/2 TYPO3_6-2-0beta7
TYPO3 Release Team [Sun, 16 Mar 2014 03:45:12 +0000 (04:45 +0100)]
[RELEASE] Release of TYPO3 6.2.0beta7

Change-Id: I7b0377514e702f15372338474753c2c2018b6c05
Reviewed-on: https://review.typo3.org/28438
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Check extensions in Install Tool broken 37/28437/2
Ernesto Baschny [Sun, 16 Mar 2014 03:07:23 +0000 (04:07 +0100)]
[BUGFIX] Check extensions in Install Tool broken

Since merging of 64c46b918ef016bdd1d799c5ca06e868d601f692, TYPO3_LOADED_EXT
is no longer an ArrayAccess but a regular array (like pre 6.2). This leaded
to an error in the Extension Manager important action "Check Extension",
causing an endless loop.

Catchable fatal error: Argument 2 passed to
TYPO3\CMS\Install\Controller\Action\Ajax\ExtensionCompatibilityTester
::loadExtLocalconfForExtension() must implement interface ArrayAccess,
array given

Resolves: #56952
Releases: 6.2
Change-Id: I02e83a8221653d62010952f84c17a8f6f6e185ea
Reviewed-on: https://review.typo3.org/28437
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Add htmlspecial to ShowPic file properties 36/28436/2
Ernesto Baschny [Sun, 16 Mar 2014 02:25:22 +0000 (03:25 +0100)]
[TASK] Add htmlspecial to ShowPic file properties

Follow-up to 2a85eeb6d623e74955703b254e24b958790c9a45

Resolves: #56723
Releases: 6.2
Change-Id: Ib3881b7be6f3cf87c0bc36a8a32fedcf2fa53029
Reviewed-on: https://review.typo3.org/28436
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Fix resource handling in image rendering 05/28305/4
Alexander Stehlik [Wed, 12 Mar 2014 17:41:37 +0000 (18:41 +0100)]
[BUGFIX] Fix resource handling in image rendering

The image rendering configuration of css_styled content is fixed so
that the image reference is correctly passed on through all further
methods.

The IMG_RESOURCE content object also accepts file or file reference
objects and will only pass on the file to TemplateService::getFileName()
if GIFBUILDER is used to prevent PHP warnings.

This fixes the image rendering after the imageLinkWrap function was
made FAL aware in #56723.

Releases: 6.2
Resolves: #56825
Change-Id: Ie6b0261de40b25aab26740b4d889a1eebc3e7a8c
Reviewed-on: https://review.typo3.org/28305
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Additional margin on top of ExtJS context menus 35/28435/2
Ernesto Baschny [Sun, 16 Mar 2014 01:07:05 +0000 (02:07 +0100)]
[BUGFIX] Additional margin on top of ExtJS context menus

Resolves: #56950
Releases: 6.2
Change-Id: I936f75be45447111083b9f5cae2e88d3fac1d2c5
Reviewed-on: https://review.typo3.org/28435
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Tests: Do not initialize TYPO3_DB in unit tests 32/28432/3
Christian Kuhn [Sat, 15 Mar 2014 23:19:00 +0000 (00:19 +0100)]
[TASK] Tests: Do not initialize TYPO3_DB in unit tests

Change-Id: I9d147353411314416cdf1f5196d18a127e8c5145
Resolves: #56948
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28432
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Incomplete mock of $GLOBALS['TYPO3_DB'] 31/28431/3
Christian Kuhn [Sat, 15 Mar 2014 22:52:05 +0000 (23:52 +0100)]
[BUGFIX] Tests: Incomplete mock of $GLOBALS['TYPO3_DB']

Still some unit tests rely on TYPO3_DB, mostly through the extbase
object manager. The patch fixes most occurrences and skips two
complex tests that should be moved to functional tests later.

This should be the final patch for tests accessing TYPO3_DB.

Change-Id: I8deb0fb9c13b47c8ce4262f041744def9e6b0e79
Resolves: #56947
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28431
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Improve performance of Bootstrap/PackageManager 29/28329/7
Thomas Maroschik [Sat, 15 Mar 2014 12:41:04 +0000 (13:41 +0100)]
[TASK] Improve performance of Bootstrap/PackageManager

This patch is a combined patch which tries to address
the findings from the Bootstrap/PackageManager/ClassLoader
performance analysis.

Resolves: #56934
Resolves: #56310
Resolves: #56331
Resolves: #56341
Resolves: #56538
Releases: 6.2
Change-Id: I269159906534f58eff59973ab30e170fadac10e4
Reviewed-on: https://review.typo3.org/28329
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Ensure cache clearing is done properly by EM 72/28372/8
Markus Klein [Thu, 13 Mar 2014 23:22:58 +0000 (00:22 +0100)]
[BUGFIX] Ensure cache clearing is done properly by EM

This fixes problems with access to classes from ext_localconf
files that were discarded from the classes cache at the wrong
time.

Resolves: #54906
Releases: 6.2
Change-Id: Icf650261a5ed72c36d332e3407ababf627968ab2
Reviewed-on: https://review.typo3.org/28372
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Tests: Replace objectManager with mock in ext:extbase 21/28421/5
Anja Leichsenring [Sat, 15 Mar 2014 15:25:22 +0000 (16:25 +0100)]
[BUGFIX] Tests: Replace objectManager with mock in ext:extbase

The usage of native objectManager in Extbase' BaseTestClass introduces
a dependency to the systems database. In order to reduce the unit test
bootstrap this dependency must be resolved.

Change-Id: I862664d4ca032d18f22b18677816bed1e1bc2a4a
Resolves: #56936
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28421
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] version entry script cleanup 09/28209/2
Nicole Cordes [Mon, 10 Mar 2014 00:50:13 +0000 (01:50 +0100)]
[TASK] version entry script cleanup

The patch adds usage of module dispatcher to enable CSRF protection to
version click module.

Resolves: #55675
Releases: 6.2
Change-Id: Ib31e419fd2a880052e93f3eea95d51c75d442e23
Reviewed-on: https://review.typo3.org/28209
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Prevent IconUtility to throw PHP Warning 65/28065/5
Caspar Stuebs [Tue, 4 Mar 2014 22:16:17 +0000 (23:16 +0100)]
[BUGFIX] Prevent IconUtility to throw PHP Warning

Do an array typecast while using function in_array()
Clean up the code to make it more clear

Change-Id: I97738ab4bc4e1e4c346cd25836e2b4d1f875ec23
Resolves: #56558
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/28065
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] FAL: Invalid title and broken layout 59/27259/3
Marcel Wieser [Sun, 2 Feb 2014 11:04:45 +0000 (12:04 +0100)]
[BUGFIX] FAL: Invalid title and broken layout

This fix resolves the issue of the wrong title for FAL irre relations.
Now the title of the sys_file metadata will be displayed,
if there's no title for the sys_file_reference.
Additionally the title, labels and placeholder
will be cropped if necessary.

Resolves: #55485
Releases: 6.2
Change-Id: I22b41931e10c565d83edb53ab9689311d13e811a
Reviewed-on: https://review.typo3.org/27259
Reviewed-by: Steffen Ritter
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Install Tool: Optimize permission checking and fixing 16/25416/10
Ernesto Baschny [Thu, 14 Nov 2013 12:44:02 +0000 (13:44 +0100)]
[TASK] Install Tool: Optimize permission checking and fixing

* Adjust default permissions back to "world readable" (775/664)
* Do not attempt to fix permissions on an existing folder structure
* Streamline the separation of Notices, Warnings and Errors
* Cosmetical optimizations in the "Folder Structure" item
* Also report if the default permissions are too insecure (i.e.
  world writeable / readable).

Note that the new defaults (775/664) are set to make the system work
by default on almost most scenarios, but the recommended secure setup
is still 770/660. This is on purpose to make the administrator aware
of it but will require manual intervention (i.e. "thinking") if this
setup will work or not (we cannot detect that automatically).

Resolves: #52668
Releases: 6.2
Change-Id: I77c72617fa58fd808ebc5fd818e94b48c2644102
Reviewed-on: https://review.typo3.org/25416
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Index on sys_file_processedfile is still too large 29/28429/2
Ernesto Baschny [Sat, 15 Mar 2014 20:59:25 +0000 (21:59 +0100)]
[BUGFIX] Index on sys_file_processedfile is still too large

On some systems even "332" characters is too large. To also cope with
potential utf8mb4 setups (1 char = 4 bytes), and staying under 1000 byte
limit, we reduce the amount of characters in the index to 249.

Resolves: #56786
Related: #54234
Releases: 6.2
Change-Id: I79452224f37ec2b6ca5b3a35044144eed787df67
Reviewed-on: https://review.typo3.org/28429
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Tests: Release ext:form tests from exbase base class 28/28428/2
Christian Kuhn [Sat, 15 Mar 2014 20:31:29 +0000 (21:31 +0100)]
[TASK] Tests: Release ext:form tests from exbase base class

Change-Id: I7e9f09fa747a07208bf248aa35fdf154cd1fa9c4
Resolves: #56943
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28428
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Release em tests from extbase base class 27/28427/3
Christian Kuhn [Sat, 15 Mar 2014 19:47:37 +0000 (20:47 +0100)]
[BUGFIX] Tests: Release em tests from extbase base class

Extbase BaseTestClass comes with a not mocked objectManager that
gives headaches if it is injected to a test subject. Releasing
the extensionmanager test classes from this and using core
UnitTestCase as parent reveals these parts in existing tests,
those are fixed with the patch.

Change-Id: Ia7acd7f838f9ac0eb2f44e0737893fc30c41ff55
Resolves: #56942
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28427
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years agoRevert "[BUGFIX] Implement locking in ClassLoader" 26/28426/3
Ernesto Baschny [Sat, 15 Mar 2014 19:36:47 +0000 (20:36 +0100)]
Revert "[BUGFIX] Implement locking in ClassLoader"

This reverts commit 76284d26065af1a0a5b141f5f16305a5821609fa

The implemented locking is fine, but currently breaks a fresh new
installation (when there is no typo3temp directory yet). We remove
this feature for the release of beta7 and merge it afterwards again
to be able to improve upon it during the next week before the release
candidate.

Change-Id: Ie69352e5c7e3a224b0a0c71457efe3dbb8d90aac
Reviewed-on: https://review.typo3.org/28426
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Tests: Skip some FAL tests 24/28424/4
Christian Kuhn [Sat, 15 Mar 2014 17:06:54 +0000 (18:06 +0100)]
[TASK] Tests: Skip some FAL tests

While the FAL tests were already streamlined and simplified a lot,
the ResourceStorageTest class is still a mixture of functional and
unit test that involves heavy set up code and still does not mock
dependencies properly.
This test class needs a rewrite and a clean separation of units
together with a number of working functional tests to be of any use.
For now, all tests that rely on initialized database are skipped and
marked as TODO.

Change-Id: I3191c809c50f4f19ab91b9a5b5f2f3ebc3fa47ff
Resolves: #56940
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28424
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove old hook for simulatestatic 91/27991/4
Markus Klein [Mon, 3 Mar 2014 12:25:12 +0000 (13:25 +0100)]
[TASK] Remove old hook for simulatestatic

The hook was introduced and deprecated when
simulatestatic was moved to TER for 6.0.

Furthermore the old wapversion.lib files are
not part of the Core anymore, hence we can remove
some more overhead.

Resolves: #56491
Releases: 6.2
Change-Id: Ib9c05895eed3539ac9e540b39d720038c5cacedb
Reviewed-on: https://review.typo3.org/27991
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mock in IndexerServiceTest 23/28423/2
Christian Kuhn [Sat, 15 Mar 2014 16:13:52 +0000 (17:13 +0100)]
[BUGFIX] Tests: Incomplete mock in IndexerServiceTest

Change-Id: Idad4b11894ee6e09e0b8eca9a057c7a776925a70
Resolves: #56939
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28423
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] inline BEUserAuth::getCookieName 18/28418/3
Thomas Maroschik [Sat, 15 Mar 2014 12:13:33 +0000 (13:13 +0100)]
[TASK] inline BEUserAuth::getCookieName

During bootstrapping in index_ts.php there is a check
for an existing be_typo_user cookie which enables
TimeTracking. The simple static getter triggers the loading
and parsing of BackendUserAuthentication and
AbstractUserAuthentication which are both pretty fat classes
and have an impact upon eID calls and frontend calls.

This patch inlines the cookie name retrieval and defers thus
the loading of the fat classes.

Resolves: #56316
Releases: 6.2
Change-Id: I5ce5cf92095dcb8820fb0e548e16e38a99f4f12e
Reviewed-on: https://review.typo3.org/28418
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Tests: Improve mocking in DatabaseConnectionTest 22/28422/2
Christian Kuhn [Sat, 15 Mar 2014 15:49:52 +0000 (16:49 +0100)]
[BUGFIX] Tests: Improve mocking in DatabaseConnectionTest

With the switch to mysqli object it is now possible to fully mock
and check the final database calls in DatabaseConnectionTest, the
test table can be removed after refactoring the tests.

Change-Id: I60e33f6af5b4be8111a21469d12e38843650e7c4
Resolves: #56938
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28422
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Tests: Refactor cache Typo3DatabaseBackend 20/28420/2
Christian Kuhn [Sat, 15 Mar 2014 14:28:21 +0000 (15:28 +0100)]
[TASK] Tests: Refactor cache Typo3DatabaseBackend

Tests of the Typo3DatabaseBackend are refactored to not depend on
initialized $GLOBALS['TYPO3_DB'] anymore, queries and quoting is
now performed to a mock object. Next to a better separation this
has the advantage of a nice speedup executing those tests.

Change-Id: I8fc23fec56a50e48f74422eac3ee4a07ed3669b9
Resolves: #56937
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28420
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Follow-up: .t3-table & .dblist-table 06/28406/2
Felix Kopp [Fri, 14 Mar 2014 22:16:09 +0000 (23:16 +0100)]
[BUGFIX] Follow-up: .t3-table & .dblist-table

Fixes different headers and columns paddings for .t3-table
and the former .typo3-dblist. Also fixes .row-header link
hover style where text links went black and dark gray.

Resolves: #56926
Releases: 6.2
Change-Id: I0e93ccc315f4740b87be7656df1d54cd40272be7
Reviewed-on: https://review.typo3.org/28406
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Improve mocking in ext:extbase 07/28407/6
Anja Leichsenring [Fri, 14 Mar 2014 23:02:15 +0000 (00:02 +0100)]
[BUGFIX] Tests: Improve mocking in ext:extbase

Unit tests reveal some warnings which are caused by incomplete
mocking. They all belong to $GLOBALS['LANG']

Change-Id: Ic2adda9984a530b82e259c1d8931015996f167ba
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28407
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Implement locking in ClassLoader 56/28156/21
Alexander Opitz [Fri, 7 Mar 2014 11:37:47 +0000 (12:37 +0100)]
[BUGFIX] Implement locking in ClassLoader

After cache clearing we can run in the situation that 2 processes will
rebuild the ClassLoader cache which will lead to a non useable cache,
which produces fatals. As the data is generated more than once the load
of the server increases per request while ClassLoader cache is build.

The implemented Locking will stop this issue. Every process waits till
the first is ready and then looks if data was generated and stops re-
generating the cache.

Resolves: #55099
Releases: 6.2
Change-Id: I109821b9c37ec99c5ec5dbc5bcef6223d1d0d153
Reviewed-on: https://review.typo3.org/28156
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Incomplete Mocking in ext:extensionmanager 12/28412/2
Anja Leichsenring [Sat, 15 Mar 2014 10:51:14 +0000 (11:51 +0100)]
[BUGFIX] Tests: Incomplete Mocking in ext:extensionmanager

After the removal of GLOBALS initialisation the extension raises
warnings in unittests.

Change-Id: I450932b1de1852302e4ae9861b250c5721f6032e
Resolves: #56930
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28412
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[TASK] Improve Locker 59/28159/19
Markus Klein [Fri, 7 Mar 2014 12:38:42 +0000 (13:38 +0100)]
[TASK] Improve Locker

Code cleanup for locker and fix of semaphore locking.
It is now possible to reuse a semaphore.

Resolves: #40420
Releases: 6.2
Change-Id: I843aca1f9fa3d070ce0a508a27d3c433725991fa
Reviewed-on: https://review.typo3.org/28159
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[BUGFIX] PublicURL calculation for storage 0 is wrong 95/28395/7
Steffen Ritter [Fri, 14 Mar 2014 18:04:13 +0000 (19:04 +0100)]
[BUGFIX] PublicURL calculation for storage 0 is wrong

Since the refactoring of the publicURL Feature and the possibility to
link to files via jump-scripts the generation of publicUrls for files
in storage zero is broken due to the fact that every relative base-path
for this URL is appended with a slash.

If the base-path has been empty (like for storage 0), appending a slash
makes it absolute.

This patch changes the behaviour to only append a slash on non-empty
paths.

Releases: 6.2
Resolves: #56927
Change-Id: I14e8bae0b64ed8dc537a5edbf57d9dce6ddf0932
Reviewed-on: https://review.typo3.org/28395
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Language labels missing in Localization Overview 60/28260/6
Patrick Broens [Tue, 11 Mar 2014 15:07:09 +0000 (16:07 +0100)]
[BUGFIX] Language labels missing in Localization Overview

The submodule "Localization Overview" of Web > Info is missing
language labels. These labels are requested from the wrong localization file.

This patch fixes this by changing the label calls to a different file.

Change-Id: Id6aaddf3e9bb88da30bb5008b875279b0b07daa5
Resolves: #56767
Releases: 6.2
Reviewed-on: https://review.typo3.org/28260
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Update requirejs to 2.1.11 89/28389/2
Jan Kiesewetter [Fri, 14 Mar 2014 14:21:11 +0000 (15:21 +0100)]
[TASK] Update requirejs to 2.1.11

Change-Id: I1daabdbb0e39badb3575f6cea9fd1d4bd1e95ba3
Resolves: #56913
Releases: 6.2
Reviewed-on: https://review.typo3.org/28389
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix thumbnail display for IRRE records 44/27844/5
Alexander Stehlik [Fri, 14 Mar 2014 11:39:05 +0000 (12:39 +0100)]
[BUGFIX] Fix thumbnail display for IRRE records

The system will only generate a thumbnail for IRRE records if the
related file object is an image file.

Additionally the UID of the file reference will be used as alternative
text and as title for the thumbnail so that it behaves like the icon
that is used for non-image files.

Resolves: #56274
Releases: 6.2
Change-Id: Ibe6530368434c384d5b7cca93e81b656c8c56383
Reviewed-on: https://review.typo3.org/27844
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Remove unmaintainable testclass 01/28401/4
Anja Leichsenring [Fri, 14 Mar 2014 20:54:10 +0000 (21:54 +0100)]
[TASK] Remove unmaintainable testclass

The test class contains only one test, but to execute this,
it depends on many classes which are not all properly mocked and a
nightmare to maintain. Additionally the test has nothing
to do with the execution of tasks, so subject scope is not met.

To keep test maintenance a doable task this test class in removed.

Change-Id: I97ac02040cb6dc711dcc300fb84c15c6785736e2
Resolves: #56924
Relates: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28401
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix Content-Disposition header sent by dumpFileContents 99/28399/3
Frans Saris [Fri, 14 Mar 2014 19:53:40 +0000 (20:53 +0100)]
[BUGFIX] Fix Content-Disposition header sent by dumpFileContents

This patch changes the Content-Disposition header so it is also
send when $asDownload isn't set with value inline and the filename
is between quotes.

Resolves: #56923
Releases: 6.2
Change-Id: Ic47c7d3743e7bac73936d20addbc61193e6fd49c
Reviewed-on: https://review.typo3.org/28399
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Remove ExtJS normalization 69/28069/6
Ernesto Baschny [Thu, 13 Mar 2014 19:29:02 +0000 (20:29 +0100)]
[BUGFIX] Remove ExtJS normalization

To avoid conflicts with normalize.css, we remove the normalization done by
ExtJS, which is loaded after the normalize.css now.

Resolves: #56418
Releases: 6.2
Change-Id: I8a5b633244c5074755d478d0497b8f438ef86b65
Reviewed-on: https://review.typo3.org/28069
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] RootlineUtility does not consider disablefield 77/28277/4
Christian Reiter [Tue, 11 Mar 2014 19:50:01 +0000 (20:50 +0100)]
[BUGFIX] RootlineUtility does not consider disablefield

Make sure RootlineUtility::enrichWithRelationFields() respects
the setting of $TCA[$table]['ctrl']['enablecolumns']['disabled'] when
fetching foreign data for the rootline.

Otherwise hidden relations from sys_file_reference are added to the
rootline and cause exceptions in the frontend, instead of being ignored.

Resolves: #56150
Releases: 6.2, 6.1
Change-Id: I21917fec1407a10818058da8ea879b0bb39441a4
Reviewed-on: https://review.typo3.org/28277
Tested-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Incomplete mocking in PreparedStatementTest 98/28398/2
Christian Kuhn [Fri, 14 Mar 2014 19:11:56 +0000 (20:11 +0100)]
[BUGFIX] Tests: Incomplete mocking in PreparedStatementTest

Release PreparedStatementTest from an active DB connection. The
quote tests are refactored a bit to find out in one specific test
if it is done for parameters.

Change-Id: I37853cd49368c2b23d0c2d6926fc806618674279
Resolves: #56922
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28398
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Refactor log writer tests in ext:core 96/28396/3
Christian Kuhn [Fri, 14 Mar 2014 18:24:24 +0000 (19:24 +0100)]
[BUGFIX] Tests: Refactor log writer tests in ext:core

Test files and class naming is adapted to subject class names in
ext:core Log/Writer and the DatabaseWriterTests are rewritten to
not depend on initialized database connection anymore.

Change-Id: Ifff4e5a064018bb5b0db3bf9eeb1b9232adfb262
Resolves: #56921
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28396
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Better mocking in ext:core 94/28394/2
Christian Kuhn [Fri, 14 Mar 2014 16:19:24 +0000 (17:19 +0100)]
[BUGFIX] Tests: Better mocking in ext:core

Some tests still rely on initialized $GLOBALS['TYPO3_DB']. The patch
handles some easy cases in ext:core.

Change-Id: I5b720154035cc5f8b156a9358806673daaf9c9ec
Resolves: #56918
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28394
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] JavaScript generation in RTE element browser 38/28338/2
Alexander Stehlik [Thu, 13 Mar 2014 10:23:21 +0000 (11:23 +0100)]
[BUGFIX] JavaScript generation in RTE element browser

The JavaScript in the RTE element browser is now initialized at the
end of the initialization process to make sure that all required
class variables (like $this->act) are initialized.

Resolves: #56860
Releases: 6.2
Change-Id: I39d3223921c5b17cffb31d98d62f02fa46663d27
Reviewed-on: https://review.typo3.org/28338
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Tests: Incomplete mocking in ext:fluid 90/28390/2
Christian Kuhn [Fri, 14 Mar 2014 14:26:43 +0000 (15:26 +0100)]
[BUGFIX] Tests: Incomplete mocking in ext:fluid

Change-Id: I4bd6ff219c3232211106e968fce45ee3f2dd674a
Resolves: #56914
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28390
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Incomplete mocking in backend condition matcher 88/28388/3
Christian Kuhn [Fri, 14 Mar 2014 14:17:25 +0000 (15:17 +0100)]
[BUGFIX] Tests: Incomplete mocking in backend condition matcher

Mock deterimenRootline to suppress calling database stuff
in dependencies.

Change-Id: I54938f9e20d52eda568c6520fa7bd72ec19b61e2
Resolves: #56912
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28388
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Remove not maintainable test 84/28384/3
Christian Kuhn [Fri, 14 Mar 2014 12:07:50 +0000 (13:07 +0100)]
[TASK] Remove not maintainable test

ext:backend test getNodesSetsIsMountPointField() works on getNode()
of PageTree DataProvider. The method has tons of dependencies that
are sometimes even static, and the method is recursive. It is very
hard to test properly and the current test is still not mocking
completly. The test is removed for now since it does not give us
much benefit and is hard to maintain in current state, the subject
method should be covered by tests again if it was refactored.

Change-Id: I344c584b4d6e3868471f4857a08223be3a5d03e4
Resolves: #56907
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28384
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Failing group/select test changeElementSorting 78/28278/4
Oliver Hader [Tue, 11 Mar 2014 21:23:18 +0000 (22:23 +0100)]
[BUGFIX] Failing group/select test changeElementSorting

The workspace modify test "changeElementSorting" is failing
in the frontend for the TCA types "select" and "group".

The reason is, that the move placeholder is not selected
via the "uidInList" TypoScript property and thus removed
in PageRepository::versionOL().

To avoid that, "uidInList" gets extended to look-up
move placeholders if versioning preview is enabled.

Resolves: #56782
Releases: 6.2
Change-Id: Ifae30527bead02b38888f326de2615f6bfe35f5b
Reviewed-on: https://review.typo3.org/28278
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Thorsten Kahler
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Incomplete mock in ext:scheduler 74/28374/2
Christian Kuhn [Fri, 14 Mar 2014 08:08:41 +0000 (09:08 +0100)]
[BUGFIX] Tests: Incomplete mock in ext:scheduler

Do not call __construct of subject.

Change-Id: I7b936efde9220c847b0a6278ea0d5b3606203e17
Resolves: #56894
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28374
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: improve Mocking in ext:extbase 70/28370/3
Anja Leichsenring [Thu, 13 Mar 2014 22:31:53 +0000 (23:31 +0100)]
[BUGFIX] Tests: improve Mocking in ext:extbase

Unittests reveal some warnings which are caused by incomplete mocking.

Change-Id: I42089bb6c9016187d83382a2fa10450310993a84
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28370
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove checkbox "Include Access List" in be_groups 73/28373/2
Georg Ringer [Fri, 14 Mar 2014 07:29:24 +0000 (08:29 +0100)]
[TASK] Remove checkbox "Include Access List" in be_groups

The checkbox "Include Access Lists" in the be_groups just produces extra
clicks and extra reloads. If you don't need those information in the
current group, just don't look at the tab.

Change-Id: I300f711944e76e4366472cf99011e1b193224239
Resolves: #56893
Releases: 6.2
Reviewed-on: https://review.typo3.org/28373
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] FunctionalTestCaseBootstrapUtility throws warnings on Windows 71/28371/2
Nicole Cordes [Thu, 13 Mar 2014 22:20:15 +0000 (23:20 +0100)]
[BUGFIX] FunctionalTestCaseBootstrapUtility throws warnings on Windows

If the FunctionalTestCaseBootstrapUtility::removeInstance() tries to
delete an existing symlink to a folder, the function unlink() is used.
This leads to a warning on Windows systems because unlink can only
delete files and symlinks to files.
This patch adds a rmdir() call for symlinks which works for Windows
system as well.

Resolves: #56892
Releases: 6.2
Change-Id: I2de757daea89a65a0a631c7592287e16218c1452
Reviewed-on: https://review.typo3.org/28371
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[CLEANUP] DataHandler::clear_cache() 51/28351/3
Markus Klein [Thu, 13 Mar 2014 14:47:06 +0000 (15:47 +0100)]
[CLEANUP] DataHandler::clear_cache()

* Improves the structure
* Removes useless if
* Retrieves the cacheManager only once

Resolves: #56879
Releases: 6.2
Change-Id: Id96a3c74a58a9ebb9eb16aa55f87791afcba6a66
Reviewed-on: https://review.typo3.org/28351
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Tests: Incomplete mocking in BackendUtilityTest 31/28331/3
Christian Kuhn [Wed, 12 Mar 2014 22:09:47 +0000 (23:09 +0100)]
[BUGFIX] Tests: Incomplete mocking in BackendUtilityTest

Remove dependencies in BackendUtilityTest with better mocking and
introduce static:: instead of self:: in BackendUtility for late
static binding.
The flexForm test for getExcludeFields() is separated to an own
test and an array duplication bug confusing array key and value
in getExcludeFields() is fixed along the way.

Change-Id: If242bab64075aee5050dfc77317e54dcb2f5e25d
Resolves: #56854
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28331
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Use table styles for wizard "Create new pages" 46/28346/4
Georg Ringer [Thu, 13 Mar 2014 13:11:11 +0000 (14:11 +0100)]
[TASK] Use table styles for wizard "Create new pages"

Use a table with the according styles instead of
the old bgColor4/6 classes

Resolves: #56870
Releases: 6.2
Change-Id: I272f13f3c77a8b174d6a62524ed7a0afa6da90cc
Reviewed-on: https://review.typo3.org/28346
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Cleanup EXT:indexed_search 08/28308/5
Wouter Wolters [Thu, 13 Mar 2014 22:26:44 +0000 (23:26 +0100)]
[TASK] Cleanup EXT:indexed_search

* Move modAccess check to constructor
* Move isLoaded check to constructor
* Remove check if extbase is loaded
* Replace $TYPO3_CONF_VARS to $GLOBALS['TYPO3_CONF_VARS']

Resolves: #56831
Releases: 6.2
Change-Id: Ib824d34219bc1afb646fbaf70b572b6bd3a55a47
Reviewed-on: https://review.typo3.org/28308
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Cleanup EXT:openid 09/28309/2
Wouter Wolters [Wed, 12 Mar 2014 18:15:48 +0000 (19:15 +0100)]
[TASK] Cleanup EXT:openid

* Remove deprecated calls to require_once
* Restore license header
* Remove empty TODO file

Resolves: #56832
Releases: 6.2
Change-Id: I291f5469638659d64e9df181017d1588f27317e1
Reviewed-on: https://review.typo3.org/28309
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move modAccess and language include in EXT:taskcenter 15/28315/3
Wouter Wolters [Wed, 12 Mar 2014 18:56:30 +0000 (19:56 +0100)]
[TASK] Move modAccess and language include in EXT:taskcenter

Resolves: #56838
Releases: 6.2
Change-Id: Iac44b90bc96529458a2e452e47cb5548600464b0
Reviewed-on: https://review.typo3.org/28315
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move modAccess and language include in EXT:perm 11/28311/3
Wouter Wolters [Wed, 12 Mar 2014 18:29:13 +0000 (19:29 +0100)]
[TASK] Move modAccess and language include in EXT:perm

Resolves: #56834
Releases: 6.2
Change-Id: Iec646bbae646bb85479f9f19c438e6aa9283e0dd
Reviewed-on: https://review.typo3.org/28311
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move modAccess and language include in EXT:scheduler 14/28314/3
Wouter Wolters [Wed, 12 Mar 2014 18:48:58 +0000 (19:48 +0100)]
[TASK] Move modAccess and language include in EXT:scheduler

Resolves: #56837
Releases: 6.2
Change-Id: Ieec0e8f532abd8fab0444e137c31424f1a69b67e
Reviewed-on: https://review.typo3.org/28314
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move modAccess and language include in EXT:recycler 13/28313/3
Wouter Wolters [Wed, 12 Mar 2014 18:38:13 +0000 (19:38 +0100)]
[TASK] Move modAccess and language include in EXT:recycler

* Remove deprecated require_once call

Resolves: #56835
Releases: 6.2
Change-Id: I7d79b4c9947c5f3da82c66a4dbb0e3d2e0fd9284
Reviewed-on: https://review.typo3.org/28313
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Tests: Improve Mocking in ext:extbase 65/28365/2
Anja Leichsenring [Thu, 13 Mar 2014 21:07:57 +0000 (22:07 +0100)]
[BUGFIX] Tests: Improve Mocking in ext:extbase

Unittests reveal some warnings which are caused by incomplete mocking.

Change-Id: Iee09220d675335aeadd286c2d4544d53c981016f
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28365
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] PHP-functionality instead of GeneralUtility::deHSCentities 80/22580/8
Stefan Neufeind [Wed, 5 Feb 2014 11:52:05 +0000 (12:52 +0100)]
[TASK] PHP-functionality instead of GeneralUtility::deHSCentities

Use native PHP-functionality provided by htmlspecialchars()
with a parameter since PHP 5.2.3 to prevent double-encoding
instead of calling deHSCentities().

Change-Id: I2863181259046f16b554770a3f1ed8b03112fedf
Resolves: #50449
Releases: 6.2
Reviewed-on: https://review.typo3.org/22580
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Pascal Dürsteler
Reviewed-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Extbase tries to overlay pages_language_overlay records 33/28333/2
Stanislas Rolland [Thu, 13 Mar 2014 01:46:22 +0000 (21:46 -0400)]
[BUGFIX] Extbase tries to overlay pages_language_overlay records

Method doLanguageAndWorkspaceOverlay of
Extbase\Persistence\Generic\Storage\Typo3DbBackend should not attempt
to get a parent record if the overlays are in a separate table (most
probably pages_language_overlay) by checking whether
$GLOBALS['TCA'][$tableName]['ctrl']['transOrigPointerTable'] is set.

Resolves: #56855
Releases: 6.0, 6.1, 6.2
Change-Id: I2cb53bc4733ee626ca0ae92e5dd91073d88ecc9d
Reviewed-on: https://review.typo3.org/28333
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] TCA title of table sys_file_metadata is "File" 61/28361/2
Xavier Perseguers [Thu, 13 Mar 2014 20:49:52 +0000 (21:49 +0100)]
[BUGFIX] TCA title of table sys_file_metadata is "File"

Table sys_file_metadata shares the same title as table sys_file
which makes it impossible to distinguish when granting access
in a be_groups record.

Fixes: #56890
Releases: 6.2
Change-Id: Ibce38f0f878e34c06a0d66c550fe7bf62cc33700
Reviewed-on: https://review.typo3.org/28361
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Missing icons for some core db tables 90/28290/4
Frans Saris [Tue, 11 Mar 2014 08:24:03 +0000 (09:24 +0100)]
[BUGFIX] Missing icons for some core db tables

The records of EXT:extensionmanager are also set to adminOnly=TRUE

Resolves: #56808
Releases: 6.2
Change-Id: I79f7dae056c8ede8e041f71200dc1f88b7a5551c
Reviewed-on: https://review.typo3.org/28290
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Warnings in ArrayUtility with some PHP versions 59/28359/2
Christian Kuhn [Thu, 13 Mar 2014 20:09:52 +0000 (21:09 +0100)]
[BUGFIX] Warnings in ArrayUtility with some PHP versions

PHP issue https://bugs.php.net/bug.php?id=50688 triggers a warning
in ArrayUtility::sortArraysByKey() on some supported PHP versions
like debian wheezy 5.4.4. Since this is a language error and the
code itself is correct and covered by unit tests, the warning is
now suppressed using the @ operator.

Change-Id: Ie169774d8659e55542f0c831078c00958de257c9
Resolves: #56889
Relases: 6.2
Reviewed-on: https://review.typo3.org/28359
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Link to extension manual 52/28352/6
Xavier Perseguers [Thu, 13 Mar 2014 15:30:03 +0000 (16:30 +0100)]
[TASK] Link to extension manual

If an extension manual is available locally, it should be
linked in Extension Manager.

Resolves: #56880
Releases: 6.2
Change-Id: I24572348e0dc79513ece37477e3aee186676d923
Reviewed-on: https://review.typo3.org/28352
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] ClickMenu: Visibility-options only if fields allowed 48/27348/8
Stefan Neufeind [Tue, 4 Feb 2014 23:38:04 +0000 (00:38 +0100)]
[BUGFIX] ClickMenu: Visibility-options only if fields allowed

So far the entries "Hide/Unhide" and "Visibility settings" always
showed up in the ClickMenu. We need to check via excludefields if the
other has any right to change such a field or hide the icons.

Change-Id: Ib86fbd6d30f2cc0ec52e506d5fa2f12c95a2f178
Resolves: #55683
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/27348
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Tests: MemcacheBackendTest throws warnings 57/28357/3
Christian Kuhn [Thu, 13 Mar 2014 19:08:40 +0000 (20:08 +0100)]
[BUGFIX] Tests: MemcacheBackendTest throws warnings

setUp() of memcache cache backend tests checks with fsockopen() if
a connect to memcache is possible to skip the tests if memcache is
not available. If fsockopen fails it throws a warning, this should
be suppressed.

Change-Id: I8590d20201e76f0768e5beb0c9b549b2b48933ec
Resolves: #56885
Releases: 6.2
Reviewed-on: https://review.typo3.org/28357
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Include PHP warnings as exceptional errors 91/28191/5
Markus Klein [Sun, 9 Mar 2014 13:41:39 +0000 (14:41 +0100)]
[TASK] Include PHP warnings as exceptional errors

Resolves: #56683
Releases: 6.2
Change-Id: I471e5b44eeb2dcb29217fbea3a33b4aba95e2cdd
Reviewed-on: https://review.typo3.org/28191
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Move modAccess and language include in EXT:filelist 04/28304/3
Wouter Wolters [Wed, 12 Mar 2014 16:59:46 +0000 (17:59 +0100)]
[TASK] Move modAccess and language include in EXT:filelist

* Remove deprecated require_once call

Resolves: #56827
Releases: 6.2
Change-Id: Iae4b666f7bb3ff81194ea6a6ff51b84fd9a1112c
Reviewed-on: https://review.typo3.org/28304
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[FEATURE] Signal to process actions in Extension Manager 47/28347/2
Xavier Perseguers [Thu, 13 Mar 2014 13:10:26 +0000 (14:10 +0100)]
[FEATURE] Signal to process actions in Extension Manager

This adds a way for third party extensions to process
extensions' available actions in Extension Manager.

Resolves: #56869
Releases: 6.2
Change-Id: I7cbacba7fccfd3178dc1265ad69bf5dec531cf70
Reviewed-on: https://review.typo3.org/28347
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Show thumbnails in list module 42/28342/5
Markus Klein [Thu, 13 Mar 2014 11:28:55 +0000 (12:28 +0100)]
[BUGFIX] Show thumbnails in list module

Add missing checks if type column exists in a row.

Resolves: #56830
Releases: 6.2, 6.1
Change-Id: Ifafdb0c51266c76620696c6d94471b3efddba112
Reviewed-on: https://review.typo3.org/28342
Reviewed-by: Andreas Kiessling
Tested-by: Andreas Kiessling
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Remove checks for extensions which are always loaded 35/28335/2
Georg Ringer [Thu, 13 Mar 2014 08:13:13 +0000 (09:13 +0100)]
[TASK] Remove checks for extensions which are always loaded

There are several calls to check if extensions like extbase are loaded.
As those extensions cannot be removed and are always loaded,
the code can be removed.

Resolves: #56858
Releases: 6.2
Change-Id: I434daaa2e5ae98ac623e8c9c06a0cb41560d3610
Reviewed-on: https://review.typo3.org/28335
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Fix xml2array values for attributes type NULL 45/27845/3
Marc Bastian Heinrichs [Tue, 25 Feb 2014 15:10:05 +0000 (16:10 +0100)]
[BUGFIX] Fix xml2array values for attributes type NULL

Method array2xml converts elements with value NULL to
nodes with attribute type "NULL" and empty value, e.g.:
<node index="myIndex" type="NULL"></node>
This is not correct transformed back in xml2array and results
in an empty string as value.
This in turn results in wrong imported data using impexp with
xml format.

Resolves: #55082
Releases: 6.2
Change-Id: Icfea2f2b7524c44711866c3f75f06331a1958183
Reviewed-on: https://review.typo3.org/27845
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Adopt the method comment to reflect changes of names 39/28339/2
Georg Ringer [Thu, 13 Mar 2014 10:26:55 +0000 (11:26 +0100)]
[TASK] Adopt the method comment to reflect changes of names

Some constants have been renamed in #10655 but the method comments still
use the old names

Resolves: #54947
Releases: 6.2
Change-Id: Ia40062b190139dd6d1adf9a248247b81986fc402
Reviewed-on: https://review.typo3.org/28339
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[FEATURE] Allow escaping of dots in TypoScript key 80/19480/24
Markus Klein [Mon, 24 Feb 2014 17:05:42 +0000 (18:05 +0100)]
[FEATURE] Allow escaping of dots in TypoScript key

This patch allows the use of backslashes to escape dots in
TypoScript keys, for example:

my\.escaped\.key = test

will result in a single key "my.escaped.key" with the
value "test".

Additionally it is possible to protect backslashes from beeing
interpreted as escape characters by using double backslashes.

Resolves: #29461
Documentation: #56249
Releases: 6.2
Change-Id: Idcaae75d9a8800134f4a82e0740ddabe35b3df89
Reviewed-on: https://review.typo3.org/19480
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Add missing icons for main backend modules 93/28293/2
Frans Saris [Wed, 12 Mar 2014 13:05:43 +0000 (14:05 +0100)]
[BUGFIX] Add missing icons for main backend modules

Resolves: #56809
Releases: 6.2
Change-Id: I5ea532065ef0be0fd279fe53d9498ae0df849af8
Reviewed-on: https://review.typo3.org/28293
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Use cHash in language menu links if necessary 42/21242/4
Dmitry Dulepov [Wed, 5 Jun 2013 13:05:49 +0000 (16:05 +0300)]
[BUGFIX] Use cHash in language menu links if necessary

Current menu implementation does not add the cHash in language
menus. This causes a non-cached page and performance
degradation if the page contains parameters and a user switches
between languages. Together with extensions like RealURL it
can become a long time issue because of the caching of wrong
URLs. The fix implements analysis for the query string and
relevant parameters to decide whether the cHash should be
added or not.

Change-Id: I711e732555e03c9bf5a1321523b505735aa20c41
Resolves: #33833
Releases: 6.2
Reviewed-on: https://review.typo3.org/21242
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Add "ts" to the textfile_ext 17/28317/5
Eric Chavaillaz [Wed, 12 Mar 2014 19:06:57 +0000 (20:06 +0100)]
[TASK] Add "ts" to the textfile_ext

The extension "ts" for typoscript is missing in the
default configuration. This patch adds it.

The goal is that the typoscript files can be edited
in the backend.

Resolves: #48812
Releases: 6.2
Change-Id: I40aca45f482e132b21aab03925d2cecd126e30ab
Reviewed-on: https://review.typo3.org/28317
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove wrong deprecation comment in EXT:impexp 06/28306/2
Wouter Wolters [Wed, 12 Mar 2014 17:47:11 +0000 (18:47 +0100)]
[TASK] Remove wrong deprecation comment in EXT:impexp

Resolves: #56829
Releases: 6.2
Change-Id: I7e710e1e901c0aa9a29e58aaeb29edea83a47238
Reviewed-on: https://review.typo3.org/28306
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove locking around log files 12/28312/2
Philipp Gampe [Wed, 12 Mar 2014 18:27:08 +0000 (19:27 +0100)]
[TASK] Remove locking around log files

Log files are opened in append mode and concurrency is handled by the
operation system. The PHP documentation declares fwrite
to be atomic for normal operations.

Resolves: #56833
Releases: 6.2
Change-Id: I151fdf8ce0e237d52263ad8fbc77207fd9940633
Reviewed-on: https://review.typo3.org/28312
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated genTreeStatus in DatabaseIntegrityCheck 22/28322/2
Wouter Wolters [Wed, 12 Mar 2014 19:44:32 +0000 (20:44 +0100)]
[TASK] Remove deprecated genTreeStatus in DatabaseIntegrityCheck

Resolves: #56844
Releases: 6.2
Change-Id: Ic49eb279b8cc3df9da93a153b407e0f7dea0396f
Reviewed-on: https://review.typo3.org/28322
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated functions from GeneralUtility 23/28323/2
Wouter Wolters [Wed, 12 Mar 2014 19:48:37 +0000 (20:48 +0100)]
[TASK] Remove deprecated functions from GeneralUtility

getValidClassPrefixes
hasValidClassPrefix

Resolves: #56845
Releases: 6.2
Change-Id: I14ffedbe603a5b5117abfd38b4d25fa12e0cb422
Reviewed-on: https://review.typo3.org/28323
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer