Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Make Extbase pagination work with QueryBuilder queries 09/53409/12
Tymoteusz Motylewski [Mon, 14 Aug 2017 14:27:22 +0000 (16:27 +0200)]
[BUGFIX] Make Extbase pagination work with QueryBuilder queries

Now you can pass a query built by QueryBuilder to $query->statement(),
and use the QueryResult for pagination.

So inside repository you can create custom query like:

$queryBuilder->select('*')->...
$query = $this->createQuery();
$query->statement($queryBuilder);
return $query->execute();

and pass the result to paginate ViewHelper.

Resolves: #81887
Releases: master, 8.7
Change-Id: Ia00f673039362afaa8ef7232ba4bc89c520d5a46
Reviewed-on: https://review.typo3.org/53409
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix using contains in query on property of group 93/53993/8
Łukasz Uznański [Fri, 8 Sep 2017 09:29:36 +0000 (11:29 +0200)]
[BUGFIX] Fix using contains in query on property of group

Related: master, 8.7
Resolves: #80215
Change-Id: I6f5c88650d6167550a46ad2200c846ec9d11d34a
Reviewed-on: https://review.typo3.org/53993
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Migrate cHash configuration on silent upgrade wizard 02/53202/11
Benni Mack [Tue, 13 Jun 2017 15:19:06 +0000 (17:19 +0200)]
[TASK] Migrate cHash configuration on silent upgrade wizard

The cHash calculation is done on every TYPO3 request, which is
really unnecessary overhead, as this could be taken care by the
SilentConfigurationUpgradeService once and store the new value.

Resolves: #81568
Releases: master
Change-Id: I30b562c0b9376d1044979cd7264c67a79209f6b6
Reviewed-on: https://review.typo3.org/53202
Reviewed-by: Nathan Boiron <nathan.boiron@gmail.com>
Tested-by: Nathan Boiron <nathan.boiron@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update localization rendering tests to newest Testing Framework 51/54051/2
Tymoteusz Motylewski [Sat, 9 Sep 2017 10:20:18 +0000 (12:20 +0200)]
[TASK] Update localization rendering tests to newest Testing Framework

addTypoScriptToTemplateRecord method was added to FunctionalTestCase.php
in Testing Framework.
So we can remove it from test cases.
Fix two other germlins also (unneeded comment and unused variable).

Resolves: #82401
Releases: master, 8.7, 7.6
Change-Id: I8144bae5a807d60123ef5228a44eba579a7705c7
Reviewed-on: https://review.typo3.org/54051
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Create multiple pages: cast bool values to int 54/54054/2
Andreas Fernandez [Sat, 9 Sep 2017 11:00:25 +0000 (13:00 +0200)]
[BUGFIX] Create multiple pages: cast bool values to int

Resolves: #82403
Related: #81768
Releases: master
Change-Id: Id6610c9f7fbc445c142c999bb41c7b7c6eb83729
Reviewed-on: https://review.typo3.org/54054
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Move felogin type icon registration 61/53961/2
Mathias Brodala [Thu, 7 Sep 2017 16:29:43 +0000 (18:29 +0200)]
[TASK] Move felogin type icon registration

Resolves: #82350
Releases: master
Change-Id: I60280df8d62cc65250bf5edbf8c26a65dbb5f250
Reviewed-on: https://review.typo3.org/53961
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Remove legacy code for version extension 44/54044/5
Matthias Vogel [Fri, 8 Sep 2017 21:15:39 +0000 (23:15 +0200)]
[BUGFIX] Remove legacy code for version extension

The "Display version" module of ext:version has been
moved to ext:compatibility7 with v8. The list module links
to this view but the link is dead if compat7 is not loaded.
The v8 version of the patch now checks for "loaded version,
loaded compat7, but not loaded workspaces" to render the link,
in master, this button is removed entirely

Resolves: #82394
Related: #79942
Releases: master, 8.7
Change-Id: I4e32a63b144b658f84362e25bda1cc312247367e
Reviewed-on: https://review.typo3.org/54044
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix system maintainer access 65/53965/3
Helmut Hummel [Thu, 7 Sep 2017 17:27:13 +0000 (19:27 +0200)]
[BUGFIX] Fix system maintainer access

Fix a check to not allow acces to admin users
but system maintainers only.

Change-Id: I2e5209bbaf7c3e3cee013d1fa08f48ff7e776956
Resolves: #82396
Related: #82306
Related: #82395
Releases: master
Reviewed-on: https://review.typo3.org/53965
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Replace all system_extinstall urls with corresponding urls 46/54046/4
Matthias Vogel [Fri, 8 Sep 2017 21:42:54 +0000 (23:42 +0200)]
[BUGFIX] Replace all system_extinstall urls with corresponding urls

Resolves: #82393
Releases: master
Change-Id: I0782af0fa9dc36f7a1e54caec8b7ff24334e63c7
Reviewed-on: https://review.typo3.org/54046
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Add configurable footnote to login screen 18/53918/8
Christian Heindl [Tue, 5 Sep 2017 16:55:43 +0000 (18:55 +0200)]
[FEATURE] Add configurable footnote to login screen

We are introducing a new option to provide an optional footnote for the
login screen. The footnote can provide for example legal information for
the login screen image or a descriptive text. This option is now
available in the backend extension configuration.

Resolves: #82303
Releases: master
Change-Id: I14f90ecfa8eee538234dcc9542576f6ab9f1d774
Reviewed-on: https://review.typo3.org/53918
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[!!!][TASK] Remove TYPO3.jQuery 37/53237/8
Benni Mack [Fri, 16 Jun 2017 11:32:48 +0000 (13:32 +0200)]
[!!!][TASK] Remove TYPO3.jQuery

This change removes the availability of TYPO3.jQuery within the
TYPO3 Core by default.

The constants PageRenderer::JQUERY_NAMESPACE_DEFAULT / and
PageRenderer: JQUERY_NAMESPACE_DEFAULT_NOCONFLICT namespace options
"jQuery" are removed. This also means the removal
of having custom namespaces of jQuery (e.g. TYPO3.bennis_jQuery) leaving
"noConflict" to be used by default.

Related: #79221
Resolves: #82378
Releases: master
Change-Id: Ibc939999159dbf376b09f53aacac618ed7cc40e8
Reviewed-on: https://review.typo3.org/53237
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Restrict em & lang module to system maintainer 47/54047/3
Christian Kuhn [Fri, 8 Sep 2017 21:44:24 +0000 (23:44 +0200)]
[TASK] Restrict em & lang module to system maintainer

Both extension manager and language pack adiminstration
change system configuration and should be restricted to
system maintainers.

Change-Id: I456ece7726b79a81c375eec0c949a5c63fd97df2
Resolves: #82395
Releases: master
Reviewed-on: https://review.typo3.org/54047
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use TYPO3_OS constant in Services registration 53/53953/2
Benni Mack [Thu, 7 Sep 2017 14:25:20 +0000 (16:25 +0200)]
[TASK] Use TYPO3_OS constant in Services registration

There is a comment that TYPO3_OS is not yet defined, which
is wrong as it is one of the first things available during bootstrap,
so the check can be used directly.

Resolves: #82343
Releases: master, 8.7
Change-Id: I01e0aa7a090bc068195b44474f645d09220f8b71
Reviewed-on: https://review.typo3.org/53953
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:form - use own folder for form definitions 89/53989/15
Thomas Kieslich [Fri, 8 Sep 2017 08:34:43 +0000 (10:34 +0200)]
[TASK] EXT:form - use own folder for form definitions

Change default filemount for form definitions to fileadmin/form_definitions,
the directory is automatically created if necessary.

Existing forms in fileadmin/user_upload can be listed, duplicated and removed
but not edited.

Since no migration wizard can be provided for this, a manual migration is
necessary which can be done

1) ...by moving all form definitions to the new directory via filesystem or
2) ...by duplicating all form definitions (thus storing them in the new
location) and removing the old form definitions.

Resolves: #82328
Releases: master
Change-Id: Id804f58747a203e92998aca2699b37f81900e9e7
Reviewed-on: https://review.typo3.org/53989
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Remove extended fluid core class CmsVariableProvider 28/54028/3
Benni Mack [Fri, 8 Sep 2017 15:12:06 +0000 (17:12 +0200)]
[FOLLOWUP][TASK] Remove extended fluid core class CmsVariableProvider

Class CmsVariableProvider within EXT:fluid was removed but the tests
were kept, they are removed as well.

Resolves: #82229
Releases: master
Change-Id: I59812100589a7d4e63619896f78a63dadbdda657
Reviewed-on: https://review.typo3.org/54028
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Install tool: Improve ajax error handling 35/54035/3
Markus Hoelzle [Fri, 8 Sep 2017 16:19:59 +0000 (18:19 +0200)]
[TASK] Install tool: Improve ajax error handling

Show an error message if the server answer ajax calls
with http status code 200. This could happen if a proxy
responses to the http request or a network failures
occures.

Releases: master
Resolves: #82388

Change-Id: Ie91832dde42c7d17323be084cfaf67cc98de8535
Reviewed-on: https://review.typo3.org/54035
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] PHP7.2: Check value for NULL before count 38/53938/6
Alexander Opitz [Thu, 7 Sep 2017 07:04:47 +0000 (09:04 +0200)]
[BUGFIX] PHP7.2: Check value for NULL before count

Resolves: #82275
Releases: master, 8.7, 7.6
Change-Id: I77dc811456f4bbd759e28c27284c4652ad09dd23
Reviewed-on: https://review.typo3.org/53938
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove context service from install tool 66/53966/3
Romain Canon [Thu, 7 Sep 2017 17:28:50 +0000 (19:28 +0200)]
[TASK] Remove context service from install tool

This service was not useful anymore as the install tool modules handling
changed.

It is replaced by a single string that allows doing basically the same
job.

Resolves: #82353
Releases: master
Change-Id: I34e28e0d1a716b293897f54f7f800e5e6fb8e0c5
Reviewed-on: https://review.typo3.org/53966
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Tested-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Tested-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Update typo3/testing-framework to 1.1.3 36/54036/2
Christian Kuhn [Fri, 8 Sep 2017 16:44:10 +0000 (18:44 +0200)]
[TASK] Update typo3/testing-framework to 1.1.3

Three smaller patches to improve functional testing.

Change-Id: I7ff6b9c6b4d5b22b42ab2d09e670337e5bad8162
Resolves: #82389
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54036
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Store extension configuration in key EXTENSIONS 99/53999/7
Matthias Vogel [Fri, 8 Sep 2017 09:53:16 +0000 (11:53 +0200)]
[BUGFIX] Store extension configuration in key EXTENSIONS

The previous patch changed it to EXTCONF,
but this conflicts with other stuff.

Resolves: #82370
Releases: master
Change-Id: Ib515a1364f45739fb7f8e0fa3e781099f1c1a107
Reviewed-on: https://review.typo3.org/53999
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Enforce checkout with linux lf for yaml files 39/54039/2
Benjamin Kott [Fri, 8 Sep 2017 19:06:20 +0000 (21:06 +0200)]
[BUGFIX] Enforce checkout with linux lf for yaml files

Resolves: #82392
Releases: master, 8.7
Change-Id: I2ba42454a6b16aa8b4dd97a5741251b4fe265c0e
Reviewed-on: https://review.typo3.org/54039
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Refactor distribution list view with cards 19/53619/12
Markus Sommer [Fri, 28 Jul 2017 14:43:39 +0000 (16:43 +0200)]
[TASK] Refactor distribution list view with cards

The card component has been extended and is now more flexible to be
more usefull for different usecases, and is now used in the distribution
listing of the extension manager. We have also changed to Documentation
format of the CSS files to match KSS Knyle Style Sheets format.

Releases: master
Resolves: #82000

Change-Id: I61711dd0ee6c38e3c249d9b744a3ee6b2e24273e
Reviewed-on: https://review.typo3.org/53619
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[BUGFIX] Remove restrictions from SQL in InstallTool 76/53976/2
Simon Praetorius [Thu, 7 Sep 2017 20:30:27 +0000 (22:30 +0200)]
[BUGFIX] Remove restrictions from SQL in InstallTool

Since the context of the install tool can now be either standalone
or backend, SQL queries need to be adjusted so that Doctrine
restrictions don't change their results.

Resolves: #82360
Releases: master
Change-Id: Ic1934f06f73d6212d108658ad655228f2e983cc3
Reviewed-on: https://review.typo3.org/53976
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Tested-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[CLEANUP] Remove some unused variables and cleanup some code styles 75/53975/3
Markus Hoelzle [Thu, 7 Sep 2017 20:33:36 +0000 (22:33 +0200)]
[CLEANUP] Remove some unused variables and cleanup some code styles

Remove some unused variable and cleanup some PHP docs and some code styles

Resolves: #82364
Releases: master
Change-Id: I72f69a7c05514088bd318fed0e2c4ecc4710e183
Reviewed-on: https://review.typo3.org/53975
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] SplitButtons: Abort click event if requested 68/53968/3
Andreas Fernandez [Thu, 7 Sep 2017 18:13:17 +0000 (20:13 +0200)]
[BUGFIX] SplitButtons: Abort click event if requested

If any callback is registered by `SplitButtons.addPreSubmitCallback()` and
requests to stop the event by `stopPropagation()`, the event must be
aborted and not only possibly stacked events.
Additionally, the `preventExec` flag gets reset.

Resolves: #82355
Related: #77942
Releases: master, 8.7, 7.6
Change-Id: Ib8478ef4c51915365c804c1c408b3fc16a13da0b
Reviewed-on: https://review.typo3.org/53968
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][BUGFIX] Separate sys_history from sys_log db entries 95/53195/29
Benni Mack [Tue, 13 Jun 2017 05:17:18 +0000 (07:17 +0200)]
[!!!][BUGFIX] Separate sys_history from sys_log db entries

Before, the history module fetched info about "modified records" from
sys_history+the authoritive user from a coupled sys_log entry.

Info about "insert" and "delete" was fetched from sys_log solely.

However, when using a scheduled cleanup task to truncate sys_log
then all history information is useless (see bug report).

The patch introduces a new RecordHistoryStore as an abstraction
for adding history entries (currently done solely within DataHandler).

It adds some additional, necessary SQL fields to sys_history to
store all information in there and creates an update wizard
to migrate all coupled sys_history/sys_log entries to a
new sys_history entry itself.

Additionally, the whole existing "RecordHistory" class is
now only necessary for fetching the so-called ChangeLog,
for a page or a specific record, and to do rollbacks, preparing
the history records so they can be worked on.

The whole logic for fetching the GET/POST parameters is moved
into the "ElementHistoryController", everything that is only possible
via Fluid is moved from the RecordHistory object and the
ElementHistoryController into the view.

Referencing from sys_log (Log module) into sys_history is
now done the other way around, storing information about
the corresponding history entry inside sys_log.
As a side-effect, sys_log should load faster.

Abstraction basis:
- sys_history is the only source of truth about the history of a record
- sys_log contains a reference to an history entry now
(inside sys_log.log_data) to link from the backend log module
- RecordHistoryStore exists for tracking changes to records
- RecordHistory is for retrieving, compiling the history/changelog and rollbacks
- ElementHistoryController is doing PSR-7 style request/response
handling and preparing data for the view
- Fluid is handling more view functionality now, removing
the need for doing <f:format.raw> everywhere in the templates.

Sidenotes:
* Data within sys_history is now stored as JSON, not serialized anymore
* Adding/deleting was previously stored in sys_log only, is now within sys_history
* Moving records is now tracked (but not evaluated yet)
* Highlight/Snapshot functionality within the Backend Module
was removed

This functionality is built so it can also be used within Extbase
persistence and in FE in general in a future iteration.

Resolves: #55298
Resolves: #71950
Releases: master
Change-Id: I354317609099bac10c264b9932e331fa908c98be
Reviewed-on: https://review.typo3.org/53195
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] EXT:form - catch YAML parsing errors 14/54014/7
Daniel Lorenz [Fri, 8 Sep 2017 11:52:32 +0000 (13:52 +0200)]
[BUGFIX] EXT:form - catch YAML parsing errors

Catche YAML parsing errors and display this them alongside
their form definition files in form module and plugin.

Resolves: #82369
Releases: master, 8.7
Change-Id: Icf71027d21d0a8e30c238a51369676715de2e5c5
Reviewed-on: https://review.typo3.org/54014
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove option to allow uploading system extensions 08/54008/3
Benni Mack [Fri, 8 Sep 2017 10:54:12 +0000 (12:54 +0200)]
[!!!][TASK] Remove option to allow uploading system extensions

The extension manager has the option to upload an extension
into typo3/sysext/, which is no recommendation and should
not be an option from the Backend UI itself, as it is heavily
conflicting with core updates where typo3_src/ / sysext is
exchanged.

The option is removed without substitution, if somebody
wants to play with typo3/sysext/ it's at the admins own risk,
and should not be encouraged or mentioned neither in the install
tool (All Configuration) nor Extension Manager.

Resolves: #82377
Releases: master
Change-Id: I19782a4960bb52bd2012b79e912e483610d297d8
Reviewed-on: https://review.typo3.org/54008
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] add document ready for initalize CardLayout 23/54023/2
Matthias Vogel [Fri, 8 Sep 2017 13:18:52 +0000 (15:18 +0200)]
[BUGFIX] add document ready for initalize CardLayout

Resolves: #82385
Releases: master
Change-Id: I7bbb7066e7097b56509bbaaeee3468723420af74
Reviewed-on: https://review.typo3.org/54023
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Improve SCSS of Form Framework 62/53962/6
Andreas Steiger [Thu, 7 Sep 2017 15:15:38 +0000 (17:15 +0200)]
[TASK] Improve SCSS of Form Framework

Cleanup SCSS of Form Framework. Improve the usage of variables.
Furthermore, optimize the structure tree spacings of Form Editor.

Resolves: #82327
Releases: master
Change-Id: Ia1088475e16e5a04999140cca5ee3ff7d713e661
Reviewed-on: https://review.typo3.org/53962
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Make "lang:language:update" a symfony console command 28/53928/6
Alexander Schnitzler [Wed, 6 Sep 2017 11:44:36 +0000 (13:44 +0200)]
[TASK] Make "lang:language:update" a symfony console command

This commit migrates the command "lang:language:update" from
an extbase command controller to a symfony console command.

Also, the alias language:update will be flagged deprecated.

Resolves: #82315
Releases: master
Change-Id: If9fd08981ee8286bd8187fe5eaa5b36f625bd576
Reviewed-on: https://review.typo3.org/53928
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Decouple classes extending AbstractRecordList 47/53947/15
Matthias Vogel [Fri, 8 Sep 2017 10:23:25 +0000 (12:23 +0200)]
[!!!][TASK] Decouple classes extending AbstractRecordList

In order to refactor the page module, list module,
and the file module individually,
the classes should become independent from each other.

Resolves: #82334
Releases: master
Change-Id: I2ca6aad28cbe4a88c03ef71f47fc11eb4b7649f7
Reviewed-on: https://review.typo3.org/53947
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][BUGFIX] Fix minor error handler code bugs 17/54017/2
Benni Mack [Fri, 8 Sep 2017 12:21:33 +0000 (14:21 +0200)]
[FOLLOWUP][BUGFIX] Fix minor error handler code bugs

ErrorHandler should deal with the same severity for trigger_error()
for E_USER_DEPRECATED as GeneralUtility::deprecationLog()
when calling GeneralUtility::devLog().

Resolves: #82375
Releases: master, 8.7
Change-Id: Iaff5f96f5bd0a2d94bb3bc76d9d3fec2d019c901
Reviewed-on: https://review.typo3.org/54017
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Separators shown in explicit allow/deny section 09/54009/2
Oliver Hader [Fri, 8 Sep 2017 10:49:01 +0000 (12:49 +0200)]
[BUGFIX] Separators shown in explicit allow/deny section

The explicit allow/deny section of backend user groups (be_groups)
render separators (--div--) in the backend which need to be skipped.

Change-Id: Iac578d43a7a561618d095819b9d667c613621f2b
Resolves: #82379
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54009
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Tested-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix configuration of distribution packages 05/54005/3
Markus Hoelzle [Fri, 8 Sep 2017 10:24:34 +0000 (12:24 +0200)]
[BUGFIX] Fix configuration of distribution packages

Fix link to configuration of distribution packages
and redirect after saving this confiuration.

Releases: master,8.7
Resolves: #82376
Change-Id: I7f054a32187260e102b30c097937d5348ec121a6
Reviewed-on: https://review.typo3.org/54005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix minor error handler code bugs 02/54002/2
Benni Mack [Fri, 8 Sep 2017 10:00:11 +0000 (12:00 +0200)]
[BUGFIX] Fix minor error handler code bugs

ErrorHandler has a few minor quirks:

1. the protected property is an integer (bitwise-comparison) but initialized as array
2. small indention and repeatable string introduction
3. human-readable text for E_USER_DEPRECATED missing
4. error handling when no autoloader is available is obsolete.

The patch fixes all these minor issues.

Resolves: #82375
Releases: master, 8.7
Change-Id: Id6f9616602021e04ac6a50737438253a62da788c
Reviewed-on: https://review.typo3.org/54002
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years agoRevert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class" 04/54004/3
Christian Kuhn [Fri, 8 Sep 2017 10:14:36 +0000 (12:14 +0200)]
Revert "[TASK] Let GeneralUtility::makeInstance() throw exception on unknown class"

This reverts commit 4bc4fb0273cb1b2cbdb025558b5c3ae9d76b0394.

The patch turned a PHP \Error into \Exception, which adds no value,
but can be misleading.

Change-Id: I6cc32da6c0620cb0d717c930d10fa4338d6cefac
Releases: master, 8.7
Resolves: #82131
Reverts: #82131
Reviewed-on: https://review.typo3.org/54004
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add the full namespace to afterInitializeCurrentPage 72/53972/4
Daniel [Thu, 7 Sep 2017 20:16:17 +0000 (22:16 +0200)]
[TASK] Add the full namespace to afterInitializeCurrentPage

Releases: master, 8.7
Resolves: #82362
Change-Id: I36a4341aea620027822af1b8714e9197ff4bcb00
Reviewed-on: https://review.typo3.org/53972
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Show spaces of content elements in page module 79/53879/4
Christoph Lehmann [Mon, 4 Sep 2017 15:24:23 +0000 (17:24 +0200)]
[BUGFIX] Show spaces of content elements in page module

Resolves: #82290
Releases: master,8.7
Change-Id: Ie988290ae4431f8a77dc2c38397429b9fa0c95ef
Reviewed-on: https://review.typo3.org/53879
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Tested-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Unify labels for space before/after 37/53937/3
Stefan Neufeind [Thu, 7 Sep 2017 06:52:46 +0000 (08:52 +0200)]
[BUGFIX] Unify labels for space before/after

Resolves: #82321
Releases: master, 8.7
Change-Id: Idd47fbb0b7af3f5668d45a6aee545c794ec17a1a
Reviewed-on: https://review.typo3.org/53937
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Fluid: Fix missing classes 98/53998/2
Andreas Fernandez [Fri, 8 Sep 2017 09:53:15 +0000 (11:53 +0200)]
[FOLLOWUP][TASK] Fluid: Fix missing classes

Fix a forgotten comment.

Resolves: #82335
Releases: master
Change-Id: Iff63f765fd741462cbed56e56543916f92b65444
Reviewed-on: https://review.typo3.org/53998
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Fluid: Fix missing classes 45/53945/4
Benni Mack [Thu, 7 Sep 2017 12:20:48 +0000 (14:20 +0200)]
[TASK] Fluid: Fix missing classes

When TYPO3 v8.0 switched to Fluid standalone, the RootNode
class was removed but the references were kept and done via
class aliases.

The Fluid standalone class should be used instead of the
class alias.

Resolves: #82335
Releases: master, 8.7
Change-Id: I50f74b71b86fcc347dc6bffbde052e6e2adbc842
Reviewed-on: https://review.typo3.org/53945
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] PHP7.2: Check value for NULL before count 39/53939/3
Alexander Opitz [Thu, 7 Sep 2017 07:48:21 +0000 (09:48 +0200)]
[BUGFIX] PHP7.2: Check value for NULL before count

Resolves: #82322
Releases: master, 8.7, 7.6
Change-Id: I31f7bc2db61337e10be7ffd44ac294b77c44d07b
Reviewed-on: https://review.typo3.org/53939
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:form - fix error on single database insert 69/53969/2
Mathias Brodala [Thu, 7 Sep 2017 18:37:13 +0000 (20:37 +0200)]
[BUGFIX] EXT:form - fix error on single database insert

Resolves: #81805
Releases: master, 8.7
Change-Id: I8ee3582170db9812d7be2b9710cb4d46335ec86a
Reviewed-on: https://review.typo3.org/53969
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Install tool: CLI user is no system maintainer 81/53981/3
Mathias Brodala [Fri, 8 Sep 2017 06:51:00 +0000 (08:51 +0200)]
[BUGFIX] Install tool: CLI user is no system maintainer

Prevent selection of _cli_ user as system maintainer.

Related: #82319
Resolves: #82367
Releases: master
Change-Id: Ia1e67faea383817d4931c956a166525e1aa9e8e0
Reviewed-on: https://review.typo3.org/53981
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:form - exclude hidden fields within summary pages and mails 83/53383/8
Ralf Zimmermann [Mon, 3 Jul 2017 10:23:09 +0000 (12:23 +0200)]
[BUGFIX] EXT:form - exclude hidden fields within summary pages and mails

Add a "renderingOptions" property called "_isHiddenFormElement" to
prevent form elements from being shown within summary pages and emails.

Resolves: #81770
Releases: master, 8.7
Change-Id: Iea3232879fc2be2cae00e5ed5cea565e68e192f3
Reviewed-on: https://review.typo3.org/53383
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] EXT:form - change naming and icon in new content element wizard 57/53957/5
Thomas Kieslich [Thu, 7 Sep 2017 15:04:00 +0000 (17:04 +0200)]
[TASK] EXT:form - change naming and icon in new content element wizard

Change language labels and move them to ext:form locallang.xlf.
Change the icon to content-form.

Resolves: #81650
Releases: master, 8.7
Change-Id: I1c497b78da92dc589ad9d7a47dde35c5aeba488a
Reviewed-on: https://review.typo3.org/53957
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Remove not working "Lock Install Tool" button 71/53971/3
Matthias Vogel [Thu, 7 Sep 2017 19:49:37 +0000 (21:49 +0200)]
[BUGFIX] Remove not working "Lock Install Tool" button

Resolves: #82359
Releases: master
Change-Id: Id439a0b04e6af11214d0df7b30cb20e7c94dd99c
Reviewed-on: https://review.typo3.org/53971
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove ExtJS Debugging and $GLOBALS['error'] 17/53817/5
Benni Mack [Mon, 28 Aug 2017 04:48:14 +0000 (06:48 +0200)]
[!!!][TASK] Remove ExtJS Debugging and $GLOBALS['error']

The global variable $GLOBAL['error'] is used only in ExtJS-context for ExtDirect
(via ExtDirectDebug) however, but evaluates at every request.

This is the first of a series of patches to remove ExtJS in total.

The global methods debugBegin() and debugEnd() are removed as well.

Resolves: #37180
Releases: master
Change-Id: I00843d85660e85c213ac66059abdd84344c4fe3f
Reviewed-on: https://review.typo3.org/53817
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Install tool: System maintainer administration 31/53931/6
Christian Kuhn [Wed, 6 Sep 2017 17:22:33 +0000 (19:22 +0200)]
[TASK] Install tool: System maintainer administration

Adds a card to the "Settings" menu to allow configuration of
"System Maintainers" in the install tool writing SYS/systemMaintainers
array to LocalConfiguration.

Change-Id: I0219b60e9a261373befab7b846e55b61ea215e5e
Resolves: #82319
Releases: master
Reviewed-on: https://review.typo3.org/53931
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Matthias Vogel <typo3@kanti.de>
Tested-by: Matthias Vogel <typo3@kanti.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:form - fix values with dots within form editor 56/53956/7
Ralf Zimmermann [Thu, 7 Sep 2017 15:16:13 +0000 (17:16 +0200)]
[BUGFIX] EXT:form - fix values with dots within form editor

Fix JavaScript errors if "properties.options" array keys contain dots.

Resolves: #80197
Resolves: #82210
Resolves: #81961
Resolves: #82186
Releases: master, 8.7
Change-Id: Idfa976bca2ba5bbe08a72852f306c83d84b8eef0
Reviewed-on: https://review.typo3.org/53956
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] EXT:form - fix missing id attribute 59/53959/3
protos [Thu, 7 Sep 2017 15:33:32 +0000 (17:33 +0200)]
[BUGFIX] EXT:form - fix missing id attribute

Insert missing id attribute for image and file upload element.

Resolves: #82223
Releases: master, 8.7
Change-Id: Ia88cda2db1eda1ce6dab0678052e089184d8b0cd
Reviewed-on: https://review.typo3.org/53959
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] EXT:form - cleanup of leftovers, better wording 51/53951/3
protos [Thu, 7 Sep 2017 14:04:08 +0000 (16:04 +0200)]
[TASK] EXT:form - cleanup of leftovers, better wording

Change some wording for better understanding in frontend and backend.

Resolves: #82326
Releases: master, 8.7
Change-Id: Idc43a1543a315f5d54fdaf6c575a2f7ef0084aae
Reviewed-on: https://review.typo3.org/53951
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] EXT:form - Add HTML5 form types / attributes 16/52016/19
Ralf Zimmermann [Sun, 12 Mar 2017 18:26:40 +0000 (19:26 +0100)]
[FEATURE] EXT:form - Add HTML5 form types / attributes

It is now possible to add HTML5 elements with its needs.

Resolves: #80130
Resolves: #80128
Resolves: #80127
Resolves: #80125
Resolves: #80126
Releases: master
Change-Id: I1088d77c8ee52cca93878847a5d59c6b92faf1de
Reviewed-on: https://review.typo3.org/52016
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] EXT:form - fix page drag & drop 49/53949/4
Ralf Zimmermann [Thu, 7 Sep 2017 13:29:54 +0000 (15:29 +0200)]
[BUGFIX] EXT:form - fix page drag & drop

Fix JavaScript errors on page drag & drop within the form editor

Resolves: #82337
Releases: master, 8.7
Change-Id: I6e67b05a68273f1ad2d6f851ed5dfa4781d7d5bb
Reviewed-on: https://review.typo3.org/53949
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[FEATURE] Store extension configuration as plain array 57/53657/8
Susanne Moog [Thu, 20 Jul 2017 16:37:23 +0000 (18:37 +0200)]
[FEATURE] Store extension configuration as plain array

Extension configuration is now stored as plain array
instead of serialized values. To ensure backwards-
compatibility and stream-line core usage, the old
values will still be stored and written in
$GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf'] whereas
the new array will be stored in
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF'].

As a second step we are going to introduce an API for
retrieving extension configuration to remove the necessity
for GLOBALS access in this case.

Resolves: #82254
Releases: master
Change-Id: I52ef7768491633e114e7e1b153a4ba63e07243ff
Reviewed-on: https://review.typo3.org/53657
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Install Tool: Remove authentication from backend context 60/53860/7
Benni Mack [Fri, 1 Sep 2017 07:00:10 +0000 (09:00 +0200)]
[TASK] Install Tool: Remove authentication from backend context

Currently calling the install tool modules from within the Backend does a
simple redirect with adding GET variables.

That's the reason why you need to re-authenticate again, and the context
is handed over as a query parameter, which is simply not needed at all.

Now, the redirect is removed, as the Backend entrypoint / request handler
handles the authentication of the backend user, and the standalone entry
point deals with the install tool password etc.

The context parameter is now detected by the entry point (!) as well,
allowing to get rid of quite some code.

There are some more consequences:
- Calling the install tool from the backend does not validate if you configuration
is set up (= recovery necessary) -> since you're already in the backend we guess
you're fine anyway.
- Redirect functionality is almost not needed anymore in the regular request handler
- routeParameters concept was removed again (which was introduced a couple of weeks ago)

Additionally, the contextService could be replaced at a later stage with just
a string.

Resolves: #82306
Releases: master
Change-Id: If7e4ddfaccf46cf93448d06c0ba9af81d5b9494c
Reviewed-on: https://review.typo3.org/53860
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Properly render multiline form values 50/53950/2
Daniel Lorenz [Thu, 7 Sep 2017 13:25:50 +0000 (15:25 +0200)]
[BUGFIX] Properly render multiline form values

Properly render multiline form values in summary page
and HTML emails.

Resolves: #82026
Releases: master, 8.7
Change-Id: Ic0d9cca3712437cd4625a4644355f77db8f01587
Reviewed-on: https://review.typo3.org/53950
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Shorten form doc file paths 46/53946/3
Mathias Brodala [Thu, 7 Sep 2017 12:25:34 +0000 (14:25 +0200)]
[TASK] Shorten form doc file paths

Use shorter file paths to reduce the risk of hitting the Windows
file path limit.

Resolves: #82336
Releases: master
Change-Id: Ibbba15a71b6b69df52ccf009ebe298f09840d864
Reviewed-on: https://review.typo3.org/53946
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Tests for rendering tt_content with FAL in Extbase 21/53921/5
Tymoteusz Motylewski [Wed, 6 Sep 2017 07:01:49 +0000 (09:01 +0200)]
[TASK] Tests for rendering tt_content with FAL in Extbase

Functional tests checking Extbase rendering of tt_content
records with FAL images.

Also fixes two typos in fixture data.

Resolves: #82298
Releases: master, 8.7, 7.6
Change-Id: I2cddf81a99b08df46a7fd03dc0e54b41b10452e5
Reviewed-on: https://review.typo3.org/53921
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nathan Boiron <nathan.boiron@gmail.com>
Tested-by: Nathan Boiron <nathan.boiron@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Do not use LIMIT/OFFSET on total count query 40/53940/2
Susanne Moog [Thu, 7 Sep 2017 08:27:30 +0000 (10:27 +0200)]
[BUGFIX] Do not use LIMIT/OFFSET on total count query

Usage of limit > 0 or offset in a count query do not
make sense and result in broken pagination in the list
module as the returned total count of items is always 0.

Reset given offsets/limit for that exact query.

Change-Id: I18b1964b860e51256a6d0a5f39fd4c40544bac85
Resolves: #82325
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53940
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] EXT:form - catch exceptions within page module and form engine 01/52701/5
Ralf Zimmermann [Thu, 4 May 2017 10:58:06 +0000 (12:58 +0200)]
[BUGFIX] EXT:form - catch exceptions within page module and form engine

* Show messages within page module and form engine if the backend user
  does not have access to the selected form definition.
* Show flash messages within page module and form engine if the
  ext:form configuration is invalid.

Resolves: #80678
Resolves: #81113
Releases: master, 8.7
Change-Id: I9646b31ac44752b8871635c8f1a04547872e715d
Reviewed-on: https://review.typo3.org/52701
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[TASK] Move DefaultConfigurationDescription to Yaml format 23/53923/4
Benni Mack [Wed, 6 Sep 2017 05:13:45 +0000 (07:13 +0200)]
[TASK] Move DefaultConfigurationDescription to Yaml format

Defining all configuration options in TYPO3 Install Tool is now handled
via a Yaml file which additionally specifies the "type" of the configuration
option, allowing to use further render settings, one of them already introduced
for "allowedValues". This moves the "All Configuration" to a more flexible output
rendering of dropdowns for a specific type.

Resolves: #82312
Releases: master
Change-Id: Id23c6a8e57177a68659fe98cbe7278f8744c0c34
Reviewed-on: https://review.typo3.org/53923
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Remove runtime cache and early return from TemplatePaths 17/53917/6
Claus Due [Tue, 5 Sep 2017 15:10:18 +0000 (17:10 +0200)]
[BUGFIX] Remove runtime cache and early return from TemplatePaths

This patch removes the previously introduced runtime cache
and early returns from TemplatePaths, both of which were
implemented in an attempt to prevent excessive TypoScript
parsing - an issue which has since been solved by optimising
the TypoScript parsing enough that a cache and early return
is no longer necessary (no longer constitutes a significant
performance increase).

The early return and caching introduced regressions described
in the related forge issues. Removing both solves those problems.

In addition, the method resolving TypoScript paths is now
covered by extensive unit tests confirming everything from
merging to sorting of template paths. An average of 8 tests
cover the method's lines. Each of the expected behaviors
is now declared as specific test.

Change-Id: Ia6d505dcec7d77ad7aaeea9094d7d85a58553c63
Resolves: #82196
Resolves: #82181
Related: #79662
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53917
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Update guzzlehttp/guzzle dependency to 6.3.0 24/53924/2
Benni Mack [Wed, 6 Sep 2017 07:57:40 +0000 (09:57 +0200)]
[TASK] Update guzzlehttp/guzzle dependency to 6.3.0

This brings PHP 7.2 support for guzzle functionality.

Verified that guzzle still runs with PHP7.0 (min requirement for us)

Resolves: #82313
Releases: master, 8.7
Change-Id: I65b27c41d49dcb8b740b6f276da305df864ff50e
Reviewed-on: https://review.typo3.org/53924
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prevent empty sorting field to be quoted and put into an array 15/53915/2
Xavier Perseguers [Tue, 5 Sep 2017 14:17:26 +0000 (16:17 +0200)]
[BUGFIX] Prevent empty sorting field to be quoted and put into an array

Change-Id: I807a888ac7d977606d94f5ad9ccdfeee07ee61ec
Resolves: #82307
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53915
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Allow string as $subpartContent 16/53916/3
Sebastian Fischer [Tue, 5 Sep 2017 14:40:13 +0000 (16:40 +0200)]
[TASK] Allow string as $subpartContent

The parameter $subpartContent of substituteSubpart() can be either
string or array. IDEs need to have both present in the comment to not
show warnings for given parameters that are correct.

Resolves: #82308
Releases: master, 8.7
Change-Id: Ifcceb8dcd5ad8be56695cef161949046ff74c994
Reviewed-on: https://review.typo3.org/53916
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Apply CGL fixes 05/53905/2
Oliver Hader [Tue, 5 Sep 2017 10:01:20 +0000 (12:01 +0200)]
[TASK] Apply CGL fixes

Releases: master, 8.7, 7.6
Change-Id: I167c68d7d04dd4b8c876b1f6f8f939cf3d933478
Reviewed-on: https://review.typo3.org/53905
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
2 years ago[!!!][TASK] Remove unused constant TYPO3_user_agent 08/53908/4
Benni Mack [Tue, 5 Sep 2017 10:20:18 +0000 (12:20 +0200)]
[!!!][TASK] Remove unused constant TYPO3_user_agent

The constant TYPO3_user_agent is removed as it is not in use anymore
since TYPO3 v8.

Resolves: #82296
Releases: master
Change-Id: I4860e291c1888251be5c64c2c454022f5d51643b
Reviewed-on: https://review.typo3.org/53908
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Add functional tests for rendering translated tt_content with FAL 98/53798/14
Tymoteusz Motylewski [Mon, 4 Sep 2017 12:07:01 +0000 (14:07 +0200)]
[TASK] Add functional tests for rendering translated tt_content with FAL

Functional tests checking TypoScript rendering of tt_content
records with FAL images.

Releases: master, 8.7, 7.6
Resolves: #82187
Change-Id: I5889ab13183b28dc2ff1ccc2c00c18f01ceacc76
Reviewed-on: https://review.typo3.org/53798
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[SECURITY] Disallow pht as file extension 04/53904/2
Susanne Moog [Tue, 5 Sep 2017 09:37:42 +0000 (11:37 +0200)]
[SECURITY] Disallow pht as file extension

Some web servers allow and accept pht files as PHP files
and execute them. Thus, pht should be part of the default
file deny pattern and PHP file extensions.

Resolves: #82078
Releases: master, 8.7, 7.6
Security-Commit: d7e19499bfa4bd552d4428a2b9a943005c20c61d
Security-Bulletin: TYPO3-CORE-SA-2017-007
Change-Id: Ibadcaa8c32b70b9aec569027862918d0360ec075
Reviewed-on: https://review.typo3.org/53904
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Remove version from default User-Agent 03/53903/2
Susanne Moog [Tue, 5 Sep 2017 09:37:28 +0000 (11:37 +0200)]
[SECURITY] Remove version from default User-Agent

TYPO3 does no longer send the concrete TYPO3 version as
part of the default User-Agent header when doing requests.

Resolves: #82072
Releases: master, 8.7, 7.6
Security-Commit: f5558a5d745f2bafe3c27d5621ef1ce26f3989a9
Security-Bulletin: TYPO3-CORE-SA-2017-006
Change-Id: If9d7745d909e93899e2b405e016518a9284a1006
Reviewed-on: https://review.typo3.org/53903
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Respect permissions of storages in a file collection 02/53902/2
Georg Ringer [Tue, 5 Sep 2017 09:37:22 +0000 (11:37 +0200)]
[SECURITY] Respect permissions of storages in a file collection

If a user creates a sys_file_collection record, only those
storage records must be shown which are allowed for the
user.

Resolves: #82029
Releases: master, 8.7, 7.6
Security-Commit: 45cdfccd52a224d8128e537214606848c717d8e7
Security-Bulletin: TYPO3-CORE-SA-2017-005
Change-Id: Iee94cd84f07ee0dc0730fe1ce84d228dad2f75a2
Reviewed-on: https://review.typo3.org/53902
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Escape record title in RecordsOverview 01/53901/2
Georg Ringer [Tue, 5 Sep 2017 09:37:15 +0000 (11:37 +0200)]
[SECURITY] Escape record title in RecordsOverview

The record title must be properly escaped.

Resolves: #81967
Releases: master, 8.7
Security-Commit: bb686f45996424aadd68185871c14bb4544107c2
Security-Bulletin: TYPO3-CORE-SA-2017-004
Change-Id: I71c8bdef21e76fafdae170c6ebd9f0f0834d5b0e
Reviewed-on: https://review.typo3.org/53901
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Fluid: Migrate same methods into AbstractTemplateView 31/53831/3
Benni Mack [Wed, 30 Aug 2017 06:10:20 +0000 (08:10 +0200)]
[TASK] Fluid: Migrate same methods into AbstractTemplateView

StandaloneView currently replicates a lot of code which is already
present within TemplateView (= Extbase), however, both classes inherit
from AbstractTemplateView.

In order to see which parts are different (and continue on streamlining
fluid) the parts can be placed within AbstractTemplateView.

Resolves: #82269
Releases: master
Change-Id: I4184a5899b98227cf50f93db6c3ae38812cc86ec
Reviewed-on: https://review.typo3.org/53831
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Space before class has a typo in access list for page content 75/53875/2
Jörg Bösche [Mon, 4 Sep 2017 11:15:30 +0000 (13:15 +0200)]
[BUGFIX] Space before class has a typo in access list for page content

The locallang_ttc.xlf has a typo in the key "space_before_class" which
is shown in the access list of a page content field.

Resolves: #82284
Releases: master, 8.7
Change-Id: Id61c8c7d5c5da11b8f7bb3e55e49d7613e593730
Reviewed-on: https://review.typo3.org/53875
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove wrong </td> tag in AbstractLinkBrowser 73/53873/2
Georg Ringer [Mon, 4 Sep 2017 06:44:56 +0000 (08:44 +0200)]
[BUGFIX] Remove wrong </td> tag in AbstractLinkBrowser

Remove a not needed </td> tag which has not been removed with the
refactoring.

Resolves: #82279
Releases: master, 8.7, 7.6
Change-Id: I2077e9e0b0119e6b064b0a6d4ebb9c3dc1d848a4
Reviewed-on: https://review.typo3.org/53873
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Install Tool: Use PSR-7 for fetching all POST parameters 59/53859/4
Benni Mack [Thu, 31 Aug 2017 21:07:28 +0000 (23:07 +0200)]
[TASK] Install Tool: Use PSR-7 for fetching all POST parameters

Resolves: #82270
Releases: master
Change-Id: I37fbb8c1d5199239eaa4cd432fb49d958bc86123
Reviewed-on: https://review.typo3.org/53859
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Improve performance of Fluid TemplatePaths 24/53824/3
Claus Due [Mon, 28 Aug 2017 20:27:26 +0000 (22:27 +0200)]
[TASK] Improve performance of Fluid TemplatePaths

This patch improves the performance of TemplatePaths
in two ways:

* GeneralUtility::removeDotsFromTS() is called on a far
  smaller array instead of all TypoScript.
* Fallback paths are allowed to be cached in the runtime
  cache which avoids re-reading TypoScript when no
  paths are configured in TS.

Saves several thousand calls to removeDotsFromTs
which in turn saves several tens of thousands of calls
to in_array.

Change-Id: Ib8aef69dc9136d355441ac05f21fe391e524eacc
Resolves: #82232
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53824
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Fix broken validation translation form docs 51/53851/3
Justus Leon Moroni [Thu, 31 Aug 2017 16:59:39 +0000 (18:59 +0200)]
[TASK] Fix broken validation translation form docs

The TranslationService uses the additional key 'error' in its translations
of the validation errors.

See https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Service/TranslationService.php#L428.

Releases: master,8.7
Resolves: #82264
Change-Id: Id00b60de0bf1b2b882f583f538be9bc8e40c010f
Reviewed-on: https://review.typo3.org/53851
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Install Tool: Introduce PSR-7 response objects 56/53856/5
Benni Mack [Thu, 31 Aug 2017 18:34:22 +0000 (20:34 +0200)]
[TASK] Install Tool: Introduce PSR-7 response objects

Uses PSR-7 instead of plain echo() and die - and shutdown the
install tool properly (except for redirects currently).

In the future, we should introduce proper PSR-7 response objects
for certain responses (JSON, Redirect) but this will happen in
a separate step.

Resolves: #82268
Releases: master
Change-Id: If8124f975936f6205f45009d30d979204765d8d1
Reviewed-on: https://review.typo3.org/53856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Only allow access to install tool for system maintainers 30/53830/11
Benni Mack [Tue, 29 Aug 2017 21:09:27 +0000 (23:09 +0200)]
[FEATURE] Only allow access to install tool for system maintainers

A new option $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemMaintainers']
is introduced, which contains a list of Backend User uids. It is
then possible to restrict access to backend modules to system
maintainers - most importantly the four Install Tool modules.

When this option is not set in LocalConfiguration.php, then all
admins are system maintainers, same goes for accessing TYPO3
in Development context.

This is the first step to remove the necessary "enter your
intall tool password" when accessing the install tool from
within TYPO3 Backend.

Resolves: #82266
Releases: master
Change-Id: If0026748ede694394b4e7f39788a650816160146
Reviewed-on: https://review.typo3.org/53830
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Remove suhosin mentions 58/53858/2
Christian Kuhn [Thu, 31 Aug 2017 19:12:27 +0000 (21:12 +0200)]
[TASK] Remove suhosin mentions

The master version of this 8.7 patch just removes
last mentions of suhosin from the codebase.

Change-Id: If003a8db37660662c65290a1e1bf25ef61375b80
Resolves: #82267
Related: #82257
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53858
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Install Tool: Migrate authentication logic into AuthenticationService 37/53837/6
Benni Mack [Wed, 30 Aug 2017 11:23:47 +0000 (13:23 +0200)]
[TASK] Install Tool: Migrate authentication logic into AuthenticationService

The PHP request flow logic for authentication against the install tool password
is moved into a new class called AuthenticationService.

Additionally, all logic which is only needed inside the StepController is moved
from the AbstractController into the StepController or the recovery request handler.

ToolController and AjaxController are now free of session handling completely.

Resolves: #82265
Releases: master
Change-Id: Ib75c920877da81d7d859feaa5e6cbbcf4f0fd2cf
Reviewed-on: https://review.typo3.org/53837
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Install tool: Use ext:core messaging 35/53835/12
Christian Kuhn [Wed, 30 Aug 2017 10:39:07 +0000 (12:39 +0200)]
[TASK] Install tool: Use ext:core messaging

The install tool brought its own "status message" class
structure since the 6.2 refactoring. This is used at many
places in the install tool for message handling.

The core has a very similar class construct "Messaging"
with only little dependencies, too. To simplify a later
separation of 'install tool' and 'installer' the internal
status message class structure is removed and transitioned
to the core Messaging structure. to get rid of just
another special thing the install tool does.

The ext:core FlashMessage and FlashMessageQueue now both
implement the \JsonSerialize interface. This allows direct
json_encode() calls on these objects, helpful for instance
for ajax responses.

In ext:install "Environment checks" suhosin specific checks
have been removed since the project is dead and only has a
pre-alpha php 7.0 fork, so probably nobody is using
that with the given core PHP constraints anymore.

Change-Id: Ifecd3cd4889d8db5aaf3e87f317c98be706ae82b
Resolves: #82257
Releases: master
Reviewed-on: https://review.typo3.org/53835
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Move signal slots from EXT:install to EXT:core 36/53836/4
Benni Mack [Wed, 30 Aug 2017 10:38:40 +0000 (12:38 +0200)]
[TASK] Move signal slots from EXT:install to EXT:core

The left-over signals in EXT:install/ext_localconf.php belong
to EXT:core (uses classes from EXT:core anyways) and since
both extensions are required at any time (part of minimal system)
this is just a separation cleanup.

Resolves: #82241
Releases: master
Change-Id: I9ec93ada9b4985ced285276fa5c33b851ec0be8f
Reviewed-on: https://review.typo3.org/53836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[TASK] Improve exception for invalid transOrigPointerField 88/53788/3
Mathias Brodala [Wed, 23 Aug 2017 06:52:09 +0000 (08:52 +0200)]
[TASK] Improve exception for invalid transOrigPointerField

Resolves: #82175
Releases: master, 8.7
Change-Id: I4b70b2a662b1818171bb180f88f8d40a48ee91ed
Reviewed-on: https://review.typo3.org/53788
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] a div around no-result to style it 99/53799/2
Fabian Thommen [Thu, 24 Aug 2017 14:49:08 +0000 (16:49 +0200)]
[TASK] a div around no-result to style it

Releases: master
Resolves: #82194
Change-Id: I6bb00c14dc331ec362614d00e48bf169da7cd572
Reviewed-on: https://review.typo3.org/53799
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sidoine Ghomsi Nokam <s.ghomsinokam@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Only reorder integer keys in ArrayUtility 05/53805/2
Susanne Moog [Fri, 25 Aug 2017 05:17:57 +0000 (07:17 +0200)]
[BUGFIX] Only reorder integer keys in ArrayUtility

PHP already converts strings representing 8-bit integers
to int - so there are no numeric array keys that are
of type string that ArrayUtility should reorder.

Change-Id: Ieff77f4b1b8d6cbadba73dad06e9ec02d8748e85
Resolves: #82201
Releases: master
Reviewed-on: https://review.typo3.org/53805
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix broken identifier in form docs 25/53825/5
Daniel Siepmann [Tue, 29 Aug 2017 09:32:04 +0000 (11:32 +0200)]
[TASK] Fix broken identifier in form docs

Within the docs, an incorrect identifier is used for a custom finisher.
This has been fixed and is in line with the example code above.

Releases: master,8.7
Resolves: #82234
Change-Id: I41881f825e7961f4945805360683c3189f2f9fcb
Reviewed-on: https://review.typo3.org/53825
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:form - use configured finisher identifiers for translations 63/53363/3
Ralf Zimmermann [Fri, 30 Jun 2017 08:12:19 +0000 (10:12 +0200)]
[BUGFIX] EXT:form - use configured finisher identifiers for translations

Use the configured finisher identifier for translation keys instead of
the finisher class name.

Resolves: #81591
Releases: master, 8.7
Change-Id: Ib78e942121b4b6e299ae394c30261603760444f7
Reviewed-on: https://review.typo3.org/53363
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Denis Mir <mir.denis@googlemail.com>
Tested-by: Denis Mir <mir.denis@googlemail.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update typo3/testing-framework to 1.1.2 40/53840/2
Christian Kuhn [Thu, 31 Aug 2017 10:45:52 +0000 (12:45 +0200)]
[TASK] Update typo3/testing-framework to 1.1.2

Brings a bug fix in frontend functional test parsing.

Change-Id: I3e95f4ee12069bbbfc225fb5045793273eff6f95
Resolves: #82256
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53840
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use proper key name in db config 33/53833/3
Ludwig Rafelsberger [Wed, 30 Aug 2017 07:47:32 +0000 (09:47 +0200)]
[BUGFIX] Use proper key name in db config

Releases: master,8.7
Resolves: #82239
Change-Id: I90d4ecdb4917c567a652a7bf5d24b55b39d646fd
Reviewed-on: https://review.typo3.org/53833
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Install Tool: Split up Checks into RequestHandlers 00/53800/21
Benni Mack [Thu, 24 Aug 2017 19:20:09 +0000 (21:20 +0200)]
[TASK] Install Tool: Split up Checks into RequestHandlers

In order to get the controllers free of security checks, the logic of
authentication/session handling is moved from various controllers into
the RequestHandler and the Application.

Additionally, a second RequestHandler (RecoveryRequestHandler) is introduced
which acts as a fallback if TYPO3 is not installed yet, or the installation is
broken (e.g. missing PackageStates.php).

This brings a cleaner dispatching mechanism, having the RecoveryRequestHandler
(which can handle any request) dealing with the StepController, and the
regular RequestHandler (with higher priority) for handling the maintenance
functionality for running installations.

Resolves: #82238
Releases: master
Change-Id: I906ab3f15479bbe70202608f6bd7838cc22d9e3a
Reviewed-on: https://review.typo3.org/53800
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update Fluid dependency to 2.4.0+ 23/53823/4
Claus Due [Mon, 28 Aug 2017 15:56:52 +0000 (17:56 +0200)]
[TASK] Update Fluid dependency to 2.4.0+

This patch updates the composer Fluid dependency
to version 2.4.0 and above. Fixes multiple bugs and
performance issues - and adds a few new features.

Full list of changes:

https://github.com/TYPO3/Fluid/compare/2.3.4...2.4.0

Change-Id: I2d16c6c95ecb6c985da772736d066d8e10da8761
Resolves: #82230
Releases: master
Reviewed-on: https://review.typo3.org/53823
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Install tool: Disable/Enable db analyzer buttons 21/53821/4
Christian Kuhn [Mon, 28 Aug 2017 10:39:39 +0000 (12:39 +0200)]
[BUGFIX] Install tool: Disable/Enable db analyzer buttons

The database analyzer buttons "Run again" and "Apply" are
now disabled when a scan is in progress.
This prevents multiple ajax calls in
parallel which lead to duplicate output.

Change-Id: I28df15e2c7169960e0889aed903bbd72034f07cc
Resolves: #82152
Related: #76084
Releases: master
Reviewed-on: https://review.typo3.org/53821
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove extended fluid core class CmsVariableProvider 27/53227/4
Benni Mack [Thu, 15 Jun 2017 20:28:16 +0000 (22:28 +0200)]
[TASK] Remove extended fluid core class CmsVariableProvider

The CmsVariableProvider within EXT:fluid extends a Fluid core class with
the same functionality and can be removed. A class alias ensures that the
PHP class is still available.

Resolves: #82229
Releases: master
Change-Id: I71eb7beaf0684631d9c7e857bbed91f08b75d47c
Reviewed-on: https://review.typo3.org/53227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Update CKEditor to 4.7.2 51/53751/3
Anders Kostending [Mon, 21 Aug 2017 10:38:12 +0000 (12:38 +0200)]
[TASK] Update CKEditor to 4.7.2

Update CKEditor to the lastest version that fixes a lot of bugs.

Release notes:
https://ckeditor.com/release-notes

Fixes:
 * Added Advanced Content Filter integration with the Justify plugin.
 * [Chrome] Fixed: Clicking the scrollbar throws an Uncaught TypeError:
 element.is is not a functionerror.
 * Fixed: Widgets cannot be properly pasted into a table cell.
 * Fixed: Internal cke_table-faked-selection-table class is visible
 in the Stylesheet Classes field of the Table Properties dialog.
 * [Edge] Fixed: Error thrown when pressing the Select All button
 in Source Mode.
 * Fixed: Double slash in the path to stylesheet needed by the
 Table Selection plugin.
 * Fixed: Unnecessary dependency on the Editor Toolbar plugin inside
 the Notification plugin.
 * Fixed: Error thrown into the browser console after opening the
 Styles Combo plugin menu in the editor without any selection.
 * Fixed: Double click does not open the dialog for modifying anchors
 inserted via the Link plugin.
 * [IE8-9] Fixed: Clicking inside an empty read-only editor throws
 an error.
 * [IE10] Fixed: Clicking below a single horizontal rule throws
 an error.
 * Fixed: The range.cloneContents method selects the whole element when
 the selection starts at the beginning of that element.
 * Fixed: The range.extractContents method returns an incorrect result
 when multiple nodes are selected.
 * Fixed: The elementPath.contains method incorrectly excludes the last
 element instead of root when the fromTop parameter is set to true.
 * Fixed: SCAYT leaves underlined word after the CKEditor Replace
 dialog corrects it.
 * Added the CKEDITOR.dom.nodeList.toArray method which returns an
 array representation of a node list.

Resolves: #82143
Releases: master, 8.7
Change-Id: I6f6037e48d768e4a2887c799c1791f3201ce40c8
Reviewed-on: https://review.typo3.org/53751
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Tested-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Always show input field for empty link fields 90/53790/2
Johannes Schlier [Wed, 23 Aug 2017 14:34:01 +0000 (16:34 +0200)]
[BUGFIX] Always show input field for empty link fields

The trigger values can be hardcoded here, as the previous
filtering only gives us fields for which we want to hide
the explanation and show the input field.
Previuosly each time a new link field was created  (as an
IRRE element for example) the input and explanation fields
were triggered. This created confusion with editors and
also broke the trigger button, so that fields that were in
the explanation mode could not be triggered back to input mode.

Resolves: #82179
Releases: master, 8.7
Change-Id: Ic92129c6cdafe5fab19fbc76b9e9b7713b9e8736
Reviewed-on: https://review.typo3.org/53790
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Tested-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Install tool: Presets with custom im/gm paths 22/53822/2
Christian Kuhn [Mon, 28 Aug 2017 12:06:21 +0000 (14:06 +0200)]
[BUGFIX] Install tool: Presets with custom im/gm paths

Fix "Find imagemagick / graphicsmagic in specific direcory" input
field in image preset handling.
The preset handling is still a bit ugly and does not integrate
too well into the ajax based handling all other cards use. This
needs a bigger refactoring and is not done with this patch.
For now, submitting a path to the image preset path input field
reloads the view and executes the path test, so the functionality
is there, it's just a bit ugly to use.

Change-Id: I2da1680b44ff34df05aecc4eb589a293bb8d72c2
Resolves: #82188
Related: #76084
Releases: master
Reviewed-on: https://review.typo3.org/53822
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>