Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Do not try to resolve a path to t3lib 09/39909/2
Markus Klein [Wed, 3 Jun 2015 07:40:36 +0000 (09:40 +0200)]
[BUGFIX] Do not try to resolve a path to t3lib

Resolves: #67267
Releases: master, 6.2
Change-Id: Ic866968a02a4e41df74ae56acd160d21177537d7
Reviewed-on: http://review.typo3.org/39909
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Fix FileList ordering for upper/lowercase 50/37250/8
Alexander Opitz [Thu, 26 Feb 2015 09:44:39 +0000 (10:44 +0100)]
[BUGFIX] Fix FileList ordering for upper/lowercase

File names which only differ in upper/lowercase writing are now sorted
stable with uppercase first.

Resolves: #65319
Releases: master, 6.2
Change-Id: Ib1b907cb8aed6364aadc4f028cfc9294b5c18884
Reviewed-on: http://review.typo3.org/37250
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] DBAL: Autoloading for userdefined database-handler 49/32949/4
Stefan Neufeind [Wed, 24 Sep 2014 01:26:47 +0000 (03:26 +0200)]
[TASK] DBAL: Autoloading for userdefined database-handler

Make specifying a classFile optional. If not given,
it may simply be loaded using the autoloader.

Change-Id: Ib8168d014f814a58d1e58e641287cc64bee3e095
Resolves: #61829
Releases: master
Reviewed-on: http://review.typo3.org/32949
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][BUGFIX] Check for existing index column in exec_SELECTgetRows() 07/39807/7
Markus Klein [Fri, 29 May 2015 21:18:40 +0000 (23:18 +0200)]
[!!!][BUGFIX] Check for existing index column in exec_SELECTgetRows()

In case the specified $uidIndexField does not exist in the result,
throw an exception.

Do not call debug() again since it has already been called in
exec_SELECTquery().

Resolves: #67204
Releases: master
Change-Id: I3b0a49a24da50b8ee5390f0619bf78e2e3fe772d
Reviewed-on: http://review.typo3.org/39807
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Fix broken hook in DatabaseRecordList 13/39913/3
Tim Lochmüller [Wed, 3 Jun 2015 09:39:18 +0000 (11:39 +0200)]
[BUGFIX] Fix broken hook in DatabaseRecordList

This patch fix broken hook in DatabaseRecordList,
If there are more than one hook registered, the compatibility layer is
broken, because the restructure process of the cells was executed
multiple times.

Resolves: #67270
Releases: master
Change-Id: If9ea77c4b79076f39dc622cc3258f4e2dccceff0
Reviewed-on: http://review.typo3.org/39913
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Call initializeObject() after instantiating empty objects 14/39914/5
Morton Jonuschat [Wed, 3 Jun 2015 09:38:22 +0000 (11:38 +0200)]
[BUGFIX] Call initializeObject() after instantiating empty objects

If the object is initializable and has a callable initializeObject()
method run that so that initialization work will be done.

This affects model instances retrieved from the persistence.

Resolves: #67272
Resolves: #67274
Related: #66473
Releases: master, 6.2
Change-Id: I7b0278855270e8fa6ef75a424d339d072af29c54
Reviewed-on: http://review.typo3.org/39914
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Delete FAL records + relations in ResourceStorage::deleteFolder() 51/39951/2
Frans Saris [Thu, 4 Jun 2015 15:08:50 +0000 (17:08 +0200)]
[BUGFIX] Delete FAL records + relations in ResourceStorage::deleteFolder()

When deleting a folder (recursive) also delete all FAL records and
relations to keep the FAL index up-to-date.

Resolves: #67084
Releases: master, 6.2
Change-Id: Ic3ae51a568ad43e6283e3900da24796656c9347c
Reviewed-on: http://review.typo3.org/39951
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[!!!][FEATURE] BE Login form API 34/39234/29
Frank Nägler [Sun, 3 May 2015 11:41:53 +0000 (13:41 +0200)]
[!!!][FEATURE] BE Login form API

With the new login screen (introduced in 7.2) the possibility to
override or extend the login template was removed.
The old globals ``$GLOBALS['TBE_STYLES']['htmlTemplates']`` was
removed without replacement.

With this patch we introduce a new way to extend the login form and
add a BE login form API.

Resolves: #66669
Releases: master
Change-Id: I36ab4cdabbab55f370d1fd19b7212cf2f858db57
Reviewed-on: http://review.typo3.org/39234
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] PropertyMapper now normalizes simple types 28/39628/3
Wouter Wolters [Wed, 20 May 2015 09:00:18 +0000 (11:00 +0200)]
[BUGFIX] PropertyMapper now normalizes simple types

This fixes a bug where the property mapper was unable to find a
valid typeconverter for properties annotated with int or bool.

Resolves: #67044
Releases: master,6.2
Change-Id: Ie15b6d83e70c5857a09f1d8baa21c168924d63b4
Reviewed-on: http://review.typo3.org/39628
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[!!!][FEATURE] FormEngine: The extendables 62/39662/32
Christian Kuhn [Fri, 22 May 2015 12:02:13 +0000 (14:02 +0200)]
[!!!][FEATURE] FormEngine: The extendables

For details, see the ReST files with examples for new API
and TCA changes.

* Split TCA config "type" to "type" and "renderType":
  TCA config "type" is a technical debt since it both defines the
  database storage as well as the widget that is used to render
  a certain field in FormEngine. While "type" is kept, the
  render widget is now extracted to a "renderType".

* t3editor uses this "renderType" now. type=text with
  renderType=t3editor will call the new T3editorElement provided
  by ext:t3editor, and falls back to TextElement if t3editor is
  not loaded.

* t3editor is now enabled for "setup" and "constants" of
  sys_template records if opening the whole record.

* t3editor now works when configured in a flex form.

* Introduce an API in FormEngine NodeFactory to register new
  renderType, used by t3editor.

* Introduce a resolver API in FormEngine NodeFactory to change
  the class that renders a widget or container.

* Split TextElement into TextElement that only renders a textarea
  and RichTextElement provided by ext:rtehtmlarea that renders RTE.
  ext:rtehtmlarea uses the new resolver API to route rendering to
  its own class in case RTE is enabled and configured for a field.

* In TCA section "types" a new array "columnsOverrides" is
  introduced that allows overwriting some column configurations
  of fields. Currently, this works for some View/FormEngine related
  settings like renderType and defaultExtras.

* TCA Migration is introduced to dynamically rewrite TCA before
  it is put into cache.

* TCA migration is called a second time in ext:compatibility6 in
  case TCA is still registered via ext_tables.php. This has performance
  penalty since it is done on every frontend and backend call.

* TCA migration is also called dynamically for flex form definitions.

* TCA migration moves configured t3editor wizards to type=text with
  renderType=t3editor.

* TCA migration removes the 5th parameter "style pointer" from
  types showitem

* TCA migration moves the 4th showitem parameter "extra configuration"
  to "defaultExtras" of "columnsOverrides" of given TCA type.

Change-Id: Ia2c2bc16463a01021c7a6be765b4efa872a130fd
Resolves: #67229
Releases: master
Reviewed-on: http://review.typo3.org/39662
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Add Travis CI build status badge to README 39/39939/3
Andy Grunwald [Wed, 3 Jun 2015 20:47:48 +0000 (22:47 +0200)]
[TASK] Add Travis CI build status badge to README

According to the "Pre-Merge-Tests" for TYPO3 (Gerrit -> Travis CI)
it make sense to add the Travis CI Build badge to the README.

It is not a big feature, but a nice small addition
for the TYPO3-Syncs from git.typo3.org to github like:

* https://github.com/TYPO3/TYPO3.CMS
* https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests

Furthermore this a small task at the road to get Pre-Merge-Tests ready.

Change-Id: I2d4402a5253deef7bcfb62e3d42454ba84ccc04b
Resolves: #67287
Releases: master
Reviewed-on: http://review.typo3.org/39939
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
4 years ago[BUGFIX] Clear cache_treelist table in Install Tool 16/39916/3
Wouter Wolters [Wed, 3 Jun 2015 11:24:41 +0000 (13:24 +0200)]
[BUGFIX] Clear cache_treelist table in Install Tool

This is not implemented in the caching framework and
needs to be cleared manually.

Resolves: #67275
Releases: master,6.2
Change-Id: I05f4fb96eedff1002b843ef51b184bbd50493290
Reviewed-on: http://review.typo3.org/39916
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Code cleanup EXT:backend/Classes/Controller/ContentElement/*.php 12/37512/9
Michael Oehlhof [Tue, 3 Mar 2015 22:19:19 +0000 (23:19 +0100)]
[TASK] Code cleanup EXT:backend/Classes/Controller/ContentElement/*.php

- add missing return values
- declare missing class variables
- remove unused variable assingments
- add getter for LanguageService
- add getter for BackendUser

Resolves: #65497
Releases: master
Change-Id: If6303319811e8c5c0979403c4399f8aa19459eb8
Reviewed-on: http://review.typo3.org/37512
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[!!!][FEATURE] Flash message view helper add deferred rendering 18/34818/18
Helmut Hummel [Sun, 30 Nov 2014 15:39:32 +0000 (16:39 +0100)]
[!!!][FEATURE] Flash message view helper add deferred rendering

Deprecate renderMode in favor of a flexible deferred
rendering of flash messages in the Fluid template.

This means that flash messages should no longer contain HTML tags
but only plain text, if rendered by the default rendering.

The rendered output will by default now be a <ul> list.
The usage of renderMode in the Core is removed and styles are
adapted to match the previous output.

The core is adapted to now use htmlspecialchars in a controller context
for user input. Encoding is now taken care of during rendering of
the Fluid template.

Resolves: #63453
Releases: master
Change-Id: Ie02d2e1441ca2b3c7c159ffa917f7040f50327b5
Reviewed-on: http://review.typo3.org/34818
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] Correct case for SimpleXMLElement 96/39896/8
Stephan Großberndt [Tue, 2 Jun 2015 13:23:08 +0000 (15:23 +0200)]
[CLEANUP] Correct case for SimpleXMLElement

Use the correct case 'SimpleXMLElement' instead of 'SimpleXmlElement'
when loading locallang.xml and remove backslashes for options.

Resolves: #67242
Related: #67234
Releases: master
Change-Id: Ia1234b7887396e1b848e6e74f0453ad5c8035e0c
Reviewed-on: http://review.typo3.org/39896
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] addToAllTCAtypes() must replace fields correctly 10/39910/3
Markus Klein [Wed, 3 Jun 2015 08:40:51 +0000 (10:40 +0200)]
[BUGFIX] addToAllTCAtypes() must replace fields correctly

The changes made in #57824 cause the replace functionality to fail.

Resolves: #67259
Releases: master, 6.2
Change-Id: If0d5773f2905bdae50ab7aa607c01422d18e7f81
Reviewed-on: http://review.typo3.org/39910
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: rengaw83 <rengaw83@gmx.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Replace t3lib occurences in the core 03/39903/2
Wouter Wolters [Tue, 2 Jun 2015 17:47:18 +0000 (19:47 +0200)]
[TASK] Replace t3lib occurences in the core

Resolves: #67251
Releases: master
Change-Id: I75dcc244eb3a1abd9d33f04421523b548283b7c1
Reviewed-on: http://review.typo3.org/39903
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Make SQL Schema Parser aware of combined indexes 86/39786/4
Frank Nägler [Fri, 29 May 2015 09:32:24 +0000 (11:32 +0200)]
[TASK] Make SQL Schema Parser aware of combined indexes

The patch fix problems with multiple parenthesis. e.g.
uid_foreign,tablenames(255),fieldname(255),sorting_foreign

Resolves: #66738
Releases: master
Change-Id: I49abc597e9c325a22d49c3d76355ecadec30a35d
Reviewed-on: http://review.typo3.org/39786
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Type checking at PageRepository::getFileReferences() call 80/36480/7
Alina Fleser [Fri, 30 Jan 2015 22:17:25 +0000 (00:17 +0200)]
[BUGFIX] Type checking at PageRepository::getFileReferences() call

Verification of parent element ($element) type before
PageRepository::getFileReferences() call
in FilesContentObject::handleFileReferences
to avoid PHP error in case of null value

Resolves: #64239
Resolves: #62616
Releases: master, 6.2
Change-Id: I8b89710af97eb37eee9518392e89ddeceb5b9f57
Reviewed-on: http://review.typo3.org/36480
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Import Selection with TYPO3 Element Browser 44/39744/4
Frank Nägler [Tue, 26 May 2015 14:07:56 +0000 (16:07 +0200)]
[BUGFIX] Import Selection with TYPO3 Element Browser

This patch fixes the "Import Selection" link in the element browser.

Resolves: #47322
Releases: master, 6.2
Change-Id: Ic9b7ed37f0bd25d47e6b97036e1244b97b218f3b
Reviewed-on: http://review.typo3.org/39744
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Remove references to t3lib in DefaultConfiguration 02/39902/2
Wouter Wolters [Tue, 2 Jun 2015 17:09:29 +0000 (19:09 +0200)]
[TASK] Remove references to t3lib in DefaultConfiguration

Resolves: #67250
Releases: master
Change-Id: If9868831bd4ef6bffa0e34e532769a384ea2511b
Reviewed-on: http://review.typo3.org/39902
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Reduce duplicated paths for bowercopy 66/39866/4
Mathias Brodala [Mon, 1 Jun 2015 13:04:59 +0000 (15:04 +0200)]
[TASK] Reduce duplicated paths for bowercopy

This makes use of the destPrefix option to set the target base
path only once.

Also drop the leading slash from source path which is unnecessary.

Resolves: #67226
Releases: master
Change-Id: I9d4b19479075a36fd8a7bbab1d65a4e1ce8bcb06
Reviewed-on: http://review.typo3.org/39866
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] Remove ViewHelper xmlns-attributes and specified html tag 72/38472/43
Andreas Allacher [Sat, 4 Apr 2015 05:24:56 +0000 (05:24 +0000)]
[FEATURE] Remove ViewHelper xmlns-attributes and specified html tag

In order to include ViewHelper namespaces with xmlns:*-attributes
it is currently required to use e.g. a HTML tag to allow code-completion
by an IDE. The tag itself will also be rendered.
To avoid rending the tag, workarounds are necessary.
One is to use sections, but this approach is counter-intuitive and has
rendering overhead due to extra sections being used. Additionally it is
not possible to use this workaround in layouts.

This patch introduces new functionality to remove all xmlns-attributes
which match ViewHelper namespaces.
For HTML output, we introduce a new attribute, which will cause Fluid
to remove the HTML-tag as well.
The attributes is called >data-namespace-typo3-fluid="true"<

Change-Id: I709d17da86cd79b7b3ba5c83b3f2bd6df8e2bd98
Releases: master
Resolves: #66269
Reviewed-on: http://review.typo3.org/38472
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Schmidt <daniel@netz-basis.com>
Tested-by: Daniel Schmidt <daniel@netz-basis.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[CLEANUP] File object 29/39429/4
Sascha Egerer [Mon, 11 May 2015 10:29:56 +0000 (12:29 +0200)]
[CLEANUP] File object

In the TYPO3\CMS\Core\Resource\File object the logic to load
metaDataProperties was implemented at multiple places but there
is also a method _getMetaData() that handles this logic.
The method _getMetaData() should be used instead of duplicating
the logic at multiple places.

Additionally some code is removed, which checks the
metaDataProperties member for NULL values, which can never
be the case.

Resolves: #66878
Releases: master
Change-Id: I01939a66aa58629f2c6dc08656647375460cc4e9
Reviewed-on: http://review.typo3.org/39429
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[FOLLOWUP][BUGFIX] dont set fePreview=2 with ADMCMD_noBeUser 63/39863/3
Andreas Fernandez [Mon, 1 Jun 2015 12:51:08 +0000 (14:51 +0200)]
[FOLLOWUP][BUGFIX] dont set fePreview=2 with ADMCMD_noBeUser

Restructure the nested condition for the sake of readability.

Releases: master, 6.2
Resolves: #67224
Change-Id: I25161348509245dee56b61f3a1f15d9bc778500b
Reviewed-on: http://review.typo3.org/39863
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] dont set fePreview=2 with ADMCMD_noBeUser 34/27834/5
Peter Niederlag [Wed, 19 Feb 2014 16:17:04 +0000 (17:17 +0100)]
[BUGFIX] dont set fePreview=2 with ADMCMD_noBeUser

The workspace preview adds the GET parameter ADMCMD_noBeUser
when requesting the frame for live preview.

$GLOBALS[BE_USER] is unset in index_ts.php when seeing ADMCMD_noBeUser.

In TypoScriptFrontendController fePreview=2 must not be set when
ADMCMD_noBeUser parameter is present to prevent fatal errors on
calling methods on a non-existent $GLOBALS[BE_USER]

Releases: master, 6.2
Resolves: #30643
Change-Id: Idff7febcaaa8b87bd65a993b1860ad378e09b22f
Reviewed-on: http://review.typo3.org/27834
Reviewed-by: Lorenz Ulrich <lorenz.ulrich@visol.ch>
Tested-by: Lorenz Ulrich <lorenz.ulrich@visol.ch>
Reviewed-by: Markus Bucher <markusbucher@gmx.de>
Tested-by: Markus Bucher <markusbucher@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Allow removal of search term in Page / List module 43/39743/3
Andreas Fernandez [Tue, 26 May 2015 13:52:00 +0000 (15:52 +0200)]
[BUGFIX] Allow removal of search term in Page / List module

It wasn't possible to remove the search term used in the search
in the Page and List module below the docheader, because it was
checked for an empty submit button. The checks are removed now.

Resolves: #66552
Releases: master
Change-Id: I7113f5a00903326f9d12ee06b3510a376ff0f772
Reviewed-on: http://review.typo3.org/39743
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Do not generate new processed file if it already exists 09/39709/5
Frans Saris [Mon, 25 May 2015 14:48:53 +0000 (16:48 +0200)]
[TASK] Do not generate new processed file if it already exists

When a processed file already exists but the sys_file_processedfile
record is deleted the whole processing task is executed again even
if the file already exists.

This change first checks if `targetFile` already exists and if so
uses that file and marks the task as done.

Currently this only works for `Local` file storages as the FAL API
misses proper methods get a file by folder identifier and file name.
When https://review.typo3.org/38479/ is merged a follow up is
needed for master #67126.

Resolves: #67095
Releases: master
Change-Id: I352428ddaf1d2afe4bbf031992b484ade3635e4a
Reviewed-on: http://review.typo3.org/39709
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[CLEANUP] Make use of bool/int in @param DocComments 35/39835/2
Frank Nägler [Sat, 30 May 2015 19:23:58 +0000 (21:23 +0200)]
[CLEANUP] Make use of bool/int in @param DocComments

Resolves: #67213
Releases: master
Change-Id: I8ed7802f4e4e3d95ecb946231d11b46956ea4477
Reviewed-on: http://review.typo3.org/39835
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] Remove usage of self::class 25/39825/2
Frank Nägler [Sat, 30 May 2015 13:42:16 +0000 (15:42 +0200)]
[CLEANUP] Remove usage of self::class

This patch remove the usage of self::class and make use of __CLASS__
in context of methods like makeInstance. As array key, we use the
full qualified namespace followed by ::class.

Resolves: #67211
Releases: master
Change-Id: I60e5b33313a19cdef4705b04af892916923cc97c
Reviewed-on: http://review.typo3.org/39825
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Only persist processedFile if processing was successful 96/39696/5
Frans Saris [Mon, 25 May 2015 07:19:24 +0000 (09:19 +0200)]
[BUGFIX] Only persist processedFile if processing was successful

Due to multiple reasons (for instance target folder is not writable)
the processing of a file can fail.

This change prevents wrong data being saved in sys_file_processedfile
when processing failed.

Resolves: #67094
Releases: master, 6.2
Change-Id: I6051d503ba74629dc6493b7bac9f28bf320aeb66
Reviewed-on: http://review.typo3.org/39696
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Add t3skin to class loading info in composer.json 17/39817/2
Helmut Hummel [Sat, 30 May 2015 11:56:48 +0000 (13:56 +0200)]
[BUGFIX] Add t3skin to class loading info in composer.json

With #65528 t3skin was made a protected extension, but it was forgotten
to add the extension to the class loading information array in composer.json

Do this now, so that composer class loading is active
for all protected core extensions.

Releases: master
Resolves: #67207
Change-Id: I9138d84f715c4e372763a5f17ef40f2a176cae10
Reviewed-on: http://review.typo3.org/39817
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] FeLogin: FlexForm is misleading 71/39671/5
Daniel Goerz [Sat, 23 May 2015 08:32:47 +0000 (10:32 +0200)]
[BUGFIX] FeLogin: FlexForm is misleading

The option showLogoutFormAfterLogin in the FeLogin FlexForm actually
disables all redirect configuration on login. This patch reflects
that behavior by adjusting its label to better describe what it actually does.

Since the redirect is turned off if showLogoutFormAfterLogin is set
the FrontendLoginController is also prevented from gathering redirect
URLs in the first place.

Change-Id: I0be9d166e67dd055d6057e841d9fd5509ed1e8a7
Resolves: #67115
Releases: master
Reviewed-on: http://review.typo3.org/39671
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Pass correct parameter to linkhandler 97/39797/3
Francois Suter [Fri, 29 May 2015 13:24:23 +0000 (15:24 +0200)]
[BUGFIX] Pass correct parameter to linkhandler

Since the refactoring of typolink, one wrong parameter is passed
to registered linkhandler hooks. This patch restores the right
parameter.

Resolves: #67199
Releases: master
Change-Id: I781c00abc015cc38c0c51fbb84d5063b887c72cc
Reviewed-on: http://review.typo3.org/39797
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Show full folder path in file list title 67/39767/3
Frans Saris [Thu, 28 May 2015 06:57:26 +0000 (08:57 +0200)]
[FOLLOWUP][BUGFIX] Show full folder path in file list title

In old situation the full path to of the folder was shown.
With #64759 only the accessible part is shown. The logic
to determine what the root is of the 'current' filemount
is not suitable for this and will always return the root path of
the first filemount within the storage. This could result in a wrong
root identifier.

This patch fixes the output of the readable path to the
full path by using the real storage root instead of the storage root
defined by the filemount.

Resolves: #67148
Related: #64759
Releases: master, 6.2
Change-Id: Ie00fa2dc7d3833f798c5a2913bb9674b2b15b6e7
Reviewed-on: http://review.typo3.org/39767
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[FEATURE] Add "processed files" cleanup tool to Install Tool 56/39656/10
Markus Klein [Fri, 22 May 2015 00:27:39 +0000 (02:27 +0200)]
[FEATURE] Add "processed files" cleanup tool to Install Tool

Resolves: #67071
Releases: master, 6.2
Change-Id: I1320833f0f7cfd852ca8ba458fa9367cb3b16ea0
Reviewed-on: http://review.typo3.org/39656
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] PHP7 is_numeric change 45/39745/3
Alexander Opitz [Tue, 26 May 2015 14:09:34 +0000 (16:09 +0200)]
[TASK] PHP7 is_numeric change

With PHP 7 the string 0x0 isn't any longer a numeric, so the test
fails. But the test itself makes no sense and is removed.

Resolves: #65320
Releases: master, 6.2
Change-Id: Id7569dfb859ecee7c85c595640515781b1423614
Reviewed-on: http://review.typo3.org/39745
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Deprecate t3editor->isEnabled() 62/39762/4
Christian Kuhn [Wed, 27 May 2015 14:19:58 +0000 (16:19 +0200)]
[TASK] Deprecate t3editor->isEnabled()

Method isEnabled() always returns TRUE since the checked property
is protected and never reset to something else. It is unlikely that
an extending class changes this method. isEnabled() is deprecated now.

Resolves: #67171
Releases: master
Change-Id: Ia23163a3d36f797ea9e776663057592ce12f6a1f
Reviewed-on: http://review.typo3.org/39762
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Introduce new "Important" type of documentation 60/39760/4
Frank Nägler [Wed, 27 May 2015 06:59:58 +0000 (08:59 +0200)]
[TASK] Introduce new "Important" type of documentation

Resolves: #67159
Releases: master
Change-Id: Ia17a3a52914b7acaab47b0d1bb84395a7d3fa917
Reviewed-on: http://review.typo3.org/39760
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Add "select all" to EXT:recycler 42/39742/4
Andreas Fernandez [Tue, 26 May 2015 12:44:51 +0000 (14:44 +0200)]
[TASK] Add "select all" to EXT:recycler

Re-add the "select all" toggle to select all records on a page.
The action buttons are moved to the right to match the common style
of the backend.

Resolves: #66941
Releases: master
Change-Id: I17cf35bcc9a0c48a4df26d9c0753a80a07a11f83
Reviewed-on: http://review.typo3.org/39742
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Simulate user: Fix user selection 54/39754/3
Morton Jonuschat [Tue, 26 May 2015 18:01:25 +0000 (20:01 +0200)]
[BUGFIX] Simulate user: Fix user selection

This is a follow up fix for #66801 which hides too many users as
an underscore (_) is a wildcard for a single char in SQL LIKE queries.
It also ensures proper quoting of the string value to be compatible with
databases that enforce proper query syntax.

Resolves: #67154
Resolves: #67093
Related: #66801
Releases: master
Change-Id: If0b78cd4e66c3420c832ad98aa5717034f619639
Reviewed-on: http://review.typo3.org/39754
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[TASK] Print controller->action if required argument is not set 37/39737/2
Andreas Fernandez [Tue, 26 May 2015 09:36:34 +0000 (11:36 +0200)]
[TASK] Print controller->action if required argument is not set

Extend the exception message to hint to the action of the controller
that misses a required argument.

Resolves: #67139
Releases: master, 6.2
Change-Id: I70a256d73545ad90852fd1165f2fde127ac12441
Reviewed-on: http://review.typo3.org/39737
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Add missing int-cast for checking uid zero 27/39727/2
Markus Klein [Tue, 26 May 2015 07:55:55 +0000 (09:55 +0200)]
[BUGFIX] Add missing int-cast for checking uid zero

The change #24250 introduced a strict comparison without ensuring
proper data types on both sides of the comparison.

Add the missing int-cast in \TYPO3\CMS\Backend\Tree\Pagetree\Commands

Resolves: #67138
Releases: master,6.2
Change-Id: I51dc33fd64a6d42963237ac49e0385c2abf66b71
Reviewed-on: http://review.typo3.org/39727
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Adhere "suggestions" when resolving ext loading order 92/39692/4
Markus Klein [Sun, 24 May 2015 22:55:43 +0000 (00:55 +0200)]
[BUGFIX] Adhere "suggestions" when resolving ext loading order

The issue #58701 introduced the functionality to fetch suggestions defined
in composer.json or ext_emconf.php into the Package class.
A copy and paste error causes the loading of the suggestions to
actually fail, so those never reach the DependencyResolver.

This patch fixes the tiny mistake and thus ensures that suggestions
really influence the loading order of extensions.

Resolves: #51069
Releases: master, 6.2
Change-Id: Ib12e7f91f49c0b2bda56fdb4394a604e322b741c
Reviewed-on: http://review.typo3.org/39692
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Initialize database connection in ClearCacheService 36/39636/4
Morton Jonuschat [Wed, 20 May 2015 19:06:03 +0000 (21:06 +0200)]
[BUGFIX] Initialize database connection in ClearCacheService

Without calling initialize() on the DatabaseConnection object
the DBAL the resulting connection configuration will default
to the "native" driver type (MySQL) which results in an error
as there is no MySQL server to contact with the given connection
parameters.

Resolves: #67066
Releases: master, 6.2
Change-Id: Id5d70a122dcca806ee1122cecacad0c8aef27547
Reviewed-on: http://review.typo3.org/39636
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Don't add TypoScript twice to defaultContentRendering 80/39680/3
Markus Klein [Sat, 23 May 2015 17:14:02 +0000 (19:14 +0200)]
[BUGFIX] Don't add TypoScript twice to defaultContentRendering

Calling the addTypoScript() method with last parameter set to
'defaultContentRendering' must not add the TypoScript twice.

Resolves: #67116
Releases: master, 6.2
Change-Id: I3161c62ac0ab25369fabc3f8163e5d92356aa0ca
Reviewed-on: http://review.typo3.org/39680
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[CLEANUP] ExtensionManagementUtilityTest 65/39665/3
Christian Kuhn [Fri, 22 May 2015 18:33:30 +0000 (20:33 +0200)]
[CLEANUP] ExtensionManagementUtilityTest

* Extract the AccessibleProxy to an own file to get
  rid of an evil eval() and make the class smarter
  for IDE's
* Greenify as much as possible for PhpStorm

Change-Id: I851e5e9832633bf2308e50d9d8bce13f6657119d
Resolves: #67113
Releases: master
Reviewed-on: http://review.typo3.org/39665
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[!!!][TASK] Deprecate typo3conf/extTables.php functionality 35/37235/4
Christian Kuhn [Fri, 22 May 2015 16:29:55 +0000 (18:29 +0200)]
[!!!][TASK] Deprecate typo3conf/extTables.php functionality

Using typo3conf/extTables.php for TCA overrides is bad practice.
Nowadays, stuff like that should reside in an extension that
uses Configuration/TCA/Overrides.

The patch deprecates the according parameters and logs if
an instance still has an typo3conf/extTables.php file.

The functionality within lowlevel "Configuration" backend
module to write overrides to this file is removed.

Change-Id: I648b985de4636c6af2cfb50bf8e106c472cb0fee
Releases: master
Resolves: #65344
Reviewed-on: http://review.typo3.org/37235
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Modernize irre_tutorial fixture 63/39663/2
Christian Kuhn [Fri, 22 May 2015 15:03:31 +0000 (17:03 +0200)]
[TASK] Modernize irre_tutorial fixture

Use Configuration/TCA instead of TCA registration in ext_tables.php

Resolves: #67110
Releases: master
Change-Id: I86545f3adcc58c54d74c2ae15cb7a5e1fda043ce
Reviewed-on: http://review.typo3.org/39663
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] FlexFormContainer: Read field name correctly from globalOptions 58/39658/2
Sebastian Michaelsen [Fri, 22 May 2015 11:00:50 +0000 (13:00 +0200)]
[BUGFIX] FlexFormContainer: Read field name correctly from globalOptions

The field name is read from the wrong array key, resulting in a broken
flexform.

Resolves: #67105
Releases: master
Change-Id: I64c7d1f2dfc6bf2338eaa1f1e4195dd5f139dbc8
Reviewed-on: http://review.typo3.org/39658
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Package Management only allows TYPO3 Extensions 32/39632/6
Benjamin Mack [Wed, 20 May 2015 13:21:33 +0000 (21:21 +0800)]
[BUGFIX] Package Management only allows TYPO3 Extensions

Fix a bug in the recent Package Management refactoring resulting in
Package instances only allowed if they contain an ext_emconf.php file.
This basically disallows any third-party code installed inside
Packages/ due to checking if an ext_emconf.php is present before
checking for a composer file.

Resolves: #67060
Releases: master
Change-Id: I1bec43faafc0c073da52c3bbb1945f47f6864930
Reviewed-on: http://review.typo3.org/39632
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Generate thumbnails for files without width/height 77/39077/5
Markus Klösges [Thu, 30 Apr 2015 10:06:32 +0000 (12:06 +0200)]
[BUGFIX] Generate thumbnails for files without width/height

Thumbnails should not upscale images, therefore we check for the
original size against thumbnail size. If original size is 0 (as for
pdf-Files) this leads to not generating thumbnails for those files. Now
checking original width/height against 0 to prevent this and generate
thumbs for those files again.

Resolves: #66679
Related: #66270
Releases: master, 6.2
Change-Id: I5823142a6be19e6068fea358027dc808f5fd3185
Reviewed-on: http://review.typo3.org/39077
Tested-by: Markus Klösges <mkloesges@gmx.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Check page access only if integer in ModuleRunner 48/39648/2
Nicole Cordes [Thu, 21 May 2015 11:25:59 +0000 (13:25 +0200)]
[BUGFIX] Check page access only if integer in ModuleRunner

If you register a module in main module "file" an error is thrown
because the ModuleRunner checks page access for the variable "id".
In any file module the id is a FAL identifier which can't be converted
to an integer value and the check fails.

This patch adds a limitation to the ModuleRunner to check page access
only if the id can be interpreted as integer value.

Releases: master, 6.2
Resolves: #67079
Change-Id: Iba44499b9b13172818aee48aefb01d102f810285
Reviewed-on: http://review.typo3.org/39648
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FEATURE] Add Data Processing to FLUIDTEMPLATE content object 19/39519/7
Patrick Broens [Wed, 13 May 2015 07:57:26 +0000 (09:57 +0200)]
[FEATURE] Add Data Processing to FLUIDTEMPLATE content object

The content object FLUIDTEMPLATE is extended with `dataProcessing`. With this
setting you can add full namespace class references, which can manipulate
the $data variable of the current rendered content object, like tt_content or
page, before assigning this variable to the view.

Change-Id: I757db37d86e1cf907de0116c3c63effc5270a3c1
Resolves: #66907
Releases: master
Reviewed-on: http://review.typo3.org/39519
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Use strict comparison for EXT:mediace arrays 45/39645/2
Benjamin Mack [Thu, 21 May 2015 07:04:43 +0000 (15:04 +0800)]
[BUGFIX] Use strict comparison for EXT:mediace arrays

Due to strict warnings it is not possible to use media content elements
anymore and add a simple youtube video, as a fatal is thrown here.

The change modifies the array check to be stricter.

Resolves: #67074
Releases: master
Change-Id: Ib2dfe78b39e00863b3995b7412333b0260064873
Reviewed-on: http://review.typo3.org/39645
Reviewed-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Tested-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years agoRevert "[!!!][TASK] Merge typo3/sysext/core/Build/ to Build/ directory" 49/39649/3
Christian Kuhn [Thu, 21 May 2015 12:08:05 +0000 (14:08 +0200)]
Revert "[!!!][TASK] Merge typo3/sysext/core/Build/ to Build/ directory"

The change does not play well with a symlinked core and
is reverted for now.

This reverts commit e6474fe5176c040201eae9e6ddf9b6134a54a540.

Change-Id: I74ddc970a20d34a4d105a91cbdd5f12486c9568b
Releases: master
Reverts: #67076
Reviewed-on: http://review.typo3.org/39649
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Merge typo3/sysext/core/Build/ to Build/ directory 47/39647/4
Christian Kuhn [Wed, 20 May 2015 11:52:28 +0000 (13:52 +0200)]
[!!!][TASK] Merge typo3/sysext/core/Build/ to Build/ directory

With the grunt integration a Build/ directory on repository root
level was introduced. Out test infrastructure currently relies
on a second Build/ folder located in typo3/sysext/core/.
The patch moves all files from the core Build directory to the
new global one and adapts paths.
As benefit, paths are shorter and easier to find and remember now.

This patch is breaking for test environments and extensions that
rely on the recommended core test infrastructure for unit and
functional tests.

A typical test run now should look like:

bin/phpunit -c Build/UnitTests.xml

Change-Id: I9d87a566835f5849ce1e0e22d922d24c4b46ff31
Releases: master
Resolves: #67076
Reviewed-on: http://review.typo3.org/39647
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Deprecate uc->classicPageEditMode and editRegularContentFromId 74/39474/2
Benjamin Mack [Tue, 12 May 2015 04:28:12 +0000 (12:28 +0800)]
[TASK] Deprecate uc->classicPageEditMode and editRegularContentFromId

There is some leftover, never-called code in a regular TYPO3 instance
regarding the old uc->classicPageEditMode option and its companion
functionality in EditDocumentController->editRegularContentFromId
which has been marked for deprecation.

Resolves: #66905
Releases: master
Change-Id: I0a428e411b9d7a0a646c7356d773a369c9397dde
Reviewed-on: http://review.typo3.org/39474
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[TASK] Make fileedit hook JavaScript for ext:t3editor an AMD module 34/39634/3
Wouter Wolters [Wed, 20 May 2015 18:51:55 +0000 (20:51 +0200)]
[TASK] Make fileedit hook JavaScript for ext:t3editor an AMD module

Resolves: #67065
Releases: master
Change-Id: Iff8ece078dc612c362b3e291da466b29250c8cb1
Reviewed-on: http://review.typo3.org/39634
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Show full folder path in file list title 63/38763/8
Christian Weiske [Fri, 17 Apr 2015 15:25:29 +0000 (17:25 +0200)]
[BUGFIX] Show full folder path in file list title

We have to use the name and cannot rely on the identifier, since
they can be random UUID values.

This also fixes a wrong folder name in the paste confirm message.

Change-Id: I092efdc5b666c9010717136bc063b155479eadab
Resolves: #64759
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/38763
Reviewed-by: Christian Weiske <typo3@cweiske.de>
Tested-by: Christian Weiske <typo3@cweiske.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] BE: DatabaseTreeDataProvider maxLevels incorrect 96/37196/7
Andreas Allacher [Wed, 25 Feb 2015 07:45:45 +0000 (08:45 +0100)]
[BUGFIX] BE: DatabaseTreeDataProvider maxLevels incorrect

The current behaviour for maxLevels with treeConfig is incorrect.
Currently if one uses maxLevels 0, instead of only seeing the root category,
one actually is presented of nodes up to level 2
(if one would specify the levels in nonSelectableLevels).
With maxLevels 1 it is already up to level 3.
Of course, maxLevels 0 should only display the root level, maxLevels 1 only the first child nodes.
Also increased default levelMaximum to 4, in order to ensure old non configured
trees are still behaving as intended.

Change-Id: Ic1565e39abad01599dd67bbb05b0ce9fa7161af4
Resolves: #65304
Releases: master
Reviewed-on: http://review.typo3.org/37196
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Make Content Element "Special Menus" field bigger 32/39532/5
Benjamin Mack [Wed, 13 May 2015 13:06:48 +0000 (21:06 +0800)]
[TASK] Make Content Element "Special Menus" field bigger

Increase the maxitems value to 50 to allow more values for bigger sites.

Releases: master
Resolves: #59523
Change-Id: Ie25974844bf7ce9f0b7995169964748872eb3f1a
Reviewed-on: http://review.typo3.org/39532
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Indexed_search: cleanup in SearchController 87/39587/3
Tymoteusz Motylewski [Tue, 17 Mar 2015 18:05:21 +0000 (19:05 +0100)]
[TASK] Indexed_search: cleanup in SearchController

* Add getter for databaseConnection in SearchController
* Add use statements

Releases: master
Resolves: #66998
Change-Id: I8c4e98cbf3ed0c1fb8b9d8876d6094028c2e5a49
Reviewed-on: http://review.typo3.org/39587
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Crop scheduler additional information 94/39594/2
Andreas Fernandez [Mon, 18 May 2015 08:05:14 +0000 (10:05 +0200)]
[TASK] Crop scheduler additional information

Crop additional task information based on `titleLen`.

Resolves: #67002
Releases: master
Change-Id: I16b2f7106b8485989e1df2ab4958d61308a8e3c7
Reviewed-on: http://review.typo3.org/39594
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Remove login security levels super-/challenged 76/39576/10
Markus Klein [Fri, 15 May 2015 23:19:59 +0000 (01:19 +0200)]
[!!!][TASK] Remove login security levels super-/challenged

* Remove (super)challenged login security levels
* Make loginSecurityLevel 'normal' the new default
* Change Backend login JS to use real submit event
* Refine hook usage of LoginController
* Remove unused code in ext:sv

Note:
OpenId login is broken due to hidden, but required, password field.
This will be resolved with the new Backend login API. #66669

Resolves: #66997
Releases: master
Change-Id: I280783588aabc78bc9bd9d1c7ee12e67bac9ed63
Reviewed-on: http://review.typo3.org/39576
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Add missing (string) cast in dbal/DatabaseConnection 25/39625/2
Morton Jonuschat [Tue, 19 May 2015 17:25:11 +0000 (19:25 +0200)]
[BUGFIX] Add missing (string) cast in dbal/DatabaseConnection

This is a regression fix for #54091.
It has been forgotten to cast the lastQuery to a string before
checking if it's empty

Resolves: #67040
Related: #54091
Releases: master
Change-Id: I6991cad799e686066f8205749baee4aed20a9127
Reviewed-on: http://review.typo3.org/39625
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Remove backdrop of cropper modal properly 17/39617/2
Andreas Fernandez [Tue, 19 May 2015 10:31:43 +0000 (12:31 +0200)]
[BUGFIX] Remove backdrop of cropper modal properly

Remove the `remove()` call when the cropper modal gets
closed.

Resolves: #67030
Related: #66969
Releases: master
Change-Id: Ibec6f8ee803ce4b4d6528367f25608cf0b38e21f
Reviewed-on: http://review.typo3.org/39617
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] Simplify PackageManagement / Remove Flow 18/39518/11
Benjamin Mack [Wed, 13 May 2015 06:47:31 +0000 (14:47 +0800)]
[!!!][TASK] Simplify PackageManagement / Remove Flow

The PackageManager was originally backported from Flow
but includes too many classes and options that the Core does not
use or cannot use at all.

The Package code is thus merged with only the parts needed
for the TYPO3 Core, and adapted accordingly. All Flow classes
are either removed or merged into the needed Package classes
of the TYPO3 Core.

In order to speed up the bootstrap and prepare for tight composer
integration, this task needs to be sorted out first.

Next step is to further cleanup code within the Package*
classes themselves - things that are not called at all in
the TYPO3 Core.

Resolves: #67027
Releases: master
Change-Id: Ia6823374afa515902e3d5237cef596a440747e3b
Reviewed-on: http://review.typo3.org/39518
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Deprecate page.bgImg TypoScript option 14/39614/3
Wouter Wolters [Tue, 19 May 2015 09:23:36 +0000 (11:23 +0200)]
[TASK] Deprecate page.bgImg TypoScript option

Resolves: #67029
Releases: master
Change-Id: I0f92ea91875455ea0e6726b11cf07f53b468e3a6
Reviewed-on: http://review.typo3.org/39614
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Add missing comma in ViewHelper example 18/39618/2
Georg Ringer [Tue, 19 May 2015 11:03:40 +0000 (13:03 +0200)]
[BUGFIX] Add missing comma in ViewHelper example

A comma needs to be added in an example of f:uri.image

Resolves: #66851
Releases: master, 6.2
Change-Id: Ib0a8f3d97a3f51b075b1e0e6a2208ae4c659ed6d
Reviewed-on: http://review.typo3.org/39618
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Travis: Remove hhvm-nightly for now 15/39615/2
Christian Kuhn [Tue, 19 May 2015 10:05:21 +0000 (12:05 +0200)]
[TASK] Travis: Remove hhvm-nightly for now

hhvm-nightly is no longer available on travi-ci and removed
from the build for now.

Releases: master
Change-Id: I92751c17e6e2a2f55fd956ff0a9fe069edb180aa
Reviewed-on: http://review.typo3.org/39615
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Prevent wrong record copies 05/39605/4
Nicole Cordes [Tue, 19 May 2015 07:28:46 +0000 (09:28 +0200)]
[BUGFIX] Prevent wrong record copies

Before starting any record copy process, we have to check if the
destination page can handle the record type. Currently if you copy a
record with IRRE references, the references are copied first but the
original record isn't copied because of missing permissions. The
copied IRRE elements stay and pollute the original record as the
references are added to it. This patch adds a check if the destination
page can handle the mother record type and starts copy process only if
allowed.

Resolves: #66920
Releases: master, 6.2
Change-Id: I274792b13170f37e3e799ff892ea877ba44d90a8
Reviewed-on: http://review.typo3.org/39605
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[!!!][TASK] Remove global configuration option GFX/png_to_gif 75/39475/6
Benjamin Mack [Tue, 12 May 2015 04:45:22 +0000 (12:45 +0800)]
[!!!][TASK] Remove global configuration option GFX/png_to_gif

The option png_to_gif was previously used to minimize
the size of generated images. In the current web development
png (with the support of all major browsers) has overtaken gif
functionality. The option, which was off by default for some
versions, has been removed. All calls to the actual "convert"
method in GraphicalFunction have been removed, the function
itself has been marked for deprecation.

Resolves: #66906
Releases: master
Change-Id: I1e134812f55ce8026e468b12ec12ec61e4d9d104
Reviewed-on: http://review.typo3.org/39475
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Focus tab on "Login expiring" notification 06/39606/2
Andreas Fernandez [Mon, 18 May 2015 21:15:24 +0000 (23:15 +0200)]
[TASK] Focus tab on "Login expiring" notification

Focus the tab that renders the "Login expiring" notification on click.

Resolves: #67022
Releases: master
Change-Id: I740d1ddaf07f58124045929f69b8b2642bc24828
Reviewed-on: http://review.typo3.org/39606
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Enable IE10+ users to enter login credentials after initial load 04/39604/2
Benjamin Kott [Mon, 18 May 2015 19:04:38 +0000 (21:04 +0200)]
[BUGFIX] Enable IE10+ users to enter login credentials after initial load

A problem with the autofocus chain and the autofocus attribute,
prevented users on IE10+ to enter their login credentials for
backend access directly after initial load.

Releases: master
Resolves: #67024
Change-Id: I21af4156345f610433d3f4f8d02aa1804dae2f2b
Reviewed-on: http://review.typo3.org/39604
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] felogin: Use correct regex in redirect evaluation 00/39600/4
Markus Klein [Mon, 18 May 2015 17:28:00 +0000 (19:28 +0200)]
[BUGFIX] felogin: Use correct regex in redirect evaluation

Resolves: #67013
Releases: master, 6.2
Change-Id: Ifaf0a3125ac6b5c0f9e13c2f5c3d4db94aa43ea9
Reviewed-on: http://review.typo3.org/39600
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Use GeneralUtility::quoteJSvalue() where needed part 2 37/39037/7
Wouter Wolters [Tue, 28 Apr 2015 17:00:33 +0000 (19:00 +0200)]
[TASK] Use GeneralUtility::quoteJSvalue() where needed part 2

This patch resolves it for all FormEngine related classes.

Resolves: #66635
Releases: master
Change-Id: I436e8990aa3c003dd5005937a429168825b56fb5
Reviewed-on: http://review.typo3.org/39037
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Correctly insert session data after deleting them 97/39597/2
Markus Klein [Mon, 18 May 2015 11:07:36 +0000 (13:07 +0200)]
[BUGFIX] Correctly insert session data after deleting them

Reset session data timestamp when removing session data in order to
assure that new session data are stored via INSERT later again.

Resolves: #67007
Releases: master, 6.2
Change-Id: I181017687f9569d4e2a16ca3a970367b05cf7d52
Reviewed-on: http://review.typo3.org/39597
Reviewed-by: Johann Carstens <johann.carstens@conlabz.de>
Tested-by: Johann Carstens <johann.carstens@conlabz.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[FOLLOWUP][TASK] FormEngine: The factory 98/39598/2
Christian Kuhn [Mon, 18 May 2015 12:43:41 +0000 (14:43 +0200)]
[FOLLOWUP][TASK] FormEngine: The factory

Small follow up to fix some mostly cosmetical issues.

Resolves: #67006
Releases: master
Change-Id: Ie9ffab0e5bce9e8c97d87a6ff4c213e788cd1bf7
Reviewed-on: http://review.typo3.org/39598
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] FormEngine: The factory 17/39517/6
Christian Kuhn [Tue, 12 May 2015 21:41:46 +0000 (23:41 +0200)]
[TASK] FormEngine: The factory

Creation of container and elements instances in the FormEngine is
hard coded and hard to overwrite or adapt.
The patch extends the existing NodeFactory with resolver code to
find an appropriate class for a given requested type. All FormEngine
internal container and element requests are now routed through
NodeFactory. This allows to loosen the strict dependency between
TCA config "type" to an implementing class by moving the resolving
code into the factory. This is done for SelectElement which is now
split into multiple smaller classes - one for each display type. The
NodeFactory is covered by unit tests since the resolving code will
become more complex and fine grained in the future.
As a side effect the patch resolves a hack in the FormDataTraverser
which no longer calls internal stuff of the select element.
The NodeFactory is prepared to be extended with an API for extensions
to steer and overwrite default implementations. This will be added
with a next patch.

Change-Id: I2253a0fe3240366d0d271a3cd82119ce3dc52012
Resolves: #67006
Releases: master
Reviewed-on: http://review.typo3.org/39517
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] TypoScript condition add GPmerged 57/37157/10
Andreas Allacher [Tue, 24 Feb 2015 09:25:15 +0000 (10:25 +0100)]
[FEATURE] TypoScript condition add GPmerged

If one uses TypoScript condition with GP then the check is with
GeneralUtility::_GP() which will means that if I have GET variables
beginning with an extbase plugin-namespace and POST variables with
the same plugin-namespace, e.g.
GET: tx_demo_demo[action]=detail
POST: tx_demo_demo[name]=Foo

then GeneralUtility::_GP('tx_demo_demo'), as intended, will only
return the array of the POST variables for that namespace.

However, that results in the issue that if I check for the GET variable
the check will fail.

So for such cases there is a new TypoScript condition
GPmerged which uses GeneralUtility::_GPmerged()

Change-Id: I772c1c1d178b10e9293132bc41bfc36fabd53063
Resolves: #65250
Releases: master
Reviewed-on: http://review.typo3.org/37157
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Streamline searchfield in language module 88/39588/2
Benjamin Kott [Sun, 17 May 2015 09:31:04 +0000 (11:31 +0200)]
[TASK] Streamline searchfield in language module

Releases: master
Resolves: #66999
Change-Id: I3f2d9ff945021ac0a6f9aac79033ff05c0f55db4
Reviewed-on: http://review.typo3.org/39588
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[FOLLOWUP][!!!][TASK] Rewrite ValueSlider to AMD module 86/39586/2
Andreas Fernandez [Sun, 17 May 2015 06:12:10 +0000 (08:12 +0200)]
[FOLLOWUP][!!!][TASK] Rewrite ValueSlider to AMD module

The slider object bound to "renderTooltipValue" does not contain
the configuration set in the DOM by data attributes. Get the
element containing these attributes and us this instead.

Resolves: #66991
Releases: master
Change-Id: Ib8df38bc84cf9848b55995619d952b300dec0540
Reviewed-on: http://review.typo3.org/39586
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[TASK] Replace GeneralUtility::inList() with isset() within loops 38/37138/3
Jo Hasenau [Mon, 23 Feb 2015 20:08:00 +0000 (21:08 +0100)]
[TASK] Replace GeneralUtility::inList() with isset() within loops

Rule of thumb should be to use GeneralUtility::inList() for
single checks of lists with unknown values only. Within loops
it will be faster to explode the list outside the loop, then flip
the array and finally use isset on the array keys within the loop.

Hardcoded lists might be replaced with arrays as well.

See the issue on forge for a description and some benchmarks.

This will not fully resolve the issue since there will be more
patches to come, since we should avoid monster patches to minimize
the risk of regressions.

Releases: master
Resolves: #55626
Change-Id: I5a0d8ea6f71a4f8fd39587c5ec3bfcb557d4c777
Reviewed-on: http://review.typo3.org/37138
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[!!!][TASK] Rewrite ValueSlider to AMD module 16/38516/16
Wouter Wolters [Tue, 7 Apr 2015 16:27:01 +0000 (18:27 +0200)]
[!!!][TASK] Rewrite ValueSlider to AMD module

Resolves: #66991
Releases: master
Change-Id: Ib78eab523fb6ecdba415bf4b07e15690794c2da1
Reviewed-on: http://review.typo3.org/38516
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Speed and cleanup PageRepository 00/37800/8
Wouter Wolters [Thu, 12 Mar 2015 22:06:06 +0000 (23:06 +0100)]
[TASK] Speed and cleanup PageRepository

* use strict checks
* shorten namespaces
* remove count() were possible

Resolves: #65731
Releases: master
Change-Id: I297679d373669b5b75ffaae5111c400f69ac922a
Reviewed-on: http://review.typo3.org/37800
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Keep scroll position in Debug Console 79/39579/4
Andreas Fernandez [Sat, 16 May 2015 11:58:24 +0000 (13:58 +0200)]
[BUGFIX] Keep scroll position in Debug Console

If autoscroll is either disabled or content is written into
an inactive tab, stay at the scroll position of the affected tab.

Resolves: #66992
Releases: master
Change-Id: I8a3a16fe703a76ea3a66a31195b05e06e83b8987
Reviewed-on: http://review.typo3.org/39579
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Update twbs/bootstrap to 3.3.4 65/39565/3
Wouter Wolters [Fri, 15 May 2015 11:22:36 +0000 (13:22 +0200)]
[TASK] Update twbs/bootstrap to 3.3.4

Resolves: #66969
Releases: master
Change-Id: Icd0e6a2193da9868c1456061dd089ee293329afe
Reviewed-on: http://review.typo3.org/39565
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Constant editor doesn't show new values after save 75/39575/3
Sebastian Michaelsen [Fri, 15 May 2015 20:44:17 +0000 (22:44 +0200)]
[BUGFIX] Constant editor doesn't show new values after save

Re-read the constant values to be displayed in the form after a data
update was performed.

Resolves: #65824
Releases: master
Change-Id: Ibfdd42b5fd6ce1103b6787594f9eaee60ea14223
Reviewed-on: http://review.typo3.org/39575
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Cleanup of TYPO3\CMS\Core\Localization and Charset 08/39508/4
Stephan Großberndt [Tue, 12 May 2015 20:38:28 +0000 (22:38 +0200)]
[TASK] Cleanup of TYPO3\CMS\Core\Localization and Charset

* Make use of use-statements
* fix typos
* properly align comments
* fix PHPDoc
* fix bool signatures
* remove unused variables
* rename some cryptic variables
* check for equality using === and !== where possible
* use !empty() instead of count()

Resolves: #66924
Releases: master
Change-Id: I44675b3e8c8626591feaa017e53cae1426cd1da3
Reviewed-on: http://review.typo3.org/39508
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix usage of moment.js in Language 23/39523/3
Andreas Fernandez [Wed, 13 May 2015 09:03:06 +0000 (11:03 +0200)]
[BUGFIX] Fix usage of moment.js in Language

Fix the import of moment.js in the RequireJS module used
in the Language backend module.

Resolves: #66931
Releases: master
Change-Id: I8cf669f05d04c36496354a1b7133cc0bda4233cc
Reviewed-on: http://review.typo3.org/39523
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Streamline table wizard 66/39566/2
Benjamin Kott [Fri, 15 May 2015 12:31:18 +0000 (14:31 +0200)]
[TASK] Streamline table wizard

Releases: master
Resolves: #66971
Change-Id: Id0da50761c8197559a2298b321fe283a975f71a3
Reviewed-on: http://review.typo3.org/39566
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
4 years ago[BUGFIX] Valid Content-Type header for jpg thumbnails 82/39482/3
Stephan Großberndt [Tue, 12 May 2015 11:07:32 +0000 (13:07 +0200)]
[BUGFIX] Valid Content-Type header for jpg thumbnails

Use "Content-Type: image/jpeg" instead of invalid "image/jpg" derived
from the file extension. The invalid Content-Type in combination with
"X-Content-Type-Options: nosniff" leads to thumbnails not showing up in
Internet Explorer.

While at it also correct the case of "Etag" to "ETag".

Resolves: #66913
Releases: master, 6.2
Change-Id: I9a31817e32e4e8b2b99b3008f8381608c5ac06e9
Reviewed-on: http://review.typo3.org/39482
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Render section index menu if page is not in menu 72/24872/5
Benjamin Mack [Fri, 8 May 2015 05:53:30 +0000 (13:53 +0800)]
[BUGFIX] Render section index menu if page is not in menu

This patch fixes the behaviour that a section index menu
is not rendered, if the page whose sections should be shown
has the flag "no in menu".

Resolves: #50873
Releases: master
Change-Id: Ibe1c0ac99d225ab4f9d315d576c39f477e03a3b7
Reviewed-on: http://review.typo3.org/24872
Reviewed-by: DANIEL Rémy <dogawaf@no-log.org>
Tested-by: DANIEL Rémy <dogawaf@no-log.org>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Remove unused module file list CSS 64/39564/2
Benjamin Kott [Fri, 15 May 2015 10:43:29 +0000 (12:43 +0200)]
[TASK] Remove unused module file list CSS

Releases: master
Resolves: #66967
Change-Id: I81d74108e4ec4e98c239616ce1e880b3e03bf1d3
Reviewed-on: http://review.typo3.org/39564
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Update moment to 2.10.3 62/39562/2
Wouter Wolters [Fri, 15 May 2015 08:09:43 +0000 (10:09 +0200)]
[TASK] Update moment to 2.10.3

Resolves: #66964
Releases: master
Change-Id: I08aa8539c1ba13cfd31a2a3902252877c4dd40ae
Reviewed-on: http://review.typo3.org/39562
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Update cropper to 0.9.3 63/39563/2
Wouter Wolters [Fri, 15 May 2015 08:12:37 +0000 (10:12 +0200)]
[TASK] Update cropper to 0.9.3

Resolves: #66965
Releases: master
Change-Id: I9ee15614e785475ea6ff1656de861bf32b6548df
Reviewed-on: http://review.typo3.org/39563
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Cleanup CSS and JS in documentation module 89/38289/4
Benjamin Kott [Fri, 27 Mar 2015 01:38:10 +0000 (02:38 +0100)]
[TASK] Cleanup CSS and JS in documentation module

Releases: master
Resolves: #66966

Change-Id: I18ee4c51727641d3b2ba8ce352c9622e65d31307
Reviewed-on: http://review.typo3.org/38289
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Cleanup DragUploader CSS 55/39555/2
Benjamin Kott [Thu, 14 May 2015 20:44:51 +0000 (22:44 +0200)]
[TASK] Cleanup DragUploader CSS

Releases: master
Resolves: #66963
Change-Id: If2c346be8c19da2585a4758a8ee5dc6f4d7266ec
Reviewed-on: http://review.typo3.org/39555
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Update DataTables to 1.10.7 47/39547/3
Wouter Wolters [Thu, 14 May 2015 15:37:09 +0000 (17:37 +0200)]
[TASK] Update DataTables to 1.10.7

Resolves: #66271
Releases: master
Change-Id: I6be3264173e69d6ebf36367ecb8947b7d699f978
Reviewed-on: http://review.typo3.org/39547
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>