Packages/TYPO3.CMS.git
5 years ago[TASK] Cleanup EXT:indexed_search 08/28308/5
Wouter Wolters [Thu, 13 Mar 2014 22:26:44 +0000 (23:26 +0100)]
[TASK] Cleanup EXT:indexed_search

* Move modAccess check to constructor
* Move isLoaded check to constructor
* Remove check if extbase is loaded
* Replace $TYPO3_CONF_VARS to $GLOBALS['TYPO3_CONF_VARS']

Resolves: #56831
Releases: 6.2
Change-Id: Ib824d34219bc1afb646fbaf70b572b6bd3a55a47
Reviewed-on: https://review.typo3.org/28308
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Cleanup EXT:openid 09/28309/2
Wouter Wolters [Wed, 12 Mar 2014 18:15:48 +0000 (19:15 +0100)]
[TASK] Cleanup EXT:openid

* Remove deprecated calls to require_once
* Restore license header
* Remove empty TODO file

Resolves: #56832
Releases: 6.2
Change-Id: I291f5469638659d64e9df181017d1588f27317e1
Reviewed-on: https://review.typo3.org/28309
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move modAccess and language include in EXT:taskcenter 15/28315/3
Wouter Wolters [Wed, 12 Mar 2014 18:56:30 +0000 (19:56 +0100)]
[TASK] Move modAccess and language include in EXT:taskcenter

Resolves: #56838
Releases: 6.2
Change-Id: Iac44b90bc96529458a2e452e47cb5548600464b0
Reviewed-on: https://review.typo3.org/28315
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move modAccess and language include in EXT:perm 11/28311/3
Wouter Wolters [Wed, 12 Mar 2014 18:29:13 +0000 (19:29 +0100)]
[TASK] Move modAccess and language include in EXT:perm

Resolves: #56834
Releases: 6.2
Change-Id: Iec646bbae646bb85479f9f19c438e6aa9283e0dd
Reviewed-on: https://review.typo3.org/28311
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move modAccess and language include in EXT:scheduler 14/28314/3
Wouter Wolters [Wed, 12 Mar 2014 18:48:58 +0000 (19:48 +0100)]
[TASK] Move modAccess and language include in EXT:scheduler

Resolves: #56837
Releases: 6.2
Change-Id: Ieec0e8f532abd8fab0444e137c31424f1a69b67e
Reviewed-on: https://review.typo3.org/28314
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move modAccess and language include in EXT:recycler 13/28313/3
Wouter Wolters [Wed, 12 Mar 2014 18:38:13 +0000 (19:38 +0100)]
[TASK] Move modAccess and language include in EXT:recycler

* Remove deprecated require_once call

Resolves: #56835
Releases: 6.2
Change-Id: I7d79b4c9947c5f3da82c66a4dbb0e3d2e0fd9284
Reviewed-on: https://review.typo3.org/28313
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Tests: Improve Mocking in ext:extbase 65/28365/2
Anja Leichsenring [Thu, 13 Mar 2014 21:07:57 +0000 (22:07 +0100)]
[BUGFIX] Tests: Improve Mocking in ext:extbase

Unittests reveal some warnings which are caused by incomplete mocking.

Change-Id: Iee09220d675335aeadd286c2d4544d53c981016f
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28365
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] PHP-functionality instead of GeneralUtility::deHSCentities 80/22580/8
Stefan Neufeind [Wed, 5 Feb 2014 11:52:05 +0000 (12:52 +0100)]
[TASK] PHP-functionality instead of GeneralUtility::deHSCentities

Use native PHP-functionality provided by htmlspecialchars()
with a parameter since PHP 5.2.3 to prevent double-encoding
instead of calling deHSCentities().

Change-Id: I2863181259046f16b554770a3f1ed8b03112fedf
Resolves: #50449
Releases: 6.2
Reviewed-on: https://review.typo3.org/22580
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Pascal Dürsteler
Reviewed-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Extbase tries to overlay pages_language_overlay records 33/28333/2
Stanislas Rolland [Thu, 13 Mar 2014 01:46:22 +0000 (21:46 -0400)]
[BUGFIX] Extbase tries to overlay pages_language_overlay records

Method doLanguageAndWorkspaceOverlay of
Extbase\Persistence\Generic\Storage\Typo3DbBackend should not attempt
to get a parent record if the overlays are in a separate table (most
probably pages_language_overlay) by checking whether
$GLOBALS['TCA'][$tableName]['ctrl']['transOrigPointerTable'] is set.

Resolves: #56855
Releases: 6.0, 6.1, 6.2
Change-Id: I2cb53bc4733ee626ca0ae92e5dd91073d88ecc9d
Reviewed-on: https://review.typo3.org/28333
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] TCA title of table sys_file_metadata is "File" 61/28361/2
Xavier Perseguers [Thu, 13 Mar 2014 20:49:52 +0000 (21:49 +0100)]
[BUGFIX] TCA title of table sys_file_metadata is "File"

Table sys_file_metadata shares the same title as table sys_file
which makes it impossible to distinguish when granting access
in a be_groups record.

Fixes: #56890
Releases: 6.2
Change-Id: Ibce38f0f878e34c06a0d66c550fe7bf62cc33700
Reviewed-on: https://review.typo3.org/28361
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Missing icons for some core db tables 90/28290/4
Frans Saris [Tue, 11 Mar 2014 08:24:03 +0000 (09:24 +0100)]
[BUGFIX] Missing icons for some core db tables

The records of EXT:extensionmanager are also set to adminOnly=TRUE

Resolves: #56808
Releases: 6.2
Change-Id: I79f7dae056c8ede8e041f71200dc1f88b7a5551c
Reviewed-on: https://review.typo3.org/28290
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Warnings in ArrayUtility with some PHP versions 59/28359/2
Christian Kuhn [Thu, 13 Mar 2014 20:09:52 +0000 (21:09 +0100)]
[BUGFIX] Warnings in ArrayUtility with some PHP versions

PHP issue https://bugs.php.net/bug.php?id=50688 triggers a warning
in ArrayUtility::sortArraysByKey() on some supported PHP versions
like debian wheezy 5.4.4. Since this is a language error and the
code itself is correct and covered by unit tests, the warning is
now suppressed using the @ operator.

Change-Id: Ie169774d8659e55542f0c831078c00958de257c9
Resolves: #56889
Relases: 6.2
Reviewed-on: https://review.typo3.org/28359
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Link to extension manual 52/28352/6
Xavier Perseguers [Thu, 13 Mar 2014 15:30:03 +0000 (16:30 +0100)]
[TASK] Link to extension manual

If an extension manual is available locally, it should be
linked in Extension Manager.

Resolves: #56880
Releases: 6.2
Change-Id: I24572348e0dc79513ece37477e3aee186676d923
Reviewed-on: https://review.typo3.org/28352
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] ClickMenu: Visibility-options only if fields allowed 48/27348/8
Stefan Neufeind [Tue, 4 Feb 2014 23:38:04 +0000 (00:38 +0100)]
[BUGFIX] ClickMenu: Visibility-options only if fields allowed

So far the entries "Hide/Unhide" and "Visibility settings" always
showed up in the ClickMenu. We need to check via excludefields if the
other has any right to change such a field or hide the icons.

Change-Id: Ib86fbd6d30f2cc0ec52e506d5fa2f12c95a2f178
Resolves: #55683
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/27348
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Tests: MemcacheBackendTest throws warnings 57/28357/3
Christian Kuhn [Thu, 13 Mar 2014 19:08:40 +0000 (20:08 +0100)]
[BUGFIX] Tests: MemcacheBackendTest throws warnings

setUp() of memcache cache backend tests checks with fsockopen() if
a connect to memcache is possible to skip the tests if memcache is
not available. If fsockopen fails it throws a warning, this should
be suppressed.

Change-Id: I8590d20201e76f0768e5beb0c9b549b2b48933ec
Resolves: #56885
Releases: 6.2
Reviewed-on: https://review.typo3.org/28357
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Include PHP warnings as exceptional errors 91/28191/5
Markus Klein [Sun, 9 Mar 2014 13:41:39 +0000 (14:41 +0100)]
[TASK] Include PHP warnings as exceptional errors

Resolves: #56683
Releases: 6.2
Change-Id: I471e5b44eeb2dcb29217fbea3a33b4aba95e2cdd
Reviewed-on: https://review.typo3.org/28191
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Move modAccess and language include in EXT:filelist 04/28304/3
Wouter Wolters [Wed, 12 Mar 2014 16:59:46 +0000 (17:59 +0100)]
[TASK] Move modAccess and language include in EXT:filelist

* Remove deprecated require_once call

Resolves: #56827
Releases: 6.2
Change-Id: Iae4b666f7bb3ff81194ea6a6ff51b84fd9a1112c
Reviewed-on: https://review.typo3.org/28304
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[FEATURE] Signal to process actions in Extension Manager 47/28347/2
Xavier Perseguers [Thu, 13 Mar 2014 13:10:26 +0000 (14:10 +0100)]
[FEATURE] Signal to process actions in Extension Manager

This adds a way for third party extensions to process
extensions' available actions in Extension Manager.

Resolves: #56869
Releases: 6.2
Change-Id: I7cbacba7fccfd3178dc1265ad69bf5dec531cf70
Reviewed-on: https://review.typo3.org/28347
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Show thumbnails in list module 42/28342/5
Markus Klein [Thu, 13 Mar 2014 11:28:55 +0000 (12:28 +0100)]
[BUGFIX] Show thumbnails in list module

Add missing checks if type column exists in a row.

Resolves: #56830
Releases: 6.2, 6.1
Change-Id: Ifafdb0c51266c76620696c6d94471b3efddba112
Reviewed-on: https://review.typo3.org/28342
Reviewed-by: Andreas Kiessling
Tested-by: Andreas Kiessling
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Remove checks for extensions which are always loaded 35/28335/2
Georg Ringer [Thu, 13 Mar 2014 08:13:13 +0000 (09:13 +0100)]
[TASK] Remove checks for extensions which are always loaded

There are several calls to check if extensions like extbase are loaded.
As those extensions cannot be removed and are always loaded,
the code can be removed.

Resolves: #56858
Releases: 6.2
Change-Id: I434daaa2e5ae98ac623e8c9c06a0cb41560d3610
Reviewed-on: https://review.typo3.org/28335
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Fix xml2array values for attributes type NULL 45/27845/3
Marc Bastian Heinrichs [Tue, 25 Feb 2014 15:10:05 +0000 (16:10 +0100)]
[BUGFIX] Fix xml2array values for attributes type NULL

Method array2xml converts elements with value NULL to
nodes with attribute type "NULL" and empty value, e.g.:
<node index="myIndex" type="NULL"></node>
This is not correct transformed back in xml2array and results
in an empty string as value.
This in turn results in wrong imported data using impexp with
xml format.

Resolves: #55082
Releases: 6.2
Change-Id: Icfea2f2b7524c44711866c3f75f06331a1958183
Reviewed-on: https://review.typo3.org/27845
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Adopt the method comment to reflect changes of names 39/28339/2
Georg Ringer [Thu, 13 Mar 2014 10:26:55 +0000 (11:26 +0100)]
[TASK] Adopt the method comment to reflect changes of names

Some constants have been renamed in #10655 but the method comments still
use the old names

Resolves: #54947
Releases: 6.2
Change-Id: Ia40062b190139dd6d1adf9a248247b81986fc402
Reviewed-on: https://review.typo3.org/28339
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[FEATURE] Allow escaping of dots in TypoScript key 80/19480/24
Markus Klein [Mon, 24 Feb 2014 17:05:42 +0000 (18:05 +0100)]
[FEATURE] Allow escaping of dots in TypoScript key

This patch allows the use of backslashes to escape dots in
TypoScript keys, for example:

my\.escaped\.key = test

will result in a single key "my.escaped.key" with the
value "test".

Additionally it is possible to protect backslashes from beeing
interpreted as escape characters by using double backslashes.

Resolves: #29461
Documentation: #56249
Releases: 6.2
Change-Id: Idcaae75d9a8800134f4a82e0740ddabe35b3df89
Reviewed-on: https://review.typo3.org/19480
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Add missing icons for main backend modules 93/28293/2
Frans Saris [Wed, 12 Mar 2014 13:05:43 +0000 (14:05 +0100)]
[BUGFIX] Add missing icons for main backend modules

Resolves: #56809
Releases: 6.2
Change-Id: I5ea532065ef0be0fd279fe53d9498ae0df849af8
Reviewed-on: https://review.typo3.org/28293
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Use cHash in language menu links if necessary 42/21242/4
Dmitry Dulepov [Wed, 5 Jun 2013 13:05:49 +0000 (16:05 +0300)]
[BUGFIX] Use cHash in language menu links if necessary

Current menu implementation does not add the cHash in language
menus. This causes a non-cached page and performance
degradation if the page contains parameters and a user switches
between languages. Together with extensions like RealURL it
can become a long time issue because of the caching of wrong
URLs. The fix implements analysis for the query string and
relevant parameters to decide whether the cHash should be
added or not.

Change-Id: I711e732555e03c9bf5a1321523b505735aa20c41
Resolves: #33833
Releases: 6.2
Reviewed-on: https://review.typo3.org/21242
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Add "ts" to the textfile_ext 17/28317/5
Eric Chavaillaz [Wed, 12 Mar 2014 19:06:57 +0000 (20:06 +0100)]
[TASK] Add "ts" to the textfile_ext

The extension "ts" for typoscript is missing in the
default configuration. This patch adds it.

The goal is that the typoscript files can be edited
in the backend.

Resolves: #48812
Releases: 6.2
Change-Id: I40aca45f482e132b21aab03925d2cecd126e30ab
Reviewed-on: https://review.typo3.org/28317
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove wrong deprecation comment in EXT:impexp 06/28306/2
Wouter Wolters [Wed, 12 Mar 2014 17:47:11 +0000 (18:47 +0100)]
[TASK] Remove wrong deprecation comment in EXT:impexp

Resolves: #56829
Releases: 6.2
Change-Id: I7e710e1e901c0aa9a29e58aaeb29edea83a47238
Reviewed-on: https://review.typo3.org/28306
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove locking around log files 12/28312/2
Philipp Gampe [Wed, 12 Mar 2014 18:27:08 +0000 (19:27 +0100)]
[TASK] Remove locking around log files

Log files are opened in append mode and concurrency is handled by the
operation system. The PHP documentation declares fwrite
to be atomic for normal operations.

Resolves: #56833
Releases: 6.2
Change-Id: I151fdf8ce0e237d52263ad8fbc77207fd9940633
Reviewed-on: https://review.typo3.org/28312
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated genTreeStatus in DatabaseIntegrityCheck 22/28322/2
Wouter Wolters [Wed, 12 Mar 2014 19:44:32 +0000 (20:44 +0100)]
[TASK] Remove deprecated genTreeStatus in DatabaseIntegrityCheck

Resolves: #56844
Releases: 6.2
Change-Id: Ic49eb279b8cc3df9da93a153b407e0f7dea0396f
Reviewed-on: https://review.typo3.org/28322
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated functions from GeneralUtility 23/28323/2
Wouter Wolters [Wed, 12 Mar 2014 19:48:37 +0000 (20:48 +0100)]
[TASK] Remove deprecated functions from GeneralUtility

getValidClassPrefixes
hasValidClassPrefix

Resolves: #56845
Releases: 6.2
Change-Id: I14ffedbe603a5b5117abfd38b4d25fa12e0cb422
Reviewed-on: https://review.typo3.org/28323
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated functions from TypoScriptFrontendController 27/28327/2
Wouter Wolters [Wed, 12 Mar 2014 20:04:11 +0000 (21:04 +0100)]
[TASK] Remove deprecated functions from TypoScriptFrontendController

fe_tce
isEXTincScript
getLogIPAddress
getLogHostName
getLogUserName

Resolves: #56849
Releases: 6.2
Change-Id: Ib740ebfbb29734f41e4024746132dd306f4fdd2c
Reviewed-on: https://review.typo3.org/28327
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated prepareVariableForJavascript from DebugUtility 24/28324/2
Wouter Wolters [Wed, 12 Mar 2014 19:53:14 +0000 (20:53 +0100)]
[TASK] Remove deprecated prepareVariableForJavascript from DebugUtility

Resolves: #56846
Releases: 6.2
Change-Id: Id769a6fb25cd8c207d2591f6b8f9b95165d04e05
Reviewed-on: https://review.typo3.org/28324
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated functions from ContentObjectRenderer 28/28328/3
Wouter Wolters [Wed, 12 Mar 2014 20:07:31 +0000 (21:07 +0100)]
[TASK] Remove deprecated functions from ContentObjectRenderer

HTML
PHP_SCRIPT

Resolves: #56850
Related: #36009
Related: #36402
Releases: 6.2
Change-Id: I2abfae16b7eed9b360524b6553854e4b1cbf08bc
Reviewed-on: https://review.typo3.org/28328
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated modifyPageId hook 26/28326/2
Wouter Wolters [Wed, 12 Mar 2014 19:58:45 +0000 (20:58 +0100)]
[TASK] Remove deprecated modifyPageId hook

Resolves: #56848
Releases: 6.2
Change-Id: Icb1e0566dc44dbf7278db50224dc256b94be853b
Reviewed-on: https://review.typo3.org/28326
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated getCount in FolderTreeView 18/28318/2
Wouter Wolters [Wed, 12 Mar 2014 19:14:11 +0000 (20:14 +0100)]
[TASK] Remove deprecated getCount in FolderTreeView

Resolves: #56840
Releases: 6.2
Change-Id: I7a09565946663fe8ca1e3d1c88c74f5c4ac1975e
Reviewed-on: https://review.typo3.org/28318
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated makeCopyrightNotice 16/28316/2
Wouter Wolters [Wed, 12 Mar 2014 19:10:00 +0000 (20:10 +0100)]
[TASK] Remove deprecated makeCopyrightNotice

Resolves: #56839
Releases: 6.2
Change-Id: I1a8006c7c34a3e38674ae6e114c6cbe6845c17eb
Reviewed-on: https://review.typo3.org/28316
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated stripTagsExcept from HtmlParser 25/28325/2
Wouter Wolters [Wed, 12 Mar 2014 19:55:15 +0000 (20:55 +0100)]
[TASK] Remove deprecated stripTagsExcept from HtmlParser

Resolves: #56847
Releases: 6.2
Change-Id: I69ff622366a365305e68f858d0c18611a563595c
Reviewed-on: https://review.typo3.org/28325
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated showSysNotesForPage in AbstractDatabaseRecordList 21/28321/2
Wouter Wolters [Wed, 12 Mar 2014 19:42:52 +0000 (20:42 +0100)]
[TASK] Remove deprecated showSysNotesForPage in AbstractDatabaseRecordList

Resolves: #56843
Releases: 6.2
Change-Id: I9a342144f343196a9f8c199dfc311668707c1e66
Reviewed-on: https://review.typo3.org/28321
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove deprecated initCharset from DocumentTemplate 19/28319/4
Wouter Wolters [Wed, 12 Mar 2014 19:16:10 +0000 (20:16 +0100)]
[TASK] Remove deprecated initCharset from DocumentTemplate

Removes also the deprecated method initCharset

Resolves: #56841
Releases: 6.2
Change-Id: I8e94a7ce43075f96bed857bbda4567a5165f5967
Reviewed-on: https://review.typo3.org/28319
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Remove wrong deprecation comment in EXT:form 20/28320/2
Wouter Wolters [Wed, 12 Mar 2014 19:35:12 +0000 (20:35 +0100)]
[TASK] Remove wrong deprecation comment in EXT:form

Resolves: #56842
Releases: 6.2
Change-Id: I709607157776100043969f0ffa8f801ba83bc6aa
Reviewed-on: https://review.typo3.org/28320
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Correctly validate New Content Element entries 88/27588/4
Ludwig Rafelsberger [Wed, 12 Feb 2014 19:36:09 +0000 (20:36 +0100)]
[BUGFIX] Correctly validate New Content Element entries

Each entry in the New Content Element wizard is tested to be valid,
i.e. the tt_content_defValues defined by that entry must be allowed
for the current BE user. Also, an entry may not select values that are
removed via TSconfig.

Setting TCEFORM.tt_content.[column].keepItems acts as a whitelist of
allowed values for *that* column. But the validity checks are done
hardcoded against the *CType* column.

Resolves: #23864
Releases: 6.2, 6.1
Change-Id: I5b6578f35552bd571fc822ac72f8f5fe12fe11f7
Reviewed-on: https://review.typo3.org/27588
Reviewed-by: Stefan Neufeind
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Missing localizeChildrenAtParentLocalization for CSV tests 99/28299/2
Oliver Hader [Wed, 12 Mar 2014 13:59:34 +0000 (14:59 +0100)]
[BUGFIX] Missing localizeChildrenAtParentLocalization for CSV tests

The "localizeChildrenAtParentLocalization" behaviour needs to be
set to automatically localize children for IRRE CSV functional
tests as well.

Resolves: #56819
Releases: 6.2
Change-Id: I14a09e715ad9674922776de450d519583770e0f5
Reviewed-on: https://review.typo3.org/28299
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] InvalidArgumentException in ActionControllerTest 00/28300/2
Oliver Hader [Wed, 12 Mar 2014 15:16:26 +0000 (16:16 +0100)]
[BUGFIX] InvalidArgumentException in ActionControllerTest

The cache identifier causing the exception looks like this:
randomviewobjectpattern_@package_mycontroller_myaction_myformat

However, "@package" should be "@extension" in that regard and
besides that, the cache identifier using the vendor names shall
be used in the tests.

Resolves: #56822
Releases: 6.2
Change-Id: Ic78a8690559486efcbc7f5da7219a445f3f6707f
Reviewed-on: https://review.typo3.org/28300
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Follow-up to "Add functional tests for generic persistence" 97/28297/2
Ernesto Baschny [Wed, 12 Mar 2014 13:50:35 +0000 (14:50 +0100)]
[TASK] Follow-up to "Add functional tests for generic persistence"

Test directory changed from "Relation" to "Persistence".

Resolves: #55661
Related: #55360
Related: #55167
Releases: 6.2

Change-Id: I422dbfb6bdad4215bdc70dea775917cf3159605f
Reviewed-on: https://review.typo3.org/28297
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[TASK] Add functional tests for generic persistence 62/28262/7
Felix Oertel [Tue, 11 Mar 2014 15:39:13 +0000 (16:39 +0100)]
[TASK] Add functional tests for generic persistence

To backup the changes in Extbase's generic persistence,
we add some functional tests.

Resolves: #55661
Related: #55360
Related: #55167
Releases: 6.2
Change-Id: I0b845618b1cec9788ca36ac59e25ea6779f01cb6
Reviewed-on: https://review.typo3.org/28262
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] FollowUp to #56797 in I1f15fbd262036b6b2d0159cd0e9613ad7135a296 96/28296/3
Steffen Ritter [Wed, 12 Mar 2014 13:23:36 +0000 (14:23 +0100)]
[BUGFIX] FollowUp to #56797 in I1f15fbd262036b6b2d0159cd0e9613ad7135a296

Somehow a double $this->$this slipped into the cleanup on line 390
which now fatals. This needs to be fixed.

Resolves: #56797
Releases: 6.2
Change-Id: Ibb23b5f56c95106c4fea6e9a3ba09fbc9f9905dd
Reviewed-on: https://review.typo3.org/28296
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Wrong namespace in functional test of FluidTemplate cObject 94/28294/2
Philipp Gampe [Wed, 12 Mar 2014 13:13:35 +0000 (14:13 +0100)]
[BUGFIX] Wrong namespace in functional test of FluidTemplate cObject

Resolves: #56816
Releases: 6.2
Change-Id: I3abed35a5e27bdc9db2b18d5caa13681ef5a9305
Reviewed-on: https://review.typo3.org/28294
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Download link for absolute file path 68/28168/5
Marian Pollzien [Fri, 7 Mar 2014 16:26:58 +0000 (17:26 +0100)]
[BUGFIX] Download link for absolute file path

Support FAL adapters that return absolute urls as public file url

Change-Id: I68f2675a1a5137e6d0c5cadee7b21e82e8730fdf
Resolves: #56659
Releases: 6.2
Reviewed-on: https://review.typo3.org/28168
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Use prepared statements in generic persistence 26/27426/19
Felix Oertel [Tue, 4 Feb 2014 15:42:29 +0000 (16:42 +0100)]
[TASK] Use prepared statements in generic persistence

While Typo3DbBackend claims to be the glue between Extbase
and TYPO3, it hardly uses the TYPO3 DB API.

This patch enhances getObjectData- and getObjectCountByQuery
- the main methods used when dealing with domain models
through a repository - to use the TYPO3 DB API. In conjunction
this enables Extbase to use the preparedStatement introduced
in TYPO3 4.5.

Because prepared queries might not be desirable in all circum-
stances, they are disabled by default. They can be enable on
a per-query-basis via
  $query->getQuerySettings()->setUsePreparedStatement(TRUE);

Prepared statements will *only* be used for SELECT queries.

* consistent use of the TYPO3 DB API
  use exec_SELECTgetRows and exec_SELECTcountRows() even for
  non-prepared queries. This should help a lot along the way
  to support DBAL.

* preparedStatement in custom statements
  When using custom statements, it's now possible to use a pre-
  pared statement in $query->statement(), instead of a query-
  string. The prepared statement has to be initialized already
  though, because Extbase cannot take care of splitting your
  custom query string. The parameters are given as array in the
  second argument as usual.

* deprecated using parameters in non-prepared custom statement
  If a custom query string is used with $query->statement(),
  giving the parameters in the second argument is deprecated.

* get count working
  Counting - especially with limit and offset - has been broken
  for quite some time now. By refactoring the limit and offset
  parameters and adapting exec_SELECTcountRows() this should
  now work again.

The next step is to separate the query parsing from the backend
and introduce an intelligent query cache. This will work as a
drop-in-replacement. The @todo-annotations are intended to stay
there for the next patch.

Resolves: #55360
Releases: 6.2
Change-Id: I91a3fd69470df178a8a5465511e50766b50d7f52
Reviewed-on: https://review.typo3.org/27426
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[CLEANUP] ClassLoader 79/28279/7
Markus Klein [Wed, 12 Mar 2014 12:52:20 +0000 (13:52 +0100)]
[CLEANUP] ClassLoader

Add methods to better structure class information loading/creation.
This is necessary as the follow up patches will need this code
more often.

Resolves: #56797
Releases: 6.2
Change-Id: I1f15fbd262036b6b2d0159cd0e9613ad7135a296
Reviewed-on: https://review.typo3.org/28279
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Sebastian Fischer
Reviewed-by: Patrick Broens
Tested-by: Patrick Broens
5 years ago[TASK] Enable info icon for inline fileReference elements 91/28291/2
Frans Saris [Wed, 12 Mar 2014 11:22:52 +0000 (12:22 +0100)]
[TASK] Enable info icon for inline fileReference elements

The editor has no way to find the origin of the shown files when
you add file to a content element for instance.

This patch changes the default settings of
ExtensionManagementUtility::getFileFieldTCAConfig() so
the info icon is shown.

Resolves: #56804
Releases: 6.2
Change-Id: I00752e73f891285525a7aae1a9c5caddfacc13d4
Reviewed-on: https://review.typo3.org/28291
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Outside storages can never be marked as public 24/28224/3
Fabien Udriot [Mon, 10 Mar 2014 14:23:50 +0000 (15:23 +0100)]
[BUGFIX] Outside storages can never be marked as public

There are some edge cases where "is_public"
can never be true within a storage record in the BE,
for instance for storage located outside
the document root or for storage driven by special driver
such as Flickr, ...

Change-Id: Id7ce8006f182c98d7a908c2e6c49e0c66a7c9da4
Releases: 6.2
Resolves: #56730
Reviewed-on: https://review.typo3.org/28224
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Reduce record data in functional test failure message 85/28285/2
Oliver Hader [Mon, 10 Mar 2014 19:14:10 +0000 (20:14 +0100)]
[TASK] Reduce record data in functional test failure message

If records are found in a database table that are not part of
the assertion data-set, currently the whole record array from
the database is shown as failure.
The assertion has information about the fields that should have
been asserted. To keep a better overview, the failure message
is reduced now to exactly those fields.

Resolves: #56803
Releases: 6.2
Change-Id: Ib8f2afd0d464e8a4b850929277508770ff56eb91
Reviewed-on: https://review.typo3.org/28285
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Remove functional workspaces DataHandlerTest 88/28288/2
Oliver Hader [Wed, 12 Mar 2014 10:35:40 +0000 (11:35 +0100)]
[TASK] Remove functional workspaces DataHandlerTest

DataHandling::canChangeTtContentInTheWorkspace() is now covered
by DataHandling\Regular\Modify\ActionTest::modifyContent() with
additional assertions. The mentioned test class can be removed.

Resolves: #56805
Releases: 6.2
Change-Id: I968c593f50cd7453db87e1c4fe9e0478cf045381
Reviewed-on: https://review.typo3.org/28288
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Only valid package names will be processed. 86/28286/3
Daniel Siepmann [Wed, 12 Mar 2014 10:00:34 +0000 (11:00 +0100)]
[BUGFIX] Only valid package names will be processed.

To prevent the extension manager from further steps while
invalid package keys exists in the system, the package keys are
validated earlier.

This prevents further actions that will lead to rewrite
of PackageState.php and invalid opcode cache.

Change-Id: Ib8d9f25dc1d6c97b94a59b15255b96d5a1960093
Resolves: #56532
Releases: 6.2
Reviewed-on: https://review.typo3.org/28286
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Split functional workspaces DataHandling test execution 89/28289/2
Oliver Hader [Wed, 12 Mar 2014 10:42:38 +0000 (11:42 +0100)]
[BUGFIX] Split functional workspaces DataHandling test execution

Travis-CI stops after 10 minutes of not having received any data,
unfortunately it seems that the execution of the whole bunch of
functional workspaces tests takes longer,
see https://travis-ci.org/TYPO3/TYPO3.CMS/jobs/20590551

The "solution" is to explicitly split up these tests for
parallel execution in Travis-CI.

Resolves: #56806
Releases: 6.2
Change-Id: Ib5e67e6793adb9d7896ce89872ccfa080ca849bd
Reviewed-on: https://review.typo3.org/28289
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Text changes in the Install Tool 87/28287/3
Cynthia Mattingly [Wed, 12 Mar 2014 09:07:38 +0000 (10:07 +0100)]
[TASK] Text changes in the Install Tool

Fix many small grammar and typo issues. Rewrite some larger
portions of text to be more clear to the user. These
rewrites are listed in the issue tracker.

Resolves: #56754
Related: #51965
Releases: 6.2
Change-Id: I72f3ccbbeb815d93e904154b5da0ad48213ed63c
Reviewed-on: https://review.typo3.org/28287
Reviewed-by: Sebastian Fischer
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Adapt ShowPic popup to use FAL 52/28252/6
Steffen Ritter [Tue, 11 Mar 2014 13:07:00 +0000 (14:07 +0100)]
[BUGFIX] Adapt ShowPic popup to use FAL

If not using own Lightboxes TYPO3 ships a custom solution
of an image-enlarge popup. This combines an eID for rendering
the image as well as a short JavaScript snippet opening that
in a new window.

The php code for rendering that link as well as the popup code
itself are not fal aware and to image-processing on their own.
As a result this feature is only able to deal with files in local
file system.

This change refactors both imageLinkWrap as well as
ShowImageController to use and work on FAL objects.

Releases: 6.2
Resolves: #56723
Change-Id: Iebf1379b8f72cf57d69a06b0b7540cbd8ccb32c1
Reviewed-on: https://review.typo3.org/28252
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Remove baseUri from the Storage 71/28271/4
Fabien Udriot [Tue, 11 Mar 2014 19:17:17 +0000 (20:17 +0100)]
[BUGFIX] Remove baseUri from the Storage

The baseUri in the Storage has a Getter and is the
only thing initialized in the "processConfiguration"
method of a Storage. Due to the fact that "baseUri"
is not a field in the storage-table this never could
be set, and therefore always has been null.

It appears that this has been a left over from earlier
days and it is save to remove this, since the getter
always returned NULL (and as a result was unusable).
In addition the processConfiguration and its signals
are removed as they have and never had an effect anyhow.

Change-Id: I3416ee393a1eb3d0f1ea5fc588a351bb1555cdba
Releases: 6.2
Resolves: #56783
Reviewed-on: https://review.typo3.org/28271
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Language labels taken from wrong language file 55/28255/7
Patrick Broens [Tue, 11 Mar 2014 13:58:46 +0000 (14:58 +0100)]
[BUGFIX] Language labels taken from wrong language file

The module "Pagetree overview" in Web > Info is showing an empty
selectbox because the language labels for this dropdown are called from
the wrong language file.

This patch changes the calls to the language labels

Change-Id: I791598933704752fd6d5ed0d987f43bde1811452
Resolves: #56762
Releases: 6.2
Reviewed-on: https://review.typo3.org/28255
Reviewed-by: Sebastian Müller
Tested-by: Sebastian Müller
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Different button behaviour Page module views 19/28219/3
Patrick Broens [Mon, 10 Mar 2014 12:40:22 +0000 (13:40 +0100)]
[BUGFIX] Different button behaviour Page module views

In the Page module the button behaviour for adding new content elements
"Add a new record at this place" is different in the "columns" and
"languages" view.

The columns view shows the all buttons in a column when hovering over this
column, the languages view will show one button when hovering over this
hidden button. A backend user needs to know where the button is.

The languages view should have the same behaviour as the columns view.

Change-Id: Ia1b98de5b8622c7586bd03e7769ba4aa39121e38
Resolves: #56722
Releases: 6.2, 6.1
Related: #56720
Reviewed-on: https://review.typo3.org/28219
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Add functional tests for TCA types select and group/db 23/27823/7
Oliver Hader [Mon, 24 Feb 2014 23:22:43 +0000 (00:22 +0100)]
[TASK] Add functional tests for TCA types select and group/db

The tests for TCA types 'select' and 'group' include for each
* Modify in live
* Modify in workspace
* Publish in workspace
* PublihAll in workspace

Resolves: #56707
Releases: 6.2
Change-Id: I4bd8584f01122d0c4a974618d00e126b91270589
Reviewed-on: https://review.typo3.org/27823
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Typecast cookie value to string 81/28281/2
Georg Ringer [Wed, 12 Mar 2014 06:28:41 +0000 (07:28 +0100)]
[BUGFIX] Typecast cookie value to string

The cookie might be null, therefore the INSERTquery fails in
indexed_search.

As a solution, use a type cast to string.

Change-Id: If9e650ee713c75420859813546d138000b3023ff
Resolves: #55989
Releases: 6.2
Reviewed-on: https://review.typo3.org/28281
Reviewed-by: Christian Kuhn
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Index on sys_file_processedfile is too large 72/28272/3
Ernesto Baschny [Tue, 11 Mar 2014 19:31:32 +0000 (20:31 +0100)]
[BUGFIX] Index on sys_file_processedfile is too large

Resolves: #56786
Related: #54234
Releases: 6.2
Change-Id: I9c91f3e989e65df559542135d0b84025dacbbaf2
Reviewed-on: https://review.typo3.org/28272
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Add Publish and PublishAll DataHandler workspaces tests 36/28236/4
Oliver Hader [Tue, 11 Mar 2014 19:46:27 +0000 (20:46 +0100)]
[TASK] Add Publish and PublishAll DataHandler workspaces tests

Extend current functional action tests with those actions:
* modification (Modify)
* publish single records (Publish)
* publish all records in a workspace (PublishAll)

The Publish and PublishAll tasks extend the accordant basic
Modify functional tests.

Resolves: #56708
Related: #56710
Releases: 6.2
Change-Id: I1f7a70df39585c29b3b4ff5675b5147610f254f2
Reviewed-on: https://review.typo3.org/28236
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Update ADOdb to 5.18 53/28253/5
Andreas Fernandez [Tue, 11 Mar 2014 13:33:19 +0000 (14:33 +0100)]
[TASK] Update ADOdb to 5.18

Update ADOdb to current version 5.18 which fixes various bugs
and adds PHP 5.4 compatibility.

Resolves: #56761
Releases: 6.2
Change-Id: I5d46f52f8beb2407a40a3ee5796b00229b79992f
Reviewed-on: https://review.typo3.org/28253
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Add possibility to assert error log entries 86/27886/3
Oliver Hader [Thu, 27 Feb 2014 09:51:23 +0000 (10:51 +0100)]
[TASK] Add possibility to assert error log entries

During the action tests it might happen, that errors occur.
To assert expected or unexpected error log entries in the
sys_log table, this functionality shall be added to the
functional testing framework.

Resolves: #56369
Releases: 6.2
Change-Id: I07806e69cb7f575c844a3adf442233a82fa01505
Reviewed-on: https://review.typo3.org/27886
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Use clean DataHandler for each functional test action 22/28222/3
Oliver Hader [Mon, 10 Mar 2014 13:53:12 +0000 (14:53 +0100)]
[BUGFIX] Use clean DataHandler for each functional test action

Currently the DataHandler is reused in functional tests which
leads to unexpected behaviour for copied/deleted records. The
regular use case in the backend is to use a new DataHandler
instance for each HTTP request.

Resolves: #56729
Releases: 6.2
Change-Id: Iea685f58625e6ef611d543e375a8c24c1595008d
Reviewed-on: https://review.typo3.org/28222
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Tests: Incomplete mocking in ext:frontend 74/28274/2
Christian Kuhn [Tue, 11 Mar 2014 20:21:42 +0000 (21:21 +0100)]
[BUGFIX] Tests: Incomplete mocking in ext:frontend

Improve the fluid standalone tests by not calling __construct() of
a dependency.
Additionally, renderWorksWithNestedFluidtemplate() not only tests
the standalone view, but also its connection to the content object
renderer, so this is more a functional than a unit test. The test
is streamlined and moved to the functional test suite.

Change-Id: I3ae357de4861395622bc6f70aeed6011c7760cde
Resolves: #56788
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28274
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Incomplete mocking in ext:beuser 75/28275/2
Christian Kuhn [Tue, 11 Mar 2014 20:37:41 +0000 (21:37 +0100)]
[BUGFIX] Tests: Incomplete mocking in ext:beuser

The module data storage test subject calls several static
dependencies that can not be mocked without code refactoring. Those
dependencies do database stuff in the end, so DB needs to be properly
mocked for this test.

Change-Id: Id882b3a3a785940b5499c9afeff67f193c480e3b
Resolves: #56791
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28275
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Alignment of button "add a new element at this place" 17/28217/2
Patrick Broens [Mon, 10 Mar 2014 12:19:49 +0000 (13:19 +0100)]
[BUGFIX] Alignment of button "add a new element at this place"

In the page module using the "Languages" view, the buttons "add a new
element at this place" are wrongly aligned.

This patch fixes this issue by adding a div which controls this alignment
by CSS

Change-Id: I9de8a47368682ed0b33c2ebfa0a590402c1ca8ef
Resolves: #56720
Releases: 6.1, 6.2
Reviewed-on: https://review.typo3.org/28217
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mocking in ext:scheduler 73/28273/2
Christian Kuhn [Tue, 11 Mar 2014 19:47:34 +0000 (20:47 +0100)]
[BUGFIX] Tests: Incomplete mocking in ext:scheduler

Use getMock() instead of new() to create the test subject in order to
suppress execution of __construct() of parent AbstractTask.

Change-Id: Id0c297b845db7064b15a859eefa71830ab12074d
Resolves: #56787
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28273
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] FollowUp to #56660 70/28270/2
Steffen Ritter [Tue, 11 Mar 2014 19:09:18 +0000 (20:09 +0100)]
[BUGFIX] FollowUp to #56660

Fixes the unit-test according to the changes in review
https://review.typo3.org/#/c/28195/.

Since the BasePath (and therefore vfs://...) cannot be
handover anymore on initialize() it has to be injected
via _set().

Releases: 6.2
Resolves: #56660
Change-Id: I88d03f0305ff08810d6fea82c5c891b1a7a99771
Reviewed-on: https://review.typo3.org/28270
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Styling and placement of Toggle All button install tool 43/28243/2
Patrick Broens [Tue, 11 Mar 2014 08:45:54 +0000 (09:45 +0100)]
[TASK] Styling and placement of Toggle All button install tool

The "Toggle All" button in the install tool is currently clickable plain
text, which should be a button. It also needs to move to the fixed footer,
so it's always accessible.

This patch changes the plain text to a button and moves the button to the
fixed footer

Change-Id: I25a57e7a7f0f25fe2fe204f68fe2ee4dbbf1ade0
Resolves: #55469
Releases: 6.2
Reviewed-on: https://review.typo3.org/28243
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] PackageManager initialize() signature is incompatible 95/28195/7
Wouter Wolters [Sun, 9 Mar 2014 15:22:23 +0000 (16:22 +0100)]
[BUGFIX] PackageManager initialize() signature is incompatible

PackageManagerInterface contains following method declaration:

 public function initialize(\TYPO3\Flow\Core\Bootstrap $bootstrap);

however in the PackageManager the signature is:

  public function initialize(\TYPO3\Flow\Core\Bootstrap $bootstrap,
    $packagesBasePath = FLOW_PATH_PACKAGES,
    $packageStatesPathAndFilename = '')

This will create a fatal error on some versions of php and when running
unit tests on hhvm (of CMS), see
http://php.net/manual/en/language.oop5.interfaces.php

"The class implementing the interface must use the exact same method
signatures as are defined in the interface. Not doing so will result
in a fatal error."

This change updates the method signature of the PackageManager to be in
line with the interface.

Resolves: #56660
Related: #56409
Releases: 6.2
Change-Id: Iab7ae0d6d9809abe7cb6f9b73adb77f06d2f0820
Reviewed-on: https://review.typo3.org/28195
Reviewed-by: Thomas Maroschik
Reviewed-by: Sebastian Müller
Reviewed-by: Sebastian Fischer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove wrong storage->isPublic() check in localFolderTree 72/27772/3
Frans Saris [Fri, 21 Feb 2014 12:47:45 +0000 (13:47 +0100)]
[BUGFIX] Remove wrong storage->isPublic() check in localFolderTree

In localFolderTree->ext_isLinkable() is a check for storage->isPublic()
but the isPublic flag has nothing to do with the fact if links
to the files can be created.

This change removes this check.

Resolves: #56183
Releases: 6.2
Change-Id: Ia0e264b46259c0bd284a789a4eab48cf9a9e3b14
Reviewed-on: https://review.typo3.org/27772
Reviewed-by: Wouter Wolters
Reviewed-by: Sebastian Fischer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] DatabaseConnection must be initialized 54/28254/3
Xavier Perseguers [Tue, 11 Mar 2014 13:45:11 +0000 (14:45 +0100)]
[BUGFIX] DatabaseConnection must be initialized

The install tool forgets to initialize the database connection.

Change-Id: Ib7355e4f931c7152a6d13df99ed550c1b61eacf9
Fixes: #56763
Releases: 6.2
Reviewed-on: https://review.typo3.org/28254
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] DBAL: Incomplete database configuration 45/28045/6
Xavier Perseguers [Tue, 11 Mar 2014 15:08:26 +0000 (16:08 +0100)]
[BUGFIX] DBAL: Incomplete database configuration

When no database connection is established, handler_init() is used. But
at this point, the credentials are unkown and the method returns void.

As all parameters of method sql_pconnect() are deprecated, move the
_DEFAULT initialization into method handler_init() to get credentials
into the DBAL configuration.

Resolves: #56257
Releases: 6.2
Change-Id: Ifd908fab1382434d376a9358d0ae9c3af083616e
Reviewed-on: https://review.typo3.org/28045
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Inconsistent visual appearance Install Tool 25/28225/5
Patrick Broens [Mon, 10 Mar 2014 14:41:01 +0000 (15:41 +0100)]
[BUGFIX] Inconsistent visual appearance Install Tool

The install tool function System Environment is not according to the
style sheet of the install tool. This is due to the fact phpinfo() is
called on this page which comes with its own CSS styles. These styles
are influencing the visual appearence of the rest of the page.

This patch adds a new utility class to cleanup the output of phpinfo()
before assigning it to the view. It also comes with our own CSS for
phpinfo().

Change-Id: Ib0b087cae4bf5db723b0e9c3481619c984ef674f
Resolves: #55116
Releases: 6.2
Reviewed-on: https://review.typo3.org/28225
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[TASK] Add api tag to ElementBrowser::setRecordList() 37/28237/4
Alexander Stehlik [Tue, 11 Mar 2014 06:09:41 +0000 (07:09 +0100)]
[TASK] Add api tag to ElementBrowser::setRecordList()

This method was introduced in TYPO3 6.2 with the purpose to be used
by Extensions. Therefore the @deprecated tag is replaced with an
@api tag.

Resolves: #56742
Releases: 6.2
Change-Id: Ia48a8c6997c26318a6fea50af32cd73f1138bb2b
Reviewed-on: https://review.typo3.org/28237
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix alignment for button "copy default content elements" 14/28214/2
Patrick Broens [Mon, 10 Mar 2014 10:44:05 +0000 (11:44 +0100)]
[BUGFIX] Fix alignment for button "copy default content elements"

In the page module in the "languages" view, the alignment of the button
"copy default content elements" is off. The button needs some padding on
the left side.

This patch fixes this by adding a div which gets the padding. It also
replaces the br's in front of this button with CSS for spacing.

Change-Id: Ic21097e8db078f2a2612c89d9496bf20fa5c0585
Resolves: #56636
Releases: 6.2
Reviewed-on: https://review.typo3.org/28214
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Create new processor registry 58/27958/9
Frans Saris [Fri, 28 Feb 2014 22:34:57 +0000 (23:34 +0100)]
[TASK] Create new processor registry

File processing might be different for external storages.
Therefore it must be possible to register your own File Processors
and make the registry driver aware.

Resolves: #56775
Releases: 6.2
Change-Id: I187f6f987f7b0bc92989ed38cbef248449a7f59f
Reviewed-on: https://review.typo3.org/27958
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Add FAL support for import in sys extension impexp 36/27836/8
Marc Bastian Heinrichs [Fri, 21 Feb 2014 15:31:05 +0000 (16:31 +0100)]
[TASK] Add FAL support for import in sys extension impexp

Until now only files from TCA type group internal_type file or
file_reference could be imported and exports from version 6.x
including sys_file records leads to exceptions on importing.
The patch adds support for handling record types introduced
with the File Abstraction Layer.

Resolves: #55532
Resolves: #55528
Resolves: #55906
Releases: 6.2
Change-Id: I7521c84094b0a0424e13c5f91c26b630bbbccbfe
Reviewed-on: https://review.typo3.org/27836
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] PHP Runtime Notice in saltedpasswords 61/28261/2
Xavier Perseguers [Tue, 11 Mar 2014 15:23:11 +0000 (16:23 +0100)]
[BUGFIX] PHP Runtime Notice in saltedpasswords

Declaration of method compareUident() should be compatible with its
parent class.

Change-Id: I66979bd76b204bbb762c41037cdaae5f006debb5
Fixes: #56769
Releases: 6.2
Reviewed-on: https://review.typo3.org/28261
Reviewed-by: Andreas Fernandez
Tested-by: Andreas Fernandez
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Layout category tree is broken 50/28250/2
Patrick Broens [Tue, 11 Mar 2014 10:43:02 +0000 (11:43 +0100)]
[BUGFIX] Layout category tree is broken

There are several issues with the layout of the category tree.

When hovering the whole element, the categories (text) get underlined.
The categories text is not aligned properly with the icon and checkbox.
The glow on a checkbox with focus is bigger than the checkbox itself.

This patch fixes these issues by adding CSS for the tree when used in
TCEforms.

Change-Id: Id9faaf906c786a95246d12f15821372648fc44b6
Resolves: #56752
Releases: 6.2
Reviewed-on: https://review.typo3.org/28250
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[FEATURE] Allow Storages outside the webroot 60/27760/11
Steffen Ritter [Thu, 20 Feb 2014 17:26:20 +0000 (18:26 +0100)]
[FEATURE] Allow Storages outside the webroot

Storages can be marked as not public or be outside of webroot.
There are no direct links to the files posible.

This change adds a eID implementation to create urls to these files.
It also implements a hook in het eID dispatcher that makes is possible
to add custom security/access checks when delivering files.

Releases: 6.2
Resolves: #36420
Change-Id: Ie7fc9c8a674a3200ea2b29d1adc17327d10bd6e5
Reviewed-on: https://review.typo3.org/27760
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Wrong note in ResourceFactory 23/28223/3
Frans Saris [Mon, 10 Mar 2014 14:23:52 +0000 (15:23 +0100)]
[BUGFIX] Wrong note in ResourceFactory

A note in the phpdoc header of ResourceFactory states it is a
lowlevel API. But this is wrong as at least since 6.2 this is
the public API and therefor this note is removed.

Resolves: #56731
Releases: 6.2
Change-Id: I90ed0dafa12656efe6d037abebee7b92de54a6f7
Reviewed-on: https://review.typo3.org/28223
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Flash messages are not shown with AJAX requests 00/28200/4
Xavier Perseguers [Sun, 9 Mar 2014 16:56:21 +0000 (17:56 +0100)]
[BUGFIX] Flash messages are not shown with AJAX requests

Due to the use of DragUploader to upload files, flash messages
are not shown immediately but after manually reloading the page.

Change-Id: Ia2e8750792bd04209b5a1f2ce0e2a63f970ba3a8
Fixes: #56561
Releases: 6.2
Reviewed-on: https://review.typo3.org/28200
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Return ProcessedFile instead of File if possible 53/27753/9
Steffen Ritter [Thu, 20 Feb 2014 12:16:55 +0000 (13:16 +0100)]
[TASK] Return ProcessedFile instead of File if possible

You can query the FAL-API for files by their filename. If the file resides
in the processing-folder of a storage it is a valid file to the storage.
Therefore creating a file-object and indexing it would be a valid thing.

Since this is not intended additionally to the storage the ResourceFactory
must know about that, too. This change implements this awareness, so there
is no way to create a FileObject for files which reside within the
processing folder.
In 6.0 and 6.1 there has been a dirty workaround for that by marking those
files as not indexable which was removed silently when introducing the new
indexer.

Releases: 6.2
Resolves: #54234
Change-Id: I274c47717560a6efc175fa94aacc4770a578fd3f
Reviewed-on: https://review.typo3.org/27753
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Missing argument in ReferenceIntegrity updater 33/28233/2
Eric Chavaillaz [Mon, 10 Mar 2014 16:55:35 +0000 (17:55 +0100)]
[BUGFIX] Missing argument in ReferenceIntegrity updater

When trying to use the upgrade wizards, a fatal error
is thrown because the mandatory where_clause is missing
in a call to exec_SELECTquery.

Resolves: #56737
Releases: 6.2
Change-Id: I4814b9c2b0b30cea11e81bbf64d94ba8213a07cb
Reviewed-on: https://review.typo3.org/28233
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Multiple Set-Cookie headers for deleting FE cookie 27/28227/3
Nicole Cordes [Mon, 10 Mar 2014 15:21:29 +0000 (16:21 +0100)]
[BUGFIX] Multiple Set-Cookie headers for deleting FE cookie

In the current master every time when removeCookie is triggered a
Set-Cookie header is generated. A cookie should only be deleted if it
was set before. As removeCookie can handle different cookie names, the
check is performed before calling removeCookie function.

Resolves: #56733
Releases: 6.2
Change-Id: I518220ce2def8d9db901b1e8daa87de745317629
Reviewed-on: https://review.typo3.org/28227
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Oliver Klee
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Remove loadExtensionTables() from unit test bootstrap 35/28235/3
Christian Kuhn [Mon, 10 Mar 2014 18:01:19 +0000 (19:01 +0100)]
[TASK] Remove loadExtensionTables() from unit test bootstrap

With proper mocking in place, loadExtensionTables() can be
removed from unit test bootstrap.
This speeds up the test suite quite a bit since the huge
$GLOBALS['TCA'] is no longer initialized and gives backup code
of phpunit less headaches.

Change-Id: I9ac96047a49914f3c6ab7acc318bbc36488b6c5b
Resolves: #56739
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28235
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Tests: Improve mocking in IconUtilityTest 20/28220/2
Christian Kuhn [Mon, 10 Mar 2014 13:26:42 +0000 (14:26 +0100)]
[BUGFIX] Tests: Improve mocking in IconUtilityTest

The IconUtility tests depend on initialized $GLOBALS['TBE_STYLES']
and sometimes on initialized $GLOBALS['TCA']. This dependency is
removed by properly setting up needed arrays now, this also makes
the tests more obvious and easier to understand.
Additionally, the static cache property introduced with #56110 now
uses late static binding, enabling the tests to extend the class
and route any static cache changes to an test internal overlay
class to not pollute the static property of the base class.

Change-Id: I01166058da051a26d7aa2df315858468828ed346
Resolves: #56725
Related: #51436
Related: #56110
Releases: 6.2
Reviewed-on: https://review.typo3.org/28220
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Change notification level for missing opcode cache 16/28216/3
Sebastian Müller [Mon, 10 Mar 2014 11:22:10 +0000 (12:22 +0100)]
[BUGFIX] Change notification level for missing opcode cache

Now the notification level is set to notice instead of warning.
Therefore no email notification will be send if the user has not
set his cache or his cache has only medium performance

Resolves: #55392
Releases: 6.2
Change-Id: I90758ba658477a4b92f1a110228eb7950648ec39
Reviewed-on: https://review.typo3.org/28216
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Improve mocking in ext:belog 15/28215/2
Christian Kuhn [Mon, 10 Mar 2014 10:57:53 +0000 (11:57 +0100)]
[BUGFIX] Tests: Improve mocking in ext:belog

The subject method initialize() calls some static dependencies
that can not be mocked. They do DB actions in the end. The patch
now mocks TYPO3_DB to suppress this DB call.

Change-Id: I43b0e002bfab081ed41a5c259011f465b507a74b
Resolves: #56718
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28215
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Wrong IRC URL for Packagist 11/28211/2
Fabien Udriot [Mon, 10 Mar 2014 09:31:02 +0000 (10:31 +0100)]
[BUGFIX] Wrong IRC URL for Packagist

Packagist complains about current IRC URL format.

Change-Id: Id8abcad6525c06d6941144cd2e1e8ea372cc975a
Releases: 6.2
Resolves: #56713
Reviewed-on: https://review.typo3.org/28211
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
5 years ago[BUGFIX] Tests: Improve Mocking in ext:extbase 07/28207/3
Anja Leichsenring [Sun, 9 Mar 2014 23:39:10 +0000 (00:39 +0100)]
[BUGFIX] Tests: Improve Mocking in ext:extbase

Change-Id: I61f7f92da42d691b0556f1e53b20d39eb082c12f
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28207
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Improve TCA mocking in BackendUtility 06/28206/3
Christian Kuhn [Sun, 9 Mar 2014 23:20:17 +0000 (00:20 +0100)]
[BUGFIX] Tests: Improve TCA mocking in BackendUtility

ext:core BackendUtilityTest no longer depends on initialized TCA.

Change-Id: I5b97b86d57da15b6176dd3033ec8fda1f4209f85
Resolves: #56699
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28206
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:frontend 04/28204/2
Anja Leichsenring [Sun, 9 Mar 2014 22:28:24 +0000 (23:28 +0100)]
[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:frontend

To reduce dependencies of tests and improve readability, some tests
can be improved by better mocking of $GLOBALS['TCA'].

Change-Id: Ib38f2dd94288c5c4f8940d3c8c969ea0459ebbcb
Resolves: #56698
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28204
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:core 03/28203/2
Christian Kuhn [Sun, 9 Mar 2014 22:16:39 +0000 (23:16 +0100)]
[BUGFIX] Tests: Incomplete mocking of $GLOBALS['TCA'] in ext:core

To reduce dependencies of tests and improve readability, some tests
can be improved by better mocking of $GLOBALS['TCA']

Change-Id: I7dee44b5a98f2384c2b77c51ebc678ff15669475
Resolves: #56696
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28203
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring