Packages/TYPO3.CMS.git
5 years ago[BUGFIX] FAL wrong \RecursiveIteratorIterator usage 08/22608/2
Christian Kuhn [Fri, 26 Jul 2013 18:54:23 +0000 (20:54 +0200)]
[BUGFIX] FAL wrong \RecursiveIteratorIterator usage

If using \RecursiveIteratorIterator on \RecursiveDirectoryIterator,
flag SELF_FIRST must be used, otherwise only leaves (files) and not
also directories are returned. This behavior is a bit dependent on
the PHP version used, younger versions (> 5.3.3 seem to do it
correctly).

Furthermore, in copyFolderWithinStorage() $itemSubPath contains
the "relative" path part and not only the node name, checking
equality to "." or ".." fails then if handling sub directories.
So, directories may be created multiple times, resulting in mkdir()
warnings. This is fixed by getting the node name itself and using
that for comparison.

Resolves: #50476
Releases: 6.2, 6.1, 6.0

Change-Id: Ifac4b28f4e02ec8a9bf5891739cf66c1e1074af9
Reviewed-on: https://review.typo3.org/22602
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit ef8204d64f44c4643482c7e6a01313a1b702ca43)
Reviewed-on: https://review.typo3.org/22608

5 years ago[BUGFIX] FAL does not copy subfolders cleanly 06/22606/2
Christian Kuhn [Fri, 26 Jul 2013 15:43:19 +0000 (17:43 +0200)]
[BUGFIX] FAL does not copy subfolders cleanly

If full structures with sub folders are copied around in FAL
local driver, sub folders are not correctly created in the
target directory.

This is detected in unit tests after recent vfsStream updates in
ext:phpunit.

The patch adds a flag to the Iterator code to also include
directories to fix the issue.

Additionally, the existing two unit tests also tested multiple other
methods of the local driver and are functional tests. The patch moves
those two tests to the functional section and adds three simple unit
tests with correct mocking instead.

Change-Id: I30d3c8bd5c6538b3fe23405d97bcddff6c1ff405
Releases: 6.2, 6.1, 6.0
Resolves: #50472
Reviewed-on: https://review.typo3.org/22596
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit b0f8bb0d15106b6f3ee2c5b3b033cbc3e1b635e2)
Reviewed-on: https://review.typo3.org/22606

5 years ago[BUGFIX] Fix failing test 86/22586/2
Anja Leichsenring [Fri, 26 Jul 2013 09:21:45 +0000 (11:21 +0200)]
[BUGFIX] Fix failing test

The test failes due to incorrect mocking, what leads to not claimed
properties for the test.
Additionally the expected call amounts where handled more strictly
where fitting.

Releases: 6.2, 6.1, 6.0
Resolves: #50458
Change-Id: I34214fb9ef9e9935892aa03518505b877538e128
Reviewed-on: https://review.typo3.org/22586
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Uninstall extension with dependency throws Exception 79/22579/2
Wouter Wolters [Tue, 9 Jul 2013 16:49:02 +0000 (18:49 +0200)]
[BUGFIX] Uninstall extension with dependency throws Exception

Exception is thrown if uninstalling an extension with
dependecies on that extension. Catch the exception and
show a nice Flashmessage.

Change-Id: I434a4e1e1d83f43a6f5d4c99a82433e35ddd92f9
Resolves: #49722
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22579
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Test regression from patch for #47192 76/22576/2
Andreas Wolf [Sat, 20 Jul 2013 21:14:22 +0000 (23:14 +0200)]
[BUGFIX] Test regression from patch for #47192

This fixes a unit test regression introduced with the solution for
 #47192.

Change-Id: I0e70b916f24fada7f76e7fd835d31e54ca41a402
Related: #47192
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22576
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Improve method annotation and type hinting in FAL 74/22574/2
Christian Kuhn [Thu, 25 Jul 2013 20:53:04 +0000 (22:53 +0200)]
[BUGFIX] Improve method annotation and type hinting in FAL

Add a missing "@throws" annotation and a namespaced comment.

Change-Id: Ibc929a01dbfdef9cf8730a8da259570786b6118c
Resolves: #50447
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22572
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 3a23fb06d51fda287a78745a133f293fe8a9db77)
Reviewed-on: https://review.typo3.org/22574

5 years ago[BUGFIX] rsaauth BackendFactory does not unset backend 71/22571/2
Markus Klein [Wed, 24 Jul 2013 18:12:42 +0000 (20:12 +0200)]
[BUGFIX] rsaauth BackendFactory does not unset backend

The BackendFactory of rsaauth tries to forcefully unset an
instantiated backend, but unsets the class name instead of the object.

Resolves: #50411
Releases: 6.2, 6.1, 6.0
Change-Id: I26712c73b74788cad159f95c7e54cbbbf69e8764
Reviewed-on: https://review.typo3.org/22571
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] require_once of vfsStream triggers travis fail 68/22568/2
Christian Kuhn [Thu, 25 Jul 2013 18:42:59 +0000 (20:42 +0200)]
[BUGFIX] require_once of vfsStream triggers travis fail

vfsStream is now included in ext:phpunit, the pear module is
not maintained and was removed in travis.
This triggeres a failure in the phplint check. All require_once
calls are removed for now, ext:phpunit now also provides an
autoloader for vfsSstream.

Change-Id: If1b07c31e999111e6b5d2804a9f5cc457066b7b0
Resolves: #50442
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22568
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Revise typo3/sysext/README.txt 57/22557/2
Wouter Wolters [Wed, 24 Jul 2013 18:00:47 +0000 (20:00 +0200)]
[TASK] Revise typo3/sysext/README.txt

* Replace GIT repository link with the new one
* Remove information about submodules

Change-Id: I60db762ce831c7edea413d9f7780a5617b7f9e96
Resolves: #50410
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22557
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Set TYPO3 version to 6.0.8-dev 21/22521/2
TYPO3 Release Team [Tue, 23 Jul 2013 17:42:59 +0000 (19:42 +0200)]
[TASK] Set TYPO3 version to 6.0.8-dev

Change-Id: I036e4f5e69e384be33b30505f62c5eb2511ee74e
Reviewed-on: https://review.typo3.org/22521
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.0.7 20/22520/2 TYPO3_6-0-7
TYPO3 Release Team [Tue, 23 Jul 2013 17:42:34 +0000 (19:42 +0200)]
[RELEASE] Release of TYPO3 6.0.7

Change-Id: Ibfe25a1c9688601c4e1f514afd28f30c8b1ee083
Reviewed-on: https://review.typo3.org/22520
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[TASK] Make DiffUtility faster and much more scaleable. 10/22510/2
Kasper Ligaard [Mon, 22 Jul 2013 16:19:49 +0000 (18:19 +0200)]
[TASK] Make DiffUtility faster and much more scaleable.

The method DiffUtility->explodeStringIntoWords() calls array_merge()
inside a loop. The cost of constantly doing a function invocation and
merging arrays needlessly slows the method and the whole diff utility.
Moving the array merging outside the loop, the method becomes faster
and able to handle much larger input.

Change-Id: I4c2d21cff9b18392e89e316fec9dc615e715a073
Resolves: #50318
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22510
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Allow colon in last "displayCond" part 52/20552/5
Sascha Egerer [Mon, 6 May 2013 16:03:24 +0000 (18:03 +0200)]
[BUGFIX] Allow colon in last "displayCond" part

Explode the "displayCond"-string just to required
number of parts. So the last part can also contain colons.

Also backports unit-tests from ElementConditionMatcher of
TYPO3 6.1 and adds a check for this colon-bugfix here.

Resolves: #47988
Releases: 6.0, 4.7, 4.5
Change-Id: I940e17ea346dda91607573406fd83d919d83e36a
Reviewed-on: https://review.typo3.org/20552
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Two mailforms on a page cause error on field validation 78/22478/2
Ernesto Baschny [Tue, 27 Nov 2012 01:38:49 +0000 (02:38 +0100)]
[BUGFIX] Two mailforms on a page cause error on field validation

Check formname for uniqueness and if need append a unique hash.

Change-Id: Ifd33c5130c383f3afc3e5e6d80c1be017f25ec5b
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Fixes: #16114
Reviewed-on: https://review.typo3.org/22478
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Width of action column is wrong 54/22454/2
Oliver Hader [Wed, 19 Jun 2013 14:53:35 +0000 (16:53 +0200)]
[BUGFIX] Width of action column is wrong

The width of the action column in the workspaces module is
wrong. 5 icons with a width of 16px each need to be displayed
and results in a required width of 80px.

Fixes: #50210
Releases: 6.0, 6.1, 6.2
Change-Id: I3e1cbfd9be53c57dad86a6003edbf38b559dab73
Reviewed-on: https://review.typo3.org/22454
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay 22/22422/2
Stanislas Rolland [Mon, 10 Jun 2013 15:25:00 +0000 (11:25 -0400)]
[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay

Solution: When this flag is set to FALSE, do not apply language
overlays.

Resolves: #47192
Releases: 6.0, 6.1, 6.2
Change-Id: Iac0d647fde2f930a63bc6982472b1c76e649601d
Reviewed-on: https://review.typo3.org/22422
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Faulty layout if row details are too long 88/22388/2
Oliver Hader [Wed, 17 Jul 2013 11:49:52 +0000 (13:49 +0200)]
[BUGFIX] Faulty layout if row details are too long

If the row details in in the workspaces difference view are too
long, e.g. a string that does not contain white-spaces like e.g.
a filename, the layout looks broken.
The solution is to introduce a new classname for the content
details and to force word breaking via CSS.

Fixes: #50114
Releases: 6.0, 6.1, 6.2
Change-Id: I9a768aed1c9bb4ebdfea5ba79083b7e5dce262d9
Reviewed-on: https://review.typo3.org/22388
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove redundant try/catches in ResourceStorage of FAL 72/22372/2
Claus Due [Fri, 21 Jun 2013 19:13:50 +0000 (21:13 +0200)]
[TASK] Remove redundant try/catches in ResourceStorage of FAL

This change simply removes some try/catch statement which did
nothing but re-throw the RuntimeException.

Fixes: #49332
Releases: 6.0, 6.1, 6.2
Change-Id: If419874910547ac7ce2475711f922ae0f59e8e67
Reviewed-on: https://review.typo3.org/22372
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Category API does not consider multiple tables 67/22367/2
Marc Wöhlken [Fri, 5 Jul 2013 16:23:58 +0000 (18:23 +0200)]
[BUGFIX] Category API does not consider multiple tables

Using the Category API with multiple tables, leads to wrong
results due to a missing check for the correct table.

Resolves: #45332
Releases: 6.2, 6.1, 6.0
Change-Id: Iaf5b453acd434ab8d8f58932a2c96385a66abf37
(cherry picked from commit 7c97fe9f6ac712faba8dac4ecf0e2c127038b5d6)
Reviewed-on: https://review.typo3.org/22367
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Pagetree filtering crashes on draft moves 32/22332/2
Bart Dubelaar [Thu, 20 Sep 2012 20:06:14 +0000 (22:06 +0200)]
[BUGFIX] Pagetree filtering crashes on draft moves

This bugfix fixes the following pagetree issues encountered in
a draft workspace:

1. Records moved in draft could not be found
2. Pagetree would crash if a moved page occurs in the rootline of
a filtered page.
3. Filtering only looked at live page title not the draft title

Change-Id: I49c0082d013303d39c0c259a42f9bb74346ba7c8
Fixes: #39197
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22332
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Skip link validation of RTE filelink 31/22331/2
Visay Keo [Thu, 20 Jun 2013 12:01:35 +0000 (19:01 +0700)]
[BUGFIX] Skip link validation of RTE filelink

When a text is linked to a file using RTE link wizard,
linkvalidator will detect it as internal link.
The validation check for internal page when it is a file will always fail.

This patch just skip validation if it finds a link to the file.

TODO:
* Proper validation of the file need to be applied.

Resolves: #49286
Releases: 6.0, 6.1, 6.2
Change-Id: I1b4901e2ac311ae93442fef044e4f7d7ae415753
Reviewed-on: https://review.typo3.org/22331
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Setting space before/after should use !important 57/22357/2
Georg Ringer [Tue, 16 Jul 2013 05:04:08 +0000 (07:04 +0200)]
[TASK] Setting space before/after should use !important

If the setting space before/after is used, the generated styles
should use !important to override possible CSS styles done somewhere else.

Change-Id: Ib2cbef280e6d2ac9d1503448ebaede48cf9d159b
Resolves: #50038
Releases: 6.2,6.1,6.0
Reviewed-on: https://review.typo3.org/22357
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Missing/Wrong copy buttons if deflangBinding is disabled 55/22355/3
Stefan Galinski [Sat, 6 Jul 2013 13:41:16 +0000 (15:41 +0200)]
[BUGFIX] Missing/Wrong copy buttons if deflangBinding is disabled

Fixes: #49712
Releases: 6.2, 6.1, 6.0
Change-Id: If3aebb786ae6b3f23964704d5f3c13ea7b0fd0af
Reviewed-on: https://review.typo3.org/22355
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Localconf upgrade wizard fails 49/22349/2
Anja Leichsenring [Tue, 16 Jul 2013 08:24:42 +0000 (10:24 +0200)]
[BUGFIX] Localconf upgrade wizard fails

Converting localconf.php to LocalConfiguration.php
with the installtool upgrade-wizard fails on
Debian Squeeze installation.

Change-Id: Id06793fc487cd1ad6b1d56ca5ee5a99960b3f4b1
Resolves: #39434
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22349
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Indexing files does not store the language 34/22334/2
Mario Rimann [Thu, 14 Mar 2013 10:32:55 +0000 (11:32 +0100)]
[BUGFIX] Indexing files does not store the language

While indexing externals (e.g. PDF files) the language of the page
being rendered is not stored with the indexed file content. Thus
the file is shown/not shown in the wrong situations.

See detailed description in bug-report regarding the "situations".

Change-Id: I69eb1e222eb186b052eba93eaa9d5a80dd1e87ab
Resolves: #46261
Releases: 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22334
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix PHP warning trigged in initFEuser 39/22339/2
Markus Klein [Mon, 15 Jul 2013 18:32:18 +0000 (20:32 +0200)]
[BUGFIX] Fix PHP warning trigged in initFEuser

TypoScriptFrontendController::initFEuser() calls
$GLOBALS['TYPO3_DB']->cleanIntList() with a possible NULL argument.
This leads to a PHP warning in GeneralUtility::trimExplode().

Resolves: #42921
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Id33ee8fe5e4177716af6ce8c9084e098b86c280
Reviewed-on: https://review.typo3.org/22339
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] requestUpdate sensitive to spaces 10/22310/3
Wouter Wolters [Sat, 13 Jul 2013 17:26:28 +0000 (19:26 +0200)]
[BUGFIX] requestUpdate sensitive to spaces

The TCA property "requestUpdate" is sensitive to spaces, although this
is documented nowhere. Indeed "foo1, foo2" will not work whereas
"foo1,foo2" does. This patch strips spaces from the "requestUpdate"
string before testing it.

Change-Id: Ifbb1fe5be59077207316e48204d65a978592f878
Resolves: #49872
Related: #42789
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22310
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Exceptions if EXT:context_help is not installed 94/22294/2
Dmitry Dulepov [Mon, 20 May 2013 11:25:34 +0000 (15:25 +0400)]
[BUGFIX] Exceptions if EXT:context_help is not installed

If the extension 'context_help' is not installed, the web
server's error log sometimes shows exceptions like "Class
'TYPO3\CMS\ContextHelp\ExtDirect\ContextHelpDataProvider'
not found" and "Invalid argument supplied for foreach()".
This happens because the class in question is registered
to ExtDirect without checking if the corresponding
extension is loaded.

Change-Id: Ic773cff2822912aac7841955be2f09d77169fdb9
Resolves: #48394
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22294
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Permissions backend module not accessible 29/22229/2
Wouter Wolters [Thu, 11 Jul 2013 20:59:08 +0000 (22:59 +0200)]
[BUGFIX] Permissions backend module not accessible

Permissions backend module not accessible in "List" view.

Change-Id: Ic1e4e06f387ee5450466e051162572c3392e3d53
Resolves: #49918
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22229
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] File upload in RTE-Link-Editor throws 500 error 90/22190/2
Philipp Gampe [Thu, 16 May 2013 18:42:49 +0000 (20:42 +0200)]
[BUGFIX] File upload in RTE-Link-Editor throws 500 error

When you want to add a link in the RTE-Editor, you can upload files in
the "File" tab. When you select a file and want to upload it, the
reloaded content in the create-link-overlay will throw an error.

The method is feed with a translation of "none - new file".

Bypass the file or folder lookup if we do not have an integer id
and print the message instead.

Resolves: #48219
Releases: 6.2, 6.1, 6.0
Change-Id: I9e1e6bc84b21fb04608841515ac414eec8c04130
Reviewed-on: https://review.typo3.org/22190
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Allow target attribute for more doctypes 25/22225/3
Jigal van Hemert [Thu, 11 Jul 2013 13:55:33 +0000 (15:55 +0200)]
[BUGFIX] Allow target attribute for more doctypes

The target attribute for links is allowed according to w3c documentation
in more doctypes than xhtml frameset and html5.

Change-Id: Id4110399dec1c1f1d0a4d69342440021837b51a9
Resolves: #37710
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22225
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Page title change directly updates title in content area 92/22192/2
Max Roesch [Fri, 5 Jul 2013 15:00:34 +0000 (17:00 +0200)]
[BUGFIX] Page title change directly updates title in content area

Updating the page title in the page tree by double click editing it
calls the changes in right order, by first persisting the
change and then doing the reload of the content area.

Resolves: #49706
Releases: 6.2, 6.1, 6.0
Change-Id: Id108659f1a8bd7a4ecd003337b0782d4fe7d3b68
Reviewed-on: https://review.typo3.org/22192
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Allow sys_category in rootpage 39/21339/2
Stefan Froemken [Tue, 11 Jun 2013 14:27:00 +0000 (16:27 +0200)]
[TASK] Allow sys_category in rootpage

Allow sys_category records to be stored in the rootpage. (pid=0)

Resolves: #47530
Releases: 6.2, 6.1, 6.0
Change-Id: Ie71a13ec9a1be65c57e28fff63f003fc5caa6ac1
Reviewed-on: https://review.typo3.org/21339
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] requestUpdate sensitive to spaces 86/22186/2
Francois Suter [Wed, 10 Jul 2013 12:12:32 +0000 (14:12 +0200)]
[BUGFIX] requestUpdate sensitive to spaces

The TCA property "requestUpdate" is sensitive to spaces, although this
is documented nowhere. Indeed "foo1, foo2" will not work whereas
"foo1,foo2" does. This patch strips spaces from the "requestUpdate"
string before testing it.

Resolves: #42789
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I340090e93e7b8645493f8db0c8c374cb1227f684
Reviewed-on: https://review.typo3.org/22186
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Cannot load css_styled_content TS using INCLUDE_TYPOSCRIPT 70/22170/2
Ingo Renner [Thu, 27 Jun 2013 01:53:35 +0000 (18:53 -0700)]
[BUGFIX] Cannot load css_styled_content TS using INCLUDE_TYPOSCRIPT

When installing extensions they may register plugins in ext_localconf.php.
By doing so some default TypoScript is generated in
Extensionutility::configurePlugin() that is then added using
ExtensionManagementUtility::addTypoScript().

Parts of the generated TypoScript are stored in
$TYPO3_CONF_VARS['FE']['contentRenderingTemplates']* and are loaded later
during TypoScript parsing after including the content rendering template.

These TS parts are used to resolve which classes and methods to call when
a plugin needs to be rendered on a page. You can find them in
tt_content.list.20.*

"content default" used to be the old content rendering template with uid
43, today we use css_styled_content instead. The part in the TypoScript
processing chain to load these generated snippets -
TemplateService::includeStaticTypoScriptSources() - is only executed when
loading the content rendering templates using the "Include static (from
extensions)" field in template records.

In return this means if you try to move as much TS to files as possible
you will still have to include css_styled_content through the Template
records in the backend. In other words when actually trying to include
css_styled_content TS from a file, the generated snippets for
tt_content.list.20.* will not be loaded and thus no plugin can be
executed.

Resolves: #49461
Resolves: #44983
Releases: 6.2, 6.1, 6.0
Change-Id: I77c0d64759fa0b5b27cac0ae1acd55e9abefe7f8
Reviewed-on: https://review.typo3.org/22170
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
5 years ago[BUGFIX] False-Positives in SQL comparison 53/21353/3
Mario Rimann [Fri, 5 Apr 2013 21:10:29 +0000 (23:10 +0200)]
[BUGFIX] False-Positives in SQL comparison

When one has e.g. a field "foo INT(11) DEFAULT '0' NOT NULL" in
it's ext_tables.sql definition, the comparison will always complain
about that field, since the underlying DB lists this field as "int(11)"
which is lowercased.

This integrates a regex that lowercases the field types before
comparing the field from the definition against the existing field.

Change-Id: If76abbbca56d0ef0ab796a7f4e6bee1197ac39e6
Resolves: #41344
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21353
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix reverse order handling of MediaProvider 73/21473/2
Alexander Opitz [Mon, 17 Jun 2013 07:37:14 +0000 (09:37 +0200)]
[BUGFIX] Fix reverse order handling of MediaProvider

Fixing the variable used to test for valid providers in reverse order.

Resolves: #49136
Releases: 6.2, 6.1, 6.0
Change-Id: Ia80366150b853138fc41c09e59df993e1540b230
Reviewed-on: https://review.typo3.org/21473
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] BasicFileUtility uses deprecation API in a wrong way 12/22112/2
Markus Klein [Sun, 7 Jul 2013 10:05:47 +0000 (12:05 +0200)]
[BUGFIX] BasicFileUtility uses deprecation API in a wrong way

Resolves: #49765
Releases: 6.2, 6.1, 6.0
Change-Id: Ieb5e652bb35f406207f0f0b63db894c9efbb98ff
Reviewed-on: https://review.typo3.org/22112
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years agoRevert "[BUGFIX] Files with unclean path indexed multiple times" 80/22080/2
Wouter Wolters [Sat, 6 Jul 2013 22:46:13 +0000 (00:46 +0200)]
Revert "[BUGFIX] Files with unclean path indexed multiple times"

This reverts commit 8ebf5d308cfccf8b0ae3f3d9663996f2b5372066

This breaks Travis big time.

Change-Id: I238c67b827ca7d5f44c529494578fe7debfa06aa
Reviewed-on: https://review.typo3.org/22080
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Travis: Speedup cloning of repos 58/22058/2
Markus Klein [Sat, 6 Jul 2013 18:51:50 +0000 (20:51 +0200)]
[TASK] Travis: Speedup cloning of repos

Make use of the additional parameters of git clone
to vastly reduce the amount of data transfered when cloning the
repositories.

Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Id0c5f3a4ed7ee0bdeb6053c6e0dc606362909d1e
Reviewed-on: https://review.typo3.org/22058
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Files with unclean path indexed multiple times 70/22070/2
Stefan Neufeind [Sat, 6 Apr 2013 15:11:52 +0000 (17:11 +0200)]
[BUGFIX] Files with unclean path indexed multiple times

When adding a file or requesting a file by an identifier
cleanup any . and .. in the path before handing off
to the driver so files are not indexed multiple times.

Change-Id: I324c4637621165a56470fb95864eeff1254f62dc
Fixes: #46989
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22070
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] sys_file record doesn't get flagged as delete 64/22064/2
Steffen Ritter [Sat, 6 Jul 2013 20:05:52 +0000 (22:05 +0200)]
[BUGFIX] sys_file record doesn't get flagged as delete

File is deleted by driver and deleted property of FileObject is set by
ResourceStorage but new state is not persisted.
Update deleted property in updateProperties array in FileObject and
persist change.

Reintroduced after fixing tests in 836dbc652033e118967eccc0bae2ebbde8637735.

Change-Id: I0784c84af4bfb8021c648139c2feee577f3e9dc1
Fixes: #48336
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22064
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Move functional test case to functional folder 51/22051/2
Steffen Ritter [Sat, 6 Jul 2013 17:15:27 +0000 (19:15 +0200)]
[BUGFIX] Move functional test case to functional folder

ext:core File/ExtendedFileUtilityTest unit test is not really
a unit test, but more a functional test case since it does no
mocking at all and writes data directly to database.
The test case has side effects and is move to the functional
section for now.

Resolves: #49746
Releases: 6.2, 6.1, 6.0
Change-Id: I3f3917f0800a9492b01676bf2b67e81eea1ae16f
Reviewed-on: https://review.typo3.org/22051
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years agoRevert "[BUGFIX] sys_file record doesn't get flagged as delete" 38/22038/2
Christian Kuhn [Sat, 6 Jul 2013 16:10:02 +0000 (18:10 +0200)]
Revert "[BUGFIX] sys_file record doesn't get flagged as delete"

This reverts commit 66e08fe0d978ee6ca6ce1c965ae99678a4f0c88b

The patch kills unit tests. We guess there is some incomplete
mocking in Resource tests but are not able to quickly find
the root of it. The patch is reverted for now until the tests
are green again.

Change-Id: I5e7bb6e14187f7179e00b0b00decda644e1c6efe
Resolves: #48336
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22038
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] CE:Image - backend preview of image order 29/22029/2
Tim Spiekerkoetter [Fri, 5 Jul 2013 20:54:01 +0000 (22:54 +0200)]
[BUGFIX] CE:Image - backend preview of image order

The Backend preview does not reflect the sorting of the elements in the
content element. This patch added the sorting field from the TCA to the
thumbCode method.

Resolves: #48645
Releases: 6.2, 6.1, 6.0
Change-Id: I9dcec1c2baae226aeded9c4c93d368c067c0bad2
Reviewed-on: https://review.typo3.org/22029
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] sys_file record doesn't get flagged as delete 25/22025/2
Frans Saris [Wed, 22 May 2013 18:36:31 +0000 (20:36 +0200)]
[BUGFIX] sys_file record doesn't get flagged as delete

File is deleted by driver and deleted property of FileObject is set by
ResourceStorage but new state is not persisted.

Update deleted property in updateProperties array in FileObject and
persist change.

Fixes: #48336
Releases: 6.2, 6.1, 6.0
Change-Id: I6cac106dcf89125e0b98b8b12a03c0b3f56d484f
Reviewed-on: https://review.typo3.org/22025
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX][Cache] Typo3DbBackend forgets tag entries in flushByTag 17/22017/2
Christian Zenker [Wed, 12 Jun 2013 14:45:57 +0000 (16:45 +0200)]
[BUGFIX][Cache] Typo3DbBackend forgets tag entries in flushByTag

flushByTags removes cache entries tagged with a given tag, but
if those cache entries have other tags assigned, they are not
deleted in the tags table.
The patch fixes this with an additional query.

Resolves: #48984
Releases: 6.2, 6.1, 6.0
Change-Id: I7096e63cf823633f0c8a47f698bd475d7d02b83c
Reviewed-on: https://review.typo3.org/22017
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Don't show translated categories in parent tree 11/22011/2
Markus Klein [Mon, 24 Jun 2013 11:22:15 +0000 (13:22 +0200)]
[BUGFIX] Don't show translated categories in parent tree

The parent category tree should only show categories in default
language.

Resolves: #44915
Releases: 6.2, 6.1, 6.0
Change-Id: I7920cf7ae208ba2db3bd24f7da5439824064c167
Reviewed-on: https://review.typo3.org/22011
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] CSV rendering in CType table not properly done 01/22001/3
Patrick Broens [Thu, 25 Apr 2013 13:09:43 +0000 (15:09 +0200)]
[BUGFIX] CSV rendering in CType table not properly done

The CSV rendering in CType table is not done properly in
css_styled_content method render_table. It uses explode with the
delimiter, but this character can also be in the cell itself.

This patch uses the PHP function str_getcsv, which is supported from PHP
version 5.3 >

Change-Id: I5707b006ab1143c108473e5ed7079e6e65cdddca
Fixes: #47356
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22001
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] StorageRepository::findByStorageType() uses wrong typeField 95/21995/2
Philipp Gampe [Fri, 17 May 2013 03:52:17 +0000 (05:52 +0200)]
[BUGFIX] StorageRepository::findByStorageType() uses wrong typeField

The table "sys_file_storage" has no field "type".
Use the field "driver" instead.

Resolves: #48127
Releases: 6.2, 6.1, 6.0
Change-Id: I64e66a8244ddae85faf68ec3d46b4b9f2f1934ff
Reviewed-on: https://review.typo3.org/21995
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Shared defaults for CE wizard using TCAdefaults 81/21981/2
Jigal van Hemert [Thu, 27 Sep 2012 19:42:19 +0000 (21:42 +0200)]
[BUGFIX] Shared defaults for CE wizard using TCAdefaults

The page TSconfig settings for the New Content Element wizard have
a higher priority than the user TSconfig TCAdefaults. Settings which
are not different for each CE type should be set in TCAdefaults. If
they are set in the tt_content_defVals the values will be different
if the editor selected the right CE type directly than if the editor
switched CE type.

Change-Id: I8b84b3059b17f88a3d674b6faae889844cae9c67
Fixes: #41434
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21981
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Enable table property for all user settings types 77/21977/2
Philipp Gampe [Sun, 5 May 2013 21:40:14 +0000 (23:40 +0200)]
[BUGFIX] Enable table property for all user settings types

The property 'table' for user settings can also be used for other
types than password and text.

Resolves: #47966
Releases: 6.2, 6.1, 6.0
Change-Id: Icf69d480013ff1be6c0b5d43212c179468885344
Reviewed-on: https://review.typo3.org/21977
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Exception on thumbnail generation in TCA 27/21927/3
Stefan Galinski [Mon, 10 Jun 2013 17:58:42 +0000 (19:58 +0200)]
[BUGFIX] Exception on thumbnail generation in TCA

In order to test this you are needing a non-FAL
TCA file reference field. Just reference something
here, remove the reference in the filesystem again
and reload the TCA of the record. An exception will
be thrown, because the file isn't available anymore.

Fixes: #49009
Releases: 6.2, 6.1, 6.0
Change-Id: I6eccb3ef77de703551a64f52ab3904cead517c8a
Reviewed-on: https://review.typo3.org/21927
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
5 years ago[BUGFIX] Improve jumpUrl download of large files 18/21918/2
Till Busch [Thu, 11 Oct 2012 13:22:48 +0000 (15:22 +0200)]
[BUGFIX] Improve jumpUrl download of large files

* Prevent output-buffering
* Add Content-Length header

Fixes: #41718
Releases: 6.2, 6.1, 6.0
Change-Id: I8a1a33dc4337a5947bafbad980b73343be637da7
Reviewed-on: https://review.typo3.org/21918
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Web->Page - Language view not usable 91/21891/2
Stefan Galinski [Tue, 18 Jun 2013 15:26:50 +0000 (17:26 +0200)]
[BUGFIX] Web->Page - Language view not usable

Since the "all language" elements are displayed in each
language (introduced in 4.7), the language view of the
page module is not really usable anymore. If you have
activated the mod.web_layout.defLangBinding setting in the
Page TS configuration  "all language" elements are not
displayed anymore. Also you cannot overwrite "all language"
elements in an easy way inside another languages
and overwritten elements are displayed together with their
"all language" default element inside a column. Furthermore
the sorting order is sometimes broken on non-default languages
if the "all language" element is rendered inside the column.
The patch fixes all this issues in the languages view by
reverting the changes introduced the 4.7 branch just for the
languages view. The columns view works like it was intented with
the fix from the 4.7 branch (it still has the same flaws as
the languages view, but this issues can be fixed with another
changeset).

Fixes: #42768
Fixes: #42771
Releases: 6.2, 6.1, 6.0
Change-Id: Ibd222c3980ebcc7a5f273d85b3d99d6938291e9e
Reviewed-on: https://review.typo3.org/21891
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
5 years ago[TASK] Remove Comment for deprecation of f:translate key 02/21902/2
Ingo Pfennigstorf [Thu, 4 Jul 2013 20:00:27 +0000 (22:00 +0200)]
[TASK] Remove Comment for deprecation of f:translate key

In future versions the usage of f:translate key and f:translate id
will both be possible, so the comment about a deprecation is removed.

Change-Id: I71a2fc1e9abec6b26c8b3848dd31e234fc056699
Fixes: #49670
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21902
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Upload in backend does not index file 94/20194/4
Steffen Ritter [Sat, 23 Mar 2013 14:19:01 +0000 (15:19 +0100)]
[BUGFIX] Upload in backend does not index file

If a file is uploaded within the backend (f.e. file-module)
the file is not automatically indexed. If done within the
file-module the indexing happens when the folder is shown.
If the file is uploaded somehow else using the
ExtendedFileUtility it's not indexed.

Add the indexing to the upload function.

Releases: 6.1, 6.0
Fixes: #46595
Change-Id: I9ea30797390f960a8e382a1f2c456259d3daa60c
Reviewed-on: https://review.typo3.org/20194
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Rootline utility must respect pageOverlayFields 23/21723/2
Stefan Galinski [Wed, 15 May 2013 14:18:05 +0000 (16:18 +0200)]
[BUGFIX] Rootline utility must respect pageOverlayFields

The rootline calculation always overlays all fields
from the pages table. This causes trouble in e.g. the
case that you want to reuse media images from the default
language in other languages. In the previous implementation
(pre 6.x) only the overlay fields from the
 $GLOBALS['TYPO3_CONF_VARS']['FE']['pageOverlayFields']
setting were overlaid.

Fixes: #48224
Releases: 6.2, 6.1, 6.0
Change-Id: I6f5a10150c916df24542ee83e33663a27bdb593f
Reviewed-on: https://review.typo3.org/21723
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
5 years ago[BUGFIX] RTE: Importing google webfonts breaks style sheet parsing 62/21862/2
Stanislas Rolland [Wed, 3 Jul 2013 22:45:12 +0000 (18:45 -0400)]
[BUGFIX] RTE: Importing google webfonts breaks style sheet parsing

Problem: Firefox raises a security error because the file is not in the
same domain as the executing script. Probably a Firefox bug since the
file certainly has adequate headers: the font are indeed displayed in
the RTE.

Solution: Since the Webfont style sheet does not contain any css rules
anyways, we will catch the error, and if it is a security error, log it
to the Javascript console (or Firebug) and silently continue. Re-throw
any other type of error.

Resolves: #49648
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Change-Id: I225152ad5d84de50f29d3830be6f1f3e10f249c8
Reviewed-on: https://review.typo3.org/21862
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Invalid cache backend option "compression" for NullBackend 01/21801/2
Xavier Perseguers [Tue, 2 Jul 2013 12:55:07 +0000 (14:55 +0200)]
[BUGFIX] Invalid cache backend option "compression" for NullBackend

If a Typo3DatabaseBackend is changed to NullBackend, the compression flag
may be set and should be part of the NullBackend interface.

Change-Id: Id70dc582ddbe87eb8388dd79963364c23900e417
Fixes: #49585
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21801
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] EM: Scheduler task does not persist to database 93/21793/2
Alexander Opitz [Mon, 1 Jul 2013 11:47:42 +0000 (13:47 +0200)]
[BUGFIX] EM: Scheduler task does not persist to database

The scheduler task for updating extension list of the extension
manager does not persist his data to database. As Scheduler is no
extbase extension and the task is no extbase task this peristence
isn't called at end of script.

Change-Id: I75629874f698f45f1b7dab47636857b5865e8d24
Resolves: #49528
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21793
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Wrong top/bottom margin rendering in CSC 87/21787/2
Patrick Broens [Thu, 25 Apr 2013 12:38:50 +0000 (14:38 +0200)]
[BUGFIX] Wrong top/bottom margin rendering in CSC

When a top or bottom margin has been chosen together with section_frame
"no frame" -> 66, no entry is made in the temporary stylesheet.

This patch solves this issue by changing the stdWrap variable to
classStdWrap for the method renderSpace().

Change-Id: Iee6c98537e2a4a8c917dfd450289f26ce50e3ca9
Fixes: #47403
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/20155
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/21787

5 years ago[BUGFIX] Increase the width of the content element of type Plain HTML 67/21767/2
Philipp Gampe [Sun, 19 May 2013 15:55:35 +0000 (17:55 +0200)]
[BUGFIX] Increase the width of the content element of type Plain HTML

The current editor field for content elements of type HTML is for too
small. Without t3editor it is only 5 lines in height and with t3editor
it is limited to 200px which is not much more.

Increase the default size for tt_content.bodytext to 80x15 and set the
height for t3editor fields to 60% as done in setup.

Resolves: #43112
Releases: 6.2, 6.1, 6.0
Change-Id: Icc27cb013cc3009dace5dedef2f9515af1975ec0
Reviewed-on: https://review.typo3.org/20923
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/21766
Reviewed-on: https://review.typo3.org/21767

5 years ago[BUGFIX] Do not show System Extensions Wizard when done 52/21752/2
Helmut Hummel [Sun, 30 Jun 2013 14:34:52 +0000 (16:34 +0200)]
[BUGFIX] Do not show System Extensions Wizard when done

The check if the wizard has been executed before and
includes all available system extensions have been installed
is wrong. Rather than casting to bool, we should
check if the difference between "seen extensions" and
available system extensions is an empty array.

This correctly shows the wizard when not finished and
hides it when finished.

Resolves: #49256
Releases: 6.2, 6.1, 6.0
Change-Id: I7bd655b2b7eeaaa5b1dd91e80564f150b1d0d038
Reviewed-on: https://review.typo3.org/21752
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] createEncryptionKey always returns key with 96 characters 50/21750/2
Mario Rimann [Tue, 29 Nov 2011 21:00:51 +0000 (22:00 +0100)]
[TASK] createEncryptionKey always returns key with 96 characters

Update the createEncryptionKey method to use the same underlying
call as its copy in the eID script.

Change-Id: I666a3620080fd0f5281e899250f5c710e2550173
Resolves: #29220
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/21750
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] EM: TimeSinceLastUpdateViewHelper fatals if never updated 46/21746/2
Alexander Opitz [Fri, 14 Jun 2013 13:22:08 +0000 (15:22 +0200)]
[BUGFIX] EM: TimeSinceLastUpdateViewHelper fatals if never updated

If the repository was never updated (or the update failed) last_update
has the value of zero in the database.
Then NULL->format in the TimeSinceLastUpdateViewHelper leads to the fatal
error.

Resolves: #47726
Releases: 6.2, 6.1, 6.0
Change-Id: Ia41c50f2037fb1c7ef935a8855a200b303347383
Reviewed-on: https://review.typo3.org/21746
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Improve error message in NotFoundView to identify source 34/21734/2
Claus Due [Sat, 29 Jun 2013 12:43:54 +0000 (14:43 +0200)]
[TASK] Improve error message in NotFoundView to identify source

The error message before this change would only report the
action name, after this change it will reflect the controller and
extension name as well.

Set to apply to all maintained version since this changes no functions
whatsoever - it only improves error feedback.

Resolves: #49519
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I61dc32a4542b8664ca9443414278e983bc181c4a
Reviewed-on: https://review.typo3.org/21734
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Wrong placement of image caption in text with image 27/21727/2
Philipp Gampe [Sat, 29 Jun 2013 12:42:36 +0000 (14:42 +0200)]
[BUGFIX] Wrong placement of image caption in text with image

If you omit the first caption, then the following captions are shifted
into this position, meaning the the captions are off by the number of
empty captions in front.

This happens because the captions are stored with a newline "\n" as
separator which is removed by a trim = 1.

Remove this trim from tt_content.image.20.caption.1.1 as the trimming of
the actual content happens with
tt_content.image.20.caption.1.stdWrap.trim = 1.

The change also has a few cleanups that popped up in PhpStorm while
investigation the issue.

Resolves: #48354
Releases: 6.2, 6.1, 6.0
Change-Id: I4523fa40cbf991b3941d18145a09e72d5e5254d3
Reviewed-on: https://review.typo3.org/21727
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix localization of the BE user module 25/21725/2
Wouter Wolters [Sat, 29 Jun 2013 12:14:59 +0000 (14:14 +0200)]
[BUGFIX] Fix localization of the BE user module

Fix some hardcoded labels by replacing them with
f:translate tags.

Change-Id: Ic75f7bd021ff8353b7709906859d2c02eb452b23
Resolves: #49402
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21725
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] compressJs returns wrong filenames 10/21410/2
Philipp Gampe [Thu, 16 May 2013 18:23:00 +0000 (20:23 +0200)]
[BUGFIX] compressJs returns wrong filenames

If you enable
    config.concatenateJs = 1
    config.compressJs = 1
then the uncompressed version of the file is linked.

This does not change much, because compression is disabled and the files
will always be uncompressed, however the right link should be generated.

The allows extension to override the compress method and implement
compression without fixing the rest of the code.

The bug is a regression introduced with: #27694 (4.6).

Return the correct filename by overriding the filename with the returned
value of compressJsFile.

Resolves: #48213
Related: #27694
Releases: 6.2, 6.1, 6.0, 4.7
Change-Id: I1f65576db8084b54f9e5a13947ced258eef893d7
Reviewed-on: https://review.typo3.org/20845
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-on: https://review.typo3.org/21410

5 years ago[BUGFIX] stdWrap for special.value applied twice 87/21687/2
Markus Klein [Fri, 14 Sep 2012 07:28:59 +0000 (09:28 +0200)]
[BUGFIX] stdWrap for special.value applied twice

In HMENU the stdWrap for special.value is applied twice.
This patches removes the superfluous call
in HierarchicalMenuContentObject.php.

Furthermore it also moves the stdWrap for excludeUidList
to AbstractMenuContentObject.php for consistency reasons.

Change-Id: Ia6594a76602acdab8b39d50803595343e65f6d02
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Fixes: #40855
Reviewed-on: https://review.typo3.org/21687
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Add support for "outdated" extensions 20/21720/2
Jigal van Hemert [Sun, 23 Jun 2013 18:50:20 +0000 (20:50 +0200)]
[TASK] Add support for "outdated" extensions

Extension Manager displays installed extensions which are marked as
"outdated" with different styling. Reports module also checks for
installed and available "outdated" extensions.

Change-Id: I3050f3f7142e4153954f1b7f76b4bf64a3066223
Resolves: #49350
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21720
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] ActionController must use namespaced object view pattern 13/21713/2
Alexander Schnitzler [Fri, 28 Jun 2013 12:39:48 +0000 (14:39 +0200)]
[BUGFIX] ActionController must use namespaced object view pattern

The ActionController still uses the old pattern like
Tx_@extension_View_@controller_@action@format for resolving
custom view objects. When using a namespaced extension it
must be possible to also use namespaced view objects.
Therefore a new view object pattern has to be introduced:
@vendor\@extension\View\@controller\@action@format

Releases: 6.2, 6.1, 6.0
Resolves: #47609
Change-Id: Iedc6120469f2277b482c5e1c40b89790404e9bbe
Reviewed-on: https://review.typo3.org/21713
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix property mapping of checkbox arrays 00/21700/2
Helmut Hummel [Thu, 27 Jun 2013 18:09:37 +0000 (20:09 +0200)]
[BUGFIX] Fix property mapping of checkbox arrays

If multiple checkboxes are rendered but none of it is
selected, an exception is thrown as the value of the hidden field,
that is submitted is a string.

This must be the case because we need to be able to clear out
selected checkboxes and cannot craft a hidden field that will
be translated to a GET/POST arument which is an empty array.

Because of that the ArrayConverter must be able to convert
empty strings to an empty array, just like the "old"
property mapper did.

Change-Id: I115831014caca4868d1f421eb968e01178e1169b
Resolves: #47832
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21700
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix localization of the language module 77/21677/2
Wouter Wolters [Wed, 26 Jun 2013 18:10:51 +0000 (20:10 +0200)]
[BUGFIX] Fix localization of the language module

The table headers are not translatable yet.
Replace them with f:translate tags.

Change-Id: Ibe9fc989eba193f3401f40b1b7f5f8be081189ef
Resolves: #49401
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21677
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Fix one language label in the extension manager 75/21675/2
Krzysztof Adaczmyk [Wed, 26 Jun 2013 09:09:24 +0000 (11:09 +0200)]
[BUGFIX] Fix one language label in the extension manager

Make hardcoded "Search:" label translatable.

Change-Id: I006f6b98f45f0d2e82c02c1b40ed549a15ac93fd
Resolves: #49404
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21675
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Wrong result on unequal globalVar condition 64/21664/2
Marc Bastian Heinrichs [Wed, 26 Jun 2013 13:01:31 +0000 (15:01 +0200)]
[BUGFIX] Wrong result on unequal globalVar condition

A TypoScript condition like "[globalVar = LIT:10 != 10]"
returns a true value instead of the expected false value.
The reason for that is a superfluous trinity (type safe)
comparator.

Change-Id: Ib9f468da0a129f08d5d071a4f97bd09904f0c91b
Fixes: #45165
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/21664
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Record history shows two back buttons in docheader 12/21612/3
Wouter Wolters [Sun, 23 Jun 2013 12:46:46 +0000 (14:46 +0200)]
[BUGFIX] Record history shows two back buttons in docheader

The back-button is loaded twice in the record history module.
Also we add back the CSH which was missing too.

Change-Id: Ib509661bdb814f27ebff633d08ef85ada0b8e8ec
Resolves: #49338
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21612
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Invisible icon blocks mousefocus of non-required inputfields 09/21609/2
Zbigniew Jacko [Sat, 22 Jun 2013 14:05:35 +0000 (16:05 +0200)]
[BUGFIX] Invisible icon blocks mousefocus of non-required inputfields

Set z-index for clear.gif, so a backend user can select the text
inside input fields. Now it's also possible to set focus on the
input field by clicking at the beginning of it.

Fixes: #34042
Releases: 6.0, 6.1, 6.2
Change-Id: Icacbaf99d46da979a4eae715f97108df39e0728e
Reviewed-on: https://review.typo3.org/21609
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Insert rows only once in exec_INSERTmultipleRows 06/21406/2
Jigal van Hemert [Fri, 14 Jun 2013 00:21:59 +0000 (02:21 +0200)]
[BUGFIX] Insert rows only once in exec_INSERTmultipleRows

For native handler types multiple rows can be inserted using the mysql
INSERTmultipleRows API call. When another handler was used, the operation
was done twice, due to a missing else after the native handler condition.
This resulted in two database records for every INSERT statement.

The patch adds the missing else branch for the condition, preventing
the second run that was only meant to handle non-native handler types.

Change-Id: Ibab98a0c73b379bac063c8d1c19e30e93f38faf4
Resolves: #48220
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Related: #34327
Reviewed-on: https://review.typo3.org/21406
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Update URL to the exception collection 88/21588/2
Piotr Molewski [Sat, 22 Jun 2013 12:20:57 +0000 (14:20 +0200)]
[TASK] Update URL to the exception collection

Updated TYPO3_URL_EXCEPTION constant
from http://typo3.org/go/exception/v4/
to http://typo3.org/go/exception/CMS/

Resolves: #49066
Releases: 6.0, 6.1, 6.2
Change-Id: Ibfb36aab1a09a016cda2b378a396390573ff1c6d
Reviewed-on: https://review.typo3.org/21588
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Flexform field is available but not passed to sub-function calls 77/21577/2
Claus Due [Fri, 21 Jun 2013 18:47:45 +0000 (20:47 +0200)]
[BUGFIX] Flexform field is available but not passed to sub-function calls

This change fixes three occurrences of calls to FlexForm DS
processing methods which accept a $fieldName argument but in
the current state of the code is given an empty string instead
of the $field variable which exists in all three contexts and
contains the proper value.

Passing the field name along to these sub functions allows hook
subscribers to use the field name - among other things. In any
case this fixes an unexpected behaviour turning it into an
expected one.

Resolves: #49331
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I078b0734f3bfa74a9acd61773c5c380f091286f8
Reviewed-on: https://review.typo3.org/21577
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Illegal string offset warning in AjaxLoginHandler 71/21571/2
Markus Klein [Fri, 21 Jun 2013 17:40:21 +0000 (19:40 +0200)]
[BUGFIX] Illegal string offset warning in AjaxLoginHandler

After logout $GLOBALS['BE_USER']->user['uid'] is checked.
This is done without isset() which triggers a warning, as ->user is unset,
if the logout was successful.

Resolves: #49327
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ia13af7f2a75090050113ff6a5d388b790df0bab1
Reviewed-on: https://review.typo3.org/21571
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Misleading label in beuser module 68/21568/2
Markus Klein [Fri, 21 Jun 2013 17:24:08 +0000 (19:24 +0200)]
[BUGFIX] Misleading label in beuser module

Change the wording of "loginBefore" label from
"Login before"
to
"Logged in before".

This should clarify the meaning of this filter.

Resolves: #49318
Release: 6.2, 6.1, 6.0
Change-Id: I1aa15c054630c3f01859fb9ef2a40f3ca0ffad2b
Reviewed-on: https://review.typo3.org/21568
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years agoRevert "[BUGFIX] Nested FLUIDTEMPLATE doesn't work anymore" 52/21552/3
Wouter Wolters [Thu, 20 Jun 2013 20:19:32 +0000 (22:19 +0200)]
Revert "[BUGFIX] Nested FLUIDTEMPLATE doesn't work anymore"

This reverts commit 1ba19b02542087ee2f26407be28d938d663c17a4

The Unit-test breaks because it is based on a FEATURE that
has been merged in 6.1,
commit 17ba001ccaec73a90b499de19d1aeefc74242b44

Change-Id: If1fec2c489bc1258716171236165f9ce388559e4
Reviewed-on: https://review.typo3.org/21552
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Nested FLUIDTEMPLATE doesn't work anymore 86/21486/2
Stefan Galinski [Tue, 7 May 2013 14:53:07 +0000 (16:53 +0200)]
[BUGFIX] Nested FLUIDTEMPLATE doesn't work anymore

It's impossible since version 6.0 to render a
FLUIDTEMPLATE content object inside a
FLUIDTEMPLATE, because the internal fluid view
instance of the parent FLUIDTEMPLATE will be
overridden by the children FLUIDTEMPLATE.

Fixes: #48021
Releases: 6.2, 6.1, 6.0
Change-Id: I776a3b0a388bb47d2995041679e39ec7442459c2
Reviewed-on: https://review.typo3.org/21486
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix JS error with Context Sensitive Help 46/21546/2
Michel Nederlof [Wed, 19 Jun 2013 21:47:02 +0000 (23:47 +0200)]
[BUGFIX] Fix JS error with Context Sensitive Help

Using the edit form for records in a new pop window leads
to a JS error, as "top" is not defined in the new window.

Resolves: #26588
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I2eab83a2c9df2fed13fd5bcc1c829bf4f2b9a055
Reviewed-on: https://review.typo3.org/21546
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Failing FAL unit test 43/21543/3
Christian Kuhn [Thu, 20 Jun 2013 16:47:39 +0000 (18:47 +0200)]
[BUGFIX] Failing FAL unit test

Using 0042 as create mask for files in unit test from issue #49029
triggers a warning and lets the test fail when the test file is
removed again. Relaxing the create mask to 0642 solves the issue.

Change-Id: I1bfdb344df5160505d853a725584c2a98f30494b
Resolves: #49296
Related: #49029
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21543
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Correct permissions of new files 33/21533/2
Michael Knabe [Tue, 11 Jun 2013 12:26:35 +0000 (14:26 +0200)]
[BUGFIX] Correct permissions of new files

Set the correct file permissions of files created with
FAL according to the fileCreateMask.

Change-Id: I4d6562f926cd79a98c3d6b0545a14915c1d7a766
Resolves: #49029
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/21533
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Filelist: Only show paste buttons if clipObj is set 14/21514/2
Philipp Gampe [Tue, 28 May 2013 13:14:19 +0000 (15:14 +0200)]
[BUGFIX] Filelist: Only show paste buttons if clipObj is set

During introduction of the paste buttons for empty folders, I assumed
that the clipboard object is always set.
This might not be the case, e.g. in EXT:sphinx 4.0.0.

Wrap the paste button code with a check if the clibObj is set.

We can not set the clibObj here, because it depends on variables of the
calling class.

Resolves: #48603
Releases: 6.2, 6.1, 6.0
Change-Id: I2c7c322c9cb994cfdfa1511c96e8c7da143dc77a
Reviewed-on: https://review.typo3.org/21514
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Raw search can't search inside the pages table 03/21503/2
Stefan Galinski [Wed, 19 Jun 2013 11:16:12 +0000 (13:16 +0200)]
[BUGFIX] Raw search can't search inside the pages table

It's impossible to search the pages table, because a field
definition is wrongly named in the pages TCA.

Fixes: #49242
Releases: 6.2, 6.1, 6.0
Change-Id: I0d1b9eeb4ffdfbff456dfc6249cb23853cb9a357
Reviewed-on: https://review.typo3.org/21503
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Use correct path in belog modules 88/21488/2
Georg Ringer [Mon, 17 Jun 2013 12:57:47 +0000 (14:57 +0200)]
[BUGFIX] Use correct path in belog modules

Belog module links to history view but path is wrong in
the info module.

Change-Id: I3e45218b2bd8b7d69d75459f41c37512de3dd23f
Releases: 6.2, 6.1, 6.0
Resolves: #49091
Reviewed-on: https://review.typo3.org/21480
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-on: https://review.typo3.org/21488
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Cleanup ChangeLog 26/21426/2
Michael Stucki [Fri, 14 Jun 2013 12:40:16 +0000 (14:40 +0200)]
[TASK] Cleanup ChangeLog

Remove duplicate lines from ChangeLog

Change-Id: I62b32f9b0b37c3977bc61b2874e37cde289846df
Resolves: #49110
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21426
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Incorrect grouping of exclude fields in translated backend 07/20507/3
Philipp Gampe [Thu, 2 May 2013 15:44:57 +0000 (17:44 +0200)]
[BUGFIX] Incorrect grouping of exclude fields in translated backend

If you use the backend in a language other than English, then the
grouping of the exclude fields in the be_group record is messed up when
flexform fields are included.

E.g. in a German backend, all tt_content fields are grouped below pages.

Sort the table names beforehand and afterwards all fields inside each
table.
Besides the patch converts some variables names into meaningful ones.

Fixes: #47839
Related: #34098
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I28ebc69d5cfc0316bdf44558276d3e939d011c2d
Reviewed-on: https://review.typo3.org/20507
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Illegal string offset 'translations' in DatabaseRecordList 57/21457/2
Philipp Gampe [Wed, 10 Apr 2013 15:41:53 +0000 (17:41 +0200)]
[BUGFIX] Illegal string offset 'translations' in DatabaseRecordList

The return value of TranslationConfigurationProvider->translationInfo
normally is an array, but it is a string in case of an error.
Move the line below the is_array() check, because it is only needed
inside.

Fixes: #47103
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ia781eae987d9295bc2b299f83c087669c96dfd00
Reviewed-on: https://review.typo3.org/21457
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Allow non-Admins to delete Records finally 54/21454/2
dkd-egerer Sascha Egerer [Tue, 27 Nov 2012 00:42:59 +0000 (01:42 +0100)]
[BUGFIX] Allow non-Admins to delete Records finally

This patch adds the posibility for non Admins to delete
records finally in the recycler.

Change-Id: I1fda11d621403758f4d78b7fa8f730d7b47d79a7
Fixes: #34156
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21454
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] FileLogWriter ignores log file configuration 25/21325/2
Steffen Müller [Thu, 6 Jun 2013 13:42:17 +0000 (15:42 +0200)]
[BUGFIX] FileLogWriter ignores log file configuration

If there are several instances of TYPO3\CMS\Core\Log\Writer\FileLogWriter
with different log files configured in $logFile, all log records end up
in one file.

This is caused by improper use of static variable $logFileHandle.
All filehandles except the one of the latest instance are ignored.

Resolves: #48918
Releases: 6.2, 6.1, 6.0
Change-Id: Ie6de5e4789d107b541117daf6c7e9855015e0a46
Reviewed-on: https://review.typo3.org/21325
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Avoid double wrap in css_styled_content 64/21364/3
Francois Suter [Wed, 12 Jun 2013 09:38:47 +0000 (11:38 +0200)]
[BUGFIX] Avoid double wrap in css_styled_content

Since TYPO3 6.0, USER objects have stdWrap property. The
various render methods of css_styled_content still call
stdWrap themselves, resulting in a double wrap.

Remove the stdWrap calls in css_styled_content render methods.

Resolves: #49051
Releases: 6.0, 6.1, 6.2
Change-Id: I3092990a4d1efb12597dc543c222a727135d63ec
Reviewed-on: https://review.typo3.org/21364
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Missing file extension class with "file links" type 43/21343/2
Stefan Galinski [Mon, 10 Jun 2013 14:50:40 +0000 (16:50 +0200)]
[BUGFIX] Missing file extension class with "file links" type

The content element type "file links" can't render
the the css class for the file extension, because
it uses a non-existing reference from pre-FAL
times. You can find the specific css class on the
generated list item.

Fixes: #48996
Releases: 6.2, 6.1, 6.0
Change-Id: I3031770a6741a331647f3bd5699ea1a2c0d444a9
Reviewed-on: https://review.typo3.org/21343
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] List Module - Reference count limited to 20 41/21341/2
Stefan Galinski [Mon, 10 Jun 2013 15:42:22 +0000 (17:42 +0200)]
[BUGFIX] List Module - Reference count limited to 20

The reference count in the list view is limited
to 20. Use the extended view to render the counter.

Fixes: #49004
Releases: 6.2, 6.1, 6.0
Change-Id: I295f3c5ea93c5cad5e5f64ba4bfd15a8f9193e61
Reviewed-on: https://review.typo3.org/21341
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe