Packages/TYPO3.CMS.git
2 years ago[FEATURE] Option to disable validation of stored records 05/51405/18
Thomas Hohn [Tue, 24 Jan 2017 13:10:29 +0000 (14:10 +0100)]
[FEATURE] Option to disable validation of stored records

Adds two new configuration options to Install Tool which are used when
saving records using the DataHandler:

* disable the validation of records after saving them
* if validating, make a strict value comparison ('' !== 0) instead of
  the default loose comparison ('' == 0)

Fixes: #79438
Releases: master
Change-Id: I01dfae57b046db00a531dfdfc386e43fe32329e4
Reviewed-on: https://review.typo3.org/51405
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[BUGFIX] Fix CGL script to new return status strategy of php-cs-fixer 54/51554/8
Wouter Wolters [Mon, 6 Feb 2017 11:57:43 +0000 (12:57 +0100)]
[BUGFIX] Fix CGL script to new return status strategy of php-cs-fixer

Status codes are only returned when running in dry-run mode.

Resolves: #79641
Releases: master,7.6
Change-Id: I3ca770d3f8c0af5aba5793cd4155722b8b68298c
Reviewed-on: https://review.typo3.org/51554
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FEATURE] Add new imageManipulation supporting multiple crop variants 15/51515/24
Helmut Hummel [Mon, 16 Jan 2017 19:11:23 +0000 (20:11 +0100)]
[FEATURE] Add new imageManipulation supporting multiple crop variants

This feature extends the image cropping tool in the backend
so that editors can now not only select one crop area,
but multiple ones per image.

Within the crop are now also a focus are can be selected
and to preview areas that will be covered once the image
is rendered in the frontend one or more cover areas can be configured
to be shown inside the crop area.

This change also adds a format.json view helper and a view helper
to generate backend URIs that are used in the now fully Fluid rendered
imageManipulation element.

This is the TYPO3 integration part. TypeScript and CSS
will be done in a second commit.

Resolves: #75880
Releases: master
Change-Id: I646f0f0a149d05d1f3d8283bcc92ab09aede768e
Reviewed-on: https://review.typo3.org/51515
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FEATURE] Add TypeScript and CSS for new imageManipulation 65/51565/6
Raphael Okon [Tue, 7 Feb 2017 17:41:55 +0000 (18:41 +0100)]
[FEATURE] Add TypeScript and CSS for new imageManipulation

This adds the necessary TypeScript and CSS changes
for the new imageManipulation element.

Resolves: #75880
Releases: master
Change-Id: I56c5042c6e6de7141ba59014ab31051c5c9cc34f
Reviewed-on: https://review.typo3.org/51565
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FEATURE] Allow to set a custom id for fluid widgets 18/51518/6
Marco Huber [Fri, 3 Feb 2017 11:44:20 +0000 (12:44 +0100)]
[FEATURE] Allow to set a custom id for fluid widgets

With this patch you can set a customWidgetId parameter in the
widget viewhelper. This id is used in the widget identifier
in addition to the nextWidgetNumber.

With this patch two equal widgets in different content elements
don't influence each other.

A good value for the customWidgetId is the {contentObjectData.uid}.

Example:  <f:widget.paginate customWidgetId="{contentObjectData.uid}" ...

Resolves: #47006
Releases: master
Change-Id: Ief1d38457da73a35e652f11d82f441898e0394d3
Reviewed-on: https://review.typo3.org/51518
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FEATURE] EXT:Scheduler: Add link browser to choose a start page 26/50926/15
Michael Oehlhof [Sun, 11 Dec 2016 10:04:12 +0000 (11:04 +0100)]
[FEATURE] EXT:Scheduler: Add link browser to choose a start page

Resolves: #12211
Releases: master
Change-Id: I382945cd92dd8ca6c99ea200f93ea3ca2dfdef41
Reviewed-on: https://review.typo3.org/50926
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[FEATURE] Page module: Show notice "Content is also shown on:" 49/51049/6
Michael Oehlhof [Tue, 27 Dec 2016 15:30:16 +0000 (16:30 +0100)]
[FEATURE] Page module: Show notice "Content is also shown on:"

If a page is selected in page module which content is also shown on
other pages, now a notice is shown with the titles and pid of these pages.

Resolves: #69572
Releases: master
Change-Id: Ie66564da98160825f5759c6ac4937fbbeaafdce0
Reviewed-on: https://review.typo3.org/51049
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[FEATURE] Add useCacheHash to typolink viewhelpers 24/51324/2
Philipp Kitzberger [Mon, 16 Jan 2017 12:37:10 +0000 (12:37 +0000)]
[FEATURE] Add useCacheHash to typolink viewhelpers

Resolves: #79337
Releases: master
Change-Id: Ib93ac38f944d6ca74f6162e705f6bfa4fa3214a9
Reviewed-on: https://review.typo3.org/51324
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[!!!][FEATURE] Refactor and streamline click menu / context menu 24/50124/73
Tymoteusz Motylewski [Mon, 23 Jan 2017 13:49:26 +0000 (14:49 +0100)]
[!!!][FEATURE] Refactor and streamline click menu / context menu

This change unifies the ClickMenu functionality of the pagetree (ExtJS)
with the ClickMenu code given in other areas of the TYPO3 Backend.

The following changes are made:
* Unify the naming, it's "ContextMenu" not "ClickMenu" anymore
* Configuration for record types are unified, the clickmenu shows
  the same entries in the same order in any place.
* ExtJS-based ContextMenu is removed, all based on the new
  ContextMenu functionality.
* A new way for extending the items inside the ContextMenu
  is handled via ItemProviders, which can easily be extended.
* Configuring clickmenu items is not done based on PageTS (as it
  was handled with the ExtJS pagetree), however certain items can
  be disabled via PageTS.

Resolves: #78192
Releases: master
Change-Id: I380ac73ced10fdc7b1fdec7261e2d56da3d7d938
Reviewed-on: https://review.typo3.org/50124
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Paste icons available at pasting position and use modal now 35/47135/21
Jo Hasenau [Sun, 6 Mar 2016 11:45:01 +0000 (12:45 +0100)]
[FEATURE] Paste icons available at pasting position and use modal now

Resolves: #13749
Releases: master
Change-Id: Iba428acf25875479aa703ad4a93832331ed0b0be
Reviewed-on: https://review.typo3.org/47135
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Allow generated BE user avatars to be cached 67/51467/7
Claus Due [Mon, 30 Jan 2017 11:32:45 +0000 (12:32 +0100)]
[TASK] Allow generated BE user avatars to be cached

Given the assumption that this particular resource is not
one that changes very often one can benefit from storing
this in the cache_runtime in order to avoid fetching
the same avator more than one in a request.

Change-Id: Idc39c59dc8213f861ef4da7c9da4f5a95cfab9ac
Resolves: #79547
Releases: master
Reviewed-on: https://review.typo3.org/51467
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Introduce allowLanguageSynchronization 91/51291/31
Oliver Hader [Thu, 12 Jan 2017 14:21:52 +0000 (15:21 +0100)]
[FEATURE] Introduce allowLanguageSynchronization

This feature introduces a new functionality called
"allowLanguageSynchronization" which can be set on a field
configuration of a TCA column. This is the successor of
"l10n_mode=mergeIfNotBlank" as the old option had several
conceptual downsides:

1) "mergeIfNotBlank" took the value of the default record
   during runtime, but only if the translation field was empty.
   This means it was not possible to see what the record
   actually contained without having all fields of the parent
   at hand.

2) It was not possible to have a value "santa" in the original
   record but remove the option in a translation (because an
   empty string "" implicitly triggered the runtime call in the
   frontend)

3) "mergeIfNotBlank" did not work on relations except for files
   fetched via the FileRepository API calls, but for no other
   inline elements.

4) "mergeIfNotBlank" did the overlay functionality in the frontend,
   but only FormEngine and DataHandler took care of the option.
   Custom backend modules had to implement the same functionality.

5) In FormEngine, there was an icon in the translation record that
   if the record kept empty the value of the original language was
   taken, but this is not optimal in terms of usability.

6) "mergeIfNotBlank" did not take the new l10n_source option into
   account, where localizations could be made from other records
   than the default language "0".

The new feature can be set on any TCA column setting:

$GLOBALS['TCA'][<table-name>]['columns']
[<field-name>]['config']['behaviour']
['allowLanguageSynchronization'] = true;

This brings an option to records with translations (both from
l10n_parent and l10n_source) to have the value for all translations
synchronized or explictly have a checkbox to use a custom value.

The information whether a field is custom filled, or kept in sync
from l10n_parent/l10n_source is stored in a separate field called
"l10n_state" inside the database.

The introduced upgrade wizard and TCA migration to remove
"l10n_mode=mergeIfNotBlank" has been modified to migrate to this
option and add a l10n_state database field if a TCA table used
"mergeIfNotBlank" but did not add the l10n_state field manually
via ext_tables.sql yet.

New extensions can easily use the new option right away,
extensions that need to stay compatible with v7 and v8 can add
both options right away to have the same output.

The main goals to achieve with this change is now:

* Have consistent database values for all records regardless
  of l10n_mode=mergeIfNotBlank paving the way to fetch translated
  records without having to overlay (once l10n_mode=exclude is
  also copying values and relations)
* Be more explicit for editors about records that have a different
  or the same state as their l10n_parent/l10n_source as a benefit
  for bigger instances with a lot of languages
* Avoid hidden magic when retrieving localized records in the
  TYPO3 Frontend.

Resolves: #79658
Related: #79243
Releases: master
Change-Id: I6c2dbfeb09b47f958a536c9ab050c24ba4bbcbbd
Reviewed-on: https://review.typo3.org/51291
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Skip non existing DatabaseRowsUpdateWizard classes 63/51563/2
Frans Saris [Tue, 7 Feb 2017 13:13:37 +0000 (14:13 +0100)]
[BUGFIX] Skip non existing DatabaseRowsUpdateWizard classes

Resolves: #79661
Releases: master
Change-Id: I9639ad35764090aa38128671084e239b53639850
Reviewed-on: https://review.typo3.org/51563
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove checked items from Upgrade Analysis 62/51562/4
Philipp Gampe [Tue, 7 Feb 2017 11:49:24 +0000 (12:49 +0100)]
[BUGFIX] Remove checked items from Upgrade Analysis

Ignored files require the full path to a file for resurrection,
not just the headline.

Resolves: #79659
Releaes: master
Change-Id: I7f4ea9a0b2080c71dcd7d708c1c0ffccb30f15be
Reviewed-on: https://review.typo3.org/51562
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update “typescript” package and recompile code 60/51560/2
Andreas Fernandez [Tue, 7 Feb 2017 08:26:59 +0000 (09:26 +0100)]
[TASK] Update “typescript” package and recompile code

TypeScript is updated to at least version 2.2.0. Existing code is
recompiled due do changes of defaults in TypeScript.

Resolves: #79653
Releases: master
Change-Id: Id656c0319ee021c8475e607e5dbe35a21074dd79
Reviewed-on: https://review.typo3.org/51560
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[!!!][FEATURE] Streamline Fluid Styled Content and CSS Styled Content 65/51065/87
Benjamin Kott [Thu, 29 Dec 2016 17:41:51 +0000 (18:41 +0100)]
[!!!][FEATURE] Streamline Fluid Styled Content and CSS Styled Content

CSS Styled Content has been a long time the preferred way of rendering
content in the frontend. Fluid Styled Content was introduced as
successor of CSC, but the feature set diverged from the beginning. The
lack of flexibility and incomplete feature set in comparision to CSC
made it hard to migrate existing instances.

Since TYPO3 CMS 7.6 Fluid-Templates are the defined standard and
official recommendation for content rendering. The feature set of FSC is
now matching CSC. Both content renderings are now streamlined to be
fully compatible with each other. For the period of CMS 8 LTS CSC will
share the same capabilities to make an transition as easy as possible.
CSC is now deprecated and goes into maintenance mode and will be removed
with CMS 9.

For compatibility, CSC is now supporting Textmedia that was before
exclusive to FSC. But also FSC has learned some tricks from CSC. Fluid
Styled Content has now support for all content elements prior existing
only in CSC, this includes "Text", "Text and Images" and "Images". Also
for example "Frames", "Space before" and "Space after" are now again
featured across both content rendering methods.

Releases: master
Resolves: #79622
Resolves: #72422
Resolves: #75466
Resolves: #71570
Resolves: #71484
Change-Id: I7d2a9072baad508b6b87470b847444b91e7323fb
Reviewed-on: https://review.typo3.org/51065
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Show list of failed input fields in FormEngine 52/51452/13
Andreas Fernandez [Sat, 28 Jan 2017 21:04:41 +0000 (22:04 +0100)]
[FEATURE] Show list of failed input fields in FormEngine

When validating input fields of the FormEngine fails, a button is now
rendered into the least possible button bar in the module document header.
Clicking the button renders a list of all input elements whose validation
failed.

Clicking onto a field in that list automatically focuses the field in the
form.

Resolves: #79521
Releases: master
Change-Id: I9e232f4d1b27216ccf4a1c7b88d4a9c70b49f4f0
Reviewed-on: https://review.typo3.org/51452
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Typos and wording issues in master documentation 51/51551/3
Stephan Großberndt [Mon, 6 Feb 2017 10:44:10 +0000 (11:44 +0100)]
[BUGFIX] Typos and wording issues in master documentation

Fixes: #79639
Releases: master
Change-Id: Ib1a963a4110114de4e2db533e610635a3a47cb6b
Reviewed-on: https://review.typo3.org/51551
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Auto-render and attach HeaderAssets and FooterAssets 80/51380/12
Claus Due [Sun, 22 Jan 2017 12:31:30 +0000 (13:31 +0100)]
[FEATURE] Auto-render and attach HeaderAssets and FooterAssets

This patch adds a new method on ActionController,
initializeAssetsForRequest($request) which comes
with a default implementation and allows overriding
in subclasses.

The default implementation of this new feature will
try to render sections HeaderAssets and FooterAssets
from the Fluid template that is resolved, assigning
the output (if not empty) to either header or footer,
by using the PageRenderer.

The feature only works for TemplateView and
subclasses thereof, since `renderSection` is not a
required method for ViewInterface implementations;
it only exists on the (MVC-centric) TemplateView.

Change-Id: Ia815410637982c077236e12a848bdd26ead22e69
Releases: master
Resolves: #79409
Reviewed-on: https://review.typo3.org/51380
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Show warning label for linkhandler if no label is defined 29/51529/3
Markus Klein [Fri, 3 Feb 2017 21:25:33 +0000 (22:25 +0100)]
[BUGFIX] Show warning label for linkhandler if no label is defined

If the configuration for a linkhandler has an empty label
put a warning label there instead to give the integrator a hint
that the configuration is evaluated correctly.

Resolves: #79621
Releases: master, 7.6
Change-Id: Ib00a86be339908408c4e31eedb3c8ea57468fa87
Reviewed-on: https://review.typo3.org/51529
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Show link information below input field 79/51479/9
Georg Ringer [Mon, 30 Jan 2017 22:25:56 +0000 (23:25 +0100)]
[FEATURE] Show link information below input field

Render link information below a link field to help editors.
Instead of 't3://page?uid=92 _top "a class" "a title"' the user
will get relevant information.

Resolves: #28171
Releases: master
Change-Id: Ic285a10e1de67bf60dd5235885a8d0037792999a
Reviewed-on: https://review.typo3.org/51479
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[!!!][FEATURE] Introduce Session Framework 49/51549/7
Markus Klein [Tue, 22 Sep 2015 16:56:51 +0000 (18:56 +0200)]
[!!!][FEATURE] Introduce Session Framework

A new session framework is introduced.
The goal is to provide interoperability between different
session storages (called "backends"), like database, Redis, etc.

An integrator may enforce a specific session backend by configuring
SYS/session in LocalConfiguration.php. It is also possible to use
custom session backends by implementing
the interface "SessionBackendInterface".

Resolves: #70316
Releases: master
Change-Id: I90a4f84344e75f13b2f46245162e749ed3505ec3
Reviewed-on: https://review.typo3.org/51549
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[FEATURE] EXT:form - Extend SaveToDatabase finisher 56/51456/9
Ralf Zimmermann [Sun, 29 Jan 2017 16:40:47 +0000 (17:40 +0100)]
[FEATURE] EXT:form - Extend SaveToDatabase finisher

This feature extends the SaveToDatabase finisher with
the following functions:

* Perform multiple database operations
* Access the inserted uids from previous database inserts
* Add a special option value '{__currentTimestamp}'
* Add a variable container object which is passed through all finishers

The issue contains examples for testing.

Resolves: #79530
Releases: master
Change-Id: Ic2a569194d69434e0320c670cd879744c864b911
Reviewed-on: https://review.typo3.org/51456
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FOLLOWUP][FEATURE] Implement configuration for CKEditor 55/51555/2
Frans Saris [Mon, 6 Feb 2017 13:10:44 +0000 (14:10 +0100)]
[FOLLOWUP][FEATURE] Implement configuration for CKEditor

Use correct field to determine page uid

Resolves: #78917
Releases: master
Change-Id: I01101640ff8ac1d801ef1619f8bc3c885aee2713
Reviewed-on: https://review.typo3.org/51555
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Update outdated TYPO3 dependencies 20/51520/3
Mona Muzaffar [Fri, 3 Feb 2017 14:49:48 +0000 (15:49 +0100)]
[TASK] Update outdated TYPO3 dependencies

  - Updating doctrine/collections (v1.3.0) to doctrine/collections (v1.4.0)
  - Updating doctrine/annotations (v1.3.0) to doctrine/annotations (v1.3.1)
  - Updating doctrine/common (v2.6.2) to doctrine/common (v2.7.2)
  - Updating doctrine/dbal (v2.5.5) to doctrine/dbal (v2.5.11)
  - Updating symfony/yaml (v3.2.0) to symfony/yaml (v3.2.2)
  - Updating symfony/finder (v3.2.0) to symfony/finder (v3.2.2)
  - Updating symfony/event-dispatcher (v3.2.0) to symfony/event-dispatcher (v3.2.2)
  - Updating symfony/dom-crawler (v3.2.0) to symfony/dom-crawler (v3.2.2)
  - Updating symfony/css-selector (v3.2.0) to symfony/css-selector (v3.2.2)
  - Updating symfony/debug (v3.2.0) to symfony/debug (v3.2.2)
  - Updating symfony/console (v3.2.0) to symfony/console (v3.2.2)
  - Updating symfony/browser-kit (v3.2.0) to symfony/browser-kit (v3.2.2)
  - Updating sebastian/comparator (1.2.2) to sebastian/comparator (1.2.4)
  - Updating phpunit/phpunit-mock-objects (3.4.2) to phpunit/phpunit-mock-objects (3.4.3)
  - Updating phpunit/php-code-coverage (4.0.3) to phpunit/php-code-coverage (4.0.5)
  - Updating myclabs/deep-copy (1.5.5) to myclabs/deep-copy (1.6.0)
  - Updating phpunit/phpunit (5.7.5) to phpunit/phpunit (5.7.11)
  - Updating guzzlehttp/promises (1.3.0) to guzzlehttp/promises (v1.3.1)
  - Updating symfony/process (v3.2.0) to symfony/process (v3.2.2)
  - Updating facebook/webdriver (1.2.0) to facebook/webdriver (1.3.0)
  - Updating codeception/codeception (2.2.8) to codeception/codeception (2.2.9)
  - Updating symfony/filesystem (v3.2.0) to symfony/filesystem (v3.2.2)
  - Updating symfony/stopwatch (v3.2.0) to symfony/stopwatch (v3.2.2)

Resolves: #79614
Releases: master
Change-Id: Ibbefff219570421d8b0037aef5788b07bb3fb4e4
Reviewed-on: https://review.typo3.org/51520
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Wrong position of init 44/51344/2
Stefan Froemken [Wed, 18 Jan 2017 14:48:00 +0000 (15:48 +0100)]
[BUGFIX] Wrong position of init

As storeIncomingData depends on some data,
which is generated in init, the init method
has to be called before.

Resolves: #79374
Releases: master, 7.6
Change-Id: I55e9f1317db83205b3a9ad0105eb8b493203ced7
Reviewed-on: https://review.typo3.org/51344
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Auto-render HeaderAssets and FooterAssets in FLUIDTEMPLATE 82/51382/6
Claus Due [Sun, 22 Jan 2017 16:48:10 +0000 (17:48 +0100)]
[FEATURE] Auto-render HeaderAssets and FooterAssets in FLUIDTEMPLATE

This patch adds a new feature for FLUIDTEMPLATE
content objects, allowing two new sections named
`HeaderAsstes` and `FooterAssets` to be defined.
When rendering the content object, those sections
then get rendered and assigned as either header or
footer data via PageRenderer.

Both sections are optional and can be combined.

Change-Id: I981f2148050b972ef42d9b18a1b428f874407615
Resolves: #79413
Releases: master
Reviewed-on: https://review.typo3.org/51382
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] EXT:form - optimize DatePicker element 61/51461/8
Ralf Zimmermann [Sun, 29 Jan 2017 23:12:35 +0000 (00:12 +0100)]
[TASK] EXT:form - optimize DatePicker element

* add more configuration options to the DatePicker element
  within the form editor
* render the frontend JavaScript as inline JavaScript within the page
  footer
* fix small bugs

Resolves: #79539
Releases: master
Change-Id: I7a33abbc3502dbad37e228313b93e32ae5b19bf5
Reviewed-on: https://review.typo3.org/51461
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] EXT:Scheduler: Implemented folding of scheduler task groups 37/51037/6
Michael Oehlhof [Fri, 23 Dec 2016 10:45:15 +0000 (11:45 +0100)]
[FEATURE] EXT:Scheduler: Implemented folding of scheduler task groups

Resolves: #67243
Releases: master
Change-Id: Ic3d1bc45b9db9ae3eb6fd8f13a03fcf9125d7422
Reviewed-on: https://review.typo3.org/51037
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Storable Filters for Upgrade Analysis 50/51050/21
Anja Leichsenring [Tue, 27 Dec 2016 16:22:09 +0000 (17:22 +0100)]
[FEATURE] Storable Filters for Upgrade Analysis

User can mark each file as 'hide from my view'. This
selection is stored in registry and applies for every user alike.

All hidden files are accessible via a section and can be restored.
This selection again applies for all users.

Change-Id: Ia3108977ca5cb180dd0e1925ff918ffb03452249
Resolves: #79420
Releases: master
Reviewed-on: https://review.typo3.org/51050
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Null placeholder initialization in inline expand 42/51542/2
Christian Kuhn [Sun, 5 Feb 2017 12:15:48 +0000 (13:15 +0100)]
[BUGFIX] Null placeholder initialization in inline expand

Opening a collapsed inline relation containing null placeholders
does not correctly initialize and both the value field as well as
the placeholder field are shown.
Easily reproducible with a FAL relation on a page record.
Fix JavaScript to initialize correctly.

Change-Id: I27b52b9f69beb24d0309422cbcf2b67cc8190e07
Resolves: #79632
Related: #79440
Releases: master
Reviewed-on: https://review.typo3.org/51542
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alex Kellner <alexander.kellner@einpraegsam.net>
Tested-by: Alex Kellner <alexander.kellner@einpraegsam.net>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Suggest wizard in flex forms 43/51543/2
Christian Kuhn [Sun, 5 Feb 2017 12:33:18 +0000 (13:33 +0100)]
[BUGFIX] Suggest wizard in flex forms

A broken variable access is fixed to hand over correct data
to the type=group suggest wizard.

Change-Id: I0c6dbf3d7da114f633e779eb594b6457a5e4fac6
Resolves: #79574
Related: #79440
Releases: master
Reviewed-on: https://review.typo3.org/51543
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Handle invalid link strings gracefully in LinkHandler 30/51530/2
Markus Klein [Fri, 3 Feb 2017 22:45:41 +0000 (23:45 +0100)]
[BUGFIX] Handle invalid link strings gracefully in LinkHandler

Resolves: #79623
Releases: master
Change-Id: Iefef14b968d4edfbfbe221ee5b58e3947d5f0d9c
Reviewed-on: https://review.typo3.org/51530
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Acceptance test paths 41/51541/2
Christian Kuhn [Sun, 5 Feb 2017 11:23:09 +0000 (12:23 +0100)]
[BUGFIX] Acceptance test paths

Change-Id: I0660bddb5411c8b02fe2cf2e285343f90f49e4d9
Resolves: #79631
Related: #79518
Releases: master
Reviewed-on: https://review.typo3.org/51541
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Limit primary key length on be_session and fe_session table 38/51538/3
Christian Kuhn [Sat, 4 Feb 2017 12:44:51 +0000 (13:44 +0100)]
[BUGFIX] Limit primary key length on be_session and fe_session table

Patch for issue #79566 increased the field length of ses_name in
fe_session and be_session table from 32 to 255.
This field is used together with ses_id as primary key.
With utf8, this now exceeds maximum key length of 757 bytes.
To fix the issue, ses_name is cut down to 100 for the time being,
the patch should be fine for master and 7.6 this way.

Change-Id: I06abecca0f8df483590cf0a3c193134083e8f5f1
Resolves: #79628
Related: #79566
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51538
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add missing namespace parts 35/51535/5
Susanne Moog [Sat, 4 Feb 2017 14:29:09 +0000 (15:29 +0100)]
[BUGFIX] Add missing namespace parts

As the main test case files are now
in subfolders, we need to correct the
namespaces.

Change-Id: Ie06edc099c5d3e42ff842eded03cde1ddf34c0ca
Releases: master
Resolves: #79629
Reviewed-on: https://review.typo3.org/51535
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix missing variable initialization in AbstractTreeView 27/51527/2
Markus Klein [Fri, 3 Feb 2017 20:42:34 +0000 (21:42 +0100)]
[TASK] Fix missing variable initialization in AbstractTreeView

https://review.typo3.org/49750 introduced code that lacks proper
variable initialization.
Get this straight.

Resolves: #79620
Releases: master, 7.6
Change-Id: I1b5735807f7f0fc476a5370f23d6b7d4654e4599
Reviewed-on: https://review.typo3.org/51527
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][TASK] Testing Framework Extraction - Next Steps 25/51525/2
Christian Kuhn [Fri, 3 Feb 2017 16:00:08 +0000 (17:00 +0100)]
[FOLLOWUP][TASK] Testing Framework Extraction - Next Steps

Fix travis

Change-Id: Ib28fdfdfd87c3643e06fee4a67b9332b17227e48
Resolves: #79518
Releases: master
Reviewed-on: https://review.typo3.org/51525
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Testing Framework Extraction - Next Steps 49/51449/12
Susanne Moog [Sat, 28 Jan 2017 09:24:15 +0000 (10:24 +0100)]
[TASK] Testing Framework Extraction - Next Steps

- Removal of the CMS part from the namespace
- Distinguish Classes / Resources

For background information see

https://decisions.typo3.org/t/testing-framework-extraction-next-steps/50

Change-Id: I3f73baeb16bbef82c9626add063c9edde41b47a6
Resolves: #79518
Releases: master
Reviewed-on: https://review.typo3.org/51449
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:form - add unit tests for the translation service 80/51480/5
Ralf Zimmermann [Mon, 30 Jan 2017 23:26:38 +0000 (00:26 +0100)]
[TASK] EXT:form - add unit tests for the translation service

This patch adds unit tests and fixes a small bug.

Resolves: #79562
Releases: master
Change-Id: If71015177c4a36acde0b5a7a8e502b98fb841311
Reviewed-on: https://review.typo3.org/51480
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] EXT:form - Add multiselect inspector editor 57/51457/9
Ralf Zimmermann [Sun, 29 Jan 2017 19:25:08 +0000 (20:25 +0100)]
[FEATURE] EXT:form - Add multiselect inspector editor

A new inspector editor, i.e. a new field type of the form editor,
has been added.

Additionally, this patch fixes the wrong mime types of file upload
form elements.

Resolves: #79531
Resolves: #79252
Releases: master
Change-Id: I8a4111b7daf04751bbb16a0a5946700767bc0461
Reviewed-on: https://review.typo3.org/51457
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] PHP requirements: improve PHP setting value 13/51513/2
Josef Glatz [Thu, 2 Feb 2017 18:22:18 +0000 (19:22 +0100)]
[BUGFIX] PHP requirements: improve PHP setting value

Streamline PHP environment setting values. The PHP
environment setting `max_execution_time` is an integer
according to the PHP manual. This must be reflected in
the INSTALL.md. Furthermore, it can be confusing for
beginners.

Resolves: #79607
Releases: master
Change-Id: I79f1bd6386b1ebe0409b02528373b10f42e57847
Reviewed-on: https://review.typo3.org/51513
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] EXT:form - remove email validator for Textarea form elements 59/51459/2
Ralf Zimmermann [Sun, 29 Jan 2017 19:50:41 +0000 (20:50 +0100)]
[TASK] EXT:form - remove email validator for Textarea form elements

Remove the email validator from the validators select list for
Textarea form elements within the form editor.

Resolves: #79533
Releases: master
Change-Id: I9f35a2291910bc0d38b388ad5f2d5b0a0f66c242
Reviewed-on: https://review.typo3.org/51459
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Move end tag of label in info module 11/51511/2
Georg Ringer [Thu, 2 Feb 2017 15:12:27 +0000 (16:12 +0100)]
[BUGFIX] Move end tag of label in info module

To make the click on the label work, move the end tag
after the text.

Resolves: #79603
Releases: master
Change-Id: I5a8b0c5a2041118b3704bd1947c17dd833154c8a
Reviewed-on: https://review.typo3.org/51511
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Show remaining characters in BE user settings module 58/51458/3
Georg Ringer [Sun, 29 Jan 2017 19:25:56 +0000 (20:25 +0100)]
[TASK] Show remaining characters in BE user settings module

The fields name & email are saved in the database and therefore
the length of its value should be checked client side to give users
a hint about the maximal length.

Use the requireJS module of FormEngine for providing the
information about the remaining available characters.

Resolves: #79532
Releases: master, 7.6
Change-Id: Ic727fcae493060fed45ddf5b3d05c5070b236a0f
Reviewed-on: https://review.typo3.org/51458
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] Preview of plugins in the backend 23/51223/4
Georg Ringer [Mon, 9 Jan 2017 19:11:00 +0000 (20:11 +0100)]
[FEATURE] Preview of plugins in the backend

It is now possible to render the preview of plugins
just like of regular content elements.

Resolves: #79225
Releases: master
Change-Id: Iab3fb50789135d5662ca3952a2de727b69090ce6
Reviewed-on: https://review.typo3.org/51223
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] EXT:form load yaml configurations in defined order 94/51494/2
Thorben Nissen [Wed, 1 Feb 2017 10:31:08 +0000 (11:31 +0100)]
[BUGFIX] EXT:form load yaml configurations in defined order

Changes configuration loading of yaml configurations. Orders the yaml configuration
by the numeric keys defined in TypoScript.

Resolves: #79578
Releases: master
Change-Id: Id1fe072b024ec58bf0e1867cff97d60b12ee6589
Reviewed-on: https://review.typo3.org/51494
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Deprecate ClientUtility::getDeviceType 76/51476/3
Georg Ringer [Mon, 30 Jan 2017 19:24:07 +0000 (20:24 +0100)]
[TASK] Deprecate ClientUtility::getDeviceType

The method ClientUtility::getDeviceType is not used
and completely outdated.

Resolves: #79560
Releases: master
Change-Id: Ib1b54a3a20aa70724e1995eb5d123ba4e0c218c1
Reviewed-on: https://review.typo3.org/51476
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Hide password hash for RsaInputField 95/51495/2
Georg Ringer [Wed, 1 Feb 2017 11:11:49 +0000 (12:11 +0100)]
[BUGFIX] Hide password hash for RsaInputField

If rsauth is used, the eval configuration does not
contain the setting 'password' and the password can always
be hidden.

Resolves: #79576
Releases: master
Change-Id: Idcc8df67400be1d3f54e948681104ff9ad2d009e
Reviewed-on: https://review.typo3.org/51495
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] EXT:form - Refactor fluid rendering 42/51442/13
Ralf Zimmermann [Thu, 26 Jan 2017 22:52:51 +0000 (23:52 +0100)]
[!!!][TASK] EXT:form - Refactor fluid rendering

This patch is a followup of issue #79439.

EXT:form uses "fluid" as the default rendering strategy.
Therefore, EXT:form has to work close with the concepts of fluid to
avoid current and future problems.
Until now, EXT:form tried to reuse a fluid view instance by
reconfiguring the instance on each nesting level, but fluid is not
intended for such a purpose.
Therefore, the templates have to be moved/ changed and some
configuration has to be changed.
The patch breaks EXT:form only for people who are using custom
configurations/ templates.

Resolves: #79464
Releases: master
Change-Id: I6346b888b47a52bcc995c7d4cd3acdc65a1396c8
Reviewed-on: https://review.typo3.org/51442
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Set TYPO3_DLOG constant in testing framework 04/51504/3
Markus Klein [Thu, 2 Feb 2017 00:18:04 +0000 (01:18 +0100)]
[BUGFIX] Set TYPO3_DLOG constant in testing framework

The constant is undefined currently and hence leads to useless calls
to the devLog facility.
Set this constant to false by default to avoid that.

Resolves: #79588
Releases: master
Change-Id: I22f9c3ddb564ccd86b763672120bd5991c97fb79
Reviewed-on: https://review.typo3.org/51504
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Fix dom path to select items and buttons 09/51509/2
Daniel Lorenz [Thu, 2 Feb 2017 11:43:21 +0000 (12:43 +0100)]
[BUGFIX] Fix dom path to select items and buttons

Resolves: #79600
Releases: master
Change-Id: Ife6221668159ea02e8980ab449d394c1a8fb3df3
Reviewed-on: https://review.typo3.org/51509
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Allow long cookie names 83/51483/2
Marco Huber [Tue, 31 Jan 2017 10:29:36 +0000 (11:29 +0100)]
[BUGFIX] Allow long cookie names

With this patch cookie names longer than 32 chars are possible.

Resolves: #79566
Releases: master, 7.6
Change-Id: I5132defab6e7524ed4aaf48ea29e44da40aee516
Reviewed-on: https://review.typo3.org/51483
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix CSH on Info -> Pagetree overview 03/51503/2
Tymoteusz Motylewski [Wed, 1 Feb 2017 19:10:18 +0000 (20:10 +0100)]
[BUGFIX] Fix CSH on Info -> Pagetree overview

Fixes undefined variable.

Releases: master
Resolves: #79586
Change-Id: I9873775cabfd274c03353b1022f325ee2636269f
Reviewed-on: https://review.typo3.org/51503
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Remove empty option tag in fluid select viewhelper 88/51388/8
Marcus Schwemer [Sun, 22 Jan 2017 21:24:39 +0000 (22:24 +0100)]
[BUGFIX] Remove empty option tag in fluid select viewhelper

Currently the select viewhelper produces an empty option tag, if no
argument "option" is provided. This is not needed.

Resolves: #79274
Releases: master
Change-Id: Ie3a78f241cba19875c866bbc44c48d58603a1e91
Reviewed-on: https://review.typo3.org/51388
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[FEATURE] Implement configuration for CKEditor 19/50919/20
Benni Mack [Tue, 17 Jan 2017 20:38:07 +0000 (21:38 +0100)]
[FEATURE] Implement configuration for CKEditor

The main problem with the current RTE configuration relies in the fact
that it is *only* configurable via pageTS.

CKEditor can now be configured via YAML, but the configuration preset
can be overriden via pageTS.

Additionally, the CKEditor Form Element is cleaned up.

A different preset can be used via PageTS config:
- RTE.default.preset = minimal
- RTE.config.tt_content.bodytext.preset = full

Once included, the next features will be
- a configuration backend module for ckeditor
- Make sure to re-add the feature for RTE.anchorClasses
- Check the languages of CKeditor that they are in line with the TYPO3
languages (possibility to add others)
- image handling
- table handling

Resolves: #78917
Releases: master
Change-Id: Ia222b73072b9e3fdb3a120d0be0a24a913552126
Reviewed-on: https://review.typo3.org/50919
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Use strict comparison for strings 62/51462/6
Georg Ringer [Mon, 30 Jan 2017 06:42:37 +0000 (07:42 +0100)]
[TASK] Use strict comparison for strings

Change string comparison for string checks. Checks which could lead
to false positives like comparing with '0' or '' are excluded.
RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+')

Resolves: #79540
Resolves: master
Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9
Reviewed-on: https://review.typo3.org/51462
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Remove additional lines in textareas of formengine 90/51490/2
Georg Ringer [Tue, 31 Jan 2017 19:15:20 +0000 (20:15 +0100)]
[BUGFIX] Remove additional lines in textareas of formengine

Remove additional lines around the actual content of a
textarea.

Resolves: #79573
Releases: master
Change-Id: I636afb0ec63d34d4a209caeaa1369bc65727665d
Reviewed-on: https://review.typo3.org/51490
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] Temporarily skip repeatedly failing tests 87/51487/2
Mona Muzaffar [Tue, 31 Jan 2017 11:35:15 +0000 (12:35 +0100)]
[BUGFIX] Temporarily skip repeatedly failing tests

Resolves: #79552
Releases: master
Change-Id: I3da3eafd095a00062e01e4ab24d6c9ebf41c3a2e
Reviewed-on: https://review.typo3.org/51487
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Clear search field in Install Tool with ESC 84/51484/6
Georg Ringer [Tue, 31 Jan 2017 10:33:30 +0000 (11:33 +0100)]
[TASK] Clear search field in Install Tool with ESC

As the search in the Install Tool > All configuration can be
triggered by using CTRL + f, it should also listen on the
ESC key to clear the search again.

Resolves: #79567
Releases: master, 7.6
Change-Id: I9a304bb455153429f99354a4ef684326b1baa612
Reviewed-on: https://review.typo3.org/51484
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Marco Huber <mail@marco-huber.de>
Tested-by: Marco Huber <mail@marco-huber.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[TASK] Show description of tests in Install Tool at start 78/51478/3
Georg Ringer [Mon, 30 Jan 2017 20:55:48 +0000 (21:55 +0100)]
[TASK] Show description of tests in Install Tool at start

The description of the following tests should be shown right away
instead after the test:

- Combining images
- Converting images
- Gdlib
- Scaling images
- Write gif & png

Furthermore the tag is used to highlight code.

Resolves: #79561
Releases: master
Change-Id: I90d1d3ff9f14cc193d4f67124e7a804085586106
Reviewed-on: https://review.typo3.org/51478
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Use normalized jpg_quality in GraphicalFunctions 00/51400/3
Sascha Egerer [Mon, 23 Jan 2017 13:47:20 +0000 (14:47 +0100)]
[TASK] Use normalized jpg_quality in GraphicalFunctions

If the setting 'processor_effects' is set the already normalized
value of jpg_quality should be used.

Change-Id: Idcebd8dfeadbc0c85e756281ed3ba05f8f9b965c
Resolves: #79428
Releases: master
Reviewed-on: https://review.typo3.org/51400
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Add Index.rst to master folder 70/51470/2
Philipp Gampe [Mon, 30 Jan 2017 14:02:19 +0000 (15:02 +0100)]
[TASK] Add Index.rst to master folder

Resolves: #79555
Releases: master
Change-Id: I1a7523dbc87907cba754c405cc4bbf9050a51255
Reviewed-on: https://review.typo3.org/51470
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Temporaryly skip tests repeatedly failing 68/51468/5
Mona Muzaffar [Mon, 30 Jan 2017 12:10:16 +0000 (13:10 +0100)]
[BUGFIX] Temporaryly skip tests repeatedly failing

Change-Id: I7d2492782ff1a7203beafc37a1b4457bf65735a2
Resolves: #79552
Releases: master
Reviewed-on: https://review.typo3.org/51468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Link to crawler extension docs 63/51463/3
Christian Weiske [Mon, 30 Jan 2017 09:50:55 +0000 (10:50 +0100)]
[TASK] Link to crawler extension docs

Change-Id: Ie1e780af0b15c9785225bd8a147b08458b6a3b06
Resolves: #79541
Releases: master
Reviewed-on: https://review.typo3.org/51463
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Use “error” icon for validation failures in FormEngine 60/51460/3
Andreas Fernandez [Sun, 29 Jan 2017 20:38:16 +0000 (21:38 +0100)]
[TASK] Use “error” icon for validation failures in FormEngine

Currently, a warning sign is rendered next to field labels whose
validation failed. Failed validations are errors and thus another icon
should be rendered. With this patch, a red circle containing an
exclamation mark is rendered. It’s the same icon as in the tabs holding
affected fields.

Resolves: #79537
Releases: master
Change-Id: I01b783c36dfac551bf6e9f0cb8fc703290c3eb72
Reviewed-on: https://review.typo3.org/51460
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix wrong condition in method checkValueForText 65/51465/3
Dominique Kreemers [Mon, 30 Jan 2017 10:48:41 +0000 (11:48 +0100)]
[BUGFIX] Fix wrong condition in method checkValueForText

This makes "eval" processing working again for text fields.

Resolves: #79545
Related: #79341
Releases: master
Change-Id: Icda2f32a41a95afa33c87be9ed60c5b5ed47f275
Reviewed-on: https://review.typo3.org/51465
Reviewed-by: Marcus Schwemer <ms@schwemer.de>
Tested-by: Marcus Schwemer <ms@schwemer.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[FOLLOWUP][TASK] Code cleanup for RteHtmlParser 55/51455/2
Frans Saris [Sun, 29 Jan 2017 15:56:29 +0000 (16:56 +0100)]
[FOLLOWUP][TASK] Code cleanup for RteHtmlParser

Resolves: #79280
Releases: master
Change-Id: I1d3815cef36d624c910d40eb6d63a3eba4f3f53d
Reviewed-on: https://review.typo3.org/51455
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Improve LogEntries partial performance 64/51464/2
Claus Due [Mon, 30 Jan 2017 10:06:56 +0000 (11:06 +0100)]
[TASK] Improve LogEntries partial performance

This patch avoids `f:switch` in the partial template,
since this ViewHelper is not compilable in the
version provided as override from TYPO3 CMS.

The patch also adds the CompileWithRenderStatic
trait to a ViewHelper used frequently in that partial.

Change-Id: I768e43e7c70a17fef04c28774169d4b3badb310b
Resolves: #79542
Releases: master
Reviewed-on: https://review.typo3.org/51464
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Remove ses_hashlock from acceptance test fixtures 53/51453/3
Andreas Fernandez [Sun, 29 Jan 2017 11:11:38 +0000 (12:11 +0100)]
[BUGFIX] Remove ses_hashlock from acceptance test fixtures

With the merge of #79513 the fields `ses_hashlock` were removed from
be_users and fe_users. The usages within the acceptance test fixtures
were not removed, causing the acceptance test to fail.

This patch removes the field usages in the fixtures.

Resolves: #79526
Related: #79513
Releases: master
Change-Id: Ibf139599ac0b71f510e322e011d461c4df400664
Reviewed-on: https://review.typo3.org/51453
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Do not strip sub-paths from emulated controller name 51/51451/4
Claus Due [Sat, 28 Jan 2017 12:02:52 +0000 (13:02 +0100)]
[BUGFIX] Do not strip sub-paths from emulated controller name

This patch solves a special case in the integration with
Fluid. Fluid itself allows an emulated controller action
to be used, which contains a sub-path (controller name
supports this as well). However, the RenderingContext
forced use of pathinfo() on the passed path, which caused
sub-paths to be removed. The patch switches from
pathinfo() to substr() to preserve any slashes in such
controller action names.

Only direct usage of Fluid's API is affected and no
current compatibility is broken by the patch.

Change-Id: I7e1c27d55a44b957aadbace571e50afd7614d8a0
Resolves: #79519
Releases: master
Reviewed-on: https://review.typo3.org/51451
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[CLEANUP] Simplify updating of timestamp in writeForeignField 76/50976/3
Thomas Hohn [Thu, 15 Dec 2016 10:45:22 +0000 (11:45 +0100)]
[CLEANUP] Simplify updating of timestamp in writeForeignField

There is no need to check the record we are updating -
since we update it anyway, update timestamp too and
save both a call to getRecord and a loop through fields,
casting and checking each field value comparing to DB.

Change-Id: Ic807030c5cea83d36e543ed0f75cf980c3872d1e
Releases: master, 7.6
Resolves: #79004
Reviewed-on: https://review.typo3.org/50976
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:linkvalidator Keep field content when saving new task 11/51011/2
Michael Oehlhof [Tue, 20 Dec 2016 22:43:29 +0000 (23:43 +0100)]
[BUGFIX] EXT:linkvalidator Keep field content when saving new task

When saving a new linkvalidator task in the scheduler and the validation
failed, now the previous input is kept in the external fields.

Resolves: #79056
Releases: master
Change-Id: Ib629f47890f2972de8c8bfa28644ef933357c374
Reviewed-on: https://review.typo3.org/51011
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Remove alerts of locked records 87/51387/2
Georg Ringer [Sun, 22 Jan 2017 20:36:30 +0000 (21:36 +0100)]
[TASK] Remove alerts of locked records

Use tooltips instead of ancient JavaScript alerts for locked
records.

Resolves: #79422
Releases: master
Change-Id: Ia9911f8eaad1c55c2af14e366af13e0e9b7b21df
Reviewed-on: https://review.typo3.org/51387
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Change EM composer mode message to info level 59/51059/2
Benjamin Franzke [Thu, 29 Dec 2016 12:10:17 +0000 (13:10 +0100)]
[BUGFIX] Change EM composer mode message to info level

As https://review.typo3.org/#/c/44025/ enabled extensionmanager
offline mode for composer installations, the composer mode message
should no longer be a warning but an info.

Releases: master, 7.6
Fixes: #79107
Change-Id: Ic9fcb134c113172de504833ed81f7a46a0ba4e2c
Reviewed-on: https://review.typo3.org/51059
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Avoid version overlay if EXT:version is not loaded 52/50952/5
Claus Due [Tue, 13 Dec 2016 16:31:36 +0000 (17:31 +0100)]
[BUGFIX] Avoid version overlay if EXT:version is not loaded

PlainDataResolver will do semi-expensive operations for
workspaces-enabled tables even if EXT:version (and
therefore EXT:workspaces) is not loaded.

Doing a cheap check can prevent calling two such
operations and saves SQL queries and memory.

Change-Id: I6062538c3c158352b7be5748d407bbe2aad3a641
Resolves: #78982
Releases: master
Reviewed-on: https://review.typo3.org/50952
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Consolidate code duplications in form data groups 43/51443/3
Artus Kolanowski [Wed, 25 Jan 2017 00:33:00 +0000 (01:33 +0100)]
[TASK] Consolidate code duplications in form data groups

Introduce a new class `OrderedProviderList` which calls providers
with dependencies given by setter.

Resolves: #79512
Releases: master
Change-Id: Icf97e2e6fa5ed88d7b76b7628bb4e9790b615a38
Reviewed-on: https://review.typo3.org/51443
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Extbase: Fix counting objects on joined tables 20/51320/3
Morton Jonuschat [Sun, 15 Jan 2017 21:21:44 +0000 (13:21 -0800)]
[BUGFIX] Extbase: Fix counting objects on joined tables

While it's normally fine to replace DISTINCT with GROUP BY when counting
objects this results in a different resultset. The GROUP BY statement will
have n rows with the count per grouped combination while the DISTINCT
based query will have one row with the count of unique combinations.

Use a COUNT(DISTINCT uid) to get the expected result.
DISTINCT is supported on MySQL, PostgreSQL, Oracle and MSSQL Server.

Change-Id: If3193113529f1bb01693dba39abccfe349f169b1
Resolves: #79330
Releases: master
Reviewed-on: https://review.typo3.org/51320
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Move page module function QuickEdit to EXT:compatibility7 40/51340/10
Artus Kolanowski [Tue, 17 Jan 2017 23:46:33 +0000 (00:46 +0100)]
[!!!][TASK] Move page module function QuickEdit to EXT:compatibility7

To follow the concept of backend apps and provide a lean core by
removing a rarely used feature, which benefit is pretty low for
the editor.

Resolves: #79364
Releases: master
Change-Id: Ic1796aa4f23507ac45b52155c66da02cffc88b3b
Reviewed-on: https://review.typo3.org/51340
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] EXT:Scheduler: Run manually executed tasks on next cron-run 07/45807/16
Michael Oehlhof [Sun, 10 Jan 2016 19:24:47 +0000 (20:24 +0100)]
[FEATURE] EXT:Scheduler: Run manually executed tasks on next cron-run

Added a feature to the scheduler to mark tasks to be run by
next cron job.

Resolves: #45537
Releases: master
Change-Id: I72d0e693821630a0be655159b53c168b1973d886
Reviewed-on: https://review.typo3.org/45807
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Deprecate the field select_key of tt_content 34/49934/8
Georg Ringer [Tue, 13 Sep 2016 18:12:06 +0000 (20:12 +0200)]
[!!!][TASK] Deprecate the field select_key of tt_content

The field `select_key` is not used by the core and
is moved to the EXT:compatibility7.

Resolves: #77934
Releases: master
Change-Id: Ied7fa722c1bccb314fd02229da407613fbce7dfe
Reviewed-on: https://review.typo3.org/49934
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Remove lockHashKeyWords functionality 37/51437/4
Benni Mack [Thu, 26 Jan 2017 16:36:46 +0000 (17:36 +0100)]
[!!!][TASK] Remove lockHashKeyWords functionality

The TYPO3 Core used the "useragent" to create a hashbase
by default to harden the session hijacking functionality.

This very very old feature adds a tiny bit of security on top,
however it has the drawback that users get logged out (of BE or FE)
if their browser updates (due to evergreen browsers or security
updates as the user agent string changes). This is very inconvenient
for websites that use a very long session time for logged in users
in the frontend (or backend) when using TYPO3 as a platform or
application.

It was originally concepted so it could be extended but there is no
hook to do so, and extending all classes does not really make a lot
of sense in the hierarchical PHP class structure.

Resolves: #79513
Releases: master
Change-Id: I78e58210da80c7c1544a644e8e10bc1f667b5bf1
Reviewed-on: https://review.typo3.org/51437
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FEATURE] Add signal to exclude tables from ReferenceIndex 62/51362/11
Thomas Hohn [Thu, 19 Jan 2017 13:38:07 +0000 (14:38 +0100)]
[FEATURE] Add signal to exclude tables from ReferenceIndex

A new signal is introduced to allow the exclusion of tables from the
ReferenceIndex. The checks whether tables or columns should be excluded
are extracted to methods.

Fixes: #79387
Releases: master
Change-Id: I5ef558bc1a1c63553e8a1dc193167d068f235487
Reviewed-on: https://review.typo3.org/51362
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Only perform reindex if data has indeed changed 18/51018/2
Thomas Hohn [Tue, 13 Dec 2016 20:46:38 +0000 (21:46 +0100)]
[BUGFIX] Only perform reindex if data has indeed changed

Change-Id: I889264f34599be556e16b3d37825a3761b681e70
Resolves: #79068
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51018
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Persist traversable domain objects via identifier 87/51287/3
Mathias Brodala [Thu, 12 Jan 2017 13:03:04 +0000 (14:03 +0100)]
[BUGFIX] Persist traversable domain objects via identifier

Objects implementing the DomainObjectInterface must always be
persisted using their identifier, even if they implement the
Traversable interface.

Change-Id: Iccb53d6e7ded9b6b5300e111e8503641b10615f4
Resolves: #79294
Related: #57255
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51287
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Add .php_cs.cache to .gitignore 41/51441/4
Georg Ringer [Thu, 26 Jan 2017 20:24:52 +0000 (21:24 +0100)]
[TASK] Add .php_cs.cache to .gitignore

The php-cs fixer creates a cache file which
should not be commited. Add it to the .gitgnore to avoid
any mistakes.

Resolves: #79510
Releases: master, 7.6
Change-Id: Ia85f825416ad767a07d280de35a18c318e1a5133
Reviewed-on: https://review.typo3.org/51441
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[!!!][FEATURE] FormEngine element level refactoring 51/51151/74
Christian Kuhn [Thu, 5 Jan 2017 17:08:27 +0000 (18:08 +0100)]
[!!!][FEATURE] FormEngine element level refactoring

The patch introduces a new API on FormEngine element level
that substitutes the old "wizards" / renderWizard() API
with a more powerful system.

Single wizards are now split into one of three categories:
* An informational wizard
* A control button / icon
* A true wizard with additonal functionality

Method renderWizards() is still called in elements for compatibility
reasons if people added own scrip/popup/userFunc wizards, but all
core wizards are migrated.

The patch significantly cleans the HTML of single elements, especially
HTML stuff that was added by the SingleFieldContainer is now put down
to single elements, while main HTML wraps formerly done by renderWizards()
is fetched "up" to single elements. This gives single elements full
control about the main HTML it is producing, which is a must have
preparation in order to further advance in this area and to switch
single elements to fluid rendering in one of the next steps.

The patch brings a pretty huge list of TCA changes and
simplifications, all TCA changes are supported by TCA migration,
so existing extensions should benefit out of the box and just
get deprecations logged.

Change-Id: I45083e14e45bbf40c06267b51c9d0b7c15e2f7ab
Resolves: #79440
Resolves: #70032
Releases: master
Reviewed-on: https://review.typo3.org/51151
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Functional test for VariableFrontend cache type 94/51394/3
Manuel Selbach [Sun, 22 Jan 2017 06:13:44 +0000 (22:13 -0800)]
[TASK] Functional test for VariableFrontend cache type

Add a functional test to verify that serialized PHP objects
can be successfully stored in the database without having
encoding/escaping problems.

Resolves: #79452
Releases: master
Change-Id: I97d586cb8a50e571d99ff8b7fc463c0a83e15f36
Reviewed-on: https://review.typo3.org/51394
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] EXT:form - Add CE preview for form plugins 22/51422/5
Ralf Zimmermann [Wed, 25 Jan 2017 10:58:06 +0000 (11:58 +0100)]
[TASK] EXT:form - Add CE preview for form plugins

Render the form label or a placeholder text (if no form is selected)
within the page module.

Resolves: #78834
Releases: master
Change-Id: I5519ce8bec7ae077d22328ff0ad70b29aa1b5af7
Reviewed-on: https://review.typo3.org/51422
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:form - Optimize frontend templates 26/51426/2
Andreas Steiger [Wed, 25 Jan 2017 15:40:03 +0000 (16:40 +0100)]
[TASK] EXT:form - Optimize frontend templates

* add attribute role="alert" to error hints
* streamline bootstrap 3 error classes
* add attribute formnovalidate to previous button of multistep form
* remove fieldset wrap from element type 'PAGE'

Resolves: #69974
Releases: master
Change-Id: I66336879bed0f94752482404c3ed7cfa7028046d
Reviewed-on: https://review.typo3.org/51426
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] EXT:form - Add form settings button to module header 25/51425/3
Ralf Zimmermann [Wed, 25 Jan 2017 15:10:42 +0000 (16:10 +0100)]
[FEATURE] EXT:form - Add form settings button to module header

Adds a new button into the form editor module header.
Clicking on this buttons shows the form settings within the inspector.

Resolves: #79467
Releases: master
Change-Id: I767c71fcf65ca5bd58b2b530a60fce1caf75e3c9
Reviewed-on: https://review.typo3.org/51425
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:form - parse finisher values only if string 81/51381/4
Ralf Zimmermann [Sun, 22 Jan 2017 16:40:24 +0000 (17:40 +0100)]
[BUGFIX] EXT:form - parse finisher values only if string

Parse finisher option values only if the referenced formelement value
is a string.

Resolves: #79412
Releases: master
Change-Id: Ie379a396473c31907d52c8aa096168fed803510b
Reviewed-on: https://review.typo3.org/51381
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Improve constant editor 86/51386/3
Georg Ringer [Sun, 22 Jan 2017 20:15:24 +0000 (21:15 +0100)]
[TASK] Improve constant editor

- Skip length check of header
- Use type "number" for integer types
- Apply min & max attributes if available

Resolves: #79421
Releases: master
Change-Id: I508000547214d3d3ca18a8e311ce68dd03dea09b
Reviewed-on: https://review.typo3.org/51386
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mattias Nilsson <tollepjaer@gmail.com>
Tested-by: Mattias Nilsson <tollepjaer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix SQL error in createEntryData 97/51397/5
Thomas Hohn [Mon, 23 Jan 2017 08:35:45 +0000 (09:35 +0100)]
[BUGFIX] Fix SQL error in createEntryData

The database field definition for ref_string is limited to varchar(200)
and can cause an SQL error when bigger strings are inserted.
In addition it makes sense to add a mb_substr() to avoid an error if
longer strings are inserted.

Fixes: #79425
Releases: master
Change-Id: I1f1e672f610f830ad5e02509cb1f0529c9cbeb41
Reviewed-on: https://review.typo3.org/51397
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Access check for delete pages expects array of integers 42/51342/4
Mona Muzaffar [Wed, 18 Jan 2017 13:42:56 +0000 (14:42 +0100)]
[BUGFIX] Access check for delete pages expects array of integers

An error occurs in the createNamedParameter function
which expects an array but gets a string instead.

Change-Id: I393a6a87c912129ded28f677ca65c081fc4205e7
Resolves: #79309
Releases: master
Reviewed-on: https://review.typo3.org/51342
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup code of LocalizationController::process 49/51349/3
Manuel Selbach [Wed, 18 Jan 2017 20:12:16 +0000 (21:12 +0100)]
[TASK] Cleanup code of LocalizationController::process

Change-Id: I6db726bfff61c092309a971eb71e074c30cad046
Releases: master, 7.6
Resolves: #79378
Reviewed-on: https://review.typo3.org/51349
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Deprecate visibility for internal variables in Datahandler class 11/51411/6
Thomas Hohn [Tue, 24 Jan 2017 21:00:33 +0000 (22:00 +0100)]
[TASK] Deprecate visibility for internal variables in Datahandler class

This patch marks some internal cache variables in the
Datahandler as deprecated since their visibility should be
changed from public to protected or even be replaced
by a runtime cache. Since this can't be done before
TYPO3 v9 they are marked as deprecated in TYPO3 v8
as a preparation.

Fixes: #79441
Releases: master
Change-Id: I7d35792fb81e6f16b3b729a3841c1cfda109952f
Reviewed-on: https://review.typo3.org/51411
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Use subselect to update reference index 70/51370/8
Thomas Hohn [Fri, 20 Jan 2017 10:57:04 +0000 (11:57 +0100)]
[BUGFIX] Use subselect to update reference index

Switch updateIndex method to use a subselect based approach
to avoid errors due to huge parameter lists for manually
built NOT IN queries which could exceed the maximum query
length.

Add a warning if the table doesn't share a connection with
the reference index as it can not be updated automatically.

Resolves: #79397
Releases: master
Change-Id: I563dfe607b24ffe949ef5a0e9d2e62b2312ff8f0
Reviewed-on: https://review.typo3.org/51370
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Debugger output: split lines before escaping them 69/51369/2
Markus Klein [Fri, 20 Jan 2017 09:16:29 +0000 (10:16 +0100)]
[BUGFIX] Debugger output: split lines before escaping them

This fixes the issue that lines are wrapped within a HTML entity.

Resolves: #79398
Releases: master, 7.6
Change-Id: I0bf1722cb9792fea0f45421fe1f72e1932879002
Reviewed-on: https://review.typo3.org/51369
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Dominique Kreemers <dominique.kreemers@icloud.com>
Tested-by: Dominique Kreemers <dominique.kreemers@icloud.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup ActionService::getVersionedId 51/51351/3
Manuel Selbach [Wed, 18 Jan 2017 20:55:29 +0000 (21:55 +0100)]
[TASK] Cleanup ActionService::getVersionedId

Within the refactoring process the optional parameter $useDeleteClause was missed
to remove from the parameter list of the method, as it is not implemented in the body and
not used anywhere in the core.

Releases: master
Resolves: #79382
Change-Id: I4db104941b78f44573b0b1f51ad216ded93887bf
Reviewed-on: https://review.typo3.org/51351
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>