Packages/TYPO3.CMS.git
4 years ago[SECURITY] Regenerate session id upon login if needed 05/40805/2 05/40805/3
Helmut Hummel [Tue, 17 Jun 2014 09:01:17 +0000 (11:01 +0200)]
[SECURITY] Regenerate session id upon login if needed

When authenticating as a frontend user with a previously
present anonymous session, the session id is not regenerated
which leads to a possible session fixation.

This is now fixed by re-generating a new id
when a user is just authenticated but no
new session id is generated during this process.

Resolves: #59258
Releases: master, 6.2
Security-Bulletin: TYPO3-CORE-SA-2015-003
Change-Id: Ia52b17e95cf8074b0f569cf025eab4d041d1677f
Reviewed-on: http://review.typo3.org/40805
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[SECURITY] Prevent edit of file metadata of files with no access 04/40804/2 04/40804/3 04/40804/4
Marc Bastian Heinrichs [Wed, 23 Apr 2014 15:28:46 +0000 (17:28 +0200)]
[SECURITY] Prevent edit of file metadata of files with no access

By forging edit URLs it was possible to edit
meta data records of files which were not
within a user mount.

Implement several hooks to check access to the file
and only grant access to a meta data record if the
user has access to the file.

Resolves: #56644
Releases: master, 6.2
Security-Bulletin: TYPO3-CORE-SA-2015-002
Change-Id: I0f0704af2e7f01d16b9420f9ba4ac1a7846b5270
Reviewed-on: http://review.typo3.org/40804
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Improve .htaccess files 54/39254/20
Andreas Fernandez [Mon, 4 May 2015 09:16:12 +0000 (11:16 +0200)]
[TASK] Improve .htaccess files

Improve the example .htaccess file by adding rules for caching,
MIME types and CORS. Also, the rewrite rules are extended to block
access to certain files and folders.

Additionally all rules are made compatible for Apache 2.4 as well.

Resolves: #23078
Resolves: #66235
Releases: master, 6.2
Change-Id: I629f524b5a209769601f04a74bb7434736058ab8
Reviewed-on: http://review.typo3.org/39254
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Use single quotes in query for values in EXT:workspaces 48/40748/4
Andreas Fernandez [Tue, 30 Jun 2015 08:03:21 +0000 (10:03 +0200)]
[BUGFIX] Use single quotes in query for values in EXT:workspaces

Use single quotes for values in the query executed in
WorkspaceService::isOldStyleWorkspaceUsed().

In ANSI SQL, single quotes have to be used for values.

Resolves: #67835
Releases: master, 6.2
Change-Id: I5bf598d9acdbc7d2db6d5b8b6f1a4c668fe13ccb
Reviewed-on: http://review.typo3.org/40748
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Duplicate XLIFF identifiers 85/40785/2
Xavier Perseguers [Wed, 1 Jul 2015 09:27:23 +0000 (11:27 +0200)]
[BUGFIX] Duplicate XLIFF identifiers

Change-Id: I691706710f9bfe3294c59010fa0fd3fdb21f6a3e
Releases: master, 6.2
Resolves: #67867
Reviewed-on: http://review.typo3.org/40785
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Skip dependency check for extensions 75/40775/2
Nicole Cordes [Tue, 30 Jun 2015 17:44:58 +0000 (19:44 +0200)]
[BUGFIX] Skip dependency check for extensions

If an incompatible extension is trying to be installed, a popup opens
with the possibility to skip dependency checks and retry the
installation. Currently the skipping is only implemented for system
checks (TYPO3 and PHP versions). This patch adds the missing skip method
during extension dependency resolving.

Resolves: #67863
Releases: master
Change-Id: Idbd4bc649a83a8e8a98652ffb8bd8081a7c65192
Reviewed-on: http://review.typo3.org/40775
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Florian Weiss <typo3org@leblanc.at>
Tested-by: Florian Weiss <typo3org@leblanc.at>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] dbal: return field type information from admin_get_fields() 41/39941/9
Morton Jonuschat [Wed, 3 Jun 2015 22:31:19 +0000 (00:31 +0200)]
[BUGFIX] dbal: return field type information from admin_get_fields()

Deprecate MetaType() which always returned an empty meta fieldtype
with DBAL and move function to getMetadata(). The signature for
getMetadata() includes the field information for the query so that
the cached field metatype can be used before resorting to querying
the DBMS.

Resolves: #67288
Releases: master
Change-Id: I57dbd7501c9e7a62f2164fb755f1d1a73da01a05
Reviewed-on: http://review.typo3.org/39941
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[CLEANUP] Replace count with empty in EXT:core 86/40686/5
Andreas Fernandez [Sat, 27 Jun 2015 12:18:11 +0000 (14:18 +0200)]
[CLEANUP] Replace count with empty in EXT:core

Replace occurences of count() with matching empty() pendants.

Resolves: #67778
Releases: master
Change-Id: I16c0299db8afda4c0fe406f7465a41d5eee3dd88
Reviewed-on: http://review.typo3.org/40686
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Cleanup IndexedSearchRepository 68/40768/3
Frederic Gaus [Tue, 30 Jun 2015 13:48:27 +0000 (15:48 +0200)]
[TASK] Cleanup IndexedSearchRepository

Cleanup \TYPO3\CMS\IndexedSearch\Domain\Repository\IndexSearchRepository

Resolves: #67857
Releases: master
Change-Id: I696b996d0f517a87deec7ba54cff46be5f069571
Reviewed-on: http://review.typo3.org/40768
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] 1st level cache for ``QueryResult::count()`` 50/40750/4
Mathias Brodala [Tue, 30 Jun 2015 08:17:23 +0000 (10:17 +0200)]
[BUGFIX] 1st level cache for ``QueryResult::count()``

Counting the results of the ``QueryResultInterface`` proxy returned by
Repository finder methods always executed a ``COUNT query`` even if
the results had been fetched or counted already.

With this patch the number of results is cached as soon as the result
is initialized and/or counted once.

Resolves: #67837
Releases: master, 6.2
Change-Id: I98f680372b845f992ad3d436647b0cf5e460b606
Reviewed-on: http://review.typo3.org/40750
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Remove deprecated language labels 63/40763/2
Wouter Wolters [Tue, 30 Jun 2015 09:54:42 +0000 (11:54 +0200)]
[TASK] Remove deprecated language labels

Resolves: #67847
Releases: master
Change-Id: Ia76a7166a7da9b1663acd8cd40edb6fe040f0f67
Reviewed-on: http://review.typo3.org/40763
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Cleanup EXT:taskcenter 69/40769/3
Frederic Gaus [Tue, 30 Jun 2015 14:35:24 +0000 (16:35 +0200)]
[TASK] Cleanup EXT:taskcenter

Resolves: #67861
Releases: master
Change-Id: I18531f6ef4d9541e9ef1163c3b4703f6b37bc84c
Reviewed-on: http://review.typo3.org/40769
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove obsolete require statements from ErrorHandler 59/40759/2
Benjamin Mack [Tue, 30 Jun 2015 09:26:38 +0000 (11:26 +0200)]
[TASK] Remove obsolete require statements from ErrorHandler

As the autoloader is now always present through the bootstrap
and Composer class loader, the fallback of manually
requiring classes can be removed.

Resolves: #36061
Releases: master
Change-Id: I299232630a0390688bd683b64e5d31c422baa444
Reviewed-on: http://review.typo3.org/40759
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Locallang file is not an XLIFF file in ext:extensionmanager 64/40764/5
Wouter Wolters [Tue, 30 Jun 2015 09:59:05 +0000 (11:59 +0200)]
[BUGFIX] Locallang file is not an XLIFF file in ext:extensionmanager

Resolves: #67849
Releases: master
Change-Id: I9b532c45322bad3e9d776326a3d9aa9257325175
Reviewed-on: http://review.typo3.org/40764
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Introduce "Application" classes for all entry points 93/40493/14
Benjamin Mack [Sat, 20 Jun 2015 16:26:25 +0000 (18:26 +0200)]
[FEATURE] Introduce "Application" classes for all entry points

In an effort to move away from TYPO3_MODE and global code
an instance that acts as an entry point has been introduced. The
Application class which serves as a wrapper for setting up the
Bootstrap and calling the request has been introduced.

Additionally, new Applications (like typo3_console) can benefit
from the flexible way of registering RequestHandlers on their own
while still using the bootstrap or only parts of it.

Resolves: #67808
Releases: master
Change-Id: I20c92d0bc8df5d50d76922a8dfe1cbd898e6f1dd
Reviewed-on: http://review.typo3.org/40493
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] SYS_LASTCHANGED is only updated if page is viewed in live or no 59/40259/4
Romain L [Mon, 15 Jun 2015 16:29:34 +0000 (18:29 +0200)]
[BUGFIX] SYS_LASTCHANGED is only updated if page is viewed in live or no
workspace

The SYS_LASTCHANGED field was updated whenever which workspace was loaded,
leading to SYS_LASTCHANGED being updated while no content was
published yet.
This patch changes this behavior by updating SYS_LASTCHANGED only if
page is viewed from the live workspace or no workspace at all.

Resolves: #42158
Releases: master
Change-Id: I09aca547a7b22ba1699f521ea7609053991fed4c
Reviewed-on: http://review.typo3.org/40259
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[CLEANUP] Replace count with empty in EXT:frontend 91/40691/3
Andreas Fernandez [Sat, 27 Jun 2015 15:13:48 +0000 (17:13 +0200)]
[CLEANUP] Replace count with empty in EXT:frontend

Resolves: #67784
Releases: master
Change-Id: I65b01b82692a981eee1c0d3cc6d6d161f9d80daf
Reviewed-on: http://review.typo3.org/40691
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] hmenu.special = list must evaluate showAccessRestrictedPages 15/40315/5
Gilles FOUET [Tue, 16 Jun 2015 15:59:28 +0000 (17:59 +0200)]
[BUGFIX] hmenu.special = list must evaluate showAccessRestrictedPages

For menus of type "list" the option showAccessRestrictedPages is now
taken into account as well and the enableFields omit the fe_group
contraint if the option is set.

Resolves: #16840
Releases: master, 6.2
Change-Id: I4203bf0087367781ecee15fe3aa42deea8d34039
Reviewed-on: http://review.typo3.org/40315
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Fix SQL error in IndexSearchRepository 60/40760/2
Wouter Wolters [Tue, 30 Jun 2015 09:27:28 +0000 (11:27 +0200)]
[FOLLOWUP][BUGFIX] Fix SQL error in IndexSearchRepository

Add a missing "AND" concatenation to fix a SQL error.

Resolves: #67834
Releases: master
Change-Id: Ide173f13d9142b05db625648bf1ce995749ff233
Reviewed-on: http://review.typo3.org/40760
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[!!!][FEATURE] Allow individual content caching 15/35915/15
Philipp Gampe [Fri, 9 Jan 2015 03:55:56 +0000 (04:55 +0100)]
[!!!][FEATURE] Allow individual content caching

Since TYPO3 4.7 'stdWrap.cache' is available. This stores the rendered
string into the cache_hash via the caching framework and retrieves it
on successive renderings.
However stdWrap kicks in too late for many cObjects, e.g. COA.

Moving the 'cache.' logic into the central render method avoids the
rendering of the cObject, thus gaining a major speed improvement if
a cache entry already exists for a cObject.

Custom cObjects and USER objects utilizing the 'cache.' property need
adoption.

This change allows to make effective use of page section caching to
share the same generated HTML across many pages without regeneration.
It provides the same power as Magento block caching.

Additionally the properties key, lifetime and tags get stdWrap support.

Resolves: #64200
Releases: master
Change-Id: Ic0776082e09c70e03a9b432b41207031b4f2efa6
Reviewed-on: http://review.typo3.org/35915
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[TASK] Change misleading texts to "lowlevel" modules 51/40751/3
Benjamin Mack [Tue, 30 Jun 2015 08:29:23 +0000 (10:29 +0200)]
[TASK] Change misleading texts to "lowlevel" modules

Resolves: #18486
Releases: master
Change-Id: Iba2514001570428e50eb55a75cee793ff7a409fb
Reviewed-on: http://review.typo3.org/40751
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Fix SQL error in IndexSearchRepository 49/40749/2
Tim Schreiner [Tue, 30 Jun 2015 08:11:19 +0000 (10:11 +0200)]
[BUGFIX] Fix SQL error in IndexSearchRepository

Add a missing "AND" concatenation to fix a SQL error.

Resolves: #67834
Releases: master, 6.2
Change-Id: I557ee19754462200a6baf52fd5b590c9b21eb21c
Reviewed-on: http://review.typo3.org/40749
Reviewed-by: David Greiner <hallo@davidgreiner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] Introduce TCA > ctrl > descriptionColumn 49/40449/3
Felix Kopp [Thu, 18 Jun 2015 13:33:44 +0000 (15:33 +0200)]
[FEATURE] Introduce TCA > ctrl > descriptionColumn

Introduce annotation for table column fields "descriptionColumn". Is
added in TCA > ctrl for tables. Optional setting. Defined table column
that holds description / guidance for editors and admins within backend.

Description should only displayed in the backend.

Adds descriptionColumn to records that already hold internal description.
This patch does not add new description table columns.

Resolves: #67603
Related: #67550
Related: #67578
Releases: master
Change-Id: Ib081e5f14b9cbbcabbbad0d45a7a90274cd3dc09
Reviewed-on: http://review.typo3.org/40449
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] AddController: RemoveXSS on REQUEST_URI 80/20680/5
Laurent Cherpit [Mon, 29 Jun 2015 22:06:59 +0000 (00:06 +0200)]
[BUGFIX] AddController: RemoveXSS on REQUEST_URI

sanitizeLocalUrl() fails to compare returnUrl value if the TCA column of a
field type "select" contains configuration keys like "itemListStyle" or
"selectedListStyle".
In "AddController", using RemoveXSS on request_uri before assigning the
returnUrl parameter, the comparaison of the params of returnUrl will
match on the backlink generation used to close the editForm.

If returnUrl contains string with "style" in it, it will be processed in
the same manner by sanitizeLocalUrl. So the backlink of the editForm
will not be dummy.php.

Change-Id: I5f3282766fe6cf9cae24f70d7f979ce4be004d5f
Resolves: #48096
Releases: master
Reviewed-on: http://review.typo3.org/20680
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Namespace prefix t3 for id on file is not defined 24/40724/5
Xavier Perseguers [Mon, 29 Jun 2015 15:11:32 +0000 (17:11 +0200)]
[BUGFIX] Namespace prefix t3 for id on file is not defined

Change-Id: If9cf05b0d6d98a6aa3e07dc50ab8c96750183613
Resolves: #67814
Releases: master
Reviewed-on: http://review.typo3.org/40724
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[FEATURE] Add description-field for backend-users 79/40379/4
Felix Kopp [Wed, 17 Jun 2015 17:56:43 +0000 (19:56 +0200)]
[FEATURE] Add description-field for backend-users

With the new field it is possible to give a short description
about a user.

Change-Id: I5ffbc0112d1f12099ccd544ceda600367ce51611
Resolves: #67578
Releases: master
Reviewed-on: http://review.typo3.org/40379
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Loosen type check of Redis identifiers and tags 91/23191/8
Thorsten Kahler [Mon, 19 Aug 2013 17:57:27 +0000 (19:57 +0200)]
[BUGFIX] Loosen type check of Redis identifiers and tags

RedisBackend denies identifiers and tags allowed in all other
implementations of caching backends. This change allows all identifiers
and tags which can be casted to string.
Specifically it adds a check for objects having a __toString method.

Change-Id: Id5cc372f6a00c68d9e44a1eb8bb38c8a3679f2a7
Resolves: #51031
Releases: master
Reviewed-on: http://review.typo3.org/23191
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Add functional test for exclude field mixup in FormEngine 26/20026/9
Alexander Stehlik [Mon, 15 Jun 2015 19:50:15 +0000 (21:50 +0200)]
[TASK] Add functional test for exclude field mixup in FormEngine

This patch introduces a functional test that makes sure that the
exclude field mechanism works correctly with inline elements.

Since the problem was already solved by the FormEngine rewrite
no functional changes are made.

The actual bugfix will be added in the TYPO3 6.2 backport.

Resolves: #47359
Releases: master, 6.2
Change-Id: I5a7a2de16d767f854b4d3f89d599deec28266092
Reviewed-on: http://review.typo3.org/20026
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[CLEANUP] Replace count with empty in EXT:impexp 92/40692/2
Andreas Fernandez [Sat, 27 Jun 2015 15:24:22 +0000 (17:24 +0200)]
[CLEANUP] Replace count with empty in EXT:impexp

Resolves: #67785
Releases: master
Change-Id: I488a505fa811b76e216a3397bf4f1458d4f098df
Reviewed-on: http://review.typo3.org/40692
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] Replace count with empty in EXT:extensionmanager 89/40689/2
Andreas Fernandez [Sat, 27 Jun 2015 13:57:56 +0000 (15:57 +0200)]
[CLEANUP] Replace count with empty in EXT:extensionmanager

Replace occurences of count() with matching empty() pendants.

Resolves: #67781
Releases: master
Change-Id: I4279ab12911ff7aa82c42e5a8bc2875c6e41f299
Reviewed-on: http://review.typo3.org/40689
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][TASK] Remove typo3/ext/README.txt and typo3/sysext/README.txt 33/40733/2
Christian Kuhn [Mon, 29 Jun 2015 21:10:29 +0000 (23:10 +0200)]
[!!!][TASK] Remove typo3/ext/README.txt and typo3/sysext/README.txt

The two README.txt files within typo3/ext and typo3/sysext do
not provide crucial information that can't be found elsewhere
and are dropped now.

As a side effect, typo3/ext folder does no longer exist
with new packages - the "global" system functionality is kept.
A .rst file hints about this missing folder.

Resolves: #67824
Releases: master
Change-Id: Idc3c408f135a8be3ee2db43e4835a1c6b39436da
Reviewed-on: http://review.typo3.org/40733
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Move typo3 logo icons into EXT:backend 35/40735/3
Benjamin Mack [Mon, 29 Jun 2015 21:30:58 +0000 (23:30 +0200)]
[TASK] Move typo3 logo icons into EXT:backend

The typo3 logos used in various places of the backend
including the default favicon are now moved
to EXT:backend.

Resolves: #67826
Releases: master
Change-Id: Id3c01679aab1410a6e48020df57c451dd601c24c
Reviewed-on: http://review.typo3.org/40735
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove colorpicker icons from typo3/gfx/ 34/40734/4
Wouter Wolters [Mon, 29 Jun 2015 21:13:08 +0000 (23:13 +0200)]
[TASK] Remove colorpicker icons from typo3/gfx/

This patch also removes TCA options "dim" and "tableStyle".

Resolves: #67825
Releases: master
Change-Id: I3812d791269e2fee69fce0f7c5ea2b579eeb8c1d
Reviewed-on: http://review.typo3.org/40734
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Remove unused refresh/edit/required icons from gfx/ 32/40732/2
Benjamin Mack [Mon, 29 Jun 2015 20:58:36 +0000 (22:58 +0200)]
[TASK] Remove unused refresh/edit/required icons from gfx/

Releases: master
Resolves: #67823
Change-Id: I819844c20d1bac0070a66e6bfaf91ba9e72cb4cd
Reviewed-on: http://review.typo3.org/40732
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Refactoring of the QueryGenerator Interface Part 2 94/40694/8
Frank Nägler [Sat, 27 Jun 2015 15:43:37 +0000 (17:43 +0200)]
[TASK] Refactoring of the QueryGenerator Interface Part 2

Next step of QueryGenerator Refactoring.

Main goals:
- Remove all inline JavaScript
- Remove usage of TBE_EDITOR
- Introduce QueryGenerator AMD module
- Improve HTML output
- Improve styling
- Use htmlspecialchars for all output

Resolves: #67790
Releases: master
Change-Id: I0a4f6ecf52e226f49f434ad8d472a969cb3b160b
Reviewed-on: http://review.typo3.org/40694
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Remove non-CGL-compliant switch clause in EXT:setup 31/40731/3
Benjamin Mack [Mon, 29 Jun 2015 20:06:43 +0000 (22:06 +0200)]
[TASK] Remove non-CGL-compliant switch clause in EXT:setup

Resolves: #67821
Releases: master
Change-Id: I70b1434d1350883ab55d39703af3b3ec4d32d7de
Reviewed-on: http://review.typo3.org/40731
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FOLLOWUP][FEATURE] Extract dependency ordering out of DependencyResolver 29/40729/2
Benjamin Mack [Mon, 29 Jun 2015 17:06:49 +0000 (19:06 +0200)]
[FOLLOWUP][FEATURE] Extract dependency ordering out of DependencyResolver

The dependency order resolver needs to be injected at runtime.

Resolves: #67293
Releases: master
Change-Id: Id7f2b65b0258e22081d326f06d3d13f874bea1ff
Reviewed-on: http://review.typo3.org/40729
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Allow quotes in titles of typolink 62/40162/12
Markus Klein [Wed, 10 Jun 2015 22:59:34 +0000 (00:59 +0200)]
[!!!][TASK] Allow quotes in titles of typolink

Introduce proper handling of quotes in titles of typolinks.

Example title: 'Here "I\\" am'
Expected link field value: '15 - - "Here \"I\\\\\" am"'

Do not use the GeneralUtility::unQuoteFilenames() method anymore, since
it was not made for the purpose to decode CSV-like strings.
Use the newly introduced TypoLinkCodecService instead.

Resolves: #55759
Releases: master
Change-Id: Iea612842b4b9c70924ecf56b87513350dd9383a8
Reviewed-on: http://review.typo3.org/40162
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Remove tceforms.js because we don't need it anymore 26/40726/2
Frank Nägler [Mon, 29 Jun 2015 16:31:17 +0000 (18:31 +0200)]
[!!!][TASK] Remove tceforms.js because we don't need it anymore

The IE code for ValueSlider is not needed anymore, also the QuickTips not
used within FormEngine.

Resolves: #67815
Releases: master
Change-Id: I9919dc1350271281ece6aa8767fb8c375205e906
Reviewed-on: http://review.typo3.org/40726
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Cleanup ContentContentObject 19/40719/4
Frederic Gaus [Mon, 29 Jun 2015 13:02:53 +0000 (15:02 +0200)]
[TASK] Cleanup ContentContentObject

Minor cleanup of \TYPO3\CMS\Frontend\ContentObject\ContentContentObject

Resolves: #67809
Releases: master
Change-Id: I34ad1bba9497fbc61cd4d117ca7bbb287d6f54ea
Reviewed-on: http://review.typo3.org/40719
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[TASK] Change naming in context preset in Install Tool 30/40730/3
Benjamin Mack [Mon, 29 Jun 2015 19:13:55 +0000 (21:13 +0200)]
[TASK] Change naming in context preset in Install Tool

Due to the similar naming logic, the preset for configuring optimal
debugging output conflicts with the ApplicationContext set as an
environment variable (TYPO3_CONTEXT), is changed from
"Production" and "Development" to "Live" and "Debug".

Resolves: #67820
Releases: master
Change-Id: I01f0db39532222a8cbeb3a45a745ce6fd977e137
Reviewed-on: http://review.typo3.org/40730
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Improve requireJS handling for FormEngine 21/40721/4
Frank Nägler [Mon, 29 Jun 2015 13:46:43 +0000 (15:46 +0200)]
[TASK] Improve requireJS handling for FormEngine

Resolves: #67812
Releases: master
Change-Id: Ie7d8826ae56b5054114a58db13bd413c63d58940
Reviewed-on: http://review.typo3.org/40721
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Move form field wizard icons 60/40660/5
Wouter Wolters [Thu, 25 Jun 2015 22:30:11 +0000 (00:30 +0200)]
[TASK] Move form field wizard icons

Migrate TCA and FlexForm with the TCA migration during bootstrap.

Resolves: #67793
Releases: master
Change-Id: I1cfa4196603832d6fb1d91a58ac12d05d48562a8
Reviewed-on: http://review.typo3.org/40660
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Correction of Filelink of FAL in linkvalidator 64/39464/4
Pierre Boivin [Mon, 11 May 2015 20:00:10 +0000 (16:00 -0400)]
[BUGFIX] Correction of Filelink of FAL in linkvalidator

Add a fetchType function for linkvalidator to take
FileLinktype class for "file:XXX" media instead of internalLink class.

Make a first validation with "retrieveFileOrFolderObject" to
check if file exist in a database.

Make a second validation on the file "physically" on the server.

Resolves: #66895
Releases: master, 6.2
Change-Id: Ife0ab588e0ac4eb932cca3d6545f243bbcddc7ae
Reviewed-on: http://review.typo3.org/39464
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
4 years ago[!!!][TASK] RTE: locallang inferno 02/40702/12
Christian Kuhn [Sat, 27 Jun 2015 21:28:59 +0000 (23:28 +0200)]
[!!!][TASK] RTE: locallang inferno

The patch resolves quite some mess in ext:rtehtmlarea
around the localization files. Many files are moved around
and some are deleted (ok with localization team). Some
internal methods are adapted a bit.

Change-Id: I23bfd10cfc4920e4361c7df971251741e04d2f29
Resolves: #67811
Releases: master
Reviewed-on: http://review.typo3.org/40702
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Invalid XLIFF attribute xml:space="preserver" 23/40723/3
Xavier Perseguers [Mon, 29 Jun 2015 14:57:18 +0000 (16:57 +0200)]
[BUGFIX] Invalid XLIFF attribute xml:space="preserver"

XLIFF does not validate since xml:space must be
either "default" or "preserve".
This attribute is dropped altogether since it is useless.

Change-Id: I075eabfd95359aa4d00ca5b1655399211648042d
Resolves: #67813
Releases: master
Reviewed-on: http://review.typo3.org/40723
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Extract dependency ordering out of DependencyResolver 55/39955/13
Markus Klein [Thu, 4 Jun 2015 20:34:33 +0000 (22:34 +0200)]
[FEATURE] Extract dependency ordering out of DependencyResolver

The DependencyOrderingService allows to resolve dependency lists
containing before/after dependency specifications into an ordered
list. This is useful for all sorts of registration APIs like hooks.

The code is extracted from the existing DependencyResolver for packages.
The DependencyResolver is adjusted to use the DepencyOrderingService.

Resolves: #67293
Releases: master
Change-Id: Ic4cb1c7cfbcc8c4a0ebe2946eb5824d7983e711c
Reviewed-on: http://review.typo3.org/39955
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Only count items in ForViewHelper when ``iteration`` argument is set 11/40711/3
Mathias Brodala [Mon, 29 Jun 2015 07:49:48 +0000 (09:49 +0200)]
[BUGFIX] Only count items in ForViewHelper when ``iteration`` argument is set

When using the ``iteration`` argument, the ``ForViewHelper`` provides
information about the current iteration, including the ``cycle`` and
``total``. Therefore it needs to count all elements.
The problem is, that this happens even if the iteration argument is
not specified leading to performance issues especially when iterating
over a (subset of a) lot of (remote) items.

This patch fixes this by adding a check for the ``iteration`` argument.

Resolves: #67801
Releases: master, 6.2
Change-Id: I4645ed03322bea36f2c36263378900f401626f24
Reviewed-on: http://review.typo3.org/40711
Reviewed-by: David Greiner <hallo@davidgreiner.de>
Tested-by: David Greiner <hallo@davidgreiner.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[!!!][TASK] Indexed Search: Remove class aliases 19/40119/4
Markus Klein [Mon, 8 Jun 2015 22:02:31 +0000 (00:02 +0200)]
[!!!][TASK] Indexed Search: Remove class aliases

Resolves: #67792
Releases: master
Change-Id: I83a5d93645af8e1bd0a1b6397587c134cca332b0
Reviewed-on: http://review.typo3.org/40119
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Remove --div-- without associated label 17/40717/3
David Greiner [Mon, 29 Jun 2015 12:14:33 +0000 (14:14 +0200)]
[BUGFIX] Remove --div-- without associated label

Due to a --div-- without a associated label brakes the backend while
adding a new sys_action of type "SQL-Query", this patch removes this
double existent --div-- from sys_action's tca configuration.

Change-Id: I58085a32cc167e3f985e0ed04bdf66457d72260d
Resolves: #67805
Releases: master
Reviewed-on: http://review.typo3.org/40717
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Install "parallel" as addon in Travis CI 06/40706/3
Mathias Brodala [Mon, 29 Jun 2015 07:15:12 +0000 (09:15 +0200)]
[TASK] Install "parallel" as addon in Travis CI

Resolves: #67799
Releases: master
Change-Id: Ie3ca1f54c08dbd7a17f63018f1112949addc2dc1
Reviewed-on: http://review.typo3.org/40706
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Update Configuration for excludeForPackaging 04/40704/6
Benjamin Mack [Sun, 28 Jun 2015 11:05:08 +0000 (13:05 +0200)]
[TASK] Update Configuration for excludeForPackaging

Also exclude .swp files.

Resolves: #67772
Releases: master
Change-Id: I54377634717572144047bde96f0ee9a9dc679957
Reviewed-on: http://review.typo3.org/40704
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] Removing an element from select field must trigger validation 12/40712/3
Frank Nägler [Mon, 29 Jun 2015 08:05:52 +0000 (10:05 +0200)]
[FOLLOWUP][BUGFIX] Removing an element from select field must trigger validation

Fix typo in typeof comparison.

Resolves: #67791
Releases: master
Change-Id: If6ad561f87c7071591c3504ee93c6c1027b290a6
Reviewed-on: http://review.typo3.org/40712
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[BUGFIX] Removing an element from select field must trigger validation 01/40701/3
Frank Nägler [Sat, 27 Jun 2015 20:46:00 +0000 (22:46 +0200)]
[BUGFIX] Removing an element from select field must trigger validation

This patch ensures that re-validation is triggered in case
an element is removed from a select field.

Resolves: #67791
Releases: master
Change-Id: I8b2b6e67216ba9410a3a404fe697064748cd5871
Reviewed-on: http://review.typo3.org/40701
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Fix wrong validation of select fields in backend 03/40703/2
Frank Nägler [Sun, 28 Jun 2015 19:30:21 +0000 (21:30 +0200)]
[BUGFIX] Fix wrong validation of select fields in backend

This patch fix a wrong validation of select fields in backend.
Also some small performance imrpovements.

Resolves: #67794
Releases: master
Change-Id: Ic4a6335999f24ffcd112f255431c769b806d3014
Reviewed-on: http://review.typo3.org/40703
Reviewed-by: René Bigler <raziel@dunkelweiss.li>
Tested-by: René Bigler <raziel@dunkelweiss.li>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Remove AbstractToolbarItem class 98/40698/3
Anja Leichsenring [Sat, 27 Jun 2015 19:21:04 +0000 (21:21 +0200)]
[TASK] Remove AbstractToolbarItem class

The Abstract is only implemented by one single class, so it is pretty useless.
The functionality is moved to the actual class, and the Abstract is removed.

Change-Id: I61e5d2cabd7458c7963d3223e7ed11d49a3f1f41
Releases: master
Resolves: #67788
Reviewed-on: http://review.typo3.org/40698
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: David Greiner <hallo@davidgreiner.de>
Tested-by: David Greiner <hallo@davidgreiner.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Register ToolbarItems with timestamps 00/40700/2
Anja Leichsenring [Sat, 27 Jun 2015 19:28:13 +0000 (21:28 +0200)]
[TASK] Register ToolbarItems with timestamps

In order to ensure unique registration of ToolbarItems,
a unique timestamp is used for each item to register with.

Change-Id: I4ba901c2c7fc80dd531c29e4c444ecc16b6b6826
Resolves: #67789
Releases: master
Reviewed-on: http://review.typo3.org/40700
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Make Exception message more helpful 97/40697/3
Anja Leichsenring [Sat, 27 Jun 2015 16:40:13 +0000 (18:40 +0200)]
[TASK] Make Exception message more helpful

Let the missing hookobject tell, what class it is, in order to
find the place where the interface might be missing.

Change-Id: I5a654384005b74e1256ab2019e936c7da7a76ab6
Resolves: #67787
Releases: master
Reviewed-on: http://review.typo3.org/40697
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Replace count with empty in EXT:filelist 90/40690/2
Andreas Fernandez [Sat, 27 Jun 2015 14:59:29 +0000 (16:59 +0200)]
[CLEANUP] Replace count with empty in EXT:filelist

Resolves: #67783
Releases: master
Change-Id: If374d781e4e808291dd99b92dfaffd8653862ec3
Reviewed-on: http://review.typo3.org/40690
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Add TypoLinkCodec 73/40673/6
Markus Klein [Fri, 26 Jun 2015 12:00:04 +0000 (14:00 +0200)]
[FEATURE] Add TypoLinkCodec

The class allows to encode or decode TypoLink strings.

Resolves: #67765
Releases: master
Change-Id: Ibe103ee5c60e411e4d9d965c3623d80f20cc6435
Reviewed-on: http://review.typo3.org/40673
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[CLEANUP] Replace count with empty in EXT:documentation 88/40688/3
Andreas Fernandez [Sat, 27 Jun 2015 13:53:01 +0000 (15:53 +0200)]
[CLEANUP] Replace count with empty in EXT:documentation

Replace occurences of count() with matching empty() pendants.

Resolves: #67780
Releases: master
Change-Id: I5239a038aeeaf47d656f3767ce56db61901a69e6
Reviewed-on: http://review.typo3.org/40688
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Travis: Add github oauth token 87/40687/2
Christian Kuhn [Sat, 27 Jun 2015 13:21:33 +0000 (15:21 +0200)]
[TASK] Travis: Add github oauth token

Resolves: #67779
Releases: master
Change-Id: I8b5b249fa40e4d162bcf2dee7ef7cae28f6d5bd8
Reviewed-on: http://review.typo3.org/40687
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Refactoring of the QueryGenerator Interface 56/40656/12
Frank Nägler [Thu, 25 Jun 2015 20:34:55 +0000 (22:34 +0200)]
[TASK] Refactoring of the QueryGenerator Interface

Main goals of this patch:
- introduce bootstrap markup
- remove usage of all gfx icons (IconUtility)
- better usability
- better readable of the code

Some more changes will follow with other patches.

Resolves: #67769
Releaes: master
Change-Id: If29908afe0942f70dc7361ad74e97b7b1f6e3b33
Reviewed-on: http://review.typo3.org/40656
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Switch travis-ci to container based builds 82/40682/4
Christian Kuhn [Sat, 27 Jun 2015 11:21:14 +0000 (13:21 +0200)]
[TASK] Switch travis-ci to container based builds

Resolves: #67775
Releases: master
Change-Id: I30522630218f2dd8c87ec607fd2bbed5efe3f3ad
Reviewed-on: http://review.typo3.org/40682
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Travis fail form/RemovexssFilter not found 81/40681/2
Christian Kuhn [Sat, 27 Jun 2015 10:28:27 +0000 (12:28 +0200)]
[TASK] Travis fail form/RemovexssFilter not found

This is an intermediate fix to make travis find
form/RemovexssFilter and others again.

Change-Id: I17911ad8379c83e14f096df3ddd65521669d5653
Releases: master, 7.3
Resolves: #67773
Related: #67767
Reviewed-on: http://review.typo3.org/40681
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[BUGFIX] Fix wrong variable spelling in RteHtmlParser 78/40678/3
Markus Klein [Fri, 26 Jun 2015 16:15:23 +0000 (18:15 +0200)]
[BUGFIX] Fix wrong variable spelling in RteHtmlParser

Resolves: #67770
Releases: master, 6.2
Change-Id: Ie9682bd3f4b471f65b1717fb98293b1f129d2ca5
Reviewed-on: http://review.typo3.org/40678
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Refactor formengine required handling 02/39302/22
Frank Nägler [Sun, 3 May 2015 11:48:19 +0000 (13:48 +0200)]
[TASK] Refactor formengine required handling

This patch removes the required images and adds CSS based styling
for required fields and minitems/maxitems validation.

Resolves: #67354
Releases: master
Change-Id: I5dbccb1c84035fa21079b09748c767bc4f3d06d0
Reviewed-on: http://review.typo3.org/39302
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[TASK] Include autoload info of all core extensions 74/40674/2
Helmut Hummel [Fri, 26 Jun 2015 12:36:36 +0000 (14:36 +0200)]
[TASK] Include autoload info of all core extensions

Previously classes for extensions that were not loaded,
were also not autoloadable. To simplify composer installation
of the core, we now include autoload information of all extensions
that are delivered with the typo3/cms package.

By doing so, authors of distribution composer.json files
do not need to amend it with class loading information of
core extensions any more.

This means that class loading information for every
system extension will be written to typo3/contrib/vendor
by the packaging script, so that we do not need to respect
these when building additional autoload information for extensions
that are installed via the extension manager in a non composer
managed environment.

Releases: master, 7.3
Resolves: #67767
Change-Id: I1b68ebff29fc5392a0d874a17b9caa3dd4483096
Reviewed-on: http://review.typo3.org/40674
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Daniel Goerz <ervaude@web.de>
Tested-by: Daniel Goerz <ervaude@web.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
4 years ago[BUGFIX] Make save query possible again 68/40668/3
Frank Nägler [Fri, 26 Jun 2015 10:08:57 +0000 (12:08 +0200)]
[BUGFIX] Make save query possible again

Resolves: #67762
Related: #64137
Releases: master
Change-Id: I06c1f22c0bb1c63aeb3d87e7e8748be8a60ae69c
Reviewed-on: http://review.typo3.org/40668
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Drop "Show field descriptions" in quick edit 58/40658/2
Christian Kuhn [Thu, 25 Jun 2015 21:03:37 +0000 (23:03 +0200)]
[TASK] Drop "Show field descriptions" in quick edit

Page module in "quick edit" mode shows a happy little
checkbox at the bottom "Show field descriptions".
This doesn't do anything for quite some time already
and is dropped now. Poor checkbox ;)

Change-Id: Ia24f944d924bee5f2abec773b67652595010a7b6
Resolves: #67759
Releases: master
Reviewed-on: http://review.typo3.org/40658
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[FEATURE] Emit Signal when an IndexRecord is marked as missing 77/39877/4
c_reiter [Tue, 2 Jun 2015 09:00:10 +0000 (11:00 +0200)]
[FEATURE] Emit Signal when an IndexRecord is marked as missing

Introduce a new signal that is emitted when the FAL indexer encounters
a sys_file record which does not have a corresponding filesystem entry
and marks it as missing.

Releases: master
Resolves: #67228
Change-Id: I8419e0919cb9019160782b9de58f3db3fc32352a
Reviewed-on: http://review.typo3.org/39877
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[BUGFIX] Increase lifetime of cache_rootline 59/40659/2
Christian Kuhn [Thu, 25 Jun 2015 21:45:56 +0000 (23:45 +0200)]
[BUGFIX] Increase lifetime of cache_rootline

The default lifetime of frontend related rootline cache is
only one hour, raising query load in production. This is
raised to 30 days now - same as cache_pagesection.
The rootline cache entries are tagged with pageId_* and
in cache group "pages", so the DataHandler automatically
drops those entries if pages are moved around or change.

Resolves: #50231
Releases: master, 6.2
Change-Id: I3839982058f8b78726c050d5a7da90c0f2588102
Reviewed-on: http://review.typo3.org/40659
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Remove reference to removed image in ext:sys_action 57/40657/2
Wouter Wolters [Thu, 25 Jun 2015 21:00:31 +0000 (23:00 +0200)]
[TASK] Remove reference to removed image in ext:sys_action

This image has been removed already in TYPO3 CMS 4.4

Resolves: #67758
Releases: master
Change-Id: I249dd3dc01b14404019d67d4de6888e9354701ec
Reviewed-on: http://review.typo3.org/40657
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[FOLLOWUP][TASK] Streamline pages table in PageRepository 65/40665/2
Benjamin Mack [Fri, 26 Jun 2015 07:55:36 +0000 (09:55 +0200)]
[FOLLOWUP][TASK] Streamline pages table in PageRepository

Fix unit tests which require a valid TCA for pages now (as no
bootstrapping is done in Tests, also one test was failing before
as the expected SQL was negated.

Resolves: #65786
Releases: master
Change-Id: I93237f18cee42f86e2a7325cc859f2217bcf99ff
Reviewed-on: http://review.typo3.org/40665
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Streamline pages table in PageRepository 02/37902/5
Benjamin Mack [Tue, 17 Mar 2015 11:35:02 +0000 (12:35 +0100)]
[TASK] Streamline pages table in PageRepository

Since TYPO3 CMS 6, the TCA is always fully loaded
when using the PageRepository in the Frontend.

This way a lot of hard-coded built-in logic for having
the special handling of the "pages" table is not needed
anymore.

Resolves: #65786
Releases: master
Change-Id: I73c0b9f603d16848afb261c189ac16433353955e
Reviewed-on: http://review.typo3.org/37902
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] IRRE: close open records correctly when expandSingle is set 52/40552/5
Andreas Allacher [Tue, 23 Jun 2015 10:46:44 +0000 (12:46 +0200)]
[BUGFIX] IRRE: close open records correctly when expandSingle is set

inline records are now closed correctly when using expandSingle.
Prior to this commit if a record was opened,
all open records remained open instead of being closed

Resolves: #67691
Releases: master
Change-Id: I5e815824181be17622558c55c452d4a1dac5c339
Reviewed-on: http://review.typo3.org/40552
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] dbal: Ignore MySQL UNSIGNED/ZEROFILL in database schema compare 37/40137/3
Morton Jonuschat [Tue, 9 Jun 2015 17:47:03 +0000 (19:47 +0200)]
[TASK] dbal: Ignore MySQL UNSIGNED/ZEROFILL in database schema compare

Avoid suggestions for database alterations in the install tool
that can not be implemented on DBMS other than MySQL due to
usage of non-standard attributes.

Resolves: #67335
Releases: master
Change-Id: I749563e0b0abc9b42236f2951222cb2771507a79
Reviewed-on: http://review.typo3.org/40137
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Deprecate custom singleton logic in GeneralUtility::getUserObj 16/40516/3
Benjamin Mack [Mon, 22 Jun 2015 05:52:13 +0000 (07:52 +0200)]
[TASK] Deprecate custom singleton logic in GeneralUtility::getUserObj

The prepending ampersand within GeneralUtility::getUserObj($className)
is marked for removal, as the SingletonInterface pattern should be used
in general for this approach as well.

Resolves: #67670
Releases: master
Change-Id: I7b6fbfdbcd668657ac66eba5f3b21361fbe7f5ac
Reviewed-on: http://review.typo3.org/40516
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Bernhard Kraft <kraftb@think-open.at>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[!!!][TASK] FormEngine: Drop "Show secondary options" 49/40649/6
Christian Kuhn [Thu, 25 Jun 2015 15:00:33 +0000 (17:00 +0200)]
[!!!][TASK] FormEngine: Drop "Show secondary options"

Resolves: #67753
Releases: master
Change-Id: I35195892b81a11026a6e6227337bb6da47166a67
Reviewed-on: http://review.typo3.org/40649
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[CLEANUP] Early continues in DataHandler::copyRecord_fixRTEmagicImages() 87/40387/4
Andreas Wolf [Wed, 17 Jun 2015 19:01:05 +0000 (21:01 +0200)]
[CLEANUP] Early continues in DataHandler::copyRecord_fixRTEmagicImages()

Change-Id: I0336727989044a5cf8a618b32464f4319af120ab
Resolves: #67582
Releases: master
Reviewed-on: http://review.typo3.org/40387
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Use makeInstance in some hooks 21/40621/3
Christian Kuhn [Thu, 25 Jun 2015 12:06:50 +0000 (14:06 +0200)]
[TASK] Use makeInstance in some hooks

Switch some hooks from getUserObj() to makeInstance() and
rely on auto loading.

Resolves: #67749
Releases: master
Change-Id: Ib89e920fd50a40103a38eedb229382d547de62e1
Reviewed-on: http://review.typo3.org/40621
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[CLEANUP] Early returns in DataHandler::localize() 85/40385/5
Andreas Wolf [Sun, 7 Jun 2015 09:23:02 +0000 (11:23 +0200)]
[CLEANUP] Early returns in DataHandler::localize()

Resolves: #67583
Releases: master
Change-Id: Ib3971ac6fa4c531b45227f41307d79e3e434b89f
Reviewed-on: http://review.typo3.org/40385
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[CLEANUP] Early continues in DataHandler::fillInFieldArray() 88/40388/4
Andreas Wolf [Tue, 16 Jun 2015 10:33:14 +0000 (12:33 +0200)]
[CLEANUP] Early continues in DataHandler::fillInFieldArray()

Resolves: #67584
Releases: master
Change-Id: I4c4d38686718c919732fe1f9739389c4bee0ab45
Reviewed-on: http://review.typo3.org/40388
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Early returns in DataHandler::deleteRecord() 89/40389/3
Andreas Wolf [Tue, 16 Jun 2015 10:19:44 +0000 (12:19 +0200)]
[CLEANUP] Early returns in DataHandler::deleteRecord()

Resolves: #67585
Releases: master
Change-Id: Iea8eab8a50e7014884f23be0ce7ada7b5f1743d7
Reviewed-on: http://review.typo3.org/40389
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Avoid race conditions in typo3temp/Cache 95/39895/7
Bernhard Kraft [Tue, 2 Jun 2015 13:19:23 +0000 (15:19 +0200)]
[BUGFIX] Avoid race conditions in typo3temp/Cache

Race conditions can occur when the cache in typo3temp/Cache gets
cleared, for example by using the Install Tool "Clear all caches"
button. The cache is currently cleared using GeneralUtility::rmdir()
which does a directory traversal and unlinks all contained files.
Instead GeneralUtility::flushDirectory() should get used. This method
renames the directory into a temp-dir name and then removes the temp-dir
using GeneralUtility:rmdir().

Change-Id: I23f31da4e7b1730edee9007e713a51d4b39c6f1c
Resolves: #67238
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39895
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[!!!][TASK] Drop additional palette handling 99/40599/13
Christian Kuhn [Wed, 24 Jun 2015 16:36:40 +0000 (18:36 +0200)]
[!!!][TASK] Drop additional palette handling

Change-Id: I33a5173515ebf04e19f31838cff84dd5561bc3c3
Resolves: #67737
Releases: master
Reviewed-on: http://review.typo3.org/40599
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Refactor IndexedSearch hook examples 11/40611/3
Frederic Gaus [Thu, 25 Jun 2015 09:36:05 +0000 (11:36 +0200)]
[TASK] Refactor IndexedSearch hook examples

* Remove long class names
* Define undefined variables
* Correct and add phpDocs

Releases: master
Resolves: #67746
Change-Id: Ide42c2cd6c3ca0bcb5a74a2c6a33cb4dcef6579a
Reviewed-on: http://review.typo3.org/40611
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[TASK] Update breaking documentation FormEngineRefactoring 13/40613/2
Andreas Allacher [Thu, 25 Jun 2015 10:56:00 +0000 (12:56 +0200)]
[TASK] Update breaking documentation FormEngineRefactoring

Change-Id: Ib5855f17930e65a1e6fee878b43dffa215b0ed32
Resolves: #67747
Releases:  master
Related: #63846
Reviewed-on: http://review.typo3.org/40613
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Make ext_update working 03/40603/5
Markus Klein [Wed, 24 Jun 2015 18:51:14 +0000 (20:51 +0200)]
[BUGFIX] Make ext_update working

Running the actual update now works with all variants of ext_update
classes. Namespaced and non-namespaced.

Additionally we avoid autoloading at some places, since the composer
autoloader is too intelligent and finds the class from another ext.

Resolves: #67735
Releases: master, 6.2
Change-Id: Idec85d9b97cb67d862c0c8647e1490d146f27f45
Reviewed-on: http://review.typo3.org/40603
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Use ResourceStorage::replaceFile for upload + replace 05/38505/2
Frans Saris [Tue, 7 Apr 2015 09:04:58 +0000 (11:04 +0200)]
[BUGFIX] Use ResourceStorage::replaceFile for upload + replace

Resolves: #65089
Releases: master
Change-Id: Ic59e525c6e06c8b0ff71da8ff01f536f0a7059fa
Reviewed-on: http://review.typo3.org/38505
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Fix exception in IssueCommand view helper 87/40587/3
Andreas Fernandez [Wed, 24 Jun 2015 12:35:57 +0000 (14:35 +0200)]
[BUGFIX] Fix exception in IssueCommand view helper

The URL used in the IssueCommand view helper is now built properly
to fix the exception mentioned in the ticket.

Resolves: #67653
Releases: master
Change-Id: I13dab0ad845d9091ff1cfc54e104803faa149f6e
Reviewed-on: http://review.typo3.org/40587
Reviewed-by: David Greiner <hallo@davidgreiner.de>
Tested-by: David Greiner <hallo@davidgreiner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Use proper PHP 5.5 class references (no singleton) 06/40606/3
Benjamin Mack [Thu, 25 Jun 2015 07:57:57 +0000 (09:57 +0200)]
[TASK] Use proper PHP 5.5 class references (no singleton)

Resolves: #67743
Releases: master
Change-Id: Iad5c37fbf0350d52b03ea7d8a92b2e82440cb3de
Reviewed-on: http://review.typo3.org/40606
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Cleanup AbstractExceptionHandler and fix variable access 65/40565/4
Mathias Schreiber [Tue, 23 Jun 2015 16:52:01 +0000 (18:52 +0200)]
[BUGFIX] Cleanup AbstractExceptionHandler and fix variable access

AbstractExceptionHandler still used a formerly public property which
has been defined as protected in the meantime.
Cleaning up the code and using a getter method for access of $GLOBALS
revealed the issue.

Resolves: #67703
Releases: master, 6.2
Change-Id: I36ec96312769e09734891cc78ea4f800bb5af976
Reviewed-on: http://review.typo3.org/40565
Reviewed-by: Felix Nagel <info@felixnagel.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Correct namespace for RichTextElement 07/40607/3
Frederic Gaus [Thu, 25 Jun 2015 08:28:15 +0000 (10:28 +0200)]
[BUGFIX] Correct namespace for RichTextElement

Correct namespace of \TYPO3\CMS\RteHtmlarea\Form\Element\RichTextElement

Releases: master
Resolves: #67744
Change-Id: Ia27a1f3ac92de7e86f5487fe61569c3dde2e1147
Reviewed-on: http://review.typo3.org/40607
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] EXT:mediace does not resolve EXT:paths for swf includes 05/40605/2
Benjamin Mack [Thu, 25 Jun 2015 05:19:13 +0000 (07:19 +0200)]
[BUGFIX] EXT:mediace does not resolve EXT:paths for swf includes

Due to the moving of the swf player files from typo3/contrib
to EXT:mediace one file does not resolve the EXT: syntax yet
making the mediace swf player not working in CMS7.

The patch resolves the path to swfobject.js when given with
a EXT: syntax.

Resolves: #67740
Releases: master
Change-Id: If33385c79bbd4d2944480b55f695cdfc1533d6fd
Reviewed-on: http://review.typo3.org/40605
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Fix media paths for CSS Styled Content 6.2 TS 04/40604/3
Benjamin Mack [Thu, 25 Jun 2015 05:15:12 +0000 (07:15 +0200)]
[BUGFIX] Fix media paths for CSS Styled Content 6.2 TS

The paths for CSS Styled Content media with the
6.2 rendering are adopted to fit the new paths
related to EXT:mediace.

Resolves: #67739
Releases: master
Change-Id: I41afec10354f8110d3eb6b789753892955a685e8
Reviewed-on: http://review.typo3.org/40604
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[TASK] Change ellipsis icon to chevron in list view 02/40602/4
Jan Helke [Wed, 24 Jun 2015 18:42:04 +0000 (20:42 +0200)]
[TASK] Change ellipsis icon to chevron in list view

The ellipsis icon at the end of the list view looks confusing without the
context of other icons. The chevron expresses the meaning "expand list"
much better.

Releases: master
Resolves: #67734
Change-Id: Ia201505c63ffa7e2cb5b240ad49af96941e4dda2
Reviewed-on: http://review.typo3.org/40602
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
4 years ago[TASK] Improve addFieldsToAllPalettesOfField() tests 01/40601/3
Christian Kuhn [Wed, 24 Jun 2015 18:40:54 +0000 (20:40 +0200)]
[TASK] Improve addFieldsToAllPalettesOfField() tests

Cut existing addFieldsToAllPalettesOfField() tests into smaller pieces
and do not use generateTCAForTable() to make them better readable and
understandable. Test one thing at a time.

Resolves: #67733
Releases: master
Change-Id: Ib763e905e91cc7835028bbe04cda14946604be9a
Reviewed-on: http://review.typo3.org/40601
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Better description for parameter in AuthenticationService::getGroups() 79/40579/8
Frank Nägler [Tue, 23 Jun 2015 21:04:13 +0000 (23:04 +0200)]
[TASK] Better description for parameter in AuthenticationService::getGroups()

This patch add a note why this parameter should not be removed.

Resolves: #67715
Releases: master
Change-Id: Iaefc4e3d73e1df2e34a2b9d0f60a0b9d49a158d0
Reviewed-on: http://review.typo3.org/40579
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Mark ext:beuser as stable in ext_emconf 94/40594/2
Christian Kuhn [Wed, 24 Jun 2015 15:23:22 +0000 (17:23 +0200)]
[TASK] Mark ext:beuser as stable in ext_emconf

Resolves: #67729
Releases: master
Change-Id: Ic756bce02270116cac1cc8ae559862d4fc807308
Reviewed-on: http://review.typo3.org/40594
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>