Packages/TYPO3.CMS.git
13 months ago[BUGFIX] Simulate submit button for rsaauth form submit 04/56104/6
Nicole Cordes [Sat, 28 May 2016 17:12:38 +0000 (19:12 +0200)]
[BUGFIX] Simulate submit button for rsaauth form submit

This patch adds the name and value of the first submit button found in a
form to the input field used to send the form.

RsaEncryptionWithLib.min.js created with:
../../../../../../Build/node_modules/uglify-js/bin/uglifyjs \
RsaLibrary.js RsaEncryption.js > RsaEncryptionWithLib.min.js

Resolves: #76120
Releases: master, 8.7, 7.6
Change-Id: I3f0fdc7e933267689114d5bcf62d3fcfe2db5146
Reviewed-on: https://review.typo3.org/56104
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Properly HTML encode site name in page module 87/56087/2
Helmut Hummel [Fri, 9 Mar 2018 21:14:09 +0000 (22:14 +0100)]
[BUGFIX] Properly HTML encode site name in page module

Resolves: #84191
Releases: master, 8.7, 7.6
Change-Id: Id0f2da6f77b3c01293478329503dc922ccd7e72c
Reviewed-on: https://review.typo3.org/56087
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
13 months ago[BUGFIX] Do not check HTTP referrer anymore 19/55819/3
Benni Mack [Tue, 20 Feb 2018 07:50:59 +0000 (08:50 +0100)]
[BUGFIX] Do not check HTTP referrer anymore

Under certain circumstances some browsers do not set the HTTP referrer
anymore due to privacy reasons. Hence, checking the referrer breaks
functionality.

Resolves: #83768
Releases: master, 8.7, 7.6
Change-Id: Ia8f882e07a9e2091ceb38aee814badb97403250d
Reviewed-on: https://review.typo3.org/55819
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
13 months ago[BUGFIX] Unset internal properties of processed file on delete 06/53506/3
Helmut Hummel [Mon, 20 Mar 2017 18:28:12 +0000 (19:28 +0100)]
[BUGFIX] Unset internal properties of processed file on delete

When a processed file is deleted because it needs reprocessing, set the
internal deleted property to true and unset its properties as well, as
they are stale anyway.

This is important as in the later processing it is checked whether the
current object is persisted (which it is not anymore) and an SQL update
is triggered, which then fails leading to another processing run in
subsequent requests.

When unsetting the internal properties a new row will be inserted
in the same request.

Resolves: #80359
Releases: 7.6, 8.7, master
Change-Id: I39eec59ed4ac071883ff97eab7018d1ede92fb95
Reviewed-on: https://review.typo3.org/53506
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
13 months ago[TASK] Synchronize RST files 12/56012/2
Christian Kuhn [Mon, 5 Mar 2018 12:43:41 +0000 (13:43 +0100)]
[TASK] Synchronize RST files

* Various .rst file index fixes, NotScanned usually does not make
  sense on Important- and Feature- files.
* Add a missing extension scanner config
* Sync 7* and 8* folders to other core branches

Resolves: #84141
Releases: master, 8.7, 7.6
Change-Id: Ifc19d774d45395cb30bd51f50d9121af409f48bb
Reviewed-on: https://review.typo3.org/56012
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Filter duplicate cache commands from cacheQueue 87/55587/2
Simon Schmidt [Wed, 7 Feb 2018 15:55:59 +0000 (16:55 +0100)]
[TASK] Filter duplicate cache commands from cacheQueue

remove multiple calling for clear_cachecmd with the same page id

Resolves: #83797
Related: #82930
Releases: 7.6
Change-Id: I5740a33d3cf5dd5c7ccbe7166b9d0ba3e9ddeaee
Reviewed-on: https://review.typo3.org/55587
Reviewed-by: Daniel Klockenkaemper <dk@marketing-factory.de>
Tested-by: Daniel Klockenkaemper <dk@marketing-factory.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Put commit hooks into Build/git-hooks directory 74/55974/2
Sybille Peters [Wed, 14 Feb 2018 09:41:20 +0000 (10:41 +0100)]
[TASK] Put commit hooks into Build/git-hooks directory

* commit-msg hook: change wiki link to link to official contribution guide
* commit-msg hook: rebase with original source
* commit-msg hook: add Change-Id on last line after footer
* pre-commit hook: check if staged php files conform to coding guidelines
* Build/Scripts/cglFixMyCommit.sh: extended
  parameters to be used by new pre-commit hook

Resolves: #83891
Releases: master, 8.7, 7.6
Change-Id: I6d00aa32ef3f9517d88e90c40059c7f73d7f6cfe
Reviewed-on: https://review.typo3.org/55974
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Avoid renumbering array keys on writing configuration 44/55944/2
Helmut Hummel [Wed, 28 Feb 2018 12:41:49 +0000 (13:41 +0100)]
[BUGFIX] Avoid renumbering array keys on writing configuration

Renumbering array keys, even if all keys are integer
is a destructive operation.
Doing so at least breaks our logging configuration,
which uses LogLevel constants as array keys and these constants
are defined as integer.

Therefore this pure visual optimization is removed
when writing LocalConfiguration.php

At a later point we might consider deprecating this
method, which at least has a wrong method name
(mentions "numeric", while it meanwhile uses "int" checks).
As this method performs a destructive operation,
its usefulness is limited.

Resolves: #82304
Releases: master, 8.7, 7.6
Change-Id: I8d252428f3e27379e4377d30af0fdfd5e5d8719d
Reviewed-on: https://review.typo3.org/55944
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Catch exception editing record with deleted relation 52/55752/2
Andreas Fernandez [Wed, 24 Jan 2018 15:50:17 +0000 (16:50 +0100)]
[BUGFIX] Catch exception editing record with deleted relation

Editing a record with a deleted related record leads to an uncaught
DatabaseRecordException. This patch catches the exception and
ignores such records, but logs a warning.

Due to possible errors occurring with certain DBMS (e.g. MySQL
strict) columns may require a default value now in TCA.

Resolves: #83412
Releases: master, 8.7, 7.6
Change-Id: I5adaf385443350ce245dd83da6e5f1a16d9c9afb
Reviewed-on: https://review.typo3.org/55752
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Correctly handle identical arrays in arrayDiffAssocRecursive 25/55925/2
Markus Klein [Tue, 27 Feb 2018 14:57:58 +0000 (15:57 +0100)]
[BUGFIX] Correctly handle identical arrays in arrayDiffAssocRecursive

Add a new test to make sure that identical input arrays also deliver
an empty result as difference.

Resolves: #84067
Releases: master, 8.7, 7.6
Change-Id: Ia16ca9560094c4ae42eb69cac9e09cd4bef7dc4e
Reviewed-on: https://review.typo3.org/55925
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Show error message when hiding page from context menu 05/55905/2
Tymoteusz Motylewski [Mon, 26 Feb 2018 12:51:58 +0000 (13:51 +0100)]
[BUGFIX] Show error message when hiding page from context menu

Renamed key in the response to match what is expected
in actions.js evaluateResponse method.

Releases: 8.7, 7.6
Resolves: #82282
Change-Id: I4528963aded3a8203ab144c8353fc0509aa8a1e7
Reviewed-on: https://review.typo3.org/55905
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Update readme copyright date to 2018 98/55898/2
Guido Schmechel [Sat, 24 Feb 2018 08:35:34 +0000 (09:35 +0100)]
[TASK] Update readme copyright date to 2018

Releases: master, 8.7, 7.6
Resolves: #84028

Change-Id: Ia6094c57c976ecf6e89b1d99aca0a1b12684e0b2
Reviewed-on: https://review.typo3.org/55898
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Don't download language packs of not loaded extensions 64/55864/2
Christian Kuhn [Wed, 21 Feb 2018 23:05:49 +0000 (00:05 +0100)]
[BUGFIX] Don't download language packs of not loaded extensions

The backend language module struggles with downloading
language packs of existing, but not loaded extensions
and fetchess old (non core version specific) packs
for core extensions.
This is hard to solve on a bugfix level for v7 and v8,
and in general it does not make much sense to have
language packs of not loaded extensions lying around
in typo3conf/l10n.
The patch ignores fetching of language packs for
not loaded extensions, it easily applies to all
maintained core versions.

Change-Id: I9ad885012a572368f7946f1027d870ee09550034
Resolves: #83406
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55864
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Stucki <michael.stucki@typo3.org>
Tested-by: Michael Stucki <michael.stucki@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Extend untangleFilesArray function test in RequestBuilder 11/55811/2
Joshua Westerheide [Sat, 11 Nov 2017 16:42:05 +0000 (17:42 +0100)]
[TASK] Extend untangleFilesArray function test in RequestBuilder

Check for cases where the files array is nested more complex or
keywords (e.g. "error") are used as field names.

Run `curl -F "d0[]=@d12.txt" -F "d0[d1][d2][d3]=@d12.txt"
-F "error=@error_file.txt" localhost:8080` against a custom
php script to generate the testing $_FILES array.

Resolves: #82976
Releases: master, 8.7, 7.6
Change-Id: I51fb9da7c87871b6bb1e8ac4de317973f307dd49
Reviewed-on: https://review.typo3.org/55811
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Change the label for scheduler "Save and create" 07/55807/2
Tomas Norre Mikkelsen [Thu, 15 Feb 2018 13:10:50 +0000 (14:10 +0100)]
[TASK] Change the label for scheduler "Save and create"

The label for the "Save and create new document" in the scheduler module,
will be change to a more appropriate label "Save and create new task"

Resolves: #83920
Releases: master, 8.7, 7.6
Change-Id: Ic4d6ad9d4598aafbc16c03b5bc50789451f6cdaf
Reviewed-on: https://review.typo3.org/55807
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[BUGFIX] Make it possible to translate selectMultipleSideBySide 75/55675/2
Manuel Selbach [Thu, 8 Feb 2018 17:51:43 +0000 (18:51 +0100)]
[BUGFIX] Make it possible to translate selectMultipleSideBySide

For the default language it was possible to view the field, but on
translating the dataset, the following exception is thrown:
'PHP Warning: Invalid argument supplied for foreach() in
backend/Classes/Form/Element/SelectMultipleSideBySideElement.php line 66'

As the defaultLanguageRow keeps to be "unparsed", the $selectedItems
could be a comma separated string within the method
TYPO3\CMS\Backend\Form\Element\SelectMultipleSideBySideElement::renderReadOnly
if the TCA configuration of a field is set to 'defaultAsReadonly'.

Resolves: #77155
Releases: master, 8.7, 7.6
Change-Id: Id9380fe3761e683352166565ed1a7e56f5e64190
Reviewed-on: https://review.typo3.org/55675
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Access Close.html from Resources/Public/Html/ 93/54993/3
Stephan Großberndt [Fri, 8 Dec 2017 14:38:44 +0000 (15:38 +0100)]
[BUGFIX] Access Close.html from Resources/Public/Html/

Clicking the close button in a editing popup accesses Close.html in
Resources/Public/Html/ which is a folder accessible by a web user
instead of Resources/Private/Templates/ which lead to a HTTP 403 error
on closing the popup.

Releases: master, 8.7, 7.6
Resolves: #83258
Related: #68108
Change-Id: Ibe7e328936240df436a3c9585e53122f1577dc6e
Reviewed-on: https://review.typo3.org/54993
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
14 months ago[TASK] Block access to .typoscript files 26/55626/2
Tymoteusz Motylewski [Fri, 9 Feb 2018 09:14:24 +0000 (10:14 +0100)]
[TASK] Block access to .typoscript files

As .typoscript is the preferred file ending for TypoScript files,
this should be reflected in the .htaccess access rules as well.

Change-Id: If894d831afb5fd7e3ed1c098023111b82cde124f
Resolves: #83703
Releases: 7.6
Reviewed-on: https://review.typo3.org/55626
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Do not rawurlencode record titles using label_alt and type=group 83/54483/3
Oliver Hader [Tue, 6 Feb 2018 21:55:11 +0000 (22:55 +0100)]
[BUGFIX] Do not rawurlencode record titles using label_alt and type=group

Do not rawurlencode the label_alt part references of record titles if
they are of type=group as this leads to duplicate encoding.

Resolves: #78995
Releases: 7.6
Change-Id: I9a445745415080856adfbf51c4a87820a8e77375
Reviewed-on: https://review.typo3.org/54483
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
14 months ago[BUGFIX] Allow users without delete permissions to drag pages in page tree 35/55535/2
Tymoteusz Motylewski [Thu, 7 Dec 2017 13:46:48 +0000 (14:46 +0100)]
[BUGFIX] Allow users without delete permissions to drag pages in page tree

BE users without delete rights can now drag-drop pages in the page tree.
The drag - delete area is not shown.

Resolves: #25135
Releases: 8.7, 7.6
Change-Id: Icc82675a783f19ae72b6d00ac2809ad76b93dd67
Reviewed-on: https://review.typo3.org/55535
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
14 months ago[TASK] Set TYPO3 version to 7.6.25-dev 74/55574/2
Oliver Hader [Tue, 6 Feb 2018 10:55:13 +0000 (11:55 +0100)]
[TASK] Set TYPO3 version to 7.6.25-dev

Change-Id: I74d839719a841d19b23241af87c1f5cfbc012d7f
Reviewed-on: https://review.typo3.org/55574
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[RELEASE] Release of TYPO3 7.6.24 73/55573/2 7.6.24 TYPO3_7-6-24 v7.6.24
Oliver Hader [Tue, 6 Feb 2018 10:53:43 +0000 (11:53 +0100)]
[RELEASE] Release of TYPO3 7.6.24

Change-Id: I58a85b55724c2a4072a7ceec900cab685a0a834b
Reviewed-on: https://review.typo3.org/55573
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
14 months ago[BUGFIX] Replace calls to the deprecated PHP function each() 70/55570/4
Reiner Teubner [Wed, 31 Jan 2018 14:30:21 +0000 (15:30 +0100)]
[BUGFIX] Replace calls to the deprecated PHP function each()

This patch replaces the calls to the PHP function each() as it is
marked as deprecated in PHP 7.2. Additionally it adds unit tests for
QueryGenerator::getSubscript().

Resolves: #83737
Releases: master, 8.7, 7.6
Change-Id: Ie61a6d44fcdbd4ce6105a6c185085a3a68866fd8
Reviewed-on: https://review.typo3.org/55570
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Invalid session token on creating content element in admin panel 90/55490/2
Oliver Hader [Mon, 29 Jan 2018 15:43:45 +0000 (16:43 +0100)]
[BUGFIX] Invalid session token on creating content element in admin panel

When creating a new content element in the frontend using the according
button in the "editing" section of the admin panel, the request to the
TYPO3 backend is rejected due to an invalid XSRF session token:

Validating the security token of this form has failed.
Please reload the form and submit it again.

The reason is, that the URL after issue #70055 looks like the following
"token=<hash>id=<id>" instead of "token=<hash>&id=<id>" - the id became
part of the XSRF session token.

Resolves: #83719
Releases: master, 8.7, 7.6
Change-Id: Ibdd252b2e59d9e8de78bb0be14a95e0789dc0d17
Reviewed-on: https://review.typo3.org/55490
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
14 months ago[BUGFIX] Properly check serialized_executions to avoid PHP 7.2 warnings 84/55484/3
Oliver Hader [Mon, 29 Jan 2018 11:59:02 +0000 (12:59 +0100)]
[BUGFIX] Properly check serialized_executions to avoid PHP 7.2 warnings

To avoid warnings with PHP 7.2, `serialized_executions` must be checked
for being not an empty value.

Resolves: #83691
Releases: master, 8.7, 7.6
Change-Id: I5855a03d6669ec0e82931cfc0110c2b7ca134ad4
Reviewed-on: https://review.typo3.org/55484
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
14 months ago[TASK] Move changing preview processing config to processing service 71/55271/3
Helmut Hummel [Sun, 24 Dec 2017 14:21:49 +0000 (15:21 +0100)]
[TASK] Move changing preview processing config to processing service

Instead of complementing processing configuration in the file class,
move it to the processing service and LocalPreviewHelper class
to not have the code and logic duplicated and to ensure it is
always executed, not only when using the file API.

Resolves: #83421
Related: #81776
Related: #83242
Releases: master, 8.7, 7.6
Change-Id: I9b3f380625756137a56e7ad0ea55d21f47464ab8
Reviewed-on: https://review.typo3.org/55271
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
14 months ago[BUGFIX] Use correct default value for field data_page_reg1 49/55449/2
Georg Ringer [Tue, 23 Jan 2018 04:22:48 +0000 (05:22 +0100)]
[BUGFIX] Use correct default value for field data_page_reg1

The field data_page_reg1 of table index_phash is defined as integer.
Therefore the default value must be 0 instead of an empty string.

Resolves: #83641
Releases: master, 8.7, 7.6
Change-Id: I4c1f115b8c8bbcb961627d7f5a5a413a8d5cf419
Reviewed-on: https://review.typo3.org/55449
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[FEATURE] Support pecl-memcached in MemcachedBackend 84/55384/5
Andreas Fernandez [Mon, 14 Sep 2015 14:44:35 +0000 (16:44 +0200)]
[FEATURE] Support pecl-memcached in MemcachedBackend

The MemcachedBackend now also supports the pecl-memcached
module. The caching backend detects which modules are installed
and uses "memcache" over "memcached" to avoid being a breaking
change. If both modules are installed, an integrator can choose the
PECL module by setting the new ``peclModule`` option.

This feature was originally introduced with TYPO3 v8.0. Due to
compatibility reasons with PHP 7 this feature gets backported as the
memcache module is not available anymore.

Resolves: #83569
Related: #69794
Releases: 7.6
Change-Id: Idd4e85cf8ec71d47217b63dfe55b1231107c7b82
Reviewed-on: https://review.typo3.org/55384
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Update composer.json license definition 95/55395/3
Oliver Hader [Thu, 18 Jan 2018 10:23:11 +0000 (11:23 +0100)]
[TASK] Update composer.json license definition

Composer license definition GPL-2.0+ has been deprecated
and has to be replaced with GPL-2.0-or-later.

Resolves: #83607
Releases: master, 8.7, 7.6, 6.2
Change-Id: I6113bc3a90cb6a56830b930522dde2eaacd5025e
Reviewed-on: https://review.typo3.org/55395
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Improve exception output for ImageService 76/55376/2
Georg Ringer [Tue, 16 Jan 2018 10:28:05 +0000 (11:28 +0100)]
[BUGFIX] Improve exception output for ImageService

Avoid spamming the log in PHP 7.2 due to get_class(null) if fetching the
image in ImageService->getImage() fails.

Resolves: #83570
Releases: master, 8.7, 7.6
Change-Id: Icc3c78f5b747842cee89d184134ff298b8e04a3a
Reviewed-on: https://review.typo3.org/55376
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] impexp: Wrong FAL references after import 68/55368/2
Christian Kuhn [Mon, 15 Jan 2018 14:54:57 +0000 (15:54 +0100)]
[BUGFIX] impexp: Wrong FAL references after import

Fix a case during ext:impexp FAL uid mapping where
sys_file_reference end up pointing to wrong sys_file
records in case new sys_file uids also already exist
in import file, due to multiple mappings.
Power the patch with a functional test - it fails
without the change in Import.php and is ok with the
change.
See the test method comments for more details
on what exactly is checked here.

Change-Id: I472cad2652e8d6f5d30e4ebc68ff1ae93de71ea1
Resolves: #67188
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55368
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Make empty $GLOBALS['TBE_MODULES_EXT'] traversable 97/55297/3
Richard Haeser [Fri, 5 Jan 2018 10:44:01 +0000 (11:44 +0100)]
[BUGFIX] Make empty $GLOBALS['TBE_MODULES_EXT'] traversable

Prevent warnings and notices if $GLOBALS['TBE_MODULES_EXT'] is not
set, which can be the case if no extensions are installed.

Change-Id: I72f513329790ee3b71fd30054574b79f41a6dcf8
Resolves: #83479
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55297
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Prevent javascript error in backend 14/54714/5
Markus Günther [Mon, 20 Nov 2017 08:18:27 +0000 (09:18 +0100)]
[BUGFIX] Prevent javascript error in backend

Adding a condition to check if a backend user has permissions on the
search to prevent a JS error while initializing the autocomplete module.
Also check if a module is available to start with.

Fixes: #82969
Releases: master, 8.7, 7.6
Change-Id: If2827902443ff7411d9b2c1050213be3e0d78fb6
Reviewed-on: https://review.typo3.org/54714
Reviewed-by: Markus Günther <mail@markus-guenther.de>
Tested-by: Markus Günther <mail@markus-guenther.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
15 months ago[BUGFIX] Use strict flag in signalslot dispatcher 89/55189/3
Georg Ringer [Thu, 12 Oct 2017 07:03:30 +0000 (09:03 +0200)]
[BUGFIX] Use strict flag in signalslot dispatcher

To avoid exceptions with complex structures, the strict flag
must be used in the in_array check.

Resolves: #82736
Releases: master, 8.7, 7.6
Change-Id: I3ecf859e3e3cc70ab40b10ef9052d46e8b486957
Reviewed-on: https://review.typo3.org/55189
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[TASK] Update copyright year in documentation to 2018 49/55249/2
Andreas Fernandez [Tue, 2 Jan 2018 21:26:29 +0000 (22:26 +0100)]
[TASK] Update copyright year in documentation to 2018

Resolves: #83453
Releases: master, 8.7, 7.6
Change-Id: I40654f5c230e0e91b3b479dd1c07eb087e639051
Reviewed-on: https://review.typo3.org/55249
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
15 months ago[BUGFIX] Correct permissions for root page setting up empty site 46/55246/2
Stephan Großberndt [Tue, 2 Jan 2018 18:40:13 +0000 (19:40 +0100)]
[BUGFIX] Correct permissions for root page setting up empty site

Use the correct maximal permission "31" for the root page when setting
up an empty site during the installation process instead of "32" which
leads to non-editable permissions for that page even by an admin.

Resolves: #83369
Releases: master, 8.7, 7.6
Change-Id: I092f32b48c2a6deb79727fd6a1f8730829161287
Reviewed-on: https://review.typo3.org/55246
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Fix PHP 7.2 issues in EXT:lowlevel 37/55237/2
Georg Ringer [Sun, 24 Dec 2017 08:58:08 +0000 (09:58 +0100)]
[BUGFIX] Fix PHP 7.2 issues in EXT:lowlevel

Resolves: #83409
Releases: master, 8.7, 7.6
Change-Id: I94a3a3ad31de6e4969d5456f12b728c98adf0815
Reviewed-on: https://review.typo3.org/55237
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
15 months ago[FOLLOWUP][BUGFIX] Add `controlsList` as known additional attribute 91/55191/4
Andreas Fernandez [Thu, 21 Dec 2017 14:59:39 +0000 (15:59 +0100)]
[FOLLOWUP][BUGFIX] Add `controlsList` as known additional attribute

Fix an issue in unit tests.

Resolves: #81222
Releases: 7.6
Change-Id: I439c81e6d3f0c142367b2ea0241a997d0c78cd8e
Reviewed-on: https://review.typo3.org/55191
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
15 months ago[BUGFIX] Add `controlsList` as known additional attribute 87/55187/2
Andreas Fernandez [Thu, 21 Dec 2017 13:18:32 +0000 (14:18 +0100)]
[BUGFIX] Add `controlsList` as known additional attribute

The HTML5 attribute `controlsList` is used in at least Google Chrome
to limit the control buttons. The AudioTagRenderer and VideoTagRenderer
classes are now aware of that attribute.

Resolves: #81222
Releases: master, 8.7, 7.6
Change-Id: I9a577ae077e7e7b55b9fed7852a5a61a5fd4061a
Reviewed-on: https://review.typo3.org/55187
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
16 months ago[TASK] Changelog docs: Review and add tags 84/55184/3
Christian Kuhn [Wed, 20 Dec 2017 20:12:21 +0000 (21:12 +0100)]
[TASK] Changelog docs: Review and add tags

* Add tags of all v7 Changelog files
* Minor .rst reformattings and fixes

Change-Id: I4761a1d8028feca5de30a3f860fd5f01bbdd42d1
Resolves: #83402
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55184
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] Only select current file when editing metadata 68/55168/2
Stephan Großberndt [Sat, 16 Dec 2017 17:08:46 +0000 (18:08 +0100)]
[BUGFIX] Only select current file when editing metadata

Only select the current file connected to the metadata when editing the
metadata of a file.

Resolves: #78845
Releases: master, 8.7, 7.6
Change-Id: Ib65b1e1aaae1fa2c93b03e4865582841a28990a6
Reviewed-on: https://review.typo3.org/55168
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
16 months ago[BUGFIX] Use correct path and add missing labels in TCA of extensionmanager 66/55166/3
Stephan Großberndt [Mon, 18 Dec 2017 15:06:02 +0000 (16:06 +0100)]
[BUGFIX] Use correct path and add missing labels in TCA of extensionmanager

Releases: master, 8.7, 7.6
Resolves: #83375
Change-Id: Id998c9fb688b8dcd41f09a0b863f87e8290adb2a
Reviewed-on: https://review.typo3.org/55166
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
16 months ago[BUGFIX] AdminPanelView tries to count null value 02/55102/3
Oliver Hader [Fri, 15 Dec 2017 15:58:03 +0000 (16:58 +0100)]
[BUGFIX] AdminPanelView tries to count null value

Resolves: #83345
Releases: master, 8.7, 7.6
Change-Id: I49e0de26154430c8a93c6a25a7fa54d5e49be39d
Reviewed-on: https://review.typo3.org/55102
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
16 months ago[TASK] Changelog docs: Update Howto.rst 41/55141/2
Christian Kuhn [Sun, 17 Dec 2017 16:23:47 +0000 (17:23 +0100)]
[TASK] Changelog docs: Update Howto.rst

Align Howto.rst with version from master.

Change-Id: Ie68e5eb59f080537050717106bf549dc6d4a0ef3
Resolves: #83371
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55141
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[TASK] v7 Changelog: Add a missing forge reference 28/55128/2
Christian Kuhn [Sat, 16 Dec 2017 18:15:19 +0000 (19:15 +0100)]
[TASK] v7 Changelog: Add a missing forge reference

One .rst Changelog file misses the mandatory
index to the forge issue number.

Change-Id: I3d4275f777bf164cf51b4df61a8a3606c7058bbf
Resolves: #83364
Releases: 7.6
Reviewed-on: https://review.typo3.org/55128
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[TASK] v7 Changelog: Further fixes and alignments with master 26/55126/4
Christian Kuhn [Sat, 16 Dec 2017 17:33:36 +0000 (18:33 +0100)]
[TASK] v7 Changelog: Further fixes and alignments with master

Two fixes in specific .rst files and syncing main Index.rst
and other files on this level with master.

Change-Id: Ibe3221e455bd05fe4417aafab4afeb4c2ba409e4
Resolves: #83362
Releases: 7.6
Reviewed-on: https://review.typo3.org/55126
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[TASK] v7 Changelog: Fix compile warnings, update 7.6.x/ Index.rst 24/55124/2
Christian Kuhn [Sat, 16 Dec 2017 15:57:10 +0000 (16:57 +0100)]
[TASK] v7 Changelog: Fix compile warnings, update 7.6.x/ Index.rst

Fixes a broken link and restructures the 7.6.x/Index.rst to be
free from patch level releases. This is ok with the low number
of files in this folder. Since v8, the install tool documentation
module will further help with keeping track of new files during
patch level releases, too. Not having named patch level versions
is easier to maintain from core point of view and simplifies
the underlying workflow.
The patch also adds indirectly adds a file which has been forgotton
to reference in Index.rst, this can't happen anymore from now on
due to the glob reference.

Change-Id: I2163f0823becbf5b719dc4cf9c1520ed224abb15
Resolves: #83361
Releases: 7.6
Reviewed-on: https://review.typo3.org/55124
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] EXT:scheduler: Update Documentation version 10/55110/3
Michael Oehlhof [Sat, 16 Dec 2017 11:40:35 +0000 (12:40 +0100)]
[BUGFIX] EXT:scheduler: Update Documentation version

Resolves: #83351
Releases: 7.6
Change-Id: I62793199cbbd0c2745fd357563c69f1196911c8c
Reviewed-on: https://review.typo3.org/55110
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] Replace PHP 7.2 deprecated each() 84/55084/2
Patrick Schriner [Thu, 14 Dec 2017 09:19:51 +0000 (10:19 +0100)]
[BUGFIX] Replace PHP 7.2 deprecated each()

each() is deprecated in PHP 7.2 and has to be replaced.

Resolves: #83321
Releases: master, 8.7, 7.6
Change-Id: Ic318b50a9921cd6a55435cc9b2e0b254e61b9dbc
Reviewed-on: https://review.typo3.org/55084
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
16 months ago[BUGFIX] Read TER XML entity value complete 58/55058/2
Alexander Opitz [Tue, 5 Dec 2017 12:46:27 +0000 (13:46 +0100)]
[BUGFIX] Read TER XML entity value complete

Improve reading the TER XML file while using the php xml extension.
The character data handler could be called multiple times, so we
shouldn't cut previous data away.

Resolves: #83227
Releases: master, 8.7, 7.6
Change-Id: I9e96ade88da6a4709d1f72cd49fe766758d265fe
Reviewed-on: https://review.typo3.org/55058
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
16 months ago[BUGFIX] Make recycler PHP 7.2 compatible 47/55047/2
Stefan Neufeind [Tue, 12 Dec 2017 13:12:53 +0000 (14:12 +0100)]
[BUGFIX] Make recycler PHP 7.2 compatible

Change-Id: I36167b0a8b61532adbafea93c88c93097ea52d73
Resolves: #83297
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55042
Reviewed-on: https://review.typo3.org/55047
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] Do not reprocess image preview when empty configuration is passed 40/55040/2
Tymoteusz Motylewski [Mon, 27 Nov 2017 21:09:52 +0000 (22:09 +0100)]
[BUGFIX] Do not reprocess image preview when empty configuration is passed

Fixes regression introduced in https://review.typo3.org/53399
Where thumbnail was regenerated every time process was called with
empty configuration like:

$fileObject->process(ProcessedFile::CONTEXT_IMAGEPREVIEW, [])

Resolves: #83242
Relates: #81776
Releases: master, 8.7, 7.6
Change-Id: I6a4c331bad4d80225d3914f1a48f6071b0d87380
Reviewed-on: https://review.typo3.org/55040
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
16 months ago[BUGFIX] Use correct path variable on Windows 25/55025/2
Nicole Cordes [Wed, 6 Dec 2017 00:19:02 +0000 (01:19 +0100)]
[BUGFIX] Use correct path variable on Windows

There is a difference between Apache and CLI exposing global path
configuration on Windows Systems. The CommandUtility uses the global
path to initialize an internal path storage for possible command
resources. The patch ensures both possible keys on Windows systems are
taken into account to resolve possible application locations.

Resolves: #83234
Releases: master, 8.7, 7.6
Change-Id: Id7166042e39c4f468c10c1c489c7fe5beae7a5fc
Reviewed-on: https://review.typo3.org/55025
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
16 months ago[FOLLOWUP][BUGFIX] Make category tree filterable for editors 78/54978/2
Christoph Lehmann [Thu, 7 Dec 2017 21:53:35 +0000 (22:53 +0100)]
[FOLLOWUP][BUGFIX] Make category tree filterable for editors

Check if TCEFORM.pages.categories.config.treeConfig.rootUid
itself is in the users category mounts (no need for a pseudo
parent category)

Resolves: #83257
Releases: master,8.7,7.6
Change-Id: I8a60860ee3a22d68964f4e44018f0962f7f0f278
Reviewed-on: https://review.typo3.org/54978
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
16 months ago[BUGFIX] Output correct max upload size 39/54939/2
Alexander Opitz [Wed, 6 Dec 2017 00:10:24 +0000 (01:10 +0100)]
[BUGFIX] Output correct max upload size

We should show what the max upload file size is and not the max size of
a HTTP post body.

Resolves: #83230
Releases: master, 8.7, 7.6
Change-Id: Ib6fa244b19c434417808bb19126f862cf9418fb0
Reviewed-on: https://review.typo3.org/54939
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
16 months ago[TASK] Consistenly update to 2.8.x branch of Symfony packages 32/54932/3
Helmut Hummel [Mon, 4 Dec 2017 19:38:26 +0000 (20:38 +0100)]
[TASK] Consistenly update to 2.8.x branch of Symfony packages

To ensure PHP 5.5.0 compatibility as stated in our version constraints,
we limit updating package dependencies within our shipped code
to this PHP version.

Additionally we update these packages to their latest version

Composer commands used:

composer up symfony/console symfony/finder
composer req symfony/debug:^2.7
composer req --dev symfony/stopwatch:^2.8 symfony/process:^2.8 \
  symfony/options-resolver:^2.8 symfony/filesystem:^2.8 \
  symfony/event-dispatcher:^2.8 symfony/yaml:^2.8
composer config platform.php 5.5
composer up --lock

Releases: 7.6
Resolves: #83223
Change-Id: Idb271d632bf472705a3e887c1405fcffb282cb05
Reviewed-on: https://review.typo3.org/54932
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
16 months ago[CLEANUP] Add class-imports in Extbase Persistence classes 01/54901/2
Markus Klein [Fri, 1 Dec 2017 21:54:25 +0000 (22:54 +0100)]
[CLEANUP] Add class-imports in Extbase Persistence classes

This cleanup should ease backporting future patches in that area.

Releases: master, 8.7, 7.6
Resolves: #83189
Change-Id: I42b700d2fd17beadc4a9b8e64e500f3d3b93fd1f
Reviewed-on: https://review.typo3.org/54901
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
16 months ago[TASK] bamboo v7: Include php 7.2 in test suite 28/54928/3
Christian Kuhn [Sun, 3 Dec 2017 21:04:55 +0000 (22:04 +0100)]
[TASK] bamboo v7: Include php 7.2 in test suite

Run core v7 acceptance, unit and lint tests on php 7.2, too.

Change-Id: I2db7c3fb6cde92c6d2d0320ba39343679e57e126
Resolves: #83215
Releases: 7.6
Reviewed-on: https://review.typo3.org/54928
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[TASK] Update typo3/cms-composer-installers from 1.3.1 to 1.3.2 30/54930/3
Christian Kuhn [Mon, 4 Dec 2017 17:27:27 +0000 (18:27 +0100)]
[TASK] Update typo3/cms-composer-installers from 1.3.1 to 1.3.2

The update brings patches for PHP 7.2 compatibility.

Change-Id: Ibdfc231cd336511e0327eae485003d818fd1cc1e
Resolves: #83222
Releases: 7.6
Reviewed-on: https://review.typo3.org/54930
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[TASK] Update php-cs-fixer from 2.0.0 to 2.2.x 18/54818/4
Auer, Fabian [Mon, 27 Nov 2017 16:19:36 +0000 (17:19 +0100)]
[TASK] Update php-cs-fixer from 2.0.0 to 2.2.x

Latest 2.2 branch of the require-dev dependency of
php-cs-fixer brings PHP 7.2 compatibility.
The core has this dependency to run the cglFixMyCommit.sh
script which needs a slight adaption with the version raise.

Change-Id: I5c80b80716fdfa076ca77d281587cbb9c8d1068d
Resolves: #83220
Releases: 7.6
Reviewed-on: https://review.typo3.org/54818
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] fluid: Harden CountViewHelper 27/54927/2
Christian Kuhn [Sun, 3 Dec 2017 20:30:35 +0000 (21:30 +0100)]
[BUGFIX] fluid: Harden CountViewHelper

The CountViewHelper calls count() on non-arrays or non-Countable
objects. This throws warnings on PHP 7.2 - sanitize this call.

Change-Id: Ie1932c31a099577cb0d344824a6441509aefbc03
Resolves: #83214
Releases: 7.6
Reviewed-on: https://review.typo3.org/54927
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] Incomplete mocks in fluid tests 26/54926/2
Christian Kuhn [Sun, 3 Dec 2017 20:27:59 +0000 (21:27 +0100)]
[BUGFIX] Incomplete mocks in fluid tests

Sanitize some view helper unit tests to not trigger
PHP 7.2 warnings count()'ing non-arrays by proper mocking.

Change-Id: I9929a02a03c9218ab73838f4a214165333d414aa
Resolves: #83213
Releases: 7.6
Reviewed-on: https://review.typo3.org/54926
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] Unit tests: Define TYPO3_REQUESTTYPE 25/54925/3
Christian Kuhn [Sun, 3 Dec 2017 19:48:21 +0000 (20:48 +0100)]
[BUGFIX] Unit tests: Define TYPO3_REQUESTTYPE

Unit test boostrap does not initialize constants
TYPO3_REQUESTTYPE and TYPO3_REQUESTTYPE_*, but various
tests rely on this basic constants being properly defined
in core v7. With PHP 7.2, accessing undefined connstants
throws warnings.
Patch makes according bootstrap method public and calls
it during unit test bootstrap.

Change-Id: I450e440694385244c554adef00a9c74135d457f5
Resolves: #83211
Releases: 7.6
Reviewed-on: https://review.typo3.org/54925
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
16 months ago[BUGFIX] Undefined constant ADODB_ASSOC_CASE 24/54924/2
Christian Kuhn [Sun, 3 Dec 2017 19:21:18 +0000 (20:21 +0100)]
[BUGFIX] Undefined constant ADODB_ASSOC_CASE

adodb (v7 only) expects constant ADODB_ASSOC_CASE to be
set. PHP 7.2 now throws warnings if constants are not
defined.
Patch defines ADODB_ASSOC_CASE in unit test setUp() if
it not has been defined before.

Change-Id: Ie338c3e871ae0eb2f8536515c65b556381bf65c3
Resolves: #83210
Releases: 7.6
Reviewed-on: https://review.typo3.org/54924
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] Undefined constant OCI_COMMIT_ON_SUCCESS 23/54923/2
Christian Kuhn [Sun, 3 Dec 2017 18:43:38 +0000 (19:43 +0100)]
[BUGFIX] Undefined constant OCI_COMMIT_ON_SUCCESS

Test suite on core v7 with PHP 7.2 complains a lot about
"Undefined constant OCI_COMMIT_ON_SUCCESS". This is
found in the adodb oracle oci8 driver, used as property
default value and thus evaluated as soon as the driver class
is instantiated in tests.
The test suite does not include oci8 in php. The php module
sets constant OCI_COMMIT_ON_SUCCESS to hex '0x20' which is
32 in decimal.
The patch uses decimal 32 to suppress the warning if
oci8 module is not loaded for tests.

Change-Id: I218e9758fe8b1bf8a92a8398f6782faa4ed4c9c9
Resolves: #83209
Releases: 7.6
Reviewed-on: https://review.typo3.org/54923
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[TASK] Update phpdocumentor/type-resolver from 0.2 to 0.2.1 21/54921/2
Christian Kuhn [Sun, 3 Dec 2017 18:03:26 +0000 (19:03 +0100)]
[TASK] Update phpdocumentor/type-resolver from 0.2 to 0.2.1

Raising this indirect require-dev dependency fixes ~330
unit tests on PHP 7.2 that otherwise throw a count() on
non-array or countable warning.

Change-Id: I3dce8ffe6d2180bf41740b0bc5fd8397425cc985
Resolves: #83207
Releases: 7.6
Reviewed-on: https://review.typo3.org/54921
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] Use of undefined constant E_DEBUG 15/54915/2
Christian Kuhn [Sun, 3 Dec 2017 14:05:53 +0000 (15:05 +0100)]
[BUGFIX] Use of undefined constant E_DEBUG

Global function debug() initializes its 6th argument
to constant E_DEBUG which does not exist and then defaults
to string 'E_DEBUG'. This raises a PHP 7.2 warning.
Relevant for v8 & v7 only, this argument has been removed
in master already.
Fix by defaulting to string 'E_DEBUG' in method signature.

Change-Id: If04c9e55bb810980b19b924496680ea1758e4b24
Resolves: #83200
Related: #82640
Releases: 8.7, 7.6
Reviewed-on: https://review.typo3.org/54915
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] PreparedStatement: count() must be an array or countable 12/54912/2
Christian Kuhn [Sun, 3 Dec 2017 12:09:08 +0000 (13:09 +0100)]
[BUGFIX] PreparedStatement: count() must be an array or countable

Sanitize a count() call in PreparedStatement (8.7, 7.6 only)
for PHP 7.2 compatibility.

Change-Id: I8d3cac3814093c7223c6be8f8ab8dc8c610d28e1
Resolves: #83196
Releases: 8.7, 7.6
Reviewed-on: https://review.typo3.org/54912
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] phpunit: Update comparator from 1.2.2 to 1.2.4 10/54910/3
Christian Kuhn [Sun, 3 Dec 2017 11:50:40 +0000 (12:50 +0100)]
[BUGFIX] phpunit: Update comparator from 1.2.2 to 1.2.4

Raising this indirect require-dev dependency fixes a
PHP 7.2 compatibility issue on core 7.6 branch:
"Declaration of DOMNodeComparator::assertEquals() must be
compatible with ..."

Change-Id: I1c422edab82250b51ae9a0cc268110c62977ee08
Resolves: #83195
Resolves: #83120
Releases: 7.6
Reviewed-on: https://review.typo3.org/54910
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] Implicit constant to string cast in unit test case 05/54905/2
Christian Kuhn [Sat, 2 Dec 2017 01:24:18 +0000 (02:24 +0100)]
[BUGFIX] Implicit constant to string cast in unit test case

An array key is not used as string but as constant in
two ConfigurationManager test cases. PHP 7.2 is more
picky about this an throws warnings. Fix by creating
proper strings.

Change-Id: I64def6cf9b5d9df7e150d137929c721558c761d7
Resolves: #83190
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54905
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[BUGFIX] Fix wrong reference to language file in FileList class 00/54900/3
Wouter Wolters [Fri, 1 Dec 2017 20:43:51 +0000 (21:43 +0100)]
[BUGFIX] Fix wrong reference to language file in FileList class

During a backport of #80920 the file reference was not updated to
the right location.

Resolves: #83187
Releases: 7.6
Change-Id: I20637d1d1ee26f892084909c600cbe43a7c46a02
Reviewed-on: https://review.typo3.org/54900
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
16 months ago[BUGFIX] Make category tree filterable for editors with category mounts 38/54138/3
Christoph Lehmann [Wed, 13 Sep 2017 21:34:45 +0000 (23:34 +0200)]
[BUGFIX] Make category tree filterable for editors with category mounts

TCEFORM.pages.categories.config.treeConfig.rootUid should filter
the category tree. Non-Admin users with category mounts currently
need every child category of rootUid in their category mounts
since the rootline of rootUid is not checked against the category
mounts.

Resolves: #78274
Releases: master,8.7,7.6
Change-Id: Id02ae69111df7397207939a034ed05797eb160ad
Reviewed-on: https://review.typo3.org/54138
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
16 months ago[BUGFIX] Prevent catchable error during workspace publishing 55/54855/2
Benni Mack [Wed, 29 Nov 2017 09:50:58 +0000 (10:50 +0100)]
[BUGFIX] Prevent catchable error during workspace publishing

When publishing a workspace, incorrect TCA might lead to a catchable
fatal error. This happened, when TCA for a field did not contain a
config-entry.

Resolves: #77619
Releases: master, 8.7, 7.6
Change-Id: I81a3b727320ee984908c964d0729551c4c264f8d
Reviewed-on: https://review.typo3.org/54855
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
16 months ago[BUGFIX] Failing task "Fileadmin garbage collection" 39/54839/4
Sebastian Hofer [Tue, 28 Nov 2017 18:25:29 +0000 (19:25 +0100)]
[BUGFIX] Failing task "Fileadmin garbage collection"

Fix the identifier string, which is used to retrive the file object,
a relative path instead of an absolute path is expected.

Releases: 7.6
Fixes: #82672
Change-Id: I8786330f07996f1b341bb38fafa50709d364d25e
Reviewed-on: https://review.typo3.org/54839
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
16 months ago[BUGFIX] Send correct Cache-Control header if no client side caching 94/54794/2
Łukasz Uznański [Mon, 27 Nov 2017 12:20:45 +0000 (13:20 +0100)]
[BUGFIX] Send correct Cache-Control header if no client side caching

Add 'Cache-Control: no-store' if conditions allowing client caching
are not met. This change will prevent caching content by browser.

Resolves: #81160
Releases: master, 8.7, 7.6
Change-Id: Ia91a339178b8cd8387706679bbea40ed0d1b0548
Reviewed-on: https://review.typo3.org/54794
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
16 months ago[BUGFIX] bamboo: Label parsing 77/54777/2
Christian Kuhn [Mon, 27 Nov 2017 09:23:05 +0000 (10:23 +0100)]
[BUGFIX] bamboo: Label parsing

The bamboo test setup relies on a funny solution to determine the
gerrit patch id and patch set, used for reporting results back
to gerrit.

The regex based solution started behaving weird with latest
bamboo versions and is now quoted slightly differently to fix that.

Special thanks to atlassian support for being friendly, helpful,
quick and providing a working solution to our issue.

Change-Id: I51ec85be2133033777fac8ff1f12071a81c71efc
Resolves: #83107
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54777
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
16 months ago[FOLLOWUP][BUGFIX] Spaces between attributes in boolean fields 38/54738/2
Jigal van Hemert [Thu, 23 Nov 2017 22:46:19 +0000 (23:46 +0100)]
[FOLLOWUP][BUGFIX] Spaces between attributes in boolean fields

Spaces added between attributes of boolean input fields.

Resolves: #83040
Releases: 7.6
Change-Id: I28f24bbfbc46d992e452b7f0420c64575dda2df5
Reviewed-on: https://review.typo3.org/54738
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
16 months ago[BUGFIX] backend formfields: Make boolean fields UI working in Edge/IE 21/54721/2
Stefan Neufeind [Wed, 22 Nov 2017 08:40:37 +0000 (09:40 +0100)]
[BUGFIX] backend formfields: Make boolean fields UI working in Edge/IE

Add for/id so clicking the label toggles the checkbox.

Resolves: #83040
Releases: master, 8.7, 7.6
Change-Id: I3dc08706556e1a95ddc8d96cae705ee968c48326
Reviewed-on: https://review.typo3.org/54721
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
16 months ago[BUGFIX] Fix class name of success button in the install tool 98/54698/2
Markus Günther [Mon, 20 Nov 2017 10:46:09 +0000 (11:46 +0100)]
[BUGFIX] Fix class name of success button in the install tool

Releases: master, 8.7, 7.6
Fixes: #83044
Change-Id: I2c16f160a18f4c0e58b87261b59fbde90aca2f82
Reviewed-on: https://review.typo3.org/54698
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
17 months ago[BUGFIX] Show deleted page actions in record history 10/54610/2
Helmut Hummel [Tue, 7 Nov 2017 14:09:08 +0000 (15:09 +0100)]
[BUGFIX] Show deleted page actions in record history

Because users have no access to deleted pages,
the access check always fails, leading to delete page
actions not being shown in the history despite being
properly tracked.

We now check this case and do a more lightweight check
so that we still have the permissions checked,
but can show deleted pages without disclosing unwanted
information.

Resolves: #45056
Releases: 7.6, 8.7, master
Change-Id: Id919a24651c18a351f9723e86610b525a4f4726c
Reviewed-on: https://review.typo3.org/54610
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
17 months ago[BUGFIX] ConstantEditor: Make boolean fields UI working in Edge/IE 83/54683/2
Markus Klein [Sun, 19 Nov 2017 01:34:46 +0000 (02:34 +0100)]
[BUGFIX] ConstantEditor: Make boolean fields UI working in Edge/IE

Move the hidden form field out of the label tag to ensure clicking
the label's content (eg. fa icon) really toggles the checkbox.

Resolves: #82998
Releases: master, 8.7, 7.6
Change-Id: Id4293b4109c82a9e6410e113a5b5560ffd1b75d4
Reviewed-on: https://review.typo3.org/54683
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
17 months ago[BUGFIX] Add workspace overlay for translated page title 85/54585/2
Georg Ringer [Wed, 8 Nov 2017 07:21:39 +0000 (08:21 +0100)]
[BUGFIX] Add workspace overlay for translated page title

The title of a translated page must be overlayed with the
workspace version.

Resolves: #65607
Releases: master, 8.7, 7.6
Change-Id: If10260f196776a16a53968b78542827ecbc145fe
Reviewed-on: https://review.typo3.org/54585
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
17 months ago[BUGFIX] Handle returnUrl for access module 28/54528/2
Markus Klein [Mon, 30 Oct 2017 19:56:30 +0000 (20:56 +0100)]
[BUGFIX] Handle returnUrl for access module

With this fix the access module again returns to the correct
page the user expects it to return to.

Resolves: #82883
Releases: master, 8.7, 7.6
Change-Id: I76953aa1547365db6fbbea772d786e1ad9bfc184
Reviewed-on: https://review.typo3.org/54528
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
17 months ago[BUGFIX] Access module preselects owner/group when changed via AJAX 27/54527/3
Markus Klein [Mon, 30 Oct 2017 20:42:05 +0000 (21:42 +0100)]
[BUGFIX] Access module preselects owner/group when changed via AJAX

Resolves: #79915
Releases: master, 8.7, 7.6
Change-Id: Ie3b573857ff011295be198633a0f6868b1ff55b6
Reviewed-on: https://review.typo3.org/54527
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
17 months ago[BUGFIX] Add missing image for workspace preview 77/54477/2
Georg Ringer [Thu, 26 Oct 2017 12:41:23 +0000 (14:41 +0200)]
[BUGFIX] Add missing image for workspace preview

Readd an image which has been removed during cleanups

Resolves: #82857
Releases: 7.6
Change-Id: Idd487fec1d35dc919099bcf9477860976d346d38
Reviewed-on: https://review.typo3.org/54477
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[BUGFIX] Fix link rendering in li tag 65/54165/3
Sebastian Hofer [Mon, 18 Sep 2017 13:20:00 +0000 (15:20 +0200)]
[BUGFIX] Fix link rendering in li tag

Changes the rendering for li tags in RTE in sys ext css_styled_content.
This change is based on a former bugifx for TYPO3 6.2:
https://review.typo3.org/#/c/38681/

The fix was not ported to css_styled_content for TYPO3 7,
so the issue is present in TYPO3 7 if no fluid_styled_content
TypoScript is present.

Releases: 7.6
Resolves: #65506
Change-Id: I1aa744b7f381681a01cb797ff6dd9c61f221934a
Reviewed-on: https://review.typo3.org/54165
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
18 months ago[BUGFIX] CSC Header CE does not respect lib.parseTarget configuration 30/54430/4
Harry Glatz [Sat, 3 Sep 2016 09:59:38 +0000 (11:59 +0200)]
[BUGFIX] CSC Header CE does not respect lib.parseTarget configuration

The TypoScript of the CSC header element does not respect
the global lib.parseTarget configuration

Resolves: #36216
Releases: 8.7, 7.6
Change-Id: I08ea6c59829a4a63b4aca6bf90b89223921b3fdf
Reviewed-on: https://review.typo3.org/54430
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
18 months ago[BUGFIX] Fix declaration of injectView in install tool 17/54417/5
Susanne Moog [Tue, 17 Oct 2017 16:22:08 +0000 (18:22 +0200)]
[BUGFIX] Fix declaration of injectView in install tool

When using PHP7 declarations of sub classes have to
be compatible to their parent declarations.

As the install tool has been completely refactored in
newer TYPO3 version this patch implements only a
workaround to prevent the PHP warning.

Change-Id: I4128b3aef30a3a1bb9de6188509db1cdf4314b02
Resolves: #77203
Releases: 7.6
Reviewed-on: https://review.typo3.org/54417
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
18 months ago[FOLLOWUP][BUGFIX] IRRE: Check if TCA['ctrl']['languageField'] is set 70/54170/5
Nicole Cordes [Tue, 19 Sep 2017 13:06:41 +0000 (15:06 +0200)]
[FOLLOWUP][BUGFIX] IRRE: Check if TCA['ctrl']['languageField'] is set

This patch adds missing functional tests for
\TYPO3\CMS\Backend\Controller\FormInlineAjaxController::createAction

Related: #82330
Releases: master, 8.7, 7.6
Change-Id: I61c8c07dd0d2c6a92bb445d7f2b6baee23251f5d
Reviewed-on: https://review.typo3.org/54170
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[BUGFIX] Configuration->"Use regular expression" 80/54380/2
Christian Kuhn [Thu, 12 Oct 2017 12:43:20 +0000 (14:43 +0200)]
[BUGFIX] Configuration->"Use regular expression"

Setting / unsetting the checkbox "Use regular expression"
fails with JavaScript error "jumpToUrl is not defined".
Add that to the document body.

Change-Id: I0a5928e008972493d070a35d1219a0acca579ce8
Resolves: #82746
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54380
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Add page uid to rte module urls for correct TSconfig loading 56/52756/2
Marc Bastian Heinrichs [Thu, 11 May 2017 08:48:38 +0000 (10:48 +0200)]
[BUGFIX] Add page uid to rte module urls for correct TSconfig loading

Because of a missing page uid in rte module window iframe urls, like for
the BrowseLinks popup, the ConditionMatcher could not evaluate
conditions in INCLUDE_TYPOSCRIPT that rely on the page uid, like
PIDinRootline.

Resolves: #81190
Releases: 7.6
Change-Id: I7952b910d9caa50ce5ca1abd6bf7309ad80c60b1
Reviewed-on: https://review.typo3.org/52756
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Correct an always-true if statement in GeneralUtility::mkdir_deep 31/54331/2
Joshua Westerheide [Sat, 7 Oct 2017 18:45:53 +0000 (20:45 +0200)]
[BUGFIX] Correct an always-true if statement in GeneralUtility::mkdir_deep

Resolves: #82697
Releases: master, 8.7, 7.6
Change-Id: I64bf51d5efd0394f4d3269965820281cbaf2de90
Reviewed-on: https://review.typo3.org/54331
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[TASK] bamboo-specs: Upgrade to 6.1 99/54299/2
Christian Kuhn [Wed, 4 Oct 2017 21:02:31 +0000 (23:02 +0200)]
[TASK] bamboo-specs: Upgrade to 6.1

The 6.0 to 6.1 upgrade allows us to specifiy last missing
pieces via bamboo specs: mostly job cleanups, plugin
configuration and plan permissions.

Change-Id: If26aeb45b1109ba9797f3807087201033ea1f368
Resolves: #82679
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54299
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[TASK] Increase size of domain name field 91/54191/3
Georg Ringer [Wed, 20 Sep 2017 18:19:39 +0000 (20:19 +0200)]
[TASK] Increase size of domain name field

Allow 255 chars for a domain to be in sync with RFC 1035.

Resolves: #82515
Releases: master, 8.7, 7.6
Change-Id: I63916cb115b00e50c62c1926cf890e29bf89de77
Reviewed-on: https://review.typo3.org/54191
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
18 months ago[BUGFIX] Fix broken redis tests 97/54197/2
Frank Naegler [Thu, 21 Sep 2017 10:09:19 +0000 (12:09 +0200)]
[BUGFIX] Fix broken redis tests

Resolves: #82533
Releases: master, 8.7, 7.6
Change-Id: Ia47f604b9cb7fa53d3707e6150554709cbfdb763
Reviewed-on: https://review.typo3.org/54197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Do not allow users to edit doktypes without permissions 15/53715/3
Markus Hoelzle [Wed, 22 Feb 2017 09:27:49 +0000 (10:27 +0100)]
[BUGFIX] Do not allow users to edit doktypes without permissions

Disallow backend users to edit pages which doktypes are not allowed
via backend usergroup permissions.

Resolves: #79954
Releases: master, 8.7, 7.6
Change-Id: I527602e71c62bc8e33b0886a5758c7c8040b4720
Reviewed-on: https://review.typo3.org/53715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Set TYPO3 version to 7.6.24-dev 69/54169/2
Oliver Hader [Tue, 19 Sep 2017 13:03:21 +0000 (15:03 +0200)]
[TASK] Set TYPO3 version to 7.6.24-dev

Change-Id: I2ac58940eef04059791b3ef8b76f7c2223e15b28
Reviewed-on: https://review.typo3.org/54169
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[RELEASE] Release of TYPO3 7.6.23 68/54168/2 7.6.23 TYPO3_7-6-23 v7.6.23
Oliver Hader [Tue, 19 Sep 2017 13:01:22 +0000 (15:01 +0200)]
[RELEASE] Release of TYPO3 7.6.23

Change-Id: I8ec14f6fd21ec2757988c13f1612348998d198c5
Reviewed-on: https://review.typo3.org/54168
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] IRRE: Check if TCA['ctrl']['languageField'] is set 44/53944/5
Oliver Hader [Tue, 19 Sep 2017 10:58:13 +0000 (12:58 +0200)]
[BUGFIX] IRRE: Check if TCA['ctrl']['languageField'] is set

On creating child records for an inline field, the values of
TCA['ctrl']['languageField'] configuration of parent and child
records are used without checking if they are set at all.
This patch adds appropriate guards.

Resolves: #82330
Releases: 7.6
Change-Id: I6383e55820239b0363ff890855430ac32e2cdf62
Reviewed-on: https://review.typo3.org/53944
Reviewed-by: Tobias Liebig <tobias.liebig@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Correctly handle non-existing level in menu.directory VH 67/54167/2
Markus Klein [Tue, 19 Sep 2017 10:23:56 +0000 (12:23 +0200)]
[BUGFIX] Correctly handle non-existing level in menu.directory VH

Providing a non-existing entry-level to the getPageUids() method
now returns an empty array instead of an array with key zero and
a null value.

This way we can correctly stop processing in the viewhelpers
using the MenuViewHelperTrait.

Resolves: #82507
Releases: 7.6
Change-Id: I99a610e612545648d7637e4a441dcdd1b1e51adc
Reviewed-on: https://review.typo3.org/54167
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>