Packages/TYPO3.CMS.git
2 years ago[TASK] bamboo: Add a nightly build plan spec 04/53304/3
Christian Kuhn [Wed, 21 Jun 2017 11:36:42 +0000 (13:36 +0200)]
[TASK] bamboo: Add a nightly build plan spec

Configures a second build for core master that
runs as nightly plan and has more combinations:
The acceptance and functionals are explicitly
executed on both php 7.0 and 7.1 with all DBMS,
the cgl checker runs through whole core.
This "full run" is too much for pre-merge tests,
so the nightly now takes care of these time
consuming things.
Reporting will be added if that plan is stable.
https://bamboo.typo3.com/browse/CORE-GTN

Change-Id: Id77fc0acceca7af67960b67fd8b8700c98df888e
Resolves: #81660
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53304
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix namespace of `SaltedPasswordsUtility` in documentation 00/53300/2
Andreas Fernandez [Wed, 21 Jun 2017 14:55:43 +0000 (16:55 +0200)]
[BUGFIX] Fix namespace of `SaltedPasswordsUtility` in documentation

Resolves: #81655
Releases: master, 8.7, 7.6
Change-Id: I4fe1b16b6e4c2bdd26fd05143e7b0ead91445223
Reviewed-on: https://review.typo3.org/53300
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Stabilize a flaky unit test 97/53297/2
Christian Kuhn [Wed, 21 Jun 2017 11:09:22 +0000 (13:09 +0200)]
[BUGFIX] Stabilize a flaky unit test

getParseTimeReturnsZeroIfNoValuesAreSet() tends to fail sometimes
if $beUserInitialization is > 0 but $totalParseTime is 0. This
edge case of method getParseTime() is avoided by rearranging the call
order of $this->getMilliseconds() slightly.

Change-Id: If5cf00196f6739224c34011b0f8c1ef1f5bbb39a
Resolves: #81653
Related: #80742
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53297
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Tested-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] Fix checking config.metaCharset with uppercase letters 91/53291/3
Stephan Großberndt [Tue, 20 Jun 2017 16:25:56 +0000 (18:25 +0200)]
[BUGFIX] Fix checking config.metaCharset with uppercase letters

Releases: master, 8.7
Resolves: #81634
Change-Id: I48bc1885aec47a4dcc66bf556cd69d50a7781fd5
Reviewed-on: https://review.typo3.org/53291
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] bamboo: Allow mssql+postgres builds on both php 7.0 & 7.1 92/53292/2
Christian Kuhn [Tue, 20 Jun 2017 16:48:10 +0000 (18:48 +0200)]
[TASK] bamboo: Allow mssql+postgres builds on both php 7.0 & 7.1

Change-Id: I240ed28992cea31e04aa7451ef609c68eade7782
Resolves: #81635
Releases: master
Reviewed-on: https://review.typo3.org/53292
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Ensure links with ampersands are HSC-decoded 68/53268/4
Benni Mack [Tue, 20 Jun 2017 08:08:51 +0000 (10:08 +0200)]
[BUGFIX] Ensure links with ampersands are HSC-decoded

Since the new link structure is in place with TYPO3 v8
all links are properly htmlspecialchar'ed in the database.

This means, that links with an ampersand are now encoded
and need to be decoded on output so ampersands are rendered
as "&" and not as "&amp;" in the frontend.

Resolves: #80985
Resolves: #81625
Releases: master, 8.7
Change-Id: I213f84453a721b97c3238662febe10d0fb5a9bf7
Reviewed-on: https://review.typo3.org/53268
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Populate loaded commands after ext_tables is loaded 70/53270/2
Benni Mack [Tue, 20 Jun 2017 09:00:58 +0000 (11:00 +0200)]
[BUGFIX] Populate loaded commands after ext_tables is loaded

Especially in TYPO3 v8, where TCA is not loaded at all times,
running a CLI command with an empty cache will result in
errors, but for the sake of clean structure, the commands
will be populated when executing the actual command.

Resolves: #80897
Releases: master, 8.7
Change-Id: I7ad33ca86724d94f451c44f68538d5d38e343636
Reviewed-on: https://review.typo3.org/53270
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prevent uncaught exception in Import/Export controller 63/52363/5
Nicole Cordes [Tue, 4 Apr 2017 13:26:43 +0000 (15:26 +0200)]
[BUGFIX] Prevent uncaught exception in Import/Export controller

Currently an error is thrown if no post data was sent to the
ImportExportController. This can easily happen if a t3d file should
be uploaded but is larger than the configured post_max_size of the
server. This patch checks the incoming information, sets the import
action as default and displays an information to the user that he/she
may have tried to upload a file that was too large.

Resolves: #80681
Releases: master, 8.7, 7.6
Change-Id: I561dbf6abd74acace3eff179a513b4f9128d792d
Reviewed-on: https://review.typo3.org/52363
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Select suitable distribution version in em 62/53262/4
Christian Kuhn [Sun, 18 Jun 2017 11:48:56 +0000 (13:48 +0200)]
[BUGFIX] Select suitable distribution version in em

The distribution installer selects current_version=1
extensions only and fails in core v7 since the current
introduction version is not compatible with v7 anymore.

The patch changes version selection a bit to first find
all distribution extensions, then filters those suitable
for given core version, then filters latest version of
the distribution extension.

Installing introduction package in 7.6 works again.

Change-Id: I11f2def2ea606ada5f7c3efd3043f59bd4be0452
Resolves: #81068
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53262
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Skip quoted fields in insertData 72/53172/7
Jigal van Hemert [Thu, 8 Jun 2017 21:22:44 +0000 (23:22 +0200)]
[BUGFIX] Skip quoted fields in insertData

While parsing the input value for expressions inside curly brackets
it must skip quoted field names which are also in curly brackets
but start with a '#'.

Resolves: #81492
Related: #80506
Releases: master, 8.7
Change-Id: Ic58fcdcbb68108ac77da746db3e6a442515ce7ea
Reviewed-on: https://review.typo3.org/53172
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Tested-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Revert "Port RteLinkBrowser to TypeScript" 74/53274/3
Benni Mack [Tue, 20 Jun 2017 09:48:11 +0000 (11:48 +0200)]
[TASK] Revert "Port RteLinkBrowser to TypeScript"

This change introduced a flaw in the RteLinkBrowser JS file
which needs to override LinkBrowser class instead of just
writing RteLinkBrowser.

See https://review.typo3.org/#/c/53062/
This reverts commit c5d75c151cdd23ed24ea0acd9e01767054ac7353.

Resolves: #81630
Reverts: #81444
Releases: master
Change-Id: I4a3a9dc52bd6b9cee183ba6411389e8da2eebd21
Reviewed-on: https://review.typo3.org/53274
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Avoid redundant SQL queries in ReferenceIndex 66/50566/71
Claus Due [Thu, 10 Nov 2016 10:50:20 +0000 (11:50 +0100)]
[BUGFIX] Avoid redundant SQL queries in ReferenceIndex

Change methods inside ReferenceIndex to allow them to receive an
existing record as array rather than a UID to avoid each method loading
it from the database again to read record or record fields.

For a copy operation on 25 pages with ~100 content elements total there
are 1,500 SQL queries less leading to a ~40% time reduction and
~10% memory reduction.

Change-Id: I0ed05478dfbc0535efc8d1d29b6a8298d475fb6b
Releases: master, 8.7
Resolves: #78634
Reviewed-on: https://review.typo3.org/50566
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Tested-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[CLEANUP] Wrap doesRecordExist in new method 47/51447/55
Thomas Hohn [Fri, 27 Jan 2017 11:11:45 +0000 (12:11 +0100)]
[CLEANUP] Wrap doesRecordExist in new method

Wraps the functionality from doesRecordExist
in a new method recordInfoWithPermissionCheck.

The goal is a general cleanup and avoid unnecessary
calls to the database in the case where the actual
record is re-fetched from the database for processing
just after a doesRecordExist call.

Resolves: #79515
Releases: master, 8.7
Change-Id: I76d217a1690ee4b97e28b83f7591ebf8cba18e6e
Reviewed-on: https://review.typo3.org/51447
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Fix wrong parameter type 60/53260/3
Henrik Elsner [Mon, 19 Jun 2017 10:56:00 +0000 (12:56 +0200)]
[BUGFIX] Fix wrong parameter type

The quoting parameter constants \PDO::PARAM_* are in fact integers. The
annotation shipped with doctrine says string, and the strict type
processing in core leads to a wrong parameter error.
Changing the strict type to int, as would be correct, solves the problem.

Releases: master, 8.7
Resolves: #81613
Change-Id: Ic327b2d761b74868cc46d781acab1f4fd9e6cfdb
Reviewed-on: https://review.typo3.org/53260
Reviewed-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Tested-by: Anja Leichsenring <anja.leichsenring@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] FormEngine creating section container in new record 15/53215/3
Christian Kuhn [Wed, 14 Jun 2017 18:55:23 +0000 (20:55 +0200)]
[BUGFIX] FormEngine creating section container in new record

If a records has not been persisted and a flex section container
is added, the form compiler needs the "NEW123" uid of parent to
prefix form fields correctly.

Change-Id: Iab3945efa93d2becf636c5cf4f8596bc696cd2e0
Resolves: #80825
Related: #80100
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53215
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[FEATURE] Add possibility to write tests in TypeScript 48/53248/3
Susanne Moog [Sun, 18 Jun 2017 09:53:00 +0000 (11:53 +0200)]
[FEATURE] Add possibility to write tests in TypeScript

Adjust grunt and tsconfig to allow writing unit tests
in TypeScript. Test example is included.

Additionally configuration was adjusted to allow running
grunt tasks on windows and linux.

Change-Id: Ibeb0c501242afbbe796726a85329d14257acfd1c
Resolves: #81601
Releases: master
Reviewed-on: https://review.typo3.org/53248
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[!!!][TASK] Always throw exception if a userFunc does not exist 96/50996/9
Andreas Fernandez [Mon, 19 Dec 2016 15:31:49 +0000 (16:31 +0100)]
[!!!][TASK] Always throw exception if a userFunc does not exist

The parameter `$errorMode` is removed from the method
`GeneralUtility::callUserFunction()`. Thus, the checks agains this
variable are removed as well, causing exceptions being always thrown now.

Resolves: #74533
Releases: master
Change-Id: Ibf8b0c9de55b4d8d210dac8fc6c82b14ca7c849d
Reviewed-on: https://review.typo3.org/50996
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] Move service report from EXT:sv to EXT:reports 63/53163/10
Georg Ringer [Wed, 7 Jun 2017 15:27:31 +0000 (17:27 +0200)]
[!!!][TASK] Move service report from EXT:sv to EXT:reports

Move the report as a first step to get rid of EXT:sv.

Resolves: #81536
Releases: master
Change-Id: I46e38b5c4bf8d5466e1bcc1db510b1cd660a7b38
Reviewed-on: https://review.typo3.org/53163
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] rte_ckeditor triggers has-change on change 68/52968/4
Ralf Hettinger [Mon, 29 May 2017 20:38:43 +0000 (22:38 +0200)]
[BUGFIX] rte_ckeditor triggers has-change on change

CKEditor fields now triggers FormEngine.Validation.markFieldAsChanged
therefore a warning of unsaved changes on closing the form is raised
based on changes within these CKEditor fields.

Resolves: #68955
Releases: master, 8.7
Change-Id: I0da98c2204b20b0f6cd27a53b66f2df3d369a145
Reviewed-on: https://review.typo3.org/52968
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FOLLOWUP][BUGFIX] Use mb_* methods directly instead of CharsetConverter 45/53245/2
Benni Mack [Sat, 17 Jun 2017 19:33:07 +0000 (21:33 +0200)]
[FOLLOWUP][BUGFIX] Use mb_* methods directly instead of CharsetConverter

Fixing one issue with the wrong variable name.

Resolves: #81575
Releases: master, 8.7
Change-Id: I820a3bcfc9a250a35ca2bec69b71a40fc7c8d01a
Reviewed-on: https://review.typo3.org/53245
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Deprecate DocumentTemplate::formWidth() 85/53185/3
Georg Ringer [Sun, 11 Jun 2017 16:59:34 +0000 (18:59 +0200)]
[TASK] Deprecate DocumentTemplate::formWidth()

The method DocumentTemplate::formWidth() is not needed anymore as
the styling can be done by using bootstrap and regular CSS classes.

Resolves: #81540
Releases: master
Change-Id: Id767665e71afc454f04002b6989876ca28354fe3
Reviewed-on: https://review.typo3.org/53185
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Use the correct named parameter type in Extbase queries 02/52802/14
Christian Toffolo [Sun, 14 May 2017 12:24:25 +0000 (14:24 +0200)]
[BUGFIX] Use the correct named parameter type in Extbase queries

In Extbase query expressions the second operand is converted to a plain
value which is either an integer or a string. This type must also be
specified when creating a named parameter in the query.

Resolves: #79473
Resolves: #80978
Resolves: #81487
Resolves: #81019
Resolves: #81056
Releases: master, 8.7
Change-Id: I835643653e03b98bfcd5a8b35b5de750641ecb79
Reviewed-on: https://review.typo3.org/52802
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Port RteLinkBrowser to TypeScript 62/53062/6
Johannes Goslar [Fri, 2 Jun 2017 20:01:30 +0000 (22:01 +0200)]
[TASK] Port RteLinkBrowser to TypeScript

Resolves: #81444
Releases: master
Change-Id: I7247ef2c88ff60c484c3ca7ff0af48d3b8e72aac
Reviewed-on: https://review.typo3.org/53062
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Fix DB error handling in FrontendUserImageUpdateWizard 30/53130/2
Morton Jonuschat [Tue, 6 Jun 2017 03:45:19 +0000 (20:45 -0700)]
[BUGFIX] Fix DB error handling in FrontendUserImageUpdateWizard

The errorCode() method returns a string representation of the error that happened.
Comparing this to an integer value to determine is not reliable. In addition Doctrine
throws Exceptions when database statements fail so this part of the code could not be
reached.
Catch the DBALException, extract the error message and let the re-raised extension
bubble up to show the actual error message to the user.

Change-Id: I042b94329e3d52f9520ded812247ee78a73ea402
Resolves: #79870
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53130
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Respect selected page in recursive record list search 73/52873/6
Sascha Egerer [Sat, 20 May 2017 06:56:15 +0000 (08:56 +0200)]
[BUGFIX] Respect selected page in recursive record list search

The backend list view must respect the selected pages even if the search
level is set to infinite. This bug was introduced by the Doctrine
migration.

Resolves: #81278
Releases: master,8.7
Change-Id: I6ab0e93a019a001f9df08e00c01f7525a6621284
Reviewed-on: https://review.typo3.org/52873
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Remove superfluous extbase TS option 35/53235/2
Benni Mack [Fri, 16 Jun 2017 11:03:46 +0000 (13:03 +0200)]
[BUGFIX] Remove superfluous extbase TS option

When removing the extbase query cache in 8.3, the TypoScript option
was not removed which has no effect anymore since then.

Resolves: #77460
Releases: master, 8.7
Change-Id: I72d3907fd1c3aa302a03cc1f41bfe28b97020216
Reviewed-on: https://review.typo3.org/53235
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Streamline bool arguments throughout the core 36/53236/2
Benni Mack [Fri, 16 Jun 2017 11:10:03 +0000 (13:10 +0200)]
[BUGFIX] Streamline bool arguments throughout the core

There are still places left in TYPO3 where methods are called with
integers as parameters, although they are marked as boolean.

These places are changed to the correct and necessary value.

Resolves: #81595
Releases: master, 8.7
Change-Id: I1664e7d5e3962f0d2cf59ba6148812291d0b803b
Reviewed-on: https://review.typo3.org/53236
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Have bamboo test plans as files 25/53225/6
Christian Kuhn [Thu, 15 Jun 2017 17:08:27 +0000 (19:08 +0200)]
[TASK] Have bamboo test plans as files

Atlassian bamboo allows to define test plans in
files since version 6. The test plans are based on
rather simple Java files.
The patch delivers build information of
default core pre-merge plan.
Changes of bamboo test configuration for these plans
are now coordinated via casual patch requests and can
be reviewed just as all other code.
This adds full transparency on what exactly the core
test environment does and can be used by others as
reference for local execution and extension test plan
boilerplates.
Upload to bamboo.typo3.com to update test plans can
be done by a bamboo administrator.

Change-Id: I756cb65eba3a58e9edf0995aa9f1f2d4f96f7926
Resolves: #81589
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53225
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] AdminPanel: Change fields for simulate time 30/53230/3
Thorben Nissen [Fri, 16 Jun 2017 06:32:19 +0000 (08:32 +0200)]
[BUGFIX] AdminPanel: Change fields for simulate time

When entering a date string in the admin panel to simulate a certain
date/time and clicking the "update" button an exception it thrown. Due to
the names and ordering of the fields, the timestamp from the hidden field
gets overridden by the date string.

Move the hidden timestamp field after the human readable date string field
to avoid the timestamp being overridden by the date string. Add a comment
to explain the ordering and avoid future changes.

Resolves: #81174
Releases: master, 8.7
Change-Id: I87236c9b8ef84dabb3ec63e0530f14582ecbe6fe
Reviewed-on: https://review.typo3.org/53230
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Add missing format.case capitalWords mode 21/53221/3
Benni Mack [Thu, 15 Jun 2017 14:26:37 +0000 (16:26 +0200)]
[BUGFIX] Add missing format.case capitalWords mode

The mode "capitalWords" was just a todo statement that indicated a
missing implementation.
The implementation is now added.

Resolves: #81588
Releases: master, 8.7
Change-Id: I12b733da703de34568c6b79c083031f0333cdb92
Reviewed-on: https://review.typo3.org/53221
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Use mb_* methods directly instead of CharsetConverter 08/53208/6
Benni Mack [Wed, 14 Jun 2017 12:11:47 +0000 (14:11 +0200)]
[BUGFIX] Use mb_* methods directly instead of CharsetConverter

There are several places where mb_* methods are still not used, although
they are even better to use instead of the $csConv->parseCharset() method
for instance, as it has more aliases defined already.

Same goes for "entities_to_utf8" which is a PHP user-space implementation
of html_entity_decode() dated back to Kaspers' change in 2003.

Using native PHP methods should also increase performance marginally.

Resolves: #81575
Releases: master, 8.7
Change-Id: I5e97881cc7107883a5ff53d534161a7ec17e1ee5
Reviewed-on: https://review.typo3.org/53208
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Extbase: Remove invalid class ObjectManagerException 31/53231/3
Benni Mack [Fri, 16 Jun 2017 08:23:33 +0000 (10:23 +0200)]
[BUGFIX] Extbase: Remove invalid class ObjectManagerException

There is a class called "ObjectManagerException" which was
introduced very early with Extbase and was a clone of
the (now further developed) object manager.

It was originally used in the wrong place in workspaces
and then changed in workspaces to the real object manager
but the class was kept.

This class was then wrongly renamed in TYPO3 6.0 with the
change to namespaces and called "Exception" which it is
definitively NOT and thus, plain wrong in the place as it
is.

The class (and the interface) should be removed as it
is not just plain useless and a hard mistake we carried on
for 7 years now.

Resolves: #52825
Releases: master, 8.7
Change-Id: I615caaa9d297631a338ca6488bfe8e5c29594e3b
Reviewed-on: https://review.typo3.org/53231
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Include RSA JS in FE with relative URL 12/52112/4
Markus Klein [Tue, 21 Mar 2017 18:41:50 +0000 (19:41 +0100)]
[BUGFIX] Include RSA JS in FE with relative URL

Releases: master, 8.7
Resolves: #80952
Change-Id: I94a5124a16c9ad9893c1c2346967089fd16ad142
Reviewed-on: https://review.typo3.org/52112
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mario T <typoser@trashmail.de>
Tested-by: Mario T <typoser@trashmail.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FOLLOWUP][TASK] Deprecate render method arguments on ViewHelpers 99/53199/2
Claus Due [Tue, 13 Jun 2017 12:33:59 +0000 (14:33 +0200)]
[FOLLOWUP][TASK] Deprecate render method arguments on ViewHelpers

Followup patch to migrate f:widget.autocomplete which
had been missed by the previous patch.

Change-Id: I9e2552925df84f225144b1120a93bf65d9874047
Resolves: #81213
Releases: master
Reviewed-on: https://review.typo3.org/53199
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Better documentation of cObject viewhelper 88/53188/5
Markus Klein [Mon, 12 Jun 2017 09:26:15 +0000 (11:26 +0200)]
[BUGFIX] Better documentation of cObject viewhelper

Add more information about the table argument and when it should
be set.

Resolves: #81545
Releases: master, 8.7
Change-Id: Ic95794869b384e0932d59747df545f15afe2825f
Reviewed-on: https://review.typo3.org/53188
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Robert Wildling <robertwildling@gmail.com>
Tested-by: Robert Wildling <robertwildling@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Linkvalidator: Links (from rte) not detected correctly 92/52592/10
Thorben Nissen [Tue, 25 Apr 2017 07:15:11 +0000 (09:15 +0200)]
[BUGFIX] Linkvalidator: Links (from rte) not detected correctly

Due to the changed link syntax ("t3://...") instead of "<link ...>" the
links to files and internal pages are not recognised anymore. Furthermore
are external links now written with <a href="..."> and are therefore also
not recognized anymore.

Rewrite code for detecting "typolink_tags" correctly. When recognizing
urls, e.g. from "external url" pages or plain urls in texts, include https
and not only http and ftp.

Resolves: #80991
Resolves: #80988
Releases: master, 8.7
Change-Id: I5a9267b1d4ab53a6a39efdbd411e610dc9233ead
Reviewed-on: https://review.typo3.org/52592
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Tested-by: Christer V <cvi@systime.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix wrong markup of download icon in extension manager 16/53216/2
Georg Ringer [Wed, 14 Jun 2017 19:03:55 +0000 (21:03 +0200)]
[BUGFIX] Fix wrong markup of download icon in extension manager

Apply the classes 'btn btn-default' directly to the a tag instead
to have the full button area clickable.

Resolves: #81579
Releases: master, 8.7
Change-Id: Ib296d8e8e56c45d5d879cb7cb7a749b1c7141b2f
Reviewed-on: https://review.typo3.org/53216
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[FOLLOWUP][BUGFIX] Allow processing of multiple new record localizations 13/53213/3
Oliver Hader [Wed, 14 Jun 2017 16:28:59 +0000 (18:28 +0200)]
[FOLLOWUP][BUGFIX] Allow processing of multiple new record localizations

Complete data-map for a table is handed over in $idValues to
DataMapProcessor::fetchDependencies(string $tableName, array $ids),
but should only contain the id-values - either integer or string.

Resolves: #80239
Releases: master, 8.7
Change-Id: If12562dad839687b7d60855fa99d9ffc21bc1167
Reviewed-on: https://review.typo3.org/53213
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Allow processing of multiple new record localizations 71/52871/16
Oliver Hader [Tue, 13 Jun 2017 15:40:05 +0000 (17:40 +0200)]
[BUGFIX] Allow processing of multiple new record localizations

The current implementation of DataMapProcessor to determine the necessity
of synchronizing record localizations is too strict since it expects real
persisted database records and cannot resolve new records that have been
handed with the very same data-map to the DataHandler.

This mentioned constraint is resolved. Besides that, an additional value
processing for internal fields is added. This method resolves new record
ids to their real persisted UIDs using the famous remap stack. This only
is executed, if these fields have not been processed in a relation-aware
context and have a meaning to TYPO3 data-structures - for instance this
is the case for 'l10n_source' field defined as TCA type 'passthrough'.

Change-Id: Id1291910d85b3d314af7203314b8696a337fe364
Resolves: #80239
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52871
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Remove manually set database row 43/52543/3
Susanne Moog [Wed, 14 Jun 2017 08:49:55 +0000 (10:49 +0200)]
[BUGFIX] Remove manually set database row

databaseRow should not be set incompletely in a
FormDataProvider or controller as subsequent
processing may rely on the complete database
row being set (for example language fields).

Resolves: #80855
Related: #80100
Release: master, 8.7, 7.6
Change-Id: I139b426c6598a93a2012cae088e3cbece4e1a83b
Reviewed-on: https://review.typo3.org/52543
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Faton Haliti <fha@systime.dk>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Check for enabled devlog inside devLog() 51/52751/8
Benni Mack [Fri, 19 May 2017 12:24:24 +0000 (14:24 +0200)]
[BUGFIX] Check for enabled devlog inside devLog()

Calling GeneralUtility::devLog() can be called but
the method itself should check whether the devlog
is enabled, instead of having third-party code
rely on checking the option with an if statement.

This effectively removes the need for checks on
if (TYPO3_DLOG) and the other two constants TYPO3_ERROR_DLOG
and TYPO3_EXCEPTION_DLOG in all callers' code.

Resolves: #80289
Releases: master, 8.7
Change-Id: Ibaeeca6300bdb37a513a07fb46c2616cfc51c7f2
Reviewed-on: https://review.typo3.org/52751
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Correct overflow behavior for iframes in modal windows 84/53184/2
Benjamin Kott [Sun, 11 Jun 2017 12:19:09 +0000 (14:19 +0200)]
[BUGFIX] Correct overflow behavior for iframes in modal windows

Resolves: #81539
Releases: master, 8.7
Change-Id: I2633df64020e9f6a8e95048ed2d23f84d3013313
Reviewed-on: https://review.typo3.org/53184
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Throw proper exception when parsing Yaml files 97/53197/3
Benni Mack [Tue, 13 Jun 2017 05:50:12 +0000 (07:50 +0200)]
[BUGFIX] Throw proper exception when parsing Yaml files

When having an empty Yaml file, the error that is thrown isn't
helpful for the developer, and in case of RTE, the RTE is not shown
at all.

Resolves: #81557
Releases: master, 8.7
Change-Id: Ie435b9f42623962637a9ead0243be6cde15c82c6
Reviewed-on: https://review.typo3.org/53197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Deprecate render method arguments on ViewHelpers 96/52796/8
Claus Due [Fri, 12 May 2017 20:04:49 +0000 (22:04 +0200)]
[TASK] Deprecate render method arguments on ViewHelpers

Deprecates usage of arguments on render methods and
refactors the abstract ViewHelper class to avoid injecting
ReflectionService in every ViewHelper, calling on it only
when the ViewHelper actually requires it.

Safe removal since the DI property is declared private and
thus cannot be accessed in ViewHelper classes.

Change-Id: I94bb7e9f306b34c25dc31519eb17316c88ea0540
Resolves: #81213
Releases: master
Reviewed-on: https://review.typo3.org/52796
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Leaving edit by clicking in page tree does not show a warning 75/53075/13
Oliver Hader [Sat, 3 Jun 2017 12:54:54 +0000 (14:54 +0200)]
[FEATURE] Leaving edit by clicking in page tree does not show a warning

If edit forms have unsaved changes, changing the IFRAME URL is caught by
explicitly sending interaction requests that are handled by individual
client components, such as the FormEngine. This feature does not use the
Window.beforeunload event, but some custom messaging API instead.

Click events on the ExtJS page-tree are caught if those trigger a change
request for the content component, however highlighting the clicked page
node is not caught due to nested ExtJS event hierarchies.

Resolves: #77268
Releases: master
Change-Id: I3e2359cf27d95197b17e8d8489759ace403ce1af
Reviewed-on: https://review.typo3.org/53075
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Update CKEDITOR to 4.7.0 38/53138/8
Anders Kostending [Tue, 6 Jun 2017 13:21:42 +0000 (15:21 +0200)]
[TASK] Update CKEDITOR to 4.7.0

Updates the version of CKEditor to 4.7.

This update fixes 30+ bugs, that can be seen here:
http://ckeditor.com/release/CKEditor-4.7.0

In addition there will be simpler tables, better
support for CSP, better paste from Excel and
Word and so on.

Added one fix to the typo3link plugin.

Resolves: #81483
Releases: master, 8.7
Change-Id: Id5a023e5bf9ad9bfac5e7c9c103670978ef95d8f
Reviewed-on: https://review.typo3.org/53138
Reviewed-by: Anders Kostending <aha@systime.dk>
Tested-by: Anders Kostending <aha@systime.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Convert remaining ViewHelpers to static calling 84/52784/9
Claus Due [Thu, 11 May 2017 18:59:40 +0000 (20:59 +0200)]
[TASK] Convert remaining ViewHelpers to static calling

Last pass, touches all remaining ViewHelpers which
are capable of conversion to the compilation helper
traits from Fluid.

Change-Id: I73e32da48b00444b66a568f462ab41ff66969503
Resolves: #81200
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52784
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prefix single digit dates with 0 instead of whitespace 89/53189/2
Sascha Egerer [Mon, 12 Jun 2017 11:05:46 +0000 (13:05 +0200)]
[BUGFIX] Prefix single digit dates with 0 instead of whitespace

The backend query view, used for csv exports and lists, uses a date
format where single digit days of a date value are prefixed with a
whitespace instead of a 0.
This ends up in useless CSV exports that can not be interpreted by
tools like Excel.

Change-Id: Ie11c5f8a923eb412f014f06df528a2aa0101a0d4
Resolves: #81551
Releases: master,8.7
Reviewed-on: https://review.typo3.org/53189
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Allow RTE yml presets in LocalConfiguration 81/53181/4
Christian Kuhn [Fri, 9 Jun 2017 21:36:13 +0000 (23:36 +0200)]
[BUGFIX] Allow RTE yml presets in LocalConfiguration

ext:rte_ckeditor declares the default config yml preset pointers
of TYPO3_CONF_VARS['RTE'] in its ext_localconf.php file.
This file is loaded after LocalConfiguration.php.
The patch wraps the declarations in guards to ensure any
previously set pointers are not blindly reset.

Change-Id: Ic945d988f436aab7453b7f7fba8694bbf3580b1d
Resolves: #81537
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53181
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FOLLOWUP][TASK] Remove obsolete jQuery plugin 'matchHeight' 86/53186/3
Johannes Goslar [Mon, 12 Jun 2017 09:02:01 +0000 (11:02 +0200)]
[FOLLOWUP][TASK] Remove obsolete jQuery plugin 'matchHeight'

Remove package from lock file.

Resolves: #81493
Releases: master
Change-Id: I92e72464a509a5a76a84e28b0044b2e8f6678a21
Reviewed-on: https://review.typo3.org/53186
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] change intval() to (int) 83/53183/3
DanielRuf [Sat, 10 Jun 2017 21:58:51 +0000 (23:58 +0200)]
[TASK] change intval() to (int)

Typecasting with (int) is about 2-3 times faster than using intval().

Change-Id: Ifddcaaf9bf5c1fa77c632df10cba62c82d4614d1
Resolves: #81544
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53183
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Add TypeScript type definitions to linter 37/53137/2
ksjogo [Tue, 6 Jun 2017 11:27:44 +0000 (13:27 +0200)]
[TASK] Add TypeScript type definitions to linter

Resolves: #81480
Releases: Master
Change-Id: I6dddb5504ba9ecd22952c371610c225e700b6100
Reviewed-on: https://review.typo3.org/53137
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Register stylesSet in Editor/Base.yaml 51/53151/3
Frans Saris [Wed, 7 Jun 2017 12:11:05 +0000 (14:11 +0200)]
[TASK] Register stylesSet in Editor/Base.yaml

Resolves: #81499
Release: master, 8.7
Change-Id: I14fbb369de466cc1884bb164bbd3a16ba051e9b0
Reviewed-on: https://review.typo3.org/53151
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Remove CSH of ancient form wizard 60/53160/4
Georg Ringer [Wed, 7 Jun 2017 14:31:39 +0000 (16:31 +0200)]
[TASK] Remove CSH of ancient form wizard

The first form wizard is not there anymore, therefore the
CSH must be removed as well.

Resolves: #81505
Releases: master, 8.7
Change-Id: If1f37fa26576c85ba1a756cc20b19c23d023054a
Reviewed-on: https://review.typo3.org/53160
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add alias for grunt tasks 45/53145/4
Markus Sommer [Tue, 6 Jun 2017 20:34:57 +0000 (22:34 +0200)]
[TASK] Add alias for grunt tasks

After this patch you need no local grunt-cli
you can run all task with npm like `npm run build-css`

Resolves: #81491
Releases: master, 8.7
Change-Id: I112ec3f2102c23ecfa8a715933905d03ef35e55f
Reviewed-on: https://review.typo3.org/53145
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove double escaping in warning in DatabaseRecordList 46/53146/2
Georg Ringer [Wed, 7 Jun 2017 05:47:31 +0000 (07:47 +0200)]
[BUGFIX] Remove double escaping in warning in DatabaseRecordList

As the flash message's title and text are escaped already, remove the
htmlspecialchars in DatabaseRecordList.

Additionally remove the text "Warning:" from the text as this is already
expressed by the flash message itself.

Resolves: #81494
Releases: master, 8.7
Change-Id: I557dfb6f1422d2194dcdf83bbbc156a99efb290e
Reviewed-on: https://review.typo3.org/53146
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Limit shown user groups in the permission module 57/53157/2
Georg Ringer [Wed, 7 Jun 2017 14:03:51 +0000 (16:03 +0200)]
[BUGFIX] Limit shown user groups in the permission module

The usergroup selection in the overview view of the permission
module must respect the field 'hide_in_lists' as done in the
detail view of a page selected in the permission module.

Resolves: #81504
Releases: master, 8.7
Change-Id: I23c821af7abd5bdce16d780814d928e956333bb0
Reviewed-on: https://review.typo3.org/53157
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make date/time fields working again 42/51242/16
Markus Klein [Wed, 7 Jun 2017 13:47:46 +0000 (15:47 +0200)]
[BUGFIX] Make date/time fields working again

This patch solves an issue with time-fields and a couple of
inconsistencies for time(sec), date and datetime fields in BE:

- BackendUtility::time() is superfluous as gmdate() can be used
- Ensure stored data is identical to TYPO3 7
- Only use ISO dates in UTC timezone to communicate with JS
  (time fields use 1970-01-01 as date)
- Only write ISO dates in UTC back to hidden FormEngine fields
- Do that for all date/time fields to simplify JS code
- Take care of necessary timezone conversion for date(time) fields
- Correctly handle manual input
- Fix record titles if a date field is the label field
- Fix wrong Acceptance tests
- Fix wrong Unit tests
- Remove superfluous data-date-offset attribute for DateTimePicker
- Streamline FormEngineValidation date handling code
- Refactor DateTimePicker: fix code duplication, work in UTC only

Resolves: #79249
Releases: master, 8.7
Change-Id: I12ef6b6f59f0843182e093f8f274989161820894
Reviewed-on: https://review.typo3.org/51242
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Default value for native datetime fields must not be 0 96/51296/8
Sascha Egerer [Thu, 12 Jan 2017 21:14:41 +0000 (22:14 +0100)]
[BUGFIX] Default value for native datetime fields must not be 0

The default database value for native fields of type datetime
must not be 0 but NULL.

Resolves: #79304
Releases: master, 8.7
Change-Id: I823a85be2a01ccd8df4997ab2969b2c95ed78cd1
Reviewed-on: https://review.typo3.org/51296
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove obsolete jQuery plugin 'matchHeight' 49/53149/4
Jasmina Liessmann [Wed, 7 Jun 2017 08:53:42 +0000 (10:53 +0200)]
[TASK] Remove obsolete jQuery plugin 'matchHeight'

Since using flexbox for displaying boxes at the same height in module
'About' the jQuery plugin 'matchHeight' is not needed anymore.

Resolves: #81493
Releases: master
Change-Id: I1f593111804cd34f66beee472cbdd4ac258fc0ab
Reviewed-on: https://review.typo3.org/53149
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Remove last LESS file 65/53165/2
Josef Glatz [Wed, 7 Jun 2017 20:09:02 +0000 (22:09 +0200)]
[TASK] Remove last LESS file

Remove the last LESS file after the switch to SCSS.

Resolves: #81509
Releases: master
Change-Id: I24138144497c60e018b5612bce3624b631ac6d0b
Reviewed-on: https://review.typo3.org/53165
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Dim not selected crop area again 56/53156/2
Helmut Hummel [Wed, 7 Jun 2017 13:50:26 +0000 (15:50 +0200)]
[BUGFIX] Dim not selected crop area again

While cleanup css with #79998 the background was accidentally removed.
Add it again to make the selected crop area more prominent again.

Resolves: #81503
Releases: master, 8.7
Change-Id: I197d6c4bb9b7be7d2b9a443ce1b60ab3b4d82bcd
Reviewed-on: https://review.typo3.org/53156
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Robert Vock <robert.vock@4wdmedia.de>
Tested-by: Robert Vock <robert.vock@4wdmedia.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] mssql: ext:impexp test fixes 53/53153/2
Christian Kuhn [Mon, 22 May 2017 13:39:09 +0000 (15:39 +0200)]
[BUGFIX] mssql: ext:impexp test fixes

The patch adds fixture comparison files
for mssql platform on ext:impexp functional
tests.

Change-Id: I2ff9048b9f6395c555f72a68b16684e9bf22de84
Resolves: #81501
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53153
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] mssql: Proper types inserting / updating rows 50/53150/3
Christian Kuhn [Mon, 22 May 2017 13:39:09 +0000 (15:39 +0200)]
[BUGFIX] mssql: Proper types inserting / updating rows

MS SQL server is more picky about types than postgres and
mysql. This is especially true for LOB columns - even empty
strings need a proper cast and specific handling.

Various parts of the core deal with arbitrary tables and
don't know if a column is int, text or lob, or whatever.
Those are blindly updated / inserted, resulting in mssql
saying "no".

Solution is to fetch column schema and to set proper types
based on that schema. This is expensive. We will have to
refactor that again, and we will probably end up with a
(cache?) entry that knows the entire table schema of an
instance.

Solving that in a good way would also fix various mysql strict
issues we still have in the core. However, this needs more work.

Goal of the current patch is to bring mssql to a working state.
The solution must be seen as hacky, but is restricted to that
platform only and can be relaxed and improved as soon as we
take the next steps with schema handling in the TYPO3 core.

Change-Id: I9b582a9bde7461cfbcc2414192518fb7b7b1341d
Resolves: #81498
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53150
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] mssql: ExpressionBuilder inSet() support 41/53141/4
Christian Kuhn [Tue, 6 Jun 2017 15:57:15 +0000 (17:57 +0200)]
[BUGFIX] mssql: ExpressionBuilder inSet() support

mssql does not support FIND_IN_SET(). The patch adds a
solution based on LIKE.
Since the query fiddling in this area is a bit tricky,
this area is now supported by a bunch of functional tests.
A postgres bug those new functional tests reveal is fixed
along the way.

Change-Id: I5e94ad8df7a37a680b457eff1b5b16a0c14dba39
Resolves: #81488
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53141
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Use correct database connection for table in ReferenceIndex 31/53131/2
Morton Jonuschat [Tue, 6 Jun 2017 03:55:38 +0000 (20:55 -0700)]
[BUGFIX] Use correct database connection for table in ReferenceIndex

Reusing the connection object for the sys_refindex table can fail
if the table that is being indexed is actually on another connection.
Select the proper connection before attempting to execute the query.

Change-Id: I4c031428f7405031aea6ef652c8b6f488f921228
Resolves: #81049
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53131
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] FormEngine: Show correct error message (render)Type is unknown 39/53139/3
Markus Klein [Tue, 6 Jun 2017 14:40:45 +0000 (16:40 +0200)]
[BUGFIX] FormEngine: Show correct error message (render)Type is unknown

Issue correct error message if the renderType (or the type) is unknown.
The message now includes also the renderType, if specified.

Releases: master, 8.7, 7.6
Resolves: #81485
Change-Id: I44e736a546fc27733a8c8df14089dd25dc172f2b
Reviewed-on: https://review.typo3.org/53139
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add sitemap to sysext:core/Documentation 33/53133/3
Martin Bless [Tue, 6 Jun 2017 07:55:48 +0000 (09:55 +0200)]
[TASK] Add sitemap to sysext:core/Documentation

Resolves: #81477
Releases: master, 8.7, 7.6
Change-Id: Ie98fcc81c386fe5704c669f36220827f7cfbd2e5
Reviewed-on: https://review.typo3.org/53133
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Use correct variable when throwing exception in PageRepository 22/53122/3
Wouter Wolters [Mon, 5 Jun 2017 14:08:55 +0000 (16:08 +0200)]
[BUGFIX] Use correct variable when throwing exception in PageRepository

The wrong variable is used in a hook exception. Use the correct variable
to prevent fatal errors.

Resolves: #81472
Releases: master,8.7
Change-Id: I8cf84c2ac84c09bbeecc2111eb6128fdc71be3c7
Reviewed-on: https://review.typo3.org/53122
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] System > Access module now starting in selected page of page tree 44/51044/2
Michael Oehlhof [Sun, 25 Dec 2016 23:35:12 +0000 (00:35 +0100)]
[BUGFIX] System > Access module now starting in selected page of page tree

Resolves: #78355
Releases: master
Change-Id: Ibf4966f312124bdab38701e014cd9fd74f768adf
Reviewed-on: https://review.typo3.org/51044
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[CLEANUP] Review comment of getPageAndRootline() 63/52963/3
Elmar Hinz [Mon, 29 May 2017 17:22:11 +0000 (19:22 +0200)]
[CLEANUP] Review comment of getPageAndRootline()

Releases: master
Resolves: #81280
Change-Id: Ib67d57b69e9d5cd4f46cd8c7201107ec5945d64c
Reviewed-on: https://review.typo3.org/52963
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Avoid overflow of page titles in several tables 06/53106/4
Jasmina Liessmann [Sat, 3 Jun 2017 21:31:29 +0000 (23:31 +0200)]
[TASK] Avoid overflow of page titles in several tables

Page titles are used within several table views. This patch avoids
page titles from being displayed outside their columns.

Resolves: #81456
Releases: master, 8.7
Change-Id: I38d773ff8b3300027ef815b4f792cc45b0a66aff
Reviewed-on: https://review.typo3.org/53106
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Restructure position of help icons in 'Pagetree overview' 86/53086/8
Jasmina Liessmann [Sat, 3 Jun 2017 12:30:01 +0000 (14:30 +0200)]
[TASK] Restructure position of help icons in 'Pagetree overview'

Move general CSH for 'Pagetree overview' next to form fields.

Resolves: #81453
Releases: master, 8.7
Change-Id: I8e5c3a4257d569277f837bee2c641cd1a95dd9a5
Reviewed-on: https://review.typo3.org/53086
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Modernize TypeScript setup and fix module paths 21/53021/17
Johannes Goslar [Fri, 2 Jun 2017 19:57:31 +0000 (21:57 +0200)]
[TASK] Modernize TypeScript setup and fix module paths

Resolves: #81416
Releases: master, 8.7
Change-Id: If7e3893baa73c1392f3317d5b871be51eeab41b5
Reviewed-on: https://review.typo3.org/53021
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Prevent exception in ImageCropUpdater 20/53120/2
Nicole Cordes [Mon, 5 Jun 2017 12:18:51 +0000 (14:18 +0200)]
[BUGFIX] Prevent exception in ImageCropUpdater

The ImageCropUpdater throws an exception if a non-existing file is tried
to be processed. This happens because deleted rows are updated. The patch
checks the returned file object before further processing is executed.

Resolves: #81470
Releases: master, 8.7
Change-Id: I488994b1ad842e28d928f3b4a2db1c8c007afe3c
Reviewed-on: https://review.typo3.org/53120
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] mssql: Identifier quoting and return types 15/53115/2
Christian Kuhn [Sun, 4 Jun 2017 12:46:49 +0000 (14:46 +0200)]
[BUGFIX] mssql: Identifier quoting and return types

Microsoft sql server field & columns quotes quotes identifiers as
[anIdentifier] in comparison to mysql and postgres which quote
with a character that is identical left and right.
The patch adapts some quoting methods to cope with that and
adapts a return type hint where the mssql doctrine driver returns
more precise value types than other platform drivers.

Change-Id: I8db6109d5a92ff43f3503f245c5d131b96201096
Resolves: #79297
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53115
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix getTemplatePathAndFilename on StandaloneView 21/51021/7
Claus Due [Thu, 22 Dec 2016 12:28:46 +0000 (13:28 +0100)]
[BUGFIX] Fix getTemplatePathAndFilename on StandaloneView

This patch avoids calling a non-existing method and instead calls
upon TemplatePaths to resolve the template file - which is closer
to the original behavior.

Change-Id: Ib2669056e59bf1a6524e35e02e1f677226a5efa5
Resolves: #79073
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/51021
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add component card 99/53099/8
maikh [Sat, 3 Jun 2017 16:53:41 +0000 (18:53 +0200)]
[TASK] Add component card

Add card component.
Rebuild "about" start page with new card component

Change-Id: I059fae38c96455dc08ff143bd68da3f05fb63fa6
Resolves: #81462
Releases: master
Reviewed-on: https://review.typo3.org/53099
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
2 years ago[BUGFIX] Fix height of the modal content 23/53023/8
Jasmina Liessmann [Fri, 2 Jun 2017 10:15:47 +0000 (12:15 +0200)]
[BUGFIX] Fix height of the modal content

Fix height of the modal content to avoid misbehavior in IE11.

Resolves: #81232
Releases: master, 8.7
Change-Id: I302915e1efcd2040f78db8052dc2e09e06f1dfe4
Reviewed-on: https://review.typo3.org/53023
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make TemplatePaths->fillDefaultsByPackageName sort paths 38/52938/3
Claus Due [Wed, 24 May 2017 15:41:14 +0000 (17:41 +0200)]
[BUGFIX] Make TemplatePaths->fillDefaultsByPackageName sort paths

Due to the sequence of methods being called from this method,
it is necessary to sort TS-configured paths right when they are
resolved instead of passing the unsorted array further down.

Patch also sorts methods protected below public; true diff is
one line. Toggle this line between before/after and run the test
to see the problem demonstrated.

See issue description for a more detailed reasoning.

Change-Id: I0317c4ee683c2fac2c7def7c6d79f947afc4b078
Resolves: #81340
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52938
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Prevent thumbnail generation for non image files 07/53107/6
maikh [Sat, 3 Jun 2017 21:33:01 +0000 (23:33 +0200)]
[TASK] Prevent thumbnail generation for non image files

Check files if they are image files before thumbnail generation.

Change-Id: I7dae2ccbb5ab93e582d21efe8f7d29cf7006a1c3
Resolves: #81147
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53107
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Streamline icons for "new" actions 05/53105/2
Daniel Windloff [Sat, 3 Jun 2017 19:59:08 +0000 (21:59 +0200)]
[FOLLOWUP][TASK] Streamline icons for "new" actions

- actions-add
Link to one new record or a wizard to select the type
of the record
- actions-page-new
Link to one new page record
- actions-document-new
Link to create multiple new records (EditDocumentController)

Resolves: #81428
Releases: master
Change-Id: Ic95a4b3b7727e96a2da818633d03cba7a1c7bde7
Reviewed-on: https://review.typo3.org/53105
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] mssql: A series of functional test fixes 02/53102/2
Christian Kuhn [Mon, 22 May 2017 13:39:09 +0000 (15:39 +0200)]
[TASK] mssql: A series of functional test fixes

A couple of straight patches withis functional test cases
for mssql compatibility:
* Set identity where records with uids are inserted
* Quote LOB fields correctly
* A change to cope with [] encapsulated field and table names

Change-Id: I103021550fbe5c62f15e82454c766d67fc0dc63f
Resolves: #81465
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53102
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Drop ext:typo3db_legacy 12/52612/5
Christian Kuhn [Wed, 26 Apr 2017 13:17:01 +0000 (15:17 +0200)]
[!!!][TASK] Drop ext:typo3db_legacy

The extension containing legacy $GLOBALS['TYPO3_DB'] has been moved to
github at https://github.com/FriendsOfTYPO3/typo3db_legacy
and is available as TER extension and now dropped from core.
An upgrade wizard is added to dowload and install the extension
if needed.

Change-Id: Id99794844e39632a3451e19c7a7d55d47bc3118c
Resolves: #81023
Releases: master
Reviewed-on: https://review.typo3.org/52612
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Tested-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Hide empty descriptions in textmedia in page module 92/53092/2
Jigal van Hemert [Sat, 3 Jun 2017 15:30:39 +0000 (17:30 +0200)]
[BUGFIX] Hide empty descriptions in textmedia in page module

In the Page module with textmedia content elements the descriptions
are shown below the thumbnails of linked media. If there is no
description an empty line is now suppressed.

Resolves: #81408
Releases: master, 8.7, 7.6
Change-Id: I9f342908f179550bcf2156328117c464bb8c672f
Reviewed-on: https://review.typo3.org/53092
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove bower and update Gruntfile.js 89/53089/3
Johannes Goslar [Sat, 3 Jun 2017 13:23:25 +0000 (15:23 +0200)]
[TASK] Remove bower and update Gruntfile.js

Resolves: #81459
Releases: master, 8.7
Change-Id: I213c8d52d8c5ed0d027c1c6e7d01e9bec49ce506
Reviewed-on: https://review.typo3.org/53089
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Tested-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move bower dependencies to npm 78/53078/7
Johannes Goslar [Fri, 2 Jun 2017 22:18:01 +0000 (00:18 +0200)]
[TASK] Move bower dependencies to npm

Resolves: #81448
Resolves: #81449
Resolves: #81450
Releases: master, 8.7
Change-Id: Ic87b62f09d607e7f37491ebec2ea4619bc1aff70
Reviewed-on: https://review.typo3.org/53078
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] DocumentEditController save with translation broken 30/52730/2
Markus Sommer [Fri, 5 May 2017 11:48:09 +0000 (13:48 +0200)]
[BUGFIX] DocumentEditController save with translation broken

With changing the input type=image to input type=submit,
the x/y values are no longer transferred the
EditDocumentController checked for, and content is no
longer saved. Adapt the controller code for the new parameters.

Resolves: #76649
Releases: 8.7, master

Change-Id: I921b92f1086e142592fc84083656c4baecd43aa7
Reviewed-on: https://review.typo3.org/52730
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Show hidden sub group items in be_groups records 85/53085/4
Markus Sommer [Sat, 3 Jun 2017 12:26:25 +0000 (14:26 +0200)]
[TASK] Show hidden sub group items in be_groups records

Show hidden records in the subgroup list of be_group
records, too.

Change-Id: Iaca85f22bdf8a4c308b59fd37bd75b4a913614a0
Resolves: #81452
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53085
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Marco Christian Krenn <krenn@webconsulting.at>
Tested-by: Marco Christian Krenn <krenn@webconsulting.at>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][FEATURE] Collect lost elements and show them separately 82/53082/4
Cybercraft [Sat, 3 Jun 2017 11:46:56 +0000 (13:46 +0200)]
[FOLLOWUP][FEATURE] Collect lost elements and show them separately

Add missing RST file for new feature

Resolves: #67884
Releases: master
Change-Id: I9d7ffa4203cbcec5dac2b5359f418faeaf5462fa
Reviewed-on: https://review.typo3.org/53082
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove CSH on bottom of page module 79/53079/2
Marco Christian Krenn [Sat, 3 Jun 2017 11:13:27 +0000 (13:13 +0200)]
[TASK] Remove CSH on bottom of page module

CSH buttons on bottom of page are removed, text on the top CSH button
is rewriten.

Resolves: #81454
Releases: master
Change-Id: Ie04f8eab19eef996b258808986c05317535b72dc
Reviewed-on: https://review.typo3.org/53079
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Prohibit editing of uneditable labels in pagetree 63/53063/4
Johannes Goslar [Fri, 2 Jun 2017 20:15:16 +0000 (22:15 +0200)]
[BUGFIX] Prohibit editing of uneditable labels in pagetree

Resolves: #81445
Releases: master, 8.7
Change-Id: Ie88eb7ce2fdaf7429377062e86996847f7e9bfa9
Reviewed-on: https://review.typo3.org/53063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Avoid jumping of form fields on focus 69/53069/4
Jasmina Liessmann [Fri, 2 Jun 2017 22:20:30 +0000 (00:20 +0200)]
[BUGFIX] Avoid jumping of form fields on focus

Use absolute position for hints of remaining
characters to prevent form fields from being
moved down.

Resolves: #81447
Related: #77069
Releases: master, 8.7
Change-Id: I8df8cd25955a6ed44bfa5ee727f439856960167f
Reviewed-on: https://review.typo3.org/53069
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Add edit icon to Backend User "Compare" view 76/53076/3
Markus Sommer [Sat, 3 Jun 2017 10:30:21 +0000 (12:30 +0200)]
[FEATURE] Add edit icon to Backend User "Compare" view

Change-Id: I828ed0219033ea8f5ed075eaa4d72c84cdf37414
Resolves: #53685
Releases: master
Reviewed-on: https://review.typo3.org/53076
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Streamline preview icons 57/53057/3
Daniel Windloff [Fri, 2 Jun 2017 17:09:57 +0000 (19:09 +0200)]
[TASK] Streamline preview icons

Usage:
- actions-view-page
Preview a single page record
- actions-view
Preview a single record (except pages)
- actions-document-view
Preview images or documents.
(Preview multiple records)

Resolves: #81429
Releases: master
Change-Id: I7a537b8b171981bcfe3b55d4d4156192f660ba3c
Reviewed-on: https://review.typo3.org/53057
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] Collect lost elements and show them separately from backend layout 40/53040/14
Cybercraft [Fri, 2 Jun 2017 13:20:58 +0000 (15:20 +0200)]
[FEATURE] Collect lost elements and show them separately from backend layout

Resolves: #67884
Releases: master
Change-Id: I7c14886e5dc1c81d7d816e5f2eb5d36afb8cdbf9
Reviewed-on: https://review.typo3.org/53040
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Streamline icons for "new" actions 73/53073/3
Daniel Windloff [Sat, 3 Jun 2017 08:14:00 +0000 (10:14 +0200)]
[TASK] Streamline icons for "new" actions

Usage:
- actions-add-placeholder
Link to wizards / controller where the selection
between serveral kinds of new records can be made
- actions-add
Link to creation form for all records
except pages (EditDocumentController)
-actions-page-new
Link to creation form for page record
-actions-document-new
Link to create multiple new records

Resolves: #81428
Releases: master
Change-Id: I10ced54f5cd8c09c095a699fd0994a9dd5fa0f05
Reviewed-on: https://review.typo3.org/53073
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] CSH on popup window - more link leads to non-existent page 65/53065/4
Oliver Hader [Fri, 2 Jun 2017 21:13:38 +0000 (23:13 +0200)]
[BUGFIX] CSH on popup window - more link leads to non-existent page

Opening CSH help popups from another popup (e.g. add/edit wizard) fails
since the resolved CSH URI is not valid.

Resolves: #80665
Releases: master, 8.7
Change-Id: I16f4dcd037cdb7ab210c083272d0941c979da205
Reviewed-on: https://review.typo3.org/53065
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Move jquery to npm 66/53066/3
Johannes Goslar [Fri, 2 Jun 2017 22:02:01 +0000 (00:02 +0200)]
[TASK] Move jquery to npm

Resolves: #81446
Change-Id: I10fd5950636d2e4b992e1a03f1720759d9e7c55d
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53066
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use reference for label 'bodytext' in CType 'textpic' 64/53064/2
Jasmina Liessmann [Fri, 2 Jun 2017 21:08:14 +0000 (23:08 +0200)]
[TASK] Use reference for label 'bodytext' in CType 'textpic'

Resolves: #81352
Releases: master, 8.7
Change-Id: I7f55e6998ebde5d8d90e7b6bcd05f4550f6ce09a
Reviewed-on: https://review.typo3.org/53064
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>