Packages/TYPO3.CMS.git
4 months ago[TASK] Run functional tests without xdebug on bamboo 01/58801/2
Christian Kuhn [Tue, 30 Oct 2018 14:41:54 +0000 (15:41 +0100)]
[TASK] Run functional tests without xdebug on bamboo

With the increased number of functional tests in v9 we
should squeeze out as much performance as possible from
the tests so waiting for bamboo is not so annoying. Not
loading xdebug gives us roughly 10-30% for functionals.

Resolves: #86801
Releases: master, 8.7
Change-Id: Ic7b9dd4dd0c71799ecb7207fc0e7170f98729545
Reviewed-on: https://review.typo3.org/58801
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Show correct namespace in example block of CommaSeparatedValueProcessor 99/58799/2
Joerg Boesche [Tue, 30 Oct 2018 13:27:29 +0000 (14:27 +0100)]
[BUGFIX] Show correct namespace in example block of CommaSeparatedValueProcessor

Resolves: #86800
Releases: master, 9.5, 8.7
Change-Id: I243589ee7e619f26e99e27d34c626e848a1ee80a
Reviewed-on: https://review.typo3.org/58799
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[BUGFIX] Update karma 82/58782/4
Andreas Fernandez [Mon, 29 Oct 2018 18:52:25 +0000 (19:52 +0100)]
[BUGFIX] Update karma

karma is used for JavaScript based unit tests. The currently installed
version is aged and doesn't compile on newer systems anymore, thus the
package is updated to a recent version.

Used command:
yarn add karma@^3.1.0 --dev

Resolves: #86798
Releases: master, 8.7
Change-Id: I1cea78cf3759227a2cd09b8560f37121ae580202
Reviewed-on: https://review.typo3.org/58782
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Test fully built css in bamboo 88/58788/5
Christian Kuhn [Tue, 30 Oct 2018 08:28:11 +0000 (09:28 +0100)]
[TASK] Test fully built css in bamboo

Extend the "Lint scss ts" bamboo job to also build css
next to js and only after that verify with git status
no file changed. This should prevent outdated css as
recently fixed with #86789.
Additionally switch from npm to direct grunt calls,
to be in sync with runTests.sh and to allow kicking
npm from the docker images entirely.

Change-Id: I5134d43c5f5d524005242eee59aa743b6e49219a
Resolves: #86794
Related: #86789
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58788
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Set TYPO3 version to 9.5.2-dev 96/58796/2
Oliver Hader [Tue, 30 Oct 2018 10:46:34 +0000 (11:46 +0100)]
[TASK] Set TYPO3 version to 9.5.2-dev

Change-Id: If96e59eef0e6be1eac2e58e2d50cf79ba70d6b16
Reviewed-on: https://review.typo3.org/58796
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[RELEASE] Release of TYPO3 9.5.1 94/58794/2 v9.5.1
Oliver Hader [Tue, 30 Oct 2018 10:45:16 +0000 (11:45 +0100)]
[RELEASE] Release of TYPO3 9.5.1

Change-Id: Ic1c6183af103b9c957b85d046ff2564348f165bc
Reviewed-on: https://review.typo3.org/58794
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Move FieldControl/ListModule handling to module 49/58649/5
Andreas Fernandez [Thu, 18 Oct 2018 13:27:42 +0000 (15:27 +0200)]
[TASK] Move FieldControl/ListModule handling to module

The FieldControl `ListModule` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86647
Releases: master
Change-Id: Ibf47ee8ebaea584f88ccb9615681bd579e4cd305
Reviewed-on: https://review.typo3.org/58649
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[TASK] Move FieldControl/InsertClipboard handling to module 24/58624/4
Andreas Fernandez [Sat, 13 Oct 2018 10:54:05 +0000 (12:54 +0200)]
[TASK] Move FieldControl/InsertClipboard handling to module

The FieldControl `InsertClipboard` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86646
Releases: master
Change-Id: I42ded87ab9152d92d07f3fe5b40b327d979aad4a
Reviewed-on: https://review.typo3.org/58624
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[TASK] Move FieldControl/TableWizard handling to module 50/58650/3
Andreas Fernandez [Thu, 18 Oct 2018 13:32:23 +0000 (15:32 +0200)]
[TASK] Move FieldControl/TableWizard handling to module

The FieldControl `TableWizard` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86649
Releases: master
Change-Id: I1cb71ad317f737afb0d943a4278583888737bcab
Reviewed-on: https://review.typo3.org/58650
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Move FieldControl/AddRecord handling to module 48/58648/6
Andreas Fernandez [Thu, 18 Oct 2018 13:19:41 +0000 (15:19 +0200)]
[TASK] Move FieldControl/AddRecord handling to module

The FieldControl `AddRecord` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86642
Releases: master
Change-Id: I0d4e44719f38d4dd0e2355e3aeab6551e1725fb7
Reviewed-on: https://review.typo3.org/58648
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Move FieldControl/ResetSelection handling to module 51/58651/9
Andreas Fernandez [Thu, 18 Oct 2018 14:07:19 +0000 (16:07 +0200)]
[TASK] Move FieldControl/ResetSelection handling to module

The FieldControl `ResetSelection` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86648
Releases: master
Change-Id: I478d5ae5567f38fb7cf75c30ab8ac7e2c021224e
Reviewed-on: https://review.typo3.org/58651
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Unsplit split buttons in TableController 84/58784/2
Andreas Fernandez [Mon, 29 Oct 2018 21:26:39 +0000 (22:26 +0100)]
[BUGFIX] Unsplit split buttons in TableController

The controller of the table wizard doesn't use split buttons anymore.

Resolves: #86792
Releases: master
Change-Id: I1d4c1f0d2a6a47dc9d997148fa70f6ea82b058cc
Reviewed-on: https://review.typo3.org/58784
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Re-build backend.css 83/58783/2
Andreas Fernandez [Mon, 29 Oct 2018 19:08:34 +0000 (20:08 +0100)]
[BUGFIX] Re-build backend.css

Since #86449, the backend.css is stale. This patch refreshes the build of
our CSS.

Used command:
grunt css

Resolves: #86789
Related: #86449
Releases: master
Change-Id: I5705c9680f3302a5b4ea6a0be013a49405979acb
Reviewed-on: https://review.typo3.org/58783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Clean up PharStreamWrapperInterceptor 81/58781/2
Oliver Hader [Mon, 29 Oct 2018 18:01:22 +0000 (19:01 +0100)]
[TASK] Clean up PharStreamWrapperInterceptor

* fix spacing issue
* remove superfluous method

Resolves: #86788
Releases: master
Change-Id: I2825819663ef90cd8ba84578e3153faa62047f54
Reviewed-on: https://review.typo3.org/58781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Ignore unique evaluation in l10n_mode exclude 51/56151/9
Christoph Lehmann [Wed, 14 Mar 2018 22:17:53 +0000 (23:17 +0100)]
[BUGFIX] Ignore unique evaluation in l10n_mode exclude

The l10n_mode "exclude" explains to copy the field value from
source language, so unique evaluation should be ignored for
translated records.

Resolves: #84267
Resolves: #83572
Releases: master, 8.7
Change-Id: I6a086cb1fc447dda2cbcfe27f33ba9f3dd714f53
Reviewed-on: https://review.typo3.org/56151
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Render correct paging label 79/58779/4
Andreas Fernandez [Mon, 29 Oct 2018 13:58:40 +0000 (14:58 +0100)]
[BUGFIX] Render correct paging label

In case of paging in any record list, the page browser is rendered in top
and on bottom of ther record list.

The upper browser now renders the paging correctly by calculating the
offset of items of the previous page instead of hard-coding a "1".

Resolves: #86787
Releases: master, 8.7
Change-Id: Ib7c8856f248107ea9d17aeabe83a564189f69abf
Reviewed-on: https://review.typo3.org/58779
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Improve styling of upload form in extension manager 67/58467/4
Georg Ringer [Sat, 29 Sep 2018 17:50:57 +0000 (19:50 +0200)]
[TASK] Improve styling of upload form in extension manager

- Add missing id attribute
- Use bootstrap styling
- Use styled button

Resolves: #86449
Releases: master
Change-Id: I782226bc4326ecac4df1d3f8186b3d84d7e21fb7
Reviewed-on: https://review.typo3.org/58467
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update typo3/testing-framework to 4.10.0 21/58621/6
Nicole Cordes [Fri, 12 Oct 2018 10:07:05 +0000 (12:07 +0200)]
[TASK] Update typo3/testing-framework to 4.10.0

Update from 4.9.0 to 4.10.0.
Notable change: The fluid RenderingContextFixture is
now provided by typo3/testing-framework, so core
namespace references can be adapted.

composer require --dev typo3/testing-framework ~4.10.0

Change-Id: Ifff354a2d418e09f08cf8818c3cd12ab87bf1ba8
Resolves: #86786
Releases: master
Reviewed-on: https://review.typo3.org/58621
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Respect endOfRange in pagination 50/57650/4
Guido Schmechel [Sat, 21 Jul 2018 12:55:14 +0000 (14:55 +0200)]
[BUGFIX] Respect endOfRange in pagination

If prepareObjectsSlice is called in the pagination with a QueryResult,
the endOfRange is calculated and used for each page.

This ensures that the maximum limit is not exceeded.

Resolves: #85585
Releases: master
Change-Id: I13f2ce910cbb4102782aafffca0ff7d193620735
Reviewed-on: https://review.typo3.org/57650
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Disable caching if fluid debugging is enabled 46/58646/7
Georg Ringer [Thu, 18 Oct 2018 07:42:48 +0000 (09:42 +0200)]
[BUGFIX] Disable caching if fluid debugging is enabled

Resolves: #86675
Releases: master
Change-Id: Ife47f1fe8c78899785fbad73e21e2a2bf9b8441a
Reviewed-on: https://review.typo3.org/58646
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser 96/58096/5
Frans Saris [Fri, 31 Aug 2018 08:21:13 +0000 (10:21 +0200)]
[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser

The fileBrowser now passes the related pid, table and field to
getDefaultUploadFolder().

Resolves: #86053
Releases: master, 8.7
Change-Id: I954753ee84b4107b37ba45cbd08917f4c4be17d9
Reviewed-on: https://review.typo3.org/58096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Always use default language for uniqueInSite 22/58722/5
Benni Mack [Fri, 26 Oct 2018 16:55:33 +0000 (18:55 +0200)]
[BUGFIX] Always use default language for uniqueInSite

SlugHelper fetches records of the same language, and takes the
pageId of the _current_ language record (uid), which is wrong.
For records, it must be 'pid', for pages it must be 'uid', but for
translated pages it must be 'pages.l10n_parent'.

Resolves: #86625
Releases: master
Change-Id: I7af6f0438f5a90169505069c557792d4e7b08b7c
Reviewed-on: https://review.typo3.org/58722
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Added default cropping ratio for social media images 74/58774/3
Richard Haeser [Mon, 29 Oct 2018 08:38:41 +0000 (09:38 +0100)]
[TASK] Added default cropping ratio for social media images

Most of the social networks use the 1.91:1 aspect ratio for images that
belong to the page that is shared.

Now og:image and twitter:image will be rendering an image with a 1.91:1
ratio by default.

Resolves: #86419
Releases: master
Change-Id: Icd3588363f64659f66ba25d4f44a57afff5c1fe1
Reviewed-on: https://review.typo3.org/58774
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update TypoScript include 84/58184/3
Nick [Tue, 4 Sep 2018 12:52:52 +0000 (14:52 +0200)]
[TASK] Update TypoScript include

TypoScript include method with ext_typoscript_setup.txt should be removed,
this file is deprecated since July 2005.

Releases: master
Resolves: #86143
Change-Id: If30c52159a4e9242ed5645eebc45cd524c8c55ad
Reviewed-on: https://review.typo3.org/58184
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[TASK] Ensure UTF-8 files contain no BOM 62/58762/6
Christian Kuhn [Sun, 28 Oct 2018 13:29:33 +0000 (14:29 +0100)]
[TASK] Ensure UTF-8 files contain no BOM

Extends bamboo to verify UTF-8 files contain no BOM and
adds Build/Scripts/runTests.sh -s checkBom to do the same
locally.

Resolves: #86781
Releases: master
Change-Id: I97f994f0fe4db427563197925018f412d9ada626
Reviewed-on: https://review.typo3.org/58762
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Move SCSS instructions from modal to install.scss 71/58771/3
Benni Mack [Sun, 28 Oct 2018 14:53:47 +0000 (15:53 +0100)]
[BUGFIX] Move SCSS instructions from modal to install.scss

This change accidentally merged the code into the wrong file.

Resolves: #86783
Related: #86562
Releases: master
Change-Id: Ibdcd74bac852cc48a5911a086c709c73562d55c6
Reviewed-on: https://review.typo3.org/58771
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Update local cache upon creation of new storage object 58/56058/5
Bernhard Kraft [Thu, 8 Mar 2018 12:39:36 +0000 (13:39 +0100)]
[BUGFIX] Update local cache upon creation of new storage object

When a new storage object for the "local" driver is being created
it is not possible to retrieve the new object instantaneous. The
objects are being cached in a local static variable which needs
to get flushed (set to "null") first.

Resolves: #86689
Resolves: #62273
Releases: master
Change-Id: Ib5a0d6b148ef7b503c26ccd1610519707a8fa86d
Reviewed-on: https://review.typo3.org/56058
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[BUGFIX] Keep MP parameters upon redirect of overlay 29/52829/10
Elmar Hinz [Wed, 17 May 2017 15:46:55 +0000 (17:46 +0200)]
[BUGFIX] Keep MP parameters upon redirect of overlay

When a mount point, that is overlayed, redirects to the overlaying page,
don't throw away existing mount point parameters. The other mount point
parameters may specify a mount point upwards in the root line.

Under normal circumstances the page should not be linked at all. However
a redirect is provided and as it is provided it should work as expected.

Releases: master
Resolves: #81251
Change-Id: I4cf830e5b24ebc9799e58f83d7787a726f92a3d4
Reviewed-on: https://review.typo3.org/52829
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Allow unicode characters in verifyFileNameAgainstDenyPattern 89/57389/6
Pascal Rinker [Mon, 25 Jun 2018 14:43:32 +0000 (16:43 +0200)]
[BUGFIX] Allow unicode characters in verifyFileNameAgainstDenyPattern

Using (valid) unicode characters in
GeneralUtility::verifyFilenameAgainstDenyPattern was not possible due
to a missing unicode modifier when evaluating regular expressions.
The unicode modifier has been added.
Since unicode errors in regular expressions will lead to `false`
results, it is important to perform type-safe checks against `0`.

Resolves: #67061
Releases: master, 8.7
Change-Id: If3eea7129c92b296b85b93a1f1c81a446a2f5f90
Reviewed-on: https://review.typo3.org/57389
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Add missing copy and cut button in file list search result 26/58426/11
Gianluigi Martino [Fri, 28 Sep 2018 06:54:40 +0000 (08:54 +0200)]
[BUGFIX] Add missing copy and cut button in file list search result

It is now possible to copy or cut the file in file list search result.

Resolves: #86414
Releases: master
Change-Id: I60ca052d36efaa45cc348f712b05cac3127cc120
Reviewed-on: https://review.typo3.org/58426
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Redirect site to language after site resolving 14/58614/9
Georg Ringer [Thu, 11 Oct 2018 10:01:59 +0000 (12:01 +0200)]
[BUGFIX] Redirect site to language after site resolving

In order to allow custom redirects not depending on the site language
base, the redirect functionality is extracted into a separte middleware.

This allows to also exchange the base redirects with
a custom middleware when GeoIP / UserAgent based language
detection is necessary.

Resolves: #86615
Releases: master
Change-Id: I93e3452dfb55aa2d45b4c6d464944bf5a5d7fbe9
Reviewed-on: https://review.typo3.org/58614
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Avoid PHP warnings in BackendUtility if no BE user is set 52/58752/5
Anja [Sun, 28 Oct 2018 10:44:55 +0000 (11:44 +0100)]
[BUGFIX] Avoid PHP warnings in BackendUtility if no BE user is set

BackendUtility no longer tries to resolve the workspace property
of a not set BackendUserAuthentication. This prevents warnings from
being thrown.

Change-Id: I30d739273a0107e70987beadd3649d8b6bb67f60
Resolves: #86617
Releases: master
Reviewed-on: https://review.typo3.org/58752
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Pass FlexForm context to USER display condition 13/58413/5
Nicole Cordes [Thu, 27 Sep 2018 14:23:21 +0000 (16:23 +0200)]
[BUGFIX] Pass FlexForm context to USER display condition

If using a user display condition within a FlexForm field,
the passed information is insufficient and information about the
parsed FlexForm is missing.

Resolves: #86403
Releases: master, 8.7
Change-Id: I9917b3f98f7d7eb4fa3370e1cd2e9a9cd0eef627
Reviewed-on: https://review.typo3.org/58413
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add test for (wrong) unique eval handling in pages:alias 22/57322/4
Andreas Wolf [Fri, 22 Jun 2018 22:13:48 +0000 (00:13 +0200)]
[TASK] Add test for (wrong) unique eval handling in pages:alias

Change-Id: Ie47dbc9153d8a4dcbde15a7eb61c207bbcc34480
Resolves: #86780
Related: #84267
Related: #83572
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57322
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Registration of multiple additional view models 06/58106/3
Ralf Zimmermann [Fri, 31 Aug 2018 17:17:22 +0000 (19:17 +0200)]
[BUGFIX] Registration of multiple additional view models

The form setup properties within "additionalViewModelModules" must be
written as numerical associative arrays to make it possible that
multiple extensions can extend the form editor with javascript modules.

Resolves: #85710
Releases: master, 8.7
Change-Id: Iaddf1bfd6f4df8d0c01e0c18be9cef458d8d2caf
Reviewed-on: https://review.typo3.org/58106
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Correctly resolve parameter for USER display condition 12/58412/4
Nicole Cordes [Thu, 27 Sep 2018 13:56:11 +0000 (15:56 +0200)]
[BUGFIX] Correctly resolve parameter for USER display condition

According to the documentation there is no limit of the used
additional parameters. However during parameter processing, there
is a limit of 4 parameters applied. This limit needs to be unset
when dealing with a USER display condition.

Resolves: #85274
Releases: master, 8.7
Change-Id: Ieff6d089cbb5540ab1d3b389eb0511ef993b900d
Reviewed-on: https://review.typo3.org/58412
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Improve performance of UriBuilder by memory cache 27/53827/10
Claus Due [Tue, 29 Aug 2017 17:07:31 +0000 (19:07 +0200)]
[TASK] Improve performance of UriBuilder by memory cache

The TYPO3 backend is eager to generate the same URL
with the same parameters multiple times, causing a lot
of cascading calls to URI parsing, token generation etc.

Turning the UriBuilder into a Singleton removes many
hundreds of calls to instantiate the object - and remembering
the URLs that were generated further saves many hundred
calls to UriBuilder->buildUri in for example the page module.

Change-Id: I7444ccf8bb27789c489f7d7c15c65449fa3456a0
Resolves: #82237
Releases: master
Reviewed-on: https://review.typo3.org/53827
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Check for Extbase response type instead of environment 00/58200/3
Daniel Siepmann [Thu, 6 Sep 2018 12:36:16 +0000 (14:36 +0200)]
[TASK] Check for Extbase response type instead of environment

Functional tests always set CLI context to true. Even if Extbase returns
an Web\Response, the method getExitCode will be called, which only
exists in Cli\Response.

Therefore a check against the response type allows to run functional
tests with Web\Response in Extbase.

Resolves: #86170
Releases: master
Change-Id: I5982d77aad82f92b6e6bb13cca5118ea2a3e7796
Reviewed-on: https://review.typo3.org/58200
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] BE checkFullLanguagesAccess check all translated records 59/58759/2
Ursula Klinger [Sun, 28 Oct 2018 12:26:27 +0000 (13:26 +0100)]
[BUGFIX] BE checkFullLanguagesAccess check all translated records

All translated records are checked for language access in the method
checkFullLanguagesAccess of BackendUserAuthentication

Resolves: #86778
Releases: master, 8.7
Change-Id: I9c0101507c741471a8537a92329a9a66b78fa559
Reviewed-on: https://review.typo3.org/58759
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use different placeholder than ### 86/58586/3
Stefan Neufeind [Sat, 6 Oct 2018 16:34:08 +0000 (18:34 +0200)]
[TASK] Use different placeholder than ###

preg_quote since PHP 7.3.0 also quotes #.
Simply use a different placeholder.

Resolves: #86586
Releases: master, 8.7, 7.6
Change-Id: I8ed9bd39605341a09347e21dd38c9a1824a01ee5
Reviewed-on: https://review.typo3.org/58586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Remove canonical link if noindex 00/58600/6
Gianluigi Martino [Tue, 9 Oct 2018 11:37:19 +0000 (13:37 +0200)]
[TASK] Remove canonical link if noindex

Some frontend and backend optimizations for canonical links

- Change position of canonical link input field in backend
- Hide canonical link input if in backend "no_index" toggle is inactive
- Reload page by changing "no_index" toggle in backend

Resolves: #86515
Releases: master
Change-Id: I70dd8e36ada7c1a4c9b5aec7f69866eae0592945
Reviewed-on: https://review.typo3.org/58600
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add unit tests for BackendUtiily::resolveFileReferences 58/58758/4
Anja [Sun, 28 Oct 2018 12:28:45 +0000 (13:28 +0100)]
[TASK] Add unit tests for BackendUtiily::resolveFileReferences

This tests are a left over from a patch being abandoned.
Keeping them should not be wrong, they help identify notices
thrown, if nothing else.

Change-Id: If88d0f60f8b5bef9ce34b628b5fb46b86d2ae36f
Resolves: #86779
Releases: master
Reviewed-on: https://review.typo3.org/58758
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Fix continue-statement inside a switch-block 93/58593/2
Stefan Neufeind [Sun, 7 Oct 2018 23:37:18 +0000 (01:37 +0200)]
[TASK] Fix continue-statement inside a switch-block

Calling continue inside a switch-block would work just like break.
This is usually not intended and thus triggers a warning since
PHP 7.3.0.

Resolves: #86589
Releases: master, 8.7, 7.6
Change-Id: Ic35998b8a37bd35110b9d3494f1cf258e845097a
Reviewed-on: https://review.typo3.org/58593
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Keep update button in linkbrowser for RTE CKEditor on edit 37/58737/3
Joerg Kummer [Sat, 27 Oct 2018 18:21:42 +0000 (20:21 +0200)]
[BUGFIX] Keep update button in linkbrowser for RTE CKEditor on edit

This patch moves the current value of the link into the parameter array
for the linkbrowser to keep the value in all linked actions inside the
linkbrowser for the RTE CKEditor.

This keeps the update button in the page linkhandler,
if an existing page link will be edited.

Resolves: #83545
Releases: master, 8.7
Change-Id: Ia9217057e45a5d94668bb5ac2f111198da9a69d1
Reviewed-on: https://review.typo3.org/58737
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Cleanup generation of sitemap-index-URLs 48/58548/3
Stefan Neufeind [Mon, 1 Oct 2018 21:34:07 +0000 (23:34 +0200)]
[TASK] Cleanup generation of sitemap-index-URLs

Use pageType-parameter from f:uri.page instead of providing
the type through additionalParams.
And don't include the page-parameter unless we are on another page
than the first one (page=0). Many DataProviders might only use one
page anyway.

Resolves: #86531
Releases: master
Change-Id: Id6f7ac8f53d03802e904ee0c946c8d0c02ee61f9
Reviewed-on: https://review.typo3.org/58548
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver 07/57207/4
Nicole Cordes [Wed, 13 Jun 2018 10:08:15 +0000 (12:08 +0200)]
[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver

This patch ensures that
AbstractHierarchicalFilesystemDriver::getParentFolderIdentifierOfIdentifier
always returns a file identifier using forward slashes. Furthermore
it removes double forward slashes for a root folder identifier.

Resolves: #85249
Releases: master, 8.7
Change-Id: I562eaade7353e5235d4f65725a4159f6c0b71d75
Reviewed-on: https://review.typo3.org/57207
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Process large list of hashes in chunks updating reference index 46/57846/4
Gleb Levitin [Thu, 9 Aug 2018 15:14:25 +0000 (17:14 +0200)]
[BUGFIX] Process large list of hashes in chunks updating reference index

The list of old hashes by cleaning up the reference index can
be very long. To avoid exceeding query limits like maximum number
of placeholder per query or the max allowed statement length these
large lists are split into chunks of safe length before processing.

Resolves: #85795
Releases: master, 8.7
Change-Id: Iaebc555fe791f9e41f336bcd30d5b6eb149ad4e9
Reviewed-on: https://review.typo3.org/57846
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Edit a translated record without def. language access 38/58738/3
Ursula Klinger [Sat, 27 Oct 2018 18:44:25 +0000 (20:44 +0200)]
[BUGFIX] Edit a translated record without def. language access

Editor without access to default language could not edit a translated
content element, because there was an entry in available languages
for index 0 with null

Resolves: #86771
Releases: master
Change-Id: I608791a6df9b26f420fb233d47f38fe7685931c8
Reviewed-on: https://review.typo3.org/58738
Reviewed-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASk] Fully qualified classes was expecting bool 84/58584/2
Tomas Norre Mikkelsen [Fri, 5 Oct 2018 16:30:40 +0000 (18:30 +0200)]
[TASk] Fully qualified classes was expecting bool

Releases: master
Resolves: #86582
Change-Id: Ie4a5578c632ff99898c97f5bd3a4e80f87260194
Reviewed-on: https://review.typo3.org/58584
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Set correct language uids in MenuProcessor when set to auto 76/58576/3
Nikita Hovratov [Thu, 4 Oct 2018 14:45:14 +0000 (16:45 +0200)]
[BUGFIX] Set correct language uids in MenuProcessor when set to auto

The configuration special.auto was introduced in #84775. The function
MenuProcessor->prepareLevelLanguageConfiguration() was not aware of that
and set the value for the languageUids to "auto".

Resolves: #86571
Releases: master
Change-Id: I6e6aedd351077b7e1ac49ed5bd7facab48590014
Reviewed-on: https://review.typo3.org/58576
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Catch Exceptions in RTE with invalid links 46/58746/2
Benni Mack [Sat, 27 Oct 2018 21:35:40 +0000 (23:35 +0200)]
[BUGFIX] Catch Exceptions in RTE with invalid links

Only one area is covered with catching invalid links when setting
an ugly external URL without proper scheme.

The other area is caught now too.

Resolves: #84009
Releases: master, 8.7
Change-Id: Ief7549009b114803daacf39e36528523718a0d36
Reviewed-on: https://review.typo3.org/58746
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Allow runTests.sh on Windows WSL 50/58750/3
Susanne Moog [Sun, 28 Oct 2018 10:15:26 +0000 (11:15 +0100)]
[TASK] Allow runTests.sh on Windows WSL

Pre-Requisites:
- docker for windows installed
- Base mount path for Windows drives is / (not /mnt/)
- docker for windows exposes daemon via tcp
- DOCKER_HOST set to tcp://localhost:2375
- ./Build/Scripts/runTests.sh has Linux line endings

Running:
- same as on Linux: on WSL go to /path/to/your/checkout
- run: ./Build/Scripts/runTests.sh

Resolves: #86777
Releases: master
Change-Id: Ia66ab92bc9f7711584b93cc321abdb076be4c2ab
Reviewed-on: https://review.typo3.org/58750
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[!!!][TASK] Remove X-UA-Compatible from HTML of backend 44/58744/2
Susanne Moog [Sat, 27 Oct 2018 21:02:30 +0000 (23:02 +0200)]
[!!!][TASK] Remove X-UA-Compatible from HTML of backend

Resolves: #76166
Releases: master
Change-Id: I5d36ea2342c18fe08cb5b5c06f123e8cb575849c
Reviewed-on: https://review.typo3.org/58744
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Nicolai Schirawski <ns@t3magic.de>
Tested-by: Nicolai Schirawski <ns@t3magic.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] No UTF-8 with BOM files 51/58751/2
Christian Kuhn [Sun, 28 Oct 2018 09:29:54 +0000 (10:29 +0100)]
[TASK] No UTF-8 with BOM files

Some files contain not needed BOM bytes in UTF-8 files.
Remove them since they can lead to not too funny headaches
in some details.

Resolves: #86776
Releases: master
Change-Id: I1b0dfb34966024e39c35863312dd2775a5024dc7
Reviewed-on: https://review.typo3.org/58751
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Adjust headline decoration in documentation file 48/58748/2
Anja [Sun, 28 Oct 2018 09:36:54 +0000 (10:36 +0100)]
[BUGFIX] Adjust headline decoration in documentation file

Change-Id: Ic30290ba8548049b2c053d1e3bfa4beae1615e24
Resolves: #86775
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58748
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Have LF line endings for .sh scripts in .gitattributes 47/58747/3
Christian Kuhn [Sun, 28 Oct 2018 09:26:04 +0000 (10:26 +0100)]
[TASK] Have LF line endings for .sh scripts in .gitattributes

Resolves: #86774
Releases: master, 8.7
Change-Id: I8b677426c6011a0b3115f83380ae567582dc9c17
Reviewed-on: https://review.typo3.org/58747
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Decouple GeneralUtility::rmdir from Environment::isWindows() 31/58631/2
Nicole Cordes [Sun, 14 Oct 2018 19:12:42 +0000 (21:12 +0200)]
[BUGFIX] Decouple GeneralUtility::rmdir from Environment::isWindows()

To be able to call rmdir without an initialized Environment instance,
the check if a Windows system is used, is decoupled. This allows to
call GeneralUtility::rmdir e.g. in typo3/testing-framework.

Resolves: #86655
Releases: master
Change-Id: Ica1feafbd9a07005c4b653ef2fe1153fba4b9417
Reviewed-on: https://review.typo3.org/58631
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Allow more tags when no RTE processing is available 45/58745/2
Benni Mack [Sat, 27 Oct 2018 21:28:41 +0000 (23:28 +0200)]
[BUGFIX] Allow more tags when no RTE processing is available

If somebody has no RTE extension available, there is also no
RTE processing information available, so the default
from RteHtmlParser is used. However, tags like <abbr>
are then not provided by the yaml configuration, so they are
not allowed, and thus - escaped.

The patch adds abbr,acronym and dfn to be allowed all the time.

Resolves: #83424
Releases: master, 8.7
Change-Id: Ifdc0e7f155bef95a7c397584f2cf7b1eab61f6bb
Reviewed-on: https://review.typo3.org/58745
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Add margin-bottom for tab-content 72/58572/5
Nikita Hovratov [Wed, 3 Oct 2018 19:06:44 +0000 (21:06 +0200)]
[BUGFIX] Add margin-bottom for tab-content

This adds a margin between the tab-content and the submit-button in the
extension configuration form.

Resolves: #86562
Releases: master
Change-Id: Ifdbf30af3cb92162c876c49b46d32776b654991e
Reviewed-on: https://review.typo3.org/58572
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Do not require */ext to be writable in Composer Mode 72/57772/3
Łukasz Uznański [Sat, 31 Mar 2018 23:33:34 +0000 (01:33 +0200)]
[BUGFIX] Do not require */ext to be writable in Composer Mode

Resolves: #81857
Releases: master
Change-Id: I2dc07e8ac23edad2c7bd4880c4fd12ebcf2e40d6
Reviewed-on: https://review.typo3.org/57772
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Resolve correct page in slug validation 29/58229/8
Oliver Hader [Sat, 8 Sep 2018 12:54:45 +0000 (14:54 +0200)]
[BUGFIX] Resolve correct page in slug validation

The SlugHelper now receives an encapsulated RecordState object that
represents a record.

This allows fine-grained control over a record and helps resolving
related information, which is required to resolve slugs properly in a
case where e.g. the node ("parent") and language uid can occur multiple
times.

The RecordState contains:

- an EntityContext which describes a variant of a record by its language
  and workspace assignment

- a node object (EntityPointer) that points to the node (aka "parent") of
  the record

- a EntityUidPointer that describes the origin of the record by its table
  name and uid

The RecordStateFactory creates such RecordState objects and enriches them
with links (EntityPointerLink) that point to languages and versions, that
are also represented by EntityPointer implementations.

Resolves: #86195
Releases: master
Change-Id: If17a30e98f802825d80e95044572153f2426bea2
Reviewed-on: https://review.typo3.org/58229
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Move page fields to new tab 'social media' 18/58718/3
Jasmina Ließmann [Fri, 26 Oct 2018 15:03:22 +0000 (17:03 +0200)]
[TASK] Move page fields to new tab 'social media'

Move fields for open graph and twitter card to a new tab 'social media'

Resolves: #86514
Releases: master
Change-Id: I293f250b57f6bba3c696e77550584912db3491eb
Reviewed-on: https://review.typo3.org/58718
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update typo3/cms-composer-installers to 2.2.1 42/58742/2
Christian Kuhn [Sat, 27 Oct 2018 20:03:20 +0000 (22:03 +0200)]
[TASK] Update typo3/cms-composer-installers to 2.2.1

Upgrade from 2.2.0 to 2.2.1 which allows PHP 7.3
in this dependency.

composer update typo3/cms-composer-installers

Resolves: #86772
Releases: master
Change-Id: I04ca2bd7af007321de7ea0d010b073e113e4cb61
Reviewed-on: https://review.typo3.org/58742
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Detect recursions in PageContentErrorHandler 15/58615/3
Simon Praetorius [Thu, 11 Oct 2018 12:43:09 +0000 (14:43 +0200)]
[BUGFIX] Detect recursions in PageContentErrorHandler

Possible recursions that can occur while fetching the content of an error page are now detected and resolved.

Resolves: #86626
Releases: master
Change-Id: I72ca04bd57ac400e14a06231218cee903c713675
Reviewed-on: https://review.typo3.org/58615
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Show original error in ReflectionService exception 30/58730/7
Susanne Moog [Sat, 27 Oct 2018 10:58:50 +0000 (12:58 +0200)]
[BUGFIX] Show original error in ReflectionService exception

Instead of displaying a custom error message, let the original
exception message be part of the ReflectionException to differentiate
if the original class or any of the type hints has a problem.

Resolves: #86742
Releases: master, 8.7
Change-Id: I215ce779812b43f8bca5e6dfd2052461686482a7
Reviewed-on: https://review.typo3.org/58730
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] In BE: MetaTags are not cached by page rendering 34/58734/3
Ursula Klinger [Sat, 27 Oct 2018 13:49:39 +0000 (15:49 +0200)]
[BUGFIX] In BE: MetaTags are not cached by page rendering

Calling the redirect module in the BE, the page renderer is called
without a specified $GLOBALS['TSFE']->page['uid']. So the meta tags
could not be cached.

Resolves: #86769
Releases: master
Change-Id: I39c099c7c0d13dda0c7098a2f798671b6d7b3f5b
Reviewed-on: https://review.typo3.org/58734
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add more doktypes to be excluded from XML sitemap by default 15/58715/5
Richard Haeser [Fri, 26 Oct 2018 14:06:31 +0000 (16:06 +0200)]
[TASK] Add more doktypes to be excluded from XML sitemap by default

Shortcuts and backend user sections should be removed from the XML
sitemap because a search engine should not index those pages
by default.

An integrator can always override this setting.

Resolves: #86690
Releases: master
Change-Id: I1b6c2299dc01d315c0aefe2205436037f045dc8c
Reviewed-on: https://review.typo3.org/58715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[BUGFIX] Also process array in InputSlugElement 00/58700/6
Daniel Goerz [Thu, 25 Oct 2018 14:07:15 +0000 (16:07 +0200)]
[BUGFIX] Also process array in InputSlugElement

It is possible that the incoming $row contains an array
at the $languageField. This patch assures that the
$languageId can always be determined.

Resolves: #86734
Resolves: #86554
Relates: #86754
Releases: master
Change-Id: Ia2c8621cd935788f33a9b625ec0226a22e21b123
Reviewed-on: https://review.typo3.org/58700
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Linkvalidator validates linked content elements 12/57612/6
Patrick Broens [Mon, 16 Jul 2018 13:49:45 +0000 (15:49 +0200)]
[BUGFIX] Linkvalidator validates linked content elements

This patch makes the LinkValidator check typolinks to tt_content
elements like t3://page?uid=x#y by calling InternalLinktype twice, once
for the page as first part of the SoftReferenceIndex and again for the
tt_content element as second part.

Resolves: #85576
Related: #84016
Releases: master, 8.7
Change-Id: I94243e66f5eff38c9a0b0859a85aac48885e38ba
Reviewed-on: https://review.typo3.org/57612
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Avoid excluding fields in copyToLanguage 35/58235/5
Oliver Hader [Sun, 9 Sep 2018 09:17:33 +0000 (11:17 +0200)]
[BUGFIX] Avoid excluding fields in copyToLanguage

Given that a TCA column is using 'l10n_mode' => 'exclude' and creating
a "free localization" of that record using DataHandler's copyToLanguage
command, the according field stays empty in the created localization.

The expected behavior is that the accordings field is still duplicated
once on creating the duplicate for a particular language. Title prefix
"[Translate to <language>:]" is expected to be missing here since it
is the result of a copy command instead of a localize command.

Resolves: #86203
Releases: master
Change-Id: Ib9914a8d02cbbabdbdc56720a983b6314a34709b
Reviewed-on: https://review.typo3.org/58235
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Respect no_index while creating canonical and hreflang tags 88/58588/3
Richard Haeser [Sat, 6 Oct 2018 19:05:13 +0000 (21:05 +0200)]
[BUGFIX] Respect no_index while creating canonical and hreflang tags

When the current page is set to no_index, no canonical tag
and hreflang tags will be generated.

Resolves: #86569
Releases: master
Change-Id: I7e5360bc9159e31a4ffaa352a05ba0d8296693ed
Reviewed-on: https://review.typo3.org/58588
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Marc Hirdes <hirdes@clickstorm.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add field pages.hidden to rootline default fields 27/58727/2
Joerg Kummer [Sat, 27 Oct 2018 01:43:21 +0000 (03:43 +0200)]
[TASK] Add field pages.hidden to rootline default fields

Adding field 'hidden' to default field list of rootline page requests
ensures more detailed rendering of page status in FLUID using
ViewHelper core:iconForRecord.

Resolves: #86512
Releases: master
Change-Id: I111d9cb22c47d735029603463cf43c0837a0f732
Reviewed-on: https://review.typo3.org/58727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Allow relative URLs in locationHeaderUrl 05/58705/9
Susanne Moog [Thu, 25 Oct 2018 20:18:45 +0000 (22:18 +0200)]
[BUGFIX] Allow relative URLs in locationHeaderUrl

Resolves: #81720
Releases: master, 8.7
Change-Id: I099c905bf335a13fafa920c2849fd88971dc0e44
Reviewed-on: https://review.typo3.org/58705
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Ursula Klinger <klinger@punkt.de>
Tested-by: Ursula Klinger <klinger@punkt.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Update display of text under the translated input field 93/58693/4
Jasmina Liessmann [Thu, 25 Oct 2018 09:25:30 +0000 (11:25 +0200)]
[BUGFIX] Update display of text under the translated input field

Break words in text of default language under the translated input field.

Resolves: #84020
Releases: master
Change-Id: I07e0f0d75439b0ccba95f998d6c68276e649a939
Reviewed-on: https://review.typo3.org/58693
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Use correct type for header value 23/58723/4
Daniel Goerz [Fri, 26 Oct 2018 17:27:44 +0000 (19:27 +0200)]
[BUGFIX] Use correct type for header value

Resolves: #86758
Releases: master
Change-Id: Ia0803d4ba68e0913478e4cfa9173cce5e1c5b5db
Reviewed-on: https://review.typo3.org/58723
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Pass status code as int to RedirectResponse 31/58731/3
Thomas Alboth, undkonsorten [Sat, 27 Oct 2018 11:06:52 +0000 (13:06 +0200)]
[BUGFIX] Pass status code as int to RedirectResponse

The filelist module shows an error when creating an new textfile
with a file extension that is not allowed via [SYS][textfile_ext],
e.g. test.md and sends an according RedirectResponse.

The RedirectResponse constructor call has been fixed to be called with
an int instead of a string as status code.

Resolves: #86765
Releases: master
Change-Id: I63ea741223db21b8e4f8fbda1cc958b608ff981e
Reviewed-on: https://review.typo3.org/58731
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Always set overrideVals when editing a page 12/58712/4
Daniel Goerz [Fri, 26 Oct 2018 13:24:51 +0000 (15:24 +0200)]
[BUGFIX] Always set overrideVals when editing a page

Resolves: #86754
Releases: master
Change-Id: I2bb3226595e53ed993e0114130123e4f87f1603b
Reviewed-on: https://review.typo3.org/58712
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Refactor AdminPanel JavaScript 99/58699/5
Oliver Hader [Fri, 26 Oct 2018 11:13:45 +0000 (13:13 +0200)]
[TASK] Refactor AdminPanel JavaScript

- move to namespaced functions
- remove console log on copy

Prerequisite for further bug fixes.

Resolves: #86744
Releases: master
Change-Id: I7647cd7b75bab999680806fc65dddcec9271717f
Reviewed-on: https://review.typo3.org/58699
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Update codemirror to 5.40.2 62/58662/2
Andreas Fernandez [Fri, 19 Oct 2018 10:19:03 +0000 (12:19 +0200)]
[TASK] Update codemirror to 5.40.2

Used commands:
yarn add codemirror@^5.40.0 --dev
grunt build

Resolves: #86700
Releases: master
Change-Id: I07a146e2ca108339092e16d769fef8031e783511
Reviewed-on: https://review.typo3.org/58662
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Recover switched items in maxitems=1 selectMultipleSideBySide 99/58599/4
Kevin von Spiczak [Tue, 9 Oct 2018 11:32:37 +0000 (13:32 +0200)]
[BUGFIX] Recover switched items in maxitems=1 selectMultipleSideBySide

Shows and re-enables all the options, that are currently not selected
when using maxitems = 1

Resolves: #86594
Releases: master, 8.7
Change-Id: I1f5e727ec42203981edaaf4b79bb6e201352d296
Reviewed-on: https://review.typo3.org/58599
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Nicolai Schirawski <ns@t3magic.de>
Tested-by: Nicolai Schirawski <ns@t3magic.de>
Reviewed-by: Eike Starkmann <starkmann@undkonsorten.com>
Tested-by: Eike Starkmann <starkmann@undkonsorten.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Give install tool a fresher look 43/58543/4
Benjamin Kott [Mon, 1 Oct 2018 19:34:31 +0000 (21:34 +0200)]
[TASK] Give install tool a fresher look

During the last-minute changes before LTS, some stylings in the
Maintenance area were done to streamline the look&feel, but the
installer process should get an update look as well.

Resolves: #86756
Releases: master
Change-Id: Idb58da1f467c27ce3e12252f201e031c2faaedc2
Reviewed-on: https://review.typo3.org/58543
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Remove surrounding &nsbp; in the tables with ol or ul in CKEditor 77/57777/4
Łukasz Uznański [Thu, 2 Aug 2018 12:07:13 +0000 (14:07 +0200)]
[BUGFIX] Remove surrounding &nsbp; in the tables with ol or ul in CKEditor

This patch removes generated &nbsp; in tables with ol or ul inside. This
is unintented behaviour, and we can't manually remove them from table.

Also, I moved HTMLparser section into existing nonTypoTagStdWrap

Resolves: #83795
Releases: master, 8.7
Change-Id: I711e4cbab8249fe6f43c8abe6f63183eaac9131f
Reviewed-on: https://review.typo3.org/57777
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Thomas Alboth, undkonsorten <ta@undkonsorten.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Display FlashMessage in View Module 73/58573/6
Oliver Bartsch [Wed, 3 Oct 2018 19:53:32 +0000 (21:53 +0200)]
[BUGFIX] Display FlashMessage in View Module

When clicking on the root page while in view module
a FlashMessage is now displayed with proper information.
The FlashMessage is also shown in the case of clicking the
root page and a Page, marked as siteroot, exists.
Furthermore the FlashMessage is now also shown if the
selected page has no valid doktype e.g. sysfolder
or spacer.

Resolves: #86563
Releases: master
Change-Id: Ia8c6cddfe38602c94b41d5da81987d061778096f
Reviewed-on: https://review.typo3.org/58573
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Avoid exception of renderType selectCheckBox in workspace 84/57484/4
Alexey Atsyn [Fri, 6 Jul 2018 14:03:50 +0000 (19:03 +0500)]
[BUGFIX] Avoid exception of renderType selectCheckBox in workspace

Resolves: #85109
Releases: master, 8.7
Change-Id: I34a269ec2d564a546d4dc2036a97eb1027d2352f
Reviewed-on: https://review.typo3.org/57484
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Prevent null value being passed to hash_equals 96/58596/5
Sascha Egerer [Mon, 8 Oct 2018 23:13:49 +0000 (01:13 +0200)]
[BUGFIX] Prevent null value being passed to hash_equals

The second parameter of hash_equals must be a string but could be a
null value in the FileDumpController. It is ensured now that the
value is always a string.

Resolves: #86599
Releases: master, 8.7
Change-Id: Iaf682b405be6712aa31603521a2d873b4c3bcb89
Reviewed-on: https://review.typo3.org/58596
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Show deleted records in recycler 60/58660/2
Stefan Froemken [Fri, 19 Oct 2018 07:45:34 +0000 (09:45 +0200)]
[BUGFIX] Show deleted records in recycler

Show deleted records in recycler also when
related be_user was deleted completely from database.

Resolves: #86696
Releases: master
Change-Id: Idc16781ce4bb0c28be48cc86052738110c500165
Reviewed-on: https://review.typo3.org/58660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Ursula Klinger <klinger@punkt.de>
Tested-by: Ursula Klinger <klinger@punkt.de>
Tested-by: Eike Starkmann <starkmann@undkonsorten.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Add EXT:recordlist as dependency of EXT:backend 75/58575/7
Jan Stockfisch [Thu, 4 Oct 2018 09:24:25 +0000 (11:24 +0200)]
[BUGFIX] Add EXT:recordlist as dependency of EXT:backend

Resolves: #86567
Releases: master
Change-Id: Ida5a35fe28b32f100779b048bc9b676cb2bd099e
Reviewed-on: https://review.typo3.org/58575
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 months ago[BUGFIX] Properly reference config.yaml instead of config.yml 09/58709/2
Benni Mack [Fri, 26 Oct 2018 12:06:05 +0000 (14:06 +0200)]
[BUGFIX] Properly reference config.yaml instead of config.yml

There is one wrong documentation about config.yaml of
site configuration, where it is `config.yml`, however,
TYPO3 Core always uses the `yaml` file ending.

Resolves: #86752
Releases: master
Change-Id: I06605ca83baa453bc64da96d321f7a22b0893687
Reviewed-on: https://review.typo3.org/58709
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[BUGFIX] CleanerTask processes all FileResource Fields 12/57112/4
Sven Jürgens [Fri, 1 Jun 2018 13:19:32 +0000 (15:19 +0200)]
[BUGFIX] CleanerTask processes all FileResource Fields

By removing an errorous break in a loop, all FileResource Fields are found
and therefor all connected files can be deleted.

Resolves: #85140
Releases: master, 8.7
Change-Id: I0aea4427dd9e74b1a11ab04e8aa235e17ae1a031
Reviewed-on: https://review.typo3.org/57112
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Properly mock LocalizationFactory in form tests 03/58703/2
Susanne Moog [Thu, 25 Oct 2018 18:49:02 +0000 (20:49 +0200)]
[BUGFIX] Properly mock LocalizationFactory in form tests

Resolves: #86704
Releases: master
Change-Id: Ie30f22e641d76890a97bc47c51665d697aad93f5
Reviewed-on: https://review.typo3.org/58703
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Execute tests via docker 89/57789/29
Christian Kuhn [Fri, 3 Aug 2018 10:00:52 +0000 (12:00 +0200)]
[TASK] Execute tests via docker

The patch adds a new entry script Build/Script/runTests.sh
that hides away all the complexity of test suite execution
and docker details to execute everything that bamboo performs
locally via docker.

Use Build/Script/runTests.sh -h for an overview of available
options.

Example call to execute all functional tests on postgres DBMS
and sending xdebug output to a local (phpstorm) listening on
port 9000:
Build/Script/runTests.sh -s functional -d postgres -x

Change-Id: Idaaf0a90ed1a0ba0f31c1b7128dd9d564335e056
Resolves: #86746
Releases: master
Reviewed-on: https://review.typo3.org/57789
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Register "then"/"else" in IfHasRoleViewHelper again 92/58692/2
Mathias Brodala [Thu, 25 Oct 2018 09:07:58 +0000 (11:07 +0200)]
[BUGFIX] Register "then"/"else" in IfHasRoleViewHelper again

This fixes the usage of "then" and "else" for the inline notation.

Resolves: #86743
Releases: master, 8.7
Change-Id: Ia0a749fedcb3b3d4ffe7f90ac40ab604fd7c340a
Reviewed-on: https://review.typo3.org/58692
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 months ago[BUGFIX] Allow fallback to default language in site config 98/58698/2
Daniel Goerz [Thu, 25 Oct 2018 11:01:05 +0000 (13:01 +0200)]
[BUGFIX] Allow fallback to default language in site config

Resolves: #86597
Releases: master
Change-Id: I119a83a76bb3b5695965490434daef78245c27dd
Reviewed-on: https://review.typo3.org/58698
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Allow editing of pages with language ID > 9 96/58696/2
Daniel Goerz [Thu, 25 Oct 2018 10:49:47 +0000 (12:49 +0200)]
[BUGFIX] Allow editing of pages with language ID > 9

Resolves: #86734
Releases: master
Change-Id: Ib26c0336531e1e692f73ccc431b7091c47755ce9
Reviewed-on: https://review.typo3.org/58696
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Allow rendering of description for InputSlugElement 81/58681/2
Georg Ringer [Wed, 24 Oct 2018 07:46:43 +0000 (09:46 +0200)]
[TASK] Allow rendering of description for InputSlugElement

The description must be available for the InputSlugElement as well to give
editors an additional guidance.

Resolves: #86720
Releases: master
Change-Id: Iaa70a6e62209eb72cbe51be91727c8bed775fac6
Reviewed-on: https://review.typo3.org/58681
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Let CObjectViewHelper render top level objects again 86/58686/3
Helmut Hummel [Wed, 24 Oct 2018 16:46:19 +0000 (18:46 +0200)]
[BUGFIX] Let CObjectViewHelper render top level objects again

Making the CObjectViewHelper had the unfortunate side effect,
that top level object paths are not working any more.

Adapt the tests to show the mistake and make the rendering
work in this case.

Additionally now an exception is also thrown, if the given
object path does not resolve to a TypoScript object.

Releases: master
Resolves: #86729
Related: #84345
Change-Id: I686119b480c6fae88be7d704b82094e35789c0d7
Reviewed-on: https://review.typo3.org/58686
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Assure that $_POST is never set to null 82/58682/4
Daniel Goerz [Wed, 24 Oct 2018 08:05:24 +0000 (10:05 +0200)]
[BUGFIX] Assure that $_POST is never set to null

Resolves: #86731
Releases: master
Change-Id: Ia48925cf98637d7c7b2ecfb071bc935508032dec
Reviewed-on: https://review.typo3.org/58682
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Update php-cs-fixer configuration to exclude _generated directory 83/58683/2
Sybille Peters [Wed, 24 Oct 2018 08:21:38 +0000 (10:21 +0200)]
[TASK] Update php-cs-fixer configuration to exclude _generated directory

Resolves: #86730
Releases: master, 8.7
Change-Id: I9e707e6d9c1305baa92b7f2c4c0f83bbeea52daa
Reviewed-on: https://review.typo3.org/58683
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[BUGFIX] Remove `fbclid` argument from chash calculation 71/58671/2
Andreas Fernandez [Tue, 23 Oct 2018 06:17:56 +0000 (08:17 +0200)]
[BUGFIX] Remove `fbclid` argument from chash calculation

Facebook adds the `fbclid` argument to outbound URLs which triggers a
recalculcation of the cache hash. The argument is now added to the
blacklist for chash parameters.

Resolves: #86715
Releases: master, 8.7, 7.6
Change-Id: I8cd66fdfa2c549c65750d6ef896261cccba4b54d
Reviewed-on: https://review.typo3.org/58671
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Remove duplicate XLIFF entry 70/58670/4
Xavier Perseguers [Mon, 22 Oct 2018 09:13:51 +0000 (11:13 +0200)]
[TASK] Remove duplicate XLIFF entry

Resolves: #86135
Releases: master
Change-Id: I2b77b58aeb5bdbd12e9186b1b18d8b82a9dbfe6d
Reviewed-on: https://review.typo3.org/58670
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Tested-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>