Packages/TYPO3.CMS.git
5 years ago[TASK] Find functional tests automatically, optimize travis-ci 01/29901/2
Christian Kuhn [Tue, 6 May 2014 18:15:39 +0000 (20:15 +0200)]
[TASK] Find functional tests automatically, optimize travis-ci

Simalar to UnitTests.xml, FunctionalTests.xml no longer register
single test suites but find all functional tests cases using a
wildcard.

For travis-ci, single tests cases are now given to parallel using
gnu find. This leads to a nice performance improvement on travis
since more but shorter processes are executed, sharing the available
hardware more effectively.

Change-Id: I8dc34ed2fcc1ae8390bc05dbe6f5e7009af17a36
Resolves: #58578
Related: #58533
Releases: 6.2
Reviewed-on: https://review.typo3.org/29901
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] Clean up functional tests 48/29848/3
Felix Oertel [Sun, 4 May 2014 11:45:11 +0000 (13:45 +0200)]
[CLEANUP] Clean up functional tests

To allow running of all functional tests, instead of
relying on travis.yml, we want to clean up broken and
abandoned tests.

So we remove the tests that fatal because they are not
meant to be used in the functional testing framework.

Resolves: #58445
Releases: 6.2
Change-Id: I8fd021a9814dec43f71200641c9ba1ebbc0e32d0
Reviewed-on: https://review.typo3.org/29848
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jan Helke
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] ext:rsaauth cliBackend pollutes cli output 77/29877/7
Christian Kuhn [Mon, 5 May 2014 16:50:52 +0000 (18:50 +0200)]
[BUGFIX] ext:rsaauth cliBackend pollutes cli output

The CommandLineBackend using exec "openssl genrsa" outputs its key
generation to standard error. If SAPI is cli (eg. in unit tests),
this is is shown to the user. The patch silences openssl by
redirecting stderr to /dev/null (NUL on Windows systems).

Resolves: #58530
Related: #51436
Releases: 6.2
Change-Id: I702d2d3180bc2e32e5548a4402d4eefb02dd2523
Reviewed-on: https://review.typo3.org/29877
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Inaccessible pages on shortcuts/PageNotFound handler 90/21390/9
Alexander Opitz [Thu, 13 Jun 2013 13:48:17 +0000 (15:48 +0200)]
[BUGFIX] Inaccessible pages on shortcuts/PageNotFound handler

The var pageNotFound is set, if the called page has access
restrictions. Afterwards starts a searching for an accessible page
in the rootline upwards.

If that page is a short link which also isn't accessible we stop
instead of searching again in this new rootline. Limiting this to a
maximum of 20 iterations to prevent endless loops.

If an accessible page is found we do not reset the pageNotFound var.
The PageNotFound handler reacts on this var and redirects to the 404
page instead of presenting the accessible page we found later on.

You can reproduce this with the introduction package, for example
change the access to the Example/Tables page to "Customer".
Afterwards go to http://yourdomain/?id=38 and you will see the 404
page. If you disable the pageNotFound_handling you will see the
content of the Example page.

Resolves: #16472
Releases: 6.2, 6.1
Change-Id: I1e58ec1f96422c6bf3e5c9c74f1b1c1666b68762
Reviewed-on: https://review.typo3.org/21390
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] EXT:saltedpasswords remove dependency on EXT:setup 56/29656/8
Markus Klein [Fri, 25 Apr 2014 13:26:11 +0000 (15:26 +0200)]
[BUGFIX] EXT:saltedpasswords remove dependency on EXT:setup

As saltedpasswords is required for backend and can't be uninstalled, we
can remove the implicit dependency on extension "setup" by adjusting
the default settings there.

Resolves: #58192
Releases: 6.2
Change-Id: I6490b9962924c0e384243f663f3e5057c947749e
Reviewed-on: https://review.typo3.org/29656
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Always convert webroot to unix styled path 93/29893/2
Nicole Cordes [Tue, 6 May 2014 10:28:38 +0000 (12:28 +0200)]
[BUGFIX] Always convert webroot to unix styled path

This patch adds the conversion from Windows styled to unix styled path.

Resolves: #58559
Releases: 6.2
Change-Id: I2b5b431fe60531ab1ad1c75bf9fd7749414c4df2
Reviewed-on: https://review.typo3.org/29893
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Properly check existence of array item 43/29343/6
Markus Klein [Thu, 10 Apr 2014 16:01:56 +0000 (18:01 +0200)]
[BUGFIX] Properly check existence of array item

The flexform converter in ContentObjectRenderer tries to access
an array element on a non-array.

Check existence with isset() first.

Resolves: #57809
Releases: 6.2, 6.1
Change-Id: I8e6111afee3a639b3077dc59bc2e32b72fa12f5c
Reviewed-on: https://review.typo3.org/29343
Reviewed-by: Oliver Klee
Tested-by: Jost Baron
Reviewed-by: Wouter Wolters
Reviewed-by: Julian Wundrak
Tested-by: Julian Wundrak
Reviewed-by: Stefan Neufeind
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] DependencyUtility does count() on an integer 76/29876/3
Markus Klein [Mon, 5 May 2014 16:51:16 +0000 (18:51 +0200)]
[BUGFIX] DependencyUtility does count() on an integer

Remove the superfluous count() call.

Resolves: #58529
Releases: 6.2, 6.1, 6.0
Change-Id: I0933650b52063009de52268034480f6e06af56ac
Reviewed-on: https://review.typo3.org/29876
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Don't send HTTP headers in CLI context 54/29554/2
Gabe Blair [Thu, 17 Apr 2014 20:26:42 +0000 (13:26 -0700)]
[BUGFIX] Don't send HTTP headers in CLI context

Resolves: #58029
Releases: 6.2
Change-Id: If2a5f41e8524c457a20dec810f711f546d4fbb8c
Reviewed-on: https://review.typo3.org/29554
Reviewed-by: Stefan Neufeind
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Set internalUploadMap on upload in ExtendedFileUtility 20/29820/2
Marc Bastian Heinrichs [Sat, 3 May 2014 17:34:24 +0000 (19:34 +0200)]
[BUGFIX] Set internalUploadMap on upload in ExtendedFileUtility

Since introducing FAL the internalUploadMap array in
ExtendedFileUtility was not set on uploading files.

Resolves: #58463
Releases: 6.2, 6.1, 6.0
Change-Id: I4a537a57f1b688c26c20b9f68356a4be67bc5851
Reviewed-on: https://review.typo3.org/29820
Reviewed-by: Sascha Wilking
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Group permissions for new pages are not set 75/29875/2
Markus Klein [Mon, 5 May 2014 16:06:55 +0000 (18:06 +0200)]
[BUGFIX] Group permissions for new pages are not set

This is a regression to #54085 which accidentally converted a !strcmp()
to !==.

Resolves: #56393
Releases: 6.2
Change-Id: Ie0b2e169916e6b0ea848510e615b05d68be02199
Reviewed-on: https://review.typo3.org/29875
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Loek Hilgersom
Tested-by: Loek Hilgersom
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Tests: Find all tests automatically 79/29879/2
Christian Kuhn [Mon, 5 May 2014 17:56:55 +0000 (19:56 +0200)]
[TASK] Tests: Find all tests automatically

All regular unit tests are located at
typo3/sysext/"extension"/Tests/Unit. The patch substitutes the single
suite registration in UnitTests.xml with a wildcard, only "Legacy"
and "Integration" tests are still registered as special locations.

Following this schema, tests located at default locations within
extensions will be found automatically without explicit registration.

Resolves: #58533
Related: #51436
Releases: 6.2
Change-Id: Ic822a68f60060437d2e3aabea7754f5b1e72af50
Reviewed-on: https://review.typo3.org/29879
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Tests: Activate ext:rsaauth test suite 78/29878/2
Christian Kuhn [Mon, 5 May 2014 17:16:56 +0000 (19:16 +0200)]
[TASK] Tests: Activate ext:rsaauth test suite

The test suite of ext:rsaauth is missing in UnitTests.xml, add it.

Resolves: #58531
Related: #58530
Related: #51436
Releases: 6.2
Change-Id: I5c1c8bbf415ed53270a09bdf68df300e28eb5f09
Reviewed-on: https://review.typo3.org/29878
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Search box list module not shown 73/29873/2
Frans Saris [Mon, 5 May 2014 15:21:05 +0000 (17:21 +0200)]
[BUGFIX] Search box list module not shown

The search box at the bottom of the BE List module
disappears when you search for something and there
are no records found.

This patch makes sure the search box is also shown
when a search was done.

Resolves: #58526
Releases: 6.2
Change-Id: I95385bbdd988c4fb036d8bdc0c6b30638020a1cc
Reviewed-on: https://review.typo3.org/29873
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Tests: Refactor and activate dbal tests 74/29874/2
Christian Kuhn [Mon, 5 May 2014 15:21:49 +0000 (17:21 +0200)]
[TASK] Tests: Refactor and activate dbal tests

Our unit test environment is finally ready to execute existing dbal
unit tests, even if no database connection exists.

The patch refactors unit tests of ext:dbal, modernizes their codebase
and adds them to the build.

Resolves: #52527
Related: #51436
Releases: 6.2
Change-Id: I70507591dc89331d658d50196dfcaea002caa7d5
Reviewed-on: https://review.typo3.org/29874
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] saltedpasswords: Check rsaauth loading 59/29859/7
Nicole Cordes [Sun, 4 May 2014 17:45:48 +0000 (19:45 +0200)]
[BUGFIX] saltedpasswords: Check rsaauth loading

This patch adds the loading check of rsaauth before trying to access the
BackendFactory of rsaauth. Otherwise the extension manager gets broken
on entering extension configuration.

Resolves: #58504
Releases: 6.2, 6.1
Change-Id: I197fb5e032b31e6add388269f77e6fc834e45b54
Reviewed-on: https://review.typo3.org/29859
Reviewed-by: Markus Klein
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Fix broken impexp functional tests 57/29857/3
Markus Klein [Sun, 4 May 2014 15:34:05 +0000 (17:34 +0200)]
[BUGFIX] Fix broken impexp functional tests

Issue #58484 fixed the inclusion of CSS class
attributes in typolinks, but did not adjust the
impexp tests. Update the affected fixture data.

Resolves: #58503
Releases: 6.2
Change-Id: Ib71d50d03d045db37cd411523b54f8c6a1837833
Reviewed-on: https://review.typo3.org/29857
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years agoRevert "[BUGFIX] Fix broken impexp functional test" 56/29856/2
Marc Bastian Heinrichs [Sun, 4 May 2014 17:12:16 +0000 (19:12 +0200)]
Revert "[BUGFIX] Fix broken impexp functional test"

Doesn't fix the tests completely.

This reverts commit 8ae7a4b9eb9efc6b392fba3151cfe34ea51d2099

Change-Id: Ifadcc61d2bf159c5d70f4f1b5b8d436471a79f76
Reviewed-on: https://review.typo3.org/29856
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Fix broken impexp functional test 54/29854/4
Markus Klein [Sun, 4 May 2014 15:34:05 +0000 (17:34 +0200)]
[BUGFIX] Fix broken impexp functional test

Issue #58484 fixed the inclusion of CSS classes
in typolinks, but did not adjust the tests.
Update the affected fixture data.

Resolves: #58503
Releases: 6.2
Change-Id: I511847bda3e393f104f1f141fb3a0bed4a97c1b1
Reviewed-on: https://review.typo3.org/29854
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] SoftReferenceIndex support for more values in class attribute 46/29846/2
Marc Bastian Heinrichs [Sun, 4 May 2014 10:42:47 +0000 (12:42 +0200)]
[BUGFIX] SoftReferenceIndex support for more values in class attribute

The SoftReferenceIndex parses and rebuilds typolink tags, but the
support for more than one value in class attribute is missing, because
the values don't get enclosed with quotes on rebuilding.
This leads to lost classes in typolinks in exports from impexp.

Resolves: #58484
Releases: 6.2, 6.1, 4.5
Change-Id: I12ed3be7f5be36254bcee57fcb24bf2a10f92f46
Reviewed-on: https://review.typo3.org/29846
Reviewed-by: Wouter Wolters
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix file handling in import/export module 94/25294/8
Oliver Hader [Tue, 12 Nov 2013 00:26:56 +0000 (01:26 +0100)]
[BUGFIX] Fix file handling in import/export module

The file handling (downloading/storing or uploading/fetching
existing T3D/XML files) is currently not full FAL compatible in the
import/export module of the TYPO3 CMS backend. Also saving
export file to folder on server shows an error, but the file is saved.

In further TYPO3 version the .htaccess protected folder
fileadmin/_temp_/ was used to store the export files. This was lately
changed to the public accessible users default upload folder,
normally fileadmin/user_upload/. This patch changes this
back to a .htaccess protected folder, namely _temp_/importexport/
below users default upload folder.

Resolves: #53552
Releases: 6.2
Change-Id: I250e08188d9e9aac011c759fccf7e831fea037fb
Reviewed-on: https://review.typo3.org/25294
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[TASK] Enhance localization behavior of pages.media 39/29839/2
Oliver Hader [Sun, 4 May 2014 09:01:45 +0000 (11:01 +0200)]
[TASK] Enhance localization behavior of pages.media

With issue #57488 the pages.media field became localizable again,
however the selective approach turns out to be problematic in
terms of overlaying data in the frontend (the "mergeIfNotBlank"
settings and the like).
Thus, instead of letting the editor localize the references after
persisting the parent and having to overlay/fallback in the
frontend, now the references are already shown in the edit view
during the localization (still before being persisted).

Resolves: #58476
Releases: 6.2
Change-Id: Id6980f2a5cfea109375afce27f62cad8c101c58e
Reviewed-on: https://review.typo3.org/29839
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Disable removal of installed extensions 49/29849/3
Nicole Cordes [Sun, 4 May 2014 11:54:04 +0000 (13:54 +0200)]
[BUGFIX] Disable removal of installed extensions

This patch removes the deletion possibility for installed extension in
the list view of the extension manager. Furthermore the javascript can
be adopted as the check for installed extensions can be removed as well.

Resolves: #58493
Related: #53459
Releases: 6.2
Change-Id: I713bbb93230108db144044be9184e77f484931c9
Reviewed-on: https://review.typo3.org/29849
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Nadir S.
Tested-by: Nadir S.
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Limit FileTableSplittingUpdate to TYPO3 6.0/6.1 24/29024/6
Alexander Opitz [Tue, 1 Apr 2014 12:56:04 +0000 (14:56 +0200)]
[BUGFIX] Limit FileTableSplittingUpdate to TYPO3 6.0/6.1

If the database field does not exist it may be that we have an
installation before 6.0 or after 6.1 so we do not need to migrate
the data to sys_file_metadata. This prevents empty metadata
information which may lead to other issues.
(width/height=0 for images)

Resolves: #57492
Related: #46020
Releases: 6.2
Change-Id: Id5826ea480d4139f2e232587fc2b119928b28bc8
Reviewed-on: https://review.typo3.org/29024
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Nicole Cordes
Reviewed-by: Anja Leichsenring
Reviewed-by: Jan Runte
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Fix dragging of elements in page module 37/29837/4
Jan Runte [Sat, 3 May 2014 21:01:33 +0000 (23:01 +0200)]
[BUGFIX] Fix dragging of elements in page module

When dragging content elements in the page module, the element gets
overlayed by TCEform elements. It loses its hover state, when dragged
outside the viewport or very rapidly.

* Set z-index higher than 4000
* Add a css class to stabilize active drag state
* Remove duplicated javascript code in page module

Resolves: #58473
Releases: 6.2, 6.1
Change-Id: I87577d30e5d6bb16f6999d466bef92da95b2add3
Reviewed-on: https://review.typo3.org/29837
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Wouter Wolters
5 years ago[BUGFIX] Flush caches in group should throw exception 81/26981/9
Helmut Hummel [Tue, 21 Jan 2014 14:31:51 +0000 (15:31 +0100)]
[BUGFIX] Flush caches in group should throw exception

If a not existent cache group is specified
to the flushCachesInGroup methods, there is no
indication that actually nothing happened.

Throw an exception instead, so that calling code
can easily be fixed.

Resolves: #58465
Releases: 6.2
Change-Id: I9617fcee9abfa27a9cb76a3fd12543c62420e719
Reviewed-on: https://review.typo3.org/26981
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
5 years ago[BUGFIX] Fix description of userHomePath and groupHomePath 38/29838/2
Marc Bastian Heinrichs [Sun, 4 May 2014 09:07:32 +0000 (11:07 +0200)]
[BUGFIX] Fix description of userHomePath and groupHomePath

Since making userHomePath and groupHomePath FAL compatible
the descriptions in DefaultConfiguration don't fit anymore.

Resolves: #56986
Releases: 6.2, 6.1
Change-Id: Ia27193b967137dd3744c2fdcf5b5b0d3366c0080
Reviewed-on: https://review.typo3.org/29838
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Detection of image manipulation libs with open_basedir 22/29822/5
Anja Leichsenring [Sat, 3 May 2014 19:28:13 +0000 (21:28 +0200)]
[BUGFIX] Detection of image manipulation libs with open_basedir

If open_basedir is restricted to files, eg. /usr/bin/gm, detection
fails in install tool. The additional is_dir() check may fail then.
The patch removes it since @is_file() covers the same checks.

Resolves: #58466
Releases: 6.2
Change-Id: I5ab6a36ccd3d283a1dc1e672f7deddc2f0ea37c4
Reviewed-on: https://review.typo3.org/29822
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years agoRevert "[TASK] Reduce file size of core images" 28/29828/2
Anja Leichsenring [Sat, 3 May 2014 20:41:52 +0000 (22:41 +0200)]
Revert "[TASK] Reduce file size of core images"

This patch changes the file permissions, so we need to work
some more on it.

This reverts commit 03cf03b28f7f37cab14f2467f6ad1c3134ae5fa4

Change-Id: I21343c8273db1e5173d6b8211cc2fed510e9810e
Reviewed-on: https://review.typo3.org/29828
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Follow-up to Queries don't respect MM_match_fields 21/29821/3
Felix Oertel [Sat, 3 May 2014 18:51:23 +0000 (20:51 +0200)]
[BUGFIX] Follow-up to Queries don't respect MM_match_fields

Fixed two small glitches which escaped us in the review of
https://review.typo3.org/#/c/29713/.

Resolves: #10487
Releases: 6.2
Change-Id: I6425835a3aa349ac47ab0a01cf1241be2df6d187
Reviewed-on: https://review.typo3.org/29821
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Enable alt and link fields for page media 16/29816/2
Frans Saris [Sat, 3 May 2014 15:51:30 +0000 (17:51 +0200)]
[BUGFIX] Enable alt and link fields for page media

As the page.media in most cases is for images it makes
sense to enable the alt and link fields just like
tt_content.images.

This patch changes the default TCA for table pages so
the alt and link fields are enabled for the media
file_references.

Resolves: #56884
Releases: 6.2
Change-Id: I4496644d340a6fab9be18bf4942ea96a22b1b4ce
Reviewed-on: https://review.typo3.org/29816
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Nadir S.
Tested-by: Nadir S.
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] wrong set layer in page module during drag and drop 24/29824/2
Jan Runte [Sat, 3 May 2014 18:37:50 +0000 (20:37 +0200)]
[BUGFIX] wrong set layer in page module during drag and drop

During drag and drop the dragged content element was
overlayed from the next content scope (headline element).

The "z-index" must be fixed here. Just added a hover effect
for the whole draggable content element. The correct value
for the "z-index" may between the z-index values of "topbar"
and "toolbar" (under "structure" stylesheets).

Resolves: #58413
Releases: 6.2, 6.1
Change-Id: I8fa83cec793b5deb7dbbc13553a043b706510904
Reviewed-on: https://review.typo3.org/29824
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Reduce file size of core images 17/29617/5
Christian Kuhn [Sat, 3 May 2014 18:57:59 +0000 (20:57 +0200)]
[TASK] Reduce file size of core images

Reduce the file size without losing quality.
This reduces total typo3 directory size by ~2 MB.

Resolves: #58110
Releases: 6.2
Change-Id: I2062cead3939d93b847f1be741ef8a26bfb0edd8
Reviewed-on: https://review.typo3.org/29617
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Tested-by: Nadir S.
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] AbstractDomainObject _cleanProperties is array 14/29814/4
Roland Waldner [Sat, 3 May 2014 13:57:28 +0000 (15:57 +0200)]
[BUGFIX] AbstractDomainObject _cleanProperties is array

Properly initialize _cleanProperties to array to prevent warnings.

Resolves: #57244
Releases: 6.2
Change-Id: I64f62cbcaf7268740af0e3c51303c49fc343136b
Reviewed-on: https://review.typo3.org/29814
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Oliver Klee
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Improve Windows support for functional tests 57/29057/5
Nicole Cordes [Tue, 1 Apr 2014 22:53:33 +0000 (00:53 +0200)]
[BUGFIX] Improve Windows support for functional tests

Solve some issues running function tests on windows OS

* Disable colors, this is hardly supported in windows CLI,
  enable in .travis.yml explicitly
* Convert the web root path into a unix styled one to prevent a
  mix between backslashes and forward slashes
* Improve finding the PHP binary as the system constants PHP_BINDIR
  is defined with "C:\php" even if PHP is installed in a different folder
* Improves command line argument escaping for special windows
  requirements.

Resolves: #57524
Releases: 6.2
Change-Id: I80b1652e35b816f8ca93929950d014c45b9535d1
Reviewed-on: https://review.typo3.org/29057
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Removed extension stays in PackageStates file 21/26921/4
Wouter Wolters [Sat, 18 Jan 2014 14:57:05 +0000 (15:57 +0100)]
[BUGFIX] Removed extension stays in PackageStates file

Deleting an extension in the Extension Manager doesn't delete
the entry in PackageStates file.

Use the package manager to delete the extension. This will take care of
linked extensions (just remove the link) too.
The package manager will take care to remove the entry from the
PackageStates file.

If an extension is not listed in the PackageStates file (e.g. because
we uploaded it via FTP and forgot to clear the system caches),
directly remove the folder.

Resolves: #53459
Releases: 6.2
Change-Id: I10d5ef33ccf6438fece512478408c57d5d7486de
Reviewed-on: https://review.typo3.org/26921
Reviewed-by: Jan Runte
Tested-by: Jan Runte
Reviewed-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove backslash for UnexpectedValueException in mod.php 31/29731/3
Wouter Wolters [Tue, 29 Apr 2014 19:52:48 +0000 (21:52 +0200)]
[TASK] Remove backslash for UnexpectedValueException in mod.php

Resolves: #58344
Releases: 6.2
Change-Id: Ic2cbc0a9d8a27c67e145ea9fef55c60d13466c33
Reviewed-on: https://review.typo3.org/29731
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Add phpdoc @var for calls to makeInstance() 15/29815/3
Roland Waldner [Sat, 3 May 2014 14:30:46 +0000 (16:30 +0200)]
[TASK] Add phpdoc @var for calls to makeInstance()

Resolves: #58459
Related: #50248
Releases: 6.2
Change-Id: I3b72ecd65dff934a4eff10be7cb3c46ded948a34
Reviewed-on: https://review.typo3.org/29815
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Clear all cache in install tool throws exception 11/29811/7
Sascha Wilking [Sat, 3 May 2014 13:06:41 +0000 (15:06 +0200)]
[BUGFIX] Clear all cache in install tool throws exception

reinitializeClassLoaderAndCachesAndPackageManagement
not only reloads the class loader and package management
but also reloads LocalConfiguratzion and
AdditionalConfiguration. This can lead to errors if
AdditionalConfiguration contains require_once calls.
The method is only used by ClearCacheService which
does not need the configuration reload.

Solution is to remove the method and introduce a new
one to unregister only the class loader. The other
bootstrap methods are now called directly in clear
cache of install tool.

Resolves: #58337
Releases: 6.2
Change-Id: I59cec5f3fc7dacbf83854c0559b4a8b3f143707d
Reviewed-on: https://review.typo3.org/29811
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Jan Runte
Tested-by: Jan Runte
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Remove unnecessary redirect loops for first installation 02/29802/3
Nicole Cordes [Sat, 3 May 2014 10:47:18 +0000 (12:47 +0200)]
[BUGFIX] Remove unnecessary redirect loops for first installation

This patch changes the default configuration to prevent any redirect
loops during the first installation process.

Resolves: #58380
Releases: 6.2
Change-Id: I8c0cbb779ee40b3310d2cb7ad6600d3bcaf4ec41
Reviewed-on: https://review.typo3.org/29802
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Remove hardcoded calling script in help controller 09/29809/3
Helmut Hummel [Sat, 3 May 2014 13:10:44 +0000 (15:10 +0200)]
[BUGFIX] Remove hardcoded calling script in help controller

The Extbase help command controller has the calling
script hardcoded in several places. This may cause
confusion if the calling script was different.

Use the real script from argv[0] instead.

Resolves: #58456
Releases: 6.2
Change-Id: I622484cb75ad87078ed8b5f923f1f3b972c64124
Reviewed-on: https://review.typo3.org/29809
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years agoRevert "[TASK] EM: Add possibility to bypass system dependency checks" 13/29813/3
Anja Leichsenring [Sat, 3 May 2014 13:56:40 +0000 (15:56 +0200)]
Revert "[TASK] EM: Add possibility to bypass system dependency checks"

The patch breaks Travis due to incomplete mocking.
Additionally was considered 'not ready' post merge. We work some more
on it.

This reverts commit 22695e3b2c5940c0be31541b16ff589390429826

Change-Id: I8194801b6be9d4c3b4f57d14d26df42df36f4b09
Reviewed-on: https://review.typo3.org/29813
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Queries don't respect MM_match_fields 13/29713/11
Stefan Froemken [Mon, 28 Apr 2014 17:18:44 +0000 (19:18 +0200)]
[BUGFIX] Queries don't respect MM_match_fields

In case of sys_category and all other
MM-relations with MM_match_fields, parseConstraint
has no implementation for this property.

This patch adds MM_match_fields for
matching and deletion.

Resolves: #10487
Releases: 6.2
Change-Id: Id4f53fd4ed42dd6e785011b5efbc61f6ce62e022
Reviewed-on: https://review.typo3.org/29713
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] EM: Add possibility to bypass system dependency checks 24/28924/15
Nicole Cordes [Thu, 27 Mar 2014 21:30:58 +0000 (22:30 +0100)]
[TASK] EM: Add possibility to bypass system dependency checks

This patch extends the extension manager in three different ways. First
all dependencies are checked and error messages are bundled to show all
problems to the user.

Secondly on uploading an extension file the installation process is
started automatically.

The main change of this patch is to introduce a new function to prevent
(system) dependency checks. This means the checks for TYPO3 and PHP
version don't throw an exception anymore. Required extensions are tried
to be fetched from TER but don't stop installation either.

If errors occur on first installation process, a link to force the
installation is added to the notification. Before any installation
can be run, a dialog with a "break warning" is shown and has to be
confirmed by clicking the unfocussed field.

To be able to skip the system dependency check, a new property for
ExtensionManagementService and DependencyUtility is introduced which
controls disabling the system dependency check. All extension
dependencies are still resolved and needed extensions are tried
to be fetched from TER.

Resolves: #54512
Releases: 6.2
Change-Id: Ia11b7770a2773538bda48d889282ff51bf187c84
Reviewed-on: https://review.typo3.org/28924
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] IMAGE param stdWrap-function not working 96/29796/6
Oliver Hader [Sat, 3 May 2014 09:51:55 +0000 (11:51 +0200)]
[BUGFIX] IMAGE param stdWrap-function not working

Images in TypoScript are rendered using method cImage() of
the ContentObjectRender. This method has the possibility to
modify the HTML parameters to be set.

However, the parameters are not recognized, if those are only
rendered using stdWrap functions, e.g. using params.dataWrap

This change moves method stdWrapValue() from the FILES cObject
to the parent ContentObjectRenderer and delegates the call to
the new location of that method.
Besides that, a superfluous space has been removed from the
template markers definition.

Resolves: #58420
Releases: 6.2
Change-Id: I56229ef5aa5133205114c6ee945a68983ef3f52e
Reviewed-on: https://review.typo3.org/29796
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jan Runte
Tested-by: Jan Runte
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Remove superfluous margin above #typo3-menu 56/28556/4
Roland Waldner [Thu, 20 Mar 2014 10:03:19 +0000 (11:03 +0100)]
[TASK] Remove superfluous margin above #typo3-menu

Added padding-top to start the first li in the menue at the bottom line
of the first grey space in the content-area

Resolves: #57098
Releases: 6.2
Change-Id: I8ec5defea0cfae9483cfd19bdb918ee063b22f70
Reviewed-on: https://review.typo3.org/28556
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] Remove abandoned functional test 95/29795/5
Felix Oertel [Sat, 3 May 2014 09:26:01 +0000 (11:26 +0200)]
[CLEANUP] Remove abandoned functional test

To allow running of all functional tests, instead of relying on
travis.yml, we want to clean up broken and abandoned tests.

This one was not touched for over a year, does not work anymore
and noone really knows, if it is even suitable anymore.

Releases: 6.2
Resolves: #58446
Relates: #58445
Change-Id: Ie3926f557c0cc91d40ad4e4554f0f39de1901adf
Reviewed-on: https://review.typo3.org/29795
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Oliver Hader
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix namespace of RelationTest 98/29798/2
Marc Bastian Heinrichs [Sat, 3 May 2014 10:23:58 +0000 (12:23 +0200)]
[BUGFIX] Fix namespace of RelationTest

Resolves: #58450
Releases: 6.2
Change-Id: I78d39b0be0d4fc9a425ff3fa1e2424ee017d3180
Reviewed-on: https://review.typo3.org/29798
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Add l18n_parent to tt_content TCA 54/29054/2
Alexander Bigga [Tue, 1 Apr 2014 20:06:44 +0000 (22:06 +0200)]
[BUGFIX] Add l18n_parent to tt_content TCA

If an editor ignores the "Copy default content elements"-button, it is
not possible to get a new content element in the alternative language
related to it's parent.

The existing l18n_parent field is never shown. This seems to be a bug
which was introduced in TYPO3 4.5 and exists up to now.

The patch adds the l18n_parent field to the general tab.

Resolves: #26709
Releases: 6.2
Change-Id: Id5f171cd4d1a6441cb58123aaa2b9bd337271556
Reviewed-on: https://review.typo3.org/29054
Reviewed-by: Frans Saris
Reviewed-by: Nadir S.
Tested-by: Nadir S.
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Notification about missing impexp installation 81/29781/4
Nicole Cordes [Fri, 2 May 2014 16:51:32 +0000 (18:51 +0200)]
[BUGFIX] Notification about missing impexp installation

This patch adds a notification to install the impexp extension before
the distribution list is shown.

Resolves: #57375
Releases: 6.2
Change-Id: I04da4afcf9ac43ff99190844fad9582665c0c346
Reviewed-on: https://review.typo3.org/29781
Reviewed-by: Sascha Wilking
Tested-by: Sascha Wilking
Reviewed-by: Jan Runte
Tested-by: Jan Runte
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Make Flow Package HHVM compatible 08/29508/3
Tymoteusz Motylewski [Wed, 16 Apr 2014 14:54:19 +0000 (16:54 +0200)]
[TASK] Make Flow Package HHVM compatible

HHVM doesn't support calling array functions like key()
on objects, we need to cast object to array first.

Resolves: #57993
Related: #57992
Releases: 6.2
Change-Id: I8551860b103745622624dafd8f285db1a7b8f275
Reviewed-on: https://review.typo3.org/29508
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Speed up functional tests 75/29575/6
Christian Kuhn [Sat, 19 Apr 2014 23:18:38 +0000 (01:18 +0200)]
[TASK] Speed up functional tests

Optimize functional test bootstrap to improve performance:

* Database schema for single tests of a test case are always
  identical by design. So a database can be re-used between
  single tests to save the table creation overhead. Database
  tables are truncated instead which is quicker.
* Load less extensions by default, so less tables are created.
* Enable class loader caches.

Typically, tests instances with mysql on a ramdisk, tests are ~25%
quicker, for native mysql on hdd the performance impact is ~50%.

Change-Id: Ife1ea755c5336f7d4362b2affe7bba9e94862e92
Resolves: #58433
Releases: 6.2
Reviewed-on: https://review.typo3.org/29575
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Retrieving extension fails with some PHP versions 83/29783/3
Sascha Wilking [Fri, 2 May 2014 17:49:10 +0000 (19:49 +0200)]
[BUGFIX] Retrieving extension fails with some PHP versions

XmlParser has an issue with PHP < 5.4.28 leading to
unexpected empty arrays raising warnings. If development
preset is activated, warnings are turned into exceptions,
so the extension list parser stops importing.

Resolves: #58418
Releases: 6.2, 6.1
Change-Id: Idc6453bd8dcc46a933a1d6d72361ffff5842e39d
Reviewed-on: https://review.typo3.org/29783
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[CLEANUP] Page Module: Do hovering via CSS, not JS 44/29744/2
Benjamin Mack [Wed, 30 Apr 2014 13:07:03 +0000 (15:07 +0200)]
[CLEANUP] Page Module: Do hovering via CSS, not JS

The ExtJS functionality for adding active classes can
be done via CSS hover pseudo classes.

This is faster (native browser functionality) and
also removes some ExtJS code. With this change
however, the hovering is not disabled
anymore when dragging.

Releases: 6.2
Resolves: #58359
Change-Id: Ifcc0307b436cf68dfcfe561444e779410978d576
Reviewed-on: https://review.typo3.org/29744
Tested-by: Stefan Neufeind
Reviewed-by: Nadir S.
Tested-by: Nadir S.
Reviewed-by: Nico Schober
Tested-by: Nico Schober
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Media field is empty on page localization 19/29719/5
Oliver Hader [Mon, 28 Apr 2014 20:32:17 +0000 (22:32 +0200)]
[BUGFIX] Media field is empty on page localization

If comparing localization of regular tables (like tt_content) to
pages and its specific overlay table pages_language_overlay, the
main difference is, that regular tables are copied directly and
page translation are shown in the edit view first - without
persisting to the database and thus not having a proper uid at
this time, yet.

This means, that "localizeChildrenAtParentLocalization" in the
TCA field configuration won't have any effect.

This change brings back the IRRE localization icons for children
and "localize all" link for the media field. However, those are
only displayed if the new page overlay has been saved once.

Resolves: #57488
Releases: 6.2
Change-Id: I29886776b40accce48ce5cd10937ff65b20430fb
Reviewed-on: https://review.typo3.org/29719
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Tested-by: Nadir S.
Reviewed-by: Frans Saris
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Default image title in RTE contains the file name 59/29759/2
Stanislas Rolland [Thu, 1 May 2014 14:17:09 +0000 (10:17 -0400)]
[BUGFIX] Default image title in RTE contains the file name

When inserting an image in the RTE, the default image title should be
the image file title, not the image file name.

Resolves: #58373
Releases: 6.1, 6.2
Change-Id: I5aa3aae4db83cbd36244b89cc37c78184b290228
Reviewed-on: https://review.typo3.org/29759
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Nadir S.
Tested-by: Nadir S.
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] News Box in BE Login Screen not styled properly 45/29745/2
Benjamin Mack [Wed, 30 Apr 2014 13:24:18 +0000 (15:24 +0200)]
[BUGFIX] News Box in BE Login Screen not styled properly

The headline in the backend login screen that contains
the sys_news information has a bottom margin and
does not have the right size.

Releases: 6.2
Resolves: #58362
Change-Id: I0977a3be627a469b902fb39b14417dc9feb738da
Reviewed-on: https://review.typo3.org/29745
Reviewed-by: Nico Schober
Tested-by: Nico Schober
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove tests no longer needed 72/29772/2
Anja Leichsenring [Fri, 2 May 2014 11:38:42 +0000 (13:38 +0200)]
[TASK] Remove tests no longer needed

Category API was changed to silently fail instead of throwing an
exception, but the corresponding tests were not removed.

Releases: 6.2
Resolves: #58416
Relates: #58384
Change-Id: I52c0fac32c7f4385868ef5f28c6f94b583948e75
Reviewed-on: https://review.typo3.org/29772
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fail silently in category registry 65/29765/3
Helmut Hummel [Thu, 1 May 2014 21:22:40 +0000 (23:22 +0200)]
[BUGFIX] Fail silently in category registry

The idea was to fail when the category registry
is used in a wrong way. This however causes troubles
when the core itself reloads extension tables during
extension installation process.

Remove the exceptions, fail silently on wrong usage
and let the installation work again.

Resolves: #58384
Releases: 6.2
Change-Id: Icd6ec77fea9d95c9a58e75a85546c0ecc2a5c6d7
Reviewed-on: https://review.typo3.org/29765
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] DBAL native mode: Database compare fails 31/29631/3
Markus Klein [Thu, 24 Apr 2014 08:35:39 +0000 (10:35 +0200)]
[BUGFIX] DBAL native mode: Database compare fails

Database compare does not work with DBAL in native mode
as the ALTER TABLE statement is not processed correctly.
The SQL statement is wrongly interpreted as array, but is of
type string.

Fix this by extending the check which determines the type.

Resolves: #58147
Releases: 6.2
Change-Id: I467494c633b8af9e5a17dce64f071667dd985177
Reviewed-on: https://review.typo3.org/29631
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Sets defaultMailFromAddress as sender for install tool e-mails 26/28926/7
Torben Hansen [Fri, 28 Mar 2014 07:49:36 +0000 (08:49 +0100)]
[BUGFIX] Sets defaultMailFromAddress as sender for install tool e-mails

This patch sets [MAIL][defaultMailFromAddress] as a sender for successful
and failed login mails for the install tool. If no defaultMailFromAddress
is set, the fallback sender address is set to no-reply@example.com

Resolves: #57401
Releases: 6.2
Change-Id: Ie4e7700fff9858772688486e5efb4a068d2fe7ff
Reviewed-on: https://review.typo3.org/28926
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] checkMaximumFileUploadSize shows misleading message 96/29696/2
Markus Klein [Sun, 27 Apr 2014 17:56:48 +0000 (19:56 +0200)]
[BUGFIX] checkMaximumFileUploadSize shows misleading message

Improve the Install Tool system environment check for
PHP maximum upload size.

Resolves: #58260
Releases: 6.2
Change-Id: I9f0c0694298faa817d9ac827e2f0e7f589cd0611
Reviewed-on: https://review.typo3.org/29696
Reviewed-by: Jost Baron
Tested-by: Jost Baron
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Use REDIRECT_ prefix as fallback for environment variables 23/25123/10
Steffen Müller [Wed, 30 Apr 2014 11:21:39 +0000 (13:21 +0200)]
[BUGFIX] Use REDIRECT_ prefix as fallback for environment variables

The core uses values of environment variables for
disabling the core updater and to determine the
application context.

When setting the variable with mod_rewrite, certain server environments
prefix the variable name with REDIRECT_.
To ensure compatibility for this case, REDIRECT_
prefix is prepended as a fallback if the regular
variable is not set.

Resolves: #53188
Resolves: #58358
Resolves: #53974
Releases: 6.2
Change-Id: Iaba7f936ff1362d1f70426ec8ad1b1821e4e0d3c
Reviewed-on: https://review.typo3.org/25123
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
5 years ago[CLEANUP] Extension Manager code 31/29431/8
Markus Klein [Sat, 12 Apr 2014 15:33:29 +0000 (17:33 +0200)]
[CLEANUP] Extension Manager code

* Add missing annotations
* Shorten unnecessary namespace annotations

Resolves: #57861
Releases: 6.2
Change-Id: Ic8e24e76e3ccc09122dc0a288f1e0b538685c478
Reviewed-on: https://review.typo3.org/29431
Reviewed-by: Oliver Klee
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix oddities of the CategoryRegistry 60/29560/7
Helmut Hummel [Fri, 18 Apr 2014 17:49:08 +0000 (19:49 +0200)]
[BUGFIX] Fix oddities of the CategoryRegistry

This change makes it again possible to call
makeCategorizable from ext_tables.php files.

This is done by directly applying additions
to the TCA if the default TCA has already
been applied.

For details read the comparison matrix in the
referenced bug report.

Resolves: #58004
Releases: 6.2
Change-Id: I0cb69d0421a0df3f930cc9cac1b1811108572530
Reviewed-on: https://review.typo3.org/29560
Reviewed-by: Wouter Wolters
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] remove enableFields for sys_file_processedfile 61/29461/2
Stefan Froemken [Mon, 14 Apr 2014 15:02:18 +0000 (17:02 +0200)]
[BUGFIX] remove enableFields for sys_file_processedfile

remove additional enableFields from where clause
in ProcessedFileRepository as long as
sys_file_processedfile is not part of TCA

Resolves: #57906
Releases: 6.2
Change-Id: I393f7f952a59ca2f79bf35c8653375a54fec4170
Reviewed-on: https://review.typo3.org/29461
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Extensionmanager does not show error messages on update failure 38/28738/5
Philipp Gampe [Tue, 25 Mar 2014 02:13:49 +0000 (03:13 +0100)]
[BUGFIX] Extensionmanager does not show error messages on update failure

The extension manager fails to show any error message if an extension
update fails.

Convert exceptions (e.g. dependency fails, TER download fails) into a
nice flashmessage.
Convert any server errors (uncatchable PHP errors) into a flashmessage.

Resolves: #56823
Releases: 6.2, 6.1
Change-Id: Ife3c6d3dcd23177ba22192dd6ae720352931b538
Reviewed-on: https://review.typo3.org/28738
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jost Baron
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Make includeCsh configurable in ContainerViewHelper 90/29590/3
Nico de Haen [Mon, 21 Apr 2014 09:52:37 +0000 (11:52 +0200)]
[TASK] Make includeCsh configurable in ContainerViewHelper

The container ViewHelper does not provide a configuration
attribute for includeCsh (Context sensitive help). As consequence
ExtJS and ExtDirect code is always loaded in Backend Modules.

Resolves: #58075
Releases: 6.2
Change-Id: I1978bdc0bf3fca40f78cdae9b214a808f58abe49
Reviewed-on: https://review.typo3.org/29590
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Wrong comment in ActionMenuViewHelper 46/29646/2
Markus Klein [Thu, 24 Apr 2014 22:30:46 +0000 (00:30 +0200)]
[BUGFIX] Wrong comment in ActionMenuViewHelper

ActionMenuViewHelper contains a wrong example for the usage
of the viewhelper. It uses a '=' where a ':' would be correct.

Resolves: #58166
Releases: 6.2, 6.1
Change-Id: I135310be0ac2e8df59f81dfbf694a0febbcde99a
Reviewed-on: https://review.typo3.org/29646
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Missing TSconfig in FE 29/29729/2
Markus Klein [Tue, 29 Apr 2014 16:45:55 +0000 (18:45 +0200)]
[BUGFIX] Missing TSconfig in FE

Some extensions need page TSconfig in FE.
This was restricted to BE only with #55593.

Undo this change.

Resolves: #58338
Releases: 6.2
Change-Id: Ia14d7d36c659598415f86f8fabf515879776d148
Reviewed-on: https://review.typo3.org/29729
Reviewed-by: Gerrit Mohrmann
Tested-by: Gerrit Mohrmann
Reviewed-by: Fabien Udriot
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Reimplement ranges in NumberRangeValidator 22/29722/9
Stefan Froemken [Tue, 29 Apr 2014 08:51:14 +0000 (10:51 +0200)]
[BUGFIX] Reimplement ranges in NumberRangeValidator

We have removed startRange and endRange too early
in NumberRangeValidator. As long as TYPO3 6.3
is not reached we have to reimplement these options
again.

Resolves: #58313
Releases: 6.2
Change-Id: Id012da11227230890b27aa24e1dba1787210f931
Reviewed-on: https://review.typo3.org/29722
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Solve stackoverflow in prototype in IE8 55/29655/5
Jigal van Hemert [Fri, 25 Apr 2014 10:39:59 +0000 (12:39 +0200)]
[BUGFIX] Solve stackoverflow in prototype in IE8

The reason for this behaviour is the combination of prototype.js
and ExtJS. The ExtJS defer() method takes precedence. Calling the
defer() method without any arguments would have resulted in using
a default value of "0.01" seconds in standalone prototype.js, but
results in directly calling the submitted function.

The stack overflow is caused by not delaying the function call
and thus ending in a recursive endless loop.

Resolves: #58187
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6db191ff67a3e869072877936d949fc733cda74f
Reviewed-on: https://review.typo3.org/29655
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Session cookie is not recreated on login 26/29626/2
Markus Klein [Wed, 23 Apr 2014 21:09:08 +0000 (23:09 +0200)]
[BUGFIX] Session cookie is not recreated on login

In case login data is submitted and there is an existing cookie/session
the current session is discarded and the current cookie is unset.
Subsequently the login data is processed and login succeeds and a
new session is established, but the new cookie is not set.

Fix this be correctly remembering that we need to set a new cookie,
after we disposed the current one.

Resolves: #57751
Releases: 6.2
Change-Id: I2e4b4a381b4e557aeb95c4186c6e5365dbea442a
Reviewed-on: https://review.typo3.org/29626
Reviewed-by: Fabien Udriot
Reviewed-by: Stefan Neufeind
Reviewed-by: Robbert V
Tested-by: Robbert V
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Remove GET parameters from URLs in List module 01/29701/5
Markus Klein [Sun, 27 Apr 2014 21:15:29 +0000 (23:15 +0200)]
[BUGFIX] Remove GET parameters from URLs in List module

DatabaseRecordList (List module) generates returnUrls for localization
links. These must not contain the 'justLocalized' parameter, as this
would cause redirects to edit form over and over again.

This fix removes the inclusion of all the GET parameters - introduced
with #55314 - again. Only the module parameter is used from GET/POST.
Additional API enables extbase plugins to add necessary parameters.

The TableListViewHelper does not need any more parameters besides
the module name and hence still works after this patch.

Resolves: #58257
Related: #55314
Releases: 6.2
Change-Id: I641e4ce37e48c9ea4f9aabce41b11d8f824bf64d
Reviewed-on: https://review.typo3.org/29701
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Wouter Wolters
5 years ago[BUGFIX] Database query error for non-workspaces tables 57/29657/2
Oliver Hader [Fri, 25 Apr 2014 13:36:41 +0000 (15:36 +0200)]
[BUGFIX] Database query error for non-workspaces tables

In frontend rendering mode PageRepository::versionOL() is called
frequently to overlay workspace data. A further method call then
creates a query with required t3ver_* fields. This query fails
if a table is not considered to support workspaces/versioning at
all. This behaviour is regression that has been introduced with
issue #30604 during TYPO3 4.7 development.

Resolves: #58180
Releases: 6.2, 6.1, 6.0
Change-Id: I81d24ea16116563f4f0d75fafd06496a9c4e993d
Reviewed-on: https://review.typo3.org/29657
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years agoRevert "[TASK] Configurable width of the Element Browser" 16/29616/2
Jigal van Hemert [Wed, 23 Apr 2014 10:35:45 +0000 (12:35 +0200)]
Revert "[TASK] Configurable width of the Element Browser"

Reverted per request of the RM because:
- there is a merge freeze for regressions
- 6.2 is now a stable branch (no new features)

Besides:
- no documentation issue
- not enough votes

This reverts commit 8f520011793f558a5dad33f6a51ecabc5cef41c1

Change-Id: Ia1ffee069f825b678748808d756a2c04fd8edb18
Reviewed-on: https://review.typo3.org/29616
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Configurable width of the Element Browser 55/29555/5
Georg Ringer [Fri, 18 Apr 2014 03:24:41 +0000 (05:24 +0200)]
[TASK] Configurable width of the Element Browser

The width of the element browser is sadly hardcoded to 600 and 650.

In many situations the element browser would need more place and
with this tiny change it would be easily possible to change
that behaviour without overloading the whole file.

Resolves: #58031
Releases: 6.2
Change-Id: I8a7df0e1c8f2c977af309fe5917c38ec6de99759
Reviewed-on: https://review.typo3.org/29555
Reviewed-by: Laurent Cherpit
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Keep uid / pid parameters in element browser URLs 36/29536/2
Alexander Stehlik [Thu, 17 Apr 2014 09:41:47 +0000 (11:41 +0200)]
[TASK] Keep uid / pid parameters in element browser URLs

The uid and pid parameters will now be passed on in the jumpToUrl()
function of the element browser. This makes sure that Page TSConfig
can still be retrieved when the user clicks on a tab.

Resolves: #58005
Releases: 6.2
Change-Id: I04cecb0aade417254ed5b0320bbc398f44850617
Reviewed-on: https://review.typo3.org/29536
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years agoRevert "[BUGFIX] Do not reset Page Renderer on partial rendering" 80/29580/3
Helmut Hummel [Sun, 20 Apr 2014 10:17:53 +0000 (12:17 +0200)]
Revert "[BUGFIX] Do not reset Page Renderer on partial rendering"

The page renderer is not designed to work with
a second rendering pass without resetting to its initial state.

Not resetting will cause double compression of files and
creating wrong version numbered file names.

Reverting this again means: ->addFooter* calls are ignored
when being called before first rendering pass and
only work when done after first rendering pass.

Although this behavior is highly intransparent
it cannot easily be fixed without heavy refactoring
of the page renderer which most likely will break hooks.

Introduced regression by this change: #57919 and #58010

This reverts commit c67e8ebbb074c46dae40bec329db7392e023b0d6

Change-Id: I9e489e49f65bb69e2f3c3b997cc14465d6a08d80
Reviewed-on: https://review.typo3.org/29580
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TypoScriptParser does not validate absPath 07/29607/2
Markus Klein [Tue, 22 Apr 2014 15:20:29 +0000 (17:20 +0200)]
[BUGFIX] TypoScriptParser does not validate absPath

GeneralUtility::getFileAbsFileName() returns a blank string for
invalid paths.
TypoScriptParser::includeDirectory() does not check the return value,
but passes it on to TypoScriptParser::getAllFilesAndFoldersInPath().
This causes the method to enumerate all entries of /.

Fix this by properly checking the return value of getFileAbsFileName().

Resolves: #58102
Releases: 6.2
Change-Id: I778ad6bfc9d4a6a08f36fdd6ae00ccb9a8d2c03e
Reviewed-on: https://review.typo3.org/29607
Reviewed-by: Johannes Kasberger
Tested-by: Johannes Kasberger
Reviewed-by: Stefan Neufeind
Tested-by: Wouter Wolters
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Include RSA JS files in HTML header 81/29581/2
Helmut Hummel [Sun, 20 Apr 2014 10:25:26 +0000 (12:25 +0200)]
[BUGFIX] Include RSA JS files in HTML header

Due to an oddity in page renderer, we cannot
add the required JavaScript to the footer
as it would not be rendered.

Clean up the JavaScript to correctly work even
when included in the header and change the hook
to add the JS files to the header.

Resolves: #58010
Related: #57294
Releases: 6.2
Change-Id: I354de3b0aeaf2b163b5df5301de6f0a0aaae34a6
Reviewed-on: https://review.typo3.org/29581
Reviewed-by: Oliver Klee
Tested-by: Dirk Klimpel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Use composer for unit and functional tests in travis 95/29495/7
Christian Kuhn [Tue, 15 Apr 2014 23:05:38 +0000 (01:05 +0200)]
[TASK] Use composer for unit and functional tests in travis

The patch uses composer based dependency handling and other
stuff pushing travis-ci tests to the next level:

- phpunit registered as "dev" requirement in composer.json
- vfsStream registered as "dev" requirement in composer.json
- cms-composer-installers is not released stable and adapted
  in composer.json for successful dependency resolving via
  composer
- cloning travis-integration repository is obsolete by inlining
  scripts in .travis.yml
- cloning ext:phpunit is obsolete, native phpunit by composer
  is used now
- it is possible to set functional test suite database credentials
  with environment variables, used in .travis.yml
- redis cache backend tests are enabled on travis-ci again
- use existing php modules of travis-ci environment speeds up build

With phpunit from composer, the command to run tests is
./bin/phpunit -c typo3/sysext/core/Build/UnitTests.xml
More documentation about that can be found at
http://wiki.typo3.org/Unit_Testing_TYPO3

Change-Id: I4d524e8e0249ca22f34fc48b7209d60d72e5e921
Resolves: #57971
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/29495
Reviewed-by: Wouter Wolters
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix TCA overrides when not cached 61/29561/2
Helmut Hummel [Fri, 18 Apr 2014 19:08:46 +0000 (21:08 +0200)]
[BUGFIX] Fix TCA overrides when not cached

The TCA overrides are only parsed when the cache is built.
But they also need to be parsed if the bootstrap
requests an uncached load.

Move the signal to loadBaseTca to accomplish this.

Resolves: #58039
Releases: 6.2
Change-Id: I17b871060ec11ce044d8e09b5acfe8d20a36a5e8
Reviewed-on: https://review.typo3.org/29561
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Mitigate risk for travis-ci timeouts 53/29553/3
Christian Kuhn [Thu, 17 Apr 2014 19:36:29 +0000 (21:36 +0200)]
[TASK] Mitigate risk for travis-ci timeouts

Not using --keep-order in parallel gives output as soon as a
job is finished and thus reduces the risk for travis-ci timeouts.

Change-Id: If33087fbf4fc2b927ce52d153625140d89c2603a
Releases: 6.2
Reviewed-on: https://review.typo3.org/29553
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Set TYPO3 version to 6.2.2-dev 24/29524/2
TYPO3 Release Team [Wed, 16 Apr 2014 21:45:27 +0000 (23:45 +0200)]
[TASK] Set TYPO3 version to 6.2.2-dev

Change-Id: I6e25181228d9c65bc4eee0b2309aed54ce24d181
Reviewed-on: https://review.typo3.org/29524
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.2.1 23/29523/2 6.2.1 TYPO3_6-2-1
TYPO3 Release Team [Wed, 16 Apr 2014 21:44:57 +0000 (23:44 +0200)]
[RELEASE] Release of TYPO3 6.2.1

Change-Id: I43e62cf514ffc35d05163fee8bf0f222f3a18df7
Reviewed-on: https://review.typo3.org/29523
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[TASK] Release file and folder permission check 17/28917/4
Markus Hoelzle [Thu, 27 Mar 2014 18:37:24 +0000 (19:37 +0100)]
[TASK] Release file and folder permission check

This patch changes the warnings to a notices if files or folders are
readable for anyone. This improves usability for users on
non-restrictive systems as 1und1 servers.

Resolves: #57354
Releases: 6.2
Change-Id: Ic9eba030647e837694331d394d45dc1553c0cdf5
Reviewed-on: https://review.typo3.org/28917
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] ResourceStorage does not sanitize folder/file name 02/29202/6
Frans Saris [Sun, 6 Apr 2014 09:30:35 +0000 (11:30 +0200)]
[BUGFIX] ResourceStorage does not sanitize folder/file name

On multiple places the new folder or filename is not sanitized
before the checks are done to see if the a folder of file with
that name already exists.

This patch makes sure the new names gets sanitized first and
also takes care that the name of the resultObject is passed to
the PostFolderMove, PostFolderCopy and PostFolderRename signals.

Resolves: #57681
Releases: 6.2
Change-Id: Id951ded531c9979e7cb4bdcd319f56a8f810fa96
Reviewed-on: https://review.typo3.org/29202
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] DBAL sql_fetch_* must return boolean or array 02/29502/2
Jigal van Hemert [Wed, 16 Apr 2014 08:58:57 +0000 (10:58 +0200)]
[BUGFIX] DBAL sql_fetch_* must return boolean or array

If the end of a result set is reached some drivers produce NULL.
This must be changed into FALSE to be compatible with the
non-DBAL version of these functions.

Resolves: #57957
Releases: 6.2, 6.1
Change-Id: I664dd10735f88754c74e20ecd5c07fad5ef2b78d
Reviewed-on: https://review.typo3.org/29502
Reviewed-by: Mathias Schreiber
Tested-by: Mathias Schreiber
Reviewed-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] TCA tree fail to load with IRRE 50/12850/6
Xavier Perseguers [Mon, 4 Mar 2013 08:51:02 +0000 (09:51 +0100)]
[BUGFIX] TCA tree fail to load with IRRE

The TCA tree element fail to load inside IRRE, in some condition
(when the record is not loaded/opened)

Change-Id: Id077a71e2191b0cf91003611e11dc5aefafab0c9
Resolves: #39035
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/12850
Reviewed-by: Markus Klein
Reviewed-by: Laurent Cherpit
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Fabien Udriot
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] Set maxLevels of generated sys_category TCA 97/29297/4
Frans Saris [Tue, 8 Apr 2014 13:20:50 +0000 (15:20 +0200)]
[BUGFIX] Set maxLevels of generated sys_category TCA

The maxLevels in the TCA tree configuration is not set
by the CategoryRegistry. As a result only 4 levels are
shown.

This patch sets the maxLevels to 99 and also updates the
appearance settings of the sys_category:parent field
so these are inline with the other category tree fields.

Resolves: #57750
Releases: 6.2
Change-Id: I7c33b71d2af214cf1b2027e4769c1cc43a3c43d6
Reviewed-on: https://review.typo3.org/29297
Reviewed-by: Alexander Opitz
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Stefan Neufeind
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] Follow-up to l10n_mode=exclude for record titles 92/29492/2
Christian Kuhn [Tue, 15 Apr 2014 19:47:01 +0000 (21:47 +0200)]
[BUGFIX] Follow-up to l10n_mode=exclude for record titles

Fix a possible warning in the new method and simplify test
cases a bit.

Change-Id: Ie9ee3c1b52d3a692c23428f21e3fb7311da9cb2a
Resolves: #33499
Releases: 6.2
Reviewed-on: https://review.typo3.org/29492
Reviewed-by: Andreas Wolf
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] TceformsUpdateWizard shows up too often 33/29033/2
Markus Klein [Tue, 1 Apr 2014 15:04:11 +0000 (17:04 +0200)]
[BUGFIX] TceformsUpdateWizard shows up too often

After successfully migrating a field, the field is not added to the list
of finished fields, due to a superfluous check.

Running wizard again finally adds the field to the finished list as the
condition is fulfilled, but the additional run does not
do any useful work anymore.

Fix this by adjusting the condition to safe the extra run.

Resolves: #57497
Releases: 6.2
Change-Id: I6bc15de6f5dbeb58151a1745a849e1b0581b2fbe
Reviewed-on: https://review.typo3.org/29033
Reviewed-by: Frans Saris
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] BE ignores l10n_mode for record titles 48/10448/21
Markus Klein [Tue, 15 Apr 2014 00:22:36 +0000 (02:22 +0200)]
[BUGFIX] BE ignores l10n_mode for record titles

Change-Id: I8606f5e0a1525cb98839a41271466a18b9f3cccf
Fixes: #33499
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/10448
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[FEATURE] Provide API to add cached TCA changes 84/29484/6
Helmut Hummel [Tue, 15 Apr 2014 10:55:37 +0000 (12:55 +0200)]
[FEATURE] Provide API to add cached TCA changes

This change adds the feature that php files in the
extension directory Configuration/TCA/Overrides/
will be executed right before building the cached
TCA. These files must *only* contain PHP code
that manipulate TCA (like addTCAColumns or
addToAllTCATypes).

The benefit in doing so is that we can move all code
manipulating the TCA that previously was in ext_tables.php
and therefore uncachable, can now be in a defined
location and is only executed when TCA is built
and after that cached.

This will give backend requests quite a performance
boost once extensions start using these files.

Category Registry changes will also be applied
after Configuration/TCA/Overrides/ has been processed
so that makeCategorizable calls can now also happen
in files in this locations and do not need to stay
in ext_localconf.php where they also would be executed
on every request.

For now only filemetadata extension TCA configuration
is moved. All other core extensions will follow later.

Resolves: #57942
Documentation: #57951
Releases: 6.2
Change-Id: Id7fdebac266bc0b4e85a45b64d73e4f4f3c59a36
Reviewed-on: https://review.typo3.org/29484
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[CLEANUP] Category related tests cleanup 88/29488/2
Helmut Hummel [Tue, 15 Apr 2014 13:31:42 +0000 (15:31 +0200)]
[CLEANUP] Category related tests cleanup

The category registry test and makeCategorizable
test of extension management utility are cleaned up
to use proper naming and actually test what
is in their scope.

Resolves: #57949
Releases: 6.2
Change-Id: I5dae812435d71b5188b4dc8ecf9dd2ce9d400658
Reviewed-on: https://review.typo3.org/29488
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years agoRevert "[BUGFIX] Make category TCA changes cacheable" 80/29480/3
Helmut Hummel [Tue, 15 Apr 2014 11:27:33 +0000 (13:27 +0200)]
Revert "[BUGFIX] Make category TCA changes cacheable"

This reverts commit 2b4aeefc27719e0147858f7b0c82a70249a53749

This is reverted in favor of a better approach that makes
caching for every TCA additions or override possible.

Besides that, this change introduced a regression, as
database compare in install tool does not work properly any more.

Change-Id: I4fc0d3d76f28afd8ff82ae5537ff3b207fa53bae
Reviewed-on: https://review.typo3.org/29480
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Make category TCA changes cacheable 24/29424/3
Helmut Hummel [Sun, 13 Apr 2014 16:56:34 +0000 (18:56 +0200)]
[BUGFIX] Make category TCA changes cacheable

Currently TCA changes of the category API are applied on every request
after the extTables files is included. This makes it impossible to
override the changes by third party extensions and also we do not
benefit from caching.

Instead we now use the introduced signal and apply the changes
right before caching.

With this change we also have a clear separation of
registering category field additions (in ext_localconf.php) and
applying the TCA changes while building the TCA cache.

Resolves: #57881
Releases: 6.2
Change-Id: I385c894fe13eb4cd4f8f2b4c82a9513b05308daa
Reviewed-on: https://review.typo3.org/29424
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Remove hardcoded module name in AbstractDatabaseRecordList 49/27049/7
Marcin Sągol [Fri, 24 Jan 2014 23:12:38 +0000 (00:12 +0100)]
[TASK] Remove hardcoded module name in AbstractDatabaseRecordList

TYPO3 Fluid offers view helper TableListViewHelper to generate
records list in backend modules. When pagination is rendered
for this list all links (previous, next etc.) redirect to
List module but they should point to current backend module.
Reason of this behaviour is hardcoded module name in listURL()
function.

This patch replaces hardcoded module name with the M
parameter from GET array. Extbase modules require also
controller and action name in url's so all GET params
are merged with this defined in listURL() function. We are
using all GET params because module might require more
than controller and action name for other elements than
records list.

Resolves: #55314
Releases: 6.2
Change-Id: I706cf99838620c961e1b3f7af667d0c6ba447077
Reviewed-on: https://review.typo3.org/27049
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[CLEANUP] Clean up comments and error messages in ResourceStorage 39/29439/5
Oliver Klee [Sun, 13 Apr 2014 10:53:32 +0000 (12:53 +0200)]
[CLEANUP] Clean up comments and error messages in ResourceStorage

This changes adds some missing @throws annotations and improves the
readability of some comments.

Also fix a typo in an exception and reformat some exceptions for
better readability.

Moreover add some checks if the correct type is present
before calling undefined methods.

This change does not introduce any functional changes.

Releases: 6.2
Resolves: #57871
Change-Id: Iab4414bd480a05cc5ca3b29df0d12e719064b063
Reviewed-on: https://review.typo3.org/29439
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind