Packages/TYPO3.CMS.git
8 years ago[BUGFIX] Mirror selection is not respected
Xavier Perseguers [Mon, 1 Aug 2011 20:56:46 +0000 (22:56 +0200)]
[BUGFIX] Mirror selection is not respected

When a specific mirror is selected in Extension Manager,
the method used to return it fails.

Change-Id: Ibb60edec1a7fac4e3c217aad47d9332f7edd5fc6
Resolves: #27755
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3999
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper
8 years ago[BUGFIX][Form] Remove third-party captcha support of the new form extension
Susanne Moog [Mon, 1 Aug 2011 17:24:21 +0000 (19:24 +0200)]
[BUGFIX][Form] Remove third-party captcha support of the new form extension

The form project checks for third-party extensions to provide captcha
support currently. Remove the whole captcha support until a clean API
for registering third-party extensions is developed.

Change-Id: I1e9a8b8ff065fc091dadb582dcf8e06e7889d890
Resolves: #28651
Reviewed-on: http://review.typo3.org/3985
Reviewed-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Tested-by: Oliver Hader
8 years ago[FEATURE] Substitute markers and subparts recursively
Jigal van Hemert [Sat, 30 Jul 2011 20:38:00 +0000 (22:38 +0200)]
[FEATURE] Substitute markers and subparts recursively

Introduce new function to substitute markers and (nested) subparts
recursively. The data array defines the structure of single and subpart
markers and the function takes care of handling all the (sub)templates.

Change-Id: Ie746aff506a895c6992d6ecf9acd532704838bbf
Resolves: #28595
Reviewed-on: http://review.typo3.org/3917
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Kamper
8 years ago[FEATURE] Add support for locales
Xavier Perseguers [Fri, 15 Jul 2011 13:13:34 +0000 (15:13 +0200)]
[FEATURE] Add support for locales

Add a new class t3lib_l10n_Locales that is responsible to handle
locales such as fr_CA within TYPO3 and add support for locales
dependencies in Extension Manager.

Change-Id: If5976fc7bfbe82d347a9d84a5ebac84dcc4c76a2
Resolves: #28239
Reviewed-on: http://review.typo3.org/3359
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[FEATURE] Integrate Form project into Core
Xavier Perseguers [Fri, 22 Jul 2011 13:17:08 +0000 (15:17 +0200)]
[FEATURE] Integrate Form project into Core

Form project should now become a system extension.

Change-Id: Ide145a64ebe9db26a87437c7befd88a1c5081012
Resolves: #28388
Reviewed-on: http://review.typo3.org/3472
Tested-by: Philipp Gampe
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[FEATURE] Use FlashMessage in be_user module
bidau [Thu, 28 Jul 2011 12:26:08 +0000 (14:26 +0200)]
[FEATURE] Use FlashMessage in be_user module

Add FlashMessages:
* info about cached grouplists being updated
* when there are too many users to show

Change-Id: Iedd62f7731e61a6dff7ca9b6d477d75524351828
Resolves: #28543
Reviewed-on: http://review.typo3.org/3817
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Stefan Neufeind
Reviewed-by: Georg Ringer
8 years ago[BUGFIX] group field in TCEforms does not honor size=1 attribute
Dmitry Dulepov [Tue, 28 Jun 2011 08:58:33 +0000 (11:58 +0300)]
[BUGFIX] group field in TCEforms does not honor size=1 attribute

If the field has size=1, it should be shown as a "single entry"
selector box. In all cases it has a 'multiple="multiple"'
attribute hard-coded, which prevents the control from being
single line. The solution is not to add that attribute unless
necessary.

Change-Id: Iab244a0b797f117d270714ca14d88236399ead93
Resolves: #25221
Related: #24256
Reviewed-on: http://review.typo3.org/972
Reviewed-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] ImageMagick path detection fails on Mac OS X
Oliver Hader [Sun, 31 Jul 2011 21:50:19 +0000 (23:50 +0200)]
[BUGFIX] ImageMagick path detection fails on Mac OS X

The ImageMagick path detection fails on Mac OS X. If MacPorts
is used the additional folder /opt/local/bin should be checked.

Change-Id: I5da3d4ec4fe614c1f5449604468d8def4ba35285
Resolves: #28625
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3961
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[FEATURE] Monitor peak memory usage
Jigal van Hemert [Thu, 7 Apr 2011 20:34:36 +0000 (22:34 +0200)]
[FEATURE] Monitor peak memory usage

Monitor the peak memory usage during page generation and report if
it exceeds 90% of the memory limit.

Change-Id: Ie0cfed4dce4b2f3e269832a28be7045b972a6867
Resolves: #25836
Reviewed-on: http://review.typo3.org/1507
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Tested-by: Thorsten Kahler
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
8 years ago[FEATURE] Hide translated records from List module
Stefan Geith [Tue, 12 Jul 2011 15:27:37 +0000 (17:27 +0200)]
[FEATURE] Hide translated records from List module

Add the new TSconfig option
  mod.web_list.hideTranslations = *
or
  mod.web_list.hideTranslations = list,of,tables

For those tables, only the records of the default language are shown in
the List module. All translations are hidden.

The 'Localization view', still shows all records, including translated
records.

Change-Id: Iede6697a8ee28155b9fd62153eb7299f738258e6
Resolves: #23198
Releases: 4.6
Reviewed-on: http://review.typo3.org/3289
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[FEATURE] Include HTTP Request2 for better HTTP handling
Philipp Gampe [Fri, 8 Jul 2011 08:12:01 +0000 (10:12 +0200)]
[FEATURE] Include HTTP Request2 for better HTTP handling

Add the pear packages HTTP/Request2 end Net/URL2.
Also add PEAR/Exception.php.

Add t3lib_http_Request as wrapper for Request2.
This sets the default options from TYPO3_CONF_VARS.

Additionally add new TYPO3_CONF_VARS options and deprecate the old
cURL options.

Extend include_path that it also works with pear packages.

Change-Id: I430685159cc966e13f1e833ca19ee8f0c75e400a
Resolves: #28344
Releases: 4.5,4.6
Reviewed-on: http://review.typo3.org/3437
Reviewed-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] The requested URL typo3/undefined was not found on this server
Kay Strobach [Sat, 30 Jul 2011 16:56:55 +0000 (18:56 +0200)]
[BUGFIX] The requested URL typo3/undefined was not found on this server

Wrong handling of module url changes in modulemenu causes false
loadings.

This change changes the loading logic a bit, so that it works again.

Resolves: #28594
Releases: 4.6, 4.5

Change-Id: I1692040e38645d68002ae494e9261fd0ccb4d42d
Reviewed-on: http://review.typo3.org/3909
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[FEATURE] Integrate string replacement to stdWrap
Oliver Hader [Fri, 29 Jul 2011 09:47:45 +0000 (11:47 +0200)]
[FEATURE] Integrate string replacement to stdWrap

Allow to search/replace strings, optionally with preg-regex.

Change-Id: I05a067e06cf6d6d664a178c6cf91e17178d691a8
Resolves: #19347
Reviewed-on: http://review.typo3.org/3855
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] Error when opening TYPO3 manual
Markus Klein [Sun, 24 Jul 2011 19:12:26 +0000 (21:12 +0200)]
[BUGFIX] Error when opening TYPO3 manual

A missing parameter for SC_view_help::render_Table() causes
TYPO3 manual to produce a PHP warning.
This patch makes the second parameter optional.

Change-Id: I2b3e2cf45d4b7b411e7e7b007c7650df0bd79ea8
Resolves: #28330
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3704
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE] Enable the GIFBUILDER cObject to render 32-bit PNG images
Georg Grossberger [Sun, 24 Jul 2011 16:53:10 +0000 (18:53 +0200)]
[FEATURE] Enable the GIFBUILDER cObject to render 32-bit PNG images

Introduce the "backColor" value "transparent" to create a PNG file
that has a transparent color as background and enhance the existing
code to keep it until the final image is written to a file.

If "transparent" is set the following conditions must be met:
* png_truecolor must be set to TRUE
* reduceColors must not be set
* format must not be set to jpg or gif

If one of those conditions is not met, GIFBUILDER falls back to
its default behaviour. Already existing backColor features are not
affected by this change.

The options "transparentBackground" and "transparentColor" have no
effect if the backColor is transparent

Change-Id: I0ce9a891710bbe1e7cae935c765aff2aa5640415
Resolves: #28405
Releases: 4.6
Reviewed-on: http://review.typo3.org/3703
Reviewed-by: Jo Hasenau
Reviewed-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[FEATURE] Add UI support for Internationalized Domain Names (IDN)
Steffen Gebert [Wed, 27 Jul 2011 22:08:34 +0000 (00:08 +0200)]
[FEATURE] Add UI support for Internationalized Domain Names (IDN)

Add support for inputting and converting IDN domains in TCEforms.

The domain is still stored and processed as punycode, only the user is
now able to also enter also the IDN with its special chars in the
backend.

Include 3rd-party converter class "IDNA Convert"

Change-Id: I87d275a2f3bcfd321147b6d32a5403db704bdc4d
Resolves: #14500
Releases: 4.6
Reviewed-on: http://review.typo3.org/3804
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[FEATURE] Improve wizard for creating new records
Georg Ringer [Wed, 20 Jul 2011 17:30:08 +0000 (19:30 +0200)]
[FEATURE] Improve wizard for creating new records

Add the possibility to group records together, even
when the extension key is a different one.

Change-Id: I4acb806e27fbad6a240c530085e76bfa001c11cc
Resolves: #28353
Reviewed-on: http://review.typo3.org/3440
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Mueller
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE] Add hook to tslib_adminpanel
Georg Ringer [Fri, 29 Jul 2011 13:06:24 +0000 (15:06 +0200)]
[FEATURE] Add hook to tslib_adminpanel

Add a hook to the AdminPanel to allow additional
code beeing added by other extensions

Change-Id: Icec38ca8b91891a515a40ec2e8774a00cf553c40
Resolves: #28568
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3860
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[FEATURE] Enhance info array provided to services
Alexander Stehlik [Thu, 28 Apr 2011 13:10:30 +0000 (15:10 +0200)]
[FEATURE] Enhance info array provided to services

In t3lib_div::makeInstanceService() the info array passed to
the instanciated service class is enhanced with information about
the requested service type, service sub type and the excluded service
keys.

Deprecated references to global vars have been replaced with $GLOBALS
array.

Change-Id: I45d39b3a526ab2c9a2ce273784ecdc4c3f03affd
Resolves: #26410
Reviewed-on: http://review.typo3.org/1776
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[FEATURE] Change t3d exports default export target directory
Mario Rimann [Tue, 26 Jul 2011 21:06:33 +0000 (23:06 +0200)]
[FEATURE] Change t3d exports default export target directory

By default a t3d export ended up in fileadmin/ and the resulting file
was publicly available. This change just changes the default directory
to be fileadmin/_temp_/ which is .htaccess protected and cannot be
accessed from outside.

Change-Id: Ic01e1e38cb96e6f39ea84cd8f71decb046afccb0
Resolves: #17516
Reviewed-on: http://review.typo3.org/3728
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Saving Page Tree states issues in large environments
Jo Hasenau [Sat, 30 Jul 2011 19:59:41 +0000 (21:59 +0200)]
[BUGFIX] Saving Page Tree states issues in large environments

Change the way expanded nodes are saved for be_users back to a simple
key/boolean pair and adjust the size of the uc field to fit the needs of
larger page trees.

Change-Id: Ic926080b0dc0e6e24226ab00554091a5f0ffae66
Resolves: #24884
Releases: 4.6
Reviewed-on: http://review.typo3.org/3912
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Tested-by: Christian Kuhn
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[FEATURE] Use update-query to write fe_session data
Stefan Neufeind [Wed, 15 Jun 2011 22:50:45 +0000 (00:50 +0200)]
[FEATURE] Use update-query to write fe_session data

Use an update-query to write the front end user session data
to the database instead of doing a delete- and insert-query.

Using only one update-query saves resources and avoids
an inconsistent state between the delete- and insert-query
(since no transactions were used).

Original patch by Netresearch.

Change-Id: I58624215b65bced7473923eb6ce1966650c02860
Resolves: #19286
Reviewed-on: http://review.typo3.org/2761
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Xavier Perseguers
Reviewed-by: Markus Klein
Reviewed-by: Mario Rimann
Reviewed-by: Jo Hasenau
Reviewed-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] t3lib_div::cmpFQDN() lacks support for IPv6 and hostnames
Xavier Perseguers [Tue, 12 Jul 2011 08:16:01 +0000 (10:16 +0200)]
[BUGFIX] t3lib_div::cmpFQDN() lacks support for IPv6 and hostnames

Add checks for IPv4 and IPv6. Otherwise take input as hostname.
Implement correct (recursive) wildcard-checks.
Add unit tests.

Change-Id: I721fb6d376ee9ef01352799dfad1813b38e87ded
Resolves: #27217
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/2526
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[FEATURE] Change the way saltedpasswords sets "eval" in ext_tables.php
Laurent Cherpit [Tue, 26 Jul 2011 16:20:42 +0000 (18:20 +0200)]
[FEATURE] Change the way saltedpasswords sets "eval" in ext_tables.php

For the TCA password fields (BE|FE), saltedpasswords overrides the
field used to add some evaluations method. The problem appears when
another evaluation method is added before saltedpasswords extension is
loaded.
Change the way of the available evaluations methods are added by
saltedpasswords.

Change-Id: Ibcc13da492736891937fefbf9e323338229fb1dc
Resolves: #28494
Releases: 4.6
Reviewed-on: http://review.typo3.org/3725
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Show only not-installed extensions in Upgrade Wizard
Patrick Rodacker [Wed, 25 May 2011 19:15:13 +0000 (21:15 +0200)]
[BUGFIX] Show only not-installed extensions in Upgrade Wizard

Add the same routine from the Upgrade Wizard for new extensions to the
Upgrade Wizard for outsourced extensions to show only not-installed
extensions.

Change-Id: I8e7c0d0d1ff0b5c7f3c6c31fb26d2238730153d3
Resolves: #24914
Releases: 4.6
Reviewed-on: http://review.typo3.org/2371
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX][Cache] Let NullBackend implement PhpCapableBackend
Christian Kuhn [Sat, 30 Jul 2011 19:47:04 +0000 (21:47 +0200)]
[BUGFIX][Cache] Let NullBackend implement PhpCapableBackend

The null backend is very useful to effectivly disable caching
during development. With this change it also implements the
PhpCapableBackend interface and can be used to replace the
FileBackend this way.

This is the v4 backport of FLOW3 changeset
https://review.typo3.org/#change,3910

Additional to the FLOW3 version the null backend is now
required in config_default.php to enable the cache_phpcode
to use this backend in autoloader for development context.

Change-Id: Icca11825742eaa64b1e6f2db2aec48590887cb0b
Resolves: #28598
Related: #28589
Reviewed-on: http://review.typo3.org/3911
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[FEATURE] Session tables: add key for ses_timestamp and simplify timeout-check
Oliver Hader [Thu, 14 Jul 2011 22:50:41 +0000 (00:50 +0200)]
[FEATURE] Session tables: add key for ses_timestamp and simplify timeout-check

* add a key for ses_timestamp (in SQL) to speedup searches
  for sessions within timeout-limit
* simplify the overly-complex timeout-check

Change-Id: I171a63a0a7ec8cdd17c59d34411b41483d672b0f
Resolves: #20877
Reviewed-on: http://review.typo3.org/3341
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] htmlArea RTE: Small improvements for the Upgrade Wizard
Stanislas Rolland [Sun, 31 Jul 2011 02:13:45 +0000 (22:13 -0400)]
[BUGFIX] htmlArea RTE: Small improvements for the Upgrade Wizard

Spell "TSconfig" correctly.

Since only pages are searched for deprecated properties, add a note
that such can also be used in BE groups and BE user records.

Change-Id: I717b63139cf65803ab63e131291e2db1233e610d
Fixes: #28600
Releases: 4.6
Reviewed-on: http://review.typo3.org/3923
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Upgrade wizard incorrectly "finds" deprecated properties
Stanislas Rolland [Sat, 30 Jul 2011 22:57:44 +0000 (18:57 -0400)]
[BUGFIX] Upgrade wizard incorrectly "finds" deprecated properties

Make the pattern binary.
Do not select the pattern followed by 's' (do not select RTE.fontSizes)
Remove fontSize from properties that are replaced automatically.

Change-Id: I09d07c056eefc8e80b833fc59d99fb08c5e2a9b7
Fixes: #28597
Releases: 4.6
Reviewed-on: http://review.typo3.org/3920
Reviewed-by: Christopher
Tested-by: Christopher
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[FEATURE] Link Shortcut pages directly to target
Thorben Kapp [Tue, 19 Jul 2011 11:23:31 +0000 (13:23 +0200)]
[FEATURE] Link Shortcut pages directly to target

Menu items of type shortcut link to the target directly now,
even without realurl.

Change-Id: I444d9eddf4c98c9a8712627bbc5bd24a4c6aebc8
Related: #17037
Releases: 4.6
Reviewed-on: http://review.typo3.org/3413
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[FEATURE] htmlArea RTE: Possiblity to set pastetoggle to ON by default
Stanislas Rolland [Sat, 30 Jul 2011 05:41:28 +0000 (01:41 -0400)]
[FEATURE] htmlArea RTE: Possiblity to set pastetoggle to ON by default

Two new Page TSConfig properties are added:

* RTE.default.buttons.pastetoggle.setActiveOnRteOpen
  If set, and if the pastetoggle button is enabled, the button is
  toggled to ON when the RTE opens.

* RTE.default.buttons.pastetoggle.hidden
  If set, and if the pastetoggle button is enabled, the button is hidden
  in both the toolbar and the context menu.
  Hence, if buttons.pastetoggle.setActiveOnRteOpen is also set, all
  paste operations will be performed using the current clean paste
  behaviour.

The manual is updated to document the fact that default and/or
overriding values may be set for the clean paste behaviour.
For example:
  setup.override.rteCleanPasteBehaviour = plainText

Change-Id: I3f479846d5ce373f7f386fd450603faed08f7e8d
Resolves: #25039
Releases: 4.6
Reviewed-on: http://review.typo3.org/3896
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] htmlArea RTE: Relative url's on pasted links/images in Firefox
Stanislas Rolland [Sat, 30 Jul 2011 20:25:09 +0000 (16:25 -0400)]
[BUGFIX] htmlArea RTE: Relative url's on pasted links/images in Firefox

When copying/pasting an internal link or image from and to the RTE
editing area, Firefox changes the href or src to a relative url.
After save, the url ends up being wrong.

Similar issues arises when moving images or links inside the editing
area and when dropping images in the RTE from the image dialogue
window.

This change works around Firefox issue
https://bugzilla.mozilla.org/show_bug.cgi?id=613517,
by making the url absolute again before saving or toggling
to source text mode, as well as on paste and drop events.

Change-Id: I27024687d897a36133113f47b4d52ca9e0ab6c90
Resolves: #28497, #24852, #27353
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/3916
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[FEATURE] Show default text in search form with HTML5 attribute
Mario Rimann [Tue, 26 Jul 2011 20:39:00 +0000 (22:39 +0200)]
[FEATURE] Show default text in search form with HTML5 attribute

Adds a text "Search for" in the search form input
field as long as no text has been searched for
(improves accessibility). If the doctype is set to
"html5", the text is shown as attribute
placeholder="Search for", otherwise as field value
of the input field.

Change-Id: I6944b21d44ea365ac5969e94d7743f5418962ea2
Resolves: #28347
Resolves: #17496
Reviewed-on: http://review.typo3.org/3688
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Upgrade wizard fails if no deprecated properties are found
Stanislas Rolland [Sat, 30 Jul 2011 16:44:32 +0000 (12:44 -0400)]
[BUGFIX] Upgrade wizard fails if no deprecated properties are found

Upgrade Wizard "Deprecated RTE properties in Page TS Config" fails
when no deprecated properties are used at all.

Make it a success, but keep the information message.

Change-Id: I0e0919cc02536a12d84da3d37cea64afe3af12e3
Resolves: #28593
Releases: 4.6
Reviewed-on: http://review.typo3.org/3908
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[FEATURE] Redirect to Shortcut target page
Thorben [Mon, 18 Jul 2011 13:27:25 +0000 (15:27 +0200)]
[FEATURE] Redirect to Shortcut target page

Redirect directly to the target page in Frontend, if the accessed page
is of type Shortcut and accessed directly via its URL.

Change-Id: I4199cb8c89d6dc5a21dac6f3cd03051245880bd8
Resolves: #28322
Releases: 4.6
Reviewed-on: http://review.typo3.org/3398
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] JSwindow-typolink URLs are encoded twice
Helmut Hummel [Sat, 30 Jul 2011 11:10:39 +0000 (13:10 +0200)]
[BUGFIX] JSwindow-typolink URLs are encoded twice

In #28189 a bug was introduced for JSwindow-typolink URLs.
Because t3lib_div::quoteJSvalue is called without second paramter,
the value passed to it will also be encoded with htmlspecialchars()
which is then done a second time when putting the link together.

Change the t3lib_div::quoteJSvalue call to not encode
the result with htmlspecailchars()

Resolves: #28536
Related: #28189

Releases: 4.3, 4.4, 4.5, 4.6

Change-Id: If6bcad4d2bf1e0a4b3f5a6f04e4718df8e4e7150
Reviewed-on: http://review.typo3.org/3901
Reviewed-by: Torben Hansen
Tested-by: Torben Hansen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX][!!!] Problems with new Card Layout in backend modules
Kay Strobach [Thu, 28 Jul 2011 11:26:02 +0000 (13:26 +0200)]
[BUGFIX][!!!] Problems with new Card Layout in backend modules

There are warnings with backend modules concerning the new _JSINIT array.
To avoid these problems, this patch improves the way the module array is handled.

Module names starting with an underscore character "_" are not considered anymore.

Change-Id: Id749538dd8ee570581cb49df172800ec76242041
Releases: 4.6, 4.5
Resolves: #28523
Reviewed-on: http://review.typo3.org/3820
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Remove workspacemenu.js
Bjoern Pedersen [Thu, 21 Jul 2011 08:28:51 +0000 (10:28 +0200)]
[TASK] Remove workspacemenu.js

typo3/js/workspacemenu.js is outdated and has been superceded by
typo3/sysext/workspaces/Resources/Public/JavaScript/workspacemenu.js

Change-Id: I09f71e38dde6776d1ee75d4d9e75710f5723fe53
Resolves: #25824
Releases: 4.6
Reviewed-on: http://review.typo3.org/3447
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] ExtJS Flashmessages are not shown any more
Philipp Gampe [Tue, 26 Jul 2011 08:01:17 +0000 (10:01 +0200)]
[BUGFIX] ExtJS Flashmessages are not shown any more

Change-Id: Ieac7632e0c4851b28c05bc662fc3855334ac53a4
Resolves: #28462
Releases: 4.6
Reviewed-on: http://review.typo3.org/3719
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Extension Manager: Change the cursor on hover of required extensions
Mario Rimann [Thu, 21 Jul 2011 22:11:44 +0000 (00:11 +0200)]
[BUGFIX] Extension Manager: Change the cursor on hover of required extensions

The new extension manager shows the "hand" cursor when hovering over
the icon of a required extension. This change just disables that by
enforcing the browser to show the default "arrow" cursor.

Change-Id: I05c075710effb9de3de147ba716495362c39da0a
Resolves: #13267
Releases: 4.6
Reviewed-on: http://review.typo3.org/3463
Reviewed-by: Christopher
Tested-by: Christopher
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] htmlArea RTE: localized acronym popup window misses window title
Stanislas Rolland [Fri, 29 Jul 2011 18:43:50 +0000 (14:43 -0400)]
[BUGFIX] htmlArea RTE: localized acronym popup window misses window title

Change-Id: Id5e6dcecdc21aacc0397db9edf91deb32ee0a98e
Resolves: #28575
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3892
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[FEATURE][!!!][CONF] Deprecate various RTE configuration properties
Stanislas Rolland [Wed, 20 Jul 2011 02:54:55 +0000 (22:54 -0400)]
[FEATURE][!!!][CONF] Deprecate various RTE configuration properties

This feature is a first step at simplifying the RTE configuration.

 * Deprecate various, mostly legacy properties, and restructure
   some others in order to make the configuration structure more
   homogeneous.
 * Remove any deprecated properties from the default RTE
   configurations.
 * Provide an Install tool upgrade wizard for substituting some
   of the deprecated properties by their replacement properties and
   reporting the uid's of pages that specify deprecated properties
   that could not be replaced by the wizard; the wizard warns that
   some deprecated properties may be specified in included external
   files; those will need to be updated by the user.
 * Log to the deprecation log any usage of deprecated properties. Allow to
   disable logging of deprecated properties by setting Page
   TS Config property RTE.default.logDeprecatedProperties.disabled = 1.
   Allow to optionally log also to the BE log by setting
   RTE.default.logDeprecatedProperties.logAlsoToBELog = 1.

Change-Id: I3992d308702500ea39a2e7944eea687150995791
Resolves: #28325
Releases: 4.6
Reviewed-on: http://review.typo3.org/3425
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
Reviewed-by: Georg Ringer
8 years ago[TASK] Properly deprecate direct access to DB and file list
Xavier Perseguers [Thu, 28 Jul 2011 11:34:17 +0000 (13:34 +0200)]
[TASK] Properly deprecate direct access to DB and file list

Change-Id: I5ab30c14c57e0dc777d6faadc48fb762572c1469
Reviewed-on: http://review.typo3.org/3821
Reviewed-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Deprecation message should be on a single line
Xavier Perseguers [Thu, 28 Jul 2011 11:35:38 +0000 (13:35 +0200)]
[TASK] Deprecation message should be on a single line

Having a deprecation message on multiple lines somehow breaks
the deprecation log entry as only the first line is logged.

Change-Id: I319d66d5e4cae4d9cc8a9a0392d0e68583459ec4
Reviewed-on: http://review.typo3.org/3823
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[FEATURE] Speedup backend and allow compression in frontend
Kai Vogel [Sat, 25 Jun 2011 08:58:05 +0000 (10:58 +0200)]
[FEATURE] Speedup backend and allow compression in frontend

This patch improves the determination of relative paths of include
files, concatenates the jsFiles and jsFooterFiles in backend by
default to speedup the backend and provides a default compressor
for the frontend.

Change-Id: I569d285cc12c7eec808094903d5c8ee2e749f9ec
Resolves: #27694
Reviewed-on: http://review.typo3.org/2924
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Georg Ringer
8 years ago[FEATURE] felogin: Add hook before HTTP redirect
Xavier Perseguers [Fri, 22 Jul 2011 11:14:24 +0000 (13:14 +0200)]
[FEATURE] felogin: Add hook before HTTP redirect

Implement hook into the login process after a successful login if a
redirect is performed. When no redirect is performed, postProcContent
may be used to perform additional actions.

Change-Id: Id6259fb7c843ad08432f1df27a15963276e08611
Resolves: #23671
Releases: 4.6
Reviewed-on: http://review.typo3.org/3471
Reviewed-by: Helmut Hummel
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Prepare deprecation of t3lib_div::int_from_ver()
Xavier Perseguers [Wed, 27 Jul 2011 08:06:05 +0000 (10:06 +0200)]
[TASK] Prepare deprecation of t3lib_div::int_from_ver()

Deprecating t3lib_div::int_from_ver() in 4.6 leads to major developer
annoyance because this method is used to switch to compatibility code
for older versions of TYPO3 in extensions and a hocus-pocus is needed
to prevent calling it if using 4.6.

Deprecate this method in two phases:
- TYPO3 4.6: mark it as deprecated
- TYPO3 4.7: use deprecation log to deprecate it really

This method should only be removed in TYPO3 4.9.

Change-Id: I73cfc9a5e15f6f336534e3705e914fc37862472e
Resolves: #28499
Releases: 4.6
Reviewed-on: http://review.typo3.org/3733
Reviewed-by: Benjamin Mack
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[FEATURE] Speed-up Backend with CardLayout
Kay Strobach [Fri, 15 Jul 2011 18:03:26 +0000 (20:03 +0200)]
[FEATURE] Speed-up Backend with CardLayout

This patch adds a cardlayout to the Backend.
BE Modules may register themselves to the page renderer and add cards
directly to the layout.

To achieve that, a new way of adding JavaScript to the BE is available.
$GLOBALS['TBE_MODULES']['_JSINIT']['key'] = 'JSCODE';

This way changing the module is quite fast.

To keep old behaviour the iframe is loaded with the module root
url if the module item of an already opened module is clicked.

The Extension Manager or the About module can be simply reworked to support
that feature.

Other new features like the dashboard depend on this change too.

API hints:

JavaScript
 - in old times we used:
   TYPO3.Backend.ContentContainer.setUrl(uri);

   Now please use
   TYPO3.ModuleMenu.App.openInContentFrame(uri, params);
   The "new" function was available before and knows the current
   module. This function uses the correct iframe - if it is allowed to
   load the module.

PHP
 - added new Parameter to t3lib_extMgm::addModule to disable the card
   autocreation on demand

Change-Id: I2bf206b7154c20575b0d2ce72150621b2dfbdb35
Resolves: #12664
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3370
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Tested-by: Soren Malling
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Ext Direct API lacks the possibility of adding access control
Stefan Galinski [Wed, 27 Jul 2011 10:51:23 +0000 (12:51 +0200)]
[BUGFIX] Ext Direct API lacks the possibility of adding access control

Change-Id: I069b13ed5a36b60c1b1c03d027680e7bdb2989e7
Resolves: #25307
Reviewed-on: http://review.typo3.org/3782
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Untrusted GP data is unserialized in wizard_colorpicker.php and view_help.php
Christian Kuhn [Wed, 27 Jul 2011 10:50:49 +0000 (12:50 +0200)]
[BUGFIX] Untrusted GP data is unserialized in wizard_colorpicker.php and view_help.php

Change-Id: Ib148d040cf4c8eb4b3bde6966fdcd494b9ed7cc4
Resolves: #24577
Reviewed-on: http://review.typo3.org/3779
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Unprivileged backend user can read arbitrarily from database
Helmut Hummel [Wed, 27 Jul 2011 10:50:08 +0000 (12:50 +0200)]
[BUGFIX] Unprivileged backend user can read arbitrarily from database

Change-Id: Ie0f19500b713fece84e1fc2caf7d724864965481
Resolves: #26876
Reviewed-on: http://review.typo3.org/3775
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Backend user without accordant language permissions can see workspace changes
Michael Klapper [Wed, 27 Jul 2011 10:43:17 +0000 (12:43 +0200)]
[BUGFIX] Backend user without accordant language permissions can see workspace changes

Change-Id: I808c6879b65f3237ecfb47a2d4145f128fc8ffdf
Resolves: #27414
Reviewed-on: http://review.typo3.org/3768
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] XSS in TYPO3 core when using typolink.parameter JS-Popup Window
Marco Bresch [Wed, 27 Jul 2011 10:30:08 +0000 (12:30 +0200)]
[BUGFIX] XSS in TYPO3 core when using typolink.parameter JS-Popup Window

Change-Id: I1e04d0da3d139eef14d38f3ea4efe86172f4093d
Resolves: #28189
Reviewed-on: http://review.typo3.org/3766
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] XSS in tcemain flash message
Georg Ringer [Wed, 27 Jul 2011 10:29:52 +0000 (12:29 +0200)]
[BUGFIX] XSS in tcemain flash message

Change-Id: I1ee63a425032165587780354849f4521eccd825d
Resolves: #24535
Reviewed-on: http://review.typo3.org/3762
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] XSS in Recycler
Steffen Gebert [Wed, 27 Jul 2011 10:29:30 +0000 (12:29 +0200)]
[BUGFIX] XSS in Recycler

Change-Id: Ic53e31259e1b79f5f1d602e4b01ce9ddafe9e1af
Resolves: #24519
Reviewed-on: http://review.typo3.org/3758
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] XSS in browse_links
Georg Ringer [Wed, 27 Jul 2011 10:29:15 +0000 (12:29 +0200)]
[BUGFIX] XSS in browse_links

Change-Id: I20d53d3c5c7b6b8c92f37104832e7a44d1584341
Resolves: #24497
Reviewed-on: http://review.typo3.org/3754
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] t3lib_div::removeXSS does not remove some XSS
Jigal van Hemert [Wed, 27 Jul 2011 10:28:50 +0000 (12:28 +0200)]
[BUGFIX] t3lib_div::removeXSS does not remove some XSS

Change-Id: I7c546048e986fadcd1b20e74a6c7859fa13cd823
Resolves: #20775
Reviewed-on: http://review.typo3.org/3750
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] The delay if wrong credentials are provided during backend login can be...
Helmut Hummel [Wed, 27 Jul 2011 10:27:43 +0000 (12:27 +0200)]
[BUGFIX] The delay if wrong credentials are provided during backend login can be circumvented

Change-Id: I14a97fcb21bd9ca1c3640de02934bc53935f711e
Resolves: #24457
Reviewed-on: http://review.typo3.org/3744
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[BUGFIX] Information disclosure during backend login
Helmut Hummel [Wed, 27 Jul 2011 10:27:10 +0000 (12:27 +0200)]
[BUGFIX] Information disclosure during backend login

Change-Id: I02e956d3cb41657f68475a3de861ed13fa8b0eb3
Resolves: #24456
Reviewed-on: http://review.typo3.org/3740
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
8 years ago[TASK] Remove useless function comment
Georg Ringer [Wed, 27 Jul 2011 09:10:17 +0000 (11:10 +0200)]
[TASK] Remove useless function comment

The function getHash in t3lib_page is pointless
and can just be removed, thx to Manual Mitasch for
spotting.

Change-Id: Ifd6182d3476af025b69ec5bc4187fa62a6d33084
Resolves: #28503
Releases: 4.6
Reviewed-on: http://review.typo3.org/3734
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[TASK] Fix deprecation comment for t3lib_div::int_from_ver()
Xavier Perseguers [Tue, 26 Jul 2011 09:48:31 +0000 (11:48 +0200)]
[TASK] Fix deprecation comment for t3lib_div::int_from_ver()

Method t3lib_div::int_from_ver() has been deprecated but the phpDoc
comment is wrong. Problem is that the phpDoc is used in the
deprecation log, thus giving wrong advice to the developer.

Change-Id: Ic15258bb81ae776ce499e1d1151af295cc963daa
Reviewed-on: http://review.typo3.org/3721
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Remove duplicate hsc() for title tag at login
Georg Ringer [Thu, 9 Jun 2011 17:56:03 +0000 (19:56 +0200)]
[BUGFIX] Remove duplicate hsc() for title tag at login

htmlspecialchars() is called twice for the title tag
at the backend login page.
Once in typo3/index.php (which is removed with
this change) and one time in t3lib_pagerenderer when
filling the TITLE marker.

Change-Id: I711044c1bcce478c6935cf1fb32fef39097ce6a1
Resolves: #24975
Reviewed-on: http://review.typo3.org/2612
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Mario Rimann
8 years ago[BUGFIX] systemLocale related issues
Steffen Gebert [Mon, 25 Jul 2011 17:06:44 +0000 (19:06 +0200)]
[BUGFIX] systemLocale related issues

* Improve the description of TYPO3_CONF_VARS[SYS][systemLocale] option
* Add a hint to this option in thumbs.php, when thumbnail generation
  fails with the file not being found.

Resolves: #21609
Releases: 4.6, 4.5

Change-Id: I866dd29c941652f4f47492e7b256ae5bf7fed832
Reviewed-on: http://review.typo3.org/3714
Reviewed-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[BUGFIX] CSH labels are always in English
Xavier Perseguers [Mon, 25 Jul 2011 06:20:27 +0000 (08:20 +0200)]
[BUGFIX] CSH labels are always in English

The CSH labels are always rendered in English because the source
language (English) is used instead of its translation (target).
Only fall back to source if the corresponding label was not
translated.

Change-Id: Icaaa17734b46b49ba48c2949cd7e48ee1c251750
Fixes: #28439
Reviewed-on: http://review.typo3.org/3711
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] htmlArea RTE not loading with Safari 5.1
Stanislas Rolland [Sun, 24 Jul 2011 20:36:52 +0000 (16:36 -0400)]
[BUGFIX] htmlArea RTE not loading with Safari 5.1

In Safari 5.1, due to changes related to WebKit2, the RTE may never
load while waiting for stylesheets to become accessible, or it may
load but the editing area remains empty and not editable.

Change-Id: Ife4c8c5b59c93ba749a3bcfe7d72ce755200df47
Resolves: #28360
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3707
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years agoRevert "[BUGFIX] BE User module allows switching to CLI users"
Francois Suter [Sun, 24 Jul 2011 16:48:17 +0000 (18:48 +0200)]
Revert "[BUGFIX] BE User module allows switching to CLI users"
after discussion in the Core list. Switching to CLI users *is* useful.

This reverts commit e6960f21ba07208ca8ab305812d0e4d4a64a7f80

Change-Id: I825f92e5478c5e6c8af90c32d4c4b8a707bfef13
Reviewed-on: http://review.typo3.org/3702
Reviewed-by: Francois Suter
Tested-by: Francois Suter
8 years ago[BUGFIX] Add name of missing file to Exception in thumbs.php
Steffen Gebert [Sun, 24 Jul 2011 11:15:01 +0000 (13:15 +0200)]
[BUGFIX] Add name of missing file to Exception in thumbs.php

Exception #1270853950 only gives a hint that
"Image does not exist and/or MD5 checksum did not match."

It is pretty hard to find out, which image is responsible for this,
without outputting the file name. Thus add the file name of the image.

Change-Id: Ie931f8c797020dad154c6694753e5ea448740ff2
Resolves: #24807
Reviewed-on: http://review.typo3.org/3699
Reviewed-by: Philipp Gampe
Reviewed-by: Mario Rimann
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Improve check in t3lib_div::makeInstance
Bjoern Pedersen [Thu, 21 Jul 2011 08:14:57 +0000 (10:14 +0200)]
[BUGFIX] Improve check in t3lib_div::makeInstance

The strict string comparison is not enough to catch
all wrong arguments and throw a correct error.

Change-Id: Id7911229f90d1aa0f6ce5830a434bceb4ab61da5
Resolves: #25047
Releases: 4.6
Reviewed-on: http://review.typo3.org/3446
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[TASK] Remove @author annotation from Caching Framework
Steffen Gebert [Sat, 23 Jul 2011 21:22:08 +0000 (23:22 +0200)]
[TASK] Remove @author annotation from Caching Framework

Change-Id: I5bb4cfeeea9c379b04cbb980e9ba87320473f501
Reviewed-on: http://review.typo3.org/3694
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Chained stdWrap is broken for boolean stdWrap function types
Stefan Neufeind [Fri, 15 Jul 2011 12:52:33 +0000 (14:52 +0200)]
[BUGFIX] Chained stdWrap is broken for boolean stdWrap function types

isExecuted was not correctly set and so stdWrap was
actually called twice.

Thanks to Jo Hasenau.

Change-Id: If35c3bb3572265109207d3835135d9cc5d487a0a
Resolves: #28234
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3355
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] t3lib_TCEforms is calling deprecated method t3lib_div::testInt()
Xavier Perseguers [Fri, 22 Jul 2011 15:09:22 +0000 (17:09 +0200)]
[BUGFIX] t3lib_TCEforms is calling deprecated method t3lib_div::testInt()

As testInt, calcPriority and calcParenthesis were moved and renamed to
t3lib_utility_Math we have to change the core usages, too.

Change-Id: I13892a7d81fce116b771b75a099dc83342997cd8
Fixes: #28398
Related: #28096
Reviewed-on: http://review.typo3.org/3476
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Prevent indexing of Backend login page in search engines
Steffen Gebert [Thu, 21 Jul 2011 13:21:11 +0000 (15:21 +0200)]
[BUGFIX] Prevent indexing of Backend login page in search engines

Change-Id: Id22f34fd39daf33c69f233a54e6d969e4bab1eae
Resolves: #22599
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3453
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Add default security settings in .htaccess
Xavier Perseguers [Thu, 21 Jul 2011 21:18:47 +0000 (23:18 +0200)]
[TASK] Add default security settings in .htaccess

Add a new security section within .htaccess to help users secure their
TYPO3 install:

- Restrict access to deleted files in Recycler directories
- Restrict access to TypoScript files in default templates directories
- Restrict access to Private extension directories

Resolves: #28368
Change-Id: I94c09f50616af55cfdd9577097251692b2111ae7
Reviewed-on: http://review.typo3.org/3462
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
8 years ago[TASK] Remove deprecated parts marked for removal
Xavier Perseguers [Fri, 15 Jul 2011 11:13:02 +0000 (13:13 +0200)]
[TASK] Remove deprecated parts marked for removal

Parts of Core are marked as deprecated and should be removed in
TYPO3 4.6. This patch does this clean-up.

Change-Id: Ib33c649d1b1f31ebbfb0fe6e825bb81b47b185a1
Resolves: #27983
Releases: 4.6
Reviewed-on: http://review.typo3.org/3351
Reviewed-by: Markus Klein
Reviewed-by: Philipp Gampe
Reviewed-by: Georg Ringer
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] Regression: filelistFolderTree constructor is recursive
Philipp Gampe [Wed, 20 Jul 2011 20:56:55 +0000 (22:56 +0200)]
[BUGFIX] Regression: filelistFolderTree constructor is recursive

After fix of compatibility constructor, the real constructor
(__construct) is missing. This leads to a recursive call on
itself and thus crashes.

Change-Id: Ic788b8dfb9ae42a4ad7c1b9a122f31de1df98741
Fixes: #28354
Releases: 4.6
Reviewed-on: http://review.typo3.org/3445
Reviewed-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] t3libExtMgm does not cache extension version
Bjoern Pedersen [Fri, 15 Jul 2011 12:14:15 +0000 (14:14 +0200)]
[BUGFIX] t3libExtMgm does not cache extension version

The t3lib_extMgm::getExtensionVersion function includes
the ext_emconf.php file of an extension each time it is called.

The version is cached using the CF runtime cache.

Change-Id: I05502a035a597b5b2b09e60d4027db47d8e2ac71
Resolves: #28233
Releases: 4.6
Reviewed-on: http://review.typo3.org/3353
Reviewed-by: Georg Ringer
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[FEATURE] Enable closing of ExtJS FlashMessages
Kay Strobach [Tue, 28 Jun 2011 17:32:13 +0000 (19:32 +0200)]
[FEATURE] Enable closing of ExtJS FlashMessages

Some of the FlashMessages have such a big space requirement that users
have to wait, until they disappear to continue working in the backend.

This patch makes the ExtJS FlashMessages disappear, if the user clicks
on close icon in the message header.

Change-Id: I270dc0b6b4cfef945aa5802abcf586671db63e8b
Resolves: #27747
Releases: 4.6
Reviewed-on: http://review.typo3.org/2956
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[BUGFIX][CONF] Changed default sorting of fe_users in BE
Mario Rimann [Wed, 20 Jul 2011 08:22:17 +0000 (10:22 +0200)]
[BUGFIX][CONF] Changed default sorting of fe_users in BE

The default sorting was missing in TCA for the fe_users table. Not the table is ordered by the username field by default, but the backend user is able to override this via the GUI.

Change-Id: I565be72644d65beaa9f694269ccd3b6d5c077700
Resolves: #25604
Reviewed-on: http://review.typo3.org/3433
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Chris Zepernick
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[BUGFIX] Wrong check for existance of translated label
Steffen Gebert [Sun, 17 Jul 2011 11:46:25 +0000 (13:46 +0200)]
[BUGFIX] Wrong check for existance of translated label

While tslib_fe::getLL() checks the existance of a translated label with
isset(), language::getLLL() does this with a strict string comparison.
This is evaluated as TRUE, if the subkey is not set at all, which is an
unexpected behavior.

Thus check, whether the label was translated into the current language
using isset().

Change-Id: I421d541d9aeaa2403052d212c7adba819a4e116f
Resolves: #28264
Releases: 4.6
Reviewed-on: http://review.typo3.org/3380
Reviewed-by: Xavier Perseguers
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[BUGFIX] Cache FileBackend does not respect fileCreateMask
Steffen Gebert [Tue, 19 Jul 2011 20:00:57 +0000 (22:00 +0200)]
[BUGFIX] Cache FileBackend does not respect fileCreateMask

Change-Id: Ia786457dbc4c850c67f7293be38b2591786f1553
Resolves: #28323
Releases: 4.6
Reviewed-on: http://review.typo3.org/3422
Reviewed-by: Fabrizio Branca
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[BUGFIX] Increase "maxitems" for media in TCA of pages
Stefan Neufeind [Tue, 19 Jul 2011 12:42:50 +0000 (14:42 +0200)]
[BUGFIX] Increase "maxitems" for media in TCA of pages

Because of type TEXT the database already allows for more
than 5 items. So this patch raises the level in TCA as well.

Change-Id: I7acb4d9bfc38b6d5cef0fabe82560586f0c4eea3
Resolves: #28317
Releases: 4.6
Reviewed-on: http://review.typo3.org/3417
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Chris Zepernick
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
8 years ago[FEATURE] TCA: Allow parameters to be specified for userFunc
Xavier Perseguers [Tue, 19 Jul 2011 12:04:02 +0000 (14:04 +0200)]
[FEATURE] TCA: Allow parameters to be specified for userFunc

Add support for user-supplied parameters when using a userFunc
within a TCA field.

Change-Id: Ic808c7bc067f232d881631b790e41112fe53c44c
Resolves: #28314
Reviewed-on: http://review.typo3.org/3432
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX] htmlArea RTE: htmlArea RTE: Removing class from link in IE8 won't work
Stanislas Rolland [Wed, 20 Jul 2011 04:23:12 +0000 (00:23 -0400)]
[BUGFIX] htmlArea RTE: htmlArea RTE: Removing class from link in IE8 won't work

Removing a class on a link in the link dialogue works in Firefox and IE7 but not in IE8, due to IE8's new conformance to standard name for class attribute.

Change-Id: I304520071d428be5e6fd613252be74dcaadc8b91
Resolves: #28009
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3426
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
8 years ago[BUGFIX] Remove hardcoded limits in T3D export
Georg Ringer [Thu, 9 Jun 2011 17:22:07 +0000 (19:22 +0200)]
[BUGFIX] Remove hardcoded limits in T3D export

The memory_limit is hardcoded to 256m and
max_execution_time to 600.

There is no reason to hardcode those settings,
sometimes a bit more of both is needed.

Change-Id: I3e690eea1a079ed6cadd548230afc405e005b115
Resolves: #27272
Resolves: #17020
Resolves: #17045
Resolves: #18926
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/2610
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Björn Pedersen
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
8 years ago[FEATURE] Add warning for IE6 users
Steffen Gebert [Fri, 8 Jul 2011 19:41:16 +0000 (21:41 +0200)]
[FEATURE] Add warning for IE6 users

As IE6 is not supported anymore, add a warning that the user should
upgrade his browser.

Change-Id: Id7d8411ae38e55dd6fa2747dce2fb85522c7bbc7
Resolves: #20953
Reviewed-on: http://review.typo3.org/3381
Reviewed-by: Stefan Neufeind
Tested-by: Eric Chavaillaz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[API][!!!] Fix API compatibility break
Xavier Perseguers [Fri, 15 Jul 2011 18:59:22 +0000 (20:59 +0200)]
[API][!!!] Fix API compatibility break

Task #26505 removed old PHP4 constructors without deprecating
them first as required by TYPO3 core rules.
The change was commited to Git here: https://review.typo3.org/1797

The fix: reintroduce the old constructors and deprecate them.

Change-Id: I2fa86c6d2ddb7ffd79fbd5afbbd29eddb975ec01
Resolves: #28246
Releases: 4.6
Reviewed-on: http://review.typo3.org/3371
Reviewed-by: Stefano Kowalke
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
8 years ago[FEATURE] Enable saltedpasswords by default
Helmut Hummel [Sun, 17 Jul 2011 18:00:35 +0000 (20:00 +0200)]
[FEATURE] Enable saltedpasswords by default

Implement auto-activation of saltedpasswords and rsaauth extension.

Resolves: #28273
Releases: 4.6

Change-Id: If96cbbffec59f436748e331783bc6fc94fb2b87d
Reviewed-on: http://review.typo3.org/3389
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] Unit test checkDateWithInvalidDateValues fails with PHP warning
Steffen Gebert [Sun, 17 Jul 2011 17:33:59 +0000 (19:33 +0200)]
[BUGFIX] Unit test checkDateWithInvalidDateValues fails with PHP warning

If TYPO3 is configured to not suppress PHP warnings, the unit test
'checkDateWithInvalidDateValues with data set "Not Good"'
of Testsuite tx_scheduler_ModuleTest fails.

As it tries to insert non-numeric values into mkstring(), this warning
is raised.

We can safely suppress the output of PHP warnings for the mktime call,
as afterwards its return value is checked.

Change-Id: I7c6b9f587b574334e0096c800de98cb6ffc2033f
Resolves: #28271
Reviewed-on: http://review.typo3.org/3388
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[TASK][DB] Move workspace preview into versioning/workspace
Benjamin Mack [Sun, 17 Jul 2011 11:04:47 +0000 (13:04 +0200)]
[TASK][DB] Move workspace preview into versioning/workspace

As the whole handling of the ADMCMD_preview is related to
version / workspaces, the according code should go in
these extensions, thus it is removed in the core.

Change-Id: Iee2f4ea42aa28825d991df92eff53c7143d93e83
Resolves: #27931
Releases: 4.6
Reviewed-on: http://review.typo3.org/3080
Reviewed-by: Stefan Neufeind
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
8 years ago[BUGFIX] Value 0 in integer fields is not shown in List module anymore
Steffen Gebert [Fri, 15 Jul 2011 17:40:23 +0000 (19:40 +0200)]
[BUGFIX] Value 0 in integer fields is not shown in List module anymore

A side-effect of #27936 is that the value 0 of integer fields is not
shown anymore in the List module. This error was also catched by the
failing Unit Test t3lib_befuncTest::getProcessedValueForZeroStringIsZero

Change-Id: I07da5d05c08a9066e8e9c8ad68d3f83ef6f7dbcb
Resolves: #28218
Relates: #27936
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/3369
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
8 years ago[FEATURE] RTE rendering: Table cell content wrapped in paragraphs
Stanislas Rolland [Thu, 14 Jul 2011 15:34:33 +0000 (11:34 -0400)]
[FEATURE] RTE rendering: Table cell content wrapped in paragraphs

By default, the content of table cells is always wrapped in
paragraph tags when rendered in the frontend even if no
paragraphs are entered in the RTE.

This RFC changes this default. Non-wrapped content will not
be wrapped in paragraph inside a table cell.

Change-Id: Ia23d0bbab338d6fb0efc90eb60bdd485a2c2c5f8
Resolves: #25084
Reviewed-on: http://review.typo3.org/3327
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[FEATURE] Enable stdWrap for select.where
Stefan Neufeind [Thu, 14 Jul 2011 20:52:34 +0000 (22:52 +0200)]
[FEATURE] Enable stdWrap for select.where

stdWrap was supported at select.andWhere already.

Be careful not to use GPvar with this feature without
securing it (e.g. with stdWrap.intval)

Change-Id: I22c0e2c1c49fdd44ab67b823043a2e07f304e8c8
Resolves: #17881
Reviewed-on: http://review.typo3.org/3337
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Styling of security warnings
Johannes Feustel [Wed, 13 Jul 2011 18:16:56 +0000 (20:16 +0200)]
[BUGFIX] Styling of security warnings

* List style is missing.
* Get rid of inline styles.
* Render p instead of li if only one message comes up (e.g. if reports module is installed).

Change-Id: Ic24b92c74eb55cb54cc3f76d2207c3b10ab4cbea
Releases: 4.6, 4.5
Fixes: #28181
Reviewed-on: http://review.typo3.org/3314
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[BUGFIX] Fix front end redirect to 1-2-3 installer
Christian Kuhn [Wed, 13 Jul 2011 21:03:05 +0000 (23:03 +0200)]
[BUGFIX] Fix front end redirect to 1-2-3 installer

An empty value in the TYPO3_db constant indicates a not configured installation in
the front end. The front end then redirects to 1-2-3 installer.
This broke with change 89732c4a of #27954 because the check for db constant
is done too late.

Change the order of the checks during database connection and
check if the TYPO3_db constant has a value first.

Change-Id: I0a7003d876a747e16552fecf6385b0449de5617a
Resolves: #28185
Related: #27954
Reviewed-on: http://review.typo3.org/3316
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
8 years ago[FEATURE] Implement extbase naming scheme in core autoloader
Xavier Perseguers [Wed, 29 Jun 2011 15:06:04 +0000 (17:06 +0200)]
[FEATURE] Implement extbase naming scheme in core autoloader

The patch enables the core autoloader to find class files that are named
according to the exbase class and file location naming scheme.
This renders ext_autoload.php entries obsolete for class locations
that stick to the extbase scheme even if extbase is not used
for an extension. The autoloaders within fluid and extbase are not
needed anymore.
Additionally, the class-to-file information is cached in the core
autoloader cache in order to reduce the number of file system lookups
for consecutive calls.
The patch is covered by unit tests to verify the complex logic.

Change-Id: I1af68a2d95cfc590eecffe6d06ea4e4eb58e11ec
Resolves: #21144
Related: #28249
Related: #28250
Reviewed-on: http://review.typo3.org/2985
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
8 years ago[BUGFIX] cli_dispatch.phpsh respects path to php
Markus Bucher [Thu, 14 Jul 2011 18:55:16 +0000 (20:55 +0200)]
[BUGFIX] cli_dispatch.phpsh respects path to php

Using '#! /usr/bin/env php' as shebang respects the environment, so
if e.g. /usr/local/bin is in your PATH, this php will be chosen.

Change-Id: Ia5e6c5ed3c3615bec373b3075daf0f43721584ce
Resolves: #24506
Reviewed-on: http://review.typo3.org/3331
Reviewed-by: Andreas Lappe
Tested-by: Andreas Lappe
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[TASK] Invalidate autoloader cache in em
Christian Kuhn [Thu, 14 Jul 2011 21:58:59 +0000 (23:58 +0200)]
[TASK] Invalidate autoloader cache in em

The autoloader cache should be invalidated by the extension manager
if installing new or removing old extension from extension list to
force a recalculation of available classes on next access.

Change-Id: I485dc62aa2d3644136392b7608c77a11cf408332
Resolves: #28219
Related: #28063
Related: #28186
Related: #28187
Reviewed-on: http://review.typo3.org/3339
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[TASK] Remove XCLASS definitions from cache classes
Christian Kuhn [Thu, 14 Jul 2011 22:39:32 +0000 (00:39 +0200)]
[TASK] Remove XCLASS definitions from cache classes

With #28063 many core cache classes are required directly during bootstrap.
This makes XCLASS impossible since those base classes are not instantiated
with t3lib_div::makeInstance() anymore. t3lib_cache is static and can not be
XCLASSED. The caching framework has a built-in feature to register and use own
implementations. The patch removes all XCLASS definitions of cache classes.

Change-Id: I1e624bb769b899a14491aa3ee1cca9da480ebfb6
Resolves: #28221
Related: #28063
Reviewed-on: http://review.typo3.org/3340
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
8 years ago[BUGFIX] Localization of a constant string is empty
Xavier Perseguers [Fri, 15 Jul 2011 07:27:03 +0000 (09:27 +0200)]
[BUGFIX] Localization of a constant string is empty

When using a constant string (e.g., "CSS Styled Content") instead of a
localization key (e.g., "LLL:EXT:some_ext/locallang.xml:key"), the constant
string should be returned instead of an empty string.

Change-Id: I409664dc5174d818e875fd03a7e6c6e7fbda9e91
Fixes: #28223
Reviewed-on: http://review.typo3.org/3345
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
8 years ago[BUGFIX][INSTALL] Show description for enableDeprecationLog as <dl>
Steffen Gebert [Sat, 9 Jul 2011 09:38:19 +0000 (11:38 +0200)]
[BUGFIX][INSTALL] Show description for enableDeprecationLog as <dl>

Currently it's listed inline in the text, make it a definition list.

Change-Id: I18c2df10a0e18dbc167b40465192909cf30278e6
Resolves: #28024
Reviewed-on: http://review.typo3.org/3174
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack