Packages/TYPO3.CMS.git
5 weeks ago[BUGFIX] Ensure result is string in __toString of CropVariantCollection 87/59887/2
Susanne Moog [Wed, 6 Mar 2019 17:57:59 +0000 (18:57 +0100)]
[BUGFIX] Ensure result is string in __toString of CropVariantCollection

CropVariantCollection returns output from json_encode in its __toString
method. Json_encode may return false if it fails to properly encode the
given data (mostly when non-UTF8 data is given). To ensure that no
exception is thrown to the user in that case, the __toString method
has been adjusted to return the same result as in the empty variants case.

Resolves: #79823
Releases: master, 9.5
Change-Id: Idfbdbbbd867251c8480a0729412dd6d652f57ee1
Reviewed-on: https://review.typo3.org/c/59887
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
5 weeks ago[BUGFIX] Prevent empty new form from being closed without confirmation 37/60237/2
Wolfgang Klinger [Wed, 13 Mar 2019 15:23:31 +0000 (16:23 +0100)]
[BUGFIX] Prevent empty new form from being closed without confirmation

Set ‘has-change’ on new empty content element form container
to trigger the confirmation dialog when using ‘Close’.

Resolves: #87890
Releases: master, 9.5
Change-Id: Idc3d8fdca0f865991ee09935f4b75683dffb4d7e
Reviewed-on: https://review.typo3.org/c/60237
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
5 weeks ago[TASK] Use native idn functionality 34/60234/7
Benni Mack [Wed, 13 Mar 2019 08:13:20 +0000 (09:13 +0100)]
[TASK] Use native idn functionality

It is safe to use idn_to_ascii() these days
due to symfony's polyfill functionality.

This allows us to remove the dependency
"algo26-matthias/idna-convert".

Also, all other places now use the native
idn_to_ascii() call, which could speed up
performance.

The wrapper call GeneralUtility::idnaEncode()
can then safely be deprecated.

used composer command:
  composer remove algo26-matthias/idna-convert

Resolves: #87894
Releases: master
Change-Id: I85aa6f39b8ff5ac171cd73218ed1144a56d9f724
Reviewed-on: https://review.typo3.org/c/60234
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 weeks ago[BUGFIX] Do not send empty scheduler status mails 74/60174/2
Guido Schmechel [Mon, 11 Mar 2019 23:47:13 +0000 (00:47 +0100)]
[BUGFIX] Do not send empty scheduler status mails

Due to a missing initialization, the status providers were not filled
in the status report in the scheduler task. The providers are now
initialized in the constructor and can now always be used.

Resolves: #87555
Releases: master, 9.5
Change-Id: Ia9b02b13061775ce297f6d2881ce8332c9714591
Reviewed-on: https://review.typo3.org/c/60174
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
5 weeks ago[BUGFIX] Rename PageParameterValidator to PageArgumentValidator 61/60261/2
Markus Klein [Fri, 15 Mar 2019 15:29:19 +0000 (16:29 +0100)]
[BUGFIX] Rename PageParameterValidator to PageArgumentValidator

This patch renames the remaining usages of class PageParameterValidator
to PageArgumentValidator.

Resolves: #87932
Releases: master, 9.5
Change-Id: Ia8d8651b5caddcaa6df846007d37b8ea542e771f
Reviewed-on: https://review.typo3.org/c/60261
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[TASK] Replace bool properties in ClassSchema with a BitSet 26/59626/5
Alexander Schnitzler [Sun, 3 Feb 2019 17:16:57 +0000 (18:16 +0100)]
[TASK] Replace bool properties in ClassSchema with a BitSet

Instead of using multiple properties that hold bool flags,
ClassSchema now holds all flags in a single BitSet property.

This drastically reduces the size of the class schemata cache
file, as a lot of properties no longer need to be serialized.

Releases: master
Resolves: #87631
Change-Id: I12b2d8a2f4e481d55b1f57ce00bfede599b4cb32
Reviewed-on: https://review.typo3.org/c/59626
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
5 weeks ago[TASK] Extract ValidatorClassNameResolver from ValidatorResolver 52/59952/4
Alexander Schnitzler [Sat, 9 Mar 2019 10:23:14 +0000 (10:23 +0000)]
[TASK] Extract ValidatorClassNameResolver from ValidatorResolver

The ValidatorResolver contained a method for resolving validator
class names. Extbase supports various shorthand notations to
make the life of developers more easy. There are notations like:

- NotEmpty
- TYPO3.CMS.Extbase:NotEmpty
- CustomExtension:ValidatorName

Resolving these notations takes place in a dedicated
ValidatorClassNameResolver class now.

Releases: master
Resolves: #87868
Change-Id: Ib0d57127a0e1dc4ae0536a8e76ca497f6d2bd56d
Reviewed-on: https://review.typo3.org/c/59952
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[TASK] Move language labels to correct extension(s) 92/60092/4
Susanne Moog [Mon, 11 Mar 2019 12:43:45 +0000 (13:43 +0100)]
[TASK] Move language labels to correct extension(s)

The filelist module contained labels solely used in different extensions,
for example "sys_file_storage.*" labels which was only used by the `core` extension.
Those labels have been moved to their corresponding parent extension.

This patch is a prerequisite for making filelist uninstallable and part
one of decoupling the filelist module. For more information see the
Epic.

Related: #87878
Resolves: #87879
Releases: master
Change-Id: I4954f9e8c45866ce34f387ec637b347b0d681bd8
Reviewed-on: https://review.typo3.org/c/60092
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
5 weeks ago[BUGFIX] Check if field exists when deleting items from `group` field 59/60259/2
Andreas Fernandez [Fri, 15 Mar 2019 13:32:46 +0000 (14:32 +0100)]
[BUGFIX] Check if field exists when deleting items from `group` field

Fields of type `group` don't have a visible counterpart as opposed to
`selectMultipleSideBySide`. Thus, we have to check whether such field
exists before trying to interact with that field.

Resolves: #87925
Related: #87324
Releases: master
Change-Id: Ic8608e065b155949d15ab8d576e30f8d7f8d86db
Reviewed-on: https://review.typo3.org/c/60259
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 weeks ago[DOCS] Update ext:rte_ckeditor manual for > v8 LTS 54/60254/4
Josef Glatz [Thu, 14 Mar 2019 22:53:39 +0000 (23:53 +0100)]
[DOCS] Update ext:rte_ckeditor manual for > v8 LTS

- add info about ext:rtehtmlarea support
- add info about the wordcount plugin and its location
- remove obsolete installation instructions

Resolves: #87918
Releases: master, 9.5
Change-Id: I9ceb9fd4b75ea801c363bed9a3e783eba23ce4bd
Reviewed-on: https://review.typo3.org/c/60254
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 weeks ago[TASK] Remove needless string concatenations 55/60155/5
Georg Ringer [Mon, 11 Mar 2019 16:55:14 +0000 (17:55 +0100)]
[TASK] Remove needless string concatenations

Replace string concatenations like 'abc' . 'def' with 'abcdef'.

Resolves: #87004
Releases: master
Change-Id: I9c1a610e88dd4bd4e617214989a915b1dafda094
Reviewed-on: https://review.typo3.org/c/60155
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
5 weeks ago[TASK] Move filelist related controllers to filelist 53/60153/9
Susanne Moog [Mon, 11 Mar 2019 15:29:09 +0000 (16:29 +0100)]
[TASK] Move filelist related controllers to filelist

The following controllers have been moved to filelist as they are
part of filelist functionality and not called anywhere else:

- `CreateFolderController`
- `EditFileController`
- `FileUploadController`
- `RenameFileController`
- `ReplaceFileController`

In addition the TypeScript module `RenameFile` has also been moved to
EXT:filelist.

The base file function route `tce_file` has not been changed.

Related: #87878
Resolves: #87882
Releases: master
Change-Id: I160d13dc6ac20de23aa89543c0f6975ad403075e
Reviewed-on: https://review.typo3.org/c/60153
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 weeks ago[TASK] Upgrade ckeditor to 4.11.3 43/60243/2
Andreas Fernandez [Wed, 13 Mar 2019 18:24:44 +0000 (19:24 +0100)]
[TASK] Upgrade ckeditor to 4.11.3

This patch updates ckeditor to the latest version 4.11.3.

Used command:

    yarn upgrade ckeditor

List of changes:
https://github.com/ckeditor/ckeditor-releases/compare/4.11.1...4.11.3

Resolves: #87905
Releases: master, 9.5, 8.7
Change-Id: Iafbde59625de902774997ca0acffc9a92ba36534
Reviewed-on: https://review.typo3.org/c/60243
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
5 weeks ago[TASK] Migrate TYPO3/CMS/Install/* to TypeScript 09/59709/13
Frank Naegler [Fri, 15 Feb 2019 17:09:36 +0000 (18:09 +0100)]
[TASK] Migrate TYPO3/CMS/Install/* to TypeScript

This patch migrates all install tool JS files to TypeScript.
It also improves the performance by a better caching and
with less request for modules.

Resolves: #87724
Releases: master
Change-Id: I555924008bf19eb4394268acc231eca91d8b16c6
Reviewed-on: https://review.typo3.org/c/59709
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 weeks ago[BUGFIX] Fix broken TS build due to outdated patch 45/60245/3
Andreas Fernandez [Thu, 14 Mar 2019 09:04:46 +0000 (10:04 +0100)]
[BUGFIX] Fix broken TS build due to outdated patch

The patch for issue #87324 was based on outdated tslint configuration,
which causes all TypeScript builds to fail. The build is now fixed
by executing

    cd Build
    ./node_modules/tslint/bin/tslint -c tslint.json --fix --project .

Resolves: #87908
Related: #87324
Releases: master
Change-Id: I1447dd98aba693756f64308c048a5da199a505df
Reviewed-on: https://review.typo3.org/c/60245
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 weeks ago[TASK] Split FormEngine.js 08/58608/22
Andreas Fernandez [Wed, 10 Oct 2018 17:41:02 +0000 (19:41 +0200)]
[TASK] Split FormEngine.js

This patch splits the FormEngine.js into smaller, logically separated
parts. This increases readability and maintainability and has a positive
effect on the client's performance as only the required code is loaded.

Not every aspect of the FormEngine JavaScript is handled here yet, since
other areas, e.g. IRRE, need refactoring as well.

Resolves: #87324
Releases: master
Change-Id: I6704445254a524f8ed3152ab6b0b7105fb97d65a
Reviewed-on: https://review.typo3.org/c/58608
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
5 weeks ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\Error\Message 97/59597/5
Alexander Schnitzler [Thu, 31 Jan 2019 19:04:47 +0000 (20:04 +0100)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\Error\Message

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87602
Change-Id: Ieb9d9baa84aca6ab93a3468694ef5886bc7ed119
Reviewed-on: https://review.typo3.org/c/59597
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
5 weeks ago[BUGFIX] Add jquery.clearable to backend page tree filter 72/60172/2
Wolfgang Klinger [Mon, 11 Mar 2019 19:19:39 +0000 (20:19 +0100)]
[BUGFIX] Add jquery.clearable to backend page tree filter

Resolves: #87888
Releases: master, 9.5
Change-Id: Ie21c58f7d7e14285ec4b841324340841cde8cbec
Reviewed-on: https://review.typo3.org/c/60172
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
5 weeks ago[TASK] Remove loading of FileListLocalisation in FormEngine 12/60112/2
Susanne Moog [Mon, 11 Mar 2019 12:59:48 +0000 (13:59 +0100)]
[TASK] Remove loading of FileListLocalisation in FormEngine

The FileListLocalisation requirejs module has been removed from
FormResultCompiler. The module is used for displaying translation
toggles in the file list module (and only there).

Related: #87878
Resolves: #87880
Releases: master
Change-Id: Ifd94d1d9b594a1b6962760f45fbb4645b2383f78
Reviewed-on: https://review.typo3.org/c/60112
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
5 weeks ago[BUGFIX] Add field static_page_arguments to group by of query 72/59972/2
Georg Ringer [Sat, 9 Mar 2019 15:37:08 +0000 (16:37 +0100)]
[BUGFIX] Add field static_page_arguments to group by of query

With #86994 a new field has been added to the database table
`index_phash`. This fields needs to be added to the GROUP BY
statement as well.

Resolves: #87855
Releases: master, 9.5
Change-Id: I7b5270434b152e463ccf36886d963017fa6ad548
Reviewed-on: https://review.typo3.org/c/59972
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
5 weeks ago[BUGFIX] Update core system extension composer.json file 33/60233/2
Benni Mack [Wed, 13 Mar 2019 05:32:42 +0000 (06:32 +0100)]
[BUGFIX] Update core system extension composer.json file

In commit #11292caf2016587f61ab32258e848d24ae5db663
the update of composer.json was forgotten, so this is added
now.

Resolves: #87893
Related: #87090
Related: #87843
Releases: master
Change-Id: Iff0ce9c5272794f5f433a1098faba7db3e7f1ae0
Reviewed-on: https://review.typo3.org/c/60233
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
5 weeks ago[BUGFIX] Allow umlaut domains for site domain resolving 58/59958/6
Benni Mack [Sat, 9 Mar 2019 14:34:19 +0000 (15:34 +0100)]
[BUGFIX] Allow umlaut domains for site domain resolving

As umlaut domains require to be puny-coded, this needs
to be added into the request context of the SiteMatcher.

A polyfill package "symfony/polyfill-intl-idn" is installed
to ensure that the methods exist at all times. If "ext-intl"
is not available, the polyfill package is used.

Installed via
    composer require symfony/polyfill-intl-idn

Resolves: #87090
Resolves: #87843
Releases: master, 9.5
Change-Id: I209c01953b3a0f2c25b4e1f11ab74ed4bb29f569
Reviewed-on: https://review.typo3.org/c/59958
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Include Records with "All Languages" in default language 93/59993/3
Benni Mack [Sat, 9 Mar 2019 18:39:05 +0000 (19:39 +0100)]
[BUGFIX] Include Records with "All Languages" in default language

Records with "All Languages" (sys_language_uid=-1)
aren't shown in TYPO3 v9 anymore of the default
language.

This happened before in TYPO3 v8 and below,
however setting config.sys_language_overlay = 1
triggered the if() condition to jump into the
selection of fetching 0 and -1 records.

As this setting is removed, the check only
applies when overlays are activated, which
is not necessary in language=0.

Resolves: #86972
Resolves: #87749
Resolves: #87093
Releases: master, 9.5
Change-Id: I9308167aede071125df02b848a26283e3f77b759
Reviewed-on: https://review.typo3.org/c/59993
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Replace styles.content.get in Install Tool created TS 54/60154/2
Georg Ringer [Mon, 11 Mar 2019 16:20:54 +0000 (17:20 +0100)]
[TASK] Replace styles.content.get in Install Tool created TS

Use cObject CONTENT directly instead of using styles.content.get

Resolves: #87886
Releases: master
Change-Id: I68df06ca1a3aca2b1545efb343c8474c60da228b
Reviewed-on: https://review.typo3.org/c/60154
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
6 weeks ago[TASK] Add slug field to page-related DataHandler tests 92/59992/3
Benni Mack [Sat, 9 Mar 2019 16:19:59 +0000 (17:19 +0100)]
[TASK] Add slug field to page-related DataHandler tests

In order to ensure SlugHelper's base functionality, DataHandler
Regular test suite.

Once this is in, Workspace-related DataHandler tests are added.

Resolves: #87872
Releases: master, 9.5
Change-Id: I0265b66a4dc310c01bb2a583a76d622201dad78d
Reviewed-on: https://review.typo3.org/c/59992
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Replace strings with constants/variables 54/59954/2
Benni Mack [Sat, 9 Mar 2019 12:57:04 +0000 (13:57 +0100)]
[TASK] Replace strings with constants/variables

There are a few places where - instead of hard-coded values,
the proper constants or variables can be used instead.

Resolves: #87870
Releases: master
Change-Id: Ia1053bddefc7627cdc9699360df68ec317898d45
Reviewed-on: https://review.typo3.org/c/59954
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Use correct default value for sys_file_storage|is_public 32/60032/2
Georg Ringer [Mon, 11 Mar 2019 06:12:57 +0000 (07:12 +0100)]
[BUGFIX] Use correct default value for sys_file_storage|is_public

Use 1 instead of true as default value.

Resolves: #87873
Releases: master, 9.5, 8.7

Change-Id: I6665ebd5b59336a00ea3019cf30ba5c98123a4f6
Reviewed-on: https://review.typo3.org/c/60032
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Pass original DBALException along with SqlErrorException 88/59888/3
Christian Futterlieb [Wed, 6 Mar 2019 17:53:01 +0000 (18:53 +0100)]
[BUGFIX] Pass original DBALException along with SqlErrorException

When a
TYPO3\CMS\Extbase\Persistence\Generic\Storage\Exception\SqlErrorException
is thrown, pass the previous exception as 3rd parameter to the
constructor, to get the real reason for the exception.

Resolves: #87852
Releases: master, 9.5, 8.7
Change-Id: I20d711c0038b51a1d0c12d9a975d8c0da1f510f4
Reviewed-on: https://review.typo3.org/c/59888
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Futterlieb <christian@futterlieb.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 weeks ago[BUGFIX] Fix typos in PHP comments 53/59953/2
Benni Mack [Sat, 9 Mar 2019 12:50:48 +0000 (13:50 +0100)]
[BUGFIX] Fix typos in PHP comments

Resolves: #87869
Releases: master, 9.5
Change-Id: I789b4f28d2895c7e7bc53f0a6e04649f89709c14
Reviewed-on: https://review.typo3.org/c/59953
Tested-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] GifBuilder returns already generated images 44/59644/14
Markus Klösges [Tue, 5 Feb 2019 12:26:24 +0000 (13:26 +0100)]
[BUGFIX] GifBuilder returns already generated images

When combining image files with gifbuilder, the hash to identify the
resulting file is now stable with respect to the fact whether the
files are cropped or scaled in the current request or already cropped
before. That leads to stable hashes whenever the same images are
processed with the same configuration, and allows reuse as intended.

Also ensure that fileInfo returned from ContentObjectRenderer contains
width and height information as int, when they are returned from
database as that may lead to different serialized representations of the
configuration

Resolves: #44518
Resolves: #86947
Resolves: #87224
Releases: 8.7, 9.5, master
Change-Id: I833585034cacaf5a0ad66ba3ff04ac3920421085
Reviewed-on: https://review.typo3.org/c/59644
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Raise typo3/phar-stream-wrapper to v3.1.0 50/59850/5
Oliver Hader [Mon, 4 Mar 2019 20:37:58 +0000 (21:37 +0100)]
[TASK] Raise typo3/phar-stream-wrapper to v3.1.0

composer require typo3/phar-stream-wrapper:^3.1.0

Resolves: #87840
Releases: master, 9.5, 8.7
Change-Id: I16b472081df6813cd80afe06504fe1541f8bd769
Reviewed-on: https://review.typo3.org/c/59850
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
6 weeks ago[BUGFIX] Ensure Lowercase folders on non-case-sensitive file system 80/59880/3
Susanne Moog [Wed, 6 Mar 2019 11:08:32 +0000 (12:08 +0100)]
[BUGFIX] Ensure Lowercase folders on non-case-sensitive file system

When creating files in a storage configured as not case-sensitive
the file name gets lowercased and TYPO3 works with the lowercased
version everywhere. When creating folders the lowercasing was missing,
resulting in an exception as the expectation still was to have only
lowercased files and folders on non-case-sensitive systems.

Lowercasing for folder creation has been implemented.

Resolves: #85583
Releases: master, 9.5, 8.7
Change-Id: Icd12ea602ceda9de8bc1a44c58f8ebeaef9a8008
Reviewed-on: https://review.typo3.org/c/59880
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[BUGFIX] Access correct event variable in ContextMenu.ts 52/59852/2
Frank Naegler [Mon, 4 Mar 2019 20:49:40 +0000 (21:49 +0100)]
[BUGFIX] Access correct event variable in ContextMenu.ts

Resolves: #87839
Releases: master, 9.5
Change-Id: I9097c4e53c44b3a08eaf82ddc332514d196e1722
Reviewed-on: https://review.typo3.org/c/59852
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[BUGFIX] Add requireJs for Inline JavaScript in file replace view 51/59851/3
Frank Naegler [Mon, 4 Mar 2019 20:46:02 +0000 (21:46 +0100)]
[BUGFIX] Add requireJs for Inline JavaScript in file replace view

Resolves: #87795
Releases: master, 9.5
Change-Id: I6455729515757580b6de7704d0986414ddec0493
Reviewed-on: https://review.typo3.org/c/59851
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[BUGFIX] Remove possibility to exclude width/height in sys_file_metadata 83/59883/3
Susanne Moog [Wed, 6 Mar 2019 12:39:21 +0000 (13:39 +0100)]
[BUGFIX] Remove possibility to exclude width/height in sys_file_metadata

Width and height are readonly fields updated by system image service API.
To ensure the API (for example the crop wizard) works flawlessly for
editors out of the box, width and height are no longer exclude fields.

Bugfix is for master only, as the workaround for earlier versions is
as simple as putting this in TCA overrides:

unset(
    $GLOBALS['TCA']['sys_file_metadata']['columns']['width']['exclude'],
    $GLOBALS['TCA']['sys_file_metadata']['columns']['height']['exclude']
);

Releases: master
Resolves: #81964
Change-Id: I53f6c5353f0a8d629a9d209675a19def2d6c7a60
Reviewed-on: https://review.typo3.org/c/59883
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 weeks ago[TASK] Add code comments that explain the Extbase validation logic 28/59928/2
Alexander Schnitzler [Fri, 8 Mar 2019 20:59:44 +0000 (20:59 +0000)]
[TASK] Add code comments that explain the Extbase validation logic

Releases: master
Resolves: #87866
Change-Id: I55396a865b03df644028287a031854526d3eb445
Reviewed-on: https://review.typo3.org/c/59928
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Prevent exception in file list 79/59879/2
Susanne Moog [Wed, 6 Mar 2019 10:36:27 +0000 (11:36 +0100)]
[BUGFIX] Prevent exception in file list

When creating a file with a disallowed file
extension an exception was thrown as on creation
the redirect to edit interface on a non-existing
file was called.

Though the better fix might be to prevent the
request for an invalid file to be sent at all
this fix ensures a working file list module in
a more "surgical" way to allow secure backporting.

Resolves: #87527
Releases: master, 9.5, 8.7
Change-Id: I35a054c05b37c09acab83a7aa9eca89cf9ebf6b9
Reviewed-on: https://review.typo3.org/c/59879
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Fix strict type error in recursive mount point resolving 16/59916/4
Benni Mack [Thu, 7 Mar 2019 21:02:46 +0000 (22:02 +0100)]
[BUGFIX] Fix strict type error in recursive mount point resolving

PageLinkBuilder::populateMountPointMapForPageRecursively() requires
the $id parameter to be an integer, so this is cast properly now.

In addition, one regression is fixed where
"config.MP_mapRootPoints = root" was set, the proper variables
are now used.

Resolves: #87547
Resolves: #87473
Releases: master, 9.5
Change-Id: I899120d301309d768b9e498ad7f4ec96b9618b9d
Reviewed-on: https://review.typo3.org/c/59916
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
6 weeks ago[BUGFIX] Remove invalid sort link in filelist module 95/59895/3
Susanne Moog [Thu, 7 Mar 2019 10:56:25 +0000 (11:56 +0100)]
[BUGFIX] Remove invalid sort link in filelist module

Sorting in filelist happens via FAL drivers. Those are not capable of
sorting by TYPO3 References. The filelist nevertheless links and passes
the value _REF_ to FAL as sort option resulting in unpredictable results.

The _REF_ sort link has now been removed to avoid confusion.

Resolves: #61618
Releases: master, 9.5
Change-Id: Ie3cd46617cb7bafe0ae6d8c4252e52c11a4c98d7
Reviewed-on: https://review.typo3.org/c/59895
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Prevent various PHP notices 19/59919/2
Markus Klein [Fri, 8 Mar 2019 00:52:41 +0000 (01:52 +0100)]
[BUGFIX] Prevent various PHP notices

Resolves: #87862
Releases: master, 9.5
Change-Id: I7a48f155c031a9213034def7b39905cf9007ec50
Reviewed-on: https://review.typo3.org/c/59919
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Catch ExpressionLanguage exception for invalid base variants 01/59901/5
Benni Mack [Thu, 7 Mar 2019 18:44:16 +0000 (19:44 +0100)]
[BUGFIX] Catch ExpressionLanguage exception for invalid base variants

When adding an invalid expression for base variants,
an error is now caught instead of breaking the system.

Resolves: #87859
Releases: master, 9.5
Change-Id: I05bc10cd5f6bea7f9929c67d709cd8a0de908478
Reviewed-on: https://review.typo3.org/c/59901
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
6 weeks ago[BUGFIX] Use TSConfig defaults for DataHandler 53/58453/5
Guido Schmechel [Sat, 29 Sep 2018 11:49:59 +0000 (13:49 +0200)]
[BUGFIX] Use TSConfig defaults for DataHandler

Now the DataHandler observes the default values set in TsConfig. Example:

TCAdefaults.pages {
    # set page to visible
    hidden = 0
}

Resolves: #59383
Releases: master, 9.5
Change-Id: I51e5d07e4e9a9457135bb9af88868cd52af373d7
Reviewed-on: https://review.typo3.org/c/58453
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
6 weeks ago[BUGFIX] Do not use named parameter for list of ids in plain data resolver 49/57849/16
Gleb Levitin [Thu, 9 Aug 2018 16:23:52 +0000 (18:23 +0200)]
[BUGFIX] Do not use named parameter for list of ids in plain data resolver

The plain data resolver sorts records by a list of uids.
This list can get very big so the database will fail if the
number of placesholders exceeds its limit.

Resolves: #85797
Releases: master, 9.5
Change-Id: I0b8a623fe00660b8f2c87a83a7e48ba430790d2b
Reviewed-on: https://review.typo3.org/c/57849
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 weeks ago[BUGFIX] Reduce strictness for .pl files in fileDenyPattern 86/59886/5
Oliver Hader [Wed, 6 Mar 2019 16:46:56 +0000 (17:46 +0100)]
[BUGFIX] Reduce strictness for .pl files in fileDenyPattern

Files like "file.pl.txt" cannot be uploaded anymore since ".pl" is
considered as executable Perl file. In multilingual scenarios "pl"
is used as reference for Polish content. Since required modules
mod_perl or mod_cgid are not enabled by default, and limited to
be executable only when invoked in location "/cgi-bin/", now only
files ending with ".pl" (e.g. "file.pl") are denied.

Resolves: #87733
Releases: master, 9.5, 8.7
Change-Id: Ib9a69fd3ec04f51653857d2f7309e30b78932653
Reviewed-on: https://review.typo3.org/c/59886
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
6 weeks ago[BUGFIX] Do not treat all classes as entities in ClassSchema 06/59806/2
Alexander Schnitzler [Mon, 4 Feb 2019 09:03:08 +0000 (10:03 +0100)]
[BUGFIX] Do not treat all classes as entities in ClassSchema

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Releases: master, 9.5
Resolves: #87632
Change-Id: I15f7688b8bf1ac9486d77a0efc38ccb07a397b30
Reviewed-on: https://review.typo3.org/c/59806
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] ClassSchema must analyze all property doc blocks 46/59846/4
Alexander Schnitzler [Mon, 4 Mar 2019 18:23:39 +0000 (18:23 +0000)]
[BUGFIX] ClassSchema must analyze all property doc blocks

While introducing symfony/property-info with
https://review.typo3.org/c/Packages/TYPO3.CMS/+/59454,
the analyzing of property doc blocks changed. Before,
all properties had been analyzed but with that commit,
the analyzing had been reduced to inject and collection
properties. This however breaks the validation which is
based on knowing the type of properties.

Releases: master
Resolves: #87838
Relates: #87457
Change-Id: I171cbbe1bf1cc6d6bac235bd6158c2864c7deb4a
Reviewed-on: https://review.typo3.org/c/59846
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] Check existence of OEmbed title 78/59878/2
Susanne Moog [Wed, 6 Mar 2019 10:25:43 +0000 (11:25 +0100)]
[BUGFIX] Check existence of OEmbed title

Under certain circumstances the title property
of the OEmbed info might be empty, so the check
has been expanded to contain the used property.

Resolves: #87529
Releases: master, 9.5
Change-Id: I1e56f0d91cb6c6f86a5b16f375525b5da30d3f9f
Reviewed-on: https://review.typo3.org/c/59878
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Properly render hidden fields for IRRE records 05/59605/2
Helmut Hummel [Fri, 1 Feb 2019 12:20:11 +0000 (13:20 +0100)]
[BUGFIX] Properly render hidden fields for IRRE records

Despite $resultArray['additionalHiddenFields'] being properly
set by the elements, this section is never evaluated
in InlineRecordContainer.

Evaluate content in this property and render the fields
in the HTML output.

Resolves: #87614
Releases: master, 9.5, 8.7
Change-Id: Idb45a906d3cb019e915c94df59fa215405cb1af3
Reviewed-on: https://review.typo3.org/c/59605
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[FEATURE] Allow sorting by file metadata "Title" in CE FileLinks 97/59897/3
Susanne Moog [Thu, 7 Mar 2019 14:13:16 +0000 (15:13 +0100)]
[FEATURE] Allow sorting by file metadata "Title" in CE FileLinks

FAL allows sorting by all metadata properties, the content element
file links had no interface for that until now. The possibility to sort
by the meta data "title" has been introduced. As "title" is provided by
the core, we can be sure that the field exists.

All other fields should be implemented by the integrators by extending
TCA.

Resolves: #56213
Releases: master
Change-Id: I7eb6fb314d52e5bfff96fb5e32d210266edb57e9
Reviewed-on: https://review.typo3.org/c/59897
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
6 weeks ago[BUGFIX] Fix @var comment in AbstractFileCollection 92/59892/2
Susanne Moog [Thu, 7 Mar 2019 08:43:32 +0000 (09:43 +0100)]
[BUGFIX] Fix @var comment in AbstractFileCollection

A collection can contain either File or FileReferences. The typehint
only referenced Files confusing developers. The typehint has been
fixed.

Resolves: #67091
Releases: master, 9.5
Change-Id: I9362d19e9e80121b8c048d3eb5dd5931ed923cf9
Reviewed-on: https://review.typo3.org/c/59892
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Add missing licence header to viewhelper classes 76/59876/3
Anja Leichsenring [Tue, 5 Mar 2019 21:09:17 +0000 (22:09 +0100)]
[TASK] Add missing licence header to viewhelper classes

Resolves: #87849
Releases: master, 9.5
Change-Id: I483e0728fe6ba8440d839729ffe09b2209d27ca9
Reviewed-on: https://review.typo3.org/c/59876
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[TASK] Change abandoned package mso/idna-convert 81/59881/2
Susanne Moog [Wed, 6 Mar 2019 11:53:44 +0000 (12:53 +0100)]
[TASK] Change abandoned package mso/idna-convert

Composer commands:
composer remove mso/idna-convert
composer require algo26-matthias/idna-convert:^1.1.0

Resolves: #87779
Releases: master, 9.5, 8.7
Change-Id: Id7cb8dda54f356479a72bfc0718b1b9256382fb3
Reviewed-on: https://review.typo3.org/c/59881
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Access and update attribute `data-action` explicitly in Core Updater 75/59875/3
Andreas Fernandez [Tue, 5 Mar 2019 20:08:09 +0000 (21:08 +0100)]
[BUGFIX] Access and update attribute `data-action` explicitly in Core Updater

This patch updates the data attribute `action` via overriding the HTML
attribute. Previously, jQuery's `.data()` was used which broke the
functionality as the DOM gets re-rendered and jQuery lost the overriden
value in its data object.

Resolves: #87847
Releases: master, 9.5
Change-Id: Iddece8ccd498373b0490ea99b6808b76e6c5c2cf
Reviewed-on: https://review.typo3.org/c/59875
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
7 weeks ago[BUGFIX] Catch possible error due to wrong redirect regex 17/59817/7
Markus Klein [Mon, 4 Mar 2019 19:36:44 +0000 (20:36 +0100)]
[BUGFIX] Catch possible error due to wrong redirect regex

Capture possible errors due to invalid regex for redirects.
Log those errors as warnings.
Additionally the placeholder text of the source field is enhanced
with a proper example for a regex.

Resolves: #87744
Releases: master, 9.5
Change-Id: Ia4fa763282d91f9e69e2050df3a26c50633ee08b
Reviewed-on: https://review.typo3.org/c/59817
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 weeks ago[BUGFIX] Fix fallback language handling 76/59676/36
Andreas Fernandez [Sat, 9 Feb 2019 17:20:56 +0000 (18:20 +0100)]
[BUGFIX] Fix fallback language handling

This commit solves some issues regarding language fallback handling:

- Resolve correct page for a localized variant respecting fallbacks
  The Page Router now respects the configured language fallback chain
  and tries to find a matching page candidate per language.

- Metadata of page (e.g. page title)
  TSFE now respects the reconfigured language content id in case the
  language fallback is active and resolves the correct data.

- Respect existing localizations in menu rendering
  PageRepository, used by the menu, now respects the language fallback
  chain and finds suitable localized pages.
  However, this does not resolve all issues with shortcut pages.

Resolves: #81657
Resolves: #86595
Resolves: #19114
Releases: master, 9.5
Change-Id: Ic2b302989449ec14e7e6b5c54819870770655da9
Reviewed-on: https://review.typo3.org/c/59676
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Ralf Merz <mail@merzilla.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
7 weeks ago[BUGFIX] Force closing tag in PageViewHelper 11/59811/3
Riny van Tiggelen [Wed, 27 Feb 2019 10:08:41 +0000 (11:08 +0100)]
[BUGFIX] Force closing tag in PageViewHelper

Unlike all the other link viewhelpers (based on tagbuilder),
the PageViewHelper does not force the closing tag which
results in an invalid tag when there is no content available.

Resolves: #87804
Releases: master, 9.5, 8.7
Change-Id: Ia49aaf1f2f80be4fa3febee08f5285bebd2c0189
Reviewed-on: https://review.typo3.org/c/59811
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
7 weeks ago[BUGFIX] Add check for string to prevent PHP warning 79/59779/5
Peter Kraume [Thu, 21 Feb 2019 13:17:31 +0000 (14:17 +0100)]
[BUGFIX] Add check for string to prevent PHP warning

Resolves: #87762
Releases: master, 9.5, 8.7
Change-Id: I2e7b8b7bee6d69b3e1ae4458257be802d0d97d14
Reviewed-on: https://review.typo3.org/c/59779
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
7 weeks ago[BUGFIX] Streamline base variants for sites 38/59838/2
Benni Mack [Mon, 4 Mar 2019 10:57:43 +0000 (11:57 +0100)]
[BUGFIX] Streamline base variants for sites

The base variants for site handling was implemented
without taking the site languages into account.

This changes adds the base variants to site
languages as well.

Resolves: #87831
Relates: #86303
Releases: master, 9.5
Change-Id: I2269e8cc8cf1f733cf671de4906c1be765a2b260
Reviewed-on: https://review.typo3.org/c/59838
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Nikolaj Wojtkowiak-Pfänder <nwp@dr-bock.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nikolaj Wojtkowiak-Pfänder <nwp@dr-bock.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
7 weeks ago[BUGFIX] Fix wrong test case 36/59836/2
Frank Naegler [Sun, 3 Mar 2019 19:45:28 +0000 (20:45 +0100)]
[BUGFIX] Fix wrong test case

With #87085 a wrong test case was introduced. this patch fix the wrong
test case.

Resolves: #87828
Related: #87085
Releases: master
Change-Id: I79b44bf8739f2869f32fbc85d85d92d2feea9987
Reviewed-on: https://review.typo3.org/c/59836
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
7 weeks ago[BUGFIX] Reintroduce removed page tree TSconfig settings 86/59586/6
Soren Malling [Wed, 30 Jan 2019 08:52:51 +0000 (09:52 +0100)]
[BUGFIX] Reintroduce removed page tree TSconfig settings

This patch reintroduces to `excludeDoktypes` to the
pagetree ajax controller

Resolves: #87581
Related: #82919
Releases: master, 9.5
Change-Id: Ib1f4917e016668ff298412fc8906bd881849e13a
Reviewed-on: https://review.typo3.org/c/59586
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Soren Malling <soren@meteko.dk>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
7 weeks ago[BUGFIX] Fix indexing of pages using route enhancers 83/58983/17
Alexander Grein [Thu, 29 Nov 2018 14:23:54 +0000 (15:23 +0100)]
[BUGFIX] Fix indexing of pages using route enhancers

Because of pages using route enhancers do not use cHash in most cases,
it is necessary to add the static arguments of the page to generate the
phash values used by indexed_search.

For administration of the indexed pages, the static arguments of the page
are stored in the index_phash table as well, which makes enhancing inevitable.

Resolves: #86994
Releases: master, 9.5
Change-Id: I2e0f09a782481b024ef3fdb6efd81c22fb2fddc3
Reviewed-on: https://review.typo3.org/c/58983
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Hendrik Helmken <h.helmken@atlantismedia.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Hendrik Helmken <h.helmken@atlantismedia.de>
Reviewed-by: Benni Mack <benni@typo3.org>
7 weeks ago[TASK] Migrate TYPO3/CMS/Backend/FormEngine/Element/SelectSingleElement to TypeScript 70/59670/4
Frank Naegler [Fri, 8 Feb 2019 14:46:18 +0000 (15:46 +0100)]
[TASK] Migrate TYPO3/CMS/Backend/FormEngine/Element/SelectSingleElement to TypeScript

Resolves: #84422
Releases: master
Change-Id: I59af07e8abbe54cb09c7d4c0159f3f2ca2213672
Reviewed-on: https://review.typo3.org/c/59670
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[!!!][TASK] Don't guess extension name by looking at controller name 23/59623/5
Alexander Schnitzler [Sat, 2 Feb 2019 14:15:42 +0000 (15:15 +0100)]
[!!!][TASK] Don't guess extension name by looking at controller name

\TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::$extensionName
had been set in the constructor by looking at the controller class
name and guessing the extension name by removing parts of the
class namespace.

Since the extension name is known when registering plugins and modules,
the extension name will no longer be guessed in the constructor but
can be fetched from the request object.

Releases: master
Resolves: #87627
Change-Id: I307275861003f7e6bd37e76a77658c283a9b2bd2
Reviewed-on: https://review.typo3.org/c/59623
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[TASK] Update to phpunit 7.5 23/59823/4
Christian Kuhn [Fri, 1 Mar 2019 13:57:56 +0000 (14:57 +0100)]
[TASK] Update to phpunit 7.5

Updating to latest v7 branch of phpunit is blocked by
codeception which relies on phpunit-mock-objects, so
we need to update this first from 2.4 to 2.5:

composer require --dev codeception/codeception:^2.5.4

Updating its dependencies then drops phpunit-mock-objects
and fetches phpunit 7.5:

composer update --with-dependencies codeception/codeception

Younger phpunit now has a random-order built in, the currently
used plugin can be removed:

composer remove --dev fiunchinho/phpunit-randomizer

typo3/testing-framework needs a raise to prevent a lower
phpunit version that would break the randomizer again:

composer require --dev typo3/testing-framework:~5.0.6

runTests.sh and its docker-compose file need some adaptions
so the unit test randomizer can be used, example calls:

Build/Scripts/runTests.sh -s unitRandom

Build/Scripts/runTests.sh -s unitRandom -o 1551445682

bamboo also needs some adaptions to now use built in phpunit
random functionality instead of phpunit-randomizer.

Change-Id: I0acfebdcb1f4da785845c8397ad23b7bb8174505
Resolves: #87107
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/c/59823
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[BUGFIX] Make slugs unique when copying pages 86/59686/5
Helmut Hummel [Tue, 12 Feb 2019 17:45:35 +0000 (18:45 +0100)]
[BUGFIX] Make slugs unique when copying pages

When a page is copied the slug for the copied page
needs to be unique for a site. To accomplish that,
the site for the record is fetched. Since this new
record does not have a uid yet, the parent page uid
must be used to determine the site.

Resolves: #87697
Releases: master, 9.5
Change-Id: Iac5fa7adc673c41662b652e932c23b90633e0d5d
Reviewed-on: https://review.typo3.org/c/59686
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[TASK] Migrate TYPO3/CMS/Backend/Wizard to TypeScript 69/59669/6
Frank Naegler [Fri, 8 Feb 2019 12:44:01 +0000 (13:44 +0100)]
[TASK] Migrate TYPO3/CMS/Backend/Wizard to TypeScript

Resolves: #82612
Releases: master
Change-Id: I6dd7d2138afe98bd60889dd4f25b7a3b2dca287d
Reviewed-on: https://review.typo3.org/c/59669
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[TASK] Migrate TYPO3/CMS/Recordlist/* to TypeScript 97/59697/14
Frank Naegler [Wed, 13 Feb 2019 13:46:38 +0000 (14:46 +0100)]
[TASK] Migrate TYPO3/CMS/Recordlist/* to TypeScript

Resolves: #87708
Releases: master
Change-Id: I5870f39805e2bd89c8ea57566e949c40620e389f
Reviewed-on: https://review.typo3.org/c/59697
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[BUGFIX] Calc permissions for edit links correctly 96/57496/8
Guido Schmechel [Sat, 7 Jul 2018 10:22:11 +0000 (12:22 +0200)]
[BUGFIX] Calc permissions for edit links correctly

If an editor searches for something in LiveSearch, the
permission to edit non-pages records is now calculated correctly.

Resolves: #85251
Releases: master, 9.5
Change-Id: I1e28c7d431f24d9afcf3b0682fdc53a515fd8441
Reviewed-on: https://review.typo3.org/c/57496
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[FEATURE] Fallback options for slug fields 67/59167/14
Guido Schmechel [Sun, 16 Dec 2018 11:39:38 +0000 (12:39 +0100)]
[FEATURE] Fallback options for slug fields

Now it is possible to define several fields with fallback function for
the generatorOptions fields.

Releases: master, 9.5
Resolves: #87085
Change-Id: I985f35267955dc43baaad2263ed8947c2c87b7c6
Reviewed-on: https://review.typo3.org/c/59167
Reviewed-by: Martin Kutschker <martin.kutschker@ymail.com>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: Sebastian Rosskopf <sebastian.rosskopf@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[BUGFIX] Ensure redirectUrl is a string 95/59795/2
Andreas Wolf [Sun, 24 Feb 2019 15:51:25 +0000 (16:51 +0100)]
[BUGFIX] Ensure redirectUrl is a string

Change-Id: I69837c58e8d31eaa094748c55e27b862d501455c
Resolves: #87775
Releases: master
Reviewed-on: https://review.typo3.org/c/59795
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
7 weeks ago[BUGFIX] Properly use requirejs-loader.js in frontend context 10/59810/3
Oliver Hader [Wed, 27 Feb 2019 09:27:08 +0000 (10:27 +0100)]
[BUGFIX] Properly use requirejs-loader.js in frontend context

The eID handler in frontend context had a wrong method name. Besides
that generating according <script src="requirejs-loader.js"> tag had
flaws in path resolving.

Resolves: #87570
Releases: master, 9.5, 8.7
Change-Id: Ic5a3b824e8ae5aa776fd0e6502682aba6ae282b8
Reviewed-on: https://review.typo3.org/c/59810
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[TASK] Migrate TYPO3/CMS/Beuser/* to TypeScript 14/59814/2
Frank Naegler [Wed, 27 Feb 2019 21:35:48 +0000 (22:35 +0100)]
[TASK] Migrate TYPO3/CMS/Beuser/* to TypeScript

Resolves: #87810
Releases: master
Change-Id: Idd4525c1d97006ace05128eaa9093841d782797a
Reviewed-on: https://review.typo3.org/c/59814
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[BUGFIX] Abort slug proposal request on rapid typing 08/59808/2
Andreas Fernandez [Tue, 26 Feb 2019 15:07:05 +0000 (16:07 +0100)]
[BUGFIX] Abort slug proposal request on rapid typing

If an editor enters a manual slug into the slug field, an AJAX request
per keystroke is sent. The patch now aborts requests in case the input
changes while the previous request has not finished yet.

Resolves: #87796
Releases: master, 9.5
Change-Id: Ib61ea0197bcf7f2a85d27c89e08e8fa448fea224
Reviewed-on: https://review.typo3.org/c/59808
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[FEATURE] Add SiteProcessor 61/59761/16
Georg Ringer [Wed, 20 Feb 2019 11:04:31 +0000 (12:04 +0100)]
[FEATURE] Add SiteProcessor

The SiteProcessor can be used to retrieve all properties of the site entity.
This is especially useful if the site configuration is extended with custom
configurations.

Resolves: #87748
Releases: master, 9.5
Change-Id: I650bc9745ca3f0236072aeab9f186b1ea24313e7
Reviewed-on: https://review.typo3.org/c/59761
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Benni Mack <benni@typo3.org>
7 weeks ago[BUGFIX] Support non ASCII url slugs 96/59796/3
Guido Schmechel [Sun, 24 Feb 2019 21:49:48 +0000 (22:49 +0100)]
[BUGFIX] Support non ASCII url slugs

Resolves: #87295
Releases: master, 9.5
Change-Id: Ib4fb1a8283c79a02cbc8cb52d91e2448ad9292ec
Reviewed-on: https://review.typo3.org/c/59796
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[TASK] Tighten rst validation rule for keyword 94/59794/4
Anja Leichsenring [Sun, 24 Feb 2019 07:59:41 +0000 (08:59 +0100)]
[TASK] Tighten rst validation rule for keyword

Ignore FullyScanned|PartiallyScanned|NotScanned when looking for valid
keywords on rst files and update existing Changelog files accordingly.

Resolves: #87774
Relates: #87772
Releases: master, 9.5, 8.7
Change-Id: I5e9a9c690ddb55ef11c52bde074d4e0175b17837
Reviewed-on: https://review.typo3.org/c/59794
Tested-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[BUGFIX] Relax rst validation rules for Feature and Important 90/59790/10
Anja Leichsenring [Sat, 23 Feb 2019 17:39:04 +0000 (18:39 +0100)]
[BUGFIX] Relax rst validation rules for Feature and Important

When looking for FullyScanned|PartiallyScanned|NotScanned ignore Feature
and Important rst files from any version as well as all rst files from
7.x and 8.x

Resolves: #87772
Releases: master, 9.5, 8.7
Change-Id: I7bf2a6068f95603a8ac3e6df4cb336d66963f145
Reviewed-on: https://review.typo3.org/c/59790
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Jürgen Venne <venne@schaffrath-digital.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Jürgen Venne <venne@schaffrath-digital.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 weeks ago[BUGFIX] Remove PageRenderer debug code 09/59809/2
Oliver Hader [Wed, 27 Feb 2019 08:46:39 +0000 (09:46 +0100)]
[BUGFIX] Remove PageRenderer debug code

Resolves: #87803
Releases: master, 9.5, 8.7
Change-Id: I1d99aa132208d5db14eb3aed49308e95998a0f0e
Reviewed-on: https://review.typo3.org/c/59809
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
8 weeks agoRevert "[BUGFIX] Do not treat all classes as entities in ClassSchema" 98/59798/2
Anja Leichsenring [Mon, 25 Feb 2019 09:07:48 +0000 (10:07 +0100)]
Revert "[BUGFIX] Do not treat all classes as entities in ClassSchema"

This reverts commit 7b320c723a59f677fefb56e12cc43da3fbcb4a08.

Reason for revert: see ticket, attempt to fix and discussion here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59793

Change-Id: I2dbbfe0246814b50e5e6ad9eb1828590c6506445
Reviewed-on: https://review.typo3.org/c/59798
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[BUGFIX] htaccess does not allow pages that end with "rc" 03/59803/3
Christian Kuhn [Mon, 25 Feb 2019 16:23:19 +0000 (17:23 +0100)]
[BUGFIX] htaccess does not allow pages that end with "rc"

Page names that end with 'rc' return 403 if using apache
with the default core delivered .htaccess. The directive
should match '.rc$' instead of only 'rc$'.

Resolves: #87783
Releases: master, 9.5, 8.7
Change-Id: I59fd6b2a0d87556209713a0beedae0c6624d866f
Reviewed-on: https://review.typo3.org/c/59803
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
8 weeks ago[TASK] Replace calls to assertAttribute* methods of phpunit 58/59758/6
Anja Leichsenring [Tue, 19 Feb 2019 19:42:46 +0000 (20:42 +0100)]
[TASK] Replace calls to assertAttribute* methods of phpunit

Those methods are about to be removed, in preparation the core tests
were reviewed for usage and replaced with suitable functionality.

Resolves: #87746
Releases: master
Change-Id: Ibc79e656b914f235c27d8461bcca358a38c28b6e
Reviewed-on: https://review.typo3.org/c/59758
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
8 weeks ago[TASK] Don't process vendor names in extbase and fluid 22/59622/4
Alexander Schnitzler [Sat, 2 Feb 2019 13:39:07 +0000 (14:39 +0100)]
[TASK] Don't process vendor names in extbase and fluid

Since the controller class of a given plugin or module
is no longer guessed by looking at the class namespace,
the vendor of classes is no longer relevant.

Releases: master
Resolves: #87626
Change-Id: Ic1464f413634ed4e1e46ba1701d1bebbc8556da3
Reviewed-on: https://review.typo3.org/c/59622
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Use constructor injection in persistence backend 32/59632/4
Alexander Schnitzler [Mon, 4 Feb 2019 15:16:06 +0000 (16:16 +0100)]
[TASK] Use constructor injection in persistence backend

Class Backend does no longer use setter injection but
constructor injection instead.

Releases: master
Resolves: #87643
Change-Id: I4b06be7e3c6011bb0b8661df617017891490e070
Reviewed-on: https://review.typo3.org/c/59632
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[FEATURE] Enable validation of password via hooks during password 14/59714/5
Sascha Grötzner [Sun, 17 Feb 2019 10:53:23 +0000 (10:53 +0000)]
[FEATURE] Enable validation of password via hooks during password
changes

Add a new $_param variable "passwordValid" and
"passwordInvalidMessage" process via Hook.
In the Hook to can do your own validation or other stuff and
set "passwordValid" to false an generate a Message to
"passwordInvalidMessage".
If $hookPasswordValid is false then the password is not set
in DB and the script runs its normal way. (it will redirect
to the PasswordChange Form an prints the
"passwordInvalidMessage")

Resolves: #87726
Releases: master
Change-Id: I89f37e7c5036254b40aa4fffe65a4e6cf2cc213f
Reviewed-on: https://review.typo3.org/c/59714
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[BUGFIX] Do not treat all classes as entities in ClassSchema 28/59628/3
Alexander Schnitzler [Mon, 4 Feb 2019 09:03:08 +0000 (10:03 +0100)]
[BUGFIX] Do not treat all classes as entities in ClassSchema

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Releases: master, 9.5
Resolves: #87632
Change-Id: If4bc79b9761ee28ffd9e2f25924588140310c0fa
Reviewed-on: https://review.typo3.org/c/59628
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[BUGFIX] Don't call mergeRecursiveWithOverrule with null argument 19/59719/4
Alexander Schnitzler [Mon, 18 Feb 2019 13:56:14 +0000 (14:56 +0100)]
[BUGFIX] Don't call mergeRecursiveWithOverrule with null argument

During the removal of deprecated code in Extbase, a bug has been
introduced which is fixed with this patch.

Releases: master
Resolves: #87732
Relates: #87269
Change-Id: I5739acf64c65ad5eb79bcf16c6e7962366af59f6
Reviewed-on: https://review.typo3.org/c/59719
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[BUGFIX] Respect no_cache in PageLinkBuilder 15/59715/2
Georg Ringer [Mon, 18 Feb 2019 07:18:32 +0000 (08:18 +0100)]
[BUGFIX] Respect no_cache in PageLinkBuilder

If a link is being built with a site configuration, the
configuration no_cache must be respected.

Resolves: #87728
Releases: master, 9.5
Change-Id: I8d71f11ca953c5744063deec318d9a23c11c1337
Reviewed-on: https://review.typo3.org/c/59715
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[!!!][TASK] Harden \TYPO3\CMS\Extbase\Property\TypeConverterInterface 30/59630/5
Alexander Schnitzler [Mon, 4 Feb 2019 13:49:23 +0000 (14:49 +0100)]
[!!!][TASK] Harden \TYPO3\CMS\Extbase\Property\TypeConverterInterface

- Use strict type mode
- Use type hints whereever possible

Releases: master
Resolves: #87654
Change-Id: I3f78f502a33f9c9eae61847f32b3f17f47a69836
Reviewed-on: https://review.typo3.org/c/59630
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Mock FileRepository Singletons in unit tests 55/59755/2
Benjamin Franzke [Mon, 18 Feb 2019 14:56:21 +0000 (15:56 +0100)]
[TASK] Mock FileRepository Singletons in unit tests

Prevent indirect SignalSlot\Dispatcher and ObjectManager
invocation by mocking FileRepository.

Releases: master, 9.5
Resolves: #87740
Change-Id: Ia193cc52af95bae9b1306bef012c7871bf939b41
Reviewed-on: https://review.typo3.org/c/59755
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Use constructor injection in PersistenceManager 33/59633/3
Alexander Schnitzler [Mon, 4 Feb 2019 15:31:16 +0000 (16:31 +0100)]
[TASK] Use constructor injection in PersistenceManager

Class PersistenceManager does no longer use setter injection but
constructor injection instead.

Releases: master
Resolves: #87644
Change-Id: Id8daa169cf5cc8756aae47321d828d37bca21233
Reviewed-on: https://review.typo3.org/c/59633
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Deprecate TypeHandlingUtility::hex2bin 03/59603/4
Alexander Schnitzler [Fri, 1 Feb 2019 11:59:31 +0000 (12:59 +0100)]
[TASK] Deprecate TypeHandlingUtility::hex2bin

Method \TYPO3\CMS\Extbase\Utility\TypeHandlingUtility::hex2bin
has been deprecated. As of PHP 5.4, a native function hex2bin
exists, which should be used instead.

Releases: master
Resolves: #87613
Change-Id: I19cfade0584762148a611713412889bec4895200
Reviewed-on: https://review.typo3.org/c/59603
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[FEATURE] Introduce BitSet class 50/59650/6
Alexander Schnitzler [Wed, 6 Feb 2019 10:35:23 +0000 (11:35 +0100)]
[FEATURE] Introduce BitSet class

This patch introduces a simple BitSet class that
can be used to handle boolean flags.

Releases: master
Resolves: #87665
Change-Id: I32911ed1213421ef30596c2aceb4b8cbd27a8a45
Reviewed-on: https://review.typo3.org/c/59650
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Migrate existing ViewHelper docs to valid rst 44/58844/15
Daniel Siepmann [Mon, 5 Nov 2018 17:17:53 +0000 (18:17 +0100)]
[TASK] Migrate existing ViewHelper docs to valid rst

* In order to allow proper rendering at docs.typo3.org
* Only migrated HTML to rst, and streamlined structure.

Resolves: #86855
Releases: master, 9.5
Change-Id: Ia617d24b0e70182b8702b23a340ad1f2b536910e
Reviewed-on: https://review.typo3.org/c/58844
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Use real ObjectManager stubs in unit tests 57/59757/3
Benjamin Franzke [Mon, 18 Feb 2019 07:12:15 +0000 (08:12 +0100)]
[TASK] Use real ObjectManager stubs in unit tests

Prevent invocation of the constructor (which instantiates
an internal instance of the extbase container) and do not
mix usage of mocked and stubbed methods.

The mixture happened due to the usage of setMethods():
When specifing `setMethods(['get'])` all methods besides ->get()
are actually proxied to the real ObjectManager methods.

Releases: master, 9.5
Resolves: #87742
Change-Id: I817f8ee90d82f36b8117e873b5802e11f601384e
Reviewed-on: https://review.typo3.org/c/59757
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Mock ResourceFactory Singletons in unit tests 54/59754/4
Benjamin Franzke [Mon, 18 Feb 2019 13:54:49 +0000 (14:54 +0100)]
[TASK] Mock ResourceFactory Singletons in unit tests

This prevents indirect SignalSlotDispatcher and ObjectManager
invocation by stubbing the ResourceFactory (or removing unneeded
mocks by preventing constructor invocation as in ImageServiceTest).

Releases: master, 9.5
Resolves: #87739
Change-Id: I70c5413fbdf66f3deb8ae0113e62f17ad8168f19
Reviewed-on: https://review.typo3.org/c/59754
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Mock SignalSlot\Dispatcher Singletons in unit tests 56/59756/3
Benjamin Franzke [Mon, 18 Feb 2019 07:59:10 +0000 (08:59 +0100)]
[TASK] Mock SignalSlot\Dispatcher Singletons in unit tests

Prevent indirect ObjectManager invocation by mocking FileRepository.

Releases: master, 9.5
Resolves: #87741
Change-Id: I4a0c4f322f47223406a313f222f1f5b5e53c6ed7
Reviewed-on: https://review.typo3.org/c/59756
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Do not instantiate DocumentTemplate at every BE call 81/59781/3
Benni Mack [Thu, 21 Feb 2019 16:08:19 +0000 (17:08 +0100)]
[TASK] Do not instantiate DocumentTemplate at every BE call

Currently, document template and thus, pagerenderer is initialized
with all functionality and loaded CSS for every BE call,
which is unnecessary for simple JSON-based AJAX calls.

In order to avoid this, PageRenderer is now instantiated only
when needed - when ModuleTemplate or DocumentTemplate
are initialized, resulting in higher performance for AJAX calls
but also removing a necessary means for having DocumentTemplate
set up at all BE requests, reducing the need for DocTemplate
even more, so it can slowly be migrated to ModuleTemplate
in the future.

Resolves: #87766
Releases: master
Change-Id: Ic1549be7f4d62164bf99cb496fad4b96dee2bc7d
Reviewed-on: https://review.typo3.org/c/59781
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[!!!][TASK] Remove [SYS][recursiveDomainSearch] option 82/59782/3
Benni Mack [Thu, 21 Feb 2019 16:58:38 +0000 (17:58 +0100)]
[!!!][TASK] Remove [SYS][recursiveDomainSearch] option

The option related to sys_domain records and pseudo-sites
is removed due to the upcoming removal of Pseudo Sites.

Resolves: #87767
Releases: master
Change-Id: Ife933f86d9ce3d8049e2e74d856a6ec0df3e4e40
Reviewed-on: https://review.typo3.org/c/59782
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 weeks ago[TASK] Use PageRenderer directly in LoginController 80/59780/3
Benni Mack [Thu, 21 Feb 2019 15:53:08 +0000 (16:53 +0100)]
[TASK] Use PageRenderer directly in LoginController

In order to emphasize the PageRenderer API and get rid
of DocumentTemplate logic in further refactorings, the inline
CSS and JavaScript is added directly to the PageRenderer
instead of the document template, which contains its own
legacy-concatenation magic.

Resolves: #87765
Releases: master
Change-Id: Id5db83f34f3ab31b016198cb90a8c84126b43dd6
Reviewed-on: https://review.typo3.org/c/59780
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 months ago[TASK] Clean up Backend Controller 53/59753/2
Benni Mack [Tue, 19 Feb 2019 09:05:40 +0000 (10:05 +0100)]
[TASK] Clean up Backend Controller

The main backend controller has some pre v7 code built-in where
special handling of JavaScript includes and files could be extended
via hooks, which have been removed. This way, code within the Backend
Controller can be simplified, allowing for further work in this class.

Resolves: #87736
Releases: master
Change-Id: Ic777630cef51714197451077beebefd8e445936d
Reviewed-on: https://review.typo3.org/c/59753
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>