Packages/TYPO3.CMS.git
4 weeks ago[BUGFIX] Include DB queries with free mode records 59/58859/3
Benni Mack [Tue, 6 Nov 2018 15:24:06 +0000 (16:24 +0100)]
[BUGFIX] Include DB queries with free mode records

With the new site handling, the overlayType for fetching
records in the frontend context is always set to
OVERLAYS_ON_WITH_FLOATING, which resolves to
the previous TypoScript settings:
- config.sys_language_overlay = 1
- styles.content.get.select.includeRecordsWithoutDefaultTranslation = 1

However, the place where "includeRecordsWithoutDefaultTranslation"
is evaluated does not check for the actual
Language Aspect of the Context API, which makes
it impossible to fetch records without "l10n_parent"
= (free mode), except for setting this option
explicitly on each TypoScript "select." query.

The patch moves the functionality into a separate method,
which allows to better unit test all options.

Resolves: #86627
Releases: master
Change-Id: I3a9005dcf13ddd26962da0d2ed930929c3f3b288
Reviewed-on: https://review.typo3.org/58859
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Chris Müller <typo3@krue.ml>
Reviewed-by: Chris Müller <typo3@krue.ml>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 weeks ago[TASK] Remove fluid namespace in sitemap template 66/58866/3
Georg Ringer [Wed, 7 Nov 2018 13:59:13 +0000 (14:59 +0100)]
[TASK] Remove fluid namespace in sitemap template

There is no need to keep the fluid namespace definition in the template.

Resolves: #86873
Releases: master
Change-Id: I3f7a31a68aad5f67b37fd49b4098071c3c88cd4f
Reviewed-on: https://review.typo3.org/58866
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 weeks ago[BUGFIX] Add reports.html to acceptance tests 56/58856/3
Steffen Dietrich [Tue, 6 Nov 2018 11:45:10 +0000 (12:45 +0100)]
[BUGFIX] Add reports.html to acceptance tests

Add additional option to create reports.html upon
codeception runs on local execution of acceptance tests.

Resolves: #86867
Releases: master
Change-Id: I8f7fae03b430f51d47eb0285cc62171f7807c024
Reviewed-on: https://review.typo3.org/58856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[BUGFIX] Hide internal prefix "cat:" in tags of upgrade docs 47/58847/4
Georg Ringer [Mon, 5 Nov 2018 19:28:52 +0000 (20:28 +0100)]
[BUGFIX] Hide internal prefix "cat:" in tags of upgrade docs

The prefix "cat:" is used internally and it doesn't make sense to
show it to a regular user. Neither does it provide more output nor is
"cat" a regular word.

Resolves: #86858
Releases: master, 8.7
Change-Id: I8c48819814767c1ef4367c49da9ab3685081dceb
Reviewed-on: https://review.typo3.org/58847
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[BUGFIX] Use correct value for eventPid in DataHandler 57/58857/2
Benni Mack [Tue, 6 Nov 2018 13:51:44 +0000 (14:51 +0100)]
[BUGFIX] Use correct value for eventPid in DataHandler

When using workspaces and the record properties
should be shown, the wrong field (_ORIG_pid instead of
t3ver_oid) is used. This is introduced by
a cleanup patch of mine 1y ago, where an accidental
null coalescense evaluation is used.

Resolves: #86868
Related: #82769
Releases: master
Change-Id: I2505f103608350f37c6bf769de4368b62ed67d55
Reviewed-on: https://review.typo3.org/58857
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Tested-by: Achim Fritz <af@achimfritz.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[BUGFIX] Fix isMissing called on Null error 49/58849/7
Bernhard Sirlinger [Mon, 5 Nov 2018 21:12:40 +0000 (22:12 +0100)]
[BUGFIX] Fix isMissing called on Null error

Add a Null check in FileLinktype->checkLink
function

Resolves: #86857
Releases: master,8.7
Change-Id: I2cc270dd7b8392fa8fd240c6efca3894f0ce3273
Reviewed-on: https://review.typo3.org/58849
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[FEATURE] Improve creation of URL query strings from arrays 79/55079/40
Stefan Neufeind [Mon, 18 Dec 2017 18:46:47 +0000 (19:46 +0100)]
[FEATURE] Improve creation of URL query strings from arrays

Adds a new method HttpUtility::buildQueryString() using
http_build_query() instead of reimplementing the encoding-process like
the old method GeneralUtility::implodeArrayForUrl() did.

As the parameter $rawurlencodeParamName of implodeArrayForUrl() was set
to "false" by default and used in several places without manually
setting it to "true" using that method could lead to potentially unsafe
non-encoded parameter names.

Some unit-tests had wrong URLs with non-encoded braces [...], which were
adapted to be properly escaped as well.

Resolves: #83334
Releases: master
Change-Id: Ifbaad912f0d658671356dc7bdf1579dacff272df
Reviewed-on: https://review.typo3.org/55079
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[BUGFIX] Force word breaks in callouts 20/58820/6
Andreas Fernandez [Thu, 1 Nov 2018 20:10:52 +0000 (21:10 +0100)]
[BUGFIX] Force word breaks in callouts

The CSS of callouts is adjusted to enforce word breaks to prevent
overlapping the container.

Resolves: #86827
Releases: master
Change-Id: I91be87f22b3f3192f594f028575dfb9f36191b81
Reviewed-on: https://review.typo3.org/58820
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Tested-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[BUGFIX] Respect DateTimeImmutable in Extbase 88/57388/7
Benni Mack [Wed, 27 Jun 2018 05:44:03 +0000 (07:44 +0200)]
[BUGFIX] Respect DateTimeImmutable in Extbase

The DateTimeConverter and DataMapper of Extbase now checks for
DateTimeInterface, and can thus handle DateTimeImmutable, otherwise
Extbase cannot handle these kinds of formats.

Resolves: #72053
Releases: master
Change-Id: Ic922e715a31e1d02f5f6daa18415e8376788da8b
Reviewed-on: https://review.typo3.org/57388
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 weeks agoRevert "[BUGFIX] Set constraints in `FrontendRestrictionContainer` depending on works... 38/58838/2
Frank Naegler [Sat, 3 Nov 2018 14:51:33 +0000 (16:51 +0200)]
Revert "[BUGFIX] Set constraints in `FrontendRestrictionContainer` depending on workspace context"

This reverts commit c3e7779c61cc567b9a1cbf5fec747748e5059464.

Change-Id: Ic2d68767d463b94ab42814848396b8f019e8cb15
Releases: master
Resolves: #86845
Reverts: #85742
Reviewed-on: https://review.typo3.org/58838
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 weeks ago[TASK] Raise testing-framework and styleguide 17/58817/8
Christian Kuhn [Thu, 1 Nov 2018 13:36:54 +0000 (14:36 +0100)]
[TASK] Raise testing-framework and styleguide

Acceptance tests of testing-framework have been refactored
a bit to be easier usable by extensions. Core needs some
adaptions to cope with that. styleguide has been
slightly improved and is raised along the way.

composer require --dev typo3/testing-framework ~4.11.1
composer require --dev typo3/cms-styleguide ~9.2.2

Change-Id: Ifc5fbc1192618017e6cd5e80452463eafe527d79
Resolves: #86839
Releases: master
Reviewed-on: https://review.typo3.org/58817
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 weeks ago[BUGFIX] Show correct ReST file for @validate annotation 27/58827/5
Alexander Schnitzler [Fri, 2 Nov 2018 12:21:35 +0000 (13:21 +0100)]
[BUGFIX] Show correct ReST file for @validate annotation

The extension scanner didn't show the correct ReST file. Instead
of the file for @validate, it has shown the file for @inject.

Also, the file explaining the @validate annotation mentioned the
@inject annotation.

Releases: master
Resolves: #86840
Relates: #83617
Change-Id: I73f35a0fdf32b999b1b95754bd4366ece75f0ea6
Reviewed-on: https://review.typo3.org/58827
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[BUGFIX] Make `LoginRefresh.submitForm a lambda function 19/58819/2
Andreas Fernandez [Thu, 1 Nov 2018 19:39:14 +0000 (20:39 +0100)]
[BUGFIX] Make `LoginRefresh.submitForm a lambda function

The function `LoginRefresh.submitForm` is changed to be a lambda
function. Reason is that `this` is now bound to the class, previously it
was bound to the event target.

Resolves: #86822
Releases: master
Change-Id: Ie4c072ebfe2867966636eec99818cc1e5b0a0ab3
Reviewed-on: https://review.typo3.org/58819
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[BUGFIX] Keep existing validation errors for recursive domain relations 77/56677/6
Markus Klösges [Mon, 16 Apr 2018 08:43:24 +0000 (10:43 +0200)]
[BUGFIX] Keep existing validation errors for recursive domain relations

Do not overwrite already generated validation errors when a property
validator leads to a recursive validate() call to the currently
validated GenericObjectValidator.

Resolves: #84475
Releases: master, 8.7
Change-Id: Ifbdb28ddcf6a8e7f1517801ebcd6634149b2bd5d
Reviewed-on: https://review.typo3.org/56677
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[TASK] Changed label for page_tree_stop 28/58828/2
teilzeitphilosoph [Fri, 2 Nov 2018 13:46:48 +0000 (14:46 +0100)]
[TASK] Changed label for page_tree_stop

Clearified the message of the label of the field.
Added tooltip for a better explanation.

Resolves: #84580
Releases: master, 8.7
Change-Id: I13488115161a949193b2c5765b29407437f6b1ea
Reviewed-on: https://review.typo3.org/58828
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[BUGFIX] Set constraints in `FrontendRestrictionContainer` depending on workspace... 22/57822/8
Andreas Fernandez [Sun, 5 Aug 2018 16:12:31 +0000 (18:12 +0200)]
[BUGFIX] Set constraints in `FrontendRestrictionContainer` depending on workspace context

The `FrontendRestrictionContainer` must not respect the hidden flag, if
the request happens in a workspace context. The reason is that for
example pages that are created in a workspace have a hidden LIVE version,
which makes overlaying impossible.

This patch changes the behavior to act the same as
`PageRepository::enableFields()` does.

Resolves: #85742
Releases: master, 8.7
Change-Id: I5f1b12bcd8a63daf7eaa9bc9c065b96c343f6ab6
Reviewed-on: https://review.typo3.org/57822
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Tested-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 weeks ago[BUGFIX] Fix translated file relation with sql_mode=ONLY_FULL_GROUP_BY 13/58813/2
Mathias Brodala [Wed, 31 Oct 2018 16:34:11 +0000 (17:34 +0100)]
[BUGFIX] Fix translated file relation with sql_mode=ONLY_FULL_GROUP_BY

The SQL mode ONLY_FULL_GROUP_BY enforces all fields used in "GROUP BY"
to be present in "SELECT".

See https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_only_full_group_by

Resolves: #85159
Releases: master, 8.7
Change-Id: Iff7895dd9703557ca0b91613516bdb3391b4d4f6
Reviewed-on: https://review.typo3.org/58813
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 weeks ago[BUGFIX] Provide effectivePid for flexforms segment 97/58797/5
Patrick Lenk [Tue, 30 Oct 2018 11:20:36 +0000 (12:20 +0100)]
[BUGFIX] Provide effectivePid for flexforms segment

Custom ckeditor config is now loaded in flexforms.

Resolves: #83809
Related: #81748
Releases: master, 8.7
Change-Id: I9c0fe85d81f3e34209cd52afee18594e49020f54
Reviewed-on: https://review.typo3.org/58797
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 weeks ago[TASK] Allow type 'text' in site configuration 18/58818/4
Georg Ringer [Thu, 1 Nov 2018 19:31:38 +0000 (20:31 +0100)]
[TASK] Allow type 'text' in site configuration

As yaml supports multiline text, it should be also allowed inside the
site configuration.
With #86214 the type 'text' has been allowed within inline relations.

Resolves: #86825
Releases: master
Change-Id: I2f0172e061cd277e23cf44390930864c7481c98b
Reviewed-on: https://review.typo3.org/58818
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 weeks ago[TASK] Change cursor type hovering CE in language view 16/58816/2
Gianluigi Martino [Thu, 1 Nov 2018 11:41:31 +0000 (12:41 +0100)]
[TASK] Change cursor type hovering CE in language view

Change cursor type to "move" hovering content elements if you are in page
module and in language view. Same as in columns view in page module.

Resolves: #86820
Releases: master
Change-Id: Ib176fb4b415d8b9a64548c48aa0e9fc6f9077c26
Reviewed-on: https://review.typo3.org/58816
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 weeks ago[BUGFIX] Limit available languages in user setup module 21/58821/2
Georg Ringer [Thu, 1 Nov 2018 20:14:17 +0000 (21:14 +0100)]
[BUGFIX] Limit available languages in user setup module

Limit the available languages not only to the ones having a
translation but also if it is in the list of available languages
which are defined in the LocalConfiguration.php

Resolves: #86796
Releases: master
Change-Id: Ib08619cfaa7fcd2a829dad6bce932a29a450f21c
Reviewed-on: https://review.typo3.org/58821
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Add missing translation value for save_and_close in form engine 11/58811/2
Joerg Kummer [Wed, 31 Oct 2018 14:39:24 +0000 (15:39 +0100)]
[BUGFIX] Add missing translation value for save_and_close in form engine

Changes syntax for translation key and add default language value.

Resolves: #86799
Releases: master
Change-Id: Ic273fc845d1af9e9cda29c049239c4ff045de120
Reviewed-on: https://review.typo3.org/58811
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Preben Rather Sørensen <preben@rather.dk>
Tested-by: Preben Rather Sørensen <preben@rather.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[BUGFIX] Adding 3 to "TYPO" 10/58810/5
Jonathan I [Wed, 31 Oct 2018 14:30:31 +0000 (15:30 +0100)]
[BUGFIX] Adding 3 to "TYPO"

On other "TYPO3" references the "3" is present but not on this occurence.
Add the "3" to "TYPO" in order to have "TYPO3".

Releases: master, 8.7
Resolves: #86816
Change-Id: I21cfe6b10ca1757645c407014b3acbc41b7d7570
Reviewed-on: https://review.typo3.org/58810
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 weeks ago[TASK] Migrate FormEngineFlexForm to TypeScript 34/56234/6
Andreas Wolf [Fri, 16 Mar 2018 15:12:52 +0000 (16:12 +0100)]
[TASK] Migrate FormEngineFlexForm to TypeScript

Change-Id: I3151b16f72baf31e13f841ecc95be4ca389cf36e
Resolves: #82587
Releases: master
Reviewed-on: https://review.typo3.org/56234
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 weeks ago[TASK] Migrate FormEngineSuggest to TypeScript 20/56220/9
Andreas Fernandez [Fri, 16 Mar 2018 12:41:20 +0000 (13:41 +0100)]
[TASK] Migrate FormEngineSuggest to TypeScript

The FormEngineSuggest module is migrated to TypeScript now. In the same
step, the usage of jQuery is reduced and dead code has been removed.

Resolves: #82589
Releases: master
Change-Id: I87cf7aafdb68815c9406f5fa29661bf5af6acd85
Reviewed-on: https://review.typo3.org/56220
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 weeks ago[TASK] Migrate LayoutModule/Paste.js to TypeScript 80/56280/5
Andreas Wolf [Sat, 17 Mar 2018 10:00:43 +0000 (11:00 +0100)]
[TASK] Migrate LayoutModule/Paste.js to TypeScript

Change-Id: I1eb5996b08a6aaaac8ef5d179c2e509f68c15cb3
Resolves: #84169
Releases: master
Reviewed-on: https://review.typo3.org/56280
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 weeks ago[BUGFIX] Resolve strict type assertion in RecordStateFactory 07/58807/2
Oliver Hader [Wed, 31 Oct 2018 06:44:37 +0000 (07:44 +0100)]
[BUGFIX] Resolve strict type assertion in RecordStateFactory

Applying a strict "string" type to values that are "null" will
lead to type errors for TCA properties that are not configured
- most probably for "languageField", "transOrigPointerField"
or "translationSource".

see https://github.com/georgringer/news/issues/776

Resolves: #86809
Releases: master
Change-Id: I53e9a48f196b8a87c97620346474528a0cf3877e
Reviewed-on: https://review.typo3.org/58807
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 weeks ago[BUGFIX] Adjust FrontendUserImageUpdateWizard 95/58795/3
Alexander Grein [Tue, 30 Oct 2018 10:44:15 +0000 (11:44 +0100)]
[BUGFIX] Adjust FrontendUserImageUpdateWizard

Make "Mark undone" and the migration itself work again.

Resolves: #86751
Releases: master
Change-Id: I0f2455b36a4de5e202892c26745d91fdc828161a
Reviewed-on: https://review.typo3.org/58795
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Correct clickjacking header in backend 04/58804/8
Chris Müller [Tue, 30 Oct 2018 18:58:51 +0000 (19:58 +0100)]
[BUGFIX] Correct clickjacking header in backend

The clickjacking header in the backend was not correctly set
according to
https://developer.mozilla.org/de/docs/Web/HTTP/Headers/X-Frame-Options

Resolves: #86808
Releases: master
Change-Id: I42aa89950122fb3a875f075b5966c83d8b69f1d9
Reviewed-on: https://review.typo3.org/58804
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[BUGFIX] Execute scheduler tasks ordered by next execution time 90/58790/5
Sascha Egerer [Tue, 30 Oct 2018 09:52:04 +0000 (10:52 +0100)]
[BUGFIX] Execute scheduler tasks ordered by next execution time

When executing scheduler tasks the next execution time of the task
should be used to define the execution order.

Resolves: #86795
Releases: master, 8.7
Change-Id: Id678c74a60491aa3c8be8a33534b71ac37245217
Reviewed-on: https://review.typo3.org/58790
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Allow overlay for all root level records 17/57417/6
Mathias Brodala [Fri, 29 Jun 2018 09:24:32 +0000 (11:24 +0200)]
[BUGFIX] Allow overlay for all root level records

Instead of a hardcoded list of tables allowed on root level use
the information from TCA instead.

Resolves: #85429
Releases: master
Change-Id: I1a7d96b1912f63e6461c321d5dd5685b5df4c656
Reviewed-on: https://review.typo3.org/57417
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[TASK] Add PHP 7.3 to bamboo core master testing 03/58803/3
Christian Kuhn [Tue, 30 Oct 2018 17:55:05 +0000 (18:55 +0100)]
[TASK] Add PHP 7.3 to bamboo core master testing

Bamboo core master pre-merge now tests with PHP 7.3 rc3,
especially PHP linting and unit tests.
Bamboo core nightly extends the suite with further permutations
including PHP 7.3. Only functional testing with microsoft mssql
sqlsrv is missing, the php module is not yet released to PHP 7.3.

Resolves: #86806
Releases: master
Change-Id: I26379a1e9b592f5d4c078b296f873834b18c83d2
Reviewed-on: https://review.typo3.org/58803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Run functional tests without xdebug on bamboo 01/58801/2
Christian Kuhn [Tue, 30 Oct 2018 14:41:54 +0000 (15:41 +0100)]
[TASK] Run functional tests without xdebug on bamboo

With the increased number of functional tests in v9 we
should squeeze out as much performance as possible from
the tests so waiting for bamboo is not so annoying. Not
loading xdebug gives us roughly 10-30% for functionals.

Resolves: #86801
Releases: master, 8.7
Change-Id: Ic7b9dd4dd0c71799ecb7207fc0e7170f98729545
Reviewed-on: https://review.typo3.org/58801
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Show correct namespace in example block of CommaSeparatedValueProcessor 99/58799/2
Joerg Boesche [Tue, 30 Oct 2018 13:27:29 +0000 (14:27 +0100)]
[BUGFIX] Show correct namespace in example block of CommaSeparatedValueProcessor

Resolves: #86800
Releases: master, 9.5, 8.7
Change-Id: I243589ee7e619f26e99e27d34c626e848a1ee80a
Reviewed-on: https://review.typo3.org/58799
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 weeks ago[BUGFIX] Update karma 82/58782/4
Andreas Fernandez [Mon, 29 Oct 2018 18:52:25 +0000 (19:52 +0100)]
[BUGFIX] Update karma

karma is used for JavaScript based unit tests. The currently installed
version is aged and doesn't compile on newer systems anymore, thus the
package is updated to a recent version.

Used command:
yarn add karma@^3.1.0 --dev

Resolves: #86798
Releases: master, 8.7
Change-Id: I1cea78cf3759227a2cd09b8560f37121ae580202
Reviewed-on: https://review.typo3.org/58782
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 weeks ago[TASK] Test fully built css in bamboo 88/58788/5
Christian Kuhn [Tue, 30 Oct 2018 08:28:11 +0000 (09:28 +0100)]
[TASK] Test fully built css in bamboo

Extend the "Lint scss ts" bamboo job to also build css
next to js and only after that verify with git status
no file changed. This should prevent outdated css as
recently fixed with #86789.
Additionally switch from npm to direct grunt calls,
to be in sync with runTests.sh and to allow kicking
npm from the docker images entirely.

Change-Id: I5134d43c5f5d524005242eee59aa743b6e49219a
Resolves: #86794
Related: #86789
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58788
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 weeks ago[TASK] Set TYPO3 version to 9.5.2-dev 96/58796/2
Oliver Hader [Tue, 30 Oct 2018 10:46:34 +0000 (11:46 +0100)]
[TASK] Set TYPO3 version to 9.5.2-dev

Change-Id: If96e59eef0e6be1eac2e58e2d50cf79ba70d6b16
Reviewed-on: https://review.typo3.org/58796
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 weeks ago[RELEASE] Release of TYPO3 9.5.1 94/58794/2 v9.5.1
Oliver Hader [Tue, 30 Oct 2018 10:45:16 +0000 (11:45 +0100)]
[RELEASE] Release of TYPO3 9.5.1

Change-Id: Ic1c6183af103b9c957b85d046ff2564348f165bc
Reviewed-on: https://review.typo3.org/58794
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 weeks ago[TASK] Move FieldControl/ListModule handling to module 49/58649/5
Andreas Fernandez [Thu, 18 Oct 2018 13:27:42 +0000 (15:27 +0200)]
[TASK] Move FieldControl/ListModule handling to module

The FieldControl `ListModule` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86647
Releases: master
Change-Id: Ibf47ee8ebaea584f88ccb9615681bd579e4cd305
Reviewed-on: https://review.typo3.org/58649
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[TASK] Move FieldControl/InsertClipboard handling to module 24/58624/4
Andreas Fernandez [Sat, 13 Oct 2018 10:54:05 +0000 (12:54 +0200)]
[TASK] Move FieldControl/InsertClipboard handling to module

The FieldControl `InsertClipboard` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86646
Releases: master
Change-Id: I42ded87ab9152d92d07f3fe5b40b327d979aad4a
Reviewed-on: https://review.typo3.org/58624
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[TASK] Move FieldControl/TableWizard handling to module 50/58650/3
Andreas Fernandez [Thu, 18 Oct 2018 13:32:23 +0000 (15:32 +0200)]
[TASK] Move FieldControl/TableWizard handling to module

The FieldControl `TableWizard` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86649
Releases: master
Change-Id: I1cb71ad317f737afb0d943a4278583888737bcab
Reviewed-on: https://review.typo3.org/58650
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[TASK] Move FieldControl/AddRecord handling to module 48/58648/6
Andreas Fernandez [Thu, 18 Oct 2018 13:19:41 +0000 (15:19 +0200)]
[TASK] Move FieldControl/AddRecord handling to module

The FieldControl `AddRecord` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86642
Releases: master
Change-Id: I0d4e44719f38d4dd0e2355e3aeab6551e1725fb7
Reviewed-on: https://review.typo3.org/58648
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[TASK] Move FieldControl/ResetSelection handling to module 51/58651/9
Andreas Fernandez [Thu, 18 Oct 2018 14:07:19 +0000 (16:07 +0200)]
[TASK] Move FieldControl/ResetSelection handling to module

The FieldControl `ResetSelection` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Resolves: #86648
Releases: master
Change-Id: I478d5ae5567f38fb7cf75c30ab8ac7e2c021224e
Reviewed-on: https://review.typo3.org/58651
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] Unsplit split buttons in TableController 84/58784/2
Andreas Fernandez [Mon, 29 Oct 2018 21:26:39 +0000 (22:26 +0100)]
[BUGFIX] Unsplit split buttons in TableController

The controller of the table wizard doesn't use split buttons anymore.

Resolves: #86792
Releases: master
Change-Id: I1d4c1f0d2a6a47dc9d997148fa70f6ea82b058cc
Reviewed-on: https://review.typo3.org/58784
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] Re-build backend.css 83/58783/2
Andreas Fernandez [Mon, 29 Oct 2018 19:08:34 +0000 (20:08 +0100)]
[BUGFIX] Re-build backend.css

Since #86449, the backend.css is stale. This patch refreshes the build of
our CSS.

Used command:
grunt css

Resolves: #86789
Related: #86449
Releases: master
Change-Id: I5705c9680f3302a5b4ea6a0be013a49405979acb
Reviewed-on: https://review.typo3.org/58783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 weeks ago[TASK] Clean up PharStreamWrapperInterceptor 81/58781/2
Oliver Hader [Mon, 29 Oct 2018 18:01:22 +0000 (19:01 +0100)]
[TASK] Clean up PharStreamWrapperInterceptor

* fix spacing issue
* remove superfluous method

Resolves: #86788
Releases: master
Change-Id: I2825819663ef90cd8ba84578e3153faa62047f54
Reviewed-on: https://review.typo3.org/58781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 weeks ago[BUGFIX] Ignore unique evaluation in l10n_mode exclude 51/56151/9
Christoph Lehmann [Wed, 14 Mar 2018 22:17:53 +0000 (23:17 +0100)]
[BUGFIX] Ignore unique evaluation in l10n_mode exclude

The l10n_mode "exclude" explains to copy the field value from
source language, so unique evaluation should be ignored for
translated records.

Resolves: #84267
Resolves: #83572
Releases: master, 8.7
Change-Id: I6a086cb1fc447dda2cbcfe27f33ba9f3dd714f53
Reviewed-on: https://review.typo3.org/56151
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Render correct paging label 79/58779/4
Andreas Fernandez [Mon, 29 Oct 2018 13:58:40 +0000 (14:58 +0100)]
[BUGFIX] Render correct paging label

In case of paging in any record list, the page browser is rendered in top
and on bottom of ther record list.

The upper browser now renders the paging correctly by calculating the
offset of items of the previous page instead of hard-coding a "1".

Resolves: #86787
Releases: master, 8.7
Change-Id: Ib7c8856f248107ea9d17aeabe83a564189f69abf
Reviewed-on: https://review.typo3.org/58779
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Improve styling of upload form in extension manager 67/58467/4
Georg Ringer [Sat, 29 Sep 2018 17:50:57 +0000 (19:50 +0200)]
[TASK] Improve styling of upload form in extension manager

- Add missing id attribute
- Use bootstrap styling
- Use styled button

Resolves: #86449
Releases: master
Change-Id: I782226bc4326ecac4df1d3f8186b3d84d7e21fb7
Reviewed-on: https://review.typo3.org/58467
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Update typo3/testing-framework to 4.10.0 21/58621/6
Nicole Cordes [Fri, 12 Oct 2018 10:07:05 +0000 (12:07 +0200)]
[TASK] Update typo3/testing-framework to 4.10.0

Update from 4.9.0 to 4.10.0.
Notable change: The fluid RenderingContextFixture is
now provided by typo3/testing-framework, so core
namespace references can be adapted.

composer require --dev typo3/testing-framework ~4.10.0

Change-Id: Ifff354a2d418e09f08cf8818c3cd12ab87bf1ba8
Resolves: #86786
Releases: master
Reviewed-on: https://review.typo3.org/58621
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] Respect endOfRange in pagination 50/57650/4
Guido Schmechel [Sat, 21 Jul 2018 12:55:14 +0000 (14:55 +0200)]
[BUGFIX] Respect endOfRange in pagination

If prepareObjectsSlice is called in the pagination with a QueryResult,
the endOfRange is calculated and used for each page.

This ensures that the maximum limit is not exceeded.

Resolves: #85585
Releases: master
Change-Id: I13f2ce910cbb4102782aafffca0ff7d193620735
Reviewed-on: https://review.typo3.org/57650
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Disable caching if fluid debugging is enabled 46/58646/7
Georg Ringer [Thu, 18 Oct 2018 07:42:48 +0000 (09:42 +0200)]
[BUGFIX] Disable caching if fluid debugging is enabled

Resolves: #86675
Releases: master
Change-Id: Ife47f1fe8c78899785fbad73e21e2a2bf9b8441a
Reviewed-on: https://review.typo3.org/58646
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser 96/58096/5
Frans Saris [Fri, 31 Aug 2018 08:21:13 +0000 (10:21 +0200)]
[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser

The fileBrowser now passes the related pid, table and field to
getDefaultUploadFolder().

Resolves: #86053
Releases: master, 8.7
Change-Id: I954753ee84b4107b37ba45cbd08917f4c4be17d9
Reviewed-on: https://review.typo3.org/58096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Always use default language for uniqueInSite 22/58722/5
Benni Mack [Fri, 26 Oct 2018 16:55:33 +0000 (18:55 +0200)]
[BUGFIX] Always use default language for uniqueInSite

SlugHelper fetches records of the same language, and takes the
pageId of the _current_ language record (uid), which is wrong.
For records, it must be 'pid', for pages it must be 'uid', but for
translated pages it must be 'pages.l10n_parent'.

Resolves: #86625
Releases: master
Change-Id: I7af6f0438f5a90169505069c557792d4e7b08b7c
Reviewed-on: https://review.typo3.org/58722
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Added default cropping ratio for social media images 74/58774/3
Richard Haeser [Mon, 29 Oct 2018 08:38:41 +0000 (09:38 +0100)]
[TASK] Added default cropping ratio for social media images

Most of the social networks use the 1.91:1 aspect ratio for images that
belong to the page that is shared.

Now og:image and twitter:image will be rendering an image with a 1.91:1
ratio by default.

Resolves: #86419
Releases: master
Change-Id: Icd3588363f64659f66ba25d4f44a57afff5c1fe1
Reviewed-on: https://review.typo3.org/58774
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Update TypoScript include 84/58184/3
Nick [Tue, 4 Sep 2018 12:52:52 +0000 (14:52 +0200)]
[TASK] Update TypoScript include

TypoScript include method with ext_typoscript_setup.txt should be removed,
this file is deprecated since July 2005.

Releases: master
Resolves: #86143
Change-Id: If30c52159a4e9242ed5645eebc45cd524c8c55ad
Reviewed-on: https://review.typo3.org/58184
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[TASK] Ensure UTF-8 files contain no BOM 62/58762/6
Christian Kuhn [Sun, 28 Oct 2018 13:29:33 +0000 (14:29 +0100)]
[TASK] Ensure UTF-8 files contain no BOM

Extends bamboo to verify UTF-8 files contain no BOM and
adds Build/Scripts/runTests.sh -s checkBom to do the same
locally.

Resolves: #86781
Releases: master
Change-Id: I97f994f0fe4db427563197925018f412d9ada626
Reviewed-on: https://review.typo3.org/58762
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] Move SCSS instructions from modal to install.scss 71/58771/3
Benni Mack [Sun, 28 Oct 2018 14:53:47 +0000 (15:53 +0100)]
[BUGFIX] Move SCSS instructions from modal to install.scss

This change accidentally merged the code into the wrong file.

Resolves: #86783
Related: #86562
Releases: master
Change-Id: Ibdcd74bac852cc48a5911a086c709c73562d55c6
Reviewed-on: https://review.typo3.org/58771
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 weeks ago[BUGFIX] Update local cache upon creation of new storage object 58/56058/5
Bernhard Kraft [Thu, 8 Mar 2018 12:39:36 +0000 (13:39 +0100)]
[BUGFIX] Update local cache upon creation of new storage object

When a new storage object for the "local" driver is being created
it is not possible to retrieve the new object instantaneous. The
objects are being cached in a local static variable which needs
to get flushed (set to "null") first.

Resolves: #86689
Resolves: #62273
Releases: master
Change-Id: Ib5a0d6b148ef7b503c26ccd1610519707a8fa86d
Reviewed-on: https://review.typo3.org/56058
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[BUGFIX] Keep MP parameters upon redirect of overlay 29/52829/10
Elmar Hinz [Wed, 17 May 2017 15:46:55 +0000 (17:46 +0200)]
[BUGFIX] Keep MP parameters upon redirect of overlay

When a mount point, that is overlayed, redirects to the overlaying page,
don't throw away existing mount point parameters. The other mount point
parameters may specify a mount point upwards in the root line.

Under normal circumstances the page should not be linked at all. However
a redirect is provided and as it is provided it should work as expected.

Releases: master
Resolves: #81251
Change-Id: I4cf830e5b24ebc9799e58f83d7787a726f92a3d4
Reviewed-on: https://review.typo3.org/52829
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Allow unicode characters in verifyFileNameAgainstDenyPattern 89/57389/6
Pascal Rinker [Mon, 25 Jun 2018 14:43:32 +0000 (16:43 +0200)]
[BUGFIX] Allow unicode characters in verifyFileNameAgainstDenyPattern

Using (valid) unicode characters in
GeneralUtility::verifyFilenameAgainstDenyPattern was not possible due
to a missing unicode modifier when evaluating regular expressions.
The unicode modifier has been added.
Since unicode errors in regular expressions will lead to `false`
results, it is important to perform type-safe checks against `0`.

Resolves: #67061
Releases: master, 8.7
Change-Id: If3eea7129c92b296b85b93a1f1c81a446a2f5f90
Reviewed-on: https://review.typo3.org/57389
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Add missing copy and cut button in file list search result 26/58426/11
Gianluigi Martino [Fri, 28 Sep 2018 06:54:40 +0000 (08:54 +0200)]
[BUGFIX] Add missing copy and cut button in file list search result

It is now possible to copy or cut the file in file list search result.

Resolves: #86414
Releases: master
Change-Id: I60ca052d36efaa45cc348f712b05cac3127cc120
Reviewed-on: https://review.typo3.org/58426
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Redirect site to language after site resolving 14/58614/9
Georg Ringer [Thu, 11 Oct 2018 10:01:59 +0000 (12:01 +0200)]
[BUGFIX] Redirect site to language after site resolving

In order to allow custom redirects not depending on the site language
base, the redirect functionality is extracted into a separte middleware.

This allows to also exchange the base redirects with
a custom middleware when GeoIP / UserAgent based language
detection is necessary.

Resolves: #86615
Releases: master
Change-Id: I93e3452dfb55aa2d45b4c6d464944bf5a5d7fbe9
Reviewed-on: https://review.typo3.org/58614
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Avoid PHP warnings in BackendUtility if no BE user is set 52/58752/5
Anja [Sun, 28 Oct 2018 10:44:55 +0000 (11:44 +0100)]
[BUGFIX] Avoid PHP warnings in BackendUtility if no BE user is set

BackendUtility no longer tries to resolve the workspace property
of a not set BackendUserAuthentication. This prevents warnings from
being thrown.

Change-Id: I30d739273a0107e70987beadd3649d8b6bb67f60
Resolves: #86617
Releases: master
Reviewed-on: https://review.typo3.org/58752
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Pass FlexForm context to USER display condition 13/58413/5
Nicole Cordes [Thu, 27 Sep 2018 14:23:21 +0000 (16:23 +0200)]
[BUGFIX] Pass FlexForm context to USER display condition

If using a user display condition within a FlexForm field,
the passed information is insufficient and information about the
parsed FlexForm is missing.

Resolves: #86403
Releases: master, 8.7
Change-Id: I9917b3f98f7d7eb4fa3370e1cd2e9a9cd0eef627
Reviewed-on: https://review.typo3.org/58413
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Add test for (wrong) unique eval handling in pages:alias 22/57322/4
Andreas Wolf [Fri, 22 Jun 2018 22:13:48 +0000 (00:13 +0200)]
[TASK] Add test for (wrong) unique eval handling in pages:alias

Change-Id: Ie47dbc9153d8a4dcbde15a7eb61c207bbcc34480
Resolves: #86780
Related: #84267
Related: #83572
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57322
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Registration of multiple additional view models 06/58106/3
Ralf Zimmermann [Fri, 31 Aug 2018 17:17:22 +0000 (19:17 +0200)]
[BUGFIX] Registration of multiple additional view models

The form setup properties within "additionalViewModelModules" must be
written as numerical associative arrays to make it possible that
multiple extensions can extend the form editor with javascript modules.

Resolves: #85710
Releases: master, 8.7
Change-Id: Iaddf1bfd6f4df8d0c01e0c18be9cef458d8d2caf
Reviewed-on: https://review.typo3.org/58106
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Correctly resolve parameter for USER display condition 12/58412/4
Nicole Cordes [Thu, 27 Sep 2018 13:56:11 +0000 (15:56 +0200)]
[BUGFIX] Correctly resolve parameter for USER display condition

According to the documentation there is no limit of the used
additional parameters. However during parameter processing, there
is a limit of 4 parameters applied. This limit needs to be unset
when dealing with a USER display condition.

Resolves: #85274
Releases: master, 8.7
Change-Id: Ieff6d089cbb5540ab1d3b389eb0511ef993b900d
Reviewed-on: https://review.typo3.org/58412
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Improve performance of UriBuilder by memory cache 27/53827/10
Claus Due [Tue, 29 Aug 2017 17:07:31 +0000 (19:07 +0200)]
[TASK] Improve performance of UriBuilder by memory cache

The TYPO3 backend is eager to generate the same URL
with the same parameters multiple times, causing a lot
of cascading calls to URI parsing, token generation etc.

Turning the UriBuilder into a Singleton removes many
hundreds of calls to instantiate the object - and remembering
the URLs that were generated further saves many hundred
calls to UriBuilder->buildUri in for example the page module.

Change-Id: I7444ccf8bb27789c489f7d7c15c65449fa3456a0
Resolves: #82237
Releases: master
Reviewed-on: https://review.typo3.org/53827
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Check for Extbase response type instead of environment 00/58200/3
Daniel Siepmann [Thu, 6 Sep 2018 12:36:16 +0000 (14:36 +0200)]
[TASK] Check for Extbase response type instead of environment

Functional tests always set CLI context to true. Even if Extbase returns
an Web\Response, the method getExitCode will be called, which only
exists in Cli\Response.

Therefore a check against the response type allows to run functional
tests with Web\Response in Extbase.

Resolves: #86170
Releases: master
Change-Id: I5982d77aad82f92b6e6bb13cca5118ea2a3e7796
Reviewed-on: https://review.typo3.org/58200
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 weeks ago[BUGFIX] BE checkFullLanguagesAccess check all translated records 59/58759/2
Ursula Klinger [Sun, 28 Oct 2018 12:26:27 +0000 (13:26 +0100)]
[BUGFIX] BE checkFullLanguagesAccess check all translated records

All translated records are checked for language access in the method
checkFullLanguagesAccess of BackendUserAuthentication

Resolves: #86778
Releases: master, 8.7
Change-Id: I9c0101507c741471a8537a92329a9a66b78fa559
Reviewed-on: https://review.typo3.org/58759
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Use different placeholder than ### 86/58586/3
Stefan Neufeind [Sat, 6 Oct 2018 16:34:08 +0000 (18:34 +0200)]
[TASK] Use different placeholder than ###

preg_quote since PHP 7.3.0 also quotes #.
Simply use a different placeholder.

Resolves: #86586
Releases: master, 8.7, 7.6
Change-Id: I8ed9bd39605341a09347e21dd38c9a1824a01ee5
Reviewed-on: https://review.typo3.org/58586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Remove canonical link if noindex 00/58600/6
Gianluigi Martino [Tue, 9 Oct 2018 11:37:19 +0000 (13:37 +0200)]
[TASK] Remove canonical link if noindex

Some frontend and backend optimizations for canonical links

- Change position of canonical link input field in backend
- Hide canonical link input if in backend "no_index" toggle is inactive
- Reload page by changing "no_index" toggle in backend

Resolves: #86515
Releases: master
Change-Id: I70dd8e36ada7c1a4c9b5aec7f69866eae0592945
Reviewed-on: https://review.typo3.org/58600
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Add unit tests for BackendUtiily::resolveFileReferences 58/58758/4
Anja [Sun, 28 Oct 2018 12:28:45 +0000 (13:28 +0100)]
[TASK] Add unit tests for BackendUtiily::resolveFileReferences

This tests are a left over from a patch being abandoned.
Keeping them should not be wrong, they help identify notices
thrown, if nothing else.

Change-Id: If88d0f60f8b5bef9ce34b628b5fb46b86d2ae36f
Resolves: #86779
Releases: master
Reviewed-on: https://review.typo3.org/58758
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Fix continue-statement inside a switch-block 93/58593/2
Stefan Neufeind [Sun, 7 Oct 2018 23:37:18 +0000 (01:37 +0200)]
[TASK] Fix continue-statement inside a switch-block

Calling continue inside a switch-block would work just like break.
This is usually not intended and thus triggers a warning since
PHP 7.3.0.

Resolves: #86589
Releases: master, 8.7, 7.6
Change-Id: Ic35998b8a37bd35110b9d3494f1cf258e845097a
Reviewed-on: https://review.typo3.org/58593
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Keep update button in linkbrowser for RTE CKEditor on edit 37/58737/3
Joerg Kummer [Sat, 27 Oct 2018 18:21:42 +0000 (20:21 +0200)]
[BUGFIX] Keep update button in linkbrowser for RTE CKEditor on edit

This patch moves the current value of the link into the parameter array
for the linkbrowser to keep the value in all linked actions inside the
linkbrowser for the RTE CKEditor.

This keeps the update button in the page linkhandler,
if an existing page link will be edited.

Resolves: #83545
Releases: master, 8.7
Change-Id: Ia9217057e45a5d94668bb5ac2f111198da9a69d1
Reviewed-on: https://review.typo3.org/58737
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Cleanup generation of sitemap-index-URLs 48/58548/3
Stefan Neufeind [Mon, 1 Oct 2018 21:34:07 +0000 (23:34 +0200)]
[TASK] Cleanup generation of sitemap-index-URLs

Use pageType-parameter from f:uri.page instead of providing
the type through additionalParams.
And don't include the page-parameter unless we are on another page
than the first one (page=0). Many DataProviders might only use one
page anyway.

Resolves: #86531
Releases: master
Change-Id: Id6f7ac8f53d03802e904ee0c946c8d0c02ee61f9
Reviewed-on: https://review.typo3.org/58548
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver 07/57207/4
Nicole Cordes [Wed, 13 Jun 2018 10:08:15 +0000 (12:08 +0200)]
[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver

This patch ensures that
AbstractHierarchicalFilesystemDriver::getParentFolderIdentifierOfIdentifier
always returns a file identifier using forward slashes. Furthermore
it removes double forward slashes for a root folder identifier.

Resolves: #85249
Releases: master, 8.7
Change-Id: I562eaade7353e5235d4f65725a4159f6c0b71d75
Reviewed-on: https://review.typo3.org/57207
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Process large list of hashes in chunks updating reference index 46/57846/4
Gleb Levitin [Thu, 9 Aug 2018 15:14:25 +0000 (17:14 +0200)]
[BUGFIX] Process large list of hashes in chunks updating reference index

The list of old hashes by cleaning up the reference index can
be very long. To avoid exceeding query limits like maximum number
of placeholder per query or the max allowed statement length these
large lists are split into chunks of safe length before processing.

Resolves: #85795
Releases: master, 8.7
Change-Id: Iaebc555fe791f9e41f336bcd30d5b6eb149ad4e9
Reviewed-on: https://review.typo3.org/57846
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Edit a translated record without def. language access 38/58738/3
Ursula Klinger [Sat, 27 Oct 2018 18:44:25 +0000 (20:44 +0200)]
[BUGFIX] Edit a translated record without def. language access

Editor without access to default language could not edit a translated
content element, because there was an entry in available languages
for index 0 with null

Resolves: #86771
Releases: master
Change-Id: I608791a6df9b26f420fb233d47f38fe7685931c8
Reviewed-on: https://review.typo3.org/58738
Reviewed-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASk] Fully qualified classes was expecting bool 84/58584/2
Tomas Norre Mikkelsen [Fri, 5 Oct 2018 16:30:40 +0000 (18:30 +0200)]
[TASk] Fully qualified classes was expecting bool

Releases: master
Resolves: #86582
Change-Id: Ie4a5578c632ff99898c97f5bd3a4e80f87260194
Reviewed-on: https://review.typo3.org/58584
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Set correct language uids in MenuProcessor when set to auto 76/58576/3
Nikita Hovratov [Thu, 4 Oct 2018 14:45:14 +0000 (16:45 +0200)]
[BUGFIX] Set correct language uids in MenuProcessor when set to auto

The configuration special.auto was introduced in #84775. The function
MenuProcessor->prepareLevelLanguageConfiguration() was not aware of that
and set the value for the languageUids to "auto".

Resolves: #86571
Releases: master
Change-Id: I6e6aedd351077b7e1ac49ed5bd7facab48590014
Reviewed-on: https://review.typo3.org/58576
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Catch Exceptions in RTE with invalid links 46/58746/2
Benni Mack [Sat, 27 Oct 2018 21:35:40 +0000 (23:35 +0200)]
[BUGFIX] Catch Exceptions in RTE with invalid links

Only one area is covered with catching invalid links when setting
an ugly external URL without proper scheme.

The other area is caught now too.

Resolves: #84009
Releases: master, 8.7
Change-Id: Ief7549009b114803daacf39e36528523718a0d36
Reviewed-on: https://review.typo3.org/58746
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[TASK] Allow runTests.sh on Windows WSL 50/58750/3
Susanne Moog [Sun, 28 Oct 2018 10:15:26 +0000 (11:15 +0100)]
[TASK] Allow runTests.sh on Windows WSL

Pre-Requisites:
- docker for windows installed
- Base mount path for Windows drives is / (not /mnt/)
- docker for windows exposes daemon via tcp
- DOCKER_HOST set to tcp://localhost:2375
- ./Build/Scripts/runTests.sh has Linux line endings

Running:
- same as on Linux: on WSL go to /path/to/your/checkout
- run: ./Build/Scripts/runTests.sh

Resolves: #86777
Releases: master
Change-Id: Ia66ab92bc9f7711584b93cc321abdb076be4c2ab
Reviewed-on: https://review.typo3.org/58750
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[!!!][TASK] Remove X-UA-Compatible from HTML of backend 44/58744/2
Susanne Moog [Sat, 27 Oct 2018 21:02:30 +0000 (23:02 +0200)]
[!!!][TASK] Remove X-UA-Compatible from HTML of backend

Resolves: #76166
Releases: master
Change-Id: I5d36ea2342c18fe08cb5b5c06f123e8cb575849c
Reviewed-on: https://review.typo3.org/58744
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Nicolai Schirawski <ns@t3magic.de>
Tested-by: Nicolai Schirawski <ns@t3magic.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[TASK] No UTF-8 with BOM files 51/58751/2
Christian Kuhn [Sun, 28 Oct 2018 09:29:54 +0000 (10:29 +0100)]
[TASK] No UTF-8 with BOM files

Some files contain not needed BOM bytes in UTF-8 files.
Remove them since they can lead to not too funny headaches
in some details.

Resolves: #86776
Releases: master
Change-Id: I1b0dfb34966024e39c35863312dd2775a5024dc7
Reviewed-on: https://review.typo3.org/58751
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Felix Althaus <felix.althaus@undkonsorten.com>
Tested-by: Felix Althaus <felix.althaus@undkonsorten.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] Adjust headline decoration in documentation file 48/58748/2
Anja [Sun, 28 Oct 2018 09:36:54 +0000 (10:36 +0100)]
[BUGFIX] Adjust headline decoration in documentation file

Change-Id: Ic30290ba8548049b2c053d1e3bfa4beae1615e24
Resolves: #86775
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58748
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[TASK] Have LF line endings for .sh scripts in .gitattributes 47/58747/3
Christian Kuhn [Sun, 28 Oct 2018 09:26:04 +0000 (10:26 +0100)]
[TASK] Have LF line endings for .sh scripts in .gitattributes

Resolves: #86774
Releases: master, 8.7
Change-Id: I8b677426c6011a0b3115f83380ae567582dc9c17
Reviewed-on: https://review.typo3.org/58747
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] Decouple GeneralUtility::rmdir from Environment::isWindows() 31/58631/2
Nicole Cordes [Sun, 14 Oct 2018 19:12:42 +0000 (21:12 +0200)]
[BUGFIX] Decouple GeneralUtility::rmdir from Environment::isWindows()

To be able to call rmdir without an initialized Environment instance,
the check if a Windows system is used, is decoupled. This allows to
call GeneralUtility::rmdir e.g. in typo3/testing-framework.

Resolves: #86655
Releases: master
Change-Id: Ica1feafbd9a07005c4b653ef2fe1153fba4b9417
Reviewed-on: https://review.typo3.org/58631
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Allow more tags when no RTE processing is available 45/58745/2
Benni Mack [Sat, 27 Oct 2018 21:28:41 +0000 (23:28 +0200)]
[BUGFIX] Allow more tags when no RTE processing is available

If somebody has no RTE extension available, there is also no
RTE processing information available, so the default
from RteHtmlParser is used. However, tags like <abbr>
are then not provided by the yaml configuration, so they are
not allowed, and thus - escaped.

The patch adds abbr,acronym and dfn to be allowed all the time.

Resolves: #83424
Releases: master, 8.7
Change-Id: Ifdc0e7f155bef95a7c397584f2cf7b1eab61f6bb
Reviewed-on: https://review.typo3.org/58745
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Add margin-bottom for tab-content 72/58572/5
Nikita Hovratov [Wed, 3 Oct 2018 19:06:44 +0000 (21:06 +0200)]
[BUGFIX] Add margin-bottom for tab-content

This adds a margin between the tab-content and the submit-button in the
extension configuration form.

Resolves: #86562
Releases: master
Change-Id: Ifdbf30af3cb92162c876c49b46d32776b654991e
Reviewed-on: https://review.typo3.org/58572
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Do not require */ext to be writable in Composer Mode 72/57772/3
Łukasz Uznański [Sat, 31 Mar 2018 23:33:34 +0000 (01:33 +0200)]
[BUGFIX] Do not require */ext to be writable in Composer Mode

Resolves: #81857
Releases: master
Change-Id: I2dc07e8ac23edad2c7bd4880c4fd12ebcf2e40d6
Reviewed-on: https://review.typo3.org/57772
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Resolve correct page in slug validation 29/58229/8
Oliver Hader [Sat, 8 Sep 2018 12:54:45 +0000 (14:54 +0200)]
[BUGFIX] Resolve correct page in slug validation

The SlugHelper now receives an encapsulated RecordState object that
represents a record.

This allows fine-grained control over a record and helps resolving
related information, which is required to resolve slugs properly in a
case where e.g. the node ("parent") and language uid can occur multiple
times.

The RecordState contains:

- an EntityContext which describes a variant of a record by its language
  and workspace assignment

- a node object (EntityPointer) that points to the node (aka "parent") of
  the record

- a EntityUidPointer that describes the origin of the record by its table
  name and uid

The RecordStateFactory creates such RecordState objects and enriches them
with links (EntityPointerLink) that point to languages and versions, that
are also represented by EntityPointer implementations.

Resolves: #86195
Releases: master
Change-Id: If17a30e98f802825d80e95044572153f2426bea2
Reviewed-on: https://review.typo3.org/58229
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 weeks ago[TASK] Move page fields to new tab 'social media' 18/58718/3
Jasmina Ließmann [Fri, 26 Oct 2018 15:03:22 +0000 (17:03 +0200)]
[TASK] Move page fields to new tab 'social media'

Move fields for open graph and twitter card to a new tab 'social media'

Resolves: #86514
Releases: master
Change-Id: I293f250b57f6bba3c696e77550584912db3491eb
Reviewed-on: https://review.typo3.org/58718
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Update typo3/cms-composer-installers to 2.2.1 42/58742/2
Christian Kuhn [Sat, 27 Oct 2018 20:03:20 +0000 (22:03 +0200)]
[TASK] Update typo3/cms-composer-installers to 2.2.1

Upgrade from 2.2.0 to 2.2.1 which allows PHP 7.3
in this dependency.

composer update typo3/cms-composer-installers

Resolves: #86772
Releases: master
Change-Id: I04ca2bd7af007321de7ea0d010b073e113e4cb61
Reviewed-on: https://review.typo3.org/58742
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] Detect recursions in PageContentErrorHandler 15/58615/3
Simon Praetorius [Thu, 11 Oct 2018 12:43:09 +0000 (14:43 +0200)]
[BUGFIX] Detect recursions in PageContentErrorHandler

Possible recursions that can occur while fetching the content of an error page are now detected and resolved.

Resolves: #86626
Releases: master
Change-Id: I72ca04bd57ac400e14a06231218cee903c713675
Reviewed-on: https://review.typo3.org/58615
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[BUGFIX] Show original error in ReflectionService exception 30/58730/7
Susanne Moog [Sat, 27 Oct 2018 10:58:50 +0000 (12:58 +0200)]
[BUGFIX] Show original error in ReflectionService exception

Instead of displaying a custom error message, let the original
exception message be part of the ReflectionException to differentiate
if the original class or any of the type hints has a problem.

Resolves: #86742
Releases: master, 8.7
Change-Id: I215ce779812b43f8bca5e6dfd2052461686482a7
Reviewed-on: https://review.typo3.org/58730
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 weeks ago[BUGFIX] In BE: MetaTags are not cached by page rendering 34/58734/3
Ursula Klinger [Sat, 27 Oct 2018 13:49:39 +0000 (15:49 +0200)]
[BUGFIX] In BE: MetaTags are not cached by page rendering

Calling the redirect module in the BE, the page renderer is called
without a specified $GLOBALS['TSFE']->page['uid']. So the meta tags
could not be cached.

Resolves: #86769
Releases: master
Change-Id: I39c099c7c0d13dda0c7098a2f798671b6d7b3f5b
Reviewed-on: https://review.typo3.org/58734
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 weeks ago[TASK] Add more doktypes to be excluded from XML sitemap by default 15/58715/5
Richard Haeser [Fri, 26 Oct 2018 14:06:31 +0000 (16:06 +0200)]
[TASK] Add more doktypes to be excluded from XML sitemap by default

Shortcuts and backend user sections should be removed from the XML
sitemap because a search engine should not index those pages
by default.

An integrator can always override this setting.

Resolves: #86690
Releases: master
Change-Id: I1b6c2299dc01d315c0aefe2205436037f045dc8c
Reviewed-on: https://review.typo3.org/58715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jürgen Heym <juergen.heym@hof-university.de>
Tested-by: Jürgen Heym <juergen.heym@hof-university.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 weeks ago[BUGFIX] Also process array in InputSlugElement 00/58700/6
Daniel Goerz [Thu, 25 Oct 2018 14:07:15 +0000 (16:07 +0200)]
[BUGFIX] Also process array in InputSlugElement

It is possible that the incoming $row contains an array
at the $languageField. This patch assures that the
$languageId can always be determined.

Resolves: #86734
Resolves: #86554
Relates: #86754
Releases: master
Change-Id: Ia2c8621cd935788f33a9b625ec0226a22e21b123
Reviewed-on: https://review.typo3.org/58700
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>