git.typo3.org Git - Packages/TYPO3.CMS.git/log

[BUGFIX] Remove PHP warnings in request

Fixes PHP warnings if the controllerObjectName is not a valid class.

Change-Id: I0edc3cfb30593adac97740afe0443efc1a88faed
Fixes: #27862
Releases: 6.0
Reviewed-on: http://review.typo3.org/14811
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Mueller
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[TASK] Make all classes non final

Defining a class as final does not help and only causes troubles,
especially when creating unit tests, because a final classes
cannot be mocked.

Remove the final statement for all classes to get rid of
these problems.

Change-Id: Icbf574dacd5c3b2bf1de2333a065b0eac838ea98
Resolves: #41235
Releases: 6.0
Reviewed-on: http://review.typo3.org/14905
Reviewed-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

[BUGFIX] Fix Exception Class Name

During renaming of classes one exception class name has been forgotten.
Rename Exception\InvalidSource to Exception\InvalidSourceException

Change-Id: Ia357c25f2489ffff9fb2023d4997a2aabcc3d501
Resolves: #41210
Releases: 6.0
Reviewed-on: http://review.typo3.org/14874
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

[TASK] Fix class naming and alias map after namespace change

Change-Id: I3e0f6d9aa0e5d8680213e3afe6db58d773b54c0d
Resolves: #41131
Releases: 6.0
Reviewed-on: http://review.typo3.org/14843
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Fix translation fallback

If the target for the translation does not exist, we have to
fallback to the default language, which is guaranteed to have
a target.

Change-Id: I7c4055999df1211a5f88bf3eeadc98af568372ea
Fixes: #36905
Fixes: #39569
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/13039
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[TASK] Remove superfluous parenthesis in sysexts

Superfluous brackets in extbase after namespaces move

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I0c72e4b899db7c87b2513f8546012bbb815a7220
Resolves: #41015
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14677
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

[TASK] Adopt Extbase to the Autoloader -> ClassLoader name change

Change-Id: If464fbdacbd278d77a1e03a7df395d5a771642ea
Resolves: #40830
Related: #40095
Depends: I87da4bb2ef0420a94d1d155edde500c1aa96894a
Reviewed-on: http://review.typo3.org/14523
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

[BUGFIX] Broken backups in BackendConfigurationManagerTest

BackendConfigurationManagerTest fiddles with several $GLOBALS but
incompletly resets to previous state in tearDown(). This has side
effects to tests executed afterwards and is fixed with the patch.

Change-Id: Id3093494fc3b08b997eddc86590d85ee3f9588c9
Resolves: #40793
Releases: 6.0
Reviewed-on: http://review.typo3.org/14497
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Incomplete mocking and backups it tests

Fix two systematical warnings raised by running the unit tests:

* The DataMapperTest mocks Persistence\Generic\Mapper\DataMap which
raises warnings that the mocked class expects two constructor arguments
that are not given. The mocks are adapted to not call the constructor.

* Incomplete backups in ExtensionUtilityTest destroys
$GLOBALS['TYPO3_DB'] database handle. Fixed by using the usual
$backupGlobals and blackList code from other tests.

Change-Id: I14a22bb2e65ff2f751466e63d280d5fdf5f9be17
Resolves: #40768
Releases: 6.0
Reviewed-on: http://review.typo3.org/14474
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Declare LocalizationUtility::translateFileReference static

protected translateFileReference() is not declared static, like the
rest of the class methods. This leads to strict errors.

Change-Id: I63396e69f4bb3d36c7784c1a884dea003c89ecc4
Fixes: #40377
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/14186
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] TypeHandlingService throws Exception for StorageObjects

On using the old ObjectStorage class the TypehandlingService throws an
exception. This patch adds old class name to type handling again.

Change-Id: Iad841c1ba19ce8b701c549e1b2dcaca86f33a748
Fixes: #40290
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14147
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] fix Mvc/Request builds old classnames

This bugfix builds the classname after the new namespaced schema
@vendor\@extension\@subpackage\@controller
The vendor is default set to TYPO3\CMS by now.

Change-Id: Ie834fb64ee591f7779bd587982349de96e177162
Fixes: #40243
Relates: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14145
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Fix old propertymapper checking target with namespace

The propertymapper checks if the target is an object by checking on
is_string and an '_' in the string. Since namespaces are in use it
needs to check on \

Change-Id: I1e664995733fa1438a4df62f0e41758b22045692
Fixes: #40242
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14124
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

[BUGFIX] Fixed missing class mapping without TS

If no Root template is found the class mapping
of extbase is not loaded, so e.g. the
persistenceManager is not found any more.

Change-Id: I51359e9e3bb6e11c32425bb5740047d5f0403750
Releases: 6.0
Fixes: #40236
Reviewed-on: http://review.typo3.org/14118
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Fix classes without or broken namespace

The update script unfortunetly didn't successfully
rename all classes in Extbase, so I renamed the
remaining ones manually.

Change-Id: Ia084593b8e9bf13ba487ab3b430eddf9b254d85e
Fixes: #40224
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14112
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[CLEANUP] General code cleanup

* Cleaned up wrong PHPDoc
* Removed unused variables
* Added missing fields
* Fixed type incompatibility

Change-Id: I3ecc49ceb25458dda285cc4e005c5c2d44112100
Fixes: #40224
Releases: 6.0
Reviewed-on: http://review.typo3.org/14106
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Subrequests can't be resolved

This patch fixes the resolution of the controller object name when using
widget controller.

Change-Id: I003e7d6c7893b3519252f69b097375b741c5cf73
Fixes: #40157
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14059
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Make Cli\Command Namespace aware

Change-Id: I2e9247cac7c2df58637ea43447ac195628292b80
Fixes: #40219
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14101
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Unit tests after namespace switch

Change-Id: Ibb5b34bcefe68e7399ced84e756c24bfaf261248
Resolves: #40211
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14092
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Naming clash: Fix several unit test failures

The move of classes in Persistence area of extbase to subfolder 'generic'
confused the refactor script a bit. The patch fixes several fatals that
especially occur in the unit test.

Change-Id: I06ae18030e8659ce1251ef87e3d634a65ddbcec4
Resolves: #40150
Related: #40095
Related: #35876
Releases: 6.0
Reviewed-on: http://review.typo3.org/14067
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Interface Tx_Scheduler_AdditionalFieldProvider' not found

Fixes wrong class names in Extbase scheduler.

Change-Id: I5117f8caebfda9249499ac57c88019846c80886e
Related: #40095
Fixes: #40156
Release: 6.0
Reviewed-on: http://review.typo3.org/14058
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Reanimate unit tests

Make phpunit backend module for extbase tests load again

Change-Id: Ib3e05e343d2f34185c52727f16ede1331332b7ca
Resolves: #40135
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14046
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[TASK] Make extbase tests run again

Change-Id: Ib6475e5aed3633672c30a855edbf6c71b938510c
Resolves: #40119
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14034
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[TASK] Namespace classes

Change-Id: I403aee9d244a65e51547b21dac3b1228ffd3478e

[TASK][WIP] Move non class code back to source files

Change-Id: I916ad5a3a24864a52e945aeb66e6f997b8e6fabd

[TASK][WIP] Move classes to new locations

Change-Id: Iaae73adcbba323ed5ca903e38f0b2f2e06f497e7

[BUGFIX] Failing test translateForEmptyStringKeyReturnsNull()

Since the rootline refactoring a test case fails. Solution is to only
call the rootline in backend mode if page id is not 0. This additionally
saves some cycles in backend context.

Change-Id: I224ae2655b06dfb1f239b06d6ac2cbb89206a7a8
Resolves: #39997
Related: #39352
Releases: 6.0
Reviewed-on: http://review.typo3.org/13966
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[FEATURE] Integrate basic file abstraction layer models

Warning: This feature is marked as experimental! It is a quick shot to
get a basic connection between extbase and FAL. We added the code to
see if it works out, but it is also possible that we decide to throw it
away completly and substitute it with something different later on. Be
aware of this if you use the models and type converters in your code!

Since the file abstraction layer (FAL) has been introduced during the
development of TYPO3 6.0, it is also required to have an automized and
fluent way to access those abstract files via Extbase. Since the FAL
models cannot completely and directly be used as Extbase Domain object,
simple wrapping objects are defined to access the concrete objects.

The patch adds the basic models for this. Furthermore additional type
converter classes are added for those models.

The patch contains an additional base test case that is able to create
a test database and feed it with fixture data, it is also marked as
experimental.

Change-Id: I537d32377ddd891627af2c163af252c48554d003
Resolves: #39926
Releases: 6.0
Reviewed-on: http://review.typo3.org/13885
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Property mapper: Exception not thrown but skipped

The transformToObject function in the property mapper
checks for an existing record if an identity is given.
If no record could be found an exception should be thrown.
But the exception will never be thrown due to a wrong
condition. The condition checks for FALSE but NULL is
given.

The Exception does also not exist.

Change-Id: If6ac4d3275718cabab9c94904dad264472630c18
Fixes: #39876
Releases: 1.3, 1.4, 4.7, 6.0
Reviewed-on: http://review.typo3.org/13842
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[TASK] Unit test for FrontendUserGroup model

To improve the test coverage we should have unit tests for the
frontend user group model in extbase.

Change-Id: I8e1005e9178161f2ba41b2277a7d993b8448eba9
Resolves: #39848
Release: 6.0
Reviewed-on: http://review.typo3.org/13809
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[TASK] Unit test for FrontendUser model

To improve the test coverage we should have unit tests for the
frontend user model in extbase.

Change-Id: I975db656f7e7a3dcc2704923f4878acb0505fa49
Resolves: #39849
Release: 6.0
Reviewed-on: http://review.typo3.org/13846
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[BUGFIX] ObjectManager dependencies in SignalSlot registration

The SignalSlotDispatcher has a connect() and dispatch() method.
The connect() method usually might be used in ext_localconf.php
to register accordant slots - however, the SignalSlotDispatcher
relies on a fully initialized ObjectManager that also relies on
a fully initialized Caching Framework.

Since the Caches are not ready yet in ext_localconf.php the
whole thing will fail.

This patch removes the dependency of the ObjectManager
injecting itself to the SignalSlotDispatcher by explicitely
calling the initializeObject() method at a later point.

The SignalSlotDispatcher can then be used like this:

t3lib_div::makeInstance('Tx_Extbase_SignalSlot_Dispatcher')
->connect('Tx_MyClass', 'MySignal', 'Slot', 'slotMethod');

Change-Id: Ib0122a341865c334448f23a46bc8841c4817fdf7
Fixes: #39174
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/12989
Reviewed-by: Daniel Lorenz
Reviewed-by: Jacob Rasmussen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Possible failure in dependency injection

Extbase reflection cache calls not existing methods. This can
happen for example if a class is refactored and an injectMethod
has been dropped.

Change-Id: I30071b53f300ef340d6c882ed40f0f67fb86c440
Fixes: #39892
Related: #39174
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/13864
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Web Request should map $_FILES into arguments

Adds content of $_FILES to the request parameters.
Use FLOW3 untangleFilesArray method to set the array, as suggested
by Bastian Waidelich.

Note that file properties must be arrays not strings.

Thanks to Kevin Ulrich Moschallski for the patch.
Thanks to Tymoteusz Motylewski for the unittest.

Change-Id: Ib851c6412afc0291520e61613ad439e34e0603bd
Fixes: #34528
Releases: 6.0
Reviewed-on: http://review.typo3.org/9379
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

[FEATURE] Backend usergroup model and repository

This patch delivers an backend usergroup model and repository.

Change-Id: Ie0da23ee0160a928f74726ceec5b243348a331ef
Resolves: #39332
Releases: 6.0
Reviewed-on: http://review.typo3.org/13626
Reviewed-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[FEATURE] File mount model and repository

Actually we have a backend user model in extbase and a backend usergroup
is in progress. For these models we need a seperate file mount model.

This patch includes the model and the repository with the typoscript
mapping on the datebase table.

Change-Id: Id0b4a1ad168ba189940282222bf4e08b6441a3bf
Resolves: #39323
Releases: 6.0
Reviewed-on: http://review.typo3.org/13429
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[FEATURE] Handle enable fields and deleted records settings granulary

At the moment it's only possible to select either only visible
(non-hidden, matching start-/stop-time) or all (even deleted)
records.

To ensure a consistent handling in sync with TYPO3 Core behavior, it's
necessary to select disabled but not deleted records in the
backend.

This also effects findByUid() via the Typo3QuerySettings and
allows to write to disabled records in BE context.

* deprecates respectEnableFields in QuerySettingsInterface
* introduces ignoreEnableFields in QuerySettingsInterface
* introduces enableFieldsToBeIgnored in QuerySettingsInterface
* introduces includeDeleted in QuerySettingsInterface
* introduces feature flag ignoreAllEnableFieldsInBe to control default behavior
* select disabled but not deleted records in BE context

Fixes: #29501
Fixes: #8483
Change-Id: I11beb3b83589ad91d72d05116488408fff8d9e75
Releases: 6.0
Reviewed-on: http://review.typo3.org/8773
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[FEATURE] Improved translation handling for statement generation

When selecting items in a language other than default one, the
relations (e.g. for IRRE) can not be resolved correctly. This
fix adds the current language if handling is enabled for the chosen
table. Besides it corrects the ordering of items as it selects all
possible ones. For correct overlay the origin is fetched before.

Change-Id: Ibcfe83314c0f2fff54348d9ffab97cd7546779ca
Resolves: #32072
Resolves: #32216
Releases: 6.0
Reviewed-on: http://review.typo3.org/10188
Reviewed-by: Jochen Rau
Tested-by: Jochen Rau
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] email validator

The actuall email validator uses a regex to validate email addresses.
The TYPO3 core offers a method in t3lib_div to validate email addresses.
This patch replace the regex with t3lib_div::validEmail()

Change-Id: I8157a61b8f056d0a60510ec3a7ba9dcb182cb0e5
Releases: 6.0, 4.7
Resolves: #6970
FLOW3 issue: #39714
Reviewed-on: http://review.typo3.org/13550
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] DataMapper returns array on RELATION_HAS_ONE

When your dealing with entities, that not necessarily have
their hasOne nested entities set then the DataMapper returns
an empty array instead of null. In my opinion, an empty
array makes no sense here, because there is no hasMany
relation here.

* Removed the unused $columnMap from DataMapper::fetchRelated
* Added $columnMap in DataMapper::fetchRelatedEager
* Check if the property has a RELATION_HAS_ONE and return null
instead of an empty array then

Change-Id: I0c766d9579cbb464bbae292b194f8df7e8c4a9e9
Fixes: #25708
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/1404
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Günther
Tested-by: Markus Günther

[Task] Make Exception for Controllerdetermination more expressive

This makes exception 1316104317 more expressive and includes the
extension- and pluginname in the exception message.

Change-Id: Ia4787748487e32cd112327616992914bbf8bc736
Fixes: #33903
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/12945
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Oliver Klee
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

[TASK] Add Domain Model and Repository to Category

For extension developer's sake, it is convenient to provide a domain
model along with a repository. Both are relying on Extbase.

Change-Id: I7260a57dcc742f217f0ddfe19470673bc91532c9
Resolves: #38719
Releases: 6.0
Reviewed-on: http://review.typo3.org/12793
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Sebastian Michaelsen
Reviewed-by: Jochen Rau
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf

[BUG] Fix lastlogin property to correct lowerCamelCase

In the new backend user model the property lastlogin was not consistently
in the spelling. Sometimes is it used as lastloginDateAndTime and in the methods
it is used in correct lowerCamelCase lastLoginDateAndTime.

This patch defines the property as lastLoginDateAndTime.

Change-Id: I00e5fd98bcd82e333a6fc9a91f3fe497f2a09d12
Fixes: #39460
Releases: 6.0
Reviewed-on: http://review.typo3.org/13422
Reviewed-by: Georg Ringer
Reviewed-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf

[FEATURE] Add a BackendUser model

Some extensions in the TYPO3 backend use backend users. The belog and
the beuser module are based on extbase and it will be useful if not
every extension has to implement an own backendUser model.

This patch adds a backend user model to extbase.

Change-Id: I84e8ea528c5f91151369f59db6a00acb0174544b
Resolves: #39145
Releases: 6.0
Reviewed-on: http://review.typo3.org/12981
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[TASK] Small bugfix in Tx_Extbase_MVC_View_ViewInterface

Changed expected type of assign-param 'value' from
object to mixed

Change-Id: Ica8e8bd6f7971220da4a3a0fe0c8ca262560374c
Fixes: #39385
Releases: 1.3,1.4,4.7,6.0
Reviewed-on: http://review.typo3.org/13347
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

[BUGFIX] Remove additional slashes from typolink urls if prefixing

Typolink generates absolute uris with a leading slash. When prefixing
this with the base uri, we have to make sure, there is just one
slash in result. To prevent these situations we also trigger the
UriBuilder itself to generate an absolute path.

Thanks to Chetan Thapliyal.

Change-Id: Iae8755514fbdfc4eb27a5a6eab620e55144d912e
Fixes: #33788
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/8860
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Daniel Lorenz
Tested-by: Daniel Lorenz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] public function configureModule should be static

In the class Tx_Extbase_Utility_Extension is the public method configureModule
and it seems that the author of the method forget the static keyword.
The method is used as a static method everywhere but it is not declared
as static.

This patch only set the method to static.

Change-Id: I4ba19f3b0ff763dffd4109a65933623b79e85b45
Fixes: #37922
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/12938
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[FEATURE][Performance] Add caches for persistence layer

XDEBUG Profiler shows time saving possibilities in
Tx_Extbase_Persistence_Storage_Typo3DbBackend->addEnableFieldsStatement
(use of db->admin_get_fields) and
Tx_Extbase_Persistence_Mapper_DataMapFactory->buildDataMap

Caches should be added here. Also to be able to inject the cacheManager
the Container needs a small fix

Change-Id: I5c2defcfaa58c6454226d1abf938b6b6796b5232
Resolves: #36074
Releases: 6.0
Reviewed-on: http://review.typo3.org/10498
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

[TASK] use the objectManager to create empty domain objects

The Tx_Extbase_Persistence_Mapper_DataMapper uses the objectContainer
(Tx_Extbase_Object_Container_Container) for creating an empty object
without calling the construct.

The problem is that except the objectManager no one should use the
objectContainer. So this patch adds a wrapper class to the object
manager communicates with the objectContainer.

Change-Id: I2a2f9d68c0ac0c14a47723ea901c974b7ccc6c5e
Resolves: #13816
Release: 6.0
Reviewed-on: http://review.typo3.org/12973
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

[BUGFIX] Container calls Cache too often

The Container Classes Cache call is very expensive - and when
using a database backend, this is even slowing down
compared to a NullBackend.

One reason is that for every cache request the cache is
called 3 times: 1 time has and 2 times get.
This can be avoided and be reduced to one get call -
which reduces request time by 10-20% for a bigger Extbase request.

Change-Id: I43a0ebf7e0bfd067f3e48c0e7c27f12660b4cb7c
Resolves: #36008
Releases: 1.3, 1.4, 4.7, 6.0
Reviewed-on: http://review.typo3.org/10438
Reviewed-by: Daniel Lorenz
Tested-by: Daniel Lorenz
Reviewed-by: Schmidt Timo
Tested-by: Schmidt Timo
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[TASK] Update Readme to point to the current documentation location

The Extbase README file now contains links to the current documentation
and api documentation

Change-Id: I9f2d32f2d060cebc5a7865170f62d269ab8517e6
Fixes: #36020
Releases: 6.0, 4.7, 1.4
Reviewed-on: http://review.typo3.org/12943
Reviewed-by: Oliver Klee
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[BUGFIX] Only set request for Web_Response

The current request is needed in Tx_Extbase_MVC_Web_Response to
distinguish between a cached or a non-cached request in
addAdditionalHeaderData() as the PageRenderer does not support USER_INTs
currently. This works fine is the ActionController is called with a
Web_Response, but causes an fatal error if a Cli_Response is in charge.

This fix and the $request member in Web_Response should be removed,
once the PageRenderer is fixed for USER_INTs. For now, this patch fixes
a fatal error in the fluid unit tests.

Change-Id: I56fabc3a51ce2c5192ab4488c817b938ed8797ca
Fixes: #36751
Releases: 6.0
Reviewed-on: http://review.typo3.org/12401
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Daniel Lorenz
Tested-by: Daniel Lorenz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

[TASK] Harmonize coding style of if constructs

This corrects the whitespaces in if statements for Extbase.

Change-Id: Ie2266202ca819b78d23d7e28cb6c359cf691eee0
Fixes: #37805
Releases: 6.0
Reviewed-on: http://review.typo3.org/12957
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

[BUGFIX] CLI argument handling chokes on = use

This is a backport of the fix done in FLOW3.
The corresponding FLOW3 ticket is #30493

With this fix the last argument may use the equals sign (=)
again to separate between argument name and value.

Besides writing an additional test case which reproduces the issue,
the other test cases have been strengthened by replacing assertEquals()
by assertSame().

Change-Id: I7d7fa4e5f18a73308cc564db152fd31ab3c4e478
Fixes: #36745, #35207
Relates: #30493
Releases: 6.0, 4.7, 1.4
Reviewed-on: http://review.typo3.org/10919
Tested-by: Christian Kuhn
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Merge "[BUGFIX] Priority of CLI request handler should be lower"

[BUGFIX] Priority of CLI request handler should be lower

Allow rendering of plugin content during tx_crawler call
if option "Make direct requests" is enabled.

Change-Id: I79f992d94924e1b069486715bfa20808cd84588e
Fixes: #34691
Releases: 6.0,4.7

[BUGFIX] Return NULL instead of empty string in Localization::translate()

Localization::translate() returns an empty string instead of NULL
if no translation string is found but arguments are given

Change-Id: Id21ca9bc59a59d6115dc70decf2294497d871a81
Fixes: #34874
Related: #34877
Releases: 6.0, 4.7, 1.4, 1.3

[BUGFIX] Fix unit test for NumberRangeValidator

While back porting changes (#35255) a unit test broke in
Validation_Validator_BeforeExtbase14_NumberRangeValidatorTest.

Change-Id: I31309474866e5edae747ea420e94e65d1638758f
Resolves: #38426
Releases: 6.0

[BUGFIX] FLUIDTEMPLATE - Serialization of 'Closure' is not allowed

The Fluid TemplateCompiler uses closures to store a cached
variant of the accordant Fluid node. Several calls in Fluid
use serialize() and also will process those closures, which
will end up in a PHP fatal error.

The most obvious part is the object manager which will then
try to serialize all objects - including closures - that are
available in the object container.

The problem can be circumvented by using accordant magic PHP
methods like __sleep() and __wakeup() to ignore those properties.

Change-Id: I70e78a09b2a118cc26f099063743c530f0addc72
Fixes: #32295
Related: #36820
Releases: 6.0, 4.7, 4.6

[BUGFIX] Extbase core bootstrap not found in frontend

The patch for issue #35866 removed all class entries from ext_autoload
and relies on the 'extbase' naming scheme autoloader to find classes.
This has the side effect that classes must be requested in upper camel
case, otherwise they are not found.

The frontend extbase plugins are called by a TypoScript userFunc.
The requested extbase core bootstrap class must therefore be used
with upper camel case as well.

Change-Id: I67f1a0d3025b945ec8788f031b676fa62439a2c3
Resolves: #38527
Related: #35866
Related: #37920
Releases: 6.0

[BUGFIX] Fatal error in reports module

Change-Id: I3f0af2132bfecbe83cecdd0605e7628a2c71bc30
Fixes: #37920
Releases: 6.0

Merge "[Task] Update changelog and version to 6.0.0-dev"

[CLEANUP] Cleaned up Extbase

* Uninitialized vars
* Uninitialized properties
* Undefined classes
* PHPdoc

Change-Id: I7679c8020c56883825cb7dd1bb6d6033ee38148f
Fixes: #34970
Releases: 6.0

Merge "[TASK] Backport changes to Extbase_Error_Message"

Merge "[TASK] Improve performance of Utility/Arrays::integerExplode"

Merge "[BUGFIX] Fix undefined variables in Typo3DBBackend::parseOrderings"

[BUGFIX] Fix undefined variables in Typo3DBBackend::parseOrderings

Tx_Extbase_Persistence_Storage_Typo3DbBackend::parseOrderings
passes the potentially not defined $className and $tableName
to convertPropertyNameToColumnName.

Fixes: #34924

Change-Id: Ifd1841d899efa4d56784ba38d06bfa86bd9adf58
Branches: 6.0, 4.7, 1.4, 1.3

Merge "[TASK] Remove trailing whitespace"

[FEATURE] Allow overwriting of Bootstrap with DI

An interface is needed for the Bootstrap, which will be
used with the objectManager to make the Bootstrap
overwritable.

Resolves: #35960
Change-Id: I5cfd9ba9f00f206db46fad06e4302d808b6e1962

[TASK] Sync persistence folder scheme with FLOW3

In Persistence/ only generic, abstract classes and
interfaces are allowed. Everything specific to an
implementation has to be in Persistence/[Name].

Resolves: #35876

Change-Id: I703fa4ed6df7f56a7ade404af1d11c590041e7ad

[CLEANUP] clean up ext_autoload.php

Change-Id: Ibcb6eded45f75fa372675f79bab121c97a0bb0b0
Resolves: #35866

[Task] Update changelog and version to 6.0.0-dev

Change-Id: I70c4354cbae18905680c108ff085418f06fe4f10

[TASK] Remove trailing whitespace

There must be no empty lines after the closing
PHP tag. Empty lines after closing tags break
output compression in PHP and/or result in AJAX
errors.

Change-Id: I3a9570d1505f16c0c7686127ef8909827de94f09
Resolves: #36078
Releases: 1.4, 4.7, 6.0

[TASK] Remove deprecated methods & properties

Removes deprecated methods which are annonced to
be removed in Extbase 1.5.0

Change-Id: I9268903a5cdb3bbf541b161f9e36b09b8aace268
Resolves: #35872
Releases: 6.0

[TASK] Remove access to constant TYPO3_UseCachingFramework

The caching framework is always enabled and access
to this constant is deprecated.

Change-Id: Ibb46f5ab1908cb26bc91d42d15e1e12a95156174
Resolves: #36039
Related: #36037
Releases: 6.0

Merge "[BUGFIX] Respect all subclasses (single table inheritance)"

[TASK] Backport changes to Extbase_Error_Message

In FLOW3 the Message class contains the property arguments
which is needed to be able later to translate error messages.

Change-Id: I0b83615d514178f1c9c6c2c90915a0f133244884
Resolves: #35255
Releases: 6.0

[TASK] Improve performance of Utility/Arrays::integerExplode

Use the performance improvement from t3lib_div

Change-Id: I4d32a1107289fafbccf063ee9b9aa80a71d8063d
Resolves: #35190
Releases: master
FLOW3 Issue: #35970

[BUGFIX] Respect localized records when auto determining defaultPid

The autodetection of the defaultPid fails when there is more than one
content element of a specified plugin. It also fails when one element is
only localized. This fixes the bug and alters the query to respect the
sys_language_uid of a parameter

Change-Id: Ia0890fc63137db7208a1f042358dd387955344de
Fixes: #34433
Releases: 1.4, 4.7, 6.0

[TASK] Rename deprecation message version from 1.6 to 6.0

Adaption to the new naming scheme

Change-Id: Ia721a7944bf439796ad558ce7e4d5c7e23e51d19
Resolves: #35873
Releases: 1.4, 4.7, 6.0

[BUGFIX] PropertyMapper shouldn't check pid in getObjectByIdentifier()

getObjectByIdentifier checks the pid too which doesn't work
when not using it in own extension (because e.g. handling the
pid on yourself)

Change-Id: I94d5b699baec58931824f70ab1cd09b95f9d2c93
Resolves: #35084
Releases: 6.0

[+TASK] Web/Response uses TYPO3 PageRenderer for headerData

This task makes the Web Response class use t3lib_PageRenderer
for inserting header data.

Thanks to Steffen Kamper for reporting, sorry for delay!

Change-Id: If9ea9c8222d7c93e46a8cf413ffca24fd0502724
Resolves: #4830
Releases: 6.0

[BUGFIX] Respect all subclasses (single table inheritance)

If you ask a repository that have subclasses, that have subsubclasses,
than just the subclasses of the first level get respected and not the
subsubclasses.

Change-Id: I62b0219316a7f1fbc49cba6909d317b0a237bbe8
Fixes: #35855
Releases: 4.8, 4.7, 1.4, 1.3

Merge "[BUGFIX] Fix the unit tests to work with PHPUnit 3.6"

[BUGFIX] Unit test failures concerning the HMAC

Some of the unit tests were backported from FLOW3, but not all
class names have been properly adapted.

Fixes: #35791

Change-Id: Ie8e620b2a8e05946ec2d4deee584516839e5f0f2
Releases: 4.8, 4.7, 1.4, 1.3

[TASK] Add unittest for shorthand for custom validators

Port of unittest from FLOW3.

Resolves: #35514
Releases: 4.7, master
FLOW3 Issue: #33862

Change-Id: I4d0621e8d32d12959f647c183cf389cbe49e738d

[SECURITY] Protect arguments of form __referrer with HMAC

The request arguments of the referring request are
a serialized string written to one of the hidden
fields in a Fluid form. This string has to be protected
by a HMAC to protect Extbase from possible unserialize
attacks.

Note: For now there is no object known within Extbase,
that could be used for an unserialize exploit!

This change also backports some convenience hmac methods
to the hash service from the current master, to have the
bugfix in sync.

Also this backports some of the method renamings from
FLOW3.

Change-Id: Iaba9e7556c7aeeb8a3724c84d96160a511500e98
Security-Bulletin: TYPO3-CORE-SA-2012-001
Fixes: #35310
Releases: 1.4, 4.7, 6.0

[BUGFIX] Fix the unit tests to work with PHPUnit 3.6

PHPUnit 3.6 checks some things more strictly than 3.5.
Some unit tests needs changes to be green again.

Branches: 4.8, 4.7, 1.4, 1.3

Change-Id: I0092984a89898c785f46d9f680ceb371647eac1b
Fixes: #35201

[BUGFIX] Fix the @return of findAll

The @return documentation for Tx_Extbase_Persistence_Repository::findAll
and Tx_Extbase_Persistence_RepositoryInterface::findAll is incorrect:
It only mentions array, but also needs to mention
Tx_Extbase_Persistence_QueryResultInterface.

Fixes: #35002

Change-Id: Ic6c6e79ca3108c6eb84d27a7f77a63e980f94618
Branches: 4.8, 4.7, 1.4, 1.3

[+BUGFIX] Make $query->equals, no case sensitivity, work with UTF8

Change-Id: Ic00c9bafe6c0ca262fc3f9d716e0dae20d07ead5
Fixes: #27413
Releases: 1.3, 4.7, 4.8

[BUGFIX] Add missing "command" variable to Tx_Extbase_MVC_CLI_Request

There are multiple references to a membervariable "command" in
Tx_Extbase_MVC_CLI_Request, but this variable does not exist.

Change-Id: I0a67ba8715a28f1a6d2d1f667cc79249d1a652a2
Fixes: #34961
Releases: 4.7, 4.8

Merge "[BUGFIX] PropertyMapper throws exceptions instead of returning error objects."

[TASK] Sync backport of Utility/Arrays.php with FLOW3

Makes Tx_Extbase_Utility_Arrays class in synch with FLOW3
New methods: setValueByPath, unsetValueByPath, convertObjectToArray
Backport unittests.

Thanks to Tymoteusz Motylewski

Change-Id: Ibae165c05465b7273aa15a0e92949be17794bc29
Resolves: #34953
Releases: 4.8

[BUGFIX] Fix unit tests

In 2a7bea292be820d49efc7553d29bac5631f30b33 the unit tests broke
because the mocked ClassInfoCache does not return the previously
set class info.

Change-Id: I625335b43eb5b3d6500cd42fde6a1d9a40997aff
Resolves: #34962
Releases: 4.7, 4.8

[TASK] Allow getting the configuration without plugin-name

At the moment you need the extension- and plugin-name to retrieve the
configuration from the configurationManager. It is thus not possible
to get the extension settings. There are even unit-tests covering this
scenario.

* Allow to ommit plugin-name
* Adjust unit-tests

Change-Id: I573f2decca899bbbace63c5f3e994b607db6845e
Releases: 4.7, 4.8

[BUGFIX] parseDynamicOperand appends to uninitialized variable

Tx_Extbase_Persistence_Storage_Typo3DbBackend::parseDynamicOperand
appends to uninitialized local variable $constraintSQL.

Change-Id: Ifbe15ad5ede46bdcac401e4ea45e4006f647955c
Releases: 4.7, 4.8
Fixes: #34921

[BUGFIX] Tx_Extbase_Persistence_QueryInterface needs to provide getSource

Tx_Extbase_Persistence_Storage_Typo3DbBackend::parseQuery expects a
Tx_Extbase_Persistence_QueryInterface and then calls getSource on it.
One way to make this clean is to change
Tx_Extbase_Persistence_QueryInterface to provide the getSource method.

Releases: 4.7, 4.8
Fixes: #34916

Change-Id: Ic84a6897c7f46048e4967669712d7afcbc4df069

[CLEANUP] Replace deprecated interface from unittests

Change-Id: I2c726ab7bb482fac038a907bb82b33325f30d25a
Releases: 4.7, 4.8
Resolves: #34915

[BUGFIX] property mapping for models w/o __construct

If a model class has no __construct method, the PropertyMapper/
PersistentObjectConverter throws an Exception if it tried to convert an array
into object. This patch catches the ReflectionException directly in
buildObject() and assumes no constructor arguments, if no constructor exists.

Change-Id: I603bd7a26ba4242eef42f9fff6b29fea4673250c
Fixes: #34929
Releases: 4.7, 4.8